kenfdev ( Ken Fukuyama )

running go test with coverage
# github.com/*******/remo-exporter/exporter
exporter/exporter.go:181: Errorf format %w has unknown verb w
?   	github.com/*******/remo-exporter	[no test files]
ok  	github.com/*******/remo-exporter/config	1.025s	coverage: 89.7% of statements
FAIL	github.com/*******/remo-exporter/exporter [build failed]
?   	github.com/*******/remo-exporter/http	[no test files]
?   	github.com/*******/remo-exporter/log	[no test files]
?   	github.com/*******/remo-exporter/mocks	[no test files]
?   	github.com/*******/remo-exporter/types	[no test files]

Exited with code exit status 2

zoetrope

comment created time in 2 months

push eventkenfdev/remo-exporter

zoetrope

commit sha 416b55f36dad8de624acfc84e544f53796d3a0cd

support for Remo E lite

view details

zoetrope

commit sha 0c6ba7afee5d8cf2111487eb9f6ca6b5b4271f6f

reflect review comments * export values returned from API as it is * stop detecting the device by firmware version

view details

Ken Fukuyama

commit sha 217de0d230cc55258cc70c3daf54c5434cabf1f6

Merge pull request #18 from zoetrope/remo-e-lite Support for Remo E lite

view details

push time in 2 months

PR closed kenfdev/remo-exporter

Fix SEGV when a device lacks some events

Description

device.newest_events.* might be nil when a device lacks a event. For instance, Nature Remo E series always lack the events provided at Nature Remo series.

  {
    "name": "Remo E lite",
    "id": "[deducted]",
    "created_at": "[deducted]",
    "updated_at": "[deducted]",
    "mac_address": "[deducted]",
    "bt_mac_address": "[deducted]",
    "serial_number": "[deducted]",
    "firmware_version": "Remo-E-lite/1.1.2",
    "temperature_offset": 0,
    "humidity_offset": 0,
    "users": [
      {
        "id": "[deducted]",
        "nickname": "[deducted]",
        "superuser": true
      }
    ],
    "newest_events": {}
  }

Motivation and Context

Fix segmentation fault at /metrics when Nature Remo E is present at /1/devices API.

How Has This Been Tested?

Confirmed the SEGV no longer occurs with my local build including this patch.

+12 -4

1 commit in sorah/remo-exporter/tree/smart-meter-segv kenfdev/remo-exporter/tree/master

1 comment

1 changed file

sorah

pr closed time in 2 months

PR merged kenfdev/remo-exporter

Support for Remo E lite

Description

This PR adds a feature to support the Nature Remo E lite. This feature allows remo-exporter to expose cumulative electric energy and measured instantaneous electric energy.

The cumulative electric energy is derived from the following formula. https://developer.nature.global/jp/how-to-calculate-energy-data-from-smart-meter-values

Related Issue

This PR will fix #17

Motivation and Context

I want to visualize electric energy with Remo E lite.

How Has This Been Tested?

I added some test cases in remo_test.go and exporter_test.go.

Screenshots (if appropriate):

remo

+610 -38

2 commit in zoetrope/remo-exporter/tree/remo-e-lite kenfdev/remo-exporter/tree/master

4 comments

8 changed files

zoetrope

pr closed time in 2 months

pull request commentkenfdev/remo-exporter

Support for Remo E lite

Apologies about the delay. This LGTM but since I don't have the device, it would be nice to have someone test this with their device. Are either of you able to test this? @sorah @suzutan ?

If no one can, I'll merge this PR this weekend and let's see what happens from there 👍

Thank you all for the contribution 🚀

zoetrope

comment created time in 3 months