profile
viewpoint

freedomlayer/offset 138

Offset payment engine

freedomlayer/offset_docs 5

Offset Documentation

kamyuentse/arduino-cmake 1

Arduino CMake Build system

kamyuentse/alfred-crate 0

Alfred workflow to search Rust Package Registry

kamyuentse/apr_zh-cn 0

《async-in-rust》简体中文翻译

kamyuentse/awesome-rust 0

A curated list of Rust code and resources.

kamyuentse/cassandra_exporter 0

Apache Cassandra® metrics exporter for Prometheus

kamyuentse/cobalt.rs 0

Static site generator written in Rust

fork kamyuentse/cassandra_exporter

Apache Cassandra® metrics exporter for Prometheus

fork in 4 days

startedAltinity/clickhouse-operator

started time in 10 days

startedtimberio/vector

started time in 11 days

issue commenthelm/charts

[incubator/kafka] External access example not working

ping

pedro93

comment created time in a month

starteddenolib/awesome-deno

started time in a month

startedstjepang/smol

started time in 2 months

Pull request review commentShopify/sarama

Fix auto-commit bug and make a feature of auto-commit

 func (s *consumerGroupSession) consume(topic string, partition int32) { 		s.parent.handleError(err, topic, partition) 	} +	// update offset when auto commit+	go func() {+		for {+			if !s.parent.config.Consumer.Offsets.AutoCommit.Enable {+				continue+			}+			offsetFetched := claim.PartitionConsumer.OffsetFetched()+			s.MarkOffset(topic, partition, offsetFetched, "")+			time.Sleep(time.Second)+		}+	}()+

IIRC, the auto-commit feature already exists.

luoruiyi

comment created time in 2 months

Pull request review commentShopify/sarama

Fix auto-commit bug and make a feature of auto-commit

 func (s *consumerGroupSession) consume(topic string, partition int32) { 		s.parent.handleError(err, topic, partition) 	} +	// update offset when auto commit+	go func() {+		for {+			if !s.parent.config.Consumer.Offsets.AutoCommit.Enable {+				continue+			}+			offsetFetched := claim.PartitionConsumer.OffsetFetched()+			s.MarkOffset(topic, partition, offsetFetched, "")+			time.Sleep(time.Second)+		}+	}()+

What are you doing?! You mark all fetched messages consumed every second? And not respect to the closing event (ctx.Done() or parent.closed), which cause goroutine leak.

luoruiyi

comment created time in 2 months

issue commentgocql/gocql

Tag semver releases

Hi, guys, any update on this?

abhinav

comment created time in 2 months

fork kamyuentse/netlink

netlink libraries for rust

fork in 2 months

startedkobolog/gorb

started time in 2 months

more