profile
viewpoint

gatsbyjs/gatsby 47123

Build blazing fast, modern apps and websites with React

jzabala/sentry-files 10

Zero-dependency Node library to upload source maps to Sentry

jzabala/serverless-image-optimizer 7

Demonstration about how to create an image resizer/optimizer with Lambda and S3

jzabala/gatsby-plugin-fontawesome-css 3

Gatsby plugin that disables Font Awesome auto CSS insertion and instead inserts it at compile time.

jzabala/loan-desktop-app 1

App to handle loans.

jzabala/opencollective-frontend 1

Open Collective Frontend. A React app powered by Next.js.

jzabala/react-sentry-example 1

Sample app used to demonstrate how to add Sentry with source maps to a React app

jzabala/AppMovilRD 0

React Native Demo App

jzabala/cheetahs-map 0

Cohorts Members Map

Pull request review commentresponsively-org/responsively-app

Improve Manage Devices view UX

 import DeviceItem from '../DeviceItem';  import styles from './styles.css'; -export default function DeviceList({-  droppableId,-  devices,-  enableFiltering,-  onFiltering,-  enableCustomDeviceDeletion,-  deleteDevice,-}) {-  const [searchOpen, setSearchOpen] = useState(false);-  const [searchText, setSearchText] = useState('');-  const [filteredDevices, setFilteredList] = useState(devices);+const DeviceListHandler = props => {

Why all these changes related to the filtered devices?

maxwillkelly

comment created time in 20 days

PullRequestReviewEvent
PullRequestReviewEvent

startedcreativetimofficial/tailwind-starter-kit

started time in 25 days

startedChromeDevTools/devtools-frontend

started time in a month

pull request commentresponsively-org/responsively-app

feat(desktop-app): add light theme

@jzabala Just the conflicts otherwise can be merged.

Ready @manojVivek . Conflicts fixed 💪🏽

jzabala

comment created time in a month

push eventresponsively-org/responsively-app

Rui Saraiva

commit sha 8b87c43cc42b5000ae205ebc55742a9e25af2ee0

chore: remove package-lock.json in favor of yarn.lock

view details

Rui Saraiva

commit sha 1d154f5073a2490e8006660cd27ce8b986417152

chore(deps): upgrade husky and lint-staged

view details

Rui Saraiva

commit sha 9b3c4f2b159918788f755aea42799ade943cddc8

chore(deps): migrate from node-sass to sass

view details

Rui Saraiva

commit sha 2e85548bad89c63a62b23c6e11d1e280f89d39e0

Merge branch 'master' into chore/upgrade-packages

view details

Rui Saraiva

commit sha 8a06edb0e7d3cdf74bf1f280218fdd08be563e32

chore(webpack): spawn process with yarn instead of npm

view details

jjavierdguezas

commit sha 6eb129ba8c2fd08166115a2bdf6fff52395bbaf3

Assume HTTP for localhost subdomains resolves #433

view details

Manoj Vivek

commit sha aaed3a91c64a3fb596a79a8006495d3d35cd86f1

Crash page polish

view details

Manoj Vivek

commit sha 20ef387837738a0ca2ab3c032e468ae0109898fc

Crash page polish

view details

Manoj Vivek

commit sha bc4cd4c92e8d662ac4f52330e1bb0bb35cb4de5d

Bugfix 🐛🔨

view details

Manoj Vivek

commit sha 9399a40a1b0c64d19cc4aa188b609d014a1c0bff

Version bump v0.12.0 🎉

view details

Rui Saraiva

commit sha c753cd0fb98ba7c0651a2936c3ea552ecbe1c831

Merge branch 'master' into chore/upgrade-packages

view details

Rui Saraiva

commit sha b21f4aee3221bf979ba73e9eb1ef1c74f98c2e26

Merge branch 'master' into chore/upgrade-packages

view details

Manoj Vivek

commit sha 50b728f493de3fcc6e43c32e826dbf5dfd3f7473

Notifications updated

view details

Manoj Vivek

commit sha e28f8fc418a8e1684961d5f3a375e47de1862845

Update appMessages.json

view details

Manoj Vivek

commit sha 80091be18ec598aa52af04118fe21f06707e0498

Update appMessages.json

view details

Manoj Vivek

commit sha 757c61b78ad3b31484691262b7f9296b98bab15d

Merge pull request #335 from ruisaraiva19/chore/upgrade-packages chore: upgrade desktop app packages

view details

allcontributors[bot]

commit sha e8a561e9c1461d936e8eadefd351be73571817eb

docs: update README.md [skip ci]

view details

allcontributors[bot]

commit sha 91c8fb1cf942d3b02a0f02d120c6b903a41784b3

docs: update .all-contributorsrc [skip ci]

view details

Manoj Vivek

commit sha 36dfaedabf3bd37511f01deac20db5800397b89d

Merge pull request #444 from responsively-org/all-contributors/add-ruisaraiva19 docs: add ruisaraiva19 as a contributor

view details

jjavierdguezas

commit sha 153741cde3d9c3d11da970fe3cf9e1c554a792b4

requested changes

view details

push time in a month

pull request commentresponsively-org/responsively-app

Improve Manage Devices view UX

No problem, would the best approach be to keep the pull requests separate and try to avoid conflicts for later or to merge @esprush's branch into the mine now?

I think it would be better to keep them separate and since this is not a global shortcut not to use electron for it.

https://github.com/responsively-org/responsively-app/pull/443#issuecomment-686856933

maxwillkelly

comment created time in a month

pull request commentresponsively-org/responsively-app

Improve Manage Devices view UX

 search in inactive device list

I don't think we need electron shortcuts for this one. We can just add a keypress event on the div and check for the metaKey (on Mac) or ctrlKey(Window, Linux). If we are

maxwillkelly

comment created time in a month

Pull request review commentresponsively-org/responsively-app

feat(desktop-app): add light theme

 class AddressBar extends React.Component<Props> {  const MAX_SUGGESTIONS = 8; -export default AddressBar;+const styles = theme => {+  const {mode} = theme.palette;+  return {+    ...commonStyles(theme),+    addressBarContainer: {+      display: 'flex',+      position: 'relative',+      alignItems: 'center',+      height: '20px',+      width: '100%',+      padding: '14px 10px',+      borderRadius: '20px',+      backgroundColor: mode({light: theme.palette.grey['300'], dark: 'unset'}),

The grey colors come by default in the mui theme: https://material-ui.com/customization/default-theme.

I think we could standardize a couple if we agree to only use those but if we will use the whole range of grey colors in mui i would prefer to keep the number. It is hard to invent colors' names and projects usually end with: grey, lightGrey, lighterThanLightGrey, .... 😂

jzabala

comment created time in a month

PullRequestReviewEvent

push eventresponsively-org/responsively-app

José Javier Rodríguez Zas

commit sha 9765f8adee7c4e2fe17afbea12ea0fadea14b523

Feature/proxy settings (#428) * Add Proxy support resolves #186 * last minute fix * Use material-ui styling as suggested

view details

push time in a month

PR merged responsively-org/responsively-app

Reviewers
Feature/proxy settings

Resolves #186 Proxy Feature highly inspired by Proxy SwitchyOmega extension profile settings UI proxyv2

+791 -53

0 comment

14 changed files

jjavierdguezas

pr closed time in a month

issue closedresponsively-org/responsively-app

[Feature] Need Proxy Support

Developers need to use proxy to switch to different environments. It will be appreciated to set a proxy in user preference. It will be better to have this feature like the extension "ProxyOmega" in Chrome.

closed time in a month

tsengkasing

push eventresponsively-org/responsively-app

Johnny Zabala

commit sha 5b8493ced9fbf6eaa62be03838435f2749d3b1bf

refactor(desktop-app): conver module styles to mui

view details

push time in a month

pull request commentresponsively-org/responsively-app

feat(desktop-app): add light theme

@manojVivek done. Better scrollbars.

Screen Shot 2020-08-31 at 9 23 46 PM

jzabala

comment created time in a month

push eventresponsively-org/responsively-app

jjavierdguezas

commit sha 9addf7784efcb65e9e52ffe3476e7c0d4192712b

Add electron builder config to remove app data on uninstall resolves #368

view details

jjavierdguezas

commit sha 9d2e76e320e3656e4905aa578acad054a45f866c

Improve contribute section on README resolves #435

view details

jjavierdguezas

commit sha 24d25127fcf37dfeeda6baec2e66ec9d6a619e8d

fix package.json path resolution on development

view details

José Javier Rodríguez Zas

commit sha 24e766f337e5246a8b13fb2f9534678e9b44315c

Merge pull request #438 from jjavierdguezas/fix/get-environment-info fix package.json path resolution on development

view details

jjavierdguezas

commit sha 0bc8d0e6cb2d4e073be69ab0ae643f726d667514

Add windows portable version to electron-builder config handle updates checkin logic resolves #439

view details

Manoj Vivek

commit sha 9268b21c1bed31afe104c81d433531dc70b475ad

Merge pull request #436 from jjavierdguezas/fix/remove-app-data-on-uninstall Add electron builder config to remove app data on uninstall

view details

Manoj Vivek

commit sha 4a434a0adf3d225e4f73494c876ca37d4bcfcd2f

Merge pull request #437 from jjavierdguezas/feature/improve-contributor-section-on-readme Improve contribute section on README

view details

Manoj Vivek

commit sha ec18834f232de1776674a97fea20d36ff19fd981

Merge pull request #440 from jjavierdguezas/feature/windows-portable-version Add windows portable version to electron-builder config

view details

gorogoroumaru

commit sha 46323ab36cb71b167345383716778fc0856d58cf

Improve the App's crash page (#411) * Improve the App's crash page * added button to open github issue * delete unnecessaly file * applied requested changes * remove imports * applied requested chages * fix getPackageJson * improve styles * fix spelling mistake * keep titles and copy buttons centered * Remove unnecessary package Co-authored-by: José Javier Rodríguez Zas <josejavier.rodriguez@viseo.com>

view details

allcontributors[bot]

commit sha 4239166e84d41808749bc580342ec62c5a57476a

docs: update README.md [skip ci]

view details

allcontributors[bot]

commit sha a9d9f444f805215c65e70bc542782d5ccb049bb8

docs: update .all-contributorsrc [skip ci]

view details

Johnny Zabala

commit sha 271f810698ad68c198b617c510c4ddeacc776cb4

Merge pull request #442 from responsively-org/all-contributors/add-gorogoroumaru docs: add gorogoroumaru as a contributor

view details

Johnny Zabala

commit sha e93632c32882b9271cddcdcb0d90282536981daf

feat(desktop-app): add light theme

view details

push time in a month

pull request commentresponsively-org/responsively-app

Improve the App's crash page

@gorogoroumaru

  • Can you let us know your Twitter handle? We would love to give a shout out for your work from our twitter account.

  • Please join our community on Slack, for any discussions.

Looking forward to more collaboration in the future! 💪🏻

gorogoroumaru

comment created time in a month

push eventresponsively-org/responsively-app

allcontributors[bot]

commit sha 4239166e84d41808749bc580342ec62c5a57476a

docs: update README.md [skip ci]

view details

allcontributors[bot]

commit sha a9d9f444f805215c65e70bc542782d5ccb049bb8

docs: update .all-contributorsrc [skip ci]

view details

Johnny Zabala

commit sha 271f810698ad68c198b617c510c4ddeacc776cb4

Merge pull request #442 from responsively-org/all-contributors/add-gorogoroumaru docs: add gorogoroumaru as a contributor

view details

push time in a month

delete branch responsively-org/responsively-app

delete branch : all-contributors/add-gorogoroumaru

delete time in a month

PR merged responsively-org/responsively-app

docs: add gorogoroumaru as a contributor

Adds @gorogoroumaru as a contributor for code.

This was requested by jzabala in this comment

+10 -0

0 comment

2 changed files

allcontributors[bot]

pr closed time in a month

pull request commentresponsively-org/responsively-app

Improve the App's crash page

@all-contributors Please add @gorogoroumaru for code.

gorogoroumaru

comment created time in a month

push eventresponsively-org/responsively-app

gorogoroumaru

commit sha 46323ab36cb71b167345383716778fc0856d58cf

Improve the App's crash page (#411) * Improve the App's crash page * added button to open github issue * delete unnecessaly file * applied requested changes * remove imports * applied requested chages * fix getPackageJson * improve styles * fix spelling mistake * keep titles and copy buttons centered * Remove unnecessary package Co-authored-by: José Javier Rodríguez Zas <josejavier.rodriguez@viseo.com>

view details

push time in a month

PR merged responsively-org/responsively-app

Reviewers
Improve the App's crash page

Fix #407

We can't copy stack trace or error info in the app's crash page. So, I added the functionality.

+192 -30

9 comments

6 changed files

gorogoroumaru

pr closed time in a month

issue closedresponsively-org/responsively-app

Improve the App's crash page to have instructions on how to report the issue.

Right now the crash page just shows the error stacktrace as a string in a single line: 90673436-21b36780-e22e-11ea-964d-2eceb7b88c2c

The improved version can have the following:

  1. Show a clear message that the app has crashed
  2. Add instruction stating a Github issue has to be raised with the stack trace.
  3. Add a copy error button that can copy the error information to the clipboard. And if possible add a link that can take the user to the GitHub create issue page with the content prefilled.

closed time in a month

manojVivek
PullRequestReviewEvent

pull request commentresponsively-org/responsively-app

feat(desktop-app): add light theme

@jzabala This is awesome! 🎉 👏

The scrollbars got missed?

I didn't touch them 😅 .

Maybe a grey would be a better color.

jzabala

comment created time in a month

Pull request review commentresponsively-org/responsively-app

Feature/proxy settings

+.proxyManagerContainer {

Sure. In the js file you can use makeStyles.

import {makeStyles} from '@material-ui/core/styles';
// ...
function Component() {
  const classes = useStyles();
  // ...
  return (
    <div className={classes.bookmarks}>
      // ...
    </div>
  )
}
// ...
const useStyles = makeStyles(theme => ({
  bookmarks: {
    padding: '0 10px',
    display: 'flex',
    marginTop: '4px',
  },
}));

https://material-ui.com/styles/basics/

In case you were dealing with a class component you can use the withStyles HOC.

jjavierdguezas

comment created time in a month

PullRequestReviewEvent

Pull request review commentresponsively-org/responsively-app

Feature/proxy settings

+.proxyManagerContainer {

To center on a styling technology all styles should be applied using material-ui.

jjavierdguezas

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentresponsively-org/responsively-app

Improve the App's crash page

thanks @gorogoroumaru , two things to discuss here:

  • should we increase the width of the textareas? (maybe set it to a % of the viewport)
  • should we use buttons with the blue background as they are in the rest of the app? @manojVivek @jzabala

Yeah, there are a lot of space available. I think bigger boxes will look better.

gorogoroumaru

comment created time in a month

PR opened responsively-org/responsively-app

Reviewers
feat(desktop-app): add light theme

There are a lot of changes on this PR. Sorry about that 😢

Thanks @manojVivek for providing the base color scheme for the light mode 💪🏽

Screen Shot 2020-08-30 at 3 07 16 PM Screen Shot 2020-08-30 at 3 07 29 PM Screen Shot 2020-08-30 at 3 07 51 PM

Closes #238

+1694 -1832

0 comment

86 changed files

pr created time in a month

create barnchresponsively-org/responsively-app

branch : feat/add-light-theme

created branch time in a month

issue commentresponsively-org/responsively-app

Add a CSS editor that can used to quickly apply CSS for each device and then copied later to paste it to the codebase

@manojVivek

Cool, will check it out. I was thinking of https://microsoft.github.io/monaco-editor/. Will compare both and select one.

Wow monaco-editor looks rad 😍

Can you please explain this a bit? How will we copy everything when there is no selection?

Let's say I am typing in the All box and I click the copy styles button. To me that should copy the styles of all boxes ready to paste in my final file:

.btn {
  ...
}

@media only screen and (max-width: 768px) {
  .btn {
    ...
  }
}

Well, if I were in that box and instead Command+C it should copy the whole thing too. Or maybe we could use another shortcut. I just think it would be cool not to have to move my hands from the keyboard to copy everything.

manojVivek

comment created time in a month

startedmicrosoft/monaco-editor

started time in a month

issue commentresponsively-org/responsively-app

Add a CSS editor that can used to quickly apply CSS for each device and then copied later to paste it to the codebase

I was planning to start on this after the screenshot improvements, you can take it up if you are interested. Please let me know.

It sounds like an interesting issue but no worries. Go for it 😁

I saw this React editor that we could use. Check the demo, it even has autocomplete. https://github.com/securingsincity/react-ace

Is it possible to achieve that without making it a full-text field? Something like a content editable div?

Yeah. If we have the separation I suppose a simple Command+C could do the trick only you have something selected. So, on Command+C if the user has a selection only that is selected otherwise everything. What do you think?

Just feel having that separation would make it more intuitive than a single text field with CSS breakpoints.

Makes sense.

manojVivek

comment created time in a month

pull request commentresponsively-org/responsively-app

Keep inactive devices order on device management

@jjavierdguezas Is it an expected behavior that Custom devices in the inactive list always get to the top when I close and open the app?

I think it is, browser.allDevices is filled calling getAllDevices https://github.com/responsively-org/responsively-app/blob/1366d77eda5c3ad31fde93098979bed0bafba59b/desktop-app/app/reducers/browser.js#L335

which put them in that order @manojVivek https://github.com/responsively-org/responsively-app/blob/1366d77eda5c3ad31fde93098979bed0bafba59b/desktop-app/app/constants/devices.js#L101

Thanks for the quick response @jjavierdguezas

Now that I check it better I see that the only list that keeps the order after reset is the list of active devices. I ordered both lists before restating the app and as you can see in the image bellow only the active list keep the changes.

Screen Shot 2020-08-26 at 3 45 53 PM

Screen Shot 2020-08-26 at 3 47 06 PM

jjavierdguezas

comment created time in a month

pull request commentresponsively-org/responsively-app

Keep inactive devices order on device management

@jjavierdguezas

Is it an expected behavior that Custom devices in the inactive list always get to the top when I close and open the app?

jjavierdguezas

comment created time in a month

PullRequestReviewEvent

Pull request review commentresponsively-org/responsively-app

Keep inactive devices order on device management

 export default function DeviceManager(props) {       acc[val.id] = val;       return acc;     }, {});-    const inactiveDevices = props.browser.allDevices.filter(-      device => !activeDevicesById[device.id]-    );++    const currentInactiveDevicesById = devices.inactive.reduce((acc, val) => {+      acc[val.id] = val;+      return acc;+    }, {});++    const devicesById = props.browser.allDevices.reduce((acc, val) => {+      acc[val.id] = val;+      return acc;+    }, {});++    const inactiveDevices = [+      ...props.browser.allDevices.filter(

Is it an expected behavior that Custom devices in the inactive list always get to the top when I close and open the app?

jjavierdguezas

comment created time in a month

Pull request review commentresponsively-org/responsively-app

Keep inactive devices order on device management

 import {lightIconsColor, themeColor} from '../../../constants/colors';  const useStyles = makeStyles(theme => ({   fab: {-    position: 'absolute',+    position: 'absolute !important',

Got it!

jjavierdguezas

comment created time in a month

PullRequestReviewEvent

Pull request review commentresponsively-org/responsively-app

Keep inactive devices order on device management

 import {lightIconsColor, themeColor} from '../../../constants/colors';  const useStyles = makeStyles(theme => ({   fab: {-    position: 'absolute',+    position: 'absolute !important',

Oh yeah, you are right. It disappears when the modal is open. That is interesting 🤔

jjavierdguezas

comment created time in a month

PullRequestReviewEvent

Pull request review commentresponsively-org/responsively-app

Keep inactive devices order on device management

 export default function DeviceManager(props) {       acc[val.id] = val;       return acc;     }, {});-    const inactiveDevices = props.browser.allDevices.filter(-      device => !activeDevicesById[device.id]-    );++    const currentInactiveDevicesById = devices.inactive.reduce((acc, val) => {+      acc[val.id] = val;+      return acc;+    }, {});++    const devicesById = props.browser.allDevices.reduce((acc, val) => {+      acc[val.id] = val;+      return acc;+    }, {});++    const inactiveDevices = [+      ...props.browser.allDevices.filter(

Yeah, but it is added to the active devices making the expression false at line 62.

jjavierdguezas

comment created time in a month

PullRequestReviewEvent

Pull request review commentresponsively-org/responsively-app

Keep inactive devices order on device management

 export default function DeviceManager(props) {       acc[val.id] = val;       return acc;     }, {});-    const inactiveDevices = props.browser.allDevices.filter(-      device => !activeDevicesById[device.id]-    );++    const currentInactiveDevicesById = devices.inactive.reduce((acc, val) => {+      acc[val.id] = val;+      return acc;+    }, {});++    const devicesById = props.browser.allDevices.reduce((acc, val) => {+      acc[val.id] = val;+      return acc;+    }, {});++    const inactiveDevices = [+      ...props.browser.allDevices.filter(

During testing I saw this expression only returned something during the first render. If that is the case all the work done to generate this value in subsequent renders is unnecessary. I would recommend to move that work to a useMemo that only runs once.

jjavierdguezas

comment created time in a month

Pull request review commentresponsively-org/responsively-app

Keep inactive devices order on device management

 import {lightIconsColor, themeColor} from '../../../constants/colors';  const useStyles = makeStyles(theme => ({   fab: {-    position: 'absolute',+    position: 'absolute !important',

Since we are using css-in-js styles are scoped. This removes, in theory, style conflicts. Why the !important in all these styles?

jjavierdguezas

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

issue openedresponsively-org/responsively-app

Improve Manage Devices view UX

  1. CommandOrControl+F (depending on the platforms) in this view should open and focus the search input.

Aug-26-2020 08-51-42

  1. Escape with the search input focused should close it and not the whole view.

Aug-26-2020 08-53-07

created time in a month

issue commentresponsively-org/responsively-app

Desktop Vertical- and Horizontal Scrollbar also on Non-Desktop-devices

@jjavierdguezas I can't either but this was probably fixed by https://github.com/responsively-org/responsively-app/pull/364

Version: 0.11.0 Electron: 9.1.1 Chrome: 83.0.4103.122 Node.js: 12.14.1 V8: 8.3.110.13-electron.0 OS: Darwin x64 19.6.0

Screen Shot 2020-08-25 at 3 16 00 PM Screen Shot 2020-08-25 at 3 16 13 PM

123Peter789

comment created time in a month

startedfeathericons/feather

started time in a month

issue commentresponsively-org/responsively-app

Add a CSS editor that can used to quickly apply CSS for each device and then copied later to paste it to the codebase

@manojVivek I see. That definitely looks better than mine 😂

A user using this tool will probably just copy the whole thing and paste it in the css file. What would you think about only using the big All screens and use Add Screen to add the media query at the end? I know the Copy Styles will probably do that but if I were typing I'll just do Command+A, Command+C and back to my editor.

manojVivek

comment created time in a month

issue commentresponsively-org/responsively-app

Add a CSS editor that can used to quickly apply CSS for each device and then copied later to paste it to the codebase

@manojVivek I have been thinking a little about this feature. What would you think about a design like this:

css editor

  • Instead of tab we use checkboxes.

  • Selecting all selects all checkbox + all devices checkboxes

  • Unselecting 1 checkbox, other than all, unselects that checkbox + all checkbox.

  • Unselecting all, unselects all checkbox + all devices checkboxes.

  • The css in the box is applied to all selected devices.

What do you think?

manojVivek

comment created time in a month

push eventresponsively-org/responsively-app

Johnny Zabala

commit sha 6f90c31dd082ba39ddb26c2b351f80ca0442e48c

fix(desktop-app): improve address bar suggestions

view details

Johnny Zabala

commit sha c16f515e8bf75ddd0b9c30df123954efec405ce2

Merge pull request #413 from responsively-org/fix/improve-address-bar-suggestions fix(desktop-app): improve address bar suggestions

view details

push time in a month

delete branch responsively-org/responsively-app

delete branch : fix/improve-address-bar-suggestions

delete time in a month

PR merged responsively-org/responsively-app

Reviewers
fix(desktop-app): improve address bar suggestions

Aside from fixing the bug reported in #410 this PR fixes other errors too:

Bug reported in PR

  • This PR

new app 0

new app 0 1

Can't go all the way around

  • Current app

current app 1

  • This PR

new app 1

App crash

  • Current app

current app 2

  • This PR

new app 2

Can't open suggestion after outside click

  • Current app

current app 3

  • This PR

new app 3

Fixes #410

+141 -85

1 comment

2 changed files

jzabala

pr closed time in a month

issue closedresponsively-org/responsively-app

Address bar suggestions do not work with initially highlighted item

Version: 0.11.0 Electron: 9.1.1 Chrome: 83.0.4103.122 Node.js: 12.14.1 V8: 8.3.110.13-electron.0 OS: Windows_NT x64 10.0.18362

  • How to reproduce: 1- Start typing in the address bar to trigger suggestions 2- Without moving or selecting anything, press ENTER to go to the highlighted website 3- Responsively will go to the incomplete url instead of going to the highlighted website

Do not highlight any item when the suggestions first appear or when you press ENTER, go to the highlighted item or add user input as the first suggestion

address bar

closed time in a month

jjavierdguezas

pull request commentresponsively-org/responsively-app

fix(desktop-app): improve address bar suggestions

Looks great. Nice demo too with the key presses shown on the screen. 👏

Thanks 😁 . This is the Mac app I used to do it https://github.com/keycastr/keycastr. It is Open Source too.

It saved me a lot of time in having to write the description of how to reproduce every case 😅

jzabala

comment created time in a month

issue commentresponsively-org/responsively-app

Remove routing dependencies.

In this case, we will have to manually manipulate the values in the store to reflect the required state right? I guess, passing a specific URL to load(in the below line) and letting the router do the rest would be taken care of by the router.

Doing it via the url or in other way, I think the code that takes those values and manipulate the store needs to exists somewhere. The only thing we'll be changing is from where the values are coming from.

I get that the libs are already in the app and they don't bothered anyone, but if we are not using them they are just making the app a little (very very little) heavier and slower (since it is more code the engine needs to process).

Also there is no risk in removing them. If we find a use case we can just revert the commit and done, libs back 😀

What do you think?

jzabala

comment created time in a month

issue commentresponsively-org/responsively-app

Remove routing dependencies.

Or maybe we can keep it and make better use of it. Like integrating the user-preferences section to the router, so that the app's UI state can be restored via an URL?

Just a thought.

Do you have an idea of a situation where we would use that? Because at all moments we have the user preferences in the store and for opening the app with specific args we could use something similar to the issue #369

jzabala

comment created time in a month

issue openedresponsively-org/responsively-app

Remove routing dependencies.

Looking through the app I see it depends on react-router, react-router-dom and connected-react-router but we only have 1 route (HOME):

https://github.com/responsively-org/responsively-app/blob/6fd99970e9604fa7a89ca6e5abaf760def48d8a5/desktop-app/app/Routes.js#L19

Unless there is a good reason to keep them I think we can remove these routing dependencies from the app.

@manojVivek @jjavierdguezas @esprush

created time in a month

PR opened responsively-org/responsively-app

Reviewers
fix(desktop-app): improve address bar suggestions

Aside from fixing the bug reported in #410 this PR fixes other errors too:

Bug reported in PR

  • This PR

new app 0

new app 0 1

Can't go all the way around

  • Current app

current app 1

  • This PR

new app 1

App crash

  • Current app

current app 2

  • This PR

new app 2

Can't open suggestion after outside click

  • Current app

current app 3

  • This PR

new app 3

Fixes #410

+141 -85

0 comment

2 changed files

pr created time in a month

push eventresponsively-org/responsively-app

Johnny Zabala

commit sha 6f90c31dd082ba39ddb26c2b351f80ca0442e48c

fix(desktop-app): improve address bar suggestions

view details

push time in a month

startedkeycastr/keycastr

started time in a month

Pull request review commentyannickcr/eslint-plugin-react

Fix 2751

 ruleTester.run('display-name', rule, {     errors: [{       message: 'Component definition is missing display name'     }]+  }, {+    code: `+      const x = {+        title: "URL",+        dataIndex: "url",+        key: "url",+        render: url => (

Sure, the main logic to detect components it at lib/util/Components.js.

I have the feeling this bug is in the function getStatelessComponent. You can start there. Hope it helps 🙂

https://github.com/yannickcr/eslint-plugin-react/blob/2588c4da026110a1c4f60bd8cd7bd0196446e8a1/lib/util/Components.js#L685

iiison

comment created time in a month

PullRequestReviewEvent

pull request commentresponsively-org/responsively-app

URI-encode-on-open-html-file

Thanks for the PR @aUsefulMethod 🙂

I have a question about what problem is this PR solving?

From what I see Chromium is already encoding the path.

Aug-20-2020 11-26-47

aUsefulMethod

comment created time in a month

issue commentresponsively-org/responsively-app

Improve the App's crash page to have instructions on how to report the issue.

@gorogoroumaru sure, no worries.

Commenting the if in Root.js

Screen Shot 2020-08-20 at 9 50 34 AM

Throwing error in WebView/index.js

https://github.com/responsively-org/responsively-app/blob/6fd99970e9604fa7a89ca6e5abaf760def48d8a5/desktop-app/app/components/WebView/index.js#L812

I get the error screen:

Screen Shot 2020-08-20 at 9 51 35 AM

manojVivek

comment created time in a month

issue commentresponsively-org/responsively-app

Improve the App's crash page to have instructions on how to report the issue.

@gorogoroumaru the problem is that in development we don't show that page. Go to:

https://github.com/responsively-org/responsively-app/blob/6fd99970e9604fa7a89ca6e5abaf760def48d8a5/desktop-app/app/containers/Root.js#L59

and comment the if statement. Now, you can throw an error (throw new Error('Foo')) from any component.

Let us know if you want to give this issue a try to assign it to you 🙂

manojVivek

comment created time in a month

push eventjzabala/rn-example-todo-app

Johnny Zabala

commit sha 2bd829a68402768aee5c06b49b042b8783c524c8

use isDone instead of section title for item done style

view details

push time in a month

create barnchjzabala/rn-example-todo-app

branch : master

created branch time in a month

created repositoryjzabala/rn-example-todo-app

created time in a month

Pull request review commentyannickcr/eslint-plugin-react

Fix 2751

 ruleTester.run('display-name', rule, {     errors: [{       message: 'Component definition is missing display name'     }]+  }, {+    code: `+      const x = {+        title: "URL",+        dataIndex: "url",+        key: "url",+        render: url => (

I don't think that under any conditions this function should be considered a component. Maybe if the name were uppercase, since that is a pattern I have seen in some libraries, something like:

<MyComponent.Button />

But not this way. What do you think @ljharb ?

iiison

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

startedmarmelab/react-admin

started time in a month

pull request commentresponsively-org/responsively-app

Feature/find text

Converting this to a draft PR, as the feature is causing the app to crash occasionally. This can only be merged after that is figured out.

Could you describe the test conditions or steps, and OS you used to crash the app while using the feature?

I tested it on Mac with different pages and the app never crashed.

esprush

comment created time in a month

issue commentyannickcr/eslint-plugin-react

Is there any way to multiline all JSX props if there are more than X props on element?

I think that there is certainly a possibility of conflict if some folks want single > multi, and others want multi > single.

I think we can implement with this plan, and if folks want to flip the priority, we can add another config option (that defaults to single > multi) that can be set to multi > single.

If we evaluate based on the start and ending line of the component we might avoid any conflicts.

For example, for single line declarations:

<App foo bar  />

there is no need to run the multiline code. It will ask if the number of props is greater than single and if that is the case suggest the corresponding multiline fix.

And for multiline declarations:

<App 
  foo fooz
  bar baz
/>

there is no need to run the single line code. It will ask if the number of props per line is greater than multi and if that is the case suggest the corresponding multi or single fix.

That way we can avoid adding another config option to the rule.

Onatolich

comment created time in a month

Pull request review commentresponsively-org/responsively-app

Feature/find text

 class WebView extends Component {         this._toggleDevTools();       }     });++    // this.webviewRef.current.addEventListener('found-in-page', event => {

Remove unnecessary commented code.

esprush

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

startedframer/motion

started time in a month

issue commentyannickcr/eslint-plugin-react

Is there any way to multiline all JSX props if there are more than X props on element?

In that case @iiison the rule would ask to put the props in one line but not in the initial line. With the config you are describing and the example code the valid version would be:

<App
  foo bar
/> 
Onatolich

comment created time in a month

issue closedresponsively-org/responsively-app

Add support for devtools extension that are not released in the Chrome web store

Often, we have custom devtools extensions for our own projects that for obvious reasons, we won't publish to the web store.

It would be great to add support for custom extensions like that. Just like how Chrome allows us to add custom extensions in developer mode.

closed time in a month

prashantpalikhe

issue commentresponsively-org/responsively-app

Add a section on the website to list the contributors

@lepasq Thank you! Assigned it to you. 🙌

manojVivek

comment created time in a month

pull request commentyannickcr/eslint-plugin-react

[Test]`prop-types`: add test

@ljharb the issue for this PR was closed. Since this only adds a test I don't know if you want to add or close it.

jzabala

comment created time in a month

issue commentyannickcr/eslint-plugin-react

react/prop-types not detecting props when defined as an interface

@jzabala so I don’t know if perhaps v 7.20.6 fixed something but it does seem to be working (for the most part) I do notice something now the rule has issues with nested function definitions but I’ll open a issue if I find this is not by design. Thanks for looking into this.

Sure, let us know if you find anything. Thanks for your support.

jarretmoses

comment created time in a month

issue commentyannickcr/eslint-plugin-react

v7.20.6 has breaking changes for react/display-name

As noted by @ljharb the change is intentional and was introduced to fix an inconsistency that was in the library (you can read the whole discussion here: https://github.com/yannickcr/eslint-plugin-react/pull/2708#discussion_r461792913).

Taking your own example:

Before the change this was a component:

const renderer = a => {
  return listItem => ( // <-- component
	<div>{a} {listItem}</div>
  )
};

But this wan't:

const renderer = a => listItem => ( <-- not a component
	<div>{a} {listItem}</div>
);

If you check carefully, in structure, the code is the same.

As also noted in the previous comment just setting any name to the last function solves the problem or you could disable the rule in that specific case:

// eslint-disable-next-line react/display-name
const renderer = a => listItem => (
	<div>{a} {listItem}</div>
);
k-yle

comment created time in 2 months

issue commentyannickcr/eslint-plugin-react

Is there any way to multiline all JSX props if there are more than X props on element?

is anybody working on this? If not, I can give this a shot...

Go for it 👍🏼

Onatolich

comment created time in 2 months

issue commentyannickcr/eslint-plugin-react

react/prop-types not detecting props when defined as an interface

@jarretmoses I added your example to the test cases and it is working, no error is reported on the prop autoLoad. Did I get your error right?

jarretmoses

comment created time in 2 months

Pull request review commentresponsively-org/responsively-app

[#385] Adds a user preference option to remove fixed positioned elements during full page screenshots

 class WebViewUtils {     await _delay(200);   } -  async hideScrollbarAndFixedPositionedElements(): Promise<string> {+  async hideScrollbarAndFixedPositionedElements(+    removeFixedPositionedElements: boolean+  ): Promise<string> {     const key = await this.webView.insertCSS(`-      .responsivelyApp__ScreenshotInProgress::-webkit-scrollbar {+      .body::-webkit-scrollbar {

Here should be body alone. Without the ..

crperezt

comment created time in 2 months

PR opened yannickcr/eslint-plugin-react

[Test]`prop-types`: add test

It is working. Adding test.

Closes #2747

+67 -0

0 comment

1 changed file

pr created time in 2 months

create barnchjzabala/eslint-plugin-react

branch : test/add-test-for-prop-types-rule

created branch time in 2 months

more