jvirtanen ( Jussi Virtanen )

Pull request review commentreal-logic/aeron

 inline uint64_t aeron_fnv_64a_buf(uint8_t *buf, size_t len)  */ int aeron_tokenise(char *input, const char delimiter, const int max_tokens, char **tokens); +/**+ * Compare two strings for equality up to the specified length. The comparison stops upon first non-equal character,+ * if the null-character is found in one of the strings or the max length reached.+ *+ * @param str1 first string to compare.+ * @param str2 second string to compare.+ * @param length number of characters to compare.+ * @return true if strings are equal up to the specified length.+ */+inline bool aeron_strn_equals(const char *str1, const char *str2, const size_t length)+{+    if (str1 == str2)+    {+        return true;+    }+    else if (NULL == str1 || NULL == str2)+    {+        return false;+    }++    for (size_t i = 0; i < length; i++)+    {+        if (str1[i] != str2[i])+        {+            return false;+        }+        else if (str1[i] == '\0')+        {+           return true;+        }+    }++    return true;+}++/**+ * Compare two null-terminated strings for equality. The comparison stops upon first non-equal character found or+ * upon null-character is found in one of the strings.+ *+ * Note: if strings are not null-terminated or longer than 1024 characters the comparison will stop after 1024+ * iterations. Calling this method is equivalent of calling:+ * <pre>+ *      aeron_strn_equals(str1, str2, 1024);+ * </pre>+ *+ * @param str1 first string.+ * @param str2 second string.+ * @return true if strings are equal (or if first 1024 characters are equal in case of very long strings).+ */+inline bool aeron_str_equals(const char *str1, const char *str2)+{+    static const size_t max_length = 1024;+    assert (strlen(str1) <= max_length);+    assert (strlen(str2) <= max_length);

Wouldn't the assert() call abort(), however, when either string is longer than 1024, unless NDEBUG was defined during the build? As I read it, the "Note:" says that the behavior would be equal to calling aeron_strn_equals with length set to 1024 in that case, however, aeron_strn_equals would not call abort() regardless of the NDEBUG macro.

vyazelenko

comment created time in 8 hours

PullRequestReviewEvent

Pull request review commentreal-logic/aeron

[C] Add common string equals functions.

 inline uint64_t aeron_fnv_64a_buf(uint8_t *buf, size_t len)  */ int aeron_tokenise(char *input, const char delimiter, const int max_tokens, char **tokens); +/**+ * Compare two strings for equality up to the specified length. The comparison stops upon first non-equal character,+ * if the null-character is found in one of the strings or the max length reached.+ *+ * @param str1 first string to compare.+ * @param str2 second string to compare.+ * @param length number of characters to compare.+ * @return true if strings are equal up to the specified length.+ */+inline bool aeron_strn_equals(const char *str1, const char *str2, const size_t length)+{+    if (str1 == str2)+    {+        return true;+    }+    else if (NULL == str1 || NULL == str2)+    {+        return false;+    }++    for (size_t i = 0; i < length; i++)+    {+        if (str1[i] != str2[i])+        {+            return false;+        }+        else if (str1[i] == '\0')+        {+           return true;+        }

Is the @return documentation correct for aeron_strn_equals("foo", "foobar", 6)?

vyazelenko

comment created time in 8 hours

PullRequestReviewEvent

Pull request review commentreal-logic/aeron

[C] Add common string equals functions.

 inline uint64_t aeron_fnv_64a_buf(uint8_t *buf, size_t len)  */ int aeron_tokenise(char *input, const char delimiter, const int max_tokens, char **tokens); +/**+ * Compare two strings for equality up to the specified length. The comparison stops upon first non-equal character,+ * if the null-character is found in one of the strings or the max length reached.+ *+ * @param str1 first string to compare.+ * @param str2 second string to compare.+ * @param length number of characters to compare.+ * @return true if strings are equal up to the specified length.+ */+inline bool aeron_strn_equals(const char *str1, const char *str2, const size_t length)+{+    if (str1 == str2)+    {+        return true;+    }+    else if (NULL == str1 || NULL == str2)+    {+        return false;+    }++    for (size_t i = 0; i < length; i++)+    {+        if (str1[i] != str2[i])+        {+            return false;+        }+        else if (str1[i] == '\0')+        {+           return true;+        }+    }++    return true;+}++/**+ * Compare two null-terminated strings for equality. The comparison stops upon first non-equal character found or+ * upon null-character is found in one of the strings.+ *+ * Note: if strings are not null-terminated or longer than 1024 characters the comparison will stop after 1024+ * iterations. Calling this method is equivalent of calling:+ * <pre>+ *      aeron_strn_equals(str1, str2, 1024);+ * </pre>+ *+ * @param str1 first string.+ * @param str2 second string.+ * @return true if strings are equal (or if first 1024 characters are equal in case of very long strings).+ */+inline bool aeron_str_equals(const char *str1, const char *str2)+{+    static const size_t max_length = 1024;+    assert (strlen(str1) <= max_length);+    assert (strlen(str2) <= max_length);

Is the "Note:" above in synchronization with these assertions?

vyazelenko

comment created time in 8 hours

PullRequestReviewEvent

push eventjvirtanen/nassau

Jan Nielsen

commit sha 522e7b22f3a6d91cf70269c3be9d948e6dc2463d

Polish -- remove unused import.