profile
viewpoint
Jussi Virtanen jvirtanen London, United Kingdom

jvirtanen/coinbase-fix-example 36

Simple example application for Coinbase Pro FIX API

jvirtanen/genesis 33

Replicate Coinbase Pro in local environment

jvirtanen/JVArgumentParser 20

Simple Objective-C library for parsing command line arguments

jvirtanen/nasdaq-tools 16

Applications for working with historical market data from Nasdaq

jvirtanen/fields 10

Fast C library for reading CSV and other tabular text formats

jvirtanen/iex-tools 5

Applications for working with near real-time market data from IEX

jvirtanen/bit 3

Simple command line utility for working with Bitbucket

jvirtanen/dada 3

Generate tabular text data

Pull request review commentreal-logic/aeron

[C] Add common string equals functions.

 inline uint64_t aeron_fnv_64a_buf(uint8_t *buf, size_t len)  */ int aeron_tokenise(char *input, const char delimiter, const int max_tokens, char **tokens); +/**+ * Compare two strings for equality up to the specified length. The comparison stops upon first non-equal character,+ * if the null-character is found in one of the strings or the max length reached.+ *+ * @param str1 first string to compare.+ * @param str2 second string to compare.+ * @param length number of characters to compare.+ * @return true if strings are equal up to the specified length.+ */+inline bool aeron_strn_equals(const char *str1, const char *str2, const size_t length)+{+    if (str1 == str2)+    {+        return true;+    }+    else if (NULL == str1 || NULL == str2)+    {+        return false;+    }++    for (size_t i = 0; i < length; i++)+    {+        if (str1[i] != str2[i])+        {+            return false;+        }+        else if (str1[i] == '\0')+        {+           return true;+        }+    }++    return true;+}++/**+ * Compare two null-terminated strings for equality. The comparison stops upon first non-equal character found or+ * upon null-character is found in one of the strings.+ *+ * Note: if strings are not null-terminated or longer than 1024 characters the comparison will stop after 1024+ * iterations. Calling this method is equivalent of calling:+ * <pre>+ *      aeron_strn_equals(str1, str2, 1024);+ * </pre>+ *+ * @param str1 first string.+ * @param str2 second string.+ * @return true if strings are equal (or if first 1024 characters are equal in case of very long strings).+ */+inline bool aeron_str_equals(const char *str1, const char *str2)+{+    static const size_t max_length = 1024;+    assert (strlen(str1) <= max_length);+    assert (strlen(str2) <= max_length);

Wouldn't the assert() call abort(), however, when either string is longer than 1024, unless NDEBUG was defined during the build? As I read it, the "Note:" says that the behavior would be equal to calling aeron_strn_equals with length set to 1024 in that case, however, aeron_strn_equals would not call abort() regardless of the NDEBUG macro.

vyazelenko

comment created time in 8 hours

PullRequestReviewEvent

Pull request review commentreal-logic/aeron

[C] Add common string equals functions.

 inline uint64_t aeron_fnv_64a_buf(uint8_t *buf, size_t len)  */ int aeron_tokenise(char *input, const char delimiter, const int max_tokens, char **tokens); +/**+ * Compare two strings for equality up to the specified length. The comparison stops upon first non-equal character,+ * if the null-character is found in one of the strings or the max length reached.+ *+ * @param str1 first string to compare.+ * @param str2 second string to compare.+ * @param length number of characters to compare.+ * @return true if strings are equal up to the specified length.+ */+inline bool aeron_strn_equals(const char *str1, const char *str2, const size_t length)+{+    if (str1 == str2)+    {+        return true;+    }+    else if (NULL == str1 || NULL == str2)+    {+        return false;+    }++    for (size_t i = 0; i < length; i++)+    {+        if (str1[i] != str2[i])+        {+            return false;+        }+        else if (str1[i] == '\0')+        {+           return true;+        }

Is the @return documentation correct for aeron_strn_equals("foo", "foobar", 6)?

vyazelenko

comment created time in 8 hours

PullRequestReviewEvent

Pull request review commentreal-logic/aeron

[C] Add common string equals functions.

 inline uint64_t aeron_fnv_64a_buf(uint8_t *buf, size_t len)  */ int aeron_tokenise(char *input, const char delimiter, const int max_tokens, char **tokens); +/**+ * Compare two strings for equality up to the specified length. The comparison stops upon first non-equal character,+ * if the null-character is found in one of the strings or the max length reached.+ *+ * @param str1 first string to compare.+ * @param str2 second string to compare.+ * @param length number of characters to compare.+ * @return true if strings are equal up to the specified length.+ */+inline bool aeron_strn_equals(const char *str1, const char *str2, const size_t length)+{+    if (str1 == str2)+    {+        return true;+    }+    else if (NULL == str1 || NULL == str2)+    {+        return false;+    }++    for (size_t i = 0; i < length; i++)+    {+        if (str1[i] != str2[i])+        {+            return false;+        }+        else if (str1[i] == '\0')+        {+           return true;+        }+    }++    return true;+}++/**+ * Compare two null-terminated strings for equality. The comparison stops upon first non-equal character found or+ * upon null-character is found in one of the strings.+ *+ * Note: if strings are not null-terminated or longer than 1024 characters the comparison will stop after 1024+ * iterations. Calling this method is equivalent of calling:+ * <pre>+ *      aeron_strn_equals(str1, str2, 1024);+ * </pre>+ *+ * @param str1 first string.+ * @param str2 second string.+ * @return true if strings are equal (or if first 1024 characters are equal in case of very long strings).+ */+inline bool aeron_str_equals(const char *str1, const char *str2)+{+    static const size_t max_length = 1024;+    assert (strlen(str1) <= max_length);+    assert (strlen(str2) <= max_length);

Is the "Note:" above in synchronization with these assertions?

vyazelenko

comment created time in 8 hours

PullRequestReviewEvent

push eventjvirtanen/nassau

Jan Nielsen

commit sha 522e7b22f3a6d91cf70269c3be9d948e6dc2463d

Polish -- remove unused import.

view details

Jussi Virtanen

commit sha c2261562ad70e4623c74aeb60c65f7a18646a904

Merge pull request #76 from JanStureNielsen/master Polish -- remove unused import.

view details

dependabot[bot]

commit sha 66c3880e2271e36f580aca594dab57e43c4e4afb

build(deps-dev): bump junit from 4.12 to 4.13.1 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](https://github.com/junit-team/junit4/compare/r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jussi Virtanen

commit sha 33969370e2e416fa992d6a99fde0735f16c71f12

Merge pull request #77 from paritytrading/dependabot/maven/junit-junit-4.13.1 build(deps-dev): bump junit from 4.12 to 4.13.1

view details

push time in 3 days

push eventjvirtanen/dotfiles

Jussi Virtanen

commit sha f2d999bfa60df8a4291ba44eeab3ef4562d0c249

git: Set 'pull.rebase' to 'true'

view details

Jussi Virtanen

commit sha c9c2be672a5b11b2ecc618d0bba0e0fe60b8628b

Remove 'scss-syntax.vim'

view details

push time in 6 days

push eventjvirtanen/philadelphia

dependabot[bot]

commit sha 9ed12fb71c1c0d68fe034fae25e27ce740685638

build(deps-dev): bump junit from 4.13 to 4.13.1 Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md) - [Commits](https://github.com/junit-team/junit4/compare/r4.13...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jussi Virtanen

commit sha 8f381840d079f1a1585b546d27a75096523f8819

Merge pull request #161 from paritytrading/dependabot/maven/junit-junit-4.13.1 build(deps-dev): bump junit from 4.13 to 4.13.1

view details

push time in 10 days

delete branch paritytrading/juncture

delete branch : dependabot/maven/junit-junit-4.13.1

delete time in 10 days

push eventparitytrading/juncture

dependabot[bot]

commit sha b6abd0fefda02587d65847e3239f2cf4a207d60c

Bump junit from 4.12 to 4.13.1 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](https://github.com/junit-team/junit4/compare/r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jussi Virtanen

commit sha 7ad0e4d609391869306d7ff2c5cfe1a1671f397e

Merge pull request #21 from paritytrading/dependabot/maven/junit-junit-4.13.1 Bump junit from 4.12 to 4.13.1

view details

push time in 10 days

PR merged paritytrading/juncture

Reviewers
Bump junit from 4.12 to 4.13.1 dependencies

Bumps junit from 4.12 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> <h2>JUnit 4.13</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md">release notes</a> for details.</p> <h2>JUnit 4.13 RC 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 RC 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.12...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 10 days

delete branch paritytrading/parity

delete branch : dependabot/maven/junit-junit-4.13.1

delete time in 10 days

push eventparitytrading/parity

dependabot[bot]

commit sha f6a8e8a43dd9829f317b9e8d6e0072ccb5bdfcf8

build(deps-dev): bump junit from 4.12 to 4.13.1 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](https://github.com/junit-team/junit4/compare/r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jussi Virtanen

commit sha 7ddf3b2cd95cd167e605eac763d6775b536b6386

Merge pull request #154 from paritytrading/dependabot/maven/junit-junit-4.13.1 build(deps-dev): bump junit from 4.12 to 4.13.1

view details

push time in 10 days

PR merged paritytrading/parity

Reviewers
build(deps-dev): bump junit from 4.12 to 4.13.1 dependencies

Bumps junit from 4.12 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> <h2>JUnit 4.13</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md">release notes</a> for details.</p> <h2>JUnit 4.13 RC 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 RC 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.12...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 10 days

delete branch paritytrading/nassau

delete branch : dependabot/maven/junit-junit-4.13.1

delete time in 10 days

push eventparitytrading/nassau

dependabot[bot]

commit sha 66c3880e2271e36f580aca594dab57e43c4e4afb

build(deps-dev): bump junit from 4.12 to 4.13.1 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](https://github.com/junit-team/junit4/compare/r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jussi Virtanen

commit sha 33969370e2e416fa992d6a99fde0735f16c71f12

Merge pull request #77 from paritytrading/dependabot/maven/junit-junit-4.13.1 build(deps-dev): bump junit from 4.12 to 4.13.1

view details

push time in 10 days

PR merged paritytrading/nassau

Reviewers
build(deps-dev): bump junit from 4.12 to 4.13.1 dependencies

Bumps junit from 4.12 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> <h2>JUnit 4.13</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md">release notes</a> for details.</p> <h2>JUnit 4.13 RC 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 RC 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.12...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 10 days

delete branch paritytrading/philadelphia-extras

delete branch : dependabot/maven/junit-junit-4.13.1

delete time in 10 days

push eventparitytrading/philadelphia-extras

dependabot[bot]

commit sha ee1ac3b2e28c79ed318c453e61b9b37d89d0f5f7

Bump junit from 4.13 to 4.13.1 Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md) - [Commits](https://github.com/junit-team/junit4/compare/r4.13...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jussi Virtanen

commit sha a4b0b2a5f841889cc4fcaee282b7fa6fe435e4ac

Merge pull request #27 from paritytrading/dependabot/maven/junit-junit-4.13.1 Bump junit from 4.13 to 4.13.1

view details

push time in 10 days

PR merged paritytrading/philadelphia-extras

Reviewers
Bump junit from 4.13 to 4.13.1 dependencies

Bumps junit from 4.13 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md">junit's changelog</a>.</em></p> <blockquote> <h2>Summary of changes in version 4.13.1</h2> <h1>Rules</h1> <h3>Security fix: <code>TemporaryFolder</code> now limits access to temporary folders on Java 1.7 or later</h3> <p>A local information disclosure vulnerability in <code>TemporaryFolder</code> has been fixed. See the published <a href="https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp">security advisory</a> for details.</p> <h1>Test Runners</h1> <h3>[Pull request <a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1669">#1669</a>:](<a href="https://github-redirect.dependabot.com/junit-team/junit/pull/1669">junit-team/junit#1669</a>) Make <code>FrameworkField</code> constructor public</h3> <p>Prior to this change, custom runners could make <code>FrameworkMethod</code> instances, but not <code>FrameworkField</code> instances. This small change allows for both now, because <code>FrameworkField</code>'s constructor has been promoted from package-private to public.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.13...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 10 days

delete branch paritytrading/philadelphia

delete branch : dependabot/maven/junit-junit-4.13.1

delete time in 10 days

push eventparitytrading/philadelphia

dependabot[bot]

commit sha 9ed12fb71c1c0d68fe034fae25e27ce740685638

build(deps-dev): bump junit from 4.13 to 4.13.1 Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md) - [Commits](https://github.com/junit-team/junit4/compare/r4.13...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jussi Virtanen

commit sha 8f381840d079f1a1585b546d27a75096523f8819

Merge pull request #161 from paritytrading/dependabot/maven/junit-junit-4.13.1 build(deps-dev): bump junit from 4.13 to 4.13.1

view details

push time in 10 days

PR merged paritytrading/philadelphia

Reviewers
build(deps-dev): bump junit from 4.13 to 4.13.1 dependencies

Bumps junit from 4.13 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md">junit's changelog</a>.</em></p> <blockquote> <h2>Summary of changes in version 4.13.1</h2> <h1>Rules</h1> <h3>Security fix: <code>TemporaryFolder</code> now limits access to temporary folders on Java 1.7 or later</h3> <p>A local information disclosure vulnerability in <code>TemporaryFolder</code> has been fixed. See the published <a href="https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp">security advisory</a> for details.</p> <h1>Test Runners</h1> <h3>[Pull request <a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1669">#1669</a>:](<a href="https://github-redirect.dependabot.com/junit-team/junit/pull/1669">junit-team/junit#1669</a>) Make <code>FrameworkField</code> constructor public</h3> <p>Prior to this change, custom runners could make <code>FrameworkMethod</code> instances, but not <code>FrameworkField</code> instances. This small change allows for both now, because <code>FrameworkField</code>'s constructor has been promoted from package-private to public.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.13...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 10 days

startedksmr/sched

started time in 13 days

startedrigtorp/c2clat

started time in 14 days

startedtmux/tmux

started time in 20 days

push eventjvirtanen/aeron

Michael Barker

commit sha 644339ba76b4489778d8680da62c557457938a89

[Java/Docs] Move tutorial code into tutorial package. (#1055) * [Java/Docs] Move tutorial code into tutorial package. * [Java/Docs] Fix checkstyle errors and align references.

view details

Dmitry Vyazelenko

commit sha ad373b32ddee723393778d0ee6a97ed08f03059a

[Java] Fix duplicate test output names.

view details

Dmitry Vyazelenko

commit sha 4dc4f6abaa5e393ff0ab47787d0caac05ffab2c8

[Java] Run slow tests on Windows.

view details

Dmitry Vyazelenko

commit sha 738c0ca0c0dd596a71111c7e31ee403c28a0aeb1

[Java] Add Java 14 to the mix.

view details

mjpt777

commit sha 188369904b8a92c26c1125a3c62050d0461b7721

[Java] Upgrade to Versions 0.31.0.

view details

mjpt777

commit sha 738acc6931a28e56ab790a88343dd387d7896403

Merge remote-tracking branch 'origin/master' into master

view details

mjpt777

commit sha f6e2394b0bc8a95a8475e871ffdfd24f42ef6d29

[Java] Minor tidy up.

view details

Michael Barker

commit sha 77ae366e123267dd331931f51c634fbb3b579c18

[C] Add get type id to C client. (#1058)

view details

Michael Barker

commit sha c1ea04bcd87eafa30bfa56615d0093a23669a051

[C/C++] C++ wrapper of the C API. (#992) * [C] Allow fetching of buffers from the counters reader. * [C] Move some function prototypes to aeronc.h for counters reader. Add define for max label length (with static assert for correctness). * [C/C++] Start on C++ wrapper of the C API. * [C++] Restore CMake configuration that was commented out. * [C++] No new when throwing in C++. * [C++] Fix compile errors. * [C++] Use registration ids to track add and find for resources in the client wrapper. * [C++] cpp_wrapper tests. * [C++] Improve the way the image and subscription poll handlers are passed through to C code. * [C++] Return various counter ids where appropriate. * [C++] Remove classes from Wrapper that are no longer required, fixing redefinition errors from Windows build. Add explicit to constructor. * [C++] Use the more appropriate cast. * [C++] Get system test working with wrapper. Add private method for attaching to the context callbacks to the underlying c context. * [C++] Friendly test naming. * [C++] Integrate callbacks for closing subscriptions. Add PubSubTest. Disable SystemTest. * [C++] Useful feedback on error failure. * [C++] Remove unused code. * [C++] Test counter addition and value changes. * [C++] Test counter addition and value changes. * [C++] Support agentConductorInvoker. * [C++] Allow resolving images via the Subscription. * [C++] Image tests and fixes for polling methods . * [C++] Implement dynamic add/remove of counter availability and client close callbacks . * [C++] Using polling macros. * [C++] Add registrationId to Counter. * [C++] Test for getting local addresses. * [C++] Reference aeron as a shared library in the shared library build. * [C++] Fix build for linux. * [C++] Fix tests and compile errors. Make sure the registrationId is picked up before freeing the async. * [C++] Change tests name to prevent errors on MacOS. * [C++] add putInt32Volatile for windows. * [C++] Move exception handler. * [C++] Get the initial_term_id from the header values. * [C++] Remove methods that won't be supported by the wrapper. * [C++] Rename. * [C++] Utilise underlying position function to support getting the position value for the header. * [C++] Use C API to get default aeron path. * [C++] Use C API function to get the registration id and remove Aeron.cpp. * [C++] Remove the cpp files for a number of classes. * [C] Use C API aeron_counter_is_closed. * [C++] Move command options parser to header, library is now header only. * [C++] Remove broadcast headers, not required for wrapper. * [C++] Remove unused term scanner code. * [C++] Formatting. * [C++] Call C implementation of request driver shutdown. * [C++] Map C++ wrapper work with AeronArchiveTest. * [C++] Start using async destination function for publications in wrapper. * [C++] Add/remove destinations for publications test. * [C++] Rename test, add exclusive publication and partial subscription test. * [C++] Completed subscription case. Tidy up test. * [C++] Use std C++ sleep. * [C++] Disable test if sanitizer is enabled. * [C++] Fix timeouts for EmbeddedMediaDriver. Set timeout based on environment variable when debugging. * [C++] Enable ArchiveClientTest to work with both C++ API and Wrapper. * [C++] Fix ReplayMerge with wrapper. * [C++] Merge long long fix for CommandOptions. * [C++] Merge add algorithm header for BackOffIdleStrategy.h. * [C++] Merge remove windows header for MemoryMappedFile.h. * [C++] Tidy header includes. * [C++] Merge tidy of atomics. * [C++] Merge tidy of includes. * [C++] Clean up MemoryMappedFile.h. * [C++] Hide noisy gradle output. * [C++] Rember the extern "C". * [C++] Merge maxPositionPosition property fix. * [C++] Formatting and header fixes. * [C++] Merge tidy of AtomicBuffer, Counters. Include get/set registration id. * [C++] Merge tidy use of cross platform separator and spelling. * [C++] Casts and formatting cleanup. * [C++] Counters * [C++] Use the C API defined functions for counters. * [C++] Remove file reference from CMake config * [C++] Remove unnecessary counter definitions. * [C/C++] Remove comment and fix merge issue. * [C++] Remove MemoryMappedFile.h from wrapper. Add test function for checking file exists. * [C++] Remove incorrect header. * [C++] Windows implementation for fileExists for use in the archive tests. * [C++] Map error codes to C++ exceptions. * [C++] Actually include the C++ exception mapping. * [C++] Implement Aeron::isClosed in wrapper and add test. * [C++] Add ownerId to counters for wrapper. * [C++] Make include styles consistent. * [C++] Implement creating a counter from a CountersReader and an id. * [C++] Remove some unneeded definitions from the DataFrameHeader.h. * [C++] Sytyle fixes. * [C++] Split out test that checks liveness timeout. * [C++] standard literals and inlines. * [C++] std prefix. Fix includes. * [C++] Rename AERON_PATH_SEP to AERON_FILE_SEP. * [C++] Formatting. * [C++] Add client type id to CountersReader in the wrapper.

view details

mjpt777

commit sha e1d803a2a11463c21a988cf4e195d8127805f44b

[C++] Carry across formatting changes and casting to the C++ wrapper.

view details

mjpt777

commit sha 944f2282996f2e91398cef47dbd59058017a3b57

[C++] Fix liveness timeout truncation in wrapper tests and close aeron client before media driver shutdown, plus fix some warnings.

view details

mjpt777

commit sha 3caa0ee0b6d4f8d3c09ccf3aae1a3d3064fde5fb

[C++] Formatting.

view details

Michael Barker

commit sha ae83d8c92bb7a38af1466b9401bf3b85a7bb8602

[C/C++] Fix error when linking with hdr histogram. #1049 (#1061)

view details

mjpt777

commit sha 3e9f7eb89ec35394b8fd1cc5ca48eb33051d40da

[C++] Client test tidyup and fix coverage build linker flags.

view details

Dmitry Vyazelenko

commit sha 4a18818823cbf89b4bfa92267594d9dbf9b6b201

Add a single place to register counter type IDs for Java and C. (#1059) * [Java] Add AeronCounters as a registry for all counter type IDs. * [C] Add aeron_counters.h with all the counter type IDs.

view details

Michael Barker

commit sha 72586bf25d17a5436f3f6e231d45d909a2b1824b

[C++] Fix build error on older versions of CMake.

view details

Michael Barker

commit sha 7923f66b63529032530a45128cc5fe35f06ade69

[C++] Revert changes to sample code.

view details

Michael Barker

commit sha 085410694b53ee81a1324e94c08c597c0f55ce9c

[C++] Fix compile error.

view details

Michael Barker

commit sha ed879ea29d6215728f88af41c13e8a509e53d75e

[Doc] Small grammatical fixes for the tutorial.

view details

mjpt777

commit sha e9418828a0d8fe561be42c78a5f5c833a9ef1125

[C] Remove some of the inappropriate use of volatile.

view details

push time in 20 days

PR opened real-logic/aeron

[Java] Clean up array truncation in driver
+5 -6

0 comment

2 changed files

pr created time in 20 days

create barnchjvirtanen/aeron

branch : java-driver-copyof

created branch time in 20 days

delete branch jvirtanen/vim-hcl

delete branch : improvements/comments

delete time in a month

push eventjvirtanen/vim-hcl

Jussi Virtanen

commit sha 89623fc22deb7892cbabcc1c83220756dc1ab9cc

Allow comments around block names

view details

Jussi Virtanen

commit sha 94fbd199c8a947ede62f98509f91d637d7967454

Merge pull request #9 from jvirtanen/improvements/comments Allow comments around block names

view details

push time in a month

delete branch jvirtanen/vim-hcl

delete branch : improvements/conditionals

delete time in a month

push eventjvirtanen/vim-hcl

Jussi Virtanen

commit sha 7468e640626ba9c730196fa6223f89bb39b362c4

Improve support for conditionals Improve handling of attribute names so that conditionals are no longer mistaken for them.

view details

Jussi Virtanen

commit sha 05e32b2d4019291cb8bea0e7678062f2d091bfbc

Merge pull request #8 from jvirtanen/improvements/conditionals Improve support for conditionals

view details

push time in a month

PR merged jvirtanen/vim-hcl

Improve support for conditionals

Improve handling of attribute names so that conditionals are no longer mistaken for them.

+1 -1

0 comment

1 changed file

jvirtanen

pr closed time in a month

PR opened jvirtanen/vim-hcl

Allow comments around block names
+1 -1

0 comment

1 changed file

pr created time in a month

create barnchjvirtanen/vim-hcl

branch : improvements/comments

created branch time in a month

PR opened jvirtanen/vim-hcl

Improve support for conditionals

Improve handling of attribute names so that conditionals are no longer mistaken for them.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchjvirtanen/vim-hcl

branch : improvements/conditionals

created branch time in a month

push eventjvirtanen/aeron

Dmitry Vyazelenko

commit sha 30dfbb7b4d8646ffbf133c03528da0b742cb2f4f

[Java] Eliminate duplicate/conflicting dependencies in Gradle build.

view details

Jussi Virtanen

commit sha fc91f3150edcd2bb23aa187d9b30a7cf8822a21c

[Java] Use ArrayUtil in driver (#1056) * [Java] Use ArrayUtil in AbstractMinMulticastFlowControl. * [Java] Use ArrayUtil in MultiSndDestination.

view details

mjpt777

commit sha ce53097f3187732780d6346f86726da25e66b278

[Java] Reduce allocation when removing last element from arrays.

view details

push time in 2 months

delete branch jvirtanen/aeron

delete branch : java-driver-arrayutil

delete time in 2 months

startedopenjdk/jdk

started time in 2 months

push eventjvirtanen/agrona

Jussi Virtanen

commit sha 57c615513772c1981c48aaa6bf07cb155bf783c0

[Java] Improve Javadoc for ArrayUtil. (#218)

view details

mjpt777

commit sha e4c9791df3fb6a2a2bcccddc478fbef53b02b927

[Java] Javadoc.

view details

push time in 2 months

delete branch jvirtanen/agrona

delete branch : javadoc-arrayutil

delete time in 2 months

push eventjvirtanen/aeron

Jussi Virtanen

commit sha 576778add3555abd08602ea6efe8f6b87f9cc9d7

[Java] Use ArrayUtil in MultiSndDestination.

view details

push time in 2 months

push eventjvirtanen/agrona

Jussi Virtanen

commit sha 370b7627fe4920131ab078c19a0cfc73351c061e

[Java] Improve Javadoc for ArrayUtil.

view details

push time in 2 months

PR opened real-logic/aeron

[Java] Use ArrayUtil in driver
+6 -38

0 comment

2 changed files

pr created time in 2 months

create barnchjvirtanen/aeron

branch : java-driver-arrayutil

created branch time in 2 months

fork jvirtanen/aeron

Efficient reliable UDP unicast, UDP multicast, and IPC message transport

fork in 2 months

PR opened real-logic/agrona

[Java] Improve Javadoc for ArrayUtil
+10 -0

0 comment

1 changed file

pr created time in 2 months

create barnchjvirtanen/agrona

branch : javadoc-arrayutil

created branch time in 2 months

delete branch jvirtanen/agrona

delete branch : arrayutil-javadoc

delete time in 2 months

create barnchjvirtanen/agrona

branch : arrayutil-javadoc

created branch time in 2 months

fork jvirtanen/agrona

High Performance data structures and utility methods for Java

fork in 2 months

GollumEvent

Pull request review commentjvirtanen/vim-hcl

Add support for syntax based folding

 syn region hclComment start=/\/\*/ end=/\*\// contains=hclTodo syn match hclAttributeName /\w\+/ contained syn match hclAttribute     /^.*=/ contains=hclAttributeName,hclComment,hclString -syn match hclBlockName /\w\+/ contained-syn match hclBlock     /^[^=]\+{/ contains=hclBlockName,hclString+syn match hclBlockName /\<[A-Za-z0-9_.\[\]*]\+\>/ nextgroup=hclString,hclBlock+syn region hclBlock start="{" end="}" fold transparent contains=hclBlock,hclVariable,hclString,hclInterpolation,hclComment+syn region hclBlock start="\[" end="\]" fold transparent contains=hclBlock,hclVariable,hclString,hclInterpolation,hclComment

I think this change also breaks the highlighting of hclNumber, which is not included in hclBlock.

droustchev

comment created time in 2 months

Pull request review commentjvirtanen/vim-hcl

Add support for syntax based folding

 syn match hclNumber /\<0[xX]\x\+\>/  syn keyword hclConstant true false null -syn region hclInterpolation start=/\${/ end=/}/ contained contains=hclInterpolation+syn region hclInterpolation start=/\${/ end=/}/ contained contains=hclString,hclInterpolation,hclAttribute,hclAttributeName

Do you have an example that has a string inside an interpolation? I admit I work almost exclusively with Terraform, but I have never seen such a construct in the wild. 🙂

In similar vein, is there a use case, which utilizes an hclAttribute (/^.*=/) inside an interpolation? 🤔

Finally, I think possibly the addition of hclAttributeName here breaks highlighting of variables (i.e. identifiers) inside interpolations, as they now become unadorned (i.e. light gray) instead of being highlighted the same way hclVariable (i.e. yellow). I think this is confusing, because it changes how variables are highlighted inside and outside interpolations.

droustchev

comment created time in 2 months

Pull request review commentjvirtanen/vim-hcl

Add support for syntax based folding

 syn region hclComment start=/\/\*/ end=/\*\// contains=hclTodo syn match hclAttributeName /\w\+/ contained syn match hclAttribute     /^.*=/ contains=hclAttributeName,hclComment,hclString -syn match hclBlockName /\w\+/ contained-syn match hclBlock     /^[^=]\+{/ contains=hclBlockName,hclString+syn match hclBlockName /\<[A-Za-z0-9_.\[\]*]\+\>/ nextgroup=hclString,hclBlock+syn region hclBlock start="{" end="}" fold transparent contains=hclBlock,hclVariable,hclString,hclInterpolation,hclComment+syn region hclBlock start="\[" end="\]" fold transparent contains=hclBlock,hclVariable,hclString,hclInterpolation,hclComment

I think the change in hclBlock breaks the highlighting of hclAttributeName, which used to be unadorned (i.e. light gray) but after this change is highlighted the same way as hclVariable (i.e. yellow). This, I feel, makes the syntax highlighting worse, as a typical attribute name as well as a typical attribute value end up both being highlighted the same way.

droustchev

comment created time in 2 months

Pull request review commentjvirtanen/vim-hcl

Add support for syntax based folding

 hi def link hclInterpolation PreProc hi def link hclComment       Comment hi def link hclTodo          Todo +syn sync fromstart+ let b:current_syntax = 'hcl'+set tabstop=2+set softtabstop=2+set shiftwidth=2+set expandtab+set smarttab

Aren't these more of a personal preference than part of Vim runtime files for a language? 🤔

One could argue that HCL has a canonical form at least in Terraform with terraform fmt, but so does Go with go fmt yet the Vim runtime files for Go, I just checked, do not specify tabstop etc.

droustchev

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

push eventjvirtanen/philadelphia

Jussi Virtanen

commit sha b7f7d4ad6532838638e83cd0197c239d2793d4dc

philadelphia-core: Add 'FIXValue#asString(Appendable)'

view details

Jussi Virtanen

commit sha c91ded160011a0e2965d5fb9ddcc57df8ddcd069

Merge pull request #159 from jvirtanen/improvements/as-string philadelphia-core: Add 'FIXValue#asString(Appendable)'

view details

Jussi Virtanen

commit sha 3d9d6cfd1890948a6bca69697df0c56d904ca4ab

philadelphia-core: Add 'FIXValue#contentEquals'

view details

Jussi Virtanen

commit sha 6e328b1930cd205c34ca36276c5f1168c1f531d5

Merge pull request #160 from jvirtanen/improvements/content-equals philadelphia-core: Add 'FIXValue#contentEquals'

view details

push time in 2 months

delete branch jvirtanen/philadelphia

delete branch : improvements/content-equals

delete time in 2 months

push eventparitytrading/philadelphia

Jussi Virtanen

commit sha 3d9d6cfd1890948a6bca69697df0c56d904ca4ab

philadelphia-core: Add 'FIXValue#contentEquals'

view details

Jussi Virtanen

commit sha 6e328b1930cd205c34ca36276c5f1168c1f531d5

Merge pull request #160 from jvirtanen/improvements/content-equals philadelphia-core: Add 'FIXValue#contentEquals'

view details

push time in 2 months

issue closedparitytrading/philadelphia

Add 'FIXValue#contentEquals' methods

Add the following methods to the FIXValue class:

boolean contentEquals(byte x);

boolean contentEquals(byte[] x);

boolean contentEquals(char x);

boolean contentEquals(CharSequence x);

These methods are inspired by the method by the same name in String and can be helpful especially when working with enumerations that mix char and String members, such as MsgType(35).

closed time in 2 months

jvirtanen

Pull request review commentparitytrading/philadelphia

philadelphia-core: Add 'FIXValue#contentEquals'

 public int length() {         return length;     } +    /**+     * Compare the string representation of this value to the specified+     * character.+     *+     * @param x the character to compare the string representation of this+     *   value against+     * @return true if this value represents the same string as the specified+     *   character, otherwise false+     */+    public boolean contentEquals(byte x) {+        return length == 1 && bytes[offset] == x;

I fixed these, and I also improved the test cases so that they exercise situations in which offset != 0.

jvirtanen

comment created time in 2 months

PullRequestReviewEvent

push eventjvirtanen/philadelphia

Jussi Virtanen

commit sha 3d9d6cfd1890948a6bca69697df0c56d904ca4ab

philadelphia-core: Add 'FIXValue#contentEquals'

view details

push time in 2 months

pull request commentjvirtanen/vim-hcl

Add support for syntax based folding

Hi @droustchev and @mbillow! My apologies, I missed this pull request when it was initially opened. I will take a look at this today.

droustchev

comment created time in 2 months

Pull request review commentparitytrading/philadelphia

philadelphia-core: Add 'FIXValue#contentEquals'

 public int length() {         return length;     } +    /**+     * Compare the string representation of this value to the specified+     * character.+     *+     * @param x the character to compare the string representation of this+     *   value against+     * @return true if this value represents the same string as the specified+     *   character, otherwise false+     */+    public boolean contentEquals(byte x) {+        return length == 1 && bytes[offset] == x;+    }++    /**+     * Compare the string representation of this value to the specified+     * character sequence.+     *+     * @param x the character sequence to compare the string representation of+     *   this value against+     * @return true if this value represents the same string as the specified+     *   character sequence, otherwise false+     */+    public boolean contentEquals(byte[] x) {+        if (length != x.length)+            return false;++        for (int i = 0; i < length; i++) {

Unfortunately that cannot be used, because bytes is always going to be longer by at least one element (the SOH). Therefore the actual arrays are not equal.

jvirtanen

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentparitytrading/philadelphia

philadelphia-core: Add 'FIXValue#contentEquals'

 public int length() {         return length;     } +    /**+     * Compare the string representation of this value to the specified+     * character.+     *+     * @param x the character to compare the string representation of this+     *   value against+     * @return true if this value represents the same string as the specified+     *   character, otherwise false+     */+    public boolean contentEquals(byte x) {+        return length == 1 && bytes[offset] == x;

Good catch! 🔍 They should all use offset.

jvirtanen

comment created time in 2 months

PullRequestReviewEvent

delete branch jvirtanen/philadelphia

delete branch : improvements/as-string

delete time in 2 months

push eventparitytrading/philadelphia

Jussi Virtanen

commit sha b7f7d4ad6532838638e83cd0197c239d2793d4dc

philadelphia-core: Add 'FIXValue#asString(Appendable)'

view details

Jussi Virtanen

commit sha c91ded160011a0e2965d5fb9ddcc57df8ddcd069

Merge pull request #159 from jvirtanen/improvements/as-string philadelphia-core: Add 'FIXValue#asString(Appendable)'

view details

push time in 2 months

issue closedparitytrading/philadelphia

Add 'FIXValue#asString(Appendable)'

Check from Java Language Specification and Java Virtual Machine Specification for Java 8 if it is possibly to widen the parameter type of FIXValue#asString(StringBuilder) from StringBuilder to Appendable without breaking binary compatibility. If it is, do so. Otherwise, add FIXValue#asString(Appendable) beside the existing method.

closed time in 2 months

jvirtanen

Pull request review commentparitytrading/philadelphia

philadelphia-core: Add 'FIXValue#asString(Appendable)'

 public String asString() {         return new String(bytes, offset, length, US_ASCII);     } +    /**+     * Get the value as a string. The value is appended to the provided+     * appendable.+     *+     * @param x an appendable+     * @throws IOException if an I/O error occurs+     */+    public void asString(Appendable x) throws IOException {

Removing that method would introduce a binary incompatible change. Also, it's worth noting that Appendable#append may throw an IOException whereas StringBuilder#append may not.

jvirtanen

comment created time in 2 months

PullRequestReviewEvent

push eventjvirtanen/philadelphia

Jussi Virtanen

commit sha 3f4f2f74ba1aac649f261623d06fd4c5c030ff33

philadelphia-core: Add 'FIXValue#contentEquals'

view details

push time in 2 months

push eventjvirtanen/philadelphia

Jussi Virtanen

commit sha afdc56eace6ddc4407d1b138f3816b3b688824e3

philadelphia-core: Add 'FIXValue#contentEquals'

view details

push time in 2 months

create barnchjvirtanen/philadelphia

branch : improvements/content-equals

created branch time in 2 months

create barnchjvirtanen/philadelphia

branch : improvements/as-string

created branch time in 2 months

push eventjvirtanen/philadelphia

Jussi Virtanen

commit sha f43666be5c8d21e93a20a4c4556b73daea6eedbe

philadelphia-core: Rename chunks to blocks in 'FIXMessage'

view details

push time in 2 months

issue commenttfutils/tfenv

terraform executions delayed by ~ 1 second

Have you thought about refactoring tfenv to operate the same way as more modern version managers, such as chruby and chnode? Instead of having a shim executable (the terraform script in tfenv), tfenv would only update $PATH and a terraform invocation would directly invoke the real Terraform executable.

(Now that I checked, there is actually Terraform version manager, aptly called chtf, that already does this.)

radeksimko

comment created time in 3 months

issue openedparitytrading/philadelphia

Add 'FIXValue#asString(Appendable)'

Check from the Java Language Specification and Java Virtual Machine Specification for Java 8 if it is possibly to widen the parameter type of FIXValue#asString(StringBuilder) from StringBuilder to Appendable without breaking binary compatibility. If it is, do so. Otherwise, add FIXValue#asString(Appendable) beside the existing method.

created time in 3 months

issue openedparitytrading/philadelphia

Add 'FIXValue#contentEquals' methods

Add the following methods to the FIXValue class:

boolean contentEquals(byte x);

boolean contentEquals(byte[] x);

boolean contentEquals(char x);

boolean contentEquals(CharSequence x);

These methods are inspired by the method by the same name in String and can be helpful especially when working with enumerations that mix char and String members, such as MsgType(35).

created time in 3 months

push eventjvirtanen/parity

Jussi Virtanen

commit sha c78a5c412c2624ebf2e4a9b171ced990f67b7924

parity-fix: Clean up value handling

view details

Jussi Virtanen

commit sha 8cb5a9c739cdf42a3d751ef5dd2a47d5f7190890

parity-fix: Clean up CxlRejResponseTo(434) handling

view details

Jussi Virtanen

commit sha ebacbc98adba1433b2561565a81d97e40165c31f

Merge pull request #153 from jvirtanen/cleanups/fix parity-fix: Clean up value handling

view details

push time in 3 months

delete branch jvirtanen/parity

delete branch : cleanups/fix

delete time in 3 months

push eventparitytrading/parity

Jussi Virtanen

commit sha c78a5c412c2624ebf2e4a9b171ced990f67b7924

parity-fix: Clean up value handling

view details

Jussi Virtanen

commit sha 8cb5a9c739cdf42a3d751ef5dd2a47d5f7190890

parity-fix: Clean up CxlRejResponseTo(434) handling

view details

Jussi Virtanen

commit sha ebacbc98adba1433b2561565a81d97e40165c31f

Merge pull request #153 from jvirtanen/cleanups/fix parity-fix: Clean up value handling

view details

push time in 3 months

PR opened paritytrading/parity

parity-fix: Clean up value handling
+14 -10

0 comment

1 changed file

pr created time in 3 months

create barnchjvirtanen/parity

branch : cleanups/fix

created branch time in 3 months

push eventjvirtanen/philadelphia

Jussi Virtanen

commit sha 1571bf60bbba825fd216794a3d09bb0f41092a29

philadelphia-core: Optimize 'FIXTimestamps#setDigits' This decreases the bytecode size of the method from 36 to 28 bytes, which is within HotSpot's default maximum inline size of 35 bytes.

view details

Jussi Virtanen

commit sha e52aebad3973d62098e2c158735481b07f7ca939

Merge pull request #156 from jvirtanen/improvements/timestamps philadelphia-core: Optimize 'FIXTimestamps#setDigits'

view details

push time in 3 months

push eventjvirtanen/parity

Jussi Virtanen

commit sha d50971b096a332bc901d80d1de5bb50d4126ecdd

parity-match: Remove price levels This makes the 'enterAndCancel' performance test case 31% faster.

view details

Jussi Virtanen

commit sha 571f5365203d780d9695a59e790d31d016d8b50c

Merge pull request #152 from jvirtanen/improvements/match parity-match: Remove price levels

view details

push time in 3 months

delete branch jvirtanen/philadelphia

delete branch : improvements/timestamps

delete time in 3 months

more