@sickcodes @xRiot The trick is to create a custom OpenCore image (https://github.com/kholia/OSX-KVM/blob/master/OpenCore-Catalina/OpenCore.qcow2) that boots in the way you want it to boot. Docker-OSX loads this image here: https://github.com/sickcodes/Docker-OSX/blob/master/Dockerfile#L156-L157

    && tee -a Launch.sh <<< '-drive id=OpenCoreBoot,if=none,snapshot=on,format=qcow2,file=/home/arch/OSX-KVM/OpenCore-Catalina/OpenCore.qcow2 \' \
    && tee -a Launch.sh <<< '-device ide-hd,bus=sata.2,drive=OpenCoreBoot \' \

You can tweak OpenCore's config.plist (https://github.com/kholia/OSX-KVM/blob/master/OpenCore-Catalina/config.plist) and re-build it using this script: https://github.com/kholia/OSX-KVM/blob/master/OpenCore-Catalina/opencore-image-ng.sh.

These are some of the settings you might be interested in: https://github.com/kholia/OSX-KVM/blob/master/OpenCore-Catalina/config.plist#L520-L529

			<key>PickerMode</key>
			<string>External</string>
			<key>PollAppleHotKeys</key>
			<true/>
			<key>ShowPicker</key>
			<true/>
			<key>TakeoffDelay</key>
			<integer>0</integer>
			<key>Timeout</key>
			<integer>0</integer>

You can find the docs here: https://github.com/acidanthera/OpenCorePkg/blob/master/Docs/Configuration.pdf

Signed-off-by: Juan Cruz Viotti [email protected]

@balena-ci I self-certify!

@balena-ci I self-certify

The "not" operator takes an array of contracts as an argument (as all the other operators). The requirements are unfulfilled if at least one if the contracts declared in the "not" array exists in the context.

Change-type: minor Fixes: https://github.com/balena-io/contrato/issues/20 Fixes: https://github.com/balena-io/balena-supervisor/issues/1388

Hi @Tobias-Keller ,

Thanks for the heads up. I haven't been involved in the Electron.js community lately, but I'll do some research. In the mean-time, what are those better methods that you are mentioning?

Do you have a rough idea of how things should work on Electron.js 10, and how to add this in a backwards compatible way to this module?

Bumps lodash.merge from 4.6.1 to 4.6.2. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/lodash/lodash/commits">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

The README states that:

(digest-crc) supports optional C extensions which increases performance by ~40x. If the C extensions cannot be compiled for whatever reason, digest-crc will automatically fallback to the pure-Ruby implementation.

However, the gem's native extensions can't be installed (on Catalina at least) without Xcode command line tools and no fallback seems to be provided:

I'm following the xcode-install instructions to install the tool without a working compiler:

Note: unfortunately, XcodeInstall has a transitive dependency on a gem with native extensions and this is not really fixable at this point in time. If you are installing this on a machine without a working compiler, please use these alternative instructions instead

However the installation eventually fails on digest-crc (https://github.com/postmodern/digest-crc), as it also has a native extension:

What puzzles me is that digest-crc states, in their README, that:

Supports optional C extensions which increases performance by ~40x. If the C extensions cannot be compiled for whatever reason, digest-crc will automatically fallback to the pure-Ruby implementation.

Am I doing something wrong?

@CameronDiver I encountered one in support, but the issue seemed transient there in the end.

@CameronDiver Is there a known workaround? Are we planning to release a fix soon? Should we advise users to downgrade?

Bumps lodash from 4.17.11 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.11...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Bumps lodash from 4.17.13 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.13...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Bumps lodash from 4.17.11 to 4.17.13. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/e37182845f16715a0d1c391c8662d83c55609cee"><code>e371828</code></a> Bump to v4.17.13.</li> <li><a href="https://github.com/lodash/lodash/commit/357e899e685872b4af5403ecc4b2a928f961ae63"><code>357e899</code></a> Rebuild lodash and docs.</li> <li><a href="https://github.com/lodash/lodash/commit/fd9a062d57646450b61f74029315abd4cc834b08"><code>fd9a062</code></a> Bump to v4.17.12.</li> <li><a href="https://github.com/lodash/lodash/commit/e77d68121ff00ba86b53eed5893d35adfe94c9dd"><code>e77d681</code></a> Rebuild lodash and docs.</li> <li><a href="https://github.com/lodash/lodash/commit/629d1865793182cd967196716f4beff223aa4a91"><code>629d186</code></a> Update OpenJS references.</li> <li><a href="https://github.com/lodash/lodash/commit/2406eac542b2a1282be8d812a6d8a45433ade80a"><code>2406eac</code></a> Fix minified build.</li> <li><a href="https://github.com/lodash/lodash/commit/17a34bc5854bb982ef333bfe7ae469f4dfcee0ec"><code>17a34bc</code></a> Fix test bootstrap for core build.</li> <li><a href="https://github.com/lodash/lodash/commit/53838a38f8e4f6204ef2f837fecc4e07d09afe77"><code>53838a3</code></a> Fix tests in older browsers.</li> <li><a href="https://github.com/lodash/lodash/commit/29e258497b5ff45494a85cfa58743517aaeeff52"><code>29e2584</code></a> Fix style:test lint nits.</li> <li><a href="https://github.com/lodash/lodash/commit/8f4d3eb018884d96eb57fba3f724bfff494df724"><code>8f4d3eb</code></a> Update deps.</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.11...4.17.13">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Landed in v4.2.0

I've been struggling for months to find the root cause of this issue, but it occurs so rarely I've been unable to pin it down.

I think this happens mostly on Mac, though perhaps my sample size is just too small to accurately tell if environment is a significant factor. This still happens on 4.1.5.

I'm shipping a validate: true opt-in option in .set() as part of v4.2.0 that will make .set() read back the keys after a little while and retry (for a limited number of times) if the contents do not match. Use this with care though, as you might get into some concurrency problems if more than one process writes keys at the same time and try to validate what each other wrote.

See: https://github.com/electron-userland/electron-json-storage/issues/123

@Slapbox I added it behind a validate: true option in .set()

Bumps electron from 2.0.14 to 7.2.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron/electron/releases">electron's releases</a>.</em></p> <blockquote> <h2>electron v7.2.4</h2> <h1>Release Notes for v7.2.4</h1> <h2>Fixes</h2> <ul> <li>Fixed Promise timeout issue when running Electron as Node. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23324">#23324</a></li> <li>Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23182">#23182</a></li> <li>Fixed an issue where windows without <code>nativeWindowOpen: true</code> could invoke the non-native-open path. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23224">#23224</a></li> <li>Fixed memory leak when using contextBridge with sandbox=true. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23232">#23232</a></li> <li>MacOS VoiceOver is now able to find its way back into web contents after it navigated "out" of an application. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23174">#23174</a></li> </ul> <h2>electron v7.2.3</h2> <h1>Release Notes for v7.2.3</h1> <h2>Fixes</h2> <ul> <li>Security: Ensure proxy object is created in the correct context a9bead22</li> </ul> <h2>electron v7.2.2</h2> <h1>Release Notes for v7.2.2</h1> <h2>Fixes</h2> <ul> <li>Fixed a potential crash on invalid <code>zoomFactor</code> values when setting the zoom factor of a webpage. <a href="https://github-redirect.dependabot.com/electron/electron/issues/22710">#22710</a></li> <li>Fixed an issue with <code>maximizable</code> state persistence of BrowserWindows on macOS. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23019">#23019</a></li> <li>Fixed an issue with possible creation of a messageBox which cannot be dismissed on macOS. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23089">#23089</a></li> <li>Fixed an occasional crash when closing all BrowserWindows. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23024">#23024</a></li> <li>Security: Backported fix for CVE-2020-6426: inappropriate implementation in V8. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23043">#23043</a></li> <li>Security: backported a fix for crbug.com/1065094. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23059">#23059</a></li> <li>Security: backported fix for a potential buffer overrun in WebRTC audio encoding. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23037">#23037</a></li> <li>Security: backported fix for site isolation bypass in dedicated workers. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23040">#23040</a></li> <li>Security: backported the fix to CVE-2020-6452: potential container-overflow in MediaStream mojo. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23044">#23044</a></li> </ul> <h2>Other Changes</h2> <ul> <li>Security: Backport fix for buffer underflow in DWrite. <a href="https://github-redirect.dependabot.com/electron/electron/issues/22979">#22979</a></li> <li>Security: Backported fix for use after free in file chooser. <a href="https://github-redirect.dependabot.com/electron/electron/issues/22981">#22981</a></li> <li>Security: backport fix for CVE-2020-6451: Use after free in WebAudio. <a href="https://github-redirect.dependabot.com/electron/electron/issues/22945">#22945</a></li> <li>Security: backport fix for use after free in VideoEncodeAccelerator. <a href="https://github-redirect.dependabot.com/electron/electron/issues/22983">#22983</a></li> <li>Security: backported fix for CVE-2019-20503: Out of bounds read in usersctplib. <a href="https://github-redirect.dependabot.com/electron/electron/issues/22986">#22986</a></li> <li>Security: backported fix for CVE-2020-6422: Use after free in WebGL. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23017">#23017</a></li> <li>Security: backported fix for CVE-2020-6423: Use after free in audio. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23048">#23048</a></li> <li>Security: backported fix for CVE-2020-6427: Use after free in audio. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23015">#23015</a></li> <li>Security: backported fix for CVE-2020-6428: Use after free in audio. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23013">#23013</a></li> <li>Security: backported fix for CVE-2020-6429: Use after free in audio. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23011">#23011</a></li> <li>Security: backported fix for CVE-2020-6449: Use after free in audio. <a href="https://github-redirect.dependabot.com/electron/electron/issues/23009">#23009</a></li> <li>Security: backported fix for use-after-poison in WebAudio (crbug.com/1023810). <a href="https://github-redirect.dependabot.com/electron/electron/issues/22869">#22869</a></li> <li>Security: backported fix for use-after-poison in WebAudio. <a href="https://github-redirect.dependabot.com/electron/electron/issues/22943">#22943</a></li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/electron/electron/commit/0552e0d5de46ffa3b481d741f1db5c779e201565"><code>0552e0d</code></a> Bump v7.2.4</li> <li><a href="https://github.com/electron/electron/commit/c87b474496c35580ebbeab13f9c8c982b4eab4d3"><code>c87b474</code></a> refactor: port window-setup to use ctx bridge instead of being run in the mai...</li> <li><a href="https://github.com/electron/electron/commit/69683def0dbea9a7a1bb382050293183c2ba066e"><code>69683de</code></a> fix: use Node's microtasks policy in node_main.cc (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23154">#23154</a>) (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23324">#23324</a>)</li> <li><a href="https://github.com/electron/electron/commit/8148b76efa0092ec236bcde64249fda93ce6ff1d"><code>8148b76</code></a> style: use build/include_directory for NOLINT (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23266">#23266</a>) (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23304">#23304</a>)</li> <li><a href="https://github.com/electron/electron/commit/7dfcb5ef0495cc34738e52c2ef13ecda5c998017"><code>7dfcb5e</code></a> fix: block custom window.open when nativeWindowOpen is true (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23188">#23188</a>) (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23224">#23224</a>)</li> <li><a href="https://github.com/electron/electron/commit/0b3bf1e5566efe64c31d5b6aa07c0a8eb1c81836"><code>0b3bf1e</code></a> fix: do not mutate ipc instances across contexts (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23239">#23239</a>)</li> <li><a href="https://github.com/electron/electron/commit/fd529ac30a7875c22d6d5b6d7af003843e0fbf18"><code>fd529ac</code></a> fix: do not allow child windows to specify their own preload script (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23229">#23229</a>)</li> <li><a href="https://github.com/electron/electron/commit/3909001a006cff7b36505a0a80ca8926f0e0646f"><code>3909001</code></a> fix: ensure that functions are not retained beyond their context being releas...</li> <li><a href="https://github.com/electron/electron/commit/039be2e407237c4696ec099e00662c235527cfb7"><code>039be2e</code></a> build: improve patch filename remembering (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23070">#23070</a>) (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23184">#23184</a>)</li> <li><a href="https://github.com/electron/electron/commit/fb6f60460ba646cb5ea9985b09db3d7bd92e1376"><code>fb6f604</code></a> fix: heap-use-after-free in tray.popUpContextMenu (<a href="https://github-redirect.dependabot.com/electron/electron/issues/22842">#22842</a>) (<a href="https://github-redirect.dependabot.com/electron/electron/issues/23182">#23182</a>)</li> <li>Additional commits viewable in <a href="https://github.com/electron/electron/compare/v2.0.14...v7.2.4">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

@Slapbox I think the main problem with this is that you could get into update conflicts if two entities are trying to write to the same key. Each of them may re-read what they wrote, just to find that the other entity over-wrote it already (this is coming up in the test failures).

Maybe we can add it, but as an opt-in feature behind an option flag?

I think that will do! Thanks!

firewalld doesn't allow DNS requests (this is the case that bit me, but there might be more) on docker0 unless the interface is added to the trusted zone.

See: https://github.com/docker/for-linux/issues/955 Fixes: https://github.com/sickcodes/Docker-OSX/issues/56 Signed-off-by: Juan Cruz Viotti [email protected]

@sickcodes I think got to the bottom of it. The DNS requests would get blocked by firewalld on my Fedora 32 system. See this snippet from docker0 after trying to ping google from within the container:

Apparently things work again if I set docker0 to the trusted zone:

firewall-cmd --permanent --zone=trusted --add-interface=docker0
firewall-cmd --reload

See https://github.com/docker/for-linux/issues/955

Hey there!

I recently sent a PR to OSX-KVM (https://github.com/kholia/OSX-KVM/pull/135) to add a new OpenCore image in OpenCore-Catalina directory. I plan to use this on a base image that extends sickcodes/docker-osx to boot into the VM in headless mode.

Would you mind re-building and re-pushing sickcodes/docker-osx to Dockerhub (so that https://github.com/sickcodes/Docker-OSX/blob/master/Dockerfile#L115 clones the latest OSX-KVM version) so that we can start using this new OpenCore image?

Thanks a lot!

The updates are there. Thanks a lot!

@sickcodes Any clues about this? I've been trying some long shots, but I feel that I'm mostly in the dark. I'm following the instructions exactly as described in the README, so it must be something in my host system, right?

Thanks for the quick response. Trying it out now...

Hey there!

I recently sent a PR to OSX-KVM (https://github.com/kholia/OSX-KVM/pull/135) to add a new OpenCore image in OpenCore-Catalina directory. I plan to use this on a base image that extends sickcodes/docker-osx to boot into the VM in headless mode.

Would you mind re-building and re-pushing sickcodes/docker-osx to Dockerhub (so that https://github.com/sickcodes/Docker-OSX/blob/master/Dockerfile#L115 clones the latest OSX-KVM version) so that we can start using this new OpenCore image?

Thanks a lot!

The current OpenCore image always displays the disk selection menu, as ShowPicker is true, and doesn't provide a timeout, making it impossible to boot to macOS on a headless environment (i.e. CI).

This commit creates a new OpenCore config.plist that has ShowPicker set to false, and includes the resulting qcow2 image.

Signed-off-by: Juan Cruz Viotti [email protected]

@sickcodes I was able to connect to it by omitting the --net host option in docker run. The port is bound and I can see that in docker ps, however the VM has no internet connection now :/

@sickcodes This is the output of docker ps:

CONTAINER ID        IMAGE               COMMAND                  CREATED             STATUS              PORTS               NAMES
e082f90113ab        catalina            "/bin/sh -c 'ls -la …"   25 hours ago        Up 25 hours                             competent_bassi

And I'm running the image as:

docker run \
  --privileged \
  --net host \
  -p 50922:10022 \
  -e "DISPLAY=${DISPLAY:-:0.0}" \
  -e RAM=6 \
  --cap-add=ALL \
  -v /tmp/.X11-unix:/tmp/.X11-unix \
  -v /dev:/dev -v /lib/modules:/lib/modules \
  -v /var/run/libvirt/libvirt-sock:/var/run/libvirt/libvirt-sock \
  sickcodes/docker-osx

I'm afraid I can't make it work yet. I enabled remote login in macOS, and I can ssh to the VM from within the VM at port 22, but 50922 never gets forwarded to the host.

You also have to turn on system sharing once you've installed the OS Its under "remote login" in OSX settings

I see. It would be nice to mention this in the docs! Thanks!

I'm following the instructions and running the VM by port forwarding the SSH port -p 50922:10022, however I can't get a shell on the VM at localhost as the connection is refused and nmap doesn't show the port being open.

Am I missing something?