profile
viewpoint
Jason Quense jquense International Justice Mission New Jersey

facebook/react 144399

A declarative, efficient, and flexible JavaScript library for building user interfaces.

insin/react-maskedinput 681

Masked <input/> React component

jquense/bill 53

css selector engine for React elements and components

graphql-dotnet/relay 49

A toolset for creating Relay.js compatible GraphQL servers in dotnet.

amatiasq/vsc-sort-imports 35

Sort ES6 imports automatically.

jquense/babel-plugin-jsx-fragment 16

jsx syntatic sugar for React's `createFragment()`

jquense/component-metadata-loader 5

webpack loader to parse React component metadata from source code

jquense/chain-function 3

chain a bunch of functions

created tagjquense/docpocalypse

tag@docpocalypse/gatsby-theme@0.9.10

created time in 15 hours

push eventjquense/docpocalypse

Jason Quense

commit sha ff57cf1122ba7f23c7f36be48f0a24a224953436

Publish - @docpocalypse/gatsby-theme-core@0.7.8 - @docpocalypse/gatsby-theme@0.9.10

view details

push time in 15 hours

push eventjquense/docpocalypse

Jason Quense

commit sha 199136adda95fffbc8e49f39f0dc6ff09a7efc51

actually fix this

view details

push time in 15 hours

push eventjquense/docpocalypse

Jason Quense

commit sha f8542a2d2e071124f3e42d7acc18ae07751d7d18

fix: new import thing

view details

Jason Quense

commit sha 2b20a27214dd77efe56d3c672043a8986ea1fd8a

Publish - @docpocalypse/gatsby-theme-core@0.7.7 - @docpocalypse/gatsby-theme@0.9.9

view details

push time in 15 hours

created tagjquense/docpocalypse

tag@docpocalypse/gatsby-theme@0.9.9

created time in 15 hours

issue openedreactjs/react-docgen

Stack overflow with cast generic

export const toArray = <T>(arr?: any) =>
  ([] as T[]).concat(arr);

Will break. It's due to the as T[], maybe a similar issue as #410 ?

created time in 15 hours

push eventjquense/docpocalypse

Jason Quense

commit sha cc2f2c259d5f8906ccf198de77239e280fe456db

Publish - @docpocalypse/code-live@0.4.1 - @docpocalypse/gatsby-data-utils@1.0.4 - gatsby-plugin-typedoc@0.3.4 - react-docgen-styled-resolver@0.3.0 - @docpocalypse/gatsby-theme-core@0.7.6 - @docpocalypse/gatsby-theme@0.9.8

view details

push time in 15 hours

push eventjquense/docpocalypse

Jason Quense

commit sha 12172113e0d93a8f45b5411d825b65ca9d9ab7ca

feat: hide useless TOC

view details

Jason Quense

commit sha ab77d143bf02e1aad0f9fd54d33d5325990e1414

feat: switch back to react-docgen and support imports in comments

view details

push time in 15 hours

push eventgatsbyjs/gatsby

Jason Quense

commit sha 5637fd470794092bef87f12e381a217be4e13614

add period

view details

push time in 17 hours

PR opened gatsbyjs/gatsby

feat: Allow silencing the warning for adding resolvers for missing types

Description

Useful for theme authors who want to extend plugin types if they exist.

Documentation

I updated the jsdoc comments

I also did not see any tests for createResolvers otherwise I would have written one

+8 -3

0 comment

2 changed files

pr created time in 17 hours

create barnchgatsbyjs/gatsby

branch : allow-resolvers-for-non-existent-types

created branch time in 17 hours

push eventjquense/docpocalypse

Jason Quense

commit sha c64682cd14a56f0ce30ee7136c0717550315b423

Publish - cli@1.0.3 - @docpocalypse/code-live@0.4.0 - @docpocalypse/gatsby-data-utils@1.0.3 - gatsby-plugin-typedoc@0.3.3 - @docpocalypse/props-table@0.3.5 - react-docgen-styled-resolver@0.2.3 - synthetic-grass@0.1.2 - @docpocalypse/gatsby-theme-core@0.7.5 - @docpocalypse/gatsby-theme@0.9.7

view details

push time in 18 hours

push eventjquense/docpocalypse

Jason Quense

commit sha 25e81a0636def1baa060bd62353c2322ee6a63d3

feat: add renderAsComponent and bump deps

view details

Jason Quense

commit sha 9fef99b7fd4c164904613e25bf68ec58bf5ccccc

fix types

view details

Jason Quense

commit sha d1795c37ba2ca24ff0a1a66435d29c0c1b2bf2d6

feat: clean up nav styling more

view details

push time in 18 hours

pull request commentreactjs/react-transition-group

test: remove deprecated findDOMNode from tests

not sure i see why but thanks!

iamandrewluca

comment created time in 20 hours

push eventreactjs/react-transition-group

Andrew Luca

commit sha 7346e5d6cb6432d94342b401fba47a2b7128d045

test: remove deprecated findDOMNode from tests (#591)

view details

push time in 20 hours

push event4Catalyzer/javascript

Jason Quense

commit sha 9d865c45c6977945b29f2d98737c928b506f745f

Publish - @4c/babel-preset@7.3.3 - eslint-config-4catalyzer-flow-react@1.0.7 - eslint-config-4catalyzer-jest@2.0.5 - eslint-config-4catalyzer-react@1.0.5 - eslint-config-4catalyzer-typescript@1.1.7 - @4c/jest-preset@1.5.0 - @4c/semantic-release-alt-publish-dir@5.0.6 - @4c/semantic-release-config@2.0.6

view details

push time in 21 hours

push event4Catalyzer/javascript

Jason Quense

commit sha cdac85443f2ab1c46be0951f8025798c639de6df

feat: use root mode upwards-optional for jest preset (#532)

view details

push time in 21 hours

delete branch 4Catalyzer/javascript

delete branch : rootmode

delete time in 21 hours

PR merged 4Catalyzer/javascript

Reviewers
feat: use root mode upwards-optional for jest preset

I think this is ok as a default. My understanding reading: https://babeljs.io/docs/en/configuration is that local babelrc's are always preferred to a config, but this setting means if there is no local babelrc it will look for a root config. Helpful in monorepo's with centralized config

+33 -4

8 comments

4 changed files

jquense

pr closed time in 21 hours

push event4Catalyzer/javascript

Jimmy Jia

commit sha 141d7082ab94b2d009c9ea3624f73c1e574576a3

fix: Use TS no-unused-expressions rule (#533)

view details

Jimmy Jia

commit sha 15481beabac9f41eb9cebe7d3a69f228ea915f6b

Publish - @4c/babel-preset@7.2.2 - eslint-config-4catalyzer-typescript@1.1.2

view details

renovate[bot]

commit sha 4dc82db532a6967be62eb6f05553b5d81b7534bc

chore(deps): update dependency eslint-plugin-jest to v23 (#536)

view details

Giacomo Tagliabue

commit sha 40e3d662bb647bed9c5ee163f4aac642f9b9e925

set import/extensions to off for ts files (#537)

view details

Giacomo Tagliabue

commit sha 97a8171c0cb541a3f80f3baf1c66f1f88a4ad57f

Publish - @4c/babel-preset@7.2.3 - eslint-config-4catalyzer-jest@2.0.2 - eslint-config-4catalyzer-typescript@1.1.3

view details

Jimmy Jia

commit sha ac08c5c673a8e9eaa2249eff47c07be8f6a52430

fix: Allow importing TS without extension from JS (#538)

view details

Jimmy Jia

commit sha 8427d4e0b99d63035688c7de4c8402eaf7978757

Publish - @4c/babel-preset@7.2.4 - eslint-config-4catalyzer-flow-react@1.0.3 - eslint-config-4catalyzer-flow@1.0.2 - eslint-config-4catalyzer-react@1.0.1 - eslint-config-4catalyzer-typescript@1.1.4 - eslint-config-4catalyzer@1.0.1

view details

Jimmy Jia

commit sha e3feee712dede4ada5c137fca78b1e9e836f1d9e

chore(deps): update all non-major dependencies (#542)

view details

renovate[bot]

commit sha d59d4ba2cda98fe56b245f81679ed82fd1c65d0f

chore(deps): update dependency eslint-plugin-react-hooks to v2 (#541)

view details

Jimmy Jia

commit sha ad694468b83ef886bdf23c9dd76ea414c6647ae6

chore(deps): update all non-major dependencies (#548)

view details

renovate[bot]

commit sha 9783b19aa73cfec8d5328199f63a776bd8a7d386

chore(deps): update all non-major dependencies (#549)

view details

Jimmy Jia

commit sha fb2008872e83b53f28b5cf5f865bef84526963ea

chore(deps): update all non-major dependencies (#553) Co-authored-by: Renovate Bot <renovatebot@gmail.com>

view details

renovate[bot]

commit sha fe74c477350485ca887f0c9e8f21d58e60f4dcd2

chore(deps): update dependency husky to v4 (#554) Co-authored-by: Renovate Bot <renovatebot@gmail.com>

view details

renovate[bot]

commit sha fbd3f983e1653c97bfdddc6acef63cd0f2575066

chore(deps): update semantic-release monorepo (#556) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

view details

renovate[bot]

commit sha b0096aff9718b56f7d211da79cae484994b94599

chore(deps): update all non-major dependencies (#557) Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

view details

Jimmy Jia

commit sha f2832ad8b77401179137067cfabb6944dca90092

chore: Use Babel 7.8 defaults (#558)

view details

Jason Quense

commit sha 32cbb5bfb7f57eee6cacae520543183a7a53477f

feat: add esm targeted preset (#544) * feat: add esm targeted preset * fix: handle quoted strings in intl message descriptors * WIP * allow browserslist targets * add comment

view details

Jason Quense

commit sha 0e4d830f33760b4f833cba2250da372b20707239

Publish - @4c/babel-preset@7.3.0 - eslint-config-4catalyzer-flow-react@1.0.4 - eslint-config-4catalyzer-flow@1.0.3 - eslint-config-4catalyzer-jest@2.0.3 - eslint-config-4catalyzer-react@1.0.2 - eslint-config-4catalyzer-typescript@1.1.5 - eslint-config-4catalyzer@1.0.2 - @4c/jest-preset@1.4.4 - @4c/semantic-release-alt-publish-dir@5.0.4 - @4c/semantic-release-config@2.0.4

view details

Renovate Bot

commit sha 5a6aa3825e870c42df5b8ed28822694a8003cc83

chore(deps): update all non-major dependencies

view details

renovate[bot]

commit sha f8b27841ea69c57ff65d1928c52fa388c33d3f07

chore(deps): update dependency lint-staged to v10 (#560) * chore(deps): update dependency lint-staged to v10 * Update package.json Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> Co-authored-by: Jimmy Jia <tesrin@gmail.com>

view details

push time in 21 hours

issue commentjquense/react-widgets

Support for React 17.x

O and v5 is in typescript so no new defs needed

mateusz-meller

comment created time in a day

issue commentjquense/react-widgets

Support for React 17.x

v5 is almost ready to go, there are a few rough edges that need to be filed down and some more stuff to tweak. The issue is more that i'm still trashing a bit on the list and listbox implementations around focus management. In any case we use v5 in prod so it does work. The localizers need to be released as well

mateusz-meller

comment created time in a day

issue commentpopperjs/react-popper

Experiment a new hooks based API

To clarify folks, out hook does not accept refs intentionally because useRef is the wrong thing to use when you need to be updated when they change. Instead you should use a "callback ref" (react's confusing name not mine).

const [el, setEl] = useState<HTMLElement>(null)
const popper = usePopper(el)

return <div ref={setEl} />

As @ignatevdev noted the problem with refs is you cannot respond to changes very easily. instead In other words, useState is the more correct thing to do here if you need to respond to element changes like we do. That it is null on the first pass is unimportant in practice (in our experience here, and in react-bootstrap. b/c the element is set and updated before any DOM rendering issues could happen.

references: https://reactjs.org/docs/refs-and-the-dom.html#callback-refs https://twitter.com/sebmarkbage/status/1091808948523581440

FezVrasta

comment created time in a day

push eventjquense/docpocalypse

Jason Quense

commit sha a239a0fe7e19c7008cbcfa6ad4bb79c21aec5352

Publish - @docpocalypse/gatsby-theme-core@0.7.4 - @docpocalypse/gatsby-theme@0.9.6

view details

push time in a day

push eventjquense/docpocalypse

Jason Quense

commit sha 9c4b679f1f64132a860567d04b9411ec98a28e88

fix: live code info component

view details

Jason Quense

commit sha 868bb64ab3758c96f5e575a756a9076a0e2e8992

fix: LinkedHeading padding

view details

Jason Quense

commit sha ec9b422f251365f44e804b70100e4959d9943069

feat: auto none api pages

view details

push time in a day

Pull request review comment4Catalyzer/astroturf

Imports

+// declare global {+//   namespace JSX {+//     interface IntrinsicAttributes {+//       css?: string | Record<string, string>;+//     }+//   }+// }+// declare module 'react' {+//   interface DOMAttributes<T> {+//     css?: string | Record<string, string>;+//   }+// }

Arg oops. Thanks for catching

jquense

comment created time in a day

issue commentpopperjs/react-popper

Experiment a new hooks based API

I don't think you need to worry about it unless you are running into perf issues. Popper already schedules and dedupes the events via requestAnimationFrame so it should be smooth even if it's noisy. If it does causes issues you can disable updates from events, which is partly why its a first class option on the hook

FezVrasta

comment created time in a day

issue closedfacebook/react

setState takes type State but it should be Partial<State>

Not sure where TS typing complaints belong, I have this one:

Screenshot from 2020-02-25 17-13-18

As far as I know it should be Partial<State> not State for the type. Here is the type of setState()

    function useState<S>(initialState: S | (() => S)): [S, Dispatch<SetStateAction<S>>];

but this is better:

    function useState<S>(initialState: S | (() => S)): [S, Dispatch<SetStateAction<Partial<S>>>];

closed time in a day

ORESoftware

issue commentfacebook/react

setState takes type State but it should be Partial<State>

The useState hook isn't like setState in a class it completely replaces the previous value on update. So "partial" updates like your example would leave state without hotReloadState

ORESoftware

comment created time in a day

pull request commentjquense/docpocalypse

feat: typescript doc block

I'd hope something akin to the inline case for documentation js e.g. https://www.gatsbyjs.org/docs/node-model/#runQuery

I don't think you need to have the title be super long, but you do want to treat it as a nested block to define. Capped at some depth, probably 6 since that's as far as h* tags go anyway

ethanve

comment created time in 2 days

push eventjquense/docpocalypse

Jason Quense

commit sha 37d137647602cf31bbe51d9be103adc8231ae9eb

fix: fix up a bunch of styles and remove remark prism

view details

Jason Quense

commit sha 3b10bac3c50398e055c4f2d15f8f4a7ad8925c31

Publish - @docpocalypse/gatsby-data-utils@1.0.2 - gatsby-plugin-typedoc@0.3.2 - @docpocalypse/gatsby-theme-core@0.7.3 - @docpocalypse/gatsby-theme@0.9.5

view details

push time in 2 days

push event4Catalyzer/astroturf

Jason Quense

commit sha f660d12a61f90e43c5e6c7f784fa61a1584e4fff

feat: split imports and output esm (#566) * feat: split imports and output esm Adds a `astroturf/react` sub import for better namespacing BREAKING CHANGE: styled is not exported on the main entry anymore BREAKING CHANGE: css props cannot use the DECSS prop mapping convention anymore * fix tests

view details

push time in 2 days

delete branch 4Catalyzer/astroturf

delete branch : imports

delete time in 2 days

PR merged 4Catalyzer/astroturf

Imports

Adds a astroturf/react sub import for better namespacing

BREAKING CHANGE: styled is not exported on the main entry anymore BREAKING CHANGE: css props cannot use the DECSS prop mapping convention anymore

+418 -868

0 comment

70 changed files

jquense

pr closed time in 2 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 8a79a4b38226db60d1c795998cf550451674dacc

fix tests

view details

push time in 2 days

created tagreact-restart/hooks

tagv0.3.21

A set of utility and general-purpose React hooks.

created time in 2 days

push eventreact-restart/hooks

Jason Quense

commit sha ed37bf3dfc8fc1d9234a6d8fe0af94d69fad3b74

Publish v0.3.21

view details

push time in 2 days

pull request commentjquense/docpocalypse

feat: typescript doc block

This looks great, There is one issue tho I think we should handle here. The types don't really recurse past the first level. so useThing(opts: SomeType) doesn't show any useful info about SomeType it's just opts: SomeType

ethanve

comment created time in 2 days

push event4Catalyzer/astroturf

Jason Quense

commit sha bb78dca897b7efc9f5210dd9f345ceb82f1aa041

v0.4 style composition api for css props (#563) * WIP * WIP * feat: add variants * Update src/features/styled-component.ts * address feedback * snaps

view details

Jason Quense

commit sha b358ddc7fa5e87f22b1f257f037744d6232f7b3d

feat: split imports and output esm Adds a `astroturf/react` sub import for better namespacing BREAKING CHANGE: styled is not exported on the main entry anymore BREAKING CHANGE: css props cannot use the DECSS prop mapping convention anymore

view details

push time in 2 days

push event4Catalyzer/astroturf

Jason Quense

commit sha bb78dca897b7efc9f5210dd9f345ceb82f1aa041

v0.4 style composition api for css props (#563) * WIP * WIP * feat: add variants * Update src/features/styled-component.ts * address feedback * snaps

view details

push time in 2 days

delete branch 4Catalyzer/astroturf

delete branch : dynamic-classes

delete time in 2 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 6dfa70ddf2967f6fe3997288e02c268b4e1e9ffa

feat: split imports and output esm Adds a `astroturf/react` sub import for better namespacing BREAKING CHANGE: styled is not exported on the main entry anymore BREAKING CHANGE: css props cannot use the DECSS prop mapping convention anymore

view details

push time in 2 days

PR opened 4Catalyzer/astroturf

Imports
+1114 -1071

0 comment

89 changed files

pr created time in 2 days

PR merged 4Catalyzer/astroturf

v0.4 style composition api for css props

~not done!~

+665 -382

1 comment

47 changed files

jquense

pr closed time in 2 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 82770e9d287bd55b60fe45353cd294ecc1306cfd

feat: split imports and output esm Adds a `astroturf/react` sub import for better namespacing BREAKING CHANGE: styled is not exported on the main entry anymore BREAKING CHANGE: css props cannot use the DECSS prop mapping convention anymore

view details

push time in 2 days

create barnch4Catalyzer/astroturf

branch : imports

created branch time in 2 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 7be871d172e07b45ba1cdabc441c8affe746e9ae

snaps

view details

push time in 2 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 7c4e01b3de954678a350eacf6152b1e60107be84

address feedback

view details

push time in 2 days

push event4Catalyzer/astroturf

Jason Quense

commit sha b357b816a4c32829c2a2ebc279ebfc52d365374a

Update src/features/styled-component.ts

view details

push time in 2 days

Pull request review comment4Catalyzer/astroturf

v0.4 style composition api for css props

 function buildStyledComponent(     value: '',   }; -  const { text, dynamicInterpolations, imports } = buildTaggedTemplate({+  const importId = styleImports.add(style);++  const { css, vars, variants, interpolations } = buildTaggedTemplate({     style,     nodeMap,-    quasiPath: path.get('quasi'),+    importId,     location: 'COMPONENT',+    quasiPath: path.get('quasi'),     pluginOptions: opts.pluginOptions,   }); -  style.imports = imports;-  style.interpolations = trimExpressions(dynamicInterpolations);-  style.value = imports + wrapInClass(text);--  const importId = styleImports.add(style);+  // style.imports = dependencyImports;
jquense

comment created time in 2 days

pull request comment4Catalyzer/astroturf

v0.4 style composition api for css props

No prettier still makes this look not great, there was a PR to fix it tho, but it got abandoned. someone just needs to do it

jquense

comment created time in 2 days

Pull request review comment4Catalyzer/astroturf

v0.4 style composition api for css props

 function jsx(type, props, ...children) {     const { css, ...childProps } = props;     childProps.style = varsToStyles(childProps, css[1]);     childProps.className = propsToStyles(childProps, css[0] || css, true);+    childProps.className += resolveVariants(css[2]);

not with the reduce since the first one is ''

jquense

comment created time in 2 days

Pull request review comment4Catalyzer/astroturf

v0.4 style composition api for css props

 const camelCase = str =>     '',   ); +function resolveVariants(variants) {+  return variants.length+    ? variants.reduce((c, n) => (n ? `${c} ${n}` : c), '')

true!

jquense

comment created time in 2 days

pull request commentreact-bootstrap/react-overlays

Migrate to import * as React from 'react'

does this make sense to change until they actually provide an esm build?

TrySound

comment created time in 3 days

push event4Catalyzer/layout

Jason Quense

commit sha 109f453dec03d19c78d1993541a4c3cc3da3f31a

2.0.5

view details

push time in 3 days

issue commentreact-bootstrap/react-bootstrap

Toast uses opacity 0 instead of display none

ya go for it 👍

ccornici

comment created time in 3 days

issue commenttivac/modular-css

Question: why does external compose all the classes into a selector?

yup will do some research, wanted to make sure i had all the context first 👍

jquense

comment created time in 3 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 9de6a237ce699ec7eab2003d5f18e8a53ce3fa52

feat: add variants

view details

push time in 3 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 1131738acba7f65b7fd84a8e20c6b15daa40ad80

feat: better webpack tooling (#561) * feat: better webpack tooling * Update README.md Co-Authored-By: Jimmy Jia <tesrin@gmail.com> * fix snapshots with path names Co-authored-by: Jimmy Jia <tesrin@gmail.com>

view details

Jason Quense

commit sha 10b2a7929c7da07dc6bdd9af9d0f0cbc8e913e5f

WIP

view details

Jason Quense

commit sha fd5177d6202c684908093d020c6d66ca788ff648

WIP

view details

Jason Quense

commit sha 8424d5d5955b71829a466a50053093d66d854325

feat: add variants

view details

push time in 3 days

issue commentpopperjs/react-popper

Experiment a new hooks based API

if anyone is looking for some public implementation react-overlays has a popper hook: https://github.com/react-bootstrap/react-overlays/blob/master/src/usePopper.js

FezVrasta

comment created time in 3 days

startedsuchipi/test-it

started time in 3 days

issue commenttivac/modular-css

Question: why does external compose all the classes into a selector?

It's not causing issues in the sense something is broken, but it is leading to confusing css, and more bytes. Specifically we use something like tailwindcss where you can have a lot of classes composed in:

.foo {
  composes: pt-5 pb-6 mx-6 bg-red leading-wide from global;
}

you end up with a long selector that isn't necessary. I also see the other side of this which is that composed classes aren't really part of the thing you are trying to reference, they are an implementation detail, and having to think about them feels a bit off. In any case it's not actively a problem just something we noticed! Will report back if i find something technically limiting

jquense

comment created time in 3 days

issue closedfacebook/react

i can not see the components

👉 Please follow one of these issue templates:

  • https://github.com/facebook/react/issues/new/choose

Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.

closed time in 4 days

karrziloo

Pull request review commentjquense/docpocalypse

feat: typescript doc block

 export function createSchemaCustomization({         SomeValue: { value: 2097248 }       }     }),+    schema.buildObjectType({+      name: `TypedocMdx`,+      extensions: ['dontInfer'],+      fields: {+        body: 'String!',+        mdxAST: 'JSON'+      }+    }),+    schema.buildObjectType({+      name: `TypedocMarkdownRemark`,+      extensions: ['dontInfer'],+      fields: {+        html: 'String'+      }+    }),+    schema.buildObjectType({+      name: 'TypedocCommentValue',+      interfaces: ['Node'],+      extensions: ['dontInfer'],+      fields: {+        value: 'String',+        markdownRemark: {+          type: 'TypedocMarkdownRemark',+          resolve: proxyToNode('fields.markdownRemark')

I think you are missing https://github.com/jquense/docpocalypse/blob/master/packages/theme-core/plugins/react-docgen/gatsby-node.js#L267 to make this work,

These fields are set by a createNodeField call. What is happening in the react-docgen case is this:

  • create a description node
    • MDX sees a new text/markdown node and creates a MDX node, with that node as it's parent
  • react-docgen plugin sees the new MDX node, check if it's parent is a Description
    • if so it tags the description with the mdx ID so it can resolve it easier a bit later. It's sort of like adding a backref

Then in the description resolver, the logic is

  • Grab node that corresponds to the ID stored at this path (fields.mdx)"
  • Get every field matching field on my GQL type, that has a corresponding field on the other type
    • use the resolver for the other field as the resolver for my field of the same name

E.gTypedocMDX.body use the MDX.body field def to resolve the value

The reason this is convoluted is if you just link to the MDX type, it MUST exist in the graphql schema, b/c strong typing. Since MDX is optional, e.g. a user may not have it configured we need to make a proxy type, that way if MDX isn't configured our types still exist, but resolve to null

ethanve

comment created time in 6 days

Pull request review commentjquense/docpocalypse

feat: typescript doc block

 export function createSchemaCustomization({       }        type TypedocComment @dontInfer {-        text: String-        shortText: String+        text: TypedocCommentValue!

you want the @link directive as well, which set the gql resolver to resolve the src value as an id and return the node instead. e.g. it does this:

resolve: (obj) => getNode(src)
ethanve

comment created time in 6 days

Pull request review commentjquense/docpocalypse

feat: typescript doc block

+const commentId = (parentId, type) => `${parentId}--${type}TypedocCommentValue`;++const toTextNodeFactory = ({+  createNode,+  createNodeId,+  createContentDigest,+  id+}) => (value, type: 'Text' | 'ShortText') => {+  const node = {+    value,+    id: createNodeId(commentId(id, type)),+    parent: id,+    children: [],+    internal: {+      type: `TypedocCommentValue`,+      mediaType: `text/markdown`,+      content: value,+      contentDigest: createContentDigest(value)+    }+  };++  createNode(node);+  return node;+};++interface CommentNode {+  id: string;+  parent: string;+  children: string[];+  text?: string;+  shortText?: string;+  tags?: any;+}++function createCommentNode(+  node,+  entry: { tags?: string[]; text?: string; shortText?: string },+  actions,+  createNodeId,+  createContentDigest+) {+  const { createNode } = actions;++  const toTextNode = toTextNodeFactory({+    createNode,+    createNodeId,+    createContentDigest,+    id: node.id+  });++  const commentNode: CommentNode = {+    id: createNodeId(commentId(node.id, '')),+    parent: node.id,

you also need an internal field here, every node (not graphql Node, gatsby Node) needs it

ethanve

comment created time in 6 days

Pull request review commentjquense/docpocalypse

feat: typescript doc block

+const commentId = (parentId, type) => `${parentId}--${type}TypedocCommentValue`;++const toTextNodeFactory = ({+  createNode,+  createNodeId,+  createContentDigest,+  id+}) => (value, type: 'Text' | 'ShortText') => {+  const node = {+    value,+    id: createNodeId(commentId(id, type)),+    parent: id,+    children: [],+    internal: {+      type: `TypedocCommentValue`,+      mediaType: `text/markdown`,+      content: value,+      contentDigest: createContentDigest(value)+    }+  };++  createNode(node);+  return node;+};++interface CommentNode {+  id: string;+  parent: string;+  children: string[];+  text?: string;+  shortText?: string;+  tags?: any;+}++function createCommentNode(+  node,+  entry: { tags?: string[]; text?: string; shortText?: string },+  actions,+  createNodeId,+  createContentDigest+) {+  const { createNode } = actions;++  const toTextNode = toTextNodeFactory({+    createNode,+    createNodeId,+    createContentDigest,+    id: node.id+  });++  const commentNode: CommentNode = {+    id: createNodeId(commentId(node.id, '')),+    parent: node.id,+    children: []

you can probably just spread in ...entry and not do as many checks below

ethanve

comment created time in 6 days

Pull request review commentjquense/docpocalypse

feat: typescript doc block

 export function createSchemaCustomization({       }        type TypedocComment @dontInfer {-        text: String-        shortText: String+        text: TypedocCommentValue!+        shortText: TypedocCommentValue!

what is the difference between these fields btw?

ethanve

comment created time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 1131738acba7f65b7fd84a8e20c6b15daa40ad80

feat: better webpack tooling (#561) * feat: better webpack tooling * Update README.md Co-Authored-By: Jimmy Jia <tesrin@gmail.com> * fix snapshots with path names Co-authored-by: Jimmy Jia <tesrin@gmail.com>

view details

push time in 6 days

delete branch 4Catalyzer/astroturf

delete branch : tooling

delete time in 6 days

PR merged 4Catalyzer/astroturf

Tooling

This is foundation for doing more advanced tooling on astroturf produced styles. It's a bit POC, but works.

What happens is the js loader, adds an inline loader to the astroturf style import, That loader, moves itself to right after css-loader and handles nesting, etc.

With this we can handle doing the css module transforms ourself, or whatever else. I've not attempted that here tho, since this was getting a bit complex as it was

+2567 -1667

0 comment

47 changed files

jquense

pr closed time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha cab1c0649a1c6d7c1ed3419d063bdb57b7e647ab

fix snapshots with path names

view details

push time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 31ed001590d4015ab8e3f31619745be6909e10a5

fix snapshots with path names

view details

push time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha a7e323c5b5dd2edf692609f7b1efaf5a8d315df1

fix snapshots with path names

view details

push time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha c2cff5958afc2266b836e201a7a7f7dbac62f793

Update README.md Co-Authored-By: Jimmy Jia <tesrin@gmail.com>

view details

push time in 6 days

PR opened 4Catalyzer/astroturf

WIP: v0.4 style composition api for css props
+619 -210

0 comment

12 changed files

pr created time in 6 days

create barnch4Catalyzer/astroturf

branch : dynamic-classes

created branch time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha ce5a6c69a647ff908c65b4c9d03e450eddbc39a5

feat: better webpack tooling

view details

push time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 77855c9c70023391ec8fb2b78a116072575e21c9

feat: update option names BREAKING CHANGE: option names have changed BREAKING CHANGE: allowGlobal no longer defaults to true

view details

Jason Quense

commit sha eaa2adb8d32af02d7dd08f2b36f0090a8d9a968b

WIP

view details

Jason Quense

commit sha f9777846343817b6380272de7ef178381f2be0ae

WIP

view details

Jason Quense

commit sha 30c05c4af20705cfb8ce2d0e08bc7185e41da2a5

feat: split css and stylesheet tags for single class declarations

view details

Jason Quense

commit sha 3ee3662ed3723a5877afae1b0f3ec68512d08b53

Merge pull request #552 from 4Catalyzer/stylesheet Stylesheets and single classes

view details

Jason Quense

commit sha dce3de8d609e33ad3b64ce3dfffafea1e4ff07c9

feat: better webpack tooling

view details

push time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha bf9f93104e1573c98e99c56a4d65b84fbf8ea568

feat: better errors for bad dynamic expression usage (#562)

view details

Jason Quense

commit sha b77b4a68f8c8a0872d2d86629a32a0e0085e76bd

WIP

view details

Jason Quense

commit sha 3fd0326b80c99f87c45221b7248db8eda62da3fa

fixup

view details

Jason Quense

commit sha be8426aa9e16bbab0634cb92c985f057093e171a

sync

view details

push time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 77855c9c70023391ec8fb2b78a116072575e21c9

feat: update option names BREAKING CHANGE: option names have changed BREAKING CHANGE: allowGlobal no longer defaults to true

view details

Jason Quense

commit sha eaa2adb8d32af02d7dd08f2b36f0090a8d9a968b

WIP

view details

Jason Quense

commit sha f9777846343817b6380272de7ef178381f2be0ae

WIP

view details

Jason Quense

commit sha 30c05c4af20705cfb8ce2d0e08bc7185e41da2a5

feat: split css and stylesheet tags for single class declarations

view details

Jason Quense

commit sha 3ee3662ed3723a5877afae1b0f3ec68512d08b53

Merge pull request #552 from 4Catalyzer/stylesheet Stylesheets and single classes

view details

push time in 6 days

delete branch 4Catalyzer/astroturf

delete branch : stylesheet

delete time in 6 days

PR merged 4Catalyzer/astroturf

Stylesheets and single classes
+384 -367

1 comment

35 changed files

jquense

pr closed time in 6 days

issue openedtivac/modular-css

Question: why does external compose all the classes into a selector?

Just a general question about the original rationale for having :external compose all the clases the references composes and not just the class matching the identifier:

.wooga { color: red; }

.booga {
  composes: wooga;
}

// other file
.b :external(booga from  "./simple.css") {
    background: blue;
}

Produces:

.b .wooga.booga {

instead of

.b .booga {

The current approach it seems maybe more "correct" somehow, but also leads to selectors whose specificity is hard to reason about (and can change indirectly). Wondering if there were specific practical considerations or if you've seen benefits vs downsides to this approach?

created time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha bf9f93104e1573c98e99c56a4d65b84fbf8ea568

feat: better errors for bad dynamic expression usage (#562)

view details

Jason Quense

commit sha 77855c9c70023391ec8fb2b78a116072575e21c9

feat: update option names BREAKING CHANGE: option names have changed BREAKING CHANGE: allowGlobal no longer defaults to true

view details

Jason Quense

commit sha eaa2adb8d32af02d7dd08f2b36f0090a8d9a968b

WIP

view details

Jason Quense

commit sha f9777846343817b6380272de7ef178381f2be0ae

WIP

view details

Jason Quense

commit sha 30c05c4af20705cfb8ce2d0e08bc7185e41da2a5

feat: split css and stylesheet tags for single class declarations

view details

push time in 6 days

issue closedfacebook/react

Tell me how to install react js doc

I would like not only to install the engine, but also to put on your local machine the documentation that you have on the official website. For the reason that I do not have permanent Internet access.

https://reactjs.org/ - > https://localhost:3000/ Is it possible to do this?

closed time in 6 days

Corsairs

issue commentfacebook/react

Tell me how to install react js doc

you'd need to build the docs site from source: https://github.com/reactjs/reactjs.org

Corsairs

comment created time in 6 days

issue commenttivac/modular-css

Editor support

We use https://github.com/AndrewLeedham/vscode-css-modules, it also has instructions for configuring vscode's builtin lint plugins to handle the syntax.

erykpiast

comment created time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha 56e807bf35bb829cf8441e71cc3f139be801a17f

fixup

view details

push time in 6 days

push event4Catalyzer/astroturf

Jason Quense

commit sha bf9f93104e1573c98e99c56a4d65b84fbf8ea568

feat: better errors for bad dynamic expression usage (#562)

view details

push time in 7 days

delete branch 4Catalyzer/astroturf

delete branch : warning

delete time in 7 days

PR merged 4Catalyzer/astroturf

Better errors
+140 -37

0 comment

6 changed files

jquense

pr closed time in 7 days

issue closedreact-bootstrap/react-bootstrap

Dropdown in Tab is broken when wrapping NavDropdown as a separate functional component

Describe the bug

The dropdown in tab cannot be extracted as a separate functional component.

To Reproduce

// Works
<Nav>
  <NavItem>
    key={'item1'}
    eventKey={'item1'}
    onClick={onClick}
    >
      item 1
  </NavItem >
</Nav>


// Doesn't work
const MyDropdown = () => (
  <NavDropdown>
    <NavItem>
      key={'item1'}
      eventKey={'item1'}
      onClick={onClick}
      >
        item 1
    </NavItem >
  </NavDropdown>
);

<Nav>
  <MyDropdown />
</Nav>

Sandbox

https://codesandbox.io/s/react-bootstrap-tab-navbar-functional-component-85cfw

Expected behavior

The second code snippet above should be equivalent as the first example The SnackDropdown in the codesandbox should be working

If applicable, add screenshots to help explain your problem.

Environment (please complete the following information)

  • React v16.12.0
  • React-Bootstrap 0.33.1

closed time in 7 days

kimyu92

issue commentreact-bootstrap/react-bootstrap

`Dropdown.Toggle` incorrectly expects `onClick` prop when using a custom element.

its a type issue, if it's blocking you override the type in your code or cast to any, we will get to this eventually but type def issues are low on the priority list, since they are advisory and do not affect the actual code behavior

fbessou

comment created time in 7 days

PR opened 4Catalyzer/astroturf

Better errors
+140 -37

0 comment

6 changed files

pr created time in 7 days

more