profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jquense/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

facebook/react 170138

A declarative, efficient, and flexible JavaScript library for building user interfaces.

gatsbyjs/gatsby 50557

Build blazing fast, modern apps and websites with React

insin/react-maskedinput 708

Masked <input/> React component

graphql-dotnet/relay 61

A toolset for creating Relay.js compatible GraphQL servers in dotnet.

amatiasq/vsc-sort-imports 55

Sort ES6 imports automatically.

jquense/bill 53

css selector engine for React elements and components

jquense/babel-plugin-jsx-fragment 16

jsx syntatic sugar for React's `createFragment()`

jquense/component-metadata-loader 5

webpack loader to parse React component metadata from source code

issue commentreact-bootstrap/react-bootstrap

Focus error in Dropdown

By default, dropdowns do not render the menu until the button toggle is clicked. So in this case, since there is no menu, the ref isn't valid yet. We'll need to check if menuRef.current exists before calling contains()

xkomiks

comment created time in 2 hours

delete branch react-restart/ui

delete branch : rtl-modal

delete time in 2 hours

push eventreact-restart/ui

Kyle Tsang

commit sha c7464becb8ca9f4ba1a9d0f5f0d515efefbecb27

feat(ModalManager): support left padding adjustment for RTL (#12)

view details

push time in 2 hours

PR merged react-restart/ui

feat(ModalManager): support left padding adjustment for RTL

Adds ability to set padding on left side if RTL enabled. Also increase test coverage for ModalManager

+88 -8

0 comment

2 changed files

kyletsang

pr closed time in 2 hours

issue commentreact-bootstrap/react-bootstrap

Documentation: Remind users to import glyphicon in their css

you may add:

import { Glyphicon } from 'react-bootstrap'; import 'bootstrap/dist/css/bootstrap.min.css';

cschoder

comment created time in 9 hours

startedjquense/react-widgets

started time in 9 hours

startedAndreasFaust/gatsby-source-custom-api

started time in 10 hours

startedjquense/yup

started time in 13 hours

startedjquense/yup

started time in 13 hours

issue openedreactjs/react-transition-group

Declaring `-enter-active` before `-enter` breaks transitions

What is the current behavior?

When mixing up the order of the -enter and -enter-active classes, transitions stop working properly.

/* Works */
.fade-enter .btn {}
.fade-enter-active .btn {}
/* Doesn't work */
.fade-enter-active .btn {}
.fade-enter .btn {}

What is the expected behavior?

I'm expecting the transitions to work regardless of class order, but that might just be my lack of knowledge about CSS transitions talking. I couldn't find anything in the docs explaining that the class order is important.

Could you provide a CodeSandbox demo reproducing the bug?

https://codesandbox.io/s/priceless-brook-66uzg?file=/src/styles.css

created time in 14 hours

startedjquense/yup

started time in 20 hours

issue commentjquense/yup

Validate at least one checkbox (boolean) is chosen

Hi, I'm using React Native and I've got the following data structure:

const initialValues = { exercises: [ { title: "", exerciseType: { reps: false, duration: false, extraWeight: false, }, }, ], }; And this is my exercise Schema

const exerciseSchema = yup.object().shape({ exercises: yup.array().of( yup.object().shape({ title: yup.string().required().min(2).label("Exercise Name"), exerciseType: yup.object({ reps: yup.boolean(), duration: yup.boolean(), }), }) ), });

Whilst it's working for title, I can't get it working for the checkboxes. I'm getting the values for reps and duration, but how can I check that at least one of them is true?

rosskevin

comment created time in a day

pull request commentreactjs/react-transition-group

chore: migrate storybook to v6

This is quite slow and is not acceptable, so I have to resolve the issue before merging this.

koba04

comment created time in a day

issue commentreact-bootstrap/react-bootstrap

Focus error in Dropdown

The source of the error lays in react-overlays: Dropdown.tsx #281 !menuRef.current!.contains(e.target as HTMLElement)

I'm not sure if the non-null assertion failing should be prevented or if the state of current being null is illegal.

xkomiks

comment created time in a day

pull request commentreact-bootstrap/react-bootstrap

Fixed autoClose being mandatory

@kyletsang Yeah, if I hadn't used it myself, I also would've missed it. This was the time working with propTypes together with a ts prop type declaration. Naming a defaultProp and leaving the oneOf() without .isRequired doesn't seem to satisfy typescript.

jotoh98

comment created time in a day

issue commentreact-bootstrap/react-bootstrap

missing `backdrop` attribute on `ModalProps` when using typescript

@golota60 yeah, I think fixing it in react-overlays/@restart/ui is the better option. Pick was just a quick fix 😛

achmadk

comment created time in a day

push eventreact-bootstrap/react-bootstrap

Kyle Tsang

commit sha d646fa18724bc7ea60c89a4be3fe79c8027436dc

Update CHANGELOG.md

view details

push time in a day

push eventreact-bootstrap/react-bootstrap

kyletsang

commit sha 6453bbfb0281733edb3acf38241240890b3cb0fd

Publish v2.0.0-beta.2

view details

push time in a day

created tagreact-bootstrap/react-bootstrap

tagv2.0.0-beta.2

Bootstrap components built with React

created time in a day

PR opened react-restart/ui

Reviewers
feat(ModalManager): support left padding adjustment for RTL

Adds ability to set padding on left side if RTL enabled. Also increase test coverage for ModalManager

+88 -8

0 comment

2 changed files

pr created time in a day

create barnchreact-restart/ui

branch : rtl-modal

created branch time in a day

push eventreact-bootstrap/react-bootstrap

Jonathan Hassel

commit sha 159ee208c07027aa18f25e85e93a8608ba9a432b

Fixed autoClose being mandatory (#5886) * adds autoClose behaviour for dropdowns * replaced autoClose type, refactored logic, cleaned up tests * made autoClose optional, refactored code, improved doc naming

view details

push time in a day

pull request commentreact-bootstrap/react-bootstrap

Fixed autoClose being mandatory

Thanks, totally missed that

jotoh98

comment created time in a day

PR merged react-bootstrap/react-bootstrap

Fixed autoClose being mandatory

Closes #5885.

Made autoClose optional, refactored code slightly and improved the naming in the doc to be like https://getbootstrap.com/docs/5.0/components/dropdowns/#auto-close-behavior

+51 -20

0 comment

2 changed files

jotoh98

pr closed time in a day

issue closedreact-bootstrap/react-bootstrap

autoClose for dropdowns is mandatory

Describe the bug

The autoClose property in the interface DropdownProps is mandatory though the specification states an implicit standard value. Upon working with NavDropdown, I stumbled across this.

Expected behavior

The autoClose property should not be mandatory. If not defined, the standard value true should be used.

closed time in a day

jotoh98

startedmicrosoft/GW-BASIC

started time in a day

push event4Catalyzer/found

Renovate Bot

commit sha ff8029dd75d037d9000926d05a3f2ffb35a2705d

chore(deps): update all non-major dependencies

view details

push time in a day

push eventreact-bootstrap/react-overlays

Renovate Bot

commit sha 15cafd2583c855e0d348998bc6a9ed0b456b3467

chore(deps): update all non-major dependencies

view details

push time in a day

issue commentreact-bootstrap/react-bootstrap

missing `backdrop` attribute on `ModalProps` when using typescript

@kyletsang I got around to fixing it by using Pick, but an idea came to my mind, but I'd like to get it confirmed before implementing, cause it would require changes in react-overlays.

So, in react-overlays, instead of having ModalProps we could split them like so:


interface IndexSignature { [other: string]: any};

export interface ModalPropsWithoutIndexSignature {
    children?: React.ReactElement;
    role?: string;
    style?: React.CSSProperties;
    className?: string;
    show?: boolean;
    container?: DOMContainer;
    onShow?: () => void;
    onHide?: () => void;
    manager?: ModalManager;
    backdrop?: true | false | 'static';
    renderDialog?: (props: RenderModalDialogProps) => React.ReactNode;
    renderBackdrop?: (props: RenderModalBackdropProps) => React.ReactNode;
    onEscapeKeyDown?: (e: KeyboardEvent) => void;
    onBackdropClick?: (e: React.SyntheticEvent) => void;
    containerClassName?: string;
    keyboard?: boolean;
    transition?: ModalTransitionComponent;
    backdropTransition?: ModalTransitionComponent;
    autoFocus?: boolean;
    enforceFocus?: boolean;
    restoreFocus?: boolean;
    restoreFocusOptions?: {
        preventScroll: boolean;
    };
}

export type ModalProps = ModalPropsWithoutIndexSignature & IndexSignature;

Doing that would allow us to import ModalPropsWithoutIndexSignature as BaseModalProps instead of ModalProps as BaseModalProps, and then, in react-bootstrap we would just re-apply the index signature like so


export interface ModalProps
  extends Omit<
    BaseModalProps,
    | 'role'
    | 'renderBackdrop'
    | 'renderDialog'
    | 'transition'
    | 'backdropTransition'
  > {
  size?: 'sm' | 'lg' | 'xl';
  fullscreen?:
    | true
    | 'sm-down'
    | 'md-down'
    | 'lg-down'
    | 'xl-down'
    | 'xxl-down';
  bsPrefix?: string;
  centered?: boolean;
  backdropClassName?: string;
  animation?: boolean;
  dialogClassName?: string;
  contentClassName?: string;
  dialogAs?: React.ElementType;
  scrollable?: boolean;
  [other: string]: any;
}

I think this way of handling it would be better - if ModalProps in react-overlays ever change, when using Pick we would need to update that, but if we apply the suggested solution it would take care of itself

achmadk

comment created time in a day