@PH9 @rogerluan Ahhhhh yeah yeah yeah, I can kind of see how that conflict might cause an issue since :username is also picking stuff up from FASTLANE_USER and DELIVER_USER 😬 It probably is best to remove these conflicts!

Hey sorry! This one slipped my eyes. I’ll be looking into!

<!-- Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

Checklist

• [x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
• [x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Motivation and Context

<!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. -->

https://github.com/fastlane/fastlane/issues/17243 In this issue, it's reported that deliver got stuck with the message "Waiting for screenshot to appear before uploading..." and didn't recover from it shortly. That message comes from this bit.

https://github.com/fastlane/fastlane/blob/53ce1fab1f616b981fc80d3abd97320f65187ba7/spaceship/lib/spaceship/connect_api/models/app_screenshot.rb#L100-L115

After some investigations, I managed to replicate the similar errors locally and concluded that it was a regression caused in #16972.

https://github.com/fastlane/fastlane/issues/17243#issuecomment-700347130

Whilst #16972 gives significant performance improvements, it seemed to have a slight behaviour change when overiwrite_screenshots option is set to false.

Description

<!-- Describe your changes in detail. --> <!-- Please describe in detail how you tested your changes. -->

(This is just copied from https://github.com/fastlane/fastlane/issues/17243#issuecomment-700347130 )

https://github.com/fastlane/fastlane/blob/53ce1fab1f616b981fc80d3abd97320f65187ba7/deliver/lib/deliver/upload_screenshots.rb#L131-L148

The above check code "index >= 10" still works without "overwrite_screenshots: true" if you append images to only the end of the set. But in the scenario below, "index" will kind of make a contradiction...

Let's say we have already uploaded 6 screenshots for 6.5-inch screen like this.

1. "6.5_1.jpg" (uploaded)
2. "6.5_2.jpg" (uploaded)
3. "6.5_3.jpg" (uploaded)
4. "6.5_4.jpg" (uploaded)
5. "6.5_5.jpg" (uploaded)
6. "6.5_6.jpg" (uploaded)

And then you happen to copy another lang's 6.5inch screenshots and paste to the directory ^ those screenshots are stored. It will be like this if sorted. (This would sound weird but was the easiest way to replicate this actually.)

1. "6.5_1 copy.jpg" (local)
2. "6.5_1.jpg" (uploaded)
3. "6.5_2 copy.jpg" (local)
4. "6.5_2.jpg" (uploaded)
5. "6.5_3 copy.jpg" (local)
6. "6.5_3.jpg" (uploaded)
7. "6.5_4 copy.jpg" (local)
8. "6.5_4.jpg" (uploaded)
9. "6.5_5 copy.jpg" (local)
10. "6.5_5.jpg" (uploaded)
11. "6.5_6 copy.jpg" (local)
12. "6.5_6.jpg" (uploaded)

With the current code, it's going to pick up the first 10 images from the above list to decide "skip" or "upload", which means -

• 5 local images; "6.5_1 copy.jpg", "6.5_2 copy.jpg", "6.5_3 copy.jpg", "6.5_4 copy.jpg" and "6.5_5 copy.jpg", are going to be newly uploaded and "6.5_1.jpg", "6.5_2.jpg" , "6.5_3.jpg" , "6.5_4.jpg" , "6.5_5.jpg" are skipped
• "6.5_6 copy.jpg" and "6.5_6.jpg" will be just ignored
• Since 6 images "6.5_[1-6].jpg" have been uploaded already, at least one of those uploads must fail (it's concurrently working so can't tell which one fails)

This behaviour was covered by this initialisation of the count of existing uploaded screenshots.

https://github.com/fastlane/fastlane/blob/8c1d2c9cd894d76b29abf1fe40ef3c830e23a166/deliver/lib/deliver/upload_screenshots.rb#L140-L144

But with the refactoring of extractions of iterators, it was changed to rely only on index worked out from local data. https://github.com/fastlane/fastlane/blob/53ce1fab1f616b981fc80d3abd97320f65187ba7/deliver/lib/deliver/app_screenshot_iterator.rb#L87-L91

This PR obsoleted that index params returned from the iterator and then restore counting logic with initialising app_screenshot_set.app_screenshots.count like before.

Testing Steps

<!-- Optional: steps, commands, or code used to test your changes. --> <!-- Providing these will reduce the time needed for testing and review by the fastlane team. -->

You can test this with the scenario in the description. I also added a unit test case to cover the scenario.

Don't show analytics opt-out message on first run if the user has already opted out, regardless of whether the .did_show_opt_info file has been created on disk.

<!-- Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

Checklist

• [x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
• [x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Motivation and Context

Fixes: #16874

Description

When deciding whether to show the analytics message, previously the only thing that was considered was whether the file .did_show_opt_info exists, meaning the message had been shown before. This changes the logic to also consider whether the user has opted out (either via ENV variable or fastfile), and skips showing the message if they have, even if the file .did_show_opt_info has not been created yet.

Testing Steps

rm ~/.fastlane/.did_show_opt_info
FASTLANE_OPT_OUT_USAGE=YES fastlane

Before this patch: analytics message is displayed After this patch: analytics message is not displayed

<!-- Thanks for helping fastlane! Before you submit your issue, please make sure you followed our checklist and check the appropriate boxes by putting an x in the [ ]: [x] -->

New Issue Checklist

• [x] Updated fastlane to the latest version
• [x] I read the Contribution Guidelines
• [x] I read docs.fastlane.tools
• [x] I searched for existing GitHub issues

Issue Description

<!-- Please include what's happening, expected behavior, and any relevant code samples --> In fastlane_core, the logic that emits the message about "sending analytics" in AnalyticsSession occurs before checking whether the opt_out flag is set in AnalyticsIngesterClient. This leads the customer to believe that analytics are still being sent even when the opt_out flag is provided.

I suggest that at the very beginning of AnalyticsSession#action_launched, the first thing to do would be to check whether the opt_out flag is provided and return immediately if true.

Command executed

<!-- The command you executed on the command line that resulted in an error --> I reproduced this using the trainer command which uses fastlane internally, but it should be reproducible with any fastlane tooling:

rm ~/.fastlane/.did_show_opt_info
FASTLANE_OPT_OUT_USAGE=YES fastlane

Complete output when running fastlane, including the stack trace and command used

<!-- You can use --capture_output as the last command line argument for many commands to get that collected for you. Otherwise, please do it manually. Caution: The output of --capture_output could contain sensitive data such as application ids, certificate ids, or email addresses. Please make sure you double check the output and replace anything sensitive you don't wish to submit in the issue -->

<details> <pre> [✔] 🚀 [12:58:45]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile [12:58:49]: Sending anonymous analytics information [12:58:49]: Learn more at https://docs.fastlane.tools/#metrics [12:58:49]: No personal or sensitive data is sent. [12:58:49]: You can disable this by adding opt_out_usage at the top of your Fastfile /usr/local/lib/ruby/gems/2.7.0/gems/highline-1.7.10/lib/highline.rb:624: warning: Using the last argument as keyword parameters is deprecated [12:58:49]: Could not find fastlane in current directory. Make sure to have your fastlane configuration files inside a folder called "fastlane". Would you like to set fastlane up? (y/n) </pre> </details>

Environment

<!-- Please run fastlane env and copy the output below. This will help us help you. If you used the --capture_output option, please remove this block as it is already included there. -->

<details> <pre> <details><summary>✅ fastlane environment ✅</summary>

Stack

System Locale

fastlane files:

No Fastfile found

No Appfile found

fastlane gems

Loaded fastlane plugins:

No plugins Loaded

<details><summary><b>Loaded gems</b></summary>

</details>

generated on: 2020-07-16 </details> </pre> </details>

transform string key to symbol, since hash args in options from CLI keyed by string

<!-- Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

Checklist

• [x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
• [x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Motivation and Context

app_review_information passed into deliver from CLI is parsed to hash keyed by string but not symbol. This makes set_review_information failed.

Description

I'm not very familiar with Ruby and I haven't much time, so my solution looks a bit ugly. Better way to fix this problem is to make sure hash args in options keyed by symbol when generate options, hope maintainers can help me.

Testing Steps

I use command below to test

DELIVER_SUBMISSION_INFO='{"add_id_info_limits_tracking":true,"add_id_info_serves_ads":false,"add_id_info_tracks_action":false,"add_id_info_tracks_install":true,"add_id_info_uses_idfa":true}'

DELIVER_APP_REVIEW_INFO='{"demo_user":"xxxxx","demo_password":"xxxxx"}'

fastlane deliver submit_build --username 'email' --team_id 000000 --app_identifier 'com.xxxx.xxxx' --platform 'ios' --app_version $app_version --build_number $build_number --skip_binary_upload true --skip_screenshots true --skip_app_version_update true --automatic_release false --phased_release true --reset_ratings false --submission_information "$DELIVER_SUBMISSION_INFO" --app_review_information "$DELIVER_APP_REVIEW_INFO" --reject_if_possible true --force true

@TheWirv You should be able to switch it both ways (in my experience) but I’m there could be some secret rules that we don’t know about 🤔

So if your app has “This app has the necessary rights to its third-party content.” then maybe you need to set submission_information.content_rights_contains_third_party_content: true

This was changed up in the latest App Store Connect update so I’m personally still trying to figure out all the information about them 😬

<hr/>

But also, would you be able to run fastlane run spaceship_logs after this fails for you the next time and send me the contents of the file? It shows the raw request/response and maybe there is some more error messages in the response that we are missing that could help think 🤷‍♂️

@SEGVeenstra Thanks for reply! I haven’t tested it on Azure DevOps myself yet 🤔 Putting \n in there should work as of 2.161.0 (which it looks like you are on). I’m not sure how Azure DevOps handles the insert of multi-line test.

I don’t know if this is how you added the \n but I would maybe deleting the lines in a text editor and replacing them with \n before copying them into Azure.

Maybe we should also support a Base64 encoded key_content to prevent this issue from happening 🤔

⚠️ I had trouble installing dependencies so I wasn't able to actually test these changes locally 😬

Issue

The href inside the head for is empty because subscribe_rss isn't defined but being used in _includes/head.html

<link href="" rel="alternate" title="Artsy Engineering" type="application/atom+xml">

Solution

Define subscribe_rss and and update _includes/head.html to use root

<!-- Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

Checklist

• [x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
• [x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Motivation and Context

<!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. -->

Description

<!-- Describe your changes in detail. --> <!-- Please describe in detail how you tested your changes. -->

Testing Steps

<!-- Optional: steps, commands, or code used to test your changes. --> <!-- Providing these will reduce the time needed for testing and review by the fastlane team. -->

Ah cool! I will add this into this PR and get this out on Thursday-ish 😊 Thanks for finding the fix ❤️

@ryechus Thanks for reporting this! I think this is fixed in https://github.com/fastlane/fastlane/pull/17291 but I will verify and fix it if it isn’t 😊

This new match changes should be going out this week (maybe early Thursday morning)

@googlebot I consent.

<!-- Thanks for helping fastlane! Before you submit your issue, please make sure you followed our checklist and check the appropriate boxes by putting an x in the [ ]: [x] -->

New Issue Checklist

• [x] Updated fastlane to the latest version
• [x] I read the Contribution Guidelines
• [x] I read docs.fastlane.tools
• [x] I searched for existing GitHub issues

Issue Description

<!-- Please include what's happening, expected behavior, and any relevant code samples --> Starting around July 7th, I've been unable to use Spaceship to add new members to my team. The attempt fails with the error "Not Found". Tracing has shown this is because the iTunesConnect endpoint ra/users/itc/create returns a 404 response.

 {
  :status=>404,
  :body=>{"data"=>nil, "messages"=>{"error"=>["Not Found"], "info"=>nil, "warn"=>nil}, "statusCode"=>"ERROR"},
  ... 
}

(from calling Faraday::Response.to_hash)

Command executed

<!-- The command you executed on the command line that resulted in an error -->

I've written an internal script that includes the following.

  # app store setup (SUCCESS)
  Spaceship::Tunes.login(username, password)
  Spaceship::Tunes.select_team(team_id: team_uuid)

  # send invite (FAILS)
  Spaceship::Tunes::Members.create!(firstname: options[:firstname], lastname: options[:lastname], email_address: options[:email_address], roles: roles)

It's Spaceship::Tunes::Members.create! that results in the 404 response failure.

Complete output when running fastlane, including the stack trace and command used

<!-- You can use --capture_output as the last command line argument for many commands to get that collected for you. Otherwise, please do it manually. Caution: The output of --capture_output could contain sensitive data such as application ids, certificate ids, or email addresses. Please make sure you double check the output and replace anything sensitive you don't wish to submit in the issue -->

<details> <pre> 2: from /Users/cniles/.gems/gems/fastlane-2.154.0/spaceship/lib/spaceship/tunes/members.rb:26:in create!' 1: from /Users/cniles/.gems/gems/fastlane-2.154.0/spaceship/lib/spaceship/tunes/tunes_client.rb:542:increate_member!' /Users/cniles/.gems/gems/fastlane-2.154.0/spaceship/lib/spaceship/tunes/tunes_client.rb:232:in `handle_itc_response': Not Found (Spaceship::Tunes::Error) </pre> </details>

Environment

<!-- Please run fastlane env and copy the output below. This will help us help you. If you used the --capture_output option, please remove this block as it is already included there. -->

<details> <pre> <details><summary>✅ fastlane environment ✅</summary>

Stack

System Locale

fastlane files:

No Fastfile found

No Appfile found

fastlane gems

Loaded fastlane plugins:

No plugins Loaded

<details><summary><b>Loaded gems</b></summary>

</details>

generated on: 2020-08-04 </details> </pre> </details>

This was fixed and merged in https://github.com/fastlane/fastlane/pull/17315. This should be out in the next fastlane version this week!

<!-- Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

Checklist

• [x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
• [x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Motivation and Context

Own branch with new model: ref: https://github.com/fastlane/fastlane/pull/17305

@googlebot I consent.

@xanderbuck I think I’m going to keep this open and see if we can provide some more useful feedback when the P8 is bad 😊 I’m sure there will be more reports of this if we don’t... which is totally fair 😉

And welcome to community! So happy to have you 😊 Glad you had a good experience! Hopefully we see (and don’t see you) more 😝

@SEGVeenstra I’m glad key_filepath works but key_content should be working too! How are you trying to load it? Are you trying to load it from an environment variable or a string? One thing you will need to make sure that you do is that you keep the new lines (\n) in there.

We should actually probably catch this error and spit out something a bit more useful 🤔

<!-- Thanks for helping fastlane! Before you submit your issue, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

New Regression Checklist

• [x] Updated fastlane to the latest version
• [x] I read the Contribution Guidelines
• [x] I read docs.fastlane.tools
• [x] I searched for existing GitHub issues

Regression Information

<!-- Knowing the breaking versions and last working versions helps us track down the regression easier -->

• Breaking version: 2.161.0
• Last working version: 2.160.0

Regression Description

firebase_app_distribution action is not working since the last update: it seems that groups parameter/contents is processed case-sensitive (probably) and the firebase backend returns error. There is an issue in action repository where other developers confirms that downgrading to 2.160.0 solves their issue, so this is not a regression in the action itself. Maybe it is regressed by #17256?

Complete output when running fastlane, including the stack trace and command used

This is the regressed fastlane output: <details> <pre> [14:02:36]: --------------------------------------- [14:02:36]: --- Step: firebase_app_distribution --- [14:02:36]: --------------------------------------- [14:02:36]: Authenticating with FIREBASE_TOKEN environment variable [14:02:36]: 🔐 Authenticated successfully. [14:02:38]: ⌛ Uploading the IPA. [14:02:53]: ✅ Uploaded the IPA. [14:02:53]: ✅ No release notes passed in. Skipping this step. [14:02:53]: ------------------- [14:02:53]: --- Step: is_ci --- [14:02:53]: ------------------- [14:02:53]: -------------------------- [14:02:53]: --- Step: fastlane env --- [14:02:53]: -------------------------- ... | 💥 | firebase_app_distribution | 20 | | 49 | is_ci | 0 | | 50 | fastlane env | 2 | +------+---------------------------------------------------------------+-------------+

[09:55:34]: fastlane finished with errors

[!] Could not enable access for testers. Check that the groups exist and the tester emails are formatted correctly Emails:
Groups: ["ios-testers"] script returned exit code 1

</pre> </details>

And this is the output on 2.160.0: <details> <pre>[13:50:30]: --------------------------------------- [13:50:30]: --- Step: firebase_app_distribution --- [13:50:30]: --------------------------------------- [13:50:30]: Authenticating with FIREBASE_TOKEN environment variable [13:50:30]: 🔐 Authenticated successfully. [13:50:32]: ⌛ Uploading the IPA. [13:50:44]: ✅ Uploaded the IPA. [13:50:44]: ✅ No release notes passed in. Skipping this step. [13:50:47]: ✅ Added testers/groups. [13:50:47]: 🎉 App Distribution upload finished successfully. [13:50:47]: ------------------------------------------- [13:50:47]: --- Step: upload_symbols_to_crashlytics --- [13:50:47]: ------------------------------------------- </pre> </details>

There is no difference in Fastfile between these two launches. They both call

		firebase_app_distribution(app: app_id, groups: "ios-testers", debug: true)	

Environment

<details><summary>✅ fastlane environment ✅</summary>

Stack

System Locale

fastlane gems

Loaded fastlane plugins:

<details><summary><b>Loaded gems</b></summary>

</details> generated on: 2020-09-29 </details>

Hello! We've started getting 400 errors right after 0.2.2 update:

[20:07:57]: ---------------------------------------
[20:07:57]: --- Step: firebase_app_distribution ---
[20:07:57]: ---------------------------------------
[20:07:57]: Authenticating with GOOGLE_APPLICATION_CREDENTIALS environment variable: /home/circleci/google-service-account.json
[20:07:57]: 🔐 Authenticated successfully.
[20:07:57]: ⌛ Uploading the APK.
[20:08:03]: ✅ Uploaded the APK.
+------------------+---------+
|        Lane Context        |
+------------------+---------+
| DEFAULT_PLATFORM | android |
| PLATFORM_NAME    |         |
| LANE_NAME        | beta    |
+------------------+---------+
[20:08:03]: the server responded with status 400

+------+----------------------------+-------------+
|                fastlane summary                 |
+------+----------------------------+-------------+
| Step | Action                     | Time (in s) |
+------+----------------------------+-------------+
| 1    | opt_out_usage              | 0           |
| 2    | Verifying fastlane version | 0           |
| 3    | default_platform           | 0           |
| 💥   | firebase_app_distribution  | 6           |
+------+----------------------------+-------------+

[20:08:03]: fastlane finished with errors

Looking for related GitHub issues on fastlane/fastlane...

➡️  Distribute to hockeyapp suddenly failing
    https://github.com/fastlane/fastlane/issues/400 [closed] 8 💬
    22 Sep 2016

➡️  Uploading assets with a GitHub release fails in `set_github_release`
    https://github.com/fastlane/fastlane/issues/9922 [closed] 5 💬
    18 Nov 2017

➡️  Deliver: Segmentation fault after completing
    https://github.com/fastlane/fastlane/issues/10479 [closed] 16 💬
    10 May 2018

and 1 more at: https://github.com/fastlane/fastlane/search?q=the%20server%20responded%20with%20status%20400&type=Issues&utf8=✓

bundler: failed to load command: fastlane (/home/circleci/.rubies/ruby-2.6.1/bin/fastlane)
Faraday::BadRequestError: [!] the server responded with status 400
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/faraday-1.0.1/lib/faraday/response/raise_error.rb:16:in `on_complete'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/faraday-1.0.1/lib/faraday/response.rb:12:in `block in call'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/faraday-1.0.1/lib/faraday/response.rb:65:in `on_complete'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/faraday-1.0.1/lib/faraday/response.rb:11:in `call'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/faraday_middleware-1.0.0/lib/faraday_middleware/response_middleware.rb:36:in `call'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/faraday-1.0.1/lib/faraday/rack_builder.rb:153:in `build_response'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/faraday-1.0.1/lib/faraday/connection.rb:492:in `run_request'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/faraday-1.0.1/lib/faraday/connection.rb:279:in `post'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-plugin-firebase_app_distribution-0.2.2/lib/fastlane/plugin/firebase_app_distribution/client/firebase_app_distribution_api_client.rb:68:in `post_notes'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-plugin-firebase_app_distribution-0.2.2/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb:37:in `run'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/runner.rb:263:in `block (2 levels) in execute_action'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/actions/actions_helper.rb:69:in `execute_action'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/runner.rb:255:in `block in execute_action'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/runner.rb:229:in `chdir'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/runner.rb:229:in `execute_action'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
  Fastfile:10:in `block in parsing_binding'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/lane.rb:33:in `call'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/lane_manager.rb:47:in `cruise_lane'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/commands_generator.rb:352:in `run'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
  /home/circleci/.rubies/ruby-2.6.1/lib/ruby/gems/2.6.0/gems/fastlane-2.161.0/bin/fastlane:23:in `<top (required)>'
  /home/circleci/.rubies/ruby-2.6.1/bin/fastlane:23:in `load'
  /home/circleci/.rubies/ruby-2.6.1/bin/fastlane:23:in `<top (required)>'

+-------------------------------------------+---------+---------------------------------+
|                                     Used plugins                                      |
+-------------------------------------------+---------+---------------------------------+
| Plugin                                    | Version | Action                          |
+-------------------------------------------+---------+---------------------------------+
| fastlane-plugin-firebase_app_distribution | 0.2.2   | firebase_app_distribution       |
|                                           |         | firebase_app_distribution_login |
+-------------------------------------------+---------+---------------------------------+

Any ideas on these? I'll provide additional information if necessary.

@SerhiiMatvieiev No need to downgrade anymore! You can upgrade the firebase plugin to 0.2.3 (that has the fix in it)

Of course! Thanks again ❤️

Thank you! Really appreciate the quick response 🙌

@lfkellogg That would be great! I texted Stefan but I know he is off today so if you could build and push to Rubygems that would be 🔥

Need to release - https://github.com/fastlane/fastlane-plugin-firebase_app_distribution/releases/tag/v0.2.3

@tagboola @lfkellogg Would either of you be able to release v0.2.3 to Ruby gems? A fix is in (and tested) and version is bumped.

I don’t have access to fastlane-plugin-firebase_app_distribution but I’ve requested access from @snatchev (whenever he is able to give it to me). Not sure if either of you would be able to add me (joshdholtz) but if you could that would be ❤

Fixed in https://github.com/fastlane/fastlane-plugin-firebase_app_distribution/pull/160 by @brownoxford ❤️ I will comment when the new gem is out.

Fixed in https://github.com/fastlane/fastlane-plugin-firebase_app_distribution/pull/160 by @brownoxford ❤️ I will comment when the new gem is out.

Yup yup! I’m working on a fix for exactly that 😊

@sbo-nemlig @brownoxford Yup yup, I’m working on a fix for this right now! I’ll keep you all updated when I have something ready

I think this might be the cause - https://github.com/fastlane/fastlane/pull/17218

This was a fix to another problem but it looks the firebase plugin might have been relying on this 🤔 I’m unsure but that is what I’m going to look into first.

Looking into the issue! Will hopefully have a solution soon.

Looking into what could have caused this! Will try to have a fix soon.

Thank you!

@xanderbuck Can you create a new issue and mention me in it?

Oh goodness! I don't know if your results make me feel better or worse 😝

I'll try to replicate on my side and see which of these errors (if any) I get 😬

@john-mejia Greatly appreciated it! I won't be able to look in to anymore today (I got some family stuff to do) but I will look into tomorrow (or Wednesday at latest) for you!

@john-mejia Oh interesting.... Can you create a new issue for that and mention me in it? That does sound like a regression that I might have missed 😬

@robmaceachern Making meta data empty and setting skip to false is the correct work around right now 🤔 I'll look into moving this outside of metadata though! I just need to make sure its backwards compatible enough to make that change 😬

Created with brew bump-formula-pr.

Auto-generated by fastlane bot 🤖

@john-mejia It shouldn't have stopped persisting 😬 I don't have any issues over here with mine persisting 🤔 But there are to things at play here.

1. The session is stored in ~/.fastlane/spaceship/<email> directory
   • There could be some issue with this not getting stored? Maybe?
2. The password for you Apple ID is stored in Keychain access
   • This is what gets looked at after the session expires and you enter your email address. If you are relying on your password to be entered automatically and its not reading from here, your keychain may not be unlocked? Maybe?

Auto-generated by fastlane 🤖

Changes since release '2.160.0':

• [action] add file ignore param for ensure_git_status_clean (#17115) via Devzhr
• [action[ set http request read_timeout to 300 seconds for download_dsyms (#17262) via Pranav Raj
• [Fastlane.swift] fix crash in LaneFileProtocol.swift when executing fastlane Swift without using SPM (#17276) via Roger Oba
• [docs] update AppStoreConnect.md (#17319) via Fernando
• [docs] fix typos in documentation across the board (#17324) via Roger Oba
• [pilot] make key contents sensitive (#17256) via Roger Oba
• [action] fixed issue in app_store_connect_api_key with loading key content from env variable (#17322) via Josh Holtz
• [spaceship] checks is not nil on Spaceship::ConnectAPI.patch_app (#17261) via Abraão Levi de Oliveira Figueredo
• [spaceship] modify Net::HTTPGenericRequest monkeypatch so that only Apple domains are affected (#17218) via Ash Tyndall

Auto-generated by fastlane 🤖

Changes since release '2.160.0':

• [action] add file ignore param for ensure_git_status_clean (#17115) via Devzhr
• Set http request read_timeout to 300 seconds (#17262) via Pranav Raj
• [Fastlane.swift] fix crash in LaneFileProtocol.swift when executing fastlane Swift without using SPM (#17276) via Roger Oba
• Update AppStoreConnect.md (#17319) via Fernando
• [documentation] fix typos in documentation across the board (#17324) via Roger Oba
• [pilot] make key contents sensitive (#17256) via Roger Oba
• [action] fixed issue in app_store_connect_api_key with loading key content from env variable (#17322) via Josh Holtz
• [spaceship] checks is not nil on Spaceship::ConnectAPI.patch_app (#17261) via Abraão Levi de Oliveira Figueredo
• Modify Net::HTTPGenericRequest monkeypatch so that only Apple domains are affected (#17218) via Ash Tyndall

<!-- Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

Checklist

• [x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
• [x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Motivation and Context

<!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. -->

Description

<!-- Describe your changes in detail. --> <!-- Please describe in detail how you tested your changes. -->

Testing Steps

<!-- Optional: steps, commands, or code used to test your changes. --> <!-- Providing these will reduce the time needed for testing and review by the fastlane team. -->

<!-- Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

Checklist

• [x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
• [x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Motivation and Context

Refer to this: #17252 <!-- If it fixes an open issue, please link to the issue here. -->

Description

<!-- Describe your changes in detail. --> Have increased the read_timeout from the default 60s to 300s. <!-- Please describe in detail how you tested your changes. -->

Testing Steps

<!-- Optional: steps, commands, or code used to test your changes. --> <!-- Providing these will reduce the time needed for testing and review by the fastlane team. --> Ran bundle exec fastlane test command which ran successfully.

New Regression Checklist

• [x] Updated fastlane to the latest version
• [x] I read the Contribution Guidelines
• [x] I read docs.fastlane.tools
• [x] I searched for existing GitHub issues

Regression Information

• Breaking version: 2.159.0
• Last working version: 2.158.0

Regression Description

Running fastlane Swift without using SPM crashes with the error:

… Fatal error: Unexpectedly found nil while unwrapping an Optional value: file /Users/rogerluan/Documents/Projects/tellus-ios/fastlane/swift/LaneFileProtocol.swift, line 121 … 784: unexpected token at '' …

Note that this was only possible after fixing some issues according to this comment: https://github.com/fastlane/fastlane/issues/17234#issuecomment-695099513

Complete output when running fastlane, including the stack trace and command used

<!-- You can use: --capture_output as the last commandline argument to get that collected for you -->

<!-- The output of --capture_output could contain sensitive data such as application ids, certificate ids, or email addresses, Please make sure you double check the output and replace anything sensitive you don't wish to submit in the issue -->

<details> <pre>[18:59:41]: ▸ Fatal error: Unexpectedly found nil while unwrapping an Optional value: file /Users/rogerluan/Documents/Projects/tellus-ios/fastlane/swift/LaneFileProtocol.swift, line 121 #<Thread:0x00007fa552614988@/Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/swift_lane_manager.rb:220 run> terminated with exception (report_on_exception is true): Traceback (most recent call last): 9: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/swift_lane_manager.rb:223:in block in start_socket_thread' 8: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/server/socket_server.rb:38:instart' 7: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/server/socket_server.rb:158:in listen' 6: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/server/socket_server.rb:49:inreceive_and_process_commands' 5: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/server/socket_server.rb:49:in loop' 4: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/server/socket_server.rb:62:inblock in receive_and_process_commands' 3: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/server/socket_server.rb:81:in parse_and_execute_command' 2: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/server/command_parser.rb:12:inparse' 1: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/json-2.3.1/lib/json/common.rb:263:in parse' /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/json-2.3.1/lib/json/common.rb:263:inparse': 784: unexpected token at '' (JSON::ParserError) [18:59:41]: ▸ sh: line 1: 37728 Illegal instruction: 4 ./fastlane/FastlaneRunner lane submit version 2.30.14 swiftServerPort 2000 > /dev/null #<Thread:0x00007fa552637e10@/Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/swift_lane_manager.rb:96 run> terminated with exception (report_on_exception is true): Traceback (most recent call last): 4: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/swift_lane_manager.rb:97:in block in cruise_swift_lane_in_thread' 3: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/helper/sh_helper.rb:12:insh' 2: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane/lib/fastlane/helper/sh_helper.rb:80:in sh_control_output' 1: from /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane_core/lib/fastlane_core/ui/ui.rb:17:inmethod_missing' /Users/rogerluan/Documents/Projects/tellus-ios/.vendor/ruby/2.6.0/gems/fastlane-2.160.0/fastlane_core/lib/fastlane_core/ui/interface.rb:153:in `shell_error!': Exit status of command './fastlane/FastlaneRunner lane submit version 2.30.14 swiftServerPort 2000 > /dev/null' was 132 instead of 0. (FastlaneCore::Interface::FastlaneShellError) Fatal error: Unexpectedly found nil while unwrapping an Optional value: file /Users/rogerluan/Documents/Projects/tellus-ios/fastlane/swift/LaneFileProtocol.swift, line 121 sh: line 1: 37728 Illegal instruction: 4 ./fastlane/FastlaneRunner lane submit version 2.30.14 swiftServerPort 2000 > /dev/null +-----------+--------+ | Lane Context | +-----------+--------+ | LANE_NAME | submit | +-----------+--------+ [18:59:41]: 784: unexpected token at '' [18:59:41]: fastlane finished with errors </pre> </details>

Environment

<!-- Please run fastlane env and copy the output below. This will help us help you :+1: If you used --capture_output option, please remove this block as it is already included there. -->

<details> <pre><details><summary>✅ fastlane environment ✅</summary>

Stack

System Locale

fastlane files:

<details><summary>./fastlane/Fastfile.swift</summary>

<redacted>

</details>

No Appfile found

fastlane gems

Loaded fastlane plugins:

No plugins Loaded

<details><summary><b>Loaded gems</b></summary>

</details>

generated on: 2020-09-18 </details></pre> </details>

transform_keys is only available in Ruby 2.5 and up so we need to do something a little bit more manual here 😬

      info = options[:app_review_information]
      info = info.collect { |k, v| [k.to_sym, v] }.to_h

🔑

Checklist

• [x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
• [x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• [x] I've read the Contribution Guidelines
• [x] I've updated the documentation if necessary.

Motivation and Context

I've noticed a few typos every now and then and decided to scan the whole project looking for them.

Description

Vale was used to look for them, and although I scanned all files, I feel like code comments were probably left behind 😛 but still caught a few typos here and there.

Testing Steps

N/A

@mogbot @myanime Ahhhhh, I think there are issues with this when its an "Apple Arcade" app and also "pre-order" 😱

I will look into how to best fix this while providing backwards capability for other users 🤔 Yell at me if you don't hear from me in a day or two 😉

@TheWirv I wish we could have gotten back a more useful error from the API there. Did you have any issues showing to you in the dashboard at all when submitting?

Your logs showed that it failed during the update of submission information (which is 👇 from your logs above)

submission_information.add_id_info_limits_tracking                         | false                                                                             |
| submission_information.add_id_info_serves_ads                              | false                                                                             |
| submission_information.add_id_info_tracks_action                           | false                                                                             |
| submission_information.add_id_info_tracks_install                          | false                                                                             |
| submission_information.add_id_info_uses_idfa                               | false                                                                             |
| submission_information.content_rights_has_rights                           | false                                                                             |
| submission_information.content_rights_contains_third_party_content         | false                                                                             |
| submission_information.export_compliance_platform                          | ios                                                                               |
| submission_information.export_compliance_compliance_required               | false                                                                             |
| submission_information.export_compliance_encryption_updated                | false                                                                             |
| submission_information.export_compliance_uses_encryption                   | false                                                                             |
| submission_information.export_compliance_is_exempt                         | false                                                                             |
| submission_information.export_compliance_contains_third_party_cryptography | false                                                                             |
| submission_information.export_compliance_contains_proprietary_cryptography | false                                                                             |
| submission_information.export_compliance_available_on_french_store         | false

Is this all true? Did you have to adjust any of these settings when you submitted through the dashboard?

And future thanks for answering my questions 😊

Is this still an issue that you are consistently receiving? I'm not really sure what could be causing this be the looks of those logs 😔

I'm not sure if this is something you are able to run but running fastlane run spaceship_logs after this failure and sending me that file would be a big help here (if you are able to get it). Its the raw API requests and responses.

@Panajev I believe this is temporary issue. If you could try uploading again and/or use a different provider (👇) that would be great!

# Available options are: DAV, Aspera, Signiant
DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS=-t Aspera

@strongbox-mark @john-mejia I think this might be because you have skip_metadata: true 🤔 This is technically metadata so that needs to be false in order for it to update 😬