profile
viewpoint
Josep M Sobrepere josepot @AdaptiveConsulting Barcelona

AdaptiveConsulting/ReactiveTraderCloud 1477

Real-time FX trading showcase by Adaptive.

josepot/grid-styletr 5

Responsive React grid system built with styletron-react

AnnaKanska/stock-tracker-react-redux 1

Application allows you to select a specific stock and see information pertaining to it.

josepot/angularjs-book 1

Examples and Code snippets from the AngularJS O'Reilly book

josepot/AoC-2018 1

Advent of Code 2018

josepot/hn-react-redux 1

WIP submission for https://hnpwa.com

startedGoogleChrome/web-vitals

started time in 12 hours

push eventAdaptiveConsulting/ReactiveTraderCloud

Josep M Sobrepere

commit sha 8e276e32d32c14c093fd5217cd34c05134b24572

Update snapshot

view details

push time in 3 days

PR opened krausest/js-framework-benchmark

Upgrade dependencies on react contributions

Hi and thanks a lot for creating and maintaining this project!

I'm about to make a contribution for "react-rxjs" and I thought that maybe it's a good idea to first upgrade all react-based contributions so that they use the latest version of their own library and the latest stable version of React.

Regarding react-mobx though, I have been able to upgrade to React 17.0.1 without any issues. However, I did notice that there are newer versions of both mobx and mobx-react, but I haven't been able to upgrade those 2 because there are breaking changes and I don't want to mess with its implementation.

If you rather handle these upgrades yourself, no worries, I totally get it. When I send the react-rxjs contribution I will be using the same version of React 16 that all the other ones are using and I will upgrade when the other ones upgrade. Thanks!

+5628 -2899

0 comment

18 changed files

pr created time in 3 days

push eventjosepot/js-framework-benchmark

Josep M Sobrepere

commit sha 7e25f2691dff088b531bca0d5c87e3b09e4f3e66

chore(keyed/react-easy-state): upgrade dependencies

view details

Josep M Sobrepere

commit sha 8981b460bbf81905e243db6a2139a7fd83257957

chore(keyed/react-hooks): upgrade dependencies

view details

Josep M Sobrepere

commit sha efe5218e4f326f2da94ddaa534da0eebb35eb2bb

chore(keyed/react-mobX): upgrade dependencies

view details

Josep M Sobrepere

commit sha 4b1bc5383aef4edc25aee912f6c314720b3650be

chore(keyed/react-redux): upgrade dependencies

view details

Josep M Sobrepere

commit sha cc6b5fbda68d2524d1ac3cf211627d767de43093

chore(keyed/react-redux-hooks): upgrade dependencies

view details

Josep M Sobrepere

commit sha 2e1ae4ac7e3ec0b7821cdc88cabe4bf343f407e6

chore(keyed/react-tracked): upgrade dependencies

view details

Josep M Sobrepere

commit sha db13ab45a1801f919676ed5e8c9ae9d92d18dbed

chore(keyed/reaml-react): upgrade dependencies

view details

Josep M Sobrepere

commit sha 456a4fd834993439ec07378f9b0c8f3b420bae4a

chore(keyed/reason-react): upgrade dependencies

view details

push time in 4 days

push eventjosepot/js-framework-benchmark

Josep M Sobrepere

commit sha ef1aab8a69ed19731f6157ff90a6c63d446baa0d

chore(keyed/react): upgrade dependencies

view details

Josep M Sobrepere

commit sha 5650f158767446c14471a6b6e2b789d400d8c7af

chore(keyed/react-easy-state): upgrade dependencies

view details

Josep M Sobrepere

commit sha 0f7faff624c36a149b0f10ab3d7debc5e3546008

chore(keyed/react-hooks): upgrade dependencies

view details

Josep M Sobrepere

commit sha 91e7b898981a2f39ab3d2dcab788cb65fbd48512

chore(keyed/react-mobX): upgrade dependencies

view details

Josep M Sobrepere

commit sha 76f93df78c3ac9532e964e8433506279af0b2753

chore(keyed/react-redux): upgrade dependencies

view details

Josep M Sobrepere

commit sha e9cf7953a1c71e04a348cec229140f81cff67a17

chore(keyed/react-redux-hooks): upgrade dependencies

view details

Josep M Sobrepere

commit sha 66e4926b8b1547c01d192191b307ac23fc84d6ea

chore(keyed/react-tracked): upgrade dependencies

view details

Josep M Sobrepere

commit sha 3f68c75989fd1a9e0ccf4adff265b0b74fbc10a2

chore(keyed/reaml-react): upgrade dependencies

view details

Josep M Sobrepere

commit sha 11bf4d46b13ecf783e19367001bd0ea0c46e274b

chore(keyed/reason-react): upgrade dependencies

view details

push time in 4 days

create barnchjosepot/js-framework-benchmark

branch : upgrade-react-libraries

created branch time in 4 days

startedDylanVann/perfect-dark-mode

started time in 5 days

delete branch AdaptiveConsulting/ReactiveTraderCloud

delete branch : fix-tradebutton-colors

delete time in 5 days

push eventAdaptiveConsulting/ReactiveTraderCloud

Mark Bekker

commit sha e7505a74270ce3a90dd16d0e21983e49b576ca4a

fixed tradebutton colors

view details

Mark-Adaptive

commit sha ed301994a6459d9fbfac78a24b9d368d8889c6ec

Updated snapshots

view details

Mark-Adaptive

commit sha 6cf35e5efca25538bc8f84e38784cb280120c11f

fixed tests

view details

Mark-Adaptive

commit sha df8958b8fb0a6e7e724298db0c3be2de6ac74ee6

Tile testing

view details

Josep M Sobrepere

commit sha f8e0618937f6c74e2e7d295744472f53ed9d2266

Update snapshot

view details

push time in 5 days

PR merged AdaptiveConsulting/ReactiveTraderCloud

fixed tradebutton colors

The lines that I removed where overwriting the pre-existing hover behavior of the trade buttons which is the desired behavior (sell button turns red on hover and buy button turns blue on hover). I simply removed those lines and now the desired behavior is achieved according to the zeplin mocks. image image

+98 -141

4 comments

3 changed files

Mark-Adaptive

pr closed time in 5 days

Pull request review commentReactiveX/rxjs

refactor: Predicate types

+/** @prettier */ import { Observable } from '../Observable'; import { EmptyError } from '../util/EmptyError';-import { OperatorFunction } from '../../internal/types';+import { OperatorFunction, TruthyTypesOf } from '../types'; import { filter } from './filter'; import { takeLast } from './takeLast'; import { throwIfEmpty } from './throwIfEmpty'; import { defaultIfEmpty } from './defaultIfEmpty'; import { identity } from '../util/identity'; -/* tslint:disable:max-line-length */-export function last<T, D = T>(-  predicate?: null,-  defaultValue?: D-): OperatorFunction<T, T | D>;+export function last<T>(predicate: BooleanConstructor): OperatorFunction<T, TruthyTypesOf<T>>;+export function last<T, D>(predicate: BooleanConstructor, defaultValue: D): OperatorFunction<T, TruthyTypesOf<T> | D>;+export function last<T, D = T>(predicate?: null, defaultValue?: D): OperatorFunction<T, T | D>;

Ups sorry! I misread the implementation... I thought that it was doing filter(identity) when the predicate was not provided (which wouldn't make any sense, ofc) and it's actually doing just identity. Sorry about that!

benlesh

comment created time in 5 days

PullRequestReviewEvent

push eventAdaptiveConsulting/ReactiveTraderCloud

Josep M Sobrepere

commit sha 59856a89d02d35e4eeb6414739c4cb90f244d3f7

Update snapshot

view details

push time in 5 days

push eventjosepot/js-framework-benchmark

Robert Kempton

commit sha d0d133eac825cfcbb7e522a9939da970e9cce8f2

use faster select row impl

view details

Robert Kempton

commit sha b6f85298d3f177882387585de19c5838641b7034

revert tr use, remove extra classname change

view details

Lucas Segurado

commit sha ba779054f0cfc5bd7ca0d63acdafb16a74def051

Add LS-Element

view details

Lucas Segurado

commit sha 04c79fbfca7d10a64caa09e0ca03511ef9815717

Minor change

view details

Lucas Segurado

commit sha a3dfb9b170b8613d9f4b16b602d227212aacf614

Updated LS-Element library to latest version

view details

Lucas Segurado

commit sha ee6e8d1363c68b3e83155c72a49b745e7589c88b

Removed store

view details

Lucas Segurado

commit sha 0f2de599825577ef9aebdd2b8c3bf457d4861910

Removed unnecesary dependencies

view details

Lucas Segurado

commit sha b7a71bc50cf564e63ff769573bd3f510e4988484

Fixed bug for remove item

view details

Lucas Segurado

commit sha cc6e6a7375e20de0c8e3a09663a548db4be62326

Updated package.json as required

view details

TheComputerM

commit sha f5f9b50aab6377c7681d7032e7fd515f56a01212

updated svelte to v3.28.0

view details

Lucas Segurado

commit sha 5af324b330219e5019e658b9ef0237a243ebb4b1

Updated to last version

view details

Lucas Segurado

commit sha 80ed420e8d1c694b750a7d4cf7e0862d1b7b716c

Updated to last version

view details

Juan Aguilar Santillana

commit sha 1fc145c735eb400c6c2853425a7bab774c2833b2

Rename yarte_wasm_app to delorean and update

view details

Stefan Krause

commit sha 18d79b286b19f687d72f78ee6ce76c5e7df41463

fix react swap rows edge case

view details

Stefan Krause

commit sha f1347fb2e79d247da14a5f1a228d864423da8bd7

remove keyed/non-keyed suffix

view details

Stefan Krause

commit sha 66389ed903b60436a3057b78112b35d813bf6282

clean up webdriver-ts directory

view details

Stefan Krause

commit sha 77e120f97eaf2c69321b836016b25d1f2bba60c9

results for chrome 86

view details

Stefan Krause

commit sha 1e2b48376b2252b46393a28347f3ec5dc20259eb

Merge branch 'master' of https://github.com/lsegurado/js-framework-benchmark into lsegurado-master

view details

Stefan Krause

commit sha aaf04b6a72d26b2bc145a1e21ac30ecc1d56fb30

fix missing click event

view details

Stefan Krause

commit sha 93a1a375c88d411c26df548db40060b4a4ff1839

Merge branch 'lsegurado-master' into master

view details

push time in 6 days

create barnchjosepot/js-framework-benchmark

branch : react-rxjs

created branch time in 6 days

PR opened re-rxjs/react-rxjs

Reviewers
chore(deps): upgrade dependencies

While I'm happy to see that all our tests are pass on React 17, I think that we should have a way to run our tests against different versions of react & rxjs... I wonder what the best way to go about that would be 🤔 @voliva any ideas?

+1737 -1420

0 comment

5 changed files

pr created time in 6 days

create barnchre-rxjs/react-rxjs

branch : chore/upgrade-dependencies

created branch time in 6 days

Pull request review commentReactiveX/rxjs

refactor: Predicate types

+/** @prettier */ import { Observable } from '../Observable'; import { EmptyError } from '../util/EmptyError';-import { OperatorFunction } from '../../internal/types';+import { OperatorFunction, TruthyTypesOf } from '../types'; import { filter } from './filter'; import { takeLast } from './takeLast'; import { throwIfEmpty } from './throwIfEmpty'; import { defaultIfEmpty } from './defaultIfEmpty'; import { identity } from '../util/identity'; -/* tslint:disable:max-line-length */-export function last<T, D = T>(-  predicate?: null,-  defaultValue?: D-): OperatorFunction<T, T | D>;+export function last<T>(predicate: BooleanConstructor): OperatorFunction<T, TruthyTypesOf<T>>;+export function last<T, D>(predicate: BooleanConstructor, defaultValue: D): OperatorFunction<T, TruthyTypesOf<T> | D>;+export function last<T, D = T>(predicate?: null, defaultValue?: D): OperatorFunction<T, T | D>;

What about?

export function last<T, D = TruthyTypesOf<T>>(predicate?: null, defaultValue?: D): OperatorFunction<T, TruthyTypesOf<T> | D>;

I'm not sure, though :thinking:

benlesh

comment created time in 6 days

PullRequestReviewEvent

startedvoliva/react-reactive-form

started time in 6 days

pull request commentReactiveX/rxjs

feat(filter): improve type inference for filter(Boolean)

Yup, fair enough. I agree. Please revert and let's pretend that this never happened :sweat_smile: Thanks!

josepot

comment created time in 6 days

pull request commentReactiveX/rxjs

feat(filter): improve type inference for filter(Boolean)

right, because false type is boolean, if it had been of(false as const).pipe(filter(Boolean)) then the expected type would have been Observable<never>... I don't know, I won't feel bad if you revert the commit, but IMO that kinda makes sense :shrug:

josepot

comment created time in 6 days

Pull request review commentReactiveX/rxjs

feat(filter): improve type inference for filter(Boolean)

 import { OperatorSubscriber } from './OperatorSubscriber';  /* tslint:disable:max-line-length */ export function filter<T, S extends T>(predicate: (value: T, index: number) => value is S, thisArg?: any): OperatorFunction<T, S>;-// NOTE(benlesh): T|null|undefined solves the issue discussed here: https://github.com/ReactiveX/rxjs/issues/4959#issuecomment-520629091-export function filter<T>(predicate: BooleanConstructor): OperatorFunction<T | null | undefined, NonNullable<T>>;+export function filter<T>(+  predicate: BooleanConstructor+): OperatorFunction<T, T extends null | undefined | false | 0 | -0 | 0n | '' ? never : T>;

What about?

type Falsy = null | undefined | false | 0 | -0 | 0n | "";

type NonFalsy<T> = T extends Falsy ? never : T;
type NonTruthy<T> = T extends Falsy ? T : never;

Would that be helpful anywhere else? I wouldn't mind working on that PR.

josepot

comment created time in 6 days

PullRequestReviewEvent

delete branch josepot/rxjs

delete branch : feat/filter-boolean-type

delete time in 6 days

PR opened dai-shi/will-this-react-global-state-work-in-concurrent-mode

chore: re-rxjs -> react-rxjs

Hi @dai-shi

Lots of things happened since I first opened the PR for re-rxjs. Since then the library has been renamed to react-rxjs and the API has changed a bit. So, in this PR I'm using the latest version of @react-rxjs/core and I'm changing the references to the new name and website. I hope that's ok.

Thanks!

+199 -204

0 comment

6 changed files

pr created time in 6 days

pull request commentfacebook/react

useRef: Warn about reading or writing mutable values during render

We could change the warning semantics to only warn on read if the ref was mutated after being initialized (not including lazy-init pattern). The danger there is that maybe there's a code path that triggers a second mutation that just doesn't run often. Maybe you'd rarely or never see it in dev. So you have a false sense of confidence that your component is safe, when really there's an unsafe read that might cause a bug in production if this infrequent code path gets triggered.

Sorry, my intention was not to criticize the work done on this PR. I agree that it's better to err on the side of caution.

I made that comment because I wasn't sure if you were proposing those alternatives because you deemed the original code to be unsafe or because you wanted to highlight alternative implementations that accomplished the same thing while avoiding warnings.

Thanks a lot for clarifying that.

bvaughn

comment created time in 6 days

pull request commentfacebook/react

useRef: Warn about reading or writing mutable values during render

The reason that sandbox would warn with the semantics on this PR is not because of the lazy init pattern, but because of the read further down on line 60 (passing ref.current to createPortal).

But since that ref would always yield the same value, that would be a "false positive", correct? I mean, as long as the render function always behaves the same for the same props, state and context, then it's ok to read a value from a ref, right?

bvaughn

comment created time in 6 days

created tagre-rxjs/react-rxjs

tag@react-rxjs/core@0.5.0

React bindings for RxJS

created time in 6 days

release re-rxjs/react-rxjs

@react-rxjs/core@0.5.0

released time in 6 days

delete branch re-rxjs/react-rxjs

delete branch : release/core@0.5.0

delete time in 6 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 31aba858a1095454f29ff984f00a9d84308c3936

release: core@0.5.0

view details

push time in 6 days

PR merged re-rxjs/react-rxjs

release: core@0.5.0
+3 -3

1 comment

3 changed files

josepot

pr closed time in 6 days

PR opened re-rxjs/react-rxjs

release: core@0.5.0
+3 -3

0 comment

3 changed files

pr created time in 6 days

create barnchre-rxjs/react-rxjs

branch : release/core@0.5.0

created branch time in 6 days

delete branch re-rxjs/react-rxjs

delete branch : feat/default-val

delete time in 6 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha ca95e6a80fbc5bd1fdf09a6ecd2a682821bc4cf5

feat(core): default value on bind

view details

push time in 6 days

PR merged re-rxjs/react-rxjs

feat(core): default value on bind

I can't wait to get this in!! 😬

+120 -16

1 comment

7 changed files

josepot

pr closed time in 6 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 5edc2bf8023867cc9978f64c0f30b284aca3e851

feat(core): default value on bind

view details

push time in 6 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 3e42190415222ba2ad4bce64c499381119fcb73d

feat(core): default value on bind

view details

push time in 6 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 14398b3509e195fdce1a89dede0915caef8d4836

fix(core/bind): avoid triggering SUSPENSE when the stream emits synchronously

view details

Josep M Sobrepere

commit sha 2780e1740adcd4e60904b20eae6cbd801570954a

chore(core): decrease bundle-size

view details

Josep M Sobrepere

commit sha 09fde4b9ac80ef26ad1a96167a9a4dd6b2490fc1

release: core@0.4.5

view details

Josep M Sobrepere

commit sha 2c0372efeb6e202cf7dbbea2239ba5b7fc83d765

feat(core): default value on bind

view details

push time in 6 days

created tagre-rxjs/react-rxjs

tag@react-rxjs/core@0.4.5

React bindings for RxJS

created time in 6 days

release re-rxjs/react-rxjs

@react-rxjs/core@0.4.5

released time in 6 days

delete branch re-rxjs/react-rxjs

delete branch : release/core@0.4.5

delete time in 6 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 09fde4b9ac80ef26ad1a96167a9a4dd6b2490fc1

release: core@0.4.5

view details

push time in 6 days

PR merged re-rxjs/react-rxjs

release: core@0.4.5
+3 -3

1 comment

3 changed files

josepot

pr closed time in 6 days

PR opened re-rxjs/react-rxjs

release: core@0.4.5
+3 -3

0 comment

3 changed files

pr created time in 6 days

create barnchre-rxjs/react-rxjs

branch : release/core@0.4.5

created branch time in 6 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 2780e1740adcd4e60904b20eae6cbd801570954a

chore(core): decrease bundle-size

view details

push time in 6 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha a03e9362ca976df5070980b8dc7ab6c48e22e5ba

chore(core): decrease bundle-size

view details

push time in 6 days

PR opened re-rxjs/react-rxjs

Reviewers
chore(core): decrease bundle-size
+15 -7

0 comment

4 changed files

pr created time in 6 days

create barnchre-rxjs/react-rxjs

branch : chore/small-improvements

created branch time in 6 days

delete branch re-rxjs/react-rxjs

delete branch : fix/sync-observables

delete time in 6 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 14398b3509e195fdce1a89dede0915caef8d4836

fix(core/bind): avoid triggering SUSPENSE when the stream emits synchronously

view details

push time in 6 days

PR opened re-rxjs/react-rxjs

Reviewers
fix(core/bind): avoid triggering SUSPENSE when the stream emits synch…

…ronously

+22 -2

0 comment

2 changed files

pr created time in 6 days

create barnchre-rxjs/react-rxjs

branch : fix/sync-observables

created branch time in 6 days

Pull request review commentReactiveX/rxjs

feat(filter): improve type inference for filter(Boolean)

 it('should support Boolean as a predicate', () => { // https://github.com/ReactiveX/rxjs/issues/4959#issuecomment-520629091 it('should support inference from a return type with Boolean as a predicate', () => {   interface I {-    a: string | null;+    a: string | null | undefined | false | 0 | -0 | 0n | '';

Done, thanks!

josepot

comment created time in 11 days

PullRequestReviewEvent

push eventjosepot/rxjs

Josep M Sobrepere

commit sha 051ad3417af5a5e2adcf40c471cc6f52133d2122

feat(filter): improve type inference for filter(Boolean)

view details

push time in 11 days

Pull request review commentReactiveX/rxjs

feat(filter): improve type inference for filter(Boolean)

 it('should support Boolean as a predicate', () => { // https://github.com/ReactiveX/rxjs/issues/4959#issuecomment-520629091 it('should support inference from a return type with Boolean as a predicate', () => {   interface I {-    a: string | null;+    a: string | null | undefined | false | 0 | -0 | 0n | '';

Instead, add more expectations - for the different falsy types - to the test that's above this one.

Yep. That makes a lot of sense. I will do that, for sure. Thanks!

josepot

comment created time in 11 days

PullRequestReviewEvent

pull request commentReactiveX/rxjs

feat(filter): improve type inference for filter(Boolean)

Looking at this again, I think a dtstlint test needs to be added to ensure that the problem mentioned in this comment does not occur: #4959 (comment)

I was under the impression that the current dtslint test already does that.

josepot

comment created time in 11 days

push eventjosepot/rxjs

Josep M Sobrepere

commit sha 2230fdab8789cbcd1e084b328a82a50d02cc5a1b

feat(filter): improve type inference for filter(Boolean)

view details

push time in 11 days

push eventjosepot/rxjs

Josep M Sobrepere

commit sha ad951b13b95e1f1a99291ff03cea59032e5a64dc

feat(filter): improve type inference for filter(Boolean)

view details

push time in 11 days

push eventjosepot/rxjs

Josep M Sobrepere

commit sha 00b4f238136f07d1ad4b506a0d88de29766b4c94

feat(filter): improve type inference for filter(Boolean)

view details

push time in 11 days

PR opened ReactiveX/rxjs

feat(filter): improve type inference for filter(Boolean)

I think that the changes on this PR improve the types of the BooleanConstructor overload of filter

+4 -3

0 comment

2 changed files

pr created time in 11 days

create barnchjosepot/rxjs

branch : feat/filter-boolean-type

created branch time in 11 days

issue commentReactiveX/rxjs

filter control flow

Or you can use Boolean to match this signature

Nice!!!

Although, AFAICT that's not yet available on the stable release... it's only available on the beta version of v7. On v6 the type would be Observable<unknown>

I'm very excited about the release of v7!

criskrzysiu

comment created time in 11 days

issue commentReactiveX/rxjs

filter control flow

Hi @criskrzysiu ,

This is a "limitation" of TypeScript. Even if the filter operator was internally implemented with switchMap TypeScript wouldn't be able to infer what's the type that has to be excluded. For instance, even with this code:

type Easing = 'ease-in' | 'ease-out' | 'ease-in-out';

const subject = new Subject<Easing>();

const customFilter = <T>(filterFn: (val: T) => boolean) =>
  switchMap((val: T) => filterFn(val) ? of(val) : EMPTY);

const withEaseOut$ = subject.pipe(customFilter((easing) => easing !== 'ease-out'));

withEaseOut$'s type would be Observable<'ease-in' | 'ease-out' | 'ease-in-out'>

Notice that Array.filter also suffers from this exact same issue, which is why TS provides the is keyword, so that we can help TS infer the resulting type of a filter

So, the way to handle this would be to write your code like this:

const validationResult$ = subject2.pipe(filter((obj): obj is ValidationSuccess => obj.isValid));

Also, maybe you would find this operator that I made useful :wink: :

type Diff<T, U> = T extends U ? never : T;

export default function filterNonFalsy<T>(): (
  x: Observable<T>
) => Observable<Diff<T, null | undefined | false | 0 | 0n | ''>> {
  return filter(Boolean as any);
}
criskrzysiu

comment created time in 11 days

push eventjosepot/js-framework-benchmark

Josep M Sobrepere

commit sha fca0527295ed1d1654c9fcae6331e39abd5d4442

almost there

view details

Josep M Sobrepere

commit sha c85f258fb7cc95718946d6a392e4bf7bc9907b0c

yeah

view details

push time in 11 days

PR opened re-rxjs/react-rxjs

Reviewers
feat(core): default value on bind

I can't wait to get this in!! 😬

+122 -16

0 comment

7 changed files

pr created time in 12 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha d79cdc8bde78e446f7f00339a875fcaadcc4b72f

feat(core): default value on bind

view details

push time in 12 days

create barnchre-rxjs/react-rxjs

branch : feat/default-val

created branch time in 12 days

created tagre-rxjs/react-rxjs

tag@react-rxjs/core@0.4.4

React bindings for RxJS

created time in 12 days

release re-rxjs/react-rxjs

@react-rxjs/core@0.4.4

released time in 12 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha fcd6641b14832213bdf4d87a09429a61b8f24e5c

release: core@0.4.4

view details

push time in 12 days

PR merged re-rxjs/react-rxjs

release: core@0.4.4
+3 -3

1 comment

3 changed files

josepot

pr closed time in 12 days

PR opened re-rxjs/react-rxjs

release: core@0.4.4
+3 -3

0 comment

3 changed files

pr created time in 12 days

create barnchre-rxjs/react-rxjs

branch : release/core@0.4.4

created branch time in 12 days

delete branch re-rxjs/react-rxjs

delete branch : impr/factory-observable

delete time in 12 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha ea14185628e3a5c489a59ec72ffbeb7143647ce4

test(core): missing test for connectFactoryObservable

view details

Josep M Sobrepere

commit sha 6002f71cfd26763682c3e7b4c3331b144bbc7cc1

perf(core): small perf improvement for factoryObservable

view details

push time in 12 days

PR merged re-rxjs/react-rxjs

Impr/factory observable

The last commit on #137 was a fix without a test. This PR adds a test for that commit, plus another commit with a tiny perf improvement for factory-observables.

+31 -6

1 comment

2 changed files

josepot

pr closed time in 12 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 2fdc31d8579bd3d447b138909a1648426cc176d0

perf(core): small perf improvement for factoryObservable

view details

push time in 12 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 4faac313977d52db5100c366b05c511b64043fd3

perf(core): small perf improvement for factoryObservable

view details

push time in 12 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 9b57fa6ed11bfc4dba5ea765611d43108dd825c8

test(core): missing test for connectFactoryObservable

view details

Josep M Sobrepere

commit sha cf4b58857b364813840a1d15a721d20115f6a8c5

perf(core): small perf improvement for factoryObservable

view details

push time in 12 days

PR opened re-rxjs/react-rxjs

Reviewers
Impr/factory observable

The last commit on #137 was a fix without a test. This PR adds a test for that commit, plus another commit with a tiny perf improvement for factory-observables.

+31 -5

0 comment

2 changed files

pr created time in 12 days

create barnchre-rxjs/react-rxjs

branch : impr/factory-observable

created branch time in 12 days

delete branch re-rxjs/react-rxjs

delete branch : perf/core

delete time in 12 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha d4ac471665e954a2d1568b084d552f52ad5c4075

chore(core): remove graceTime

view details

Josep M Sobrepere

commit sha 8ea930d4f240f5e052aecd94e42d3728e3c3cd40

perf(core): lots of performance improvements

view details

Josep M Sobrepere

commit sha ccf81ed6030495638c3fb0a89d313eda48f136d3

perf(core): react-enhancer only returns a function

view details

Josep M Sobrepere

commit sha c01cd43cb02c239afb2f81fe975129a37a1a7091

perf(core): avoid unnecessary calls to setState

view details

Josep M Sobrepere

commit sha ce05cf36b46d07401c653ea7fb7b27c623ca0254

fix(core): ensure the same observable on useObservable

view details

push time in 12 days

PR merged re-rxjs/react-rxjs

Removing graceTime and adding lots of perf improvements

The graceTime is a dangerous thing. No one should rely on it, it's an implementation detail. So, I've decided to remove it because it's not as useful as I initial thought it was. Also, it adds lots of unnecessary complexity.

There are 3 different commits in this PR:

  1. Gets rid of the graceTimesecond
  2. Simplifies a lot both: the reactEnhancer and useObservable
  3. Removes reactEnhancer :tada:
+166 -215

1 comment

9 changed files

josepot

pr closed time in 12 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha ff808514e0b1d630a7136846966958c4e4e1e53b

perf(core): avoid unnecessary calls to setState

view details

Josep M Sobrepere

commit sha 5c14ec5c449ea90f5d9a19943bd0c67a7f33bbbc

fix(core): ensure the same observable on useObservable

view details

push time in 12 days

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha ecf62da520609c54e5bcb86b08da752c7b85f288

perf(core): react-enhancer only returns a function

view details

Josep M Sobrepere

commit sha cbe666a564607bfe76829f50fecb2a5053656a7b

perf(core): avoid unnecessary calls to setState

view details

Josep M Sobrepere

commit sha 199ce281ff78a628ee6a3b62ec6e0dd5c6272c93

fix(core): ensure the same observable on useObservable

view details

push time in 12 days

Pull request review commentre-rxjs/react-rxjs

Removing graceTime and adding lots of perf improvements

 export default function connectFactoryObservable<A extends [], O>(        return source$.subscribe(subscriber)     }) as BehaviorObservable<O>-    const reactObservable$ = reactEnhancer(publicShared$)+    publicShared$.getValue = getEmpty

sure... I mean, in that case sharedObservable$.getValue will returnEMPTY_VALUE`, so it really is the same. But yeah, I'll make the change. Thanks!

josepot

comment created time in 12 days

PullRequestReviewEvent

Pull request review commentre-rxjs/react-rxjs

Removing graceTime and adding lots of perf improvements

-import { useEffect, useReducer } from "react"-import { BehaviorObservable, Action } from "./BehaviorObservable"+import { useEffect, useState } from "react" import { SUSPENSE } from "../SUSPENSE" import { EMPTY_VALUE } from "./empty-value"--const reducer = (-  current: { type: Action; payload: any },-  action: { type: Action; payload: any },-) =>-  current.type === action.type && Object.is(current.payload, action.payload)-    ? current-    : action--const init = (source$: BehaviorObservable<any>) => source$.getValue()+import { Observable } from "rxjs"  export const useObservable = <O>(-  source$: BehaviorObservable<O>,+  source$: Observable<O>,+  getValue: any,

Ups! Yep, thanks for spotting that :sweat_smile:

josepot

comment created time in 12 days

PullRequestReviewEvent

push eventre-rxjs/react-rxjs

Josep M Sobrepere

commit sha 8de1bcc4e5b0f1aa4d200ee704740374d68fa968

fix(core): ensure the same observable on useObservable

view details

push time in 12 days

more