profile
viewpoint
Jorge Moya jorgemoya @bigcommerce Austin, TX Front End Engineer

jorgemoya/japtor 1

Project for compiler design class @ itesm.

jorgemoya/bc-challenge 0

Interview demo project

jorgemoya/downshift 0

🏎 Primitive to build simple, flexible, WAI-ARIA compliant enhanced input React components

jorgemoya/reactnd-project-mobile-flashcards 0

Code for the Mobile Flashcards Project

jorgemoya/reactnd-project-myreads 0

Starter Code for the React MyReads Project

jorgemoya/reactnd-project-would-you-rather 0

Code for the React Would You Rather Project

jorgemoya/request-sender-js 0

HTTP request client for browsers

jorgemoya/tslint-config 0

Default TSLint configuration used at BigCommerce

PullRequestReviewEvent

delete branch jorgemoya/big-design

delete branch : change-inline-message

delete time in 4 days

push eventbigcommerce/big-design

Jorge Moya

commit sha d88b504094a5749948c0bb1993dd483a3f5a0363

chore(component): rename InlineAlert to InlineMessage (#464) BREAKING CHANGE: Rename `InlineAlert` to `InlineMessage`.

view details

push time in 4 days

PR merged bigcommerce/big-design

chore(component): rename InlineAlert to InlineMessage

Breaking Change

Rename InlineAlert to InlineMessage.

Screenshot

inline-message

+66 -66

1 comment

12 changed files

jorgemoya

pr closed time in 4 days

push eventjorgemoya/big-design

Daniel Almaguer

commit sha 395a06cbe5ecac5f88a321097ad854e0e69ead83

chore(ci): bump cache version (#468)

view details

Jorge Moya

commit sha e8d993775429d906efa073372b77114508fc0fbf

chore(component): rename InlineAlert to InlineMessage

view details

Jorge Moya

commit sha ca7b4ccc323253f8708cb4fdb67084467f3ea397

fix: revert changelog

view details

push time in 5 days

PullRequestReviewEvent

push eventjorgemoya/big-design

Jorge Moya

commit sha 92694078077f1de383f2cbc69896c2519fc91ce5

fix: revert changelog

view details

push time in 5 days

push eventjorgemoya/big-design

Vitalii

commit sha 886b41da9f5ad538506503a9af2e17f669ee4904

fix(component): do not shrink radio component (#465)

view details

Daniel Almaguer

commit sha 7e66238ca42cb27d91b1a80cc9e1c8014808e27b

fix: webpack 5 compatibility (#466)

view details

Chancellor Clark

commit sha 5d7cf681e2c33633e08c10be0b38697d58100e6d

chore: remove unused uniqueId util in favor of hook (#467)

view details

Jorge Moya

commit sha 4fbe17fccf935cc779afcb8022619c636608af2d

chore(component): rename InlineAlert to InlineMessage

view details

Jorge Moya

commit sha ba38c830309925b469b047d1daf124a66fb172b9

fix: revert changelogs

view details

push time in 5 days

push eventjorgemoya/big-design

Jorge Moya

commit sha 003634e32bc66698ead759a56c029ea0299a3649

fix: revert changelogs

view details

push time in 14 days

push eventjorgemoya/big-design

Jorge Moya

commit sha 84617b27a1e0dcec9acf69bfa6e405a3739552b5

fix: revert changelogs

view details

push time in 14 days

push eventjorgemoya/big-design

Daniel Almaguer

commit sha 8444aaa919ffbf3fa16347c2a0c38080fd6cb2d1

chore(release): publish - @bigcommerce/big-design@0.24.0 - @bigcommerce/docs@0.24.0 - @bigcommerce/examples@0.11.0

view details

Jorge Moya

commit sha 30abae49cdceea76ce196a336f70ad709f1e05e1

chore(component): rename InlineAlert to InlineMessage

view details

push time in 14 days

PR opened bigcommerce/big-design

chore(component): rename InlineAlert to InlineMessage

Breaking Change

Rename InlineAlert to InlineMessage.

Screenshot

inline-message

+70 -70

0 comment

16 changed files

pr created time in 15 days

create barnchjorgemoya/big-design

branch : change-inline-message

created branch time in 15 days

delete branch jorgemoya/big-design

delete branch : fix-dropdown

delete time in 15 days

push eventbigcommerce/big-design

Jorge Moya

commit sha 10b26a6d8168a3f794b6890d01828bac0b76e1f8

fix(component): add missing prop to open dropdown (#463)

view details

push time in 15 days

PR merged bigcommerce/big-design

fix(component): add missing prop to open dropdown

Dropdown's <List /> component was missing the isOpen prop.

Will lurk the Downshift library to figure out why getMenuProps returns any, which caused an oversight by me thinking ts would catch an issue like this.

+3 -0

0 comment

3 changed files

jorgemoya

pr closed time in 15 days

Pull request review commentbigcommerce/big-design

fix(component): add missing prop to open dropdown

 export const Select = typedMemo(       isOpen,       onOptionChange,       openMenu,+      selectedOption,

Missed adding this dependency on #462

jorgemoya

comment created time in 15 days

PullRequestReviewEvent

PR opened bigcommerce/big-design

fix(component): add missing prop to open dropdown

Dropdown's <List /> component was missing the isOpen prop.

Will lurk the Downshift library to figure out why getMenuProps returns any, which caused an oversight by me thinking ts would catch an issue like this.

+3 -0

0 comment

3 changed files

pr created time in 15 days

create barnchjorgemoya/big-design

branch : fix-dropdown

created branch time in 15 days

push eventjorgemoya/big-design

Jorge Moya

commit sha 8b42ac10b61bd9a7ff638f5aa4bcfdb3089f0581

feat(component): show icon on selected item (#462)

view details

push time in 15 days

delete branch jorgemoya/big-design

delete branch : add-icon-select

delete time in 15 days

push eventbigcommerce/big-design

Jorge Moya

commit sha 8b42ac10b61bd9a7ff638f5aa4bcfdb3089f0581

feat(component): show icon on selected item (#462)

view details

push time in 15 days

PR merged bigcommerce/big-design

feat(component): show icon on selected item

What

Show icon on selected item

Screenshot

Screen Shot 2020-10-15 at 11 21 42 AM

Closes #400

+3 -1

0 comment

2 changed files

jorgemoya

pr closed time in 15 days

issue closedbigcommerce/big-design

Support left icon on Select component

Add the capacity to show an icon on the left of a Select component next to the field label.

Note: inputs already have the capacity to show an icon on the left/right so part of this work will involve using this icon, plus adjustments to the layout

closed time in 15 days

valterfatia

push eventjorgemoya/big-design

Jorge Moya

commit sha 320f3790ffbc051034920afc20d6e7d2b6264141

feat(component): show icon on selected item

view details

push time in 16 days

PR opened bigcommerce/big-design

feat: show icon on selected item

What

Show icon on selected item

Screenshot

Screen Shot 2020-10-15 at 11 21 42 AM

+3 -1

0 comment

2 changed files

pr created time in 16 days

create barnchjorgemoya/big-design

branch : add-icon-select

created branch time in 16 days

push eventjorgemoya/big-design

Jorge Moya

commit sha 2696a2eddc2ef2a71ef21eb5d15b63dff24d9abc

fix: open select when clicked and visually hide list (#461)

view details

Daniel Almaguer

commit sha 4eb492e1b15f80c58da4a50866375a28b69f3ac8

chore(release): publish - @bigcommerce/big-design@0.23.8 - @bigcommerce/docs@0.23.8 - @bigcommerce/examples@0.10.8

view details

push time in 16 days

delete branch jorgemoya/big-design

delete branch : fix-select

delete time in 16 days

push eventbigcommerce/big-design

Jorge Moya

commit sha 2696a2eddc2ef2a71ef21eb5d15b63dff24d9abc

fix: open select when clicked and visually hide list (#461)

view details

push time in 16 days

PR merged bigcommerce/big-design

fix: open select when clicked and visually hide list

What

Open list when Select is clicked. Visually hide the list when select is closed.

Why

Should fix #459 & fix #460. I was, however, unable to reproduce #459 but I'm hoping these changes fix it.

+59 -0

0 comment

6 changed files

jorgemoya

pr closed time in 16 days

issue closedbigcommerce/big-design

Selects: Cannot re-select by clicking inside the box

Describe the bug

On the select component, after selecting an item, you cannot trigger the dropdown by clicking inside the box. The only way to show the dropdown is to click on the triangle. This is inconsistent because initially, you can trigger the dropdown by clicking inside the box.

Kapture 2020-10-13 at 23 03 53

To Reproduce Steps to reproduce the behavior:

  1. Go to https://developer.bigcommerce.com/big-design/select
  2. Click on the topmost country select box
  3. Click on any other country name
  4. Click on inside the box

Expected behavior

Expected: Dropdown opens again Actual: Nothing happens

Desktop (please complete the following information, if applicable):

  • OS: [e.g. iOS] macOS 10.15.7
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22] 86

closed time in 16 days

chibicode

issue closedbigcommerce/big-design

Selects: Empty dropdown item remains after selection

Describe the bug

On the Select component, after selecting an item, an empty dropdown item remains.

Kapture 2020-10-13 at 22 39 31

To Reproduce Steps to reproduce the behavior:

  1. Go to https://developer.bigcommerce.com/big-design/select
  2. Click on the topmost country select box
  3. Click on any other country name
  4. See that an empty popup item remains

Expected behavior

The empty popup item should not appear.

Desktop (please complete the following information, if applicable):

  • OS: [e.g. iOS] macOS 10.15.7
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22] 86

closed time in 16 days

chibicode

PR opened bigcommerce/big-design

fix: open select when clicked and visually hide list

What

Open list when Select is clicked. Visually hide the list when select is closed.

Why

Should fix #459 & #460. I was, however, unable to reproduce #459 but I'm hoping these changes fix it.

+59 -0

0 comment

6 changed files

pr created time in 16 days

create barnchjorgemoya/big-design

branch : fix-select

created branch time in 16 days

issue commentbigcommerce/big-design

Selects: Empty dropdown item remains after selection

Hey @chibicode I can't seem to be able to reproduce this. I'm running almost identical specs as you. Could there be some unexpected changes in the example code that may make this trigger?

chibicode

comment created time in 17 days

push eventjorgemoya/big-design

Chancellor Clark

commit sha 4c6201842cc91645c67f82f55ede79ddf09ce804

chore(release): publish - @bigcommerce/big-design@0.23.6 - @bigcommerce/docs@0.23.6 - @bigcommerce/examples@0.10.6

view details

Jorge Moya

commit sha 5543b2a793abe8321bc66134cfc0edd24a33ea2c

feat: update downshift and fix tests (#456)

view details

Animesh Singh

commit sha 0753cd306f9ffe106297ef29be572f26f3cd27df

fix(datepicker): fix order of days displayed (#457)

view details

Daniel Almaguer

commit sha 9db2d1c8420f876c0e09522bd4cf4f38d7d2ff15

chore(release): publish - @bigcommerce/big-design@0.23.7 - @bigcommerce/docs@0.23.7 - @bigcommerce/examples@0.10.7

view details

dependabot[bot]

commit sha 7f1fb23b245d4b54a5294c754a9efda23fbad728

chore(deps-dev): bump next from 9.5.2 to 9.5.4 (#458)

view details

push time in 17 days

issue commentbigcommerce/big-design

Selects: Cannot re-select by clicking inside the box

Maybe onFocus doesn’t fire when it’s already focused? https://github.com/bigcommerce/big-design/blob/7f1fb23b245d4b54a5294c754a9efda23fbad728/packages/big-design/src/components/Select/Select.tsx#L253

Yeah, I think it is along those lines. Will take a look.

chibicode

comment created time in 17 days

issue commentbigcommerce/big-design

Selects: Empty dropdown item remains after selection

Thanks for the report, will take a look.

chibicode

comment created time in 17 days

delete branch jorgemoya/big-design

delete branch : update-downshift

delete time in 24 days

push eventbigcommerce/big-design

Jorge Moya

commit sha 5543b2a793abe8321bc66134cfc0edd24a33ea2c

feat: update downshift and fix tests (#456)

view details

push time in 24 days

PR merged bigcommerce/big-design

feat: update downshift and fix tests

Update downshift to use the latest version and make the changes necessary to make it work. Fixed breaking tests due to new changes.

There is a still a performance pass pending but will be done at a different time.

+479 -252

0 comment

14 changed files

jorgemoya

pr closed time in 24 days

push eventjorgemoya/big-design

Chancellor Clark

commit sha 4c6201842cc91645c67f82f55ede79ddf09ce804

chore(release): publish - @bigcommerce/big-design@0.23.6 - @bigcommerce/docs@0.23.6 - @bigcommerce/examples@0.10.6

view details

Jorge Moya

commit sha 3be0b72229a0a9eeb99cba878e9eedf3ff77cc34

feat: update downshift and fix tests

view details

push time in 24 days

PR opened bigcommerce/big-design

feat: update downshift and fix tests

Update downshift to use the latest version and make the changes necessary to make it work. Fixed breaking tests due to new changes.

There is a still a performance pass pending but will be done at a different time.

+479 -252

0 comment

14 changed files

pr created time in 24 days

push eventjorgemoya/big-design

Jorge Moya

commit sha d638d3961b561d263c5fe41b22c3aa5144d17e69

feat: update downshift and fix tests

view details

push time in 24 days

push eventjorgemoya/big-design

Jorge Moya

commit sha 11129a27478eb7db548bb19f093a05b7caf67fe2

feat: update downshift and fix tests

view details

push time in 24 days

create barnchjorgemoya/big-design

branch : update-downshift

created branch time in 24 days

issue commentdownshift-js/downshift

Downshift hooks discard previous action dispatch changes if a new action is dispatched

Good catch, I'm experiencing this same problem after upgrading from 5.2.2. Fix partially fixes one of my issues, still debugging another one.

karangarg45

comment created time in a month

push eventjorgemoya/big-design

Chancellor Clark

commit sha eb657fca18824ecc2ea8756cef1d06645115ce30

feat(component): add HR component (#438)

view details

Daniel Almaguer

commit sha c025900d9562d5e3b0deafa127df28f277caeef9

feat(component): add zIndex prop to Box (#439)

view details

Daniel Almaguer

commit sha d1e877d71783c504267737bf40acbd4fc689f6e1

feat(component): add emptyComponent prop to Table (#436)

view details

Daniel Almaguer

commit sha 11b1dff42f686b9241a2f508fb546b32db5d45d8

feat(component): rename alertManager's fadeAway to autoDismiss (#437) BREAKING CHANGE: If you are using alertManager's `fadeAway` option you will need to change it to `autoDismiss`.

view details

Daniel Almaguer

commit sha f04e120f3fa1613b1e76b736374423c2bee780b5

feat(component): add mobileWidth prop to Button (#435)

view details

Daniel Almaguer

commit sha 82b30f5886e9d43a6904cf3285433fa304a52839

chore(deps): bump react-popper and update tests (#440)

view details

Daniel Almaguer

commit sha c0c4496f85180f0e70c9dba1811fa10be93406cd

feat(component): adds Popover component

view details

Daniel Almaguer

commit sha b37d109c63b159ad91834d2e15b69a6d0237e0c6

feat(docs): adds docs for Popover

view details

Daniel Almaguer

commit sha 561f770c437e8811bda1a2858e7fbaa07c67c641

chore(release): publish - @bigcommerce/big-design@0.23.0 - @bigcommerce/docs@0.23.0 - @bigcommerce/examples@0.10.0

view details

Chancellor Clark

commit sha cdfeb493973cce48ed92e30951be2b8bc87ed194

feat(theme): add DefaultTheme extension types

view details

Chancellor Clark

commit sha 1b12288842143ebfab7b146caa94f4bf6f9acd94

fix(component): allow Dropdown groups to have optional `label`

view details

Chancellor Clark

commit sha 4887ede98cd198adfaa093cef5cb78a9edce209a

chore(deps): upgrade to latest minors/patches

view details

William Kwon

commit sha 4123553137f82758537ffb192de57de78769531e

feat(component): add hr to dropdown when separated flag is true (#445)

view details

Daniel Almaguer

commit sha 2083ba6a9271f3ecf0ad3801065e99ef9b9a1f7d

fix(component): modal overflowY cleanup on unmount (#446)

view details

Daniel Almaguer

commit sha 3b944718e372779fea370849271ea3f091c1df55

chore(release): publish - @bigcommerce/big-design-icons@0.13.1 - @bigcommerce/big-design-theme@0.10.1 - @bigcommerce/big-design@0.23.1 - @bigcommerce/docs@0.23.1 - @bigcommerce/examples@0.10.1

view details

Daniel Almaguer

commit sha 4a88f09adf9383ba9861cfecd54c48155fc0b953

feat(component): rename popover offset props and defaults (#447)

view details

Daniel Almaguer

commit sha 4ba0f68b2ad8517d84a7c5569b5bd0072460c836

chore(release): publish - @bigcommerce/big-design@0.23.2 - @bigcommerce/docs@0.23.2 - @bigcommerce/examples@0.10.2

view details

Chancellor Clark

commit sha 569fc1eae89735766fd67f9f6474cd32cf7cedc4

feat(component): add id support for Tree component

view details

Chancellor Clark

commit sha 0c84516a5585581b7c6928a26de967a40dc6507c

feat(component): add aria-checked to Checkbox component

view details

Chancellor Clark

commit sha 96238c23e190566ae6c618d2c94aaae4744c782c

chore(release): publish - @bigcommerce/big-design@0.23.3 - @bigcommerce/docs@0.23.3 - @bigcommerce/examples@0.10.3

view details

push time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventjorgemoya/big-design

Chancellor Clark

commit sha 8a39278adfe189055f973d4387e3efb7be5bbbcf

feat(docs): add BigDesign version on the documentation site (#428)

view details

Animesh Singh

commit sha 340bcecdab6d919e2899a30ed50036905a65bf2d

feat(component): add Switch component (#429)

view details

Animesh Singh

commit sha 23ee544956719379ac45b0527ef8f73f26df22df

feat(component): add Timepicker component (#425)

view details

William Kwon

commit sha bb48f2d6aefa627f35137f6043b582268ac76ef4

feat(icons): add code, brush and get_app icons (#433)

view details

Chancellor Clark

commit sha 6d06b8007784bc0cc966449f186e128db75ff6db

chore(release): publish - @bigcommerce/big-design-icons@0.13.0 - @bigcommerce/big-design@0.22.0 - @bigcommerce/docs@0.22.0 - @bigcommerce/examples@0.9.0

view details

push time in 2 months

Pull request review commentbigcommerce/big-design

feat(component): add Timepicker component

+import React, { forwardRef, memo, Ref } from 'react';++import { getTimeIntervals } from '../../utils';+import { Select } from '../Select';+interface Props {+  error?: React.ReactNode;+  label?: string;

Good catch. The Select type was changed recently.

animesh1987

comment created time in 3 months

Pull request review commentbigcommerce/big-design

feat(component): add Timepicker component

 import { ListItemProps } from '../List/Item';  interface BaseSelect extends Omit<React.HTMLAttributes<HTMLInputElement>, 'children'> {   action?: SelectAction;+  autoWidth?: boolean;

☝️

animesh1987

comment created time in 3 months

push eventjorgemoya/big-design

Jorge Moya

commit sha f49dd81e1e30cfc45e951e828fabe4315ff4ad1e

feat(component): allow FormControlLabels in Selects (#422)

view details

Jorge Moya

commit sha e9705dda4bbd5ee40dc1f493db3204e3e9b1995e

feat(component): set offset to 4px for dropdowns (#424)

view details

Stanislav Holts

commit sha 2efaab5b9563a164540eb57e77a12504dc6169ce

feat(component): add description to select options and action (#423)

view details

dependabot-preview[bot]

commit sha 717f1489a2cb6c78dbf2a536548f99f875d68746

chore(deps): [security] bump elliptic from 6.5.2 to 6.5.3 (#427)

view details

Chancellor Clark

commit sha 5dbdba6dc19c7151b715487b6a8b192742486bcf

chore(release): publish - @bigcommerce/big-design@0.21.2 - @bigcommerce/docs@0.21.2 - @bigcommerce/examples@0.8.2

view details

push time in 3 months

more