profile
viewpoint
John Papa johnpapa JohnPapa.net, LLC Orlando, FL http://johnpapa.net http://johnpapa.me/

johnpapa/angular-styleguide 24207

Angular Style Guide: A starting point for Angular development teams to provide consistency through good practices.

johnpapa/angular-ngrx-data 906

Angular with ngRx and experimental ngrx-data helper

johnpapa/angular-tour-of-heroes 772

Angular - Tour of Heroes - The Next Step after Getting Started

DanWahlin/angular-architecture 316

Examples of Angular Architecture Concepts

DanWahlin/TypeScriptDemos 139

A set of TypeScript demos showing various features of the language.

johnpapa/angular-event-view-cli 127

Angular Demo with a Little bit of a lot of features

johnpapa/angular2-force 116

ngConf 2016 live coding demo

johnpapa/angular-first-look-hosted 88

Hosted Code from Pluralsight Course "Angular First Look"

johnpapa/angular-first-look-examples 81

angular first look for pluralsight

johnpapa/angular-cosmosdb 79

Cosmos DB, Express.js, Angular, and Node.js app

push eventjohnpapa/vscode-peacock

John Papa

commit sha 1ae1a64e127b1c2d6b37a6cc523990f3f0b39912

Update azure-pipelines.yml

view details

push time in 10 hours

issue commentjohnpapa/vscode-peacock

Don't reset the color scheme every time Code opens

Thank you @STGHMAAV for creating this issue!

STGHMAAV

comment created time in a day

issue commentangular/vscode-ng-language-service

Emmet support for inline templates in VS Code and other editors that support emmet today

@ayazhafiz yes. All emmet features for html should work in inline template. Just as they do in html templates in vs code.

Similar works in JSX for react or .vue files for vue.

johnpapa

comment created time in 2 days

push eventjohnpapa/heroes-angular-serverless

John Papa

commit sha c69c0f38ca6bcc742ee1f097347d33af431d7e2c

peacock

view details

push time in 2 days

push eventjohnpapa/heroes-react

John Papa

commit sha 43a7100016c17ae3378cea8bef800c04db595152

lint & prettier

view details

push time in 2 days

push eventjohnpapa/heroes-react

Ward Bell

commit sha d6e3794dce6544fa94c2bf73cc4177c00575e99f

Convert Hero component classes to functions with hooks

view details

push time in 2 days

PR merged johnpapa/heroes-react

Convert Hero component classes to functions with hooks

DO NOT MERGE I think you want to create a hooks-version branch off of your master first and then merge my PR into that.

+526 -248

0 comment

4 changed files

wardbell

pr closed time in 2 days

push eventjohnpapa/heroes-angular

John Papa

commit sha 93e70084705d00cd7d480a37b5bd0d827dbbc930

peacock

view details

John Papa

commit sha dbd5a9870cdbc607fba977a53757aecdfcf64ece

v8

view details

John Papa

commit sha 6c78ef519bc121d623789064a21ff0b2bde4f965

Merge branch 'master' of github.com:johnpapa/heroes-angular

view details

John Papa

commit sha aa2814263b537bb448d6b96cb751856401961095

lock

view details

John Papa

commit sha 672c6afd5dfcdc579888dca2a13f2788b8dbb59e

lock fixes

view details

John Papa

commit sha b9c67f2ec64b4e08db59b469ee9d46da725e7aba

proxy to port 7626

view details

push time in 2 days

push eventjohnpapa/heroes-react

John Papa

commit sha 7f55235ce7e6e713ba3d099308c1eed7b4e8ce85

peacock

view details

John Papa

commit sha 2c3f0ae5df6fd1c2651dde4c5a3a748ccf6f95d1

Merge branch 'master' of github.com:johnpapa/heroes-react

view details

push time in 2 days

push eventjohnpapa/heroes-vue

John Papa

commit sha 1075812ba863133f3635fc53106481830c1425aa

eslint

view details

John Papa

commit sha cdef7630aab47a2d72d06fb38f8409a47632d360

eslint fixes

view details

push time in 2 days

push eventjohnpapa/heroes-vue

John Papa

commit sha 10504a3593e5ec089b9475566bedc5096173ec28

vue-cli upgrade to v4

view details

push time in 3 days

push eventjohnpapa/heroes-angular-serverless

John Papa

commit sha d3e056e75ce6e1e78662758e8445e25b71c919de

audit fix

view details

John Papa

commit sha e3418f8f0519eb25641a3b33a51839360da89aa7

v8

view details

John Papa

commit sha 10e159c4e3b32e36b5bea29a72139d768e3ef500

readme

view details

John Papa

commit sha ecad322fa4cf8a0f74fdd75d0feb729159a4d6ec

v8

view details

John Papa

commit sha 071e44e620e877d6f13c5ddaa93d859ccec8e0c2

v9

view details

John Papa

commit sha 6961ed77bb64edce78f97782ac804aa7576f1dfb

moved proxy.conf.json to /src cuz it makes sense and docs show it that way too

view details

push time in 3 days

issue closedangular/angular-cli

Add --flat back as a flag for ng new

🚀 Feature request

Add back the --flat flag for ng new so we can tell the CLI to always create components where they are instead of in a nested folder.

Command (mark with an x)

<!-- Can you pin-point the command or commands that are relevant for this feature request? --> <!-- ✍️edit: -->

  • [x] new
  • [ ] build
  • [ ] serve
  • [ ] test
  • [ ] e2e
  • [ ] generate
  • [ ] add
  • [ ] update
  • [ ] lint
  • [ ] xi18n
  • [ ] run
  • [ ] config
  • [ ] help
  • [ ] version
  • [ ] doc

closed time in 3 days

johnpapa

issue commentangular/angular-cli

Add --flat back as a flag for ng new

Good point. I always forget about the ng config commands. I set mine up and then ... forgot :)

I'll do that for now.

johnpapa

comment created time in 3 days

issue commentangular/angular-cli

Add --flat back as a flag for ng new

Maybe I am mistaken. But this would be helpful globally. So I change my request to add this flag.

Otherwise I currently have to use it every time I make a component.

johnpapa

comment created time in 3 days

push eventjohnpapa/angular-lazy-load-demo

John Papa

commit sha 959a5337bd1705ebc873d8f2642d2aa495c96f1d

gif

view details

push time in 3 days

push eventjohnpapa/angular-lazy-load-demo

John Papa

commit sha bc7ab1884f4137af0da0c2b3dd18212eb8262249

readme links

view details

push time in 3 days

push eventjohnpapa/angular-lazy-load-demo

John Papa

commit sha 319fa40f9ff082a9589e4fcaf05b6b08e8cca510

readme

view details

push time in 3 days

issue commentjohnpapa/angular-lazy-load-demo

Do you have to declare entry components?

No declarations nor entry components needed with this technique angular 9. I noticed some of the versions are not updated in that package file.

crh225

comment created time in 3 days

issue commentangular/angular

Add guidance to avoid using the webpack comment syntax for naming bundles

I hear you. Rough call.

But - since webpack syntax does work today and it is also supported in vue and react, i be people just assume it will work. And that it won’t suddenly stop working. That’s more of my concern. Preventing people from a sudden failure in the future.

johnpapa

comment created time in 4 days

issue commentangular/angular

Create docs for debugging with ng

Here is another article I wrote with debugging examples. Feel feee to use any of this that may be helpful. https://dev.to/azure/debugging-angular-9-interacting-with-components-5053

johnpapa

comment created time in 4 days

pull request commentmicrosoft/25-days-of-serverless

Updated for week 3, challenge 17

From all of us on the Cloud Advocacy team at Microsoft, thank you for creating this pull request!

gloveboxes

comment created time in 4 days

push eventjohnpapa/angular-lazy-load-demo

John Papa

commit sha fbb1ecd910690de706f59901327cc9284c4f24bd

prettierrc again

view details

push time in 4 days

push eventjohnpapa/angular-lazy-load-demo

John Papa

commit sha 63c15e7ffb8c77559d150e2fe534790b246bb93c

readme

view details

push time in 4 days

create barnchjohnpapa/angular-lazy-load-demo

branch : master

created branch time in 4 days

created repositoryjohnpapa/angular-lazy-load-demo

Lazy loading Angular components

created time in 4 days

issue openedangular/angular-cli

Add --flat back as a flag for ng new

🚀 Feature request

Add back the --flat flag for ng new so we can tell the CLI to always create components where they are instead of in a nested folder.

Command (mark with an x)

<!-- Can you pin-point the command or commands that are relevant for this feature request? --> <!-- ✍️edit: -->

  • [x] new
  • [ ] build
  • [ ] serve
  • [ ] test
  • [ ] e2e
  • [ ] generate
  • [ ] add
  • [ ] update
  • [ ] lint
  • [ ] xi18n
  • [ ] run
  • [ ] config
  • [ ] help
  • [ ] version
  • [ ] doc

created time in 4 days

issue commentjohnpapa/vscode-peacock

Cannot remove peacock.favoriteColors from settings.json permanently

Thank you @pwahlmueller for creating this issue!

pwahlmueller

comment created time in 7 days

issue openedangular/angular

Add guidance to avoid using the webpack comment syntax for naming bundles

Since the CLI may not support it officially.

created time in 7 days

issue openedangular/angular

Create docs for debugging with ng

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

Please file any Docs or angular.io issues at: https://github.com/angular/angular/issues/new/choose

For the time being, we keep Angular AIO issues in a separate repository.

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

created time in 7 days

issue openedangular/angular

Create guide for debugging with ng

<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅

Oh hi there! 😄

To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates.

🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->

📚 Docs or angular.io bug report

Description

<!-- ✍️edit:--> A clear and concise description of the problem...

There is no guide to how to debug with ng

🔬 Minimal Reproduction

What's the affected URL?**

<!-- ✍️edit:--> https://angular.io/...

Reproduction Steps**

<!-- If applicable please list the steps to take to reproduce the issue --> <!-- ✍️edit:-->

Expected vs Actual Behavior**

<!-- If applicable please describe the difference between the expected and actual behavior after following the repro steps. --> <!-- ✍️edit:-->

📷Screenshot

<!-- Often a screenshot can help to capture the issue better than a long description. --> <!-- ✍️upload a screenshot:--> See details here of some Things we can do https://dev.to/azure/debug-angular-9-in-60-seconds-5h8k

🔥 Exception or Error

<pre><code> <!-- If the issue is accompanied by an exception or an error, please share it below: --> <!-- ✍️-->

</code></pre>

🌍 Your Environment

Browser info

<!-- ✍️Is this a browser specific issue? If so, please specify the device, browser, and version. -->

Anything else relevant?

<!-- ✍️Please provide additional info if necessary. -->

created time in 7 days

issue openedangular/angular-cli

Create docs for debugging with ng

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

Please file any Docs or angular.io issues at: https://github.com/angular/angular/issues/new/choose

For the time being, we keep Angular AIO issues in a separate repository.

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

created time in 7 days

issue openedangular/angular-cli

Add guidance to avoid using the webpack comment syntax for naming bundles

Since the CLI may not support it officially.

created time in 7 days

push eventjohnpapa/vscode-angular-essentials

John Papa

commit sha af5354e4f2de5c2a324f7408f00d6c919abb02e3

fixed links

view details

push time in 8 days

push eventjohnpapa/vscode-angular-essentials

John Papa

commit sha 435d92e616e11e4c58498810f4fd3ea441dc9c98

fix readme bug

view details

John Papa

commit sha 7e28d8344304fc39a083fe28e2822dd60e48a91e

readme update for settings

view details

push time in 9 days

push eventjohnpapa/vscode-angular-essentials

John Papa

commit sha 601b3f912c904edf2d229a971946eb4777c4a345

readme

view details

John Papa

commit sha 0667a8fe2a4be601ae91684a15f84f10bb3b0985

changelog

view details

push time in 9 days

push eventjohnpapa/vscode-angular-snippets

John Papa

commit sha c05fc44d0bda954f5a944242ab8aa7c7e7544a7a

audit fix

view details

John Papa

commit sha ecf7345e6bd782c8b72862b1e5d84f69cab73604

readme

view details

push time in 9 days

push eventjohnpapa/vscode-angular-essentials

John Papa

commit sha 88966a48d0b35381a7b1652f2545cecff8384436

peacock

view details

push time in 9 days

push eventjohnpapa/vscode-angular-essentials

John Papa

commit sha 595b9d51f961796cc353b7e35d2c3a911bc6b4f2

v9

view details

John Papa

commit sha 9eb381d1c4fafadbb3971ede9e2cd81ca8ad87d6

Merge branch 'master' of github.com:johnpapa/vscode-angular-essentials

view details

push time in 9 days

issue closedjohnpapa/vscode-angular-snippets

RxJs operators reference needs to be updated

OS and Version?

Windows 10

Versions

8.3.0

Repro steps

use snippet a-http-interceptor-logging

The log given by the failure.

'.../rxjs' has no exported member tap.

Mention any other details that might be useful.

RxJs operators got moved to the /operators directory. The snippet adds the import:

  • import { Observable, tap } from 'rxjs';

When it should be adding two imports:

  • import { Observable } from 'rxjs';
  • import { tap } from 'rxjs/operators';

This could be happening in other snippets, but I haven't used them extensively yet.

closed time in 9 days

HammNCheez

delete branch johnpapa/vscode-angular-snippets

delete branch : v9

delete time in 9 days

push eventjohnpapa/vscode-angular-snippets

John Papa

commit sha adbefe73a087f92f1039228aacf57c84e6eba089

v9

view details

push time in 9 days

PR merged johnpapa/vscode-angular-snippets

v9

Angular v9

+103 -53

0 comment

5 changed files

johnpapa

pr closed time in 9 days

PR opened johnpapa/vscode-angular-snippets

v9

Purpose

  • ...

What

  • ...

How to Test

  • ...

What to Check

Verify that the following are valid

  • ...
+103 -53

0 comment

5 changed files

pr created time in 9 days

push eventjohnpapa/vscode-angular-snippets

John Papa

commit sha 68c4709cb2565ea48881b4c2d34bddc4af45cd9f

added preload strategies

view details

push time in 9 days

create barnchjohnpapa/vscode-angular-snippets

branch : v9

created branch time in 9 days

push eventjohnpapa/vscode-angular-snippets

Jonathan Hammond

commit sha ad5a97dfa0089b94668b9e325ec28c9fd73aa8d7

Update a-http-interceptor-logging for RxJS move thanks

view details

push time in 9 days

PR merged johnpapa/vscode-angular-snippets

Update a-http-interceptor-logging for RxJS move

'tap' operator was moved to /operators sub folder in #RxJS. This fixes the imports when using the logging interceptor snippet

Purpose

  • Fixes issue #106, RxJS tap operator moved to /operators folder

What

  • a-http-interceptor-logging snippet has bad import of tap operator

How to Test

  • use the a-http-interceptor snippet on a project with RxJS 6.0.0 or higher

What to Check

Verify that the following are valid

  • Three imports should be added to the top of the snippet instead of just two -- Various HTTP classes from '@angular/common/http' -- Observable from rxjs -- tap from 'rxjs/operators'
+2 -1

0 comment

1 changed file

HammNCheez

pr closed time in 9 days

issue openedangular/angular-cli

ng update should detect typings files and added it to the appropriate tsconfig file

<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅

Oh hi there! 😄

To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates.

🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->

🚀 Feature request

I have a typings.d.ts file that no longer is included in the compilation/build. I was getting errors about not being able to find my ambient types that were in that files. I noticed the tsconfig.app.json was updated to only compile the main.ts and the polyfills. Once I added the typings.d.ts explictly, it worked.

Yes, it's likely not a common scenario. But It might be good to include this scenario in the ng update process to v9.

It would be nice if the ng update process noticed if there was a typings file and added it to the config.

Command (mark with an x)

<!-- Can you pin-point the command or commands that are relevant for this feature request? --> <!-- ✍️edit: -->

  • [ ] new
  • [ ] build
  • [ ] serve
  • [ ] test
  • [ ] e2e
  • [ ] generate
  • [ ] add
  • [x] update
  • [ ] lint
  • [ ] xi18n
  • [ ] run
  • [ ] config
  • [ ] help
  • [ ] version
  • [ ] doc

created time in 9 days

issue commentjohnpapa/vscode-peacock

An in-range update of @typescript-eslint/eslint-plugin is breaking the build 🚨

Thank you @greenkeeper[bot] for creating this issue!

greenkeeper[bot]

comment created time in 9 days

issue commentjohnpapa/vscode-peacock

An in-range update of @typescript-eslint/parser is breaking the build 🚨

Thank you @greenkeeper[bot] for creating this issue!

greenkeeper[bot]

comment created time in 9 days

push eventjohnpapa/vscode-angular-snippets

stefnotch

commit sha eb7c5cb5170e0621d79742b000d7929aa822beec

Fix #95 (#105)

view details

push time in 10 days

PR merged johnpapa/vscode-angular-snippets

Fix #95

Purpose

  • Fix #95

What

  • Fixes it by replacing params with paramMap and removing the function part
+3 -3

1 comment

1 changed file

stefnotch

pr closed time in 10 days

issue closedjohnpapa/vscode-angular-snippets

a-route-params-subscribe outdated

Please provide us with the following information:

OS and Version?

Windows 10

Versions

8.1.0 (2019-06-07)

Repro steps

a-route-params-subscribe creates

this.route.params
  .pipe(map(params => params.get('id')), tap(id => (this.id = +id)))
  .subscribe(id => function()());

However, the angular documentation says

params—An Observable that contains the required and optional parameters specific to the route. Use paramMap instead.

Also, there doesn't seem to be a reason to write function()() in the subscribe part.

So, it should be changed to

this.route.paramMap
  .pipe(switchMap(params => params.get('id')), tap(id => (this.id = +id)))
  .subscribe(id => { });

closed time in 10 days

stefnotch

pull request commentjohnpapa/vscode-angular-snippets

Fix #95

Thanks

stefnotch

comment created time in 10 days

push eventjohnpapa/vscode-angular-snippets

Alex Okrushko

commit sha 8bb048c0d1160cf69350fcf17541aac79000d4cb

update effects - wrap with return (#100)

view details

push time in 10 days

PR merged johnpapa/vscode-angular-snippets

update effects - wrap with return

Purpose

Update snippets for effects. see discussion at https://github.com/ngrx/platform/issues/2192

What

the effects callback is now wrapped with return statement

+16 -15

4 comments

1 changed file

alex-okrushko

pr closed time in 10 days

pull request commentjohnpapa/vscode-angular-snippets

update effects - wrap with return

Sorry for the delay.

All is well. Thanks for the PR.

alex-okrushko

comment created time in 10 days

issue openedangular/angular-cli

ng update to v8 causes [error] Error: Job name "..getProjectMetadata" does not exist.

<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅

Oh hi there! 😄

To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates.

🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->

🐞 Bug report

Command (mark with an x)

<!-- Can you pin-point the command or commands that are effected by this bug? --> <!-- ✍️edit: -->

  • [ ] new
  • [ ] build
  • [ ] serve
  • [ ] test
  • [ ] e2e
  • [ ] generate
  • [ ] add
  • [x] update
  • [ ] lint
  • [ ] xi18n
  • [ ] run
  • [ ] config
  • [ ] help
  • [ ] version
  • [ ] doc

Description

<!-- ✍️--> A clear and concise description of the problem... When I run ng update @angular/cli@8 @angular/core@8, I then get an error when I run ng build

[error] Error: Job name "..getProjectMetadata" does not exist.

Details are also here https://stackoverflow.com/questions/59447679/an-unhandled-exception-occurred-job-name-getprojectmetadata-does-not-exist

I resolved this by running npm i @angular-devkit/build-angular@0.803.24

I expected that updating to v8 would resolve this.

created time in 10 days

issue openedangular/angular

After upgrading to Angular 9, ngFor and ngIf are unknown

🐞 Bug report

Command (mark with an x)

<!-- Can you pin-point the command or commands that are effected by this bug? --> <!-- ✍️edit: -->

  • [ ] new
  • [ ] build
  • [ ] serve
  • [ ] test
  • [ ] e2e
  • [ ] generate
  • [ ] add
  • [ ] update
  • [ ] lint
  • [ ] xi18n
  • [ ] run
  • [ ] config
  • [ ] help
  • [ ] version
  • [ ] doc

Description

<!-- ✍️--> A clear and concise description of the problem...

🔬 Minimal Reproduction

  1. upgrade a project to angular 9 using the terminal in vs code
  2. Open a template with ngFor or ngIf in VS Code.
  3. Notice the errors (red squiggly lines) in the template over an ngFor

🔥 Exception or Error

<pre><code> Property binding ngForOf not used by any directive on an embedded template. Make sure that the property name is spelled correctly and all directives are listed in the "@NgModule.declarations".ng(0) </code></pre>

This goes away if I ng build AND reload vs code.

created time in 10 days

issue openedangular/angular-cli

After upgrading to Angular 9, ngFor and ngIf are unknown

🐞 Bug report

Command (mark with an x)

<!-- Can you pin-point the command or commands that are effected by this bug? --> <!-- ✍️edit: -->

  • [ ] new
  • [ ] build
  • [ ] serve
  • [ ] test
  • [ ] e2e
  • [ ] generate
  • [ ] add
  • [ ] update
  • [ ] lint
  • [ ] xi18n
  • [ ] run
  • [ ] config
  • [ ] help
  • [ ] version
  • [ ] doc

Description

<!-- ✍️--> A clear and concise description of the problem...

🔬 Minimal Reproduction

  1. upgrade a project to angular 9 using the terminal in vs code
  2. Open a template with ngFor or ngIf in VS Code.
  3. Notice the errors (red squiggly lines) in the template over an ngFor

🔥 Exception or Error

<pre><code> Property binding ngForOf not used by any directive on an embedded template. Make sure that the property name is spelled correctly and all directives are listed in the "@NgModule.declarations".ng(0) </code></pre>

This goes away if I ng build AND reload vs code.

created time in 10 days

issue openedangular/angular-cli

Summarize the display output when ngcc is running

🚀 Feature request

Command (mark with an x)

<!-- Can you pin-point the command or commands that are relevant for this feature request? --> <!-- ✍️edit: -->

  • [ ] new
  • [ ] build
  • [ ] serve
  • [ ] test
  • [ ] e2e
  • [ ] generate
  • [ ] add
  • [x] update
  • [ ] lint
  • [ ] xi18n
  • [ ] run
  • [ ] config
  • [ ] help
  • [ ] version
  • [ ] doc

Description

<!-- ✍️--> A clear and concise description of the problem or missing capability... When ng build first runs, we get a long list of text. it is not a great experience ... perhaps we can trim this up or explain it better or show it in a different way.

Describe the solution you'd like

<!-- ✍️--> If you have a solution in mind, please describe it.

Ideas ...

  • only display it with --verbose
  • show a single line of output and change the text for what it is compiling as it goes (or a progress bar)
  • title it with WHY it is doing it (because sometimes it is not running). perhaps show it always and say ...

Verifying if ngcc needs to run due to changes. then you can say ngcc required or show the 1 liner as it compiles.

From @mgechev

We can improve the DX here. Maybe show a spinner and output the targets we're compiling on the same line (just for a sense of progress, because in big projects this may take a while and just showing a spinner may look like the CLI got stuck).

created time in 10 days

issue openedangular/angular

Add explanation to why a css component budget is added in ng update to v9

📚 Docs or angular.io bug report

Description

The ng update command will add this code to the angular.json file. People might want to know why.

Here is why ...

  • this budget will throw an error if any component has style > 6kb. but it WONT raise an warning if global styles are huge
  • it will be a “warning” not an “error” cause in this case the budget has not been configured to error out.
  • This budget is only checked against individual component styles.
  • Filipe says "We just wanted to prevent individual 100k component css"
            {
              type: 'anyComponentStyle',
              maximumWarning: '6kb',
              maximumError: '10kb',
            },

https://github.com/angular/angular-cli/blob/9de282ca3209c3c8895dcfc1da36c30e4a05fc67/packages/schematics/angular/application/index.ts#L227-L231

created time in 10 days

push eventjohnpapa/express-to-functions

John Papa

commit sha c728db47ead561df54e08f532c94002888edece9

peacock

view details

John Papa

commit sha b68344b7fdabd4d849b97272a039bab49d583ac5

v9

view details

John Papa

commit sha b3236b42d9ef72d2fa7ce1c74ce0dd0cbb302d54

force to 8

view details

John Papa

commit sha 9c84759a68145ad091d08300c8e5b82b17e82b35

v9

view details

push time in 10 days

push eventjohnpapa/express-to-functions

John Papa

commit sha cd4ed541d57acfbebe2b019bb3378df5ce7b2222

peacock

view details

John Papa

commit sha b0e6ef7c8e355dfeeb930d3558bcd81b9aa7dd4e

env prod for storage to talk to functions

view details

John Papa

commit sha f0a15aff6c1f80488468277ae2cda6b22b71d568

Merge branch 'master' of github.com:johnpapa/express-to-functions

view details

John Papa

commit sha 8e08c5bca59b00b6f8ca8ac577c78092d1f128bd

peacock

view details

John Papa

commit sha 65c88621b336e44f55215c3491e7b8dbcfd411e0

npm audit fix

view details

push time in 10 days

pull request commentmicrosoft/25-days-of-serverless

Update CONTRIBUTORS.md

From all of us on the Cloud Advocacy team at Microsoft, thank you for creating this pull request!

iennae

comment created time in 11 days

pull request commentangular/angular-cli

fix(@angular/cli): added clarity on angular cli version issues

@alan-agius4 new PR with proper commit title

johnpapa

comment created time in 11 days

PR opened angular/angular-cli

fix(@angular/cli): added clarity on angular cli version issues

fixes #16888

+1 -1

0 comment

1 changed file

pr created time in 11 days

push eventjohnpapa/angular-cli

John Papa

commit sha 39e13ebee385d40925f33aca9f0dc01df9c2ed38

fix(@angular/cli): added clarity on angular cli version issues fixes #16888

view details

push time in 11 days

delete branch johnpapa/angular-cli

delete branch : patch-1

delete time in 11 days

PR closed angular/angular-cli

fix(@angular/cli): added clarity on angular cli version issues cla: yes

fixes https://github.com/angular/angular-cli/issues/16885

+1 -1

2 comments

1 changed file

johnpapa

pr closed time in 11 days

push eventjohnpapa/angular-cli

John Papa

commit sha 7fac733cc504771409dd8756dded09e4034dd5be

fix(@angular/cli): added clarity on angular cli version issues fixes https://github.com/angular/angular-cli/issues/16885

view details

John Papa

commit sha f547a01355a6140e1eb485d1c9b2ceeae081f8a3

Merge branch 'patch-1' of github.com:johnpapa/angular-cli into patch-1

view details

push time in 11 days

push eventjohnpapa/vikings

John Papa

commit sha e7022d2d21fd47369b13b0b073fc865236513d2f

space

view details

John Papa

commit sha 48adf7f821a46b1ff5d580dac6ff0597097ee609

Merge branch 'master' of github.com:johnpapa/vikings

view details

push time in 11 days

pull request commentangular/angular-cli

fix(@angular/cli): added clarity on angular cli version issues

Thanks for this, can you please amend the commit msg header to something like fix(@angular/cli): added clarity on outdated message?

Thanks

Modified. thanks

johnpapa

comment created time in 11 days

issue commentangular/vscode-ng-language-service

Invalid Template variables don't show up as an error

I tried to repro today and it is not happening now.

I guess you can close this (although as you can see in the above image it DID happen).

If it happens again, I will open an issue

johnpapa

comment created time in 11 days

issue commentangular/vscode-ng-language-service

New models do not appear in intellisense in templates

I tried to repro today and it is not happening now.

I guess you can close this (although as you can see in the above image it DID happen).

If it happens again, I will open an issue

johnpapa

comment created time in 11 days

issue commentangular/vscode-ng-language-service

Allow Setting a Breakpoint in templates

Sure.

  1. Set a breakpoint in the html file's gutter where there is a binding.
  2. Debug the app (start vs code debugger for vs code)
  3. When the template tries to bind, break on that line (example, ngmodel="name" ... or ... ngif="selectedHero")

The debugger would allow seeing the value of the binding model, locals, values in the component, etc.

Without this, when a binding is not working as expected, we are left to chrome extensions to help. And often these are spotty. Even when they work, we now have to debug some in vs code and some in browser. so having this all in the tooling would be hugely beneficial

johnpapa

comment created time in 11 days

issue openedangular/angular

ng update should remove entryComponents since they are no longer needed

<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅

Oh hi there! 😄

To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates.

🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->

🚀 Feature request

ng update should remove entryComponents since they are no longer needed

Command (mark with an x)

<!-- Can you pin-point the command or commands that are relevant for this feature request? --> <!-- ✍️edit: -->

  • [ ] new
  • [ ] build
  • [ ] serve
  • [ ] test
  • [ ] e2e
  • [ ] generate
  • [ ] add
  • [x] update
  • [ ] lint
  • [ ] xi18n
  • [ ] run
  • [ ] config
  • [ ] help
  • [ ] version
  • [ ] doc

Description

<!-- ✍️--> A clear and concise description of the problem or missing capability...

ng update should remove entryComponents since they are no longer needed

created time in 12 days

push eventjohnpapa/heroes-angular

John Papa

commit sha 3864ff7eaee58ca985c07f41fa51c4527591458e

added prettierrc because double quote were coming back!

view details

push time in 12 days

issue commentangular/angular-cli

Confusing message: The installed Angular CLI version is older than the latest stable version.

yes, that would be MUCH clearer. thanks for clarifying what is happening.

I added a quick PR https://github.com/angular/angular-cli/pull/16888

johnpapa

comment created time in 12 days

PR opened angular/angular-cli

added clarity

fixes https://github.com/angular/angular-cli/issues/16885

+1 -1

0 comment

1 changed file

pr created time in 12 days

push eventjohnpapa/angular-cli

John Papa

commit sha 666b4d7516cd9462d525fa6be2297bad4bbcc51d

added clarity fixes https://github.com/angular/angular-cli/issues/16885

view details

push time in 12 days

push eventjohnpapa/heroes-angular

John Papa

commit sha 67f20219f12e14470db47caa8e9a4ff6f45144e3

oops

view details

John Papa

commit sha 10bdfc7793eb6452b79e020d9c7bf030ee095739

peacock

view details

push time in 12 days

push eventjohnpapa/heroes-angular

John Papa

commit sha 73fdfc6f5164477a0fd3212f28a40deab29512da

pretty

view details

John Papa

commit sha 1359cf90e1bd085c92dea7a654911ba80b007a00

latest v8

view details

John Papa

commit sha c5b5e6850267ce7fb29a9efbd5c74bed408819f9

audit fixes

view details

John Papa

commit sha da1aceb738ee50165e20d9cabddf6d540f119014

font awesome

view details

John Papa

commit sha 2ee9aabbeee189af73c1496cdbbf8362f800bdf9

v9

view details

push time in 12 days

issue openedangular/angular-cli

Confusing message: The installed Angular CLI version is older than the latest stable version.

🐞 bug report

I first installed v9.0.1 of the @angular/cli globally. Then I ran ...

ng update @angular/cli @angular/core

It complains about this ...

The installed Angular CLI version is older than the latest stable version.
Installing a temporary version to perform the update.

If it means the global CLI, then how is this possible if I have 9.0.1 and I just installed it moments ago?

This doesnt make sense to me ... either the message is wrong, or I am misunderstanding it.

created time in 12 days

issue commentjohnpapa/vscode-peacock

[Feature Request] Workspace Color Customization Overrides

thanks for the issue. I see your point here. Peacock does change those colors, so really by using Peacock you are opting into letting Peacock adjust them for you.

The darker and lighter features do let you adjust a little (have you tired those?)

But ... if you really wanted to adjust something that Peacock handles, then it would be overwritten (as you mentioned). So ... it may be worth exploring an option where you tell Peacock to stop doing its thing.

This may have a lot of consequences ... so it's not something we should do lightly. But I am open o hearing more about this and seeing if the community can help offer some suggestions and insight in discussion here.

presto2116

comment created time in 12 days

issue commentjohnpapa/vscode-peacock

[Minor bug] activityBar.activeBackground not sync with it background

thanks.

have you tried this with other themes? are you sure it is just with that specific theme?

CuongNgMan

comment created time in 12 days

PR closed johnpapa/vscode-peacock

Use Open Colors for the favorite ones (Fixes #335)

https://yeun.github.io/open-color/

They are pretty colors and easier to choose.

I chose the 9th color of every color.

+98 -98

1 comment

15 changed files

lipis

pr closed time in 12 days

pull request commentjohnpapa/vscode-peacock

Use Open Colors for the favorite ones (Fixes #335)

thanks for the PR. I appreciate your choice in colors, but I will keep what we have for now.

I recommend you change your favorites to these. Peacock only gives you a starter set - you can then change them as you desire.

lipis

comment created time in 12 days

issue openedangular/angular-cli

ng update should remove entryComponents since they are no longer needed

<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅

Oh hi there! 😄

To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates.

🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->

🚀 Feature request

ng update should remove entryComponents since they are no longer needed

Command (mark with an x)

<!-- Can you pin-point the command or commands that are relevant for this feature request? --> <!-- ✍️edit: -->

  • [ ] new
  • [ ] build
  • [ ] serve
  • [ ] test
  • [ ] e2e
  • [ ] generate
  • [ ] add
  • [x] update
  • [ ] lint
  • [ ] xi18n
  • [ ] run
  • [ ] config
  • [ ] help
  • [ ] version
  • [ ] doc

Description

<!-- ✍️--> A clear and concise description of the problem or missing capability...

ng update should remove entryComponents since they are no longer needed

created time in 12 days

push eventjohnpapa/vikings

John Papa

commit sha 000cbcddcd8cd19f18ed76cadf077191975f18f9

debug

view details

John Papa

commit sha 9a2e66ad8c6ce1141b85d531a0de5baa69094dd3

no longer need entry components

view details

John Papa

commit sha 8922902613bae9952f4e046d29ae7db6fc519849

format

view details

push time in 12 days

issue openedangular/vscode-ng-language-service

New models do not appear in intellisense in templates

Describe the bug

  1. add a new model to a component
  2. go to the html template file for that component
  3. try to use it ... notice intellisense has no awareness of it

2020-02-08_00-02-38 (1)

using angular 9

created time in 12 days

issue openedangular/vscode-ng-language-service

Invalid Template variables don't show up as an error

Describe the bug

When typing an invalid model into a template file, no errors are displayed.

image

created time in 12 days

push eventjohnpapa/vikings

John Papa

commit sha ec4fccda979cdc3eb21bfd90e193f9d267893210

latest v8

view details

John Papa

commit sha ce766edd693f81cf920474a4c4a4ad53a42d9339

upgrade to v9

view details

push time in 12 days

push eventjohnpapa/angular-event-view-cli

John Papa

commit sha 6513aae41e7c9c40d042713df9450c71589df321

upgrade to 8.2.14

view details

John Papa

commit sha 7422b63a693d2bbc7a8072a5388a4d77f47362bc

in mem api upgrade

view details

John Papa

commit sha ab54d9f166676cd228fe54e50b4ce6310f85527f

ng update 9

view details

push time in 12 days

issue openedangular/angular

Confusing message: The installed Angular CLI version is older than the latest stable version.

🐞 bug report

I first installed v9.0.1 of the @angular/cli globally. Then I ran ...

ng update @angular/cli @angular/core

It complains about this ...

The installed Angular CLI version is older than the latest stable version.
Installing a temporary version to perform the update.

If it means the global CLI, then how is this possible if I have 9.0.1 and I just installed it moments ago?

This doesnt make sense to me ... either the message is wrong, or I am misunderstanding it.

created time in 12 days

issue commentjohnpapa/vscode-peacock

An in-range update of @types/vscode is breaking the build 🚨

Thank you @greenkeeper[bot] for creating this issue!

greenkeeper[bot]

comment created time in 13 days

push eventjohnpapa/vikings

John Papa

commit sha 4fd7a316f698c4860957ffd4a7873a4e2fe462a9

updated the villains

view details

John Papa

commit sha ba0ed1714141e11b90bc834cfc6bd35eff0bce78

removed core modules

view details

push time in 18 days

more