profile
viewpoint
James Hillyerd jhillyerd @google Redmond, WA, US https://twitter.com/jameshillyerd Google Cloud TSE, Golang enthusiast

release jhillyerd/enmime

v0.7.0

released time in 11 days

issue commentjhillyerd/enmime

go test fails from master

New release has been cut

tegk

comment created time in 11 days

created tagjhillyerd/enmime

tagv0.7.0

MIME mail encoding and decoding package for Go

created time in 11 days

push eventjhillyerd/enmime

James Hillyerd

commit sha 9c98ce6d9158470a9fe756ebec7ec26669489d78

Update change log for 0.7.0

view details

James Hillyerd

commit sha 39591e3f29fe611a24bd1ea41dec26feccfc8d3e

Merge branch 'release/0.7.0'

view details

James Hillyerd

commit sha cf488a7d428e11c06fa07f9e14e1ac27460347c0

Merge tag 'v0.7.0' into develop Added - Public DecodeHeaders function for getting header data without processing the body parts (thanks requaos.) - Test coverage over 90% (thanks requaos!) Changed - Update dependencies Fixed - Do not attempt to detect character set for short messages (#131, thanks requaos.) - Possible slice out of bounds error (#134, thanks requaos.) - Tests on Go 1.13 no longer fail due to textproto change (#137, thanks to requaos.)

view details

push time in 11 days

delete branch jhillyerd/enmime

delete branch : release/0.7.0

delete time in 11 days

push eventjhillyerd/enmime

James Hillyerd

commit sha 1ec10a5879a84d0b13cd9ccbe660efbf3c1644cc

Merge tag 'v0.6.0' into develop Added: - Make ParseMediaType public. Fixed: - Improve quoted display name handling (#112, thanks to requaos.) - Refactor MIME part boundary detection (thanks to requaos.) - Several improvements to MIME attribute decoding (thanks to requaos.) - Detect text/plain attachments properly (thanks to davrux.)

view details

James Hillyerd

commit sha 0f4ede24cbd55da4a5e938b6a898cd36b9271ec5

Update dependencies

view details

Neil

commit sha 3834172bce1f263d6170096b0454466f728c6d6e

include rune count minimum for chardet

view details

Neil

commit sha b1b363610e44b97ee3d06f19df38f1f4885578db

reverted test modifications to original values, chardet doesn't have enough data

view details

Neil

commit sha 221d76c304e3afd280ae0913160fecb2eb3fc178

added testdata for chardet success testing

view details

Neil

commit sha 51ed44ec39b1f7e7ff1a7ef9f539b3d57131b983

Merge pull request #132 from requaos/requaos/chardetcharlimit #131 include rune count minimum for chardet

view details

Neil

commit sha d24345a2fa08197d230a1f2c9b81a251ed19afad

added public DecodeHeaders package-level function (#133)

view details

Neil

commit sha b5e158451d20c5a756cbc5ab6175ed7cd5f8f7ce

use rfc2047decode in fixMangledMediaType for #134

view details

Neil

commit sha f750ad6b174c517587efa22a1aa2f6f7bf62146e

include go 1.13 in travis-ci testing

view details

Neil

commit sha d9268eb778cde3bb80c27f39aa3b22dd3a4a9b96

prefilter case for textproto input

view details

Neil

commit sha 7d95f55019bca3a42df416b82acd419c0b5afe6c

Merge pull request #136 from requaos/requaos/consolidaterfc2047decoder use rfc2047decode in fixMangledMediaType for #134

view details

Neil

commit sha 16ee96ea1182bd969268071a06c1792afa03a0ec

Increase test coverage (#138) * envelope tests * encode coverage * inspect coverage * refactor mapLatinSpecial to use a hashmap instead of switch

view details

James Hillyerd

commit sha 7a7cd4428806825f5094d3da690f52435397e718

Update change log

view details

James Hillyerd

commit sha 9c98ce6d9158470a9fe756ebec7ec26669489d78

Update change log for 0.7.0

view details

James Hillyerd

commit sha 39591e3f29fe611a24bd1ea41dec26feccfc8d3e

Merge branch 'release/0.7.0'

view details

push time in 11 days

create barnchjhillyerd/enmime

branch : release/0.7.0

created branch time in 11 days

push eventjhillyerd/enmime

James Hillyerd

commit sha 7a7cd4428806825f5094d3da690f52435397e718

Update change log

view details

push time in 11 days

push eventjhillyerd/enmime

Neil

commit sha 16ee96ea1182bd969268071a06c1792afa03a0ec

Increase test coverage (#138) * envelope tests * encode coverage * inspect coverage * refactor mapLatinSpecial to use a hashmap instead of switch

view details

push time in 11 days

PR merged jhillyerd/enmime

Reviewers
Increase test coverage

Just trying to get that test coverage number up

+618 -62

4 comments

18 changed files

requaos

pr closed time in 11 days

pull request commentjhillyerd/enmime

Increase test coverage

Amazing! I wasn't even sure it was possible to get to 90% for us.

requaos

comment created time in 11 days

pull request commentjhillyerd/plugin-git

Add git switch and restore alias (#29)

Thanks!

BruceZhang1993

comment created time in 17 days

push eventjhillyerd/plugin-git

Bruce Zhang

commit sha a636bc29e795fa8cbc6f6d0491dce40f8ac68930

Add git switch and restore alias (#29) (#30) * Add git switch and restore alias

view details

push time in 17 days

PR merged jhillyerd/plugin-git

Add git switch and restore alias (#29)
  • git switch
  • git switch -c
  • git restore
  • git restore --source
+8 -0

1 comment

2 changed files

BruceZhang1993

pr closed time in 17 days

delete branch jhillyerd/plugin-git

delete branch : develop

delete time in 17 days

Pull request review commentjhillyerd/plugin-git

Add git switch and restore alias (#29)

 $ omf install https://github.com/jhillyerd/plugin-git | gmt          | `git mergetool --no-prompt`                                 | | grh          | `git reset HEAD`                                            | | grhh         | `git reset HEAD --hard`                                     |+| grs          | `git restore`                                               |+| grss         | `git restore --source`                                               |

Column is too wide. Might have been from the use of tabs; if so, please convert to spaces.

BruceZhang1993

comment created time in 17 days

Pull request review commentjhillyerd/plugin-git

Add git switch and restore alias (#29)

 abbr -a gstd       git stash drop abbr -a gstp       git stash pop abbr -a gsts       git stash show --text abbr -a gsu        git submodule update+abbr -a gsw        git switch+abbr -a gswc       git switch -c

Yes, please use long form option names where feasible.

BruceZhang1993

comment created time in 17 days

pull request commentjhillyerd/plugin-git

Add commands

Thanks!

MartinDelille

comment created time in 22 days

push eventjhillyerd/plugin-git

Martin Delille

commit sha 11670278200327d6cac9244e3464d377b3494935

Add commands (#28) * Add gsu: git submodule update * Add gpan: git branch -a -v --no-merged * Add glom: git log --online --decorate --color master..

view details

push time in 22 days

PR merged jhillyerd/plugin-git

Add commands
gsu: git submodule update
gban: git branch -a -v --no-merged 
+6 -0

4 comments

2 changed files

MartinDelille

pr closed time in 22 days

pull request commentjhillyerd/plugin-git

Add commands

Can you add gban and gsu to the README as well? Thanks.

MartinDelille

comment created time in 23 days

push eventjhillyerd/plugin-git

Martin Delille

commit sha cc48b1b39bc04582641bb8c75dde0bf786370434

more verbose glr command (#27)

view details

push time in 23 days

PR merged jhillyerd/plugin-git

More verbose glr command

After looking at #26, I wasn't sure what git pull -r was doing and decided to propose the longer form git pull --rebase for more clarity.

I would suggest using long option in the future for more clarity.

+2 -2

0 comment

2 changed files

MartinDelille

pr closed time in 23 days

pull request commentjhillyerd/plugin-git

Add commands

Away from computer for a couple weeks

On Mon, Nov 4, 2019, 7:29 PM Martin Delille notifications@github.com wrote:

@jhillyerd https://github.com/jhillyerd any feedback on these new commands?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jhillyerd/plugin-git/pull/28?email_source=notifications&email_token=AATDAUCO75EIYKY3SPR2FHTQR72PXA5CNFSM4JHKQBBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC6ZGUQ#issuecomment-549294930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATDAUHNZL7ZYJEGG4I6KFDQR72PXANCNFSM4JHKQBBA .

MartinDelille

comment created time in a month

pull request commentNixOS/nixpkgs

chezmoi: 1.5.5 -> 1.7.2

I don't think it's a good idea to upgrade as the current version is using temporary packages in go.mod. Future builds would fail when those repos are deleted

On Sat, Nov 2, 2019, 1:04 AM ofborg[bot] notifications@github.com wrote:

@ofborg https://github.com/ofborg[bot] requested your review on: #72435 https://github.com/NixOS/nixpkgs/pull/72435 chezmoi: 1.5.5 -> 1.7.2.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NixOS/nixpkgs/pull/72435?email_source=notifications&email_token=AATDAUAKA3VTFGD63DLTD23QRRHPHA5CNFSM4JH4EPGKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUS5GBOY#event-2763677883, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATDAUEABEMIO7ASEEXRXLDQRRHPHANCNFSM4JH4EPGA .

marsam

comment created time in a month

issue commentjhillyerd/enmime

go test fails from master

I'm traveling, so I can't make any changes for a couple weeks

On Fri, Nov 1, 2019, 11:41 PM Till Knuesting notifications@github.com wrote:

would you consider a hot-fix or what is your ETA? I am hesitant to use a library where the tests are not working.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jhillyerd/enmime/issues/137?email_source=notifications&email_token=AATDAUCP3T2NFGD7NPTLL6DQRQ5ZPA5CNFSM4JHJCF2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3DSKY#issuecomment-548813099, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATDAUBU6LQ57OQ42VQECODQRQ5ZPANCNFSM4JHJCF2A .

tegk

comment created time in a month

Pull request review commentNixOS/nixpkgs

services.xserver.imwheel: add module

+{ config, lib, pkgs, ... }:++with lib;++let+  cfg = config.services.xserver.imwheel;+in+  {+    options = {+      services.xserver.imwheel = {+        enable = mkEnableOption "IMWheel service";++        options = mkOption {+          type = types.listOf types.str;+          default = ["-d" "-b 45" "--kill"];

I like long form also.

turboMaCk

comment created time in a month

Pull request review commentNixOS/nixpkgs

services.xserver.imwheel: add module

 stdenv.mkDerivation rec {    buildInputs = [ libX11 libXext libXi libXmu libXt libXtst ]; -  postPatch = ''-    substituteInPlace Makefile.in --replace "ETCDIR = " "ETCDIR = $out"-    substituteInPlace util.c --replace "/etc/X11/imwheel" "$out/etc/X11/imwheel"-  '';+  installFlags = ["sysconfdir=/etc" "ETCDIR=/etc" ];

nit: inconsistent spacing around brackets

turboMaCk

comment created time in a month

Pull request review commentNixOS/nixpkgs

services.xserver.imwheel: add module

+{ config, lib, pkgs, ... }:++with lib;++let+  cfg = config.services.xserver.imwheel;+in+  {+    options = {+      services.xserver.imwheel = {+        enable = mkEnableOption "IMWheel service";++        options = mkOption {+          type = types.listOf types.str;+          default = ["-d" "-b 45" "--kill"];

nit: why mix long and short argument forms?

turboMaCk

comment created time in a month

startedarpruss/USBComposite_stm32f1

started time in a month

pull request commentNixOS/nixpkgs

services.xserver.imwheel: add module

I haven't done services yet with NixOS, so I'm probably not the best to review. One comment though: could we make -d mandatory instead of default, so that imwheel never daemonizes itself, and drop the ExecStop=pkill line?

turboMaCk

comment created time in 2 months

pull request commentjhillyerd/plugin-git

Add git pull -r commands "glr"

Thanks!

yingkong1987

comment created time in 2 months

push eventjhillyerd/plugin-git

yingkong1987

commit sha c0e76a02f752fcab223b4f515423582dedcaa703

Add git pull -r commands "glr" (#26) * Add git pull -r commands * supplemental readme. add `git pull -r`

view details

push time in 2 months

pull request commentjhillyerd/plugin-git

Add git pull -r commands

Thanks, can you also add it to the README so others are aware of it?

yingkong1987

comment created time in 2 months

startedrust-embedded/awesome-embedded-rust

started time in 2 months

issue commentinbucket/inbucket

Multiple accept domains are treated as relays

Sometimes I prefix the command I am trying to run with echo to get an idea of what the shell is expanding things to.

poblabs

comment created time in 2 months

issue commentinbucket/inbucket

Multiple accept domains are treated as relays

What OS are you running on? In general Unix shells will not pass on double quotes specified on the command line; they just allow you to have spaces. If something about the way you are pasting is converting them to special quotes outside of normal ASCII (like MS Word smart quotes does), that would cause issues.

poblabs

comment created time in 2 months

issue commentinbucket/inbucket

Multiple accept domains are treated as relays

Can you test without the spaces to see if it has an impact? If that doesn't fix it, if you are using INBUCKET_MAILBOXNAMING="domain" can you also test with "full" or "local" and see if that impacts the result.

poblabs

comment created time in 2 months

push eventjhillyerd/dotvim

James Hillyerd

commit sha d9c563f461ea664568d3d6816e44e95dcba1fa68

rust: test runners

view details

push time in 2 months

issue commentinbucket/inbucket

Monitor does not show old messages after restart

Correct, no auto refresh on for the inbox page at this time. The back end already supports it (for new messages), but the front end does not yet use it.

poblabs

comment created time in 2 months

issue commentinbucket/inbucket

Monitor does not show old messages after restart

In case it wasn't clear, you have to enable the unified domain inbox if you want to use it.

Yes, go ahead an open an issue for the deleted messages leading to 400s, that's something I'd like to fix eventually; and will be a precursor to live-updating mailbox content.

poblabs

comment created time in 2 months

issue commentinbucket/inbucket

Monitor does not show old messages after Docker restart when using volume

You may also find the feature added in #139 (available in current beta release) helpful, as it collapses all inbound emails to just their domain name and uses that as the mailbox.

There does seem to be enough interest in persisting the monitor log that I think it should be added in the future.

poblabs

comment created time in 2 months

issue commentinbucket/inbucket

Monitor does not show old messages after Docker restart when using volume

Yes, there is a similar conversation on #137 - but glad to have a dedicated issue for it. Here's a lightly edited copy of my previous response:

What you describe isn't a bug, currently by design but I am open to more feedback.

  1. Most of what you see in the monitor tab is actually being cached by your browser. Only INBUCKET_WEB_MONITORHISTORY (default 30) are stored in server memory. Restarting Inbucket will clear that.
  2. Even the number of stored emails is calculated at runtime (they are counted during the retention scanner run), and won't be immediately available at server startup.

Given that your Inbucket isn't being shutdown cleanly, it might require some sort of rolling journal of received mail. A periodic checkpoint may not run often enough. One of my goals for Inbucket is to keep performance high, so this would require some more thought.

poblabs

comment created time in 2 months

push eventjhillyerd/dotfiles

James Hillyerd

commit sha d7698114e1f195491de6912141ba8ed24aacc0ac

omf: add .cargo/bin to path

view details

push time in 2 months

push eventjhillyerd/dotfiles

James Hillyerd

commit sha 6d5d66ff18e3c88f482a30d6eea6220247fed34a

Add local config template

view details

James Hillyerd

commit sha 80f3bbdad85da23cafed2145914d64a86c94baa4

xsession: mouse stuff only on desktops

view details

push time in 2 months

push eventjhillyerd/dotvim

James Hillyerd

commit sha 2b81b2188e7d1be95a13619f384f2aeed20fbe82

add rust language support

view details

push time in 2 months

push eventjhillyerd/nixfiles

James Hillyerd

commit sha 0d95460eb372472895a7e86c0d2b8a9ea33b4216

common: add imwheel

view details

push time in 2 months

push eventjhillyerd/dotvim

James Hillyerd

commit sha 5e8861d1fe677584527cd7c652c1eab70ca53fc2

term: make nvim auto insert, auto close

view details

push time in 2 months

pull request commentinbucket/inbucket

Fix var name for tls cert

Thanks!

mcfedr

comment created time in 3 months

push eventinbucket/inbucket

Fred Cox

commit sha 12802e93cb71c3a7758314ff0c493fedad5a398a

Fix var name for tls cert (#146)

view details

push time in 3 months

PR merged inbucket/inbucket

Fix var name for tls cert
+1 -1

0 comment

1 changed file

mcfedr

pr closed time in 3 months

issue commentbetaflight/blackbox-log-viewer

No lines in graph

I've never installed or run the black box explorer before today, and ran into this issue. v3.3.1 win32 on Win 10

flatwound

comment created time in 3 months

issue commentinbucket/inbucket

Allow a specific password to be setup for accessing POP3

I think SHA-512 + salt is a good plan. I think we should hard code the iterations and prefix the salt on the hash such that we only need one environment variable for this; Inbucket configuration is daunting enough for new users, I'd rather not add three.

MatthewJohn

comment created time in 3 months

issue commentinbucket/inbucket

Allow a specific password to be setup for accessing POP3

I think that's reasonable. I'd rather it were stored hashed in the env variable rather than plain text. Ideally a hash with a javascript implementation, so we could add it to the configurator.

MatthewJohn

comment created time in 3 months

pull request commentjhillyerd/enmime

WIP: Line wrapping for text/plain content

Thinking about this a bit... the only reason to force a wrap before 76-80 characters is to improve the readability of the text in a plain text email program, or when viewing the source - if we split the line in the middle of the word, we aren't improving the readability.

It may be better to pick an wider (but <= 998) number so that if the email is wrapped at something slightly higher than 76, we allow it to pass through, otherwise we hard wrap to remain compliant with the spec.

There is some interesting reading in rfc3676 4.2, but I don't know much about format=flowed.

requaos

comment created time in 3 months

push eventjhillyerd/enmime

Neil

commit sha d24345a2fa08197d230a1f2c9b81a251ed19afad

added public DecodeHeaders package-level function (#133)

view details

push time in 3 months

PR merged jhillyerd/enmime

Reviewers
added public HumanHeadersOnly package-level function

#64 Proposed Solution

Obviously the function name is up for debate, but this is the general flow I noticed that the main lib doesn't yet support recursive rfc2047 encoded header values, so that will need to get incorporated into the ReadEnvelope flow as well

+352 -1

6 comments

4 changed files

requaos

pr closed time in 3 months

pull request commentjhillyerd/enmime

added public HumanHeadersOnly package-level function

Thanks!

requaos

comment created time in 3 months

issue commentinbucket/inbucket.org

Question: How to edit configurator

Yes, it's part of this repo: https://github.com/inbucket/inbucket.org/tree/master/vue-configurator (vue is the JS framework it uses)

It looks like the Vue outputDir is already points to the root /configurator link, so I believe a npm run build will update that.

While you are in there, could you also run an npm audit fix + build, and send that as a separate PR? Cheers.

MatthewJohn

comment created time in 3 months

more