profile
viewpoint
John Resig jeresig @Khan Brooklyn, NY https://johnresig.com/ Chief Architect at @Khan

jeresig/dromaeo 71

JavaScript Performance Test Suite

jeresig/begin-app 5

Begin app

jeresig/brooklynjs.github.io 1

The world's most popular programming language, in New York's most popular borough

jeresig/dokku-bower-grunt-build-plugin 1

Add build steps for bower and grunt

jeresig/dokku-elasticsearch 1

Forked from: https://bitbucket.org/foldr/dokku-elasticsearch-plugin

PullRequestReviewEvent

startedKnapsackPro/knapsack-pro-jest

started time in 2 days

pull request commentfacebook/flow

(Updated again) Flowlint no floating promises

This is very exciting - we were talking about wanting this exact linter to use at Khan Academy. It would definitely help us to catch a lot of tricky bugs that would otherwise be nearly impossible to find. We likely won't be able to offer technical support but here is a huge 👍 to seeing this PR and hopefully it getting it merged in someday soon!

SebastienGllmt

comment created time in 6 days

push eventKhan/live-editor

John Resig

commit sha 612ad7b4d468ede50298e5cfe6fe70015a79c9ac

Remove global i18n references and support Node v12 (#741) We had a couple references to a global i18n object, but this is easy enough to fix! Also, in order to get the build running, I had to pin the version of graceful-fs to v4 and use npm-shrinkwrap.json to force the sub-dependencies to use it too. Issue: none Test plan: Hopefully this should "just work" inside Webapp?

view details

push time in 12 days

delete branch Khan/live-editor

delete branch : global-i18n

delete time in 12 days

PR merged Khan/live-editor

Reviewers
Remove global i18n references and support Node v12

We had a couple references to a global i18n object, but this is easy enough to fix!

Also, in order to get the build running, I had to pin the version of graceful-fs to v4 and use npm-shrinkwrap.json to force the sub-dependencies to use it too.

Issue: none

Test plan: Hopefully this should "just work" inside Webapp?

+20 -12

3 comments

3 changed files

jeresig

pr closed time in 12 days

PullRequestReviewEvent

pull request commentKhan/live-editor

Remove global i18n references and support Node v12

@pamelafox Done!

jeresig

comment created time in 12 days

push eventKhan/live-editor

Pamela Fox

commit sha 38e13cd634fb2111ee94f14d76dae5470f274804

Upgrade gulp to gulp 4 (#742)

view details

John Resig

commit sha cbcd6d022b09760fd4845bb4a05e8181b8ca30d9

Merge branch 'master' into global-i18n

view details

John Resig

commit sha 90ad65a21559ad6e928c21a8fdb895f011863bf0

Remove Node 12 changes.

view details

push time in 12 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventKhan/live-editor

John Resig

commit sha 0b55ce2c413269a7921a2ebedd4c806cc4bd1a8b

Switch to using Yarn.

view details

push time in 14 days

PR opened Khan/live-editor

Reviewers
Remove global i18n references and support Node v12

We had a couple references to a global i18n object, but this is easy enough to fix!

Also, in order to get the build running, I had to pin the version of graceful-fs to v4 and use npm-shrinkwrap.json to force the sub-dependencies to use it too.

Issue: none

Test plan: Hopefully this should "just work" inside Webapp?

+7324 -12

0 comment

5 changed files

pr created time in 14 days

create barnchKhan/live-editor

branch : global-i18n

created branch time in 14 days

PullRequestReviewEvent
PullRequestReviewEvent

starteddenverquane/MMM-Teslamate

started time in 19 days

startedadriankumpf/teslamate

started time in 19 days

PullRequestReviewEvent

push eventmongaku/mongaku

John Resig

commit sha 7ec06da961cb6b988a1db7c4398676879c3de958

Add ja flag.

view details

push time in 23 days

push eventmongaku/ukiyo-e.org

John Resig

commit sha c222419132e4a42db7bfb54114960dcbf71914cd

Add in translation file.

view details

John Resig

commit sha 90436b3a25dd5a15ae63fcf4d73cd0f832f265ce

Update mongaku.

view details

push time in 23 days

push eventmongaku/mongaku

John Resig

commit sha 6334afca4a24b859177180b6265a23f2370a047a

Show data imports if they already exist.

view details

John Resig

commit sha 5d6b1724b50e939992c94216f135e4df4d3cf13e

Remove logging statement.

view details

John Resig

commit sha 801a7633f329d2f42c2945ca4be69c1f68aa2004

Fix function parsing.

view details

push time in 23 days

push eventmongaku/ukiyo-e.org

John Resig

commit sha 522f71932f477ad27aae05339b3575290e3504f5

Update dependencies.

view details

push time in 23 days

push eventjeresig/node-romaji-name

John Resig

commit sha 7bf67d442b7e009fdf1a08f0a75465fc7083ca66

Update deps, bump version.

view details

push time in 23 days

push eventjeresig/node-enamdict

John Resig

commit sha af8732dea464e109c7120fb09b3cc16a8a13d321

Upgrade iconv, update DB, bump version.

view details

push time in 23 days

push eventmongaku/mongaku

John Resig

commit sha bde534843faa6f2d6e25678467422f8d42e7711b

Get working with the latest version of babel and Node 12.

view details

push time in 23 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentKhan/gerald

Added a way of running Regex patterns against the content of files changed

 describe('get filtered lists', () => {         ];         const fileDiffs = {'yaml.yml': 'this is a function that has added this test line'}; -        const {requiredReviewers, reviewers} = getReviewers(filesChanged, fileDiffs, 'yipstanley');-        const notified = getNotified(filesChanged, fileDiffs, 'pull_request');

Great, thank you!

yipstanley

comment created time in a month

Pull request review commentKhan/gerald

Moved gerald-tester to the Gerald repo

     "@babel/register": "^7.10.4",     "actions-utils": "Khan/actions-utils#v1.1.0",     "babel-eslint": "^10.1.0",+    "chalk": "2.4.2",

If chalk and prompts are only used for the tester then they should be devDependencies.

yipstanley

comment created time in a month

Pull request review commentKhan/gerald

Moved gerald-tester to the Gerald repo

     "@babel/register": "^7.10.4",     "actions-utils": "Khan/actions-utils#v1.1.0",     "babel-eslint": "^10.1.0",+    "chalk": "2.4.2",     "fast-glob": "^3.2.4",     "flow-bin": "0.124.0",     "jest": "^26.1.0",

Flow, Jest, and Prettier should also be devDependencies (missed this before!)

yipstanley

comment created time in a month

Pull request review commentKhan/gerald

Moved gerald-tester to the Gerald repo

     "@babel/register": "^7.10.4",     "actions-utils": "Khan/actions-utils#v1.1.0",     "babel-eslint": "^10.1.0",

babel-eslint should be a devDependency (since it's only used for linting)

yipstanley

comment created time in a month

Pull request review commentKhan/gerald

Added a way of running Regex patterns against the content of files changed

 describe('get filtered lists', () => {         ];         const fileDiffs = {'yaml.yml': 'this is a function that has added this test line'}; -        const {requiredReviewers, reviewers} = getReviewers(filesChanged, fileDiffs, 'yipstanley');-        const notified = getNotified(filesChanged, fileDiffs, 'pull_request');

It looks like these test changes are just making the existing code work - are there any tests for the new functionality?

yipstanley

comment created time in a month

push eventKhan/react-render-server

John Resig

commit sha 25d1147f36f6eed2ca460de1b2ff513641819c8c

Update README

view details

push time in 2 months

push eventKhan/jenkins-jobs

John Resig

commit sha a1a273f034bcb0c5d1acf16aa6eb409deba3bcdb

WEB-1883: Remove jenkins deploy/build setup for react-render-server Summary: We don't need this anymore! I'm not sure if this is enough though, I suspect that there may be other Jenkins config that we need to change? But I'm not sure where we would do that. We also need to delete the service from production but I don't think I have permission to do that: https://khanacademy.atlassian.net/browse/WEB-1882 Issue: https://khanacademy.atlassian.net/browse/WEB-1883 Test Plan: Not sure how to test this! Reviewers: #frontend-infrastructure, #sre, #devops, boris, davidbraley Reviewed By: #sre, #devops, boris, davidbraley Subscribers: davidbraley, csilvers, boris Differential Revision: https://phabricator.khanacademy.org/D65233

view details

push time in 2 months

created tagKhan/jenkins-jobs

tagphabricator/diff/261056

Scripts and the like that Jenkins jobs can run.

created time in 2 months

created tagKhan/jenkins-jobs

tagphabricator/base/261056

Scripts and the like that Jenkins jobs can run.

created time in 2 months

Pull request review commentKhan/gerald

Gerald will now run when comments are made

+// @flow++import {type Octokit$IssuesListCommentsResponseItem} from '@octokit/rest';++import {parseExistingComments} from './utils';+import {ownerAndRepo, context, extraPermGithub} from './setup';++const makeNewComment = (existingBody: string, removedJustNames: Array<string>): string => {+    let newComment = existingBody;+    // look through each of the names and see if the existing comment mentions these names+    for (const justName of removedJustNames) {+        const regex = new RegExp(`\n^@${justName}.*$\n`, 'gm');++        // if so, remove them. $TODO{Stanley} - remove review requests as well.

Is there a Jira task to track this?

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Gerald will now run when comments are made

 name: Gerald - Notify and Request Reviewers On Pull Request 'on':- - pull_request

What's the impact of this?

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Added a constants.js class

+// GitHub and GitHub Action Constants

I think if you add // @flow to the top of this file that'll fix the flow errors you see below.

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Added tests for the runPush function (see #19)

 export const runPush = async () => {         prevCommit = commitData.data.sha;     } };++export type __TestCommit = {+    author: '__testAuthor',+    comment_count: -1,+    committer: '__testCommitter',+    id: string,+    message: string,+    tree: '__TESTING__',+    url: '__TESTING__',+    verification: '__TESTING__',+};++type __TestContext = {|+    issue: {|owner: '__TESTING__', repo: '__TESTING__', number: -1|},+    payload: {|+        pull_request: {|base: {|ref: '__TESTING__'|}, user: {|login: '__testUser'|}|},+        before: string,+        after: string,+        commits: Array<__TestCommit>,+    |},+    actor: '__testActor',+|};+

A comment explaining why we're exporting these would be useful!

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Added tests for the runPush function (see #19)

 export const runPush = async () => {         prevCommit = commitData.data.sha;     } };++export type __TestCommit = {+    author: '__testAuthor',+    comment_count: -1,+    committer: '__testCommitter',+    id: string,+    message: string,+    tree: '__TESTING__',+    url: '__TESTING__',+    verification: '__TESTING__',+};++type __TestContext = {|

Is this extra type needed? It doesn't seem like it should be - the input should be about to be the same type as the Context, so we can remove this type and the __TestCommit type.

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Added tests for the runPush function (see #19)

 export const runPush = async () => {         prevCommit = commitData.data.sha;     } };++export type __TestCommit = {+    author: '__testAuthor',+    comment_count: -1,+    committer: '__testCommitter',+    id: string,+    message: string,+    tree: '__TESTING__',+    url: '__TESTING__',+    verification: '__TESTING__',+};++export type __TestObject = {+    context: __TestContext,+    testNotified: string,+};++type __TestContext = {|+    issue: {|owner: '__TESTING__', repo: '__TESTING__', number: -1|},+    payload: {|+        pull_request: {|base: {|ref: '__TESTING__'|}, user: {|login: '__testUser'|}|},+        before: string,+        after: string,+        commits: Array<__TestCommit>,+    |},+    actor: '__testActor',+|};++/**+ * @desc ONLY TO BE USED FOR TESTING. This is used to allow main.test.js to+ * retrieve commits. This is necessary because main.test.js mocks a lot of the+ * GitHub rest functions and "saves" commits into an object.+ */+export const __testGetCommit = async (commitSHA: string) => {+    return await extraPermGithub.git.getCommit({

Rather than making these methods and exporting them, it seems like it'd be better to export extraPermGithub and then you can do whatever calls you need on it to get the underlying data.

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Added tests for the runPush function (see #19)

 export const runPullRequest = async () => {     await updatePullRequestComment(megaComment, notified, reviewers, requiredReviewers); }; -export const runPush = async () => {+export const runPush = async (__testObject: ?__TestObject) => {

I think a better way to format this is to have it so that when runPush is called you always have to pass in the context.

And then for the testNotified - it looks like that's used to mock out the fs.readFileSync calls in getNotified. Probably the best way to fix this would be to make a file of fs utils, like fs.js that exports a method readFileSync (that calls `fs.readFileSync internally) and then you can easily mock that out using Jest.

IMO, anytime you see special logic for making code testable, that almost always feels like a problem, in that it could be resolved if the code was formatted in a different way or abstracted in a different way.

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Updated Gerald to be smarter about fetching/checking out

 jobs:     steps:       - uses: actions/checkout@v2         with:-          fetch-depth: 0-      - run: git fetch+          ref: '${{ github.ref }}'+          fetch-depth: '$(node -e "console.log(${{ github.event.commits.length }}.length + 1")'

Woah, this is very hacky! Haha - is it possible to leave a comment here explaining what's happening so that future folks know how to maintain it?

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Open Sourcing Gerald

+Copyright 2020 KhanAcademy
Copyright 2020 Khan Academy
yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Gerald setup files

+# Gerald Usage Documentation++Gerald is the project described under [ADR 356](https://docs.google.com/document/d/1TDE_nmrV3vuGi54HtC8X7irSMwTTcc9p83cuhH4kB6Y/edit#heading=h.zcx77itbdtis). The goal was to port over as much of the used Phabricator Herald functionality into Github Actions as possible.++This is the [JIRA Epic](https://khanacademy.atlassian.net/browse/WEB-2448) to track the progress of the Gerald project.++The code for the project exists in the [Gerald repository](https://github.com/Khan/gerald).++## Overview++Gerald is the name given to the custom Github Actions and code that reads in and handles **Notification Rules** and **Reviewer Rules** from the `.github/NOTIFIED` and `.github/REVIEWERS files`, respectively.++Every rule has a condition and a list of Github usernames or team slugs. Every time a pull request is made, Gerald will test the files changed and the squashed diff of the pull request against all of the rules in the NOTIFIED and REVIEWERS files. Rules that test positive against the pull request are pulled into a list of notifyees and reviewers, depending on the file that the rule exists in. People in this list will be mentioned on the pull request, and reviews will be requested from the list of reviewers.++Every time the pull request is updated, Gerald will rerun and update the pull request comments with a new list of notifyees and reviewers. Commenting #removeme on the pull request will stop Gerald from tagging you in the pull request.++## Adding a Rule++The two relevant files for Gerald are `.github/NOTIFIED` and `.github/REVIEWERS`. These files follow the [Github CODEOWNERS syntax](https://docs.github.com/en/enterprise/2.15/user/articles/about-code-owners#:~:text=CODEOWNERS%20syntax,org%2Fteam%2Dname%20format.). The only difference is that the order of a rule does not matter; no rules take precedence over others.

"The only difference" is not entirely true due to to the regex matching (as mentioned below). May be worth mentioning it here too!

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Gerald setup files

+# Gerald Usage Documentation++Gerald is the project described under [ADR 356](https://docs.google.com/document/d/1TDE_nmrV3vuGi54HtC8X7irSMwTTcc9p83cuhH4kB6Y/edit#heading=h.zcx77itbdtis). The goal was to port over as much of the used Phabricator Herald functionality into Github Actions as possible.++This is the [JIRA Epic](https://khanacademy.atlassian.net/browse/WEB-2448) to track the progress of the Gerald project.

I think eventually we'll want to remove some of the Khan Academy-specific links, if folks are interested in using this outside of KA, but for now this is ok!

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Gerald setup files

+# Gerald Usage Documentation++Gerald is the project described under [ADR 356](https://docs.google.com/document/d/1TDE_nmrV3vuGi54HtC8X7irSMwTTcc9p83cuhH4kB6Y/edit#heading=h.zcx77itbdtis). The goal was to port over as much of the used Phabricator Herald functionality into Github Actions as possible.++This is the [JIRA Epic](https://khanacademy.atlassian.net/browse/WEB-2448) to track the progress of the Gerald project.++The code for the project exists in the [Gerald repository](https://github.com/Khan/gerald).++## Overview++Gerald is the name given to the custom Github Actions and code that reads in and handles **Notification Rules** and **Reviewer Rules** from the `.github/NOTIFIED` and `.github/REVIEWERS files`, respectively.++Every rule has a condition and a list of Github usernames or team slugs. Every time a pull request is made, Gerald will test the files changed and the squashed diff of the pull request against all of the rules in the NOTIFIED and REVIEWERS files. Rules that test positive against the pull request are pulled into a list of notifyees and reviewers, depending on the file that the rule exists in. People in this list will be mentioned on the pull request, and reviews will be requested from the list of reviewers.
Every rule has a condition and a list of Github usernames or team slugs. Every time a pull request is made, Gerald will test the files changed, and the squashed diff of the pull request, against all of the rules in the NOTIFIED and REVIEWERS files. Rules that test positive against the pull request are pulled into a list of notifyees and reviewers, depending on the file that the rule exists in. People in this list will be mentioned on the pull request, and reviews will be requested from the list of reviewers.
yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Gerald setup files

+name: Notify and Request Reviewers On Push+'on':+  push:+    branches:+      - master+      - develop+      - main+jobs:+  gerald:+    runs-on: ubuntu-latest+    steps:+      - uses: actions/checkout@v2+        with:+          fetch-depth: 0

Same comment for the mobile repo - this is going to be super expensive to run for webapp, for example. If we are only reading the latest commit then we should probably remove this!

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Gerald setup files

+# Gerald Setup README++This file is intended to help you set up [Gerald](github.com/Khan/gerald) on an existing repository.++## Prerequisite Setup++Ensure that you have set up your GitHub repository with a [secret authentication token](https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets#creating-encrypted-secrets-for-a-repository) that has access to view teams, comment on commit messages and pull requests, and make review requests.++To take advantage of Gerald's Required Reviewers functionality, ensure that you have [OLC tools](github.com/Khan/our-lovely-cli) set up. If OLC tools are not set up, required reviewers will function no differently than reviewers, but Gerald is still usable.++Make a `.github/workflows/` folder if it doesn't already exist in your repository.++## Files Setup++1. Copy `gerald-pr.yml` and `gerald-push.yml` to the `.github/workflows` folder.+2. Change the `<SECRET TOKEN>` in line 14 of `gerald-pr.yml` and line 20 of `gerald-push.yml` to be the name of the secret authentication token that you set up in the Prerequisite Setup section.

I wonder if we should be more idiomatic here and give it a name GERALD_SECRET or some such, and tell folks to name it that when they set it up? (That way the file starts out as syntactically valid?)

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Gerald setup files

+[NOTIFY RULES]++Be sure to read through https://khanacademy.atlassian.net/wiki/spaces/FRONTEND/pages/598278672/Gerald+Documentation before adding any rules!++----Everything above this line will be ignored!----+[ON PULL REQUEST] (DO NOT DELETE THIS LINE)++# Notify these people for any changes made to any file+*

I notice here we have * and in the mobile repo we have **/*?

yipstanley

comment created time in 2 months

Pull request review commentKhan/render-gateway

[WEB-2197] Add error taxonomy

 export class JSDOMSixteenResourceLoader extends ResourceLoader {         super();          if (renderAPI == null) {-            throw new Error("Must provide render API.");+            throw new KAError("Must provide render API.", Errors.Internal);

InvalidInput here too?

somewhatabstract

comment created time in 2 months

Pull request review commentKhan/render-gateway

[WEB-2197] Add error taxonomy

 export class JSDOMSixteenEnvironment implements IRenderEnvironment {      */     constructor(configuration: IJSDOMSixteenConfiguration) {         if (configuration == null) {-            throw new Error("Must provide environment configuration");+            throw new KAError(+                "Must provide environment configuration",+                Errors.Internal,

InvalidInput here too.

somewhatabstract

comment created time in 2 months

Pull request review commentKhan/render-gateway

[WEB-2197] Add error taxonomy

 export class JSDOMSixteenConfiguration implements IJSDOMSixteenConfiguration {         registrationCallbackName?: string = "__jsdom_env_register",     ) {         if (typeof getFileList !== "function") {-            throw new Error(+            throw new KAError(                 "Must provide valid callback for obtaining file list",+                Errors.Internal,

These feel like InvalidInput to me (input from whomever is instantiating this!)

somewhatabstract

comment created time in 2 months

Pull request review commentKhan/render-gateway

[WEB-2197] Add error taxonomy

 export const getAgentForURL = (url: URL): HttpAgent | HttpsAgent => {             return new https.Agent(agentOptions);          default:-            throw new Error(`Unsupported protocol: ${url.protocol}`);+            throw new KAError(+                `Unsupported protocol: ${url.protocol}`,+                Errors.Internal,

Maybe InvalidInput?

somewhatabstract

comment created time in 2 months

Pull request review commentKhan/render-gateway

[WEB-2197] Add error taxonomy

+// @flow++/**+ * @typedef {Object} Errors The different errors in our error taxononomy.+ *+ * @property {ErrorKind} NotFound A resource was not found. If the resource+ * couldn't be retrieved due to access control use {@link Unauthorized}+ * instead. If the resource couldn't be found because the input was invalid use+ * {@link InvalidInput} instead.+ *+ * @property {ErrorKind} InvalidInput There was a problem with provided input,+ * such as the wrong format. This indicates inputs that are problematic+ * regardless of the state of the system. If the input was valid but caused+ * problems anyway consider {@link NotAllowed}.+ *+ * @property {ErrorKind} NotAllowed There was a problem due to the state of the+ * system not matching the requested operation or input. For example, trying to+ * create a username that is valid, but is already taken by another user. Use+ * {@link InvalidInput} instead when the input isn't valid regardless of+ * the state of the system. Use {@link NotFound} when the failure is due+ * to not being able to find a resource.+ *+ * @property {ErrorKind} Unauthorized There was an access control problem+ *+ * @property {ErrorKind} Internal The function failed for a reason unrelated+ * to invalid input or problems working with a remote system. This is the most+ * commonly used error kind.+ *+ * @property {ErrorKind} NotImplemented The function isn't implemented+ *+ * @property {ErrorKind} TransientService There was a problem when making a+ * request to a non-Khan service, e.g. datastore that might be resolvable by+ * retrying.+ *+ * @property {ErrorKind} Service There was a non-transient problem when making+ * a request to a non-Khan service, e.g. datastore.+ */++/**+ * @type {Errors} A utility for referencing our error taxonomy.+ */+export const Errors = Object.freeze({+    NotFound: "NotFound",+    InvalidInput: "InvalidInput",+    NotAllowed: "NotAllowed",+    Unauthorized: "Unauthorized",+    Internal: "Internal",+    NotImplemented: "NotImplemented",+    TransientService: "TransientService",+    Service: "Service",

Should we be keeping this in sync with some sort of central list that SRE has?

somewhatabstract

comment created time in 2 months

Pull request review commentKhan/gerald

Glob ignore folders are now parsed from the .geraldignore file of a repo

 import fs from 'fs'; import fg from 'fast-glob'; // flow-uncovered-line  import {execCmd} from './execCmd';++type NameToFiles = {[name: string]: string[], ...};++/**+ * @desc Read ./.geraldignore if it exists. Otherwise, read ./.gitignore.+ * Split the file by newlines to serve as the list of files/directories to+ * ignore for Gerald.+ */+const getGeraldIgnore = (): Array<string> => {+    if (fs.existsSync('.geraldignore')) {+        return fs.readFileSync('.geraldignore', 'utf-8').split('\n');+    } else if (fs.existsSync('.gitignore')) {+        return fs.readFileSync('.gitignore', 'utf-8').split('\n');+    }

I think you should split apart these if/elses and combine the result from both .geraldignore AND .gitignore. This way you don't need to re-ignore everything listed in .gitignore in your .geraldignore just because you have one.

yipstanley

comment created time in 2 months

Pull request review commentKhan/gerald

Switched from using glob to fast-glob

 describe('get notified', () => { [ON PULL REQUEST] (DO NOT DELETE THIS LINE)  .github/**          @githubUser-*.js                @yipstanley @githubUser+**/*.js             @yipstanley @githubUser

Ah, slightly different semantics!

yipstanley

comment created time in 2 months

startedcheckly/puppeteer-recorder

started time in 2 months

Pull request review commentKhan/render-gateway

Make memory usage traces more useful

 export const trace = (          * We disable this lint rule as the linter does not appear to          * understand the optional chaining.          */-        // eslint-disable-next-line flowtype/no-unused-expressions

huh - what fixed this?

somewhatabstract

comment created time in 3 months

push eventKhan/render-gateway

Jeff Yates

commit sha 0e2adf97be94b4429a925122210751c68ff0a6fc

Add missing tests and provide means to override resource loading result if we need to (#218) * Allow for resource loader to intercept results * Add missing test case for makeShouldRetry * Add test case for making sure we use resource loader with getFileList * Ignore heapdump setup from coverage data * Update build artifacts * Rollback superagent to 5.2.2 * Revert "Rollback superagent to 5.2.2" This reverts commit 2a463abc572139cdbd9a1d12cb853bad827ddfd9.

view details

John Resig

commit sha 317102fe226418e364dd573c0979982c44c1f4be

Merge branch 'master' into use-worker

view details

push time in 3 months

push eventKhan/render-gateway

dependabot-preview[bot]

commit sha 98f616c531a4ea79042eb023319d2042979dfd7f

Bump @babel/plugin-proposal-optional-chaining from 7.10.3 to 7.10.4 (#210)

view details

dependabot-preview[bot]

commit sha 0121a103e6975e33c1f28a1acea5647ae12e79cc

Bump @babel/plugin-proposal-class-properties from 7.10.1 to 7.10.4 (#213)

view details

dependabot-preview[bot]

commit sha 2209608fea835387c494b4da2c2b8ff56c69863c

Bump eslint-plugin-babel from 5.3.0 to 5.3.1 (#212)

view details

dependabot-preview[bot]

commit sha f124ad5ee78c02cf13374315d6ad6899dfa9fa9b

Bump @babel/core from 7.10.3 to 7.10.4 (#215)

view details

dependabot-preview[bot]

commit sha 8031df513cb086b43cf4cb6f24e4d226f68b1a65

Bump @babel/cli from 7.10.3 to 7.10.4 (#217)

view details

dependabot-preview[bot]

commit sha 04d61995c4106a21e36cfac5dc8bd51106de8548

Bump @babel/preset-flow from 7.10.1 to 7.10.4 (#211)

view details

dependabot-preview[bot]

commit sha e884f834ea5d98c8764f8cab804dc0715fd630c8

Bump eslint-plugin-react from 7.20.1 to 7.20.2 (#214)

view details

dependabot-preview[bot]

commit sha 5ea72b1003dce3e4f3e8b618fafd3e2f22263d99

Bump @babel/preset-env from 7.10.3 to 7.10.4 (#216)

view details

dependabot-preview[bot]

commit sha de4105f00e6da567c9a9db0e59de09040c13951f

Bump flow-bin from 0.127.0 to 0.128.0 (#206) Bumps [flow-bin](https://github.com/flowtype/flow-bin) from 0.127.0 to 0.128.0. - [Release notes](https://github.com/flowtype/flow-bin/releases) - [Commits](https://github.com/flowtype/flow-bin/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

John Resig

commit sha f9c49a5244fd6e06b428f8dd8a206f8299664247

Merge branch 'master' into use-worker

view details

push time in 3 months

push eventKhan/render-gateway

dependabot-preview[bot]

commit sha 53df6bd187e5ff1ef35ca71817cab6ee89ffc62a

Bump eslint-plugin-react from 7.20.0 to 7.20.1 (#207)

view details

dependabot-preview[bot]

commit sha 08bf96fb82bd24c9482adc8642cb289f2ebc10f0

Bump eslint-plugin-import from 2.21.2 to 2.22.0 (#208)

view details

dependabot-preview[bot]

commit sha 76f32ef04160468f422a2bdd3bd0146131be74be

Bump superagent from 5.2.2 to 5.3.1 (#209)

view details

Jeff Yates

commit sha 04e6c9f2021f67283dccb102148b96d4c754da1c

Make sure the resource loader is getting closed (#205) * Make sure the resource loader is getting closed * Update tests * Update build * Make the headers type have the ...

view details

John Resig

commit sha 410683a62eefce5450582889fea7f960d5dcb58e

Merge branch 'master' into use-worker

view details

push time in 3 months

push eventKhan/render-gateway

John Resig

commit sha 34faf7f3ad1fdb81dc098b4c4d1a36ae28210368

Revert "WEB-2510: Pass headers through in render API (#203)" This reverts commit 7b4b27c04e6216152825e0a4c70f79a6481f36e4.

view details

John Resig

commit sha 3323a44e638bc9443281e63eb80821a6bfcc99b5

Revert "Revert "WEB-2510: Pass headers through in render API (#203)"" This reverts commit 34faf7f3ad1fdb81dc098b4c4d1a36ae28210368.

view details

push time in 3 months

push eventKhan/render-gateway

John Resig

commit sha 34faf7f3ad1fdb81dc098b4c4d1a36ae28210368

Revert "WEB-2510: Pass headers through in render API (#203)" This reverts commit 7b4b27c04e6216152825e0a4c70f79a6481f36e4.

view details

push time in 3 months

create barnchKhan/render-gateway

branch : use-worker

created branch time in 3 months

more