profile
viewpoint
James Munro jdmunro @datacamp Leamington Spa, United Kingdom https://jdmunro.net Javascript Software Engineer @datacamp. React Native app developer. Games industry refugee. Always learning.

datacamp/datacamp-light 967

Convert any blog or website to an interactive learning platform for data science

jdmunro/apollo-link-state-counter-example 6

A simple incrementing counter example for apollo-link-state

datacamp/react-native-snowplow-tracker 1

React Native bindings for the mobile Snowplow Tracker SDKs

jdmunro/cocos2d-iphone 1

cocos2d for iPhone

jdmunro/mpdas 1

MPD AudioScrobbler written in C++ using libcurl

datacamp-engineering/facebook-android-sdk 0

Used to integrate Android apps with Facebook Platform.

jdmunro/apollo-client 0

:rocket: A fully-featured, production ready caching GraphQL client for every server or UI framework

jdmunro/beacon-finder 0

A simple app project designed to demonstrate iBeacon capabilities.

jdmunro/cocos2d-x 0

cocos2d for iOS, Android, Win32 and OS X. Built using C++

created tagdatacamp/datacamp-light

tagv3.0.0-beta.2

Convert any blog or website to an interactive learning platform for data science

created time in 4 hours

release datacamp/datacamp-light

v3.0.0-beta.2

released time in 4 hours

created tagdatacamp/datacamp-light

tagv2.3.0

Convert any blog or website to an interactive learning platform for data science

created time in 4 hours

release datacamp/datacamp-light

v2.3.0

released time in 4 hours

push eventdatacamp/datacamp-light

Jeroen Hermans

commit sha a7c7022b53798d5e6c569d2b15bb72415609d8ac

💄 update: rebrand the application

view details

push time in 5 hours

push eventdatacamp/datacamp-light

James Munro

commit sha 09a1b3cd617e7a1b8482fb321ddecef03a40571c

💄 update: rebrand the application

view details

push time in 5 hours

startedMinaSamir11/react-native-in-app-review

started time in 2 months

startedkusti8/proton-native

started time in 2 months

startedVSCodium/vscodium

started time in 2 months

startedaristocratos/bpytop

started time in 2 months

startedlightningnetwork/lnd

started time in 2 months

starteddylanaraps/neofetch

started time in 2 months

startedonivim/oni2

started time in 2 months

startedtc39/proposal-pipeline-operator

started time in 2 months

issue commentjdmunro/react-native-spotlight-search

TypeScript definitions

Hey @whalemare - sure I'd be happy to include those!

whalemare

comment created time in 2 months

startedspotify/XCLogParser

started time in 2 months

startedsickcodes/Docker-OSX

started time in 2 months

startedmarmelab/json-graphql-server

started time in 2 months

startedcli/cli

started time in 2 months

startedromefrontend/rome

started time in 2 months

startedandpor/react-native-sqlite-storage

started time in 2 months

pull request commentardaogulcan/react-native-keyboard-accessory

Add a TypeScript module definition

No worries at all - hope you had a nice vacation 😁🚀

jdmunro

comment created time in 3 months

delete branch jdmunro/react-native-keyboard-accessory

delete branch : typescript-definition

delete time in 3 months

delete branch jdmunro/DefinitelyTyped

delete branch : react-native-calendars/missing-prop

delete time in 3 months

pull request commentDefinitelyTyped/DefinitelyTyped

react-native-calendars: Add missing enableSwipeMonths prop

Ready to merge

jdmunro

comment created time in 3 months

startedwixplosives/sample-monorepo

started time in 3 months

startedwinkjs/wink-nlp

started time in 3 months

pull request commentardaogulcan/react-native-keyboard-accessory

Add a TypeScript module definition

@ardaogulcan No worries at all 😄 enjoy your vacation! 🏖️

jdmunro

comment created time in 3 months

pull request commentardaogulcan/react-native-keyboard-accessory

Add a TypeScript module definition

Hey @ardaogulcan are you interested in merging these type definitions into the repo? If you'd prefer not to, I can submit them to DefinitelyTyped instead. Thanks!

jdmunro

comment created time in 3 months

pull request commentDefinitelyTyped/DefinitelyTyped

react-native-calendars: Add missing enableSwipeMonths prop.

Indeed that's much simpler @Tyler-Zhang - I've made the changes thanks!

jdmunro

comment created time in 3 months

push eventjdmunro/DefinitelyTyped

James Munro

commit sha 96d7063b1b6df70a76194ea88d719639adb4ff65

react-native-calendars: Add missing enableSwipeMonths prop.

view details

push time in 3 months

PR opened DefinitelyTyped/DefinitelyTyped

react-native-calendars: Add missing enableSwipeMonths prop.

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).
  • [x] Provide a URL to documentation or source code which provides context for the suggested changes:
  • https://github.com/wix/react-native-calendars/search?q=enableSwipeMonths&unscoped_q=enableSwipeMonths
  • [x] Include tests for your changes

A little more explanation for the changes:

  • We cannot simply use CalendarBaseProps for CalendarListBaseProps directly anymore because enableSwipeMonths is not compatible with CalendarList. Therefore I opted to pick the properties we actually want, rather than trying to exclude only the one we don't - it's a bit safer this way for future versions. Happy to reimplement this if other's disagree though 😄
+37 -1

0 comment

2 changed files

pr created time in 3 months

create barnchjdmunro/DefinitelyTyped

branch : react-native-calendars/missing-prop

created branch time in 3 months

fork jdmunro/DefinitelyTyped

The repository for high quality TypeScript type definitions.

fork in 3 months

pull request commentjerson/react-native-fast-openpgp

Fix a postinstall bug when running yarn remove

@jerson Awesome, thank you!

jdmunro

comment created time in 3 months

pull request commentjerson/react-native-fast-openpgp

Fix a postinstall bug when running yarn remove

Hey @jerson - would you mind publishing a patch release?

jdmunro

comment created time in 3 months

Pull request review commentardaogulcan/react-native-keyboard-accessory

Add a TypeScript module definition

+import { ViewStyle, LayoutAnimationConfig } from "react-native";+import { ReactNode } from "react";++interface KeyboardAccessoryViewProps {+  style?: ViewStyle;+  animateOn?: "ios" | "android" | "all" | "none";+  animationConfig?: (() => LayoutAnimationConfig) | LayoutAnimationConfig;+  alwaysVisible?: boolean;+  bumperHeight?: number;+  visibleOpacity?: number;+  onKeyboardShowDelay?: boolean | number;+  hiddenOpacity?: number;+  hideBorder?: boolean;+  inSafeAreaView?: boolean;+  androidAdjustResize?: boolean;+  avoidKeyboard?: boolean;+  children:+    | (({ isKeyboardVisible }: { isKeyboardVisible: boolean }) => ReactNode)+    | ReactNode;+}++export declare const KeyboardAccessoryView: React.ComponentType<KeyboardAccessoryViewProps>;++type ArrowDirection = "down" | "up" | "right" | "left";++interface KeyboardAccessoryNavigationProps extends KeyboardAccessoryViewProps {+  doneButtonTitle?: string;+  tintColor?: string;+  doneButton?: ReactNode;+  nextButton?: ReactNode;+  previousButton?: ReactNode;+  infoContainer?: ReactNode;+  doneDisabled?: boolean;+  nextDisabled?: boolean;+  previousDisabled?: boolean;+  doneHidden?: boolean;+  nextHidden?: boolean;+  previousHidden?: boolean;+  accessoryStyle?: ViewStyle;+  doneButtonStyle?: ViewStyle;+  doneButtonTitleStyle?: ViewStyle;+  infoMessageStyle?: ViewStyle;+  previousButtonStyle?: ViewStyle;+  nextButtonStyle?: ViewStyle;+  nextButtonDirection?: ArrowDirection;+  previousButtonDirection?: ArrowDirection;+  onDone?: () => void;+  onNext?: () => void;+  onPrevious?: () => void;+}++export declare const KeyboardAccessoryNavigation: React.ComponentType<KeyboardAccessoryNavigationProps>;++interface KeyboardAwareTabBarComponentProps {+  TabBarComponent: React.ComponentType<any>;+  [x: string]: any;

I think that's fair - this also seems to be one of the lesser used components in this package.

jdmunro

comment created time in 3 months

push eventjdmunro/react-native-keyboard-accessory

James Munro

commit sha da8495351701d734ad61bd1dc7ae4b3bdacf1e81

Add a TypeScript module definition.

view details

push time in 3 months

push eventjdmunro/react-native-keyboard-accessory

James Munro

commit sha f99d2547b898d6797dca41c3b6ef51406b30709b

Add a TypeScript module definition.

view details

push time in 3 months

Pull request review commentardaogulcan/react-native-keyboard-accessory

Add a TypeScript module definition

+import { ViewStyle, LayoutAnimationConfig } from "react-native";+import { ReactNode } from "react";++interface KeyboardAccessoryViewProps {+  style?: ViewStyle;+  animateOn?: "ios" | "android" | "all" | "none";+  animationConfig?: (() => LayoutAnimationConfig) | LayoutAnimationConfig;+  alwaysVisible?: boolean;+  bumperHeight?: number;+  visibleOpacity?: number;+  onKeyboardShowDelay?: boolean | number;+  hiddenOpacity?: number;+  hideBorder?: boolean;+  inSafeAreaView?: boolean;+  androidAdjustResize?: boolean;+  avoidKeyboard?: boolean;+  children:+    | (({ isKeyboardVisible }: { isKeyboardVisible: boolean }) => ReactNode)+    | ReactNode;+}++export declare const KeyboardAccessoryView: React.ComponentType<KeyboardAccessoryViewProps>;++type ArrowDirection = "down" | "up" | "right" | "left";++interface KeyboardAccessoryNavigationProps extends KeyboardAccessoryViewProps {+  doneButtonTitle?: string;+  tintColor?: string;+  doneButton?: ReactNode;+  nextButton?: ReactNode;+  previousButton?: ReactNode;+  infoContainer?: ReactNode;+  doneDisabled?: boolean;+  nextDisabled?: boolean;+  previousDisabled?: boolean;+  doneHidden?: boolean;+  nextHidden?: boolean;+  previousHidden?: boolean;+  accessoryStyle?: ViewStyle;+  doneButtonStyle?: ViewStyle;+  doneButtonTitleStyle?: ViewStyle;+  infoMessageStyle?: ViewStyle;+  previousButtonStyle?: ViewStyle;+  nextButtonStyle?: ViewStyle;+  nextButtonDirection?: ArrowDirection;+  previousButtonDirection?: ArrowDirection;+  onDone?: () => void;+  onNext?: () => void;+  onPrevious?: () => void;+}++export declare const KeyboardAccessoryNavigation: React.ComponentType<KeyboardAccessoryNavigationProps>;++interface KeyboardAwareTabBarComponentProps {+  TabBarComponent: React.ComponentType<any>;+  [x: string]: any;

Do you have a suggestion for this one? It's not clear how to type this, given that the props are passed through: https://github.com/ardaogulcan/react-native-keyboard-accessory/blob/master/src/KeyboardAwareTabBarComponent.js#L45 It might be possible to do something with generics, but it's not so straight forward.

jdmunro

comment created time in 3 months

startedtvler/experimental-react-like-framework

started time in 3 months

startedformium/tsdx

started time in 3 months

push eventjdmunro/react-native-keyboard-accessory

James Munro

commit sha 477d9267d2e80dd18b4d725950bf68a3a151d9db

Add a TypeScript module definition.

view details

push time in 3 months

push eventjdmunro/react-native-keyboard-accessory

James Munro

commit sha 3030232585063ea0bf561703087701d1db854335

Add a TypeScript module definition.

view details

push time in 3 months

PR opened ardaogulcan/react-native-keyboard-accessory

Add a TypeScript module definition

Adds a TS module definition based on the documentation and prop types.

The type for KeyboardAwareTabBarComponent could be improved (the pass-through props will be untyped, essentially) but it should not cause any problems.

You'll need to make sure index.d.ts is included in the nom package when publishing.

+58 -0

0 comment

1 changed file

pr created time in 3 months

create barnchjdmunro/react-native-keyboard-accessory

branch : typescript-definition

created branch time in 3 months

fork jdmunro/react-native-keyboard-accessory

A React Native Keyboard Accessory (View, Navigation) Component. Sticky views on keyboard.

fork in 3 months

startedYomguithereal/react-blessed

started time in 3 months

startedRigellute/spotify-tui

started time in 3 months

more