profile
viewpoint
James Bowes jbowes @manifoldco Halifax, NS http://repl.ca CTO @ @manifoldco Father, husband, secret hip-hop icon 🎤 💙 I like @golang, @kubernetes, and shiny things.

badges/buckler 298

Go library and CLI for making Shields-style badges (PNG)

jbowes/cl-eye-catching-uis 32

GopherCon 2018 tutorial session slides and examples

jbowes/cpsn 6

Query PSN Friend status from the CLI

jbowes/cling 5

Clear and obvious wrapping for Go error values

dgoodwin/rounder 2

Poker for your GNOME desktop.

dgoodwin/wuja 2

Google Calendar integration for your GNOME desktop.

jbowes/akimbo 1

Agile process management tool

jbowes/content-set-packer 1

Design and Sample Implementation for Candlepin's content set packing

fork jbowes/docusaurus

Easy to maintain open source documentation websites.

https://docusaurus.io

fork in 8 days

PR opened LoginRadius/go-saml

Add support for SHA-1 in responses

Use the SigningAlgorithm and DigestAlgorithm fields on IdentityProvider to configure digest and signing algorithms for responses. If not set, the default of SHA256 and RSA-SHA256 will be used.

closes #1

+55 -6

0 comment

4 changed files

pr created time in 25 days

create barnchjbowes/go-saml

branch : add-sha1-support

created branch time in 25 days

fork jbowes/go-saml

High Level API Implementation of SAML 2.0 (Currently Supported Identity Provider Implementation) Single Sign On

fork in 25 days

release manifoldco/promptui

v0.8.0

released time in a month

created tagmanifoldco/promptui

tagv0.8.0

Interactive prompt for command-line applications

created time in a month

push eventmanifoldco/promptui

James Bowes

commit sha 981a3cab68f6f3481bf42c6a98521af7fbd14fae

Update changelog for v0.8.0

view details

push time in a month

push eventmanifoldco/promptui

Sean Wong

commit sha ad237b6669c62534341fef522f469beaf7484b00

master: masking input with empty rune to not increment the cursor position to prevent the input length being revealed

view details

James Bowes

commit sha 43f74af14a796252d8320bff820f51b8231e32b1

Merge pull request #133 from Wotzhs/master masking input with empty rune to not increment the cursor position

view details

push time in a month

PR merged manifoldco/promptui

masking input with empty rune to not increment the cursor position

prevent sensitive input (e.g. passwords) length being revealed

+4 -0

2 comments

1 changed file

Wotzhs

pr closed time in a month

PullRequestReviewEvent

push eventmanifoldco/promptui

Brian Dwyer

commit sha 9d0836213a09d109614171cf22dd947a97e0c0a8

Readline now correctly triggers arrow keys on Windows Signed-off-by: Brian Dwyer <Brian.Dwyer@broadridge.com>

view details

James Bowes

commit sha fd5822cb85f6eb641c3a35e9eb57d359098596a3

Merge branch 'master' into bdwyertech

view details

James Bowes

commit sha 5c051320c5352c38b72f0f5cf5889bdb5be1abfe

Merge pull request #145 from bdwyertech/bdwyertech Use the same keycodes cross-platform

view details

push time in a month

PR merged manifoldco/promptui

Use the same keycodes cross-platform

Use the same keycodes cross-platform. Keyboard keys work fine on Windows.

+12 -26

1 comment

3 changed files

bdwyertech

pr closed time in a month

PullRequestReviewEvent

push eventbdwyertech/promptui

micnncim

commit sha 289685b65456eba670d973e87802443f7cf8e95a

Add Ctrl-H support to delete input text

view details

jamesdobson

commit sha c2f558aa8ab5c302c5761930793834f36b10eb09

Fixed echo of cursor after input is finished. (fixes #117) Based on: https://github.com/manifoldco/promptui/pull/118 by github.com/richardmcsong, taking only the changes required to fix issue #117.

view details

Yaroslav Skopets

commit sha 361491009c119a9063b88de9581d5ebc5cb440c4

prompt: add `HideEntered` flag

view details

James Bowes

commit sha 85345fc7c3b501edfbff8d29f467426447fe207f

Merge pull request #135 from micnncim/add-ctrl-h-support Add Ctrl-H support to delete input text

view details

James Bowes

commit sha ff07e3d5c296963ac8f2b365ae815ac0a622b71a

Merge pull request #147 from jamesdobson/master Fixed echo of cursor after input is finished. (fixes #117)

view details

James Bowes

commit sha 0ce406edb7bee6411a77f3b5b95ff9306a86efe3

Merge pull request #151 from yskopets/feature/add-prompt-hide-entered-flag prompt: add `HideEntered` flag

view details

James Bowes

commit sha fd5822cb85f6eb641c3a35e9eb57d359098596a3

Merge branch 'master' into bdwyertech

view details

push time in a month

pull request commentmanifoldco/promptui

Fix comment typos on prompt.go

Hi there! I know this is trivial, but do you mind signing the CLA regardless?

xrx

comment created time in a month

push eventmanifoldco/promptui

Yaroslav Skopets

commit sha 361491009c119a9063b88de9581d5ebc5cb440c4

prompt: add `HideEntered` flag

view details

James Bowes

commit sha 0ce406edb7bee6411a77f3b5b95ff9306a86efe3

Merge pull request #151 from yskopets/feature/add-prompt-hide-entered-flag prompt: add `HideEntered` flag

view details

push time in a month

PullRequestReviewEvent

push eventmanifoldco/promptui

jamesdobson

commit sha c2f558aa8ab5c302c5761930793834f36b10eb09

Fixed echo of cursor after input is finished. (fixes #117) Based on: https://github.com/manifoldco/promptui/pull/118 by github.com/richardmcsong, taking only the changes required to fix issue #117.

view details

James Bowes

commit sha ff07e3d5c296963ac8f2b365ae815ac0a622b71a

Merge pull request #147 from jamesdobson/master Fixed echo of cursor after input is finished. (fixes #117)

view details

push time in a month

issue closedmanifoldco/promptui

Prompt resource doesn't remove cursor when ENTER key is pressed.

image Code:

prompt = promptui.Prompt{
	Label: "Prompt 3",
}
_, err = prompt.Run()

The string that I get back from prompt.Run doesn't include the cursor, though.

closed time in a month

richardmcsong

PR merged manifoldco/promptui

Fixed echo of cursor after input is finished. (fixes #117)

Based on: https://github.com/manifoldco/promptui/pull/118 by github.com/richardmcsong, taking only the changes required to fix issue #117.

+11 -3

7 comments

2 changed files

jamesdobson

pr closed time in a month

PullRequestReviewEvent

push eventmanifoldco/promptui

micnncim

commit sha 289685b65456eba670d973e87802443f7cf8e95a

Add Ctrl-H support to delete input text

view details

James Bowes

commit sha 85345fc7c3b501edfbff8d29f467426447fe207f

Merge pull request #135 from micnncim/add-ctrl-h-support Add Ctrl-H support to delete input text

view details

push time in a month

PR merged manifoldco/promptui

Add Ctrl-H support to delete input text

Currently, <kbd>Ctrl</kbd>+<kbd>H</kbd> is unavailable to delete input text. It will be good for some users to support <kbd>Ctrl</kbd>+<kbd>H</kbd>.

+5 -2

3 comments

3 changed files

micnncim

pr closed time in a month

PullRequestReviewEvent

pull request commentmanifoldco/promptui

Add Ctrl-H support to delete input text

LGTM, and apologies for the very late review.

micnncim

comment created time in a month

delete branch jbowes/vimconfig

delete branch : patch-1

delete time in 2 months

PR closed jelmersnoeck/vimconfig

Update README.md
+2 -2

1 comment

1 changed file

jbowes

pr closed time in 2 months

pull request commentjelmersnoeck/vimconfig

Update README.md

Withdrawing this PR. the maintainer and I have irresolvable disagreements over these changes.

jbowes

comment created time in 2 months

PR opened jelmersnoeck/vimconfig

Update README.md
+2 -2

0 comment

1 changed file

pr created time in 2 months

push eventjbowes/vimconfig

James Bowes

commit sha fb5de0770cfd9c27e326b5f2f8592bb1094cf450

Update README.md

view details

push time in 2 months

issue commentfacebook/ent

Error unwrapping implemented incorrectly in 0.4.0

Thank you! We'll see who gets to it first :)

jbowes

comment created time in 2 months

issue commentfacebook/ent

Error unwrapping implemented incorrectly in 0.4.0

That's fair, but I think it's tricky for two reasons:

  • (what we hit) ValidationError is in a generated package end users own and control, and so we've extended it, and have access to the err field. You could easily argue this isn't supported.
  • Not all code in the ent code base populates the ValdationError's err with a fmt.wrapError. The create template generates uses of ValidationError with errors.New, which will end up returning nil :(
jbowes

comment created time in 2 months

issue openedfacebook/ent

Error unwrapping implemented incorrectly in 0.4.0

A recent change Updated how validation errors implement the error Unwrap interface. The change calls errors.Unwrap() instead of returning the err field.

This is incorrect (the previous behaviour was correct) because errors.Unwrap returns either the error that the passed-in error wraps, or nil if the passed-in error doesn't implement Unwrap.

Effectively, the immediate error contained in the validation error will never be returned -- it will always be skipped over, having its wrapped error returned instead.

created time in 2 months

more