profile
viewpoint
Jason Paulos jasonpaulos @algorand Software engineer at @algorand

jasonpaulos/solid-health 4

A proof-of-concept mobile app for decentralized health record management

jasonpaulos/ArrowCamMod 3

Implements arrow cam in Minecraft

jasonpaulos/MatchMaker 3

An open source, survey-based matchmaking program

EvanJRichard/msgpack-javascript 0

MessagePack for JavaScript/TypeScript/ECMA-262 / msgpack.org[JavaScript]

jasonpaulos/algoship 0

Battleship on the Algorand blockchain :ship: :ship: :boom:

jasonpaulos/apollo-client 0

:rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server

jasonpaulos/go-algorand 0

Algorand's official implementation in Go.

jasonpaulos/markbook-app 0

book mark <--> mark book -- insane social bookmarking for the solid platform

delete branch algorand/js-algorand-sdk

delete branch : jasonpaulos/test-browser

delete time in 34 minutes

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 1d4216852ceacd0d31dad7363e31364ba3a759c7

Run tests for browser (#228) Allow our mocha tests and SDK unit and integration tests to run in browsers.

view details

push time in 34 minutes

PR merged algorand/js-algorand-sdk

Reviewers
Run tests for browser

This PR allows our mocha tests and SDK unit and integration tests to run in browsers.

Primary changes:

  • Setting the environment variable TEST_BROWSER to either chrome or firefox and running npm test or make docker will run tests in that browser instead of Node. If you are running on a desktop, that browser will open to a testing window, which can be used to debug any failing tests too.
    • The tests are still driven from the Node command line, but we use selenium-webdriver to execute test code in the browser. Any failed tests will report back an error to Node, however these errors are often less useful that what gets reported in the browser.
  • Chrome and Firefox testing have been added as parallel Travis jobs, however the Firefox job is not required to pass since it has errors--I've opened a separate issue (#230) to debug those.
  • SDK unit and integration tests no longer run inside of a docker container. This is because they now may need to interact with a browser, and that's harder to do if they run inside of a container. @winder let me know if you think this would cause any problems.

Secondary changes:

  • make docker is now just a wrapper around npm run docker-test. This allowed me to define a predocker-test npm script that builds the package and an auxiliary testing bundle and puts them in the right place for browser tests.
  • The logicsig templates in src/logicTemplates are now exported to algosdk.LogicTemplates.
  • In order to resolve a circular dependency after exporting the above, I moved most of the functions from src/main.js into separate files that can be required individually.
  • The Transaction class is now exported to algosdk.Transaction. This enables it to be tested in the browser after our package has been bundled.

Browser bugs fixed:

  • In the browser binary msgpack fields would sometimes be a Uint8Array, but a Buffer in Node. Now everything should be a Uint8Array.
  • Superagent in the browser seems to parse response bodies when the content type is text/plain, but in Node it uses a default value of {}. This caused an issue with the /health endpoint, which returns null with content type text/plain. I've submitted algorand/go-algorand#1621 to fix this, and in the meantime just ignored the body of the health response.

Closes #211.

+6825 -4478

3 comments

45 changed files

jasonpaulos

pr closed time in 34 minutes

issue closedalgorand/js-algorand-sdk

Run tests for browser

#209 is a bug where code for requesting data from some endpoints failed to return anything when ran in a web browser, but they worked fine in Node. To stop issues like this from happening, we should run the SDK tests in a browser context as well.

Cucumber and webdriver: https://cucumber.io/docs/guides/browser-automation/

closed time in 34 minutes

jasonpaulos

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha a5c4e9fd898dba23a1246fa7ddca5d86a71dee79

Install browsers inside of test container

view details

push time in 17 hours

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 714a346f25e96f8edab2dc7529563ec748e9da76

Try using host network

view details

push time in 19 hours

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 2d96faf2554d4589028d4d56f669a60c05a945dc

Fix docker network

view details

push time in 20 hours

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha cecf8b8f6164823d81b73f3da654deccbc834079

Update travis script

view details

push time in 21 hours

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 8640f4056e635cff7012b3effab3fcbf14854cad

Remove TxGroup from exports

view details

Jason Paulos

commit sha 4e5225fd96e0adf13ee4f1ec003b6fad00e91465

Put test runner back in docker

view details

push time in 21 hours

pull request commentalgorand/go-algorand

Add goal account info command

@tsachiherman I've updated this PR with the above changes. Let me know if it looks good to you.

jasonpaulos

comment created time in a day

push eventjasonpaulos/go-algorand

Jason Paulos

commit sha 722df2dcd134ea8dfc37e4f02a8ea2a82ed5f32a

Add goal account info command

view details

push time in a day

issue commentalgorand/go-algorand

Goal command `goal account balance` only display the balance of ALGO

Hi @Mine77, thanks for reporting this. We have decided that the functionality of goal account balance should remain the same and its description should be updated to state it will only show the balance of algos.

We will add a new command, goal account info, to show information about the assets and applications that belong to an account.

Mine77

comment created time in 4 days

push eventjasonpaulos/go-algorand

Tsachi Herman

commit sha 0f9f8c93004867d266d20372a08e7638d9a5d6a7

Fix datarace in TestPing unit test (#1624) Fix data race in TestPing unit test

view details

Jason Paulos

commit sha 69514e38169de86d21ca251fdd27fefcc633e3d8

Set content type header for health endpoint (#1621) Set content type header for health endpoint

view details

Tsachi Herman

commit sha e2865f404a9de7e07e562940e5ace1e991aaefd5

extend account lookup to include validity range (#1626) extend account lookup to include validity range

view details

push time in 4 days

push eventjasonpaulos/go-algorand

btoll

commit sha 302a3e6b47e263eb11cb26f529fdc88509585e69

Update mule rpm packaging to support more scenarios (#1476)

view details

btoll

commit sha f5a0ebd0c058029bfec149ead948d69d3299b986

Update deploy scripts to reflect current deploy strategy (#1477) The deployment stage is currently being run manually and this PR updates or replaces the older deploy scripts that were not being used.

view details

algonautshant

commit sha c99d72142eb9d47c5e315dbafadbabf9ed497f9c

Add unit tests for IsWritingCatchpointFile and GetCatchpointStream (#1581) Coverage tests for IsWritingCatchpointFile and GetCatchpointStream

view details

Tsachi Herman

commit sha 31ebf7a6aa1781240fb65394284108967768fa7a

bugfix: correct accounting of transactions in checkPendingQueueSize (#1584) Ensure correctly limiting number of transactions in transaction

view details

Tsachi Herman

commit sha f28458e40ff1c5fdb51b9eb43ad0ec0ec5af5658

Improve network template validation (#1512) Improve network template validation for small fractional sums.

view details

Tsachi Herman

commit sha 726a95ed4b2f240f7f95e41f2b5edeef9bed998c

Decouple database round and acctupdate round (#1527) Decouple database round and acctupdate round

view details

btoll

commit sha fc537bcfab6e2bf9c597dc9c84823efe9d00b08b

Added more deb and rpm package tests (#1580) Added the following tests: verify_control_files.sh verify_genesis_file.sh verify_package_binaries.sh The tests are separated into two locations: ./test/tests/pre for tests that should run before any packages are installed (these test control files, for example) ./test/tests/post for tests that should run after packages are installed (basically, everything else) This prevents getting into potentially messy logic that needs to happen if packages needs to be (re-)installed/removed before any tests are run. Workflow: mule -> make -> test.sh (sets up env vars, installs packages using dpkg or rpm) -> run all tests in pre/ -> run all tests in post/

view details

Tsachi Herman

commit sha 965ece046f9f02bbb3cec9b7c18cd4f5604f7eee

avoid printing control characters from goal (#1585) Avoid printing control characters as part of the goal output

view details

Tsachi Herman

commit sha 953277be951a398b8021c135d360c6116ea0bd44

Optimize listCreatables per reviewer request. (#1599) Avoid copying the array needlessly, and preallocate storage of array and map

view details

Brian Olson

commit sha 96786912bb2c769579e861d6f6c4480c5d079c8e

cleanup buggy test code (#1602) Remove the buggy implementation buildTestHTTPPeerSource from test code.

view details

Brian Olson

commit sha 52dd3020ed546d6227f99a1672549e558dd825c5

make sanity (#1603) Ensure code formatting is uniform across code base.

view details

btoll

commit sha 3df0d063dcf4adf1452c93fc93ad77f04198db61

Simplify mule signing task (#1604) Simplify package signing by only having one task that signs all build artifacts instead of delineating them by type.

view details

Tsachi Herman

commit sha eeb195c8b45519a22826f2375ae93503716bf39f

Add support for Windows compilation on travis (#1608) Compile product under Windows

view details

btoll

commit sha 8619d736102cf271d98dc6dbbf53cc545c6c4c89

Remove unused dockerfiles (#1610)

view details

nicholasguoalgorand

commit sha 95e4404f27f42ff547d30ef14206a50adfa8e500

Refactor AssembleBlock error (#1611) AssembleBlock would produce an error during catchup that does not interfere with the node. Bumping the error down to an warn message.

view details

algonautshant

commit sha 284f69ad176af8df84fc1ddba628691f4a5635ab

Correct Telemetry uploading message reported in node.log (#1605) Correct Telemetry uploading message reported in node.log

view details

Tsachi Herman

commit sha 93a9909494c8f8535b6e3eb59fa1d590d58168d1

Repack merkle trie pages before flush (#1612) Repack change nodes into full pages before flushing them to disk.

view details

algonautshant

commit sha 667949f41e1b5e87591807e4665c3d09ec82e234

Change telemetryConfig from global variable to a member of the logger (#1619) Fix the SessionGUID output in the log file.

view details

Tsachi Herman

commit sha 47c1ca221fdc92ae6632f9646a45c5d0ddf20c20

add ascii filtering for remote requests logged data (#1595) Bulletproof log writing against non-ascii requests.

view details

btoll

commit sha fbe0bfe07686f2bad50bdd422484febe7f8f7135

Update mule docs for new pipeline (#1606)

view details

push time in 4 days

pull request commentalgorand/js-algorand-sdk

Run tests for browser

@winder I can see the benefit of running the tests in a container now. I will look into how we can still support that for browser tests too. The main reason I chose to get rid of running the tests in a container is because it's easier to setup WebDriver when the process running the tests, browser, and WebDriver driver for that browser are all on the same machine and I wasn't aware of any benefits of running our tests in a container.

jasonpaulos

comment created time in 4 days

Pull request review commentalgorand/js-algorand-sdk

Run tests for browser

 class Transaction {     // supply feePerByte to increment fee accordingly     addRekey(reKeyTo, feePerByte=0) {         if (reKeyTo !== undefined) {-            this.reKeyTo = address.decode(reKeyTo);+            this.reKeyTo = address.decodeAddress(reKeyTo);         }         if (feePerByte !== 0) {             this.fee += (ALGORAND_TRANSACTION_REKEY_LABEL_LENGTH + ALGORAND_TRANSACTION_ADDRESS_LENGTH) * feePerByte;         }     } } - /**- * Aux class for group id calculation of a group of transactions+ * encodeUnsignedTransaction takes a completed txnBuilder.Transaction object, such as from the makeFoo+ * family of transactions, and converts it to a Buffer+ * @param transactionObject the completed Transaction object+ * @returns {Uint8Array}  */-class TxGroup {-    constructor(hashes) {-        if (hashes.length > ALGORAND_MAX_TX_GROUP_SIZE) {-            let errorMsg = hashes.length.toString() + " transactions grouped together but max group size is " + ALGORAND_MAX_TX_GROUP_SIZE.toString();-            throw Error(errorMsg);-        }--        this.name = "Transaction group";-        this.tag = Buffer.from("TG");--        this.txGroupHashes = hashes;-    }--    get_obj_for_encoding() {-        const txgroup = {-            "txlist": this.txGroupHashes-        };-        return txgroup;-    }--    static from_obj_for_encoding(txgroupForEnc) {-        const txn = Object.create(this.prototype);-        txn.name = "Transaction group";-        txn.tag = Buffer.from("TG");-        txn.txGroupHashes = [];-        for (let hash of txgroupForEnc.txlist) {-            txn.txGroupHashes.push(new Buffer.from(hash));-        }-        return txn;-    }+function encodeUnsignedTransaction(transactionObject) {+    let objToEncode = transactionObject.get_obj_for_encoding();+    return encoding.encode(objToEncode);+} -    toByte() {-        return encoding.encode(this.get_obj_for_encoding());-    }+/**+ * decodeUnsignedTransaction takes a Buffer (as if from encodeUnsignedTransaction) and converts it to a txnBuilder.Transaction object+ * @param transactionBuffer the Uint8Array containing a transaction+ * @returns {Transaction}+ */+function decodeUnsignedTransaction(transactionBuffer) {+    let partlyDecodedObject = encoding.decode(transactionBuffer);+    return Transaction.from_obj_for_encoding(partlyDecodedObject);+} +/**+ * decodeSignedTransaction takes a Buffer (from transaction.signTxn) and converts it to an object+ * containing the Transaction (txn), the signature (sig), and the auth-addr field if applicable (sgnr)+ * @param transactionBuffer the Uint8Array containing a transaction+ * @returns {Object} containing a Transaction, the signature, and possibly an auth-addr field+ */+function decodeSignedTransaction(transactionBuffer) {+    let stxnDecoded = encoding.decode(transactionBuffer);+    stxnDecoded.txn = Transaction.from_obj_for_encoding(stxnDecoded.txn);+    return stxnDecoded; } -module.exports = {Transaction, TxGroup, ALGORAND_MIN_TX_FEE};

Similar to my above reply, I believe changing where TxGroup is defined should not break any supported uses of the SDK since it only changes internal files.

Re: exporting functions, I will change it so that TxGroup is not publicly exported, since it is only used by our mocha tests, which can import internal files. However Transaction is used by cucumber steps, which can't import internal files because it runs against our bundled browser code. If it's important that this class does not get publicly exported, I can rewrite the two steps that use it.

jasonpaulos

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentalgorand/js-algorand-sdk

Run tests for browser

 function isValidAddress(address) {     return utils.arrayEqual(checksum, decoded.checksum); } -function decode(address) {

These specific functions were used internally as address.decode/encode but exported by main.js in wrapper functions decodeAddress/encodeAddress. As part of the refactor I did, I thought it would be simpler to give them their public names from the beginning to avoid renaming later. So the end user shouldn't notice a difference here, unless they specifically import the internal file algosdk/src/encoding/address.

In JS it's best practice for modules to export all public functions & variables from their main entrypoint (main.js in our case), so I don't think we should support users importing our internal files. These internal files aren't even accessible in the browser from the bundle we build, so it would be unfair to expect users to have to do that anyway to access parts of the SDK.

jasonpaulos

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentalgorand/js-algorand-sdk

Run tests for browser

+const MICROALGOS_TO_ALGOS_RATIO = 1e6;+const ERROR_INVALID_MICROALGOS = new Error("Microalgos should be positive and less than 2^53 - 1.");

@EvanJRichard did you make a change here that got lost in the rebase, or is leveraging the BigInt support within the SDK still in progress?

jasonpaulos

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventalgorand/js-algorand-sdk

Evan Richard

commit sha c076525c43a71fc19ff555e98e41f411d5bb2adb

Remove old msgpack dependency from packjage.json (#232)

view details

Jason Paulos

commit sha 7a76aba3190cd1573d46d15475429dbfcae66b67

Use npm ci

view details

Jason Paulos

commit sha 6fddc8ce221dd5a76c9f08e38aca6d6b6e529738

Remove unnecesary test imports

view details

Jason Paulos

commit sha 20566ce78adf1c0fb08d548e4e60ab63d8846927

Break up step definition file

view details

Jason Paulos

commit sha 2792ac291be617685e748371beb858d3eefe013a

Unify resource loading

view details

Jason Paulos

commit sha c9940596a8cb46e8cf1817eaf208614ed309bb80

Add cors headers to mock server

view details

Jason Paulos

commit sha c93de7c1073a5a71fe6094355ddd49657700438b

Support for cucumber unit tests in browser

view details

Jason Paulos

commit sha 4d659f26258ffc9fca3e78d618d585f54d6b1141

Add browser tests to travis

view details

Jason Paulos

commit sha c6f5ea65daf0d3c22a2560f4a61bcc40144acc81

Make binary responses consistent

view details

Jason Paulos

commit sha 0f7b896182bccc4096f660536415607e37de1cd7

Run integration tests

view details

Jason Paulos

commit sha 9449dfc75fe910a6e702555c4ecb267cfb6a860c

Export logic templates

view details

Jason Paulos

commit sha b14be13aa7355276ceb883b62bf550386e8dc9e7

Add firefox support, refactor to avoid circular references, add browser mocha support

view details

Jason Paulos

commit sha 1c159509c1354230cc6f0446881cedeed96ba8f5

Update gitignore

view details

Jason Paulos

commit sha adcfbba9719fb8e0108057e593b4ea1c21bcbef0

Fix failures in chrome integration tests

view details

Jason Paulos

commit sha ca90dcfa4bb05c41c9939590decdc9ea207e6633

Update test scripts and README

view details

Jason Paulos

commit sha 46bffdac8bf2818d0b90fa95bc58cb3dbadb9a07

Add comment to step definition file

view details

Jason Paulos

commit sha 7fb6ef5121494ed87df83057f55a670555161d74

Clean up docker files

view details

Jason Paulos

commit sha 415e19cfe7cb734863cd39bc4c030e6671842235

Fix test environment log

view details

push time in 5 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 840cf9a4d0fdd60c5643254d6e7ed70887f52ce6

Fix test environment log

view details

push time in 5 days

push eventalgorand/js-algorand-sdk

Evan Richard

commit sha 4add848fbf01234fa7ea8b6739b8bf35958b413d

document that fee will be bumped up to min if final fee < min (#231) Resolves: #224

view details

Jason Paulos

commit sha d417eb5af82b220fc17d3811e3c21f1f5d858c73

Use npm ci

view details

Jason Paulos

commit sha 423b040f042adb811a784e35d0d5b60c6ba7ad0e

Remove unnecesary test imports

view details

Jason Paulos

commit sha 060dde9f21cb84cabc210dad613eb640e2d4393d

Break up step definition file

view details

Jason Paulos

commit sha 2ed5db76fb0fa07b3d38966f8ace041fe6c3e9ba

Unify resource loading

view details

Jason Paulos

commit sha 217d57d6095bf850f5cfc7d2f22ae08830dcf640

Add cors headers to mock server

view details

Jason Paulos

commit sha bb0629c342a81cb9276d0b790f495d5cc856175b

Support for cucumber unit tests in browser

view details

Jason Paulos

commit sha 821fc18699efa916037d07186f8a83c004d72911

Add browser tests to travis

view details

Jason Paulos

commit sha c4735dd167e657384059dd456a65704f0e4635a4

Make binary responses consistent

view details

Jason Paulos

commit sha 12bdc1455d945bbf473a767e187c7206efb8995a

Run integration tests

view details

Jason Paulos

commit sha 75c6bc15f04d24aa47bb1e8e3744977748718a11

Export logic templates

view details

Jason Paulos

commit sha 78c6da83bdafc42be033ddd779f19b6b7fdc3361

Add firefox support, refactor to avoid circular references, add browser mocha support

view details

Jason Paulos

commit sha 14e370c3f02214a225c6f43747714c2bd1d07ac9

Update gitignore

view details

Jason Paulos

commit sha 1b9637a415451865220af49cc3e57459a38b09e4

Fix failures in chrome integration tests

view details

Jason Paulos

commit sha 6fb1fabd4fcb4cd928f6508537d5ec6b734a9569

Update test scripts and README

view details

Jason Paulos

commit sha 3c023e82245551663ce4fdfc0a5b54534e480711

Add comment to step definition file

view details

Jason Paulos

commit sha 8381e91a812dace0ebe406ec813aac5fce6ea515

Clean up docker files

view details

push time in 5 days

PullRequestReviewEvent

pull request commentalgorand/js-algorand-sdk

Remove old msgpack dependency from packjage.json

Can you run npm i to update package-lock.json too?

EvanJRichard

comment created time in 5 days

push eventjasonpaulos/go-algorand

Tsachi Herman

commit sha 93a9909494c8f8535b6e3eb59fa1d590d58168d1

Repack merkle trie pages before flush (#1612) Repack change nodes into full pages before flushing them to disk.

view details

algonautshant

commit sha 667949f41e1b5e87591807e4665c3d09ec82e234

Change telemetryConfig from global variable to a member of the logger (#1619) Fix the SessionGUID output in the log file.

view details

Tsachi Herman

commit sha 47c1ca221fdc92ae6632f9646a45c5d0ddf20c20

add ascii filtering for remote requests logged data (#1595) Bulletproof log writing against non-ascii requests.

view details

btoll

commit sha fbe0bfe07686f2bad50bdd422484febe7f8f7135

Update mule docs for new pipeline (#1606)

view details

btoll

commit sha e81b91b5676b3622ac61cd131cf94d2fac65fc0d

Added `package-upload` mule task (#1617) Upload build assets to algorand-staging at any point in the build pipeline process.

view details

Tsachi Herman

commit sha a156ba9a9f2627de4f84303ba7520009194039a1

Fix unreliable unit test. (#1622) fix unreliable network unit test TestSlowPeerDisconnection

view details

nicholasguoalgorand

commit sha ebc90afde4badad98d5de4379c1c520d4fe90a72

Add syncMu to AlgorandFullNode OnNewBlock (#1623) separate synchronization primitive for updating the latest round reached timestamp to improve catchup performance.

view details

Pavel Zbitskiy

commit sha 3fa7a928dd92815bf41c650f31389b3816ddee0d

Implement e2e test for tealdbg (#1609) Add e2e test for tealdbg

view details

push time in 5 days

pull request commentalgorand/js-algorand-sdk

Run tests for browser

The refactor is internal only so it should not break backwards compatibility unless users require specific files in our package (which we don't support anyway).

jasonpaulos

comment created time in 5 days

PullRequestReviewEvent

delete branch jasonpaulos/pyteal

delete branch : codegen-dag

delete time in 6 days

delete branch jasonpaulos/pyteal

delete branch : logicsig-v2-backup

delete time in 6 days

delete branch jasonpaulos/pyteal

delete branch : logicsig-v2-staging

delete time in 6 days

delete branch jasonpaulos/pyteal

delete branch : test-examples

delete time in 6 days

PR opened algorand/pyteal

[WIP] Add more codegen tests

Closes #17

+32 -77

0 comment

1 changed file

pr created time in 6 days

create barnchalgorand/pyteal

branch : codegen-tests

created branch time in 6 days

delete branch algorand/pyteal

delete branch : test-examples

delete time in 6 days

create barnchalgorand/pyteal

branch : test-examples

created branch time in 6 days

push eventjasonpaulos/pyteal

Jason Paulos

commit sha 1ff775cfbb732cfacd4e60051cc01392ba11fe12

Small docs fixes

view details

Jason Paulos

commit sha 6b07db1040a6efb82b0cb2fbf1204e5e14c23875

Fix typo in voting example docs

view details

Jason Paulos

commit sha a5db88ddb46df828f320c0fe6298299d77a28cf3

Fix security token example typo

view details

Jason Paulos

commit sha 8a756e63e88d884f5724267f9abac0e7f0b02d2e

Update voting example and add deployment script Closes #24.

view details

Jason Paulos

commit sha 8cf1cc91ab364cc383a052319efcfba3eb3edde2

Use clear state program in examples

view details

John Lee

commit sha 9428df4926fa0725138757b7057105d699b89541

Remove travis token from build status image (#25)

view details

Jason Paulos

commit sha 2483aebfbcb4f1a3d09cc6d2312f3b393ceddb54

Fix typos in docs

view details

Jason Paulos

commit sha 54d797512cf2d0862da923c8895116675e77c869

Fix mistakes in state docs

view details

Jason Paulos

commit sha 980c7874419fc28a31ade68bf92214eb4c79a76a

Use examples in compile test

view details

push time in 6 days

PR opened algorand/pyteal

[WIP] Improve codegen

Uses an intermediate DAG for codegen, which allows us to add optimizations to shrink program size.

Closes #9.

+2317 -680

0 comment

51 changed files

pr created time in 6 days

create barnchalgorand/pyteal

branch : codegen-dag

created branch time in 6 days

push eventjasonpaulos/pyteal

Jason Paulos

commit sha 6b07db1040a6efb82b0cb2fbf1204e5e14c23875

Fix typo in voting example docs

view details

Jason Paulos

commit sha a5db88ddb46df828f320c0fe6298299d77a28cf3

Fix security token example typo

view details

Jason Paulos

commit sha 8a756e63e88d884f5724267f9abac0e7f0b02d2e

Update voting example and add deployment script Closes #24.

view details

Jason Paulos

commit sha 8cf1cc91ab364cc383a052319efcfba3eb3edde2

Use clear state program in examples

view details

John Lee

commit sha 9428df4926fa0725138757b7057105d699b89541

Remove travis token from build status image (#25)

view details

Jason Paulos

commit sha 2483aebfbcb4f1a3d09cc6d2312f3b393ceddb54

Fix typos in docs

view details

Jason Paulos

commit sha 54d797512cf2d0862da923c8895116675e77c869

Fix mistakes in state docs

view details

Jason Paulos

commit sha 6afc0f4440756732e0b2bb453b04699c45e7f954

Reduce generated code size using a DAG

view details

Jason Paulos

commit sha 7e761492fabc436e5c27203f71d9666d76ffc901

Add DAG tests and improvements

view details

push time in 6 days

push eventjasonpaulos/pyteal

John Lee

commit sha 9428df4926fa0725138757b7057105d699b89541

Remove travis token from build status image (#25)

view details

Jason Paulos

commit sha 2483aebfbcb4f1a3d09cc6d2312f3b393ceddb54

Fix typos in docs

view details

Jason Paulos

commit sha 54d797512cf2d0862da923c8895116675e77c869

Fix mistakes in state docs

view details

push time in 6 days

push eventalgorand/pyteal

Jason Paulos

commit sha 54d797512cf2d0862da923c8895116675e77c869

Fix mistakes in state docs

view details

push time in 6 days

push eventalgorand/pyteal

Jason Paulos

commit sha 2483aebfbcb4f1a3d09cc6d2312f3b393ceddb54

Fix typos in docs

view details

push time in 6 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 9c02945f43b789fdb0d52edc0bad0607f650946d

Fix bigint test

view details

push time in 6 days

push eventalgorand/js-algorand-sdk

jecassis

commit sha 08807c8a417bb2402167eb2b6dd3ccda44e88c55

Update Keccak library to 3.0.0 (#151) * Update Keccak library to 3.0.1 - Fixes #126 * Add test for htlc keccak hash function Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>

view details

Evan Richard

commit sha 1a31f97d0683a87f7737fe52fcc061405002d9af

Use msgpack fork that supports bigints. (#229) A bigint is used only when the decoded number cannot fit in to a Number. Resolves: #130

view details

Jason Paulos

commit sha dc35e88bca7b345c6bd840635685e36f4bc5611d

Merge branch 'develop' into jasonpaulos/test-browser

view details

push time in 6 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 62289b33fb4b7620ab95602a292e2ff3b66f4f71

Clean up docker files

view details

push time in 6 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha bc228edfff3665810aeec243ec18cb522d49f5c8

Add comment to step definition file

view details

push time in 6 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 4986b5bcc1d3e3118f854b2adb19188ecfac36c1

Update test scripts and README

view details

push time in 6 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 5bfc3d654f34ce3cb70459d9a8a47d75c4e463f1

Unify resource loading

view details

Jason Paulos

commit sha 611dd04db5f10e289a1c13941d3db7dc83beae02

Add cors headers to mock server

view details

Jason Paulos

commit sha b937c41636a2f002c5f62b66179d7513617f8f28

Add http for cors

view details

Jason Paulos

commit sha 46d4de1c5265caa09b26dcc2d271b66bbdfbb771

Support for cucumber unit tests in browser

view details

Jason Paulos

commit sha 2714f3b9b2ff845dc58272d22a62e6511d1a3ec7

Add browser tests to travis

view details

Jason Paulos

commit sha 03d31317de6fd1a34edac2757db779b9b32829f2

Make binary responses consistent

view details

Jason Paulos

commit sha c59e6e13f6030314bdd612a90fb57079a875d87f

Run integration tests

view details

Jason Paulos

commit sha 667ef4882c42d192805a1fb3a205ee4f7bceaca7

Export logic templates

view details

Jason Paulos

commit sha f6ffdfe75d9bfd39b8559f3fdc94d0116f9acc67

Add firefox support, refactor to avoid circular references, add browser mocha support

view details

Jason Paulos

commit sha ef09c819f28faf7284750579eb8bc29db6945d18

Update gitignore

view details

jecassis

commit sha d1b9436048829592dc9c9d22287ad953ae3c6b40

Update Keccak library to 3.0.0 (#151) * Update Keccak library to 3.0.1 - Fixes #126 * Add test for htlc keccak hash function Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>

view details

Jason Paulos

commit sha 3bd61bdab177b61112693524a001fdecd1941e1b

Update logicsig test

view details

Jason Paulos

commit sha 38d511a8de9ac406ef22e460f44a1f6d42da9880

Correctly add firefox test

view details

Jason Paulos

commit sha e1278edba55cf201423ca382397db8517957f640

Catch errors in mocha script

view details

Jason Paulos

commit sha 676a508a860070dedd9a0da610b49321d55b883c

Fix failures in chrome integration tests

view details

Evan Richard

commit sha 10da5020022bf1a724f3f67b36ad5b912c2a9ae3

Use msgpack fork that supports bigints. (#229) A bigint is used only when the decoded number cannot fit in to a Number. Resolves: #130

view details

Jason Paulos

commit sha 9a9dff5390c91dbb1d1995ee4b05ac2c104bfd19

Fix test after merge

view details

push time in 6 days

push eventalgorand/js-algorand-sdk

Evan Richard

commit sha 1a31f97d0683a87f7737fe52fcc061405002d9af

Use msgpack fork that supports bigints. (#229) A bigint is used only when the decoded number cannot fit in to a Number. Resolves: #130

view details

Jason Paulos

commit sha 877dcd276e4477bfaf40cade90ce6e013f2236a1

Merge branch 'develop' into jasonpaulos/test-browser

view details

Jason Paulos

commit sha 2f12f84c182b357722b4b76f4b08688d47185567

Fix test after merge

view details

push time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha a2b5bdf667abc38b81993e8ff868d7719a476c58

Fix failures in chrome integration tests

view details

push time in 7 days

PullRequestReviewEvent

PR opened algorand/go-algorand

Reviewers
Set content type header for health endpoint

<!-- Thanks for submitting a pull request! We appreciate the time and effort you spent to get this far.

If you haven't already, please make sure that you've reviewed the CONTRIBUTING guide: https://github.com/algorand/go-algorand/blob/master/CONTRIBUTING.md#code-guidelines

In particular ensure that you've run the following:

  • make generate
  • make sanity (which runs make fmt, make lint, make fix and make vet)

It is also a good idea to run tests:

  • make test
  • make integration -->

Summary

According to algod.oas2.json, the /health endpoint should return application/json, however that endpoint does not set the Content-Type header.

This became an issue when running tests for the Javascript SDK in the browser. Our HTTP request library behaves differently in the browser when the Content-Type is not JSON, which led to a bug there.

I don't imagine this change will break any consumers of the API, since the endpoint always returns null, which is valid JSON.

Test Plan

I'm not aware of any tests specifically for the REST endpoints. If there are, let me know and I'll add a check there.

+1 -0

0 comment

1 changed file

pr created time in 7 days

create barnchjasonpaulos/go-algorand

branch : health-content-type

created branch time in 7 days

push eventjasonpaulos/go-algorand

btoll

commit sha 302a3e6b47e263eb11cb26f529fdc88509585e69

Update mule rpm packaging to support more scenarios (#1476)

view details

btoll

commit sha f5a0ebd0c058029bfec149ead948d69d3299b986

Update deploy scripts to reflect current deploy strategy (#1477) The deployment stage is currently being run manually and this PR updates or replaces the older deploy scripts that were not being used.

view details

algonautshant

commit sha c99d72142eb9d47c5e315dbafadbabf9ed497f9c

Add unit tests for IsWritingCatchpointFile and GetCatchpointStream (#1581) Coverage tests for IsWritingCatchpointFile and GetCatchpointStream

view details

Tsachi Herman

commit sha 31ebf7a6aa1781240fb65394284108967768fa7a

bugfix: correct accounting of transactions in checkPendingQueueSize (#1584) Ensure correctly limiting number of transactions in transaction

view details

Tsachi Herman

commit sha f28458e40ff1c5fdb51b9eb43ad0ec0ec5af5658

Improve network template validation (#1512) Improve network template validation for small fractional sums.

view details

Tsachi Herman

commit sha 726a95ed4b2f240f7f95e41f2b5edeef9bed998c

Decouple database round and acctupdate round (#1527) Decouple database round and acctupdate round

view details

btoll

commit sha fc537bcfab6e2bf9c597dc9c84823efe9d00b08b

Added more deb and rpm package tests (#1580) Added the following tests: verify_control_files.sh verify_genesis_file.sh verify_package_binaries.sh The tests are separated into two locations: ./test/tests/pre for tests that should run before any packages are installed (these test control files, for example) ./test/tests/post for tests that should run after packages are installed (basically, everything else) This prevents getting into potentially messy logic that needs to happen if packages needs to be (re-)installed/removed before any tests are run. Workflow: mule -> make -> test.sh (sets up env vars, installs packages using dpkg or rpm) -> run all tests in pre/ -> run all tests in post/

view details

Tsachi Herman

commit sha 965ece046f9f02bbb3cec9b7c18cd4f5604f7eee

avoid printing control characters from goal (#1585) Avoid printing control characters as part of the goal output

view details

Tsachi Herman

commit sha 953277be951a398b8021c135d360c6116ea0bd44

Optimize listCreatables per reviewer request. (#1599) Avoid copying the array needlessly, and preallocate storage of array and map

view details

Brian Olson

commit sha 96786912bb2c769579e861d6f6c4480c5d079c8e

cleanup buggy test code (#1602) Remove the buggy implementation buildTestHTTPPeerSource from test code.

view details

Brian Olson

commit sha 52dd3020ed546d6227f99a1672549e558dd825c5

make sanity (#1603) Ensure code formatting is uniform across code base.

view details

btoll

commit sha 3df0d063dcf4adf1452c93fc93ad77f04198db61

Simplify mule signing task (#1604) Simplify package signing by only having one task that signs all build artifacts instead of delineating them by type.

view details

Tsachi Herman

commit sha eeb195c8b45519a22826f2375ae93503716bf39f

Add support for Windows compilation on travis (#1608) Compile product under Windows

view details

btoll

commit sha 8619d736102cf271d98dc6dbbf53cc545c6c4c89

Remove unused dockerfiles (#1610)

view details

nicholasguoalgorand

commit sha 95e4404f27f42ff547d30ef14206a50adfa8e500

Refactor AssembleBlock error (#1611) AssembleBlock would produce an error during catchup that does not interfere with the node. Bumping the error down to an warn message.

view details

algonautshant

commit sha 284f69ad176af8df84fc1ddba628691f4a5635ab

Correct Telemetry uploading message reported in node.log (#1605) Correct Telemetry uploading message reported in node.log

view details

push time in 7 days

issue openedalgorand/js-algorand-sdk

Add testing for firefox

Our browser tests fail in firefox, so we need to identify and fix the failures.

created time in 7 days

push eventalgorand/algorand-sdk-testing

Jason Paulos

commit sha 7e82ee8dc73c7ef170d5fc2907ae9a20a5a4036f

Fix db script permissions

view details

push time in 7 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha de0e9539d61f7e51b82570796d6d3a48172aad34

Catch errors in mocha script

view details

push time in 8 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha b9c62161b868e83efc032bbe20411a9e017da00f

Correctly add firefox test

view details

push time in 8 days

push eventalgorand/js-algorand-sdk

jecassis

commit sha 08807c8a417bb2402167eb2b6dd3ccda44e88c55

Update Keccak library to 3.0.0 (#151) * Update Keccak library to 3.0.1 - Fixes #126 * Add test for htlc keccak hash function Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>

view details

Jason Paulos

commit sha d3d3f0c6ec2f4af5f78f34f43e52d7c47937968c

Update gitignore

view details

Jason Paulos

commit sha ffc3301f71ee02af81057ec6a62dcd07cca0b0ff

Merge branch 'develop' into jasonpaulos/test-browser

view details

Jason Paulos

commit sha 36c2eadf65dccd638c3201f2d157f50f5e29ba9c

Update logicsig test

view details

push time in 8 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha ffdadeed6df516d1cb299eabb3542dba950cb7f0

Add firefox support, refactor to avoid circular references, add browser mocha support

view details

push time in 8 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 1f534cffd5f748e0c28c19fa9240db039492760a

Update tests for logic templates

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 9836f15025f7415b8827e8cfa71eeacc203a0ba3

Export logic templates

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha fb769880fdc6c06167923fec4dc23f07a09990b5

Run integration tests

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 45339c2f6c08270f4f727f7e6733096df185a210

Make binary responses consistent

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 171f4205947b2ad605077232cf47478e01a5217c

Remove extra steps

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha a28cb33e9c539e2ae68b0cadaed90544c3d0643a

Remove condition for browser prepare

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha e8ff4a10534fd11fac8117e3fe04e97e329ce085

Add delay after starting browser

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha fbffb627e47a0dd049d530d63dc81beee37bf61e

Use window.steps

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 8db4f8cfbcecd5214db846984da8cb64a936566c

Use headless chrome

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha e6583c6a03806b763674d1c31f6160e415c7fe56

Add no sandbox to chrome args

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 1f280b25f1dc8a37b82a5442526f09049c459122

Add browser prepare step

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 9e7c11542cf113d7b4634dc1a3417144e8f8806b

Don't use docker for test runner

view details

push time in 11 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha f9aa12d644dfd4c014195f0d5882dab3df43fccd

Add missing arg

view details

push time in 12 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 51e95293a1e3d20cd55d227feb3a727cf776096b

Fix test browser var in docker

view details

push time in 12 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 4802b75e2adf54df0a5ef7af8673f97e0ced066b

Use travis jobs

view details

push time in 12 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 192f6919d01235bb5df497dc3d13e461720083bd

Add http for cors

view details

push time in 12 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 54cbdccb6341ade3fd2dbfe17a29e258ba82387f

Add test browser variable to dockerfile

view details

push time in 12 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 29427e9127a88c57e373924093029c5f80b26ded

Add browser tests to travis

view details

push time in 12 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 6d1e1c5f311ad3941e031261473a52195553b452

Support for cucumber unit tests in browser

view details

push time in 13 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha ea542a06d0cf4acd9ba4c08deea4f2d887ab10d1

Add cors headers to mock server

view details

push time in 13 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 7e940922cfcbb6ee0eb8c86e5f658af4d5f7404e

Fix resource path

view details

push time in 14 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha 559fcdffe5057e8609fd8e17d295037a57d2c5b4

Unify resource loading

view details

push time in 14 days

push eventalgorand/js-algorand-sdk

Jason Paulos

commit sha afa60d9006d6e6baa99b76388cc2ac4b99b61d30

Break up step definition file

view details

push time in 14 days

pull request commentalgorand/py-algorand-sdk

remove the zero receiver from transaction

LGTM 👍

mjiang102628

comment created time in 14 days

push eventalgorand/js-algorand-sdk

jecassis

commit sha 08807c8a417bb2402167eb2b6dd3ccda44e88c55

Update Keccak library to 3.0.0 (#151) * Update Keccak library to 3.0.1 - Fixes #126 * Add test for htlc keccak hash function Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>

view details

push time in 15 days

PR merged algorand/js-algorand-sdk

Update Keccak library to 3.0.0

The keccak256 wrapper package is not needed as the only usage in the SDK is already guaranteed to be a buffer. So dropped it and in the process updated the keccak package to 3.0.0 and made it a direct dependency to fix the failure in #126 where the function overloads in the C++ library without arguments where removed from Node.js's V8 bindings.

Fixes #126

+66 -35

4 comments

4 changed files

jecassis

pr closed time in 15 days

issue closedalgorand/js-algorand-sdk

Does not install with latest Node 12 LTS

Hi,

This release added a dependency on keccak256 which in turn uses an outdated version of the native keccak library (1.4.0) causing node-gyp to fail compilation.

The native version v3.0.0 has this issue fixed but the middleware library does not use it.

Regards, Mauro.

closed time in 15 days

mxmauro

PR opened algorand/js-algorand-sdk

Run tests for browser

Closes #211.

+27 -33

0 comment

2 changed files

pr created time in 15 days

create barnchalgorand/js-algorand-sdk

branch : jasonpaulos/test-browser

created branch time in 15 days

push eventjecassis/js-algorand-sdk

algorotem

commit sha dc857c363f7b8182ec004ea143a47d2eb699a803

Release/v1.7.1 (#205) See CHANGELOG.md for details. Review: https://github.com/algorand/js-algorand-sdk/pull/205

view details

Jason Paulos

commit sha 8c7f21a85b032e3bf18bff6951796786017bd880

Merge branch 'master' into release/v1.7.2

view details

Jason Paulos

commit sha c012397e5913f6a583df641bea5e0e81788d3ccb

1.7.2

view details

algorotem

commit sha 6f3d3a71ee57564615118fd1578ae98de7cc1411

Merge pull request #217 from algorand/release/v1.7.2 Release/v1.7.2

view details

Jason Paulos

commit sha 3a052ea3109e212fb962c1691051dcc169f9343d

Add way to encode/decode addresses from binary (#216) * Add way to encode/decode addresses from binary

view details

Evan Richard

commit sha fd1f22700ed0ecd53ac0cc302fc074e805036727

Add helpers for converting buffers to Transactions and vice versa. (#218) It is a very common use case that js user-devs wish to take a Transaction, convert it to bytes, and then convert it back to a Transaction - either for reading and writing to file, coming in as bytes from a wire, or something else. The js-sdk does support this, but usage is non-obvious and error-prone. So, this commit adds three functions to algosdk: encodeUnsignedTransaction to turn a Transaction into bytes, decodeUnsignedTransaction to take those bytes back to a Transaction, and decodeSignedTransaction to take the output of Transaction.signTxn and turn it into something more usable. (decodeSignedTransaction would also work on the blob member of the object output by algosdk.signTransaction). Review: https://github.com/algorand/js-algorand-sdk/pull/218 Resolves: https://github.com/algorand/js-algorand-sdk/issues/114 https://github.com/algorand/js-algorand-sdk/issues/176

view details

Jason Paulos

commit sha 07ed42f50f77d24fce807785a72a4a6f2d289d62

Add rekey param to make txn functions (#221)

view details

John Lee

commit sha b675872ba54a58abde59c636a7536769f65d2746

Remove travis token from build status image (#223)

view details

Jason Paulos

commit sha dc213128286b1295c5b6d3dba73e9a8cad81a4d7

Merge branch 'develop' into develop

view details

push time in 15 days

push eventEvanJRichard/msgpack-javascript

Jason Paulos

commit sha 38681cf1dd147fd7092e1502e91956543cb61ad7

Fix BigInt 64-bit decoding

view details

push time in 15 days

delete branch algorand/js-algorand-sdk

delete branch : onetechnical-remove-travis-token

delete time in 18 days

push eventalgorand/js-algorand-sdk

John Lee

commit sha b675872ba54a58abde59c636a7536769f65d2746

Remove travis token from build status image (#223)

view details

push time in 18 days

PR merged algorand/js-algorand-sdk

Reviewers
Remove travis token from build status image

This token is only necessary for private repositories and could potentially leak private repository (i.e. not this repository) information.

+1 -1

0 comment

1 changed file

onetechnical

pr closed time in 18 days

PullRequestReviewEvent
more