profile
viewpoint
Jan Lelis janlelis Berlin https://janlelis.com Full-Range Web Developer and TRICK awarded Rubyist. I dream in Unicode.

janlelis/clipboard 301

Ruby access to the clipboard on Windows, Linux, macOS, Java, Cygwin, and WSL 📋︎

janlelis/debugging 42

Improve your Print Debugging

janlelis/characteristics 23

Character info under different encodings

janlelis/code 21

Displays a Ruby method's source code

janlelis/debundle.rb 21

Allows you to use gems not in your Gemfile.

farao/elixir-ecc 17

An elixir module for elliptic curve cryptography

janlelis/better-array 15

Unobtrusive JavaScript Array Extras

janlelis/boolean2 11

Boolean2 is a Ruby constant that is an ancestor of true and false.

janlelis/az 10

From A to Z

janlelis/derb 10

Dockerfile.erb

startednguyenquangminh0711/ruby_jard

started time in 2 days

issue openedjuwi/palava-ansible

role: turnserver

created time in 4 days

issue openedjuwi/palava-ansible

role: nginx

created time in 4 days

issue openedjuwi/palava-ansible

role: general

  • fail2ban
  • unattended-upgrades

created time in 4 days

issue openedjuwi/palava-ansible

role: palava-web

created time in 4 days

issue commentjuwi/palava-ansible

role: stunserver

/etc/defaults/stun

# Defaults for stun initscript
# sourced by /etc/init.d/stun
# installed at /etc/default/stun by the maintainer scripts

#
# This is a POSIX shell fragment
#

#uncommment the next line to allow the init.d script to start the stun daemon 
START_DAEMON=true

# Additional options that are passed to the Daemon.
DAEMON_OPTS=""

PRIMARY_IP="1st IP"
SECONDARY_IP="2nd IP"
PRIMARY_PORT=3478
SECONDARY_PORT=3479

# whom the daemons should run as
DAEMON_USER=nobody
janlelis

comment created time in 4 days

issue openedjuwi/palava-ansible

role: stunserver

created time in 4 days

issue openedjuwi/palava-ansible

signaltower staging env

created time in 4 days

issue openedjuwi/palava-ansible

signaltower systemd

created time in 4 days

push eventjuwi/palava-ansible

Jan Lelis

commit sha b4c7a32359897509b5ed008a47f877ccc67a0cdb

Fix role name

view details

push time in 4 days

push eventjuwi/palava-ansible

Jan Lelis

commit sha 97670642b5c5c991cd294a860faeb2008ee453ff

README: First deployment instructions

view details

push time in 4 days

push eventjuwi/palava-ansible

Jan Lelis

commit sha 5a7abc677fc7b6a2f0048385147825f9203522da

Use root user instead of plv

view details

push time in 4 days

push eventjuwi/palava-ansible

Jan Lelis

commit sha dfd534ad28bd949785d2a76cd6a08887df870510

Update README.md

view details

push time in 4 days

issue closedjanlelis/irbtools

Can't install irbtools-more due to drx gem

I want to use irbtools-more for my irb session. However, the gem depends on drx which is not supported for Ruby > 2.0 (https://github.com/mooffie/drx/issues/6) Is there a way for me to skip the gem drx so that I can still use irbtools-more?

closed time in 4 days

foreverLoveWisdom

push eventjanlelis/unicode-emoji

Chris Stringer

commit sha fbe095c1844dca14543bfacf40bd39c427162c1f

Correct year for Emoji 13

view details

Jan Lelis

commit sha 6ba17ebcca397624e7768d728196892cb9b144e3

Merge pull request #7 from jcstringer/emoji_13_date Correct year for Emoji 13

view details

push time in 9 days

PR merged janlelis/unicode-emoji

Correct year for Emoji 13

There appeared to be a typo in the README so just proposing this correction

+1 -1

1 comment

1 changed file

jcstringer

pr closed time in 9 days

pull request commentjanlelis/unicode-emoji

Correct year for Emoji 13

Awesome, thanks!

jcstringer

comment created time in 9 days

issue closedjanlelis/unicode-display_width

Bold/Italic Unicode characters incorrect width

Example: 𝗕𝗼𝗹𝗱

Javascript count this as 8 characters (just like emojis, each bold character has the length 2).

Ruby counts this word as 4 characters, causing an inconsistency with the frontend.

I just tried it with this Gem, but Unicode::DisplayWidth.of("𝗕𝗼𝗹𝗱") still returns 4.

Is this a bug or is there something I need to do in order to make it work for my use case?

Thank you

closed time in 10 days

kalemi19

issue commentjanlelis/unicode-display_width

Bold/Italic Unicode characters incorrect width

The length return by JavaScript is the number of code units required to represent the data in UTF-16. You can use the unibits utility to get a lower-level view of the data:

𝗕                                       𝗼                                       
U+1D5D5                                 U+1D5FC                                 
35        D8        D5        DD        35        D8        FC        DD        
00110101  11011000  11010101  11011101  00110101  11011000  11111100  11011101  

𝗹                                       𝗱                                       
U+1D5F9                                 U+1D5F1                                 
35        D8        F9        DD        35        D8        F1        DD        
00110101  11011000  11111001  11011101  00110101  11011000  11110001  11011101  

Each code point (i.e. character) is made of 4 bytes which resemble the lower and the higher code unit in UTF-16 (also see https://en.wikipedia.org/wiki/UTF-16)

What this library (unicode-display_width) does is assigning a width to each code point, using each code point's EastAsianWidth as a one major factor (see https://www.unicode.org/reports/tr11/#Overview). As stated in the first comment, the bold characters have no full-width property defined, which is why they are counted as being just on 1 terminal space wide.

kalemi19

comment created time in 11 days

startedant-media/Ant-Media-Server

started time in 12 days

created tagjanlelis/clipboard

tag1.3.5

Ruby access to the clipboard on Windows, Linux, macOS, Java, Cygwin, and WSL 📋︎

created time in 14 days

push eventjanlelis/clipboard

Jan Lelis

commit sha ff1ca29f43eb303184d2df2bfcb77fd1aaef04e5

Release 1.3.5

view details

push time in 14 days

push eventjanlelis/clipboard

Jan Lelis

commit sha a3f86b33d7ff12166903b7af7eef04b2581463fd

Update travis Rubies

view details

push time in 14 days

pull request commentjanlelis/clipboard

Fix missing String#+@ method on Ruby <2.3

Good catch, thank you!

AaronC81

comment created time in 14 days

push eventjanlelis/clipboard

Aaron Christiansen

commit sha 88af82bfb6183aa9cffd8a18feca2cbca8c364ee

Fix missing String#+@ method on Ruby <2.3

view details

Jan Lelis

commit sha f03e81837f4c91c3f4e23e444945ba7d74426cf6

Merge pull request #39 from AaronC81/AaronC81-string-unary-plus-fix Fix missing String#+@ method on Ruby <2.3

view details

push time in 14 days

PR merged janlelis/clipboard

Fix missing String#+@ method on Ruby <2.3

The unary plus method on String was only added in Ruby 2.3, so trying to use the Windows clipboard implementation on an earlier version (in my case, Ruby 2.2) raises an exception.

This replaces the use of the unary plus method with #dup, which should be equivalent for this string literal.

+1 -1

0 comment

1 changed file

AaronC81

pr closed time in 14 days

issue commentjanlelis/irbtools

Can't install irbtools-more due to drx gem

Hey there, please make sure you are using the newest versions of irbtools and irbtools-more - it should work since drx was dropped a long time ago

foreverLoveWisdom

comment created time in 14 days

startedmatthutchinson/acts_as_textcaptcha

started time in 22 days

startedpd3f/pd3f

started time in 22 days

startedlwissler/co2_company_data

started time in 22 days

startedgridsome/gridsome

started time in 22 days

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha b40e265a7f221f13d71232693cd29f8d081df155

Site updated to d84dc9b

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 6ceb34acba227c987cfa0930e02adb086e438a27

Add 75: "Ruby TRICKS of 2018"

view details

Jan Lelis

commit sha 14ff8f0c0b99d80951cd81d7c76055a2927cc925

Ref commit

view details

Jan Lelis

commit sha d84dc9b965b4b954c9d65de7739c5cef73bdce3d

End of season

view details

push time in a month

CommitCommentEvent

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 090579440de263093e1cff21257e49035fb20230

Site updated to 0875b08

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 7b42ce13f2f77cdabfb873cd2ced891dfb1c18e2

Add new episodes to categories overview

view details

Jan Lelis

commit sha 0875b082b1c1d0641ce65a4c389a8d2df7d13ee8

74: Add __label__ and __goto__ note

view details

push time in a month

push eventjanlelis/uniscribe

Jan Lelis

commit sha 4a13da5a75f3c97232cb4d3e0ac4ce123ff8d4d3

Update README.md

view details

push time in a month

push eventjanlelis/unicode-age

Jan Lelis

commit sha 0ff7191e61a56a3da28602910b55658e1225eabd

Link to Unicode / Ruby version table

view details

push time in a month

issue commentjanlelis/unicode-display_width

Bold/Italic Unicode characters incorrect width

Hi @kalemi19,

unfortunately, the Unicode standard does not provide a definite way how exact string width should be calculated. However, they do provide EastAsianWidth.txt which lists 𝗕 as a neutral/narrow letter.

Which method do you use to retrieve the character count in JavaScript?

kalemi19

comment created time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 0452e494267bb1e4aa3cbf06efb93278ecb378c9

Site updated to b04b48c

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha a5268be57200ea7caba0f182de25e4d954df6887

Add 74: "Super Snakes"

view details

Jan Lelis

commit sha b04b48c686402931f28ba02949599992e2fbc384

Ref commit

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 9fb37a69821a8ea3aab92a0a1eb0558ea77299be

Site updated to a461906

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha a89b4dc2a50e86f0a85224559c57096531a9ddec

20: Update standard library guide to 2.7

view details

Jan Lelis

commit sha 4ac53fd158418c84792420c367ea6d7ef2c4e5c7

20: Update GitHub links

view details

Jan Lelis

commit sha 62a61f5ddd7f886b0a5713d7d791ddc8039accf3

Add 73: "Unicode Version Mapping"

view details

Jan Lelis

commit sha 2b5c0a40650be4a3ef487db33534d9f2e522e2ec

Ref commit

view details

Jan Lelis

commit sha a46190624b63fc36dd3a0d12bd63ddf5c2b189ee

41: Link to Unicode table

view details

push time in a month

push eventjanlelis/stdgems

Jan Lelis

commit sha 36871e7de8d4e04213a8c61482e685b9b04ab002

Site updated to 187ab2c

view details

push time in a month

push eventjanlelis/stdgems

Jan Lelis

commit sha 187ab2ceff5004774b03ae07082e927e04b22123

Fix GitHub branch

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha da806ccfe5898e20afc767518e327c62b0d4ef0f

Site updated to fd1770c

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 4e5de6caf45872b89b0fcb33817b0c2cec092b7f

Add 72: "Clear Case of Unclear Casing"

view details

Jan Lelis

commit sha fd1770c5a115c4d25486fc5a9f43f3525393cf6d

Ref commit

view details

push time in a month

CommitCommentEvent

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha d457c4c42c5a6f31c537c84df3f1e26b8a773edd

Site updated to 1d42f42

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 61e201150a37e3037c7efe1925aed558b47640ba

Add 71: "Nothing to Disable"

view details

Jan Lelis

commit sha 77b102d1b94c9dfd09ffd22067d04b9b07046648

Ref commit

view details

Jan Lelis

commit sha 1d42f42642b7af7a15dd60c63a03a3a7de6b1c41

70: Add @cremno's null byte

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha c13c84d06296e12c73ef90b4457459e3b31ed1ad

Site updated to 282d3d2

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 0698caf6b5b0c67404d664eed10f68e58002bcf8

Add 70: "Nothing to Escape"

view details

Jan Lelis

commit sha 282d3d240f21d8cc069668cc397a8d566e8b8833

Ref commit

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 34b178302912234def351754e77dc5ba0892797d

Site updated to 4accb69

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 25dd2fad64b925fd33d7dd98a13dcdeda76ab65f

2: Update String method count to Ruby 2.7

view details

Jan Lelis

commit sha fcf3806b60bbc6c1c1413e8fbb398ea61f8059f1

14: Add new pattern assignment

view details

Jan Lelis

commit sha 6a13ded9cdb18cc547a6a996c8a3e8495e0b3fe3

16: Update outdated link

view details

Jan Lelis

commit sha ed0171928b11c9aa5dd97fc0061947a801127b05

27: Add code.golf

view details

Jan Lelis

commit sha 991667f91b0248e714f07dfc270e4df1c254294f

66: Current Unicode version is 13.0

view details

Jan Lelis

commit sha dea153bddb27756ac899b7ca53d03fdf22ee86da

Add new episodes to categories page

view details

Jan Lelis

commit sha 0cba8fd4d2394bb20c111d66fd1413e8a1a0044b

Add 69: "Nothing to Compare"

view details

Jan Lelis

commit sha 4accb69d585f2bfaf40406c2f9b9beedc8948341

Ref commit

view details

push time in a month

startedankane/ahoy

started time in a month

push eventjanlelis/stdgems

Jan Lelis

commit sha 21600b64dada204345503c4c2c19fd9c750ab151

Site updated to ac21505

view details

push time in a month

push eventjanlelis/stdgems

Jan Lelis

commit sha ac215055c8030d98b13e4cc0cd0697e70a577072

Add Ruby 2.7 to supported Rubies and remove 2.4

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 1e0e528c6db1a774cc56320c530dbfa75531e240

Site updated to d9d8b24

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 9a8457193e9c0406096054d41433311bafd0594f

Update dependencies

view details

Jan Lelis

commit sha ab3ef49cd5d1d0f76b5e96671890407ad76fed29

Homepage wording updates

view details

Jan Lelis

commit sha 8e88e9738e96aecbd18d05ccb5d92f0f6fb3cf30

Add 67: "Warning: The Experiment"

view details

Jan Lelis

commit sha aa62f69f4b26de260d6e39292dc4b74ff641745c

Ref commit

view details

Jan Lelis

commit sha 2bc0ab6325415a4bad09caeea2c6398f09c95150

Add 68: "Assignments In-Style"

view details

Jan Lelis

commit sha d9d8b24bb1621d19526f938a0868d708dd85e333

Ref commit

view details

push time in a month

push eventjanlelis/idiosyncratic-ruby.com

Jan Lelis

commit sha 613a4c34ad6bf756c48f00032f006794ad1f55f8

Site updated to aa62f69

view details

push time in 2 months

starteddropbox/fast_rsync

started time in 2 months

startedjdemaeyer/brightsky

started time in 2 months

issue commentstrapi/strapi

Not possible to use an absolute directory as public path

Hi @petersg83 - I upgraded from beta19.5 to the latest stable (3.1.2)

I am putting all uploaded assets into a folder which the web server has access to (and which is part of the Front-end application) so that the web server can serve them directly to the users.

janlelis

comment created time in 2 months

starteddumblob/mysql2sqlite

started time in 2 months

issue openedstrapi/strapi

Not possible to use an absolute directory as public path

Describe the bug

Hey there, thank you for strapi, it's awesome!

After updating from beta to the latest stable (3.1.2) it seems that using absolute paths as the public directory breaks file uploads (which used to work before) :confused:

Steps to reproduce the behavior

  1. Go to 'config/middleware.js'

  2. Edit option 'settings.public' as described here https://strapi.io/documentation/v3.x/concepts/middlewares.html#core-middleware-configurations

  3. Enter an /absolute/path

  4. Upload a file

  5. See error message

    error Error: ENOENT: no such file or directory, open '/path/to/strapi/absolute/path/uploads/<filename>'

Expected behavior

File upload should work

System

  • Node.js version: 12.16.1
  • NPM version: 6.13.4
  • Strapi version: 3.1.2
  • Database: MySQL
  • Operating system:

Distributor ID: Debian Description: Debian GNU/Linux 10 (buster) Release: 10 Codename: buster

created time in 2 months

startedLuminosoInsight/python-ftfy

started time in 2 months

startedAndyObtiva/glimmer

started time in 2 months

startedenvato/zxcvbn-ruby

started time in 2 months

startedalacritty/copypasta

started time in 2 months

push eventpalavatv/palava-client

Jan Lelis

commit sha ec0cb4861c9161b795f39188042b1711b88fbc91

Fix passing around turn credentials

view details

push time in 2 months

push eventpalavatv/palava-client

Jan Lelis

commit sha 996fda72596955eba1fcf350f36c8c6ded3841cf

LocalPeer#{disable,enable}{Audio,Video}: Mute microphone / disable camera

view details

Jan Lelis

commit sha 0da869d336f8ac2d94b7e6ba5a5e855038ea079f

Improve Peer#has{Audio,Video} checks to also check for enabled status, and: - Add Peer#canSend{Audio,Video} to only check for capabilities (i.e. tracks are present)

view details

Jan Lelis

commit sha 5b5ddcc71ee075fb18b363e8979d99751b0e28ad

Improve naming of has{Audio,Video}() methods

view details

Jan Lelis

commit sha b044398ebb6dab9baafcf03489d8273266595182

Return booleans in transmits{Audio,Video}

view details

Jan Lelis

commit sha 2bb3ac22d7ff43f095952a39f467d1c9e29b97d6

Rework rake tasks

view details

Jan Lelis

commit sha e6f6392accb1bcf138919761657672181aa07d85

Rebuild bundle/docs & release v2.1.0

view details

Marius Melzer

commit sha 4239dfecafb12f2b1615a503364fad827658d9f8

Add TURN support The client receives a turn login on room join if the server supports TURN. It first tries a connection via stun. If that fails, it tries again with turn using the received login.

view details

push time in 2 months

issue openedpalavatv/palava-client

Make TURN accessible via UDP and TCP

created time in 2 months

Pull request review commentpalavatv/signaltower

Add TURN support

 defmodule RoomTest do      _user2 =       spawn_user_no_join(fn ->-        GenServer.call(room_pid, {:join, self(), %{user: "1"}})+        GenServer.call(room_pid, {:join, self(), %{user: "1"}, 0})

Maybe GenServer's handle_call can have 0 as default value

farao

comment created time in 2 months

Pull request review commentpalavatv/signaltower

Add TURN support

 defmodule SignalTower.Room do     end)   end -  defp send_joined_room(pid, peer_id, members) do-    response_for_joined_peer = %{-      event: "joined_room",-      own_id: peer_id,-      peers: members |> Map.values()-    }+  defp send_joined_room(pid, own_id, members, turn_timeout) do+    now = System.os_time(:second)++    {turn_response, next_turn_timeout} =

*turn_timeout seems to be a kind of expire_date - do you agree this would make the code more readable?

farao

comment created time in 2 months

Pull request review commentpalavatv/signaltower

Add TURN support

 By default, the websocket is bound to all interfaces (0.0.0.0), you can also bin export SIGNALTOWER_LOCALHOST ``` +## References+ [palava protocol]: https://github.com/palavatv/palava-client/wiki/Protocol

Issue to track: https://github.com/palavatv/palava-client/issues/32

farao

comment created time in 2 months

Pull request review commentpalavatv/signaltower

Add TURN support

 defmodule SignalTower.Room do     end)   end -  defp send_joined_room(pid, peer_id, members) do-    response_for_joined_peer = %{-      event: "joined_room",-      own_id: peer_id,-      peers: members |> Map.values()-    }+  defp send_joined_room(pid, own_id, members, turn_timeout) do+    now = System.os_time(:second)++    {turn_response, next_turn_timeout} =+      if System.get_env("SIGNALTOWER_TURN_SECRET") && turn_timeout < now do+        next_timeout = now + 3 * 60 * 60

Could this value (3h) be extracted to its own variable/constant ("no magic numbers": https://en.wikipedia.org/wiki/Magic_number_(programming))

farao

comment created time in 2 months

issue openedpalavatv/palava-client

Document current version of the palava protocol

Including TURN: https://github.com/palavatv/palava-client/wiki/Protocol

created time in 2 months

issue commentpalavatv/palava-web

Testing on Android (Chrome)

@pascalwengerter This is probably related to the missing TURN support (see https://github.com/palavatv/signaltower/pull/30, and https://palava.tv/info/about "Important" section), which is the most important issue right now to make palava more reliable

janlelis

comment created time in 2 months

issue commentpalavatv/palava-web

Play a sound when someone connects or disconnects

Hey Pascal! Thanks for the proof-of-concept "beep"! Although I Love that it is generated in the browser, I think from a sound-design perspective, there is still some room for improvements :). Maybe we can jam with the sounds on some other web platform (where jamming is easier) and then move it to palava? (We could also do a jam session at my place!)

janlelis

comment created time in 3 months

pull request commentjanlelis/paint

Fix broken link in README.md

Awesome, thank you!

eizengan

comment created time in 3 months

push eventjanlelis/paint

Nate Eizenga

commit sha 1ad52147ca6a0dd0db4b42e5cd3c39e961a6ab24

Fix broken link in README.md

view details

Jan Lelis

commit sha f35f57ae2540fd8021735b6f011be36687ca8b8b

Merge pull request #27 from eizengan/main Fix broken link in README.md

view details

push time in 3 months

PR merged janlelis/paint

Fix broken link in README.md

Hello! Noticed this broken link while checking out your gem - figured I'd lend a hand

+1 -1

0 comment

1 changed file

eizengan

pr closed time in 3 months

pull request commentpalavatv/palava-web

Add TURN support

https://github.com/palavatv/palava/issues/45

farao

comment created time in 3 months

issue openedpalavatv/palava

Multiple TURN servers

Is your feature request related to a problem? Please describe. A single TURN server has limited band-width

Describe the solution you'd like A way to configure multiple TURN servers (might be done via the signaling protocol)

Additional context Will be implemented after initial TURN implementation

created time in 3 months

push eventjanlelis/unicode-display_width

Jan Lelis

commit sha bbfce64e2da3a4b58d0e5d87b4b405fdce45f9eb

Fix typo in README

view details

push time in 3 months

issue commentpalavatv/palava-web

Play a sound when someone connects or disconnects

@pascalwengerter Awesome! I'll take a look early next week!

If it is stable enough web audio would be awesome, maybe option 2 is just a fall-back (on the other hand, we currently only target modern browsers)

janlelis

comment created time in 3 months

startedschenkd/nginx-ui

started time in 3 months

pull request commentpalavatv/palava-web

Add TURN support

@farao Looks good, and I just wanted to merge, however one thing just came to my mind: How should we configure multiple TURN servers?

farao

comment created time in 3 months

pull request commentpalavatv/palava-web

Add TURN support

Awesome to see this finally being tackled!

farao

comment created time in 3 months

push eventpalavatv/palava-web

Jan Lelis

commit sha d527dfa1c7968dd4f9ea4cfb8a729754ed7d85cd

Fix session initalization

view details

push time in 3 months

Pull request review commentpalavatv/palava-client

Add TURN support

 class palava.Session extends @EventEmitter     @room.on 'signaling_error',      (t, e) => @emit 'signaling_error', t, e     true +  createTurnAPIClient: =>

is this still needed?

farao

comment created time in 3 months

Pull request review commentpalavatv/palava-client

Add TURN support

 class palava.Session extends @EventEmitter      @createChannel()     @createRoom()+    @createTurnAPIClient

is this still needed?

farao

comment created time in 3 months

Pull request review commentpalavatv/palava-client

Add TURN support

 class palava.RemotePeer extends palava.Peer      @peerConnection +  # Check if turn was already tried as (last) connection option+  #+  # @return [Boolean] true if turn was tried by using the tryTurn function+  #+  hasTriedTurn: => !!@turnCredentials++  # Check if turn was already tried as (last) connection option+  #+  # @return [Object] true if turn was tried by using the tryTurn function+  #+  tryTurn: (credentials) =>

+1 for the idea to only use TURN when the peer connection has failed

farao

comment created time in 3 months

Pull request review commentpalavatv/palava-client

Add TURN support

 class palava.RemotePeer extends palava.Peer     @setupPeerConnection(offers)     @setupDistributor() +    @offers = offers

If #20 yields that we have to keep this around, we should really rename this flag

farao

comment created time in 3 months

Pull request review commentpalavatv/palava-client

Add TURN support

 class palava.RemotePeer extends palava.Peer     options = []     if @room.options.stun       options.push({urls: [@room.options.stun]})-    if @room.options.turn+    if @room.options.turn && @turnCredentials       options.push-        urls: [@room.options.turn.url]-        username: @room.options.turn.username-        credential: @room.options.turn.password+        urls: [@room.options.turn]+        username: @turnCredentials.user

+1 for completely removing static configuration!

farao

comment created time in 3 months

push eventpalavatv/palava-client

Jan Lelis

commit sha 996fda72596955eba1fcf350f36c8c6ded3841cf

LocalPeer#{disable,enable}{Audio,Video}: Mute microphone / disable camera

view details

Jan Lelis

commit sha 0da869d336f8ac2d94b7e6ba5a5e855038ea079f

Improve Peer#has{Audio,Video} checks to also check for enabled status, and: - Add Peer#canSend{Audio,Video} to only check for capabilities (i.e. tracks are present)

view details

Jan Lelis

commit sha 5b5ddcc71ee075fb18b363e8979d99751b0e28ad

Improve naming of has{Audio,Video}() methods

view details

Jan Lelis

commit sha b044398ebb6dab9baafcf03489d8273266595182

Return booleans in transmits{Audio,Video}

view details

Jan Lelis

commit sha 2bb3ac22d7ff43f095952a39f467d1c9e29b97d6

Rework rake tasks

view details

Jan Lelis

commit sha e6f6392accb1bcf138919761657672181aa07d85

Rebuild bundle/docs & release v2.1.0

view details

Marius Melzer

commit sha 2999fc858fe83c5e0cdff8813d5565c109594c58

Add TURN support The client receives a turn login on room join if the server supports TURN. It first tries a connection via stun. If that fails, it tries again with turn using the received login.

view details

Jan Lelis

commit sha 5d82b91592efc017dbe5688110913fd0e3bd9220

Fix passing around turn credentials

view details

push time in 3 months

push eventpalavatv/palava-web

Jan Lelis

commit sha 32b5eb1a802b3a31f3fa3c4f07009ff4205239f2

Turn off/on microphone/camera in-session, fixes #9

view details

Marius Melzer

commit sha 849870479421a59e414e4939757e24fb323dddeb

Add TURN support The TURN server url can be set via environment variable VUE_APP_TURN_URL.

view details

Jan Lelis

commit sha 8e395bbbde2e0179f270b9b94a24104f9bd42a67

README fixes

view details

push time in 3 months

push eventpalavatv/palava-web

Jan Lelis

commit sha 32b5eb1a802b3a31f3fa3c4f07009ff4205239f2

Turn off/on microphone/camera in-session, fixes #9

view details

push time in 3 months

PR merged palavatv/palava-web

Turn off/on microphone/camera in-session, fixes #9

Requires https://github.com/palavatv/palava-client/pull/29

+30 -10

0 comment

1 changed file

janlelis

pr closed time in 3 months

more