profile
viewpoint

jacobstr/confer 98

Configuration management with extra protein.

jacobstr/django-dynamic-formset 3

Git mirror of django-dynamic-formset: http://code.google.com/p/django-dynamic-formset (updates every hour)

derekdowling/bursa 2

Go/React Webstack for doing Bitcoin Wallet Provisioning

jacobstr/connect-mongo 2

MongoDB session store for Connect.

jacobstr/dumpling 2

Very simple PHP object dumper.

jacobstr/crusher 1

Slack bot for campsite reservations.

jacobstr/django-filter 1

A generic system for filtering Django QuerySets based on user selections

jacobstr/django-haystack 1

Modular search for Django. Currently v1.1.0-alpha.

startedNerdyPepper/dijo

started time in 15 days

startedcorkami/formats

started time in 25 days

issue commentplanetlabs/draino

Ask god what the draino works?

Yes your understanding is correct:

  • NPD sets node conditions. By themselves, conditions do not cause a node to be drained and cordoned. Many are informational.
  • Draino allows one to configure conditions that should result in the node being drained - what you described as 👇:

In order to prevent reuse of this node, draino will Each node is set as maintenance and cannot be scheduled to prevent other containers from being allocated to this node and expel the pod of the node.

  • Regular kubernetes mechanisms will attempt to schedule your pod to another node (e.g. because only 2/3 pod replicas are now running).
  • As a result of the node being drained, the autoscaler will typically identify an underutilized node and delete it. This threshold is configurable in the autoscaler. Draino does not itself destroy nodes.
  • As a result of there being fewer nodes, the autoscaler will typically create a new one for you if there is is not enough CPU/Memory in the remaining nodes to schedule the pods that were evicted when the node was drained.
zhaocheng173

comment created time in a month

push eventjacobstr/crusher

Jacob Straszynski

commit sha 9fb04d7aa9310349d7650a1dad056ba9aba26a27

add a deploy step

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha 8f0299b43dd8a116df57b04fb2c161ab33b1d68b

add a deploy step

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha 3d3d1b930323f688f6974f6fe60b881674672920

add a deploy step

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha 019a75a30873461af72fb0e256298c8a730b331d

add a deploy step

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha f8fed6299946c33160db37336c8b7ef38487961a

add a deploy step

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha 3c4eca5c92e4de1cfd446f773ca6c95c0529d620

add a deploy step

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha ad2600cd666e770e8c89f4bd12c6edd21736e1bf

add a deploy step

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha 55e63c62d67cca2921d7d12d845a7e3e9bae69e7

ci debugging joy

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha d11907869272a34b83745a4afd76705a002a25c7

ci debugging joy

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha ae69d7d5ff1804df5306dc8502be61304f067ea9

there's the deploy folder..

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha 7c2fc817bd6cad6de70d3f126bb488628bab0e5d

cd to the build dir yo

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha e8207c8c4f2b7980529163ddd89624491cb64e98

whatever, travis

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha edc9dc2ff9309095551234fb2129ca94a4710a48

beautiful debugging CI in the open

view details

push time in 2 months

push eventjacobstr/crusher

Jacob Straszynski

commit sha 7348f17a3350eb9baf72ec95572eccfbbfda7aca

add a deploy step

view details

push time in 2 months

push eventjacobstr/crusher

dependabot[bot]

commit sha 4eb6cc496063cf87a29b848e9888fbbae863666a

Bump urllib3 from 1.24 to 1.24.2 in /server Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.24 to 1.24.2. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/master/CHANGES.rst) - [Commits](https://github.com/urllib3/urllib3/compare/1.24...1.24.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jacob Straszynski

commit sha bae681d5a5014ddd6c3aa4f08199f6874a2c4f06

Merge pull request #16 from jacobstr/dependabot/pip/server/urllib3-1.24.2 Bump urllib3 from 1.24 to 1.24.2 in /server

view details

push time in 2 months

PR merged jacobstr/crusher

Bump urllib3 from 1.24 to 1.24.2 in /server dependencies

⚠️ Dependabot is rebasing this PR ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.


Bumps urllib3 from 1.24 to 1.24.2. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/master/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h2>1.24.2 (2019-04-17)</h2> <ul> <li> <p>Don't load system certificates by default when any other <code>ca_certs</code>, <code>ca_certs_dir</code> or <code>ssl_context</code> parameters are specified.</p> </li> <li> <p>Remove Authorization header regardless of case when redirecting to cross-site. (Issue <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1510">#1510</a>)</p> </li> <li> <p>Add support for IPv6 addresses in subjectAltName section of certificates. (Issue <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1269">#1269</a>)</p> </li> </ul> <h2>1.24.1 (2018-11-02)</h2> <ul> <li> <p>Remove quadratic behavior within <code>GzipDecoder.decompress()</code> (Issue <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1467">#1467</a>)</p> </li> <li> <p>Restored functionality of <code>ciphers</code> parameter for <code>create_urllib3_context()</code>. (Issue <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1462">#1462</a>)</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/1efadf43dc63317cd9eaa3e0fdb9e05ab07254b1"><code>1efadf4</code></a> Release 1.24.2 (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1564">#1564</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/a6ec68a5c5c5743c59fe5c62c635c929586c429b"><code>a6ec68a</code></a> Merging new release version: 1.24.1</li> <li><a href="https://github.com/urllib3/urllib3/commit/0cedb3b0f1e5d79c89c6db767c534b064b794cf2"><code>0cedb3b</code></a> Restore context.set_ciphers() to create_urllib3_context() (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1463">#1463</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/0aeba3be0224a930f6ffef254ed12b41303a86d7"><code>0aeba3b</code></a> Use bytearray to accumulate bytes from gzip (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1468">#1468</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/f8d1c787d9b02a70d66ddbde9c99061d9073d54a"><code>f8d1c78</code></a> Uninstall oclint to ensure gcc can be brew upgraded (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1464">#1464</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/cd7cfa613b2678e700597d098ce9bbdc934863e6"><code>cd7cfa6</code></a> Resolve pytest pluggy version conflict (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1457">#1457</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b548abc9812a628d3290d0cab83e44f3c31ac6fe"><code>b548abc</code></a> Update changelog for 1.24 release</li> <li>See full diff in <a href="https://github.com/urllib3/urllib3/compare/1.24...1.24.2">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

push eventjacobstr/crusher

dependabot[bot]

commit sha c160800c289e71a85d062b98c25650d742dff006

Bump urllib3 from 1.24 to 1.24.2 in /worker Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.24 to 1.24.2. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/master/CHANGES.rst) - [Commits](https://github.com/urllib3/urllib3/compare/1.24...1.24.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jacob Straszynski

commit sha 9b2e8af06fdbf933acd210e2c063656a0ecda1a4

Merge pull request #15 from jacobstr/dependabot/pip/worker/urllib3-1.24.2 Bump urllib3 from 1.24 to 1.24.2 in /worker

view details

push time in 2 months

PR merged jacobstr/crusher

Bump urllib3 from 1.24 to 1.24.2 in /worker dependencies

Bumps urllib3 from 1.24 to 1.24.2. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/master/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h2>1.24.2 (2019-04-17)</h2> <ul> <li> <p>Don't load system certificates by default when any other <code>ca_certs</code>, <code>ca_certs_dir</code> or <code>ssl_context</code> parameters are specified.</p> </li> <li> <p>Remove Authorization header regardless of case when redirecting to cross-site. (Issue <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1510">#1510</a>)</p> </li> <li> <p>Add support for IPv6 addresses in subjectAltName section of certificates. (Issue <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1269">#1269</a>)</p> </li> </ul> <h2>1.24.1 (2018-11-02)</h2> <ul> <li> <p>Remove quadratic behavior within <code>GzipDecoder.decompress()</code> (Issue <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1467">#1467</a>)</p> </li> <li> <p>Restored functionality of <code>ciphers</code> parameter for <code>create_urllib3_context()</code>. (Issue <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1462">#1462</a>)</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/1efadf43dc63317cd9eaa3e0fdb9e05ab07254b1"><code>1efadf4</code></a> Release 1.24.2 (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1564">#1564</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/a6ec68a5c5c5743c59fe5c62c635c929586c429b"><code>a6ec68a</code></a> Merging new release version: 1.24.1</li> <li><a href="https://github.com/urllib3/urllib3/commit/0cedb3b0f1e5d79c89c6db767c534b064b794cf2"><code>0cedb3b</code></a> Restore context.set_ciphers() to create_urllib3_context() (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1463">#1463</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/0aeba3be0224a930f6ffef254ed12b41303a86d7"><code>0aeba3b</code></a> Use bytearray to accumulate bytes from gzip (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1468">#1468</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/f8d1c787d9b02a70d66ddbde9c99061d9073d54a"><code>f8d1c78</code></a> Uninstall oclint to ensure gcc can be brew upgraded (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1464">#1464</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/cd7cfa613b2678e700597d098ce9bbdc934863e6"><code>cd7cfa6</code></a> Resolve pytest pluggy version conflict (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1457">#1457</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b548abc9812a628d3290d0cab83e44f3c31ac6fe"><code>b548abc</code></a> Update changelog for 1.24 release</li> <li>See full diff in <a href="https://github.com/urllib3/urllib3/compare/1.24...1.24.2">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

push eventjacobstr/crusher

Beau Fabry

commit sha 68e020fc547f9ed619f5db84be1e46977583ebb1

add GNP sites

view details

Jacob Straszynski

commit sha 28addb253a37ddfc91d46890ffe80c79d5ef747b

Merge pull request #14 from bfabry/master add GNP sites

view details

push time in 2 months

PR merged jacobstr/crusher

add GNP sites

btw did you ever get the patreon up for this thing

+21 -0

1 comment

1 changed file

bfabry

pr closed time in 2 months

Pull request review commentivanilves/lstags

Fix whitespace handling with gcr service accounts in mind.

 func Load(fileName string) (*Config, error) { 		}  		authenticationToken := string(b)-		usernameAndPassword := strings.Split(authenticationToken, ":")+		usernameAndPassword := strings.SplitN(authenticationToken, ":", 2)

This was the initial change I made in order to fix the decoding of the base64 data I gleaned from my ~/.docker/config.json. The commit message in e33c4e28ec51fbac4d319ee050aad291448a656a discusses how I replicated and tested this:

The shape of the moving parts (username, password) was largely reverse
engineered by:

1. Generating a service account with gcr access and saving to `key.json`.
2. `cat key.json | docker login -u _json_key --password-stdin https://gcr.io`
3. `cat `~/.docker/config.json` should now contain somethin like:```
    "gcr.io" : {
      "auth" : "..."
      }
jacobstr

comment created time in 2 months

Pull request review commentivanilves/lstags

Fix whitespace handling with gcr service accounts in mind.

 func (c *Config) GetCredentials(registry string) (string, string, bool) { }  func getAuthJSONString(username, password string) string {-	if username == "_json_key" {-		return fmt.Sprintf("%s:%s", username, password)+	b, err := json.Marshal(types.AuthConfig{+		Username: "_json_key",+		Password: password,+	})++	// Because of the shape of the struct and inputs involved, this should never+	// happen. We preserve the non error-propagating API for callers, but want+	// some visibility into this that's better than simply swallowing the error.+	if err != nil {+		panic(err)

Potentially a bit lazy here, but I didn't want to mess with your API's to much by changing the signature here.

jacobstr

comment created time in 2 months

Pull request review commentivanilves/lstags

Fix whitespace handling with gcr service accounts in mind.

 func (c *Config) GetCredentials(registry string) (string, string, bool) { }  func getAuthJSONString(username, password string) string {-	if username == "_json_key" {

I tried to grok this a bit - 005c3ac3610d444e9c180a5c73820ae3c6f08b02 mentions that it was done to fix gcr authentication, but I could not get GCR working end to end until I made these changes.

It appeared to work initially - list operations against GCR succeeded. I saw subsequent push failures however.

jacobstr

comment created time in 2 months

Pull request review commentivanilves/lstags

Fix whitespace handling with gcr service accounts in mind.

 func (c *Config) GetCredentials(registry string) (string, string, bool) { }  func getAuthJSONString(username, password string) string {-	if username == "_json_key" {-		return fmt.Sprintf("%s:%s", username, password)+	b, err := json.Marshal(types.AuthConfig{

Considering using an anonymous struct here as well to reduce the dependencies, but I wanted to denote where the fields come from - it may assist future contributors in discovering what authn knobs are available.

jacobstr

comment created time in 2 months

Pull request review commentivanilves/lstags

Fix whitespace handling with gcr service accounts in mind.

 package config  import (+	"fmt"+	"io/ioutil" 	"testing" )  var configFile = "../../fixtures/docker/config.json"  func TestGetRegistryAuth(t *testing.T) { 	examples := map[string]string{-		"registry.company.io":     "eyAidXNlcm5hbWUiOiAidXNlcjEiLCAicGFzc3dvcmQiOiAicGFzczEiIH0=",-		"registry.hub.docker.com": "eyAidXNlcm5hbWUiOiAidXNlcjIiLCAicGFzc3dvcmQiOiAicGFzczIiIH0=",+		"registry.company.io":     "eyJ1c2VybmFtZSI6Il9qc29uX2tleSIsInBhc3N3b3JkIjoicGFzczEifQ==",

The json encoding via json.Marshal strips some of the whitespace, resulting in this base64 difference.

jacobstr

comment created time in 2 months

push eventjacobstr/lstags

Jacob Straszynski

commit sha e33c4e28ec51fbac4d319ee050aad291448a656a

fix: remove special _json_key handling The approach of base64 encoding the json-like structure appears to work fine. The shape of the moving parts (username, password) was largely reverse engineered by: 1. Generating a service account with gcr access and saving to `key.json`. 2. `cat key.json | docker login -u _json_key --password-stdin https://gcr.io` 3. `cat `~/.docker/config.json` should now contain somethin like:``` "gcr.io" : { "auth" : "..." } The password should typically itself be a json-encoded service account i.e. the contents of `key.json` above. We've replaced the parent commits sprintf json-encoding by using the upstream types. Note: we're panicking on the error here vs. propagating it. This is partially laziness, the perceived unlikihood, and finally the desire to keep this change set as straightforward as possible. ```

view details

push time in 2 months

push eventjacobstr/lstags

Jacob Straszynski

commit sha 7a69f1f54fb2bc0dfc689cb104cba66a7f3e5cf3

fix: remove special _json_key handling The approach of base64 encoding the json-like structure appears to work fine. The shape of the moving parts (username, password) was largely reverse engineered by: 1. Generating a service account with gcr access and saving to `key.json`. 2. `cat key.json | docker login -u _json_key --password-stdin https://gcr.io` 3. `cat `~/.docker/config.json` should now contain somethin like:``` "gcr.io" : { "auth" : "..." } The password should typically itself be a json-encoded service account i.e. the contents of `key.json` above. We've replaced the parent commits sprintf json-encoding by using the upstream types. Note: we're panicking on the error here vs. propagating it. This is partially laziness, the perceived unlikihood, and finally the desire to keep this change set as straightforward as possible. ```

view details

push time in 2 months

push eventjacobstr/lstags

Jacob Straszynski

commit sha e349ad2e4f5ba89dd8f0f6aacc7f1da93e8e6ca9

fix: remove special _json_key handling The approach of base64 encoding the json-like structure appears to work fine. The shape of the moving parts (username, password) was largely reverse engineered by: 1. Generating a service account with gcr access and saving to `key.json`. 2. `cat key.json | docker login -u _json_key --password-stdin https://gcr.io` 3. `cat `~/.docker/config.json` should now contain somethin like:``` "gcr.io" : { "auth" : "..." } The password should typically itself be a json-encoded service account i.e. the contents of `key.json` above. We've replaced the parent commits sprintf json-encoding by using the upstream types. Note: we're panicking on the error here vs. propagating it. This is partially laziness, the perceived unlikihood, and finally the desire to keep this change set as straightforward as possible. ```

view details

push time in 2 months

push eventjacobstr/lstags

Jacob Straszynski

commit sha 5783b5084fca2d7f4191b28ba4ce002a9c72ca36

fix: remove special _json_key handling The approach of base64 encoding the json-like structure appears to work fine. The shape of the moving parts (username, password) was largely reverse engineered by: 1. Generating a service account with gcr access and saving to `key.json`. 2. `cat key.json | docker login -u _json_key --password-stdin https://gcr.io` 3. `cat `~/.docker/config.json` should now contain somethin like:``` "gcr.io" : { "auth" : "..." } The password should typically itself be a json-encoded service account i.e. the contents of `key.json` above. We've replaced the parent commits sprintf json-encoding by using the upstream types. Note: we're panicking on the error here vs. propagating it. This is partially laziness, the perceived unlikihood, and finally the desire to keep this change set as straightforward as possible. ```

view details

push time in 2 months

PullRequestEvent

push eventjacobstr/lstags

Jacob Straszynski

commit sha cc2ba493de73f9179990a159f78407c4e9059979

remove special _json_key handling The approach of base64 encoding the json-like structure appears to work fine. The shape of the moving parts (username, password) was largely reverse engineered by: 1. Generating a service account with gcr access and saving to `key.json`. 2. `cat key.json | docker login -u _json_key --password-stdin https://gcr.io` 3. `cat `~/.docker/config.json` should now contain somethin like:``` "gcr.io" : { "auth" : "..." } The password should typically itself be a json-encoded service account i.e. the contents of `key.json` above. We've replaced the parent commits sprintf json-encoding by using the upstream types. Note: we're panicking on the error here vs. propagating it. This is partially laziness, the perceived unlikihood, and finally the desire to keep this change set as straightforward as possible. ```

view details

push time in 2 months

pull request commentivanilves/lstags

Fix whitespace handling with gcr service accounts in mind.

Looks like there's a bit more to this still. Going to close an re-open.

jacobstr

comment created time in 2 months

PR closed ivanilves/lstags

Fix whitespace handling with gcr service accounts in mind.

At some point in time I followed the instructions here to generate a static config.json using a service account authenticated against GCR for use in our CI flows.

The encoded password is actually json and the embedded ":" causes it to be split across multiple array elements. That's undesirable in this case and ends up getting manifest as:

FATA[0004] Bad response status: 401 Unauthorized >>

Because the config loader ends up skipping the element in https://github.com/ivanilves/lstags/blob/master/docker/config/config.go#L108

+23 -10

2 comments

4 changed files

jacobstr

pr closed time in 2 months

push eventjacobstr/lstags

Jacob Straszynski

commit sha a10732b57e42ede3904fb255caa79e2a0610be1a

fix: base64 encoded json service accounts When encoding json service accounts, the base64 encoded json may contain newlines. These resulted in > 2 elements in the strings.Split. This modification makes the function resilient to differences whitespace within the embedded service account.json. --- drive-by fix to error string generation We're using a formatting string, but not the `f` variant of `Sprint`. --- address linter complaint -> use fmt.Errorf

view details

push time in 2 months

pull request commentivanilves/lstags

Fix whitespace handling with gcr service accounts in mind.

Note: https://github.com/ivanilves/lstags/issues/211 suggests using this exact strategy. Folks attempting that will surely run into this caveat.

jacobstr

comment created time in 2 months

push eventjacobstr/lstags

Jacob Straszynski

commit sha b447b8f3fd2a150538685177721dd79824414730

address linter complaint -> use fmt.Errorf

view details

push time in 2 months

push eventjacobstr/lstags

Jacob Straszynski

commit sha c4b119c01f19966565e71f5c6e58810472fc078e

address linter complaint -> use fmt.Errorf

view details

push time in 2 months

PR opened ivanilves/lstags

Fix whitespace handling with gcr service accounts in mind.

At some point in time I followed the instructions here to generate a service account for gcr: https://cloud.google.com/container-registry/docs/advanced-authentication

The encoded password is actually json and the embedded ":" cause it to be split across multiple array elements. That's undesirable in this case.

This ends up getting manifest as:

FATA[0004] Bad response status: 401 Unauthorized >>

Because the config loader ends up skipping the element in https://github.com/ivanilves/lstags/blob/master/docker/config/config.go#L108

+19 -3

0 comment

4 changed files

pr created time in 2 months

push eventjacobstr/lstags

Jacob Straszynski

commit sha 6b5539e0c96c0f66e3a6dc65bf3d515e39ce2f09

drive-by fix to error string generation We're using a formatting string, but not the `f` variant of `Sprint`.

view details

push time in 2 months

create barnchjacobstr/lstags

branch : koobz/fix-gcr-sa

created branch time in 2 months

fork jacobstr/lstags

Explore Docker registries and manipulate Docker images!

fork in 2 months

push eventplanetlabs/draino

Jesse Cordeiro

commit sha 5a8c950e51bdbd4a2ed84131796b8f7e18bfe540

fix typo

view details

Jacob Straszynski

commit sha 68d76c2a6a31b595984ec216e8f8ab518867935d

Merge pull request #77 from jessecordeiro/jessecordeiro-patch-1 Fix typo in readme

view details

push time in 2 months

PR merged planetlabs/draino

Fix typo in readme

Fixes minor typo in readme

+1 -1

1 comment

1 changed file

jessecordeiro

pr closed time in 2 months

push eventplanetlabs/kostanza

Jacob Straszynski

commit sha bea9c9c33c9fc3c4bbf9b0d17c4f139183cdedf2

fix container build

view details

push time in 3 months

push eventplanetlabs/kostanza

Jacob Straszynski

commit sha bb34606f09934657a3600747dfd70d692b049a5b

update vendoring to use go modules

view details

Jacob Straszynski

commit sha 4de3f847c1bab29bafb038bf1c1e272dc77e9c3c

test + fix multi-gpu scenarios.

view details

Jacob Straszynski

commit sha 5a3ae82ff4db431d22e944190409b710a2e2163a

add tests for non-resource limited pods

view details

Jacob Straszynski

commit sha 773327fe04bd506ab0d874b4f8c7dd699961ed4d

use golangci lint and address errors

view details

Jacob Straszynski

commit sha c146ff80cc5a13e5fc689adeb417fc8518e94c0a

Merge pull request #4 from planetlabs/koobz/pricing update to golang 1.14, add tests for non-resource limited pods.

view details

push time in 3 months

PR merged planetlabs/kostanza

update to golang 1.14, add tests for non-resource limited pods.

A hodge-podge of changes to:

  • Update to go modules. My local dev environment is 1.14 now.
  • Address some large negative numbers resulting from unspecified cpu/memory limits.
  • Add tests for pods without resource limits.
  • Add test for pods with multiple gpus.
+832 -110989

1 comment

124 changed files

jacobstr

pr closed time in 3 months

push eventplanetlabs/kostanza

Jacob Straszynski

commit sha 773327fe04bd506ab0d874b4f8c7dd699961ed4d

use golangci lint and address errors

view details

push time in 3 months

push eventplanetlabs/kostanza

Jacob Straszynski

commit sha 8694dd281460e6be2447ff9003242f933088d04b

use golangci lint and address errors

view details

push time in 3 months

push eventplanetlabs/kostanza

Jacob Straszynski

commit sha c24eac8011de97291326f54477910c0b04d137fc

use golangci lint and address errors

view details

push time in 3 months

push eventplanetlabs/kostanza

Jacob Straszynski

commit sha 47744241acf95685c8cafdbebf07a80482f9ba79

golangci lint

view details

push time in 3 months

PR opened planetlabs/kostanza

update to golang 1.14, add tests for non-resource limited pods.

A hodge-podge of changes to:

  • Update to go modules. My local dev environment is 1.14 now.
  • Address some large negative numbers resulting from unspecified cpu/memory limits.
  • Add tests for pods without resource limits.
  • Add test for pods with multiple gpus.
+820 -110970

0 comment

120 changed files

pr created time in 3 months

create barnchplanetlabs/kostanza

branch : koobz/pricing

created branch time in 3 months

more