profile
viewpoint
Shubham Kumar imskr Chandigarh, India https://shubhamkumar.live A Computer Science Undergrad & Researcher

imskr/Flappy-Bird-AI 31

Artificial Intelligence based Flappy Bird Game

imskr/gatsby-starter-plasma 6

🚀 A modern and clean starter to get up and developing quickly with Gatsby

imskr/DS-and-Algorithms 4

Collection of Data Structure and Algorithms Notes & Problems!

imskr/A-to-Z-Resources-for-Students 3

:ballot_box_with_check: Curated list of resources for college students :octocat: Show your :heart: by giving a :star:

imskr/DeepSpeech 1

A TensorFlow implementation of Baidu's DeepSpeech architecture

imskr/appium 0

:iphone: Automation for iOS, Android, and Windows Apps.

imskr/awesome-first-timers 0

Place to contribute if you are a first timer

imskr/awesome-github-profile-readme 0

A curated list of awesome Github Profile READMEs

imskr/badgeyay 0

Attendee Badge Generator for Conferences http://badgeyay.com Backend: http://badgeyay-dev.herokuapp.com

push eventimskr/imskr

Shubham Kumar

commit sha 5b9127f217cf2aaecaa8ab876e86a00e98956f39

Update README.md

view details

push time in 3 days

issue commentowl4ce/dotfiles

Installation on Ubuntu

@beppevoto I fixed it. But i checked system settings click on tap is ON but still its not working only buttons click is working not the touchpad

imskr

comment created time in 7 days

startedmut-ex/minimal-functional-fox

started time in 9 days

issue openedowl4ce/dotfiles

Installation on Ubuntu

  • How to setup this on fresh Ubuntu installation
  • In ubuntu, we have DM and another server by default.
  • Please tell the steps I need to get this setup!

created time in 9 days

issue openedVaughnValle/elektropunk

Add installation steps

  • How to install and achieve this on fresh base Arch Linux or Artix?

created time in 11 days

startedxriley/DevBook-Theme

started time in 13 days

startedowl4ce/dotfiles

started time in 13 days

issue openedowl4ce/dotfiles

Installation help

  • I liked the 6th and 7th theme from your wiki page - rice journey. How to install that theme on-base arch Linux?

created time in 13 days

issue commentSwiftyChicken/dotfiles

Add installation steps

@SwiftyChicken

imskr

comment created time in 16 days

issue closedszorfein/dots

chezmoi apply error

Its demanding github username and pass while running chezmoi apply

closed time in 17 days

imskr

issue openedSwiftyChicken/dotfiles

Add installation steps

  • please add installation steps

created time in 17 days

startedminitorch/minitorch.github.io

started time in 17 days

startedSwiftyChicken/dotfiles

started time in 18 days

issue commentfacebook/docusaurus

v2: Add themeConfig.noIndex option

I can fix this! @slorber

slorber

comment created time in 19 days

issue commentszorfein/dots

chezmoi apply error

I was also trying another way given in wiki of dotfiles but stow lines -t ~ don't work throws some error

imskr

comment created time in 20 days

issue commentszorfein/dots

chezmoi apply error

I just changed the config themes=lines

Authentication failed for 'https://github.com/szorfein/lines.vim/'

imskr

comment created time in 20 days

issue openedszorfein/dots

chezmoi apply error

Its demanding github username and pass while running chezmoi apply

created time in 20 days

issue commentmozilla/fxa

Long Device name causes layout issues in “Disconnect from sync” confirmation panel

No @LZoog. @mrunalvilas you can work on this

vasilicatamas

comment created time in 20 days

startedszorfein/dotfiles

started time in 20 days

pull request commentfacebook/docusaurus

refactor(v2): clean default or fallback values

Hi @imskr . Do you want me to complete this PR and merge it?

Sorry couldn't find time. Yes, please Thank you

imskr

comment created time in 21 days

startedhoanhan101/ultimate-go

started time in 23 days

pull request commentimskr/gatsby-starter-plasma

Fixes issue #12

@piyush97 It doesn't fix the problem. I can still not see navbar items centered!

piyush97

comment created time in 24 days

startedchiphuyen/python-is-cool

started time in a month

issue commentfacebook/docusaurus

Add baseUrl to the link suggested by the dev server on start

@slorber This is open?

maksnester

comment created time in a month

push eventimskr/docusaurus

Sébastien Lorber

commit sha 9c34f68a7aa67553f0990ad3df53ba370a465cbf

fix(v2): DocSearch should keep working after a new release (#3393) * We should create an alias for searching last version of docs on DocSearch/Algolia, so that on new version publish, search still works even if new version is not already indexed (https://github.com/facebook/docusaurus/issues/3391) * commit missing snapshot * update after algolia changes * put back facetFilters: [`version:${versions[0]}`] until latest facet is indexed

view details

Sébastien Lorber

commit sha 0baf3c2e54bbce78bacbbc4f5e129db6c3dfff88

fix(v2): DocSearch should keep working after a new release (part 2/2) (#3397)

view details

Sébastien Lorber

commit sha 8af3ad42504966b63cab84dea8105c7391a72925

chore(v2): prepare v2.0.0.alpha-63 release (#3400) * add alpha 63 + remove +3month old versions * update publish guide * v2.0.0-alpha.63

view details

dependabot[bot]

commit sha e32bac88bb951b5bb3ed9c2b3c72faf013e9ab29

chore(deps): bump decompress from 4.2.0 to 4.2.1 (#3401) Bumps [decompress](https://github.com/kevva/decompress) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/kevva/decompress/releases) - [Commits](https://github.com/kevva/decompress/compare/v4.2.0...v4.2.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Sébastien Lorber

commit sha f49d8baf2f00b42b7fc688e2138af3665a42d51e

fix(v2): fix debug plugin unscoped global css affecting all code blocks (#3405) https://github.com/facebook/docusaurus/issues/3402

view details

Sébastien Lorber

commit sha 21852948ce2b19a25252c436ba3301d13926eb20

feat(v2): ability to add/override theme html metadatas (#3406) * ability to add/override theme html metadatas see https://github.com/facebook/docusaurus/issues/3024 * refactor/fix validateThemeConfig tests

view details

Sébastien Lorber

commit sha 17975950b25abe5b41b3d86fa9defab3b7a6d285

fix(v2): reset sidebar state on sidebar changes (#3418)

view details

Rutik Wankhade

commit sha 3638b1651a193821958b22b5f56407f1267dd9fc

docs(v2): minor typo fix (#3423) * docs: minor typo fix Markdown import example in website/src/pages/examples/markdownPageExample.md imports the wrong chapter. See this comment https://github.com/facebook/docusaurus/commit/f234c407f1f279a76ab388df2bab4f33e8eadf85#r42067403 ### Have you read the [ Contributing Guidelines on pull requests](https://github.com/facebook/docusaurus/blob/master/CONTRIBUTING.md#pull-requests)? (Yes) * Update website/src/pages/examples/markdownPageExample.md Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>

view details

Méril

commit sha d844ff61079ef292144229f98d911683ff7b3298

feat(v2): add an option to toggle trailing slash for urls in sitemap (#3426)

view details

Méril

commit sha 77db1443785d528179d0abea38fe71f97cf879bd

docs(v2): reference Eta's syntax in ssrTemplate section (#3425)

view details

Thad Guidry

commit sha 94527b0b625921a89760c2afeb8261844f54d582

docs(v2): fix grammar (#3428) Co-authored-by: Andrulko <andriy@crowdin.com>

view details

josephMG

commit sha d2801768064a65cd68d509fcbdf411b1d8ce360f

fix(v1): versioned_docs and skip-next-release relative path issue by adding versioned_source to metadata (#3429)

view details

Bartosz Kaszubowski

commit sha 80c9431af77da85e7f5ab3c41924a3e94ae3280a

fix(v2): fix theme-classic announcement bar closable style (#3433)

view details

Ash

commit sha 37989a00c36a6147852798f583b65a5488cc5f86

fix(v2): Correctly resolve sw.js path on windows (#3436) * fix(v2): Correctly resolve sw.js path on windows * Just fixing the icons too Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>

view details

Sébastien Lorber

commit sha 7ffe93903c13999f1954a3a6dec8c8a4302fbb95

fix(v2): fix empty link error message (#3435) * fix empty link error message * fix snapshot

view details

Sébastien Lorber

commit sha c0ce83f24344d0caccd9886095842940db7f9915

fix(v2): fix manifest to support baseUrl (#3438)

view details

Bartosz Kaszubowski

commit sha 086bee287d4f50246afbf5d09d243876b7b7df03

feat(v2): add style property to theme-classic navbar (#3432) * feat(v2): add style property to theme-classic navbar * revert config test change * review changes

view details

Sébastien Lorber

commit sha 306122e3b1781eb246efa28350b547348f23423e

chore(v2): upgrade webpack/workbox related deps to get rid of serialize-javascript 3.x security issues (#3439)

view details

Nahiyan Kamal

commit sha 8a437961f6fbbd74dc95dbb6469e11cad132b065

fix(v2): fixing typo in error message (#3441)

view details

Sébastien Lorber

commit sha 9bf4dfb2759759c14d99df6daebbacf833109d78

chore(v2): prepare v2.0.0.alpha-64 release (#3440) * add 2.0.0 alpha 64 files * v2.0.0-alpha.64

view details

push time in a month

issue commentimskr/Rusty-Skywalker

Add Chrome Extension Support

@imabp Not open for contributions yet!

imskr

comment created time in a month

PR closed mozilla/bedrock

Fixed JS error on /contact page

Description

Uncaught TypeError: can't access property "setAttribute", e is null
    <anonymous> https://www.mozilla.org/media/js/BUNDLES/contact-spaces.8c743e70c527.js:1
    <anonymous> https://www.mozilla.org/media/js/BUNDLES/contact-spaces.8c743e70c527.js:1

Issue / Bugzilla link

Fixes #9322

Testing

+0 -6

2 comments

1 changed file

imskr

pr closed time in a month

pull request commentmozilla/bedrock

Fixed JS error on /contact page

Oops wrong file pushed!!!

imskr

comment created time in a month

push eventimskr/javascript-test

Shubham Kumar

commit sha 9fbaee6f30c3b6b647727f64abce6f3d597df136

add basic layout

view details

push time in a month

create barnchimskr/javascript-test

branch : master

created branch time in a month

created repositoryimskr/javascript-test

Test demonstration

created time in a month

PR opened mozilla/bedrock

Fixed JS error on /contact page

Description

Uncaught TypeError: can't access property "setAttribute", e is null
    <anonymous> https://www.mozilla.org/media/js/BUNDLES/contact-spaces.8c743e70c527.js:1
    <anonymous> https://www.mozilla.org/media/js/BUNDLES/contact-spaces.8c743e70c527.js:1

Issue / Bugzilla link

Fixes #9322

Testing

+0 -6

0 comment

1 changed file

pr created time in a month

create barnchimskr/bedrock

branch : skr-test

created branch time in a month

issue commentmozilla/bedrock

JS error on /contact/ page

I am taking this issue!

alexgibson

comment created time in a month

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha 4eb79a161cd1cd99f064f0b3a20e5d1605634455

add some comment

view details

push time in a month

pull request commentfacebook/docusaurus

refactor(theme-classic): clean default or fallback values

@slorber Fixed it! Is it good?

imskr

comment created time in 2 months

push eventimskr/docusaurus

Shubham Kumar

commit sha ede33173fb3c369e8c59313a3ca2469ccc4879be

refactor(theme-classic): revert prism destruct

view details

push time in 2 months

push eventimskr/docusaurus

Shubham Kumar

commit sha c730dbbbfd976663774af203a69e4be5d6c77246

refactor(theme-classic): fixed react hook warning error

view details

push time in 2 months

push eventimskr/docusaurus

Shubham Kumar

commit sha f102f916c5dd62227ee33e3ba65c6460ac13cbf3

refactor(theme-classic): fix announcementbar undefined error

view details

push time in 2 months

Pull request review commentfacebook/docusaurus

refactor(theme-classic): clean default or fallback values

 import useUserPreferencesContext from '@theme/hooks/useUserPreferencesContext'; import styles from './styles.module.css';  function AnnouncementBar(): JSX.Element | null {-  const {-    siteConfig: {themeConfig: {announcementBar = {}} = {}} = {},-  } = useDocusaurusContext();+  const {announcementBar} = useDocusaurusContext().siteConfig.themeConfig;   const {content, backgroundColor, textColor, isCloseable} = announcementBar;

cool :)

imskr

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentfacebook/docusaurus

refactor(theme-classic): clean default or fallback values

 import useUserPreferencesContext from '@theme/hooks/useUserPreferencesContext'; import styles from './styles.module.css';  function AnnouncementBar(): JSX.Element | null {-  const {-    siteConfig: {themeConfig: {announcementBar = {}} = {}} = {},-  } = useDocusaurusContext();+  const {announcementBar} = useDocusaurusContext().siteConfig.themeConfig;   const {content, backgroundColor, textColor, isCloseable} = announcementBar;

Thanks. While doing it, eslint throws error React Hook "useUserPreferencesContext" is called conditionally. React Hooks must be called in the exact same order in every component render react-hooks/rules-of-hooks

imskr

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentfacebook/docusaurus

refactor(theme-classic): clean default or fallback values

 import useUserPreferencesContext from '@theme/hooks/useUserPreferencesContext'; import styles from './styles.module.css';  function AnnouncementBar(): JSX.Element | null {-  const {-    siteConfig: {themeConfig: {announcementBar = {}} = {}} = {},-  } = useDocusaurusContext();+  const {announcementBar} = useDocusaurusContext().siteConfig.themeConfig;   const {content, backgroundColor, textColor, isCloseable} = announcementBar;

what will be the right way to do this?

imskr

comment created time in 2 months

PullRequestReviewEvent

pull request commentfacebook/docusaurus

refactor(theme-classic): clean default or fallback values

@slorber tests are failing. Looks like I've done it the wrong way!

imskr

comment created time in 2 months

issue commentfacebook/docusaurus

Cleanup themes default/fallback values

@slorber I have made a PR #3394

slorber

comment created time in 2 months

PR opened facebook/docusaurus

Reviewers
refactor(theme-classic): clean default or fallback values

<!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to Docusaurus here: https://github.com/facebook/docusaurus/blob/master/CONTRIBUTING.md

Happy contributing!

-->

Motivation

  • Cleanup default/fallback values in packages/docusaurus-theme-classic.
  • Fixes #3342

Have you read the Contributing Guidelines on pull requests?

  • Yes

Test Plan

  • yarn test

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

+24 -52

0 comment

9 changed files

pr created time in 2 months

push eventimskr/docusaurus

Shubham Kumar

commit sha 09177c208749a32e47ab2118c6f0252a8d9fd46f

refactor(theme-classic): clean default or fallback values

view details

push time in 2 months

create barnchimskr/docusaurus

branch : skr-destruct

created branch time in 2 months

create barnchimskr/docusaurus

branch : skr-refact

created branch time in 2 months

push eventimskr/docusaurus

Thad Guidry

commit sha 149d82c730c73ef9cad24264abd329a660c460da

docs(v2): fix grammar on introduction page (#3369)

view details

Sébastien Lorber

commit sha d8cfabb66a3bd7dcc36b634878e2cd505edd3d26

feat(v2): docs options.onlyIncludeVersions (#3373) * docs options.onlyIncludeVersions * adapt docsVersionDropdown if we render a single version * fix bad error message * fix netlify deploy when versioning is disabled

view details

Sébastien Lorber

commit sha 1eb6e13fb70078abdb2fa379c063bcdaf0634a74

fix(v2): reject routeBasePath: '' (#3377) * routeBasePath: '' should be forbidden * routeBasePath: '' should be forbidden * commit * try to trigger cla bot

view details

Sam Ko

commit sha 2a3fe865798c6ef6ed14e67dd12e577fc7b4ae40

docs(v2): update Deploy to Vercel guide (#3344)

view details

Sébastien Lorber

commit sha a4769e3f30b52428f7df8c0f69d4e1e46eb6f209

fix(v2): alpha 62 doc fixes (#3381) * deprecated nextVersionLabel option * useActivePlugin failfast option * remove deprecated option nextVersionLabel * routeBasePath: '' should be forbidden * routeBasePath: '' should be forbidden * Docs: do not show version badge if there is only 1 version: https://github.com/facebook/docusaurus/issues/3362 * allow sidebars file to not exist: fallback to empty sidebars https://githu.com/facebook/docusaurus/issues/3366

view details

Sébastien Lorber

commit sha 5359d61d9e6aad824b8185117ed167e0aadecd3b

fix(v2): allow using classic theme/preset without the docs plugin (#3382) * deprecated nextVersionLabel option * useActivePlugin failfast option * remove deprecated option nextVersionLabel * routeBasePath: '' should be forbidden * routeBasePath: '' should be forbidden * Docs: do not show version badge if there is only 1 version: https://github.com/facebook/docusaurus/issues/3362 * allow sidebars file to not exist: fallback to empty sidebars https://githu.com/facebook/docusaurus/issues/3366 * Ability to use classic theme/preset while not using docs/pages without trouble. https://github.com/facebook/docusaurus/issues/3360 * fix netlify redirects * do not throw if useDocs do not load? * netlify deploy typo * try to fix useDocs * docs(v2): update Deploy to Vercel guide (#3344) * filter annoying useDocs conditional require warning * netlify deploy preview homepage * typo * try to trigger again CLA bot Co-authored-by: Sam Ko <sam@vercel.com>

view details

Sébastien Lorber

commit sha 0d018a88c5bccb56474b4dd0bb9cc7aaab4ad3e3

fix(v2): script tags should allow unknown values (#3385) https://github.com/facebook/docusaurus/issues/3378

view details

Bartosz Kaszubowski

commit sha e8e16a45d3323cecab0ee39957647c0def8689b2

feat(v2): add isCloseable property for theme-classic announcement bar (#3388) * feat(v2): add `isCloseable` property for announcement bar * correct styling for non-closeable announcement * fix tests

view details

Sébastien Lorber

commit sha ab3ebdad3914ed4b9d2627585464922cf75c43e1

chore(v2): pin exact dependency versions (#3386) * Attempt to pin all dependency versions exactly for https://github.com/facebook/docusaurus/issues/3371 * warn if @docusaurus package versions mismatch * fix yarn lock

view details

Sam Ko

commit sha 8f24a0a14964813e7c2f9a2117c1a1828a20dc09

docs(v1, v2): Update Deploy to Vercel guide (#3390) * Update Vercel guide for version-2.0.0-alpha.62 * Update Vercel guides for Docusaurus v1

view details

Sébastien Lorber

commit sha 9857f7b2b50aae94f54f7d70fa1170962904eba8

feat(v2): officially release @docusaurus/plugin-debug (#3392) * Add json styling to config debug * Style debug content page * Add style and collapse depth to json viewer * Add style to debug layout * Add style to metadata debug * Add style support to registry debugger * Remove default content if other instances are present * Change colors for more contrast * Add debug routes styles * Add active link style * Fix container css issues * Style registry debug page * Remove unused style modules * Add white space to style files * Add font scaling * Fix prettier errors * Add child routes to route debug * Readd default content plugin json * Add empty home page to debug * Prettier * Revert "Add empty home page to debug" This should be included in a separate PR This reverts commit 9c43c9f7fbf1c51a228a495dcc081e1ad383e51d. * Set colors to dark theme * Add plugin debug doc + minor fixes + expose global data * more debug plugin doc Co-authored-by: Drewbi <drewalexander986@gmail.com>

view details

Méril

commit sha 3ace60043b0090adec0680b8f451aef4a1ddb810

feat(v2): allow users to specify a custom ssr HTML template (#3387) * feat(v2): allow users to specify a custom ssr HTML template * docs(v2): add ssrTemplate property to docusaurus.config.js page

view details

push time in 2 months

startedpublic-apis/public-apis

started time in 2 months

issue commentOpenMined/PySyft

Fix all warnings in syft_0.3.0 documentation

Can i work on this @iamtrask?

iamtrask

comment created time in 2 months

issue commentimskr/Rusty-Skywalker

Clarify readme

@lf- This is much more than that. Right now we support only Twitter. With this you can go to any twitter account, search inside twitter etc. Soon I will be adding chrome extension and other commands such as github, mail etc.

lf-

comment created time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha b8f30dea59b7eca2e44bfd813eac5eb4eda69511

add demo gif

view details

push time in 2 months

issue openedimskr/Rusty-Skywalker

Add Chrome Extension Support

  • It's nice to have a chrome extension, that would set the settings with just one click!

created time in 2 months

push eventimskr/docusaurus

Yang Luo

commit sha 661eac4fe9e9c5dcf619e5114b9b3aa8176b3603

docs(v1): showcase user Casbin (#3326) * Add Casbin to users * Update users.js Co-authored-by: Yangshun Tay <tay.yang.shun@gmail.com>

view details

Teik Jun

commit sha 878ce3132b94ecfc112793212fff3e16cb9e6318

docs(v2): add anshul and tj to fellows team (#3333)

view details

Drew Alexander

commit sha c7daf32642829cac45204f9abec5b2b798d58655

docs(v2): add Drew to Fellows section (#3334) * Add me to Fellows section * Update team.md Co-authored-by: Yangshun Tay <tay.yang.shun@gmail.com>

view details

Yangshun Tay

commit sha d04a30cc9316cabfe4ee9a94663602e09b0e074e

docs(v2): update team profile (#3335) * docs(v2): update team profile * misc: add Sam intro

view details

Nisarag

commit sha 306d3afc0a79340999a8e8bb2568c4965611a555

adding team profile card about myself (#3336)

view details

adinaja

commit sha 8fd5375b26b26ec092f354d08bb3b90792d6a76e

fix(v1): fenced block detection (#3340)

view details

Bogdan Doroschenko

commit sha 3ccca399f17ac674cb44d3e2d5acdd70cfde5bec

test(v2): make blog posts unit test ordering determinate (#3339)

view details

Sébastien Lorber

commit sha b86806460c721cec345aacfd3d515ffe9c59835e

refactor(v2): announcement bar bad spelling + minor refactors (#3343)

view details

Sam Zhou

commit sha d299b99631276ecdafc652522d37b1c9838996c3

feat(v2): Provide docs plugin typing (#3328)

view details

Bogdan Doroschenko

commit sha a72ac91e3eb9809367d41085cc6a78def6bbda94

test(v2): add unit test for migration of config file (#3323)

view details

Shubham Kumar

commit sha 658dac7d4248db9c6d1b479d5614a958cd3941ff

docs(v2): add draft doc (#3346) * docs(v2): add draft doc * Update docs/guides-blog.md Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>

view details

Sam Zhou

commit sha bd9b6618c12fd98c86deb2ff0296c93b878791bf

feat(v2): Provide typing to most of the theme-classic components (#3348) * feat(v2): Provide typing to most of the theme-classic components * Expose type to the end users and dogfood it in v2 website

view details

Sébastien Lorber

commit sha c7fc781ce09c7899527685cad82cd925e7e7f7af

fix(v2): linking to asset or external html page -> don't use history.push() (#3347) * Rework markdown links to asset require processing + add test page * implement pathname:// protocol / escape hatch at the Link level * linking to assets: fix tests + avoid creating an useless nested paragraph * fix assets linking doc * attempt to fix windows e2e test * try to fix windows errors

view details

Vincent

commit sha 56c04c783409d0abe3e1c7fac3eac1909e39b0fd

fix(v2): Allow the alt for the logo to be empty (#3352) See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Img#Attributes > Setting this attribute to an empty string (alt="") indicates that > this image is not a key part of the content (it’s decoration or a > tracking pixel), and that non-visual browsers may omit it from > rendering. Since the logo is indeed decorative and redundant with the actual project name, an empty alt is fine.

view details

Sam Zhou

commit sha c8d6e418ff97158ecb4b12e5d82dda0871e1d59e

feat(v2): Provide type definitions for MDXPage from page plugin (#3354)

view details

Sam Zhou

commit sha 16ae3bf4628f7bf79ab1ef87f3bfaf8c1efb9fc3

fix(v2): Add missing dependencies to packages (#3355)

view details

Sam Zhou

commit sha aa9212cb45d53435d1a56107ac0b4673b825e0bf

feat(v2): Provide type definitions for remaining theme-classic components (#3356)

view details

Archit

commit sha a999928ad8064ca36feac11516a72f1caa875142

fix(v2): add https support in webpack devserver (#3311)

view details

Sébastien Lorber

commit sha 4bfc3bbbe79dc8017a02f98c54e251247c0355cf

fix(v2): fix migrate cli paths (sidebars/customcss) (#3358) * fix: Allow docusaurus-migrate to create relative paths #3239 * fix migration cli sidebars/customcss paths * fix migration cli sidebars paths Co-authored-by: PalAditya <adityapal.nghss@gmail.com>

view details

Sébastien Lorber

commit sha ae877f299051560b7e2af1c7ed41bb987e11c979

feat(v2): docs version configuration: lastVersion, version.{path,label} (#3357) * add new docs versioning options * Add some tests for new versioning options * Add some docs for version configurations * try to fix broken link detection after /docs/ root paths have been removed on deploy previews * improve dev/deploypreview versioning configurations * disable custom current version path, as it produces broken links * readVersionDocs should not be order sensitive * fix versions page according to versioning config * fix versions page according to versioning config

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha 4d7b7f0bae15c722eca2b44b4824617c120b650b

Update README.md

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha 44f7af2e538c25d8e673f5acde5538209abc28c3

add usage

view details

push time in 2 months

issue closedimskr/Rusty-Skywalker

Heroku App Crashes

  • Heroku deployment error H10

closed time in 2 months

imskr

issue commentimskr/Rusty-Skywalker

Heroku App Crashes

Fixed in latest commit, looks like it was naming error!

imskr

comment created time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha b075f89a26ae5d3a4ad24ec1fa8a666a256e49e2

fix heroku error

view details

push time in 2 months

issue openedimskr/Rusty-Skywalker

Heroku App Crashes

  • Heroku deployment error H10

created time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha ba0aca6f605cf4d19752fbbca20b00be03a00423

purge cache

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha 97a897307f9e169630adb58b1dededa9e9f81c45

purge cache

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha c8f85a68ac7ca3ffe19dbd087f2ceb46ca5c57d9

add gitattributes 🥶

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha baa97be71e97cf66f7931f9a4bd8cdbefb214f5e

add UI

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha 008e78cc387c04e4ae14f363e54fb6f1e7a48cf9

add staticFiles rocket support

view details

push time in 2 months

Pull request review commentfacebook/docusaurus

docs(v2): add draft doc

 The only required field is `title`; however, we provide options to add author in - `title` - The blog post title. - `slug` - The blog post url slug. Example: `/blog/my-test-slug`. When not specified, the blog url slug will be extracted from the file name. - `unlisted` - The post will be accessible by directly visiting the URL but will not show up in the sidebar in the final build; during local development, the post will still be listed. Useful in situations where you want to share a WIP post with others for feedback.+- `draft` - The post will not be appeared if set to `true`. Useful in situations where WIP but don't want to share the post.

Thanks for editing the change!

imskr

comment created time in 2 months

PullRequestReviewEvent

issue commentfacebook/docusaurus

Cleanup themes default/fallback values

@slorber I would like to start working on this!

slorber

comment created time in 2 months

startedfacebook/docusaurus

started time in 2 months

issue commentfacebook/docusaurus

V2: blog "draft" frontmatter

@slorber Please review the PR

slorber

comment created time in 2 months

PR opened facebook/docusaurus

docs(v2): add draft doc

<!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to Docusaurus here: https://github.com/facebook/docusaurus/blob/master/CONTRIBUTING.md

Happy contributing!

-->

Motivation

  • draft was added but not mentioned in docs.
  • Fixes #3305

Have you read the Contributing Guidelines on pull requests?

  • Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

  • Didn't change any code.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

+1 -0

0 comment

1 changed file

pr created time in 2 months

create barnchimskr/docusaurus

branch : v2-draft

created branch time in 2 months

issue commentfacebook/docusaurus

V2: blog "draft" frontmatter

@slorber Yeah sure let me check!

slorber

comment created time in 2 months

startediterative/dvc

started time in 2 months

issue commentfacebook/docusaurus

V2: blog "draft" frontmatter

@slorber Thanks since I am new here. Just to confirm, I have to make changes here right?

slorber

comment created time in 2 months

push eventimskr/fxa

Staś Małolepszy

commit sha bc5bd56cbc6cf0279ed9a9fd52d2dd5b4f3611bb

chore(payments): upgrade to @fluent/react 0.12.0

view details

Ryan Kelly

commit sha 12cbb8caa3e30c602e37f5ef0ac175e0b24588d5

fix(validation): Allow unicode replacement character in display-safe strings. Because: * Some clients (notably Firefox Desktop) will attempt to build a default device name out of system-provided data, and if they encounter unicode encoding issues then they'll insert the unicode replacment character rather than failing. * Such clients cannot complete FxA device registration, because we forbid the device name from containing any characters in the unicode specials block. * There is not a concrete risk associated with characters from the specials block, we just exclude them because they might have unexpected effects (and particularly because some of them are currently unassigned). This commit: * Allows the unicode replacement character U+FFFD (otherwise known as "that diamond thingy with a question mark in it") in the display-safe string validator.

view details

Wil Clouser

commit sha c81c76d15e48a9066d24aec118979fc3ade14865

fix(release): fixes versioning and changelogs Because: * The release script makes some wrong assumptions about the format of data This commit: * Fixes the changelog updates to work with empty/new changelogs * Updates version numbers to the latest versions Fixes #6195

view details

Danny Coates

commit sha da2e99729c31909a4a889a02fe30d8359d5ece05

chore(deps): update yarn version and root level deps

view details

Danny Coates

commit sha e3b42e7fa343f04b2313f8bd52c58e59e5c27cbb

Merge pull request #6279 from mozilla/update-root-deps chore(deps): update yarn version and root level deps

view details

Les Orchard

commit sha 367f39d9d45ceb9a2c37b3d936b25bc328bc6360

fix(payments): use default payment details in reactivation email This switches from displaying the payment details used in the last charge to displaying default payment details which will be used in the next invoice. fixes #6172

view details

Jody Heavener

commit sha c1d280084a301d99eb18992d14505d07b6f7f4c4

chore(settings): add md syntax highlighting to docs

view details

Les Orchard

commit sha d35996579a4641297fc6ae1f7d5c7533432e7132

Merge pull request #6277 from mozilla/6172-incorrect-card-details-on-reactivation fix(payments): use default payment details in reactivation email

view details

Jody Heavener

commit sha d637bb4893cbebd1150a704e980fb15cfa614075

feat(settings): introduce hook to handle errors in mutations

view details

Jody Heavener

commit sha 24de4f70592c4cab2b387507398b3c8c632954aa

Merge pull request #6283 from mozilla/jh/settings-updates

view details

Vijay Budhram

commit sha 18395c17c28adb03ad2dfa0d1126e0d86384578a

fix(totp): Don't reuse existing sessions for oauth webchannel clients

view details

Barry Chen

commit sha 035c09ca9fdf970f6b65387c6ef659dd99ba3f18

Merge pull request #6152 from chenba/pr/stasm/6096 chore(payments): upgrade to @fluent/react 0.12.0

view details

Staś Małolepszy

commit sha e6083822cebccf5bdce380b334d70d3491bed8af

chore(payments): upgrade @fluent/bundle to 0.16, @fluent/react to 0.13, @fluent/langneg to 0.5

view details

Ryan Kelly

commit sha 1d8e3c913b6da4d474629ad89c906e41d1e84807

Merge pull request #6270 from mozilla/allow-replacement-character-in-display-safe-strings fix(validation): Allow unicode replacement character in display-safe strings

view details

Danny Coates

commit sha bb8791b95dd02474127ace60d74e1fdd98cb3958

feat(gql): added destroySession mutation fixes #6286 Add the destroySession mutation to log out of the current session

view details

Danny Coates

commit sha eb1a3f4a53f932343165a913a79a810cfd641c1e

Merge pull request #6293 from mozilla/issues/6286 feat(gql): added destroySession mutation

view details

Vijay Budhram

commit sha 9bada420a4f9eb127b9fb982442965df79984bc5

Merge pull request #6288 from mozilla/fxa-2427, r=@dannycoates ## Because - We should always try to prompt the user for 2FA if it is enabled on the account ## This pull request - For oauth webchannel clients (now FxiOS and Fenix) we shouldn't allow them to reuse a sessionToken which could lead to edge cases like these ## Issue that this pull request solves Closes: #6208

view details

Wil Clouser

commit sha f16ae922da23413f65e615d71c8d9cdb6d7e7e1a

Merge pull request #6278 from clouserw/6195 fix(release): fixes versioning and changelogs

view details

Barry Chen

commit sha 7978f632f470cc00c4a5344502366498bfc07bec

Merge pull request #6291 from chenba/pr/stasm/6098 chore(payments): upgrade @fluent/bundle to 0.16, @fluent/react to 0.1…

view details

push time in 2 months

startedmdx-js/mdx

started time in 2 months

startedrough-stuff/rough-notation

started time in 2 months

push eventimskr/fxa

Shubham Kumar

commit sha 9e81f9e05f0945b559265e56ea808e807c1dcc4c

feat(fido-2): Add client libs and register and login endpoints😎

view details

push time in 2 months

push eventimskr/fxa

Shubham Kumar

commit sha 335933195dd574b0c58f6bae634e52a0e6572803

feat(fido-2): Add client libs and register and login endpoints😎

view details

push time in 2 months

push eventimskr/fxa

Shubham Kumar

commit sha af269aef0709cb0757cd3655da84dc8ad0b7710c

feat(fido-2): add login endpoints

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha 884db5759ac1ecc67d02aec0f201d0e12e41dd47

add install steps

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha c574f0182d806f202bf99c171c53b29829d7d689

add heroku support config 💡

view details

push time in 2 months

push eventimskr/imskr

Adrian Wloszynski

commit sha 7640cd9a736b83de796be705fc03fbdc5ec0c14f

Correcting a typo ;)

view details

Shubham Kumar

commit sha d367de7d99c1d9a2661724916ee2fc9bb4d4d827

Merge pull request #1 from wloszynski/patch-1 Correcting a typo ;)

view details

push time in 2 months

PR merged imskr/imskr

Correcting a typo ;)
+1 -1

1 comment

1 changed file

wloszynski

pr closed time in 2 months

pull request commentimskr/imskr

Correcting a typo ;)

Hey, Thanks ;)

wloszynski

comment created time in 2 months

push eventimskr/fxa

Shubham Kumar

commit sha 31ae5ebaa0cdfb8c81008169faef493a61593261

feat(fido-2): Add client libs and fido-register😎

view details

push time in 2 months

push eventimskr/fxa

Shubham Kumar

commit sha 65b31ae708e2935db806a07b847f32509105f727

fix(fido-2): fix failing test

view details

push time in 2 months

push eventimskr/fxa

Shubham Kumar

commit sha 460544535743e30ebd1b1025c185f4169fe03bb7

fix(fido-2): fix failing test

view details

push time in 2 months

push eventimskr/fxa

Shubham Kumar

commit sha f97c82763baa04e538eb243dff6ef5af244670da

feat(fido-2): Add client libs and fido-register😎

view details

push time in 2 months

push eventimskr/fxa

Shubham Kumar

commit sha 3ef65333abcf545b1ae70f1e2420c53d0cd67b9f

feat(fido-2): success registration process😎

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha d27356cfde27efdd533821c22c30ed9a81097396

add prerequisites doc

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha e2dbe224ee1a065f188d7698ba4eebc3ee7b3f9b

update doc readme 😎

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha 8f58702de88cc6af61d26e0789c16e45faacabd8

Update README.md

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha f3a5ad2279feaf53eb70308443fef5b22e26daba

Update README.md

view details

push time in 2 months

push eventimskr/Rusty-Skywalker

Shubham Kumar

commit sha 66aa006879a6fcfb6ce17aa147063f6f30db4fa8

Update README.md

view details

push time in 2 months

more