profile
viewpoint
Ilan Ben Tal ilandbt Harish, Israel

push eventilandbt/SlackTest

Ilan Ben Tal

commit sha 93604f1dad89c33d4a00070586834d4be48a31ff

Update README.md

view details

push time in 2 months

create barnchilandbt/SlackTest

branch : master

created branch time in 2 months

created repositoryilandbt/SlackTest

created time in 2 months

created repositoryilandbt/IlanSlackTest

created time in 2 months

issue commentdelight-im/Android-AdvancedWebView

Why does the WebView call resumeTimers/pauseTimers ?

Thanks for the fast response. My issue with this is that you change a global state with a specific instance.

I'n my case i have a fragment with AdvancedWebViewthat can open a new Fragment with the native WebView. So the Native WebViewstops working in this scenario.

As you added from the official documentation - This can be useful if the application has been paused.

I would call pauseTimers() only in this scenario. not when the fragment is paused.

I think the removal of these functions should be investigated but for now i think a disable function is a good idea.

Thanks again

ilandbt

comment created time in 2 months

issue openeddelight-im/Android-AdvancedWebView

Why does the WebView call resumeTimers/pauseTimers ?

Hey, Hey why do you call resumeTimers /pauseTimers in onResume/onPause ? These functions affect all WebViews in the app.

You can see In onPause comment. https://android.googlesource.com/platform/frameworks/base/+/a5408e6/core/java/android/webkit/WebView.java#1140

That calling webView.onPause.

This affects all webViews that don't call these functions.

Thanks

created time in 2 months

more