profile
viewpoint

hyangah/mgodoc 10

Godoc on Mobile Device (android/ios)

hyangah/bugs 0

core dump for various bug debugging (nothing interesting)

hyangah/catapult 0

Catapult

hyangah/cobra 0

A Commander for modern Go CLI interactions

hyangah/delve 0

Delve is a debugger for the Go programming language.

hyangah/demangle 0

C++ symbol name demangler written in Go

hyangah/ESPClock 0

ESP8266-based touchscreen clock and light controller with WiFi

hyangah/expdev 0

dev branch experiment

issue commentgolang/vscode-go

tree-kill: spawns too many pgrep processes, causing the extension to become unresponsive

@stamblerre great finding. I looked into the tree-kill code and definitely there is a race condition.

But not only that, I also observed the default /usr/bin/pgrep (I've been using) and the pgrep from proctools behave differently inside vscode. In particular, pgrep -P from proctools does not behave as expected but returns all processes.

(base) ~/projects/vscode-go$ $HOMEBREW/bin/pgrep -P 21385 | wc -l
     444
(base) ~/projects/vscode-go$ /usr/bin/pgrep -P 21385 | wc -l
       3
(base) ~/projects/vscode-go$ $HOMEBREW/bin/pgrep -P 21385 | wc -l
     444

tree-kill builds a process tree by invoking pgrep recursively. This incorrect results can easily cause many pgrep calls (but failing to construct the right tree to kill).

I can't say all the pgrep issues users were reporting were due to this, but definitely, this can be one of them.

@butuzov are you using pgrep from proctools by any chance? If so, do you still see the same issue if you uninstall proctools or teach the vscode to prefer /usr/bin/pgrep?

butuzov

comment created time in an hour

issue commentgolang/go

x/tools/gopls: does not support go <= 1.12

In an ideal world, it would be nice if everyone moves timely to the new thing. But in practice, we know some platform couldn't get rid of 1.9 until recently. Google's Appengine doc is still listing go1.12 https://cloud.google.com/appengine/docs/standard/go/runtime.

And, some users may want to test their software with different versions of Go to check regression or run comparison, and I believe that is a valid use case.

bvwells

comment created time in 10 hours

issue commentgolang/vscode-go

Extensions

About what each tool is doing: https://github.com/golang/vscode-go/blob/master/docs/tools.md

We need better documentation and improve the installation process.

About formatting: formatting can be disabled with "editors.formatOnSave", for example,

"[go]": {
   "editors.formatOnSave": false
}

But, go has its own formatting rule from the very beginning of the language, and the formatting tool is an essential part of the Go code writing that helps keeping the code style consistent among Go developers. Skipping formatting and applying different formatting rules is not recommended in general.

If you use gopls, many of them are unnecessary, and the extension shouldn't suggest installation of those tools - please update https://github.com/golang/vscode-go/issues/51 if you find any questionable tools that were recommended when using gopls.

Kur-Ich

comment created time in 12 hours

issue commentmicrosoft/vscode-go

Please change Go file icon

@inliquid the screenshot uses three colors and high resolution. In low resolution, single color the eyes get smudged and doesn't look like a gopher.

AlekSi

comment created time in 13 hours

issue commentgolang/vscode-go

Debugger should try to run the main package instead of failing.

@00sivan I am not worried about the go compiler. I am worried whether the main package with the open window is really the right one to run. We can't make any assumption about users workflow or authoring pattern in this case.

It's not uncommon to have multiple windows for different main packages open. It's not uncommon to have an unrelated main package open for edit, while editing a different package. Accidentally leaving an unrelated main package source code open can start debugging with that implicitly chosen main package, and I fear that will confuse users.

Since launch.json already allows that kind of customization and provides more flexibility (you can pass parameters and data files) and ability to share with team members, I am not sure if we need this feature.

cc/ @quoctruong @ramya-rao-a

00sivan

comment created time in 13 hours

issue commentmicrosoft/vscode-go

Please change Go file icon

@inliquid sadly it didn't work as nicely as we hoped with the seti-ui color constraints and the icon size, especially in a low resolution. :-( And, that's a new variation of gopher, so I am afraid people with different taste will still have different opinions. https://storage.googleapis.com/golang-assets/Go-brand-book-v1.9.5.pdf

AlekSi

comment created time in 14 hours

issue commentmicrosoft/vscode

[themes] update seti-ui icons

@misolori thanks! While testing your PR, can you also please check the icon for go.mod file? There shouldn't be no icon assigned to it. Otherwise, that's a regression and I am happy to file an issue.

hyangah

comment created time in 14 hours

issue commentmicrosoft/vscode-go

Please change Go file icon

I filed https://github.com/microsoft/vscode/issues/98586

@inliquid, the icon change is not what we intended as I described in my PR to seti-ui and also in the newly created issue.

All of us love the gopher mascot. If anyone finds a way to create a gopher icon that holds its original cuteness and beauty, please send the PR.

AlekSi

comment created time in 16 hours

issue openedmicrosoft/vscode

[themes] update seti-ui icons

seti-ui accepted a couple of update PRs recently. Can you please sync extensions/theme-seti/icons?

Meanwhile, I noticed that go.mod file was falsely classified as xml type file. https://github.com/jesseweed/seti-ui/pull/568#issuecomment-633533831 I am not sure if that's a real issue in the latest vscode release candidate, or just a non-reproducible problem caused by some peculiarity in my vscode dev env. Can you please take a look?

@orta @ramya-rao-a @inliquid

created time in 16 hours

issue commentgolang/vscode-go

Rename failed: gorename: package xxx is not in GOROOT

You are using Go in modules mode (based on set GOMOD=D:\go_workspace\src\pink-api\go.mod). I don't think gorename, the underlying tool used in this case, supports module mode. https://github.com/golang/go/issues/24661

For modules mode, we recommend gopls instead

"go.useLanguageServer": true

taobaohi

comment created time in 17 hours

issue commentgolang/vscode-go

Debugger should try to run the main package instead of failing.

@00sivan Thanks for the feature request.

If launching a specific program in different location needs to be done frequently, isn't it possible to configure a custom launch.json to point to the program? https://code.visualstudio.com/docs/editor/debugging#_launch-configurations

If you commit launch.json, it will help other project members sharing the workflow, instead depending on the ad-hoc way of finding a main package to run.

And, if multiple main packages or unrelated main package files are open, I am afraid this implicit target choice can lead confusion.

00sivan

comment created time in 17 hours

pull request commentjesseweed/seti-ui

use Go brand logo for .go files

Thanks @orta. I confirm the change of .mod file icon isn't caused by this PR.

From the dev instance built from vscode head, I see go.mod still uses the xml language icon. image

I don't know what caused vscode to believe go.mod to be a xml file. If it happens in the released version of vscode, we need to report this to vscode.

hyangah

comment created time in 2 days

issue commentgolang/go

cmd/pprof: use netrc for user/password authentication

@bcmills what do you think about moving cmd/go/internal/auth to somewhere so cmd/pprof can reuse?

prashantv

comment created time in 3 days

issue commentgolang/vscode-go

Invalid auto-completion result for pointer type fields

Thanks for sharing the info, @wtask I filed https://github.com/golang/go/issues/39227. Let's see what others think about it.

wtask

comment created time in 3 days

issue openedgolang/go

x/tools/gopls: consider using &S form instead of *S for pointer type struct field autocompletion.

Currently autocompletion for a struct field uses the field's type as the placeholder text. For example,

type F struct {...}
type S {
   Field *F
}

The autocompletion for the Field will return "newText":"Field: ${1:*F},". gopls uses the type info for placeholder text, so I don't think the choice is incorrect nor invalid.

But if the suggestion used &F instead, it would be more convenient when users want to use composite literals. Especially, if the type name is long to type, reusing what's already in the placeholder will save many keystrokes.

(Based on https://github.com/golang/vscode-go/issues/85)

created time in 3 days

issue commentgolang/vscode-go

repository management: determine prefixes for issues and changelists

We need extra rules for issues.

Issues for bugs can use the same rule (culprit module name) if the source of the problem is obvious. Users may not know the actual implementation, so maintainers need to identify them if possible.

But for issues that involve upstreams (go, gopls, vscode, dlv, ...), the choice is not obvious. Maybe just use the upstream name in that case.

New feature requests may not fall into any of the existing modules. For them, 'proposal' or 'feature request'? (I think proposal is a more concrete form of feature request that may include discussion of design and implementation though).

stamblerre

comment created time in 4 days

issue closedgolang/vscode-go

testing: Go Extension Tests With Gopls/Completion middleware testing is failing

https://github.com/golang/vscode-go/pull/44/checks?check_run_id=693415725 and other CI runs. (currently we are ignoring the test failures from this gopls integration tests because they are flaky)

1 failing
  1) Go Extension Tests With Gopls
       Completion middleware:
     Error: Timeout of 1000000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/vscode-go/vscode-go/out/test/gopls/extension.test.js)
  	at listOnTimeout (internal/timers.js:531:17)
  	at processTimers (internal/timers.js:475:7)

cc/ @stamblerre

closed time in 4 days

hyangah

issue commentgolang/vscode-go

testing: Go Extension Tests With Gopls/Completion middleware testing is failing

I don't see any more similar failure after cl/234719. Closing now.

hyangah

comment created time in 4 days

issue commentgolang/vscode-go

Invalid auto-completion result for pointer type fields

@wtask Thanks for the bug report. Can you please share the go extension related settings?

From Command Palette -> Preferences: Open Settings (JSON), and share any settings that start with go, [go], gopls prefixes. (If you use workspace-setting, do the same for Preferences: Open Workspace Settings (JSON) too.)

wtask

comment created time in 4 days

pull request commentgolang/vscode-go

src: support running an individual subtest

Thanks for the PR @seancaffery. Please follow the instruction in the googlebot's comment and complete the cla signing. There is the step for corp signers too.

seancaffery

comment created time in 4 days

PR opened jesseweed/seti-ui

use Go brand logo for .go files

The only change I manually made is to replace icon/go2.svg with a new svg file. Changes to all other files were automatically done by gulp icon.

Before: Screen Shot 2020-05-22 at 7 46 01 PM

After: Screen Shot 2020-05-22 at 7 36 54 PM

Light color mode: Screen Shot 2020-05-22 at 7 36 05 PM

Note: gulp svg and gulp icon resulted in minimizing the existing babel.svg and prolog.svg. That is not what this PR intended, but I don't know how to avoid affecting these files.

Note: From the screenshot, I noticed the vs code now uses xml.svg for go.mod files and I don't know what caused this change.

Fixes #499 Fixes microsoft/vscode-go#1982

+6 -17

0 comment

8 changed files

pr created time in 4 days

push eventhyangah/seti-ui

Hana (Hyang-Ah) Kim

commit sha c44a2aec9a52cddfc9a19f44470443a8297b092a

use go logo for .go files Fixes jesseweed/seti-ui#499 Fixes microsoft/vscode-go#1982

view details

Hana (Hyang-Ah) Kim

commit sha a1f0842a5b09775bec1082596c82e95393c786f3

run gulp svg; gulp icon

view details

push time in 4 days

fork hyangah/seti-ui

A subtle dark colored UI theme for Atom.

fork in 4 days

issue commentmicrosoft/vscode-go

Please change Go file icon

  1. See the previous update You can still find gophers when you create files for the go present/blog tools.
  2. Any better icon you have in mind?

I am thinking to tone down go.mod and go.sum using light grey color instead. They are not meant to be edited, so less attention is better.

AlekSi

comment created time in 5 days

issue commentmicrosoft/vscode-go

Please change Go file icon

right, go2.svg is the file used for .go. go.svg is still in use for .article and .slide files that are meant for the go present and blog files and I will leave them untouched this time. :-)

Not finalized, but what do you think about this?

image

AlekSi

comment created time in 5 days

issue commentmicrosoft/vscode-go

When debugging with "go.toolsEnvVars" that are incompatible with host machine, the failure message is opaque

Was told dlv@master already has more sensible error message. not an executable file. Is the error message more helpful?

Or do you want to have more specific error messages mentioning the misleading Go env vars?

firelizzard18

comment created time in 5 days

issue commentgo-delve/delve

helpful error message when the debuggee is incompatible with the host OS/arch

Yes, it works! Thanks! When will be the new version release? We were with v1.4.0 quite some time.

hyangah

comment created time in 5 days

issue commentgolang/vscode-go

repository management: determine prefixes for issues and changelists

For changes to files in src, using the file level (module) is an option already. (e.g. src/goCover, src/goLanguageServer) Some of the utility modules and small files may be merged or need to be refactored.

Then, all, docs, build, test/gopls, test/integration',syntaxes,snippets`, ...

An alternative is the approach like https://www.conventionalcommits.org/en/v1.0.0/ , which allows variations of tools like https://github.com/googleapis/release-please that help automating part of the frequent release process. OTOH, we may use relnote for release note generation instead. In that case, the info can be done through RELNOTE tags in the gerrit cl review comment https://github.com/golang/go/wiki/CodeReview#cl-directives

stamblerre

comment created time in 6 days

issue commentmicrosoft/vscode-go

When debugging with "go.toolsEnvVars" that are incompatible with host machine, the failure message is opaque

If the feature request is not accepted I think we can still compare GOHOSTARCH/GOHOSTOS and GOARCH/GOOS values from go env output and reject early before launching. But I am not sure if there are any advanced use cases where such simple environment checks can't capture or cause false positives. (e.g. using alternateTools to shell out dlv magically)

firelizzard18

comment created time in 6 days

issue openedgo-delve/delve

helpful error message when the debuggee is incompatible with the host OS/arch

This is a feature request (based on https://github.com/microsoft/vscode-go/issues/2696.

If the program to debug is not executable on the current GOHOSTOS/GOHOSTARCH so dlv cannot launch, I'd like to see more helpful message than the current message.

  1. What version of Delve are you using (dlv version)? 1.4.0

  2. What version of Go are you using? (go version)? go1.14.x

  3. What operating system and processor architecture are you using? darwin/amd64

  4. What did you do? Basically, GOOS=linux dlv debug on mac OS. Accidentally cross-compiled. :-) Similar issue when dlv exec when the target binary isn't executable.

  5. What did you expect to see? An error message indicating the target binary is not executable. For example, go run command outputs exec format error. Attempt to run such incompatible binaries directly outputs cannot execute binary file.

  6. What did you see instead? could not launch process: stub exited while waiting for connection: exit status 0 which is vague. Or, is this (incompatible or corrupted executable) the only case dlv would fail to launch the process with the error message? (If so, maybe rephrase the error message?)

created time in 6 days

push eventhyangah/vscode-go

Hana (Hyang-Ah) Kim

commit sha 76e8bda73f5c74171ef51051be42e7c55dec98fd

test/gopls: enable gopls using settings.json instead of vscode extension API Config update notification delivery is unpredictable and causes spurious language server restarts. Use the workspace vscode settings.json file so the vscode instance for testing can pick up the necessary config as soon as it's activated. Updates golang/vscode-go#79. Change-Id: I0c05a415b0773ddfa75ba3cd9c328a4a3a75188c

view details

push time in 6 days

PR opened golang/vscode-go

test/gopls: use settings.json instead of vscode extension API

Config update notification delivery is unpredictable and causes spurious language server restarts.

Use the workspace vscode settings.json file so the vscode instance for testing can pick up the necessary config as soon as it's activated.

Updates golang/vscode-go#79.

Change-Id: I0c05a415b0773ddfa75ba3cd9c328a4a3a75188c

+15 -9

0 comment

4 changed files

pr created time in 6 days

create barnchhyangah/vscode-go

branch : attempt

created branch time in 6 days

issue commentgolang/vscode-go

testing: Go Extension Tests With Gopls/Completion middleware testing is failing

I will add a .vscode/settings.json file under the test workspace instead of relying on vscode.workspace.getConfiguration. Looks like we are often getting multiple configuration update notifications. Whenever that happens, we stop the language server. I hope starting the test host with the file improves stability.

hyangah

comment created time in 6 days

issue commentgolang/vscode-go

testing: Go Extension Tests With Gopls/Completion middleware testing is failing

I got a very strange gopls trace when the test timed out. It indicates gopls is killing the current session, maybe to restart (possibly delayed configuration change notification). And, not sure why that tough causes the test to hang yet.

<details>

[Trace - 20:13:34.434 PM] Sending request 'initialize - (0)'.
Params: {"processId":92449,"clientInfo":{"name":"vscode","version":"1.45.1"},"rootPath":"/Users/hakim/projects/google/vscode-go/test/gopls/testfixtures/src/workspace","rootUri":"file:///Users/hakim/projects/google/vscode-go/test/gopls/testfixtures/src/workspace","capabilities":{"workspace":{"applyEdit":true,"workspaceEdit":{"documentChanges":true,"resourceOperations":["create","rename","delete"],"failureHandling":"textOnlyTransactional"},"didChangeConfiguration":{"dynamicRegistration":true},"didChangeWatchedFiles":{"dynamicRegistration":true},"symbol":{"dynamicRegistration":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]}},"executeCommand":{"dynamicRegistration":true},"configuration":true,"workspaceFolders":true},"textDocument":{"publishDiagnostics":{"relatedInformation":true,"versionSupport":false,"tagSupport":{"valueSet":[1,2]}},"synchronization":{"dynamicRegistration":true,"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"dynamicRegistration":true,"contextSupport":true,"completionItem":{"snippetSupport":true,"commitCharactersSupport":true,"documentationFormat":["markdown","plaintext"],"deprecatedSupport":true,"preselectSupport":true,"tagSupport":{"valueSet":[1]}},"completionItemKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25]}},"hover":{"dynamicRegistration":true,"contentFormat":["markdown","plaintext"]},"signatureHelp":{"dynamicRegistration":true,"signatureInformation":{"documentationFormat":["markdown","plaintext"],"parameterInformation":{"labelOffsetSupport":true}},"contextSupport":true},"definition":{"dynamicRegistration":true,"linkSupport":true},"references":{"dynamicRegistration":true},"documentHighlight":{"dynamicRegistration":true},"documentSymbol":{"dynamicRegistration":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]},"hierarchicalDocumentSymbolSupport":true},"codeAction":{"dynamicRegistration":true,"isPreferredSupport":true,"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}}},"codeLens":{"dynamicRegistration":true},"formatting":{"dynamicRegistration":true},"rangeFormatting":{"dynamicRegistration":true},"onTypeFormatting":{"dynamicRegistration":true},"rename":{"dynamicRegistration":true,"prepareSupport":true},"documentLink":{"dynamicRegistration":true,"tooltipSupport":true},"typeDefinition":{"dynamicRegistration":true,"linkSupport":true},"implementation":{"dynamicRegistration":true,"linkSupport":true},"colorProvider":{"dynamicRegistration":true},"foldingRange":{"dynamicRegistration":true,"rangeLimit":5000,"lineFoldingOnly":true},"declaration":{"dynamicRegistration":true,"linkSupport":true},"selectionRange":{"dynamicRegistration":true}},"window":{"workDoneProgress":true}},"initializationOptions":{},"trace":"off","workspaceFolders":[{"uri":"file:///Users/hakim/projects/google/vscode-go/test/gopls/testfixtures/src/workspace","name":"workspace"}]}


[Trace - 20:13:34.464 PM] Received response 'initialize - (0)' in 30ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["quickfix","source.fixAll","source.organizeImports"]},"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"documentOnTypeFormattingProvider":{"firstTriggerCharacter":""},"renameProvider":{"prepareProvider":true},"foldingRangeProvider":true,"executeCommandProvider":{"commands":["tidy","upgrade.dependency","generate"]},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"Build info\n----------\ngolang.org/x/tools/gopls 0.4.1\n    golang.org/x/tools/gopls@v0.4.1 h1:0e3BPxGV4B3cd0zdMuccwW72SgmHp92lAjOyxX/ScAw=\n    github.com/BurntSushi/toml@v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=\n    github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=\n    golang.org/x/mod@v0.2.0 h1:KU7oHjnv3XNWfa5COkzUifxZmxp1TyI7ImMXqFxLwvQ=\n    golang.org/x/sync@v0.0.0-20190911185100-cd5d95a43a6e h1:vcxGaoTs7kV8m5Np9uUNQin4BrLOthgV7252N8V+FwY=\n    golang.org/x/tools@v0.0.0-20200513154647-78b527d18275 h1:e7nYe9s94RHunFJ7b+mmPxiQMOKMVSqYASToWb1EcHs=\n    golang.org/x/xerrors@v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=\n    honnef.co/go/tools@v0.0.1-2020.1.3 h1:sXmLre5bzIR6ypkjXCDI3jHPssRhc8KD/Ome589sc3U=\n    mvdan.cc/xurls/v2@v2.1.0 h1:KaMb5GLhlcSX+e+qhbRJODnUUBvlw01jt4yrjFIHAuA=\n\nGo info\n-------\ngo version go1.14.1 darwin/amd64\n\n"}}
[Trace - 20:13:34.490 PM] Sending notification 'initialized'.
Params: {}


[Trace - 20:13:34.491 PM] Received request 'client/registerCapability - (1)'.
Params: {"registrations":[{"id":"workspace/didChangeConfiguration","method":"workspace/didChangeConfiguration"},{"id":"workspace/didChangeWorkspaceFolders","method":"workspace/didChangeWorkspaceFolders"},{"id":"workspace/didChangeWatchedFiles","method":"workspace/didChangeWatchedFiles","registerOptions":{"watchers":[{"globPattern":"**/*.go","kind":7}]}}]}
[Trace - 20:13:34.498 PM] Sending response 'client/registerCapability - (1)' in 7ms.
Result:
[Trace - 20:13:34.519 PM] Received request 'workspace/configuration - (2)'.
Params: {"items":[{"scopeUri":"file:///Users/hakim/projects/google/vscode-go/test/gopls/testfixtures/src/workspace","section":"gopls"},{"scopeUri":"file:///Users/hakim/projects/google/vscode-go/test/gopls/testfixtures/src/workspace","section":"gopls-workspace"}]}


[Trace - 20:13:34.519 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/05/20 20:13:34 Build info\n----------\ngolang.org/x/tools/gopls 0.4.1\n    golang.org/x/tools/gopls@v0.4.1 h1:0e3BPxGV4B3cd0zdMuccwW72SgmHp92lAjOyxX/ScAw=\n    github.com/BurntSushi/toml@v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=\n    github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=\n    golang.org/x/mod@v0.2.0 h1:KU7oHjnv3XNWfa5COkzUifxZmxp1TyI7ImMXqFxLwvQ=\n    golang.org/x/sync@v0.0.0-20190911185100-cd5d95a43a6e h1:vcxGaoTs7kV8m5Np9uUNQin4BrLOthgV7252N8V+FwY=\n    golang.org/x/tools@v0.0.0-20200513154647-78b527d18275 h1:e7nYe9s94RHunFJ7b+mmPxiQMOKMVSqYASToWb1EcHs=\n    golang.org/x/xerrors@v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=\n    honnef.co/go/tools@v0.0.1-2020.1.3 h1:sXmLre5bzIR6ypkjXCDI3jHPssRhc8KD/Ome589sc3U=\n    mvdan.cc/xurls/v2@v2.1.0 h1:KaMb5GLhlcSX+e+qhbRJODnUUBvlw01jt4yrjFIHAuA=\n\nGo info\n-------\ngo version go1.14.1 darwin/amd64\n\n\n"}


[Trace - 20:13:34.575 PM] Sending notification '$/setTraceNotification'.
Params: {"value":"off"}


[Trace - 20:13:34.583 PM] Sending request 'shutdown - (1)'.
Params:
[Trace - 20:13:34.598 PM] Sending response 'workspace/configuration - (2)' in 79ms.
Result: [null,null]
[Info  - 8:13:34 PM] 2020/05/20 20:13:34 Build info
----------
golang.org/x/tools/gopls 0.4.1
    golang.org/x/tools/gopls@v0.4.1 h1:0e3BPxGV4B3cd0zdMuccwW72SgmHp92lAjOyxX/ScAw=
    github.com/BurntSushi/toml@v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
    github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
    golang.org/x/mod@v0.2.0 h1:KU7oHjnv3XNWfa5COkzUifxZmxp1TyI7ImMXqFxLwvQ=
    golang.org/x/sync@v0.0.0-20190911185100-cd5d95a43a6e h1:vcxGaoTs7kV8m5Np9uUNQin4BrLOthgV7252N8V+FwY=
    golang.org/x/tools@v0.0.0-20200513154647-78b527d18275 h1:e7nYe9s94RHunFJ7b+mmPxiQMOKMVSqYASToWb1EcHs=
    golang.org/x/xerrors@v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
    honnef.co/go/tools@v0.0.1-
2020.1.3 h1:sXmLre5bzIR6ypkjXCDI3jHPssRhc8KD/Ome589sc3U=
    mvdan.cc/xurls/v2@v2.1.0 h1:KaMb5GLhlcSX+e+qhbRJODnUUBvlw01jt4yrjFIHAuA=

Go info
-------
go version go1.14.1 darwin/amd64

</details>

hyangah

comment created time in 6 days

issue commentgolang/vscode-go

testing: Go Extension Tests With Gopls/Completion middleware testing is failing

Seems like the cl isn't fixing the issue yet. https://github.com/golang/vscode-go/pull/77/checks?check_run_id=691620781

hyangah

comment created time in 6 days

issue commentgolang/vscode-go

testing: Go Extension Tests With Gopls/Completion middleware testing is failing

Will take a look - It seems like this is the main reason of the recent test time increase, and test failures in GCB. Test time increase: https://github.com/golang/vscode-go/actions?query=branch%3Amaster

hyangah

comment created time in 6 days

push eventhyangah/vscode-go

Hana (Hyang-Ah) Kim

commit sha f6bc80201bac88c7e68849ac8d8448ef36df5f56

images/goIcon.png: delete unused gopher image And ignore .github directory from vscode packaging. Change-Id: If3acde40ba4e46ec1dd398e147c01bdfb32cb33d

view details

push time in 6 days

PR opened golang/vscode-go

images/goIcon.png: delete unused gopher image

We are using the go logo. Also, skip .github directory from vsce packaging.

Change-Id: If3acde40ba4e46ec1dd398e147c01bdfb32cb33d

+3 -2

0 comment

3 changed files

pr created time in 6 days

create barnchhyangah/vscode-go

branch : byepotato

created branch time in 6 days

issue openedgolang/vscode-go

testing: Go Extension Tests With Gopls/Completion middleware testing is failing

https://github.com/golang/vscode-go/pull/44/checks?check_run_id=693415725 and other CI runs. (currently we are ignoring the test failures from this gopls integration tests because they are flaky)

1 failing
  1) Go Extension Tests With Gopls
       Completion middleware:
     Error: Timeout of 1000000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/vscode-go/vscode-go/out/test/gopls/extension.test.js)
  	at listOnTimeout (internal/timers.js:531:17)
  	at processTimers (internal/timers.js:475:7)

cc/ @stamblerre

created time in 7 days

push eventhyangah/vscode-go

Hana (Hyang-Ah) Kim

commit sha acc38cc83f478c4a95ec863655a9ba4c21839229

use webpack for packaging WIP Following the instruction in https://aka.ms/vscode-bundle-extension. I couldn't turn on the 'production' mode yet in packaging due to an issue with the Go Debug Adapter host program. Will keep investigating. Updates golang/vscode-go#53 Change-Id: I3466188557038772966a351f9cd41754d8b5ffe4

view details

push time in 7 days

create barnchhyangah/vscode-go

branch : webpack

created branch time in 7 days

issue commentmicrosoft/vscode-go

Unable to set breakpoint when using gutter and clear Code coverage

There is an open bug #3252 about not being able to clear the code coverage. Will you still need the workaround (gutter instead of highlight) if the bug is fixed?

JCzz

comment created time in 7 days

issue commentmicrosoft/vscode

support default folding configuration while using LSP

Thanks @kieferrm That's what I originally expected, but we are seeing different behavior. (microsoft/vscode-go#3249) It seems to me that only the result from LS's folding range resultsis reflected and the default foldingRange information is ignore. Should I reopen this issue?

hyangah

comment created time in 7 days

push eventhyangah/vscode-go

Rebecca Stambler

commit sha e04d33fe93565724d9eecbbb7e236714fb265fc9

src: convert installTools to be async Broke out a piece of https://go-review.googlesource.com/c/vscode-go/+/233538 into this PR, which converts all of the call sites of `installTools` to use async/await. Change-Id: I16d53d57790f4a01c9f116d4aed0de0b5b5c8161 GitHub-Last-Rev: 5463347f27ec2f3220a2b334b094a2676f9c55c7 GitHub-Pull-Request: golang/vscode-go#46 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/234021 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

view details

Hana (Hyang-Ah) Kim

commit sha 41650cfcd8199bb661484d283c8ba4207b8f546b

.github: delete unused bot configuration Our issue management is done by gopherbot. See https://go-review.googlesource.com/c/build/+/233377 Also, delete unnecessary METADATA Change-Id: I5da8e7b98fd6da659eff16c00360200b4b6e63f3

view details

push time in 7 days

push eventhyangah/vscode-go

Hana (Hyang-Ah) Kim

commit sha f0db5abb161f298898b1e95955d77eb19c0f3d92

src/telemetry.ts: remove telemetry The existing telemetry code is no longer used. Remove the dependency on the telemetry module that was a blocker of extension bundling. Update golang/vscode-go#53 Change-Id: I659166d121da05766cd5fd7ed16bbaf36e05c74b

view details

push time in 7 days

push eventhyangah/vscode-go

Hana (Hyang-Ah) Kim

commit sha 3fefc68386047a90ca44f2282f4e8a3bf99f182d

src/telemetry.ts: remove telemetry The existing telemetry code is no longer used. Remove the dependency on the telemetry module that was a blocker of extension bundling. Update golang/vscode-go#53 Change-Id: I659166d121da05766cd5fd7ed16bbaf36e05c74b

view details

push time in 7 days

PR opened golang/vscode-go

src/telemetry.ts: remove telemetry

The existing telemetry code is no longer used. Remove the dependency on the telemetry module that was a blocker of extension bundling.

Updates golang/vscode-go#53

Change-Id: I659166d121da05766cd5fd7ed16bbaf36e05c74b

+4 -328

0 comment

10 changed files

pr created time in 7 days

push eventhyangah/vscode-go

Hana Kim

commit sha 36c182f7de1eba7c26457f1ca16ba9ae9c2ce040

METADATA: add METADATA file Change-Id: I536057b891b495e5c766a4230fabdc8519d08981

view details

Hana Kim

commit sha 4263aca7c7da184f6a2c7e24789740a203fd6d7a

telemetry.ts: send telemetry only if aiKey is not empty Change-Id: Ic1fe3eb79f85d6a0eafea20dc7dc6e5d283d7ca4

view details

Hana Kim

commit sha ada08587033b59b41f093fc39f8890350d2dbacd

package.json: update for Go Nightly and disable telemetry This changes the extension publisher id and name for nightly. And set the preview field. Go Nightly is a preview of Go extension. Also, disable telemetry by setting aiKey in telemetry.ts to be empty. NIGHTLY ONLY Change-Id: I89aee39334102e16db402019a087fcb6f5021a57

view details

Hana Kim

commit sha cc26d302ce210a5fed8b6a65770a93ae763a3f9b

goLanguageServer.ts: allow Go Nightly to use pre-release versions. Also add isForNightly that is true if the extension is for nightly The extension name is one of the best way to check the extension's mode, but I couldn't find a way to dynamically determine the current extensionId through vscode api. For now I use the already existing constant that happens to be in the telemetry.ts. The extensionId is useful for purposes other than telemetry, so we'd better consider refactoring in the future. NIGHTLY ONLY Change-Id: I00377edbca233d1951052d200c730001493dc3cd

view details

Hana Kim

commit sha 57eea9ba2fcbf37d249b968b3ff10798ac13f464

README.md: add sections for Go Nightly NIGHTLY ONLY Change-Id: I9d20b35e4ccb1972b26f50b6d990bf1b95c8a405

view details

Hana Kim

commit sha a8f31eed929c226c83865c8fadf58c4c18ba5d97

builds: cloudbuild setup for Go Nightly Tested with the following commands $ gcloud auth login $ gcloud config set project vscode-go-insiders $ gcloud builds submit --config build/cloudbuild.container.yaml $ gcloud builds submit --config build/cloudbuild.yaml NIGHTLY ONLY Change-Id: I55f9cb181f8510caab7c7a8ff43d1e40540d7734

view details

Hana (Hyang-Ah) Kim

commit sha 341a4fffaaeab1b90e74cb5b2d30705f6ca5b908

CHANGELOG.md: 2020.3.x NIGHTLY ONLY Change-Id: Iad0001757f578716ea62c44feee4da7ad4cfc77f

view details

Hyang-Ah Hana Kim

commit sha 330f08ca9833221619433286d0cc89cfb43c512a

telemetry.ts: send telemetry only if aiKey is not an empty string(#3091)

view details

Hana (Hyang-Ah) Kim

commit sha 7bcec4e16ce8c720d50da12b5c6b552841f9518d

github/workflows: add CI github action workflow Ideally I want the CI to run from Gerrit because that will be our primary change review system, but the internal system is not ready yet. This is a temporary solution that uses Github Action. The CI workflow kicks in for every PR and every commit on the master. Change-Id: I97c9d20f4649c4cafd7a984c02fa84d0bc70f554 GitHub-Last-Rev: 948b555fc413ccff9d4c8e2f4564af041f73bbbc GitHub-Pull-Request: golang/vscode-go#4 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/222921 Reviewed-by: Rebecca Stambler <rstambler@golang.org>

view details

Hana (Hyang-Ah) Kim

commit sha c6967b397e765a9784bb114eb8a36036c69c11da

github/workflows: fix the syntax error in ci.yml Fixes the error in https://github.com/golang/vscode-go/actions/runs/53803644 And triggers the workflow for all push/prs. Change-Id: I1aa506b0863485a640b47c5da1993ace739c4ce8 GitHub-Last-Rev: dac3185ff61e928463626aa070b6fafc1b397f5c GitHub-Pull-Request: golang/vscode-go#7 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/222924 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

view details

Rebecca Stambler

commit sha d60e8c192ef755ed0363b6d678ff1b775ba67711

Refactor handling for go-langserver installation Remove the code that handled this in the language server installation, and be careful to only install the tool specified by the user. Also, remove some unused import lines in the goLanguageServer.ts file. Fixes microsoft/vscode-go#3028. Change-Id: I813c39f7d4997b63f7a87c1551de23df2808259c GitHub-Last-Rev: 9aa7363eae5ba645b8b9f1e01d6261e8c841c4c6 GitHub-Pull-Request: golang/vscode-go#2 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/222417 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

view details

Alan Fregtman

commit sha 5dc0357d681f05a7d7c78869a751728e7e86579a

bug_report.md: Fix "architecture" typo. (#3095)

view details

Hyang-Ah Hana Kim

commit sha 6d1bf5c7999d5af0adcc15141ca012c34a9ca71c

Include the link to release note/package overview in the update prompt, and update gopls default version (#3041)

view details

Hana (Hyang-Ah) Kim

commit sha ff99b034674f02200a54edc269058a4b6e3e3ad1

test/integration: use default GOPATH when the env var is not set If the env var GOPATH is not set when the test runs, now it runs `go env GOPATH` to retrieve the default value the underlying go commands will use. I wished I could make this command run asynchronously, but I am not familiar with the test framework and failed to make it working with async functions. So, like many other file operations used in the test setup phase, I am using execFileSync. Update golang/vscode-go#6 Change-Id: Id075827ab8ebd955f7a86460aaa7ea4e0e7cd183 GitHub-Last-Rev: 62221580ddaae0062ec79a3ab3efc6258c912117 GitHub-Pull-Request: golang/vscode-go#8 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223177 Reviewed-by: Andrew Bonventre <andybons@golang.org>

view details

Hana (Hyang-Ah) Kim

commit sha 2c09acac9109d2caf3daf9fa0601277be1d1f1a7

github/workflow: daily release workflow Daily release workflow is triggered everyday between Mon-Thu, 15:00 UTC (11am EDT). This prepares the version string through local modification on package.json and runs the tests again before publishing. The newly released version has the version string computed based on the last git commit's commit timestamp. <Year>.<Month>.<Day>-<Short Commit Hash> That means, if there is no commit since the last release, the publishing step will fail (because the MS VS Code extension market will detect the identical version). Update golang/vscode-go#5 Change-Id: Ief59f5ed4e89eea66df3607f20263c3f6b75e716 GitHub-Last-Rev: b888148a09251f7012136653d7f705d5ef4d1fde GitHub-Pull-Request: golang/vscode-go#10 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223677 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Quoc Truong

commit sha 7da50774f84578b5ec6c46b27c0a3446d485f4a6

Address mismatch on path separators in debug config (#2010) (#3108)

view details

Hana (Hyang-Ah) Kim

commit sha d5854798ada5b11f0d75fbfce6e26988f721f165

github/workflows: use <year>.<month>.<day>.<hour> as version Marketplace does not allow prerelease annotation. That caused the release error like https://github.com/golang/vscode-go/runs/517074211?check_suite_focus=true Use the four digit semver instead. Note the current `vsce package` command allows prerelease annotation but does not allow four digit semver format currently. And record the commit hash to the CHANGELOG.md since we cannot rely on the version string to encode the info. Update golang/vscode-go#5 Change-Id: Id45fc822bb0d5b6b6750e28bf71bbb49f3eb97be GitHub-Last-Rev: cf712916b004aab4b72eed837b14ac8d8be70827 GitHub-Pull-Request: golang/vscode-go#12 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223961 Reviewed-by: Rebecca Stambler <rstambler@golang.org>

view details

Hana (Hyang-Ah) Kim

commit sha f19678deb40956873ec192d0e2c6b8c584308c4a

github/workflows: use npm install for release testing Change-Id: I9967b4024c34db71b8ea7d753da4790a4bec9fa7 GitHub-Last-Rev: 8678cf28d1055e546c5ea310e7efda6624441ae2 GitHub-Pull-Request: golang/vscode-go#15 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/224139 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

view details

Hana (Hyang-Ah) Kim

commit sha 114da49796da3d8ddfbce8e276312610a8e570d5

github/workflows: use npm install and change version to X.Y.Z format semver package is unhappy about X.Y.Z.W format of version string and leave the extension in invalid state. Now make semver happy. Also, use npm install to ensure all test dependencies are pulled in. Change-Id: I98fd51b475fce20ef069b50b86a2eb9eba530032 GitHub-Last-Rev: 9bf48fc971e39c37dfd49db739b219f124c79962 GitHub-Pull-Request: golang/vscode-go#16 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/224099 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

view details

Luis GG

commit sha 00c318b30ba15773987851af42586c72c625c7a8

Add stacktrace dump and better error messages on EXC_BAD_ACCESS panics (#2904)

view details

push time in 7 days

PR opened golang/vscode-go

.github: delete unused bot configuration

Our issue management is done by gopherbot.

See https://go-review.googlesource.com/c/build/+/233377

Change-Id: I5da8e7b98fd6da659eff16c00360200b4b6e63f3

+0 -11

0 comment

2 changed files

pr created time in 7 days

create barnchhyangah/vscode-go

branch : delete

created branch time in 7 days

PR closed microsoft/vscode-go

Generated Code message related fixes

This commit changes default functionality of vscode-go extention (see #3243 ):

  1. It allows to check other (then) first line of the file for target msg, but only the lines with comments and empty lines at begining of the file.
  2. It uses lookup table to cache results of previous checks
  3. It uses non-greedy regexp for checking targeted lines.
+38 -10

1 comment

1 changed file

butuzov

pr closed time in 7 days

pull request commentmicrosoft/vscode-go

Generated Code message related fixes

Closing this in favor of https://github.com/golang/vscode-go/pull/69

Thanks for the PR!

butuzov

comment created time in 7 days

pull request commentgolang/vscode-go

src/goCheck.ts: relax generated code detection rule

@butuzov I left comments in gerrit (https://golang.org/cl/234359), the default review tool in the Go project. Can you take a look?

Sorry for this confusing PR review process. I hope we can get it sorted out soon. Thanks!!

butuzov

comment created time in 7 days

PR opened golang/vscode-go

doc: update debug adapter doc

Change-Id: I935c576fe61e085c4addcee65c4886709bfa3af7

+4 -4

0 comment

1 changed file

pr created time in 8 days

create barnchhyangah/vscode-go

branch : dapdoc

created branch time in 8 days

issue commentgolang/go

x/mobile/cmd/gomobile: bind command fails with "direct call too far" with 100 MB executable file

@cherrymui Can you please help with this linker error?

Shagrat2

comment created time in 8 days

issue commentmicrosoft/vscode-go

Background of covered and not covered code cannot be removed after running package test

@Kegsay thanks for the pointer. I don't know why but I observed isDirty is never true when the callback is invoked. Can you please take a look at the linked PR?

@ramya-rao-a I sent my PR for the fix in golang/vscode-go. How do you want to handle PRs for minor bug fixes like this during the repo migration?

xhit

comment created time in 8 days

PR opened golang/vscode-go

src/goCover: clear cached coverage info on save

This is a fix for the regression in ms-vscode.Go@0.14.2

The isDirty bit of the TextDocument when vscode.workspace.onDidSaveTextDocument is already false. Adjust the condition for clearing cache not to check it. Modification should be tracked already by trackCodeCoverageRemovalOnFileChange.

And let modifiedFiles start with an empty value rather than as undefined.

Fixes https://github.com/microsoft/vscode-go/issues/3252.

+2 -2

0 comment

1 changed file

pr created time in 8 days

create barnchhyangah/vscode-go

branch : coverfix

created branch time in 8 days

issue commentmicrosoft/vscode-go

Background of covered and not covered code cannot be removed after running package test

Thanks. I could reproduce this as well. @ramya-rao-a @Kegsay Is this intended behavior?

xhit

comment created time in 8 days

issue commentmicrosoft/vscode-go

Background of covered and not covered code cannot be removed after running package test

@xhit does the coverage info still remain if the edited file is saved? I believe the issue #2551 is a feature request to preserve the coverage info while typing because otherwise, it is difficult to fix code based on the coverage feedback.

xhit

comment created time in 8 days

issue commentgolang/go

runtime/trace: test failures increased as of 2020-05-01

cc/ @dvyukov @pjweinbgo who know better about the ordering algorithm.

bcmills

comment created time in 8 days

issue commentgolang/go

runtime/trace: test failures increased as of 2020-05-01

Thanks @mknyszek for investigating it. What will happen if we relax the trace ordering requirement, and allow GoWaiting -> GoStart transitions (and inject a dummy GoUnblock event)?

bcmills

comment created time in 8 days

issue closedmicrosoft/vscode-go

numeric constants containing underscore are not colored correctly

Go version 1.14.1 VS Code Go: 0.14.2 VS Code version: Version: 1.45.1 (system setup) Commit: 5763d909d5f12fe19f215cbfdd29a91c0fa9208a Date: 2020-05-14T08:27:35.169Z Electron: 7.2.4 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.18363

Go allows embedded underscore characters in numeric constants. Please see language spec: https://golang.org/ref/spec#Integer_literals and https://golang.org/ref/spec#Floating-point_literals

the following program compiles correctly where 5_3_1 == 531, but only the number 3.1415 is colored correctly.

package main
import (
	"fmt"
)
func main() {
	fmt.Println(5_3_1, 1_000_000, 3.1415)
}

closed time in 8 days

WBare

issue commentmicrosoft/vscode-go

numeric constants containing underscore are not colored correctly

Thanks for the report.

There is already an open bug. Let's follow up there. https://github.com/jeff-hykin/better-go-syntax/issues/3

WBare

comment created time in 8 days

issue commentgolang/vscode-go

gopls installation works only with go 1.13+

The current way of vscode Go extension building underlying tools from the latest versions of sources needs fixing. Now the main question is how and where we store and maintain the mapping.

Note: the version required to build a tool and the version the tool can analyze can be different. Often the latter is wider.

hyangah

comment created time in 8 days

issue commentgolang/go

runtime: "fatal error: runtime: name offset out of range" on Android 6.0.1 arm64-v8a

awesome, @x0b!

@eliasnaur @ianlancetaylor is it possible to revert the change (in particular, if ldd is still under testing)?

x0b

comment created time in 8 days

PR closed microsoft/vscode-go

test/integration: fix Build Tags checking tests

The test invoked 'check' concurrently with different sets of tags. Underneath, the check function invokes the goBuild, which cancels outstanding go build commands before starting another go build command. That means, the three go build processes race and try to cancel others. The premature cancelation results in empty diagnostics and thus, flakiness when tests expect non-empty results.

Serialize the tests.

While we are here, also fixes the use of assert.equal which expects the actual value as the first parameter and the expected value as the second parameter.

+38 -60

1 comment

1 changed file

hyangah

pr closed time in 9 days

pull request commentmicrosoft/vscode-go

test/integration: fix Build Tags checking tests

Merged to golang/vscode-go with https://go-review.googlesource.com/c/vscode-go/+/233517

hyangah

comment created time in 9 days

issue openedmicrosoft/vscode-go

Extension Migration Plan

We plan to change the extension's publisher ID from ms-vscode to golang. The extension ID will become golang.Go after the transition.

Date: TBD

  • [ ] Public announcement about the plan.
  • [ ] Publish the final version of ms-vscode.Go (0.14.N). (#3247)@ramya-rao-a
  • [ ] Notify extension pack authors who depend on ms-vscode.Go. @hyangah @stamblerre
  • [ ] (optional) Search GitHub for .vscode/extensions.json that mentions ms-vscode.Go, and notify the owners. @hyangah @stamblerre
  • [ ] Give @chrisdias publisher rights to golang publisher (needed for marketplace transfer). @hyangah
  • [ ] Contact the Microsoft/Marketplace team to transfer the extension. The actual transfer will take ~24hrs due to time zones. @chrisdias
  • [ ] Check all searches, etc. will work properly. Note a few exceptions: * The extension on disk will still have ms-vscode publisher ID until the new extension release. * VS Code extension recommendation will not work until the new extension release.
  • [ ] Notify extension pack authors of the Marketplace transfer completion and encourage to publish updates with golang.Go id. @hyangah @stamblerre
  • [ ] Publish v0.14.(N+1) with golang.Go. It is identical with v0.14.N feature-wise.
  • [ ] Update VS Code recommendations released to VS Code insiders/stable. @chrisdias
  • [ ] Remove @chrisdias from golang publisher. @hyangah
  • [ ] Archive github.com/microsoft/vscode-go. @ramya-rao-a

created time in 9 days

issue commentgolang/vscode-go

test: make sure user's configuration or environment does not affect tests

Seems like the --user-data-dir trick no longer works. Filed https://github.com/microsoft/vscode/issues/97995

stamblerre

comment created time in 9 days

issue commentmicrosoft/vscode-go

Debugging uses wrong working directory

@JoseFMP Please send a PR to the new repository github.com/golang/vscode-go (https://github.com/microsoft/vscode-go#we-are-moving)

I still need to understand the error message "main.go:4:2: package ****** is not in GOROOT (*******)" - that's a build error so I am not yet sure how changing cwd will help finding the main.go file. But I hope it will become obvious with the PR for fix.

cc @quoctruong @ramya-rao-a

JoseFMP

comment created time in 9 days

issue openedmicrosoft/vscode

support default folding configuration while using LSP

When LSP is enabled, the folding marker listed in vscode/extensions/go/language-configuration.json seems to be ignored. https://github.com/microsoft/vscode-go/issues/3249

Is this intentional?

Is there any way to use this default foldingRange information while using LSP?

The //#region .... //#endregion is not part of the language spec so handling this is beyond the language server's responsibility. Either we need to teach vscode to use both information sources, or combine the info from LanguageClient middleware.

created time in 9 days

pull request commentmicrosoft/vscode-go

Add note on migration process

Closing in favor of Rebecca's #3250

hyangah

comment created time in 9 days

PR closed microsoft/vscode-go

Reviewers
Add note on migration process
+2 -1

1 comment

1 changed file

hyangah

pr closed time in 9 days

CommitCommentEvent

issue commentmicrosoft/vscode-go

// .*DO NOT EDIT.?$

@butuzov gopls is still in beta. So we will keep the option to use this extension without gopls open for a while. But we hope to consider gopls and dlv dap first if the features can be provided through LSP and DAP.

butuzov

comment created time in 10 days

issue openedgolang/vscode-go

gopls installation works only with go 1.13+

Recent versions of gopls (v0.4.1+) depends on new APIs available only after go1.13+

../../../../pkg/mod/golang.org/x/tools@v0.0.0-20200513154647-78b527d18275/internal/jsonrpc2/messages.go:168:5: undefined: errors.As

We have a couple of options to consider

  • suggest a compatible version of gopls for users with old versions of Go or
  • ask to use the latest version of Go to build the gopls or
  • ask to upgrade Go (this may not be desirable for users who need to use old versions, e.g. comparison, regression testing, etc)

@stamblerre @ianthehat

created time in 10 days

PR opened microsoft/vscode-go

Add note on migration process
+2 -1

0 comment

1 changed file

pr created time in 10 days

create barnchhyangah/vscode-go

branch : upstream

created branch time in 10 days

issue openedmicrosoft/vscode-go

Extension Migration Plan

Preparation

  • [x] Create a public issue with the checklist. @hyangah
  • [ ] Pin this issue and update the README. @ramya-rao-a
  • [x] Update github.com/microsoft/vscode-go/README.md and issue templates. @ramya-rao-a
  • [ ] Update github.com/golang/vscode-go documentation and issue templates. @hyangah @stamblerre
  • [ ] Notify open PR authors, and ask to move to https://github.com/golang/vscode-go.
  • [ ] Transfer or close remaining open issues.
  • [ ] Notify extension pack authors who depend on ms-vscode.Go. @hyangah @stamblerre
  • [ ] (optional) Search GitHub for .vscode/extensions.json that mentions ms-vscode.Go, and notify the owners. @hyangah @stamblerre

Extension Transfer

from ms-vscode.Go to golang.Go

  • [ ] Commit all remaining PRs and publish the final version of ms-vscode.Go (v0.15.0) with github.com/golang/vscode-go/issues as the issue tracker. @ramya-rao-a
  • [ ] Give @chrisdias publisher rights to golang publisher (needed for marketplace transfer). @hyangah
  • [ ] Contact the Microsoft/Marketplace team to transfer the extension. The actual transfer will take ~24hrs due to time zones. @chrisdias
  • [ ] Check all searches, etc. will work properly. Note a few exceptions: * The extension on disk will still have ms-vscode publisher ID until the new extension release. * VS Code extension recommendation will not work until the new extension release.
  • [ ] Notify extension pack authors of the Marketplace transfer completion and encourage to publish updates with golang.Go id. @hyangah @stamblerre
  • [ ] Publish v0.15.1 with golang.Go. v0.15.1 is identical with v0.15.0 feature-wise.
  • [ ] Update VS Code recommendations released to VS Code insiders/stable. @chrisdias
  • [ ] Remove @chrisdias from golang publisher. @hyangah
  • [ ] Archive github.com/microsoft/vscode-go. @ramya-rao-a

created time in 10 days

issue commentgolang/vscode-go

build: enable strict type checking

note: i sent multiple PRs (as separate branches) in order to export them as separate CLs, each of which can be reasonably sized. :-(

hyangah

comment created time in 10 days

issue commentmicrosoft/vscode-go

// .*DO NOT EDIT.?$

Wish https://github.com/golang/go/issues/13560 made any progress in this problem domain.

@stamblerre what does gopls do to detect generated code?

butuzov

comment created time in 10 days

issue closedmicrosoft/vscode-go

Extension issue

  • Issue Type: Bug
  • Extension Name: Go
  • Extension Version: 0.14.2
  • OS Version: Windows_NT x64 10.0.18362
  • VSCode version: 1.45.1

:warning: We have written the needed data into your clipboard. Please paste! :warning:

closed time in 10 days

yadavalli1

issue commentmicrosoft/vscode-go

Extension issue

Need more details about the issue.

yadavalli1

comment created time in 10 days

issue closedmicrosoft/vscode-go

Compile with `--strictNullChecks` and `--strictPropertyInitialization` flags

Continuation of #2284, as discussed with @ramya-rao-a and @vladbarosan. There are about 390 compilation errors with both flags activated, so there's quite a bit of work to do

I'd copy the list but running tsc from the console works differently than the VS Code task, and I get the following error (even with the flags deactivated and no errors running the task):

tsconfig.json(14,3): error TS5023: Unknown compiler option 'strictBindCallApply'.
^[[A^[[Bsrc/goImport.ts(79,9): error TS7034: Variable 'edits' implicitly has type 'any[]' in some locations where its type cannot be determined.
src/goImport.ts(85,4): error TS7005: Variable 'edits' implicitly has an 'any[]' type.

closed time in 10 days

lggomez

issue commentmicrosoft/vscode-go

Compile with `--strictNullChecks` and `--strictPropertyInitialization` flags

Closing this in favor of https://github.com/golang/vscode-go/issues/57 I will make the change to tsconfig.json once all the outstanding PRs in the golang/vscode-go repo land.

lggomez

comment created time in 10 days

PR opened golang/vscode-go

strict: fix type check errors in utilities

Update golang/vscode-go#57

+116 -93

0 comment

6 changed files

pr created time in 10 days

PR opened golang/vscode-go

strict: fix type check errors in src/goLanguageServer.ts

Update golang/vscode-go#57

+39 -29

0 comment

1 changed file

pr created time in 10 days

PR opened golang/vscode-go

strict: fix type check errors in test code

Update golang/vscode-go#57

+31 -25

0 comment

4 changed files

pr created time in 10 days

PR opened golang/vscode-go

strict: fix type check errors in code for legacy providers

Update golang/vscode-go#57

+115 -103

0 comment

8 changed files

pr created time in 10 days

PR opened golang/vscode-go

strict: fix strict type check errors in debug feature implementation

Update golang/vscode-go#57

+240 -134

0 comment

2 changed files

pr created time in 10 days

PR opened golang/vscode-go

strict: fix strict type check errors in various commands implementation

Update golang/vscode-go#57

+68 -43

0 comment

11 changed files

pr created time in 10 days

PR opened golang/vscode-go

strict: fix strict type check errors in src/avlTree.ts

Update golang/vscode-go#57

Change-Id: I44f25a8fc9f76cab5265365b7a1940dcd2f04217

+15 -17

0 comment

1 changed file

pr created time in 10 days

create barnchhyangah/vscode-go

branch : debt

created branch time in 10 days

create barnchhyangah/vscode-go

branch : debt-test

created branch time in 10 days

more