profile
viewpoint

choojs/bankai 1054

:station: - friendly web compiler

choojs/wayfarer 323

:eyeglasses: composable trie based router

browserify/ify-loader 67

Webpack loader to handle browserify transforms as intended.

hughsk/adobe-swatch-exchange 35

Encode/decode color palettes in Adobe's .ase format

ahdinosaur/transpilify 28

:frog: Applies browserify transforms to your source code, without actually bundling it.

glslify/glslify-hex 28

A transform stream for glslify that replaces CSS-style hexadecimal colors with `vec3/vec4` definitions.

hughsk/ansi-html-stream 28

Stream for converting terminal UTF-8 ANSI color codes into HTML

glslify/glslify-import 13

A transform stream for glslify that adds an `import` directive to your shaders.

glslify/glslify-optimize 12

A browserify transform stream that optimizes your glslify shaders

hughsk/atob-lite 12

Smallest/simplest possible means of using atob with both Node and browserify

pull request commentkiln/flourish-popup

Improve performance of repeated calls to popup.hide()

Done! :)

hughsk

comment created time in 5 days

created tagkiln/flourish-popup

tagv2.1.3

Flourish popup component

created time in 5 days

push eventkiln/flourish-popup

Hugh Kennedy

commit sha 864126c0c1faa33aa4c4b149c8cb06f3b0796c3b

2.1.3

view details

push time in 5 days

pull request commentkiln/flourish-popup

Improve performance of repeated calls to popup.hide()

Tested with sticky and non-sticky popups on the point map and display: none seems to do the trick! No issues arising either -- though may want to check again in another template :)

hughsk

comment created time in 5 days

push eventkiln/flourish-popup

Hugh Kennedy

commit sha 33ddc8429716e05e788122012d898aa57c72b0e2

Hide popup constrainer when popup is hidden This prevents the constrainer from extending beyond its bounds when resizing the window when the popup is hidden.

view details

push time in 5 days

PR opened kiln/flourish-popup

Improve performance of repeated calls to popup.hide()

Previously, _resizeConstrainer() was being called every time popup.hide() was being called. This introduces a simple check that prevents popup.hide() from running any heavy code if it's already hidden.

This improves the performance of the popup module in the point map template, which currently calls popup.hide() once per frame. It's possible to make changes in the template to prevent this, but I figure it's better to address this at the module level to prevent it causing performance issues in other templates in the future :)

See also: https://github.com/kiln/template-3d-point-map/issues/97#issuecomment-662986017

+5 -0

0 comment

2 changed files

pr created time in 11 days

create barnchkiln/flourish-popup

branch : popup-hide-perf

created branch time in 11 days

more