profile
viewpoint

hirochachacha/go-smb2 23

SMB2/3 client library written in Go.

hirochachacha/plua 7

Lua 5.3 implementation (WIP)

u16suzu/Reading-The-RSpec-Book 3

Reading The RSpec Book in English at Geekhouse Musashi-Kosugi

hirochachacha/graphql-auto-transformer 2

A custom transformer of the amplify-cli. It can control accessibility of auto generated fields.

hirochachacha/p 1

experimental UI for google/pprof

hirochachacha/amplify-cli 0

A CLI toolchain for simplifying serverless web and mobile development.

hirochachacha/apython 0

My personalized version of bpython. It's not for general purpose

hirochachacha/babel 0

:tropical_fish: Babel is a compiler for writing next generation JavaScript.

hirochachacha/compose 0

Define and run multi-container applications with Docker

hirochachacha/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

PR opened aws-amplify/amplify-cli

chore: fix file permissions

Issue #, if available:

Description of changes:

Convert some file permissions from 755 to 644.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+4 -17

0 comment

27 changed files

pr created time in a day

create barnchhirochachacha/amplify-cli

branch : chore/fix_permissions

created branch time in a day

pull request commentaws-amplify/amplify-cli

chore(cli): improve error message in readJsonFile

@kaustavghosh06 @SwaySway PTAL

hirochachacha

comment created time in a day

push eventhirochachacha/amplify-cli

Nikhil Lingireddy

commit sha 3c31f2524680894c83a4c344784428f0c12b0d20

fix: add frontend plugins for guessing platform (#3312) * fix: add frontend plugins for guessing platform fix #3300 * test(amplify-app): add tests to amplify-app for javascript test angular and react amplify projects are set up correctly, along with modelgen and init/push * fix: lint-fix * test: add tests for android and ios * style: white space * style: fix test suite name * refactor: addressing pr comments * fix: update min cli version

view details

Nikhil Lingireddy

commit sha 4f9a820fdd520716cf1af3841440499337c4d45b

refactor: update min cli version (#3374)

view details

aws-amplify-bot

commit sha dcc5623433af21cd97eafae5d188fa968923856e

chore(release): Publish [ci skip] - amplify-app@2.13.2 - amplify-appsync-simulator@1.13.2 - amplify-category-analytics@2.13.2 - amplify-category-api@2.13.2 - amplify-category-auth@2.13.2 - amplify-category-function@2.13.2 - amplify-category-hosting@2.1.10 - amplify-category-interactions@2.1.10 - amplify-category-notifications@2.13.2 - amplify-category-predictions@2.1.10 - amplify-category-storage@2.1.10 - amplify-category-xr@2.1.10 - @aws-amplify/cli@4.13.2 - amplify-codegen-appsync-model-plugin@1.13.2 - amplify-codegen@2.13.2 - amplify-dynamodb-simulator@1.13.2 - amplify-e2e-tests@2.13.2 - amplify-frontend-android@2.13.2 - amplify-frontend-ios@2.13.2 - amplify-frontend-javascript@2.13.2 - amplify-graphiql-explorer@1.1.10 - amplify-graphql-docs-generator@2.1.10 - amplify-graphql-types-generator@2.1.10 - amplify-provider-awscloudformation@4.13.2 - amplify-storage-simulator@1.1.10 - amplify-ui-tests@2.13.2 - amplify-util-mock@3.13.2 - amplify-velocity-template@1.1.10 - graphql-auth-transformer@6.13.2 - graphql-connection-transformer@4.13.2 - graphql-dynamodb-transformer@6.13.2 - graphql-elasticsearch-transformer@4.3.2 - graphql-function-transformer@2.1.10 - graphql-http-transformer@4.13.2 - graphql-key-transformer@2.13.2 - graphql-mapping-template@4.13.2 - graphql-predictions-transformer@2.1.10 - graphql-relational-schema-transformer@2.13.2 - graphql-transformer-common@4.13.2 - graphql-transformer-core@6.13.2 - graphql-transformers-e2e-tests@6.13.2 - graphql-versioned-transformer@4.13.2

view details

Josue Ruiz

commit sha 9462bb5b3d364b23415105daf6245fd63a446b1f

fix(amplify-graphql-types-generator): fix passing typename on fields … (#3328) * fix(amplify-graphql-types-generator): fix passing typename on fields fix passing typenames when evaluating fields and their selection sets fix #1325

view details

Yathi

commit sha 931db6d5d575d1d68776205df5f136801032c852

build: sync packages to use same version of jest (#3356) Updated packages in monorepo to use the same version of jest related packages

view details

Yathi

commit sha 044cd045f6633c08dbb7ccbbcb78190ea194d2ca

test(amplify-e2e-tests): disable ts-jest diagnostics (#3400)

view details

Yathi

commit sha 7b0ff5f4bd199cfb201fdbafa73962cfe7441730

ci: update amplify e2e tests to use packages from verdaccio (#3392) updated amplify E2E tests to use package published to verdaccio instead of using the development version of the Amplify CLI

view details

Nikhil Lingireddy

commit sha 7f5846e4fd2c751fe0ae90d44d5f982494d29ad9

Refactor amplify-app tests (#3397) * test: refactor amplify app e2e tests and move to e2e dir * refactor: remove tests from amplify-app * refactor: remove jest and nextpect from amplify-app package.json

view details

Nikhil Lingireddy

commit sha aae3a929f81a59514210cb3974e9e2fbb7a954ef

fix: fix amplify-app on windows (#3401) fix #3396

view details

Yathi

commit sha 926fa0d595809061d0ae84323bcfcd3d5c5737b7

chore: update setup-dev-win to work on windows (#2651) Update the windows setup script to work with yarn and generate amplify-dev.cmd when linking

view details

Yathi

commit sha ab369b33a1459c9296c648748624e2219f1d1fcf

feat(amplify-util-mock): update cfn processing (#3285) * fix(amplify-util-mock): update cfn parsing for mock API mock server uses graphql generated CloudFormation to provision resources locally. Updated the processing logic to process resources individually instead of merging resources directly and provisioning resources. Earlier implementation did not account for nested stacks and dependevcies. Updated the parsing code to print warning about resources that are not supported by mock to provide why an API might fail to start * fix tests * fix lgtm error * remOve duplicate scripts Co-authored-by: Attila Hajdrik <attila@eyedea.hu>

view details

Yathi

commit sha 8f96f321b79eea2f6c22435bc34cd78a18ec0631

chore: fix integ test setup error (#3405)

view details

Yathi

commit sha 33fdadccaad59bca719135b8e122d3d1800e7b29

docs: update node version on Readme.md (#3412)

view details

Attila Hajdrik

commit sha 89c68eec54bfce1819b76696eca81d85546e2c1d

chore: update yarn.lock before release (#3408)

view details

Nikhil Lingireddy

commit sha 65f961ed967261059bcd5615b1865dedb06bb75c

test: fixing spawn in amplify-app tests to work in CI (#3410) * test: fixing spawn in amplify-app tests to work in CI * test: fix spawn args

view details

ammarkarachi

commit sha 97c893c34efab3758b1f2d21a47154e4fcb5bb82

test: waiting on deletion of bucket and deleting project for hosting (#3415)

view details

Yathi

commit sha a6eba858f2ed31192a1214a22a3180dd243c80c7

fix(amplify-codegen): support appsync scalars in modelgen (#3424) using an appsync scalar in the schema caused issues when generating data store model due to the change in graphql-codegenerator library. Fixing the version of the lib which is known to work when plugins use addToSchema method to extend the schema in the plugin partial fix #3296

view details

aws-amplify-bot

commit sha 26fb93b79d94111ed9df20dbd3931432341cda57

chore(release): Publish [ci skip] - amplify-app@2.13.3 - amplify-appsync-simulator@1.13.3 - amplify-category-analytics@2.13.3 - amplify-category-api@2.13.3 - amplify-category-auth@2.13.3 - amplify-category-function@2.13.3 - amplify-category-hosting@2.1.11 - amplify-category-interactions@2.1.11 - amplify-category-notifications@2.13.3 - amplify-category-predictions@2.1.11 - amplify-category-storage@2.1.11 - amplify-category-xr@2.1.11 - @aws-amplify/cli@4.13.3 - amplify-codegen-appsync-model-plugin@1.13.3 - amplify-codegen@2.13.3 - amplify-dynamodb-simulator@1.13.3 - amplify-e2e-tests@2.13.3 - amplify-graphql-docs-generator@2.1.11 - amplify-graphql-types-generator@2.1.11 - amplify-provider-awscloudformation@4.13.3 - amplify-ui-tests@2.13.3 - amplify-util-mock@3.14.0 - graphql-auth-transformer@6.13.3 - graphql-connection-transformer@4.13.3 - graphql-dynamodb-transformer@6.13.3 - graphql-elasticsearch-transformer@4.3.3 - graphql-function-transformer@2.1.11 - graphql-http-transformer@4.13.3 - graphql-key-transformer@2.13.3 - graphql-mapping-template@4.13.3 - graphql-predictions-transformer@2.1.11 - graphql-relational-schema-transformer@2.13.3 - graphql-transformer-common@4.13.3 - graphql-transformer-core@6.13.3 - graphql-transformers-e2e-tests@6.13.3 - graphql-versioned-transformer@4.13.3

view details

Marco Reni

commit sha a7ad64c519dff1e1977f3fca48f0adea4586aeb8

feat(amplify-appsync-simulator): implement missing string methods(#3389) (#3398) Add the following methods for JavaString: concat contains endsWith indexOf isEmpty lastIndexOf replace replaceFirst matches split startsWith substring toLowerCase toUpperCase trim split() implementation has been adapted from ConduitVC/aws-utils repository (which AFAIU was the starting point for the amplify mock).

view details

Marco Reni

commit sha 55287607a2d97936420b9725cd2108d92ed35b61

fix(amplify-appsync-simulator): forward stash to responseMappingTemplate (#3387)

view details

push time in a day

delete branch hirochachacha/go-smb2

delete branch : tests/integration

delete time in 3 days

push eventhirochachacha/go-smb2

Hiroshi Ioka

commit sha 0e82d26b8f08d7c6f2fb983625bd3307c49fa028

test: add integration test

view details

push time in 3 days

push eventhirochachacha/go-smb2

Hiroshi Ioka

commit sha 89ec7e0ef0425620d2eaac0fd5c71570ca5be90a

test: add integration test

view details

push time in 3 days

push eventhirochachacha/go-smb2

Hiroshi Ioka

commit sha 76cdba2e58402372dad26daa9f11be2bb362418f

test: integration test

view details

push time in 3 days

push eventhirochachacha/go-smb2

Hiroshi Ioka

commit sha 1f3638da733e7d69306cdfbb59bb71a5452cc39d

fad

view details

push time in 3 days

push eventhirochachacha/go-smb2

Hiroshi Ioka

commit sha b19996000d1eb13f5df256bf8c41142643c20de3

fadf

view details

push time in 3 days

push eventhirochachacha/go-smb2

Hiroshi Ioka

commit sha 67d61c3aeab66cff810340680d1ec4f9c5adf793

fsdaf

view details

push time in 3 days

push eventhirochachacha/go-smb2

Hiroshi Ioka

commit sha 5edcbe2f31664c6409f66ca627f586373e7882d5

fasdf

view details

push time in 3 days

push eventhirochachacha/go-smb2

Hiroshi Ioka

commit sha 905a197a2ea84b839f9149d690016f18a335ac24

fdasf

view details

push time in 3 days

push eventhirochachacha/go-smb2

Hiroshi Ioka

commit sha b7aa37f5bd164d102bb45bab24c1dc10997f17ab

test: integration test

view details

push time in 3 days

create barnchhirochachacha/go-smb2

branch : tests/integration

created branch time in 3 days

PR closed hirochachacha/go-smb2

Allow zero-length file paths to enable opening of root directories

According to the MS-SMB2 spec, a zero length file name in an SMB2 CREATE request indicates a request to open the root directory of the share.

https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-smb2/5606ad47-5ee0-437a-817e-70c366052962

+19 -35

2 comments

13 changed files

omnifocal

pr closed time in 3 days

push eventhirochachacha/go-smb2

Hiroshi Ioka

commit sha 62da7427dd3447e69287f590c52e2405bff396bb

fix: allow empty pathname for Open https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-smb2/e8fb45c1-a03d-44ca-b7ae-47385cfd7997 said: NameOffset field SHOULD be set to the offset of the Buffer field from the beginning of the SMB2 header. The file name (after DFS normalization if needed) MUST conform to the specification of a relative pathname in [MS-FSCC] section 2.1.5. A zero length file name indicates a request to open the root of the share. Suggested by @pbergman and @omnifocal. Fixes #5 #6

view details

push time in 3 days

PR closed hirochachacha/go-smb2

add Readdir method for RemoteFileSystem

Maybe I misunderstood something but i could not find a method for reading the current directory of an open RemoteFileSystem.

the api suggest something like:

	mount, err := sf.client.Mount(`\\127.0.0.1\data`)
	if err != nil {
		panic(err)
	}
        defer mount.Umount()
        rf, err := mount.Open("PATH_NAME")
	if err != nil {
		panic(err)
	}
        files, err := dir.Readdir(-1)
	if err != nil {
		panic(err)
	}
       ......

This is ok when you know the (or have an) path but when you want read the root the isInvalidPath method will return an error because it is not allow an empty string as argument what makes sense when opening an file but not for opening an file object to read the current directory.

+11 -0

0 comment

1 changed file

pbergman

pr closed time in 3 days

pull request commenthirochachacha/go-smb2

Allow zero-length file paths to enable opening of root directories

https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-smb2/e8fb45c1-a03d-44ca-b7ae-47385cfd7997

NameOffset field SHOULD be set to the offset of the Buffer field from the beginning of the SMB2 header. The file name (after DFS normalization if needed) MUST conform to the specification of a relative pathname in [MS-FSCC] section 2.1.5. A zero length file name indicates a request to open the root of the share.

OK. I found it.

omnifocal

comment created time in 3 days

pull request commenthirochachacha/go-smb2

Allow zero-length file paths to enable opening of root directories

@omnifocal Could you give me more specific links? Thanks.

omnifocal

comment created time in 4 days

issue closedhirochachacha/graphql-auto-transformer

amplify api gql-compile TypeError: Class constructor Transformer cannot be invoked without 'new'

When I try to use the the transformer (with NODE_PATH workaround) I get the error:

amplify api gql-compile TypeError: Class constructor Transformer cannot be invoked without 'new'

latest amplify-cli version - 4.13.2

closed time in 9 days

Futhark

issue commenthirochachacha/graphql-auto-transformer

amplify api gql-compile TypeError: Class constructor Transformer cannot be invoked without 'new'

Thank you for your report. I've fixed the issue in the latest version. Please give it a try.

Futhark

comment created time in 9 days

push eventhirochachacha/graphql-auto-transformer

Hiroshi Ioka

commit sha a9c77181faa005b7ab7f5c405713a99af85e7b87

update ts target from es5 to es2018; yarn upgrade

view details

Hiroshi Ioka

commit sha d593a414ab88af285771e71b6d50f13166353759

v1.2.1

view details

push time in 9 days

issue commentaws-amplify/amplify-cli

createdAt, updatedAt and id should not be required on inputs / mutations

This is #1657. That's the reason I made https://github.com/hirochachacha/graphql-auto-transformer. @malcomm Perhaps, it might help you as a temporary solution.

malcomm

comment created time in 12 days

pull request commentshelfio/jest-dynamodb

feat: add installer config

@vladgolubev How about https://github.com/shelfio/jest-dynamodb/pull/74?

hirochachacha

comment created time in 13 days

push eventhirochachacha/jest-dynamodb

Hiroshi Ioka

commit sha 0e8e1071172fda9cff4164695cbee2516ecab188

docs: add explanation for config

view details

push time in 13 days

push eventhirochachacha/jest-dynamodb

Hiroshi Ioka

commit sha 49d0a512240cf96d5fad1e83a93a50f3ebb6f0aa

docs: add explanation for config

view details

push time in 13 days

push eventhirochachacha/jest-dynamodb

Hiroshi Ioka

commit sha 93e200f7db0f53b72a7b88f119e701bb67600361

docs: add explanation for config

view details

push time in 13 days

create barnchhirochachacha/jest-dynamodb

branch : docs/explain_config

created branch time in 13 days

pull request commentaws-amplify/amplify-cli

chore(cli): improve error message in readJsonFile

By the way, how can I run test inside packages/amplify-cli/tests ? Perhaps, the test setting is broken. Also I don't see defining utility functions on amplify context is the best idea. There're some places we cannot use the context. I can confirm that by find . -name '*.js' -or -name '*.ts' | grep -v 'node_modules' | grep -v 'chunk.js' | xargs grep 'JSON.parse'. Furthermore, ini and yaml need equal treatment. To define new package for utility functions might be better solution.

hirochachacha

comment created time in 13 days

push eventhirochachacha/amplify-cli

Hiroshi Ioka

commit sha 95422ebfc35611ddde15e3051aa0fdbbfc1267d1

chore(cli): improve error message in readJsonFile

view details

push time in 13 days

Pull request review commentaws-amplify/amplify-cli

chore(cli): improve error message in readJsonFile

 function stripBOM(content) {   return content; } +class JSONParseError extends Error {

Done

hirochachacha

comment created time in 13 days

push eventhirochachacha/amplify-cli

Attila Hajdrik

commit sha 9a517aaf7d23b5bf12b7513d5b0f79c086518f49

fix: handle @auth propagation for non-model nested types (#3223)

view details

Nikhil Lingireddy

commit sha 612574dea9e389c0f8dd1136a43495e09894a838

chore: bump min reqd version of cli in amplify-app (#3241)

view details

Yathi

commit sha 0cff7ed09bfaf797baad2acd1c0a6d013cb717e8

fix(amplify-appsync-simulator): support early return from resolvers (#2497) AppSync has support to return early from the resolver, if the template has #return statement. If the #return statement is executed in request mapping template, niether the invoker or response template is executed. If the #return statemnt is executed in an AppSync function, the function returns immediately with out executing the remaining template or data invoker. Update the mock impletentation to support this behavior fix #2427

view details

Scott Humphries

commit sha 107300ded9686ef4f1dd1d71c9a6605a129b97fb

feat(amplify-graphql-docs-generator):magic comment for syntax highlighting (#2706) Added magic comments in generated queries for syntax highlighting and Parsing

view details

Josue Ruiz

commit sha 33ef33b1daf33ac3f7702908239cbc17d2e1a21c

test(amplify-e2e-tests): use waitFor on bucket delection check (#3242) use waitFor when checking that bucket is deleted

view details

aws-amplify-bot

commit sha fabbe61d3010d24e28f44cfa93e5eb19f6f5bbad

chore(release): Publish [ci skip] - amplify-app@2.13.0 - amplify-appsync-simulator@1.13.0 - amplify-category-analytics@2.13.0 - amplify-category-api@2.13.0 - amplify-category-auth@2.13.0 - amplify-category-function@2.13.0 - amplify-category-hosting@2.1.8 - amplify-category-interactions@2.1.8 - amplify-category-notifications@2.13.0 - amplify-category-predictions@2.1.8 - amplify-category-storage@2.1.8 - amplify-category-xr@2.1.8 - @aws-amplify/cli@4.13.0 - amplify-codegen-appsync-model-plugin@1.13.0 - amplify-codegen@2.13.0 - amplify-dynamodb-simulator@1.13.0 - amplify-e2e-tests@2.13.0 - amplify-frontend-android@2.13.0 - amplify-frontend-ios@2.13.0 - amplify-frontend-javascript@2.13.0 - amplify-graphiql-explorer@1.1.8 - amplify-graphql-docs-generator@2.1.8 - amplify-graphql-types-generator@2.1.8 - amplify-provider-awscloudformation@4.13.0 - amplify-storage-simulator@1.1.8 - amplify-ui-tests@2.13.0 - amplify-util-mock@3.13.0 - amplify-velocity-template@1.1.8 - graphql-auth-transformer@6.13.0 - graphql-connection-transformer@4.13.0 - graphql-dynamodb-transformer@6.13.0 - graphql-elasticsearch-transformer@4.3.0 - graphql-function-transformer@2.1.8 - graphql-http-transformer@4.13.0 - graphql-key-transformer@2.13.0 - graphql-mapping-template@4.13.0 - graphql-predictions-transformer@2.1.8 - graphql-relational-schema-transformer@2.13.0 - graphql-transformer-common@4.13.0 - graphql-transformer-core@6.13.0 - graphql-transformers-e2e-tests@6.13.0 - graphql-versioned-transformer@4.13.0

view details

Josue Ruiz

commit sha f9473cf50bbcf43a701f1f44b6f4d451dc2be237

fix(amplify-category-api): edit auth workflow if cognito is not used (#3232) removes the fine grain auth schema option if aws cognito is not selected as an auth mode re #2967

view details

Attila Hajdrik

commit sha f48fefa31cb36846af2b029ecf3c0c7049937811

fix: non-model @auth propagation fails enums (#3252)

view details

Yathi

commit sha c5109baf5f9b47e91ab19bc5f5c7a0e4e3089adf

fix(amplify-codegen-appsync-model-plugin): fix typo in swift model gen (#3256)

view details

Attila Hajdrik

commit sha fd692e885962810ed9e6295899e24903413fe184

chore: update dependencies, remove unused packages, apply required test fixes (#3250) * chore: remove unused dependencies * chore: consolidate to single versions of deps * chore: update packages to latest version in most cases * fix: update snapshots and fix test * fix: hanging mock subscription tests * refactor(amplify-codegen-appsync-model-plugin): rebased master Co-authored-by: Josue Ruiz <josurui@amazon.com>

view details

aws-amplify-bot

commit sha a684439ad3367a8df6377c0b7fd897c7c0229a9c

chore(release): Publish [ci skip] - amplify-app@2.13.1 - amplify-appsync-simulator@1.13.1 - amplify-category-analytics@2.13.1 - amplify-category-api@2.13.1 - amplify-category-auth@2.13.1 - amplify-category-function@2.13.1 - amplify-category-hosting@2.1.9 - amplify-category-interactions@2.1.9 - amplify-category-notifications@2.13.1 - amplify-category-predictions@2.1.9 - amplify-category-storage@2.1.9 - amplify-category-xr@2.1.9 - @aws-amplify/cli@4.13.1 - amplify-codegen-appsync-model-plugin@1.13.1 - amplify-codegen@2.13.1 - amplify-dynamodb-simulator@1.13.1 - amplify-e2e-tests@2.13.1 - amplify-frontend-android@2.13.1 - amplify-frontend-ios@2.13.1 - amplify-frontend-javascript@2.13.1 - amplify-graphiql-explorer@1.1.9 - amplify-graphql-docs-generator@2.1.9 - amplify-graphql-types-generator@2.1.9 - amplify-provider-awscloudformation@4.13.1 - amplify-storage-simulator@1.1.9 - amplify-ui-tests@2.13.1 - amplify-util-mock@3.13.1 - amplify-velocity-template@1.1.9 - graphql-auth-transformer@6.13.1 - graphql-connection-transformer@4.13.1 - graphql-dynamodb-transformer@6.13.1 - graphql-elasticsearch-transformer@4.3.1 - graphql-function-transformer@2.1.9 - graphql-http-transformer@4.13.1 - graphql-key-transformer@2.13.1 - graphql-mapping-template@4.13.1 - graphql-predictions-transformer@2.1.9 - graphql-relational-schema-transformer@2.13.1 - graphql-transformer-common@4.13.1 - graphql-transformer-core@6.13.1 - graphql-transformers-e2e-tests@6.13.1 - graphql-versioned-transformer@4.13.1

view details

hirochachacha

commit sha 12eacbee29be477c197f3d4324f638ad951a5aae

chore: append eslint-disable to generated files (#3278) Fixes #3277

view details

Nikhil Lingireddy

commit sha 1c223503c93070e320eaab93a5783bce2d096e21

fix(amplify-graphql-types-generator): generate array return type (#3233) * fix(amplify-graphql-types-generator): generate array return type fix #2478 * fix: add test for array type

view details

Nikhil Lingireddy

commit sha 9ef1deb4583eb6c9c88cbced192a74b4a6a6a21c

fix: update snapshot for eslint (#3301)

view details

hirochachacha

commit sha 644e5cd65990e3da95e288510186817258b85a3a

docs: update Readme.md and LICENSE (#3276) * add env checkout command * add link to the contribution guide * fix markdown * update copyright year

view details

ammarkarachi

commit sha 6795e783c104004a2b2576f6903b35c1c6d2ed03

fix: falsy values can be returned in mock now (#3254) checking for undefined rather than falsy value of prevValue in pipeline resolvers fix #2566

view details

Benoît Bouré

commit sha 82f1d26aa12306bdb7d6fe635fd37b3ac7180d19

fix(amplify-velocity-template): #Return directive called several times (#3306)

view details

Edward Foyle

commit sha 1d01fb3ca26924c96a7964fa871edce9649016d7

fix(amplify-appsync-simulator): fixes #3202 filter error.data filter error.data based on graphql selection set as specified in appsync docs here: https://docs.aws.amazon.com/appsync/latest/devguide/resolver-util-reference.html

view details

Attila Hajdrik

commit sha 2a28d62e2d2f08e11335cb61e6fc45160cd65354

chore: Move to shared TypeScript config in projects where possible, standardize packages (#3315) * wip * wip * chore: fix remaining package files * fix: remaining test and imports

view details

Attila Hajdrik

commit sha 6e7348b40d6308fe0111ecc2dc85ae70f9e300d4

chore: fix amplify-cli structure (#3329)

view details

push time in 13 days

Pull request review commentaws-amplify/amplify-cli

chore(cli): improve error message in readJsonFile

 function stripBOM(content) {   return content; } +class JSONParseError extends Error {

It looks the same idea. https://github.com/sindresorhus/parse-json/blob/master/index.js https://github.com/zkat/json-parse-better-errors/blob/latest/index.js Anyway, I will.

hirochachacha

comment created time in 13 days

PR opened aws-amplify/amplify-cli

feat(amplify-graphql-types-generator): generate model types

Fixes #3323

  • accumulate return type of operation
  • accumulate object types, interface types and union types
  • generate object types, interface types and union types (for TypeScript)

This PR mainly handles TypeScript. Other frontends may have similary issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+2773 -86

0 comment

12 changed files

pr created time in 16 days

create barnchhirochachacha/amplify-cli

branch : feature/generate_model_types

created branch time in 16 days

issue openedaws-amplify/amplify-cli

generate model type

Note: If your feature-request is regarding the AWS Amplify Console service, please log it in the official AWS Amplify Console forum

Is your feature request related to a problem? Please describe.

type Blog @model {
  id: ID!
  name: String!
  posts: [Post] @connection(name: "BlogPosts")
}
type Post @model {
  id: ID!
  title: String!
  blog: Blog @connection(name: "BlogPosts")
  comments: [Comment] @connection(name: "PostComments")
}
type Comment @model {
  id: ID!
  content: String
  post: Post @connection(name: "PostComments")
}

generates:

src/API.ts in TypeScript.

However generated types aren't interchangeable each other.

src/typeCheck.ts:

import * as API from './API'

type CommentList1 = API.GetCommentQuery['getComment'][]
type CommentList2 = API.ListCommentsQuery['listComments']['items']
type CommentList3 = API.OnCreateCommentSubscription['onCreateComment'][]
type CommentList4 = API.GetPostQuery['getPost']['comments']['items']

let c1: CommentList1
let c2: CommentList2
let c3: CommentList3
let c4: CommentList4

c1 = c2
c1 = c3
c1 = c4

c2 = c1
c2 = c3
c2 = c4

c3 = c1
c3 = c2
c3 = c4

c4 = c1
c4 = c2
c4 = c3

then

$ tsc --noEmit src/typeCheck.ts
src/typeCheck.ts:13:1 - error TS2322: Type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; }; }[]' is not assignable to type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; blog: { __typename: "Blog"; id: string; name: string; }; comments: { __typename: "ModelCommentConnection"; nextToken: string; }; }; }[]'.
  Type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; }; }' is not assignable to type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; blog: { __typename: "Blog"; id: string; name: string; }; comments: { __typename: "ModelCommentConnection"; nextToken: string; }; }; }'.
    Types of property 'post' are incompatible.
      Type '{ __typename: "Post"; id: string; title: string; }' is missing the following properties from type '{ __typename: "Post"; id: string; title: string; blog: { __typename: "Blog"; id: string; name: string; }; comments: { __typename: "ModelCommentConnection"; nextToken: string; }; }': blog, comments

13 c1 = c2
   ~~

src/typeCheck.ts:15:1 - error TS2322: Type '{ __typename: "Comment"; id: string; content: string; }[]' is not assignable to type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; blog: { __typename: "Blog"; id: string; name: string; }; comments: { __typename: "ModelCommentConnection"; nextToken: string; }; }; }[]'.
  Property 'post' is missing in type '{ __typename: "Comment"; id: string; content: string; }' but required in type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; blog: { __typename: "Blog"; id: string; name: string; }; comments: { __typename: "ModelCommentConnection"; nextToken: string; }; }; }'.

15 c1 = c4
   ~~

  src/API.ts:500:5
    500     post:  {
            ~~~~
    'post' is declared here.

src/typeCheck.ts:19:1 - error TS2322: Type '{ __typename: "Comment"; id: string; content: string; }[]' is not assignable to type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; }; }[]'.
  Property 'post' is missing in type '{ __typename: "Comment"; id: string; content: string; }' but required in type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; }; }'.

19 c2 = c4
   ~~

  src/API.ts:530:7
    530       post:  {
              ~~~~
    'post' is declared here.

src/typeCheck.ts:22:1 - error TS2322: Type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; }; }[]' is not assignable to type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; blog: { __typename: "Blog"; id: string; name: string; }; comments: { __typename: "ModelCommentConnection"; nextToken: string; }; }; }[]'.
  Type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; }; }' is not assignable to type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; blog: { __typename: "Blog"; id: string; name: string; }; comments: { __typename: "ModelCommentConnection"; nextToken: string; }; }; }'.
    Types of property 'post' are incompatible.
      Type '{ __typename: "Post"; id: string; title: string; }' is missing the following properties from type '{ __typename: "Post"; id: string; title: string; blog: { __typename: "Blog"; id: string; name: string; }; comments: { __typename: "ModelCommentConnection"; nextToken: string; }; }': blog, comments

22 c3 = c2
   ~~

src/typeCheck.ts:23:1 - error TS2322: Type '{ __typename: "Comment"; id: string; content: string; }[]' is not assignable to type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; blog: { __typename: "Blog"; id: string; name: string; }; comments: { __typename: "ModelCommentConnection"; nextToken: string; }; }; }[]'.
  Property 'post' is missing in type '{ __typename: "Comment"; id: string; content: string; }' but required in type '{ __typename: "Comment"; id: string; content: string; post: { __typename: "Post"; id: string; title: string; blog: { __typename: "Blog"; id: string; name: string; }; comments: { __typename: "ModelCommentConnection"; nextToken: string; }; }; }'.

23 c3 = c4
   ~~

  src/API.ts:674:5
    674     post:  {
            ~~~~
    'post' is declared here.


Found 5 errors.

I hit the problem when I tried to use comment list and comment subscription together.

Current workaround is creating model types manually.

export type Blog = {
  __typename: "Blog",
  id: string,
  name: string,
  posts?: ModelPostConnection | null,
};

export type ModelPostConnection = {
  __typename: "ModelPostConnection",
  items?: Array< Post | null > | null,
  nextToken?: string | null,
};

export type Post = {
  __typename: "Post",
  id: string,
  title: string,
  blog?: Blog | null,
  comments?: ModelCommentConnection | null,
};

export type ModelCommentConnection = {
  __typename: "ModelCommentConnection",
  items?: Array< Comment | null > | null,
  nextToken?: string | null,
};

export type Comment = {
  __typename: "Comment",
  id: string,
  content?: string | null,
  post?: Post | null,
};

// test code

type CommentList = Comment[]

let c: CommentList

c = c1
c = c2
c = c3
c = c4

I'd say these types should be automatically generated by amplify-cli.

Describe the solution you'd like

generate model types.

Describe alternatives you've considered

I have no other ideas.

Additional context

created time in 16 days

create barnchhirochachacha/jest-dynamodb

branch : feature/add_installer_config

created branch time in 19 days

fork hirochachacha/jest-dynamodb

Jest preset for DynamoDB local server

fork in 19 days

issue commentaws-amplify/amplify-cli

reusing an existing ID field in a connection leads to error: All fields provided to an @connection must be non-null scalar or enum fields.

Oh, sorry for misreading. If I understand correctly, you pointed that @key and @connection have inconsistency - @key accepts nullable fields, on the other hand @connection rejects nullable fields. That's not dup of #1657.

AndreasEK

comment created time in 22 days

push eventhirochachacha/graphql-auto-transformer

Hiroshi Ioka

commit sha e032d0b3f6e882f6d44455911cd822702099022e

v1.1.2

view details

Hiroshi Ioka

commit sha 2af63a2d7961c6b5b67c06ef639b95c0b27a5c5c

setup files property

view details

Hiroshi Ioka

commit sha 6ed5e9fdb7e0e79c2089b65b2ad5f29eb4212bee

v1.1.3

view details

Hiroshi Ioka

commit sha 70cf8d0bcfb0418b6076b00416c7310f4a68559c

update README.md

view details

push time in 22 days

push eventhirochachacha/amplify-cli

Hiroshi Ioka

commit sha 1157b61970be61a75248ae93f18d492f9e4f7d16

chore: append eslint-disable to generated files Fixes #3277

view details

push time in 23 days

PR opened aws-amplify/amplify-cli

chore: append eslint-disable to generated files

Fixes #3277

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+2 -0

0 comment

2 changed files

pr created time in 23 days

issue openedaws-amplify/amplify-cli

eslint doesn't ignore generated files

Note: If your feature-request is regarding the AWS Amplify Console service, please log it in the official AWS Amplify Console forum

Is your feature request related to a problem? Please describe.

generated files include /* tslint:disable */. It should include /* eslint-disable */ also.

Describe the solution you'd like

append /* eslint-disable */

Describe alternatives you've considered

Additional context

created time in 23 days

PR opened aws-amplify/amplify-cli

docs: update Readme.md and LICENSE
  • add env checkout command
  • add link to the contribution guide
  • fix markdown
  • update copyright year

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+32 -30

0 comment

2 changed files

pr created time in 23 days

create barnchhirochachacha/amplify-cli

branch : docs/update_readme

created branch time in 23 days

PR opened aws-amplify/docs

Mention that group authorization is available for oidc
+4 -4

0 comment

1 changed file

pr created time in 23 days

create barnchhirochachacha/docs

branch : oidc

created branch time in 23 days

pull request commentdocker/compose

add --skip-env-file option

It looks like docker-compose team made a great decision. https://github.com/docker/compose/pull/7150 Since it changes some semantics, perhaps it comes with major version up?

hirochachacha

comment created time in 25 days

Pull request review commentaws-amplify/amplify-cli

chore(cli): improve error message in readJsonFile

 function stripBOM(content) {   return content; } +class JSONParseError extends Error {

Could you give me more specific suggestion? I grepped packages/amplify-cli and I saw there is only one custom error class definition. Are you suggesting that throwing generic error is good enough like throw new Error("message")?

hirochachacha

comment created time in a month

Pull request review commentaws-amplify/amplify-cli

chore(cli): improve error message in readJsonFile

 const fs = require('fs-extra');+const os = require('os');++const posPattern = /at position (\d+)$/;

Implementation level: Yes

https://github.com/nodejs/node/blob/32e7e813e93ec3d0625d315658288769e448dd99/deps/v8/src/common/message-template.h#L424-L427 https://github.com/nodejs/node/blob/32e7e813e93ec3d0625d315658288769e448dd99/deps/v8/src/json/json-parser.cc#L251-L266

Specification level: No, I guess not.

I think providing line number and column number is ideal, but providing only filename is still good enough. If we want to show line and column seriously, we need to use or create custom JSON parser like https://www.npmjs.com/package/jsonlint.

hirochachacha

comment created time in a month

pull request commentaws-amplify/amplify-cli

chore(cli): improve error message in readJsonFile

@SwaySway

View our contributing guidelines here: https://github.com/aws-amplify/amplify-cli/blob/master/CONTRIBUTING.md

I wasn't aware that guide. Probably https://github.com/aws-amplify/amplify-cli#contributing shadows that guide.

hirochachacha

comment created time in a month

pull request commentaws-amplify/amplify-cli

support lambda layer

rebased. I did git pull --rebase origin pull/3255/head and git pull --rebase origin master. Because test is broken currently. https://github.com/aws-amplify/amplify-cli/pull/3255

hirochachacha

comment created time in a month

push eventhirochachacha/amplify-cli

Yathi

commit sha c5109baf5f9b47e91ab19bc5f5c7a0e4e3089adf

fix(amplify-codegen-appsync-model-plugin): fix typo in swift model gen (#3256)

view details

Nikhil Lingireddy

commit sha b5e3746e58d2f3c299cbeb19a13298bb7f6a2afc

fix(amplify-velocity-template): fix return value test remove whitespace

view details

Hiroshi Ioka

commit sha 201bf00c0f268b08cad20328786e51bc1a25501c

feat: allow flexible assets The CL allows user to support lambda layer manually. Update #703

view details

Hiroshi Ioka

commit sha f4f03d892a7f602f1578f9a777e8f5b472e4916a

feat: add new package amplify-category-layer

view details

Hiroshi Ioka

commit sha 4f58c1c82132c732dee725e65cf3636dbde0d6b3

feat: add prompt for layer support Fixes #703

view details

Hiroshi Ioka

commit sha b363790a2eedf02d9b700c1c0baa84254acccfff

chore: add e2e test for layer

view details

push time in a month

push eventhirochachacha/amplify-cli

Yathi

commit sha 9c5b7e931e8382fe744516dee35a1aa545a91a97

fix(amplify-codegen-appsync-model-plugin): support non-codeable types (#3226) fixed iOS model gen to handle non-codeable type arrays to use [] instead of List<> type fix #3035

view details

UnleashedMind

commit sha cbe26e01c657031e73b77fe408e53430029cab17

fix(cli): fix console issue 342 and 350 (#3189) * fix(cli): fix console issue 342 * minor text fix * fix console issue #350

view details

UnleashedMind

commit sha 6a35a5c8fadc4dbc5c38b82d007cd0cc240afe00

fix(amplify-provider-awscloudformation): add condition for migration (#3196) Add check on if a project is fully setup for the amplify service migraiton logic

view details

James George

commit sha 8c3cd9d3c9adb8e83d94ee4e339f34f45d65d40b

refactor(amplify-app): Eliminate code redundancy (#3159) * refactor: make use of object destructuring possibilities * refactor: eliminate code redundancy * fix: lint

view details

kevcam4891

commit sha e15d994fcd2e7c136932845a9e772a9546d48b73

fix: remove extra curly brace in CLI output (#3194) CLI reads: Amplify AppID found: xxx. Amplify App name is: name} The brace was used in JS to interpolate the string, but one too many left one being printed for no reason. Removing.

view details

kevcam4891

commit sha 0ded9bae7e58c689608ec69612f532f029a964e2

docs: update link for how to write custom transformer (#3203)

view details

Yathi

commit sha 3a5e43a4a5392c5bbe3cce1b5d4c7f793ca14273

fix(cli): disable ESM cache (#3230) ESM cache gets out of sync and causes hard to diagnose issue like the ones reported in #3199. Disabling the caching fix #3199

view details

Attila Hajdrik

commit sha 9a517aaf7d23b5bf12b7513d5b0f79c086518f49

fix: handle @auth propagation for non-model nested types (#3223)

view details

Nikhil Lingireddy

commit sha 612574dea9e389c0f8dd1136a43495e09894a838

chore: bump min reqd version of cli in amplify-app (#3241)

view details

Yathi

commit sha 0cff7ed09bfaf797baad2acd1c0a6d013cb717e8

fix(amplify-appsync-simulator): support early return from resolvers (#2497) AppSync has support to return early from the resolver, if the template has #return statement. If the #return statement is executed in request mapping template, niether the invoker or response template is executed. If the #return statemnt is executed in an AppSync function, the function returns immediately with out executing the remaining template or data invoker. Update the mock impletentation to support this behavior fix #2427

view details

Scott Humphries

commit sha 107300ded9686ef4f1dd1d71c9a6605a129b97fb

feat(amplify-graphql-docs-generator):magic comment for syntax highlighting (#2706) Added magic comments in generated queries for syntax highlighting and Parsing

view details

Josue Ruiz

commit sha 33ef33b1daf33ac3f7702908239cbc17d2e1a21c

test(amplify-e2e-tests): use waitFor on bucket delection check (#3242) use waitFor when checking that bucket is deleted

view details

aws-amplify-bot

commit sha fabbe61d3010d24e28f44cfa93e5eb19f6f5bbad

chore(release): Publish [ci skip] - amplify-app@2.13.0 - amplify-appsync-simulator@1.13.0 - amplify-category-analytics@2.13.0 - amplify-category-api@2.13.0 - amplify-category-auth@2.13.0 - amplify-category-function@2.13.0 - amplify-category-hosting@2.1.8 - amplify-category-interactions@2.1.8 - amplify-category-notifications@2.13.0 - amplify-category-predictions@2.1.8 - amplify-category-storage@2.1.8 - amplify-category-xr@2.1.8 - @aws-amplify/cli@4.13.0 - amplify-codegen-appsync-model-plugin@1.13.0 - amplify-codegen@2.13.0 - amplify-dynamodb-simulator@1.13.0 - amplify-e2e-tests@2.13.0 - amplify-frontend-android@2.13.0 - amplify-frontend-ios@2.13.0 - amplify-frontend-javascript@2.13.0 - amplify-graphiql-explorer@1.1.8 - amplify-graphql-docs-generator@2.1.8 - amplify-graphql-types-generator@2.1.8 - amplify-provider-awscloudformation@4.13.0 - amplify-storage-simulator@1.1.8 - amplify-ui-tests@2.13.0 - amplify-util-mock@3.13.0 - amplify-velocity-template@1.1.8 - graphql-auth-transformer@6.13.0 - graphql-connection-transformer@4.13.0 - graphql-dynamodb-transformer@6.13.0 - graphql-elasticsearch-transformer@4.3.0 - graphql-function-transformer@2.1.8 - graphql-http-transformer@4.13.0 - graphql-key-transformer@2.13.0 - graphql-mapping-template@4.13.0 - graphql-predictions-transformer@2.1.8 - graphql-relational-schema-transformer@2.13.0 - graphql-transformer-common@4.13.0 - graphql-transformer-core@6.13.0 - graphql-transformers-e2e-tests@6.13.0 - graphql-versioned-transformer@4.13.0

view details

Josue Ruiz

commit sha f9473cf50bbcf43a701f1f44b6f4d451dc2be237

fix(amplify-category-api): edit auth workflow if cognito is not used (#3232) removes the fine grain auth schema option if aws cognito is not selected as an auth mode re #2967

view details

Attila Hajdrik

commit sha f48fefa31cb36846af2b029ecf3c0c7049937811

fix: non-model @auth propagation fails enums (#3252)

view details

Nikhil Lingireddy

commit sha d0f5ed38f7c23baf5e19b3d6e1b641cd35bbcd62

fix(amplify-velocity-template): fix return value test remove whitespace

view details

Yathi

commit sha 3fad9e4f353782df7da1a19d2aaa38e70c5d22ae

fix(amplify-codegen-appsync-model-plugin): fix typo in swift model gen (#3256)

view details

Hiroshi Ioka

commit sha f43831021edc5086aa02b66215dc9a63eaa6be69

feat: allow flexible assets The CL allows user to support lambda layer manually. Update #703

view details

Hiroshi Ioka

commit sha badb5f9e17836a925aa22142607fc74e1735d4d5

feat: add new package amplify-category-layer

view details

Hiroshi Ioka

commit sha 68fc629120fae38aa7af49594ed25714fad02482

feat: add prompt for layer support Fixes #703

view details

push time in a month

push eventhirochachacha/amplify-cli

Hiroshi Ioka

commit sha 976ae27f6c90f025399b66e406a5f7e3bcd1f4fb

fix(amplify-category-function): fix typo

view details

push time in a month

Pull request review commentaws-amplify/amplify-cli

support lambda layer

 async function openEditor(context, category, options) { async function invoke(context, category, service, resourceName) {   const { amplify } = context;   serviceMetadata = amplify.readJsonFile(`${__dirname}/../supported-services.json`)[service];-  const { inputs } = serviceMetadata;+  const { inputs: rawInputs } = serviceMetadata;+  const inputs = {};+  rawInputs.forEach(input => {+    inputs[input.key] = input;+  });+  const { handlerFilename, handlerName, eventName } = input;

Yes, indeed. Thank you for your detailed review.

hirochachacha

comment created time in a month

pull request commentaws-amplify/amplify-cli

fix(amplify-provider-awscloudformation): custom transformer imports

https://github.com/nodejs/node/blob/dcba12895ad58275ba5b027c2c5110461dfebf66/lib/internal/modules/cjs/loader.js#L1263-L1268

hirochachacha

comment created time in a month

pull request commentaws-amplify/amplify-cli

fix(amplify-provider-awscloudformation): custom transformer imports

@attilah I tried to use my custom transformer.

  1. yarn add -D graphql-auto-transformer
  2. edit amplify/backend/api/<YOUR_API>/transform.conf
    "transformers": [
      "./graphql-auto-transformer"
    ]
  1. amplify-dev api gql-compile

Then I saw

Error: Cannot find module 'graphql-auto-transformer'

The following code is a short summary of current implementation.

require('module').createRequireFromPath(__dirname)("./graphql-auto-transformer")

You can check that this line of code cannot load graphql-auto-transformer from node_modules.

And next one is proposed solution.

require('module').createRequireFromPath(`${__dirname}/noop.js`)('graphql-auto-transformer');
hirochachacha

comment created time in a month

push eventhirochachacha/amplify-cli

Hiroshi Ioka

commit sha 177f12a28eb6fe273a3fddf47fa6469b0057a2ce

fix(amplify-provider-awscloudformation): custom transformer imports Current implementation misuses createRequireFromPath API. Unfortunately this API doesn't support directory path well. For example, ``` createRequireFromPath("/my/project")("./node_modules/mylib") ``` isn't same as ``` require("/my/project/node_modules/mylib") ``` Actually, it's ``` require("/my/node_modules/mylib") ```

view details

push time in a month

issue commentaws-amplify/amplify-cli

using createdAt as a sortKey in @key directive results mandatory id and createdAt fields in CreateItemInput and CreateItem mutation in GraphQL Transform

It turned out that amplify's import mechanism is broken. https://github.com/aws-amplify/amplify-cli/pull/3236 So above approach doesn't work right now.

iselcuk

comment created time in a month

push eventhirochachacha/amplify-cli

Hiroshi Ioka

commit sha c8e93ff4180248b1cc4dc413d7b9dd78b50d4464

fix(amplify-provider-awscloudformation): custom transformer imports Current implementation misuses createRequireFromPath API. Unfortunately this API doesn't support directory path well. For example, ``` createRequireFromPath("/my/project")("./node_modules/mylib") ``` isn't same as ``` require("/my/project/node_modules/mylib") ``` Actually, it's ``` require("/my/node_modules/mylib") ```

view details

push time in a month

pull request commentaws-amplify/amplify-cli

fix(amplify-provider-awscloudformation): custom transformer imports

I think this issue is important one. It's difficult to add custom transformers without this change

hirochachacha

comment created time in a month

Pull request review commentaws-amplify/amplify-cli

fix(amplify-provider-awscloudformation): custom transformer imports

 function getTransformerFactory(context, resourceDir, authConfig) {         let importedModule;         const tempModulePath = modulePath.toString(); +        console.log('tempModulePath', tempModulePath);+         try {           if (path.isAbsolute(tempModulePath)) {             // Load it by absolute path             importedModule = require(modulePath);           } else {+            // 'require' from project path             const projectRootPath = context.amplify.pathManager.searchProjectRootPath();             const { createRequireFromPath } = require('module');-            const projectRequire = createRequireFromPath(projectRootPath);--            if (tempModulePath.startsWith('./')) {

It seems that there is no concept like global require and local require. module.paths is calculated by caller's path and NODE_PATH. https://stackoverflow.com/questions/15636367/nodejs-require-a-global-module-package

hirochachacha

comment created time in a month

push eventhirochachacha/amplify-cli

Hiroshi Ioka

commit sha 445587be6493a8745742c466bab5e9cbee4dfe24

fix(amplify-provider-awscloudformation): custom transformer imports Current implementation misuses createRequireFromPath API. Unfortunately this API doesn't support directory path well. For example, ``` createRequireFromPath("/my/project")("./node_modules/mylib") ``` isn't same as ``` require("/my/project/node_modules/mylib") ``` Actually, it's ``` require("/my/node_modules/mylib") ```

view details

push time in a month

PR opened aws-amplify/amplify-cli

fix(amplify-provider-awscloudformation): custom transformer imports

Current implementation misuses createRequireFromPath API. Unfortunately this API doesn't support directory path well.

For example,

createRequireFromPath("/my/project")("./node_modules/mylib")

isn't same as

require("/my/project/node_modules/mylib")

Actually, it's

require("/my/node_modules/mylib")

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+4 -2

0 comment

1 changed file

pr created time in a month

create barnchhirochachacha/amplify-cli

branch : fix/custom_transformer_imports

created branch time in a month

PR opened aws-amplify/amplify-cli

chore(cli): improve error message in readJsonFile

Issue #, if available:

I'm tired to see useless error messages like SyntaxError: Unexpected token } in JSON at position 6

This CL improves error messaage like following:

JSONParseError: some.json:3:2: Unexpected token } in JSON at position 6

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+81 -5

0 comment

2 changed files

pr created time in a month

push eventhirochachacha/graphql-auto-transformer

Hiroshi Ioka

commit sha 58992c92b7260e34aa197304e5f3c3470927bbfc

v1.1.1

view details

push time in a month

push eventhirochachacha/graphql-auto-transformer

hirochachacha

commit sha 21f94ef81c3c4d128e4e3529a252011e67dd33ca

Create nodejs.yml

view details

push time in a month

delete branch hirochachacha/graphql-auto-transformer

delete branch : hirochachacha-patch-1

delete time in a month

push eventhirochachacha/graphql-auto-transformer

hirochachacha

commit sha 2e3f9362fff6a517733713ab511664b2f8563e57

Create nodejs.yml

view details

push time in a month

create barnchhirochachacha/graphql-auto-transformer

branch : hirochachacha-patch-1

created branch time in a month

push eventhirochachacha/amplify-cli

Attila Hajdrik

commit sha 30ecb495a9198e70f4630d7a975c14b2afcbd1b1

chore: Consolidate linting to eslint (#3195) * chore: eslint cleanup wip * chore: eslint rules completion to make eslint pass for existing code * chore: add tslint rules and temporary disabled rules to make it line * fix: failing s3 simulator code because of lint update

view details

Yathi

commit sha 77bec1df49a32f030e9e5a06651003409da00eb9

fix(amplify-appsync-simulator): make resolver result parsing strict (#3224) updated the appsync resolver parsing to use plain JSON parse instead of using JSON5 which is a looser spec fix #3180

view details

Josue Ruiz

commit sha f81ea329f47194fbc19eb966cacee9877e04a389

fix(graphql-elasticsearch-transformer): allow range on searches (#3129) * fix(graphql-elasticsearch-transformer): allow range on searches allows the use of lt lte gt gte on @searchable re #2775 * test(graphql-transformers-e2e-tests): add lte and gte on string range add lte gte on searchable string range e2e test

view details

Hiroshi Ioka

commit sha 9a7dc85fbb95c236d3d8c1c0553304990f64b74c

feat: allow flexible assets The CL allows user to support lambda layer manually. Update #703

view details

Hiroshi Ioka

commit sha f6fa0e4063ccbd9cadfe0ac1deb73c183e111660

feat: add new package amplify-category-layer

view details

Hiroshi Ioka

commit sha d93a63cf9761fb8a7f1fa47002026f40320d4d90

feat: add prompt for layer support Fixes #703

view details

Hiroshi Ioka

commit sha e1d1060bc800136a1b6c9f48f5fdc1badfe2b931

chore: add e2e test for layer

view details

push time in a month

push eventhirochachacha/amplify-cli

Yathi

commit sha a565053463e563ed3d44f1405ab551520e0cd818

fix(amplify-codegen): replace upath with slash (#3133) Replaced upath lib with slash, as updath does not work with latest version of node fix #3131

view details

Yathi

commit sha 33fc92578a9124a4d1b669039dc09dc737bd36c8

fix(amplify-appsync-simulator): set max payload size for request (#3132) set the body size limit to 10MB fix #3086

view details

UnleashedMind

commit sha b25105c4f4417c21075f92004cd4a6c19aa61a87

fix(cli): fix postinit invokation (#3130) fix #2642

view details

ammarkarachi

commit sha fc4577874579ad12a12e9b693e62a2bd88144335

fix: delete hangs for a bit before exiting (#2979) * feat(cli): collecting crash reports * Revert "feat: Delete all (#2615)" This reverts commit 54676797b913d4a2c284c62244c8ccf8e55a44d8. * Revert "feat(cli): collecting crash reports" This reverts commit 00cf4960cb2410ef5eca02073a7fbad1641bf914. * Revert "Revert "feat: Delete all (#2615)"" This reverts commit 2797e0da2eacdce923dfff97e497c2db4941488d. * fix(amplify-provider-awscloudformation): fix for hanging deletes Make deleteing of the s3 buckets delete after deleting the stack

view details

ammarkarachi

commit sha 182f36c391cf872397373f05e1a017b3c4bb2ee1

chore(release): Publish [ci skip] (#3156) - amplify-app@2.12.0 - amplify-appsync-simulator@1.12.0 - amplify-category-analytics@2.12.0 - amplify-category-api@2.12.0 - amplify-category-auth@2.12.0 - amplify-category-function@2.12.0 - amplify-category-hosting@2.1.7 - amplify-category-interactions@2.1.7 - amplify-category-notifications@2.12.0 - amplify-category-predictions@2.1.7 - amplify-category-storage@2.1.7 - amplify-category-xr@2.1.7 - @aws-amplify/cli@4.12.0 - amplify-codegen-appsync-model-plugin@1.12.0 - amplify-codegen@2.12.0 - amplify-dynamodb-simulator@1.12.0 - amplify-e2e-tests@2.12.0 - amplify-frontend-android@2.12.0 - amplify-frontend-ios@2.12.0 - amplify-frontend-javascript@2.12.0 - amplify-graphiql-explorer@1.1.7 - amplify-graphql-docs-generator@2.1.7 - amplify-graphql-types-generator@2.1.7 - amplify-provider-awscloudformation@4.12.0 - amplify-storage-simulator@1.1.7 - amplify-ui-tests@2.12.0 - amplify-util-mock@3.12.0 - amplify-velocity-template@1.1.7 - graphql-auth-transformer@6.12.0 - graphql-connection-transformer@4.12.0 - graphql-dynamodb-transformer@6.12.0 - graphql-elasticsearch-transformer@4.2.0 - graphql-function-transformer@2.1.7 - graphql-http-transformer@4.12.0 - graphql-key-transformer@2.12.0 - graphql-mapping-template@4.12.0 - graphql-predictions-transformer@2.1.7 - graphql-relational-schema-transformer@2.12.0 - graphql-transformer-common@4.12.0 - graphql-transformer-core@6.12.0 - graphql-transformers-e2e-tests@6.12.0 - graphql-versioned-transformer@4.12.0

view details

Josue Ruiz

commit sha 61c0769cb1d40faa76ff3de8e82f2f58199b4a0f

fix: point to correct file to delete for amplify config (#3116) * fix: point to correct file in delete amplify config point to aws exporsts in js deleteConfig and include amplify configuration in the delete for android and ios re #2997 * test(amplify-e2e-tests): check for deleted configs in delete e2e check for deleted config based on the type of app that is built android/ios/js

view details

UnleashedMind

commit sha 4fb26498c6eb266ffe11bdb276f5e91a46f1f65d

fix(amplify-provider-awscloudformation): fix add env learn more bug (#3164) * fix(amplify-provider-awscloudformation): fix add env learn more bug fix #3158 * fix text

view details

Attila Hajdrik

commit sha a8cdac5aabc3bf7cc2457b1cd0d454b6e4e4bfa2

chore: update to latest graphql.js package (#3150) * fix: update graphqljs to latest version * fix: add back repeatable that was removed somehow * fix: add back repeatable that was removed somehow

view details

ammarkarachi

commit sha 1a1efcfe9ba11242316ebed3bca3bf5fe78761f7

fix(amplify-category-analytics): reverted the hyphen and updated tests (#3181) * fix(amplify-category-analytics): reverted the hyphen and updated tests The hyphens are not allowed when pushing and had to revert it back fix #3163 * test(amplify-e2e-tests): fixing the misplaced boolean

view details

swyx

commit sha 621b5f19d8afc0f6bb1f6e20f89fc40af34c1299

add amplify pull docs (#3126)

view details

hirochachacha

commit sha 741eedb0fd5ebeefa32c0640d1585a828e244eae

feat(graphql-auth-transformer): enable groups authentication for oidc (#2719)

view details

Josue Ruiz

commit sha c855fbd0fe75ceaae1e78449c3636bec0c44a438

test(amplify-e2e-tests): added missing src extension (#3208)

view details

Yathi

commit sha c9a6ada683a32f2a82ef9fdc4b0cb37ea70ccb11

fix: pass appsync specific directives to model gen (#3211) AppSync service has some custom directives defined in the service. These directives are defiend in transformer, so the documents that have them pass graphql validation. Passing them to model gen plugin from transformer to keep these directives in sync

view details

hirochachacha

commit sha c9885650f99021bf5d83d52a700e62e4a2acea50

Merge branch 'master' into feature/add_amplify-category-layer

view details

push time in a month

PR opened aws-amplify/amplify-cli

Fixes #703

Follow-up PR of https://github.com/aws-amplify/amplify-cli/pull/3135

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+800 -212

0 comment

26 changed files

pr created time in a month

create barnchhirochachacha/amplify-cli

branch : feature/add_amplify-category-layer

created branch time in a month

push eventhirochachacha/graphql-auto-transformer

Hiroshi Ioka

commit sha ca4c08ae4877e3589fa65073f809c51d077e6331

update README.md

view details

push time in a month

push eventhirochachacha/graphql-auto-transformer

Hiroshi Ioka

commit sha 0ffbf1479084b6f633cc1dbc53d05fc8ec823a42

fix export

view details

Hiroshi Ioka

commit sha de2ac1f39c7bd704d892a8fa1073f1733e04fb96

v1.1.0

view details

push time in a month

PR opened aws-amplify/amplify-cli

feat: support arbitary command hooks

Current implementation support hooks for only two commands - amplify init and amplify push. It's not good enough for plugin developers.

For example, if someone want to checkout own configuration file per environment, (like https://github.com/aws-amplify/amplify-cli/issues/2670) they probably need to handle not only amplify init, but also amplify pull, amplify env add, amplify env checkout and amplify env pull.

This CL allows to implement such features.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+41 -62

0 comment

3 changed files

pr created time in a month

issue commentaws-amplify/amplify-cli

using createdAt as a sortKey in @key directive results mandatory id and createdAt fields in CreateItemInput and CreateItem mutation in GraphQL Transform

Usage:

type Item @model @key(fields: ["id", "createdAt"]){
    id: ID!
    createdAt: String! @auto
}
iselcuk

comment created time in a month

issue commentaws-amplify/amplify-cli

using createdAt as a sortKey in @key directive results mandatory id and createdAt fields in CreateItemInput and CreateItem mutation in GraphQL Transform

I've created https://github.com/hirochachacha/graphql-auto-transformer for solving these kinds of problems.

iselcuk

comment created time in a month

delete branch hirochachacha/amplify-cli

delete branch : fix/make_validation_permissive_on_connection_directive

delete time in a month

pull request commentaws-amplify/amplify-cli

fix(graphql-connection-transformer): make validation permissive

Thank you for your advice. I've created https://github.com/hirochachacha/graphql-auto-transformer which should solve https://github.com/aws-amplify/amplify-cli/issues/1657 too.

hirochachacha

comment created time in a month

push eventhirochachacha/graphql-auto-transformer

Hiroshi Ioka

commit sha 7abce1af383d35356166fe0f95927ecae739ae5d

update package.json

view details

Hiroshi Ioka

commit sha e2a7d968cbeffb5587addeee5a02742ee7462728

v1.0.2

view details

push time in a month

create barnchhirochachacha/graphql-auto-transformer

branch : master

created branch time in a month

created repositoryhirochachacha/graphql-auto-transformer

created time in a month

Pull request review commentDefinitelyTyped/DefinitelyTyped

types/react-stripe-elements: simplify StripeProps

 //                 Hiroshi Ioka <https://github.com/hirochachacha> //                 Austin Turner <https://github.com/paustint> // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped-// TypeScript Version: 2.8+// TypeScript Version: 3.5

Thank you for the review.

Omit was introduced since 3.5. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-5.html

That being said, we can define Omit by ourselves.

type Omit<T, K> = Pick<T, Exclude<keyof T, K>>;

Either is fine with me. If you think keeping the version is beneficial, I'll follow the advice.

hirochachacha

comment created time in a month

push eventhirochachacha/amplify-cli

Hiroshi Ioka

commit sha b096b08f05cf9a1050285ad46206bd0e5ca5c2ab

feat: allow flexible assets The CL allows user to support lambda layer manually. Update #703

view details

push time in a month

PR opened aws-amplify/amplify-cli

feat: allow flexible assets

Update #703

The CL allows users to support lambda layer manually.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+78 -34

0 comment

3 changed files

pr created time in a month

create barnchhirochachacha/amplify-cli

branch : feature/conform_to_asset_meta_tag

created branch time in a month

more