pull request commentfacebookexperimental/MIRAI

Special case paths to fields of structs that looks like fat pointers

Codecov Report

Merging #736 (814b959) into master (03f69e9) will decrease coverage by 0%. The diff coverage is 50%.

@@          Coverage Diff           @@
##           master    #736   +/-   ##
======================================
- Coverage      41%     41%   -1%     
======================================
  Files          22      22           
  Lines       12881   12889    +8     
  Branches     5766    5770    +4     
======================================
+ Hits         5393    5396    +3     
+ Misses       3159    3152    -7     
- Partials     4329    4341   +12

Impacted Files	Coverage Δ
checker/src/block_visitor.rs	`40% <33%> (+<1%)`	:arrow_up:
checker/src/callbacks.rs	`57% <100%> (+<1%)`	:arrow_up:
checker/src/path.rs	`46% <0%> (-1%)`	:arrow_down:
checker/src/abstract_value.rs	`37% <0%> (-1%)`	:arrow_down:
checker/src/environment.rs	`44% <0%> (ø)`
checker/src/constant_domain.rs	`39% <0%> (ø)`
checker/src/type_visitor.rs	`59% <0%> (+<1%)`	:arrow_up:
checker/src/expected_errors.rs	`50% <0%> (+1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac70b9e...814b959. Read the comment docs.

hermanventer

comment created time in 2 days

pull request commentfacebookexperimental/MIRAI

Fill in more atomic operation contracts

Codecov Report

Merging #735 (c5c59cb) into master (0732afb) will increase coverage by 0%. The diff coverage is 44%.

@@          Coverage Diff           @@
##           master    #735   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12848   12882   +34     
  Branches     5747    5766   +19     
======================================
+ Hits         5374    5392   +18     
- Misses       3161    3162    +1     
- Partials     4313    4328   +15

Impacted Files	Coverage Δ
checker/src/block_visitor.rs	`40% <42%> (+<1%)`	:arrow_up:
checker/src/callbacks.rs	`56% <100%> (+<1%)`	:arrow_up:
checker/src/expected_errors.rs	`49% <0%> (-2%)`	:arrow_down:
checker/src/abstract_value.rs	`37% <0%> (-1%)`	:arrow_down:
checker/src/constant_domain.rs	`39% <0%> (ø)`
checker/src/path.rs	`46% <0%> (+<1%)`	:arrow_up:
checker/src/known_names.rs	`69% <0%> (+<1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03f69e9...c5c59cb. Read the comment docs.

hermanventer

comment created time in 2 days

pull request commentfacebookexperimental/MIRAI

Add support for drop handlers

Codecov Report

Merging #734 (8bb3e31) into master (0732afb) will increase coverage by 0%. The diff coverage is 42%.

@@          Coverage Diff           @@
##           master    #734   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12848   12881   +33     
  Branches     5747    5766   +19     
======================================
+ Hits         5374    5391   +17     
+ Misses       3161    3157    -4     
- Partials     4313    4333   +20

Impacted Files	Coverage Δ
checker/src/block_visitor.rs	`40% <42%> (+<1%)`	:arrow_up:
checker/src/expected_errors.rs	`49% <0%> (-2%)`	:arrow_down:
checker/src/abstract_value.rs	`37% <0%> (-1%)`	:arrow_down:
checker/src/path.rs	`46% <0%> (+<1%)`	:arrow_up:
checker/src/known_names.rs	`69% <0%> (+<1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0732afb...8bb3e31. Read the comment docs.

hermanventer

comment created time in 3 days

issue commentfacebook/prepack

Unhelpful fatal error with loop in pure mode

@trueadm Thank you. I hope you will nevertheless find someone who takes over responsibility for this project. It's too promising to stay in an experimental state. It's exactly what I wanted to start for myself, but very soon I came to the conclusion that symbolic execution is no trivial task at all.

NTillmann

comment created time in 3 days

issue commentfacebook/prepack

Unhelpful fatal error with loop in pure mode

@akidee Sorry for the confusion. I've updated the README and removed this part, as it is no longer the case.

NTillmann

comment created time in 3 days

push eventfacebook/prepack

Dominic Gannaway

commit sha 5beedbe85bd5b9d2de1264abafbb3b76f8584297

Update README.md Update README to remove part where we plan on working again on Prepack in a few months, as this wasn't and is no longer the case.

view details

push time in 3 days

issue commentfacebook/prepack

Unhelpful fatal error with loop in pure mode

@trueadm https://github.com/facebook/prepack#status

If this is not true any more, at least this info should be updated.

NTillmann

comment created time in 3 days

issue commentfacebook/prepack

Unhelpful fatal error with loop in pure mode

@akidee Where was that quote from? AFAIK that is not the case.

NTillmann

comment created time in 3 days

issue commentfacebook/prepack

Unhelpful fatal error with loop in pure mode

@trueadm

However, we'd like to resume work on Prepack again in a few months.

By whom else? You have some more information?

NTillmann

comment created time in 3 days

issue commentfacebook/prepack

Unhelpful fatal error with loop in pure mode

@akidee Sorry to say, but Prepack isn't being maintained anymore by Facebook.

NTillmann

comment created time in 3 days

issue commentfacebook/prepack

Unhelpful fatal error with loop in pure mode

Same strange results here with v0.2.54:

Input:

class A {
  constructor(a) {
    this.a = a
  }
  add(b){ return this.a + b }
  mult(c, b) { 
    var sum = 0;
    for (var i = 0; i < this.a; i++)
      sum += b;
    return sum
  }
}
__optimize(A.prototype.mult)

Output of prepack --compatibility [ANY] prepacktest.js:

In input file prepacktest.js(8:25) FatalError PP0001:  (https://github.com/facebook/prepack/wiki/PP0001)
    at mult (prepacktest.js:8:25)
Prepack failed, reporting 1 fatal error.
(function () {
  var _$4 = this;

  var _1 = class {
    constructor(a) {
      this.a = a;
    }

    mult(c, b) {
      var __get_scope_binding_0 = function (__selector) {
        var __captured;

        switch (__selector) {
          case 0:
            __captured = [void 0];
            break;
        }

        __scope_0[__selector] = __captured;
        return __captured;
      };

      var __scope_0 = new Array(1);

      var __leaked_0, __leaked_1;

      var _9 = function () {
        var __captured__scope_1 = __scope_0[0] || __get_scope_binding_0(0);

        for (__captured__scope_1[0] = 0; __captured__scope_1[0] < this.a; __captured__scope_1[0]++) __leaked_1 += __leaked_0;
      };

      __leaked_0 = b;
      __leaked_1 = 0;

      var _$2 = _9.call(this);

      var _$3 = __leaked_1;
      return _$3;
    }

    add(b) {
      return this.a + b;
    }

  };

  _$4.A = _1;
}).call(this);

It looks like some parts of the generator code (managing scope) leaked into the output?

However, I have tested prepack with a regular source file of some hundred lines, and the output is promising despite some exaggerated variable declarations (see https://github.com/facebook/prepack/issues/2655).

PS: This is a great library, keep it going!

NTillmann

comment created time in 3 days

pull request commentfacebookexperimental/MIRAI

Deal with aliasing between slice and index paths

Codecov Report

Merging #733 (eb925f0) into master (e767eb9) will increase coverage by 0%. The diff coverage is 60%.

@@          Coverage Diff           @@
##           master    #733   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12842   12847    +5     
  Branches     5744    5747    +3     
======================================
+ Hits         5356    5370   +14     
+ Misses       3181    3169   -12     
- Partials     4305    4308    +3

Impacted Files	Coverage Δ
checker/src/body_visitor.rs	`34% <33%> (+<1%)`	:arrow_up:
checker/src/call_visitor.rs	`36% <100%> (ø)`
checker/src/callbacks.rs	`56% <100%> (+<1%)`	:arrow_up:
checker/src/abstract_value.rs	`37% <0%> (+<1%)`	:arrow_up:
checker/src/type_visitor.rs	`58% <0%> (+<1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d2e9f9...8daa2c4. Read the comment docs.

hermanventer

comment created time in 4 days

pull request commentfacebookexperimental/MIRAI

Compile standard contracts in paranoid mode

Codecov Report

Merging #732 (ad9dcef) into master (895771f) will decrease coverage by 0%. The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #732   +/-   ##
======================================
- Coverage      41%     41%   -1%     
======================================
  Files          22      22           
  Lines       12841   12842    +1     
  Branches     5744    5744           
======================================
- Hits         5358    5357    -1     
- Misses       3173    3181    +8     
+ Partials     4310    4304    -6

Impacted Files	Coverage Δ
checker/src/callbacks.rs	`55% <100%> (+<1%)`	:arrow_up:
checker/src/abstract_value.rs	`36% <0%> (-1%)`	:arrow_down:
checker/src/constant_domain.rs	`39% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e767eb9...ad9dcef. Read the comment docs.

hermanventer

comment created time in 5 days

pull request commentfacebookexperimental/MIRAI

Adapt to nightly 2021-01-19

Codecov Report

Merging #731 (06d2b89) into master (895771f) will decrease coverage by 0%. The diff coverage is 67%.

@@          Coverage Diff           @@
##           master    #731   +/-   ##
======================================
- Coverage      41%     41%   -1%     
======================================
  Files          22      22           
  Lines       12841   12880   +39     
  Branches     5744    5782   +38     
======================================
- Hits         5358    5345   -13     
- Misses       3173    3213   +40     
- Partials     4310    4322   +12

Impacted Files	Coverage Δ
checker/src/z3_solver.rs	`46% <0%> (+<1%)`	:arrow_up:
checker/src/body_visitor.rs	`34% <22%> (+<1%)`	:arrow_up:
checker/src/callbacks.rs	`60% <94%> (+4%)`	:arrow_up:
checker/src/environment.rs	`43% <0%> (-2%)`	:arrow_down:
checker/src/abstract_value.rs	`36% <0%> (-1%)`	:arrow_down:
checker/src/crate_visitor.rs	`32% <0%> (-1%)`	:arrow_down:
checker/src/constant_domain.rs	`38% <0%> (-1%)`	:arrow_down:
checker/src/fixed_point_visitor.rs	`42% <0%> (-1%)`	:arrow_down:
checker/src/path.rs	`45% <0%> (-1%)`	:arrow_down:
checker/src/call_visitor.rs	`36% <0%> (-1%)`	:arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e767eb9...06d2b89. Read the comment docs.

hermanventer

comment created time in 5 days

issue openedfacebook/prepack

No loop unrolling

Input:

f = (function(a, b) {
  function id(s) {  return s; }
  return function m(c){
    let s = 0
    for (let i = 0; i < a; i++)
      s += c + id(b)
    return s
  }
})(2, 5)

Prepack output (with default settings in the REPL):

(function () {
  var _$0 = this;

  var _3 = function (s) {
    return s;
  };

  var _1 = function (c) {
    let s = 0;

    for (let i = 0; i < 2; i++) s += c + _3(5);

    return s;
  };

  _$0.f = _1;
}).call(this);

I'd expect this result:

(function () {
  var _$0 = this;

  var _3 = function (s) {
    return s;
  };

  var _1 = function (c) {
    let s = 0;

   s += c + 5;
   s += c + 5;

    return s;
  };

  _$0.f = _1;
}).call(this);

Or better:

    ...
    return 2 * c + 10;
    ...

i has no side effects, c is never changed and id is an identity function. The way I expect it, it is more performant, too (as a little benchmark prooves).

created time in 6 days

pull request commentfacebookexperimental/MIRAI

Remove default contracts for functions that might have side-effects

Codecov Report

Merging #730 (70b5ea5) into master (6e154b9) will decrease coverage by 0%. The diff coverage is 34%.

@@           Coverage Diff           @@
##           master    #730    +/-   ##
=======================================
- Coverage      41%     41%    -1%     
=======================================
  Files          22      22            
  Lines       12696   12842   +146     
  Branches     5673    5744    +71     
=======================================
+ Hits         5305    5358    +53     
- Misses       3132    3178    +46     
- Partials     4259    4306    +47

Impacted Files	Coverage Δ
checker/src/abstract_value.rs	`36% <33%> (-1%)`	:arrow_down:
checker/src/callbacks.rs	`55% <100%> (+<1%)`	:arrow_up:
checker/src/expected_errors.rs	`49% <0%> (-2%)`	:arrow_down:
checker/src/interval_domain.rs	`64% <0%> (-1%)`	:arrow_down:
checker/src/block_visitor.rs	`40% <0%> (-1%)`	:arrow_down:
checker/src/expression.rs	`48% <0%> (+<1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 895771f...70b5ea5. Read the comment docs.

hermanventer

comment created time in 9 days

pull request commentfacebookexperimental/MIRAI

Add expression simplification rules

Codecov Report

Merging #729 (107af3e) into master (f54a248) will increase coverage by 0%. The diff coverage is 47%.

@@           Coverage Diff           @@
##           master    #729    +/-   ##
=======================================
  Coverage      41%     41%            
=======================================
  Files          22      22            
  Lines       12652   12841   +189     
  Branches     5671    5744    +73     
=======================================
+ Hits         5258    5357    +99     
- Misses       3131    3178    +47     
- Partials     4263    4306    +43

Impacted Files	Coverage Δ
checker/src/call_visitor.rs	`36% <0%> (ø)`
checker/src/abstract_value.rs	`36% <33%> (-1%)`	:arrow_down:
checker/src/type_visitor.rs	`58% <46%> (+<1%)`	:arrow_up:
checker/src/body_visitor.rs	`34% <50%> (-1%)`	:arrow_down:
checker/src/callbacks.rs	`55% <97%> (+19%)`	:arrow_up:
checker/src/interval_domain.rs	`64% <0%> (-1%)`	:arrow_down:
checker/src/path.rs	`46% <0%> (-1%)`	:arrow_down:
checker/src/block_visitor.rs	`40% <0%> (ø)`
checker/src/constant_domain.rs	`39% <0%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e154b9...107af3e. Read the comment docs.

hermanventer

comment created time in 9 days

pull request commentfacebookexperimental/MIRAI

Deal with closures that are passed via fields of parameters

Codecov Report

Merging #728 (eb8ba12) into master (03aeb06) will increase coverage by 0%. The diff coverage is 78%.

@@          Coverage Diff           @@
##           master    #728   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12649   12696   +47     
  Branches     5669    5673    +4     
======================================
+ Hits         5261    5308   +47     
- Misses       3121    3129    +8     
+ Partials     4267    4259    -8

Impacted Files	Coverage Δ
checker/src/abstract_value.rs	`37% <ø> (+<1%)`	:arrow_up:
checker/src/call_visitor.rs	`36% <0%> (ø)`
checker/src/body_visitor.rs	`34% <28%> (-1%)`	:arrow_down:
checker/src/type_visitor.rs	`58% <53%> (+<1%)`	:arrow_up:
checker/src/callbacks.rs	`55% <97%> (+19%)`	:arrow_up:
checker/src/path.rs	`46% <0%> (-1%)`	:arrow_down:
checker/src/expression.rs	`47% <0%> (ø)`
checker/src/constant_domain.rs	`39% <0%> (ø)`
checker/src/block_visitor.rs	`40% <0%> (+<1%)`	:arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f54a248...eb8ba12. Read the comment docs.

hermanventer

comment created time in 10 days

pull request commentfacebookexperimental/MIRAI

Handle expression overflows in summary effects

Codecov Report

Merging #727 (af85444) into master (30bdcb0) will increase coverage by 0%. The diff coverage is 30%.

@@          Coverage Diff           @@
##           master    #727   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12573   12652   +79     
  Branches     5630    5671   +41     
======================================
+ Hits         5223    5259   +36     
- Misses       3118    3131   +13     
- Partials     4232    4262   +30

Impacted Files	Coverage Δ
checker/src/abstract_value.rs	`37% <ø> (+<1%)`	:arrow_up:
checker/src/body_visitor.rs	`34% <0%> (-1%)`	:arrow_down:
checker/src/path.rs	`46% <31%> (-2%)`	:arrow_down:
checker/src/type_visitor.rs	`57% <0%> (-1%)`	:arrow_down:
checker/src/constant_domain.rs	`39% <0%> (ø)`
checker/src/expression.rs	`47% <0%> (+<1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03aeb06...af85444. Read the comment docs.

hermanventer

comment created time in 11 days

pull request commentfacebookexperimental/MIRAI

Add side effects via references to summaries

Codecov Report

Merging #726 (18a408e) into master (a78f84a) will increase coverage by 0%. The diff coverage is 40%.

@@          Coverage Diff           @@
##           master    #726   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12554   12647   +93     
  Branches     5624    5667   +43     
======================================
+ Hits         5205    5256   +51     
- Misses       3126    3131    +5     
- Partials     4223    4260   +37

Impacted Files	Coverage Δ
checker/src/body_visitor.rs	`34% <0%> (ø)`
checker/src/environment.rs	`44% <0%> (ø)`
checker/src/path.rs	`46% <40%> (+<1%)`	:arrow_up:
checker/src/abstract_value.rs	`37% <62%> (+<1%)`	:arrow_up:
checker/src/expected_errors.rs	`49% <0%> (-2%)`	:arrow_down:
checker/src/type_visitor.rs	`57% <0%> (ø)`
checker/src/expression.rs	`47% <0%> (+<1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30bdcb0...18a408e. Read the comment docs.

hermanventer

comment created time in 12 days

pull request commentfacebookexperimental/MIRAI

Fix join logic for unit values

Codecov Report

Merging #725 (b9113d7) into master (a78f84a) will increase coverage by 0%. The diff coverage is 57%.

@@          Coverage Diff           @@
##           master    #725   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12554   12573   +19     
  Branches     5624    5630    +6     
======================================
+ Hits         5205    5224   +19     
+ Misses       3126    3115   -11     
- Partials     4223    4234   +11

Impacted Files	Coverage Δ
checker/src/body_visitor.rs	`34% <0%> (ø)`
checker/src/environment.rs	`44% <0%> (ø)`
checker/src/abstract_value.rs	`37% <62%> (+<1%)`	:arrow_up:
checker/src/path.rs	`47% <71%> (+1%)`	:arrow_up:
checker/src/expected_errors.rs	`49% <0%> (-2%)`	:arrow_down:
checker/src/constant_domain.rs	`39% <0%> (ø)`
checker/src/type_visitor.rs	`58% <0%> (+<1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62e22d6...b9113d7. Read the comment docs.

hermanventer

comment created time in 13 days

pull request commentfacebookexperimental/MIRAI

Canonicalize initial parameter value paths

Codecov Report

Merging #724 (9a3cbeb) into master (fbe6a2d) will increase coverage by 0%. The diff coverage is 33%.

@@          Coverage Diff           @@
##           master    #724   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12605   12567   -38     
  Branches     5677    5628   -49     
======================================
+ Hits         5202    5218   +16     
+ Misses       3143    3123   -20     
+ Partials     4260    4226   -34

Impacted Files	Coverage Δ
checker/src/body_visitor.rs	`34% <0%> (ø)`
checker/src/call_visitor.rs	`36% <0%> (ø)`
checker/src/block_visitor.rs	`40% <14%> (-1%)`	:arrow_down:
checker/src/abstract_value.rs	`36% <45%> (+<1%)`	:arrow_up:
checker/src/path.rs	`47% <64%> (+4%)`	:arrow_up:
checker/src/type_visitor.rs	`58% <100%> (+<1%)`	:arrow_up:
checker/src/z3_solver.rs	`46% <0%> (+<1%)`	:arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a78f84a...9a3cbeb. Read the comment docs.

hermanventer

comment created time in 15 days

pull request commentfacebookexperimental/MIRAI

Remove duplicated code for dealing with deref of pointer values

Codecov Report

Merging #723 (18d1810) into master (fbe6a2d) will increase coverage by 0%. The diff coverage is 28%.

@@          Coverage Diff           @@
##           master    #723   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12605   12554   -51     
  Branches     5677    5624   -53     
======================================
+ Hits         5202    5205    +3     
+ Misses       3143    3126   -17     
+ Partials     4260    4223   -37

Impacted Files	Coverage Δ
checker/src/body_visitor.rs	`34% <0%> (ø)`
checker/src/call_visitor.rs	`36% <0%> (ø)`
checker/src/block_visitor.rs	`40% <14%> (-1%)`	:arrow_down:
checker/src/abstract_value.rs	`36% <50%> (+<1%)`	:arrow_up:
checker/src/path.rs	`46% <58%> (+3%)`	:arrow_up:
checker/src/type_visitor.rs	`57% <100%> (+<1%)`	:arrow_up:
checker/src/z3_solver.rs	`46% <0%> (+<1%)`	:arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 286c99b...18d1810. Read the comment docs.

hermanventer

comment created time in 16 days

pull request commentfacebookexperimental/MIRAI

Canonicalize paths that bind to Offset/HeapBlock values

Codecov Report

Merging #722 (bd245e7) into master (fbe6a2d) will increase coverage by 0%. The diff coverage is 26%.

@@          Coverage Diff           @@
##           master    #722   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12605   12562   -43     
  Branches     5677    5630   -47     
======================================
+ Hits         5202    5207    +5     
+ Misses       3143    3128   -15     
+ Partials     4260    4227   -33

Impacted Files	Coverage Δ
checker/src/body_visitor.rs	`34% <0%> (ø)`
checker/src/call_visitor.rs	`36% <0%> (ø)`
checker/src/block_visitor.rs	`40% <14%> (-1%)`	:arrow_down:
checker/src/abstract_value.rs	`36% <50%> (+<1%)`	:arrow_up:
checker/src/path.rs	`45% <62%> (+2%)`	:arrow_up:
checker/src/type_visitor.rs	`57% <100%> (+<1%)`	:arrow_up:
checker/src/z3_solver.rs	`46% <0%> (+<1%)`	:arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff90c71...bd245e7. Read the comment docs.

hermanventer

comment created time in 16 days

pull request commentfacebookexperimental/MIRAI

Remove unused depth parameter

Codecov Report

Merging #721 (beb9bd6) into master (11e1e39) will decrease coverage by 0%. The diff coverage is 35%.

@@           Coverage Diff           @@
##           master    #721    +/-   ##
=======================================
- Coverage      41%     41%    -1%     
=======================================
  Files          23      22     -1     
  Lines       12405   12555   +150     
  Branches     5538    5638   +100     
=======================================
+ Hits         5160    5192    +32     
+ Misses       3164    3124    -40     
- Partials     4081    4239   +158

Impacted Files	Coverage Δ
checker/src/call_visitor.rs	`36% <4%> (-2%)`	:arrow_down:
checker/src/expression.rs	`47% <22%> (+<1%)`	:arrow_up:
checker/src/body_visitor.rs	`34% <26%> (+1%)`	:arrow_up:
checker/src/constant_domain.rs	`39% <33%> (-2%)`	:arrow_down:
checker/src/block_visitor.rs	`40% <37%> (-1%)`	:arrow_down:
checker/src/abstract_value.rs	`36% <40%> (-1%)`	:arrow_down:
checker/src/path.rs	`44% <50%> (+<1%)`	:arrow_up:
checker/src/utils.rs	`59% <50%> (+<1%)`	:arrow_up:
checker/src/type_visitor.rs	`57% <55%> (+2%)`	:arrow_up:
checker/src/callbacks.rs	`36% <100%> (+3%)`	:arrow_up:
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fbe6a2d...beb9bd6. Read the comment docs.

hermanventer

comment created time in 17 days

pull request commentfacebookexperimental/MIRAI

New nightly

Codecov Report

Merging #720 (d4a6734) into master (11e1e39) will decrease coverage by 0%. The diff coverage is 41%.

@@           Coverage Diff           @@
##           master    #720    +/-   ##
=======================================
- Coverage      41%     41%    -1%     
=======================================
  Files          23      22     -1     
  Lines       12405   12605   +200     
  Branches     5538    5677   +139     
=======================================
+ Hits         5160    5203    +43     
+ Misses       3164    3143    -21     
- Partials     4081    4259   +178

Impacted Files	Coverage Δ
checker/src/call_visitor.rs	`36% <12%> (-2%)`	:arrow_down:
checker/src/expression.rs	`47% <22%> (+<1%)`	:arrow_up:
checker/src/body_visitor.rs	`34% <31%> (+1%)`	:arrow_up:
checker/src/constant_domain.rs	`39% <33%> (-2%)`	:arrow_down:
checker/src/abstract_value.rs	`36% <40%> (-1%)`	:arrow_down:
checker/src/path.rs	`43% <40%> (-1%)`	:arrow_down:
checker/src/block_visitor.rs	`40% <44%> (-1%)`	:arrow_down:
checker/src/utils.rs	`59% <50%> (+<1%)`	:arrow_up:
checker/src/type_visitor.rs	`57% <53%> (+2%)`	:arrow_up:
checker/src/callbacks.rs	`36% <100%> (+3%)`	:arrow_up:
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6200d88...d4a6734. Read the comment docs.

hermanventer

comment created time in 18 days

pull request commentfacebookexperimental/MIRAI

Tweak path type inference to deal with more Opaque types

Codecov Report

Merging #719 (11c2743) into master (e64992a) will increase coverage by 0%. The diff coverage is 32%.

@@           Coverage Diff           @@
##           master    #719    +/-   ##
=======================================
  Coverage      40%     41%            
=======================================
  Files          23      23            
  Lines       12664   12402   -262     
  Branches     5667    5537   -130     
=======================================
- Hits         5186    5167    -19     
+ Misses       3369    3152   -217     
+ Partials     4109    4083    -26

Impacted Files	Coverage Δ
checker/src/abstract_value.rs	`37% <ø> (+2%)`	:arrow_up:
checker/src/body_visitor.rs	`33% <0%> (+<1%)`	:arrow_up:
checker/src/call_visitor.rs	`38% <4%> (+<1%)`	:arrow_up:
checker/src/block_visitor.rs	`41% <6%> (+<1%)`	:arrow_up:
checker/src/path.rs	`43% <45%> (-2%)`	:arrow_down:
checker/src/type_visitor.rs	`57% <58%> (+2%)`	:arrow_up:
checker/src/crate_visitor.rs	`31% <100%> (+<1%)`	:arrow_up:
checker/src/lib.rs	`0% <0%> (ø)`
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11e1e39...11c2743. Read the comment docs.

hermanventer

comment created time in 18 days

issue openedfacebook/prepack

Test Results and Code Coverage Unavailable

The Links in Test Results and Code Coverage open a page containing:- { "message" : "Artifact not found" }

created time in 18 days

pull request commentfacebookexperimental/MIRAI

Rename and simplify refine_paths

Codecov Report

Merging #718 (ba29919) into master (27f5f0d) will increase coverage by 0%. The diff coverage is 32%.

@@           Coverage Diff           @@
##           master    #718    +/-   ##
=======================================
  Coverage      40%     41%            
=======================================
  Files          23      23            
  Lines       12650   12405   -245     
  Branches     5664    5538   -126     
=======================================
- Hits         5176    5160    -16     
+ Misses       3362    3164   -198     
+ Partials     4112    4081    -31

Impacted Files	Coverage Δ
checker/src/body_visitor.rs	`33% <0%> (+<1%)`	:arrow_up:
checker/src/fixed_point_visitor.rs	`43% <0%> (-1%)`	:arrow_down:
checker/src/block_visitor.rs	`41% <6%> (+<1%)`	:arrow_up:
checker/src/abstract_value.rs	`37% <26%> (+2%)`	:arrow_up:
checker/src/call_visitor.rs	`38% <34%> (+<1%)`	:arrow_up:
checker/src/path.rs	`43% <45%> (-2%)`	:arrow_down:
checker/src/environment.rs	`44% <50%> (+<1%)`	:arrow_up:
checker/src/type_visitor.rs	`55% <100%> (+<1%)`	:arrow_up:
checker/src/lib.rs	`0% <0%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e64992a...ba29919. Read the comment docs.

hermanventer

comment created time in 19 days

pull request commentfacebookexperimental/MIRAI

Rename refers_to_unknown_location to might_benefit_from_refinement

Codecov Report

Merging #717 (3a7f182) into master (27f5f0d) will increase coverage by 0%. The diff coverage is 47%.

@@          Coverage Diff           @@
##           master    #717   +/-   ##
======================================
  Coverage      40%     40%           
======================================
  Files          23      23           
  Lines       12650   12664   +14     
  Branches     5664    5667    +3     
======================================
+ Hits         5176    5186   +10     
- Misses       3362    3364    +2     
- Partials     4112    4114    +2

Impacted Files	Coverage Δ
checker/src/fixed_point_visitor.rs	`43% <0%> (-1%)`	:arrow_down:
checker/src/call_visitor.rs	`37% <47%> (+<1%)`	:arrow_up:
checker/src/environment.rs	`43% <50%> (ø)`
checker/src/path.rs	`45% <50%> (+<1%)`	:arrow_up:
checker/src/abstract_value.rs	`35% <73%> (-1%)`	:arrow_down:
checker/src/z3_solver.rs	`43% <0%> (+<1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8c71f6...3a7f182. Read the comment docs.

hermanventer

comment created time in 20 days