My dotfiles
JADE-based agents project written in Scala.
A single page application Leiningen template based on Reagent, Sente, Component
Cellular automata experiments.
A playground & HW assingments for Brent Yorgey's CIS 194
asynchronous communication for clojure
A curated list of awesome Clojure libraries and resources. Inspired by awesome-... stuff
gsnewmark/awesome-javascript 0
A collection of awesome browser-side JavaScript libraries, resources and shiny things.
Set of small utils to automate common daily tasks.
a rosetta stone for jvm byte representations
startedSaltieRL/Saltie
started time in 9 hours
startedkengz/SLM-Lab
started time in 9 hours
startedfacebookresearch/ReAgent
started time in 9 hours
starteddeepmind/acme
started time in 9 hours
pull request commenthlissner/doom-emacs
getting_started.org: Gentoo Linux install guide
You might want to mention that the xft use flag must be enabled for app-editors/emacs in order for the fonts to render correctly.
See #4876
comment created time in 11 hours
issue commenthlissner/doom-emacs
@savageCW
In order for the fonts to render correctly on Gentoo you need to enable the xft use-flag for app-editors/emacs.
This can be done like so...
# echo "app-editors/emacs xft" >> /etc/portage/package.use/emacs
comment created time in 11 hours
PR opened hlissner/doom-emacs
<!--
YOUR PR WILL NOT BE ACCEPTED IF IT DOES NOT MEET THE FOLLOWING CRITERIA:
- [x] It targets the develop branch
- [ ] I've searched for similar pull requests and found nothing
- [ ] This change is NOT in Doom's do-not-PR list: https://doomemacs.org/d/do-not-pr (GRR, this requires Discourse also???)
- [ ] If I've bumped any packages, I've done so according to https://doomemacs.org/d/how2bump
- [x] I've linked any relevant issues and PRs below
- [x] All my commit messages are descriptive and distinct
-->
This changes the FAQ link to a link that works for all users.
Is there a reason this currently points to Discourse which (seems to) force one to have a login to even see the content?
I tried to check the "do-not-PR" list but it has the same issue - of evidently being locked behind needing a Discourse account?
pr created time in 18 hours
pull request commenthlissner/doom-emacs
@iyefrat - on the "bibtex-actions improvements?" todo issue about menus.
We actually have a WIP progress PR to add embark-act at-point functionality, which includes as well a keymap specific to that.
Ideally, I'd like to get these "simple menus" with descriptoins working in which-key and, by extension, Doom.
https://github.com/bdarcus/bibtex-actions/pull/57/commits/33a9617194b31dbfd036513a7cf05b6b8c2a534e
But I never had any success, and it seems it has to wait on an unmerged, and stagnant, which-key PR.
If necessary, I can just provide the Doom-specific mapping, so we get nice and consistent menus with embark-act both at-point and in-buffer.
comment created time in a day
issue commentarcticicestudio/nord
Hi. I recently made Nord color for my qtcreator. Here is the link to my attempt:
- Code style: https://git.disroot.org/FollieHiyuki/dotfiles/src/branch/master/home/.config/QtProject/qtcreator/styles/nord.xml
- qtcreator theme: https://git.disroot.org/FollieHiyuki/dotfiles/src/branch/master/home/.config/QtProject/qtcreator/themes/nord.creatortheme
Sadly I know nothing about the Nord guidelines, and only cherry-picked colors so that the theme pleases my eyes. But hope this helps other with implementing the request.
comment created time in a day
PR opened hlissner/doom-emacs
<!--
YOUR PR WILL NOT BE ACCEPTED IF IT DOES NOT MEET THE FOLLOWING CRITERIA:
- [x] It targets the develop branch
- [x] I've searched for similar pull requests and found nothing
- [x] This change is NOT in Doom's do-not-PR list: https://doomemacs.org/d/do-not-pr
- [x] If I've bumped any packages, I've done so according to https://doomemacs.org/d/how2bump
- [x] I've linked any relevant issues and PRs below
- [x] All my commit messages are descriptive and distinct
-->
Fixes #5176 <!-- remove if not applicable -->
{{{ Summarize what you've changed HERE and why }}}
I changed the +tabs:next-or-goto and +tabs:previous-or-goto functions to use (interactive "P") so they accept the prefix as tab index. This reduce the extra key strike when you just want next ore previous, and works with a big tab index. Also the current implementation doesn't work with index.
pr created time in a day
issue commenthlissner/doom-emacs
centaur-tabs' `gt`/`gT` asking for more key input.
Yep, tried it and it works as expected.
comment created time in a day
issue commenthlissner/doom-emacs
centaur-tabs' `gt`/`gT` asking for more key input.
@acristoffers Hi, I tried to edebug this and found out <C> will set the extra key's byte as the value of index.
So I think this function should be like this
(evil-define-command +tabs:next-or-goto (index)
"Switch to the next tab, or to INDEXth tab if a count is given."
(interactive "P")
(if index
(centaur-tabs-select-visible-nth-tab index)
(centaur-tabs-forward)))
which takes the prefix as the tab index. Or it needs to to parse the key to number as the real index.
comment created time in a day
issue commenthlissner/doom-emacs
centaur-tabs' `gt`/`gT` asking for more key input.
Simply replacing current-prefix-arg by index and restarting emacs resulted in the functionality not working anymore. gt took me to the last tab and then gT did nothing.
comment created time in a day
issue commenthlissner/doom-emacs
centaur-tabs' `gt`/`gT` asking for more key input.
I think the current-prefix-arg in:
(evil-define-command +tabs:next-or-goto (index)
"Switch to the next tab, or to INDEXth tab if a count is given."
(interactive "<C>")
(if current-prefix-arg
(centaur-tabs-select-visible-nth-tab current-prefix-arg)
(centaur-tabs-forward)))
should be index, it's reading the prefix rather than the extra key?
comment created time in a day
startedtoluaina/pgsync
started time in 2 days
Pull request review commenthlissner/doom-emacs
+;;; completion/selectrum/config.el -*- lexical-binding: t; -*-++(use-package! selectrum+ :hook (doom-first-input . selectrum-mode)+ :init+ (setq selectrum-display-action nil+ selectrum-extend-current-candidate-highlight t+ selectrum-fix-vertical-window-height 17+ selectrum-max-window-height 17+ projectile-completion-system 'default)+ (when (featurep! +prescient)+ (setq completion-styles '(substring partial-completion)))+ :config+ (defadvice! +selectrum-refresh-on-cycle (&rest _)+ :after 'marginalia-cycle+ (when (bound-and-true-p selectrum-mode) (selectrum-exhibit)))+ (defun +selectrum/backward-updir ()+ "Delete char before or go up directory for file cagetory selectrum buffers."+ (interactive)+ (if (and (eq (char-before) ?/)+ (eq (selectrum--get-meta 'category) 'file))+ (let ((new-path (minibuffer-contents)))+ (delete-region (minibuffer-prompt-end) (point-max))+ (insert (abbreviate-file-name+ (file-name-directory+ (directory-file-name+ (expand-file-name new-path))))))+ (call-interactively 'backward-delete-char)))+ (map! :map selectrum-minibuffer-map+ [backspace] #'+selectrum/backward-updir))++(use-package! selectrum-prescient+ :when (featurep! +prescient)+ :hook (selectrum-mode . selectrum-prescient-mode)+ :hook (selectrum-mode . prescient-persist-mode)+ :config+ (setq selectrum-preprocess-candidates-function #'selectrum-prescient--preprocess)+ (add-hook 'selectrum-candidate-selected-hook #'selectrum-prescient--remember)+ (add-hook 'selectrum-candidate-inserted-hook #'selectrum-prescient--remember))++(use-package! orderless+ :when (not (featurep! +prescient))+ :demand t+ :config+ (defun +selectrum-orderless-dispatch (pattern _index _total)+ (cond+ ;; Ensure that $ works with Consult commands, which add disambiguation suffixes+ ((string-suffix-p "$" pattern) `(orderless-regexp . ,(concat (substring pattern 0 -1) "[\x100000-\x10FFFD]*$")))+ ;; Ignore single !+ ((string= "!" pattern) `(orderless-literal . ""))+ ;; Without literal+ ((string-prefix-p "!" pattern) `(orderless-without-literal . ,(substring pattern 1)))+ ;; Initialism matching+ ((string-prefix-p "`" pattern) `(orderless-initialism . ,(substring pattern 1)))+ ((string-suffix-p "`" pattern) `(orderless-initialism . ,(substring pattern 0 -1)))+ ;; Literal matching+ ((string-prefix-p "=" pattern) `(orderless-literal . ,(substring pattern 1)))+ ((string-suffix-p "=" pattern) `(orderless-literal . ,(substring pattern 0 -1)))+ ;; Flex matching+ ((string-prefix-p "~" pattern) `(orderless-flex . ,(substring pattern 1)))+ ((string-suffix-p "~" pattern) `(orderless-flex . ,(substring pattern 0 -1)))))+ (setq completion-styles '(orderless)
yeah but the weird thing is that it seems under C-h f for example, it seems to prioritize the shorter matches first, while in company it seems to just sort them in alphabetical order. Do selectrum and vertico add some extra sorting on the list of matched candidates or something?
comment created time in 2 days
Pull request review commenthlissner/doom-emacs
+;;; completion/selectrum/config.el -*- lexical-binding: t; -*-++(use-package! selectrum+ :hook (doom-first-input . selectrum-mode)+ :init+ (setq selectrum-display-action nil+ selectrum-extend-current-candidate-highlight t+ selectrum-fix-vertical-window-height 17+ selectrum-max-window-height 17+ projectile-completion-system 'default)+ (when (featurep! +prescient)+ (setq completion-styles '(substring partial-completion)))+ :config+ (defadvice! +selectrum-refresh-on-cycle (&rest _)+ :after 'marginalia-cycle+ (when (bound-and-true-p selectrum-mode) (selectrum-exhibit)))+ (defun +selectrum/backward-updir ()+ "Delete char before or go up directory for file cagetory selectrum buffers."+ (interactive)+ (if (and (eq (char-before) ?/)+ (eq (selectrum--get-meta 'category) 'file))+ (let ((new-path (minibuffer-contents)))+ (delete-region (minibuffer-prompt-end) (point-max))+ (insert (abbreviate-file-name+ (file-name-directory+ (directory-file-name+ (expand-file-name new-path))))))+ (call-interactively 'backward-delete-char)))+ (map! :map selectrum-minibuffer-map+ [backspace] #'+selectrum/backward-updir))++(use-package! selectrum-prescient+ :when (featurep! +prescient)+ :hook (selectrum-mode . selectrum-prescient-mode)+ :hook (selectrum-mode . prescient-persist-mode)+ :config+ (setq selectrum-preprocess-candidates-function #'selectrum-prescient--preprocess)+ (add-hook 'selectrum-candidate-selected-hook #'selectrum-prescient--remember)+ (add-hook 'selectrum-candidate-inserted-hook #'selectrum-prescient--remember))++(use-package! orderless+ :when (not (featurep! +prescient))+ :demand t+ :config+ (defun +selectrum-orderless-dispatch (pattern _index _total)+ (cond+ ;; Ensure that $ works with Consult commands, which add disambiguation suffixes+ ((string-suffix-p "$" pattern) `(orderless-regexp . ,(concat (substring pattern 0 -1) "[\x100000-\x10FFFD]*$")))+ ;; Ignore single !+ ((string= "!" pattern) `(orderless-literal . ""))+ ;; Without literal+ ((string-prefix-p "!" pattern) `(orderless-without-literal . ,(substring pattern 1)))+ ;; Initialism matching+ ((string-prefix-p "`" pattern) `(orderless-initialism . ,(substring pattern 1)))+ ((string-suffix-p "`" pattern) `(orderless-initialism . ,(substring pattern 0 -1)))+ ;; Literal matching+ ((string-prefix-p "=" pattern) `(orderless-literal . ,(substring pattern 1)))+ ((string-suffix-p "=" pattern) `(orderless-literal . ,(substring pattern 0 -1)))+ ;; Flex matching+ ((string-prefix-p "~" pattern) `(orderless-flex . ,(substring pattern 1)))+ ((string-suffix-p "~" pattern) `(orderless-flex . ,(substring pattern 0 -1)))))+ (setq completion-styles '(orderless)+ completion-category-defaults nil+ ;; note that despite override in the name orderless can still be used in find-file etc.+ completion-category-overrides '((file (styles . (partial-completion))))+ orderless-style-dispatchers '(+selectrum-orderless-dispatch)+ orderless-component-separator "[ &]"+ selectrum-refine-candidates-function #'orderless-filter+ selectrum-highlight-candidates-function #'orderless-highlight-matches))++(use-package! consult+ :defer t+ :init+ (fset 'multi-occur #'consult-multi-occur)+ (define-key!+ [remap apropos] #'consult-apropos+ [remap bookmark-jump] #'consult-bookmark+ [remap evil-show-marks] #'consult-mark+ [remap goto-line] #'consult-goto-line+ [remap imenu] #'consult-imenu+ [remap locate] #'consult-locate+ [remap load-theme] #'consult-theme+ [remap man] #'consult-man+ [remap recentf-open-files] #'consult-recent-file+ [remap switch-to-buffer] #'consult-buffer+ [remap switch-to-buffer-other-window] #'consult-buffer-other-window+ [remap switch-to-buffer-other-frame] #'consult-buffer-other-frame+ [remap yank-pop] #'consult-yank-pop+ [remap persp-switch-to-buffer] #'+selectrum/switch-workspace-buffer)+ (setq completion-in-region-function #'consult-completion-in-region)+ :config+ (recentf-mode)+ (setq consult-project-root-function #'doom-project-root+ completion-in-region-function #'consult-completion-in-region+ consult-narrow-key "<"+ consult-line-numbers-widen t+ consult-async-input-debounce 0.5+ consult-async-input-throttle 0.8)+ (consult-customize+ consult-ripgrep consult-git-grep consult-grep+ consult-bookmark consult-recent-file+ +default/search-project +default/search-project-for-symbol-at-point+ +default/search-other-project +selectrum/search-symbol-at-point+ +default/search-cwd +default/search-other-cwd+ +default/search-notes-for-symbol-at-point+ consult--source-file consult--source-project-file consult--source-bookmark+ :preview-key (list (kbd "C-SPC") (kbd "C-M-j") (kbd "C-M-k"))))++(use-package! consult-flycheck+ :when (featurep! :checkers syntax)+ :after (consult flycheck))++(use-package! embark+ :init+ (setq embark-action-indicator+ (lambda (map _target)+ (which-key--show-keymap "Embark" map nil nil 'no-paging)+ #'which-key--hide-popup-ignore-command)+ embark-become-indicator embark-action-indicator)+ (map! "C-;" #'embark-act ; to be moved to :config default if accepted
ah, right.
comment created time in 2 days
Pull request review commenthlissner/doom-emacs
+;;; completion/selectrum/config.el -*- lexical-binding: t; -*-++(use-package! selectrum+ :hook (doom-first-input . selectrum-mode)+ :init+ (setq selectrum-display-action nil+ selectrum-extend-current-candidate-highlight t+ selectrum-fix-vertical-window-height 17+ selectrum-max-window-height 17+ projectile-completion-system 'default)+ (when (featurep! +prescient)+ (setq completion-styles '(substring partial-completion)))+ :config+ (defadvice! +selectrum-refresh-on-cycle (&rest _)+ :after 'marginalia-cycle+ (when (bound-and-true-p selectrum-mode) (selectrum-exhibit)))+ (defun +selectrum/backward-updir ()+ "Delete char before or go up directory for file cagetory selectrum buffers."+ (interactive)+ (if (and (eq (char-before) ?/)+ (eq (selectrum--get-meta 'category) 'file))+ (let ((new-path (minibuffer-contents)))+ (delete-region (minibuffer-prompt-end) (point-max))+ (insert (abbreviate-file-name+ (file-name-directory+ (directory-file-name+ (expand-file-name new-path))))))+ (call-interactively 'backward-delete-char)))+ (map! :map selectrum-minibuffer-map+ [backspace] #'+selectrum/backward-updir))++(use-package! selectrum-prescient+ :when (featurep! +prescient)+ :hook (selectrum-mode . selectrum-prescient-mode)+ :hook (selectrum-mode . prescient-persist-mode)+ :config+ (setq selectrum-preprocess-candidates-function #'selectrum-prescient--preprocess)+ (add-hook 'selectrum-candidate-selected-hook #'selectrum-prescient--remember)+ (add-hook 'selectrum-candidate-inserted-hook #'selectrum-prescient--remember))++(use-package! orderless+ :when (not (featurep! +prescient))+ :demand t+ :config+ (defun +selectrum-orderless-dispatch (pattern _index _total)+ (cond+ ;; Ensure that $ works with Consult commands, which add disambiguation suffixes+ ((string-suffix-p "$" pattern) `(orderless-regexp . ,(concat (substring pattern 0 -1) "[\x100000-\x10FFFD]*$")))+ ;; Ignore single !+ ((string= "!" pattern) `(orderless-literal . ""))+ ;; Without literal+ ((string-prefix-p "!" pattern) `(orderless-without-literal . ,(substring pattern 1)))+ ;; Initialism matching+ ((string-prefix-p "`" pattern) `(orderless-initialism . ,(substring pattern 1)))+ ((string-suffix-p "`" pattern) `(orderless-initialism . ,(substring pattern 0 -1)))+ ;; Literal matching+ ((string-prefix-p "=" pattern) `(orderless-literal . ,(substring pattern 1)))+ ((string-suffix-p "=" pattern) `(orderless-literal . ,(substring pattern 0 -1)))+ ;; Flex matching+ ((string-prefix-p "~" pattern) `(orderless-flex . ,(substring pattern 1)))+ ((string-suffix-p "~" pattern) `(orderless-flex . ,(substring pattern 0 -1)))))+ (setq completion-styles '(orderless)
In my opinion completion at point (Company, Corfu etc) should be treated differently than minibuffer completion. Therefore you may want to configure a separate completion style for company. Unfortunately this is not possible ootb and requires advices to Company/Corfu such that a special completion style is used.
comment created time in 2 days
Pull request review commenthlissner/doom-emacs
+;;; completion/selectrum/config.el -*- lexical-binding: t; -*-++(use-package! selectrum+ :hook (doom-first-input . selectrum-mode)+ :init+ (setq selectrum-display-action nil+ selectrum-extend-current-candidate-highlight t+ selectrum-fix-vertical-window-height 17+ selectrum-max-window-height 17+ projectile-completion-system 'default)+ (when (featurep! +prescient)+ (setq completion-styles '(substring partial-completion)))+ :config+ (defadvice! +selectrum-refresh-on-cycle (&rest _)+ :after 'marginalia-cycle+ (when (bound-and-true-p selectrum-mode) (selectrum-exhibit)))+ (defun +selectrum/backward-updir ()+ "Delete char before or go up directory for file cagetory selectrum buffers."+ (interactive)+ (if (and (eq (char-before) ?/)+ (eq (selectrum--get-meta 'category) 'file))+ (let ((new-path (minibuffer-contents)))+ (delete-region (minibuffer-prompt-end) (point-max))+ (insert (abbreviate-file-name+ (file-name-directory+ (directory-file-name+ (expand-file-name new-path))))))+ (call-interactively 'backward-delete-char)))+ (map! :map selectrum-minibuffer-map+ [backspace] #'+selectrum/backward-updir))++(use-package! selectrum-prescient+ :when (featurep! +prescient)+ :hook (selectrum-mode . selectrum-prescient-mode)+ :hook (selectrum-mode . prescient-persist-mode)+ :config+ (setq selectrum-preprocess-candidates-function #'selectrum-prescient--preprocess)+ (add-hook 'selectrum-candidate-selected-hook #'selectrum-prescient--remember)+ (add-hook 'selectrum-candidate-inserted-hook #'selectrum-prescient--remember))++(use-package! orderless+ :when (not (featurep! +prescient))+ :demand t+ :config+ (defun +selectrum-orderless-dispatch (pattern _index _total)+ (cond+ ;; Ensure that $ works with Consult commands, which add disambiguation suffixes+ ((string-suffix-p "$" pattern) `(orderless-regexp . ,(concat (substring pattern 0 -1) "[\x100000-\x10FFFD]*$")))+ ;; Ignore single !+ ((string= "!" pattern) `(orderless-literal . ""))+ ;; Without literal+ ((string-prefix-p "!" pattern) `(orderless-without-literal . ,(substring pattern 1)))+ ;; Initialism matching+ ((string-prefix-p "`" pattern) `(orderless-initialism . ,(substring pattern 1)))+ ((string-suffix-p "`" pattern) `(orderless-initialism . ,(substring pattern 0 -1)))+ ;; Literal matching+ ((string-prefix-p "=" pattern) `(orderless-literal . ,(substring pattern 1)))+ ((string-suffix-p "=" pattern) `(orderless-literal . ,(substring pattern 0 -1)))+ ;; Flex matching+ ((string-prefix-p "~" pattern) `(orderless-flex . ,(substring pattern 1)))+ ((string-suffix-p "~" pattern) `(orderless-flex . ,(substring pattern 0 -1)))))+ (setq completion-styles '(orderless)+ completion-category-defaults nil+ ;; note that despite override in the name orderless can still be used in find-file etc.+ completion-category-overrides '((file (styles . (partial-completion))))+ orderless-style-dispatchers '(+selectrum-orderless-dispatch)+ orderless-component-separator "[ &]"+ selectrum-refine-candidates-function #'orderless-filter+ selectrum-highlight-candidates-function #'orderless-highlight-matches))++(use-package! consult+ :defer t+ :init+ (fset 'multi-occur #'consult-multi-occur)+ (define-key!+ [remap apropos] #'consult-apropos+ [remap bookmark-jump] #'consult-bookmark+ [remap evil-show-marks] #'consult-mark+ [remap goto-line] #'consult-goto-line+ [remap imenu] #'consult-imenu+ [remap locate] #'consult-locate+ [remap load-theme] #'consult-theme+ [remap man] #'consult-man+ [remap recentf-open-files] #'consult-recent-file+ [remap switch-to-buffer] #'consult-buffer+ [remap switch-to-buffer-other-window] #'consult-buffer-other-window+ [remap switch-to-buffer-other-frame] #'consult-buffer-other-frame+ [remap yank-pop] #'consult-yank-pop+ [remap persp-switch-to-buffer] #'+selectrum/switch-workspace-buffer)+ (setq completion-in-region-function #'consult-completion-in-region)+ :config+ (recentf-mode)+ (setq consult-project-root-function #'doom-project-root+ completion-in-region-function #'consult-completion-in-region+ consult-narrow-key "<"+ consult-line-numbers-widen t+ consult-async-input-debounce 0.5+ consult-async-input-throttle 0.8)+ (consult-customize+ consult-ripgrep consult-git-grep consult-grep+ consult-bookmark consult-recent-file+ +default/search-project +default/search-project-for-symbol-at-point+ +default/search-other-project +selectrum/search-symbol-at-point+ +default/search-cwd +default/search-other-cwd+ +default/search-notes-for-symbol-at-point+ consult--source-file consult--source-project-file consult--source-bookmark+ :preview-key (list (kbd "C-SPC") (kbd "C-M-j") (kbd "C-M-k"))))
Very good. Consult generally also has a focus on responsiveness or at least it can be configured to be responsive. But these configurations must really be done on a per command basis, since it all depends. For example consult-buffer previews are always responsive in my configuration. But this is not generally the case - in some setups buffer switching is more expensive and profits from debouncing.
comment created time in 2 days
Pull request review commenthlissner/doom-emacs
+;;; completion/selectrum/config.el -*- lexical-binding: t; -*-++(use-package! selectrum+ :hook (doom-first-input . selectrum-mode)+ :init+ (setq selectrum-display-action nil+ selectrum-extend-current-candidate-highlight t+ selectrum-fix-vertical-window-height 17+ selectrum-max-window-height 17+ projectile-completion-system 'default)+ (when (featurep! +prescient)+ (setq completion-styles '(substring partial-completion)))+ :config+ (defadvice! +selectrum-refresh-on-cycle (&rest _)+ :after 'marginalia-cycle+ (when (bound-and-true-p selectrum-mode) (selectrum-exhibit)))+ (defun +selectrum/backward-updir ()+ "Delete char before or go up directory for file cagetory selectrum buffers."+ (interactive)+ (if (and (eq (char-before) ?/)+ (eq (selectrum--get-meta 'category) 'file))+ (let ((new-path (minibuffer-contents)))+ (delete-region (minibuffer-prompt-end) (point-max))+ (insert (abbreviate-file-name+ (file-name-directory+ (directory-file-name+ (expand-file-name new-path))))))+ (call-interactively 'backward-delete-char)))+ (map! :map selectrum-minibuffer-map+ [backspace] #'+selectrum/backward-updir))++(use-package! selectrum-prescient+ :when (featurep! +prescient)+ :hook (selectrum-mode . selectrum-prescient-mode)+ :hook (selectrum-mode . prescient-persist-mode)+ :config+ (setq selectrum-preprocess-candidates-function #'selectrum-prescient--preprocess)+ (add-hook 'selectrum-candidate-selected-hook #'selectrum-prescient--remember)+ (add-hook 'selectrum-candidate-inserted-hook #'selectrum-prescient--remember))++(use-package! orderless+ :when (not (featurep! +prescient))+ :demand t+ :config+ (defun +selectrum-orderless-dispatch (pattern _index _total)+ (cond+ ;; Ensure that $ works with Consult commands, which add disambiguation suffixes+ ((string-suffix-p "$" pattern) `(orderless-regexp . ,(concat (substring pattern 0 -1) "[\x100000-\x10FFFD]*$")))+ ;; Ignore single !+ ((string= "!" pattern) `(orderless-literal . ""))+ ;; Without literal+ ((string-prefix-p "!" pattern) `(orderless-without-literal . ,(substring pattern 1)))+ ;; Initialism matching+ ((string-prefix-p "`" pattern) `(orderless-initialism . ,(substring pattern 1)))+ ((string-suffix-p "`" pattern) `(orderless-initialism . ,(substring pattern 0 -1)))+ ;; Literal matching+ ((string-prefix-p "=" pattern) `(orderless-literal . ,(substring pattern 1)))+ ((string-suffix-p "=" pattern) `(orderless-literal . ,(substring pattern 0 -1)))+ ;; Flex matching+ ((string-prefix-p "~" pattern) `(orderless-flex . ,(substring pattern 1)))+ ((string-suffix-p "~" pattern) `(orderless-flex . ,(substring pattern 0 -1)))))+ (setq completion-styles '(orderless)+ completion-category-defaults nil+ ;; note that despite override in the name orderless can still be used in find-file etc.+ completion-category-overrides '((file (styles . (partial-completion))))+ orderless-style-dispatchers '(+selectrum-orderless-dispatch)+ orderless-component-separator "[ &]"+ selectrum-refine-candidates-function #'orderless-filter+ selectrum-highlight-candidates-function #'orderless-highlight-matches))++(use-package! consult+ :defer t+ :init+ (fset 'multi-occur #'consult-multi-occur)+ (define-key!+ [remap apropos] #'consult-apropos+ [remap bookmark-jump] #'consult-bookmark+ [remap evil-show-marks] #'consult-mark+ [remap goto-line] #'consult-goto-line+ [remap imenu] #'consult-imenu+ [remap locate] #'consult-locate+ [remap load-theme] #'consult-theme+ [remap man] #'consult-man+ [remap recentf-open-files] #'consult-recent-file+ [remap switch-to-buffer] #'consult-buffer+ [remap switch-to-buffer-other-window] #'consult-buffer-other-window+ [remap switch-to-buffer-other-frame] #'consult-buffer-other-frame+ [remap yank-pop] #'consult-yank-pop+ [remap persp-switch-to-buffer] #'+selectrum/switch-workspace-buffer)+ (setq completion-in-region-function #'consult-completion-in-region)+ :config+ (recentf-mode)+ (setq consult-project-root-function #'doom-project-root+ completion-in-region-function #'consult-completion-in-region+ consult-narrow-key "<"+ consult-line-numbers-widen t+ consult-async-input-debounce 0.5+ consult-async-input-throttle 0.8)+ (consult-customize+ consult-ripgrep consult-git-grep consult-grep+ consult-bookmark consult-recent-file+ +default/search-project +default/search-project-for-symbol-at-point+ +default/search-other-project +selectrum/search-symbol-at-point+ +default/search-cwd +default/search-other-cwd+ +default/search-notes-for-symbol-at-point+ consult--source-file consult--source-project-file consult--source-bookmark+ :preview-key (list (kbd "C-SPC") (kbd "C-M-j") (kbd "C-M-k"))))++(use-package! consult-flycheck+ :when (featurep! :checkers syntax)+ :after (consult flycheck))++(use-package! embark+ :init+ (setq embark-action-indicator+ (lambda (map _target)+ (which-key--show-keymap "Embark" map nil nil 'no-paging)+ #'which-key--hide-popup-ignore-command)+ embark-become-indicator embark-action-indicator)+ (map! "C-;" #'embark-act ; to be moved to :config default if accepted
It does the same as RET, however it is useful if you want to keep the minibuffer open.
comment created time in 2 days
issue openedhlissner/doom-emacs
- [X] I have searched the FAQ and the documentation for solutions.
- [X] I have searched the issue tracker for similar issues (the closed issues too).
- [X] I have searched the Discourse for any errors and solutions.
- [X] I can reproduce my issue on the latest commit of Doom Emacs.
- [X] I have read How to Debug Issues and found no solution.
What did you expect to happen?
I expect *.js files to open with no errors.
What actually happened?
When opening a *.js file, I get the following message:
Error (js-mode-hook): Error running hook "js" because: (error Autoloading file /usr/share/emacs/27.2/lisp/progmodes/js.elc failed to define function js)
Describe your attempts to resolve the issue
No response
Steps to reproduce
Just open any *.js file.
System Information
https://ynh.mmksoft.uk/privatebin/?b9ce1ed102dd6270#AEq4gktAJ8JhuwYvKpEr3mAuQQc4snkNDkY63LySRkTy
created time in 2 days
Pull request review commenthlissner/doom-emacs
+;;; completion/selectrum/config.el -*- lexical-binding: t; -*-++(use-package! selectrum+ :hook (doom-first-input . selectrum-mode)+ :init+ (setq selectrum-display-action nil+ selectrum-extend-current-candidate-highlight t+ selectrum-fix-vertical-window-height 17+ selectrum-max-window-height 17+ projectile-completion-system 'default)+ (when (featurep! +prescient)+ (setq completion-styles '(substring partial-completion)))+ :config+ (defadvice! +selectrum-refresh-on-cycle (&rest _)+ :after 'marginalia-cycle+ (when (bound-and-true-p selectrum-mode) (selectrum-exhibit)))+ (defun +selectrum/backward-updir ()+ "Delete char before or go up directory for file cagetory selectrum buffers."+ (interactive)+ (if (and (eq (char-before) ?/)+ (eq (selectrum--get-meta 'category) 'file))+ (let ((new-path (minibuffer-contents)))+ (delete-region (minibuffer-prompt-end) (point-max))+ (insert (abbreviate-file-name+ (file-name-directory+ (directory-file-name+ (expand-file-name new-path))))))+ (call-interactively 'backward-delete-char)))+ (map! :map selectrum-minibuffer-map+ [backspace] #'+selectrum/backward-updir))++(use-package! selectrum-prescient+ :when (featurep! +prescient)+ :hook (selectrum-mode . selectrum-prescient-mode)+ :hook (selectrum-mode . prescient-persist-mode)+ :config+ (setq selectrum-preprocess-candidates-function #'selectrum-prescient--preprocess)+ (add-hook 'selectrum-candidate-selected-hook #'selectrum-prescient--remember)+ (add-hook 'selectrum-candidate-inserted-hook #'selectrum-prescient--remember))++(use-package! orderless+ :when (not (featurep! +prescient))+ :demand t+ :config+ (defun +selectrum-orderless-dispatch (pattern _index _total)+ (cond+ ;; Ensure that $ works with Consult commands, which add disambiguation suffixes+ ((string-suffix-p "$" pattern) `(orderless-regexp . ,(concat (substring pattern 0 -1) "[\x100000-\x10FFFD]*$")))+ ;; Ignore single !+ ((string= "!" pattern) `(orderless-literal . ""))+ ;; Without literal+ ((string-prefix-p "!" pattern) `(orderless-without-literal . ,(substring pattern 1)))+ ;; Initialism matching+ ((string-prefix-p "`" pattern) `(orderless-initialism . ,(substring pattern 1)))+ ((string-suffix-p "`" pattern) `(orderless-initialism . ,(substring pattern 0 -1)))+ ;; Literal matching+ ((string-prefix-p "=" pattern) `(orderless-literal . ,(substring pattern 1)))+ ((string-suffix-p "=" pattern) `(orderless-literal . ,(substring pattern 0 -1)))+ ;; Flex matching+ ((string-prefix-p "~" pattern) `(orderless-flex . ,(substring pattern 1)))+ ((string-suffix-p "~" pattern) `(orderless-flex . ,(substring pattern 0 -1)))))+ (setq completion-styles '(orderless)
@daanturo Hmm. I'm not sure if this is the best way to solve this, I need to look into it more to make sure there aren't any unintended consequences. There also seem to be some discussions in orderless issues that relate to this as well.
comment created time in 2 days
startedmeilisearch/MeiliSearch
started time in 2 days
Pull request review commenthlissner/doom-emacs
+;;; completion/selectrum/config.el -*- lexical-binding: t; -*-++(use-package! selectrum+ :hook (doom-first-input . selectrum-mode)+ :init+ (setq selectrum-display-action nil+ selectrum-extend-current-candidate-highlight t+ selectrum-fix-vertical-window-height 17+ selectrum-max-window-height 17+ projectile-completion-system 'default)+ (when (featurep! +prescient)+ (setq completion-styles '(substring partial-completion)))+ :config+ (defadvice! +selectrum-refresh-on-cycle (&rest _)+ :after 'marginalia-cycle+ (when (bound-and-true-p selectrum-mode) (selectrum-exhibit)))+ (defun +selectrum/backward-updir ()+ "Delete char before or go up directory for file cagetory selectrum buffers."+ (interactive)+ (if (and (eq (char-before) ?/)+ (eq (selectrum--get-meta 'category) 'file))+ (let ((new-path (minibuffer-contents)))+ (delete-region (minibuffer-prompt-end) (point-max))+ (insert (abbreviate-file-name+ (file-name-directory+ (directory-file-name+ (expand-file-name new-path))))))+ (call-interactively 'backward-delete-char)))+ (map! :map selectrum-minibuffer-map+ [backspace] #'+selectrum/backward-updir))++(use-package! selectrum-prescient+ :when (featurep! +prescient)+ :hook (selectrum-mode . selectrum-prescient-mode)+ :hook (selectrum-mode . prescient-persist-mode)+ :config+ (setq selectrum-preprocess-candidates-function #'selectrum-prescient--preprocess)+ (add-hook 'selectrum-candidate-selected-hook #'selectrum-prescient--remember)+ (add-hook 'selectrum-candidate-inserted-hook #'selectrum-prescient--remember))++(use-package! orderless+ :when (not (featurep! +prescient))+ :demand t+ :config+ (defun +selectrum-orderless-dispatch (pattern _index _total)+ (cond+ ;; Ensure that $ works with Consult commands, which add disambiguation suffixes+ ((string-suffix-p "$" pattern) `(orderless-regexp . ,(concat (substring pattern 0 -1) "[\x100000-\x10FFFD]*$")))+ ;; Ignore single !+ ((string= "!" pattern) `(orderless-literal . ""))+ ;; Without literal+ ((string-prefix-p "!" pattern) `(orderless-without-literal . ,(substring pattern 1)))+ ;; Initialism matching+ ((string-prefix-p "`" pattern) `(orderless-initialism . ,(substring pattern 1)))+ ((string-suffix-p "`" pattern) `(orderless-initialism . ,(substring pattern 0 -1)))+ ;; Literal matching+ ((string-prefix-p "=" pattern) `(orderless-literal . ,(substring pattern 1)))+ ((string-suffix-p "=" pattern) `(orderless-literal . ,(substring pattern 0 -1)))+ ;; Flex matching+ ((string-prefix-p "~" pattern) `(orderless-flex . ,(substring pattern 1)))+ ((string-suffix-p "~" pattern) `(orderless-flex . ,(substring pattern 0 -1)))))+ (setq completion-styles '(orderless)+ completion-category-defaults nil+ ;; note that despite override in the name orderless can still be used in find-file etc.+ completion-category-overrides '((file (styles . (partial-completion))))+ orderless-style-dispatchers '(+selectrum-orderless-dispatch)+ orderless-component-separator "[ &]"+ selectrum-refine-candidates-function #'orderless-filter+ selectrum-highlight-candidates-function #'orderless-highlight-matches))++(use-package! consult+ :defer t+ :init+ (fset 'multi-occur #'consult-multi-occur)+ (define-key!+ [remap apropos] #'consult-apropos+ [remap bookmark-jump] #'consult-bookmark+ [remap evil-show-marks] #'consult-mark+ [remap goto-line] #'consult-goto-line+ [remap imenu] #'consult-imenu+ [remap locate] #'consult-locate+ [remap load-theme] #'consult-theme+ [remap man] #'consult-man+ [remap recentf-open-files] #'consult-recent-file+ [remap switch-to-buffer] #'consult-buffer+ [remap switch-to-buffer-other-window] #'consult-buffer-other-window+ [remap switch-to-buffer-other-frame] #'consult-buffer-other-frame+ [remap yank-pop] #'consult-yank-pop+ [remap persp-switch-to-buffer] #'+selectrum/switch-workspace-buffer)+ (setq completion-in-region-function #'consult-completion-in-region)+ :config+ (recentf-mode)+ (setq consult-project-root-function #'doom-project-root+ completion-in-region-function #'consult-completion-in-region+ consult-narrow-key "<"+ consult-line-numbers-widen t+ consult-async-input-debounce 0.5+ consult-async-input-throttle 0.8)+ (consult-customize+ consult-ripgrep consult-git-grep consult-grep+ consult-bookmark consult-recent-file+ +default/search-project +default/search-project-for-symbol-at-point+ +default/search-other-project +selectrum/search-symbol-at-point+ +default/search-cwd +default/search-other-cwd+ +default/search-notes-for-symbol-at-point+ consult--source-file consult--source-project-file consult--source-bookmark+ :preview-key (list (kbd "C-SPC") (kbd "C-M-j") (kbd "C-M-k"))))
@minad Oh this is a very good addition to consult! There was a good chance that automatic previews on consult-theme would end up being deactivated by default due to doom's focus on responsiveness, but this might keep them around. At the very least I'll keep this around in my private config :grin:
comment created time in 2 days
Pull request review commenthlissner/doom-emacs
+;;; completion/selectrum/config.el -*- lexical-binding: t; -*-++(use-package! selectrum+ :hook (doom-first-input . selectrum-mode)+ :init+ (setq selectrum-display-action nil+ selectrum-extend-current-candidate-highlight t+ selectrum-fix-vertical-window-height 17+ selectrum-max-window-height 17+ projectile-completion-system 'default)+ (when (featurep! +prescient)+ (setq completion-styles '(substring partial-completion)))+ :config+ (defadvice! +selectrum-refresh-on-cycle (&rest _)+ :after 'marginalia-cycle+ (when (bound-and-true-p selectrum-mode) (selectrum-exhibit)))+ (defun +selectrum/backward-updir ()+ "Delete char before or go up directory for file cagetory selectrum buffers."+ (interactive)+ (if (and (eq (char-before) ?/)+ (eq (selectrum--get-meta 'category) 'file))+ (let ((new-path (minibuffer-contents)))+ (delete-region (minibuffer-prompt-end) (point-max))+ (insert (abbreviate-file-name+ (file-name-directory+ (directory-file-name+ (expand-file-name new-path))))))+ (call-interactively 'backward-delete-char)))+ (map! :map selectrum-minibuffer-map+ [backspace] #'+selectrum/backward-updir))++(use-package! selectrum-prescient+ :when (featurep! +prescient)+ :hook (selectrum-mode . selectrum-prescient-mode)+ :hook (selectrum-mode . prescient-persist-mode)+ :config+ (setq selectrum-preprocess-candidates-function #'selectrum-prescient--preprocess)+ (add-hook 'selectrum-candidate-selected-hook #'selectrum-prescient--remember)+ (add-hook 'selectrum-candidate-inserted-hook #'selectrum-prescient--remember))++(use-package! orderless+ :when (not (featurep! +prescient))+ :demand t+ :config+ (defun +selectrum-orderless-dispatch (pattern _index _total)+ (cond+ ;; Ensure that $ works with Consult commands, which add disambiguation suffixes+ ((string-suffix-p "$" pattern) `(orderless-regexp . ,(concat (substring pattern 0 -1) "[\x100000-\x10FFFD]*$")))+ ;; Ignore single !+ ((string= "!" pattern) `(orderless-literal . ""))+ ;; Without literal+ ((string-prefix-p "!" pattern) `(orderless-without-literal . ,(substring pattern 1)))+ ;; Initialism matching+ ((string-prefix-p "`" pattern) `(orderless-initialism . ,(substring pattern 1)))+ ((string-suffix-p "`" pattern) `(orderless-initialism . ,(substring pattern 0 -1)))+ ;; Literal matching+ ((string-prefix-p "=" pattern) `(orderless-literal . ,(substring pattern 1)))+ ((string-suffix-p "=" pattern) `(orderless-literal . ,(substring pattern 0 -1)))+ ;; Flex matching+ ((string-prefix-p "~" pattern) `(orderless-flex . ,(substring pattern 1)))+ ((string-suffix-p "~" pattern) `(orderless-flex . ,(substring pattern 0 -1)))))+ (setq completion-styles '(orderless)+ completion-category-defaults nil+ ;; note that despite override in the name orderless can still be used in find-file etc.+ completion-category-overrides '((file (styles . (partial-completion))))+ orderless-style-dispatchers '(+selectrum-orderless-dispatch)+ orderless-component-separator "[ &]"+ selectrum-refine-candidates-function #'orderless-filter+ selectrum-highlight-candidates-function #'orderless-highlight-matches))++(use-package! consult+ :defer t+ :init+ (fset 'multi-occur #'consult-multi-occur)+ (define-key!+ [remap apropos] #'consult-apropos+ [remap bookmark-jump] #'consult-bookmark+ [remap evil-show-marks] #'consult-mark+ [remap goto-line] #'consult-goto-line+ [remap imenu] #'consult-imenu+ [remap locate] #'consult-locate+ [remap load-theme] #'consult-theme+ [remap man] #'consult-man+ [remap recentf-open-files] #'consult-recent-file+ [remap switch-to-buffer] #'consult-buffer+ [remap switch-to-buffer-other-window] #'consult-buffer-other-window+ [remap switch-to-buffer-other-frame] #'consult-buffer-other-frame+ [remap yank-pop] #'consult-yank-pop+ [remap persp-switch-to-buffer] #'+selectrum/switch-workspace-buffer)+ (setq completion-in-region-function #'consult-completion-in-region)+ :config+ (recentf-mode)+ (setq consult-project-root-function #'doom-project-root+ completion-in-region-function #'consult-completion-in-region+ consult-narrow-key "<"+ consult-line-numbers-widen t+ consult-async-input-debounce 0.5+ consult-async-input-throttle 0.8)+ (consult-customize+ consult-ripgrep consult-git-grep consult-grep+ consult-bookmark consult-recent-file+ +default/search-project +default/search-project-for-symbol-at-point+ +default/search-other-project +selectrum/search-symbol-at-point+ +default/search-cwd +default/search-other-cwd+ +default/search-notes-for-symbol-at-point+ consult--source-file consult--source-project-file consult--source-bookmark+ :preview-key (list (kbd "C-SPC") (kbd "C-M-j") (kbd "C-M-k"))))++(use-package! consult-flycheck+ :when (featurep! :checkers syntax)+ :after (consult flycheck))++(use-package! embark+ :init+ (setq embark-action-indicator+ (lambda (map _target)+ (which-key--show-keymap "Embark" map nil nil 'no-paging)+ #'which-key--hide-popup-ignore-command)+ embark-become-indicator embark-action-indicator)+ (map! "C-;" #'embark-act ; to be moved to :config default if accepted
@minad Yeah probably. It seems like embark-dwim is primarily meant to be used on buffers, yeah? Since when using embark on the minibuffer it does the same thing as RET as far as i can tell from the keymaps.
comment created time in 2 days
startedmntmn/reform
started time in 2 days
startedhardpixel/unite-shell
started time in 2 days
Pull request review commenthlissner/doom-emacs
+;;; completion/selectrum/config.el -*- lexical-binding: t; -*-++(use-package! selectrum+ :hook (doom-first-input . selectrum-mode)+ :init+ (setq selectrum-display-action nil+ selectrum-extend-current-candidate-highlight t+ selectrum-fix-vertical-window-height 17+ selectrum-max-window-height 17+ projectile-completion-system 'default)+ (when (featurep! +prescient)+ (setq completion-styles '(substring partial-completion)))+ :config+ (defadvice! +selectrum-refresh-on-cycle (&rest _)+ :after 'marginalia-cycle+ (when (bound-and-true-p selectrum-mode) (selectrum-exhibit)))+ (defun +selectrum/backward-updir ()+ "Delete char before or go up directory for file cagetory selectrum buffers."+ (interactive)+ (if (and (eq (char-before) ?/)+ (eq (selectrum--get-meta 'category) 'file))+ (let ((new-path (minibuffer-contents)))+ (delete-region (minibuffer-prompt-end) (point-max))+ (insert (abbreviate-file-name+ (file-name-directory+ (directory-file-name+ (expand-file-name new-path))))))+ (call-interactively 'backward-delete-char)))+ (map! :map selectrum-minibuffer-map+ [backspace] #'+selectrum/backward-updir))++(use-package! selectrum-prescient+ :when (featurep! +prescient)+ :hook (selectrum-mode . selectrum-prescient-mode)+ :hook (selectrum-mode . prescient-persist-mode)+ :config+ (setq selectrum-preprocess-candidates-function #'selectrum-prescient--preprocess)+ (add-hook 'selectrum-candidate-selected-hook #'selectrum-prescient--remember)+ (add-hook 'selectrum-candidate-inserted-hook #'selectrum-prescient--remember))++(use-package! orderless+ :when (not (featurep! +prescient))+ :demand t+ :config+ (defun +selectrum-orderless-dispatch (pattern _index _total)+ (cond+ ;; Ensure that $ works with Consult commands, which add disambiguation suffixes+ ((string-suffix-p "$" pattern) `(orderless-regexp . ,(concat (substring pattern 0 -1) "[\x100000-\x10FFFD]*$")))+ ;; Ignore single !+ ((string= "!" pattern) `(orderless-literal . ""))+ ;; Without literal+ ((string-prefix-p "!" pattern) `(orderless-without-literal . ,(substring pattern 1)))+ ;; Initialism matching+ ((string-prefix-p "`" pattern) `(orderless-initialism . ,(substring pattern 1)))+ ((string-suffix-p "`" pattern) `(orderless-initialism . ,(substring pattern 0 -1)))+ ;; Literal matching+ ((string-prefix-p "=" pattern) `(orderless-literal . ,(substring pattern 1)))+ ((string-suffix-p "=" pattern) `(orderless-literal . ,(substring pattern 0 -1)))+ ;; Flex matching+ ((string-prefix-p "~" pattern) `(orderless-flex . ,(substring pattern 1)))+ ((string-suffix-p "~" pattern) `(orderless-flex . ,(substring pattern 0 -1)))))+ (setq completion-styles '(orderless)
Code completion with company was so weird when completion-styles is set to '(orderless) only.
In Emacs Lisp mode, when I type set, the first candidate to appear was (setf seq-elt) even though set, setq, setf, etc. were expected instead.
Appending, rather than setting so a single style, seems to revert company to it's old behavior but M-x is still sorted.
(add-to-list 'completion-styles 'orderless t)
comment created time in 2 days