profile
viewpoint
Michael Gottesman gottesmm Apple, Inc. San Francisco, CA

llvm/llvm-project 7402

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. Note: the repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

gottesmm/swift 2

The Swift Programming Language

gottesmm/llvm 0

Mirror of official llvm git repository located at http://llvm.org/git/llvm. Updated every five minutes.

gottesmm/magit-gh-pulls 0

Magit plugin for dealing with GitHub pull requests

gottesmm/swift-corelibs-foundation 0

The Foundation Project, providing core utilities, internationalization, and OS independence

create barnchapple/swift

branch : shahmishal/test-version-bump

created branch time in 3 minutes

pull request commentapple/swift

SIL: let SingleValueInstruction only inherit from a single SILNode.

@atrick the size of SingleValueInstruction is still 10 words (2 for the inst-list node, 1 for the parent, 3 for ValueBase and 4 for the debug location). Though, I believe we could get the debug location down to 3 words, or even less.

eeckstein

comment created time in 23 minutes

pull request commentapple/swift

SIL: let SingleValueInstruction only inherit from a single SILNode.

@swift-ci smoke test

eeckstein

comment created time in 36 minutes

pull request commentapple/swift

[ClangImporter] Adopt change for preprocessor option, `DisablePCHValidation`

https://github.com/apple/llvm-project/pull/2370

@swift-ci smoke test OS X platform

akyrtzi

comment created time in an hour

pull request commentapple/swift

[ClangImporter] Adopt change for preprocessor option, `DisablePCHValidation`

@swift-ci smoke test OS X platform

akyrtzi

comment created time in an hour

pull request commentapple/swift

[ClangImporter] Adopt change for preprocessor option, `DisablePCHValidation`

https://github.com/apple/llvm-project/pull/2370

@swift-ci smoke test

akyrtzi

comment created time in 3 hours

push eventapple/swift

Richard Howell

commit sha 6b6e5b84a6b9fe8ba8acbbb6f30cfddf66d3ebd1

[Testing] Add missing REQUIRES: concurrency

view details

Saleem Abdulrasool

commit sha 997cb0f6719c3f487795f1f7487c6364e1dd44e1

Platform: add HLSL compiler to the WinSDK modulemap The DirectX subsystem may require access to the HLSL compiler for building the shaders before uploading to the GPU. This is adds to the modulemap the D3DCompiler module to get access to the compiler.

view details

Saleem Abdulrasool

commit sha 3c9e76d5fe7dbae6f69ad7e8f7a21ac7aa682c62

Concurrency: attempt to handle Windows draining Rather than just simply invoking abort on Windows, attempt to load dispatch and execute the main loop by looking up `dispatch_main` in the module. Assuming that dispatch was used already, the `LoadLibraryW` will provide the handle to the module currently mapped in. This still is not correct, since we do not link to libdispatch, so we cannot have invoked any dispatch queuing methods. However, this is better than the previous behaviour of simply aborting. This resolves the symptom in SR-14086, but not the underlying problem.

view details

3405691582

commit sha 6adaf48e96a30e85175ee64bdc6c38e97e25833a

[stdlib] Add missing Glibc dependency for OpenBSD. Otherwise, the build may fail as the build attempts to build SwiftReflectionTest before Glibc has been built.

view details

Saleem Abdulrasool

commit sha e08ba66ec6c3b2f3197cbccbbbf0c83518bbdd57

Merge pull request #35577 from compnerd/infinite-loop-rather-than-explode Concurrency: attempt to handle Windows draining

view details

Saleem Abdulrasool

commit sha 682eeb4be71ccc8bbfc027f14f95e3ce766b7d3c

Merge pull request #35578 from 3405691582/ReflectionTestDependsOnGlibc [stdlib] Add missing Glibc dependency for OpenBSD.

view details

Saleem Abdulrasool

commit sha 0f47bd3e198f6234edf8054c96af35fca34dae20

Merge pull request #35562 from rmaz/concurrency_fixes [Testing] Add missing REQUIRES: concurrency

view details

Saleem Abdulrasool

commit sha bbe3d4fb18db701e9d32292d28a53b2a22668edf

Merge pull request #35576 from compnerd/hlsl Platform: add HLSL compiler to the WinSDK modulemap

view details

swift_jenkins

commit sha 8e86724bca7b91fd950f4164a4c33c3f5808ebb0

Merge remote-tracking branch 'origin/main' into next

view details

push time in 4 hours

PR opened apple/swift

[5.4][stdlib] Add missing Glibc dependency for OpenBSD.

Original description Otherwise, the build may fail as the build attempts to build SwiftReflectionTest before Glibc has been built.

Rationale

  • Explanation: Ensures build succeeds consistently.
  • Scope: Bugfix/platform support change.
  • SR issue: None.
  • Risk: Likely minimal: dependencies for existing platforms not modified.
  • Testing: Change has already landed on main branch (see #35578); this pr is a cherry-pick of that commit.
  • Reviewer: cc @kylemacomber please and thank you.

Please let me know if anything else is required.

+1 -0

0 comment

1 changed file

pr created time in 5 hours

push eventapple/swift

Richard Howell

commit sha 6b6e5b84a6b9fe8ba8acbbb6f30cfddf66d3ebd1

[Testing] Add missing REQUIRES: concurrency

view details

Saleem Abdulrasool

commit sha 997cb0f6719c3f487795f1f7487c6364e1dd44e1

Platform: add HLSL compiler to the WinSDK modulemap The DirectX subsystem may require access to the HLSL compiler for building the shaders before uploading to the GPU. This is adds to the modulemap the D3DCompiler module to get access to the compiler.

view details

3405691582

commit sha 6adaf48e96a30e85175ee64bdc6c38e97e25833a

[stdlib] Add missing Glibc dependency for OpenBSD. Otherwise, the build may fail as the build attempts to build SwiftReflectionTest before Glibc has been built.

view details

Saleem Abdulrasool

commit sha 682eeb4be71ccc8bbfc027f14f95e3ce766b7d3c

Merge pull request #35578 from 3405691582/ReflectionTestDependsOnGlibc [stdlib] Add missing Glibc dependency for OpenBSD.

view details

Saleem Abdulrasool

commit sha 0f47bd3e198f6234edf8054c96af35fca34dae20

Merge pull request #35562 from rmaz/concurrency_fixes [Testing] Add missing REQUIRES: concurrency

view details

Saleem Abdulrasool

commit sha bbe3d4fb18db701e9d32292d28a53b2a22668edf

Merge pull request #35576 from compnerd/hlsl Platform: add HLSL compiler to the WinSDK modulemap

view details

swift-ci

commit sha d78c1db1a16beec9d8f8262030500570f1060f7b

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 5 hours

push eventapple/swift

Saleem Abdulrasool

commit sha 997cb0f6719c3f487795f1f7487c6364e1dd44e1

Platform: add HLSL compiler to the WinSDK modulemap The DirectX subsystem may require access to the HLSL compiler for building the shaders before uploading to the GPU. This is adds to the modulemap the D3DCompiler module to get access to the compiler.

view details

Saleem Abdulrasool

commit sha bbe3d4fb18db701e9d32292d28a53b2a22668edf

Merge pull request #35576 from compnerd/hlsl Platform: add HLSL compiler to the WinSDK modulemap

view details

push time in 6 hours

PR merged apple/swift

Platform: add HLSL compiler to the WinSDK modulemap

The DirectX subsystem may require access to the HLSL compiler for building the shaders before uploading to the GPU. This is adds to the modulemap the D3DCompiler module to get access to the compiler.

<!-- What's in this pull request? --> Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-NNNN.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+17 -3

2 comments

1 changed file

compnerd

pr closed time in 6 hours

push eventapple/swift

Richard Howell

commit sha 6b6e5b84a6b9fe8ba8acbbb6f30cfddf66d3ebd1

[Testing] Add missing REQUIRES: concurrency

view details

Saleem Abdulrasool

commit sha 0f47bd3e198f6234edf8054c96af35fca34dae20

Merge pull request #35562 from rmaz/concurrency_fixes [Testing] Add missing REQUIRES: concurrency

view details

push time in 6 hours

PR merged apple/swift

[Testing] Add missing REQUIRES: concurrency

This change adds a requirement on the concurrency feature in 3 tests. Without this change and with SWIFT_ENABLE_EXPERIMENTAL_CONCURRENCY set to NO the tests will fail with errors like:

<unknown>:0: error: unexpected error produced: no such module '_Concurrency'
+3 -1

2 comments

3 changed files

rmaz

pr closed time in 6 hours

push eventapple/swift

3405691582

commit sha 6adaf48e96a30e85175ee64bdc6c38e97e25833a

[stdlib] Add missing Glibc dependency for OpenBSD. Otherwise, the build may fail as the build attempts to build SwiftReflectionTest before Glibc has been built.

view details

Saleem Abdulrasool

commit sha 682eeb4be71ccc8bbfc027f14f95e3ce766b7d3c

Merge pull request #35578 from 3405691582/ReflectionTestDependsOnGlibc [stdlib] Add missing Glibc dependency for OpenBSD.

view details

push time in 6 hours

PR merged apple/swift

[stdlib] Add missing Glibc dependency for OpenBSD.

Otherwise, the build may fail as the build attempts to build SwiftReflectionTest before Glibc has been built.

+1 -0

1 comment

1 changed file

3405691582

pr closed time in 6 hours

pull request commentapple/swift

[SR-12033] [Sema] Do not allow inferring defaultable closure `() -> $T` for autoclosure arguments result

I'm working on making it right now. The idea is that determineBestBindings can avoid having to gather constraints and re-compute bindings all the time since that's just wasted work if constraints didn't change, instead bindings could be tracked in constraint graph as constraints are introduced and removed.

Awesome, it seems that it will give a good speed up on inference 🎉 So for this PR, should we wait on those changes to land to avoid any issues?

LucianoPAlmeida

comment created time in 7 hours

pull request commentapple/swift

[SR-14050][Sema] Removing check on subtype validation at matchFunctionRepresentations

@swift-ci Please test source compatibility

LucianoPAlmeida

comment created time in 7 hours

PR opened apple/swift

Reviewers
[SR-14050][Sema] Removing check on subtype validation at matchFunctionRepresentations

<!-- What's in this pull request? --> For what I could see and test seems is just fine to remove this check and just adding a bit more information. Most relations between function types are handled by conversions. I'm running the tests to make sure, but let me know if you think there are some situation where the check still be necessary.

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-14050.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+8 -5

0 comment

1 changed file

pr created time in 7 hours

push eventapple/swift

Saleem Abdulrasool

commit sha 3c9e76d5fe7dbae6f69ad7e8f7a21ac7aa682c62

Concurrency: attempt to handle Windows draining Rather than just simply invoking abort on Windows, attempt to load dispatch and execute the main loop by looking up `dispatch_main` in the module. Assuming that dispatch was used already, the `LoadLibraryW` will provide the handle to the module currently mapped in. This still is not correct, since we do not link to libdispatch, so we cannot have invoked any dispatch queuing methods. However, this is better than the previous behaviour of simply aborting. This resolves the symptom in SR-14086, but not the underlying problem.

view details

Saleem Abdulrasool

commit sha e08ba66ec6c3b2f3197cbccbbbf0c83518bbdd57

Merge pull request #35577 from compnerd/infinite-loop-rather-than-explode Concurrency: attempt to handle Windows draining

view details

swift-ci

commit sha a63af72d7baa50014db237aed966ea9816b597fb

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 7 hours

push eventapple/swift

Saleem Abdulrasool

commit sha 3c9e76d5fe7dbae6f69ad7e8f7a21ac7aa682c62

Concurrency: attempt to handle Windows draining Rather than just simply invoking abort on Windows, attempt to load dispatch and execute the main loop by looking up `dispatch_main` in the module. Assuming that dispatch was used already, the `LoadLibraryW` will provide the handle to the module currently mapped in. This still is not correct, since we do not link to libdispatch, so we cannot have invoked any dispatch queuing methods. However, this is better than the previous behaviour of simply aborting. This resolves the symptom in SR-14086, but not the underlying problem.

view details

Saleem Abdulrasool

commit sha e08ba66ec6c3b2f3197cbccbbbf0c83518bbdd57

Merge pull request #35577 from compnerd/infinite-loop-rather-than-explode Concurrency: attempt to handle Windows draining

view details

push time in 8 hours

PR merged apple/swift

Concurrency: attempt to handle Windows draining

Rather than just simply invoking abort on Windows, attempt to load dispatch and execute the main loop by looking up dispatch_main in the module. Assuming that dispatch was used already, the LoadLibraryW will provide the handle to the module currently mapped in. This still is not correct, since we do not link to libdispatch, so we cannot have invoked any dispatch queuing methods. However, this is better than the previous behaviour of simply aborting.

This resolves the symptom in SR-14086, but not the underlying problem.

<!-- What's in this pull request? --> Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-NNNN.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+18 -6

4 comments

1 changed file

compnerd

pr closed time in 8 hours

pull request commentapple/swift

Concurrency: attempt to handle Windows draining

CoreFoundation does build/work on Windows. However, we do not have a build of CoreFoundation handy. That is actually a bug in the implementation for non-Darwin platforms (I have another patch for that I will be putting up). The CoreFoundation implementation in Foundation is not meant to be used outside of Foundation (as per @millenomi).

compnerd

comment created time in 8 hours

push eventapple/swift

Minhyuk Kim

commit sha f138ce0b199da0f2153577ea82e35c0180208b18

Add specific warning for overriden `NSObject.hash(into:)`

view details

Minhyuk Kim

commit sha 5c21cdf4a66a64c4a8c6ab8cf9fa7628f9c996eb

Modify override_decl_extension error to be more descriptive

view details

Robert Widmann

commit sha c2163703fdffdca2f9faf59e4a16504bb3958a78

Merge pull request #35465 from mininny/objc-override-hash-warning [Diagnostics] Add specific warning for overriden `NSObject.hash(into:)`

view details

swift_jenkins

commit sha 4aaace9999ae46a152327dfcc5402c8a505fa958

Merge remote-tracking branch 'origin/main' into next

view details

push time in 8 hours

pull request commentapple/swift

[TSan] Don't instrument inout accesses on known-empty types

@swift-ci Please smoke test

devincoughlin

comment created time in 8 hours

PR opened apple/swift

[TSan] Don't instrument inout accesses on known-empty types

Empty types (such as structs without stored properties) have a meaningless value for their address. To avoid crashes in the Thread Sanitizer runtime, rather than passing this unspecified value as the address of the inout access, skip emission of the runtime call.

The bug allowing unspecified behavior here has been present since we first added TSan support for checking Swift access races -- but codegen changes on arm64 have recently made crashes due to the bug much more likely.

rdar://problem/47686212

+38 -0

0 comment

2 changed files

pr created time in 8 hours

pull request commentapple/swift

Concurrency: attempt to handle Windows draining

Does CoreFoundation compile/work for Windows? If yes, could we match the Mac/Linux behaviour and check for CFRunLoopRun first and use that if present before falling back on dispatch_main? If not, oh well, don't worry about it, LGTM. Thanks for fixing this.

compnerd

comment created time in 9 hours

pull request commentapple/swift

[Pending Evolution] Super call enforcement

Thanks for the feedback, I’ll address them shortly!

theblixguy

comment created time in 9 hours

pull request commentapple/swift

Update guide to mention correct subdirectory

Yes, it seems https://github.com/apple/swift/commit/565385b6b07335f7e66da1f693054b7085894fd8 is what broke it.

brentleyjones

comment created time in 10 hours

Pull request review commentapple/swift

Update guide to mention correct subdirectory

 toolchain as a one-off, there are a couple of differences:      If you plan on contributing regularly, cloning over SSH provides a better      experience. After you've [uploaded your SSH keys to GitHub][]:      ```sh-     git clone git@github.com:apple/swift.git .+     git clone git@github.com:apple/swift.git swift

The dot is what makes it incorrect. Unless we change to the swift directory first.

brentleyjones

comment created time in 10 hours

more