profile
viewpoint

llvm/llvm-project 7441

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. Note: the repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

apple/swift-syntax 1489

SwiftPM package for SwiftSyntax library.

akyrtzi/cairo-gral 10

A hardware accelerated cairo backend. Leverages GPU hardware as much as possible and minimizes CPU usage.

nathawes/swift 1

The Swift Programming Language

akyrtzi/indexstore-db 0

Index database library for use with sourcekit-lsp

akyrtzi/sourcekit-lsp 0

Language Server Protocol implementation for Swift and C-based languages

akyrtzi/swift 0

The Swift Programming Language

akyrtzi/swift-cmark 0

CommonMark parsing and rendering library and program in C

delete branch apple/swift-source-compat-suite

delete branch : revert-486-xfail-swift-futures

delete time in 2 hours

push eventapple/swift-source-compat-suite

Mishal Shah

commit sha 0a26e9c88a76e1fa28373e5ce239aa1d2fa0768f

Revert "Xfail swift-futures"

view details

Mishal Shah

commit sha 66870bdf5891961ea417a9aaa123229e63da9952

Merge pull request #488 from apple/revert-486-xfail-swift-futures Revert "Xfail swift-futures"

view details

push time in 2 hours

PR merged apple/swift-source-compat-suite

Revert "Xfail swift-futures"

Reverts apple/swift-source-compat-suite#486

Fixed - https://github.com/apple/swift/pull/35596

+1 -6

1 comment

1 changed file

shahmishal

pr closed time in 2 hours

pull request commentapple/swift-driver

Propagate Experimental Cross Module Incremental Build Flag

I'd feel significantly better if this PR included some unit test additions to test out the new kind of dependency.

There are tests for what functionality we can observe at this time, which is the propagation of this flag. Without the integration code (which requires the bitstream writer I have just submitted to TSC) I cannot unit test any further behaviors of the system because... well, there aren't many other new behaviors here.

Thanks for your answer. Good point. Maybe as the new behaviors are added there will be tests that could be added to FineGrainedDependencyTests.cpp. Those tests were very helpful to me in the past for finding bugs in the code I was writing.

CodaFi

comment created time in 3 hours

pull request commentapple/swift-source-compat-suite

Revert "Xfail swift-futures"

@swift-ci test

shahmishal

comment created time in 4 hours

PR opened apple/swift-source-compat-suite

Reviewers
Revert "Xfail swift-futures"

Reverts apple/swift-source-compat-suite#486

Fixed - https://github.com/apple/swift/pull/35596

+1 -6

0 comment

1 changed file

pr created time in 4 hours

create barnchapple/swift-source-compat-suite

branch : revert-486-xfail-swift-futures

created branch time in 4 hours

delete branch apple/swift-source-compat-suite

delete branch : shahmishal/xfail-swift-futures-release

delete time in 4 hours

pull request commentapple/swift-source-compat-suite

XFail swift-futures only for release not debug

We dont need this any more because @atrick already fixed the compiler issue.

shahmishal

comment created time in 4 hours

pull request commentapple/swift-source-compat-suite

XFail swift-futures only for release not debug

./swift-source-compat-suite/utils/format_projects_list.py swift-source-compat-suite/projects.json

Passed

shahmishal

comment created time in 4 hours

pull request commentapple/swift-source-compat-suite

XFail swift-futures only for release not debug

@swift-ci test

shahmishal

comment created time in 4 hours

created tagapple/sourcekit-lsp

tagswift-DEVELOPMENT-SNAPSHOT-2021-01-26-a

Language Server Protocol implementation for Swift and C-based languages

created time in 11 hours

created tagapple/swift-driver

tagswift-DEVELOPMENT-SNAPSHOT-2021-01-26-a

Swift compiler driver reimplementation in Swift

created time in 11 hours

created tagapple/swift-syntax

tagswift-DEVELOPMENT-SNAPSHOT-2021-01-26-a

SwiftPM package for SwiftSyntax library.

created time in 11 hours

created tagapple/indexstore-db

tagswift-DEVELOPMENT-SNAPSHOT-2021-01-26-a

Index database library for use with sourcekit-lsp

created time in 11 hours

created tagapple/swift-stress-tester

tagswift-DEVELOPMENT-SNAPSHOT-2021-01-26-a

Stress testing utilities for Swift's tooling

created time in 11 hours

created tagapple/swift-cmark

tagswift-DEVELOPMENT-SNAPSHOT-2021-01-26-a

CommonMark parsing and rendering library and program in C

created time in 11 hours

created tagapple/swift-llbuild

tagswift-DEVELOPMENT-SNAPSHOT-2021-01-26-a

A low-level build system, used by Xcode and the Swift Package Manager

created time in 11 hours

delete branch apple/swift-source-compat-suite

delete branch : drop-project-py

delete time in 16 hours

push eventapple/swift-source-compat-suite

Mishal Shah

commit sha 51e08a09ae2b69b219575490da5849793cfa8304

Use project_future over project file

view details

Zachary 'Clack' Cole

commit sha 2921e70aef933e188d179a0b2380c9a37687d2b0

Merge pull request #485 from apple/drop-project-py Use project_future over project file

view details

push time in 16 hours

delete branch apple/swift-source-compat-suite

delete branch : add-swift-atomics

delete time in 18 hours

push eventapple/swift-source-compat-suite

Clack Cole

commit sha 313052788f7da41638e7ac174e678da0c0c40854

Add swift-atomics

view details

Clack Cole

commit sha 08c48d4f9c38f264dce5834804d2a4ea652e0527

Include swiftpm tag

view details

Clack Cole

commit sha a22867507df66736ffbf942bd9eaac9cf49bf854

Include Linux for swift-atomics

view details

Zachary 'Clack' Cole

commit sha 317de46876e1ded3da4626ebb621d6bfa567aced

Merge branch 'main' into add-swift-atomics

view details

Zachary 'Clack' Cole

commit sha 042fb167425a97a946b53d625a01ddf480fba7e5

Merge branch 'main' into add-swift-atomics

view details

Mishal Shah

commit sha 0ad488f8d1dcf194784abdbd3903ee7c84088ca0

Merge pull request #476 from apple/add-swift-atomics Add swift-atomics

view details

push time in 18 hours

PR merged apple/swift-source-compat-suite

Reviewers
Add swift-atomics

Pull Request Description

Add https://github.com/apple/swift-atomics

Acceptance Criteria

  • [x] be an Xcode or swift package manager project
  • [x] support building on either Linux or macOS
  • [x] target Linux, macOS, or iOS/tvOS/watchOS device
  • [x] be contained in a publicly accessible git repository
  • [x] maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • [x] have maintainers who will commit to resolve issues in a timely manner
  • [x] be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • [x] add value not already included in the suite
  • [x] be licensed with one of the following permissive licenses:
    • Apache License, version 2.0
  • [x] pass ./project_precommit_check script run
PASS: swift-atomics, 5.2, df9f81, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- swift-atomics checked successfully against Swift 5.2 ---
+27 -0

12 comments

1 changed file

clackary

pr closed time in 18 hours

pull request commentapple/swift-driver

Propagate Experimental Cross Module Incremental Build Flag

I'd feel significantly better if this PR included some unit test additions to test out the new kind of dependency.

There are tests for what functionality we can observe at this time, which is the propagation of this flag. Without the integration code (which requires the bitstream writer I have just submitted to TSC) I cannot unit test any further behaviors of the system because... well, there aren't many other new behaviors here.

CodaFi

comment created time in 19 hours

pull request commentapple/swift-driver

[NFC, Incremental] Use let's instead of var's for the ChangedInput struct.

let in structs is almost an attractive nuisance. An assignment to a struct field declared as a var behaves semantically identically to a complete re-creation of the struct and its fields but with the point-mutation applied, which is what this kind of refactoring inspires users to type explicitly when they inevitably discover they don't have access to the setter. You don't really... win anything.

davidungar

comment created time in 19 hours

pull request commentapple/swift-driver

[NFC, Incremental] Use let's instead of var's for the ChangedInput struct.

But it doesn't need to be mutable

That's not what var and let signal primarily in this language. In particularly, let is semantically stronger than something like const. It is an anti-pattern to use let for struct fields that are not semantically constants in most cases. All it does is make it harder to use - and in particular initialize - instances of this value in a way that does not go through the memberwise initializer. I am neutral on its removal given that we do not have code mutating through these members, but for the future this kind of refactoring is not always a positive.

davidungar

comment created time in 19 hours

more