profile
viewpoint
Fredrik Enestad fredr Soundtrack Your Brand AB Stockholm, Sweden https://soundtrackyourbrand.com

djonsson/jenkins-atlassian-theme 270

Jenkins improved UI - Atlassian style

fredr/dydb 6

Command line tool for AWS DynamoDB

fredr/caseconv 4

A very simple case converter in go

fredr/climux 3

A mux for the cli in go

fredr/dotfiles 3

fredr dotfiles

fredr/cp_ios 1

Coffee & Power's iOS app

fredr/godep 1

dependency tool for go

fredr/absinthe 0

The GraphQL toolkit for Elixir

fredr/absinthe-graphql-playground 0

GraphQL Playground for Absinthe

fredr/absinthe-socket 0

Core JavaScript support for Absinthe WS-based operations

issue commentgrafana/grafana

Explore/Loki: persist parsed fields toggling across queries refresh

Maybe this PR will make you happy then #27409. slightly_smiling_face When implemented for Explore.

It makes me very happy! :smile:

cippaciong

comment created time in 19 days

issue commentgrafana/grafana

Explore/Loki: persist parsed fields toggling across queries refresh

Adding it to the URL would make me happy, since it would then be preserved when pasting links to team members while debugging problems. But it would also result in quite long and "ugly" urls.

cippaciong

comment created time in 19 days

issue commentgrafana/grafana

Explore/Loki: persist parsed fields toggling across queries refresh

Since the ui state was removed from the url in #27753 we can't add it there. I'll dig into this to see if there is an other way of solving the refresh problem

cippaciong

comment created time in 21 days

push eventgrafana/grafana

Fredrik Enestad

commit sha 266aba71ebd4d81ffe9b8397a7bf8e6c8edd1ff1

Add Fredrik Enestad as member (#27959)

view details

push time in 24 days

delete branch grafana/grafana

delete branch : add-fredr

delete time in 24 days

PR merged grafana/grafana

Add Fredrik Enestad as member
+1 -0

5 comments

1 changed file

fredr

pr closed time in 24 days

pull request commentgrafana/grafana

Add Fredrik Enestad as member

@daniellee cheers, now it works! 🙏🍾🥂

fredr

comment created time in 24 days

pull request commentgrafana/grafana

Add Fredrik Enestad as member

welcome to the team!

Thank you!

Do you want to merge the PR yourself? You should have permision to now.

I'm not able to merge because of the restrictions on master

Screenshot from 2020-10-01 17-19-57

fredr

comment created time in 25 days

PR opened grafana/grafana

Add Fredrik Enestad as member
+1 -0

0 comment

1 changed file

pr created time in 25 days

create barnchgrafana/grafana

branch : add-fredr

created branch time in 25 days

pull request commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

Just quick Question does it support in Dashboard ?

The toggle parsed fields functionality has only been added for the Explore view. For dashboards it would need some more discussion with the grafana team of how/if that should work. Maybe via a transform. I would suggest starting a conversation about it on slack, or create a separate issue about it on github

fredr

comment created time in a month

pull request commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

@cloudcafetech Your regex expects the format trace_id=id or traceID=id and in the log message that I can see in the screenshot it is in the format "trace_id": "id", so maybe you need to change your regex? Something like "(?:trace_id|traceID)": "(\w+)"

fredr

comment created time in a month

issue commentgrafana/grafana

Explore/Loki: persist parsed fields toggling across queries refresh

I would like it to be persisted in the URL state (in ExploreUIState maybe). That would (I think) solve this issue, and it would also be possible to share links with toggled fields. (And it would also be saved to history/starred queries I think).

cippaciong

comment created time in a month

push eventfredr/grafana

Torkel Ödegaard

commit sha c80da5f2f9c9734e98633e6b8ccb4404122e155e

Transformers: Removed display name from reduced fields (#27141)

view details

Yoan Blanc

commit sha 69df8b424c23284ef58393c19961b794fadf77c9

Docs: zipkin links to Loki documentation (#27144)

view details

Hugo Häggmark

commit sha 09a1af3f91e3d686d45e65bba5326865abfcfa2a

Variables: Fixes issue with All variable not being resolved (#27151) * Variables: Fixes issue with All variable not being resolved * Tests: update tests according to changes

view details

Emil Tullstedt

commit sha 954a2811b3f00bb5d4d0b40426bf3daedaf50215

Stats: Stop counting the same user multiple times (#26777) * Stats: Cache based stats implementation * Stats: Correct logic and add larger scale test * Stats: linter * Stats: SQL implementation * Stats: cleanup SQL * Stats: Tab -> Spaces * Update pkg/services/sqlstore/stats.go Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com> * Stats: Quote 'user' table with dialect.Quote * Stats: Ensure test is run as integration test * Stats: Use boolean value ...because if (v) { true } else { false } is unnecessary at best. Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>

view details

Dominik Prokop

commit sha f7950491a3edbafbcea3b6a952893f1c30304f99

Field overrides: Overrides UI improvements (#27073) * Add filter name by regex matcher for overrides * Update docs * Introduce UI improvements to overrides list * Update public/app/features/dashboard/components/PanelEditor/OverrideEditor.tsx Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> * Review improvements * Fix merge * Remove ellipsis Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com>

view details

Alex Khomenko

commit sha 4a6268014af5ae01c0a1ed848a9bdecdcb29cebf

Grafana-UI: Add story and mdx file (#27152)

view details

Kyle Brandt

commit sha 1778e9f03435bcc1a4db16fd7f5e680f8a0f7159

Alerting: remove LongToWide call in alerting (#27140) causing issues and currently as we use it, the query should be requesting it as part of the query model via fromat as time series fixes #27132

view details

kay delaney

commit sha b54c0b5d52e79ba67d72444c80a5dd713099d1d1

UI/ClickOutsideWrapper: Fix for undesirable timepicker behavior (#27164)

view details

Diana Payton

commit sha 1502722129efeba5091a35661a03929e18d9923e

Docs: Add FAQcontent (#27139) * update content * updated content * update content * Update graphite.md

view details

Will Browne

commit sha ed6f0663c217f04b2c07344e49cbb8d70504346b

Alerting: Store sensitive settings encrypted for Sensu notifier (#27131) * encrypt password * update docs

view details

Will Browne

commit sha bbbbf9ac422f1f06e60a7f509d26dc9a6e5adac0

Alerting: Store sensitive settings encrypted for LINE notifier (#27157) * encrypt token * update docs

view details

Will Browne

commit sha 30d6405c536ebcf91d8466852533f0ad22278743

Alerting: Store sensitive settings encrypted for Pushover notifier (#27159) * encrypt api + user keys * update docs * fix decrypt steps

view details

Will Browne

commit sha daaa3e571bf7d7e4fb662a57506e7305442d3c21

Alerting: Store sensitive settings encrypted for Threema notifier (#27160) * encrypt API secret * update docs

view details

Ryan McKinley

commit sha cd9a773427ff04ef92ef6d896d8a87d151eb2e5d

InfluxDB: use converters from SDK (#27138)

view details

Simon Podlipsky

commit sha 84eb03e7e55fef7b288abf39827a23b128b896d8

BackendSrv: Use uuid v4 as an identifier instead of Date.now() (#27176)

view details

Emil Tullstedt

commit sha d5687cce1181fdd36ff376eb5af9d102938c9f0b

Stats: Correct the number of arguments for SQL call (#27182) * Stats: Correct the number of arguments for SQL call * Stats: Run admin stats call as integration test

view details

Torkel Ödegaard

commit sha ddabf4ade1db0c4491aff227d5aa22b7dca7a0c4

Transforms: Labels to fields rewrite that uses merge transform inside it (#27125) * testing things * POC: Simplify labels to fields by using merge transform inside it * removed old code * Fixed test ts issues * Added valueLabel field option * Updated merge transform tests to not expect a sort * fixed type * refactoring to minimize nesting

view details

Torkel Ödegaard

commit sha 88fbdd6716a49ef82d529769e9e078add6d1d9db

DisplayProcessor: Show strings as strings (#27097) * WIP: strings and numbers * Works in displayProcessor but units are not applied in applyFieldOverride * removed bit * Updated * Added docs * fixed typo

view details

Alex Khomenko

commit sha f5ee1f93cd73043dce857672adc6fa5d6fc2278f

Grafana-UI: Alert components tweaks (#27128) * Grafana-UI: Add Alert docs and story * Grafana-UI: Move Alert styles to emotion * Grafana-UI: Tweak docs * Grafana-UI: Update test * Grafana-UI: Add outline to custom content * Grafana-UI: Remove class name * Grafana-UI: Remove _Alert.scss * Grafana-UI: Add e2e Alert selector * Grafana-UI: Use @deprecated * Grafana-UI: Remove circular reference * Grafana-UI: Final tweaks

view details

Fredrik Enestad

commit sha 6a01bab67c47b6e7c4328efd227d62b8a69fbe84

Allow toggling of derived fields (#27148)

view details

push time in a month

push eventfredr/loki

Robert Fratto

commit sha ee67b9c70728e3ac97c341425ac8ede66ee0545e

Expose UserAgent and fix User-Agent version source (#2603) * Use prometheus/common/version for reporting build version in User Agent header Promtail wasn't using github.com/prometheus/common/version for the User-Agent header when obtaining the build version. Instead, it imported github.com/grafana/loki/pkg/build which modifies the Prometheus version package on init. This causes problems for importers that also import and modify github.com/prometheus/common/version with their own build information (i.e., grafana/agent). This PR changes Promtail to obtain the build info from the common dependency to obtain the correct build information regardless of how Promtail is being run. * expose UserAgent to allow it to be modifiable by importers

view details

Ed Welch

commit sha 2015763327eb9c4c4c4d437d5f9bd44ef8dee9bf

Loki: Fix query-frontend ready handler (#2610) * query frontend should not have a default route as it usurps the ready handler, the ready handler was also not implemented completely for the query frontend. * enable ready check for query-frontend in ksonnet

view details

push time in 2 months

PR opened grafana/loki

Dashboard: typo in Loki Operational dashboard

seconds_seconds => seconds

+4 -4

0 comment

1 changed file

pr created time in 2 months

push eventfredr/loki

Fredrik Enestad

commit sha 0b15185454ec73571f9145da909d622605a0ec9d

typo in operational dashboard seconds_seconds => seconds

view details

push time in 2 months

push eventfredr/loki

Mercedes Arias-Duval

commit sha 8ebac4ced0aaa7a43b5df22ca13671d7e31f7fca

Update logql.md (#2125) * Update logql.md Edited grammar, syntax, typos and added a few lists to make the document easier to read. * Update docs/logql.md Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * Update docs/logql.md Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * Update docs/logql.md Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> Co-authored-by: Owen Diehl <ow.diehl@gmail.com> Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>

view details

Fredrik Enestad

commit sha c3d3f2ba777a9f57a95e5b2ec67b641af9d69922

docs: BoltDB typo (#2217)

view details

Takayuki Watanabe

commit sha 59f312545cb69ca206afa699b1ae39fb09b74d58

Improve fluentd plugin development experience (#2179) * Add Gemfile.lock and .rspec_status to .gitignore * Converge gem definition in gemspec file * Add missing `bundle exec` to README * s/FluentD/Fluentd/g

view details

Joshua Hügli

commit sha 1127d9328b6472597afd26c409caf2ad57e27b43

BUG: add missing namespace in ingress object (#2205) * add missing namespace in ingress object * update chart version * bump loki stack as well

view details

Sandeep Sukhani

commit sha f04bc99e05d8a1a81e97ee9220298328e0ef0d5e

query tee proxy with support for comparison of responses (#2211)

view details

Richard Hartmann

commit sha 0ecaa108c1de8b7a9e45b9d47e193949b9ab559e

[WIP] Propose new governance (#2137) Add new governance Signed-off-by: Richard Hartmann <richih@richih.org> Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>

view details

Takayuki Watanabe

commit sha e2a7941e326a57f2c42de1d26f4cb198e2a199cb

Add server TLS certificate verification (#2171) * Add server TLS certificate verification * Generalize use of server TLS certificate verification * Fix typo * Bump fluent-plugin-grafana-loki gem version: 1.2.12 -> 1.2.13 * Replace option: verify_tls -> insecure_tls * Update document * Update docs/clients/fluentd/README.md Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>

view details

vhrosales

commit sha 4dd7a6c639af1676adcc0eed2abb0ba1cb640896

helm: Add loadBalancerIP option to loki chart (#2238) * Add loadBalancerIP option for LoadBalancer service type * Bump minor version * Bump loki-stack minor version

view details

Peter Štibraný

commit sha 9bf1130f088e706e3dcf2451d2172bcdf5db7203

Remove single newline from the line before printing. (#2235) Lines are printed with Println, so this avoids having extra empty line between printed log lines. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Periklis Tsirakidis

commit sha 815c47533e0659fb749923b8c975d151054da513

Replace memberlist service in favor of cortex provided service (#2224) * Bump cortex deps to include non-experimental memberlist service * Replace memberlist service in favor of cortex provided service * Fix route method param for querytee tool * Register memberlist flags * Add documentation and example for memberlist

view details

Aditya C S

commit sha 1729592f38c087d1c7c9a3c3405adc823fca798b

Add Error method for step evaluators (#2223)

view details

Cyril Tovena

commit sha 79a90dc4f644780ecd0682b5965d29b7fb577739

Docker driver relabeling (#2199) * Add relabeling to docker driver using `loki-relabel-config` log option. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Add docs. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

view details

Cyril Tovena

commit sha 314531cb0476829765a3e9a6fcc26d06fd113876

Improve point allocations for each steps in the logql engine. (#2216) Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

view details

Cyril Tovena

commit sha 721256403c44e913897161e3989525f379f0cf4a

Reuse buffer for hash computation in the engine. (#2218) Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

view details

Cyril Tovena

commit sha 91158abec19ecab87e2a2a486f439047c6a89cb7

Reuse slice for the range vector allocations. (#2219) Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

view details

Sandeep Sukhani

commit sha 9ab3800522a04c82e52d2e40845735eab61c2aac

boltdb shipper download failure handling and some refactorings (#2156)

view details

Calle Pettersson

commit sha baa264392bf9c0170931c67310c6aeba1cac7f4e

Set user agent on outgoing http requests (#2242) Signed-off-by: Calle Pettersson <calle@cape.nu>

view details

Simone Esposito

commit sha d5eb3e40399f0638c28c5e5a4e6eefdd85cf8092

Kubernetes manifests: Remove namespace from cluster-wide resources (#2241) Fixes https://github.com/grafana/loki/issues/2234

view details

vyzigold

commit sha d307a0b11b5688e4c5658197b0cd06a37f85cd83

Add readmes to individual helm charts (#2233)

view details

Cyril Tovena

commit sha 54a9e67529e88f3f54c0e09b02abd46825a4f80f

Render loki datasources even if Grafana is disabled. (#2197) I didn't realize but this was a perfect ok use case to generate datasource when using a different grafana deployment. Fixes #2186 Fixes #2195 Now regarding https://github.com/grafana/loki/pull/2086 it seems pretty easy to use `.Values.grafana.sidecar.datasources.enabled` if you don't want any datasources. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

view details

push time in 2 months

delete branch fredr/grafana

delete branch : fix/toggle-derived-fields

delete time in 2 months

delete branch fredr/grafana

delete branch : feature/toggle-parsed-fields

delete time in 2 months

pull request commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

@fredr I just built and checked that PR, and yes it does now work on my parsed fields! Great work btw, we were contemplating bodging something like this ourselves and you put this PR up about 2 days later :)

Thanks for testing, glad it worked! And thank you :) We are in the process of switching over to loki/grafana from es/kibana, and this was the biggest blocker for us

fredr

comment created time in 2 months

pull request commentgrafana/grafana

Explore/Logs: Allow toggling of derived fields

Thanks so much @fredr for your work! rockettadablue_heart

Thanks for testing and reviewing!

fredr

comment created time in 2 months

startedivanahuckova/sourdough_monitor

started time in 2 months

PR opened grafana/grafana

Allow toggling of derived fields

This fixes a regression from #26178

The log details shows both parsed fields and derived fields. In the current implementation, when toggling a field like ts or tsNs, nothing is displayed, since those fields are not part of the parsed message.

+80 -75

0 comment

4 changed files

pr created time in 2 months

push eventfredr/grafana

Fredrik Enestad

commit sha 63f3e8b8a5c546694fd26c849401e6fab4cf2188

Allow toggling of derived fields

view details

push time in 2 months

create barnchfredr/grafana

branch : fix/toggle-derived-fields

created branch time in 2 months

pull request commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

I'm trying to use this with a datasource plugin I've written, we return log data and have parsed fields as part of the data frame as in the docs (https://grafana.com/docs/grafana/latest/developers/plugins/build-a-logs-data-source-plugin/#extract-parsed-fields-from-your-logs)

This doesn't work, I believe because when calling getParser, our log format doesn't match JSON or key=value, so it returns []. I guess it's using the same code that is used to extract parsed fields from data that doesn't explicitly define them, rather than look at the parsed fields that exist.

Is there a way to implement a parser for a datasource?

I think you'll get a better answer by creating an issue or asking in the grafana slack, this pr only adds the toggling of parsed fields, and not parsed fields itself, so I'm not sure. But looking at the code, it looks like you cant add custom parsers atm.

fredr

comment created time in 2 months

pull request commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

This is awesome @fredr Thanks so much!

:pray: :pray: Thank you

fredr

comment created time in 2 months

push eventfredr/grafana

Dominik Prokop

commit sha 74b2c2acdcece0a3a9b6a4ad849f9c294d115090

Fix lint (#26130)

view details

Ivana Huckova

commit sha 52f12d10c5df97873c2fb09afb0cc571ff4b2cd3

Explore/Loki: Escape \ in labels for show context queries (#26116) * Hot fix, keep the file * Add comment * Update public/app/plugins/datasource/loki/datasource.ts Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Remove script.go file Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

view details

Arve Knudsen

commit sha ba4a8256a44579a69eecb84ea7b9627242035094

Chore: Rename plugin CI image as grafana/grafana-plugin-ci:latest-alpine (#26106) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

view details

Torkel Ödegaard

commit sha 81e955e6b5a95d795b099022a409f652a8c1dc49

BackendSrv: Cancellable requests & Observable all the way (#25746) * BackendSrv: Observable all the way POC * starting to unify code paths * tests pass * Unified error handling * Single request path and error handling * Fixed ts issue * another ts issu * Added back old requestId cancellation * Slow progress trying to grasp the full picture of cancellation * Updates * refactoring * Remove a bunch of stuff from backendSrv * Removed another function * Do not show error alerts for data queries * Muu * Updated comment * fixed ts issue * unify request options type * Made query inspector subscribe to backendSrv stream instead of legacy app events * Add back support for err.isHandled to limit scope * never show success alerts * Updated tests * Fixing tests * Minor weak * Improved logic for the showErrorAlert and showSuccessAlert boolean flags, now they work more logically * Fix issue

view details

Diana Payton

commit sha b0fd9f03cafcc928343d55342d018aecb9dc0a81

Docs: Add strategies topic (#26103) * Create use.md * Update timeseries.md * changed file name and added content * Update menu.yaml * Update strategies.md

view details

Ryan McKinley

commit sha 2b6833d0da5e1169692f69cfa9dbd00ef810ab4b

DataSourceWithBackend: add internal comment for new method (#26139)

view details

Dominik Prokop

commit sha 30a682a4da6b9568a2da84c7fedef87de693c3a0

Do not break dashboard settings UI when time intervals end with trailing comma (#26126)

view details

Ryan McKinley

commit sha b26ef1db2592bbdb2207bc4772b124d0cb038423

CSV: force UTF-8 encoding for download (#26145)

view details

Mitsuhiro Tanda

commit sha 292c985b76345c8ca11e6bdacf193a177bf22382

Alerting: Support storing sensitive notifier settings securely/encrypted (#25114) Support storing sensitive notification settings securely/encrypted. Move slack notifier url and api token to secure settings. Migrating slack notifier to store token and url encrypted is currently a manual process by saving an existing slack alert notification channel. saving an existing slack alert notification channel will reset the stored non-secure url and token. Closes #25113 Ref #25967 Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>

view details

Torkel Ödegaard

commit sha 89b56782c61fd9ee86d47032093086b30bda0a70

DataLinks: Fixed interpolation of repeated variables used in data links (#26147)

view details

Torkel Ödegaard

commit sha fd44c01675e54973370969dfb9e78f173aff7910

Chore: Fix typescript strict null fixes now at 298 (#26125) * Chore: Fix typescript strict null errors * Added new limit * Fixed ts issue * fixed tests * trying to fix type inference * Fixing more ts errors * Revert tsconfig option * Fix * Fixed code * More fixes * fix tests * Updated snapshot * Chore: More ts strict null fixes * More fixes in some really messed up azure config components * More fixes, current count: 441 * 419 * More fixes * Fixed invalid initial state in explore * Fixing tests * Fixed tests * Explore fix * More fixes * Progress * Sub 300 * Fixed incorrect type * removed unused import

view details

Marcus Andersson

commit sha 17d87071e6850827528e109e6fe5701ce057b649

Transform: adding missing "table"-transform and "series to rows"-transform to Grafana v7-transforms. (#26042) * Fixed so the merge for table values works as it did before. * wip * fixed tests. * merge tests are green. * removed unused code and simplify the seriesToRows. * added time series to rows editor. * using getFrameDisplayName for the metric value. * updated description of transforms. * updated docs. * fixed according to feedback. * changed from images to markdown tables for the examples. * forgot to save :P

view details

Torkel Ödegaard

commit sha 8ab5d2ddd9dbacffcecc7d16e5ef9e4d0e56e726

Dashboard: Refresh intervals should not always add the server min refresh interval (#26150)

view details

Torkel Ödegaard

commit sha cace879c96dd5bdc75132de090618da9db565ffb

Templating: Fixed recursive queries triggered when switching dashboard settings view (#26137) * Templating: Fixed recursive queries triggered when going into dashboard settings * Fixed unused import * use locationUtil

view details

kay delaney

commit sha fd29b952a6790089f0bd35a6bd4f050826a859ff

Backend: use latest Go plugin SDK (#26162)

view details

Jess

commit sha 6d4f72cd04ef682a2954c180580389acc7636969

Create Slider.mdx (#26149) add simple documentation for slider component

view details

Jess

commit sha 14209c0ed16ee19b4852fa316d8ea607962a32ba

Create Badge.mdx (#26114)

view details

Oana Mangiurea

commit sha 84bf94709e16eaac04fc5e84cd378bb7b48dc8e3

Created Legend.mdx (#26146) Add simple docs to legend component Signed-off-by: Oana <oana.mangiurea@gmail.com>

view details

Oana Mangiurea

commit sha ea33668014ab3a596a9bd651db6f867418981c78

Update TextArea.mdx (#26159) Add additional information in docs to textarea component

view details

Jess

commit sha f242840275a77af1b6d977bb10b97ae9324799e5

Create ConfirmButton.mdx (#26113) add docs to ConfirmButton element

view details

push time in 2 months

pull request commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

🍻 Cheers! Thanks for merging

fredr

comment created time in 2 months

push eventfredr/grafana

Fredrik Enestad

commit sha d9c7ddb7a1f4bea935883689ba368772def1666a

clean up after making optional

view details

push time in 2 months

pull request commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

This is really shaping up. I've demoed this internally and got very positive feedback. Most users also prefer to see the empty rows even when they don't have any selected field to show, so let's leave this as is. I'm trying to find out how to best apply the color (it's something we're not doing anywhere else yet). Probably ready to merge tomorrow.

Excellent, glad to hear! Let me know if I should change anything, or squash the commits or something.

fredr

comment created time in 2 months

push eventfredr/grafana

Fredrik Enestad

commit sha 70eab46ca39cb4f7a6d4af5841d96ee1d9aa1a1e

better label

view details

push time in 2 months

Pull request review commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

 export class Logs extends PureComponent<Props, State> {           />         )} +        {showParsedFields && showParsedFields.length > 0 && (+          <MetaInfoText+            metaItems={[+              {+                label: 'Showing only parsed labels',

good catch!

fredr

comment created time in 2 months

pull request commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

There are some changes to LogQL coming that should make it easer to "unpack" certain values within JSON log lines. But I think this is a great feature nonetheless. I suggest a couple of things:

Thanks for this feedback!

* `parseMessage` that is used in `LogRowMessageParsed` is the same as in `LogDetails`, please reuse that one (there was already a fix done in `LogDetails` recently that would have not made it into this new feature if we didnt reuse the code).

I've moved the parseMessage to a common place, so we only have one

* The eye metaphor is not quite fitting. It's not show/hide, but rather select/deselect, plus a base state where nothing is selected which means that everything is shown unparsed. Select/deselect are usually done with checkbox icons, but I think the eye is not so bad after all if we consider this as setting field visibility. I think what I don't like is the crossed eye (hide) semantic. I'd rather do something like a blue eye, ie if a field was selected its eye gets blue, and then it can be unselected to turn it normal gray again. And the tooltips should be adapted to accurately describe what's happening: Something like "Show this field instead of the message" to activate and "Hide this field" to deselect.

I changed it to be blue when selected, I did not know what blue I should use, so I used blue95, but is there a better way of doing that, or a more general value to set it to?

* the status message about the selection needs to be cleaned up, either as part of the controls (A), or as part of the meta section where it would make sense to also specify which fields are being shown (B)

I've now added them to the meta section, as I think its nice to display what fields are selected there

* IMO empty rows should not be rendered.

I think its kind of nice to be able to expand the rows that did not include any of the selected fields to be able to check what that was, and potentially add fields from those as well (thats kind of how it works in kibana which is what I use today). But if you feel strongly about it, I'll change it. I guess I would have to parse the rows in LogRows then instead

Otherwise, awesome work! rocket Let me know how I can help.

I'm not really a frontend developer, so feel free to be super nitpicky on this pr, I've probably done some things weirdly

fredr

comment created time in 2 months

push eventfredr/grafana

Adrián López

commit sha 2093f7c1f03bd971eebc7c915b801d14adda358e

grafana-cli: Fix installing of plugins missing directory entries in zip (#26945)

view details

kay delaney

commit sha 751a07e3c5a4188817b49fed54feadfb71c04b3a

Panel/BarGauge: Prevent overflow in panel with many series (#26926) * Panel/BarGauge: Prevent overflow in panel with many series Closes #24889

view details

kay delaney

commit sha a8f57b2ffddc9ce72cc5e394c8817f74bcd96685

Datasource/CloudWatchLogs: Correctly interpolate variables for data links (#26929) Closes #26792

view details

Arve Knudsen

commit sha 1698c74ec1699f5bbbdb827560e39a1547ad9807

Chore: Fix tests for Go 1.15 (#26957) * Chore: Fix tests for Go 1.15

view details

Kyle Brandt

commit sha f432e153ca07314cd8bcb0db47f77b06d10842ff

Dataframe/Alerting: to tsdb.TimeSeriesSlice - accept "empty" time series (#26903) this is in order to trigger no data when used with alerting. fixes #26897. This is perhaps better solved in the SDK but that needs more thought and is tracked in grafana/grafana-plugin-sdk-go#214

view details

martinrw

commit sha b1625955fe223166a9f5272657002a514872a47b

Docs: Mention httpMode in the docs (#26964)

view details

hebbet

commit sha 2755db6b4b149e4863cdb46db1be612f45fec906

Docs: Remove "currently in beta" (#26960) 7.1 is stable

view details

Nitesh Koushik S

commit sha 18c2aaa10e5ebab10a85a597e66866fbc694001d

Docs: Adding reference for the default database (#26950) Adding reference for the default database type SQLite

view details

Lucas Raschek

commit sha 6b1b52b704eeb58f23a10b4c512a6aebfe5b99b4

Templating: Fixes renaming a variable using special characters or same name (#26866) * Fix variable editor name-input bug You couldn't delete an invalid character after typing it into the name-input field. While investigating the issue turned out to be bigger, as there was a problem with valid characters too. (See test scenarios below) The fix seems to be, to remove an unnecessary check in the `changeVariableName` action. There is theoretically now the possibility, that the `changeVariableName` action is called with the same name, as the variable is already, but practically there seems no possibility, that this could happen. A test, which checks that, had to be removed too. Test scenarios: * 1st Scenario 1. Type "@" 2. Try deleting it * 2nd Scenario 1. Type "w" 2. delete "w" 3. Try typing "w" again Fixes #26562 * Fix bug when updating existing variable

view details

Zoltán Bedi

commit sha 75e14aa12035691c4584ec446b22a8612ed2b7e9

Chore: Let kbn util infer types (#26907) * Chore: Let kbn util infer types Type fixes where needed * Address review comments + test fix * Modify kbn method and property names to pascalCase

view details

Arve Knudsen

commit sha 9f159c5e3d6ad17fdb6ffc2e172acb1226386a23

grafana-cli: Fix file path processing, returning of errors (#26954) * grafana-cli: Fix file path processing, returning of errors

view details

Pratik Raj

commit sha 3bed3248d92b1fa13e9e7b1befdcbf67960e1c5d

Use `--no-cache-dir` flag to `pip` in Dockerfiles, to save space (#26978) Use `--no-cache-dir` flag to `pip` in Dockerfiles, to save space Signed-off-by: Pratik Raj <rajpratik71@gmail.com>

view details

Emil Tullstedt

commit sha d664853179269e1d85297a2f6786638e66a0464f

Tests: Change util GoConvey tests to use testify (#26724)

view details

Ivana Huckova

commit sha eeeea7fb8ddfbe7a69a971cb611b8d1e9a414e5a

Explore: Capitalize dedup strategy in radio buttons for consistency (#26961) * Update LogsDedupStrategy enum to keep consistent with radio button capitalization * Revert "Update LogsDedupStrategy enum to keep consistent with radio button capitalization" This reverts commit 0b05cd4e004fd3e9c78b3cec776961ae874b912d. * Capitalize dedup strategy in radio buttons

view details

Torkel Ödegaard

commit sha 5398ef11033c533bb706bf01bab3eda9ef9512c7

Templating: Fixed recursive url update issue for textbox variable (#26981) * Templating: Fixed recursive url update issue for textbox variable * Updated link * updated e2e

view details

Joan López de la Franca Beltran

commit sha ef631582bab0cff19acd2c430423a0cf424c24a1

Users: Improve conflict error handling (#26958) * API: Improve error handling (#26934) * New ErrUserAlreadyExists error has been introduced * Create user endpoint returns 412 Precondition Failed on ErrUserAlreadyExists errors * Make ErrUserAlreadyExists error message clearer Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Use errors.Is instead of equality comparator on AdminCreateUser handler * Improve sqlstore/user test definition Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Improve sqlstore/user tests for ErrUserAlreadyExists cases * Remove no needed string fmt and err declaration on sqlstore/user tests * Code improvements for sqlstore/user tests Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Use err.Error() instead of sentinel error value on AdminCreateUser Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Add ErrUserAlreadyExists handling for signup & org invite use cases Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

view details

Arve Knudsen

commit sha d823b26b06b2f50101671547b9109021f0d797af

Drone/CircleCI: Upgrade build pipeline tool (#26854) * Drone/CircleCI: Upgrade build pipeline tool Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Upgrade build pipeline tool in Docker scripts Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

view details

Arve Knudsen

commit sha c63bbbaec3bc902bcdbedc0c195b499ded583506

InfluxDB: Close Flux query results (#26917) * InfluxDB: Drop ctxhttp usage * InfluxDB: Clean up code * InfluxDB: Close query results Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

view details

Kyle Brandt

commit sha f9f60c9193fb4421b788d4debd765ea5361f9035

AzureMonitor: map more units (#26990) add BitsPerSecond and Seconds

view details

Zoltán Bedi

commit sha aae25c530873c0db51d987d1a1bfe84aeda0b3b1

Prometheus: add $__rate_interval variable (#26937) * Add rate interval variable to prometheus data source * Add tests + auto complete * Fix prometheus tests * Add doc * Modify test title * Modify kbn method name after merge

view details

push time in 2 months

push eventfredr/grafana

Fredrik Enestad

commit sha d4ecb6e28dd7effd5ddc6a483ff49050ed1af965

fix test-frontend failures

view details

push time in 2 months

pull request commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

I've updated the POC with a indicator that there are filters, and also a clear filter button

fredr

comment created time in 2 months

push eventfredr/grafana

Fredrik Enestad

commit sha ed017f5ec40fba0e0489dc2007ff07558df83952

add clear button for toggled parsed fields

view details

push time in 2 months

push eventfredr/grafana

Fredrik Enestad

commit sha 209cf321a17f54d0e6def14793df2ad73917dcff

fixed issues

view details

push time in 2 months

push eventfredr/grafana

Dominik Prokop

commit sha 74b2c2acdcece0a3a9b6a4ad849f9c294d115090

Fix lint (#26130)

view details

Ivana Huckova

commit sha 52f12d10c5df97873c2fb09afb0cc571ff4b2cd3

Explore/Loki: Escape \ in labels for show context queries (#26116) * Hot fix, keep the file * Add comment * Update public/app/plugins/datasource/loki/datasource.ts Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Remove script.go file Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

view details

Arve Knudsen

commit sha ba4a8256a44579a69eecb84ea7b9627242035094

Chore: Rename plugin CI image as grafana/grafana-plugin-ci:latest-alpine (#26106) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

view details

Torkel Ödegaard

commit sha 81e955e6b5a95d795b099022a409f652a8c1dc49

BackendSrv: Cancellable requests & Observable all the way (#25746) * BackendSrv: Observable all the way POC * starting to unify code paths * tests pass * Unified error handling * Single request path and error handling * Fixed ts issue * another ts issu * Added back old requestId cancellation * Slow progress trying to grasp the full picture of cancellation * Updates * refactoring * Remove a bunch of stuff from backendSrv * Removed another function * Do not show error alerts for data queries * Muu * Updated comment * fixed ts issue * unify request options type * Made query inspector subscribe to backendSrv stream instead of legacy app events * Add back support for err.isHandled to limit scope * never show success alerts * Updated tests * Fixing tests * Minor weak * Improved logic for the showErrorAlert and showSuccessAlert boolean flags, now they work more logically * Fix issue

view details

Diana Payton

commit sha b0fd9f03cafcc928343d55342d018aecb9dc0a81

Docs: Add strategies topic (#26103) * Create use.md * Update timeseries.md * changed file name and added content * Update menu.yaml * Update strategies.md

view details

Ryan McKinley

commit sha 2b6833d0da5e1169692f69cfa9dbd00ef810ab4b

DataSourceWithBackend: add internal comment for new method (#26139)

view details

Dominik Prokop

commit sha 30a682a4da6b9568a2da84c7fedef87de693c3a0

Do not break dashboard settings UI when time intervals end with trailing comma (#26126)

view details

Ryan McKinley

commit sha b26ef1db2592bbdb2207bc4772b124d0cb038423

CSV: force UTF-8 encoding for download (#26145)

view details

Mitsuhiro Tanda

commit sha 292c985b76345c8ca11e6bdacf193a177bf22382

Alerting: Support storing sensitive notifier settings securely/encrypted (#25114) Support storing sensitive notification settings securely/encrypted. Move slack notifier url and api token to secure settings. Migrating slack notifier to store token and url encrypted is currently a manual process by saving an existing slack alert notification channel. saving an existing slack alert notification channel will reset the stored non-secure url and token. Closes #25113 Ref #25967 Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>

view details

Torkel Ödegaard

commit sha 89b56782c61fd9ee86d47032093086b30bda0a70

DataLinks: Fixed interpolation of repeated variables used in data links (#26147)

view details

Torkel Ödegaard

commit sha fd44c01675e54973370969dfb9e78f173aff7910

Chore: Fix typescript strict null fixes now at 298 (#26125) * Chore: Fix typescript strict null errors * Added new limit * Fixed ts issue * fixed tests * trying to fix type inference * Fixing more ts errors * Revert tsconfig option * Fix * Fixed code * More fixes * fix tests * Updated snapshot * Chore: More ts strict null fixes * More fixes in some really messed up azure config components * More fixes, current count: 441 * 419 * More fixes * Fixed invalid initial state in explore * Fixing tests * Fixed tests * Explore fix * More fixes * Progress * Sub 300 * Fixed incorrect type * removed unused import

view details

Marcus Andersson

commit sha 17d87071e6850827528e109e6fe5701ce057b649

Transform: adding missing "table"-transform and "series to rows"-transform to Grafana v7-transforms. (#26042) * Fixed so the merge for table values works as it did before. * wip * fixed tests. * merge tests are green. * removed unused code and simplify the seriesToRows. * added time series to rows editor. * using getFrameDisplayName for the metric value. * updated description of transforms. * updated docs. * fixed according to feedback. * changed from images to markdown tables for the examples. * forgot to save :P

view details

Torkel Ödegaard

commit sha 8ab5d2ddd9dbacffcecc7d16e5ef9e4d0e56e726

Dashboard: Refresh intervals should not always add the server min refresh interval (#26150)

view details

Torkel Ödegaard

commit sha cace879c96dd5bdc75132de090618da9db565ffb

Templating: Fixed recursive queries triggered when switching dashboard settings view (#26137) * Templating: Fixed recursive queries triggered when going into dashboard settings * Fixed unused import * use locationUtil

view details

kay delaney

commit sha fd29b952a6790089f0bd35a6bd4f050826a859ff

Backend: use latest Go plugin SDK (#26162)

view details

Jess

commit sha 6d4f72cd04ef682a2954c180580389acc7636969

Create Slider.mdx (#26149) add simple documentation for slider component

view details

Jess

commit sha 14209c0ed16ee19b4852fa316d8ea607962a32ba

Create Badge.mdx (#26114)

view details

Oana Mangiurea

commit sha 84bf94709e16eaac04fc5e84cd378bb7b48dc8e3

Created Legend.mdx (#26146) Add simple docs to legend component Signed-off-by: Oana <oana.mangiurea@gmail.com>

view details

Oana Mangiurea

commit sha ea33668014ab3a596a9bd651db6f867418981c78

Update TextArea.mdx (#26159) Add additional information in docs to textarea component

view details

Jess

commit sha f242840275a77af1b6d977bb10b97ae9324799e5

Create ConfirmButton.mdx (#26113) add docs to ConfirmButton element

view details

push time in 2 months

push eventsoundtrackyourbrand/soundtrack_api-example_app

Fredrik Enestad

commit sha a712b5abf3b6083b5114fe7fe78185d39391773e

re-lock yarn

view details

push time in 3 months

pull request commentgrafana/grafana

Explore/Loki: POC for toggling parsed fields in the list view

Hi! Thanks for this effort, it's simple but effective and already looking pretty good.

Thanks for giving feedback!

I agree with Andrej that the interface needs feedback that tells the user that they filtered something. I think it would be nice to be able to quick-remove/unhide these hidden fields again.

I agree, that would be very useful, because right now, if you change your query while having toggled fields, and the new query doesn't have those fields, you wont be able to remove the toggles and get back to the raw log row.

Regarding dashboards, I'm not sure whether in a dashboard logs panel you would want to toggle showing/hiding fields a lot, or whether you'd just like to hide some once and keep them hidden for easy reading. I don't know how these filters work on the technical side. I wonder if it would be useful if the filters were part of the query and not just visual? because then you could share queries with pre-hidden stuff, and I imagine the hidden fields would automatically be applied in a dashboard view. If we can't do that, we need something in the panel edit to tweak the parsed fields. Maybe as a Transformation or in the "Display" options area?

I haven't used the dashboard logs panel yet, so I don't have a good idea of how that should play into this.

But currently, in this POC, the toggles are only saved in the local state, so if you copy the link and open it in an other browser, they will get lost.

IMO it would be a good idea to add them to the url query as you suggest, so that it will be preserved when sending a log explore link to someone. This is something we do a lot whenever there is an incident, or when we want to share some insight. I think it might be confusing if they are not preserved.

I guess this way it could also be saved to the query history, which I think would also be expected.

fredr

comment created time in 3 months

more