profile
viewpoint
宋铄运 (Alan Song) fnlctrl @vuejs Zhejiang University http://fnlctrl.xyz/resume Web Developer, UI Designer

fnlctrl/NewTide 5

水朝夕线上杂志 (http://tide.zjuqsc.com/)

fnlctrl/ZJUYFF-2014 3

浙江大学第二届青年电影节网站

fnlctrl/crx-hotreload 1

Chrome Extension Hot Reloader

HetongWang/ZJUYFF 1

ZJU youth film festival

posva/path-rank-tester 1

🛣 A Vue Router path debugger

fnlctrl/babel 0

:tropical_fish: Babel is a compiler for writing next generation JavaScript.

fnlctrl/babel-plugin-transform-vue-jsx 0

babel plugin for vue 2.0 jsx

pull request commentvitejs/vite

fix: css modules duplicate module / hot reload issue when imported from both script and <style src>

Changes in the css module won't trigger hot reload for js

It is a bug but the pr not fix this.

I've tested and the js file won't be re-evaluated, but the imported reference would be, e.g.

// some js that imports cssm
import styles from './test.module.css'
window.test = () => console.log(styles)

Calling window.test will print updated results if test.module.css is changed. This is ok for me.

Find other bug: multiply vue files imported same <style src="css.file">, the hmr is only updated lasted one.

Just tested and with this PR's code it's working correctly.

fnlctrl

comment created time in 2 days

pull request commentvitejs/vite

fix: css modules duplicate module / hot reload issue when imported from both script and <style src>

Class names are different (i.e. one css module loaded twice)

I think it is not matter because the module css is imported twice and it also is not a better practice.

The example here is only to demonstrate the issue. Real world usage would be the same foo.module.css imported by both .js files and .vue files.

Changes in the css module won't trigger hot reload for js

It is a bug but the pr not fix this.

Find other bug: multiply vue files imported same <style src="css.file">, the hmr is only updated lasted one.

Hmm I'll take a look.

fnlctrl

comment created time in 2 days

push eventfnlctrl/vite

Alec Larson

commit sha e703b28f30ce465565d260b96ec1883ca1b5c152

docs: add --force to help

view details

Alec Larson

commit sha 62ce9c7de0652abc8fe39420a8d69668a27944fb

nit: reword --force help Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>

view details

underfin

commit sha d44e31a10869c702a023500d0b257a4bea5da8ad

Merge pull request #679 from aleclarson/force-arg docs: add --force to help

view details

hiroki

commit sha 5e4a4f95eee00f53b12da628526edb4c04bf6b69

chore(package.json): added description (#697)

view details

ZHAO Jinxiang

commit sha f69ea0fecb439feda7c19a281917399a63fb64c7

doc: use esm in vite.config.js (#753)

view details

underfin

commit sha c9a27643f4ca612c8280c4485a6feadbc973c1ca

fix(dev): ignore .git file with hmr (#664) fix #663

view details

Michael Kurze

commit sha 2acae21b197ccbfc332651247ebe2f9b25fde238

fix(build): create at most one `esbuildService` (#694) fix #693

view details

underfin

commit sha e52e5ed1c5cf74c34cf6a35b7c1d507a3ce66373

feat(build): use `fs.emptyDir` instead of `fs.remove` (#744) close #709

view details

underfin

commit sha fb85cb2a75dd49bfe6df1a8a1038411b3744a4a2

feat(build): add option for `terser` (#734) close #733

view details

Shyam Chen

commit sha 9827abe5811f59d51f5a4c81182a58bc4c5871ee

docs: fix a broken link [ci skip] (#624)

view details

SeyyedKhandon

commit sha 2560a45897e5c608056743352a9dc90cf5ec0877

fix: README.md type/grammar (#625)

view details

underfin

commit sha 2b544f31bf8526b9f5ddee865c6c086f3edce756

fix(dev): don't rewrite files inside public (#602)

view details

wxy

commit sha 3401ca0e99de7b121d8402e5ce41a440b76fe376

fix(node):this async is redundant, await is not used (#586) * fix(node):this async is redundant, await is not used Co-authored-by: wxy <wxy306533309@163.com>

view details

Anthony Fu

commit sha e844111443d4d6773e3f67873899025855a81908

chore: rename internal terser options type to (#758) Renamed `Options` to`RollupTerserOptions` for better context reading.

view details

Eugene Kopich

commit sha 810241527d223a0407f4587dea166049eb401450

chore(package.json): vuejs->vitejs (#765)

view details

Anthony Fu

commit sha 0455b9191b9e497a80de6c11190d863e4e4c636a

feat: set NODE_ENV if not present (#732) close #696

view details

Alec Larson

commit sha 5d98994d2c0fb790458a30d4badb7bf83c48691f

fix: strip "public/" prefix in `defaultFileToRequest` (#681)

view details

underfin

commit sha ef60d55b67cf25508fe28a0c6cd2b9745b7f282a

fix(build): only extract js module script tag in html (#724) fix #670

view details

Ante Sepic

commit sha ba9dda22ca89118f39fbbad7afb79c1898892e63

fix(dev): Support passing "0" as port (#590)

view details

underfin

commit sha 49689e5d9ccb1e119951951e773d8826ec2221be

fix(dev): correctly normalize entry path on windows (#736) close #735

view details

push time in 2 days

push eventfnlctrl/vite

push time in 2 days

push eventfnlctrl/vite

Alec Larson

commit sha e703b28f30ce465565d260b96ec1883ca1b5c152

docs: add --force to help

view details

Alec Larson

commit sha 62ce9c7de0652abc8fe39420a8d69668a27944fb

nit: reword --force help Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>

view details

underfin

commit sha d44e31a10869c702a023500d0b257a4bea5da8ad

Merge pull request #679 from aleclarson/force-arg docs: add --force to help

view details

hiroki

commit sha 5e4a4f95eee00f53b12da628526edb4c04bf6b69

chore(package.json): added description (#697)

view details

ZHAO Jinxiang

commit sha f69ea0fecb439feda7c19a281917399a63fb64c7

doc: use esm in vite.config.js (#753)

view details

underfin

commit sha c9a27643f4ca612c8280c4485a6feadbc973c1ca

fix(dev): ignore .git file with hmr (#664) fix #663

view details

Michael Kurze

commit sha 2acae21b197ccbfc332651247ebe2f9b25fde238

fix(build): create at most one `esbuildService` (#694) fix #693

view details

underfin

commit sha e52e5ed1c5cf74c34cf6a35b7c1d507a3ce66373

feat(build): use `fs.emptyDir` instead of `fs.remove` (#744) close #709

view details

underfin

commit sha fb85cb2a75dd49bfe6df1a8a1038411b3744a4a2

feat(build): add option for `terser` (#734) close #733

view details

Shyam Chen

commit sha 9827abe5811f59d51f5a4c81182a58bc4c5871ee

docs: fix a broken link [ci skip] (#624)

view details

SeyyedKhandon

commit sha 2560a45897e5c608056743352a9dc90cf5ec0877

fix: README.md type/grammar (#625)

view details

underfin

commit sha 2b544f31bf8526b9f5ddee865c6c086f3edce756

fix(dev): don't rewrite files inside public (#602)

view details

wxy

commit sha 3401ca0e99de7b121d8402e5ce41a440b76fe376

fix(node):this async is redundant, await is not used (#586) * fix(node):this async is redundant, await is not used Co-authored-by: wxy <wxy306533309@163.com>

view details

Anthony Fu

commit sha e844111443d4d6773e3f67873899025855a81908

chore: rename internal terser options type to (#758) Renamed `Options` to`RollupTerserOptions` for better context reading.

view details

Eugene Kopich

commit sha 810241527d223a0407f4587dea166049eb401450

chore(package.json): vuejs->vitejs (#765)

view details

Anthony Fu

commit sha 0455b9191b9e497a80de6c11190d863e4e4c636a

feat: set NODE_ENV if not present (#732) close #696

view details

Alec Larson

commit sha 5d98994d2c0fb790458a30d4badb7bf83c48691f

fix: strip "public/" prefix in `defaultFileToRequest` (#681)

view details

underfin

commit sha ef60d55b67cf25508fe28a0c6cd2b9745b7f282a

fix(build): only extract js module script tag in html (#724) fix #670

view details

Ante Sepic

commit sha ba9dda22ca89118f39fbbad7afb79c1898892e63

fix(dev): Support passing "0" as port (#590)

view details

underfin

commit sha 49689e5d9ccb1e119951951e773d8826ec2221be

fix(dev): correctly normalize entry path on windows (#736) close #735

view details

push time in 2 days

push eventfnlctrl/vue-next

dependabot-preview[bot]

commit sha b19488e5d0adfa2bf74fe9f5a3f68d55d61caaf0

build(deps-dev): bump @microsoft/api-extractor from 7.9.11 to 7.9.13 (#2068)

view details

dependabot-preview[bot]

commit sha 02e95fc977188321371571cc414832c0be47f105

build(deps-dev): bump @types/jest from 26.0.12 to 26.0.13 (#2069)

view details

dependabot-preview[bot]

commit sha e474754c7687e2815e303a9b43d47868d27ad318

build(deps-dev): bump lint-staged from 10.2.13 to 10.3.0 (#2070)

view details

dependabot-preview[bot]

commit sha b53d45de65239fa4acd9c6bc41ed58fc9b823729

build(deps-dev): bump rollup from 2.26.9 to 2.26.10 (#2067)

view details

dependabot-preview[bot]

commit sha 629439039168ab7b768922aab6b26e6e4d52a762

build(deps-dev): bump @types/puppeteer from 2.1.2 to 2.1.3 (#2074)

view details

dependabot-preview[bot]

commit sha 110e96d1524fa9ff6d2b1fb0f26af0c4d0cb6ff7

build(deps-dev): bump rollup from 2.26.10 to 2.26.11 (#2075)

view details

dependabot-preview[bot]

commit sha 7417bac08bcc7d5e240c33434aae589d0054a519

build(deps-dev): bump @microsoft/api-extractor from 7.9.13 to 7.9.14 (#2098)

view details

dependabot-preview[bot]

commit sha d0b56d2fcc393a5e5b4b26f49830bf3b7f638b35

build(deps-dev): bump eslint from 7.8.1 to 7.9.0 (#2114)

view details

dependabot-preview[bot]

commit sha 2f7924d53090b2e51be881739416dc324cc7b1da

build(deps-dev): bump @microsoft/api-extractor from 7.9.14 to 7.9.15 (#2113)

view details

Wuzado

commit sha 542680e4786892b7d8f149389e2402ab0a0cda21

chore(readme): update link to the JSX babel plugin (#2104) [ci skip]

view details

Pick

commit sha cf1b6c666f45a284494f80981522a3dc4804a683

feat(runtime-dom): allow native Set as v-model checkbox source (#1957)

view details

Evan You

commit sha 0124eacc91bc03a9bcf135f09258c2448452423e

refactor(reactivity): refactor iteration key trigger logic + use more robust Map/Set check

view details

HcySunYang

commit sha 24fcf6ae7cd75c782a5aa2771aca259542e2a680

fix(types): properly infer return type from async setup (#2051) fix #2049

view details

Evan You

commit sha a096a58e412dc37ae618a3b4702f591c580d376a

fix(compiler-core): fix v-if block handling for components that fail to resolve fix #2058

view details

Stanislav Lashmanov

commit sha 313dd06065b1782d67f6881fbd42ae92a7f9cade

fix(runtime-core/inject): handle optional `from` option in inject object config (#2073)

view details

Evan You

commit sha 612eb6712a3858e4280946d98153b6f35792c652

fix(runtime-core/refs): handle multiple merged refs for dynamic component with vnode fix #2078

view details

underfin

commit sha a32870a8f611dd1146bb17d5605b168a7805c73f

fix: inherit `el` for static nodes inside keyed `template` fragment (#2089) fix #2080

view details

Evan You

commit sha be946ea549d5073274813ed15348bdbfabcaa30c

fix(compiler-core): fix prefixing for `<template v-for>` key expressions fix #2085

view details

Evan You

commit sha 4de5b111eec55d4a992ab4bb08ab8067a15a3e2a

test: fix cloneVNode ref tests

view details

Evan You

commit sha 124c385bafb40f8df7ec61b612765706015ff0fa

perf: should not trigger child update if changed prop is declared emit listener close #2072

view details

push time in 4 days

issue commentvuejs/vue-next

improve type for unwrap computed

image

I think the error message is quite clear 'x' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.(7022)

An easy workaround would be manually typing computed's callback: image

a631807682

comment created time in 8 days

startedMostlyAdequate/mostly-adequate-guide

started time in 14 days

startedpelotom/hkts

started time in 14 days

push eventfnlctrl/vue-next

Evan You

commit sha eb2ae44d94fe71f93cbabc5e049f03f422db48b0

refactor(types): widen `Component` type to include consutructor types returned from `defineComponent` ref: https://github.com/vuejs/vue-router-next/pull/421 also close #1880 Previous `Component` type is now exported as `ConcreteComponent`. This introduces a minor breaking change when calling `h(comp, { ... })` will now fail if `comp` is a of generic `Component` type, since it does not specify what props it expects.

view details

Pick

commit sha 02dcc68c2444fe6fea437fc4490d45332d67ea55

test(reactivity): improve built-in Collection subclass test cases (#1885)

view details

Carlos Rodrigues

commit sha c2913d57d14449775faf1f2e5647e6d1f3d3f920

fix(types): handling PropType<Function> with default value (#1896) fix #1891

view details

Evan You

commit sha 24041b7ac1a22ca6c10bf2af81c9250af26bda34

fix(compiler-core): generate NEED_PATCH flag for element with vnode hooks

view details

Evan You

commit sha 1eb6067a8598730c67b3b3a4ac459d2723aa858c

fix(runtime-core): fix beforeUpdate call timing to allow state mutation fix #1899

view details

Evan You

commit sha cfa7636bbe841d8f7e72b708e96cf0eefdc85b92

chore: comments

view details

Evan You

commit sha 91c47354168a047ebf18e07a94b96d2f3b1d370b

release: v3.0.0-rc.6

view details

HcySunYang

commit sha 7ffb79c56318861075a47bd2357e34cde8a6dad9

fix(runtime-core): correctly track dynamic nodes in renderSlot (#1911)

view details

underfin

commit sha 69cfed6b313821d1ae7ecb02b63b0aaccb5599c6

fix(compiler-core): should attach key to single element child of `<template v-for>` (#1910)

view details

Evan You

commit sha d4cc7b2496f9ed21ef6cac426697eac058da76bb

fix(teleport): only inherit el for non-patched nodes fix #1903

view details

Evan You

commit sha a74f8d7891c087f4fc1758bdb6a2ef4327f10e3b

test: use polling for more stable markdown e2e tests close #1908

view details

HcySunYang

commit sha 255a2bd17889ba4b9f9d30006d4c23847dbacbe1

test(runtime-core): add tests for the optimized mode (#1884)

view details

Evan You

commit sha 91700fbec2cd2c4e3448190b71ae93f751e4c3eb

refactor(compiler-core): simplify hoistStatic check for nodes without patchFlag close #1912

view details

Evan You

commit sha 7454e2a52b987abc654dee80f5196b073677d212

build(deps): upgrade to TypeScript 4

view details

dependabot-preview[bot]

commit sha c019110c48cb8dba7f91a9fcb797d6bfcb83819a

build(deps-dev): bump rollup from 2.26.3 to 2.26.4 (#1921)

view details

dependabot-preview[bot]

commit sha ed8cbe4f483fe8a39758006bb620aaf6df3fb9a8

build(deps-dev): bump @microsoft/api-extractor from 7.9.7 to 7.9.8 (#1922)

view details

dependabot-preview[bot]

commit sha c0411b374544a6ed962fb2417cdcdaae3e4abd27

build(deps-dev): bump jest from 26.4.0 to 26.4.1 (#1924)

view details

Evan You

commit sha f02e2f99d9c2ca95f4fd984d7bd62178eceaa214

fix(runtime-core): disable block tracking when calling compiled slot function in tempalte expressions fix #1745, fix #1918

view details

XRenSiu

commit sha bb54a84cd1cb4dc8b09d0682c449959d37d644bf

chore: use '@vue/shared' instead of '@vue/shared/src' (#1915)

view details

dependabot-preview[bot]

commit sha ec3d6d23bb23a92cfb8c7aa53cbb7bc354264b88

build(deps): bump postcss-modules from 3.2.0 to 3.2.1 (#1920) Bumps [postcss-modules](https://github.com/css-modules/postcss-modules) from 3.2.0 to 3.2.1. - [Release notes](https://github.com/css-modules/postcss-modules/releases) - [Changelog](https://github.com/css-modules/postcss-modules/blob/master/CHANGELOG.md) - [Commits](https://github.com/css-modules/postcss-modules/compare/v3.2.0...v3.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 21 days

issue openedvuejs/vue-next

scoped-slot loses reactivity after <slot/>

Version

3.0.0-rc.6

Reproduction link

https://jsfiddle.net/fnlCtrl/gbtpwaj4/

Steps to reproduce

Click on the page content to toggle active state.

What is expected?

Scoped-slot state is updated

What is actually happening?

Scoped-slot state is not updated after <slot> element

<!-- generated by vue-issues. DO NOT REMOVE -->

created time in a month

push eventfnlctrl/vue-next

likui

commit sha 9bddf3820e891de92d2fad2f1fa463c180631caf

types(runtime-core): improve types for transition hook fix #1000

view details

underfin

commit sha 63c8444d4a1b101502522d2c0f1fdf632dd638f8

Update packages/runtime-core/src/components/BaseTransition.ts Co-Authored-By: Carlos Rodrigues <david-181@hotmail.com>

view details

likui

commit sha 6b889e7c8a599c829f9a240fdcdce3299fbd0e6d

fix: run ci

view details

Sebastian Krüger

commit sha b725b63e5fd6b9c9875002c2c23e210293bd771b

chore: update CHANGELOG.md (#1141) [ci skip]

view details

dependabot-preview[bot]

commit sha 30f570e8081ae0c7128095eca0c04f73fdc897a9

build(deps-dev): bump conventional-changelog-cli from 2.0.31 to 2.0.34 Bumps [conventional-changelog-cli](https://github.com/conventional-changelog/conventional-changelog) from 2.0.31 to 2.0.34. - [Release notes](https://github.com/conventional-changelog/conventional-changelog/releases) - [Commits](https://github.com/conventional-changelog/conventional-changelog/compare/conventional-changelog-cli@2.0.31...conventional-changelog-cli@2.0.34) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha eed9d7747380824675b676eec532caa8a55ef626

build(deps-dev): bump rollup from 2.8.2 to 2.9.1 Bumps [rollup](https://github.com/rollup/rollup) from 2.8.2 to 2.9.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.8.2...v2.9.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 903e8222be1815df646698dce6e5cf9227da8ceb

build(deps-dev): bump ts-jest from 25.4.0 to 25.5.1 Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 25.4.0 to 25.5.1. - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/master/CHANGELOG.md) - [Commits](https://github.com/kulshekhar/ts-jest/compare/v25.4.0...v25.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Aurelius333

commit sha 8e692c1ca000b629309bf217d93b4522c2cc2ccd

chore: fix broken link in CHANGELOG.md (#1142) [ci skip]

view details

Evan You

commit sha a165d8293dbd092828b14530577d45e2af40deda

feat(runtime-core): expose isVNode

view details

Evan You

commit sha 66c5a556dc5b27e9a72fa7176fbb45d8c4c515b7

fix(hmr): ensure static nodes inherit DOM element in hmr mode fix #1156

view details

Evan You

commit sha 9d111f534adfea77e106f7f5054a842b3c0b26de

test(transition): refactor DOM transition test

view details

underfin

commit sha 697de07e630c502db42e93e64ba556cc4599cbe4

fix(transition): should reset enter class after appear (#1152)

view details

Evan You

commit sha 5b8883a84689dd04dbbcd677bf177ffeda43489d

fix(runtime-core): should not take unmount children fast path for v-for fragments fix #1153

view details

Evan You

commit sha 1b946c85df3d213900faccfa0723d736fa0927a3

fix(hmr): always force full child component props update in HMR mode

view details

Evan You

commit sha 7887c54dfe32fb141cfe3e1f025bfe08ba3b7efa

release: v3.0.0-beta.11

view details

Evan You

commit sha aa1672a8bd5bad6bfb7522c779b2c6c36e9cb01d

test: fix hmr test id

view details

Evan You

commit sha 2bc6a8c1cf4f409eea0cefa8b8a7619aae1f3569

fix(hmr): static child traversal should only affect elements

view details

Evan You

commit sha 3c88299f6ac5e959f117af5d0a9af03588381581

release: v3.0.0-beta.12

view details

dependabot-preview[bot]

commit sha 74ed7d1d6bc259b60ffec6775fe64245db857519

build(deps-dev): bump @types/puppeteer from 2.0.1 to 2.1.0 Bumps [@types/puppeteer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/puppeteer) from 2.0.1 to 2.1.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/puppeteer) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 8159ae8b0d7e800f0b946a8ac06d1bc900888ff8

build(deps-dev): bump rollup from 2.9.1 to 2.10.0 Bumps [rollup](https://github.com/rollup/rollup) from 2.9.1 to 2.10.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.9.1...v2.10.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in a month

pull request commentvitejs/vite

fix: css modules duplicate module / hot reload issue when imported from both script and <style src>

Hmm I'm using Windows 10 for development and tests ran just fine. Not sure why it's failing on appveyor...

fnlctrl

comment created time in a month

PR opened vitejs/vite

fix: css modules duplicate module / hot reload issue when imported from both script and <style src>

This should fix two issues when a css module is imported from both script and <style src>

  • Class names are different (i.e. one css module loaded twice)
  • Changes in the css module won't trigger hot reload for js

Reproduction repo: https://github.com/fnlctrl/vite-cssm-bug-repo

+14 -1

0 comment

3 changed files

pr created time in a month

create barnchfnlctrl/vite-cssm-bug-repo

branch : master

created branch time in a month

created repositoryfnlctrl/vite-cssm-bug-repo

created time in a month

create barnchfnlctrl/vite

branch : fix-cssm

created branch time in a month

fork fnlctrl/vite

Native-ESM powered web dev build tool. It's fast.

fork in a month

startedvuejs/vue

started time in a month

startedwireapp/wire

started time in 2 months

fork fnlctrl/vue-i18n

:globe_with_meridians: Internationalization plugin for Vue.js

https://kazupon.github.io/vue-i18n/

fork in 3 months

startedacmesh-official/acme.sh

started time in 3 months

more