profile
viewpoint

filiphr/flowable-engine 2

A compact and highly efficient workflow and Business Process Management (BPM) platform for developers, system admins and business users.

filiphr/jug_switzerland_2019 2

The code for the JUG Switzerland presentation in 2019

filiphr/mapstruct 2

An annotation processor for generating type-safe bean mappers

filiphr/activemq-boot-jms-health 1

An ActiveMQ Spring Boot application depicting the blocking Health Endpoint

filiphr/mapstruct-builder-accessor 1

Alternative Accessor Naming Strategy for MapStruct that supports builder setters

filiphr/mapstruct-examples 1

Examples for using MapStruct

assertj/assertj-assertions-generator-idea-plugin 0

Intellij Idea plugin to generate AssertJ assertions for your custom types

filiphr/assertj 0

AssertJ documentation

filiphr/assertj-assertions-generator 0

Custom assertions generator http://joel-costigliola.github.io/assertj/assertj-assertions-generator.html

filiphr/assertj-core 0

AssertJ is a library providing easy to use rich typed assertions

issue commentflowable/flowable-engine

Flowable 6.5.0 delete deployment with active process instance corrupt the database

You can use the runtime service.

ProcessInstance processInstance = runtimeService.startProcessInstanceByKey("oneTaskProcess");
carbon-60

comment created time in 19 hours

pull request commentmapstruct/mapstruct

maven-compiler-plugin 3.8.1

Thanks for the PR @sullis

sullis

comment created time in 21 hours

push eventmapstruct/mapstruct

Sean C. Sullivan

commit sha 273487f152f0299a2633f0b2970e28c58c6c50cb

maven-compiler-plugin 3.8.1

view details

push time in 21 hours

pull request commentrelayrides/pushy

Prepare for change in project ownership

Could you give me a little more direction, though? What's on your mind?

We are not that heavy users of the library, so I don't have many ideas. The current API for building the APNs client is really good and we were able to customize it to our needs quite easily.

Here are some topics from me personally:

Spring Boot

It might be interesting to know how the others from the community are using this. We are heavy Spring Boot users, so we needed to wrap it in an auto configuration in order to configure it via properties. From my point of view providing a Spring Boot auto configuration might be a good thing. However, this completely depends on the community, if there isn't big demand it doesn't make sense to go in that direction.

If there is interested into this I can see if we can do a contribution with the auto configuration.

Integration

There are some issues from me personally. Those are mostly feedback and enhancement that could be done to make the integration a bit easier. However, I have to say again the API is quite permissive, so we could easily integrate what we needed.

Reactive Stack

We are not really using it. However, I know that there is some push in that direction currently. Pushy is already more or less ready since it uses Future(s) (I think I am not that well versed in the internals)

jchambers

comment created time in a day

pull request commentrelayrides/pushy

Proposal: drop the notion of maximum payload lengths

I had a better look at the current implementation. Yes you are right the check can really easily be done on the caller side. I had something else in mind (haven't been in this area for a while 😄).

I would say that given the current state of APNs (varying content size and large enough) it is OK to not do any checks, but rather build the payload as is and let the callers do the check.

jchambers

comment created time in a day

pull request commentjunit-team/junit5

Add JRE.currentVersion() for accessing the current JRE version

Great. Thanks a lot for merging it

filiphr

comment created time in a day

delete branch filiphr/flowable-engine

delete branch : json-node-date

delete time in 2 days

push eventflowable/flowable-engine

Filip Hrisafov

commit sha 32ff48f14f5761818acd21c3f1c0bc3a9c59f3de

Convert date into ISO 8601 when setting a value in the JsonNodeELResolver

view details

push time in 2 days

push eventfiliphr/flowable-engine

Jonathan Leitschuh

commit sha 1595fdb5ba3d77d53aa0f2893b58bc61727c18a3

Use HTTPS instead of HTTP to resolve dependencies (#2170) This fixes a security vulnerability in this project where the `pom.xml` files were configuring Maven to resolve dependencies over HTTP instead of HTTPS. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

view details

gdressino

commit sha 40b8e4a257f3e283b9f3b9da24ccb350cef785fb

Minor changes in Spanish translation + script (#2163) * Improved spanish translation Modules translated: - flowable-ui-admin - flowable-ui-idm - flowable-ui-modeler - flowable-ui-tash * Minor changes in Spanish translation + script Minor changes in Spanish translation. The files were edited to match line-by-line with the English version. A script was added to detect changes in the structure of the localization files. This script allows to identify new or deleted keys according to the English version, to keep a line-by-line matching.

view details

Pascal Schumacher

commit sha a911126bfa0fbad4baf2543144f9c54b580dc757

Update MyBatis to version 3.5.4. (#2165) * Update MyBatis to version 3.5.4. * Make AsyncHistoryUpgradeTest more stable in constraint environments like CI servers.

view details

Pascal Schumacher

commit sha 9970e431cd67d5f673e39f7ab1e57ef50876a21a

Update json-unit-assertj to version 2.13.0. (#2166)

view details

Pascal Schumacher

commit sha 5af4443dcafe327731aa8a66a2686be885f4726d

Update java-uuid-generator to version 3.3.0. (#2167)

view details

Pascal Schumacher

commit sha f78869c80f7c3ba87118c92468d6b4fc5b78e667

Update felix.fileinstall to version 3.6.4. (#2168)

view details

Pascal Schumacher

commit sha 103f50a1ff593b29f089aa13594c9408f6ab1a18

Remove reference to long dead Java.net maven repository. (#2159) Co-authored-by: Tijs Rademakers <tijs.rademakers@gmail.com>

view details

David B Malkovsky

commit sha 109cf497b62ee47975e809f82034e43028ee2803

Replace 'try finally' with 'try' with resources (#2158)

view details

Albin Hasani

commit sha b960d6a0133b1857e873795cd93853bbb006d3c1

Add order by method for sorting tasks by category (#2162) - add property for category - add method to the interface - add implementations - add usage in tests - category is an optional field and allows to 'tag' tasks as belonging to a certain category - corresponding tag is flowable:category - see #2113

view details

Filip Hrisafov

commit sha 35f751d1694e2771a07750f22b532d88feaec110

The BPMN, CMMN and App Spring Engines should use the SpringEventRegistryConfigurator

view details

push time in 2 days

create barnchfiliphr/flowable-engine

branch : json-node-date

created branch time in 2 days

pull request commentjunit-team/junit5

Add JRE.currentVersion() for accessing the current JRE version

Seems like you already fixed it @marcphilipp. I rebased the PR on top of master

filiphr

comment created time in 3 days

push eventfiliphr/junit5

Marc Philipp

commit sha c702b5f18b67dcdb0cb9d326dcfe769c89be29f3

Handle missing secrets on PR builds from forks - Inject Gradle Enterprise access key via file for jobs run on forks - Ignore empty build cache credentials

view details

Marc Philipp

commit sha a73dff5c95fe6bf18911a5ceab6619251e30e510

Use HOME environment variable provided by GitHub

view details

Filip Hrisafov

commit sha cb0abd37f9c94e7aee87245ff963663d45d773fb

Add JRE.currentVersion() for accessing the current JRE version Issue: #2176

view details

push time in 3 days

pull request commentrelayrides/pushy

Prepare for change in project ownership

I am reading this one just now. Would be interesting to where the project can grow in the future.

Anyways, I just wanted to say thank you for taking up the project and continuing the work you do with Pushy

jchambers

comment created time in 3 days

pull request commentrelayrides/pushy

Proposal: drop the notion of maximum payload lengths

This looks good to me @jchambers.

I like the direction towards using alternative / customizable JSON serializers.

What I would suggest is to still check for the default size and throw an IllegalArgumentException. Perhaps add the ability to build with or without a check. This would still reduce the complexity within the builder. The benefit of doing this would be that the user won't be able to get rejected by the APNs server and would get feedback earlier (if they opt into it).

From the perspective of how we are using pushy it won't make any difference, and I would personally use the approach without a size check.

jchambers

comment created time in 3 days

issue commentjunit-team/junit5

Expose JRE.CURRENT_VERSION for public access

Thanks for agreeing to this. PR #2184 has been submitted 😄

filiphr

comment created time in 3 days

PR opened junit-team/junit5

Add JRE.currentVersion() for accessing the current JRE version

Issue: #2176

Expose public static method for accessing the current JRE.

I was not sure whether I need to add something to the release notes about this or not.

Overview

<!-- Please describe your changes here and list any open questions you might have. -->


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

+96 -0

0 comment

2 changed files

pr created time in 3 days

push eventfiliphr/junit5

Filip Hrisafov

commit sha 0a02a4e1881077211a27e9e2210d0035c06268ff

Add JRE.currentVersion() for accessing the current JRE version Issue: #2176

view details

push time in 3 days

push eventfiliphr/junit5

Filip Hrisafov

commit sha 4b3bd4a9e08c78a43d8772a196a2da46ded4c879

Add JRE.currentVersion() cor accessing the current JRE version Issue: #2176

view details

push time in 3 days

create barnchfiliphr/junit5

branch : jre-current-version

created branch time in 3 days

delete branch filiphr/junit5

delete branch : marc/maven-central-stats

delete time in 4 days

delete branch filiphr/junit5

delete branch : marc/jdk13

delete time in 4 days

delete branch filiphr/junit5

delete branch : task-based-execution-engine

delete time in 4 days

delete branch filiphr/junit5

delete branch : proposals

delete time in 4 days

delete branch filiphr/junit5

delete branch : ota-exception-hierarchy

delete time in 4 days

delete branch filiphr/junit5

delete branch : issue169-RuleAdapter-experiments

delete time in 4 days

delete branch filiphr/junit5

delete branch : issue58-dynamic-tests-with-new-resolvers-rebased

delete time in 4 days

delete branch filiphr/junit5

delete branch : issue58-dynamic-tests-with-new-resolvers

delete time in 4 days

delete branch filiphr/junit5

delete branch : groovy-2.5.7

delete time in 4 days

delete branch filiphr/junit5

delete branch : 1514-refactor

delete time in 4 days

delete branch filiphr/junit5

delete branch : issues/2039-recursive-nested-hierarchy

delete time in 4 days

delete branch filiphr/junit5

delete branch : issues/1826-github-actions-cache

delete time in 4 days

delete branch filiphr/junit5

delete branch : issues/1771-testkit-loose-event-matching

delete time in 4 days

delete branch filiphr/junit5

delete branch : issues/1724-classgraph

delete time in 4 days

delete branch filiphr/junit5

delete branch : issues/1555-singleton-resource

delete time in 4 days

delete branch filiphr/junit5

delete branch : issues/1170-methods-with-strange-names

delete time in 4 days

delete branch filiphr/junit5

delete branch : issues/1042-remove-visitor

delete time in 4 days

delete branch filiphr/junit5

delete branch : issues/864-declarative-extension-registration-params-fields

delete time in 4 days

delete branch filiphr/junit5

delete branch : issues/358-nullability-annotations

delete time in 4 days

delete branch filiphr/junit5

delete branch : experiments/test-kit-generated-assertions

delete time in 4 days

delete branch filiphr/junit5

delete branch : experiments/platform-suites

delete time in 4 days

delete branch filiphr/junit5

delete branch : experiments/json-reporting

delete time in 4 days

delete branch filiphr/junit5

delete branch : experiments/jaeger-reporting

delete time in 4 days

delete branch filiphr/junit5

delete branch : experiments/gradle-instant-execution

delete time in 4 days

delete branch filiphr/junit5

delete branch : experiments/dependency-extension-functions

delete time in 4 days

fork filiphr/junit5

The next generation of JUnit.

https://junit.org

fork in 4 days

pull request commentspring-projects/spring-boot

DataSource url property is ignored when there is no connection pool

@snicoll the problem is not about not having an embedded driver on the classpath, but rather having a wrong or missing a connection pool. Which leads to using a wrong database even though you have configured your datasource url.

Originally I opened issue #19192 which was closed in favour of this PR.

nosan

comment created time in 8 days

push eventmapstruct/mapstruct

Filip Hrisafov

commit sha ff27b2f70d9c9b4a5d120d9a4b145941d0db2865

Migrate the processor test infrastructure from Junit 4 to JUnit Jupiter With JUnit Jupiter it is still not possible to set the ClassLoader for loading the test class. Therefore, use the ModifiedClassLoaderExtension (heavily inspired by the Spring Boot https://github.com/spring-projects/spring-boot/blob/bde7bd0a1a310f48fb877b9a0d4a05b8d829d6c0/spring-boot-project/spring-boot-tools/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/classpath/ModifiedClassPathExtension.java). Once JUnit Jupiter 201 is resolved we can simplify this. With this extension we can catch all the tests in a class and then run them once the Class Extension Store gets closed with a modified ClassLoader. The CompilationCache is stored in the GlobalCache with the CompilationRequest as key. This means that even when methods are not executed in some particular order if they have same WithClasses then they would reuse the cache.

view details

Filip Hrisafov

commit sha d4268e87e50dba97002e81e7ac1e2e1deb85f646

Migrate tests to use new JUnit Jupiter Infrastructure Update test annotations to be JUnit Jupiter compatible Replace all Test annotations from tests that are run with the AnnotationProcessorTestRunner with ProcessorTest. Replace JUnit 4 Test#expected with assertThatThrownBy from AssertJ. Replace Rule for GeneratedSource with RegisterExtension. Fix some tests that were not reverting the changes to the default Locale and TimeZone. Replace usage of org.junit.Assert with equivalent from org.junit.jupiter.api.Assertions or AssertJ.

view details

push time in 9 days

create barnchfiliphr/junit5-samples

branch : reporting-issues

created branch time in 9 days

fork filiphr/junit5-samples

Collection of sample applications using JUnit 5.

fork in 9 days

push eventmapstruct/mapstruct

Filip Hrisafov

commit sha ce11b32928d60f7e269c70695e922282fb358522

Migrate the processor test infrastructure from Junit 4 to JUnit Jupiter With JUnit Jupiter it is still not possible to set the ClassLoader for loading the test class. Therefore, use the ModifiedClassLoaderExtension (heavily inspired by the Spring Boot https://github.com/spring-projects/spring-boot/blob/bde7bd0a1a310f48fb877b9a0d4a05b8d829d6c0/spring-boot-project/spring-boot-tools/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/classpath/ModifiedClassPathExtension.java). Once https://github.com/junit-team/junit5/issues/201 is resolved we can simplify this. With this extension we can catch all the tests in a class and then run them once the Class Extension Store gets closed with a modified ClassLoader. The CompilationCache is stored in the GlobalCache with the CompilationRequest as key. This means that even when methods are not executed in some particular order if they have same WithClasses then they would reuse the cache.

view details

Filip Hrisafov

commit sha 1cc87869a5477ac85795bad3240e4f8c66b1f4d5

Migrate tests to use new JUnit Jupiter Infrastructure Update test annotations to be JUnit Jupiter compatible Replace all Test annotations from tests that are run with the AnnotationProcessorTestRunner with ProcessorTest. Replace JUnit 4 Test#expected with assertThatThrownBy from AssertJ. Replace Rule for GeneratedSource with RegisterExtension. Fix some tests that were not reverting the changes to the default Locale and TimeZone. Replace usage of org.junit.Assert with equivalent from org.junit.jupiter.api.Assertions or AssertJ.

view details

push time in 9 days

issue openedmapstruct/mapstruct

Migrate Processor test infrastructure to JUnit Jupier

This is a general issue for all the JUnit Jupiter migrations:

  • [ ] Split Generated Source into assertion for fixtures and checking the generated source
    • [ ] GeneratedSource as a Parameter to test methods so that they can use it for checking the source code
    • [ ] Annotation similar to ExpectedCompilationOutcome for checking the fixtures
  • [ ] Simplify the compilation so that it can be directly created from a compilation request. The extensions should not know about the output directories

I have already started on some migration on https://github.com/mapstruct/mapstruct/tree/junit5

created time in 9 days

push eventmapstruct/mapstruct

Filip Hrisafov

commit sha 04576de1d1689aac439c092164c1fef7175e57c3

#1552 Stop processing source parameters for unprocessed defined properties when a mapping is found

view details

Filip Hrisafov

commit sha ded8d88c73c18323eae421e92c14949dccbd78be

#1578 Rename isBuilderSetter to isFluentSetter in the DefaultAccessorNamingStrategy

view details

Sjaak Derksen

commit sha bd2c206f7f7fb8eadb62b368694c1e4cea4aff6c

#1590 ArrayList missing as import for NVMS.RETURN_DEFAULT (#1598)

view details

Sjaak Derksen

commit sha 3da85bc1787c9001a8118d3b60c4f469fcfb6f7e

#1596 Missing builder type import (#1602)

view details

Sjaak Derksen

commit sha 13aa94742183fc5eedb3c991b55336d1b63a68dc

#1569 Reproducer missing Immubable buildertype import (#1605)

view details

Sjaak Derksen

commit sha 5a4990c47410df958db84dd9bb333c1d967b1fad

#1456 apply source presence tracking recursively (in nested source)

view details

Sebastian

commit sha 30c2dadec7b84895498db7f99308f169f2f516e4

#1561 add support for adders in combination with streams - Extended Type#getAlternativeTargetAccessors to recognize stream read accessors for which no corresponding setter exists (there is only an add method) - Extended SourceRHS#getSourceTypeForMatching to return the correct source type for streams too - Add StreamAdderWrapper to map Stream -> Adder - Extended PropertyMapping$PropertyMappingBuilder#assignToPlainViaAdder to return StreamAdderWrapper if source type is stream

view details

Filip Hrisafov

commit sha dcddba68533a3b6c8ce102d8346b3b2e1452b0e1

Add Sebastian to copyright.txt

view details

Sjaak Derksen

commit sha 459f57e8058800847d8c8ebaa4f26d024ecd517d

#1571 apply nullvaluecheck strategy on all relevant levels

view details

Sjaak Derksen

commit sha 4f539d2a084f80744134598b423f50b2cf8f4975

#1616 Adding an issue template to streamline answers

view details

neoXfire

commit sha 6b3cbaae9e1625f147212a9c726ae13fa1bd1239

#1595 Support for conversion between java.time.Instant and java.util.Date (#1622)

view details

Filip Hrisafov

commit sha ef82ebfbcaa652792fccb70d72861806ce0bf4c6

#1595 Update reference guide with implicit conversion between java.time.Instant and java.util.Date

view details

Sjaak Derksen

commit sha fa1ab4b781f39ccbb845a1d4994103e6609a8db9

Update copyright.txt

view details

Filip Hrisafov

commit sha f17ddcfb1874bb271b4b7b921a4e416467e977e5

#1608 Make sure that property names for fluent setters starting with is are handled properly (#1620)

view details

Filip Hrisafov

commit sha 0e0fd313e560dd17097f730f7d759d95d84eb1ee

#1594 Add test case to show that it has been fixed

view details

Filip Hrisafov

commit sha 6d5243dc2fbee57599a1aacfec2646288ba323f4

#1551 Use javax.annotation.processing.Generated if it is available and source version is at least RELEASE_9

view details

Sivaraman Viswanathan

commit sha 9f8c0749d1f465221ac7ca856085619081e6219c

#1591 Add support for mapping java.time.LocalDate to java.sql.Date

view details

Filip Hrisafov

commit sha 20bff96e99ce4a89be199e6bb909ddef5d2f5c9e

#1591 Update reference guide with implicit conversion between java.time.LocaDate and java.sql.Date

view details

Florian Tavares

commit sha d81d3e46a4b19191fff808c3b963001c6fe41a47

#1301 Use Java 8 as baseline for MapStruct * Move classes from mapstruct-common into mapstruct * Use Java 8 @Repeatable for @Mappings and @ValueMappings in the mapstruct module * Add relocation for mapstruct-jdk8 to mapstruct * Use of 1.8 source and target versions from parent POM * Update documentation to match * Update versions of some maven plugin crashing build on Java 8 * Drop JDK 6 & 7 support in integration tests * Remove mapstruct-common module (it was never deployed to Central)

view details

Florian Tavares

commit sha 71e9bd3699d1a295bf51abb7d685a093cfc1aa6f

#1301 code improvements / adaptations after language-level upgrade

view details

push time in 10 days

issue commentjunit-team/junit5

Introduce extension API for providing a custom ClassLoader (e.g., for Powermock)

Another concrete use case which is similar to the classpath-junit-extension is the ModifiedClassPathExtension which is used in the Spring Boot tests.

The way that this has been implemented allows to skip the initial execution via an InvocationInterceptor and then use the Launcher to launch the test again with the modified class loader. I have also went down this path with my requirement in our tests infrastructure. However, this adds ~300ms of execution time per test, which is understandable since it goes through the whole discovery scenario again.

I think that there are a lot of interested parties for this extension point and I think that everyone would be willing to try out in their own respective projects.

mepeisen

comment created time in 10 days

push eventfiliphr/spring-boot

Spring Buildmaster

commit sha e5303ab755a2dbf0dc3bf9f9c88534b47e404bfe

Next development version (v2.1.12.BUILD-SNAPSHOT)

view details

Jorge Cordoba

commit sha f22d0c7d8e1c677b516300e543cc5128f12aff5d

Add missing assertion to SampleTestApplicationWebIntegrationTests.test() See gh-19326

view details

Stephane Nicoll

commit sha cd085e0641c47490e771625202a648e4de0970fa

Polish contribution See gh-19326

view details

Stephane Nicoll

commit sha bf397412e6e7d7f4ffd218c55b939509107481d0

Merge pull request #19326 from jcordoba95 * pr/19326: Polish contribution Add missing assertion to SampleTestApplicationWebIntegrationTests.test() Closes gh-19326

view details

Stephane Nicoll

commit sha 01753ab5a011396629107b34d42b8241782627da

Merge branch '2.1.x' into 2.2.x Closes gh-19358

view details

Stephane Nicoll

commit sha 2c38f09911fa275e66c1792e9676ac0b81ae3c16

Merge branch '2.2.x' Closes gh-19359

view details

dreis2211

commit sha 29b602d6a08a4a7686e79d0e307c83ae78e19448

Fix link to Vaadin Spring Boot starter See gh-19338

view details

Stephane Nicoll

commit sha 283b60d24b6a7b08abc97830be6e7969cd5ee604

Merge pull request #19338 from dreis2211 * pr/19338: Fix link to Vaadin Spring Boot starter Closes gh-19338

view details

Stephane Nicoll

commit sha fc35384b037ed0ecb95f4b2b355942aee8cd7aa0

Merge branch '2.1.x' into 2.2.x Closes gh-19360

view details

Stephane Nicoll

commit sha 1d3554de060afc7cb02256d1fc709e5b6a26134e

Merge branch '2.2.x' Closes gh-19361

view details

dreis2211

commit sha 207a5c5022a34387e2f79e44c01774ca6bff3f0e

Link consistently to Tomcat 9.0 docs See gh-19340

view details

Stephane Nicoll

commit sha d93206f5c66cdf9642d4d13f1e89b5182a813058

Merge pull request #19340 from dreis2211 * pr/19340: Link consistently to Tomcat 9.0 docs Closes gh-19340

view details

Stephane Nicoll

commit sha c3ae8bcfdc2be7a6797b606a3b6ef6efdcd3381a

Merge branch '2.1.x' into 2.2.x Closes gh-19362

view details

Stephane Nicoll

commit sha 58022d72f5beb60a8bf77647de3c3b47eab15830

Merge branch '2.2.x' Closes gh-19363

view details

Madhura Bhave

commit sha 8f5777cf9ebce1762aa1202e03a51d60f2973d4f

Optimize JarLauncher when used with exploded jar - Previously, we would create a JarFileArchive for all nested jars. This was an additional overhead. We only need to create a JarFileArchive for jars that can have nested jars in them. For all other jars we only need the URL to build the classpath. - While iterating over nested entries in the exploded jar, we only need to look at BOOT-INF and we can skip any entry that does not match that. Closes gh-16655 Co-authored-by: Phillip Webb <pwebb@pivotal.io>

view details

Madhura Bhave

commit sha 8dcf1e4033eb1b453447fe48d2cbc9aa8c674d97

Provide end-to-end traceability for config properties Closes gh-14880 Co-authored-by: Andy Wilkinson <awilkinson@pivotal.io>

view details

dreis2211

commit sha 3be05f61e15eeeb0050d46f45046c9a34fa47c02

Fix unknown tag in javadoc See gh-19364

view details

Madhura Bhave

commit sha 51e558b08d5b0c3000b73c76d0b6659b5601aada

Merge pull request #19364 from dreis2211 * pr/19364: Fix unknown tag in javadoc Closes gh-19364

view details

Phillip Webb

commit sha 9bdad06c10ad40c7ef02971cb923d52fd84c8f53

Polish Netty SSL key alias support See gh-19197

view details

Phillip Webb

commit sha accd830dd5f49f97c5e87d74d5a4b7f6941bdf47

Update copyright header of changed files

view details

push time in 10 days

issue commentjunit-team/junit5

Expose JRE.CURRENT_VERSION for public access

My condition is similar to EnabledForJreRange and DisabledForJreRange. However, I can't use those since the template can be enabled for Java 11 for Javac, but disabled for Eclipse.

An example can be found here:

https://github.com/mapstruct/mapstruct/blob/a6b3cc364a7824a4584fdd690c82c6695447dd79/integrationtest/src/test/java/org/mapstruct/itest/testutil/extension/ProcessorEnabledOnJreCondition.java#L32-L36

filiphr

comment created time in 10 days

issue openedjunit-team/junit5

Expose JRE.CURRENT_VERSION for public access

I've recently been fiddling with Junit Jupiter in order to migrate some of our custom Junit 4 runners into appropriate Jupiter extensions.

Due to different reasons we need to write custom ExecutionCondition which would enable or disable running of certain tests under different JREs. We can't use the @DisabledOnJre feature since we are using a @TestTemplate which based on the passed information would later on decide if it can execute the test on the current JRE.

In our case we are running some compiler tests with Eclipse JDT and Javac. When running under Java 11 we need to disable the Eclipse JDT tests. We are using a template since the same test is executed twice, once with Eclipse and once with Javac.

Current workaround is to do

 static final JRE CURRENT_VERSION;

    static {
        JRE currentVersion = JRE.OTHER;
        for ( JRE jre : JRE.values() ) {
            if ( jre.isCurrentVersion() ) {
                currentVersion = jre;
                break;
            }
        }

        CURRENT_VERSION = currentVersion;
    }

However, it would be better if this can be provided by the JRE class itself. for example JRE.currentVersion().

If the JUnit team is OK with such addition to the JRE API I can provide a PR for adding it

Deliverables

  • [ ] ...

created time in 11 days

push eventfiliphr/mapstruct

Andrei Arlou

commit sha ee8f9283f2340e981d3ad99f786801329b013a89

Simplify conditions in package org.mapstruct.ap.internal.model and classes: Conversions.java, MappingResolverImpl.java, EclipseAsMemberOfWorkaround.java

view details

Andrei Arlou

commit sha 55048ab045ef1cf6e2d10b25ba76682a0725bac8

Simplify consistent checks in class Mapping

view details

Andrei Arlou

commit sha 8e37159a00041104a20ba8a8eaa786b7cc9bd92d

Fix minor warnings: remove unnecessary generic type for collections, remove unnecessary exceptions from signature, fix typos

view details

Andrei Arlou

commit sha ba90c95f232b144f6b73033e3371e7f8a9e65f56

#991 Split reference guide source into an adoc file per chapter

view details

Andrei Arlou

commit sha 3fd29f3ff9ba0f9388bf49e8264d77b841dd90bc

Merge pull request #1879 from Captain1653/asccii_doctor_split_reference #991 Split reference guide source into an adoc file per chapter

view details

Sjaak Derksen

commit sha 6d9a50601ee84accef48882ef91b2870f4239980

#1867 refactor make the source model only a reflection of the source (#1868)

view details

Sjaak Derksen

commit sha e12f9ffd7b906da4649d8c22903589f2ac3df67a

Refactoring of BeanMapping and Source/TargetReferences (common base class) (#1903)

view details

Andrei Arlou

commit sha e068564017fd1ad3b33db18df04d03d958af35f5

#724 Remove JaxbMapper from integration test (#1892)

view details

Andrei Arlou

commit sha f95648cef83f84f91522f039886b440d65961ba6

#1088 Refactor constructor ForgedMethod (#1888)

view details

Andrei Arlou

commit sha 7af107c9f2707a54467d631ae33d47e6a0cd5940

#1883 Remove not used method "asCollectionOrMap" from TypeFactory (#1884)

view details

Andrei Arlou

commit sha 3868735da7e0a61f4511342ea2a1e38d29cc8c3c

#1897 Remove unused methods from class SourceMethod (#1898)

view details

Andrei Arlou

commit sha 2043506179d11eab78fe3f709573a36cdff0069a

#1895 Refactor class org.mapstruct.ap.internal.util.Filters (#1896)

view details

Andrei Arlou

commit sha c044a879694cec5536baf046cb1d9377144e82e7

#1889 Remove unused parameters from classes TargetTypeSelector, ValueMapping, MethodRetrievalProcessor (#1890)

view details

Andrei Arlou

commit sha f3b0badcefc6f7a16aaa53260aad8701d4caffa9

Add Andrei Arlou in copyright list (#1906)

view details

Sjaak Derksen

commit sha 7e0327767f1a375a59b76ef2458a6394d8a5786e

#1801 Using constructor as builderCreationMethod in custom builder (#1905)

view details

Andrei Arlou

commit sha 447bb00f8932abfff2fd3ab9ee3dcb5e57223edd

#1773 Update documentation: componentModel=jsr330 with @DecoratedWith not longer experimental (#1907)

view details

Filip Hrisafov

commit sha d018aed25150d886b54d41099345908c01d4cc7b

#1790 Use mapperPrism.values.nullValuePropertyMappingStrategy when retrieving NullValuePropertyMappingStrategy

view details

Andrei Arlou

commit sha 750ce48023e9cd0022b34e86d72f1cd5ee0d4bb7

#1792 Annotation processor option for default injection strategy

view details

Filip Hrisafov

commit sha e92e3b45c6c8bc1bd4a501e6432f884e80153a29

#1904 Create compilation error if a mapper could not be created due to a TypeHierarchyErroneousException

view details

Filip Hrisafov

commit sha fcdf852a172ad04c1dceb413c3f29a1d0273e49a

#1904 Do not include private methods when getting enclosed executable elements

view details

push time in 11 days

issue commentmapstruct/mapstruct

Including both shadow copy and deep copy may be better

@patrickrioux this feature would be part of the 1.4 release. Currently you can try it by using 1.4.0-SNAPSHOT.

If the source is a Hibernate Entity object being used to generated a DTO, this should be a clone copy of the DTO. But it sounds like that DTO is a copy of the Entity which is still attached to the DB.

Sorry but I couldn't understand what you mean with that. Can you give an example perhaps?

wangtengchao

comment created time in 11 days

issue commentmapstruct/mapstruct

problem on map lazy fields

@rinaldodev of course it is a reasonable thing to ask. However, MapStruct is reflection free and it generates mapping code during compilation time. It has no knowledge about any runtime information.

Therefore one way to achieve this is to us what @kokorin proposed in https://github.com/mapstruct/mapstruct/issues/778#issuecomment-458135293 or what @sjaakd proposed in https://github.com/mapstruct/mapstruct/issues/778#issuecomment-458240412.

My personal way of doing it is to add a presence checker in your entity where you can check if the collection was initialised or not.

alireza-hanifi

comment created time in 11 days

issue closedmapstruct/mapstruct-examples

kotlin example - java.lang.Long does not have an accessible parameterless constructor

Hi, I'm trying to define a custom mapping methods between different types.

I have adjusted the PersonDto.kt and Person.kt on the mapstruct kotlin-example so that the phonenumber is stored once as a string and once as a long.

This is how my mapper looks like:

@Mapper
interface PersonConverter {

    @Mapping(source = "phoneNumber", target = "phone", qualifiedByName = ["PhoneToLong"])
    fun convertToDto(person: Person): PersonDto

    @Mapping(source = "phone", target = "phoneNumber", qualifiedByName = ["PhoneToString"] )
    fun convertToModel(personDto: PersonDto): Person

    @Named("PhoneToLong")
    fun phoneToLong(obj: String?): Long? {
        return 123L
    }

    @Named("PhoneToString")
    fun phoneToString(obj: Long?): String {
        return "123"
    }
}

I'm not sure if this is a kapt or Mapstruct problem. But the compiler throws this error: [ERROR] C:\dev\source\workspace\mapstruct-examples\mapstruct-kotlin\target\kaptStubs\compile\org\mapstruct\example\kotlin\converter\PersonConverter.java:21: error: java.lang.Long does not have an accessible parameterless constructor. [ERROR] public abstract java.lang.Long phoneToLong(@org.jetbrains.annotations.Nullable()

closed time in 11 days

vb-dci

issue commentmapstruct/mapstruct-examples

kotlin example - java.lang.Long does not have an accessible parameterless constructor

There is nothing that we can do from the Java side. This is a known problem in Kotlin. Have a look at https://github.com/mapstruct/mapstruct/issues/1577. Kotlin has @JvmDefault annotation but that also doesn't work (see KT-25960). For the time being I would suggest that you use an abstract class instead of an interface.

vb-dci

comment created time in 11 days

pull request commentmapstruct/mapstruct

Fix Javadoc of resolveViaMethodAndConversion

Thanks for the PR @timjb

timjb

comment created time in 11 days

push eventmapstruct/mapstruct

Tim J. Baumann

commit sha a6b3cc364a7824a4584fdd690c82c6695447dd79

Fix Javadoc of resolveViaMethodAndConversion and fix some smaller Javadoc typos.

view details

push time in 11 days

PR merged mapstruct/mapstruct

Fix Javadoc of resolveViaMethodAndConversion

and fix some smaller Javadoc typos.

+5 -5

0 comment

1 changed file

timjb

pr closed time in 11 days

pull request commentmapstruct/mapstruct

Updated versions on readme.md to 1.3.1.Final

Thanks a lot @vegemite4me.

Not the most productive of PRs

Every single PR and contribution is welcomed, it doesn't matter how big or small is.

vegemite4me

comment created time in 11 days

push eventmapstruct/mapstruct

Robin Clarke

commit sha 015468b46122d9f0c2e3b43d51a280a255e36a37

Updated versions on readme.md to 1.3.1.Final

view details

push time in 11 days

PR merged mapstruct/mapstruct

Reviewers
Updated versions on readme.md to 1.3.1.Final

Not the most productive of PRs, but hope it prevents someone bumping into the bug in 1.3.0 to do with field names that start with the three letters 'set'. Thanks for building a great tool.

+5 -5

0 comment

1 changed file

vegemite4me

pr closed time in 11 days

push eventmapstruct/mapstruct

Filip Hrisafov

commit sha c64e03468e51b0e55a1bc2f6ee965445e9dffb07

Fix Checkstyle error

view details

push time in 11 days

push eventfiliphr/mapstruct

Filip Hrisafov

commit sha 02a113b2d405fa2e0ecf17aa5bea6a326776ca9a

#1308 Switch to JUnit Jupiter and do not use Toolchains for the integration tests (#2013) The CI should be setup to run on different Java versions, for which the integration tests are going to be run

view details

Filip Hrisafov

commit sha f382903bc689a7e7e043fc72a9ec9d4686f69db1

Add proper attribution for the code for generating the sourceTargetVersion for other JRE

view details

Filip Hrisafov

commit sha c64e03468e51b0e55a1bc2f6ee965445e9dffb07

Fix Checkstyle error

view details

push time in 11 days

push eventfiliphr/flowable-engine

Joram Barrez

commit sha a8ce890a5f01e233f9c32031985cb759f99db760

Export sentry ref in default namespace

view details

Filip Hrisafov

commit sha 94754a380e177e8fadfafee4b4f04a58ddb35b5a

The BPMN, CMMN and App Spring Engines should use the SpringEventRegistryConfigurator

view details

push time in 13 days

issue commentmapstruct/mapstruct

Wrong decorator class name used when Decorator class is nested inside mapper interface

Thanks for the bug report @xak2000.

We'll fix this for the next release. In the meantime you can move out the decorator from your class to a top level location. That should work

xak2000

comment created time in 14 days

push eventmapstruct/mapstruct

Filip Hrisafov

commit sha f382903bc689a7e7e043fc72a9ec9d4686f69db1

Add proper attribution for the code for generating the sourceTargetVersion for other JRE

view details

push time in 15 days

push eventfiliphr/flowable-engine

push time in 15 days

create barnchfiliphr/flowable-engine

branch : include-event-spring-registry

created branch time in 15 days

push eventfiliphr/flowable-engine

Joram Barrez

commit sha df505854e8c6cf90c3069aa23d5c991c7f4be069

Fix NPE (see https://forum.flowable.org/t/npe-in-listpage-query/2265/4)

view details

Filip Hrisafov

commit sha ca078284d683add9e72c569022f04f7ebe9959bd

The BPMN, CMMN and App Spring Engines should use the SpringEventRegistryConfigurator

view details

push time in 15 days

push eventmapstruct/mapstruct

Filip Hrisafov

commit sha 02a113b2d405fa2e0ecf17aa5bea6a326776ca9a

#1308 Switch to JUnit Jupiter and do not use Toolchains for the integration tests (#2013) The CI should be setup to run on different Java versions, for which the integration tests are going to be run

view details

push time in 15 days

PR merged mapstruct/mapstruct

#1308 Switch to JUnit Jupiter and do not use Toolchains for the integration tests

The CI should be setup to run on different Java versions, for which the integration tests are going to be run

Travis is currently running Java 8, 11, 13 and EA.

I'll update to GitHub Actions eventually as well

Fixes #1308

+773 -1130

2 comments

38 changed files

filiphr

pr closed time in 15 days

issue closedmapstruct/mapstruct

Enable integration tests to run on Java 9

As recently explored by @filiphr. Some fiddling with toolchains is needed, it seems.

closed time in 15 days

gunnarmorling

issue openedmapstruct/mapstruct

Use GitHub Actions

With #2013 we are moving to Jupiter for the integration test and using matrix builds for the tests.

Let's move everything to GitHub Actions for modelling more complex scenarios. We should have the following:

  • [ ] Run and compile everything with JDK 8, 11, 13, 14-ea and 15-ea
  • [ ] Compile processor with JDK 8 and run integration tests with 11, 13, 14-ea and 15-ea
  • [ ] Publish SNAPSHOTs to Central
  • [ ] Publish code coverage to codecov

created time in 15 days

pull request commentmapstruct/mapstruct

#1308 Switch to JUnit Jupiter and do not use Toolchains for the integration tests

Thanks a lot for the review Andreas.

In a more complex build pipeline, you could even think of building the artifacts with our default JDK version (8?) and use these exact jar files in the integration tests spawned as matrix build. I bet that can be modelled with GitHub actions.

This is actually a great idea and not difficult at all with GitHub Actions. Would put it in the ideas for migrating there.

filiphr

comment created time in 15 days

CommitCommentEvent

push eventfiliphr/flowable-engine

Filip Hrisafov

commit sha ba80c0788202fda8fedb21a249b63468b686fc8f

Fix wrong import order in ProcessInstanceQueryTest

view details

push time in 16 days

push eventflowable/flowable-engine

Filip Hrisafov

commit sha ba80c0788202fda8fedb21a249b63468b686fc8f

Fix wrong import order in ProcessInstanceQueryTest

view details

push time in 16 days

pull request commentjoel-costigliola/assertj-core

Add Sonar scan on push events

Is it possible to also add

 if: github.repository == 'joel-costigliola/assertj-core'

for the job?

This way the job would be skipped on forks. Otherwise, contributors will also have this running and would be getting emails due to failures (the SONAR_TOKEN not being present)

scordio

comment created time in 16 days

push eventmapstruct/mapstruct.org

filiphr

commit sha 34f1bc79a3e82a6b51a52c688ee3fa839340c0fa

Automated deployment: Mon Feb 3 08:29:39 UTC 2020 e31eb57088bab65bf586c01dc145b5a17e42a32d

view details

push time in 16 days

delete branch filiphr/mapstruct.org

delete branch : gem-tools

delete time in 16 days

push eventmapstruct/mapstruct.org

Filip Hrisafov

commit sha e31eb57088bab65bf586c01dc145b5a17e42a32d

Blog post for announcing Gem Tools

view details

push time in 16 days

PR opened mapstruct/mapstruct.org

Blog post for announcing Gem Tools
+405 -0

0 comment

1 changed file

pr created time in 16 days

push eventflowable/flowable-engine

Filip Hrisafov

commit sha e81a4b7e84435f5d6fec09479fa83fa6ac826ec0

Stabilise ProcessInstanceQueryTest#testQueryByDeploymentIdIn by not testing the order

view details

push time in 16 days

push eventfiliphr/flowable-engine

Filip Hrisafov

commit sha 0f0c7371d71129438443858820269329915379c2

Update IntelliJ code style Use default continuation indent size (8) and blank lines around method (0)

view details

冀正

commit sha af574cfbc3768453231fd0d6ad567996e9aa4483

6.5.1 zh (#2148) * httpTask missing httpActivityBehaviorClass * Revert "httpTask missing httpActivityBehaviorClass" This reverts commit 25c6adeb1f1a73bd7eeaed2fc4a9e82eabc04641. * test * Designer Chinese documentation perfect

view details

Pascal Schumacher

commit sha 49f180151caa80f9063a5ee49659b82b3a463311

Update swagger-annotations and swagger-models to version 1.5.24. (#2151)

view details

Pascal Schumacher

commit sha be9c4e2a41962ff52266dfe96f1b96360fc656da

Update AssertJ to version 3.15.0. (#2152)

view details

gdressino

commit sha 0d38bf3225f264ec73ae5425df3e4cba776f934e

Improved spanish translation (#2146) Modules translated: - flowable-ui-admin - flowable-ui-idm - flowable-ui-modeler - flowable-ui-tash

view details

Pascal Schumacher

commit sha 98723d5abf38e7558b035fc3f9022d3616584e11

Update JUnit Jupiter to version 5.6.0. (#2139)

view details

contextshuffling

commit sha 0f490495615e1c8170bc58731d4469d04138f62f

Make test more stable by not assuming the order (#2147)

view details

Pascal Schumacher

commit sha 4dc35686a25fd662ef2d0f4b588c7620fd94d9dd

Update Camel to version 2.25.0. (#2154)

view details

Pascal Schumacher

commit sha 8f5698e1d3f19b8751d331bb36dcf1a58bf80bf4

flowable-ui-idm-app: Fix duplicated HTML id attribute in idm-privilege-mgmt.html by renaming both ids. (#2156)

view details

Pascal Schumacher

commit sha b38158c15fd391c25d4670afda776e9e9f4c7923

Copy retry code for setting up the test mail server from org.flowable.engine.test.bpmn.mail.EmailTestCase to org.flowable.examples.bpmn.mail.EmailTestCase, to fix occasional failures on CI servers (Github Actions and Travis CI). (#2155)

view details

mo-nick

commit sha 40f5c8d0c3e8111aedd39c47d0ee82e915c9441b

Spring beans secure js (#2140) * accessing spring beans in script tasks with secure javascript mode * test for accessing spring beans in script tasks with secure javascript mode * standardize imports' order * making access to beans in secure-javascript script task configurable Co-authored-by: mohammad-nick <56077690+mohammad-nick@users.noreply.github.com>

view details

Tijs Rademakers

commit sha e2e420ffbc7c86d9ded5b98305ec752e40321258

Fix duplicate key issue in translation file #2145

view details

Filip Hrisafov

commit sha e81a4b7e84435f5d6fec09479fa83fa6ac826ec0

Stabilise ProcessInstanceQueryTest#testQueryByDeploymentIdIn by not testing the order

view details

push time in 16 days

pull request commentflowable/flowable-engine

Use LinkedHashMap for deterministic iterations

Thanks a lot for adapting this @contextshuffling

contextshuffling

comment created time in 16 days

push eventfiliphr/mapstruct

Sjaak Derksen

commit sha 58da2d293f74309b3679b331013f6466d2d09aa8

#695 user control over mapping means (direct, method, conversion, 2step)

view details

Filip Hrisafov

commit sha 95ceba1a1e123bd23c11fc9f103899205ff3f45d

#2016 Update Checkstyle to 8.29 Adapt checkstyle configuration with new changes: * Move cacheFile to Checker module * Move LineLength to Checker module * Use SuppressWithPlainTextCommentFilter

view details

push time in 16 days

create barnchfiliphr/mapstruct.org

branch : gem-tools

created branch time in 16 days

push eventmapstruct/mapstruct.org

Filip Hrisafov

commit sha dd90dda663b2abe69fe560d1f0dc0e4ed3095d4f

Publish page only if the push was in the mapstruct.org repository

view details

push time in 16 days

push eventfiliphr/mapstruct.org

Filip Hrisafov

commit sha dd90dda663b2abe69fe560d1f0dc0e4ed3095d4f

Publish page only if the push was in the mapstruct.org repository

view details

push time in 16 days

push eventfiliphr/mapstruct.org

filiphr

commit sha 4468225f1581a90fd235b94691d724fb38c55179

Automated deployment: Sun Feb 2 15:23:36 UTC 2020 482a38af48e4ace2200273407a4cbdb252c2c978

view details

push time in 17 days

push eventmapstruct/mapstruct.org

filiphr

commit sha f03f1092436bbdada9d2c8c9c1d074198b58120c

Automated deployment: Sun Feb 2 15:23:28 UTC 2020 482a38af48e4ace2200273407a4cbdb252c2c978

view details

push time in 17 days

push eventfiliphr/mapstruct.org

Filip Hrisafov

commit sha 4ebbcef51ce980d7f56bad62df2b22b39901e546

#96 Allow using latest version for Hugo Allow using HTML in markdown

view details

Filip Hrisafov

commit sha 9c6c834ad1bef8828bcd33b493e38b781288fda6

#96 Split publish and generate site scripts Initial step to be able to use GitHub Actions for deployment

view details

Filip Hrisafov

commit sha 3d87341890bacbfc173124b565529f52261a970f

#96 Use GitHub Actions for deploying pages for the website Use posix shell for empty checks

view details

Filip Hrisafov

commit sha 74806549b9cd6bdefd1f0ca9f0706401eb2baea4

Fix news top page showing up in latest news Use .Site.RegularPages instead of .Site.Pages

view details

Filip Hrisafov

commit sha 482a38af48e4ace2200273407a4cbdb252c2c978

Update steps for publishing to mapstruct.org

view details

push time in 17 days

more