profile
viewpoint

filiphr/flowable-engine 2

A compact and highly efficient workflow and Business Process Management (BPM) platform for developers, system admins and business users.

filiphr/jug_switzerland_2019 2

The code for the JUG Switzerland presentation in 2019

filiphr/mapstruct 2

An annotation processor for generating type-safe bean mappers

filiphr/activemq-boot-jms-health 1

An ActiveMQ Spring Boot application depicting the blocking Health Endpoint

filiphr/mapstruct-builder-accessor 1

Alternative Accessor Naming Strategy for MapStruct that supports builder setters

filiphr/mapstruct-examples 1

Examples for using MapStruct

assertj/assertj-assertions-generator-idea-plugin 0

Intellij Idea plugin to generate AssertJ assertions for your custom types

filiphr/assertj 0

AssertJ documentation

filiphr/assertj-assertions-generator 0

Custom assertions generator http://joel-costigliola.github.io/assertj/assertj-assertions-generator.html

filiphr/assertj-core 0

AssertJ is a library providing easy to use rich typed assertions

issue commentmapstruct/mapstruct

New Functionality: A Mapper Facade

That is an interesting idea @naharoo. I would suggest looking into mapstruct-spring-extensions as well. This is a community lead project by @Chessray and the idea is to provide some additional extensions for Spring. We can create other projects for other frameworks as well.

markthegrea

comment created time in 10 hours

push eventmapstruct/mapstruct.org

filiphr

commit sha 67ef373a930270a72f2d4c37c51874795a13c5c1

Automated deployment: Mon Sep 28 09:09:56 UTC 2020 9884007c0069487f6d9907302be90b84eaf8d5e9

view details

push time in 12 hours

push eventmapstruct/mapstruct.org

Filip Hrisafov

commit sha 9884007c0069487f6d9907302be90b84eaf8d5e9

Update and rename 2020-09-28-mapstruct-1_5_0_Final-is-out.md to 2020-09-28-mapstruct-1_4_0_Final-is-out.md

view details

push time in 12 hours

push eventmapstruct/mapstruct.org

filiphr

commit sha 05792d88ab4f80594efceacb90bb15765a6200db

Automated deployment: Sun Sep 27 17:38:40 UTC 2020 4f493e3dcbb54dd9fc9eed111a34a56bf48030c6

view details

push time in a day

push eventmapstruct/mapstruct.org

Filip Hrisafov

commit sha e41121f78c6cea11dbbaa0226e87d5ce1cda82d1

Release 1.4.0.Final

view details

Filip Hrisafov

commit sha 4f493e3dcbb54dd9fc9eed111a34a56bf48030c6

Blog post for 1.4.0.Final

view details

push time in a day

push eventfiliphr/mapstruct.org

Filip Hrisafov

commit sha 4f493e3dcbb54dd9fc9eed111a34a56bf48030c6

Blog post for 1.4.0.Final

view details

push time in a day

push eventfiliphr/mapstruct.org

Filip Hrisafov

commit sha fc20072ac24ad0b7921e8636a7bb170b32005a42

Update 2020-09-28-mapstruct-1_5_0_Final-is-out.md

view details

push time in a day

push eventmapstruct/mapstruct-examples

Filip Hrisafov

commit sha 180b8f3ba77cadddd694070183b5fb1514fec1de

Upgrade example to 1.4.0.Final

view details

push time in 2 days

push eventfiliphr/mapstruct.org

Sjaak Derksen

commit sha 823a537f46369a32593a0b7635385fa61699f4a3

FAQ entry on ambiguous mappings (#106)

view details

Filip Hrisafov

commit sha 74ce7e62db97a8f66f2ad3626fdf19f3e9f9490c

Release 1.4.0.CR1

view details

Filip Hrisafov

commit sha 864dad73453a3848943ece2966f274c13c79f4f4

Blog post for 1.4.0.CR1 release

view details

Filip Hrisafov

commit sha 3552b5846cff4ddf8e4ad17774d1a6a318520f86

Change date in release blog post

view details

Filip Hrisafov

commit sha e41121f78c6cea11dbbaa0226e87d5ce1cda82d1

Release 1.4.0.Final

view details

Filip Hrisafov

commit sha f3bf7a8f335d1903c18d1e2c26dace3c4d3c8b27

Blog post for 1.4.0.Final

view details

push time in 2 days

push eventmapstruct/mapstruct

Filip Hrisafov

commit sha 9973b92ccb15d57dc6c871b7887fc9684a7950d5

[maven-release-plugin] prepare release 1.4.0.Final

view details

Filip Hrisafov

commit sha eb5b8bb71efd7a6bfa6f880bef2c503abdf007cf

[maven-release-plugin] prepare for next development iteration

view details

Filip Hrisafov

commit sha 2d750193d1f5fb8324836edb1b805ea8aaa62b26

Update versions in readme to 1.4.0.Final

view details

push time in 2 days

created tagmapstruct/mapstruct

tag1.4.0.Final

An annotation processor for generating type-safe bean mappers

created time in 2 days

pull request commentflowable/flowable-engine

Docs: includeCaseVariables instead of includecaseVariables

THanks David

dbmalkovsky

comment created time in 4 days

push eventflowable/flowable-engine

dbmalkovsky

commit sha 145cbdda695472a25207a7c727ab155f5b3bd6d4

Docs: includeCaseVariables instead of includecaseVariables

view details

push time in 4 days

PR merged flowable/flowable-engine

Docs: includeCaseVariables instead of includecaseVariables

Fix for issue raised in this forum post: includeCaseVariables instead of includecaseVariables (upper case the C).

+1 -1

0 comment

1 changed file

dbmalkovsky

pr closed time in 4 days

issue commentmapstruct/mapstruct

Different behaviours in IntellijIDEA build and Maven Build

There shouldn't be any differences between IDEA and Maven. The plugin shouldn't make a difference, since it is not affecting the compilation at all. Maybe the IDEA incremental compilation causes some problems.

Can you please compare the values in the @Generated tag in the generated mappers?

Does the value in the comments match between the mappers generated from IDEA and Maven.

Are you by any chance using Lombok?

angelodelia

comment created time in 4 days

issue closedmapstruct/mapstruct

Mapstruct 1.4.0CR: using the „.“ as target property

I tried to get the "." operator as target property working, but i get an error during the build process as follows under this configuration:

Spring Boot 2.1.2 (but not important i think) Lombok 1.18.4 MapStruct 1.4.0.CR1 Java 1.8.0_92 Intellij 2019.3 Ultimate (but not important i think)

Bank class

@Data
public class BankEntity {

    private CustomerEntity customer;
}

Customer class

@Data
public class CustomerEntity {

    private String id;
    private String name;
}

CustomerDto class

@Data
public class CustomerDto {

    private String id;
    private String name;
}

Mapper class

public interface CustomerMapper {

    @Mapping(target = ".", source = "bank.customer")
    CustomerDto toDto(BankEntity bank);

}

SIMPLE TestCase

    @Test
    public void bankToCustomerDtoTest() {
        BankEntity bank = new BankEntity();
        CustomerEntity customer = new CustomerEntity();
        customer.setId("123");
        customer.setName("Smith");
        bank.setCustomer(customer);
        CustomerMapper customerMapper = Mappers.getMapper(CustomerMapper.class);
        CustomerDto dto = customerMapper.toDto(bank);
        System.out.println(dto);
    }

Error:(7, 8) java: Internal error in the mapping processor: java.util.NoSuchElementException at java.util.ArrayList$Itr.next(ArrayList.java:854) at org.mapstruct.ap.internal.util.Collections.first(Collections.java:50) at org.mapstruct.ap.internal.model.BeanMappingMethod$Builder.handleDefinedMappings(BeanMappingMethod.java:477) at org.mapstruct.ap.internal.model.BeanMappingMethod$Builder.build(BeanMappingMethod.java:184) at org.mapstruct.ap.internal.processor.MapperCreationProcessor.getMappingMethods(MapperCreationProcessor.java:376) at org.mapstruct.ap.internal.processor.MapperCreationProcessor.getMapper(MapperCreationProcessor.java:151) at org.mapstruct.ap.internal.processor.MapperCreationProcessor.process(MapperCreationProcessor.java:122) at org.mapstruct.ap.internal.processor.MapperCreationProcessor.process(MapperCreationProcessor.java:76) at org.mapstruct.ap.MappingProcessor.process(MappingProcessor.java:283) at org.mapstruct.ap.MappingProcessor.processMapperTypeElement(MappingProcessor.java:263) at org.mapstruct.ap.MappingProcessor.processMapperElements(MappingProcessor.java:221) at org.mapstruct.ap.MappingProcessor.process(MappingProcessor.java:156) at com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:794) at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:705) at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91) at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035) at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176) at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170) at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856) at com.sun.tools.javac.main.Main.compile(Main.java:523) at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:129) at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:138) at org.jetbrains.jps.javac.JavacMain.compile(JavacMain.java:207) at org.jetbrains.jps.incremental.java.JavaBuilder.compileJava(JavaBuilder.java:486) at org.jetbrains.jps.incremental.java.JavaBuilder.compile(JavaBuilder.java:338) at org.jetbrains.jps.incremental.java.JavaBuilder.doBuild(JavaBuilder.java:263) at org.jetbrains.jps.incremental.java.JavaBuilder.build(JavaBuilder.java:216) at org.jetbrains.jps.incremental.IncProjectBuilder.runModuleLevelBuilders(IncProjectBuilder.java:1328) at org.jetbrains.jps.incremental.IncProjectBuilder.runBuildersForChunk(IncProjectBuilder.java:1006) at org.jetbrains.jps.incremental.IncProjectBuilder.buildTargetsChunk(IncProjectBuilder.java:1073) at org.jetbrains.jps.incremental.IncProjectBuilder.buildChunkIfAffected(IncProjectBuilder.java:967) at org.jetbrains.jps.incremental.IncProjectBuilder.buildChunks(IncProjectBuilder.java:796) at org.jetbrains.jps.incremental.IncProjectBuilder.runBuild(IncProjectBuilder.java:378) at org.jetbrains.jps.incremental.IncProjectBuilder.build(IncProjectBuilder.java:178) at org.jetbrains.jps.cmdline.BuildRunner.runBuild(BuildRunner.java:140) at org.jetbrains.jps.cmdline.BuildSession.runBuild(BuildSession.java:297) at org.jetbrains.jps.cmdline.BuildSession.run(BuildSession.java:130) at org.jetbrains.jps.cmdline.BuildMain$MyMessageHandler.lambda$channelRead0$0(BuildMain.java:232) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)

closed time in 4 days

javanerd

issue commentmapstruct/mapstruct

Mapstruct 1.4.0CR: using the „.“ as target property

No problem @javanerd, I am glad that the problem got resolved. It indeed felt like IntelliJ using the wrong version of MapStruct.

javanerd

comment created time in 4 days

issue commentmapstruct/mapstruct

Mapstruct 1.4.0CR: using the „.“ as target property

So IntelliJ uses the correct version of MapStruct. I really can't explain this.

Is it possible for you to create a small repository where this can be reproduced? That way I can download IJ 2019.3 and try it out.

javanerd

comment created time in 5 days

issue commentmapstruct/mapstruct

Mapper generation fails silently with Immutables and non-standard type names of target

No problem @incaseoftrouble, thanks a lot for the detailed explanation, it is always nice to see such issues.

I think that the work that @massfords has put for #2198 is also addressing this problem. He can correct me if I am wrong.

Currently, we are not doing anything special to handle the different immutables style options.

incaseoftrouble

comment created time in 5 days

issue commentmapstruct/mapstruct

Mapstruct 1.4.0CR: using the „.“ as target property

It seems like IntelliJ is not using the correct version.

Can you please check what does the "Processor path" in "Build, Execution, Deployment" -> Compiler -> "Annotation Processors" and in your module there has? This is in the Settings.

javanerd

comment created time in 5 days

issue closedmapstruct/mapstruct

Where is 'MapperGem'

import org.mapstruct.ap.internal.gem.MapperGem is not found

closed time in 5 days

BernyGao

issue commentmapstruct/mapstruct

Where is 'MapperGem'

Please use the Gitter room for asking such questions.

MapperGem is a generated class during compilation with the mapstruct/tools-gem. It is used to access the annotation elements in a type safe manner.

BernyGao

comment created time in 5 days

issue commentmapstruct/mapstruct

Mapstruct 1.4.0CR: using the „.“ as target property

That is really weird. What happens when you try to compile with Maven or Gradle?

javanerd

comment created time in 7 days

issue closedmapstruct/mapstruct

How to manage variable shadowing in JAVA with Mapstruct

I did not find a way how to manage this, because I cannot add in Mapstruct variable with the same name as a target which make sense but there is no workaround or at least I did not find any. My code:

public abstract class CaseDTOBase{

       private Integer version;

       public static void mapFromCaseToCaseDTO(Fall fall, CaseDTOBase caseDTOBase) {
        caseDTOBase.setVersion(fall.getVersion());}
       }
    }
public class AufCaseDTO extends CaseDTOBase{

  private Integer version;

  public static AufCaseDTO from(AufFall aufFall, Fall fallGemeldetAnPKR) {

  AufCaseDTO aufCaseDTO = AufCaseDTO.builder().version(aufFall.getVersion()).build();

  CaseDTOBase.mapFromCaseToCaseDTO(aufFall.getFall(), aufCaseDTO);

  return aufCaseDTO;
 }
}

As you can see the one variable "version from AufCaseDTO" uses aufFall.getVersion() and the another version from CaseDTOBase variable uses aufFall.getFall().getVersion(), I cannot add both inside of Mapstruct because it says that it does not allow duplicates. How can I make this in MapStruct?

    @Mapping(target = "version", source = "aufFall.version")  
    @Mapping(target = "version", source = "aufFall.fall.version")
    AufCaseDTO from(AufFall aufFall, Fall fallGemeldetAnPKR);

closed time in 8 days

Hard-system

issue commentmapstruct/mapstruct

How to manage variable shadowing in JAVA with Mapstruct

I see that you have cross posted this from StackOverflow (https://stackoverflow.com/q/63957233/1115491). Please do not use this issue tracker for asking questions, and do not cross post.

The question has been answered on StackOverflow.

Hard-system

comment created time in 8 days

issue closedflowable/flowable-engine

how to loop task for several user

<?xml version="1.0" encoding="UTF-8"?>
<definitions xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:activiti="http://activiti.org/bpmn" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:omgdc="http://www.omg.org/spec/DD/20100524/DC" xmlns:omgdi="http://www.omg.org/spec/DD/20100524/DI" typeLanguage="http://www.w3.org/2001/XMLSchema" expressionLanguage="http://www.w3.org/1999/XPath" targetNamespace="http://www.activiti.org/test">
  <process id="loopProcess" name="loopProcess" isExecutable="true">
    <startEvent id="startevent1" name="Start"></startEvent>
    <endEvent id="endevent1" name="End"></endEvent>
    <userTask id="loopTask" name="loopTask" activiti:async="true" activiti:candidateUsers="zn1,zn2,zn3"></userTask>
    <exclusiveGateway id="exclusivegateway1" name="Exclusive Gateway"></exclusiveGateway>
    <sequenceFlow id="flow1" sourceRef="loopTask" targetRef="exclusivegateway1"></sequenceFlow>
    <sequenceFlow id="flow2" sourceRef="exclusivegateway1" targetRef="endevent1">
      <conditionExpression xsi:type="tFormalExpression"><![CDATA[${feedback}]]></conditionExpression>
    </sequenceFlow>
    <sequenceFlow id="flow3" sourceRef="exclusivegateway1" targetRef="loopTask">
      <conditionExpression xsi:type="tFormalExpression"><![CDATA[${!feedback}]]></conditionExpression>
    </sequenceFlow>
    <sequenceFlow id="flow4" sourceRef="startevent1" targetRef="loopTask"></sequenceFlow>
  </process>

i have a loop task which should running by several user. then i set the task's candidateUsers to 'zn1,zn2,zn3', the below code to create users.

        @Override
	protected void createMembership(){
		IdentityService identityService = rule.getIdentityService();
		
		User zn1 = identityService.newUser("zn1");
		zn1.setFirstName("zn");
		zn1.setLastName("1");
		zn1.setDisplayName("zn1");
		zn1.setEmail("dianxin@126.com");
		identityService.saveUser(zn1);
		
		User zn2 = identityService.newUser("zn2");
		zn2.setFirstName("zn");
		zn2.setLastName("2");
		zn2.setDisplayName("zn2");
		zn2.setEmail("liantong@126.com");
		identityService.saveUser(zn2);
		
		User zn3 = identityService.newUser("zn3");
		zn3.setFirstName("zn");
		zn3.setLastName("3");
		zn3.setEmail("tieta@126.com");
		zn3.setDisplayName("zn3");
		identityService.saveUser(zn3);
		
		Group znbm = identityService.newGroup("WF_ZNBM");
		znbm.setName("职能部门");
		znbm.setType("znbm");
		identityService.saveGroup(znbm);
		
		identityService.createMembership(zn1.getId(), znbm.getId());
		identityService.createMembership(zn2.getId(), znbm.getId());
		identityService.createMembership(zn3.getId(), znbm.getId());
	}
	@Test
	public void testForLoop() {
		Map<String, Object> vars = new HashMap<>();
		vars.put("id", "1");

//		zn1,zn2,zn3
		ProcessInstance ins = runtimeService.startProcessInstanceByKey("loopProcess", "1", vars);
		List<String> ids = runtimeService.getActiveActivityIds(ins.getId());
		System.out.println(String.join(",", ids));

		String[] usrIds = new String[] { "zn1", "zn2", "zn3" };    // userids 
		for (int i = 0; i < 3; i++) {
			List<Task> list = taskService.createTaskQuery().taskCandidateUser(usrIds[i]).list();
			System.out.println(list.size());
//			taskService.complete(zn.getId());
		}
		
		Task tFinish = taskService.createTaskQuery().taskCandidateGroup("WF_XXW").singleResult();
		if (tFinish != null) {
			taskService.complete(tFinish.getId());
		}
	}

after start process, then query each user's task , the query result is always empty, i don't understand for it. is any wrong here?

using 6.5.0. Any help will be gratefully received.

closed time in 8 days

sendreams

issue commentflowable/flowable-engine

how to loop task for several user

Please don't use the issue tracker for asking questions. Please use the Flowable OSS Forum for that.

The reason why it is not working for you is because you have marked the user task as async. This means that the user task will be created in another thread, after the process instance has been started. I would suggest removing that from there. It might be that the async executor is disabled during your tests.

Please try out without the async flag and continue your discussion on the Forum if it isn't working.

sendreams

comment created time in 8 days

issue openedmapstruct/mapstruct

Mapping with qualifying and only target defined should implicitly look for a matching property in one of the parameters

This is basically the PR #2204.

With the following example:

class Comment {

    private Integer issueId;
}
class Repository {

    private String name;
}

class RepositoryComment {

    private Integer issueId;
    private String name;

}

@Mapper
interface RepoMapper {

    RepositoryComment clone(Comment comment, Repository repository);

    @Mapping(target = "issueId", defaultValue = "10") // This should match the issueId in Comment
    RepositoryComment clone(Comment comment, Repository repository);
}

created time in 8 days

pull request commentmapstruct/mapstruct

#2125 Parameter matching should be done based on name of all source parameters properties when source name is absent

I agree with you @imeszaros, and we are going to do that for 1.5, but since it is a small change in how things work right now we don't want to include it in the 1.4.0.Final release.

filiphr

comment created time in 8 days

delete branch filiphr/mapstruct

delete branch : 2125-v2

delete time in 8 days

push eventmapstruct/mapstruct

Filip Hrisafov

commit sha 060f17e3e2e6d8ec9cd029d9721af2fa25a4c393

#2125 Report an error when source parameter could not be determined from target mapping

view details

push time in 8 days

PR merged mapstruct/mapstruct

#2125 Report an error when source parameter could not be determined from target mapping

Fixes #2125

This is a second iteration of a solution for #2125, in which we enforce the usage of source in @Mapping when there are multiple source parameters

+214 -5

0 comment

9 changed files

filiphr

pr closed time in 8 days

issue closedmapstruct/mapstruct

Qualifier is ignored in case of name based mapping

As stated here: https://github.com/mapstruct/mapstruct/issues/2124#issuecomment-647184770 , MapStruct ignores the qualifier specification for a mapping if it is name based (i.e. source property is not specified explicitly).

Imho this behavior could be enhanced either:

  • when a qualifier is specified, it can be assumed that the user would like to defer from the automatic (name based) mapping, so MapStruct should honor it, or
  • at least the annotation processor should emit a warning that the qualifier is ignored, so the user immediately understands what is going on.

closed time in 8 days

imeszaros

delete branch filiphr/mapstruct

delete branch : dependency-upgrades

delete time in 8 days

PR opened mapstruct/mapstruct

Reviewers
#2125 Report an error when source parameter could not be determined from target mapping

Fixes #2125

This is a second iteration of a solution for #2125, in which we enforce the usage of source in @Mapping when there are multiple source parameters

+214 -5

0 comment

9 changed files

pr created time in 8 days

create barnchfiliphr/mapstruct

branch : 2125-v2

created branch time in 8 days

pull request commentmapstruct/mapstruct

#2125 Parameter matching should be done based on name of all source parameters properties when source name is absent

What is the rationale behind this restriction? I mean if it works without a @Mapping annotation, why could it not work with an annotation just specifying a qualifier?

The rationale is that you if you do @Mapping(target = "issueId", source = "issueId", qualifiedBy = ...) it will have a compilation error, because when you have multiple source parameters and you defined @Mapping then the source has to start with referencing one of the source parameters.

The idea of @Mapping(target = "issueId", qualifiedBy = ...) is to be equivalent to @Mapping(target = "issueId", source = "issueId", qualifiedBy = ...).

We can perhaps relax this restriction and allow writing the source without a source parameter, but this is not for a final release (which we want to do asap for 1.4.0.Final 😉)

filiphr

comment created time in 8 days

push eventmapstruct/mapstruct

Filip Hrisafov

commit sha e17e744b209d8c1d622c628469375c28b3c80d6f

Dependency upgrades Upgrades: * Maven Enforcer Plugin to 3.0.0-M3 * Maven Surefire Plugin to 3.0.0-M5 * Maven Checkstyle Plugin to 3.1.1 * Maven Bundle Plugin to 5.1.1 * Jacoco Maven Plugin to 0.8.6 * Checkstyle to 8.36.1 * JUnit Jipiter to 5.7.0 * AssertJ to 3.17.2 * Guava to 29.0-jre Fix AssertJ breaking changes Use Java 8 or Apache Commons IO instead of Guava where possible Update GitHub Actions to use JDK 14 and JDK 15-ea

view details

push time in 8 days

push eventfiliphr/mapstruct

Filip Hrisafov

commit sha e17e744b209d8c1d622c628469375c28b3c80d6f

Dependency upgrades Upgrades: * Maven Enforcer Plugin to 3.0.0-M3 * Maven Surefire Plugin to 3.0.0-M5 * Maven Checkstyle Plugin to 3.1.1 * Maven Bundle Plugin to 5.1.1 * Jacoco Maven Plugin to 0.8.6 * Checkstyle to 8.36.1 * JUnit Jipiter to 5.7.0 * AssertJ to 3.17.2 * Guava to 29.0-jre Fix AssertJ breaking changes Use Java 8 or Apache Commons IO instead of Guava where possible Update GitHub Actions to use JDK 14 and JDK 15-ea

view details

push time in 8 days

create barnchfiliphr/mapstruct

branch : dependency-upgrades

created branch time in 8 days

pull request commentmapstruct/mapstruct

#2125 Parameter matching should be done based on name of all source parameters properties when source name is absent

OK I understand it now. However, isn't it a bit confusing that when you have a single source parameter @Mapping(source = "issueId", qualifiedByName = "...") works, and once you add a second parameter it stops working without any error?

Perhaps we should have a compile error if the parameter does not match the source parameters here:

https://github.com/mapstruct/mapstruct/blob/52ab22bbd87c89610e913ecf6b4a891475846d33/processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java#L1088

filiphr

comment created time in 9 days

issue commentmapstruct/mapstruct

Invalid code generated for enum mapping when field name starts with underscore '_'

@ogerardin, we are now stripping both underscores and digits when sanitizing a name. In case the name is only consisted of underscores and digits, then we leave it as is. I would rather wait for an issue about that before going down a path that would make this too complex.

I wouldn't make this configurable, since it is such a low level thing in the code generation, that in my opinion it is not worth it.

ogerardin

comment created time in 9 days

delete branch filiphr/mapstruct

delete branch : 2197

delete time in 9 days

push eventmapstruct/mapstruct

Filip Hrisafov

commit sha 52ab22bbd87c89610e913ecf6b4a891475846d33

#2197 Strip leading underscores and digits when sanitizing identifier name

view details

push time in 9 days

issue closedmapstruct/mapstruct

Invalid code generated for enum mapping when field name starts with underscore '_'

I'm trying to map to a class where field names that start with an underscore. Some of these fields are enums and their type is an inner enum with the same name, e.g.:

    ...
    private Emtv3Item._06040PortfolioManagement _06040PortfolioManagement;
    ...
    public enum _06040PortfolioManagement {
        R("R"),
    ...

(Background: this class is generated by jsonschema2pojo from a JSON schema where field names start with a digit, hence the leading underscore. While this might not be good practice, it's legal and we have a use case for it)

The mapping code generated by mapstruct 1.4.0.RC1 for these enums is invalid: it uses a variable with the same name as the original field, but without the leading underscore, hence it starts with a digit:

    protected _06040PortfolioManagement m06040PortfolioManagementEnumTo_06040PortfolioManagement(M06040PortfolioManagementEnum m06040PortfolioManagementEnum) {
        if ( m06040PortfolioManagementEnum == null ) {
            return null;
        }
        _06040PortfolioManagement 06040PortfolioManagement;

If I try to use mapstruct 1.3.1.Final, the generated enum mapping code is also invalid but for a different reason: the variable has the same name as the enum, which causes problems later:

   protected _06040PortfolioManagement m06040PortfolioManagementEnumTo_06040PortfolioManagement(M06040PortfolioManagementEnum m06040PortfolioManagementEnum) {
        if ( m06040PortfolioManagementEnum == null ) {
            return null;
        }
        _06040PortfolioManagement _06040PortfolioManagement;
        switch ( m06040PortfolioManagementEnum ) {
            case R: _06040PortfolioManagement = _06040PortfolioManagement.R;

--> variable _06040PortfolioManagement might not have been initialized

A solution here is to name the variable anything legal and different from the enum class, e.g.:

        _06040PortfolioManagement _06040PortfolioManagement_var;
        switch ( m06040PortfolioManagementEnum ) {
            case R: _06040PortfolioManagement_var = _06040PortfolioManagement.R;

closed time in 9 days

ogerardin

pull request commentmapstruct/mapstruct

#2125 Parameter matching should be done based on name of all source parameters properties when source name is absent

We do explicit name based mapping if the same property exists in both sides. However, if the same property exists in multiple source parameters you have to define the source then.

In case several source objects define a property with the same name, the source parameter from which to retrieve the property must be specified using the @Mapping annotation as shown for the description property in the example.

I am doing exactly that with this PR. This is actually aligning with the behaviour that we currently have. Otherwise, the mapping was successful, but we generated wrong code with @Mapping was ignored. In this case if there is a property named same in both source parameters we still have a compile error and you have to specify it.

As for the inverse, multi source parameter methods do not qualify as inverse methods. See:

https://github.com/mapstruct/mapstruct/blob/427f5023efec6f6a91fd8946bb2b6e86a1ed2a19/processor/src/main/java/org/mapstruct/ap/internal/model/source/SourceMethod.java#L304-L310

filiphr

comment created time in 9 days

issue commentmapstruct/mapstruct

Mapstruct 1.4.0CR: using the „.“ as target property

Can you try removing the lombok annotations? If it works without them, then most likely it is a build configuration problem

javanerd

comment created time in 9 days

issue commentmapstruct/mapstruct

Mapstruct 1.4.0CR: using the „.“ as target property

I just tried this in our examples with Lombok 1.18.12 and it works correctly. How does your maven or gradle config looks like?

javanerd

comment created time in 9 days

create barnchfiliphr/mapstruct

branch : 2125

created branch time in 9 days

IssuesEvent

issue commentmapstruct/mapstruct

Qualifier is ignored in case of name based mapping

You are completely right @imeszaros, thanks a lot for the repository. The problem is when multiple source parameters are used. We will look into this.

imeszaros

comment created time in 9 days

issue closedmapstruct/mapstruct

Qualifier is ignored in case of name based mapping

As stated here: https://github.com/mapstruct/mapstruct/issues/2124#issuecomment-647184770 , MapStruct ignores the qualifier specification for a mapping if it is name based (i.e. source property is not specified explicitly).

Imho this behavior could be enhanced either:

  • when a qualifier is specified, it can be assumed that the user would like to defer from the automatic (name based) mapping, so MapStruct should honor it, or
  • at least the annotation processor should emit a warning that the qualifier is ignored, so the user immediately understands what is going on.

closed time in 10 days

imeszaros

issue commentmapstruct/mapstruct

Qualifier is ignored in case of name based mapping

I am fairly certain that this is the same as #2164 which has been fixed in 1.4.0.CR1.

Please let us know if that is the case @imeszaros, so we can reopen this one.

imeszaros

comment created time in 10 days

issue closedmapstruct/mapstruct

Incorrect mapper generation when class has generic argument - collection element not mapped

This is on mapstruct 1.3.0.Final I included a sample that demonstrates the issue.

Class X has a list of A's called children Class Y has a list of B's called children

class X has a generic Type argument that is not used at all

The generated code does conversion from A to B when mapping X to Y. The gernated code does NO conversion from B to A when mapping Y to X.

Generated code looks like this:

X to Y - Note the mapToBs() call

    @Override
    public Y map(X x) {
        if ( x == null ) {
            return null;
        }

        Y y = new Y();

        if ( y.getChildren() != null ) {
            List<B> list = mapToBs( x.getChildren() );
            if ( list != null ) {
                y.getChildren().addAll( list );
            }
        }
        return y;
    }

Y to X - the items are copied without being mapped

    @Override
    public X map(Y y) {
        if ( y == null ) {
            return null;
        }

        X x = new X();

        if ( x.getChildren() != null ) {
            List<B> list = y.getChildren();
            if ( list != null ) {
                x.getChildren().addAll( list );
            }
        }

        return x;
    }

mapstructissue.zip

closed time in 10 days

ZuperKeurZ

PR opened mapstruct/mapstruct

Reviewers
#2197 Strip leading underscores and digits when sanitizing identifier name

Fixes #2197

+129 -6

0 comment

5 changed files

pr created time in 10 days

create barnchfiliphr/mapstruct

branch : 2197

created branch time in 10 days

created tagfiliphr/mapstruct

tag1.4.0.CR1

An annotation processor for generating type-safe bean mappers

created time in 10 days

issue commentrzwitserloot/lombok

Eclipse javaagent and mapstruct APT implementation

Starting from 1.4 MapStruct will ignore exceptions thrown when trying to load the AstModifyingAnnotationProcessor(s). This means that this is no longer a problem for MapStruct.

@rspilker I think that you can close this ticket. From MapStruct side everything is working OK now.

pgaschuetz

comment created time in 10 days

issue commentmapstruct/mapstruct

ImmutablesBuilderProvider doesn't support inner classes

What kind of errors / problems do you see with the eclipse compiler? Maybe we've seen the error before

massfords

comment created time in 12 days

issue closedmapstruct/mapstruct

Provide ability to have a not null check prior to applying an expression

It doesn't seem that any of the options for null checking work along with providing an expression. I'm using 1.3.1-FINAL

@Mapper(componentModel="spring") public interface RecurringScheduleMapper { @Mappings({ @Mapping(target="adhocDates", expression="java(java.util.stream.Stream.of(recurringSchedule.getAdhocDates().split(",", 0)).collect(java.util.stream.Collectors.toList()))") }) RecurringScheduleDto entityToDto(RecurringSchedule recurringSchedule);

}

produces:

    recurringScheduleDto.setAdhocDates( java.util.stream.Stream.of(recurringSchedule.getAdhocDates().split(",", 0)).collect(java.util.stream.Collectors.toList()) );

I need

    if (recurringScheduleDto.getAdhocDates() != null) {
        recurringScheduleDto.setAdhocDates(java.util.stream.Stream.of(recurringSchedule.getAdhocDates().split(",", 0)).collect(java.util.stream.Collectors.toList()));
    }

All the null check strategies either ignore the property with the expression or give an error on generation advising that it can't be used in conjunction with an expression.

Is there some other way of accomplishing this?

closed time in 12 days

edougliu

issue commentmapstruct/mapstruct

Provide ability to have a not null check prior to applying an expression

This is not possible. When using expression we are using the expression as is. There is no way for us to know on what to do a null check.

However, you can achieve the mapping you want with some custom methods.

e.g.

@Mapper
public interface CustomMapper {

    RecurringScheduleDto entityToDto(RecurringSchedule recurringSchedule);

    @Named("stringToList")
    List<String> stringToList(String value) {
        if (value != null) {
            Stream.of(value.split(",", 0)).collect(Collectors.toList());
        }

        return null;
    }
}

You can achieve the null check in the generated code by using NullValueCheckStrategy on the mapper (@Mapper) or method (@BeanMapping) level

edougliu

comment created time in 12 days

issue commentmapstruct/mapstruct

Invalid code generated for enum mapping when field name starts with underscore '_'

You are right @ogerardin, this is pushing it to the max :). Maybe if we have no more elements, we start with a variable named a and try to generate a safe name from there.

What kind of prefix will you suggest?

ogerardin

comment created time in 12 days

CommitCommentEvent

issue commentmapstruct/mapstruct

Invalid code generated for enum mapping when field name starts with underscore '_'

This is an interesting one. We did some fixes in this area with #2142, but we haven't thought about this use case as well.

Most likely we will go with the approach with removing the underscore and digit prefixes from the generated variables.

ogerardin

comment created time in 13 days

issue commentmapstruct/mapstruct

Annotate annotations with @Documented

Thanks for creating this issue @onacit. From what I've read this should not be a big issue, since it is there only for documenting purposes and I don't know why it hasn't been set.

Perhaps @sjaakd or @gunnarmorling know the reasoning for not annotating them with @Documented

onacit

comment created time in 13 days

issue commentmapstruct/mapstruct

ImmutablesBuilderProvider doesn't support inner classes

Of course an extension like this would ideally be run be someone from the community, so if you or someone else is interested in pushing this in that direction we are more than happy to help you out.

massfords

comment created time in 13 days

issue commentmapstruct/mapstruct

ImmutablesBuilderProvider doesn't support inner classes

@massfords if there is a bigger complexity for Immutables, we can also have a look at doing a community extension targeting more complex features of Immutable. Something similar like what we are doing for Spring (https://github.com/mapstruct/mapstruct-spring-extensions).

massfords

comment created time in 13 days

push eventflowable/flowable-engine

dbmalkovsky

commit sha 695a497058b17b29442084696ef688ce5fbbf10e

Periodic import cleanup

view details

push time in 13 days

PR merged flowable/flowable-engine

Periodic import cleanup

Periodic import cleanup

+0 -24

0 comment

5 changed files

dbmalkovsky

pr closed time in 13 days

push eventflowable/flowable-engine

Filip Hrisafov

commit sha c196111d091f43ac3c5660b4236b07c86a626dac

Use getMaxTimerJobsPerAcquisition instead of getMaxAsyncJobsDuePerAcquisition when acquiring timer jobs

view details

push time in 14 days

issue commentmapstruct/mapstruct

Protobuf3-friendly mappers

@TehBakker I think that you can adapt the AccessorNamingStrategy and remove the List when getting the property name.

jvmlet

comment created time in 17 days

issue commentmapstruct/mapstruct

@Mapper(componentModel = "spring") doesn't support custom name for Spring Service Annotation

Hey @javanerd, yes I've used this solution in different projects and it works.

For it to work you have to add componentModel = "spring" to your mappers, otherwise it there will be no components.

Most likely you have the ConflictingBeanDefinitionException problem because your mappers share a package with your Spring Boot Application. If that is the case then you have 2 options:

  • Move your mappers to a different package that is not shared with your Spring Boot Application
  • Play with TypeExcludeFilter so that you can exclude the mappers
zurbergram

comment created time in 17 days

issue commentmapstruct/mapstruct

ImmutablesBuilderProvider doesn't support inner classes

Thanks for the detailed information @massfords. The idea was to get the location of the class to in order to get the builder. Where is the builder for the Child class from your example created? Where is ImmutableChild created? Is it top level class or nested within ImmutableParent.

I could submit a patch if you're open to it.

We are always open to PRs 😄. Can you please submit one against the main branch. We are planning to release 1.4.0.Final really soon, so it would be great to have this in as well.

massfords

comment created time in 19 days

issue commentmapstruct/mapstruct-idea

lots of exceptions

The fix was a bit more general and now we cast more safely. Please let us know once you try the update.

mkrumpholz

comment created time in 20 days

issue commentmapstruct/mapstruct-idea

lots of exceptions

Which version of the plugin are you using? I think that we fixed this error in the latest release.

Can you please share the mapper in which this exception is happening? Are you using @Mappings by any chance?

mkrumpholz

comment created time in 21 days

pull request commentflowable/flowable-engine

HTTP PATCH support

Thanks for the PR @ikaakkola. I've also added this to the Modeler in https://github.com/flowable/flowable-engine/commit/7e62cdef4b7492189092121547144088d16059df

ikaakkola

comment created time in 22 days

push eventflowable/flowable-engine

Filip Hrisafov

commit sha 7e62cdef4b7492189092121547144088d16059df

Add HTTP PATCH method to the Modeler

view details

push time in 22 days

push eventflowable/flowable-engine

Ilkka Kaakkola

commit sha 2ed36fe06a9c4f66e71e63e45deb5907f59ea0a1

HTTP PATCH support

view details

push time in 22 days

PR merged flowable/flowable-engine

HTTP PATCH support

Check List:

  • Unit tests: YES
  • Documentation: NA
+122 -0

0 comment

6 changed files

ikaakkola

pr closed time in 22 days

PullRequestReviewEvent

issue commentjoel-costigliola/assertj-core

Github action release

As far as I know Byte Buddy does a release via an action.

https://github.com/raphw/byte-buddy/blob/6b1bc2a5e07db2597969af274b4eca3ed31fb5bd/.github/workflows/main.yml#L92-L109

joel-costigliola

comment created time in 22 days

issue commentmapstruct/mapstruct

Mapping Iterable<?> object to an object instead of collection

Hey @sahebpreet,

Yes you can pick this up.

I think that your approach is good. This means that we would allow mapping from Iterable into some bean by marking the method with @BeanMapping. I think that @BeanMapping cannot be empty though. Perhaps we can just allow mapping between those types as is, without requiring anything special.

In any case feel free to do a PR where we can see how it will be used via some tests and the implementation.

If you have any questions feel free to ask them here or in our Gitter room.

maurofran

comment created time in 22 days

pull request commentmapstruct/mapstruct

#2195 reproducers

We don't look for factory methods in any type. We only do a special sequence to determine if a certain type has a builder. And for that we need the builder to have a factory in the type it is building.

sjaakd

comment created time in 22 days

issue commentmapstruct/mapstruct

Suppress warnings functionality

I have mixed feelings about suppressing any potential warnings in the generated code.

In this particular case it is because of the @Context, but there might be other reasons why something like this is happening and adding the suppressions arbitrary by MapStruct in the generated code might lead to unexpected errors.

To fix your particular problem, you might think in limiting the generic parameter in the CycleAvoidingMappingContext. Do you really need to apply the cycle check for collections? Do you need to do it for all objects?

e.g. you can do something like:

public class CycleAvoidingMappingContext {
    private Map<Object, Object> knownInstances = new IdentityHashMap<Object, Object>();

    @BeforeMapping
    public <T extends BaseEntity> T getMappedInstance(Object source, @TargetType Class<T> targetType) {
        return (T) knownInstances.get( source );
    }

    @BeforeMapping
    public <T extends BaseEntity> void storeMappedInstance(Object source, @MappingTarget T target) {
        knownInstances.put( source, target );
    }
}

You can limit the objects that you support for cycles by doing this.

edekovacsgalambos

comment created time in 22 days

issue closedmapstruct/mapstruct

NullValuePropertyMappingStrategy.IGNORE not working when used on method

Hi guys, I'm using MapStruct 1.3.1 final and facing a problem when using NullValuePropertyMappingStrategy.IGNORE on mapping methods.

To give an example of my use case, think about two RESTful operations one PATCH (partial update) and one PUT (full resource update).

For both methods, what I do is to first get the entity from the DB and then call the mapstruct methods. For example:

public void update(CustomFieldDto fieldDto) {
        CustomField customField = customFieldDao.findById(fieldDto.getId());

        customFieldMapper.copyDtoToEntityIncludeNull(fieldDto, customField);
        customField = customFieldDao.save(customField);
}

public void patch(CustomFieldDto fieldDto) {
        CustomField customField = customFieldDao.findById(fieldDto.getId());

        customFieldMapper.copyDtoToEntityExcludeNull(fieldDto, customField);
        customField = customFieldDao.save(customField);
} 

The mapstruct mapper I have is the following:

@Component
@Mapper(componentModel = "spring", nullValueCheckStrategy = ALWAYS, unmappedTargetPolicy = IGNORE)
public abstract class CustomFieldMapper {
    @Mappings({
            @Mapping(
                    source = "customFieldDto.attribute",  target = "attribute", qualifiedByName = "mapToAttributeEntity",
                    nullValuePropertyMappingStrategy = NullValuePropertyMappingStrategy.IGNORE
            ),
    })
    public abstract void copyDtoToEntityExcludeNull(CustomFieldDto customFieldDto, @MappingTarget CustomField customField);

    @Mappings({
            @Mapping(
                    source = "customFieldDto.attribute",  target = "attribute", qualifiedByName = "mapToAttributeEntity"
            ),
    })
    public abstract void copyDtoToEntityIncludeNull(CustomFieldDto customFieldDto, @MappingTarget CustomField customField);

I noticed that copyDtoToEntityExcludeNull is overriding with null values exactly the same as copyDtoToEntityIncludeNull mapping.

However, when I move nullValuePropertyMappingStrategy = NullValuePropertyMappingStrategy.IGNORE into @Mapper annotation it works well. The problem is that I need to control this strategy per method mapping.

Am I overlooking anything here?

closed time in 22 days

federico-piazza

issue commentmapstruct/mapstruct

NullValuePropertyMappingStrategy.IGNORE not working when used on method

I think I know what the problem is.

From what I can see you are using NullValuePropertyMappingStrategy.IGNORE in the @Mapping annotation, this means that it will only be applied to that particular mapping (and it indeed it is applied to it only).

In order for the nullValuePropertyMappingStrategy to apply to the entire method you'll need to define it in @BeanMapping. Can you please try that out and confirm whether it is working for you @federico-piazza?

I am going to close the issue, if it is still not working for you, please comment and we'll reopen this issue.

federico-piazza

comment created time in 22 days

pull request commentmapstruct/mapstruct

#2195 reproducers

Do we / or did we support a case were mapping methods return a builder?

Mapping method returning a builder is nothing more than mapping into some kind of arbitrary type. We supported that (with builder with setX) even before we had the builder support.

I am not quite sure that I follow the problem in #2195. I think I saw one place where the method return type differed than the BeanMapping result type, i.e. the BeanMapping result type was the builder. In my opinion that should be a compile error.

The regression comes from https://github.com/mapstruct/mapstruct/commit/33710584d33856495992c7cab511b4a16643f53e, right? In my opinion we should get the result type that should be mapped (either via BeanMapping or the method) and then go and look for a builder. Right now we have the returnTypeBuilder in the BeanMappingMethod, but that can be the incorrect builder.

Not sure if it makes sense what I am saying.

sjaakd

comment created time in 22 days

issue commentmapstruct/mapstruct

Mapstruct breaks Gradle task caching functionality

There is an annotation processor option. That is mapstruct suppressGeneratorTimestamp. You can find all options here in the documentation.

Another question, why is the processor even invoked a second time if nothing has changed? I thought that Gradle will not invoke the processor if there are no changes needed.

remal

comment created time in 24 days

issue commentflowable/flowable-engine

Read elementText of ExtensionElement is truncated

I think that this happens only when using the woodstox parser. If you remove that parser from the classpath then I think it works correctly. Can you please try that?

xausky

comment created time in 25 days

issue openedmapstruct/mapstruct.org

Add a more prominent link to the GitHub project

The link to the project is currently under "Source Code" if someone searches for "GitHub" they won't find anything.

created time in a month

push eventflowable/flowable-engine

Filip Hrisafov

commit sha 0549bdd829cd66327840183c70a0ef8d0a172272

Properly handle different types and null when querying for variable not equals

view details

push time in a month

delete branch filiphr/flowable-engine

delete branch : variable-value-not-equals

delete time in a month

PR merged flowable/flowable-engine

When querying for variable not equals different types and null should be properly handled

Do not merge yet.

This is an idea showing a possible way to implement notEquals for different types and null values in the DB.

This is done only for the CaseInstanceQuery. If the idea is accepted we should apply this logic to other queries as well

+1501 -79

0 comment

18 changed files

filiphr

pr closed time in a month

issue commentmapstruct/mapstruct

Generate imports only for top level classes

Hey @sahebpreet,

this is not about the imports in our codebase, but in the code that we generate. I tried doing this once and I don't think that it is as easy as I thought back then :). Have a look at https://github.com/filiphr/mapstruct/tree/top-level-imports-only.

Perhaps we should remove the label and completely close this issue.

If you are willing to give this a go feel free, otherwise you can always have a look at some of the other issues. You can also pick an issue that doesn't have the "good first issue" label ;)

filiphr

comment created time in a month

push eventfiliphr/flowable-engine

David B Malkovsky

commit sha 15dfb51d5d327f69189a520ecc807b460f9c227f

Periodic removal of unused imports (#2537)

view details

David B Malkovsky

commit sha 3bf94c237ed5dcb18785de7a4bb6c5e9e38b93ef

Use try with resources instead of try/finally (#2535)

view details

David B Malkovsky

commit sha b312dfe331bf9ccffb7612274d8d95eeaf2ecb5c

Remove duplicate dependency (#2543)

view details

Tijs Rademakers

commit sha 027e7dcc05550630167be4fe857b130bfa23b258

Fix scrolling process and case definitions

view details

Tijs Rademakers

commit sha 5906d1c0e76c273d8c74d17d0d41724d56dba34f

Merge branch 'master' of github.com:flowable/flowable-engine

view details

Tijs Rademakers

commit sha 6789c752355a92a4d1612f5021b5ef27e3221461

Fix issue with async and exclusive attributes in Modeler

view details

PHH

commit sha c68d9d0ae9bde44e59a24baf80e8f4dc4ccd5e05

Fixed links in Spring Boot section of user guide

view details

PHH

commit sha e860b11cbf3701fbfc0b1c8f39d1f3ad11849033

Upgraded Docusaurus to latest

view details

Filip Hrisafov

commit sha 4b398384d2fa525ea7b6cb0b5aa0cad8e87be795

Add a Spring WebClient implementation of the FlowableAsyncHttpClient

view details

Filip Hrisafov

commit sha a51a1a36e4792a87844a62d14a5046c3b00f4d1d

Set the FlowableHttpClient on the Process / Cmmn engines if it is available

view details

Yvo Swillens

commit sha a1d776b6bab9a88cdc93d62fdf89a086ea1a2ab3

fixed typo causing edit decision table link not working

view details

David B Malkovsky

commit sha 71e60aaee5545e93ed9f56f72e90aa3e6ac30ed7

Fix capitalization and link (#2547) * Fix capitialization and link * More small typos

view details

Yvo Swillens

commit sha 4cfe235a006d36f503368283a55ac16a61356909

moved modeler static root resources to correct location

view details

Yvo Swillens

commit sha b75ca5903dde8a272bcadab17e90e15c0264ecff

added DmnJsonConverterContext import / export helper

view details

Yvo Swillens

commit sha 5271ef45ca3fc2fc0027705dec8f97ed9f9673b3

refactored test cases

view details

Yvo Swillens

commit sha 8e03ae025afa6c25024646bc0584d6662763a9c0

fixed decision reference on DecisionTask both decision service and decision table cases were not properly supported

view details

Yvo Swillens

commit sha 87932e8ac22720b1770198f50206f4b7c1e06f77

updating decision table references in decision service during app import

view details

Yvo Swillens

commit sha 4e9dc6ac4cb9cc02734a275422c69d135eb42b19

take referenced decision tables from decision service intro account when importing

view details

Yvo Swillens

commit sha 30351d0b06260f0c46e986abfa5aa293db650851

set latest decision table model version when creating new model

view details

Yvo Swillens

commit sha 50e13bf84557a37b1675fc0d6fcab6ec82f7e4f2

removed overwriting decision table model version from client on save

view details

push time in a month

more