profile
viewpoint

fhs/acme-lsp 57

Language Server Protocol tools for the acme text editor

fhs/go-netcdf 19

Go binding for the netCDF C library.

fhs/9upspinfs 9

9P file server for Upspin

fhs/go-netrc 4

netrc file parser for Go programming language.

fhs/duitdraw 2

shiny backend for duit

fhs/edwood 2

Go version of Plan9 Acme Editor

fhs/Ghost 2

GhostText plugin for Acme text editor

fhs/archlinux-packages 1

My packages in archlinux AUR

fhs/CRC32.jl 1

32-bit cyclic redundancy check (CRC-32) checksum implementation for Julia

fhs/gig 1

[WIP] Git command implemented in pure Go

issue commentfhs/ZipFile.jl

Corruption, "crc32 do not match" writing with ZipFile.Deflate

@norru I was able to reproduce the issue on my machine. Have you tried disabling the GC? If disabling GC resolves the issue, we can have the Julia devs take over.

I don't know how easy it is to disable the GC. I just found this old thread: https://groups.google.com/forum/#!topic/julia-users/6_XvoLBzN60

norru

comment created time in 6 days

created tagfhs/acme-lsp

tagv0.9.1

Language Server Protocol tools for the acme text editor

created time in 7 days

release fhs/acme-lsp

v0.9.1

released time in 7 days

issue openedfhs/acme-lsp

Add support for versioned document edits

Currently, we ignore versioning in documents (see c143b86e62204682c98e5e3cd8c7e2cea8ab234e). We should make use of the version.

created time in 7 days

push eventfhs/acme-lsp

Fazlul Shahriar

commit sha c143b86e62204682c98e5e3cd8c7e2cea8ab234e

Workaround versioned document edits sent by gopls This fixes Organize Imports code action for gopls version >= 0.3.1. Fixes #31

view details

push time in 7 days

issue closedfhs/acme-lsp

Organize Imports code action is not working for gopls >= v0.3.1

Since I upgraded to macOS Catalina on "Put" the import path will not be organised any more (added/removed). Only the compiler will complain and write to /LSP/Diagnostics:

 /Users/m/Documents/src/project/project.go:88:14-88:26: undeclared name: strings

I tried to run acme-lsp -v but I do not get any error message or logs displayed on "Put". Any suggestions?

My config looks a follows:

WorkspaceDirectories = [
	"/Users/m/Documents/src/project",
]
FormatOnPut = true
CodeActionsOnPut = ["source.organizeImports"]

[Servers]
	[Servers.gopls]
	Command = ["gopls", "serve", "-rpc.trace"]
	StderrFile = "gopls.stderr.log"
	LogFile = "gopls.log"

		# These settings gets passed to gopls
		[Servers.gopls.Options]
		hoverKind = "FullDocumentation"

[[FilenameHandlers]]
Pattern = '([/\\]go\.mod)|([/\\]go\.sum)|(\.go)$'
ServerKey = "gopls"

closed time in 7 days

palmamartin

issue commentfhs/acme-lsp

On "Put" no import path will be organised or added/removed

I can reproduce the issue with gopls v0.3.1 and v0.3.2. Imports code action is not working because gopls changed the response format to versioned document edits. acme-lsp does not advertise to support versioned document edits, but gopls uses the new format anyway. These kinds of breakage are probably expected until gopls 1.0 is release.

Before (not versioned edit):

[Trace - 10:23:53.697 AM] Received response 'textDocument/codeAction - (2)' in 122ms.
Result: [{"title":"Organize Imports","kind":"source.organizeImports","edit":{"changes":{"file:///tmp/hello/hello.go":[{"range":{"start":{"line":8,"character":0},"end":{"line":8,"character":0}},"newText":"\t\"fmt\"\n"}]}}}]

After (versioned document edit):

[Trace - 10:13:42.788 AM] Received response 'textDocument/codeAction - (2)' in 15ms.
Result: [{"title":"Organize Imports","kind":"source.organizeImports","edit":{"documentChanges":[{"textDocument":{"version":0,"uri":"file:///tmp/hello/hello.go"},"edits":[{"range":{"start":{"line":8,"character":0},"end":{"line":8,"character":0}},"newText":"\t\"fmt\"\n"}]}]}}]
palmamartin

comment created time in 7 days

startedevanw/esbuild

started time in 7 days

issue commentfhs/ZipFile.jl

Corruption, "crc32 do not match" writing with ZipFile.Deflate

I need help to investigate the issue, come up with a reproducible case and ideally also a fix. 🙂

I'll try to investigate in the weekend. Can you include the imports used in your zip_stress function? I want to first see if I can reproduce the issue in my machine, but can't figure out where the format function is coming from.

norru

comment created time in 9 days

IssuesEvent

startedtailscale/tailscale

started time in 11 days

issue commentfhs/ZipFile.jl

Documentation not available at https://zipfilejl.readthedocs.io/en/latest/

I removed those docs when I switched over to docstrings. You can access the docs from the julia REPL. See https://docs.julialang.org/en/v1/manual/documentation/index.html#Accessing-Documentation-1

I'm open to anything that can generate html docs from julia docstrings.

norru

comment created time in 11 days

issue closedfhs/ZipFile.jl

Documentation not available at https://zipfilejl.readthedocs.io/en/latest/

The home page of the docs at https://zipfilejl.readthedocs.io/en/latest is showing an empty index file

closed time in 11 days

norru

issue commentfhs/acme-lsp

On "Put" no import path will be organised or added/removed

Check if gopls works without acme-lsp by running:

gopls check project.go

There is also gopls imports sub-command.

palmamartin

comment created time in 13 days

push eventfhs/CRC32.jl

Fazlul Shahriar

commit sha 81e636530ac6b12ad8bc669138dd9c1bc65eb9f1

Revert "Install TagBot as a GitHub Action" This reverts commit 35e1867d7d9871d72c97acd7668ea571ebfbeef9. The change was triggering build every hour because of build failure on Julia nightly. CRC32.jl is a deprecated package and we probably won't need a TagBot anyway. Update #7

view details

push time in 14 days

push eventfhs/CRC32.jl

Julia TagBot

commit sha 35e1867d7d9871d72c97acd7668ea571ebfbeef9

Install TagBot as a GitHub Action

view details

push time in 15 days

PR merged fhs/CRC32.jl

Install TagBot as a GitHub Action

You're receiving this pull request because the now-deprecated Julia TagBot GitHub App is installed for this repository. This pull request installs TagBot as a GitHub Action. If this PR does not belong in this repository for any reason, feel free to close it.

See this Discourse thread for more details and to ask questions. Please do not comment on this pull request, because it is unlikely that I (@christopher-dG) will see it.

+11 -0

0 comment

1 changed file

JuliaTagBot

pr closed time in 15 days

push eventfhs/NPZ.jl

Julia TagBot

commit sha 5ed1e44d6b12e7f81ab07085749012a92407c082

Install TagBot as a GitHub Action

view details

push time in 15 days

PR merged fhs/NPZ.jl

Install TagBot as a GitHub Action

You're receiving this pull request because the now-deprecated Julia TagBot GitHub App is installed for this repository. This pull request installs TagBot as a GitHub Action. If this PR does not belong in this repository for any reason, feel free to close it.

See this Discourse thread for more details and to ask questions. Please do not comment on this pull request, because it is unlikely that I (@christopher-dG) will see it.

+11 -0

0 comment

1 changed file

JuliaTagBot

pr closed time in 15 days

PR closed fhs/acme-lsp

Delete LICENSE
+0 -19

1 comment

1 changed file

jeepdude1980

pr closed time in 15 days

issue comment9fans/plan9port

URL of Plan9 is unreachable

The new URL is https://9p.io/plan9/ Feel free to send a PR with fixes.

vaibhavk

comment created time in a month

CommitCommentEvent

push eventfhs/ZipFile.jl

Fazlul Shahriar

commit sha 631a4ab603f07cb6f28f4b06488988505ea4f11b

Project.toml: adjust compat section Thanks to @fchorney (see https://github.com/fhs/ZipFile.jl/commit/8305ae5b1e4a36eb94050e4e7dac925bc5d95555#commitcomment-36883180)

view details

push time in a month

PR opened rjkroege/edwood

.gitattributes: fix font file attributes

Also added missing font files.

+4 -1

0 comment

4 changed files

pr created time in a month

create barnchfhs/edwood

branch : font-crlf

created branch time in a month

push eventfhs/edwood

push time in a month

created tagfhs/gompd

tagv2.1.1

Client side library for MPD (Music Player Daemon) for Go Programming Language.

created time in a month

PR closed fhs/gompd

Fixed URL escape issue
+10 -2

3 comments

2 changed files

tb0hdan

pr closed time in a month

pull request commentfhs/gompd

Fixed URL escape issue

Fixed in https://github.com/fhs/gompd/pull/48

tb0hdan

comment created time in a month

push eventfhs/gompd

BernardZhao

commit sha b4ff35b1426bd048cf1e97234e9d497708b0e262

Fixed URL escape issue

view details

push time in a month

PR merged fhs/gompd

Fixed URL escape issue

I encountered this issue myself and found #42, which was unresolved. Changing this fixed the error, but I am not familiar enough with the code to know if this is the only place where URLs can be expected. I am also not sure how to easily test this change in a unit test, since what we want to check is if our URL was formatted correctly.

+1 -1

0 comment

1 changed file

BernardZhao

pr closed time in a month

pull request commentrjkroege/edwood

Don't dump commands at the beginning of the row tag

The PR test in Travis CI has CRLF ending:

$ git clone --depth=50 https://github.com/rjkroege/edwood.git
...
$ cd edwood/
$ git fetch origin +refs/pull/290/merge:
...
$ git checkout -qf FETCH_HEAD
$ file build/font/lucsans/euro.8.font
build/font/lucsans/euro.8.font: ASCII text, with CRLF line terminators

Checking it out directly doesn't have CRLF ending:

$ git clone --depth=50 --branch=dump-rowtag-without-commands https://github.com/fhs/edwood.git 
...
$ file edwood/build/font/lucsans/euro.8.font 
edwood/build/font/lucsans/euro.8.font: ASCII text
fhs

comment created time in a month

push eventfhs/edwood

Fazlul Shahriar

commit sha 7549efd18b158c72140546c6693726b4d13203e7

Add missing font files These two were accidentally removed recently: build/font/lucm/cyrillic.9 build/font/shinonome/k14.5c01 This one is listed in the .font file but was never checked in: build/font/misc/letterlike.8

view details

Fazlul Shahriar

commit sha d67929a1f101823a73b3d059564958f7377b9e85

.gitattributes: fix font file attributes

view details

push time in a month

pull request commentrjkroege/edwood

Don't dump commands at the beginning of the row tag

The issue is that .gitattributes on master is wrong and it's changing the line ending of build/font/lucsans/euro.8.font to CRLF. Nothing I do in this PR seems to help. Maybe this is best fixed by pushing the correct .gitattributes file (along with fixed font files) directly to master.

fhs

comment created time in a month

push eventfhs/edwood

Daniel

commit sha b504fe1dc36dc55b28928425e60b35528d74aae7

Add support for tab expansion

view details

Daniel

commit sha b5e1f8725ee37414d81c3758e1c8da2268763e57

fixing references to tabexpand in wind.go

view details

Daniel

commit sha 45bfd4ab8e2dbfef5297207ac70941fb705a8c9a

cleaning up changes and fixing mistakes

view details

Daniel

commit sha 2f1749326bf27368f0ee4ae2211a12fb3e42e819

removing comparison to bool constant

view details

Daniel

commit sha 186f7d87dc8ebd8490a5a6ebc7063c75b67a1460

fixing indentation calculation

view details

Daniel

commit sha fff564cf17feb9f83a66c2ecbfd279c02bae0d9f

renaming texpand to tabexpand

view details

Daniel

commit sha 0779944182e8fed6ef02d3c14c77a7aae6e79016

reverting go.mod

view details

Daniel

commit sha 223d916a69ab401741c836249e550a43504a27e7

reverting go.sum

view details

Daniel

commit sha 550ad709af2100f14b61f673ca6a3fa5a6066eab

adding todo for rjk

view details

Daniel

commit sha 5b0f572350d77959da37828ef352d068f4efae2f

moving TODO comment

view details

Daniel

commit sha 5f887159ff6b87421cafb2f4e0b3bcfb446dd935

gofmting new changes

view details

Daniel

commit sha a17b5429c31b620ca6a66f48407bb48381150a3a

working on fixing line endings for font files

view details

Daniel

commit sha 75ff14f143c4c73a90908dcb3f678d32ae93f1b8

working on fixing line endings

view details

Daniel

commit sha 690c3de63dba71e83f9639d2cd02e42efecfc9cf

adding test for tabexpand ^I insert

view details

Daniel

commit sha 10e774a5004e80284c4f936a9ddbe49a3a613e3a

adding expand exec test

view details

Fazlul Shahriar

commit sha 442e8cd42d8f3ad2d2ec7f1062e9cc03e24ca253

Don't dump commands at the beginning of the row tag This prevents Load from adding commands that are not running to the beginning of the row tag. Every Dump/Load cycle adds more of these commands, further polluting the row tag.

view details

Fazlul Shahriar

commit sha 29aacf83627dff9d1991f68ec25d1e74d49a4f6f

Add missing font files These two were accidentally removed recently: build/font/lucm/cyrillic.9 build/font/shinonome/k14.5c01 This one is listed in the .font file but was never checked in: build/font/misc/letterlike.8 I've adjusted the .gitattributes file to ignore all binary files in the build/font directory.

view details

Fazlul Shahriar

commit sha 2f373a3b1b9facee7cb5d18fc026690be06c24ab

.gitattributes: fix font file attributes

view details

push time in a month

push eventfhs/edwood

Fazlul Shahriar

commit sha a851e4b090a87d54d15fa7926d6fbabb214e5863

Don't dump commands at the beginning of the row tag This prevents Load from adding commands that are not running to the beginning of the row tag. Every Dump/Load cycle adds more of these commands, further polluting the row tag.

view details

Fazlul Shahriar

commit sha 88663438f654020e89ec2647aec8025addc947de

Add missing font files These two were accidentally removed recently: build/font/lucm/cyrillic.9 build/font/shinonome/k14.5c01 This one is listed in the .font file but was never checked in: build/font/misc/letterlike.8 I've adjusted the .gitattributes file to ignore all binary files in the build/font directory.

view details

Fazlul Shahriar

commit sha 03c9e1779642299ddf674a280134d05aac06c6f5

.gitattributes: fix font file attributes

view details

push time in a month

push eventfhs/edwood

Fazlul Shahriar

commit sha 5094d1be4ab08d0d95a8777a1295927865473ceb

build: delete font files

view details

Fazlul Shahriar

commit sha 397ac6ac2dc5f18eb824fd77cdf49c4b464d9b52

build: add back font files Hopefully this fixes the line endings.

view details

push time in a month

push eventfhs/edwood

Fazlul Shahriar

commit sha 87ca479e7ef7ea62a0f8e7a690055a5bbb6dca2e

Fix incorrect window owner on writes to event file This fixes Send command crashing Edwood, Edit command generating wrong event, and possibly other issues caused by having window owner set to 0 while having a lock on it. Window owner was being set to 0 following Unlock, Lock sequence. Since Unlock sets owner to 0, we need to avoid using w.owner after calling Unlock. Fixes #284 Fixes #285

view details

Daniel

commit sha b504fe1dc36dc55b28928425e60b35528d74aae7

Add support for tab expansion

view details

Daniel

commit sha b5e1f8725ee37414d81c3758e1c8da2268763e57

fixing references to tabexpand in wind.go

view details

Daniel

commit sha 45bfd4ab8e2dbfef5297207ac70941fb705a8c9a

cleaning up changes and fixing mistakes

view details

Daniel

commit sha 2f1749326bf27368f0ee4ae2211a12fb3e42e819

removing comparison to bool constant

view details

Daniel

commit sha 186f7d87dc8ebd8490a5a6ebc7063c75b67a1460

fixing indentation calculation

view details

Daniel

commit sha fff564cf17feb9f83a66c2ecbfd279c02bae0d9f

renaming texpand to tabexpand

view details

Daniel

commit sha 0779944182e8fed6ef02d3c14c77a7aae6e79016

reverting go.mod

view details

Daniel

commit sha 223d916a69ab401741c836249e550a43504a27e7

reverting go.sum

view details

Daniel

commit sha 550ad709af2100f14b61f673ca6a3fa5a6066eab

adding todo for rjk

view details

Daniel

commit sha 5b0f572350d77959da37828ef352d068f4efae2f

moving TODO comment

view details

Daniel

commit sha 5f887159ff6b87421cafb2f4e0b3bcfb446dd935

gofmting new changes

view details

Daniel

commit sha a17b5429c31b620ca6a66f48407bb48381150a3a

working on fixing line endings for font files

view details

Daniel

commit sha 75ff14f143c4c73a90908dcb3f678d32ae93f1b8

working on fixing line endings

view details

Daniel

commit sha 690c3de63dba71e83f9639d2cd02e42efecfc9cf

adding test for tabexpand ^I insert

view details

Daniel

commit sha 10e774a5004e80284c4f936a9ddbe49a3a613e3a

adding expand exec test

view details

push time in a month

push eventfhs/edwood

Fazlul Shahriar

commit sha da325a216c49b2771dfc5359be2325c4e89d6858

.gitattributes: fix font file attributes

view details

push time in a month

issue openedrjkroege/edwood

Switch to GitHub Actions for CI?

GitHub Action runs start up and finish much faster than Travis CI. We should consider switching to it. Here is the setup in acme-lsp: https://github.com/fhs/acme-lsp/blob/91db24dd981550b4c777e988b86491ad4aa57e20/.github/workflows/test.yml

created time in a month

push eventfhs/edwood

Fazlul Shahriar

commit sha 8dc856b1f1da594d374c28eee8ec787ff7aa2d63

Don't dump commands at the beginning of the row tag This prevents Load from adding commands that are not running to the beginning of the row tag. Every Dump/Load cycle adds more of these commands, further polluting the row tag.

view details

Fazlul Shahriar

commit sha aa604689346028beac0d01fc9192a72e93be1627

Add missing font files These two were accidentally removed recently: build/font/lucm/cyrillic.9 build/font/shinonome/k14.5c01 This one is listed in the .font file but was never checked in: build/font/misc/letterlike.8 I've adjusted the .gitattributes file to ignore all binary files in the build/font directory.

view details

push time in a month

push eventfhs/edwood

Fazlul Shahriar

commit sha 41eb7daefee37896104148229a17c96644ac9b67

Add missing font files These two were accidentally removed recently: build/font/lucm/cyrillic.9 build/font/shinonome/k14.5c01 This one is listed in the .font file but was never checked in: build/font/misc/letterlike.8 I've adjusted the .gitattributes file to ignore all binary files in the build/font directory.

view details

push time in a month

create barnchfhs/edwood

branch : ci

created branch time in a month

CommitCommentEvent

create barnchfhs/ZipFile.jl

branch : release-0.8

created branch time in a month

CommitCommentEvent

push eventfhs/ZipFile.jl

Fazlul Shahriar

commit sha 67d35df31be996720bf5d8520f41bdeb258ea8c4

Bump version to 0.9.1

view details

push time in a month

pull request commentfhs/ZipFile.jl

Read file backwards to find EOCD offset without conflict

Ok, I'll do the releases tonight. I've never done a backport -- hopefully it works out.

On Fri, Jan 17, 2020 at 9:51 AM Fernando Chorney notifications@github.com wrote:

It looks like 0.9.0 is where julia 1.3 starts being required, so I guess we'd want to do a 0.8.4 patch if possible.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/fhs/ZipFile.jl/pull/63?email_source=notifications&email_token=AABMZTNR25CBWJFL3U5MUNTQ6HAVHA5CNFSM4KHJLS4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJH5GAA#issuecomment-575656704, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMZTLIBER42KRBUFWHU53Q6HAVHANCNFSM4KHJLS4A .

fchorney

comment created time in a month

push eventfhs/ZipFile.jl

Fernando Chorney

commit sha d56581ce8b75a879eecca4fc9e9de333e1f9e2e3

Add Broken zip for EOCD failure. https://github.com/fhs/ZipFile.jl/issues/62

view details

Fernando Chorney

commit sha f044efc443f565c9acf61fa87b0ee818e20276ba

Read file backwards to find enddir offset

view details

push time in a month

PR merged fhs/ZipFile.jl

Read file backwards to find EOCD offset without conflict

Fixes #62

Since the EOCD will always exist at the end of the file, wouldn't it make more sense to just read the file backwards for the signature, thus ensuring we don't hit any erroneous signatures within the data?

+4 -1

10 comments

3 changed files

fchorney

pr closed time in a month

issue closedfhs/ZipFile.jl

Reading Zip File fails if _EndCentralDirSig exists in the zipped data

Came across an issue where the _EndCentralDirSig aka 0x06054b50 value seems to exist in the zip data itself (which consisted of .XLSX files). The value existed within the last 1024 bytes of the zipped archive that ZipFile.jl seemed to confuse with the End of central directory record (EOCD).

I have crafted a zip file to simulate the failure.

A.zip

closed time in a month

fchorney

pull request commentfhs/ZipFile.jl

Read file backwards to find EOCD offset without conflict

Oh actually looking at the go implementation, it looks like it scans from the bottom up as well (assuming I'm reading this correctly). https://github.com/philwebb/go/blob/master/src/archive/zip/reader.go#L421-L433

Yep, that's right. I probably overlooked it when I copied the logic from Go's implementation.

fchorney

comment created time in a month

pull request commentrjkroege/edwood

Don't dump commands at the beginning of the row tag

I've added back the font files that got deleted accidentally, and also found one that was never checked in. The font should be ok now.

fhs

comment created time in a month

push eventfhs/edwood

Fazlul Shahriar

commit sha 2e028eca07146dd592e7dab7fb3fbe98db12421e

Don't dump commands at the beginning of the row tag This prevents Load from adding commands that are not running to the beginning of the row tag. Every Dump/Load cycle adds more of these commands, further polluting the row tag.

view details

Fazlul Shahriar

commit sha 14b694dd022d499eb01c1e1666c94e137c1b5f7b

Add missing font files These two were accidentally removed recently: build/font/lucm/cyrillic.9 build/font/shinonome/k14.5c01 This one is listed in the .font file but was never checked in: build/font/misc/letterlike.8 I've adjusted the .gitattributes file to ignore all binary files in the build/font directory.

view details

push time in a month

pull request commentfhs/ZipFile.jl

Read file backwards to find EOCD offset without conflict

Note: ZipFile.jl is based on Go's zip package, which uses the same logic: https://github.com/golang/go/blob/d2de9bd59c068c1bfcb4293de4286196dacf2e43/src/archive/zip/reader.go#L460 I will take a look at the spec later, but maybe we can take care of any optimization in a new PR.

fchorney

comment created time in a month

push eventfhs/plan9port

Russ Cox

commit sha 3197719090b3fd0a038767f7e8e15e771b1515be

acme: do not trim spaces during Put The commit that introduced this was pushed accidentally. It is not a good idea to do this. (It breaks programs that think that a clean window means the body matches the on-disk file.)

view details

Xiao-Yong

commit sha cc9ecfbee7b1c346bd6b35bf1b9501bdf7eb9c21

devdraw: cocoa metal screen updates (#215) * devdraw: cocoa metal screen uses a dirty hack to make everything smooth * devdraw: cocoa metal screen uses a layer to make fullscreen applications behave * devdraw: macOS cocoa metal fix resizeimg without img * devdraw: macOS cocoa metal uses blit instead of render We directly use the blit command encoder to copy texture to the framebuffer. We no longer need to compile the metal shader every time the application starts just for rendering a flat 2D surface. * travis: add osx images covering 10.13 and 10.14

view details

Russ Cox

commit sha 161742770e63fec914b0290def3ac063ad3d2cf9

acme: delete trailing spaces during Put in autoindent mode Autoident mode is the leading cause of trailing spaces on lines. Remove them during Put to make various picky tools happier. The changes during Put are added as a separate entry to the file history, so that the first Undo after Put restores the spaces.

view details

Russ Cox

commit sha 7a241631b2097b1acda431ff059b771c5d1c391c

acme: accept expanded URLs in look Just as look expands a click in /etc/passwd to the full name (provided that file exists), it now expands a click in https://9fans.net/ to the full URL (provided the prefix is http:// or https://). Probably more adjustment is needed.

view details

Pocket7878

commit sha d4e16c838ab2cccd97ad6e24fc290239666eaaac

devdraw: handle windowDidResize on macOS (#212) This supports non-live window resize.

view details

Xiao-Yong

commit sha e995a0c101863688d5f14649ae3de45a7c43789c

devdraw: cocoa metal screen adds a delayed update (#270) The immediate display of the screen sometimes miss the update from the CPU side memory. No obvious synchronization mechanism is available. In order to make sure the screen updates properly, we set needsDisplay again after 16ms delay to ensure a second screen update.

view details

Zach Scott

commit sha 7d827b5cca185b411be3ac9b71834958f4737bdf

auxstats: replace /proc ACPI calls with /sys ones (#245) According to <https://askubuntu.com/a/309146>, use of `/proc/acpi` to get battery usage is deprecated. This commit replaces the two files from this API with the single file `/sys/class/power_supply/BAT0/capacity`, simultaneously removing the need to calculate battery percentage.

view details

Fazlul Shahriar

commit sha b9424f640a0493359fd2af7c670c5a4ced334e6b

plumber: fix EOF detection on writes to rules file (#257) Instead of checking Fcall.data==nil, check Fcall.count==0. The former check always fails after `gcc -O2` optimizations (gcc version 8.3.0). Also fix an out-of-bound read detected by valgrind: ``` ==31162== Invalid read of size 1 ==31162== at 0x11005E: morerules (rules.c:739) ==31162== by 0x110254: writerules (rules.c:775) ==31162== by 0x10D2FE: fsyswrite (fsys.c:848) ==31162== by 0x10C304: fsysproc (fsys.c:248) ==31162== by 0x112E8C: threadstart (thread.c:96) ==31162== by 0x4A682BF: ??? (in /usr/lib/libc-2.29.so) ==31162== Address 0x4ea984a is 0 bytes after a block of size 250 alloc'd ==31162== at 0x483AD7B: realloc (vg_replace_malloc.c:826) ==31162== by 0x1196F3: p9realloc (malloc.c:53) ==31162== by 0x10BDFD: erealloc (plumber.c:124) ==31162== by 0x10FCD9: concat (rules.c:642) ==31162== by 0x10FCD9: concat (rules.c:635) ==31162== by 0x110230: writerules (rules.c:773) ==31162== by 0x10D2FE: fsyswrite (fsys.c:848) ==31162== by 0x10C304: fsysproc (fsys.c:248) ==31162== by 0x112E8C: threadstart (thread.c:96) ==31162== by 0x4A682BF: ??? (in /usr/lib/libc-2.29.so) ``` Fixes #256

view details

telephil

commit sha 9389de63d7b0dab99773511f48b2d303e3f957d7

upas/nfs: fix null date when message is sent to plumber (#263) When fetching, messages are sent to plumber as soon as the ENVELOPE part is read. The date field of the message is sent when the INTERNALDATE part is read and there is no guarantee that this will be read before the ENVELOPE. This bug can be observed when using faces(1) which will retrieve messages with a null date and then always display a 'Jan 1' date instead of the correct one. The fix is to simply send the message to plumber after having read all parts, thus ensuring the message is complete.

view details

deepcube

commit sha f1dd3f065a97f57bf59db2e3284868e181734159

hoc: don't nest calls to follow() when lexing ++/+= and --/-= (#287) The code had a nested use of the follow() function that could cause +=+ and -=- to register as ++ and --. The first follow() to execute could consume a character and match and then the second follow() could consume another character and match. For example i-=-10 would result in a syntax error and i-=- would decrement i.

view details

Günther Noack

commit sha 13d40aa64c8c073c296ad2c8df0bae6d607aff07

9l: support Linux version 5.0+ (#274) Update 9l to support Linux 5.x.

view details

Francis Conti

commit sha 715807d706cd13bc583588477a84090fbf02e057

Teach 9l about FreeBSD ≥ 12; address issue #247. (#249)

view details

Fazlul Shahriar

commit sha 1309450668aa571dee97f4373f9555b4fddcf1aa

awk: split record into runes for empty FS (#292) awk was splitting records into bytes instead of runes for empty FS. For example, this was printing only the first byte of the utf-8 encoding of é: echo é | awk 'BEGIN{FS=""}{print $1}' The change just copies how the `split` function handles runes. Originally reported by kris on twitter: https://twitter.com/p9luv/status/1180436083433201665

view details

Jason Felice

commit sha b0aecb4ba5c3d7df6589c01f5a7c0427f5a75305

plumber: add -f (foreground) option (#288) In MacOS, services run by launchd must run in the foreground, since launchd manages forking and other resources.

view details

Jason Felice

commit sha 436ff26c3688198de8e8e48121296eace0b5d119

9c, 9l: use $TMPDIR if available (#272) NixOS sandboxed builds (at least on Mac) don't have access to /tmp, and this should be better POSIX.

view details

Fazlul Shahriar

commit sha 46606276c3fe20fa81597cf87378e18f7baf88a7

page: fix hang for forward-only postscript files Page was hanging because ghostscript never closes the fd from which we're reading BMP data. We close our end of the pipe so that ghostscript will close its end. Tested with ghostscript version 9.50. Fixes #124

view details

Marc Simpson

commit sha 3d08a066b167b60691949fe89a7a67ef29df39cb

ed: replace magic number (077776, i.e. 32766) with NBLK-1. (#300) Temp file size is now declared in an enum; changing it from the default introduces a subtle bug in putline(), which expects it to be 32767. Mask with NBLK-1 instead.

view details

Fazlul Shahriar

commit sha 01a29ffe9dec8f11afa6db22a6ed0218bdbe5c5c

page: fix pdf prolog for ghostscript >= 9.27 (#296) Ghostscript 9.27 removed GS_PDF_ProcSet and pdfdict due to a security issue (see https://security-tracker.debian.org/tracker/CVE-2019-3839). This fix was contributed by @onyxperidot (see #279). Fixes #279

view details

Marc Simpson

commit sha f7f0512875f6eedfa8caa26a4b3969d66f31a6c4

ed: formatting tweak (remove redundant tab). (#301)

view details

Russ Cox

commit sha 4af8158b5351cc0ed7fc0ebb5e7b31c64069363d

libbio: report Bflush/close error from Bterm

view details

push time in a month

startedNationalSecurityAgency/ghidra

started time in a month

issue openedrjkroege/edwood

Crash after executing `Edit X |cat` with multiple windows

This was recently fixed in p9p acme: https://github.com/9fans/plan9port/commit/d2df5d6cbd345e101732fe7d22bb5b3baa5fb61a

created time in a month

startedory/dockertest

started time in a month

PR opened rjkroege/edwood

Don't dump commands at the beginning of the row tag

This prevents Load from adding commands that are not running to the beginning of the row tag. Every Dump/Load cycle adds more of these commands, further polluting the row tag.

+12 -3

0 comment

3 changed files

pr created time in a month

create barnchfhs/edwood

branch : dump-rowtag-without-commands

created branch time in a month

startedhouqp/sqlvet

started time in a month

pull request comment9fans/plan9port

ACME: Support editing file names with spaces

Note: there is another PR open that adds support for spaces in filenames: https://github.com/9fans/plan9port/pull/104

farhaven

comment created time in a month

issue commentfhs/acme-lsp

clojure-lsp unmarshalling json error

I've added a -rpc.trace flag to acme-lsp for easier debugging. I was able to reproduce your problems. To summarize:

  • L fmt: textDocument/codeAction is returning []Command instead of []CodeAction
  • L def: textDocument/definition is returning Location instead of []Location
  • L comp: textDocument/completion is returning CompletionItem[] instead of CompletionList

clojure-lsp is allowed to return those according to the spec. It just differs from gopls, which is what acme-lsp LSP parser is based on. The first two are probably not easy to fix. Completion should be relatively easy to fix by converting the CompletionItem[] to a CompletionList during JSON unmarshal.

I'm not sure when I'll get around to looking deeper. If anyone wants to work on fixes, PRs are welcome. There are some workarounds to these types of JSON unmarshaling issues (see internal/lsp/protocol/compat.go), but in general it's not fun trying to unmarshal JSON union types in Go.

scotts777

comment created time in a month

push eventfhs/acme-lsp

Fazlul Shahriar

commit sha 91db24dd981550b4c777e988b86491ad4aa57e20

cmd/acme-lsp: add -rpc.trace flag This helps with debugging LSP servers that don't do tracing.

view details

push time in a month

push eventfhs/acme-lsp

Fazlul Shahriar

commit sha c13a25add20414e020605183fa172d4113772c7b

internal/lsp/protocol: copy changes from gopls v0.2.2

view details

push time in a month

push eventfhs/acme-lsp

Fazlul Shahriar

commit sha c13a25add20414e020605183fa172d4113772c7b

internal/lsp/protocol: copy changes from gopls v0.2.2

view details

push time in a month

push eventfhs/acme-lsp

Fazlul Shahriar

commit sha 1b0ca50a4a301346f3262007a75faac90a35cb45

internal/golang_org_x_tools: copy updates from gopls v0.2.2

view details

push time in a month

create barnchfhs/acme-lsp

branch : test

created branch time in a month

delete branch fhs/acme-lsp

delete branch : test

delete time in a month

push eventfhs/acme-lsp

Fazlul Shahriar

commit sha 9b7e01b339b4b09be7d352e9d30094da37e3772a

.github/workflows/test.yml: fix gopls installation

view details

push time in a month

push eventfhs/acme-lsp

Fazlul Shahriar

commit sha c67e45ff68ef9e6a360389c63a78f00a19f11080

.travis.yml: fix gopls installation failure The legacy path has been removed.

view details

push time in a month

created tagfhs/acme-lsp

tagv0.9.0

Language Server Protocol tools for the acme text editor

created time in a month

release fhs/acme-lsp

v0.9.0

released time in a month

CommitCommentEvent

delete branch fhs/plan9port

delete branch : 9term-look

delete time in 2 months

push eventfhs/ZipFile.jl

Marc Ittel

commit sha c31560306cb7a6debf123e1e32203f893d171337

Fix example in docstring (#61) change readstring(f) to read(f, String)

view details

push time in 2 months

PR merged fhs/ZipFile.jl

fix docstring

change readstring(f) to read(f, String)

+1 -1

0 comment

1 changed file

MarcMush

pr closed time in 2 months

pull request commentrjkroege/edwood

Adding support for tab expansion

I think the changes in the font files are just line ending changes? They should probably be marked as binary in the .gitattributes file. I'm also encountering this:

warning: CRLF will be replaced by LF in build/font/lucm/cyrillic.9.
The file will have its original line endings in your working directory
warning: CRLF will be replaced by LF in build/font/shinonome/k14.5c01.
The file will have its original line endings in your working directory
diff --git a/build/font/lucm/cyrillic.9 b/build/font/lucm/cyrillic.9
index ac440ca..452da53 100644
Binary files a/build/font/lucm/cyrillic.9 and b/build/font/lucm/cyrillic.9 differ
diff --git a/build/font/shinonome/k14.5c01 b/build/font/shinonome/k14.5c01
index e815e9f..2b89054 100644
Binary files a/build/font/shinonome/k14.5c01 and b/build/font/shinonome/k14.5c01 differ
danieljamespost

comment created time in 2 months

startednicolagi/telegramfs

started time in 2 months

push eventcorcusinc/github-ads

Fazlul Shahriar

commit sha 310844546203f73cfdc44562e01dd8ec8aa1edce

README.md: fix typos

view details

push time in 2 months

fork fhs/github-ads

Developer first Github ads

fork in 2 months

CommitCommentEvent
CommitCommentEvent

push eventfhs/ZipFile.jl

Fazlul Shahriar

commit sha 3d665445c3b0e954e40d79010c208db10e6aef7f

Bump version to 0.9.0

view details

push time in 2 months

created tagfhs/ZipFile.jl

tagv0.9.0

Read/Write ZIP archives in Julia

created time in 2 months

issue commentfhs/acme-lsp

clojure-lsp unmarshalling json error

I think it's failing to parse CodeAction result while doing the Format. CodeAction.command should be of type Command (not string) according to the spec. However, CodeAction result can be (Command | CodeAction)[] | null, so maybe it's returning a Command instead of a CodeAction? It's hard to know what's going on without looking at the RPC trace. There may be a flag in clojure-lsp to print the json-rpc protocol trace.

scotts777

comment created time in 2 months

issue closedfhs/acme-lsp

Error starting clojure-lsp

Trying to start up acme-lsp with a config.toml file that is specifying the clojure-lsp server. Running on Mac OS X 10.15.2

My PATH contains the location of clojure-lsp. Typing clojure.lsp in the shell runs it successfully. I have used this lsp server with VSCode and Neovim successfully.

The error I am getting is: failed to create file manager: failed to execute language server: fork/exec /usr/local/clojure-lsp/clojure-lsp: exec format error

That is the correct location to clojure-lsp. There are no log messages in the LogFile or StderrFile or the clojure-lsp log.

Config is: `ProxyNetwork = "unix" ProxyAddress = "/tmp/ns.ses.:0/acme-lsp.rpc" AcmeNetwork = "unix" AcmeAddress = "/tmp/ns.ses.:0/acme" WorkspaceDirectories = ["/Users/ses/Projects/Clojure/finance"] RootDirectory = "/" FormatOnPut = true CodeActionsOnPut = ["source.organizeImports"]

[Servers] [Servers.clojure] Command = ["clojure-lsp"] Address = "" StderrFile = "/Users/ses/Library/Caches/acme-lsp/clojure.stderr.log" LogFile = "/Users/ses/Library/Caches/acme-lsp/clojure.log" [Servers.clojure.Options] hoverKind = "FullDocumentation"

[[FilenameHandlers]] Pattern = "(\.deps)|(\.clj)$" ServerKey = "clojure"`

closed time in 2 months

scotts777

issue commentfhs/acme-lsp

Error starting clojure-lsp

clojure-lsp is doing something clever to make it execute in unix shells:

$ sed 4q clojure-lsp 
:;exec java -Xmx1g -server -Dclojure-lsp.version=0.1.0-SNAPSHOT -jar $0 "$@"
@echo off
java -Xmx1g -server -Dclojure-lsp.version=0.1.0-SNAPSHOT -jar "%~f0" %*
goto :eof

This will probably work:

 Command = ["sh", "-c", "clojure-lsp"]

(Note: rc -c clojure-lsp doesn't work.)

scotts777

comment created time in 2 months

startedFiloSottile/age

started time in 2 months

push eventfhs/gig

Fazlul Shahriar

commit sha ccc6682b1bc1316bdae29ad3183708d92d1c43eb

go.mod, go.sum: remove replace directives

view details

push time in 2 months

startedfhs/gig

started time in 2 months

push eventfhs/gig

Fazlul Shahriar

commit sha 75b1543da0d3aa1fbf303c8a4c095bd74e74615a

Add package doc

view details

push time in 2 months

create barnchfhs/gig

branch : master

created branch time in 2 months

created repositoryfhs/gig

[WIP] Git command implemented in pure Go

created time in 2 months

PR opened src-d/go-git

Add Plan 9 support

Not all the tests pass yet but this makes go-git usable on Plan 9. Please merge this after https://github.com/src-d/go-billy/pull/78.

Fixes #756

Signed-off-by: Fazlul Shahriar fshahriar@gmail.com

+80 -0

0 comment

3 changed files

pr created time in 2 months

create barnchfhs/go-git

branch : plan9support

created branch time in 2 months

fork fhs/go-git

A highly extensible Git implementation in pure Go.

https://godoc.org/gopkg.in/src-d/go-git.v4

fork in 2 months

issue commentfhs/acme-lsp

question: disable diagnostics window?

Just to be clear, you're saying that when you use 'Watch go test', it would be convenient to be able to hide diagnostics, because it is redundant with the output that is in the "watch window", right?

Right. It might be worth adding support for dynamically enabling/disabling display of diagnostics, but for now I've added a -hidediag flag and a corresponding HideDiagnostics config value.

mpl

comment created time in 2 months

push eventfhs/acme-lsp

Fazlul Shahriar

commit sha e04d25695d0fef1dfdf5d4f18c59984a0b2ba851

README.md: link to Actions on master branch only

view details

Fazlul Shahriar

commit sha f9edabb552417d6775aa7006343db80a42f0b8ee

cmd/acme-lsp: add -hidediag flag and HideDiagnostics config Fixes #27

view details

push time in 2 months

more