profile
viewpoint
Fabien Potencier fabpot Symfony/Blackfire Lille, France http://fabien.potencier.org/

doctrine/DoctrineBundle 3124

Symfony Bundle for Doctrine ORM and DBAL

fabpot/Pimple 70

A small PHP 5.3 dependency injection container

fabpot/composer 42

Package Manager for PHP

fabpot/PHP-CS-Fixer 41

A tool to automatically fix PHP coding standards issues

fabpot/EasyAdminBundle 9

The new (and simple) admin generator for Symfony applications.

fabpot/security-checker 6

PHP frontend for security.sensiolabs.org

fabpot/api-platform 5

Build hypermedia and GraphQL APIs in minutes, generate Progressive Web Apps to consume them.

fabpot/api-pack 4

A pack for API Platform

fabpot/carsonbot 4

Issue Bot used on symfony/symfony

push eventsymfony/marketing

Javier Eguiluz

commit sha a89bf24e90fab45467b8fd067cd6289bff1cd58a

Added Uvdesk project

view details

Fabien Potencier

commit sha 74c098cc6572d2c93babb8a08e50fbe1c73b03fe

Merge pull request #511 from javiereguiluz/add_uvdesk Added Uvdesk project

view details

push time in 9 hours

issue commentsymfony/cli

unable to launch symfony run bin/phpunit

You should probably use symfony php instead of symfony run anyway.

On 19 Feb 2020, at 13:23, devDzign notifications@github.com wrote:

unable to launch symfony run bin/phpunit => error

$symfony run bin/phpunit

exec: "bin/phpunit": file does not exist

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/symfony/cli/issues/214?email_source=notifications&email_token=AAALRULWF22KRC6H4KVAPG3RDUQD5A5CNFSM4KXYJCE2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IOT3ZIQ, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAALRUN7H7A6BMVB6DFJ533RDUQD5ANCNFSM4KXYJCEQ.

devDzign

comment created time in 11 hours

push eventFriendsOfPHP/security-advisories

Maxime Rainville

commit sha bb67173b6c7215ed028a7d474fe03250055241d6

Add silverstripe/framework issue CVE-2019-19325

view details

Fabien Potencier

commit sha 89e1a8a20bc20d81c6ce8f2c50819a67773c1b91

Merge pull request #447 from creative-commoners/pulls/CVE-2019-19325 Add silverstripe/framework issue CVE-2019-19325

view details

push time in 19 hours

issue commentsymfony/symfony

[Mailer][Mailgun] Support more headers

That works for me.

Nyholm

comment created time in a day

PR merged symfony/symfony

[Notifier] Remove not needed argument $bus in BrowserChannel::notify(...) Status: Reviewed
Q A
Branch? master
Bug fix? no
New feature? no <!-- please update src/**/CHANGELOG.md files -->
Deprecations? no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
Tickets - <!-- prefix each issue number with "Fix #", if any -->
License MIT
Doc PR - <!-- required for new features -->

The BrowserChannel::notify(...) method defines a fourth nullable argument $bus which is not part of the ChannelInterface and also not used in the implementation. So I think it was added by mistake and can be removed.

+1 -2

3 comments

1 changed file

jschaedl

pr closed time in 2 days

push eventsymfony/symfony

Jan Schädlich

commit sha ab4123ce68eb94b328e8988cb7416138fb0cbae8

[Notifier] Remove not needed argument $bus in BrowserChannel::notify()

view details

Fabien Potencier

commit sha bd42f129df054d1a85360620f1c7d6c7a5168329

minor #35770 [Notifier] Remove not needed argument $bus in BrowserChannel::notify(...) (jschaedl) This PR was merged into the 5.0 branch. Discussion ---------- [Notifier] Remove not needed argument $bus in BrowserChannel::notify(...) | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | - <!-- required for new features --> The `BrowserChannel::notify(...)` method defines a fourth nullable argument `$bus` which is not part of the `ChannelInterface` and also not used in the implementation. So I think it was added by mistake and can be removed. Commits ------- ab4123ce68 [Notifier] Remove not needed argument $bus in BrowserChannel::notify()

view details

push time in 2 days

pull request commentsymfony/symfony

[Notifier] Remove not needed argument $bus in BrowserChannel::notify(...)

Thank you @jschaedl.

jschaedl

comment created time in 2 days

issue closedsymfony/symfony-docs

Deprecate Yoda conditions on both sources and documentation.

Preamble:

  • Simple community question (not asking for more unless concensus).
  • This question is not about raising all the syntax trolls out there. :)
  • This question is only about Documentation first, as Documentation show more custom sample code than internal Symfony code. But depending on results, question shall be raised on Symfony code repositories as well, for coherence purposes, let's not kick the anthill too fast.

Hi all!

Bumped into this today, while getting feedback on a Symfony Doc PR.

First: sorry if this is not the appropriate place nor form, I usually only correct doc straight away and not create full-text conditions to creating PRs.

This topic was internally solved positively (i.e. removed) a few years ago, since PHP7, pretty much everywhere I touched code, home, work, etc. Also, being used to contributing / reading code from sources that are not Symfony as much as sources that are Symfony, it seems the latter (which matters right now) is one of the only that uses Yoda conditions. Most other projects don't, as far as I know. Don't enter a project quoting / namedropping contest, please, this is not the place for it, even though simple mentions would be useful.

So, my question would be, in one straight sentence: could we consider dropping the Yoda conditions, as mentioned in: https://symfony.com/doc/current/contributing/code/standards.html, or do they still make sense in a full triple-equal syntax world?

I won't add all arguments here, at a glance:

  • https://knowthecode.io/yoda-conditions-yoda-not-yoda
  • https://dev.to/greg0ire/why-using-yoda-conditions-you-should-probably-not
  • PHP The Right Way doesn't use them: https://phptherightway.com/pages/The-Basics.html
  • CodingMachine states it as controversial and avoidable: http://bestpractices.thecodingmachine.com/php/defensive_programming.html
  • Long talk in CS-Fixer too: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2446

Version suggestion: should only affect 5+, thanks to dependency on PHP 7.2.+ and strict + nullable typing, no real link between those two things, but surely can help, considering there should be no "==" left anywhere in the source code, especially when encouraged to use strict typing.

Thanks for the read! :)

closed time in 2 days

DocFX

issue commentsymfony/symfony-docs

Deprecate Yoda conditions on both sources and documentation.

As @javiereguiluz already mentioned, that would be a huge amount of work for nothing. Yoda conditions are still valid and can still be somewhat useful. I don't think that === changes the status quo. In any case, that won't happen as one is not really better than the other. And we try to avoid changes with marginal value but with a huge amount of work.

Thank you for proposing.

DocFX

comment created time in 2 days

PR merged symfony/symfony

Add the bug label automatically when using the bug issue template Status: Reviewed
Q A
Branch? master (default branch)
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a
+1 -0

3 comments

1 changed file

stof

pr closed time in 2 days

push eventsymfony/symfony

Christophe Coevoet

commit sha f2f9ee546606bf75d675d27cf7c13858814b1b92

Add the bug label automatically when using the bug issue template

view details

Fabien Potencier

commit sha cde44fcad1025ebc4e2313ceee32496cba7d8b2a

minor #35768 Add the bug label automatically when using the bug issue template (stof) This PR was merged into the 5.1-dev branch. Discussion ---------- Add the bug label automatically when using the bug issue template | Q | A | ------------- | --- | Branch? | master (default branch) | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a Commits ------- f2f9ee5466 Add the bug label automatically when using the bug issue template

view details

push time in 2 days

pull request commentsymfony/symfony

Add the bug label automatically when using the bug issue template

Thank you @stof.

stof

comment created time in 2 days

pull request commentsymfony/symfony

Update EmailValidator.php

We've debated this one in the past. We've settled with official HTML5. And that won't change. So, let's close.

darkdef

comment created time in 2 days

PR closed symfony/symfony

Update EmailValidator.php Bug Status: Needs Review
Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

fix - check symbol "." before @ in email (RFC 822) for HTML5 mode similar to bug #18560

+2 -1

7 comments

2 changed files

darkdef

pr closed time in 2 days

issue commentsymfony/symfony

Invalid @author docblocks in some files

Let's see what @Tobion think about it :)

JurRutten

comment created time in 2 days

PR closed swiftmailer/swiftmailer

fix indentation
+1 -1

1 comment

1 changed file

DurandSacha

pr closed time in 2 days

pull request commentswiftmailer/swiftmailer

fix indentation

For everything related to coding standard, we are relying on PHP-CS-Fixer to automate the task. So, if something is not implemented by PHP-CS-Fixer, we don't update the code (and again, we would have to do it everywhere instead of just one place).

DurandSacha

comment created time in 2 days

PR closed twigphp/Twig

Environment Fix
+4 -2

1 comment

1 changed file

DurandSacha

pr closed time in 2 days

pull request commenttwigphp/Twig

Environment Fix

The whole doc is using inlined namespaces. So, changing just one of them would not make sense. Let's close as changing all of them would incur a lot of work when merging up from 1.x to 3.x

DurandSacha

comment created time in 2 days

created repositorysymfony/sinch-notifier

Provides Sinch integration for Symfony Notifier.

created time in 2 days

PR merged symfony/symfony

[Validator] Add the missing translations for the Polish ("pl") locale Status: Reviewed Validator
Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
License MIT

Fabbot indicates a typo, but there is no typo. The English word address is adres in Polish (with a single d and a single s).

+36 -0

1 comment

1 changed file

przemyslaw-bogusz

pr closed time in 2 days

push eventsymfony/symfony

Przemysław Bogusz

commit sha 8c4de564a8697cf63c49c39501060ffb138f4762

[Validator] Add the missing translations for the Polish ("pl") locale

view details

Fabien Potencier

commit sha 5867c7e090d87cc8a8481fec30585efe3324c04c

minor #35760 [Validator] Add the missing translations for the Polish ("pl") locale (przemyslaw-bogusz) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Add the missing translations for the Polish ("pl") locale | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Fabbot indicates a typo, but there is no typo. The English word `address` is `adres` in Polish (with a single d and a single s). Commits ------- 8c4de564a8 [Validator] Add the missing translations for the Polish ("pl") locale

view details

push time in 2 days

pull request commentsymfony/symfony

[Validator] Add the missing translations for the Polish ("pl") locale

Thank you @przemyslaw-bogusz.

przemyslaw-bogusz

comment created time in 2 days

PR merged symfony/symfony

Reviewers
[Messenger] Add missing return in AmazonSqsReceiver::getMessageCount Bug Messenger Status: Reviewed
Q A
Branch? master <!-- see below -->
Bug fix? yes
New feature? no <!-- please update src/**/CHANGELOG.md files -->
Deprecations? no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
License MIT
+1 -1

1 comment

1 changed file

mynameisbogdan

pr closed time in 2 days

push eventsymfony/symfony

Bogdan

commit sha 7042ff86eccb75d11d2e6483e6a6817cb19908df

[Messenger] Add missing return in AmazonSqsReceiver::getMessageCount

view details

Fabien Potencier

commit sha baf42452032f85325f4d8bd2c877f1499e3d2ae8

bug #35764 [Messenger] Add missing return in AmazonSqsReceiver::getMessageCount (mynameisbogdan) This PR was merged into the 5.1-dev branch. Discussion ---------- [Messenger] Add missing return in AmazonSqsReceiver::getMessageCount | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT Commits ------- 7042ff86ec [Messenger] Add missing return in AmazonSqsReceiver::getMessageCount

view details

push time in 2 days

pull request commentsymfony/symfony

[Messenger] Add missing return in AmazonSqsReceiver::getMessageCount

Thank you @mynameisbogdan.

mynameisbogdan

comment created time in 2 days

PR merged symfony/symfony

[Notifier] added Sinch texter transport Feature Notifier Status: Reviewed
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

This PR adds adapter for Sinch messaging gateway to the texter transport.

Example configuration: sinch://SID:TOKEN@default?from=PHONE

+242 -0

1 comment

12 changed files

imiroslavov

pr closed time in 2 days

issue openedsymfony/symfony-docs

[Notifier] added Sinch texter transport

Q A
Feature PR symfony/symfony#34654
PR author(s) @imiroslavov
Merged in 5.1-dev

created time in 2 days

push eventsymfony/symfony

Iliya Miroslavov Iliev

commit sha db6d360be80d7145e13162bbe3caee4b45cee344

[Notifier] added Sinch texter transport

view details

Fabien Potencier

commit sha 2b68d535266dba2511f8e8519ab572a396e9497d

feature #34654 [Notifier] added Sinch texter transport (imiroslavov) This PR was squashed before being merged into the 5.1-dev branch. Discussion ---------- [Notifier] added Sinch texter transport | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a This PR adds adapter for Sinch messaging gateway to the texter transport. Example configuration: `sinch://SID:TOKEN@default?from=PHONE` Commits ------- db6d360be8 [Notifier] added Sinch texter transport

view details

push time in 2 days

pull request commentsymfony/symfony

[Notifier] added Sinch texter transport

Thank you @imiroslavov.

imiroslavov

comment created time in 2 days

push eventimiroslavov/symfony

Iliya Miroslavov Iliev

commit sha db6d360be80d7145e13162bbe3caee4b45cee344

[Notifier] added Sinch texter transport

view details

push time in 2 days

PR closed symfony/symfony

Reviewers
[Security] Fix user role restriction. Bug Security Status: Needs Work

It was impossible to restrict user roles on the fly without deauthentication.

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35509
License MIT
Doc PR

Allowed to restrict current user roles without changing roles for user object.

+85 -3

10 comments

3 changed files

gorshkov-ag

pr closed time in 3 days

pull request commentsymfony/symfony

[Security] Fix user role restriction.

Closing as I agree with @chalasr

gorshkov-ag

comment created time in 3 days

PR closed symfony/symfony

Update SymfonyStyle.php Status: Needs Review

Add comment for some function.

+7 -7

1 comment

1 changed file

DurandSacha

pr closed time in 3 days

pull request commentsymfony/symfony

[Validator] Add the Color constraint and validator

The more I read about this one, the more I think that this should not belong to core. Of we really want it, let’s stay focus on the initial use case and name it accordingly to avoid confusion and tons of follow up PRs trying to support more formats.

fancyweb

comment created time in 4 days

Pull request review commentsymfony/symfony

[Notifier] added Sinch texter transport

+<?php++/*+ * This file is part of the Symfony package.+ *+ * (c) Fabien Potencier <fabien@symfony.com>+ *+ * For the full copyright and license information, please view the LICENSE+ * file that was distributed with this source code.+ */++namespace Symfony\Component\Notifier\Bridge\Sinch;++use Symfony\Component\Notifier\Exception\UnsupportedSchemeException;+use Symfony\Component\Notifier\Transport\AbstractTransportFactory;+use Symfony\Component\Notifier\Transport\Dsn;+use Symfony\Component\Notifier\Transport\TransportInterface;++/**+ * @author Iliya Miroslavov Iliev <i.miroslavov@gmail.com>+ *+ * @experimental in 5.0

We are going to keep it experimental in 5.1.

imiroslavov

comment created time in 5 days

PR closed symfony/symfony

[DependencyInjection][Container.php]Modify Doc and remove unnecessary aliases DependencyInjection Status: Needs Review
Q A
Branch? master
Bug fix? no
New feature? no <!-- please update src/**/CHANGELOG.md files -->
Deprecations? no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
Tickets -
License MIT
Doc PR -

I thought that Doc was a little short, so I added it. In addition, I removed some aliases that thought were not used. I'm sorry if I made any mistakes.

+16 -5

1 comment

1 changed file

souweb22

pr closed time in 5 days

pull request commentsymfony/symfony

[DependencyInjection][Container.php]Modify Doc and remove unnecessary aliases

Thank you for your PR. Unfortunately, I'm going to close it. We never add phpdocs that do not add anything that is not already part of the method signature.

souweb22

comment created time in 5 days

pull request commentsymfony/symfony

[Form] Add label_html attribute

It looks like this PR contains not related commits. Can you rebase and force push?

przemyslaw-bogusz

comment created time in 5 days

PR merged symfony/symfony

[HttpKernel] Set previous exception when rethrown from controller resolver HttpKernel Status: Reviewed
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
License MIT

If an \InvalidArgumentException is catched by ControllerResolver a new one is thrown. The old exception is not added as previous parameter on the new one so it is not visible on the exception page. This pull request adds old exception as previous on the new one, so it is also visible on the exception page.

Thank you.

+1 -1

1 comment

1 changed file

danut007ro

pr closed time in 5 days

push eventsymfony/symfony

Daniel Gorgan

commit sha 87d51c1e4bb3f121b86355df846c6abb8f004b85

Set previous exception when rethrown from controller resolver

view details

Fabien Potencier

commit sha 1a51d34d8cc49afa5cbbcae517d590b19594cdaa

bug #35722 [HttpKernel] Set previous exception when rethrown from controller resolver (danut007ro) This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead. Discussion ---------- [HttpKernel] Set previous exception when rethrown from controller resolver | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT If an `\InvalidArgumentException` is catched by ControllerResolver a new one is thrown. The old exception is not added as `previous` parameter on the new one so it is not visible on the exception page. This pull request adds old exception as previous on the new one, so it is also visible on the exception page. Thank you. Commits ------- 87d51c1e4b Set previous exception when rethrown from controller resolver

view details

push time in 5 days

pull request commentsymfony/symfony

[HttpKernel] Set previous exception when rethrown from controller resolver

Thank you @danut007ro.

danut007ro

comment created time in 5 days

push eventdanut007ro/symfony

Nicolas Grekas

commit sha 3f995ac602d42ef036491e43157239ccb0ec351d

[HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI

view details

Fabien Potencier

commit sha 926e19ce32a67f2c10a3cfc8297bb4f5e54237ad

bug #35718 [HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | https://github.com/symfony/symfony/issues/35579#issuecomment-581653196 | License | MIT | Doc PR | - Commits ------- 3f995ac602 [HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI

view details

Daniel Gorgan

commit sha 87d51c1e4bb3f121b86355df846c6abb8f004b85

Set previous exception when rethrown from controller resolver

view details

push time in 5 days

PR merged symfony/symfony

Fixes typo in error message. Bug Status: Reviewed TwigBridge
Q A
Branch? 5.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets ---
License MIT
Doc PR ---

Fixes a minor typo where the error message refers to the wrong argument.

+1 -1

1 comment

1 changed file

dbrumann

pr closed time in 5 days

push eventsymfony/symfony

Denis Brumann

commit sha 8f2fbf6e2c52f794c8c7178bd6cf90fd9f075f51

Fixes typo in error message.

view details

Fabien Potencier

commit sha 12f1c7c4a3386e2aec04929b74755662a225e515

minor #35713 Fixes typo in error message. (dbrumann) This PR was merged into the 4.4 branch. Discussion ---------- Fixes typo in error message. | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Fixes a minor typo where the error message refers to the wrong argument. Commits ------- 8f2fbf6e2c Fixes typo in error message.

view details

push time in 5 days

pull request commentsymfony/symfony

Fixes typo in error message.

Thank you @dbrumann.

dbrumann

comment created time in 5 days

PR merged symfony/symfony

[HttpClient] Correctly remove trace level options for HttpCache Bug Status: Reviewed
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

The HttpCache component allows to configure a trace level. Due to the behavior of CachingHttpClient, options that are meant for the HttpCache must be unset before preparing the request. Currently these options can't be set, because HttpClient errors with invalid configuration options.

+2 -0

1 comment

1 changed file

aschempp

pr closed time in 5 days

push eventsymfony/symfony

Andreas Schempp

commit sha 618cd80b0d9106472e6ee746fe1580c2f1161686

Correctly remove trace level options for HttpCache

view details

Fabien Potencier

commit sha f4e9293734aa5f9c787042868b6f347eb49794f5

bug #35714 [HttpClient] Correctly remove trace level options for HttpCache (aschempp) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Correctly remove trace level options for HttpCache | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - The `HttpCache` component allows to [configure a trace level](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php#L46). Due to the behavior of `CachingHttpClient`, options that are meant for the `HttpCache` must be unset before preparing the request. Currently these options can't be set, because `HttpClient` errors with invalid configuration options. Commits ------- 618cd80b0d Correctly remove trace level options for HttpCache

view details

push time in 5 days

pull request commentsymfony/symfony

[HttpClient] Correctly remove trace level options for HttpCache

Thank you @aschempp.

aschempp

comment created time in 5 days

PR merged symfony/symfony

[HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI Bug HttpKernel Status: Reviewed
Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets https://github.com/symfony/symfony/issues/35579#issuecomment-581653196
License MIT
Doc PR -
+4 -1

1 comment

1 changed file

nicolas-grekas

pr closed time in 5 days

push eventsymfony/symfony

Nicolas Grekas

commit sha 3f995ac602d42ef036491e43157239ccb0ec351d

[HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI

view details

Fabien Potencier

commit sha 926e19ce32a67f2c10a3cfc8297bb4f5e54237ad

bug #35718 [HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | https://github.com/symfony/symfony/issues/35579#issuecomment-581653196 | License | MIT | Doc PR | - Commits ------- 3f995ac602 [HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI

view details

push time in 5 days

pull request commentsymfony/symfony

[HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI

Thank you @nicolas-grekas.

nicolas-grekas

comment created time in 5 days

PR merged symfony/symfony

Add missing autoload calls Bug Status: Reviewed

Until either php 7.4 or doctrine/persistence 2 is required, these will be needed to make sure php recognises signatures using the old names as compatible with signatures using the new names. This is necessary for types defined outside Symfony that extend types from Symfony and still use the old names in signatures of methods they override.

Fixes https://github.com/doctrine/DoctrineMongoDBBundle/issues/616

Q A
Branch? 4.3
Bug fix? yes
New feature? no <!-- please update src/**/CHANGELOG.md files -->
Deprecations? no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
Tickets Fix https://github.com/doctrine/DoctrineMongoDBBundle/issues/616
License MIT
Doc PR n/a

<!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):

  • Always add tests and ensure they pass.
  • Never break backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.)
  • Features and deprecations must be submitted against branch master. --> This topic is fairly complicated, more details at https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf
+7 -0

3 comments

3 changed files

greg0ire

pr closed time in 5 days

push eventsymfony/symfony

Grégoire Paris

commit sha 94b5dbde5abe914b3d7c132b9aad6d4a1353552b

Add missing autoload calls Until either php 7.4 or doctrine/persistence 2 is required, these will be needed to make sure php recognises signatures using the old names as compatible with signatures using the new names. This is necessary for types defined outside Symfony that extend types from Symfony and still use the old names in signatures of methods they override. More details at https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf Fixes https://github.com/doctrine/DoctrineMongoDBBundle/issues/616

view details

Fabien Potencier

commit sha 9697e9d24113dc6d507c6bf3c63c3a51cb76ddd9

bug #35728 Add missing autoload calls (greg0ire) This PR was merged into the 4.4 branch. Discussion ---------- Add missing autoload calls Until either php 7.4 or doctrine/persistence 2 is required, these will be needed to make sure php recognises signatures using the old names as compatible with signatures using the new names. This is necessary for types defined outside Symfony that extend types from Symfony and still use the old names in signatures of methods they override. Fixes https://github.com/doctrine/DoctrineMongoDBBundle/issues/616 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix https://github.com/doctrine/DoctrineMongoDBBundle/issues/616 | License | MIT | Doc PR | n/a <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> This topic is fairly complicated, more details at https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf Commits ------- 94b5dbde5a Add missing autoload calls

view details

push time in 5 days

pull request commentsymfony/symfony

Add missing autoload calls

Thank you @greg0ire.

greg0ire

comment created time in 5 days

pull request commentsymfony/symfony

[Validator] Add the Color constraint and validator

Based on the discussion, we should either not merge it if we want a universal validator or merge it with only what the input supports. In that second case, we should make it very clear that this is the only supported use case.

fancyweb

comment created time in 5 days

push eventtwigphp/Twig

Abdouni Abdelkarim

commit sha e030bf6e38190edcfbb9090c3ca51304e113b62b

Update advanced.rst Hello, I just updated the class name 😉

view details

Fabien Potencier

commit sha 225ecdb1c886ad726642ded8494be180cc3e030f

minor #3267 Update advanced.rst (abdounikarim) This PR was submitted for the 3.x branch but it was merged into the 1.x branch instead. Discussion ---------- Update advanced.rst Hello, I just updated the class name 😉 Commits ------- e030bf6e Update advanced.rst

view details

Nicolas Grekas

commit sha 85cb7fd0cef6c7c57f3f5c14738a605085f31f58

Fix format of the CHANGELOG

view details

Fabien Potencier

commit sha 1325da4c850a90ea2250dda10523fb47a056d437

minor #3269 Fix format of the CHANGELOG (nicolas-grekas) This PR was merged into the 1.x branch. Discussion ---------- Fix format of the CHANGELOG Change to be applied to 2.x and 3.x when merging up of course. Commits ------- 85cb7fd0 Fix format of the CHANGELOG

view details

Fabien Potencier

commit sha 10e5015411717363363b7dacb30497154e65a67e

Merge branch '1.x' into 2.x * 1.x: Fix format of the CHANGELOG Update advanced.rst

view details

Fabien Potencier

commit sha d876bc45c9b4cd115585ec5e6fcf522611469f20

Fix CHANGELOG

view details

Fabien Potencier

commit sha 73f5ef259026a6b28f4a203ec096f491c8a94787

Fix CHANGELOG

view details

push time in 5 days

push eventtwigphp/Twig

Abdouni Abdelkarim

commit sha e030bf6e38190edcfbb9090c3ca51304e113b62b

Update advanced.rst Hello, I just updated the class name 😉

view details

Fabien Potencier

commit sha 225ecdb1c886ad726642ded8494be180cc3e030f

minor #3267 Update advanced.rst (abdounikarim) This PR was submitted for the 3.x branch but it was merged into the 1.x branch instead. Discussion ---------- Update advanced.rst Hello, I just updated the class name 😉 Commits ------- e030bf6e Update advanced.rst

view details

Nicolas Grekas

commit sha 85cb7fd0cef6c7c57f3f5c14738a605085f31f58

Fix format of the CHANGELOG

view details

Fabien Potencier

commit sha 1325da4c850a90ea2250dda10523fb47a056d437

minor #3269 Fix format of the CHANGELOG (nicolas-grekas) This PR was merged into the 1.x branch. Discussion ---------- Fix format of the CHANGELOG Change to be applied to 2.x and 3.x when merging up of course. Commits ------- 85cb7fd0 Fix format of the CHANGELOG

view details

Fabien Potencier

commit sha 10e5015411717363363b7dacb30497154e65a67e

Merge branch '1.x' into 2.x * 1.x: Fix format of the CHANGELOG Update advanced.rst

view details

Fabien Potencier

commit sha d876bc45c9b4cd115585ec5e6fcf522611469f20

Fix CHANGELOG

view details

push time in 5 days

PR merged twigphp/Twig

Fix format of the CHANGELOG

Change to be applied to 2.x and 3.x when merging up of course.

+133 -133

1 comment

1 changed file

nicolas-grekas

pr closed time in 5 days

push eventtwigphp/Twig

Nicolas Grekas

commit sha 85cb7fd0cef6c7c57f3f5c14738a605085f31f58

Fix format of the CHANGELOG

view details

Fabien Potencier

commit sha 1325da4c850a90ea2250dda10523fb47a056d437

minor #3269 Fix format of the CHANGELOG (nicolas-grekas) This PR was merged into the 1.x branch. Discussion ---------- Fix format of the CHANGELOG Change to be applied to 2.x and 3.x when merging up of course. Commits ------- 85cb7fd0 Fix format of the CHANGELOG

view details

push time in 5 days

pull request commenttwigphp/Twig

Fix format of the CHANGELOG

Thank you @nicolas-grekas.

nicolas-grekas

comment created time in 5 days

Pull request review commentsymfony/symfony

time ( void ) : int

 private function calculateTimeDelta(): int          $serverTimestamp = (int) (string) $response->getContent();

Can also remove these casts? There are not needed (maybe there are other ones to remove).

cbastienbaron

comment created time in 6 days

issue closedsymfony/symfony

Unable to enable/disable security using environment variable

Symfony version(s) affected: v4.4.4 Symfony Security Bundle(s) affected: v4.2.12

Description
I would like to enable or disable symfony security by using environment variables. In order to do that, my current approach is as follows:

security:
  firewalls:
    api:
      security: '%env(bool:ENABLE_AUTH)%'
      stateless: true
      guard:
        authenticators:
          - App\Application\Security\Guard\OAuth2Authenticator
  access_control:
    - { path: ^/check, roles: IS_AUTHENTICATED_ANONYMOUSLY }
    - { path: ^/, roles: IS_AUTHENTICATED_FULLY }

How to reproduce
Simply use the configuration above and create ENABLE_AUTH variable.

Additional context

If I use false directly, it works fine.

Thanks!

closed time in 6 days

nursultanturdaliev

issue commentsymfony/symfony

Unable to enable/disable security using environment variable

That's not supported and cannot be. Env vars should only be used for something that needs to be changed dynamically without redeploying an app.

nursultanturdaliev

comment created time in 6 days

push eventsymfony/symfony

Success Go

commit sha 5888566a89c71aeab8577807fd4d0bf436b2d07a

[HttpKernel] Fix method name in doc comments

view details

Fabien Potencier

commit sha fb14669c087c8914f70b5bb183c45e6f2945f57c

minor #35687 [HttpKernel] Fix method name in doc comments (successgo) This PR was merged into the 5.0 branch. Discussion ---------- [HttpKernel] Fix method name in doc comments | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #35686 <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> Commits ------- 5888566a89 [HttpKernel] Fix method name in doc comments

view details

Robin Chalas

commit sha 707c5bade0dd7220b6d7e03dd7e27d66840edeb0

[Console] Don't load same-namespace alternatives on exact match found

view details

Massimiliano Arione

commit sha 1c8fbe1cf9d5898094c3f88e582b37d6d4eaede4

fix links to releases page (formerly known as "roadmap")

view details

Fabien Potencier

commit sha 7f92a165de647f4bc325ee4c55af21715c1223c4

minor #35703 fix links to releases page (formerly known as "roadmap") (garak) This PR was merged into the 3.4 branch. Discussion ---------- fix links to releases page (formerly known as "roadmap") | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | kind of | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none Current releases page is https://symfony.com/releases Formerly it was https://symfony.com/roadmap and there's a nice redirect to new URL. Anyway, I think that pointing to the right new URL would be better Commits ------- 1c8fbe1cf9 fix links to releases page (formerly known as "roadmap")

view details

Fabien Potencier

commit sha 648d488bb2685e5f7a1476a06608b80c86ef0cf5

bug #35696 [Console] Don't load same-namespace alternatives on exact match (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Don't load same-namespace alternatives on exact match | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35479 | License | MIT | Doc PR | - <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> Commits ------- 707c5bade0 [Console] Don't load same-namespace alternatives on exact match found

view details

Massimiliano Arione

commit sha 5825e3c58c1b047606ea4c8526b7d93ded2f9a4e

fix anchor

view details

Fabien Potencier

commit sha fb743a545f7fd2b3fbd6662dda1e6ec6c1536d4c

minor #35705 fix anchor (garak) This PR was merged into the 3.4 branch. Discussion ---------- fix anchor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none This is a continuation of PR #35703 that was merged a bit too early. It accepts suggestion made there and, moreover, fixes anchor link (that changed from old roadmap page) Commits ------- 5825e3c58c fix anchor

view details

Christian Flothmann

commit sha e1713862997b29dd91f7203da0db6d4ef38355d6

sync validator translation files with master

view details

Fabien Potencier

commit sha f20b36e3de3a5b58d54910c75f7a0e7aa4dc4b43

minor #35712 [Validator] sync translation files with master (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] sync translation files with master | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- e171386299 sync validator translation files with master

view details

Christopher Hertel

commit sha 9e431038b204c6ebe53b2d628c0df52df086bd4a

fix unix root dir issue

view details

Fabien Potencier

commit sha f6f6a600a883e29229049bf01b31edc1c055c8c4

bug #35693 [Finder] Fix unix root dir issue (chr-hertel) This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead. Discussion ---------- [Finder] Fix unix root dir issue | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35683 | License | MIT not quite sure about this one :thinking: Commits ------- 9e431038b2 fix unix root dir issue

view details

Fabien Potencier

commit sha 7a6e3c07b338d7d24322c94646922382daf7da97

Merge branch '3.4' into 4.4 * 3.4: fix unix root dir issue sync validator translation files with master fix anchor fix links to releases page (formerly known as "roadmap") [Console] Don't load same-namespace alternatives on exact match found

view details

Fabien Potencier

commit sha 05f71d3fd575062be3e5cbd7000a2666f4e1a247

Merge branch '4.4' into 5.0 * 4.4: fix unix root dir issue sync validator translation files with master [HttpFoundation] fix not sending Content-Type header for 204 responses [ErrorHandler] silence warning when zend.assertions=-1 fix anchor [Console] Handle zero row count in appendRow() for Table fix links to releases page (formerly known as "roadmap") [Console] Don't load same-namespace alternatives on exact match found

view details

Fabien Potencier

commit sha 4c1ca329a440fbf98ac90208a79292606d4cd92c

Merge branch '5.0' * 5.0: fix unix root dir issue sync validator translation files with master fix anchor fix links to releases page (formerly known as "roadmap") [Console] Don't load same-namespace alternatives on exact match found [HttpKernel] Fix method name in doc comments

view details

push time in 6 days

push eventsymfony/symfony

Robin Chalas

commit sha 707c5bade0dd7220b6d7e03dd7e27d66840edeb0

[Console] Don't load same-namespace alternatives on exact match found

view details

Massimiliano Arione

commit sha 1c8fbe1cf9d5898094c3f88e582b37d6d4eaede4

fix links to releases page (formerly known as "roadmap")

view details

Fabien Potencier

commit sha 7f92a165de647f4bc325ee4c55af21715c1223c4

minor #35703 fix links to releases page (formerly known as "roadmap") (garak) This PR was merged into the 3.4 branch. Discussion ---------- fix links to releases page (formerly known as "roadmap") | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | kind of | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none Current releases page is https://symfony.com/releases Formerly it was https://symfony.com/roadmap and there's a nice redirect to new URL. Anyway, I think that pointing to the right new URL would be better Commits ------- 1c8fbe1cf9 fix links to releases page (formerly known as "roadmap")

view details

Fabien Potencier

commit sha 648d488bb2685e5f7a1476a06608b80c86ef0cf5

bug #35696 [Console] Don't load same-namespace alternatives on exact match (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Don't load same-namespace alternatives on exact match | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35479 | License | MIT | Doc PR | - <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> Commits ------- 707c5bade0 [Console] Don't load same-namespace alternatives on exact match found

view details

Adam Prickett

commit sha 9b382590ee719a3aeaad11a91a1ff666c0da1a3a

[Console] Handle zero row count in appendRow() for Table

view details

Fabien Potencier

commit sha e87b59971e1b761f1052e1ca135dd49ac1b0b17f

bug #35676 [Console] Handle zero row count in appendRow() for Table (Adam Prickett) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Console] Handle zero row count in appendRow() for Table | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a When a `Table` is created and rendered with no rows (headers only) and subsequently rows are added using `appendRow()`, the first call to `appendRow()` clears back one line too far., thus removing the last run This is caused by `calculateRowCount()` not accounting for the fact that the footer separator is also the header separator when no rows are present. This PR works around the issue by checking to ensure that at least 1 row exists before including the footer separator in the row count. ## Example Command: ```php <?php namespace App\Command; class TableTestCommand extends Command { // ... protected function execute(InputInterface $input, OutputInterface $output) { $output->writeln('My table'); $table = new Table($output->section()); $table->setHeaders(['Column', 'Another column']); $table->render(); $table->appendRow(['Value', 'Another Value']); $table->appendRow(['Value', 'Another Value']); } } ``` Before fix: ``` +--------+----------------+ | Column | Another column | +--------+----------------+ | Value | Another Value | | Value | Another Value | +--------+----------------+ ``` After fix: ``` My table +--------+----------------+ | Column | Another column | +--------+----------------+ | Value | Another Value | | Value | Another Value | +--------+----------------+ ``` Commits ------- 9b382590ee [Console] Handle zero row count in appendRow() for Table

view details

Massimiliano Arione

commit sha 5825e3c58c1b047606ea4c8526b7d93ded2f9a4e

fix anchor

view details

Fabien Potencier

commit sha fb743a545f7fd2b3fbd6662dda1e6ec6c1536d4c

minor #35705 fix anchor (garak) This PR was merged into the 3.4 branch. Discussion ---------- fix anchor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none This is a continuation of PR #35703 that was merged a bit too early. It accepts suggestion made there and, moreover, fixes anchor link (that changed from old roadmap page) Commits ------- 5825e3c58c fix anchor

view details

Nicolas Grekas

commit sha 67ef532f8cfbc2678fd7ea862e80d95725935897

[ErrorHandler] silence warning when zend.assertions=-1

view details

Tobias Schultze

commit sha 06f5a1113d3188e2abc43021ada4eb7bd82376ef

[HttpFoundation] fix not sending Content-Type header for 204 responses

view details

Christian Flothmann

commit sha e1713862997b29dd91f7203da0db6d4ef38355d6

sync validator translation files with master

view details

Fabien Potencier

commit sha f20b36e3de3a5b58d54910c75f7a0e7aa4dc4b43

minor #35712 [Validator] sync translation files with master (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] sync translation files with master | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- e171386299 sync validator translation files with master

view details

Fabien Potencier

commit sha a6773c115bd4d2581eb15ae286ec027d98db936d

bug #35710 [ErrorHandler] silence warning when zend.assertions=-1 (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] silence warning when zend.assertions=-1 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Reported at https://github.com/symfony/orm-pack/commit/1000287d032aaae70e74cdfb5c512cfb02c9abeb#commitcomment-37276894 Commits ------- 67ef532f8c [ErrorHandler] silence warning when zend.assertions=-1

view details

Fabien Potencier

commit sha 1a7e4ea74682077c82742f7de41379f317bedeb6

bug #35709 [HttpFoundation] fix not sending Content-Type header for 204 responses (Tobion) This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] fix not sending Content-Type header for 204 responses | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | | License | MIT | Doc PR | `$headers->remove('Content-Type')` did not actually work because PHP sends the Content-Type header based on the https://www.php.net/manual/en/ini.core.php#ini.default-mimetype ini setting anyway (which defaults to html). So we need to disable this ini for empty responses. Commits ------- 06f5a1113d [HttpFoundation] fix not sending Content-Type header for 204 responses

view details

Christopher Hertel

commit sha 9e431038b204c6ebe53b2d628c0df52df086bd4a

fix unix root dir issue

view details

Fabien Potencier

commit sha f6f6a600a883e29229049bf01b31edc1c055c8c4

bug #35693 [Finder] Fix unix root dir issue (chr-hertel) This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead. Discussion ---------- [Finder] Fix unix root dir issue | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35683 | License | MIT not quite sure about this one :thinking: Commits ------- 9e431038b2 fix unix root dir issue

view details

Fabien Potencier

commit sha 7a6e3c07b338d7d24322c94646922382daf7da97

Merge branch '3.4' into 4.4 * 3.4: fix unix root dir issue sync validator translation files with master fix anchor fix links to releases page (formerly known as "roadmap") [Console] Don't load same-namespace alternatives on exact match found

view details

Fabien Potencier

commit sha 05f71d3fd575062be3e5cbd7000a2666f4e1a247

Merge branch '4.4' into 5.0 * 4.4: fix unix root dir issue sync validator translation files with master [HttpFoundation] fix not sending Content-Type header for 204 responses [ErrorHandler] silence warning when zend.assertions=-1 fix anchor [Console] Handle zero row count in appendRow() for Table fix links to releases page (formerly known as "roadmap") [Console] Don't load same-namespace alternatives on exact match found

view details

push time in 6 days

push eventsymfony/symfony

Robin Chalas

commit sha 707c5bade0dd7220b6d7e03dd7e27d66840edeb0

[Console] Don't load same-namespace alternatives on exact match found

view details

Massimiliano Arione

commit sha 1c8fbe1cf9d5898094c3f88e582b37d6d4eaede4

fix links to releases page (formerly known as "roadmap")

view details

Fabien Potencier

commit sha 7f92a165de647f4bc325ee4c55af21715c1223c4

minor #35703 fix links to releases page (formerly known as "roadmap") (garak) This PR was merged into the 3.4 branch. Discussion ---------- fix links to releases page (formerly known as "roadmap") | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | kind of | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none Current releases page is https://symfony.com/releases Formerly it was https://symfony.com/roadmap and there's a nice redirect to new URL. Anyway, I think that pointing to the right new URL would be better Commits ------- 1c8fbe1cf9 fix links to releases page (formerly known as "roadmap")

view details

Fabien Potencier

commit sha 648d488bb2685e5f7a1476a06608b80c86ef0cf5

bug #35696 [Console] Don't load same-namespace alternatives on exact match (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Don't load same-namespace alternatives on exact match | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35479 | License | MIT | Doc PR | - <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> Commits ------- 707c5bade0 [Console] Don't load same-namespace alternatives on exact match found

view details

Massimiliano Arione

commit sha 5825e3c58c1b047606ea4c8526b7d93ded2f9a4e

fix anchor

view details

Fabien Potencier

commit sha fb743a545f7fd2b3fbd6662dda1e6ec6c1536d4c

minor #35705 fix anchor (garak) This PR was merged into the 3.4 branch. Discussion ---------- fix anchor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none This is a continuation of PR #35703 that was merged a bit too early. It accepts suggestion made there and, moreover, fixes anchor link (that changed from old roadmap page) Commits ------- 5825e3c58c fix anchor

view details

Christian Flothmann

commit sha e1713862997b29dd91f7203da0db6d4ef38355d6

sync validator translation files with master

view details

Fabien Potencier

commit sha f20b36e3de3a5b58d54910c75f7a0e7aa4dc4b43

minor #35712 [Validator] sync translation files with master (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] sync translation files with master | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- e171386299 sync validator translation files with master

view details

Christopher Hertel

commit sha 9e431038b204c6ebe53b2d628c0df52df086bd4a

fix unix root dir issue

view details

Fabien Potencier

commit sha f6f6a600a883e29229049bf01b31edc1c055c8c4

bug #35693 [Finder] Fix unix root dir issue (chr-hertel) This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead. Discussion ---------- [Finder] Fix unix root dir issue | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35683 | License | MIT not quite sure about this one :thinking: Commits ------- 9e431038b2 fix unix root dir issue

view details

Fabien Potencier

commit sha 7a6e3c07b338d7d24322c94646922382daf7da97

Merge branch '3.4' into 4.4 * 3.4: fix unix root dir issue sync validator translation files with master fix anchor fix links to releases page (formerly known as "roadmap") [Console] Don't load same-namespace alternatives on exact match found

view details

push time in 6 days

PR merged symfony/symfony

[Finder] Fix unix root dir issue Bug Finder Status: Reviewed
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35683
License MIT

not quite sure about this one :thinking:

+9 -1

1 comment

2 changed files

chr-hertel

pr closed time in 6 days

push eventsymfony/symfony

Christopher Hertel

commit sha 9e431038b204c6ebe53b2d628c0df52df086bd4a

fix unix root dir issue

view details

Fabien Potencier

commit sha f6f6a600a883e29229049bf01b31edc1c055c8c4

bug #35693 [Finder] Fix unix root dir issue (chr-hertel) This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead. Discussion ---------- [Finder] Fix unix root dir issue | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35683 | License | MIT not quite sure about this one :thinking: Commits ------- 9e431038b2 fix unix root dir issue

view details

push time in 6 days

pull request commentsymfony/symfony

[Finder] Fix unix root dir issue

Thank you @chr-hertel.

chr-hertel

comment created time in 6 days

push eventchr-hertel/symfony

Robin Chalas

commit sha 707c5bade0dd7220b6d7e03dd7e27d66840edeb0

[Console] Don't load same-namespace alternatives on exact match found

view details

Massimiliano Arione

commit sha 1c8fbe1cf9d5898094c3f88e582b37d6d4eaede4

fix links to releases page (formerly known as "roadmap")

view details

Fabien Potencier

commit sha 7f92a165de647f4bc325ee4c55af21715c1223c4

minor #35703 fix links to releases page (formerly known as "roadmap") (garak) This PR was merged into the 3.4 branch. Discussion ---------- fix links to releases page (formerly known as "roadmap") | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | kind of | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none Current releases page is https://symfony.com/releases Formerly it was https://symfony.com/roadmap and there's a nice redirect to new URL. Anyway, I think that pointing to the right new URL would be better Commits ------- 1c8fbe1cf9 fix links to releases page (formerly known as "roadmap")

view details

Fabien Potencier

commit sha 648d488bb2685e5f7a1476a06608b80c86ef0cf5

bug #35696 [Console] Don't load same-namespace alternatives on exact match (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Don't load same-namespace alternatives on exact match | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35479 | License | MIT | Doc PR | - <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> Commits ------- 707c5bade0 [Console] Don't load same-namespace alternatives on exact match found

view details

Massimiliano Arione

commit sha 5825e3c58c1b047606ea4c8526b7d93ded2f9a4e

fix anchor

view details

Fabien Potencier

commit sha fb743a545f7fd2b3fbd6662dda1e6ec6c1536d4c

minor #35705 fix anchor (garak) This PR was merged into the 3.4 branch. Discussion ---------- fix anchor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none This is a continuation of PR #35703 that was merged a bit too early. It accepts suggestion made there and, moreover, fixes anchor link (that changed from old roadmap page) Commits ------- 5825e3c58c fix anchor

view details

Christian Flothmann

commit sha e1713862997b29dd91f7203da0db6d4ef38355d6

sync validator translation files with master

view details

Fabien Potencier

commit sha f20b36e3de3a5b58d54910c75f7a0e7aa4dc4b43

minor #35712 [Validator] sync translation files with master (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] sync translation files with master | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- e171386299 sync validator translation files with master

view details

Christopher Hertel

commit sha 9e431038b204c6ebe53b2d628c0df52df086bd4a

fix unix root dir issue

view details

push time in 6 days

issue closedsymfony/symfony

[Finder] Unable to scan root in unix like systems.

Symfony version(s) affected: 5.0.4 and 4.4.4 and maybe others.

Description
When i use '/' or ['/'] as parametr in method Finder::in, got exception during iteration: Directory name must not be empty. In line 48 /vendor/symfony/finder/Iterator/RecursiveDirectoryIterator.php.

How to reproduce (code should works of unix like systems)

use Symfony\Component\Finder\Finder;

$finder = new Finder();
$finder->in('/');
foreach($finder as $item){
}

closed time in 6 days

xandros15

push eventsymfony/symfony

Adam Prickett

commit sha 9b382590ee719a3aeaad11a91a1ff666c0da1a3a

[Console] Handle zero row count in appendRow() for Table

view details

Fabien Potencier

commit sha e87b59971e1b761f1052e1ca135dd49ac1b0b17f

bug #35676 [Console] Handle zero row count in appendRow() for Table (Adam Prickett) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Console] Handle zero row count in appendRow() for Table | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a When a `Table` is created and rendered with no rows (headers only) and subsequently rows are added using `appendRow()`, the first call to `appendRow()` clears back one line too far., thus removing the last run This is caused by `calculateRowCount()` not accounting for the fact that the footer separator is also the header separator when no rows are present. This PR works around the issue by checking to ensure that at least 1 row exists before including the footer separator in the row count. ## Example Command: ```php <?php namespace App\Command; class TableTestCommand extends Command { // ... protected function execute(InputInterface $input, OutputInterface $output) { $output->writeln('My table'); $table = new Table($output->section()); $table->setHeaders(['Column', 'Another column']); $table->render(); $table->appendRow(['Value', 'Another Value']); $table->appendRow(['Value', 'Another Value']); } } ``` Before fix: ``` +--------+----------------+ | Column | Another column | +--------+----------------+ | Value | Another Value | | Value | Another Value | +--------+----------------+ ``` After fix: ``` My table +--------+----------------+ | Column | Another column | +--------+----------------+ | Value | Another Value | | Value | Another Value | +--------+----------------+ ``` Commits ------- 9b382590ee [Console] Handle zero row count in appendRow() for Table

view details

Nicolas Grekas

commit sha 67ef532f8cfbc2678fd7ea862e80d95725935897

[ErrorHandler] silence warning when zend.assertions=-1

view details

Tobias Schultze

commit sha 06f5a1113d3188e2abc43021ada4eb7bd82376ef

[HttpFoundation] fix not sending Content-Type header for 204 responses

view details

Fabien Potencier

commit sha a6773c115bd4d2581eb15ae286ec027d98db936d

bug #35710 [ErrorHandler] silence warning when zend.assertions=-1 (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] silence warning when zend.assertions=-1 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Reported at https://github.com/symfony/orm-pack/commit/1000287d032aaae70e74cdfb5c512cfb02c9abeb#commitcomment-37276894 Commits ------- 67ef532f8c [ErrorHandler] silence warning when zend.assertions=-1

view details

Fabien Potencier

commit sha 1a7e4ea74682077c82742f7de41379f317bedeb6

bug #35709 [HttpFoundation] fix not sending Content-Type header for 204 responses (Tobion) This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] fix not sending Content-Type header for 204 responses | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | | License | MIT | Doc PR | `$headers->remove('Content-Type')` did not actually work because PHP sends the Content-Type header based on the https://www.php.net/manual/en/ini.core.php#ini.default-mimetype ini setting anyway (which defaults to html). So we need to disable this ini for empty responses. Commits ------- 06f5a1113d [HttpFoundation] fix not sending Content-Type header for 204 responses

view details

Fabien Potencier

commit sha c09128cf9f715a2b04e2b1132ee66a7303c18868

Merge branch '4.4' * 4.4: [HttpFoundation] fix not sending Content-Type header for 204 responses [ErrorHandler] silence warning when zend.assertions=-1 [Console] Handle zero row count in appendRow() for Table

view details

push time in 6 days

PR merged symfony/symfony

[symfony/contracts] Reference one main CHANGELOG in each contracts Status: Reviewed
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Reverts #35663 This PR makes it easier to publish the changelog for the contracts: there is only one to reference. We also need a changelog for symfony/contracts and this PR fixes this concern.

+31 -32

1 comment

7 changed files

nicolas-grekas

pr closed time in 6 days

push eventsymfony/symfony

Nicolas Grekas

commit sha d6fa13bafdf8d5a10032c718dd059cef9ffe202f

[symfony/contracts] Reference one main CHANGELOG in each contracts

view details

Fabien Potencier

commit sha a603b14c21243d87d252d459e298aae5fbe22e3c

minor #35708 [symfony/contracts] Reference one main CHANGELOG in each contracts (nicolas-grekas) This PR was squashed before being merged into the 5.1-dev branch. Discussion ---------- [symfony/contracts] Reference one main CHANGELOG in each contracts | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Reverts #35663 This PR makes it easier to publish the changelog for the contracts: there is only one to reference. We also need a changelog for symfony/contracts and this PR fixes this concern. Commits ------- d6fa13bafd [symfony/contracts] Reference one main CHANGELOG in each contracts

view details

push time in 6 days

pull request commentsymfony/symfony

[symfony/contracts] Reference one main CHANGELOG in each contracts

Thank you @nicolas-grekas.

nicolas-grekas

comment created time in 6 days

push eventnicolas-grekas/symfony

Nicolas Grekas

commit sha d6fa13bafdf8d5a10032c718dd059cef9ffe202f

[symfony/contracts] Reference one main CHANGELOG in each contracts

view details

push time in 6 days

PR merged symfony/symfony

[HttpFoundation] fix not sending Content-Type header for 204 responses Bug HttpFoundation Status: Reviewed
Q A
Branch? 4.4
Bug fix? yes
New feature? no <!-- please update src/**/CHANGELOG.md files -->
Deprecations? no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
Tickets
License MIT
Doc PR

$headers->remove('Content-Type') did not actually work because PHP sends the Content-Type header based on the https://www.php.net/manual/en/ini.core.php#ini.default-mimetype ini setting anyway (which defaults to html). So we need to disable this ini for empty responses.

+5 -11

1 comment

2 changed files

Tobion

pr closed time in 6 days

push eventsymfony/symfony

Tobias Schultze

commit sha 06f5a1113d3188e2abc43021ada4eb7bd82376ef

[HttpFoundation] fix not sending Content-Type header for 204 responses

view details

Fabien Potencier

commit sha 1a7e4ea74682077c82742f7de41379f317bedeb6

bug #35709 [HttpFoundation] fix not sending Content-Type header for 204 responses (Tobion) This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] fix not sending Content-Type header for 204 responses | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | | License | MIT | Doc PR | `$headers->remove('Content-Type')` did not actually work because PHP sends the Content-Type header based on the https://www.php.net/manual/en/ini.core.php#ini.default-mimetype ini setting anyway (which defaults to html). So we need to disable this ini for empty responses. Commits ------- 06f5a1113d [HttpFoundation] fix not sending Content-Type header for 204 responses

view details

push time in 6 days

pull request commentsymfony/symfony

[HttpFoundation] fix not sending Content-Type header for 204 responses

Thank you @Tobion.

Tobion

comment created time in 6 days

Pull request review commentsymfony/symfony

[HttpFoundation] fix not sending Content-Type header for 204 responses

 public function prepare(Request $request)             $this->setContent(null);             $headers->remove('Content-Type');             $headers->remove('Content-Length');+            // prevent PHP from sending the Content-Type header based on default_mimetype+            ini_set('default_mimetype', '');

This should be merged in 3.4 as well, right?

Tobion

comment created time in 6 days

PR merged symfony/symfony

[ErrorHandler] silence warning when zend.assertions=-1 Bug ErrorHandler Status: Reviewed
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Reported at https://github.com/symfony/orm-pack/commit/1000287d032aaae70e74cdfb5c512cfb02c9abeb#commitcomment-37276894

+1 -1

3 comments

1 changed file

nicolas-grekas

pr closed time in 6 days

push eventsymfony/symfony

Nicolas Grekas

commit sha 67ef532f8cfbc2678fd7ea862e80d95725935897

[ErrorHandler] silence warning when zend.assertions=-1

view details

Fabien Potencier

commit sha a6773c115bd4d2581eb15ae286ec027d98db936d

bug #35710 [ErrorHandler] silence warning when zend.assertions=-1 (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] silence warning when zend.assertions=-1 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Reported at https://github.com/symfony/orm-pack/commit/1000287d032aaae70e74cdfb5c512cfb02c9abeb#commitcomment-37276894 Commits ------- 67ef532f8c [ErrorHandler] silence warning when zend.assertions=-1

view details

push time in 6 days

pull request commentsymfony/symfony

[ErrorHandler] silence warning when zend.assertions=-1

Thank you @nicolas-grekas.

nicolas-grekas

comment created time in 6 days

PR closed symfony/symfony

Update DoctrineTokenProvider.php Bug Deprecation Feature Status: Needs Review

this function can return a other function

Q A
Branch? master for features / 3.4, 4.4 or 5.0 for bug fixes <!-- see below -->
Bug fix? yes/no
New feature? yes/no <!-- please update src/**/CHANGELOG.md files -->
Deprecations? yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
Tickets Fix #... <!-- prefix each issue number with "Fix #", if any -->
License MIT
Doc PR symfony/symfony-docs#... <!-- required for new features -->

<!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):

  • Always add tests and ensure they pass.
  • Never break backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.)
  • Features and deprecations must be submitted against branch master. -->
+1 -1

1 comment

1 changed file

DurandSacha

pr closed time in 6 days

pull request commentsymfony/symfony

Update DoctrineTokenProvider.php

Looks wrong to me as it returns an instance of PersistentToken.

DurandSacha

comment created time in 6 days

PR merged swiftmailer/swiftmailer

Update messages.rst

Hello,

I just fixed a typo 😉

Q A
Bug fix? no
New feature? no
Doc update? yes
BC breaks? no
Deprecations? no
Fixed tickets no
License MIT
+1 -1

1 comment

1 changed file

abdounikarim

pr closed time in 6 days

push eventswiftmailer/swiftmailer

Abdouni Abdelkarim

commit sha a416bb6bc6c6c92f515c7e8fdfbca2522971c386

Update messages.rst Hello, I just fixed a typo 😉

view details

Fabien Potencier

commit sha 1276fbff7547a729215029eba28a6a9c935a075b

minor #1254 Update messages.rst (abdounikarim) This PR was merged into the 6.3-dev branch. Discussion ---------- Update messages.rst Hello, I just fixed a typo 😉 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Doc update? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | no | License | MIT Commits ------- a416bb6b Update messages.rst

view details

push time in 6 days

PR merged symfony/symfony

[Validator] sync translation files with master Status: Reviewed Validator
Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR
+16 -0

1 comment

4 changed files

xabbuh

pr closed time in 6 days

pull request commentswiftmailer/swiftmailer

Update messages.rst

Thank you @abdounikarim.

abdounikarim

comment created time in 6 days

push eventsymfony/symfony

Christian Flothmann

commit sha e1713862997b29dd91f7203da0db6d4ef38355d6

sync validator translation files with master

view details

Fabien Potencier

commit sha f20b36e3de3a5b58d54910c75f7a0e7aa4dc4b43

minor #35712 [Validator] sync translation files with master (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] sync translation files with master | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- e171386299 sync validator translation files with master

view details

push time in 6 days

pull request commentsymfony/symfony

[Validator] sync translation files with master

Thank you @xabbuh.

xabbuh

comment created time in 6 days

PR merged symfony/symfony

fix anchor Status: Reviewed
Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets none
License MIT
Doc PR none

This is a continuation of PR #35703 that was merged a bit too early. It accepts suggestion made there and, moreover, fixes anchor link (that changed from old roadmap page)

+1 -1

1 comment

1 changed file

garak

pr closed time in 6 days

push eventsymfony/symfony

Massimiliano Arione

commit sha 5825e3c58c1b047606ea4c8526b7d93ded2f9a4e

fix anchor

view details

Fabien Potencier

commit sha fb743a545f7fd2b3fbd6662dda1e6ec6c1536d4c

minor #35705 fix anchor (garak) This PR was merged into the 3.4 branch. Discussion ---------- fix anchor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none This is a continuation of PR #35703 that was merged a bit too early. It accepts suggestion made there and, moreover, fixes anchor link (that changed from old roadmap page) Commits ------- 5825e3c58c fix anchor

view details

push time in 6 days

pull request commentsymfony/symfony

fix anchor

Thank you @garak.

garak

comment created time in 6 days

delete branch fabpot/symfony

delete branch : package-name-fix

delete time in 6 days

PR merged symfony/symfony

Fix package names Bug Status: Reviewed
Q A
Branch? master
Bug fix? yes
New feature? no <!-- please update src/**/CHANGELOG.md files -->
Deprecations? no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
Tickets n/a <!-- prefix each issue number with "Fix #", if any -->
License MIT
Doc PR n/a <!-- required for new features -->

Consistency fix.

+2 -2

0 comment

2 changed files

fabpot

pr closed time in 6 days

push eventsymfony/symfony

Fabien Potencier

commit sha 5b1e3ddda98d6aa1c8a0a922c74c482b644204f6

Fix package names

view details

Fabien Potencier

commit sha 657b8ec872f5a4fce56f81451e0cd8fea0e20b30

bug #35706 Fix package names (fabpot) This PR was merged into the 5.1-dev branch. Discussion ---------- Fix package names | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | n/a <!-- required for new features --> Consistency fix. Commits ------- 5b1e3ddda9 Fix package names

view details

push time in 6 days

more