profile
viewpoint
Lachezar Lechev elpiel @AdExNetwork Earth, Solar System, The Milky Way https://keybase.io/elpiel Lachezar Petrov Lechev, Rustacean by

AeroRust/arsdk-rs 6

Arsdk-rs - SDK for https://parrot.com #drones 🛩️

AdExNetwork/adex-validator-stack-rust 3

AdEx validator stack reference implementation: sentry, validator worker

elpiel/bignum 1

BigNum - divisibility & arbitrary precision

elpiel/bitify 1

Bit protocol parsing crate

elpiel/docker-symfony 1

:whale: A docker multicontainer with NGINX, PHP7-FPM, MySQL, Redis and ELK (Elasticsearch Logstash and Kibana)

AdExNetwork/adex-supermarket 0

Rust implementation of the AdEx Supermarket

elpiel/adex-merkle-tree 0

Testing how ot impl MerkleTree for AdEx

elpiel/adex-validator 0

Assignment for implementing AdEx Network (www.adex.network) get_health and is_valid_transition validations

elpiel/adex-validator-stack-rust 0

AdEx validator stack reference implementation: sentry, validator worker https://www.adex.network

elpiel/afloat 0

Arbitrary precision Floating points with fixed precision

PullRequestReviewEvent

pull request commentcloudevents/sdk-rust

Making core no_std compatible

For what I've checked, snafu has it's own trait Error that it's implemented in no_std. Since thiserror doesn't have no_std support I would say to just leave snafu for now (if it ain't broken, don't fix it).

pranav-bhatt

comment created time in 2 days

push eventAdExNetwork/adex-protocol

Lachezar Lechev

commit sha b0985ee0c1b1e64ac229191ded13d9184a27b58a

validator-stack - field names to camelCase

view details

push time in 2 days

pull request commentcloudevents/sdk-rust

Replace snafu with thiserror

Should be done.

elpiel

comment created time in 2 days

push eventelpiel/sdk-rust

Francesco Guardiani

commit sha c4305e071380561671f4d88581c31d0678842aed

Modify data writer APIs on Event (#92) * Modify setters apis Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Cargo fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Switched into impls in from Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

view details

Francesco Guardiani

commit sha d1281e7feaf588f3b01b2782f8aff5327cd8c7e8

Align with C-COMMON-TRAITS criteria (#91) * Fix C-COMMON-TRAITS Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix C-COMMON-TRAITS Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

view details

Lachezar Lechev

commit sha c3e0b8ce8942ad857ebd38ad35ff502536872c5a

Issue #70 replace `snafu` with `thierror` Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>

view details

Lachezar Lechev

commit sha c1801187f527ae9f6af4294de420ab72846fb5b1

remove unnecessary `extern crate` from lib.rs Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>

view details

Lachezar Lechev

commit sha eba7ee9cb4c002034820cff9ee21bbdf14c43c0a

Error - add `#[from]` attr for the source of `Error::Other` Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>

view details

push time in 2 days

Pull request review commentcloudevents/sdk-rust

Replace snafu with thiserror

-use snafu::Snafu;+use thiserror::Error;  /// Represents an error during serialization/deserialization process-#[derive(Debug, Snafu)]+#[derive(Debug, Error)] pub enum Error {-    #[snafu(display("Wrong encoding"))]+    #[error("Wrong encoding")]     WrongEncoding {},-    #[snafu(display("{}", source))]-    #[snafu(context(false))]+    #[error(transparent)]     UnknownSpecVersion {+        #[from]         source: crate::event::UnknownSpecVersion,     },-    #[snafu(display("Unknown attribute in this spec version: {}", name))]+    #[error("Unknown attribute in this spec version: {name}")]     UnknownAttribute { name: String },-    #[snafu(display("Error while building the final event: {}", source))]-    #[snafu(context(false))]+    #[error("Error while building the final event: {source}")]     EventBuilderError {+        #[from]         source: crate::event::EventBuilderError,     },-    #[snafu(display("Error while parsing a time string: {}", source))]-    #[snafu(context(false))]-    ParseTimeError { source: chrono::ParseError },-    #[snafu(display("Error while parsing a url: {}", source))]-    #[snafu(context(false))]-    ParseUrlError { source: url::ParseError },-    #[snafu(display("Error while decoding base64: {}", source))]-    #[snafu(context(false))]-    Base64DecodingError { source: base64::DecodeError },-    #[snafu(display("Error while serializing/deserializing to json: {}", source))]-    #[snafu(context(false))]-    SerdeJsonError { source: serde_json::Error },-    #[snafu(display("IO Error: {}", source))]-    #[snafu(context(false))]-    IOError { source: std::io::Error },-    #[snafu(display("Other error: {}", source))]+    #[error("Error while parsing a time string: {source}")]+    ParseTimeError {+        #[from]+        source: chrono::ParseError,+    },+    #[error("Error while parsing a url: {source}")]+    ParseUrlError {+        #[from]+        source: url::ParseError,+    },+    #[error("Error while decoding base64: {source}")]+    Base64DecodingError {+        #[from]+        source: base64::DecodeError,+    },+    #[error("Error while serializing/deserializing to json: {source}")]+    SerdeJsonError {+        #[from]+        source: serde_json::Error,+    },+    #[error("IO Error: {source}")]+    IOError {+        #[from]+        source: std::io::Error,+    },+    #[error("Other error: {}", source)]     Other {         source: Box<dyn std::error::Error + Send + Sync>,

Not sure if it will work because of the dyn Error, also currently it's not used for transformation of any other error, but I can try and see if it will work

elpiel

comment created time in 2 days

PullRequestReviewEvent

push eventAdExNetwork/adex-protocol

Lachezar Lechev

commit sha e6da3ef2784f50bc1100cd18796b5b95e830d9c3

validator-stak - channe/:id/events-aggregates

view details

Lachezar Lechev

commit sha 126205318e574548f3b769025672073080d7e5c5

validator-stack - more API endpoints defined

view details

push time in 2 days

create barnchelpiel/arsdk-java-generated

branch : master

created branch time in 2 days

created repositoryelpiel/arsdk-java-generated

arsdk JAVA generated reference code

created time in 2 days

issue openedAeroRust/arsdk-rs

Protocol implementation for the SDK

The ArDrone Protocol

Implementation of the Protocol is hard and messy and this the reason this issue exist - to help and track the protocol implementation for the SDK Here are some resources and todos (work in progress) that need to be completed to have a fully capable SDK that understand the Protocol of the drones completely

Resources

  • BufferIDs: https://github.com/Parrot-Developers/arsdk-ng/blob/master/libarsdk/src/arsdk_transport_ids.h
  • SDK3 (official) C SDK - https://developer.parrot.com/docs/SDK3/#go-deeper must be built in order to have the reference Features to be able to track them down.
  • XML reference of all commands & values - https://github.com/Parrot-Developers/arsdk-xml
  • PyParrot (unofficial) Python SDK https://github.com/amymcgovern/pyparrot

TODOs:

  • [ ] ArDrone3 #20
    • [ ] #13 GPSState
    • [ ] .... TODO: Add the rest of the ArDrone3 commands
  • [ ] TODO: Add the rest of the Commands to the list

created time in 3 days

delete branch AdExNetwork/adex-supermarket

delete branch : improvements

delete time in 3 days

push eventAdExNetwork/adex-supermarket

Lachezar Lechev

commit sha ac56bfad1e83cc270cb23c4fc79eddbf81203a5a

Improvements on MarketApi & more logging & erorr handling in /units-for-slot

view details

Lachezar Lechev

commit sha b941f5c3eabb0a5700e4e00eb7a7b6edda166be8

Move MockCache

view details

Lachezar Lechev

commit sha e5e4a78a494633a2b80c4ffdee787b886927f1fd

Cache to Cache & Client + update primitives

view details

Lachezar Lechev

commit sha 5e8264d0c0b8d6ecd2e4fd49cefeb62ce26f9c1d

cache - ApiClient & MockClient

view details

Lachezar Lechev

commit sha ca659b469da0bfe401e41f5fb47e27be0afeb3ad

use ApiClient for lib & fix /units-for-slot tests

view details

Lachezar Lechev

commit sha 4852f0625ec27686fb78ede9a7ec237df5419d25

fix clippy

view details

Lachezar Lechev

commit sha 921a32c88a9bbfa4cc280a72cab51031f1997c39

Clean up comments

view details

Lachezar Lechev

commit sha b03f17c6f3be5ec2d3066d934f79da6298ce33ff

Merge pull request #27 from AdExNetwork/improvements Improvements on MarketApi, mocking Cache & more logging & erorr handling for /units-for-slot

view details

push time in 3 days

issue openedParrot-Developers/arsdk-xml

Documentation on the structure and options

I am working on a new SDK and I would like to understand how these xml files are used in the SDKs.

I am looking for ways to find all the available commands and reading the generated C SDK is not very helpful since it doesn't specify which command is related to which drone and if it's possible to send specific combinations of values.

Also on the developer website the SDK3 is in the section of previous version, is it obsolete?!

created time in 3 days

pull request commentcloudevents/sdk-rust

Replace snafu with thiserror

I'm also getting an unused import warning, maybe it's good to fix it as well?

warning: unused import: `attributes::AttributesIter`
  --> src/event/mod.rs:13:16
   |
13 | pub(crate) use attributes::AttributesIter;
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default
elpiel

comment created time in 3 days

push eventelpiel/sdk-rust

Lachezar Lechev

commit sha 3487d941b922908a81498c3fda51d9f76454c7c0

Issue #70 replace `snafu` with `thierror` Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>

view details

Lachezar Lechev

commit sha ab2008df980276c5d7b38db632ab04eda89e96c1

remove unnecessary `extern crate` from lib.rs Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>

view details

push time in 3 days

push eventelpiel/sdk-rust

Lachezar Lechev

commit sha bab60d38cabc61234ac619d5a5681220dbe43da4

Issue #70 replace `snafu` with `thierror`

view details

Lachezar Lechev

commit sha 245fa164d6cd693191c78571522cd3066a431ac9

remove unnecessary `extern crate` from lib.rs

view details

push time in 3 days

Pull request review commentcloudevents/sdk-rust

Replace snafu with thiserror

 //! * [cloudevents-sdk-reqwest](https://docs.rs/cloudevents-sdk-reqwest): Integration with [reqwest](https://github.com/seanmonstar/reqwest) //! -extern crate serde;

no need for extern crate in the 2018 edition

elpiel

comment created time in 3 days

Pull request review commentcloudevents/sdk-rust

Replace snafu with thiserror

-use snafu::Snafu;+use thiserror::Error;  /// Represents an error during serialization/deserialization process-#[derive(Debug, Snafu)]+#[derive(Debug, Error)] pub enum Error {-    #[snafu(display("Wrong encoding"))]+    #[error("Wrong encoding")]     WrongEncoding {},-    #[snafu(display("{}", source))]-    #[snafu(context(false))]+    #[error(transparent)]

this will handle the impl of Display to the underlying error.

elpiel

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened cloudevents/sdk-rust

Replace snafu with thiserror

Issue #70 From what I see the difference between the two is not that big. If no_std has more priority I would suggest to leave snafu for the time being.

+26 -44

0 comment

4 changed files

pr created time in 3 days

create barnchelpiel/sdk-rust

branch : replace-snafu-with-thiserror

created branch time in 3 days

fork elpiel/sdk-rust

Rust library to interact with CloudEvents

fork in 3 days

issue commentcloudevents/sdk-rust

Investigate usage of thiserror to replace snafu

If no one is working on this I want to pick it up for hacktoberfest. I have experience with thiserror and it shouldn't be that hard to replace snafu

slinkydeveloper

comment created time in 3 days

push eventAdExNetwork/adex-supermarket

Lachezar Lechev

commit sha 921a32c88a9bbfa4cc280a72cab51031f1997c39

Clean up comments

view details

push time in 3 days

PullRequestReviewEvent

pull request commentAdExNetwork/adex-validator-stack-rust

AIP#31 impl changes for all crates

ping @simzzz @samparsky Please review the PR and provide me with feedback on the remaining questions / tasks. NB: Some tasks were moved to the issues to unblock this PR

elpiel

comment created time in 4 days

Pull request review commentAdExNetwork/adex-validator-stack-rust

Issue 337 align channellist response

 pub async fn channel_list<A: Adapter>(         &query.creator,         &query.validator,         &query.valid_until_ge,+        query.page,

Another option is to return (total_pages, channels) since the db/channel is handling DB requests and then construct the response here.

let (total_pages, channels) = list_channels(...)...;

Ok(ChannelListResponse {
            total_pages,
            total: total_pages,
            page,
            channels,
})
simzzz

comment created time in 4 days

PullRequestReviewEvent

pull request commentteloxide/teloxide

add doc(cfg) attributes

No problem, my pleasure! Could you also add hacktoberfest-approved label?

elpiel

comment created time in 4 days

push eventAdExNetwork/adex-supermarket

Lachezar Lechev

commit sha 4852f0625ec27686fb78ede9a7ec237df5419d25

fix clippy

view details

push time in 4 days

push eventAdExNetwork/adex-supermarket

Lachezar Lechev

commit sha b941f5c3eabb0a5700e4e00eb7a7b6edda166be8

Move MockCache

view details

Lachezar Lechev

commit sha e5e4a78a494633a2b80c4ffdee787b886927f1fd

Cache to Cache & Client + update primitives

view details

Lachezar Lechev

commit sha 5e8264d0c0b8d6ecd2e4fd49cefeb62ce26f9c1d

cache - ApiClient & MockClient

view details

Lachezar Lechev

commit sha ca659b469da0bfe401e41f5fb47e27be0afeb3ad

use ApiClient for lib & fix /units-for-slot tests

view details

push time in 4 days

pull request commentteloxide/teloxide

add doc(cfg) attributes

Thanks! I think it's ready now.

elpiel

comment created time in 4 days

push eventelpiel/teloxide

Lachezar Lechev

commit sha 508f34148beb567e71b691dbe3ef205105834454

replace occurences of `docsrs` and add FIXME

view details

push time in 4 days

issue openedAdExNetwork/adex-validator-stack-rust

Re-think Targeting Input AIP#31

There is a problem with the current Input for targeting. This is that while Source can serialize with proper targeting::eval::Values, the Map (HashMap<String, targeting::input::Value>) can't since it's set by deserializing a Json value (serde_json::Value). This causes problems since using the Map as a base for e.g. adview-manager will result in loosing information about the values of the targeting input.

created time in 4 days

push eventelpiel/teloxide

Lachezar Lechev

commit sha 789f7f7c61167f83fafb78d1d98a867b4fd9f68c

replace most occurences of and add FIXME

view details

push time in 4 days

push eventelpiel/teloxide

Lachezar Lechev

commit sha 261b1869b5623af0cca32bc3026ba29fb0d6fecc

replace most occurences of `docsrs` and add FIXME

view details

push time in 4 days

push eventelpiel/teloxide

Lachezar Lechev

commit sha 656db8273bc498e29a10109b70b867824394d8f1

Update Cargo.toml docs.rs metadata Co-authored-by: Waffle Lapkin <waffle.lapkin@gmail.com>

view details

push time in 4 days

pull request commentteloxide/teloxide

add doc(cfg) attributes

@WaffleLapkin did you mean that I should change this docsrs to teloxide_docsrs or something else?

https://github.com/teloxide/teloxide/blob/43cdedb06a7ddbbf30208eb60fecdc7b12ddcdea/src/lib.rs#L48

docs.rs should(?!) build only this package and not all of the dependencies docs, this might be only a local issue right now?

elpiel

comment created time in 5 days

pull request commentteloxide/teloxide

add doc(cfg) attributes

(teloxide_docsrs) + leave a // FIXME(waffle): use `docsrs` here when issue with combine is resolved <https://github.com/teloxide/teloxide/pull/305#issuecomment-716172103>

Is this only for the comment or am I mistaken?

elpiel

comment created time in 5 days

push eventelpiel/teloxide

Lachezar Lechev

commit sha 43cdedb06a7ddbbf30208eb60fecdc7b12ddcdea

Readme "nightly" feature comment update

view details

push time in 5 days

Pull request review commentteloxide/teloxide

add doc(cfg) attributes

 )] #![allow(clippy::match_bool)] #![forbid(unsafe_code)]-#![cfg_attr(all(feature = "nightly", doctest), feature(external_doc))]-#![cfg_attr(all(docsrs, feature = "nightly"), feature(doc_cfg))]+// we pass "--cfg docsrs" when building docs to add `This is supported on feature="..." only.`+//+// To properly build docs of this crate run+// ```console+// $ RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --open --all-features+// ```+#![cfg_attr(all(docsrs, feature="nightly"), feature(external_doc, doc_cfg))]

:man_facepalming: stupid me... I though it says docsrs :sweat_smile:

elpiel

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventelpiel/teloxide

Lachezar Lechev

commit sha 1e0bb9324c5b796a0c21974ec44815c5c773b323

Readme "nightly" feature comment update

view details

push time in 5 days

push eventelpiel/teloxide

Lachezar Lechev

commit sha 9ae81ac978a0e8fc6181fd61fe584c2f14fbdba6

add doc(cfg) attributes

view details

push time in 5 days

PR opened teloxide/teloxide

add doc(cfg) attributes

I tried building the docs both with nightly and stable, however in both cases I get errors for underlying crates:

  1. nightly
RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --open --all-features
error[E0658]: `#[doc(cfg)]` is experimental
  --> /home/elpiel/.cargo/registry/src/github.com-1ecc6299db9ec823/combine-4.3.2/src/stream/mod.rs:51:20
   |
51 | #[cfg_attr(docsrs, doc(cfg(feature = "std")))]
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #43781 <https://github.com/rust-lang/rust/issues/43781> for more information
   = help: add `#![feature(doc_cfg)]` to the crate attributes to enable

error[E0658]: `#[doc(cfg)]` is experimental
  --> /home/elpiel/.cargo/registry/src/github.com-1ecc6299db9ec823/combine-4.3.2/src/stream/decoder.rs:49:20
   |
49 | #[cfg_attr(docsrs, doc(cfg(feature = "std")))]

.... and more
  1. stable
RUSTDOCFLAGS="--cfg docsrs" cargo doc --open --all-features

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /home/elpiel/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-io-0.3.7/src/lib.rs:29:21
   |
29 | #![cfg_attr(docsrs, feature(doc_cfg))]
+19 -3

0 comment

10 changed files

pr created time in 5 days

create barnchelpiel/teloxide

branch : doc-cfg-annotation-to-cfg-items

created branch time in 5 days

fork elpiel/teloxide

📮 An elegant Telegram bots framework for Rust

https://docs.rs/teloxide/

fork in 5 days

issue commentteloxide/teloxide

Add doc(cfg) annotations to cfg-ed items

I would like to pick this one up for hacktoberfest if no one is working on it

WaffleLapkin

comment created time in 5 days

startedEmbarkStudios/rust-gpu

started time in 7 days

push eventAdExNetwork/adex-validator-stack-rust

Lachezar Lechev

commit sha 72059fa07e7397e74a01d569350cd49532593505

primitives - supermarket - derive(PartialEq)

view details

push time in 7 days

create barnchAdExNetwork/adex-supermarket

branch : improvements

created branch time in 7 days

PR closed elpiel/photon

WIP CI actions
+253 -106

0 comment

23 changed files

elpiel

pr closed time in 8 days

pull request commentsilvia-odwyer/photon

Add CI with github & actions-rs

No worries and thanks as well! PS: It's time to put those sweet sweet build badge icons now :D Maybe a good first issue for newcomers :P

elpiel

comment created time in 8 days

pull request commentsilvia-odwyer/photon

Add CI with github & actions-rs

I did manage to break the wasm-pack build because I've removed some imports that clippy was complaining so I've added also a check for wasm32-unknown-unknown target.

Also here's proof that this now works: https://github.com/elpiel/photon/pull/1

Note: I had to clean up the benchmark file as well as there were unused imports and functions. Are they going to be used or they are obsolete?

elpiel

comment created time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha 2aeb410b040191ee763415802b5768af069562ee

fix & run rustfmt, fix clippy warnings, fix examples, remove travis.yml & ci for wasm32 check

view details

push time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha 642d09f377d9ced16d41bc0a2ce36168ba765ee1

fix & run rustfmt, fix clippy warnings, fix examples, remove travis.yml & ci for wasm32 check

view details

push time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha a3502041f6cb677927da2b517f680f6e68942c8e

fix & run rustfmt, fix clippy warnings, fix examples, remove travis.yml & ci for wasm32 check

view details

push time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha 3d440b1d61d8a533a9f33cdace8fdc36b2d25132

fix & run rustfmt, fix clippy warnings, fix examples, remove travis.yml & ci for wasm32 check

view details

push time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha 63f001c31e53c5ad9f10ae66b66f1a59dd2423f2

fix target to be wasm32 not toolchain

view details

push time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha ccd078cf831dc97e45ffa18f376ceadcbff4eb78

fix target to be wasm32 not toolchain

view details

push time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha 1d494d9229a073a5081dad0ce0c6a48ee65f63fc

fix & run rustfmt, fix clippy warnings, fix examples, remove travis.yml & ci for wasm-pack build

view details

push time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha 8442d97c34093ba3678d57053ddb61cc43af54c4

fix & run rustfmt, fix clippy warnings, fix examples, remove travis.yml & ci for wasm-pack build

view details

push time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha 78f119ecb0a9b62fd74b0b7032cd1fb3b65ac625

Fix wasm-pack build, add README.md

view details

push time in 8 days

pull request commentsilvia-odwyer/photon

Add CI with github & actions-rs

@silvia-odwyer could you enable the checks for the PRs and branches? I think this is why they don't show or run right now or it could be because I have no permissions to the repository, not really sure.

Screenshot_2020-10-22 AeroRust arsdk-rs

elpiel

comment created time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha c15a9f7a76a1249ec5652ab384047cb39d4d58fb

Add `thiserror` to Cargo.toml

view details

Lachezar Lechev

commit sha a8137942b1308bd4172d3bc779bc0a3295a5cf9f

native - Open & Save errors

view details

Lachezar Lechev

commit sha 5b9e4fbfc258bfafcc3ec1cd2e1eb92cffdd88f7

add no_run to all examples and tutorials

view details

Silvia O'Dwyer

commit sha 040ddd879dfd6923ae13b25d7c1e153be14433b7

Merge pull request #53 from elpiel/feature-request-panic-free-functions Feature request: panic-free functions

view details

push time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha c15a9f7a76a1249ec5652ab384047cb39d4d58fb

Add `thiserror` to Cargo.toml

view details

Lachezar Lechev

commit sha a8137942b1308bd4172d3bc779bc0a3295a5cf9f

native - Open & Save errors

view details

Lachezar Lechev

commit sha 5b9e4fbfc258bfafcc3ec1cd2e1eb92cffdd88f7

add no_run to all examples and tutorials

view details

Silvia O'Dwyer

commit sha 040ddd879dfd6923ae13b25d7c1e153be14433b7

Merge pull request #53 from elpiel/feature-request-panic-free-functions Feature request: panic-free functions

view details

Lachezar Lechev

commit sha 70e30d87d34f1a36385ae2b3de75d87ab570b1c6

Merge branch 'master' into add-ci

view details

Lachezar Lechev

commit sha 404e7932d9a3e79bd04cda04946b6d81693019a7

run rustfmt, fix clippy warnings, move rustfmt.toml, fix examples, remove travis.yml

view details

push time in 8 days

pull request commentsilvia-odwyer/photon

Feature request: panic-free functions

@silvia-odwyer could you also add the hacktoberfest-accepted label please? :blush:

elpiel

comment created time in 8 days

push eventelpiel/photon

Lachezar Lechev

commit sha 91bdfb245d6d7400cc80ba32627c49c2c2347098

run rustfmt & fix clippy errors

view details

push time in 8 days

push eventAdExNetwork/adex-protocol

Lachezar Lechev

commit sha 187352b731b960d02aa38d1cb6b68e122997e03c

More routes API documentation

view details

push time in 8 days

startediliekturtles/uom

started time in 8 days

Pull request review commentsilvia-odwyer/photon

Feature request: panic-free functions

  <div align="center"> -  [![Status](https://img.shields.io/badge/status-active-success.svg)]() +  [![Status](https://img.shields.io/badge/status-active-success.svg)]()   [![GitHub Issues](https://img.shields.io/github/issues/silvia-odwyer/photon.svg)](https://github.com/silvia-odwyer/photon/issues)   [![GitHub Pull Requests](https://img.shields.io/github/issues-pr/silvia-odwyer/photon.svg)](https://github.com/silvia-odwyer/photon/pulls)   [![Gitter chat](https://badges.gitter.im/silvia-odwyer/photon.png)](https://gitter.im/photonlibrary/community "Gitter chat")-  [![NPM Monthly Downloads](https://img.shields.io/npm/dm/@silvia-odwyer/photon.png)]() +  [![NPM Monthly Downloads](https://img.shields.io/npm/dm/@silvia-odwyer/photon.png)]()  </div>  ---  <p align="center"> High-performance, cross-platform Rust/WebAssembly image processing library-    <br> +    <br> </p>  ## 📝 Table of Contents - [Get Started with WebAssembly](https://github.com/silvia-odwyer/photon#get-started-with-webassembly)-- [Get Started Natively](https://github.com/silvia-odwyer/photon#getting-started)+- [Get Started Natively](https://github.com/silvia-odwyer/photon#get-started-natively)

Fixed this link since it was changed I some point I believe

elpiel

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened silvia-odwyer/photon

Add CI with github & actions-rs

It seems there is no CI integration and although there is no actual feature request I though I would add it and open a discussion for it.

The Cargo.toml for workspace is there because the actions run from the main directory for the repository and can't run within a sub-folder (as far as I looked into it)

Another consideration would be to commit the Cargo.lock file with the exact locked version of dependencies

+71 -0

0 comment

2 changed files

pr created time in 10 days

push eventelpiel/photon

Lachezar Lechev

commit sha 205f2c2336f2e08773f5d66f2a72bccccc9044d9

add Cargo.toml with workspace

view details

push time in 10 days

push eventelpiel/photon

Lachezar Lechev

commit sha bc78638ec68dc4249cb5a90eb1993ba548d2454e

WIP CI actions

view details

push time in 10 days

push eventelpiel/photon

Lachezar Lechev

commit sha 6fc737446102bbd69f2842e6e42011cab7c9894f

WIP CI actions

view details

push time in 10 days

push eventelpiel/photon

Lachezar Lechev

commit sha c9fcabfeafb603fda9672fde29e96534897f2fc8

WIP CI actions

view details

push time in 10 days

push eventelpiel/photon

Lachezar Lechev

commit sha 4a99ba732682178093668ec005ee315f9895aa94

WIP CI actions

view details

push time in 10 days

PR opened elpiel/photon

WIP CI actions
+66 -0

0 comment

1 changed file

pr created time in 10 days

create barnchelpiel/photon

branch : add-ci

created branch time in 10 days

push eventelpiel/photon

Lachezar Lechev

commit sha 5b9e4fbfc258bfafcc3ec1cd2e1eb92cffdd88f7

add no_run to all examples and tutorials

view details

push time in 10 days

push eventAdExNetwork/adex-validator-stack-rust

Lachezar Lechev

commit sha cb89066632dab057843e119bd95aa022972c77a2

derive Eq & PartialEq for primitives

view details

push time in 10 days

push eventAdExNetwork/adex-supermarket

Lachezar Lechev

commit sha 08e7e56e6e5c48f266a5819ddfdf6ed54243b14a

Cargo.lock - Updated `primitives`

view details

push time in 10 days

push eventAdExNetwork/adex-supermarket

Lachezar Lechev

commit sha ecaf0519f3e9545ff8c18122665c17744d4e43e7

fix panics and derive Debug for Market responses

view details

push time in 10 days

push eventAdExNetwork/adex-validator-stack-rust

Lachezar Lechev

commit sha a55636ee0f4c847da1c55f234913e27aeebf702a

primitives - targeting - eval - Value serialize to serde_json::Value

view details

push time in 10 days

push eventAdExNetwork/adex-supermarket

Lachezar Lechev

commit sha bc271c63eebb705874d7677f4f79ecbd13188ddb

Clean up and fix test for `/units-for-slot`

view details

push time in 10 days

push eventelpiel/serde-repr

Lachezar Lechev

commit sha d55a89e89b42d192641176693183dede88ab3912

WIP arbitrary enum discriminator

view details

push time in 10 days

issue commentdtolnay/serde-repr

Allow arbitrary enums

@lokegustafsson this is the exact thing we are looking to solve. I've opened a WIP PR and would love to get some help with how to implement this :sweat_smile:

RReverser

comment created time in 10 days

PR opened dtolnay/serde-repr

Arbitrary enum discriminator

Tries to resolve #6

I am definitely looking for feedback since macros are not my thing (yet).

+86 -31

0 comment

6 changed files

pr created time in 10 days

create barnchelpiel/serde-repr

branch : arbitrary-enums

created branch time in 10 days

pull request commentsilvia-odwyer/photon

Feature request: panic-free functions

@silvia-odwyer thanks for the quick reply. I just realized that if we were to open a real image we should probably use a hidden doc comment to load it from the specified examples/input_images/underground.jpg path. I.e. something like this:

/// use photon_rs::native::{save_image, open_image};
/// # let image_path = .... <-- Get the image path + Hidden from docs
/// // let image_path = "img.jpg"; <-- a Comment so that it will use the above `image_path`
/// let img = open_image(image_path).expect("File should open");
...

However if we do the same thing for save_image this will write a file on the filesystem which might not be preferable. How do you think to solve this?

I think the easiest way to mitigate both issues is to just use no_run attribute. This way the doc tests won't run and check the actual path, but it will compile and check the doc test code.

elpiel

comment created time in 10 days

startedanuraghazra/github-readme-stats

started time in 10 days

push eventelpiel/photon

Lachezar Lechev

commit sha a8137942b1308bd4172d3bc779bc0a3295a5cf9f

native - Open & Save errors

view details

push time in 11 days

more