ellbee ( Lee Bannard )

Improve paragraph about Relay DevTools in the Debugging docs, no longer mentioning that it ships in two ways, since it ships only as a Chrome extension.
Fix some ConnectionHandler utility descriptions.
Fix some code examples.
Fix some typos.
Add some missing backticks.

+21 -22

4 commit in kyarik/relay/tree/documentation-fixes-and-improvements facebook/relay/tree/master

0 comment

4 changed files

pr created time in 15 hours

issue commentfacebook/relay

[Feature request] Make the variables available to `optimisticUpdater` in mutations

I think closures is enough for this

andrehsu

comment created time in a day

issue openedfacebook/relay

[Feature request] Make the variables available to `optimisticUpdater` in mutations

Make the variables available to optimisticUpdater in mutations. Right now I have to use a workaround involving closures, but if the variables were passed to it then I wouldn't need to do that.

created time in a day

issue commentfacebook/relay

Internal Error: Unexpected extension kind: 'InputObjectTypeDefinition'

No I don’t have a local schema (if you mean for handling local state) it’s just that schema I sent you. Btw I also have apollo queries in this project could that be related?

Mo, Co-Founder of There

On January 16, 2021 at 5:02 PM, Lorenzo Di Giacomo ([email protected]) wrote: So are you using a input types on the client schema? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/facebook/relay/issues/3324#issuecomment-761563748 ), or unsubscribe ( https://github.com/notifications/unsubscribe-auth/ARDV2HRD3MKSNGDNXGETEBDS2GINDANCNFSM4WE5G72Q ).

momakes2

comment created time in 2 days

issue commentfacebook/relay

Internal Error: Unexpected extension kind: 'InputObjectTypeDefinition'

So are you using a input types on the client schema?

momakes2

comment created time in 2 days

issue commentfacebook/relay

Internal Error: Unexpected extension kind: 'InputObjectTypeDefinition'

You can use patch package as well

momakes2

comment created time in 2 days

issue commentfacebook/relay

Internal Error: Unexpected extension kind: 'InputObjectTypeDefinition'

@morrys Thanks. So the only solution is to wait until it gets merged I suppose?

momakes2

comment created time in 2 days

issue openedfacebook/relay

cacheConfig is always empty regardless of QueryRenderer props

my fetchQuery function:

function fetchQuery(
  operation,
  variables,
  cacheConfig,
) {
  const queryID = operation.text;
  const isMutation = operation.operationKind === 'mutation';
  const isQuery = operation.operationKind === 'query';
  const forceFetch = cacheConfig && cacheConfig.force;
  console.log(operation);
  console.log(variables);
  console.log(cacheConfig);

...
}

On each and every query I get an empty cacheConfig object regardless of what is set as cacheConfig prop to QueryRenderer (e.g. cacheConfig={{ force: this.state.ignoreCache }}).

created time in 2 days

issue commentfacebook/relay

Internal Error: Unexpected extension kind: 'InputObjectTypeDefinition'

hi @momakes2, your problem seems related to this: https://github.com/facebook/relay/pull/3221/files

momakes2

comment created time in 2 days

issue openedfacebook/relay

Internal Error: Unexpected extension kind: 'InputObjectTypeDefinition'

When building using the babel plugin, it fails with the error Module not found: Internal Error: Unexpected extension kind: 'InputObjectTypeDefinition'.

CleanShot 2021-01-16 at 06 51 48

I have only one graphql version in my yarn lock file:

  "resolutions": {
    "graphql": "^15.4.0"
  },

And here's the schema:

### This file was generated by Nexus Schema
### Do not make changes to this file directly

type Chat implements Node {
createdAt: DateTime
iconEmoji: String
id: GlobalID!
spaceId: GlobalID
title: String
}

input ChatsInput {
spaceId: GlobalID
}

"""
A date-time string at UTC, such as 2007-12-03T10:15:30Z, compliant with the `date-time` format outlined in section 5.6 of the RFC 3339 profile of the ISO 8601 standard for representation of dates and times using the Gregorian calendar.
"""
scalar DateTime

"""
A globally unique node id consisting of type:id
"""
scalar GlobalID

interface Node {
id: GlobalID!
}

type Query {
chats(input: ChatsInput): Chat
hello(name: String): String
}

type Subscription {
greetings: [String]
}

created time in 2 days

issue commentfacebook/relay

Data not fetched when using partial render policy in 10.1.0

@jstejada Hey! No worries, this is using [email protected] with react-native@baa824826dce30cc69767503291860ad63eb063c so that would be no concurrent mode I think.

janicduplessis

comment created time in 2 days

push eventfacebook/relay

Tianyu Yao

commit sha 211ac3662b4d61c8fc168090226d60b33ef3c40e

Show the content of watch man error Reviewed By: alunyov Differential Revision: D25931996 fbshipit-source-id: 008dd3261501511ea1a3f04f817ba5378767745b

view details

push time in 2 days

push eventfacebook/relay

Caleb Thomas

commit sha b322654fb56bca1106fe14cb8a62ac540b6345b0

add is_input_object() to schema::Type Reviewed By: ginfung Differential Revision: D25925646 fbshipit-source-id: 4441e95a918bd18a1949ca78ac9f9433d8c995e9

view details

push time in 2 days

pull request commentfacebook/relay

upgrade to tokio 1.0

This pull request was exported from Phabricator. Differential Revision: D25925160

kassens

comment created time in 2 days

PR opened facebook/relay

upgrade to tokio 1.0

Differential Revision: D25925160

+7 -7

1 commit in kassens/relay/tree/export-D25925160 facebook/relay/tree/master

0 comment

4 changed files

pr created time in 2 days

issue commentfacebook/relay

Data not fetched when using partial render policy in 10.1.0

hey @janicduplessis, sorry for the delay here, this definitely sounds off. quick question: which versions of react and relay were you using? were you using react concurrent mode?

janicduplessis

comment created time in 2 days

issue commentfacebook/relay

Nested fragments seem to GC even though still referenced

hey @maraisr, sorry for the delay here, this definitely sounds off. quick question: which versions of react and relay were you using? were you using react concurrent mode?

maraisr

comment created time in 2 days

PR closed facebook/relay

Change interface to detect_changes so that we don't need to pass in current TypeSystemDefinitions. CLA Signed fb-exported

Differential Revision: D25717916

+14 -50

1 commit in aakshintala/relay/tree/export-D25717916 facebook/relay/tree/master

4 comments

3 changed files

aakshintala

pr closed time in 2 days

pull request commentfacebook/relay

Change interface to detect_changes so that we don't need to pass in current TypeSystemDefinitions.

Closing as the commit has already landed.

aakshintala

comment created time in 2 days

issue commentfacebook/relay

useLazyLoadQuery breaks with GC after quick unmount -> mount

react and react-dom are locked to 16.13.1 in yarn.lock

saivann

comment created time in 2 days

issue commentfacebook/relay

useLazyLoadQuery breaks with GC after quick unmount -> mount

hey @saivann, what version of react are you using?

saivann

comment created time in 2 days

push eventfacebook/relay

Nikhil Handyal

commit sha e5b1155f141ce2320ea20c393fdfa4e17141a39b

Improve error message for fixture test failures Reviewed By: kassens Differential Revision: D25873158 fbshipit-source-id: 43a6bcdec0add124f658903c62095a7644139201

view details

push time in 2 days

issue commentfacebook/relay

useLazyLoadQuery breaks with GC after quick unmount -> mount

@jstejada We started using Relay on 0.0.0-experimental-c818bac3 (the version on which we reproduced this problem) so we do not know if this is a regression or long term bug in the library.

saivann

comment created time in 2 days

issue commentfacebook/relay

Error: The macro you imported from "undefined" is being executed outside the context of compilation with babel-plugin-macros

I was getting the same error with next.js and @j0lv3r4's fix didn't help. However it worked after replacing .babelrc with babel.config.js containing:

module.exports = {
  presets: [require.resolve('next/babel')],
  plugins: [[require.resolve('babel-plugin-macros')]],
};

mindaugasnakrosis

comment created time in 2 days

issue commentfacebook/relay

useLazyLoadQuery breaks with GC after quick unmount -> mount

@saivann, to confirm, did this problem start happening when you upgraded relay?

saivann

comment created time in 2 days