profile
viewpoint
Jan Kassens kassens Facebook San Francisco, CA http://kassens.net

kassens/frameworks 27

A Google Chrome extension to display Javascript frameworks used on a website.

kassens/fire 11

MooTools Fire - Sets AIR on Fire

kassens/javascript-formatter 8

A Javascript formatter written in Javascript using a PEG

kassens/escala-cep 4

Complex Event Processing implementation for EScala

kassens/art 3

vector drawing for buttons, icons, widgets and all that stuff

kassens/AwesomeWidgets 1

Simple desktop widgets based on MacRuby. Highly experimental.

kassens/bashmarks 1

Directory bookmarks for the shell

kassens/couchapp-tmbundle 1

CouchApp TextMate bundle

kassens/couchrest 1

A RESTful CouchDB client based on Heroku's RestClient and Couch.js - you want the version at http://github.com/couchrest/couchrest/tree/master

push eventfacebook/relay

Relay Bot

commit sha 39dd32148060ea0a121462e3120630952584139c

Deploy website Deploy website version based on 0e38b354939896ff11833e5fa49b01d3a4d00363

view details

push time in 10 days

delete branch kassens/relay

delete branch : fixup-T62185618-master

delete time in 10 days

PR closed facebook/relay

Re-sync with internal repository CLA Signed fh:direct-merge-enabled

The internal and external repositories are out of sync. This attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.

+22830 -0

1 comment

304 changed files

kassens

pr closed time in 10 days

pull request commentfacebook/relay

Re-sync with internal repository

We've landed this in parts now according to rough attribution.

kassens

comment created time in 10 days

push eventfacebook/relay

Tianyu Yao

commit sha 260f53a9760b550919b76aaacae7179577ea7ba5

[rust compiler] add signedsource crate

view details

Tianyu Yao

commit sha 0ece16747e97f4ad26dd33e24407ef8ffad35798

[rust compiler] add schema-diff crate

view details

Tianyu Yao

commit sha f37010c91a04e08211cb9e7bbffc09dbfea0083a

[rust compiler] add dependency-analyzer crate

view details

push time in 10 days

push eventfacebook/relay

Juan Tejada

commit sha d996a92b16aeb70b5ce5f3410e9203899a2d88f7

[rust compiler] add graphql-printer crate

view details

push time in 10 days

PR opened facebook/relay

[lint] exclude rust compiler from eslint

This should fix CI which picked up some (intentionally) invalid JS tests files in the snapshot assets.

+1 -0

0 comment

1 changed file

pr created time in 10 days

create barnchkassens/relay

branch : lintignore

created branch time in 10 days

push eventfacebook/relay

Jan Kassens

commit sha 887073adc06f650917a125659bfe257ff70967ab

[rust compiler] add README.md for the experimental compiler rewrite

view details

Jan Kassens

commit sha bb6519ef3b4e3200622129ec23ee7f52958a42a3

[rust compiler] add fixture-tests crate This crate provides a basic way to write snapshot based files for functions that transform from string to string.

view details

Jan Kassens

commit sha 0eca9927b5e2f0e40bc8016067e534dbd0d44744

[rust compiler] add the schema crate This crate provides schema infromation used by the compiler.

view details

Jan Kassens

commit sha 7a77f3198b8f2d54625dcfa3f75f1b90b3c54958

[rust compiler] add relay-compiler crate This crate contains the infrastructure to read files and send them to the transform pipeline.

view details

Jan Kassens

commit sha 8c375a2886c023865d1f24144f4aec25b6eebc18

[rust-compiler] add the extract-graphql crate This create is a simple, but extremely fast way to extract Relay `graphql` tags from source files. It's a basic tokenizer for "js like" languages including Typescript and Flow.

view details

Jan Kassens

commit sha db824ce2c547457f99636247b3e70141839c47e8

[rust compiler] add graphql-finder-watchman crate This crate uses watchman to find files to compile.

view details

push time in 10 days

create barnchkassens/relay

branch : rust-compiler

created branch time in 10 days

create barnchkassens/relay

branch : fixup-T62185618-master

created branch time in 10 days

PR opened facebook/relay

Re-sync with internal repository

The internal and external repositories are out of sync. This attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.

+22830 -0

0 comment

304 changed files

pr created time in 10 days

push eventfacebook/relay

Jan Kassens

commit sha 2f36049ac564798ff776e22f047f7fcbe5720868

Update ShipIt Sync fbshipit-source-id: 81bc6f8bdf77aca99243be4ea1c1de834de8e376

view details

push time in 10 days

created tagrelayjs/eslint-plugin-relay

tagv1.6.0

A plugin for the code linter ESLint to lint specific details about Relay.

created time in 10 days

push eventrelayjs/eslint-plugin-relay

Jan Kassens

commit sha c156dff03fb4573b6ed113602c942639e29331ef

v1.6.0

view details

push time in 10 days

delete branch kassens/eslint-plugin-relay

delete branch : get-module-name-change

delete time in 10 days

push eventrelayjs/eslint-plugin-relay

Jan Kassens

commit sha 4915708d6ac414c405f7a3be61eea0c578ef01ff

Update getModuleName to match Relay changes (#87)

view details

push time in 10 days

Pull request review commentrelayjs/eslint-plugin-relay

Update getModuleName to match Relay changes

 function getLocFromIndex(sourceCode, index) {  // Copied directly from Relay function getModuleName(filePath) {-  const filename = path.basename(filePath, path.extname(filePath));+  // index.js -> index+  // index.js.flow -> index.js+  let filename = path.basename(filePath, path.extname(filePath));++  // index.js -> index (when extension has multiple segments)+  // index.react -> index (when extension has multiple segments)+  filename = filename.replace(+    /(?:\.js|\.react|\.react-test|\.example|\.jsx?|\.tsx?|\.flow|\.brands)+$/,

I only added brands because it's a super common extension (unfortunately), but there's only a handful of .hooks.js files. They just need to include the Hooks suffix (Test.hooks.js requires the TestHooks prefix.

kassens

comment created time in 10 days

create barnchkassens/eslint-plugin-relay

branch : get-module-name-change

created branch time in 10 days

push eventkassens/eslint-plugin-relay

Joseph Savona

commit sha a348ee445047f8fa56bb22c90aab797ca99891f4

Fix generated flow type rule w readonly/aliased types (#60) * Fix generated flow type rule w readonly/aliased types

view details

Jan Kassens

commit sha 22b811703832c1c34ed4923a47b5a08193c8d4fd

v1.3.2

view details

Jan Kassens

commit sha b594639383cc27b66172e715d54088e33943e123

Allow graphql_DEPRECATED tag (#61) This is used for internal migration to split legacy RelayCompat code from RelayModern.

view details

Jan Kassens

commit sha 7a13ccffd0354d7733775cd0880fddfb2864cb45

Update node version to current supported (#62)

view details

Jan Kassens

commit sha 0ec7247825a5ebc3cc715f47b16bb9956eaa0199

v1.3.3

view details

Juan

commit sha 3962968b169a58d5e3d9ced6760d13d617f57225

Lint for misuse of usePaginationFragment and useRefetchableFragment without providing query type param (#63) * Add linting for misuse of usePaginationFragment and useRefetchableFragment without providing query type param * Remove unused code * prettier

view details

Juan

commit sha d145308a374e452002454ef79b541b35398b9310

Verify correct ref type is used for useRefetchable and usePagination fragments (#64) This commit ensures that we also verify that the correct ref types are imported when using useRefetchableFragment and usePaginationFragment. Currently we only do so for useFragment. Test Plan: New and updated unit tests

view details

Juan Tejada

commit sha 2fcb422f8973945b19c9648ab1e69400ce961dc8

v1.3.4

view details

Jan Kassens

commit sha 9ac7e34f60fda338ac6a3d8a953f27f7e1028525

Update yarn.lock (#65)

view details

Jan Kassens

commit sha bed8756d909d269a79145527949a916a87a4905e

Update license to MIT (#66)

view details

Jan Kassens

commit sha a84c3cc0be684bfb846bb93a0e78cdc317498887

v1.3.5

view details

Juan

commit sha fd4d54d8c68794bd28b180d38342e5d73e0930b4

Include new pagination hooks in lint rule (#67) * Include new pagination hooks in lint rule

view details

Juan

commit sha 79d76bdb5080097356a2dd9266478aa66a8d4d0c

Fix misreporting for missing`$key` type when ref comes from previous hook call (#68) Our lint rule will report an error if a component is not using the generated Flow type to declare the type of the fragment ref it receives as a prop: `<fragment>_<prop>$key`. However, this can sometimes be reported incorrectly since there are valid use cases where the `$key` type for a fragment won't be imported, specifically when the ref that's passed to a hook is obtained from the result of a previous `useFragment` call. For example, the following case should be valid: ``` type Props = {| user: UserFragment_user$key, |}; const data = useFragment(..., props.user); const {data: connectionData} = usePaginationFragment(..., data); ``` However, in this case we'll report an error since that file is never importing the Flow type for the pagination fragment. **Fix** The fix is to detect if the ref argument was previously declared as a result of a previous call to a Hook. **Test Plan:** - New regression tests

view details

Juan

commit sha 6a47a4f35c18afcbf74bbb9d0c50dc4b60f4f15d

v1.3.6

view details

Tianyu Yao

commit sha b3c82e43545c915b7984446e808ad84318b974b1

Auto fix useQuery

view details

Tianyu Yao

commit sha 0dd0a90a2863d26db8d66487b479f3030e85028b

Enable some autofix tests

view details

Tianyu Yao

commit sha 1e78dee318c931a6937071f260e9df9f23357dea

Merge branch 'enable-autofix-tests' into auto-fix-usequery

view details

Tianyu Yao

commit sha a5958edfc97e7ebcd21c042457b3e802cea66f29

Update autofix test for useQuery

view details

Tianyu Yao

commit sha 9a5b91eea8ea207c1abe5fded2bf7b251b34ba94

Merge pull request #70 from tyao1/enable-autofix-tests [1/n]Enable some snapshot tests for the autofix output

view details

Tianyu Yao

commit sha 24a467333f115e0c119faea9ec7875a932ef245f

Merge pull request #71 from tyao1/auto-fix-usequery [2/n]Auto fix usequery

view details

push time in 10 days

delete branch relayjs/relay-examples

delete branch : update-deps

delete time in 15 days

push eventrelayjs/relay-examples

Jan Kassens

commit sha 22abcff677d6236a25afdcfaa0a902ec0dc399d3

Upgrade flow and graphql

view details

Jan Kassens

commit sha 9620d7f82af0d8e7706176fcf3b1bcff5f0bb58d

Upgrade babel

view details

Jan Kassens

commit sha d2561e2d744667430a40bf0d395f95d464f0070f

Upgrade eslint

view details

Jan Kassens

commit sha 18aad5b029a2df80e7b2327fd2b4783ead71983f

Upgrade todomvc-app-css

view details

Jan Kassens

commit sha dfe21d05848051ef225c0a859950f1e606b678da

Upgrade webpack

view details

Jan Kassens

commit sha f149a49843c0b58e4d9e7e0eedd3dd3ee570f85a

Bump yarn.lock

view details

Jan Kassens

commit sha 68fc984a8103a15632cafbf371260a29ff5065f5

Update flow-typed defs By running `yarn run flow-typed`.

view details

Jan Kassens

commit sha 8304b93f36862c09ebdf9fc6da744f9800556bc6

Ignore new lint issues

view details

push time in 15 days

PR merged relayjs/relay-examples

Update dependencies CLA Signed

Updated all deps to latest.

Tested running the todo example and all seems to work fine.

+3138 -1841

0 comment

38 changed files

kassens

pr closed time in 15 days

push eventrelayjs/relay-examples

Jan Kassens

commit sha 3c4a2b586a155fc5422d61b42b5859e457ea3942

Remove node 8 from CI Node 8 is past its end of life, remove from CI.

view details

Havit Rovik

commit sha 95e3078c05f38001251d963488cd092085c76b76

Update README.md

view details

Andrey Lunyov

commit sha e681081ee37f547b9e73520100552250a9b32a9d

Merge pull request #135 from relayjs/rm-node-8 Remove node 8 from CI

view details

Jan Kassens

commit sha bd29f4c05a953e9a5402dd45e0f673bd6048f8e3

Upgrade flow and graphql

view details

Jan Kassens

commit sha e45022fe547d6ccd02b630045928a38d820241a9

Upgrade babel

view details

Jan Kassens

commit sha a3900a622798b3c600f717920b99135c02e6f5f2

Upgrade eslint

view details

Jan Kassens

commit sha 8a0f3851d07a039e18f335b63e8718b9f60b8990

Upgrade todomvc-app-css

view details

Jan Kassens

commit sha c566afd14afc3d9c478c50d7c9ce953298e25bb7

Upgrade webpack

view details

Jan Kassens

commit sha b1a961d84f7903ae131ba7dbc254787ebe572ae1

Bump yarn.lock

view details

Jan Kassens

commit sha 2d8331dbcb74e7b98b962c6139b5b2e6d5cdc6aa

Update flow-typed defs By running `yarn run flow-typed`.

view details

Jan Kassens

commit sha ed9a226095b1cce7438e9e7f07cbcad3c81f13e9

Ignore new lint issues

view details

push time in 15 days

delete branch relayjs/relay-examples

delete branch : rm-node-8

delete time in 15 days

pull request commentrelayjs/relay-examples

docs: Update README.md

Thanks!

haruelrovix

comment created time in 15 days

push eventrelayjs/relay-examples

Havit Rovik

commit sha 95e3078c05f38001251d963488cd092085c76b76

Update README.md

view details

push time in 15 days

PR merged relayjs/relay-examples

docs: Update README.md CLA Signed

No need to specify run when using yarn.

➜  todo git:(master) yarn update-schema
yarn run v1.21.1
$ babel-node ./scripts/updateSchema.js
Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade`
Wrote /Users/haruelrovix/Projects/relay-examples/todo/data/schema.graphql
✨  Done in 4.29s.

➜  todo git:(master) yarn build
yarn run v1.21.1
$ relay-compiler --src ./js/ --schema ./data/schema.graphql --artifactDirectory ./__generated__/relay
HINT: pass --watch to keep watching for changes.

Writing js
Unchanged: 12 files
✨  Done in 3.22s.

➜  todo git:(master) yarn start
yarn run v1.21.1
$ babel-node ./server.js
Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade`
ℹ 「wds」: Project is running at http://localhost:3000/
ℹ 「wds」: webpack output is served from /js/
ℹ 「wds」: Content not from webpack is served from /public/
ℹ 「wdm」: Hash: 257b3c4befe724df5b11
Version: webpack 4.41.3
Time: 1586ms
Built at: 01/11/2020 11:32:56 AM
+6 -6

0 comment

1 changed file

haruelrovix

pr closed time in 15 days

PR opened relayjs/relay-examples

Remove node 8 from CI

Node 8 is past its end of life, remove from CI.

+0 -1

0 comment

1 changed file

pr created time in 15 days

create barnchrelayjs/relay-examples

branch : rm-node-8

created branch time in 15 days

PR opened relayjs/relay-examples

Update dependencies

Updated all deps to latest.

Tested running the todo example and all seems to work fine.

+2781 -1840

0 comment

35 changed files

pr created time in 15 days

push eventrelayjs/relay-examples

Jan Kassens

commit sha 2b97b2cc16ccbd1ad975b1c550bc9dfd4e219c24

Update flow-typed defs By running `yarn run flow-typed`.

view details

push time in 15 days

create barnchrelayjs/relay-examples

branch : update-deps

created branch time in 15 days

pull request commentfacebook/relay

Export flow types to npm

I'm landing this after the 9.0 release to give us some time to test this in the latest release.

kassens

comment created time in 15 days

push eventkassens/relay

Tianyu Yao

commit sha 015f453be510811c20b20d5f26fac174cc343392

Add test case for QueryRender retry function Reviewed By: jstejada Differential Revision: D14676845 fbshipit-source-id: 473708b1114c8c0783e19d776f16491237f0f60e

view details

Jan Kassens

commit sha e492652ef0ea5104e298512869c757644de0385e

reduce Store instrumentation Summary: The instrumentation has a small overhead and isn't really interesting for function that don't do real work other then adding something to a Map. Reviewed By: alunyov Differential Revision: D14693250 fbshipit-source-id: f1ab5f6b0eb9ff0a6295729763b0ddbdf7b32297

view details

Jan Kassens

commit sha 9ddb1658f08406fa2dc54adb61ea94b2c65a55bd

remove ReactRelayContainerProfiler Reviewed By: josephsavona Differential Revision: D14692749 fbshipit-source-id: 621d4caf0263732aad2f643f99c95caeeb6e146c

view details

Juan Tejada

commit sha ea7cb1adbdef3bea88c0b38c17798d8597786e64

Fix getFragmentIdentifier; include fragment owner vars Reviewed By: alunyov Differential Revision: D14681587 fbshipit-source-id: cfbb7ad723bfb9f9a00204660b21ef66a669bd87

view details

Andrey Lunyov

commit sha 3969d7a837c86ae129a5e2e67b40a47f26fa1d49

Use environment.execute if it's not a modern environment Reviewed By: josephsavona Differential Revision: D14692736 fbshipit-source-id: 7d59f7800ca05a258e1a4046bc64a5d13f6043cc

view details

Jan Kassens

commit sha 360d07706b96c58c7ccda0146ab5e058a9b880b5

set displayName for ContainerConstructor Reviewed By: josephsavona Differential Revision: D14713493 fbshipit-source-id: d95f8202b73b073ba38af8d85a294c90c570564e

view details

Gerald Monaco

commit sha f7fd416bbae00b9ffc2aaa23e70b3cc7bf76f493

Refactor getFBFormatGeneratedModule and output @relayRequestParams Reviewed By: kassens Differential Revision: D14713903 fbshipit-source-id: 5e6ee0df7acfc68bf8cc97070659a9ff7ad4f59f

view details

Jan Kassens

commit sha 2ce9f6673e79364d4eeb527fc9ba25cdb9c5fed6

micro-optimize runtime traversals Summary: This won't be a big optimization, but curious to see if reducing function wrappers and using a switch makes a difference. Reviewed By: josephsavona, jstejada Differential Revision: D14719889 fbshipit-source-id: 12c6c0830f77c23542483a6b61f0b0707ab5bbcd

view details

Joe Savona

commit sha 32c5369f56dd015fa88b758d987ec05fcb9be27e

Unused argDefs causes runtime error 1/2: regression test Summary: Adds a runtime unit test to assert that an unused argDef can cause a runtime error and a compiler test fixture to demonstrate why. The specific error occurs when a fragment references a global variable inside `arguments` and the fragment it is passing the argument to doesn't end up using the corresponding argument: in this case, the compiler doesn't see the global variable ever being used, and doesn't check that there is a corresponding query argument definition. Without a query argument definition, Relay doesn't populate a default value for the variable, and it's then null when reader tries to access it. A follow-up diff will fix the issue. Reviewed By: jstejada Differential Revision: D14716989 fbshipit-source-id: 5b572d4d54c9a7367f8de490f68a3734dda6e870

view details

Avik Chaudhuri

commit sha d08e1a79593349c99da24d0309dcbcaf2ae71299

@allow-large-files xplat flow 0.96 upgrade Reviewed By: panagosg7 Differential Revision: D14727932 fbshipit-source-id: 66b2fce7753450204c5daa131ffe43dcd4736539

view details

Joe Savona

commit sha 9baa85a69cb34161fb54fce1b27727b584b1149d

Unused argDefs causes runtime error 2/2: Fix Summary: Fixes an issue that occurs when a fragment references a global variable inside arguments and the fragment it is passing the argument to doesn't end up using the corresponding argument: in this case, the compiler doesn't see the global variable ever being used, and doesn't check that there is a corresponding query argument definition. Without a query argument definition, Relay runtime previously did not populate a default value for the variable, which would then throw in RelayStoreUtils.getStableVariableValue due to the variable name not being defined as a key in the variables object. The fix is to explicitly set the value of these global variables to `undefined` so that accessing the value still produces the same result, but it passes the hasOwnProperty check. A subsequent diff will add stricter checking of args/argDefs (that all args are defined, and that all argDefs are used). Reviewed By: jstejada Differential Revision: D14729160 fbshipit-source-id: a0a45680094d5b71a4b0e2840a83b62a0e0f60c6

view details

Andrey Lunyov

commit sha ed59ab551260d6426201141221b0f0e600bf3674

Make it work for ServerSnapshotTests Reviewed By: jstejada Differential Revision: D14738428 fbshipit-source-id: dc27cd969b77361ccf4b371cdb26870f8e1bdab6

view details

Joe Savona

commit sha 427c0382c73c39b2f4169761d2af9f497e1da3b8

validate that all @arguments are defined on the callee Summary: Changes relay-compiler to validate that all `arguments` are *defined* on the callee - specifically, that an argument of the given name is declared with `argumentDefinitions`. It is also theoretically possible to type-check the arguments, but many argDefs unnecessarily specify the type as non-nullable even when the variable is used locally where a nullable value is okay. These leads to lots of "errors" where a nullable value is passed where a non-nullable is expected, even when it would eventually (safely) flow into a nullable usage site. Given that we already have an additional validation step - when queries are persisted - type-checking `arguments` is not critical for safety and is primarily for improved DX (surfacing errors earlier and with a more actionable message). I'll consider adding some sanity-checking of types in a follow-up. The parser also now supports `uncheckedArguments_DEPRECATED` which bypasses the above check. The compiler will error if the unchecked form is used unnecessarily (ie if all arguments are actually defined). Note: validating `arguments` wasn't previously possible due to the need to integrate with compat/classic queries that were not visible to the compiler, whose arguments couldn't be verified. Reviewed By: kassens Differential Revision: D14734748 fbshipit-source-id: 4a1bf988884a721d71f88a710c097dfacb507097

view details

Joe Savona

commit sha cf8b240dd6c39dec75f386cceebb393d28db0fa5

Only warn on changed __typename for non-client records Summary: Relaxes the warning around inconsistent `__typename` for a given record to only warn when records with a defined `id` change their type, but not for client records. Client records don't have a stable identity so it is reasonable for them to change type over time. Reviewed By: kassens Differential Revision: D14762426 fbshipit-source-id: 864cbdf6b6a80d2bab6ccf02102a98c00b4d6f53

view details

Jan Kassens

commit sha 9afc94926222df5b54c4a8c29ccfc080592beddb

Small refactor of RelayModernSelector.getVariablesFromFragment (#2704) Summary: The empty if was tripping up Google Closure Compiler I was trying out and also gets rid of an extra object copy. Pull Request resolved: https://github.com/facebook/relay/pull/2704 Reviewed By: josephsavona Differential Revision: D14778823 Pulled By: kassens fbshipit-source-id: c55e6a0b24673e010c794dccc9cdd569cd6682ea

view details

Juan Tejada

commit sha 08850dc34e6dc30a08b73cbf1fd53c1b57602c7e

RM Ownership: When computing fragment variables, make sure to use owner over context when owner is preferred Summary: `getVariablesFromObject`, similarly to other selector functions, also take an optional fragment owner as the last parameter, which will cause it to prefer the variables available through the owner instead of the operationVariables passed as the first param. However, there were a couple of callsites where we weren't correctly passing the owner we received from above, in the Pagination and Refetch containers; this hasn't been a problem because the owner variables shouldn't differ from the context variables, but will become a problem when we stop setting variables in context entirely. Reviewed By: josephsavona Differential Revision: D14751309 fbshipit-source-id: b8b03db12d2ff80900700bd4235ffc54150f1207

view details

Joe Savona

commit sha 963471586917759a2149d64a17516c75bcbaa7cd

Update babel plugin for unchecked args directive Summary: Handle the `uncheckedArguments_DEPRECATED` in the babel plugin. Reviewed By: alunyov Differential Revision: D14779087 fbshipit-source-id: 2548afc578067ee419d26345a22f85768531c2d0

view details

Andrey Lunyov

commit sha fe35a4490f6440525294d4e07aaf96adc2174a1c

RelayOperationTracker Reviewed By: jstejada Differential Revision: D14657047 fbshipit-source-id: 10b17c7f43b71edc74dedbfc068be39b8809a9ab

view details

Juan Tejada

commit sha 7aceaa93a29ce1d5feff78261df70aafc3c93412

RFC: Add checkAllowedSet to Rollout module Reviewed By: kassens Differential Revision: D14796180 fbshipit-source-id: aa0ac489e31aab281dbf62cff26606d0ddbd50d8

view details

milosa

commit sha d48ecb01aa01d9ceb515e2418508c5f17418789a

Update line number Summary: Pull Request resolved: https://github.com/facebook/relay/pull/2705 Differential Revision: D14833594 Pulled By: kassens fbshipit-source-id: e6b683298885df9f8a55b8766dea111b6336c796

view details

push time in 15 days

push eventkassens/relay

Relay Bot

commit sha b77cedd0f48eb3091b3db7cbfdb415df23d1b6b7

Deploy website Deploy website version based on 8c51286848313ef6b3dc09abaa81aa9b44bd17de

view details

push time in 15 days

push eventkassens/relay

Jan Kassens

commit sha ea4a316db430b04b974ca6858910d1b49d3c6105

restore flow suppression comment Reviewed By: alunyov Differential Revision: D19302228 fbshipit-source-id: c4bf38a24712721ba4efb0544fd3d81f91c976b8

view details

Dan Abramov

commit sha 0c433d788088d5fd38e702f4d4b5e7882dcdf2a5

React Native sync for revisions 6cff70a...19f6fe1 Reviewed By: TheSavior Differential Revision: D19318286 fbshipit-source-id: acaa5224f7162a274c395a62e54da82199001005

view details

Andrey Lunyov

commit sha 547a08a76079f1b36ab12e97838379d9ae799826

Add support for @use_customized_batch argument in the @stream_connection directive Reviewed By: jstejada Differential Revision: D18616020 fbshipit-source-id: b59dd237c82ac671108dd02dc8a3e09a18e308e4

view details

Andrey Lunyov

commit sha b4c92a23ae061943ea7a2ddb5e2f7686d3af8c0e

Add runtime support for batch response with @stream Reviewed By: josephsavona Differential Revision: D18621029 fbshipit-source-id: f858f0f0c571393e6db84b70a9fcaf6a12f9a9bc

view details

Andrey Lunyov

commit sha 78d20cc8cdeb8328d2922d840dc76aa51eb1ddd6

An optimized batch responses processing in QueryExecutor Reviewed By: josephsavona Differential Revision: D19177805 fbshipit-source-id: e97ec057b6b5b436f35632809799c588dfafc47a

view details

Daniel Sainati

commit sha a3fcfa3178a3ac70f3c3cd09bf83859556468768

suppress www errors from improving definition of React$Node Reviewed By: jbrown215 Differential Revision: D19352321 fbshipit-source-id: 5aae5e24982bfb0aba106dc123f84d997a915466

view details

George Zahariev

commit sha 007d7fa5c4c825b301d09020b041b19bcca69d91

Replace usages of `Symbol` type with `symbol` in Xplat Reviewed By: dsainati1 Differential Revision: D19351319 fbshipit-source-id: 6c4c51889b58c98a2163116933a65408f5712780

view details

Josef Brandl

commit sha 6a9c6d880af6a214cf7825422f7459f83cd15c7a

Docs: Remove excess curly brace on "GraphQL in Relay" page (#2996) Summary: I removed the excess opening curly brace. I also moved the opening square bracket, so that it becomes a valid TypeScript type with which readers are likely more familiar with Pull Request resolved: https://github.com/facebook/relay/pull/2996 Differential Revision: D19373946 Pulled By: jstejada fbshipit-source-id: 2bd70eba38d36c7b3dec50820900cee0c6e88b1c

view details

Jordan Eldredge

commit sha 0feda7481f6486af0a673c3f6bd604365cee55c7

Remove `variables` key from positional arguments to useLazyLoadQuery Summary: Pull Request resolved: https://github.com/facebook/relay/pull/2948 Reviewed By: alunyov Differential Revision: D19330647 Pulled By: captbaritone fbshipit-source-id: e07b2a398f06fa8f3aefce9e261112ac39b81530

view details

Joe Savona

commit sha 9cf5a58174f8624ee5bbcf4d774457f1d6b9dd08

Add errors to the respons cache in InternRelayNetworkServerCache Reviewed By: olegbl, kassens Differential Revision: D19347119 fbshipit-source-id: 80bce9a5ed62842ac117d447536d3648a6d85dc4

view details

Juan Tejada

commit sha e593ce23153b17668addf19e9a984d791205322e

Create root record upon store initialization Reviewed By: josephsavona Differential Revision: D19383394 fbshipit-source-id: 52c274e26675942ce5869337ad68fac3fc5bd65e

view details

Juan Tejada

commit sha 547e26c096866ff06c2ad20087944e826a6131f5

Add regression test for behavior when suspending at the root Reviewed By: josephsavona Differential Revision: D19393364 fbshipit-source-id: bff44daf66e83390f4182296370ea42c0c49e767

view details

James George

commit sha 47504e62b317da50050d1524cdb718a96f85bf45

fix(docs): Minor typographical fix (#2992) Summary: Minor grammatical tweak. Pull Request resolved: https://github.com/facebook/relay/pull/2992 Differential Revision: D19373923 Pulled By: jstejada fbshipit-source-id: c4bc29dec74788ebbbaa67f9023bded60f25a603

view details

Abdelmoumen Bouabdallah

commit sha a63e498e86560649f13c070d0bd36f17d520b090

Minor grammar fixes. Summary: Pull Request resolved: https://github.com/facebook/relay/pull/2989 Differential Revision: D19373931 Pulled By: jstejada fbshipit-source-id: 5ea45bb61e4eb09b5e3c26c1446c69af2bea02c6

view details

Joe Savona

commit sha df17e69c2f07423f31d74d5c40e0b35273435688

Remove new connection model experiment Summary: Removes support for the new connection model from across the compiler and runtime. This could be an interesting avenue to pursue in the future - and the exploration lead us to find a new approach to handling applying/reverting/rebasing optimistic updates - but overall we decided not to pursue this further right now. Reviewed By: jstejada, kassens Differential Revision: D19410941 fbshipit-source-id: 5917fb673c74112626f185675131d712728a0b93

view details

Juan Tejada

commit sha e6663b1396c9384ddd21724dde10ff78e9ea0ac3

RFC: Add unstable option to pass extra variables during pagination with hooks Summary: # Motivation In very rare cases, it is necessary for product developers to pass variables to the pagination request that are different from the original initial query. In such cases, these are variables that don't affect the output of the connection (i.e. they aren't filters), so they kind of just produce a side effect in the server, but which still need to be sent as with a different value for each request, e.g. a client request id. There are other cases such as using the `find` filter on a connection to fetch a specific node in the connection. For this case, we don't want the pagination requests to pass the original `find` value from the initial request. # Changes For this reason, this commit adds a new option to the `loadNext` function exposed by our pagination hooks: `UNSTABLE_extraVariables`. - We use Flow to enforce that the extra variables match the variables expected by the pagination request, and added a flow test for that - We ignore any pagination variables passed as extra variables. # Caution This should be used sparingly as it can cause unexpected results. If you fetch data that you are not rendering, e.g. change a filter, this wont update the connection that is being rendered. Reviewed By: josephsavona Differential Revision: D19412033 fbshipit-source-id: 1fb7918e5cb9ee34099236879ffd2fb0d0d068bd

view details

Nat Mote

commit sha 88afc38aae8d282e6cf0fffecfd017edeea18e18

Deploy Flow v0.116 to xplat Reviewed By: gkz Differential Revision: D19416307 fbshipit-source-id: 32767f24e5bfeb1912f7dd5527eb8c4db7a08a1a

view details

Jan Kassens

commit sha c20d7ca826be0a29336492fc6a5e395798311b71

add og:image attribute (#3003) Summary: This should set the `og:image` meta property that determines the scrape preview. Pull Request resolved: https://github.com/facebook/relay/pull/3003 Test Plan: Docusaurus docs here: https://docusaurus.io/docs/en/site-config#ogimage-string Should show the Relay logo after the website deploys in this tool: https://developers.facebook.com/tools/debug/?q=relay.dev Reviewed By: jstejada Differential Revision: D19448289 Pulled By: kassens fbshipit-source-id: 26a9b69e4ce3f1b91e9bc59a11e3c2822733cca7

view details

Rubén Norte

commit sha c7ad531d8992f0f804a5f1b1358dd6b17e7eb753

Add new types for Surface EntryPoints with Relay integration Summary: [Internal] Expose additional types from `EntryPointTypes.flow` Reviewed By: sahrens Differential Revision: D19021835 fbshipit-source-id: e2f7311ce3f77c3ed8c0284d6437070cbb983160

view details

Tianyu Yao

commit sha 68000434d65658f48e43643f93a268f6d7b3367d

Cleanup RelayFBMissingFieldHandlers Reviewed By: jstejada Differential Revision: D19503343 fbshipit-source-id: 9aa5e70520db35f67c1b6904455ac31a7579035d

view details

push time in 15 days

delete branch kassens/relay

delete branch : ogImage

delete time in a month

PR opened graphql/graphql-spec

[RFC] allow empty selections

Sometimes, product code might only be interested in the existence of an object. Currently, this forces a workaround of either querying __typename or adding a bool field like has_thing.

It seems natural and not too confusing to allow empty selections:

query {
  event {
    location {}
  }
}

The response should either return null or an empty object for location.

(The spec changes are incomplete.)

+10 -2

0 comment

2 changed files

pr created time in a month

push eventkassens/graphql

Lee Byron

commit sha e56702839ab0cd17982ab7234fbd8c3e4177e40f

Bump to latest version of spec-md + npm run watch (#417) The most recent version of spec-md fixes a few bugs and adds keyword highlighting which makes reading algorithms a bit more pleasent. This also introduces nodemon and an `npm run watch` script which rebuilds output when markdown files change. Also bumps node to latest version for travis builds

view details

Breno Calazans

commit sha 55fa43ea0946dc974f895c5ca0162c2b3018a543

Fix Markdown links (#406)

view details

Ivan Goncharov

commit sha 54df48d4822313a4e231b541446757f4c5d34b81

Add optional 'extensions' entry to errors (#407) * Add optional 'extensions' entry to errors * Some minor formatting changes * Specify additional entry to errors * Update Section 7 -- Response.md * Update Section 7 -- Response.md

view details

Ivan Goncharov

commit sha de5cfc4ef8f6a57d93e27f0ecef802607d0fee12

Fix formating for Note section (#422)

view details

Matt Krick

commit sha 3a33b47e013361bff0647d9b811ee0c5ef595f52

Require Interface to implement at least 1 Object (#424) * Require Interface to implement at least 1 Object Matching PR for graphql-js: https://github.com/graphql/graphql-js/pull/1280 * add period

view details

Maciek Sakrejda

commit sha 2b2467aab99f4c4155cb81440557b5077f0a990b

Add missing comma to error counter-example JSON (#421)

view details

Lee Byron

commit sha 0356f0cd105ca54cbdf5eb0f37da589eeac8c641

RFC: Fix ambiguity with null variable values and default values (#418) This change corresponds to a spec proposal (https://github.com/facebook/graphql/pull/418) which solves an ambiguity in how variable values and default values behave with explicit null values, and changes validation rules to better define the behavior of default values. Otherwise, this ambiguity can allows for null values to appear in non-null argument values, which may result in unforeseen null-pointer-errors. In summary this change includes: * Removal of `VariablesDefaultValueAllowed` validation rule. All variables may now specify a default value. * Change to `VariablesInAllowedPosition` rule to explicitly not allow a `null` default value when flowing into a non-null argument, and now allows optional (nullable) variables in non-null arguments that provide default values. * Changes to `ProvidedRequiredArguments` rule (renamed from `ProvidedNonNullArguments`) to no longer require values to be provided to non-null arguments which provide a default value. * Changes to `getVariableValues()` and `getArgumentValues()` to ensure a `null` value never flows into a non-null argument. * Changes to `valueFromAST()` to ensure `null` variable values do not flow into non-null types. * Adds to the `TypeInfo` API to allow referencing the expected default value at a given AST position.

view details

Ivan Goncharov

commit sha 1d56b8865a73cb34a50926bf728664d7a7b55c63

Clarify types of errors in spec text (#385) * Clarify types of errors in spec text * Update Section 5 -- Validation.md

view details

Lee Byron

commit sha 15b8b40662639c0e62ecc509ae5370f7708b351c

RFC: SchemaExtension (#428) * RFC: SchemaExtension This adds new grammar to the GraphQL SDL: ```graphql extend schema { mutation: MutationType } ``` This feels like the missing piece of the type system extension framework. In addition to extending types in a type system, the top level schema should be extendable as well. * Further separate type system definitions from extensions

view details

Lee Byron

commit sha 8763fd7bf9128440ae958526cf0129b49ca5e2d0

Edit: fieldType may not be defined, but will never be null (#433)

view details

Lee Byron

commit sha bc197476b268d119ee04946daa73f9b42891d109

Subscriptions delivery agnostic This adds additional clarifying text about subscriptions being at a higher level of abstraction than QoS and transport. Closes #419

view details

Lee Byron

commit sha adb11da75d24c9fb39b516e7566709844c535b36

Add notes about notational convention, links to Appx A, and shorter algorithm example Closes #238

view details

Lee Byron

commit sha 4cd6824a661f5035616e821a41bf128fe9001fe7

Update introduction paragraph to better fit current state and links to previous releases and draft

view details

Lee Byron

commit sha a4def976f874a6a78e5beb8079117b4756de0586

Edit: Result coercion no data loss (#434) This edits the "result coercion" section of the scalar types to make it clear that data loss is to be avoided and suggests that internal values of the correct type are the ideal scenario. Fixes #312

view details

Lee Byron

commit sha 4b7e22bd386a6611a939ea5b333f411eb8ae8499

Edit: reference merge field algos from validation rule (#435) Helps provide context when reading the validation rule. Fixes #347

view details

Lee Byron

commit sha 057e8a7cd013f8014eacf3b31067744dbe6bac36

Fix formatting of algorithm steps in CompleteValue

view details

Lee Byron

commit sha 007a93e698299793622ef1b966fefbd110dd325a

Edit: Clarify list coercion rules (#436) This adds some additional copy to list result coercion about handling errors and nullability for items, and clarified copy and new examples for input coercion to better clarify the single-item rule, recursive coercion, and null values. Fixes #372

view details

Lee Byron

commit sha a9a6dab3bc28b0897afa2c5e9384f90d1969bb2b

Clarify: serialization formats (#437) Factors out a section on Map ordering which was duplicated between the previous two subsections. Also clarifies that a different serialization format may use whichever natively supported primitives it likes. Closes #337

view details

Lee Byron

commit sha deac90ef73c8cd80cb424f242ce9264cbf6267d5

Edit: clarify errors occuring during selection set execution (#438) Includes some prose about it being okay to cancel or not start sibling field execution in the case of error.

view details

Lee Byron

commit sha 0f993d83077190df9843493dcaad12fbe33c9594

Edit: change sub-section headings for introspection

view details

push time in a month

create barnchkassens/graphql

branch : empty-selection

created branch time in a month

push eventfacebook/relay

Relay Bot

commit sha f05f2d37a2e52129b8d7e8ec42767b76efc71065

Deploy website Deploy website version based on c20d7ca826be0a29336492fc6a5e395798311b71

view details

push time in a month

PR opened facebook/relay

[website] add og:image attribute

This should set the og:image meta property that determines the scrape preview.

+1 -0

0 comment

1 changed file

pr created time in a month

create barnchkassens/relay

branch : ogImage

created branch time in a month

push eventfacebook/relay

Relay Bot

commit sha 44b3309c744801b0a83dff349ae2b337c5fa703f

Deploy website Deploy website version based on a63e498e86560649f13c070d0bd36f17d520b090

view details

push time in a month

push eventfacebook/relay

Relay Bot

commit sha cb610c954b003c2483dc8dd1aad5c6e3d972b4f6

Deploy website Deploy website version based on 47504e62b317da50050d1524cdb718a96f85bf45

view details

push time in a month

push eventfacebook/relay

Relay Bot

commit sha d111c05bdbb598840fcec2ff0c60589b0b9ccafa

Deploy website Deploy website version based on 0feda7481f6486af0a673c3f6bd604365cee55c7

view details

push time in a month

push eventfacebook/relay

Relay Bot

commit sha fe6a05b3356abce60b9c69e4a1ea903af1aaf60e

Deploy website Deploy website version based on 6a9c6d880af6a214cf7825422f7459f83cd15c7a

view details

push time in a month

create barnchkassens/relay

branch : transformer

created branch time in a month

push eventkassens/relay

Relay Bot

commit sha c79f1d498391e65d78e675ffc813269754099eff

Deploy website Deploy website version based on 60d93420aa347d14bddf950c604b88510c5f3778

view details

push time in a month

push eventkassens/relay

Martin Zlámal

commit sha d424dd4eda1449a0729a5972c26f1a3cbed693fa

Docs: update commitMutation.onCompleted docs (#2969) Summary: Response object in the onCompleted callback is not "raw" server response but updated response from the store. This confuses many users. You can try it easily: write an updater to modify the incoming records from the server and you will get the updated values in onCompleted callback (rather than the raw server response). Pull Request resolved: https://github.com/facebook/relay/pull/2969 Reviewed By: jstejada Differential Revision: D19263743 Pulled By: kassens fbshipit-source-id: d711a20b8f1f0bc3ecc8ff125a81480c8a197f77

view details

Jan Kassens

commit sha bec2589d3dd6b4ff972f7112f915f73587fcf503

delete getFragmentSpecIdentifier Summary: This helper is no longer used. Reviewed By: jstejada Differential Revision: D19263986 fbshipit-source-id: d9caea3744edebb96447ca0602fd25bee6f95228

view details

Panagiotis Vekris

commit sha fcb2fd951e54fc4541d3bf0514e7c3662ddcf218

suppress synced files for 0.115 Reviewed By: dsainati1 Differential Revision: D19275631 fbshipit-source-id: ee0533ecf9adc4f372a84c7c6c6511b669396e30

view details

Andrey Lunyov

commit sha 62fd9d3b996c8901324a2a3a947f3cdccfec9266

Remove RelayRecordSourceObjectImpl Reviewed By: jstejada Differential Revision: D18978530 fbshipit-source-id: db2b50814acb1d648cede6f03c19aa8a9553c804

view details

Jan Kassens

commit sha 4fab4a1a642dda170ff3dc64af50d01afe6180ac

fix copyright headers Reviewed By: jstejada Differential Revision: D19291167 fbshipit-source-id: 27a6d3593916ba7cc7ab945032920c31c885cb66

view details

Jan Kassens

commit sha a6ad1a81365c70e70c8b71af4dfc1ab8c0aed97b

Bump yarn.lock dependencies (#2986) Summary: This should fix security warnings about dependencies. Pull Request resolved: https://github.com/facebook/relay/pull/2986 Reviewed By: alunyov Differential Revision: D19293812 Pulled By: kassens fbshipit-source-id: 4534aab78583427d8ed429a60609e2940746cefe

view details

Panagiotis Vekris

commit sha d249e75e7ebe0c6a5f36380a3604e8dc7385188b

v0.115 in xplat/js Reviewed By: jbrown215 Differential Revision: D19292958 fbshipit-source-id: 4aa969bf2d0f2f5857e68a7e31ff4dcaf29e67cd

view details

Jan Kassens

commit sha 60d93420aa347d14bddf950c604b88510c5f3778

Remove node 8 support (#2987) Summary: Node 8 is out of maintenance, let's remove it from the CI matrix. `graphql-js` also no longer supports it: https://github.com/graphql/graphql-js/blob/a6c50deb671ba4197d6370dcca8a717a24d93435/package.json#L24 See: https://nodejs.org/en/about/releases/ Pull Request resolved: https://github.com/facebook/relay/pull/2987 Test Plan: CI Reviewed By: alunyov Differential Revision: D19298893 Pulled By: kassens fbshipit-source-id: 455f6433886d059d7dcd592685027a9176828a9c

view details

push time in a month

delete branch kassens/relay

delete branch : node8

delete time in a month

push eventrelayjs/eslint-plugin-relay

Jan Kassens

commit sha ce6ef087f5a6cb0cc3861033b14f3fc44699e057

Upgrade prettier to 1.19.1

view details

Jan Kassens

commit sha 2a353b8b1b846e4a76fa91d9599a48eb402cbdc4

v1.5.0

view details

push time in a month

created tagrelayjs/eslint-plugin-relay

tagv1.5.0

A plugin for the code linter ESLint to lint specific details about Relay.

created time in a month

delete branch kassens/eslint-plugin-relay

delete branch : graphql-15

delete time in a month

push eventrelayjs/eslint-plugin-relay

Jan Kassens

commit sha a160669f48b6a5e64175cb8e2c591c3debcda90e

Allow graphql@15 (#85) * Allow graphql@15 * Remove node 8 support

view details

push time in a month

PR merged relayjs/eslint-plugin-relay

Allow graphql@15 CLA Signed
+19 -21

2 comments

4 changed files

kassens

pr closed time in a month

push eventkassens/relay

Jan Kassens

commit sha f82c59598d4da4b3ffa343745fa260b10d554d4d

also remove from travis.yml

view details

push time in a month

PR opened facebook/relay

Remove node 8 support

Node 8 is out of maintenance, let's remove it from the CI matrix.

graphql-js also no longer supports it: https://github.com/graphql/graphql-js/blob/a6c50deb671ba4197d6370dcca8a717a24d93435/package.json#L24

See: https://nodejs.org/en/about/releases/

Test Plan: CI

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchkassens/relay

branch : node8

created branch time in a month

push eventkassens/eslint-plugin-relay

Jan Kassens

commit sha c9b19cde0d19eac19cfbb382ab1c51a447bab70d

Remove node 8 support

view details

push time in a month

pull request commentrelayjs/eslint-plugin-relay

Allow graphql@15

If we don't allow graphql 15, it leads to duplicate installs of graphql in node_modules when we want to upgrade.

kassens

comment created time in a month

push eventkassens/eslint-plugin-relay

Jan Kassens

commit sha ba5c6f8df26c1bcdad3c68e0b6a1abf6fc6979c2

Run prettier

view details

Jan Kassens

commit sha 4c8afa56c9d556e141f8300129cee7d8d27a4f2f

Allow graphql@15

view details

push time in a month

push eventrelayjs/eslint-plugin-relay

Jan Kassens

commit sha ba5c6f8df26c1bcdad3c68e0b6a1abf6fc6979c2

Run prettier

view details

push time in a month

PR opened relayjs/eslint-plugin-relay

Allow graphql@15
+10 -10

0 comment

2 changed files

pr created time in a month

create barnchkassens/eslint-plugin-relay

branch : graphql-15

created branch time in a month

delete branch kassens/relay

delete branch : yarn-deps

delete time in 2 months

PR opened facebook/relay

Bump yarn.lock dependencies
+59 -69

0 comment

1 changed file

pr created time in 2 months

push eventkassens/relay

Jan Kassens

commit sha 160e48ad429747580f1ba9ab2817d3f7993dd5c6

Bump yarn.lock dependencies

view details

push time in 2 months

create barnchkassens/relay

branch : yarn-deps

created branch time in 2 months

issue commentfacebook/relay

Optimizing the RequestIdentifier

Good catch, I've noticed this before but didn't get around to fixing this.

I think it'd make sense to add a hash field in addition to text to the query parameters object and use here (if we don't have an id).

morrys

comment created time in 2 months

push eventgraphql/graphql-relay-js

Jan Kassens

commit sha ecc478e7f6ed74c233aa53bbf5e9d4e04dffeada

Bump prettier to 1.19

view details

push time in 2 months

push eventfacebook/relay

Relay Bot

commit sha e09df2974449d7ca5bd7a7435db92e9624993a32

Deploy website Deploy website version based on d424dd4eda1449a0729a5972c26f1a3cbed693fa

view details

push time in 2 months

push eventkassens/relay

Relay Bot

commit sha f9867d8e441a3af78c2a876b6b50f7904862b3f4

Deploy website Deploy website version based on a2b14aca4ad9133cd7cbca2f35745edf08169f50

view details

push time in 2 months

push eventkassens/relay

Marshall Roch

commit sha 3ec97722c61246b4c96f27f7186b6db66d56d2c0

v0.114.0 Reviewed By: dsainati1 Differential Revision: D19042657 fbshipit-source-id: 04840f769207442be45e82cda39a7611784a6ce2

view details

Tianyu Yao

commit sha a4c8c86c64c339f97899f8b64d2130bd1e55533d

Turn on ENABLE_UNIQUE_MUTATION_ROOT feature flag Reviewed By: kassens Differential Revision: D19035652 fbshipit-source-id: cc2344789d43e62c9dfb03578e0a84f24f92f450

view details

Juan Tejada

commit sha 135da4c7003113e05af1d26c4fa1c1981a8cf787

Fix: Stop reading value for default render policy feature flag so early Reviewed By: kassens Differential Revision: D19048436 fbshipit-source-id: d9f4116f579d7d757f43cbaa61ea33dffd33f96e

view details

Jan Kassens

commit sha 748eae3b9ffd62665aa134fbdd3304076d8210de

remove inconsistent definition of FetchPolicy Summary: `relay-runtime` defines `FetchPolicy` as: ``` export type FetchPolicy = | 'store-only' | 'store-or-network' | 'store-and-network' | 'network-only'; ``` which is inconsistent with the subset defined here in `react-relay` that this diff removes. The definition in `react-relay` wasn't even used consistently throughout `react-relay` and one of the missing values was added back in. Reviewed By: jstejada Differential Revision: D19109847 fbshipit-source-id: 07d834fae00302838ceed05c26867ce6f1df5891

view details

Jan Kassens

commit sha f039656bc48ea17063374383b8fded43b25a2a4d

Upgrade graphql to 14.5.8 Reviewed By: mjmahone Differential Revision: D18937930 fbshipit-source-id: c64d9a4c81debedb0726e092a7b3b2679bde2399

view details

Tianyu Yao

commit sha dff1ebdec2838769567413bd6b7e9fe342b9a129

useMutaiton: Allow multiple mutation in flight Reviewed By: jstejada Differential Revision: D18976174 fbshipit-source-id: c58764c541239f8af93fa3e15ae3bb30b2ea0ca8

view details

Joe Savona

commit sha 96f9ba8f7e4d07082dd5411969443e9b51c6281b

Fix subscribing to plural fragments w missing data Reviewed By: jstejada Differential Revision: D19119009 fbshipit-source-id: 6b30e25696682257b7c5ed40d7ef4274ddcbbbd8

view details

Juan Tejada

commit sha b931d0b1961cd04580d7f019ed3a0be9818f1ea6

RFC: Only hold on to props that are fragment references (and not props from product) Summary: The purpose of this commit is to mitigate the impact of memory leaks produced by RelayModernFragmentSpecResolver when running in React Concurrent Mode. Specifically, with the fragment spec resolver, we subscribe to the Relay store when a resolver is constructed, which occurs during render. Since in Concurrent Mode render can occur many times without ever committing, this leaves open the possibility of dangling resolvers with subscriptions that never get cleaned up. This commit doesn't fix that specific issue, but makes it so we hold on to a lot less memory by not holding on to props passed to product code that aren't fragment references. Often times these props can reference parts of the React tree, causing us to hold on to a lot of memory that won't get cleaned up. Note that the preferred way of running Relay in concurrent mode is to use Relay Hooks, which are concurrent safe. Reviewed By: bgirard, steveluscher Differential Revision: D18975901 fbshipit-source-id: bbb35bb1796509ce2ac3fce95b1bb3a87f35bff7

view details

Tianyu Yao

commit sha edda8aa94e204df0a361cfa495ad5a9ed1db4c31

Fix RelayDefaultMissingFieldHandlers not getting new FeatureFlag value Reviewed By: kassens Differential Revision: D19132458 fbshipit-source-id: 8c8882a8d4dbee914e1f6ff9bfaa0fb4a4d8b866

view details

Jan Kassens

commit sha f0acc8f5a6f893e7b9efbf6dd681d41da2e7c32b

Missing field handlers should be exact objects Reviewed By: jstejada, alunyov Differential Revision: D19164177 fbshipit-source-id: d36242914fbc3909ba960807c5b5210ecb1690ce

view details

morrys

commit sha b4e7e431574c12e03751445de704bed3179ace2c

Created local ExecutionEnvironment with isServer (#2960) Summary: This PR resolves the issue https://github.com/facebook/relay/issues/2954 and fixes jest.mock. Pull Request resolved: https://github.com/facebook/relay/pull/2960 Reviewed By: kassens Differential Revision: D19071027 Pulled By: jstejada fbshipit-source-id: 3d5e216b23f5fe170ec75856d3bea484a77c1d37

view details

Orta Therox

commit sha 0cd681ea498336b1c8c1f1fa4a7f0932db86a505

Update the relay specific specifications to consider them generic best practices and not purely a relay spec (#2603) Summary: Better late than never, roughly a year ago in the GraphQL Working Group 3 we took it on Artsy to start moving the Relay specs to be considered "GraphQL Best Practices" ([link](https://github.com/graphql/graphql-wg/blob/master/notes/2018-02-01.md#discuss-moving-connectionglobal-id-specs-from-relay-into-best-practices-repo)) This starts that, beginning with first minimizing the use of Relay as being the sole client that conforms to the connection and object identifier spec. Main notes: - When referring to relay on the client I switched "Relay" to "Spec-compliant client" or "client" - When referring to relay's compatibility on the server side, I oriented it to just be "spec-compliant" - I mostly left the Mutation input spec alone, now that it's only for Relay classic and is close to being removed completely from Relay https://github.com/facebook/relay/pull/2349 - This is step one, once this is merged then I'd like to move both object identification and connection to be on the graphql repos instead of relay and I can handle link updating etc Happy to change wording etc /cc leebyron in case you don't watch this repo too closely. Pull Request resolved: https://github.com/facebook/relay/pull/2603 Reviewed By: josephsavona Differential Revision: D19071019 Pulled By: jstejada fbshipit-source-id: cf5a7dfb93cfd565d4f178a51cdff7cd0caec1a0

view details

luan

commit sha 578695f42681e0c3c9227e30f239ae0f2c6c2fc1

Relay new home page ui (#2953) Summary: New relay home page ui See https://github.com/facebook/relay/issues/2696 Final result: http://luansantosti.github.io/ This is the first step to improve the relay home page. Ps: Need to check the docs links if it's ok, there's one missing an url. The code example Orta will add the hightlights sintax to improve it. cc orta ![Kapture 2019-11-28 at 9 11 04](https://user-images.githubusercontent.com/6179731/69805299-27a87a80-11bf-11ea-8081-bb10d3d30478.gif) Pull Request resolved: https://github.com/facebook/relay/pull/2953 Reviewed By: josephsavona Differential Revision: D19025678 Pulled By: jstejada fbshipit-source-id: 7493097b666aeda09e92bfd4a94eb9f1a06c3de2

view details

Juan Tejada

commit sha 3c7a75666ef3d0cc9d47d1f86ecffb744bd8f020

v8.0.0 Reviewed By: tyao1 Differential Revision: D19053714 fbshipit-source-id: 2b801c68085b206d47200015aecece5f0b52f3cd

view details

Juan Tejada

commit sha 92b6db97a365883cc284e394b9f02e4b12e6fc81

Docs v8.0.0 Reviewed By: kassens Differential Revision: D19177715 fbshipit-source-id: beda9d351c7ba643e1781f56e41cf84745d070d4

view details

Jan Kassens

commit sha b421819cbe31b6b133418d4d7d3b024fa565780c

rename getModernOperationVariables Summary: Drop the `Modern` from this internal API as it no longer carries meaning. Reviewed By: jstejada Differential Revision: D19163598 fbshipit-source-id: cd824400a9389db45e5b42ed60942dcb7ba9321a

view details

Jan Kassens

commit sha 5febecd25604e15cb14fe918755ae70ef90b261c

drop Relay prefix from ConnectionHandler and ConnectionInterface Summary: These modules are already exported under these shorter names and this brings the internal file names in sync with the publicly exported names. Reviewed By: alunyov Differential Revision: D19164010 fbshipit-source-id: 4e9817036b3fe4a1dba6dd5c5a69c50886518e00

view details

Juan Tejada

commit sha 06d17def8a4f2f59bee1f51711197c2dee9122cc

Update public experimental docs Reviewed By: alunyov Differential Revision: D19180195 fbshipit-source-id: ce322a00387e6a2248e7c016f58841de76c0dcb1

view details

Juan Tejada

commit sha ff3bd43f7db9059235ec5170c2b5f83018badb42

preload/loadQuery should invariant if used during render Reviewed By: tyao1 Differential Revision: D19163471 fbshipit-source-id: 4cfb798e8733e9783068f1cbe8f0ba91e2bad1aa

view details

Tianyu Yao

commit sha 6f8e83d5c48f7039325b8c2693f78ac4398e2bde

Force a refetch in useLazyLoadQueryNode when the component is updated by fast refersh Reviewed By: jstejada Differential Revision: D19129463 fbshipit-source-id: 96f3135f20943e5c88036f2515fc0bd5c7dcd49f

view details

push time in 2 months

push eventrelayjs/relay-examples

Sibelius Seraphini

commit sha ab9bfeba729ceda50c490f2fcec05593c2768a5a

feat(relay): upgrade todo to relay v8

view details

Sibelius Seraphini

commit sha 8db15dc470e92ad010ceede94f49a56a9b127bde

feat(relay): update issue-tracker to relay v8

view details

push time in 2 months

PR merged relayjs/relay-examples

Feat/relay8 CLA Signed

upgrades to relay 8

+174 -418

1 comment

13 changed files

sibelius

pr closed time in 2 months

pull request commentrelayjs/relay-examples

Feat/relay8

Thanks!

sibelius

comment created time in 2 months

push eventfacebook/relay

Relay Bot

commit sha d80fffef5d8f5717f40c25b3f0f983d42f107715

Deploy website Deploy website version based on a2b14aca4ad9133cd7cbca2f35745edf08169f50

view details

push time in 2 months

push eventfacebook/relay

Relay Bot

commit sha b959b1e5b34b2005776b0ecea80805c792520f0c

Deploy website Deploy website version based on 491f75ccce803dc402f8132af062a0e57b1f9577

view details

push time in 2 months

pull request commentfacebook/relay

Docs: update commitMutation.onCompleted docs

Thanks!

mrtnzlml

comment created time in 2 months

pull request commentfacebook/relay

Add environment prop

Sorry for overlooking this a while :(

QueryRenderer API hasn't changed and is indeed missing the environment prop. When switching to useQuery in the future, the env will be provided by the environment provider.

EgorShum

comment created time in 2 months

push eventfacebook/relay

Relay Bot

commit sha b08c6d787316ee271c10809c414d5534f29b6eac

Deploy website Deploy website version based on d1836eb5a3038efeed25e44dacebdca5310fb9b5

view details

push time in 2 months

pull request commentfacebook/relay

Fix quotes in example code

Thanks for the fix!

tmus

comment created time in 2 months

delete branch graphql/graphql-relay-js

delete branch : dependabot/npm_and_yarn/eslint-utils-1.4.3

delete time in 2 months

push eventgraphql/graphql-relay-js

dependabot[bot]

commit sha 53cfbc875629c8906c32eeb266d07994aaea00c6

Bump eslint-utils from 1.3.1 to 1.4.3 (#235) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](https://github.com/mysticatea/eslint-utils/compare/v1.3.1...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 2 months

PR merged graphql/graphql-relay-js

Bump eslint-utils from 1.3.1 to 1.4.3 dependencies

Bumps eslint-utils from 1.3.1 to 1.4.3. <details> <summary>Release notes</summary>

Sourced from eslint-utils's releases.

v1.4.3

🐛 Bug fixes

  • 8f9e481ecc1204c7a1331b697f97903f90c75154 fixed false positive of ReferenceTracker.

v1.4.2

🐛 Bug fixes

  • e4cb01498df6096b66edb0c78965ee6f47d3ac77 fixed a regression of the previous release.

v1.4.1

🐛 Bug fixes

  • c119e832952c8c653bd4f21e39eb9f7ce48e5947 fixed getStaticValue() function to handle null literal correctly even if runtimes don't support BigInt natively.
  • 587cca2f82c245f5fc4a8b9fb2cf6b35c0d02552 fixed getStringIfConstant() function to handle regular expression literals and BigInt literals even if runtimes don't support those.
  • 08158db1c98fd71cf0f32ddefbc147e2620e724c fixed GHSA-3gx7-xhv7-5mx3.

v1.4.0

✨ Enhancements

  • 66456c5356310fc4309b4fe2756995f27b907747 (and ebf5a8378d3f0a20a74adb158a7112cb616bce44, aac472e815551688d23cc8fd88f9044dbf276804) added isParenthesized() function that checks if a given node is parenthesized or not.
  • 4f8407dd6cd52274ba115b3a8558153ec6d799a7 (and cb518c70ee037722f802d808bbbe93da83f07fb3) added hasSideEffect() function that checks if a given node may have side-effects or not. </details> <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+9 -5

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

delete branch graphql/graphql-relay-js

delete branch : dependabot/npm_and_yarn/js-yaml-3.13.1

delete time in 2 months

push eventgraphql/graphql-relay-js

dependabot[bot]

commit sha 471810fe5ef7c2cfcfc3130a8ac9b2afbf8893aa

Bump js-yaml from 3.11.0 to 3.13.1 (#233) Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.11.0 to 3.13.1. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](https://github.com/nodeca/js-yaml/compare/3.11.0...3.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 2 months

PR merged graphql/graphql-relay-js

Bump js-yaml from 3.11.0 to 3.13.1 dependencies

Bumps js-yaml from 3.11.0 to 3.13.1. <details> <summary>Changelog</summary>

Sourced from js-yaml's changelog.

[3.13.1] - 2019-04-05

Security

  • Fix possible code execution in (already unsafe) .load(), #480.

[3.13.0] - 2019-03-20

Security

  • Security fix: safeLoad() can hang when arrays with nested refs used as key. Now throws exception for nested arrays. #475.

[3.12.2] - 2019-02-26

Fixed

  • Fix noArrayIndent option for root level, #468.

[3.12.1] - 2019-01-05

Added

  • Added noArrayIndent option, #432.

[3.12.0] - 2018-06-02

Changed

  • Support arrow functions without a block statement, #421. </details> <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+9 -12

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

delete branch graphql/graphql-relay-js

delete branch : dependabot/npm_and_yarn/fstream-1.0.12

delete time in 2 months

push eventgraphql/graphql-relay-js

dependabot[bot]

commit sha fa11421860d55bd13d20852345c82a76d232cddf

Bump fstream from 1.0.11 to 1.0.12 (#237) Bumps [fstream](https://github.com/npm/fstream) from 1.0.11 to 1.0.12. - [Release notes](https://github.com/npm/fstream/releases) - [Commits](https://github.com/npm/fstream/compare/v1.0.11...v1.0.12) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 2 months

PR merged graphql/graphql-relay-js

Bump fstream from 1.0.11 to 1.0.12 dependencies

Bumps fstream from 1.0.11 to 1.0.12. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+35 -10

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

delete branch graphql/graphql-relay-js

delete branch : dependabot/npm_and_yarn/lodash-4.17.15

delete time in 2 months

push eventgraphql/graphql-relay-js

dependabot[bot]

commit sha 3886ad9297db433e337d30f298046899acd6e280

Bump lodash from 4.17.5 to 4.17.15 (#234) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.5 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.5...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 2 months

PR merged graphql/graphql-relay-js

Bump lodash from 4.17.5 to 4.17.15 dependencies

Bumps lodash from 4.17.5 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+4 -7

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

delete branch graphql/graphql-relay-js

delete branch : dependabot/npm_and_yarn/stringstream-0.0.6

delete time in 2 months

push eventgraphql/graphql-relay-js

dependabot[bot]

commit sha fc50ec70707d189337084ddcd48c772d9a1d482c

Bump stringstream from 0.0.5 to 0.0.6 (#236) Bumps [stringstream](https://github.com/mhart/StringStream) from 0.0.5 to 0.0.6. - [Release notes](https://github.com/mhart/StringStream/releases) - [Commits](https://github.com/mhart/StringStream/compare/v0.0.5...v0.0.6) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 2 months

more