profile
viewpoint
Barthélémy Ledoux elevatebart Wolters Kluwer Chicago SVG Buff, Component Documentation Advocate, CSS maker

elevatebart/eb-typescript 2

Ressource for nov 30th training

elevatebart/vue-cli-plugin-template-loader 2

A plugin to run the vue-template-loader from @ktsn in the vue-cli

elevatebart/vue-ts-plugin 2

Typescript Language Service Plugin for Vue

elevatebart/angular 0

One framework. Mobile & desktop.

elevatebart/AnomalyDetection 0

Anomaly Detection with R

elevatebart/babel 0

🐠 Babel is a compiler for writing next generation JavaScript.

elevatebart/buefy 0

Lightweight UI components for Vue.js based on Bulma

elevatebart/codesandbox-client 0

An online IDE for rapid web development

push eventvue-styleguidist/vue-styleguidist-example

elevatebart

commit sha afd31916dc0a544b34c2e7aeca186b79474d2f39

update keywords

view details

push time in a day

push eventvue-styleguidist/vue-styleguidist-example

elevatebart

commit sha 2781588fc2f9f76b8680980716f54594f485c5a0

last fixes

view details

push time in a day

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 70514b95cea7d689ff404491ddf6d73c20f547a3

fix: update Prism theming & docs

view details

Barthélémy Ledoux

commit sha c78ec63d1231a8efdee6ebd94cc4cfc5541323ac

Merge pull request #759 from vue-styleguidist/dev fix: update Prism theming & docs

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 70514b95cea7d689ff404491ddf6d73c20f547a3

fix: update Prism theming & docs

view details

push time in 2 days

issue commentsatya164/react-simple-code-editor

How do I use CSS prism themes?

Thank you for the tip, it works super-well

elevatebart

comment created time in 2 days

issue commentsatya164/react-simple-code-editor

How do I use CSS prism themes?

the container has no css specifics... I guess I will have to git it one.

elevatebart

comment created time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 921dbd5e26c420d692f607a7f18bcff4e626d404

feat: allow usage of prism themes

view details

elevatebart

commit sha 7a4f7309cea40616f3076c344da9d966d51e58a4

docs: document configuration of prism theme

view details

elevatebart

commit sha d8e4d4dfab49c26be1ca2e254144b57c69a3019e

Revert "refactor: avoid converting events and slots" This reverts commit 88b344310377c6de10a54f3688ff1e0905be1cc6.

view details

Barthélémy Ledoux

commit sha 1e12960b29d6b84bc9a4e724db4f378dc305e3f0

Merge branch 'dev' into feat-prism-editor-styling

view details

Barthélémy Ledoux

commit sha 515b101286dd066bba3592fec243db90b44b53ac

Merge pull request #757 from vue-styleguidist/feat-prism-editor-styling Feature: allow usage of prism editor themes

view details

Barthélémy Ledoux

commit sha 7928b16544e806f6213b6a255431fb2893b61765

Merge pull request #758 from vue-styleguidist/dev chore: deliver

view details

push time in 2 days

PR opened vue-styleguidist/vue-styleguidist

chore: deliver
+519 -239

0 comment

13 changed files

pr created time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 921dbd5e26c420d692f607a7f18bcff4e626d404

feat: allow usage of prism themes

view details

elevatebart

commit sha 7a4f7309cea40616f3076c344da9d966d51e58a4

docs: document configuration of prism theme

view details

Barthélémy Ledoux

commit sha 1e12960b29d6b84bc9a4e724db4f378dc305e3f0

Merge branch 'dev' into feat-prism-editor-styling

view details

Barthélémy Ledoux

commit sha 515b101286dd066bba3592fec243db90b44b53ac

Merge pull request #757 from vue-styleguidist/feat-prism-editor-styling Feature: allow usage of prism editor themes

view details

push time in 2 days

issue closedvue-styleguidist/vue-styleguidist

Editor theme is not applied from the config (v4.2.2)

<!---

Thanks for using Vue Styleguidist! Before you submit, please read the following:

Search open/closed issues before submitting since someone might have asked the same thing before: https://github.com/vue-styleguidist/vue-styleguidist/issues?utf8=%E2%9C%93&q=is%3Aissue

Read essential documentation: https://vue-styleguidist.github.io/getting-started.html

Make sure you’re using the latest versions of Vue Styleguidist.

When something isn’t working for you, include a reproducible demo:

  1. Fork the example project repository: https://github.com/vue-styleguidist/example
  2. Modify it to reproduce the issue.
  3. Push to GitHub and paste the link here.

Most likely you’ll find an issue yourself, while creating a demo.

-->

Looks like specifying a theme for the editor doesn't work anymore (version 4.2.2 of the vue-styleguidist) Tried out on the basic example by adding the following to the config:

	editorConfig: {
		theme: 'night'
	}

Resulting config looks like this (omitted irrelevant parts):

// ... all imports left untouched

module.exports = {
	title: 'Vue Styleguidist basic',
	components: 'src/components/**/[A-Z]*.vue',
	defaultExample: true,
	ribbon: {
		text: 'Back to examples',
		url: `${docSiteUrl}/Examples.html`
	},
	version: '1.1.1',
	webpackConfig: {
		// ... webpack config has been left untouched
	},
	usageMode: 'expand',
	exampleMode: 'expand',
	compilerConfig: {
		target: { ie: 11 }
	},
	styleguideDir: 'dist',
	editorConfig: {
		theme: 'night'
	}
}

closed time in 2 days

ol-ko

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha d8e4d4dfab49c26be1ca2e254144b57c69a3019e

Revert "refactor: avoid converting events and slots" This reverts commit 88b344310377c6de10a54f3688ff1e0905be1cc6.

view details

Barthélémy Ledoux

commit sha 1e12960b29d6b84bc9a4e724db4f378dc305e3f0

Merge branch 'dev' into feat-prism-editor-styling

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha d8e4d4dfab49c26be1ca2e254144b57c69a3019e

Revert "refactor: avoid converting events and slots" This reverts commit 88b344310377c6de10a54f3688ff1e0905be1cc6.

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 7a4f7309cea40616f3076c344da9d966d51e58a4

docs: document configuration of prism theme

view details

push time in 2 days

create barnchvue-styleguidist/vue-styleguidist

branch : feat-prism-editor-styling

created branch time in 2 days

issue commentsatya164/react-simple-code-editor

How do I use CSS prism themes?

I have a workaround but it's one my user would prefer to avoid. Add !important on the background of the style.

elevatebart

comment created time in 2 days

issue openedsatya164/react-simple-code-editor

How do I use CSS prism themes?

<!-- Issues that don't use this template are likely to be closed. --> <!-- Please search the existing issues and read the documentation before opening an issue. -->

Current behaviour

When I use vsc-dark-plus, I can make sure that all torkens have the proper color except for the background.

Expected behaviour

May this line be removed?

https://github.com/satya164/react-simple-code-editor/blob/73b57bf4d548257890f9ed0ee83ee37ec099b256/src/index.js#L625

Code sample

require('./prism-vsc-dark-plus.css')
export default function Editor(){
  return <SimpleEditor
				value={'<Button />'}
				highlight={highlight(isVueSFC ? 'html' : 'jsx')}
				// Padding should be passed via a prop (not CSS) for a proper
				// cursor position calculation
				padding={space[2]}
				// to make sure the css styles for prism are taken into account
				preClassName={'language-jsx'}
			/>
}

Screenshots (if applicable)

<!-- Include screenshots if there's a bug in the rendering. --> Capture d’écran 2020-02-16 à 6 40 23 PM

Your Environment

software version
react-simple-code-editor 0.11.0
react 16
npm or yarn yarn
node 11
browser Firefox & Chrome

created time in 2 days

issue commentvue-styleguidist/vue-styleguidist

Error: require() statements can be added only by editing a Markdown example file

ping @RyanHavoc ?

I would really like to put this bug behind us. Tell me if you have time to chat tomorrow.

Bart

RyanHavoc

comment created time in 2 days

push eventvue-styleguidist/vue-styleguidist-example

elevatebart

commit sha 57146057cf4317b792d9dd1d07118a688916c71c

final update of the sandbox

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 4906894767b9d14bb028a358bfaed69049fed91d

fix: update create-server for codesandbox

view details

elevatebart

commit sha 47eff026ea986e52cbb47a6d12b7c9871d0b2546

docs: update codesandbox url

view details

elevatebart

commit sha 0768c5143d41762caf59f5d07a1e0bc74a2570e3

fix: create-server bis for csb

view details

Barthélémy Ledoux

commit sha c22a96711863bbab6b4f75df057220c6f3474968

Merge pull request #756 from vue-styleguidist/dev chore: deliver

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 0768c5143d41762caf59f5d07a1e0bc74a2570e3

fix: create-server bis for csb

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 47eff026ea986e52cbb47a6d12b7c9871d0b2546

docs: update codesandbox url

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 4906894767b9d14bb028a358bfaed69049fed91d

fix: update create-server for codesandbox

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist-example

elevatebart

commit sha 2c104e8518951858db28f14bd94451cc18452bb8

add sandbox config template nuxt

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 26fccd9a78aba06f0a8403a8ff3123b8a8851aba

fix: stop rendering bad event properties

view details

elevatebart

commit sha 8b0650f08d3c4cde0970fd87aabb439cd1e06ef0

feat: origin column on props event methods & slots

view details

elevatebart

commit sha ba559538e2c6ed968135aedccbab19982d010b1f

docs: fix warning in vuejs

view details

elevatebart

commit sha beb36c578d7de812431fa6c308401a6d41c1be9f

docs: add displayOrigins

view details

elevatebart

commit sha df871dba383b2c01dd6b021d36b62026b70ec447

feat: add displayOrigins to vue-cli-ui

view details

Barthélémy Ledoux

commit sha 84ad9cd943f62e55fcfbaec66f24aa5c2b73ff82

Merge pull request #745 from vue-styleguidist/feat-display-origin Feature: display the origin of a prop

view details

elevatebart

commit sha c68408a4c4c7e004a2cc0df1f502d7c637ff0aa1

refactor: remove all the fat from EventsRenderer

view details

elevatebart

commit sha ae7292354e2f522bfe79ecd27272e8307785d50a

test: test the new origin column to add coverage

view details

elevatebart

commit sha 88b344310377c6de10a54f3688ff1e0905be1cc6

refactor: avoid converting events and slots

view details

elevatebart

commit sha 4b7027ec27a03c8be588d93c3d2e8772e07d45d9

fix: make origin column smaller

view details

elevatebart

commit sha ec86fd4af7c30d631c0d014ff45e1fa5137a6ef7

ci: coverage failing

view details

Barthélémy Ledoux

commit sha a35971ecddfaefdad2cc2e5105c352c451fbc5b1

Merge pull request #755 from vue-styleguidist/dev chore: deliver

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha ec86fd4af7c30d631c0d014ff45e1fa5137a6ef7

ci: coverage failing

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 88b344310377c6de10a54f3688ff1e0905be1cc6

refactor: avoid converting events and slots

view details

elevatebart

commit sha 4b7027ec27a03c8be588d93c3d2e8772e07d45d9

fix: make origin column smaller

view details

push time in 2 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha ae7292354e2f522bfe79ecd27272e8307785d50a

test: test the new origin column to add coverage

view details

push time in 2 days

PR opened vue-styleguidist/vue-styleguidist

chore: deliver
+234 -147

0 comment

41 changed files

pr created time in 3 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha c68408a4c4c7e004a2cc0df1f502d7c637ff0aa1

refactor: remove all the fat from EventsRenderer

view details

push time in 3 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 8b0650f08d3c4cde0970fd87aabb439cd1e06ef0

feat: origin column on props event methods & slots

view details

elevatebart

commit sha ba559538e2c6ed968135aedccbab19982d010b1f

docs: fix warning in vuejs

view details

elevatebart

commit sha beb36c578d7de812431fa6c308401a6d41c1be9f

docs: add displayOrigins

view details

elevatebart

commit sha df871dba383b2c01dd6b021d36b62026b70ec447

feat: add displayOrigins to vue-cli-ui

view details

Barthélémy Ledoux

commit sha 84ad9cd943f62e55fcfbaec66f24aa5c2b73ff82

Merge pull request #745 from vue-styleguidist/feat-display-origin Feature: display the origin of a prop

view details

push time in 3 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha beb36c578d7de812431fa6c308401a6d41c1be9f

docs: add displayOrigins

view details

elevatebart

commit sha df871dba383b2c01dd6b021d36b62026b70ec447

feat: add displayOrigins to vue-cli-ui

view details

push time in 3 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha ba559538e2c6ed968135aedccbab19982d010b1f

docs: fix warning in vuejs

view details

push time in 3 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 26fccd9a78aba06f0a8403a8ff3123b8a8851aba

fix: stop rendering bad event properties

view details

elevatebart

commit sha 8b0650f08d3c4cde0970fd87aabb439cd1e06ef0

feat: origin column on props event methods & slots

view details

push time in 3 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 26fccd9a78aba06f0a8403a8ff3123b8a8851aba

fix: stop rendering bad event properties

view details

push time in 3 days

delete branch elevatebart/vue-cli-plugin-template-loader

delete branch : dependabot/npm_and_yarn/yarn-1.22.0

delete time in 3 days

push eventelevatebart/vue-cli-plugin-template-loader

dependabot[bot]

commit sha 70da55b808eeaf22343dfb6899a4b8ba7de29553

chore(deps): bump yarn from 1.21.1 to 1.22.0 (#14) Bumps [yarn](https://github.com/yarnpkg/yarn) from 1.21.1 to 1.22.0. - [Release notes](https://github.com/yarnpkg/yarn/releases) - [Changelog](https://github.com/yarnpkg/yarn/blob/master/CHANGELOG.md) - [Commits](https://github.com/yarnpkg/yarn/compare/v1.21.1...v1.22.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 3 days

PR merged elevatebart/vue-cli-plugin-template-loader

chore(deps): bump yarn from 1.21.1 to 1.22.0 dependencies

Bumps yarn from 1.21.1 to 1.22.0. <details> <summary>Commits</summary>

This version was pushed to npm by daniel15, a new releaser for yarn since your current version. </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+13 -13

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 days

push eventvue-styleguidist/vue-styleguidist

Bart Ledoux

commit sha 6484a106b2964c5f1858171ad4ad40642a4f98b9

fix(docgen): protect empty comments before slots closes #749

view details

Bart Ledoux

commit sha dcbddf82631d53422d5666ca1eb1971d828b4f04

feat: add tags to slots

view details

Barthélémy Ledoux

commit sha db1595e8a8f43a76afc254be8d0dde2cfbd0e691

Merge pull request #751 from vue-styleguidist/feat-add-tags-to-slots Feature: add tags to slots

view details

Barthélémy Ledoux

commit sha ef341c4d3166bd035461a41b31f1768024141494

Merge pull request #752 from vue-styleguidist/dev chore: deliver

view details

Vue Styleguidist Bot

commit sha ad367f73e6a279623fc83ba824b80b3632f53f4b

chore: v4.8.0 [skip ci]

view details

elevatebart

commit sha 1d3d29e25ee31d6e2ffdc616247d29dadec6700f

fix: protect slots in if statements closes #753

view details

elevatebart

commit sha 3b137028a1a9219500c0491bbdac1fb738bd202d

chore: update react-styleguidist closes #750

view details

Barthélémy Ledoux

commit sha 10062088447a0de0cc9c174b14120b2ca212047c

Merge pull request #754 from vue-styleguidist/dev chore: deliver

view details

Vue Styleguidist Bot

commit sha ceaf60a1911da2accbe4e4c3b7eeb8cd44afcdf5

chore: v4.8.1 [skip ci]

view details

Barthélémy Ledoux

commit sha 3e1c755f3b22dbffea590d83d7aa1b351d743931

Merge branch 'dev' into feat-display-origin

view details

push time in 4 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 1d3d29e25ee31d6e2ffdc616247d29dadec6700f

fix: protect slots in if statements closes #753

view details

elevatebart

commit sha 3b137028a1a9219500c0491bbdac1fb738bd202d

chore: update react-styleguidist closes #750

view details

Barthélémy Ledoux

commit sha 10062088447a0de0cc9c174b14120b2ca212047c

Merge pull request #754 from vue-styleguidist/dev chore: deliver

view details

push time in 5 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 3b137028a1a9219500c0491bbdac1fb738bd202d

chore: update react-styleguidist closes #750

view details

push time in 5 days

issue closedvue-styleguidist/vue-styleguidist

Collapsible sections should open when a search result is hidden under them

Current behavior

When searching, the sections that have search results stay closed and do not display the results.

To reproduce

https://vue-styleguidist.github.io/sections/#/Documentation

When searching for the word File in the Sections demo, the Documentation stays close open.

Expected behavior

When searching for a term, it is expected that we see that term in the results. Therefore, the subsections should toggle when a search results is inside them.

closed time in 5 days

et1421

create barnchelevatebart/buefy

branch : styleguidist

created branch time in 5 days

push eventelevatebart/buefy

Walter Tommasi

commit sha 702d6aad67330e7cf5579328d42d1050eae3759f

Fix #1963 erase number-input value

view details

Walter Tommasi

commit sha 49cf0f920203c6ac2449b73c7dd03dd9504daa7d

Fix #1972 using min and max native datepicker and timepicker props

view details

Walter Tommasi

commit sha b74dcd4291d631317a0d3d4b2b157eb48f1ed478

Close #1970 add accordion prop to menu

view details

armandfarr

commit sha 3e63ed443a4423d92afa23604d5f7db1df137184

Fix typo (#1976)

view details

Walter Tommasi

commit sha 789a956a9181bd6a1f5aa60a0c1f5642dac4d2e1

Update menu api docs

view details

Adrien DAURIAT

commit sha 8dc48498b1801f6e0166ffd000901496b7047814

Fix #1909 Searchable table Header disappear or loses focus (#1967)

view details

willhatchVista

commit sha 8af277012dea5e6c675a803e9700daad68855fd2

fix #1982, searchable able to filter booleans (#1984) * fixes #1982, searchable able to filter booleans * minor update noticed a small detail that was missed

view details

Walter Tommasi

commit sha 287abc17f5a63ade99334eb44b9a56f32dd181f0

Apply #1909 only when sortable

view details

shel

commit sha b41aab04b2f09db64f01e9c2b0db487a9f73b53d

Allow disabling controls to number input (#1989)

view details

Apolokak Lab

commit sha 1d0423522ec2bd1009e521240834b9d657b5b5a1

Add description for rate variables (#1994)

view details

shel

commit sha ab965d3c699fdd085630e271054b56dd35deee95

Update config.js for build (#1992)

view details

Walter Tommasi

commit sha 56c78dbd27f5c8413d8520944535d5cc8efae554

Fix #1812 extending a component

view details

Walter Tommasi

commit sha b78366199e976052a9c372f0a95539556c93c030

Fix #1986 setting 00:00 on datetimepicker

view details

Walter Tommasi

commit sha d9ed5967ebec7568356122f02124cb17cc4a2d95

Update changelog

view details

Eugene Soloviov

commit sha 624cc236b0e88ed3ac6bc9d6718a9c586b7d9ee1

Datepicker mobile modal prop (#1998) * Datepicker mobile modal prop * New prop key * New config key for datepicker mobile modal

view details

Walter Tommasi

commit sha 92608b728f1b96cef26de112dd337c9cd5e77bfd

Update expo

view details

Apolokak Lab

commit sha 5305ab2fd4385985df21ffca720209b9b356d50e

Component: Carousel (#1997)

view details

Walter Tommasi

commit sha 173075b4baf50b60b70c481148b576df0e32d149

Fix carousel

view details

Walter Tommasi

commit sha c3c386fe4d53bac38e7063afe4f5884ca8ec3c06

Update docs

view details

Walter Tommasi

commit sha 3ab736b803206cf87798c3e513ea276796f9e616

Close #2000 add time-creator prop to timepicker

view details

push time in 5 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha 1d3d29e25ee31d6e2ffdc616247d29dadec6700f

fix: protect slots in if statements closes #753

view details

push time in 5 days

issue closedvue-styleguidist/vue-styleguidist

vue-docgen-api gives Cannot read property 'leadingComments' of null warning

Current behavior Using storybook addon-docs (vue-docgen-api version 4.8.0). When adding a the following code to a render function:

        if (this.$slots.default) {
            this.$slots.default.forEach(() => {
              console.log('foo');
            })
        }

See https://github.com/mattgreenfield/storybook-vue-sandbox/blob/leadingComments-warning/src/components/Heading/Heading.vue#L19-L23

I get this warning:

Module Warning (from ./node_modules/vue-docgen-loader/lib/index.js):
[vue-docgen-loader] failed to parse the component file with docgen-api: Cannot read property 'leadingComments' of null

See https://github.com/mattgreenfield/storybook-vue-sandbox/blob/leadingComments-warning/src/components/Button/Button.vue#L19-L23

I don't get this warning if I put the same code in a computed property for a non-render component - see

To reproduce

  • Clone this repo https://github.com/mattgreenfield/storybook-vue-sandbox
  • Checkout to the leadingComments-warning branch
  • npm i && npm run storybook:serve

Expected behavior No warnings, there are no comments to extract.

closed time in 5 days

mattgreenfield

issue commentvue-styleguidist/vue-styleguidist

vue-docgen-api gives Cannot read property 'leadingComments' of null warning

Thanks @mattgreenfield

This is a bug and I shall fix it.

Just out of curiosity, I have never seen this pattern before. What are you trying to loop through in this expression?

mattgreenfield

comment created time in 5 days

push eventstyleguidist/react-styleguidist

Barthelemy Ledoux

commit sha bcca20165553529b081a59aa76d62dc76f44bd80

update snapshots

view details

push time in 6 days

PR opened styleguidist/react-styleguidist

Fix: Open all sections when searching

fix the Error reported in the issue below

https://github.com/vue-styleguidist/vue-styleguidist/issues/750

+42 -3

0 comment

4 changed files

pr created time in 6 days

issue closedvue-styleguidist/vue-styleguidist

vue-docgen-api + property decorator: @ignore doesn't work

Current behavior

@Component
export default class HelloWorld extends Vue {
  /**
   * Message.
   * @ignore
   */
  @Prop() private msg!: string;
}

image

To reproduce

https://github.com/ftes/vue-dogen-property-decorator-ignore-issue/blob/master/src/components/HelloWorld.vue#L40

Expected behavior

The prop should not appear in the generated props table because it is @ignored.

closed time in 6 days

ftes

issue commentvue-styleguidist/vue-styleguidist

vue-docgen-api + property decorator: @ignore doesn't work

docgen 4.8 allows you to add tags to slots documentation ;-)

ftes

comment created time in 6 days

push eventvue-styleguidist/vue-styleguidist

Barthélémy Ledoux

commit sha 3ed4b1acb256826c9a6eba8f3f6f93fda5ad75ca

build: only build basic example on netlify

view details

Bart Ledoux

commit sha c1f62a590c0084b94b49841c3fdfb6dc8c245976

docs: pay for netlify as paypal

view details

Bart Ledoux

commit sha a9016033f548493486a20ccc32aa7c6ceec02bac

docs: contribution commit message updates

view details

Bart Ledoux

commit sha 6484a106b2964c5f1858171ad4ad40642a4f98b9

fix(docgen): protect empty comments before slots closes #749

view details

Bart Ledoux

commit sha dcbddf82631d53422d5666ca1eb1971d828b4f04

feat: add tags to slots

view details

Barthélémy Ledoux

commit sha db1595e8a8f43a76afc254be8d0dde2cfbd0e691

Merge pull request #751 from vue-styleguidist/feat-add-tags-to-slots Feature: add tags to slots

view details

Barthélémy Ledoux

commit sha ef341c4d3166bd035461a41b31f1768024141494

Merge pull request #752 from vue-styleguidist/dev chore: deliver

view details

push time in 6 days

push eventvue-styleguidist/vue-styleguidist

Bart Ledoux

commit sha dcbddf82631d53422d5666ca1eb1971d828b4f04

feat: add tags to slots

view details

Barthélémy Ledoux

commit sha db1595e8a8f43a76afc254be8d0dde2cfbd0e691

Merge pull request #751 from vue-styleguidist/feat-add-tags-to-slots Feature: add tags to slots

view details

push time in 6 days

push eventvue-styleguidist/vue-styleguidist

Bart Ledoux

commit sha dcbddf82631d53422d5666ca1eb1971d828b4f04

feat: add tags to slots

view details

push time in 6 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha ddba2eb4db82d19b10b1e2ca751c83b544208175

feat: extract tags from solts in script

view details

elevatebart

commit sha 592471f242fef077bb13d337254ea7955141a026

fix: review solt comment type

view details

push time in 6 days

push eventvue-styleguidist/vue-styleguidist

Bart Ledoux

commit sha e5d33482d7f78b4789daa31c44e082ff09353adb

test: add test for slot tags in script

view details

push time in 7 days

create barnchvue-styleguidist/vue-styleguidist

branch : feat-add-tags-to-slots

created branch time in 7 days

push eventvue-styleguidist/vue-styleguidist

Bart Ledoux

commit sha 6484a106b2964c5f1858171ad4ad40642a4f98b9

fix(docgen): protect empty comments before slots closes #749

view details

push time in 7 days

issue closedvue-styleguidist/vue-styleguidist

TypeError: Cannot read property 'content' of undefined

Current behavior

<!-- A clear and concise description of what the bug is -->

https://github.com/storybookjs/storybook/issues/9821

vue-docgen-api throws a TypeError when there is a comment line before <slot/> tag and it has no @slot tag.

TypeError: Cannot read property 'content' of undefined
    at /sandbox/node_modules/vue-docgen-api/dist/template-handlers/slotHandler.js:64:25
    at Array.forEach (<anonymous>)
    at slotHandler (/sandbox/node_modules/vue-docgen-api/dist/template-handlers/slotHandler.js:59:18)
    at /sandbox/node_modules/vue-docgen-api/dist/parse-template.js:59:13
    at Array.forEach (<anonymous>)
    at traverse (/sandbox/node_modules/vue-docgen-api/dist/parse-template.js:58:18)
    at traverseAstChildren (/sandbox/node_modules/vue-docgen-api/dist/parse-template.js:43:21)
    at traverse (/sandbox/node_modules/vue-docgen-api/dist/parse-template.js:69:13)
    at Object.parseTemplate [as default] (/sandbox/node_modules/vue-docgen-api/dist/parse-template.js:28:13)
    at Object.<anonymous> (/sandbox/node_modules/vue-docgen-api/dist/parseSFC.js:95:45)

To reproduce

<!-- Post a link to a reproducible demo repository here.

  1. Copy one of the example projects into a repository on github
  2. Modify it to reproduce the issue.
  3. Paste the link here.

Most likely you’ll find an issue yourself, while creating a demo.

Make sure you’re using the latest version of Vue Styleguidist.

-->

  • https://github.com/mattgreenfield/storybook-vue-sandbox (from an original issue)
  • https://codesandbox.io/s/vue-docgen-api-html-comment-4zgc3 (CodeSandbox using vue-docgen-api directly)

Expected behavior

<!-- A clear and concise description of what you expected to happen -->

The tool just ignores the comment line.

closed time in 7 days

pocka

issue commentvue-styleguidist/vue-styleguidist

vue-docgen-api + property decorator: @ignore doesn't work

I could as well implement it in vue-docgen's next major version to ignore it all there.

ftes

comment created time in 7 days

issue commentvue-styleguidist/vue-styleguidist

vue-docgen-api + property decorator: @ignore doesn't work

I believe it should work on props, events and slots. As of today, it only works for props on vue-styleguidist.

Methods are most often internals of components and should not be documented for external usage.

I think VSG 5 should have a story to implement @ignore for slots and events.

What do you think?

ftes

comment created time in 7 days

issue commentvue-styleguidist/vue-styleguidist

Error: require() statements can be added only by editing a Markdown example file

Hello @RyanHavoc

I was wondering if you had time to run through this issue once again? I really want to help you and for that, I need your help.

Would you please create a reproduction repository?

Thank you in advance, Bart

RyanHavoc

comment created time in 7 days

issue closedvue-styleguidist/vue-styleguidist

Using async/await in the examples

Problem

I want to be able to use async/await in the code examples within the guide, however transpiling doesn't seem to work for those and throws this error message:

- CompileError: Transforming async arrow functions is not implemented. Use `transforms: { asyncAwait: false }` to skip transformation and disable this error. (11:10)

This can easily be reproduced in the demo example: https://vue-styleguidist.github.io/basic/ Screenshot_20200129_093220

Additional information

I'm using @babel/core 7 and I tried setting up the runtime transform plugin. Here is my current webpack config:

{
    test: /\.js$/,
    use: {
        loader: 'babel-loader',
        options: {
            sourceType: 'unambiguous',
            plugins: [
                '@babel/plugin-transform-runtime'
            ],
            presets: [
                [
                    '@babel/preset-env',
                    {
                        useBuiltIns: 'usage',
                        corejs: 3,
                        targets: {
                            ie: '11',
                        },
                    },
                ],
            ],
            comments: false,
        },
    },
},

However that configuration still yields the same error message.

Am I running in some configuration issue or is this just not yet supported by the styleguide?

closed time in 7 days

RaffaeleCanale

issue commentvue-styleguidist/vue-styleguidist

Using async/await in the examples

I will close this request for now so that no-one expect it too soon. If I get a lot of traction, I will make it a priority and reopen the request.

Thank you for your interrest @RaffaeleCanale

RaffaeleCanale

comment created time in 7 days

issue commentvue-styleguidist/vue-styleguidist

build overwrites index.html in dist

@joroe, did updating fix your bug?

joroe

comment created time in 7 days

issue commentvue-styleguidist/vue-styleguidist

vue-docgen-api + property decorator: @ignore doesn't work

@pocka, In vue styleguidist, this is handled in the vuedoc-loader.

https://github.com/vue-styleguidist/vue-styleguidist/blob/a9016033f548493486a20ccc32aa7c6ceec02bac/packages/vue-styleguidist/src/loaders/vuedoc-loader.ts#L97-L101

Would you mind dealing with @ignore in your loader too?

ftes

comment created time in 7 days

push eventvue-styleguidist/vue-styleguidist

Bart Ledoux

commit sha f0d29754cc129fcfe95f642943a53116efd73ce3

test: update snapshots

view details

push time in 8 days

push eventvue-styleguidist/vue-styleguidist

Bart Ledoux

commit sha bb6bd78eb62418fc9bae86f9689953564b2c1309

test: fix last mockdoc needing arguments

view details

push time in 8 days

push eventvue-styleguidist/vue-styleguidist

Michelle Osmond

commit sha 6b5b87f65e219ce5798ac0ea044271a25d6ad086

fix(docgen): use webpack modules when resolving paths Pass in modules to makePathResolver closes #743

view details

Barthélémy Ledoux

commit sha e362015f7651e0ff30272537346c8e3d7cc91a01

Merge pull request #746 from yellowsunday/dev fix (docgen): Use webpack modules when resolving paths

view details

Barthélémy Ledoux

commit sha 340317ee5dad22a31c86195ca673196933812972

Merge pull request #747 from vue-styleguidist/dev chore: deliver

view details

Vue Styleguidist Bot

commit sha 1fc2d94d126cf957d4ea6a36cac30e56ca12a81e

chore: v4.7.7 [skip ci]

view details

Barthélémy Ledoux

commit sha 3ed4b1acb256826c9a6eba8f3f6f93fda5ad75ca

build: only build basic example on netlify

view details

Bart Ledoux

commit sha c1f62a590c0084b94b49841c3fdfb6dc8c245976

docs: pay for netlify as paypal

view details

Bart Ledoux

commit sha a9016033f548493486a20ccc32aa7c6ceec02bac

docs: contribution commit message updates

view details

Bart Ledoux

commit sha 364e06b9e7f404bc178a1e3c11309a5edc7029a9

Merge branch 'dev' into feat-display-origin

view details

push time in 8 days

push eventvue-styleguidist/vue-styleguidist

Bart Ledoux

commit sha 513011b674f0504ac74237fcd27fc3d96b133bfb

fix: disp exportName if no displayName for mixins

view details

push time in 8 days

push eventvue-styleguidist/vue-styleguidist

Bart Ledoux

commit sha bd5c41bc8ea767d363c74fc0ecabc3709835f4f2

test: make build pass argunment missing in tests

view details

push time in 8 days

push eventvue-styleguidist/vue-styleguidist

Bart Ledoux

commit sha c1f62a590c0084b94b49841c3fdfb6dc8c245976

docs: pay for netlify as paypal

view details

Bart Ledoux

commit sha a9016033f548493486a20ccc32aa7c6ceec02bac

docs: contribution commit message updates

view details

push time in 8 days

push eventvue-styleguidist/vue-styleguidist

Barthélémy Ledoux

commit sha 3ed4b1acb256826c9a6eba8f3f6f93fda5ad75ca

build: only build basic example on netlify

view details

push time in 8 days

push eventvue-styleguidist/vue-styleguidist

elevatebart

commit sha cca6bb4866714e9e1f9646d7dbed16436fa0cf72

docs: credit vueds and links

view details

elevatebart

commit sha fe7a060c64b2143bb15a745497292497be58fe68

docs: remove all reference to @mixin

view details

elevatebart

commit sha 50d024f0f764db130b886766a790fc78009eabe2

docs: lint basic example

view details

elevatebart

commit sha 185fb229d5404ed5e26e319b499cf13b1e3a5a8a

fix: import of named mixins failing

view details

Barthélémy Ledoux

commit sha b85acf48ae6aec77868ad17c429ed01318e70a3b

Merge pull request #744 from vue-styleguidist/fix-named-mixins fix: import of named mixins failing

view details

Michelle Osmond

commit sha 6b5b87f65e219ce5798ac0ea044271a25d6ad086

fix(docgen): use webpack modules when resolving paths Pass in modules to makePathResolver closes #743

view details

Barthélémy Ledoux

commit sha e362015f7651e0ff30272537346c8e3d7cc91a01

Merge pull request #746 from yellowsunday/dev fix (docgen): Use webpack modules when resolving paths

view details

Barthélémy Ledoux

commit sha 340317ee5dad22a31c86195ca673196933812972

Merge pull request #747 from vue-styleguidist/dev chore: deliver

view details

push time in 8 days

issue commentvue-styleguidist/vue-styleguidist

Docgen cannot find imported dependencies in custom webpack 'modules' paths

it is just out of date docs. Will fix it this morning

yellowsunday

comment created time in 8 days

PR opened vue-styleguidist/vue-styleguidist

chore: deliver
+303 -225

0 comment

31 changed files

pr created time in 8 days

push eventvue-styleguidist/vue-styleguidist

Michelle Osmond

commit sha 6b5b87f65e219ce5798ac0ea044271a25d6ad086

fix(docgen): use webpack modules when resolving paths Pass in modules to makePathResolver closes #743

view details

Barthélémy Ledoux

commit sha e362015f7651e0ff30272537346c8e3d7cc91a01

Merge pull request #746 from yellowsunday/dev fix (docgen): Use webpack modules when resolving paths

view details

push time in 8 days

PR merged vue-styleguidist/vue-styleguidist

fix (docgen): Use webpack modules when resolving paths

Pass in modules to makePathResolver

closes #743

+1 -1

2 comments

1 changed file

yellowsunday

pr closed time in 8 days

issue closedvue-styleguidist/vue-styleguidist

Docgen cannot find imported dependencies in custom webpack 'modules' paths

Current behavior

When the styleguide parses a .vue containing an import statement that references a file relative to a custom source directory that was defined in the webpack config "resolve.modules", it cannot find it and prints an error of the form:

Neither 'foo/bar.js.vue' nor 'foo/bar.js.js(x)' or 'foo/bar.js/index.js(x)' or 'foo/bar.js/index.ts(x)' could be found in '/media/path/to/src/components'

To reproduce

I encountered this with a webpack config that had 'modules' in the webpack config with two absolute file paths, the first to the source directory and the second to the node_modules. The Vue component was importing a JS util file using a path relative to the source directory.

In this case, I found that editing node_modules/vue-docgen-api/dist/utils/documentRequiredComponents.js made the error go away:

     // added opt.modules as 3rd argument
      pathResolver = makePathResolver_1.default(originalDirName, opt.alias, opt.modules);

I tried to reproduce it with the Basic example, and it was similar though not precisely the same - I modified the examples/basic/styleguide.config.js with:

    webpackConfig: {
        resolve: {
            modules: [
               path.resolve(__dirname, "../"),   // i.e. the 'examples' folder
               path.resolve(__dirname, "../../node_modules"),
               // also had to add this to fix startup errors
               path.resolve(__dirname, "../../packages/vue-styleguidist/node_modules")
            ],
            alias: ...etc
        }
    }

and the Button.vue to use: import loggerMixin from 'basic/src/mixins/loggerMixin'

This time it seems to get fixed by passing in the opt.modules in the packages/vue-docgen-api/dist/script-handlers/mixinsHandler.js. I guess this might be because it's actually a mixin being imported instead of a simple JS.

Expected behavior

No console error is printed.

I'm a little surprised that I haven't run into this before, but perhaps it's more usual for projects to define an alias to their source folders instead of adding them to the module paths.

Thanks in advance for looking at this!

closed time in 8 days

yellowsunday

issue commentvue-styleguidist/vue-live

Failed to mount component: template or render function not defined.

I did try it again and created PR#1 to show what I mean. It still works.

ManUtopiK

comment created time in 10 days

issue commentvue-styleguidist/vue-live

Failed to mount component: template or render function not defined.

Would you mind joining me on VueLand to try to figure out this mystery together? Since we both are french it might even be easier to talk in french there. Less "lost in translation" ;)

ManUtopiK

comment created time in 10 days

PR opened ManUtopiK/nuxt-vue-live

update to 1.5.1

in this setting, if I do npm ci & npm run generate, I do get the following html in index.html:

<div class="vue-live-container" style="display:flex">
                <div style="width:50%">
                  <div class="prism-editor-wrapper">
                    <!---->
                    <pre
                      contenteditable="true"
                      spellcheck="false"
                      autocapitalize="off"
                      autocomplete="off"
                      autocorrect="off"
                      data-gramm="false"
                      class="prism-editor__code language-html"
                    ><code class="language-markup"><span class="token tag"><span class="token tag"><span class="token punctuation">&lt;</span>span</span><span class="token punctuation">></span></span>test<span class="token tag"><span class="token tag"><span class="token punctuation">&lt;/</span>span</span><span class="token punctuation">></span></span> <span class="token tag"><span class="token tag"><span class="token punctuation">&lt;</span>Logo</span> <span class="token punctuation">/></span></span></code></pre>
                  </div>
                </div>
                <div style="background-color:#fff;width:50%">
                  <div>
                    <!---->
                    <div id="v-2e540a4d">
                      <span>test</span>
                      <svg
                        width="245"
                        height="180"
                        viewBox="0 0 452 342"
                        xmlns="http://www.w3.org/2000/svg"
                        class="NuxtLogo"
                      >
                        <g fill="none" fill-rule="evenodd">
                          <path
                            d="M139 330l-1-2c-2-4-2-8-1-13H29L189 31l67 121 22-16-67-121c-1-2-9-14-22-14-6 0-15 2-22 15L5 303c-1 3-8 16-2 27 4 6 10 12 24 12h136c-14 0-21-6-24-12z"
                            fill="#00C58E"
                          ></path>
                          <path
                            d="M447 304L317 70c-2-2-9-15-22-15-6 0-15 3-22 15l-17 28v54l39-67 129 230h-49a23 23 0 0 1-2 14l-1 1c-6 11-21 12-23 12h76c3 0 17-1 24-12 3-5 5-14-2-26z"
                            fill="#108775"
                          ></path>
                          <path
                            d="M376 330v-1l1-2c1-4 2-8 1-12l-4-12-102-178-15-27h-1l-15 27-102 178-4 12a24 24 0 0 0 2 15c4 6 10 12 24 12h190c3 0 18-1 25-12zM256 152l93 163H163l93-163z"
                            fill="#2F495E"
                            fill-rule="nonzero"
                          ></path>
                        </g>
                      </svg>
                    </div>
                  </div>
                </div>
              </div>
+15 -12

0 comment

3 changed files

pr created time in 10 days

push eventelevatebart/nuxt-vue-live

elevatebart

commit sha b34edf661c0ff7736dd9d2a8304644bfb2a953c4

update to 1.5.1

view details

push time in 10 days

more