profile
viewpoint
Monroe Ekilah ekilah San Francisco, CA ekilah.github.io USC alum ✌️

ekilah/inCHROMEnter 2

A simple Chrome extension to increment/decrement the URL of the current tab for fast browsing.

alghanmi/github_orgman 1

GitHub Organization Manager Scripts

ekilah/codepathgoogleimages 0

Google images search for android training class with codepath

ekilah/codepathtodo 0

A short demo project for Android for a @codepath training class

ekilah/create-react-app-buildpack 0

⚛️ Heroku Buildpack for create-react-app: static hosting for React.js web apps

ekilah/cs485_finalproject 0

Final project for Databases class - using IBD DB2 and JDBC for some simple database manipulation practice in a new SQL iteration.

ekilah/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

pull request commentCircleCI-Public/build-tools-orb

[semver:minor] Add merge-with-parent command.

Is there a plan to add documentation to the README about how to use this feature? I got here from https://ideas.circleci.com/cloud-feature-requests/p/show-test-results-for-prospective-merge-of-a-github-pr but this PR is the only evidence that this exists here as far as I saw.

gmemstr

comment created time in 6 hours

startedYqnn/svg-path-editor

started time in 12 hours

issue openedYqnn/svg-path-editor

Support scientific notation decimals

this path does not work in your tool:

M3 -1.48562e-06L0.113249 5L5.88675 5L3 -1.48562e-06Z

However it works as soon as you replace the two instances of -1.48562e-06 with -0.00000148562 .

M3 -0.00000148562L0.113249 5L5.88675 5L3 -0.00000148562Z

created time in 12 hours

issue commentGifox/Tracker

Something went wrong – export takes long time and eventually fails

I am all but certain I already had 2.2.4.04 yesterday, but I tried again just to make sure with your link, same error (you should consider adding that last build number .04 in the diagnostic data logs?)

image

image

App Logs.txt App Settings.txt

As you said, my settings don't seem to indicate an issue like you described: image

ianbytchek

comment created time in 9 days

issue commentGifox/Tracker

Something went wrong – export takes long time and eventually fails

The progress bar now gets to about 2/3 full before failing, but it still fails consistently on 2.2.4 for me today:

App Logs.txt App Settings.txt

Quitting and restarting, opening the editor shows the recording just fine, but clicking "Done" there does not get the export to work like it used to after an app restart, so this is less usable for me now than the 2.2.2 revert has been where I can at least do that.

ianbytchek

comment created time in 9 days

issue commentMoxio/stylelint-selector-tag-no-without-class

Support nested selectors

Hmm I see. Do you know of another plugin like that? Thanks for replying!

ekilah

comment created time in 22 days

issue openedMoxio/stylelint-selector-tag-no-without-class

Support nested selectors

.someClass {
  padding: 20px;

  & h2 {
    width: 500px;
  }
}

This CSS should not be considered invalid by this plugin, but is. Many of the default rules in stylelint understand the meaning of this nesting operator &, I'm not sure how much work it would be to support from your plugin.

created time in 22 days

issue commentmrmckeb/typescript-plugin-css-modules

Additional configuration needed in IntelliJ IDEs?

yeah, now that #99 is fixed, I get those too, using TS 4.0.2. image image image

fgblomqvist

comment created time in a month

issue commentmrmckeb/typescript-plugin-css-modules

Lots of errors produced in WebStorm IDE with this plugin

@mrmckeb there is no issue. I was just showing it working.

ekilah

comment created time in a month

issue commentmrmckeb/typescript-plugin-css-modules

Lots of errors produced in WebStorm IDE with this plugin

image

Seems to work great now in WebStorm. I will say, the editor did seem to take a while to load up the TS service when I added the plugin back in, I wonder how heavy this is.

Also the readonlys in the error message are a bit distracting, since they are repeated a lot. Was that a "just for correctness" piece or does it actually do something important? (idk how the internals of the plugin work)

ekilah

comment created time in a month

pull request commentdate-fns/date-fns

Fix closestTo should possibly return undefined

@V-Gutierrez thanks for picking up the issue I created! 🎉

V-Gutierrez

comment created time in a month

issue commentmrmckeb/typescript-plugin-css-modules

Lots of errors produced in WebStorm IDE with this plugin

Same here. Glad to hear this is reproducible in a more-widely available IDE!

ekilah

comment created time in a month

issue commentmrmckeb/typescript-plugin-css-modules

Lots of errors produced in WebStorm IDE with this plugin

Sure, will do tomorrow.

ekilah

comment created time in a month

issue commentmrmckeb/typescript-plugin-css-modules

Lots of errors produced in WebStorm IDE with this plugin

The same error as the original post, with or without my patch and with or without your beta, unfortunately

ekilah

comment created time in a month

pull request commentmrmckeb/typescript-plugin-css-modules

Use let instead of const

replied over at https://github.com/mrmckeb/typescript-plugin-css-modules/issues/97#issuecomment-692285923

ekilah

comment created time in a month

issue commentmrmckeb/typescript-plugin-css-modules

Lots of errors produced in WebStorm IDE with this plugin

Hm, I tried the beta today and I get the same errors. I realize the reason the errors were gone when using my patch was probably because I was using the following in package.json: "typescript-plugin-css-modules": "https://github.com/ekilah/typescript-plugin-css-modules#patch-2",

That doesn't get 'built', so the directory in node_modules only has TS files. Maybe this was just preventing the editor from running the plugin at all, and it was failing silently.

I changed package.json from prepublishOnly to prepare as suggested by https://stackoverflow.com/questions/40528053/npm-install-and-build-of-forked-github-repo and installed my patch again, and was able to see errors still. So, I guess there is another issue causing this.

ekilah

comment created time in a month

push eventekilah/typescript-plugin-css-modules

Monroe Ekilah

commit sha 2d0eb54c95b6cab3b90c38b7ecff3f395322b670

prepare so that git links in package.json work

view details

push time in a month

issue commentmrmckeb/typescript-plugin-css-modules

Additional configuration needed in IntelliJ IDEs?

@fgblomqvist can you show screenshots of the plugin working in your JetBrains editor, so I can see more about what it adds for you? I haven't seen this plugin add anything to the default behavior already present in WebStorm yet. I know what it does for my coworkers in VSCode, though.

Regarding your workaround / fix to get things going:

Turns out that my IntelliJ couldn't properly find the plugin yesterday (we use lerna and it seems like you have to put the plugin the same package that the typescript is coming from, aka. the root package).

I'm not sure what package you're referring to or what you changed. This may or may not be relevant to my use case?

fgblomqvist

comment created time in a month

pull request commentmrmckeb/typescript-plugin-css-modules

Use let instead of const

Thanks for getting back to me!

I rebased to get the TS 4.0 fix in #101, and updated the snapshots with yarn jest -u.

Without my patch: Screen Shot 2020-09-12 at 11 48 30 AM

With my patch: Screen Shot 2020-09-12 at 12 08 10 PM

Note that this just prevents the spammy errors in WebStorm; as far as I can tell, this plugin doesn't add any functionality in WebStorm. Without this plugin, WebStorm can already do this:

Screen Shot 2020-09-12 at 12 10 48 PM

That last statement somewhat conflicts with #96 - the OP seems to get some use out of this plugin that I'm not seeing, but at least this PR fixes the errors.

ekilah

comment created time in a month

push eventekilah/typescript-plugin-css-modules

Brody McKee

commit sha 9c190d2381d252be553f59922d6cd1065308f0b6

Merge branch 'release/2.5.0' into develop

view details

Monroe Ekilah

commit sha d5cb23525ee2947629acb2d3392025fc5c06af60

Use let instead of const Fixes #97

view details

Monroe Ekilah

commit sha 8d6724b771811d555b58123be51fa255ccf5f2f6

ran `yarn test -u`

view details

push time in a month

push eventekilah/typescript-plugin-css-modules

Brody McKee

commit sha f6ca99923315fd8972c091cced9a61fb42a51854

Merge branch 'release/1.1.0'

view details

Brody McKee

commit sha 48a35e0a44948525cd6993835ad978f7b14a236c

Merge branch 'release/1.1.1'

view details

Brody McKee

commit sha 9c2a3df5828accf688a7bd059733e9f73a4dcdbb

Merge branch 'release/1.2.0'

view details

Brody McKee

commit sha 4641eb63ea07dae19c3e8378481cc24c6fc214ed

Merge branch 'release/1.2.1'

view details

Brody McKee

commit sha c8048177c856a8e6639beded13d315a534544b8d

Merge branch 'release/1.3.0'

view details

Brody McKee

commit sha bd617032caf9b3e71fb9d355dddd9d36a8ca7bcd

Merge branch 'release/2.0.0'

view details

Brody McKee

commit sha b0f9527b22daeff1a0af31d3f3c8d6b91f4fe5c7

Merge branch 'release/2.0.1'

view details

Brody McKee

commit sha 88e0d73e7425eb7bcd8f40ba794badfe7faa11b9

Merge branch 'release/2.0.2'

view details

Brody McKee

commit sha cf8359f85496db3c16d8cb8f34b8861a085272be

Merge branch 'release/2.1.0'

view details

Brody McKee

commit sha b7f68de2decb5c57631c24cfc7c8d2db5c1a8dba

Merge branch 'release/2.1.1'

view details

Brody McKee

commit sha 468b6a1a43861c546fc5006698e4e6263e38be83

Merge branch 'release/2.1.2'

view details

Brody McKee

commit sha 81f36198a070f56cd7e6d7b52a81863a54055c5f

Merge branch 'release/2.2.0'

view details

Brody McKee

commit sha 72daeb8d8e9782cbf431e5631dbba0339b65b523

Merge branch 'release/2.3.0'

view details

Brody McKee

commit sha 86af6ed0e35e7dbbb349f13b39aca645787428d3

Merge branch 'release/2.4.0'

view details

Brody McKee

commit sha badd442694eddc02db6afa859879f73345bdf33f

feat: loosen TypeScript peer dependency version

view details

Brody McKee

commit sha 2798a3a04e9da9a61a8e092501ab1f51cbc31ca7

chore: bump version

view details

Brody McKee

commit sha a91ae5d7197d22e714493e5f960d626b43a67ca3

Merge branch 'release/2.5.0'

view details

Brody McKee

commit sha 7230208ad44ddb1e961d745154a53b0db1d4fdfd

feat: loosen TypeScript peerDependency version

view details

Brody McKee

commit sha 1171b339cfff5203cfec56a79d10b77fc69ec2f4

chore: bump version

view details

Brody McKee

commit sha 1743843d4c5d0954dfe06de8977d7399d240207a

Merge branch 'release/2.5.0'

view details

push time in a month

issue commentmrmckeb/typescript-plugin-css-modules

Support TS 4.0+

thanks!

ekilah

comment created time in a month

issue commentlavv17/lftp

Publishing a new release

I am new and have no idea how debian's package updates system works, but I happen to be using lftp on a debian box. I came here looking if it would be possible to get 4.8.0+ on debian, apt-get only sees 4.7.1-1. Any advice would be appreciated!

dns2utf8

comment created time in a month

pull request commentmrmckeb/typescript-plugin-css-modules

Use let instead of const

Thanks for your valuable insight.

ekilah

comment created time in 2 months

pull request commentmrmckeb/typescript-plugin-css-modules

Use let instead of const

So is having clear expectations and instructions on a project that anticipates public input from people unfamiliar with the codebase. Not getting a reply in 3 weeks isn't a good incentive to go diving into the various test suites to fix CI either.

But I'm not here to complain, I'm just trying to report an issue and help solve it. I don't think the subtle condescension about the importance of doing this and that are productive or earned.

If you don't mind posting the set of commands necessary to do what you're asking for, I can do that next time I have some time. You neglected to include instructions.

ekilah

comment created time in 2 months

pull request commentmrmckeb/typescript-plugin-css-modules

Use let instead of const

I did nothing like that no. I don't see any instructions on the repo's markdown files describing how to do what you are implying is necessary. Let me know and I can try those things.

ekilah

comment created time in 2 months

issue commentGifox/Tracker

Something went wrong – export takes long time and eventually fails

BenQ monitor here. Gifs fail now immediately after restarting the app too on the latest update, which means it's completely unusable now.

ianbytchek

comment created time in 2 months

pull request commentjneen/parsimmon

workaround for broken Edge versions 15-18

Awesome 🥳 Thanks for your help debugging & getting this live!

ekilah

comment created time in 2 months

delete branch ekilah/parsimmon

delete branch : fixEdge18

delete time in 2 months

Pull request review commentjneen/parsimmon

workaround for broken Edge versions 15-18

 ## version 1.16.0 (2020-08-25) -- Adds `Parsimmon.flags(regexp)` export-- Fixes `Parsimmon.flags(regexp)` to work in older browsers (Edge versions 15-18)+- Fixes `flags(regexp)` to work in older browsers (Edge versions 15-18), which fixes crashes on startup in those old clients

sure, solved, and thanks!

ekilah

comment created time in 2 months

PullRequestReviewEvent

push eventekilah/parsimmon

Monroe Ekilah

commit sha 62246d8cd84cffb0ce512ee53fa231fd08815c6d

changelog

view details

push time in 2 months

pull request commentjneen/parsimmon

workaround for broken Edge versions 15-18

Personally I think the test is harder to read / isn't as obviously testing the behavior it is testing this way, and it doesn't test the return value of flags() anymore.

ekilah

comment created time in 2 months

push eventekilah/parsimmon

Monroe Ekilah

commit sha 1033d7becdcfe18cc64e77ac4b2f8db20de364b9

dont export flags for test

view details

push time in 2 months

pull request commentjneen/parsimmon

workaround for broken Edge versions 15-18

@wavebeem alright, I think this should be complete. I added the changelog entries, but I guess it's a bit weird since idk if you'll actually release it with that version number. Let mek now if this needs to be squashed or if you'll do that, etc.

ekilah

comment created time in 2 months

push eventekilah/parsimmon

Monroe Ekilah

commit sha d07bcb7a5567a4183cfdae8afc2e52aff1f47159

remove eslint-ignore

view details

push time in 2 months

Pull request review commentjneen/parsimmon

workaround for broken Edge versions 15-18

     "Parsimmon": true,     "assert": true,     "testSetScenario": true+  },+  "rules": {+    "no-invalid-regexp": ["error", {"allowConstructorFlags": ["u", "y"]}]

ESLint doesn't like these flags. And this override doesn't work if you define the Regexp like /a/gimuy, you have to use the new Regexp constructor, apparently.

ekilah

comment created time in 2 months

PullRequestReviewEvent

push eventekilah/parsimmon

Monroe Ekilah

commit sha a0408b4fcec41fddf4f2ad23686372be0d2e3dbf

markdown files

view details

push time in 2 months

push eventekilah/parsimmon

Monroe Ekilah

commit sha 0577c93c6562a38e2b0d1b7c4291fea071bae071

100% test coverage

view details

push time in 2 months

push eventekilah/parsimmon

Monroe Ekilah

commit sha 9372b12470030d989d3e9a1ab74a0964bef2d658

lint:fix

view details

Monroe Ekilah

commit sha 37b45b17e874211747d6bc900fd7822a44715fbc

add test for flags function

view details

push time in 2 months

issue openeddate-fns/date-fns

`closestTo` TS typings are incorrect

If you give the closestTo function an empty list of dates, it returns undefined. This is not represented in the TS typings.

created time in 2 months

delete branch ekilah/create-react-app-buildpack

delete branch : patch-1

delete time in 2 months

push eventMercuryTechnologies/create-react-app-buildpack

Monroe Ekilah

commit sha 7165234655a4c23b3bf82571481fbef0fc73e245

Add buildpack for cleaning up the deployed slug Heroku currently copies our entire repo from `git`, builds the production app, and then copies the entire directory (including the consumed source files etc) to the machine(s) serving the app. We don't need most of that stuff in there, and now (mostly since `node_modules` has gotten quite large, but also other things, like our source images/svgs are there twice) it has gotten big enough (>300MB) that Heroku is starting to warn us about the size. `heroku-buildpack-post-build-clean` takes a `.slug-post-clean` file and deletes things you don't need in there after the build process. My fork gets rid of some errors because comments in the file weren't being ignored previously.

view details

Monroe Ekilah

commit sha 9e0128f482170a304051b67ba644438b09768085

Merge pull request #2 from ekilah/patch-1 Add buildpack for cleaning up the deployed slug

view details

push time in 2 months

PR merged MercuryTechnologies/create-react-app-buildpack

Add buildpack for cleaning up the deployed slug

Heroku currently copies our entire repo from git, builds the production app, and then copies the entire directory (including the consumed source files etc) to the machine(s) serving the app.

We don't need most of that stuff in there, and now (mostly since node_modules has gotten quite large, but also other things, like our source images/svgs are there twice) it has gotten big enough (>300MB) that Heroku is starting to warn us about the size.

heroku-buildpack-post-build-clean takes a .slug-post-clean file and deletes things you don't need in there after the build process. My fork gets rid of some errors because comments in the file weren't being ignored previously.

+1 -0

0 comment

1 changed file

ekilah

pr closed time in 2 months

PR opened MercuryTechnologies/create-react-app-buildpack

Add buildpack for cleaning up the deployed slug

Heroku currently copies our entire repo from git, builds the production app, and then copies the entire directory (including the consumed source files etc) to the machine(s) serving the app.

We don't need most of that stuff in there, and now (mostly since node_modules has gotten quite large, but also other things, like our source images/svgs are there twice) it has gotten big enough (>300MB) that Heroku is starting to warn us about the size.

heroku-buildpack-post-build-clean takes a .slug-post-clean file and deletes things you don't need in there after the build process. My fork gets rid of some errors because comments in the file weren't being ignored previously.

+1 -0

0 comment

1 changed file

pr created time in 2 months

push eventekilah/create-react-app-buildpack

Monroe Ekilah

commit sha 7165234655a4c23b3bf82571481fbef0fc73e245

Add buildpack for cleaning up the deployed slug Heroku currently copies our entire repo from `git`, builds the production app, and then copies the entire directory (including the consumed source files etc) to the machine(s) serving the app. We don't need most of that stuff in there, and now (mostly since `node_modules` has gotten quite large, but also other things, like our source images/svgs are there twice) it has gotten big enough (>300MB) that Heroku is starting to warn us about the size. `heroku-buildpack-post-build-clean` takes a `.slug-post-clean` file and deletes things you don't need in there after the build process. My fork gets rid of some errors because comments in the file weren't being ignored previously.

view details

push time in 2 months

push eventekilah/create-react-app-buildpack

Monroe Ekilah

commit sha 6d12a7e2dcf42310404377ee447cbcdc83ebaf89

use fork of post-build-clean to ignore comments

view details

push time in 2 months

push eventekilah/heroku-buildpack-post-build-clean

Monroe Ekilah

commit sha 48a468eb46b5ff6f458f3445ac38f699e19bcf43

ignore comment lines in .slug-post-clean

view details

push time in 2 months

fork ekilah/heroku-buildpack-post-build-clean

Buildpack to remove unwanted files from the slug post-build

fork in 2 months

push eventekilah/create-react-app-buildpack

Monroe Ekilah

commit sha a32fe9f2c7f6270d9234710e81b3e9053a53b9df

revert to old pinned buildpacks heroku crashes with the new ones and i haven't figured out why yet

view details

push time in 2 months

push eventekilah/create-react-app-buildpack

Monroe Ekilah

commit sha d81290ba36251dc93cb6fc95840679a21a2b67b3

add post-build-clean buildpack https://github.com/sibnerian/heroku-buildpack-post-build-clean/tree/3adfa61844ff2dd34ed9517fc5da4e1c8244c69b this is for removing stuff from the heroku deployment after building, since things like the raw `node_modules` and all of our source, etc., are left there, which takes space

view details

push time in 2 months

issue openedmrmckeb/typescript-plugin-css-modules

Support TS 4.0+

Pretty simple, the package.json should support TS 4.0 which was just released. I would submit a PR to make the change, but I'm not sure what you'd prefer to use, e.g. ^3.0.0 || ^4.0.0 would work, or >= 3.0.0. Depends on your preferences I guess.

(TS doesn't use semantic versioning, so 3.9 -> 4.0 is no different than 3.9 -> 3.10 to them.)

created time in 2 months

pull request commentjneen/parsimmon

workaround for broken Edge versions 15-18

Sure, I added that instead. I agree the way flags worked before was a bit messy, and I wasn't aware of these other flags before.

I tested the 5 boolean flags in my production environment, it looks like re.unicode doesn't work properly on these versions of Edge:

Using this regex: /[0-9]/gimuy I logged this:

    {
        regexStr: '' + regex,
        global: regex.global ?? 'undefined var',
        ignoreCase: regex.ignoreCase ?? 'undefined var',
        multiline: regex.multiline ?? 'undefined var',
        unicode: regex.unicode ?? 'undefined var',
        sticky: regex.sticky ?? 'undefined var',
      }

and got this:

image

Mostly just noting this for you if it ever comes up. I doubt it will!

As for the tests and whatnot, sure, I can do some of that maybe later in the week. As a suggestion - the README on contributing should mention the linter and/or test coverage expectations. I'd add them but I don't know what the expectations are 😄

ekilah

comment created time in 2 months

create barnchekilah/create-react-app-buildpack

branch : mercury-pins

created branch time in 2 months

fork ekilah/create-react-app-buildpack

⚛️ Heroku Buildpack for create-react-app: static hosting for React.js web apps

fork in 2 months

pull request commentheroku/heroku-buildpack-nodejs

move disabling yarn caching to YARN_CACHE env var

Forgive me if I'm mistaken, I am new to reading this codebase, but:

https://github.com/heroku/heroku-buildpack-nodejs/blob/77b953be1a71cff4dfcc956e53232f8433d74233/lib/cache.sh#L47-L58

Does this code also need to be changed to read the new env var instead?

lillianzhang331

comment created time in 2 months

push eventekilah/parsimmon

Monroe Ekilah

commit sha cc668ff9599af4e29e89a71312517c92d354ba06

use .flags when it is present

view details

push time in 2 months

issue commentjneen/parsimmon

MS Edge 18 error

I've put the below results of my testing in a PR (https://github.com/jneen/parsimmon/pull/304). It does seem like the literal string "undefined" is rendered to the regex when it is stringified on these old browser versions.

ekilah

comment created time in 2 months

PR opened jneen/parsimmon

workaround for broken Edge versions 15-18

Fixes https://github.com/jneen/parsimmon/issues/303

Summary of problem

We saw these reports in our bug tracker:

Error unsupported regexp flag "n": /[0-9]/undefined 
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:6716 Anonymous function
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:6560 K
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:11055 Anonymous function
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:348 r
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:407 Anonymous function
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:199 Anonymous function
    node_modules/parsimmon/build/parsimmon.umd.min.js:1 Anonymous function
    webpack/bootstrap:25:3 __webpack_require__
    https://mywebsite.com/static/js/main.abc.js:1:123 Anonymous function
    webpack/bootstrap:25:3 __webpack_require__

These errors were coming from MS Edge versions 15-18, but I couldn't find a way to download and install that version to test for myself. It seemed like that browser was rendering the literal string "undefined" at the end of regular expressions when they were printed as strings.

Research

To get some data from our prod environment, I added the following code to parsimmon:


function flags(re) {
  var s = "" + re;
  var fs = s.slice(s.lastIndexOf("/") + 1);
  if (fs === "undefined" || fs === undefined) {
    // eslint-disable-next-line no-console, no-undef
    console.warn('Flags of regex were undefined.', {re: re, s: s, fs: fs, typeofFs: typeof fs})
    return ""
  }
  return fs
}

and got this output from Edge versions 17 and 18:

{
  "re":{},
  "s":"/[0-9]/undefined",
  "fs":"undefined",
  "typeofFs":"string"
}

I also added this above var digit = regexp(/[0-9]/).desc("a digit"); so it would run when parsimmon is imported in my project:

var reTest = new RegExp(/[0-9]/)
var reWithFlagTest = new RegExp(/[0-9]/i)
var strTest = new RegExp("[0-9]")

// eslint-disable-next-line no-console, no-undef
console.warn('Debugging regexes:', {
  re: {
    asString: '' + reTest,
    flagsDefined: typeof reTest.flags === 'string',
    flags: reTest.flags,
  },
  reWithFlag: {
    asString: '' + reWithFlagTest,
    flagsDefined: typeof reWithFlagTest.flags === 'string',
    flags: reWithFlagTest.flags,
  },
  str: {
    asString: '' + strTest,
    flagsDefined: typeof strTest.flags === 'string',
    flags: strTest.flags,
  },
})

and got this output from Edge versions 17 and 18:

{
  "re":{
    "asString":"/[0-9]/undefined",
    "flagsDefined":false
  },
  "reWithFlag":{
    "asString":"/[0-9]/undefined",
    "flagsDefined":false
  },
  "str":{
    "asString":"/[0-9]/undefined",
    "flagsDefined":false
  }
}

Fix

To fix this, we can detect undefined as the flags string and overwrite it.

+6 -1

0 comment

1 changed file

pr created time in 2 months

create barnchekilah/parsimmon

branch : fixEdge18

created branch time in 2 months

push eventekilah/parsimmon

Monroe Ekilah

commit sha 272f67beb38b410b5ecdeaae10fd82dc6e9c931a

add workaround to flags

view details

push time in 2 months

push eventekilah/parsimmon

Monroe Ekilah

commit sha a341d98071c3381c335c34a49b2463c12c0e081f

add workaround to flags

view details

push time in 2 months

push eventekilah/parsimmon

Monroe Ekilah

commit sha 3ce9e6850a76138c504c8617a48bf9ea94061258

console warn to test regexes as strings

view details

push time in 2 months

push eventekilah/parsimmon

Monroe Ekilah

commit sha 6d4565d98d77b0ec056fbca703a3c24eef92fae3

console warn to test regexes as strings

view details

push time in 2 months

create barnchekilah/parsimmon

branch : debuggingEdge18

created branch time in 2 months

fork ekilah/parsimmon

A monadic LL(infinity) parser combinator library for javascript

fork in 2 months

issue commentjneen/parsimmon

MS Edge 18 error

It seems literally impossible to find a way to install this ancient version of Edge, I can't find an installer anywhere... 😬

ekilah

comment created time in 2 months

issue commentjneen/parsimmon

MS Edge 18 error

We made a bunch of dependency updates all at once (upgrading webpack and other things), so there aren't any guarantees I can give from my end like "this was all I changed" unfortunately. But we didn't change anything about how we use Parsimmon.

I think testing on Edge 16/18 would be the best next step; if the VMs don't allow it, let me see if my old windows 7 machine gathering dust can install it.

ekilah

comment created time in 2 months

issue commentjneen/parsimmon

MS Edge 18 error

Are you 100% sure your application code hasn't changed? If you somehow did /[0-9]/ + someVar and someVar was undefined, you would see the result in question ("/[0-9]/undefined").

The text in the error message in our bug tracker ("unsupported regexp flag") matches 100% with the string here: https://github.com/jneen/parsimmon/blob/cb77d09f900bb292389f0cf4870126bb5aa8b8d9/src/parsimmon.js#L466

not to mention the call stack being from the parsimmon library, and also parsimmon creates this regex: https://github.com/jneen/parsimmon/blob/cb77d09f900bb292389f0cf4870126bb5aa8b8d9/src/parsimmon.js#L1334

ekilah

comment created time in 2 months

issue commentjneen/parsimmon

MS Edge 18 error

So you're saying /[0-9]/ turns into "/[0-9]/undefined" when it's turned into a string in Edge 18?

That's what the Bugsnag error reports suggest, anyway. I am surprised by this as well. I wish I could confirm it, maybe I can with the VM link you suggested.

The flags function is only there because regexp.flags doesn't exist in old browsers.

Yeah, I noticed that on the MDN docs/caniuse. Specifically it seems to be missing on.... IE/old Edge. -_-

Are you interested in contributing a PR to fix this? It seems like you could do a check like if (re.flags !== undefined) return re.flags right at the top so we can just use the built-in flag property if it exists.

I would be willing to, but I would feel bad about making a PR for something I can't test. I was hoping maybe you had access to a machine that could prove the theory re: the cause. Again maybe I'll have time to do something with a VM to help out.

After reading the code here I can't see what else could cause it, since your error message prints the regex here:

https://github.com/jneen/parsimmon/blob/cb77d09f900bb292389f0cf4870126bb5aa8b8d9/src/parsimmon.js#L466


My only remaining thought is that I wasn't seeing these errors before I upgraded to the latest version, so I was wondering if you had ideas on any recent behavior changes that could have caused this. I haven't checked whether or not I had users on that browser version before my upgrade to 1.15.0, but I presume I did, since these errors showed up within an hour or two of the upgrade.

ekilah

comment created time in 2 months

issue openedjneen/parsimmon

MS Edge 18 error

Error unsupported regexp flag "n": /[0-9]/undefined 
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:6716 Anonymous function
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:6560 K
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:11055 Anonymous function
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:348 r
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:407 Anonymous function
    node_modules/parsimmon/build/parsimmon.umd.min.js:1:199 Anonymous function
    node_modules/parsimmon/build/parsimmon.umd.min.js:1 Anonymous function
    webpack/bootstrap:25:3 __webpack_require__
    https://mywebsite.com/static/js/main.abc.js:1:123 Anonymous function
    webpack/bootstrap:25:3 __webpack_require__

Seeing the above a few times in my error tracker for Windows 10 devices running Edge 16 and Edge 18 (very old, non-chromium builds of the Edge browser).

Running the latest parsimmon at 1.15.0. We just recently upgraded from 1.12.0 and I hadn't noticed these errors previously, if that's helpful.

The error message is a bit odd, but my guess is that RegExp on these versions of Edge don't support flags very well. It looks to me after reading the source for parsimmon that the regep is literally presenting as the string "/[0-9]/undefined" when flags converts it to a string:

https://github.com/jneen/parsimmon/blob/cb77d09f900bb292389f0cf4870126bb5aa8b8d9/src/parsimmon.js#L696-L699

I tried to see if I could install that version on my Windows 10 machine, but I guess Microsoft has made that difficult to do side-by-side with the new Edge, so I wasn't able to finish that try.

I mostly only bring this up because your README claims to support IE7+. I think this case would be not too hard to detect, if you're willing to test it and support these old Edge versions.

created time in 2 months

issue commentGifox/Tracker

Something went wrong – export takes long time and eventually fails

Glad to help. Sorry it took a while to try again. Let me know if more testing becomes useful, I'll do what I can. Love the tool, so I want it to work nicely again :)

ianbytchek

comment created time in 2 months

pull request commentmrmckeb/typescript-plugin-css-modules

Use let instead of const

I guess I should clarify, it seemed to resolve things, but maybe the CI failure means that it was just broken in a different way? Unclear. I'll let you tell me, I am just observing symptoms :)

ekilah

comment created time in 2 months

issue closedTypeStrong/fork-ts-checker-webpack-plugin

Branch for webpack 5 support?

Feature motivation

I have a project that is on the webpack 5 beta, and this plugin's types show some errors in my editor's TS language service window. I am wondering if this plugin has a branch or anything yet dedicated to webpack 5 support.

Error:(3, 61) TS2694: Namespace 'exports' has no exported member 'Plugin'.
Error:(11, 58) TS2694: Namespace 'exports' has no exported member 'compilation'.

image

Feature description

It appears some of the exports from Webpack have changed names / etc. (see the above screenshot). I guess they'd have to be changed in this project?

closed time in 2 months

ekilah

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Branch for webpack 5 support?

I think this is user error. I updated webpack but not @types/webpack. I'll close this out!

ekilah

comment created time in 2 months

issue commentmrmckeb/typescript-plugin-css-modules

Lots of errors produced in WebStorm IDE with this plugin

@mrmckeb Sorry it took so long to try this out, been busy!

Yes, that change does seem to fix the issue! It's annoying to test because it seems like I have to quit/restart Webstorm for it to decide to consume the changes in my package.json 😛 , but I confirmed the hundreds of errors disappeared with this change.

Added that to a PR: https://github.com/mrmckeb/typescript-plugin-css-modules/pull/100

ekilah

comment created time in 2 months

PR opened mrmckeb/typescript-plugin-css-modules

Use let instead of const

Fixes #97

This avoids errors in the Webstorm IDE's TypeScript console.

+1 -1

0 comment

1 changed file

pr created time in 2 months

push eventekilah/typescript-plugin-css-modules

Monroe Ekilah

commit sha ebbfb6cca7f828a967ca70d6487e38f8ddb3ac87

Use let instead of const Fixes #97

view details

push time in 2 months

pull request commentmrmckeb/typescript-plugin-css-modules

Fix 'const declarations be initialized' error in Webstorm

Oh, this is based on master I think, sorry

ekilah

comment created time in 2 months

PR opened mrmckeb/typescript-plugin-css-modules

Patch 1

Fixes #97

+1 -1

0 comment

1 changed file

pr created time in 2 months

push eventekilah/typescript-plugin-css-modules

Monroe Ekilah

commit sha fae50adde3f68d0fe9302c481cbbd29af4965459

try let instead of const Debugging #97 with the suggestion here: https://github.com/mrmckeb/typescript-plugin-css-modules/issues/97#issuecomment-669133538

view details

push time in 2 months

fork ekilah/typescript-plugin-css-modules

A TypeScript language service plugin providing support for CSS Modules.

fork in 2 months

issue commentGifox/Tracker

Something went wrong – export takes long time and eventually fails

Occurred again for me on 2.2.2

If you experience this issue, please send us your diagnostics data (library window > bottom-right menu button). App Logs.txt App Settings.txt

When the export fails don't quit the app and try: a. Open any earlier successful recording in the editor. Do you see the image or does it come out black? Can you play it?

No. They all look like this. The timeline on some seems to render a few frames, but regardless they won't play. image

b. Press Done to re-export it, does the export succeed? To be clear, it here is a previously-working export, as in (a) above.

No. At first my previously-working export hung like this after clicking Done: image

After 20 seconds or so, it eventually changed to the failure state, just like the new recordings do: image

c. Record a short video with the standard screen capture and import it into Gifox. Does the conversion succeed?

The video worked (cmd+shift+6 to choose the Mac native video recording since I use 5 for Gifox) but dragging it onto the Gifox menu bar and dropping it in the conversion box failed. The progress bar did move quickly at first but failed at about the 70% mark.

If you use external monitor: disconnect it and relaunch the app. Make a quick recording, reconnect it and make another recording. Disconnect it and make another recording. Did anything go wrong?

Nothing went wrong. I did several sleeps and disconnects to try and reproduce it, but it just won't reproduce for me.

Experiencing issue Disconnect monitor Relaunch Gifox Record ✅ Reconnect monitor Record ✅ Disconnect monitor Record ✅ Connect monitor Sleep, wait 20 seconds Wake Record ✅ Disconnect monitor Record ✅ Sleep, wait 20 seconds Wake Record ✅ Connect monitor Record ✅

None of these steps ran into issues. And yet, it happens for me all the time, somehow. Maybe it has more to do with how long the app is running? I basically never shut my laptop down, like once a month. Usually it just sleeps. Or, maybe I didn't sleep long enough (the computer didn't lock, it just went to sleep and woke up immediately when I pressed a key, no login screen required, which usually happens after 5min of sleep w/ my settings)

If you have any additional details or comments, please let us know!

Battery: 63%, charging (don't think this is relevant, happens all the time at 100% charging) External monitor: 4K over Thunderbolt 3 and via a dock, recently plugged in Sleep: recently woken from sleep

ianbytchek

comment created time in 2 months

issue commentfacebook/jest

Jest did not exit one second after the test run has completed.

@BigsonLvrocha thank you for that idea re: why-is-node-running! In my case that tool showed me that redux-state-sync was being initialized in tests, which has an infinite loop to listen for Redux updates in it. --detectOpenHandles did not output anything for me, either.

jamalsoueidan

comment created time in 3 months

delete branch ekilah/DefinitelyTyped

delete branch : patch-2

delete time in 3 months

pull request commentDefinitelyTyped/DefinitelyTyped

[redux-state-sync] correct type for BroadcastChannelOptions

Ready to merge

ekilah

comment created time in 3 months

delete branch ekilah/redux-state-sync

delete branch : patch-1

delete time in 3 months

pull request commentaohua/redux-state-sync

Use `undefined`, not `null`, for default options

Great, thank you!

ekilah

comment created time in 3 months

PR opened aohua/redux-state-sync

Use `undefined`, not `null`, for default options

As described in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46480 , the BroadcastChannel package will correctly default the options you pass to it if undefined is passed as the options object. However, using null results in a TypeError:

TypeError: Cannot read property 'webWorkerSupport' of null
          at fillOptionsWithDefaults (/Users/.../node_modules/redux-state-sync/node_modules/broadcast-channel/dist/lib/options.js:12:22)
          at new BroadcastChannel (/Users/.../node_modules/redux-state-sync/node_modules/broadcast-channel/dist/lib/broadcast-channel.js:23:55)
          at Object.createStateSyncMiddleware (/Users/.../node_modules/redux-state-sync/dist/syncState.js:131:19)
          at Object.<anonymous> (/Users/.../src/redux/store.ts:37:31)
+1 -1

0 comment

1 changed file

pr created time in 3 months

push eventekilah/redux-state-sync

Monroe Ekilah

commit sha cae0e035ce3901a5b23a7000757fd3c380e4c6af

Use `undefined`, not `null`, for default options As described in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46480 , the `BroadcastChannel` package will correctly default the options you pass to it if `undefined` is passed as the options object. However, using `null` results in a `TypeError`: ``` TypeError: Cannot read property 'webWorkerSupport' of null at fillOptionsWithDefaults (/Users/.../node_modules/redux-state-sync/node_modules/broadcast-channel/dist/lib/options.js:12:22) at new BroadcastChannel (/Users/.../node_modules/redux-state-sync/node_modules/broadcast-channel/dist/lib/broadcast-channel.js:23:55) at Object.createStateSyncMiddleware (/Users/.../node_modules/redux-state-sync/dist/syncState.js:131:19) at Object.<anonymous> (/Users/.../src/redux/store.ts:37:31) ```

view details

push time in 3 months

fork ekilah/redux-state-sync

A lightweight middleware to sync your redux state across browser tabs

fork in 3 months

push eventekilah/DefinitelyTyped

Monroe Ekilah

commit sha 5afaaaf0cce33be58522b30f30cbda460af3d408

fix test maybe

view details

push time in 3 months

pull request commentDefinitelyTyped/DefinitelyTyped

[redux-state-sync] correct type for BroadcastChannelOptions

I can't run the tests nor the linter locally for some reason, so I didn't add any tests at first. But since the bots demand them anyway, I tried to add one.

ekilah

comment created time in 3 months

push eventekilah/DefinitelyTyped

Monroe Ekilah

commit sha 86d8f41497ddbce573a85f2ed95ed63e9cb01102

add a test

view details

push time in 3 months

PR opened DefinitelyTyped/DefinitelyTyped

[redux-state-sync] correct type for BroadcastChannelOptions

BroadcastChannelOptions is more specific than object, and also null is incorrect - it is only allowed to be undefined in broadcast-channel, which is covered by the ? already:

https://github.com/pubkey/broadcast-channel/blob/8d2ee79aad2780e9df3ab4e1386548a9a323f8bb/dist/lib/options.js#L9 https://github.com/pubkey/broadcast-channel/blob/8d2ee79aad2780e9df3ab4e1386548a9a323f8bb/types/broadcast-channel.d.ts#L45-L46

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme. well actually I can't run the linter nor the tests locally, they all produce errors unrelated to this project for me
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present). this also errors out with errors from other projects

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: see above
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+2 -2

0 comment

1 changed file

pr created time in 3 months

push eventekilah/DefinitelyTyped

Monroe Ekilah

commit sha e3b3878ff6743d615c34e4335e2963246f574a8b

correct type for BroadcastChannelOptions `BroadcastChannelOptions` is more specific than `object`, and also `null` is incorrect - it is only allowed to be `undefined` in `broadcast-channel`, which is covered by the `?` already: https://github.com/pubkey/broadcast-channel/blob/8d2ee79aad2780e9df3ab4e1386548a9a323f8bb/dist/lib/options.js#L9 https://github.com/pubkey/broadcast-channel/blob/8d2ee79aad2780e9df3ab4e1386548a9a323f8bb/types/broadcast-channel.d.ts#L45-L46

view details

push time in 3 months

push eventekilah/DefinitelyTyped

Monroe Ekilah

commit sha b166336c274911af37a4c7a86b1975f13bdff3c6

correct type for BroadcastChannelOptions `BroadcastChannelOptions` is more specific than `object`, and also `null` is incorrect - it is only allowed to be `undefined` in `broadcast-channel`, which is covered by the `?` already: https://github.com/pubkey/broadcast-channel/blob/8d2ee79aad2780e9df3ab4e1386548a9a323f8bb/dist/lib/options.js#L9 https://github.com/pubkey/broadcast-channel/blob/8d2ee79aad2780e9df3ab4e1386548a9a323f8bb/types/broadcast-channel.d.ts#L45-L46

view details

push time in 3 months

issue commentmrmckeb/typescript-plugin-css-modules

Additional configuration needed in IntelliJ IDEs?

Somewhat unrelated, but there are some issues I'm experiencing with this plugin in WebStorm, xposting here. https://github.com/mrmckeb/typescript-plugin-css-modules/issues/97

fgblomqvist

comment created time in 3 months

more