profile
viewpoint
Evan Cordell ecordell Red Hat New York

aquasecurity/manifesto 154

Use Manifesto to store and query metadata for container images.

coreos/grafiti 31

Tag and remove AWS Resources with Automation

ecordell/chaostools 4

Educational software for the investigation of chaos.

cavalryjim/yeartogo 1

StartupBus Miami Project

ecordell/ActionSheetPicker 1

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality from Safari on iPhone/ iOS / CocoaTouch.

ecordell/aws-sdk-for-ios 1

Official mirror of the AWS SDK for iOS. For more information on the AWS SDK for iOS, see our web site:

ecordell/chargify_api_ares 1

A Chargify API wrapper for Ruby using ActiveResource

coreos-inc/apostille 0

Quay's Image Signing Service

dinhxuanvu/operator-lifecycle-manager 0

A management framework for extending Kubernetes with Operators

pull request commentopenshift/oc

Bug 1800674: Option to force RepoDigest mirror

/bugzilla refresh

kevinrizza

comment created time in 5 hours

PublicEvent
PublicEvent

PR opened openshift/oc

[wip] Update operator-registry version to v1.5.9

This commit updates operator-registry version in go.mod inorder to include operator-registry bug fix to oc. The commit also pins openshift/api and client-go pin to release-4.4 and docker to moby/moby for helm.

+16808 -4279

0 comment

312 changed files

pr created time in 6 days

create barnchecordell/oc

branch : registryVersion

created branch time in 6 days

issue commentargoproj/argo-cd

Argo-CD not detecting/linking generated objects

Ownership in kubernetes is used for building garbage collection graphs and propagating deletes - if that is not behavior you're interested in, ownerrefs aren't the right tool for the job (this is why there is no owner reference between the subscription and the csv).

Non-gc object hierarchies are typically built with labels and selectors. Would it be reasonable for Argo to allow specifying a label selector to find related objects? Or perhaps reading a value from an existing object, and using that value in a label or object query?

tylerauerbeck

comment created time in 8 days

issue commentoperator-framework/operator-lifecycle-manager

We cannot install another CSV using a different channel

Could you provide the OperatorSource or CatalogSource you are using for the catalog? Based on the information here, my guess is that the package and channel are not published, or there is some error preventing the use of the indicated channel.

The logs for the pod corresponding to the operatorsource or catalogsource would be helpful as well.

cmoulliard

comment created time in 8 days

push eventecordell/enhancements-1

Evan Cordell

commit sha ab81a4de98b4cfe45fc5b5b0e79f67d4efcac5ec

Add manifest bundle kep

view details

push time in 11 days

push eventecordell/enhancements-1

Evan Cordell

commit sha ee7f60bc66959535670865837eca0ac74a7cbf96

Add manifest bundle kep

view details

push time in 11 days

push eventecordell/origin

Evan Cordell

commit sha a8b7078e5a1908dca5ecb5e6e1ca4c9fecd44cd7

fix test flake in olm tests if the operatrgroup is not ready by the time the CSV is created, the CSV may temporarily make the CSV go unhealthy. This emits an alert, which can make the prometheus test ensuring no alerts fail.

view details

push time in 13 days

pull request commentopenshift/origin

Bug 1790825: fix test flake in olm tests

/retest

ecordell

comment created time in 13 days

push eventecordell/operator-registry

Evan Cordell

commit sha 2b01c8fa1a179c7142bdf33668170f3eac5de7d7

feat(bbolt): serialization for capabilities/requirements

view details

push time in 13 days

Pull request review commentopenshift/openshift-docs

Add OperatorSources deprecation notice back to 4.3 relnotes

 The following related APIs will be removed in a future release: * `.automationbroker.io/v1alpha1` * `.osb.openshift.io/v1` +[id="ocp-4-3-deprecation-of-operatorsources"]+==== Deprecation of OperatorSources++In a future release, OperatorSources will be deprecated from OperatorHub and the+`operatorsource.operators.coreos.com/v1` API will be removed.
`  name: operatorsources.operators.coreos.com/v1`, `catalogsourceconfigs.operators.coreos.com/v2`, and `catalogsourceconfigs.operators.coreos.com/v1` APIs will be removed.
adellape

comment created time in 13 days

Pull request review commentopenshift/openshift-docs

Add OperatorSources deprecation notice back to 4.3 relnotes

 The following related APIs will be removed in a future release: * `.automationbroker.io/v1alpha1` * `.osb.openshift.io/v1` +[id="ocp-4-3-deprecation-of-operatorsources"]+==== Deprecation of OperatorSources++In a future release, OperatorSources will be deprecated from OperatorHub and the
In a future release, OperatorSources and CatalogSourceConfigs will be deprecated from OperatorHub and the
adellape

comment created time in 13 days

pull request commentoperator-framework/operator-lifecycle-manager

fix: update existing robot credentials

/retest

exdx

comment created time in 13 days

Pull request review commentoperator-framework/operator-registry

[wip] bbolt backend

+package boltdb++import (+	"context"+	"fmt"+	"strings"++	"github.com/asdine/storm/v3"+	"github.com/asdine/storm/v3/q"++	"github.com/operator-framework/operator-registry/pkg/api"+	"github.com/operator-framework/operator-registry/pkg/registry"+)++// StormQuerier queries over operatory registry data overa a BoltDB database.+type StormQuerier struct {+	db *storm.DB+}+++var _ registry.Query = &StormQuerier{}++func NewStormQuerier(db *storm.DB) *StormQuerier {+	return &StormQuerier{+		db: db,+	}+}++func (*StormQuerier) ListTables(ctx context.Context) ([]string, error) {+	panic("implement me")+}++func (s *StormQuerier) ListPackages(ctx context.Context) ([]string, error) {+	var pkgs []Package+	if err := s.db.All(&pkgs); err != nil {+		return nil, err+	}++	var names []string+	for _, pkg := range pkgs {+		names = append(names, pkg.Name)+	}++	return names, nil+}++func (s *StormQuerier) GetPackage(ctx context.Context, name string) (*registry.PackageManifest, error) {+	var pkg Package+	if err := s.db.One("Name", name, &pkg); err != nil {+		return nil, err+	}++	var channels []Channel+	if err := s.db.Find("PackageName", name, &channels); err != nil {+		return nil, fmt.Errorf("couldn't get channels for package %s: %v", name, err)+	}++	pkgManifest := &registry.PackageManifest{+		PackageName:        pkg.Name,+		DefaultChannelName: pkg.DefaultChannel,+	}+	for _, channel := range channels {+		pkgManifest.Channels = append(pkgManifest.Channels, registry.PackageChannel{+			Name:           channel.ChannelName,+			CurrentCSVName: channel.HeadOperatorBundleName,+		})+	}++	return pkgManifest, nil+}++func (s *StormQuerier) GetBundle(ctx context.Context, pkgName, channelName, csvName string) (*api.Bundle, error) {+	// We only need the csvName to query for the OperatorBundle, since their names are 1:1+	var opBundle OperatorBundle+	if err := s.db.One("Name", csvName, &opBundle); err != nil {+		return nil, fmt.Errorf("couldn't find bundle for %s, %s, %s: %v", pkgName, channelName, csvName, err)+	}++	// Convert raw bytes into individual bundle JSON strings+	objs, err := registry.BundleStringToObjectStrings(string(opBundle.Bundle))+	if err != nil {+		return nil, err+	}+	bundle := &api.Bundle{+		CsvName:      opBundle.Name,+		CsvJson:      string(opBundle.CSV),+		Object:       objs,+		BundlePath:   opBundle.BundlePath,+		Version:      opBundle.Version,+		SkipRange:    opBundle.SkipRange,+		PackageName:  pkgName,+		ChannelName:  channelName,+		ProvidedApis: []*api.GroupVersionKind{},+		RequiredApis: []*api.GroupVersionKind{},+	}++	// provided apis+	for _, cap := range opBundle.Capabilities {+		fmt.Printf("%#v", cap)+		gvkp := strings.Split(cap.Value, "/")

if we keep this field as a string, yes

ecordell

comment created time in 13 days

Pull request review commentoperator-framework/operator-registry

[wip] bbolt backend

+package boltdb++import (+	"context"+	"database/sql"+	"fmt"+	"math/rand"+	"os"+	"testing"+	"time"++	"github.com/asdine/storm/v3"+	"github.com/stretchr/testify/require"++	"github.com/operator-framework/operator-registry/pkg/registry"+	"github.com/operator-framework/operator-registry/pkg/registry/test"+	"github.com/operator-framework/operator-registry/pkg/sqlite"+)++func init() {+	rand.Seed(time.Now().UTC().UnixNano())+}++func TestEnsureBolt(t *testing.T) {+	prefix := fmt.Sprintf("test-%d", rand.Int())+	dbName := prefix + ".db"+	backupName := dbName + ".bak"+	db, err := sql.Open("sqlite3", dbName)+	require.NoError(t, err)+	defer os.Remove(dbName)+	defer os.Remove(backupName)++	sqliteLoader, err := sqlite.NewSQLLiteLoader(db)

agreed

ecordell

comment created time in 13 days

Pull request review commentoperator-framework/operator-registry

[wip] bbolt backend

+package boltdb++import (+	"bytes"+	"errors"+	"fmt"+	"github.com/alicebob/sqlittle"+	"github.com/asdine/storm/v3"+	bolt "go.etcd.io/bbolt"+	"os"+)++type rowMigrator func(node storm.Node, errs []error) (sqlittle.RowCB, string, []string)++// TODO: thread a logger through++func EnsureBolt(file string, backupFile string) error {+	db, err := bolt.Open(file, 0600, nil)++	// file is already a boltdb, no migration from sqlite needed+	if err == nil {+		return db.Close()+	}++	// move current db to a backup location+	if err := os.Rename(file, backupFile); err != nil {

That's effectively what this does - moves the sqlite file to .db.bak, reads from the .db.bak, and writes to the .db

ecordell

comment created time in 13 days

push eventecordell/operator-registry

Evan Cordell

commit sha 4b282d3588ae0ff94d75009ac0d56bcc8ed41735

feat(bbolt): finish bbolt querier

view details

push time in 14 days

push eventecordell/operator-registry

njhale

commit sha d52815ab369a07ecf8d01aec02e7b792487dc527

feat(bbolt): add bbolt querier and refactor tests to run against multiple storage backends Also further iterates the bbolt model

view details

Evan Cordell

commit sha 7563302cc26c686074fa3cb8dcc307a9922633a7

feat(bbolt): add a migrator that can migrate from sqlite to bbolt without pulling in the go-sqlite package the migrator is still wip

view details

kevinrizza

commit sha 8cc032f13be9ad89261ee6a006e2e523d8562df5

feat(bbolt): migration update added migration changes: * complete apiprovider migration * add apirequirer migration * add channel entry migration additonally, made some small updates to the bolt querier: * updated GetBundleThatReplaces() to pass through result of select * fixed GetImagesForBundle() to pass pointer for list in Find() call * modified ChannelReplacement type to set the BundleName to match what the ORM expects

view details

Evan Cordell

commit sha 6d43b61a6739817d9dc15965c6f0549b5d967bc3

feat(bbolt): finish bbolt querier

view details

Evan Cordell

commit sha 489c7cd2f79f13ff159e0ad18479a54940d6f974

chore(tests): fix up tests after bbolt refactoring

view details

push time in 14 days

push eventecordell/operator-registry

gbenhaim

commit sha 0d63ca21a314a55c82a330860781ea5b72c860ed

Make downloader.go testable - Decouple `QuerySource` and `GetRegistryOptions` from the downloader struct. - Create the `sourceQuerier` and `registryOptionsGetter` interfaces, so it would be possible to mock the real implementation in the unit tests. - Add the `appRegistrySourceQuerier` struct which implements the `sourceQuerier` interface with the same functionality that exist before this change. - Add the `secretRegistryOptionsGetter` struct which implements the `registryOptionsGetter` interface with the same functionality that exist before this change. - Add a unit test for downloader.Prepare. Signed-off-by: gbenhaim <galbh2@gmail.com>

view details

OpenShift Merge Robot

commit sha 5ec9f93c4e8281083c3f46cee08dce65311696fc

Merge pull request #139 from gbenhaim/make_downloader_testable Make downloader.go testable

view details

Daniel Sover

commit sha 7673f8e17ff957a4d2c49f289fca46c27a9b49aa

Add validate bundle contents 1. Add bundle content validation 2. Add the bundle validation documentation 3. Add needed vendor code for validation Signed-off-by: Vu Dinh <vdinh@redhat.com>

view details

Vu Dinh

commit sha 1f920b97e9a4d3cb4c8301dd781b9f6c2385c715

Refactor bundle validation code to seperate format and contend validation 1. Seperate bundle format and content validation into 2 seperate functions 2. Remove operator-sdk reference from registry docs. Using `opm` reference instead. 3. Add bundle object validation to improve content validation Signed-off-by: Vu Dinh <vdinh@redhat.com>

view details

kevinrizza

commit sha 2066c95d074c1e4034129eea2651742776099cd4

Update docs to reflect index/bundle image changes

view details

gbenhaim

commit sha d1948d78fc941b0457451298adb62e60643f9e53

Add support for choosing the package's release Up until now, the appregistry-server always pulled the latest version of the requested packages, which makes sense for production, but not for testing and release phases of the packages. During testing, multiple version of the same package can be tested at the same time, and when releasing, it's not mandatory that the different releases will be released on the same date. When combining the appregistry-server logic, with the properties of the test and release phases, there is a need to create a complex automation for merging multiple versions (so they can be tested at the time) into a single bundle, and omitting non-ready releases from bundles, after testing and before the release. This change adds the possibility to specify the requested release after the package's name (e.g "Kubevirt:10.0.0"). If the version is not specified, the server will download the latest version from the appregistry. Signed-off-by: gbenhaim <galbh2@gmail.com>

view details

Kevin Rizza

commit sha 86898f2687dbffebc3148e811cc4d1830d9b03de

Update README.md

view details

Vu Dinh

commit sha 0d31556449e78af74fd3c4c0316fd45d7c4c7691

Address feedbacks from comments/reviews 1. Improve errors handling 2. Flattering some nested conditional loops 3. Refactoring supported types 4. Handle plain type validation Signed-off-by: Vu Dinh <vdinh@redhat.com>

view details

OpenShift Merge Robot

commit sha d8e2ec52c19ad2b2a11a91f1ecccb1887bbae787

Merge pull request #146 from exdx/feat/validate-bundle-files Add bundle contents validation

view details

Evan Cordell

commit sha 6179602a559e104eba6802cd0c5d752c8a2c162b

chore(release): add a travis.yml to build and release opm

view details

OpenShift Merge Robot

commit sha 0d3a65becc0524f4ba38c0e86afd0da8fa714783

Merge pull request #155 from ecordell/bins Build binaries for linux, windows, and mac

view details

Vu Dinh

commit sha c6cd9fe87b44434efe9b756f5e4ce4e2254dc312

Fix issue with empty docker error output Docker CLI returns error message via StdErr which doesn't get collected from cmd.Output(). As a result, an empty tring is returned if an error occurs with Docker CLI. Instead, using cmd.CombinedOutput() will collect StdErr informationas well. Bonus: Minor command wrapping to fit into 80 char limit to better display the code in browser. Signed-off-by: Vu Dinh <vdinh@redhat.com>

view details

OpenShift Merge Robot

commit sha b7af076812435888767bdf936a429958031ac3ee

Merge pull request #156 from dinhxuanvu/fix/docker-error-output Fix issue with empty docker error output

view details

Sim Dhaliwal

commit sha 67ed19064e21b8883649892499523aeea1285e50

Bug 1784028: Updating summary for 'Operator Registry ' containers

view details

Evan Cordell

commit sha ef9ece86eed47639fba80091941189830ab891cd

chore(release): use robot for deploys

view details

OpenShift Merge Robot

commit sha ee90fd93e671a22a6530b92f70fdc3b85986aa27

Merge pull request #158 from operator-framework/mkrelease chore(release): use robot for deploys

view details

OpenShift Merge Robot

commit sha 7ae179e225a387e8c7a3a294583022061587d6ef

Merge pull request #141 from gbenhaim/add_support_for_choosing_a_version Add support for choosing the release of a package

view details

OpenShift Merge Robot

commit sha 093283ebe055b84d85d1b77ce8b6828fcaaefd42

Merge pull request #153 from simrandhaliw/patch-1 Bug 1784028: Updating summary for 'Operator Registry ' containers

view details

OpenShift Merge Robot

commit sha cb8d55a3d874c956e8cdf225a8c7360d3693a428

Merge pull request #149 from kevinrizza/opm-docs Add `opm` docs

view details

Evan Cordell

commit sha 2cbaddba02ad5a1e4da8f550b6237b9b96e81ab4

fix(ci): build opm statically in CI

view details

push time in 14 days

pull request commentopenshift/oc

Bug 1790798: Mirror images one by one for oc adm catalog mirror

/cherry-pick release-4.3

ecordell

comment created time in 14 days

PR opened operator-framework/operator-registry

[wip] bbolt backend

<!--

Before making a PR, please read our contributing guidelines https://github.com/operator-framework/operator-lifecycle-manager/blob/master/CONTRIBUTING.MD Note: Make sure your branch is rebased to the latest upstream master.

-->

Description of the change:

  • [x] bbolt data model
  • [x] bbolt migrator
  • [x] tests run against old and new backends
  • [ ] finalize bbolt data model
  • [ ] benchmark queries
  • [ ] make queries efficient

Motivation for the change:

This will allow a pure-go build of registry tooling.

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

<!--

Note: If this PR is fixing an issue make sure to add a note saying: Closes #<ISSUE_NUMBER>

-->

+65115 -54231

0 comment

375 changed files

pr created time in 14 days

push eventecordell/operator-registry

Evan Cordell

commit sha 0ee8da9f84696dbe16385c797cf7f9c8f6de49b6

fixup tests

view details

push time in 14 days

create barnchecordell/operator-registry

branch : bb-migrator

created branch time in 14 days

push eventecordell/origin

Evan Cordell

commit sha 8a012aeeaf71a0141a47fbde809210b3c8617e32

fix test flake in olm tests if the operatrgroup is not ready by the time the CSV is created, the CSV may temporarily make the CSV go unhealthy. This emits an alert, which can make the prometheus test ensuring no alerts fail.

view details

push time in 16 days

push eventecordell/operator-marketplace

Evan Cordell

commit sha 264b5e4500fc2517676ec40b8da0d52d234c7ea7

Add cluster role with aggregation for reading operatorhub config

view details

push time in 16 days

pull request commentopenshift/origin

Bug 1790825: fix test flake in olm tests

/retest

ecordell

comment created time in 17 days

pull request commentoperator-framework/operator-lifecycle-manager

Bug 1789920: Fix bad opgroup annotations

/cherry-pick release-4.3

ecordell

comment created time in 17 days

push eventecordell/origin

Evan Cordell

commit sha c557c3c1493ca950f837ba4b1f8b47b9ed2d92de

fix test flake in olm tests if the operatrgroup is not ready by the time the CSV is created, the CSV may temporarily make the CSV go unhealthy. This emits an alert, which can make the prometheus test ensuring no alerts fail.

view details

push time in 17 days

pull request commentopenshift/origin

Bug 1790825: fix test flake in olm tests

/retest

ecordell

comment created time in 17 days

PR opened openshift/oc

Bug 1797026: [release-4.3] Support security options for oc adm catalog

This is a backport of the security option commits from: https://github.com/openshift/oc/pull/212 and https://github.com/openshift/oc/pull/252

+86 -0

0 comment

4 changed files

pr created time in 17 days

create barnchecordell/oc

branch : secopts-4.3

created branch time in 17 days

push eventoperator-framework/operator-lifecycle-manager

njhale

commit sha d96722226513ec6e388f2160d2171c439470d151

chore(ci): update owners

view details

Evan Cordell

commit sha 8775d5a0d7c632b1b0f1b0ccaf5c7c27fcd81f95

Merge pull request #1261 from njhale/update-owners chore(ci): update owners

view details

push time in 17 days

PR merged operator-framework/operator-lifecycle-manager

Reviewers
chore(ci): update owners approved size/S

<!--

Before making a PR, please read our contributing guidelines https://github.com/operator-framework/operator-lifecycle-manager/blob/master/CONTRIBUTING.MD

Note: Make sure your branch is rebased to the latest upstream master.

-->

Description of the change:

Update the list of approvers!

<!--

Note: If this PR is fixing an issue make sure to add a note saying: Closes #<ISSUE_NUMBER>

-->

+11 -2

3 comments

1 changed file

njhale

pr closed time in 17 days

pull request commentoperator-framework/operator-lifecycle-manager

chore(ci): update owners

doc-only, merging without ci

njhale

comment created time in 17 days

push eventoperator-framework/operator-lifecycle-manager

Ben Luddy

commit sha 713cac31832146635d49c95022dd897a525ff019

Generate manifests for version 0.14.1.

view details

Evan Cordell

commit sha d597b6656a5c61a127b392343bc4cc56faa00248

Merge pull request #1265 from benluddy/manifests-for-0.14.1 Generate manifests for version 0.14.1.

view details

push time in 17 days

pull request commentoperator-framework/operator-lifecycle-manager

Generate manifests for version 0.14.1.

this PR is upstream-only, merging without a BZ

benluddy

comment created time in 17 days

push eventoperator-framework/operator-lifecycle-manager

Ben Luddy

commit sha 9c5742df19c3e313622b62303366cd9ac3107135

Generate changelog for 0.14.0 and 0.14.1.

view details

Evan Cordell

commit sha b8941257aa346f4057f0b7d2bde8144e4b4a0458

Merge pull request #1266 from benluddy/changelog-0.14.1 Generate changelog for 0.14.0 and 0.14.1.

view details

push time in 17 days

pull request commentoperator-framework/operator-lifecycle-manager

Generate changelog for 0.14.0 and 0.14.1.

/lgtm

doc-only, merging without tests

benluddy

comment created time in 17 days

push eventecordell/origin

Evan Cordell

commit sha f61565eef6a48cd519dfd99e7ba46e0afecf8138

fix test flake in olm tests if the operatrgroup is not ready by the time the CSV is created, the CSV may temporarily make the CSV go unhealthy. This emits an alert, which can make the prometheus test ensuring no alerts fail.

view details

push time in 17 days

pull request commentoperator-framework/operator-marketplace

Bug 1752063: increase initial delay for appregistry pods

These values look good on a real cluster. The appregistry pods tend to come up in about 7 seconds right now, so this gives a good buffer.

ecordell

comment created time in 17 days

pull request commentalicebob/sqlittle

Support for deferrable and initially deferred

Thanks for merging! If you have a moment, could you tag a new version so that we can depend on a tagged version?

Thanks for this project, it's been a big help.

ecordell

comment created time in 17 days

pull request commentoperator-framework/operator-marketplace

Bug 1787660: Add CLI flag to set ClusterOperator name.

/approve /lgtm

benluddy

comment created time in 17 days

push eventecordell/origin

Luis Sanchez

commit sha a8c76b27bbc15430106aa94f570653a14ca262ea

test for excessive etcd leadership changes

view details

Aniket

commit sha 6809daab34f27b0df2cc3ba6d3956e16b6c6fa27

Uncomment the lines to verify oc explain for networking related CRDs

view details

Aniket

commit sha b3c6452047fb6ec061cc9b8fa6d50fa5f2c7944b

Move the network crds to have special case handling

view details

Fabio Bertinatto

commit sha 75e464d14b46e12a07f73b56830c201c49db6bdc

Add CSI resizer to e2e tests

view details

Maciej Szulik

commit sha 56c58210c15c4a3a71fdbf4c74e4c10fbf8af134

Loosen help tests for oc rsh

view details

Clayton Coleman

commit sha 07e7a1b965dd8a64d0b06ed37cff9d9b954a9019

test: Allow imagetags resource to be added to group RBAC This resource is new in 4.4 and is created by openshift-apiserver.

view details

Lukasz Szaszkiewicz

commit sha 150886a5e86205d190ecdc322829149142e74295

removes origin-4.4-kubernetes-1.17.0-rc.2 from publishing-kube-rules.yaml

view details

gabemontero

commit sha 908851955eba9f05a58b5b3ec38b76fdff58a04f

move off more nodejs:8 references

view details

OpenShift Merge Robot

commit sha 070402c2a8f756a89357a54aee27adc07ff3ced7

Merge pull request #24423 from p0lyn0mial/rm-publishing-rules-for-1.17.0-rc.2 removes origin-4.4-kubernetes-1.17.0-rc.2 from publishing-kube-rules.…

view details

Frederic Branczyk

commit sha 36ea4cff923890f2d27895faa9bbd5072b167956

test/extended/prometheus: Re-enable telemetry test

view details

OpenShift Merge Robot

commit sha fb75904076edd47d16c427bb7fbd2a800aafb1dd

Merge pull request #24410 from bertinatto/add-csi-resizer-e2e Add CSI resizer to e2e tests

view details

Clayton Coleman

commit sha 864c6dc8f67b9b01bfff9653ee9c176ed5664355

Merge pull request #24422 from smarterclayton/allow_image_tags test: Allow imagetags resource to be added to group RBAC

view details

David Eads

commit sha acea378202faf17274571de817d3064455da82a5

UPSTREAM: 87432: fix flaky test "should create a ResourceQuota and capture the life of a replication controller"

view details

OpenShift Merge Robot

commit sha 9bc70b023f24f58537ad9c3c729704e1075752f4

Merge pull request #24434 from gabemontero/more-nodejs8 move off more nodejs:8 references

view details

OpenShift Merge Robot

commit sha e7876f20934ab99f686c987bedd38fe47bf1e005

Merge pull request #24420 from soltysh/fix_tests Loosen help tests for oc rsh

view details

OpenShift Merge Robot

commit sha c049e5a8d58b404ea3ac9c4411338b5dc6136ec9

Merge pull request #24291 from sanchezl/e2e-leader-change test for excessive etcd leadership changes

view details

Clayton Coleman

commit sha cdb53577a51031b2f01229cbd71a3a650c8a5910

test: Remove regexes in the wildcard selection, they are expensive We noticed a 2x CPU regression in e2e runs, and these are unfortunately the culprit.

view details

Clayton Coleman

commit sha df6f5bd8c663ce1a89bd27ea289d695a66ff9199

test: Generate test annotations rather than doing them dynamically It is expensive to perform 100 checks against 1k names on every startup. Instead, move these to generated files that can be reviewed out of bounds on change. Add them to generated-bindata for verification and regen.

view details

Clayton Coleman

commit sha 85a55fdd69b3e805a6d7278cdbffd66fd3678376

test: Remove dependency on e2e in cloud config lookup Also move skip logic into provider initialization, and buffer a small amount of suite output. GCP tests are excluded from core infra, they are not used.

view details

Clayton Coleman

commit sha f0faf0c329356db1b94f11fabd7fe453ccec9cf5

test/cmd: build.sh can't reach old openshift/origin:v1.1 image Change to use centos:7 which is more consistent.

view details

push time in 17 days

push eventecordell/operator-registry

gbenhaim

commit sha 0d63ca21a314a55c82a330860781ea5b72c860ed

Make downloader.go testable - Decouple `QuerySource` and `GetRegistryOptions` from the downloader struct. - Create the `sourceQuerier` and `registryOptionsGetter` interfaces, so it would be possible to mock the real implementation in the unit tests. - Add the `appRegistrySourceQuerier` struct which implements the `sourceQuerier` interface with the same functionality that exist before this change. - Add the `secretRegistryOptionsGetter` struct which implements the `registryOptionsGetter` interface with the same functionality that exist before this change. - Add a unit test for downloader.Prepare. Signed-off-by: gbenhaim <galbh2@gmail.com>

view details

OpenShift Merge Robot

commit sha 5ec9f93c4e8281083c3f46cee08dce65311696fc

Merge pull request #139 from gbenhaim/make_downloader_testable Make downloader.go testable

view details

Daniel Sover

commit sha 7673f8e17ff957a4d2c49f289fca46c27a9b49aa

Add validate bundle contents 1. Add bundle content validation 2. Add the bundle validation documentation 3. Add needed vendor code for validation Signed-off-by: Vu Dinh <vdinh@redhat.com>

view details

Vu Dinh

commit sha 1f920b97e9a4d3cb4c8301dd781b9f6c2385c715

Refactor bundle validation code to seperate format and contend validation 1. Seperate bundle format and content validation into 2 seperate functions 2. Remove operator-sdk reference from registry docs. Using `opm` reference instead. 3. Add bundle object validation to improve content validation Signed-off-by: Vu Dinh <vdinh@redhat.com>

view details

kevinrizza

commit sha 2066c95d074c1e4034129eea2651742776099cd4

Update docs to reflect index/bundle image changes

view details

gbenhaim

commit sha d1948d78fc941b0457451298adb62e60643f9e53

Add support for choosing the package's release Up until now, the appregistry-server always pulled the latest version of the requested packages, which makes sense for production, but not for testing and release phases of the packages. During testing, multiple version of the same package can be tested at the same time, and when releasing, it's not mandatory that the different releases will be released on the same date. When combining the appregistry-server logic, with the properties of the test and release phases, there is a need to create a complex automation for merging multiple versions (so they can be tested at the time) into a single bundle, and omitting non-ready releases from bundles, after testing and before the release. This change adds the possibility to specify the requested release after the package's name (e.g "Kubevirt:10.0.0"). If the version is not specified, the server will download the latest version from the appregistry. Signed-off-by: gbenhaim <galbh2@gmail.com>

view details

Kevin Rizza

commit sha 86898f2687dbffebc3148e811cc4d1830d9b03de

Update README.md

view details

Vu Dinh

commit sha 0d31556449e78af74fd3c4c0316fd45d7c4c7691

Address feedbacks from comments/reviews 1. Improve errors handling 2. Flattering some nested conditional loops 3. Refactoring supported types 4. Handle plain type validation Signed-off-by: Vu Dinh <vdinh@redhat.com>

view details

OpenShift Merge Robot

commit sha d8e2ec52c19ad2b2a11a91f1ecccb1887bbae787

Merge pull request #146 from exdx/feat/validate-bundle-files Add bundle contents validation

view details

Evan Cordell

commit sha 6179602a559e104eba6802cd0c5d752c8a2c162b

chore(release): add a travis.yml to build and release opm

view details

OpenShift Merge Robot

commit sha 0d3a65becc0524f4ba38c0e86afd0da8fa714783

Merge pull request #155 from ecordell/bins Build binaries for linux, windows, and mac

view details

Vu Dinh

commit sha c6cd9fe87b44434efe9b756f5e4ce4e2254dc312

Fix issue with empty docker error output Docker CLI returns error message via StdErr which doesn't get collected from cmd.Output(). As a result, an empty tring is returned if an error occurs with Docker CLI. Instead, using cmd.CombinedOutput() will collect StdErr informationas well. Bonus: Minor command wrapping to fit into 80 char limit to better display the code in browser. Signed-off-by: Vu Dinh <vdinh@redhat.com>

view details

OpenShift Merge Robot

commit sha b7af076812435888767bdf936a429958031ac3ee

Merge pull request #156 from dinhxuanvu/fix/docker-error-output Fix issue with empty docker error output

view details

Sim Dhaliwal

commit sha 67ed19064e21b8883649892499523aeea1285e50

Bug 1784028: Updating summary for 'Operator Registry ' containers

view details

Evan Cordell

commit sha ef9ece86eed47639fba80091941189830ab891cd

chore(release): use robot for deploys

view details

OpenShift Merge Robot

commit sha ee90fd93e671a22a6530b92f70fdc3b85986aa27

Merge pull request #158 from operator-framework/mkrelease chore(release): use robot for deploys

view details

OpenShift Merge Robot

commit sha 7ae179e225a387e8c7a3a294583022061587d6ef

Merge pull request #141 from gbenhaim/add_support_for_choosing_a_version Add support for choosing the release of a package

view details

OpenShift Merge Robot

commit sha 093283ebe055b84d85d1b77ce8b6828fcaaefd42

Merge pull request #153 from simrandhaliw/patch-1 Bug 1784028: Updating summary for 'Operator Registry ' containers

view details

OpenShift Merge Robot

commit sha cb8d55a3d874c956e8cdf225a8c7360d3693a428

Merge pull request #149 from kevinrizza/opm-docs Add `opm` docs

view details

Evan Cordell

commit sha 2cbaddba02ad5a1e4da8f550b6237b9b96e81ab4

fix(ci): build opm statically in CI

view details

push time in 18 days

pull request commentoperator-framework/operator-lifecycle-manager

Bug 1738684: Update rh-operators configmap to prometheus 0.23.2

@madorn Actually getting these changes into 3.11 requires a PR against openshift-ansible to update the configmaps there.

madorn

comment created time in 18 days

pull request commentoperator-framework/operator-lifecycle-manager

Update rh-operators configmap to prometheus 0.23.2

/approve /lgtm

madorn

comment created time in 18 days

PR opened alicebob/sqlittle

Support for deferrable and initially deferred

I found that sqlittle was choking on parsing tables created with foreign keys that were deferred.

This PR adds support for parsing those fields to the parser.

+292 -224

0 comment

4 changed files

pr created time in 18 days

push eventecordell/sqlittle

Evan Cordell

commit sha c84c456ba61ce09daa091f3872742bd8a1734ada

Support for deferrable and initially deferred

view details

push time in 18 days

PR opened operator-framework/operator-lifecycle-manager

Bug 1789920: Fix bad opgroup annotations

<!--

Before making a PR, please read our contributing guidelines https://github.com/operator-framework/operator-lifecycle-manager/blob/master/CONTRIBUTING.MD

Note: Make sure your branch is rebased to the latest upstream master.

-->

Description of the change: This has two tests and two fixes:

  1. Fixes an issue where copied CSV's would have their operatorgroup annotation overwritten, causing them not to be GCd
  2. Adds a test to verify that behavior
  3. Finds any CSVs that may have bad operatorgroup annotations from a previous version of OLM with the bug and GC's them
  4. Adds a test to verify that behavior

Motivation for the change:

Copied CSVs had their operatorgroup annotations overwritten if they landed in namespaces that had their own operatorgroups. The GC loop looks at this annotation to find the "parent" real csv, so for ownnamespace operatorgroups, GC would find that same copied CSV, see it present, and not GC it.

This fixes the underlying issue and adds cleanup for any CSVs that have these bad annotations.

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

<!--

Note: If this PR is fixing an issue make sure to add a note saying: Closes #<ISSUE_NUMBER>

-->

+281 -1

0 comment

3 changed files

pr created time in 18 days

pull request commentopenshift/origin

Bug 1790825: fix test flake in olm tests

/retest

ecordell

comment created time in 18 days

PR opened operator-framework/operator-lifecycle-manager

Bug 1783284: fix(perf): remove periodic resync

<!--

Before making a PR, please read our contributing guidelines https://github.com/operator-framework/operator-lifecycle-manager/blob/master/CONTRIBUTING.MD

Note: Make sure your branch is rebased to the latest upstream master.

-->

Description of the change: Removes periodic resync to avoid spikes in CPU every few minutes.

CatalogSource still requires a resync to ensure polled updates are found, but that can be addressed later (and involves few resources).

Motivation for the change: /hold

holding to try this out in test clusters and make sure things look good.

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

<!--

Note: If this PR is fixing an issue make sure to add a note saying: Closes #<ISSUE_NUMBER>

-->

+4 -5

0 comment

3 changed files

pr created time in 18 days

create barnchecordell/operator-lifecycle-manager

branch : no-resync

created branch time in 18 days

PR opened operator-framework/operator-marketplace

Bug 1796414:Add cluster role with aggregation for reading operatorhub config

<!--

Before making a PR, please read our contributing guidelines https://github.com/operator-framework/operator-lifecycle-manager/blob/master/CONTRIBUTING.MD

Note: Make sure your branch is rebased to the latest upstream master.

-->

Description of the change:

Motivation for the change:

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

<!--

Note: If this PR is fixing an issue make sure to add a note saying: Closes #<ISSUE_NUMBER>

-->

+16 -0

0 comment

1 changed file

pr created time in 18 days

create barnchecordell/operator-marketplace

branch : cluster-reader-operatorhub

created branch time in 18 days

pull request commentopenshift/oc

Bug 1790798: Mirror images one by one for oc adm catalog mirror

/retest

ecordell

comment created time in 19 days

create barnchecordell/operator-registry

branch : ms-3

created branch time in 20 days

push eventecordell/sqlittle

push time in 20 days

create barnchecordell/sqlittle

branch : deferrable

created branch time in 20 days

pull request commentopenshift/oc

Bug 1790798: Mirror images one by one for oc adm catalog mirror

/retest

ecordell

comment created time in 20 days

fork ecordell/sqlittle

Pure Go SQLite file reader

fork in 20 days

push eventecordell/oc

Evan Cordell

commit sha 766ca55ecc9b8355bb3aba602cd5163a34d561e6

Mirror images one by one, since underlying `mirror` plan will fail if just one source tag does not exist

view details

push time in 20 days

push eventecordell/oc

Evan Cordell

commit sha 4819071e784a53d0db00d88becd19bb9fa9c4d75

Mirror images one by one, since underlying `mirror` plan will fail if just one source tag does not exist

view details

push time in 20 days

pull request commentopenshift/oc

Bug 1790798: Mirror images one by one for oc adm catalog mirror

/retest

ecordell

comment created time in 20 days

pull request commentopenshift/origin

Bug 1790825: fix test flake in olm tests

/retest

ecordell

comment created time in 20 days

PullRequestEvent

PR closed openshift/origin

Reviewers
Bug 1790825: fix test flake in olm tests bugzilla/valid-bug lgtm size/S

If the operatrgroup is not ready by the time the CSV is created, the CSV may temporarily make the CSV go unhealthy. This emits an alert, which can make the prometheus test ensuring no alerts fail.

+20 -3

10 comments

1 changed file

ecordell

pr closed time in 20 days

pull request commentopenshift/origin

Bug 1790825: fix test flake in olm tests

/retest

ecordell

comment created time in 21 days

pull request commentoperator-framework/operator-registry

Bug 1795237: Revert "fix(ci): build opm statically in CI"

/bugzilla refresh

ecordell

comment created time in 21 days

PR opened operator-framework/operator-registry

Revert "fix(ci): build opm statically in CI"

Reverts operator-framework/operator-registry#160

+1 -1

0 comment

1 changed file

pr created time in 21 days

create barnchoperator-framework/operator-registry

branch : revert-160-static-ci

created branch time in 21 days

Pull request review commentoperator-framework/operator-registry

Add semver graph update option to `opm`

 func (i *ImageLoader) loadOperatorBundle(manifest registry.PackageManifest, bund 		return nil 	} -	if err := i.store.AddBundlePackageChannels(manifest, bundle); err != nil {+	if err := i.store.AddBundlePackageChannels(manifest, bundle, i.mode); err != nil {

I sort of expected to see different function calls here based on the mode - seems like there will be a ton of conditional logic based on the mode in this otherwise.

kevinrizza

comment created time in 24 days

Pull request review commentoperator-framework/operator-registry

Add semver graph update option to `opm`

 func (i *ImageLoader) loadManifests(manifests string, annotationsFile *registry. 		return fmt.Errorf("error getting csv from bundle %s: %s", bundle.Name, err) 	} +	// This isn't necessarily right anymore, because the head of the channels may not be what we are adding 	packageManifest, err := translateAnnotationsIntoPackage(annotationsFile, bcsv)

this just shouldn't be called here, right? it should only be called after we know we're adding the head of a channel

kevinrizza

comment created time in 24 days

Pull request review commentoperator-framework/operator-registry

Index maintainers can export a package from an index

 func TestQuerierForDirectory(t *testing.T) {  	etcdChannelEntriesThatProvide, err := store.GetChannelEntriesThatProvide(context.TODO(), "etcd.database.coreos.com", "v1beta2", "EtcdCluster") 	require.ElementsMatch(t, []*registry.ChannelEntry{-		{"etcd", "alpha", "etcdoperator.v0.6.1", ""},-		{"etcd", "alpha", "etcdoperator.v0.9.0", "etcdoperator.v0.6.1"},+		{"etcd", "alpha", "etcdoperator.v0.9.0", ""},

What happened here? where's 0.6.1?

gallettilance

comment created time in 24 days

more