profile
viewpoint
Glenn Dwiyatcita dwiyatci RWTH Aachen Heidelberg, Germany https://tiny.cc/dwiyatci 7-6-2 millimeter, full metal jacket. An 🇮🇩 lives in 🇩🇪.

dwiyatci/jquery-inputsearch 8

🔎 jQuery plugin for transforming <input type="text"> elements into <input type="search"> 🌀like elements

dwiyatci/jquery-stickynotif 4

jQuery plugin to display info, success, warning, error, or general message in a clean and consistent sticky notification. This plugin is based on Sticky: A super simple notification system for jQuery, by Daniel Raftery.

dwiyatci/c8y-angular-polymer-boilerplate 3

⚗ Experimental Cumulocity + Angular + Polymer (Web Components) playground

dwiyatci/cumulocity-hybrid-kitchen-sink 3

🍜 A Cumulocity hybrid "kitchen sink" app for showcasing how to make half-boiled instant noodles, together with the fun and the struggles.

dwiyatci/cumulocity-kitchensink 2

🎛 A Cumulocity "kitchen sink" container app for showcasing the usage of some rather "advanced" Cumulocity UI services and components, as well as revealing the mechanics to extend/adapt the default applications

dwiyatci/cumulocity-unicornify-widget 2

:unicorn: A little esoteric Cumulocity widget that involves unicorns and high-dose of happiness

dwiyatci/dwiyatcita-adolescence-portfolio 2

🚣 My adolescence portfolio.

dwiyatci/generator-c8y 2

💂🌩 Yeoman generator for Cumulocity frontend development

dwiyatci/Apollo-11 1

Original Apollo 11 Guidance Computer (AGC) source code for the command and lunar modules.

dwiyatci/c8y-marketplace-app-example 1

🧙 A Cumulocity Marketplace app example generated by create-react-app and based on Redux Starter Kit advanced project example, developed during Software AG Innovation Week 2019.

issue commentreact-hook-form/react-hook-form

Error for field array item isn't cleared when registered control is removed

Umm, sorry. 🙄 I don't think it needs to be outside of the App though.

There, I basically want to express sth like: "Only render item A if item C exists"

I can surely make the CSB clearer again tomorrow if it needs be (since it's already past midnight here, I only changed shouldShow to shouldRenderItem for now). Thanks Bill!!

dwiyatci

comment created time in 5 hours

issue openedreact-hook-form/react-hook-form

Error for field array item isn't cleared when registered control is removed

Describe the bug Error prop for field array item isn't cleared when the corresponding registered control is removed from the DOM.

To Reproduce Steps to reproduce the behavior:

  1. Click on 'Remove Item C'.
  2. Observe error messages in the "Error Bar".

Codesandbox link (Required) https://codesandbox.io/s/rhf-error-fieldarrayitem-when-control-removed-4cu0w?file=/src/index.jsx

Expected behavior Error message "Item A is required" should not be in the Error Bar since the corresponding registered control for Item A is removed from the DOM when Item C is removed. Error message "Item B is required" should stay put.

Additional context Actually, the logic I've got in my project to show/hide some form controls based on the existence of some other form controls in the DOM is much more complex than what depicted in the CSB. So I would like to rely on the "automatic" removal of the error for such control that's no longer in the DOM, rather than using the "manual" clearErrors(...) API. 😬

created time in 7 hours

issue commentreact-hook-form/react-hook-form

Add support to insert multiple items at once when using useFieldArray

@bluebill1049 Ohh... WOW. So you're sayin' this turns out to have been implemented all along? :D

dwiyatci

comment created time in 4 days

issue commentreact-hook-form/react-hook-form

Add support to insert multiple items at once when using useFieldArray

@bluebill1049 I'm sorry to bother but this seems to become a requirement in my project sooner than I expected. 😣😖😫 While waiting for the up-votes, do you have any idea of a rather clean workaround to realise this with the current lib API? (clearly multiple actions in a loop won't work as mentioned in #2710)

dwiyatci

comment created time in 8 days

issue commentreduxjs/redux-toolkit

Inconsistency in clearing state.error in the Advanced Tutorial

@akursat Hm yeah, I guess that's one way to look at it. 🙂 But imagine state.error is used to render an error message. Then you would want to clear it as soon as you make a request to the network (as it enters the pending reducer), otherwise the error message will still be shown along with the loading spinner until the network comes back to you with a result (either fulfilled or rejected).

So this formulation may well also be desirable:

pending: (state) => {
  state.loading = true;
  state.error = null;
},
fulfilled: (state) => {
  state.loading = false;
},
rejected: (state, action) => {
  state.loading = false;
  state.error = action.payload;
}
dwiyatci

comment created time in 8 days

created tagdwiyatci/the_answer

tagv1.0.2

🔮 The answer to the ultimate question of life, the universe and everything.

created time in 14 days

push eventdwiyatci/the_answer

Glenn Dwiyatcita

commit sha 817c0bb30546a9a1b44ce89749491b0569b9fc9b

remove unnecessary "entry point" `mod.ts` and improve the README

view details

push time in 14 days

delete tag dwiyatci/the_answer

delete tag : v1.0.0

delete time in 14 days

created tagdwiyatci/the_answer

tagv1.0.0

🦕👨‍🚀 The answer to the ultimate question of life, the universe and everything.

created time in 14 days

created tagdwiyatci/the_answer

tagv1.0.1

🦕👨‍🚀 The answer to the ultimate question of life, the universe and everything.

created time in 14 days

created tagdwiyatci/the_answer

tagv1.0.0

🦕👨‍🚀 The answer to the ultimate question of life, the universe and everything.

created time in 14 days

push eventdwiyatci/the_answer

Glenn Dwiyatcita

commit sha 06f985357bc478c063c09e53f16beac3cefd2c39

do we really need an entry point? 🤔

view details

push time in 14 days

delete tag dwiyatci/the_answer

delete tag : v1.0.0

delete time in 15 days

created tagdwiyatci/the_answer

tagv1.0.0

🦕👨‍🚀 The answer to the ultimate question of life, the universe and everything.

created time in 15 days

delete tag dwiyatci/the_answer

delete tag : v1.0.0

delete time in 15 days

created tagdwiyatci/the_answer

tagv1.0.0

🦕👨‍🚀 The answer to the ultimate question of life, the universe and everything.

created time in 15 days

delete tag dwiyatci/the_answer

delete tag : v1.0.0

delete time in 15 days

created tagdwiyatci/the_answer

tagv1.0.0

🦕👨‍🚀 The answer to the ultimate question of life, the universe and everything.

created time in 15 days

push eventdwiyatci/the_answer

Glenn Dwiyatcita

commit sha c183b69859ab8085f78ae7caf1c5f93cdacd755e

add .gitignore

view details

push time in 15 days

create barnchdwiyatci/the_answer

branch : master

created branch time in 15 days

created repositorydwiyatci/the_answer

🦕👨‍🚀 The answer to the ultimate question of life, the universe and everything.

created time in 15 days

issue commentreact-hook-form/react-hook-form

Ability to call trigger() on fieldArray fields

🤔 Hm ok, just to clarify again ('cause I'm also gonna use this manual trigger for fieldArray elements in my project 😁): here in my CSB (https://codesandbox.io/s/react-hook-form-usefieldarray-forked-wu88d?file=/src/index.js), since `test[${index}].firstName` is an input name, trigger(`test[${index}].firstName`) works, right?

benswinburne

comment created time in 19 days

issue commentreact-hook-form/react-hook-form

Ability to call trigger() on fieldArray fields

@bluebill1049 @benswinburne I'm sorry, here as far as my understanding goes, after following the discussion #2379, trigger('fields[i].property') is already supported because fields[i].property is basically a fieldName, right?

benswinburne

comment created time in 20 days

issue openedreact-hook-form/react-hook-form

Add support to insert multiple items at once when using useFieldArray

Hi! I believe this is related to https://github.com/react-hook-form/react-hook-form/issues/2710. Currently I'm developing a "toggle multiple fields" feature in my project wherein I've got to be able to toggle the middle field items (form controls) ON/OFF. Here's some hypothetical snippet:

useEffect(() => {
  if (toggledOff) {
    const middleIndexes = _.range(1, fields.length - 1);

    remove(middleIndexes);
  } else {
    const middleFieldItems = [
      { index: 1, value: { foo: 42 } },
      { index: 2, value: { foo: 43 } },
    ];

    // currently not supported API
    insert(middleFieldItems);
  }
}, [toggledOff]);

While I can comfortably use remove([]) API to remove multiple field item (for toggling off) but I don't have its counterpart insert([]) (for toggling on).

Describe the solution you'd like Support insert([{ index, value, shouldFocus }, { index, value, shouldFocus }, ...]). 🙂

Thank you 🙇🏻‍♂️

created time in 21 days

startedjanhommes/noREST

started time in 24 days

issue openedjanhommes/noREST

🦕 Make it compatible for Deno

As the title says.

♨️ 😌

created time in 24 days

issue openedreduxjs/redux-toolkit

Inconsistency in clearing state.error in the Advanced Tutorial

Hi again! :)) I noticed that in the Advanced Tutorial, the state.error for issues slice and comments slice are being cleared inconsistently.

  • In the issues slice, the state.error is cleared in "fulfilled" reducers: https://codesandbox.io/s/rtk-github-issues-example-03-final-ihttc?from-embed=&file=/src/features/issuesList/issuesSlice.ts:1106-1131

  • In the comments slice, the state.error is cleared in "pending" and "fulfilled" reducers: https://codesandbox.io/s/rtk-github-issues-example-03-final-ihttc?from-embed=&file=/src/features/issueDetails/commentsSlice.ts:535-846

What would be the best place to clear the error state in order to make it consistent when dealing with async requests? Would it be enough to clear it in the "pending" reducers only? 🤔

created time in a month

issue openedreduxjs/redux-toolkit

Possibility of customising function that generates requestId in the action's meta of createAsyncThunk

Hi! :) First of all, let me express my gratitude that this library (toolkit) had already existed back in February/March when I first re-architected some project at my current company – it's been making my life so much easier since then, and fun to use – so a big THANK YOU! 🙏😇🙇🏻‍♂️🙇🏻‍♂️

Recently though, there is one aspect/requirement that I have to fulfil in my app, which is all the network requests have to be able to be tracked by uuidv4 (to conform with the existing logging/analysis infrastructure).

As I want to make use of the RTK built-in feature as much as possible, would it be possible to add a possibility to pass a custom function other than nanoid (in my case, it'd be uuidv4) to generate the action.meta.requestId used by createAsyncThunk?

This is a rather simplistic construct of how my slice would look like:

extraReducers: {
  [fetchSomething.pending]: (state, action) => {
    state.loading = true;
    state.pendingRequestIds.push(action.meta.requestId);
  },
},

I mean, currently, to satisfy this requirement, I'm making use of action.meta.arg.requestId and doing the wiring when dispatching: dispatch(fetchSomething({ requestId: uuidv4() })). So I thought it would be nice and cleaner if this feature could be implemented per se.

Thank you.

created time in a month

issue commentreact-hook-form/react-hook-form

getValues('fieldArray') doesn't seem to work inside of event handler

@bluebill1049 Hm. I, by the way, also put "inline" defaultValue on each <Controller /> in my program, but it's got the same inconsistency as illustrated in my CSB above (not sure if this is what you mean by "inline default value"). What makes it consistent in the end is to do defaulting values by using watch('test', fields) you mentioned above in my child component. 🤩

But then again, unfortunately I couldn't achieve the same consistency when using useWatch({ name: 'test', control, defaultValue: fields }). 😕 Here, you can see what I mean by uncommenting the useWatch block: https://codesandbox.io/s/react-hook-form-usefieldarray-template-forked-do236?file=/src/Child.jsx:132-248

And yup - at the end of the day, probably this really needs some good explanation and tutorial 😁

dwiyatci

comment created time in a month

issue commentreact-hook-form/react-hook-form

getValues('fieldArray') doesn't seem to work inside of event handler

@bluebill1049 Actually, you know what, Bill. I guess what I made in the previous CSB already manifests my issue very well. 😂

Here is the updated CSB again: https://codesandbox.io/s/react-hook-form-usefieldarray-template-forked-erbwu?file=/src/Child.jsx:195-266

Please take notice on the followings:

  • defaultValues is provided in useForm().
  • Default values (firstName and lastName) are provided for the new item when inserting.
  • Try to insert/remove item. You can observe in the console during the first render, the length of watchedFieldArray is always 1, which I guess is the length of test array being passed as defaultValues to useForm(). Whereas the length of fieldArray always represents the real length of the items, even on the first render.

Perhaps, as you said, this is a rather inevitable limitation?

dwiyatci

comment created time in a month

issue commentreact-hook-form/react-hook-form

getValues('fieldArray') doesn't seem to work inside of event handler

Sure! :) Would be glad to try to reconstruct this on CSB. I'll work on it sometime this week~

dwiyatci

comment created time in a month

issue commentreact-hook-form/react-hook-form

getValues('fieldArray') doesn't seem to work inside of event handler

@bluebill1049 Yah, I've read that before. Thing is, I provided the complete defaultValuesalready in useForm for that certain fieldArray field. It should be the same as providing it in watch or useWatch, right? ButsStill, it didn't help to fill that "gap" during inserting/removing of an item (I've also double-checked that I filled all the default values for the item when inserting). Well, I guess I may well stick with fieldArray.length from the parent for now 😬

dwiyatci

comment created time in a month

issue commentreact-hook-form/react-hook-form

getValues('fieldArray') doesn't seem to work inside of event handler

I see. Thank you so much for this, at least I know now what's happening, roughly 😀

dwiyatci

comment created time in a month

issue commentreact-hook-form/react-hook-form

getValues('fieldArray') doesn't seem to work inside of event handler

@bluebill1049 Yes, actually I've been using useWatch in my child component under my field array construction. But it seems like there is a split-second discrepancy between the watchedFieldArray value and the fieldArray value itself after I insert and/or remove element to the the fieldArray. I've been inspecting this bug in my program since this morning because some variables in my child component depend on the watchedFieldArray.length. 😞

Here, I've updated the CSB again to further illustrate my problem: https://codesandbox.io/s/react-hook-form-usefieldarray-template-forked-erbwu?file=/src/Child.jsx:195-323

So I guess the question now is: should I use fieldArray.length from the parent or watchedFieldArray.length?

dwiyatci

comment created time in a month

issue commentreact-hook-form/react-hook-form

getValues('fieldArray') doesn't seem to work inside of event handler

@bluebill1049 I'm sorry to come back to this issue again. But when I tried to getValues() in my app after insert and remove, it even returned undefined for the "fieldArray". Is this also intended?

Please go here again as I've updated the CSB, and click on "Insert at" and/or "Remove at": https://codesandbox.io/s/react-hook-form-usefieldarray-template-forked-erbwu?file=/src/index.js:2214-2341

dwiyatci

comment created time in a month

issue commentreact-hook-form/react-hook-form

getValues('fieldArray') doesn't seem to work inside of event handler

Ahh okay, didn't know that it was expected. Thanks, as always, Bill! :))

dwiyatci

comment created time in a month

issue openedreact-hook-form/react-hook-form

getValues('fieldArray') doesn't seem to work inside of event handler

Describe the bug When using useFieldArray, getValues('fieldArray') returns undefined inside of an event handler. But getValues().fieldArray returns the array though. 😅

To Reproduce Steps to reproduce the behavior:

  1. Click on 'Append'.
  2. See log in the console.

Codesandbox link (Required) https://codesandbox.io/s/react-hook-form-usefieldarray-template-forked-erbwu?file=/src/index.js:1575-1702

Expected behavior getValues('fieldArray') should returns the same thing as getValues().fieldArray.

created time in a month

issue openedreact-hook-form/react-hook-form

reset() only resets the first field even though defaultValues provided

Describe the bug Calling reset() without argument only resets the first field even though defaultValues has been provided in useForm().

To Reproduce Steps to reproduce the behavior:

  1. Click on 'Reset with values'.
  2. Observe the "Last name" field.

Codesandbox link (Required) https://codesandbox.io/s/react-hook-form-reset-v6-forked-4ppbq?file=/src/index.js

Expected behavior Calling reset() without any args should fallback to defaultValues provided in the useForm(), i.e. "First name" and "Last name" fields should be reset to "bill" and "luo" respectively.

Desktop (please complete the following information):

  • OS: macOS Catalina 10.15.6
  • Browser Chrome
  • Version 85

created time in a month

issue commentjsfiddle/jsfiddle-issues

Uncaught TypeError: console.dir is not a function

@oskarkrawczyk Sorry, I still got:

?editor_console=true:87 Uncaught ReferenceError: args is not defined
    at Object.dir (?editor_console=true:87)
    at ?editor_console=true:108

😕

Maybe I need to wait for quite some time?

dwiyatci

comment created time in a month

issue commentreact-hook-form/react-hook-form

incorrect watch warning

@bluebill1049 Thanks for the quick patch. I just gave it a spin and works as expected as before. 🙇🏻‍♂️

bluebill1049

comment created time in a month

issue commentreact-hook-form/react-hook-form

Nested Field Array - useWatch and watch inconsistency

@bluebill1049 The "📋 watched fields: ... are not found." warnings.

And yes, I can repro it. Here I simply forked the CSB from Matias: https://codesandbox.io/s/nested-field-array-usewatch-and-watch-inconsistency-forked-5u3u6?file=/src/App.js

Please click on "add array field" or "add nested array field" or "remove", and then you'll see the warnings in the console even though I've put default values for both watch and useWatch - I've got pretty much similar thing in my app.

MatiasCiccone

comment created time in a month

issue openedjsfiddle/jsfiddle-issues

Uncaught TypeError: console.dir is not a function

Steps to reproduce:

  • simply write code that uses console.dir in JavaScript panel:
const arr = [2, 3, 5];
console.dir(arr);

Actual: Error thrown in the console:

Uncaught TypeError: console.dir is not a function at ?editor_console=true:106

Expected: Using console.dir should be valid and not throw an error.

created time in a month

issue commentreact-hook-form/react-hook-form

Nested Field Array - useWatch and watch inconsistency

Hi, I'm sorry to jump in. But I believe I encountered similar issue when adding/removing item using useFieldArray.

@bluebill1049 I've followed your suggestion above to add default values, but it didn't seem to make the warnings go away. 😕

const xs = watch('xs', []);
// watched fields: xs are not found.

const foo = watch(`xs[${index}].foo`, '');
// watched fields: xs[1].foo are not found.

That said, it appears not to have functionality to the form UI though. Do you think I can safely ignore these warnings? Or perhaps you have any other suggestion?

MatiasCiccone

comment created time in a month

issue commentreact-hook-form/react-hook-form

<FormProvider> node doesn't seem to respect `style` prop

Thanks @bluebill1049, you're always lightning fast!! 🏃🏻‍♂️⚡

dwiyatci

comment created time in a month

issue openedreact-hook-form/react-hook-form

<FormProvider> node doesn't seem respect `style` props

Describe the bug Not sure if this is React or RHF-specific.

To Reproduce Steps to reproduce the behavior:

  1. Put style={{ display: 'none' }} on the <FormProvider> or on the containing node, e.g. <App>.
  2. Observe the behavior.

Codesandbox link (Required) https://codesandbox.io/s/provider-perf-forked-zjd0k?file=/src/App.js:812-824

Expected behavior Form should not be shown (not mounted).

Desktop (please complete the following information):

  • OS: MacOS 10.15.6
  • Browser: Chrome
  • Version: 85

created time in a month

issue commentimmerjs/use-immer

Updater function doesn't return next state (unlike Immer's produce)

🙆🏻‍♂️ 🆗, I see. Many thanks! :)

dwiyatci

comment created time in 2 months

issue commentimmerjs/use-immer

Updater function doesn't return next state (unlike Immer's produce)

@mweststrate Thank you for the enlightenment. That said, I found the construct of using useRef and useEffect is rather convoluted. 😕

As far as the updater function is concerned, isn't the effect (e.g. dispatch(savePerson(updatedPerson))) will be outside of the state updater function itself, thus it still won't have side effects?

Here in the Redux docs, I can see it appears to be "legal" to do asynchronous dispatch (effect) directly inside of an event (click) handler:

  • https://redux.js.org/tutorials/essentials/part-5-async-logic#checking-thunk-results-in-components
  • https://codesandbox.io/s/github/reduxjs/redux-essentials-example-app/tree/checkpoint-3-postRequests/?file=/src/features/posts/AddPostForm.js
dwiyatci

comment created time in 2 months

pull request commentpatresk/saturn

Add filter and clear functionality

@patresk Ahahah, true that. But I believe that should still be long way down the road. One step at a time, right ;)

Thanks for publishing the new version to the Chrome Web Store already! 🙇🏻‍♂️

patresk

comment created time in 2 months

Pull request review commentpatresk/saturn

Add filter and clear functionality

 function AppPure(props) {   );    const isDarkMode = window.matchMedia("(prefers-color-scheme: dark)").matches;+  const filteredList = useMemo(() => {+    return filter.length > 0+      ? list.filter((item) =>+          // TODO: regex?+          (item.operationName || "")+            .toLowerCase()+            .includes(filter.toLowerCase())

Uh, actually forgot one thing: since I implemented something similar before, I'd highly suggest to escape the filter by using this litte function (https://stackoverflow.com/a/3561711/2013891) in order to avoid breakage when the user enters special regex char in the filter text, such as ., /, [, etc (I know that could not possibly be in the operation name, but yeah 🙄 ).

(item.operationName || '').match(RegExp(escapeRegex(filter), 'i'))

// ...

function escapeRegex(string) {
  return string.replace(/[-\/\\^$*+?.()|[\]{}]/g, '\\$&');
}
patresk

comment created time in 2 months

PullRequestReviewEvent

pull request commentpatresk/saturn

Add filter and clear functionality

I've only got one little comment 😬, lgtm otherwise 💯 🎉

patresk

comment created time in 2 months

Pull request review commentpatresk/saturn

Add filter and clear functionality

 function AppPure(props) {   );    const isDarkMode = window.matchMedia("(prefers-color-scheme: dark)").matches;+  const filteredList = useMemo(() => {+    return filter.length > 0+      ? list.filter((item) =>+          // TODO: regex?+          (item.operationName || "")+            .toLowerCase()+            .includes(filter.toLowerCase())

Right, this may well be:

(item.operationName || '').match(RegExp(filter, 'i'))

:)

patresk

comment created time in 2 months

PullRequestReviewEvent

issue openedimmerjs/use-immer

Updater function doesn't return next state (unlike Immer's produce)

Hi, 🙂 I would like to do a sort of "optimistic" update mechanics but I found out that the updater function only returns me undefined instead of the next state when I wanna do update to the backend. Here is my hypothetical code snippet:

function PersonUpdater() {
  const personDataFromTheBackend = useSelector((state) => state.person);
  const dispatch = useDispatch();

  const [person, updatePerson] = useImmer({
    name: 'Glenn',
    age: 30,
  });

  useEffect(() => {
    updatePerson(() => personDataFromTheBackend);
  }, [personDataFromTheBackend]);

  return (
    <div className="PersonUpdater">
      <h1>
        Hello {person.name} ({person.age})
      </h1>
      <br />
      <button onClick={becomeOlder}>Older</button>
    </div>
  );

  function becomeOlder() {
    const updatedPerson = updatePerson((draft) => {
      draft.age++;
    });

    // updatedPerson is undefined
    console.log(updatedPerson);

    // this will make a call to the backend
    dispatch(savePerson(updatedPerson));
  }
}

I know I could make use of the next state of (updated) person in useEffect hook, but this would make unnecessary network call when the component first loaded/mounted.

useEffect(() => {
  // this will make an unnecessary update call to the backend when the component first rendered
  dispatch(savePerson(person));
}, [person]);

Not sure if this is by-design though. 🙄

@mweststrate Thank you so much for this awesome Immer's library btw 🙇🏻‍♂️

created time in 2 months

created tagdwiyatci/fiddle

tagv1.0.4

a little fiddler in the rye

created time in 2 months

push eventdwiyatci/fiddle

Glenn Dwiyatcita

commit sha 060dcea1b1baca276b0aae365a268b1a4fbd98ab

🔩 chore: upgrade deps

view details

Glenn Dwiyatcita

commit sha 5db10d5d0a33e0fadd977178964e2614e214082b

🔩 chore: try dry run

view details

Glenn Dwiyatcita

commit sha dd6a41cef7ca7e15918932abeb7c67a9ed71c236

📦 chore(release): version v1.0.4 build [ci skip]

view details

push time in 2 months

created tagdwiyatci/fiddle

tagv1.0.2

a little fiddler in the rye

created time in 2 months

push eventdwiyatci/fiddle

Glenn Dwiyatcita

commit sha 8099e3011ee56869811e0336329a7de70eaa0d12

chore(release): version v1.0.2 build [ci skip]

view details

push time in 2 months

push eventdwiyatci/fiddle

Glenn Dwiyatcita

commit sha e80c52215626b9a012f5cc3a5f114192ef4fdb94

🔩 chore(versioning): prepare to automate more, always starts with v1.0.0

view details

push time in 2 months

push eventdwiyatci/fiddle

Glenn Dwiyatcita

commit sha b8e10a055a3127f42f26a288e7d776f205e20c8e

🔩 chore(versioning): play along `lerna version`

view details

push time in 2 months

push eventdwiyatci/cahlanang

Glenn Dwiyatcita

commit sha 8c2fb94836f96d501bf2f39bc088cafb8c1a2a21

Errare humanum est.

view details

push time in 2 months

push eventdwiyatci/cahlanang

Glenn Dwiyatcita

commit sha 6beef62ff833f33724e0e73f857845ae2f452a53

Committing in accordance with the prophecy.

view details

push time in 2 months

fork dwiyatci/node-bulletin-board

Sample bulletin board app in Node.js and Vue.js

fork in 2 months

issue openedpatresk/saturn

🍸 Filter by Operation name

Hello, @patresk! 👋 😃 First off, thank you so much for your efforts on this Chrome extension. This is the most useful one I could find out there for debugging GraphQL requests.

That said, I'm missing the ability to filter the requests by (operation) name like in the regular "Network" tab. I believe once this "Filter" and "Clear all" (#3) features are implemented, this extension would be perfect to get a very well going. Thanks again! 🙇🏻‍♂️

created time in 2 months

issue commentgooglefonts/Inconsolata

No Ligatures in Ligconsolata

I downloaded it from the v3.000 tree:

  • https://github.com/googlefonts/Inconsolata/blob/v3.000/fonts/otf/Ligconsolata-Bold.otf
  • https://github.com/googlefonts/Inconsolata/blob/v3.000/fonts/otf/Ligconsolata-Regular.otf
  • https://github.com/googlefonts/Inconsolata/blob/v3.000/fonts/ttf/Ligconsolata-Bold.ttf
  • https://github.com/googlefonts/Inconsolata/blob/v3.000/fonts/ttf/Ligconsolata-Regular.ttf

Works for me on my IDE (VSCode/WebStorm), but for some strange reason it doesn't on my Terminal 🤷🏻‍♂️

rajadain

comment created time in 2 months

push eventdwiyatci/cahlanang

Glenn Dwiyatcita

commit sha 91cf2c6da26fff3e9ca68e315bbfb23c20135279

see if adding nyancat globally make it work to run it inside Docker (apparently not hahah)

view details

push time in 2 months

push eventdwiyatci/cahlanang

Glenn Dwiyatcita

commit sha 9796e712d4ebee6c982426fccacf79ff1fd6a79e

Who has two thumbs and remembers the rudiments of his linear algebra courses? Apparently, this guy.

view details

push time in 2 months

push eventdwiyatci/cahlanang

Glenn Dwiyatcita

commit sha 64be016d9e687e7e6849190fb1ad11f28a997206

pep8 - cause I fell like doing a barrel roll

view details

push time in 2 months

push eventdwiyatci/cahlanang

Glenn Dwiyatcita

commit sha 187343c76b0f56c718f928b0f70687c863751332

Added missing ignore item in previous commit

view details

push time in 2 months

create barnchdwiyatci/cahlanang

branch : master

created branch time in 2 months

created repositorydwiyatci/cahlanang

🐳🏄‍♂️ play along with docker

created time in 2 months

startedreact-hook-form/react-hook-form

started time in 2 months

issue openedhashicorp/vagrant

"Vagrant vs. Other Software" section in the website seems to be broken

Previously I used to be able to access these pages via the sidebar, but not anymore now:

  • https://www.vagrantup.com/intro/vs/cli-tools
  • https://www.vagrantup.com/intro/vs/docker
  • https://www.vagrantup.com/intro/vs/terraform

Please see the following screenshot. Screenshot 2020-08-23 at 11 35 23

Thank you. 🙇🏻‍♂️

created time in 2 months

issue commentreact-hook-form/react-hook-form

ReValidateMode 'onChange' doesn't validate after changes?

@bluebill1049 That's brilliant. Turned out it's pretty easy (and rather clean!) to make the workaround I need to satisfy my UX requirements. I have to set both mode and reValidateMode to 'onBlur' though, and then trigger the validation manually onChange if the control has any errors.

I'll simply leave my CSB here just in case future readers might find it useful: https://codesandbox.io/s/react-hook-form-v6-triggervalidation-forked-cbfvt?file=/src/index.js

Thanks again, Bill!! 😃

martinfrancois

comment created time in 2 months

issue commentreact-hook-form/react-hook-form

ReValidateMode 'onChange' doesn't validate after changes?

@bluebill1049 Hi again, Bill. Thank you so much for the new onTouched mode, it's awesome and is enough to get me going. Unfortunately after I've tested the interactions in CSB (https://codesandbox.io/s/react-hook-form-get-started-forked-ilrdu?file=/src/index.js), it still does not quite satisfy my UX requirements.

Here is what I did: 1. Enter "foo" in ExampleRequired control.

2. Delete "foo" from the control. ➡️ no validation result presented. ✅

3. Blur the control. Validation result "This field is required" appears. ➡️ cool, it's holding back on presenting updated validation results until focus leaves the field (onBlur) when the validation state goes from valid to invalid. 🙂

4. Focus again on the ExampleRequired control and enter "x". Validation result "This field is required" gone. ➡️ great, it's presenting updated validation results as soon as the validation state changes from invalid to valid on keypress (onChange). 🙂

5. Delete "x" from the control. Validation result "This field is required" appears. ➡️ here, I expect the validation result should appear only after I blur the control again since the validation state goes from valid to invalid. ❌🙁

Any thoughts of workaround? Should I make use of previous state vs. current state to control when to show the validation result?

martinfrancois

comment created time in 2 months

issue commentreact-hook-form/react-hook-form

ReValidateMode 'onChange' doesn't validate after changes?

@bluebill1049 Thanks for pointing the PR out! :) I've looked at that PR before posting my comment above but I'm not so sure if it's gonna satisfy the UX requirements above, especially the second point: "Eagerly reward users for correcting invalid data". Thing is, when the form control has error (is invalid) after touching, the user would still need to do submit first before the revalidation got triggered (onChange).

I might be misunderstanding some things here, that's why I would like to try the new version of RFH first on CSB in order to test the interaction. Are you gonna release this feature soon?

martinfrancois

comment created time in 2 months

issue commentreact-hook-form/react-hook-form

ReValidateMode 'onChange' doesn't validate after changes?

I'm glad that I came across this issue one month later 'cause actually I want to implement a UX in exactly the same line of theorem as @martinfrancois 🙂

--- ✂️ snip ------ There are a couple rules of thumb that guide how we implement validation triggers:

  1. Do not eagerly scold users for invalid data
  • A field should not be changed into an invalid state while the user is interacting with the field
  • This often means holding back on presenting updated validation results until focus leaves the field (onBlur)
  1. Eagerly reward users for correcting invalid data
  • The user should be informed as soon as a field is changed from invalid to valid state
  • This often means presenting updated validation results as soon as the validation state changes from invalid to valid, including on keypress (onChange)

On the surface, these rules can seem slightly contradictory. Do not validate until blur, but validate on change? However, there is a subtlety involved based on the current field validation status. If the field is already invalid, then we should update the validation results on change, without waiting for focus to leave. But if the field is was previously valid or it hasn't yet been validated, then we should wait until focus leaves the field before updating the validation results for the field. This approach improves usability and decreases frustration for the user. --- ✂️ snap ------

It's so unfortunate that RFH would need a breaking change if this "ideal" behaviour were to be introduced. 😕 But thank you so much @bluebill1049 for such a amazing masterpiece, and for suggesting this workaround:

however, RHF is flexible, you can set both mode to onSubmit and trigger validation accordingly, or simply always trigger the errors and use form state to filter when to display errors

I will try to follow this suggestion and will come back again if I have any questions ✨😁

martinfrancois

comment created time in 2 months

startedimmerjs/immer

started time in 3 months

push eventdwiyatci/minimalistic-devserver

Glenn Dwiyatcita

commit sha d1804a7f296f3636d96273fa82619a69389552ba

🔩 chore(covit-19): update deps

view details

push time in 3 months

more