profile
viewpoint
Björn Steinbrink dotdash Bielefeld, Germany

dotdash/rust-flexarray 2

A hack to provide flexarray support while waiting for DST

dotdash/actix-extras 0

A collection of additional crates supporting the actix and actix-web frameworks.

dotdash/actix-web 0

Actix web is a small, pragmatic, and extremely fast rust web framework.

dotdash/body-parser 0

JSON body parsing for iron

dotdash/cargo 0

The Rust package manager

dotdash/clap-rs 0

A full featured, fast Command Line Argument Parser for Rust

dotdash/docopt.rs 0

Docopt for Rust (command line argument parser).

dotdash/dotvim 0

My vim configuration

dotdash/git2-rs 0

libgit2 bindings for Rust

dotdash/gltf-viewer 0

glTF 2.0 Viewer written in Rust

issue commentpasscod/cargo-watch

File creation/deletion triggers rebuild even if the file is ignored

Ignoring writes for folders, may mean that adding a folder doesn't trigger.

Looking at a debug trace, at least on Windows it seems that there's a dedicated type for creation/removal of a directory.

I'm seeing

*** Paths updated: [PathOp { path: "\\\\?\\C:\\Users\\bstei\\src\\klm\\bla", op: Some(CREATE), cookie: None }]

and

*** Paths updated: [PathOp { path: "\\\\?\\C:\\Users\\bstei\\src\\klm\\bla", op: Some(REMOVE), cookie: None }]

while the problematic event had a Some(WRITE) value for op. In which casses is a write event on a directory actually interesting?

dotdash

comment created time in 4 days

issue openedpasscod/cargo-watch

File creation/deletion triggers rebuild even if the file is ignored

At least on the Windows 10 machine I'm currently working on, the creation and deletion of vim swap files causes rebuilds, even though the files are ignored. It seems that the change on the directory (which is not ignored) is responsible for this:

*** Ignoring "\\\\?\\C:\\Users\\bstei\\src\\klm\\src\\.responses.rs.swp": matched ignore filter
*** Ignoring "\\\\?\\C:\\Users\\bstei\\src\\klm\\src\\.responses.rs.swp": matched ignore filter
*** Paths updated: [PathOp { path: "\\\\?\\C:\\Users\\bstei\\src\\klm\\src", op: Some(WRITE), cookie: None }]
[Running 'cargo run']

I don't recall seeing this on Linux, but I don't have access to a machine to test this on right now.

created time in 11 days

push eventdotdash/actix-extras

Björn Steinbrink

commit sha 3e17ad9a4ef942440210f0b0e5c9db43bcecc319

Remove unneeded single path import Imports with a single path component are useless.

view details

Björn Steinbrink

commit sha d84915741139523c4dbc8e7a6265c67b8dc9c976

Update Session doc to refer to UserSession instead of RequestSession

view details

push time in 15 days

pull request commentactix/actix-web

Update Session doc to refer to UserSession instead of RequestSession

https://github.com/actix/actix-extras/pull/3

dotdash

comment created time in 16 days

create barnchdotdash/actix-extras

branch : doc_fix

created branch time in 16 days

fork dotdash/actix-extras

A collection of additional crates supporting the actix and actix-web frameworks.

https://actix.rs

fork in 16 days

create barnchdotdash/actix-web

branch : doc_fix

created branch time in 16 days

fork dotdash/actix-web

Actix web is a small, pragmatic, and extremely fast rust web framework.

https://actix.rs

fork in 16 days

issue closedbmewburn/vscode-intelephense

All(?) standard functions marked as deprecated since 1.3.5

Describe the bug Since version 1.3.5 I get warnings about pretty much all standard functions being deprecated, e.g. preg_match, array_pop, explode, etc.

This only happens in some projects and I have not figured out yet what triggers it. Having just a single file does not trigger the problem. The problem does not show up with 1.3.4 either.

To Reproduce Unfortunately I can't share the code that exhibits the problem, and it's not exactly a snippet either. If I manage to get a working example I'll add it, in the meantime I'm happy to follow instructions to try to help debugging this. Maybe there was just a change that I missed that requires adjustments to my LSP client configuration?

Expected behavior The standard PHP functions should not be marked as deprecated (except for those that actually are deprecated, obviously ;-))

Platform and version Debian Linux, Sid, Intelephense 1.3.5 - 1.3.7, using Vim with ALE as the LSP client.

closed time in a month

dotdash

issue commentbmewburn/vscode-intelephense

All(?) standard functions marked as deprecated since 1.3.5

That did the trick! Initially the functions showed up as undefined, as they were assumed to be in the current namespace, but after a few seconds the errors disappeared and now everything works correctly, even immediately after starting vim and opening a file.

Thanks a lot!

dotdash

comment created time in a month

issue commentbmewburn/vscode-intelephense

All(?) standard functions marked as deprecated since 1.3.5

Unfortunately the issue still shows up with 1.3.8.

dotdash

comment created time in a month

issue commentbmewburn/vscode-intelephense

All(?) standard functions marked as deprecated since 1.3.5

Edit: can you check if "Go to definition" on function leads to somewhere?

That jumps to the stub defined in the intelephense code

dotdash

comment created time in a month

issue openedbmewburn/vscode-intelephense

All(?) standard functions marked as deprecated since 1.3.5

Describe the bug Since version 1.3.5 I get warnings about pretty much all standard functions being deprecated, e.g. preg_match, array_pop, explode, etc.

This only happens in some projects and I have not figured out yet what triggers it. Having just a single file does not trigger the problem. The problem does not show up with 1.3.4 either.

To Reproduce Unfortunately I can't share the code that exhibits the problem, and it's not exactly a snippet either. If I manage to get a working example I'll add it, in the meantime I'm happy to follow instructions to try to help debugging this. Maybe there was just a change that I missed that requires adjustments to my LSP client configuration?

Expected behavior The standard PHP functions should not be marked as deprecated (except for those that actually are deprecated, obviously ;-))

Platform and version Debian Linux, Sid, Intelephense 1.3.5 - 1.3.7, using Vim with ALE as the LSP client.

created time in a month

delete branch dotdash/rust

delete branch : fast_lex_reg_resol_item_bodies

delete time in a month

delete branch dotdash/rust

delete branch : erase_reg

delete time in a month

delete branch dotdash/rust

delete branch : expand

delete time in a month

delete branch dotdash/rust

delete branch : locals

delete time in a month

delete branch dotdash/rust

delete branch : jt_assume

delete time in a month

delete branch dotdash/rust

delete branch : asserts

delete time in a month

create barnchdotdash/rust

branch : projections

created branch time in a month

push eventdotdash/rust

Dylan MacKenzie

commit sha 34ce0ba9196df288c21907811b63603eb53809bb

Use better name for local containing required feature gates

view details

Dylan MacKenzie

commit sha 598bed6f5124ceef83d69256d7e15ec404dda439

Ensure test actually uses dataflow, not simulation

view details

Dylan MacKenzie

commit sha 029725f139c581e4484460d90d23909d7d4bebc1

Use correct nightly version for feature

view details

ecstatic-morse

commit sha 0f0bfc9c2253c44fb826b057e4356bb50e9c704f

Document `Features::enabled` Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>

view details

Dylan MacKenzie

commit sha faa52d1cdaa8806201d56484df0c45bf550bf565

Correctly mark things as `min_const_fn`

view details

Patrick Wang

commit sha b65c6ec10fe2b80e22706f5b3245cc5f6f372edf

Fix incorrect example code of OpenOptions::open

view details

Mazdak Farrokhzad

commit sha df9e491fb238ff7b7bfee8dd2d3f01158ac8b0d3

Rollup merge of #67026 - Nadrieril:improve-usefulness-empty, r=varkor,Centril,estebank Improve diagnostics and code for exhaustiveness of empty matches There was a completely separate check and diagnostics for the case of an empty match. This led to slightly different error messages and duplicated code. This improves code reuse and generally clarifies what happens for empty matches. This also clarifies the action of the `exhaustive_patterns` feature, and ensures that this feature doesn't change diagnostics in places it doesn't need to.

view details

Mazdak Farrokhzad

commit sha 48164f8a17501e7386afa4a371432168e598fcb5

Rollup merge of #67235 - jonas-schievink:vecdeque-leak, r=KodrAus VecDeque: drop remaining items on destructor panic Closes https://github.com/rust-lang/rust/issues/67232

view details

Mazdak Farrokhzad

commit sha a0be3a683d40981b5ea19c94640621f0816c3b1a

Rollup merge of #67254 - RalfJung:vtable-ice, r=oli-obk dont ICE in case of invalid drop fn Fixes https://github.com/rust-lang/miri/issues/1112 r? @oli-obk

view details

Mazdak Farrokhzad

commit sha 88e702a6ec5e166f20dfc51eaa4b85fc4a045d6b

Rollup merge of #67256 - RalfJung:reduce-allocs, r=oli-obk Reduce allocs for validation errors This probably doesn't really matter, but I just felt like I had to do this... r? @oli-obk

view details

Mazdak Farrokhzad

commit sha 83536a5c82fae9278831cf74e82d9d8cdaf2d455

Rollup merge of #67274 - RalfJung:uninit, r=Centril be explicit that mem::uninitialized is the same as MaybeUninit::uninit().assume_init() Cc @Centril @nikomatsakis

view details

Mazdak Farrokhzad

commit sha 0f30462efa750f26ffecdb7c6099d25f5cd97078

Rollup merge of #67278 - Centril:67273, r=oli-obk `coerce_inner`: use initial `expected_ty` Fixes #67273. Follow-up to #59439. r? @oli-obk

view details

Mazdak Farrokhzad

commit sha d0cc289ec0fa35de2aa35df5445ebca332ccf4f6

Rollup merge of #67280 - shalzz:patch-1, r=jonas-schievink docs: std::convert::From: Fix typo Fix a minor typo

view details

bors

commit sha ff15e9670843f8bd6b54ab1b042d2095b4c0aa6d

Auto merge of #67284 - Centril:rollup-ghiukob, r=Centril Rollup of 7 pull requests Successful merges: - #67026 (Improve diagnostics and code for exhaustiveness of empty matches) - #67235 (VecDeque: drop remaining items on destructor panic) - #67254 (dont ICE in case of invalid drop fn) - #67256 (Reduce allocs for validation errors) - #67274 (be explicit that mem::uninitialized is the same as MaybeUninit::uninit().assume_init()) - #67278 (`coerce_inner`: use initial `expected_ty`) - #67280 (docs: std::convert::From: Fix typo) Failed merges: r? @ghost

view details

Mateusz Mikuła

commit sha 2d8d8136fa4d67574e7b27a3f262819627cf1622

Update tokio crates to latest versions

view details

Josh Stone

commit sha 6c7c5120200b711262f1c67f1924ae0835080286

Fix the configure.py TOML field for a couple LLVM options The actual fields in `config.toml.example` have dashes, not underscores.

view details

bors

commit sha 8843b28e64b02c2245f5869ad90cafa6d85ab0d9

Auto merge of #65951 - estebank:type-inference-error, r=nikomatsakis Point at method call when type annotations are needed - Point at method call instead of whole expression when type annotations are needed. - Suggest use of turbofish on function and methods. Fix #49391, fix #46333, fix #48089. CC #58517, #63502, #63082. Fixes https://github.com/rust-lang/rust/issues/40015 r? @nikomatsakis

view details

bors

commit sha 12307b3b08edee543a78fb9d4a837fbd6d6ac0fa

Auto merge of #67084 - Pagten:feature/print-msg-from-elf-entrypoint, r=Amanieu SGX: Change ELF entrypoint This fixes [rust-sgx issue #148](https://github.com/fortanix/rust-sgx/issues/148). A new entry point is created for the ELF file generated by `rustc`, separate from the enclave entry point. When the ELF file is executed as a Linux binary, the error message below is written to stderr. > Error: This file is an SGX enclave which cannot be executed as a standard Linux binary. > See the installation guide at https://edp.fortanix.com/docs/installation/guide/ on how to use 'cargo run' or follow the steps at https://edp.fortanix.com/docs/tasks/deployment/ for manual deployment. When the ELF file is converted to an SGXS using `elf2sgxs`, the old entry point is still set as the enclave entry point. In a future pull request in the rust-sgx repository, `elf2sgxs` will be modified to remove the code in the ELF entry point, since this code is not needed in the enclave.

view details

Ohad Ravid

commit sha 8a4632dec69082301d3fe67e48d422bc9fb665be

Indicate origin of where type parameter for uninferred types

view details

bors

commit sha c8ea4ace9213ae045123fdfeb59d1ac887656d31

Auto merge of #67136 - oli-obk:const_stability, r=Centril Require stable/unstable annotations for the constness of all stable fns with a const modifier r? @RalfJung @Centril Every `#[stable]` const fn now needs either a `#[rustc_const_unstable]` attribute or a `#[rustc_const_stable]` attribute. You can't silently stabilize the constness of a function anymore.

view details

push time in a month

create barnchdotdash/rust

branch : copy_prop

created branch time in a month

push eventdotdash/dotvim

Björn Steinbrink

commit sha f0e61fd89feb9220b4bbf360c3c0cc46f4c2ce98

Update plug

view details

push time in 2 months

create barnchdotdash/rust

branch : derive_clean

created branch time in 3 months

pull request commentdense-analysis/ale

Balloonify

Hey, thanks for picking this up :+1:

I'd rather have you push it across the finish line than take ownership if that's fine with you.

ian-howell

comment created time in 3 months

Pull request review commentdense-analysis/ale

Balloonify

 function! s:ShowCursorDetailForItem(loc, options) abort      let s:last_detailed_line = line('.')     let l:message = get(a:loc, 'detail', a:loc.text)-    let l:lines = split(l:message, "\n")-    call ale#preview#Show(l:lines, {'stay_here': l:stay_here})++    if g:ale_set_balloons == 1 && has('balloon_eval')

Popups are more general and separate from the balloon feature. The feature check needs to check for textprop instead of balloon_eval.

There should probably also be a separate option, since at least I want popups, but no balloons as I find the mouse hover feature rather irritating.

ian-howell

comment created time in 3 months

push eventdotdash/dotvim

Björn Steinbrink

commit sha b74db24f64410b8d94b3db62b4c8deda6da5e378

Remove phpcomplete

view details

Björn Steinbrink

commit sha 22712445bbfb74890667b0ba3505fcfefe73c8ac

Remove commented out plugins

view details

Björn Steinbrink

commit sha a8b00b7cce394fa9a2cc72d2a516354137feb40f

Install ale

view details

Björn Steinbrink

commit sha d1cf63964b510c7c443f7d6ea178e68380efdb5b

Add intelephense support for ale

view details

Björn Steinbrink

commit sha 328eac1fa15f105530414593ced80760ed35cdd1

Add rust-analyzer support for ale

view details

Björn Steinbrink

commit sha 6284a191a89f998feec18fc9c808b19a819450b3

Limit the PHPPreview mapping to PHP buffers

view details

Björn Steinbrink

commit sha dda027db860e4b48e63e0bce9ed564ad71955a8e

Add mappings for ale for PHP and Rust

view details

Björn Steinbrink

commit sha 954b212201181274199cc1b86f868adf33009120

Update .gitignore

view details

Björn Steinbrink

commit sha d4380f5d4d42500d19d2ef009a8febdb0e779ae6

Remove the unused YouCompleteMe configuration

view details

push time in 3 months

issue openeddense-analysis/ale

Support popup windows for ALEHover and ALEDetail

Using the popup feature you can get a balloon like experience without having to use the mouse.

A proof of concept patch is below, but I'm not experienced enough in either vimscript or ale's code specifically to provide a fully fleshed out PR.

diff --git autoload/ale/cursor.vim autoload/ale/cursor.vim
index 8c331c5..edb99e2 100644
--- autoload/ale/cursor.vim
+++ autoload/ale/cursor.vim
@@ -136,8 +136,7 @@ function! s:ShowCursorDetailForItem(loc, options) abort
 
     let s:last_detailed_line = line('.')
     let l:message = get(a:loc, 'detail', a:loc.text)
-    let l:lines = split(l:message, "\n")
-    call ale#preview#Show(l:lines, {'stay_here': l:stay_here})
+    call ale#util#ShowMessage(l:message)
 
     " Clear the echo message if we manually displayed details.
     if !l:stay_here
diff --git autoload/ale/util.vim autoload/ale/util.vim
index 99cd856..cf46136 100644
--- autoload/ale/util.vim
+++ autoload/ale/util.vim
@@ -21,15 +21,7 @@ function! ale#util#ShowMessage(string) abort
         call ale#preview#CloseIfTypeMatches('ale-preview.message')
     endif
 
-    " We have to assume the user is using a monospace font.
-    if has('nvim') || (a:string !~? "\n" && len(a:string) < &columns)
-        execute 'echo a:string'
-    else
-        call ale#preview#Show(split(a:string, "\n"), {
-        \   'filetype': 'ale-preview.message',
-        \   'stay_here': 1,
-        \})
-    endif
+    call popup_atcursor(split(a:string, "\n"), {'border':[], 'moved': 'any'})
 endfunction
 
 " A wrapper function for execute, so we can test executing some commands.

created time in 3 months

create barnchdotdash/kickerfeld-liga-manager

branch : master

created branch time in 4 months

created repositorydotdash/kickerfeld-liga-manager

created time in 4 months

issue commentrust-lang/rust

Some closures are not inlined in release mode

There was already a bug report at https://bugs.llvm.org/show_bug.cgi?id=26495

I commented there with what I found out so far.

jyn514

comment created time in 6 months

issue commentrust-lang/rust

Some closures are not inlined in release mode

LLVM intentionally discourages inlining for such call sites, see https://github.com/llvm/llvm-project/blob/master/llvm/lib/Analysis/InlineCost.cpp#L782

Though arguably in this case, the bonus for completely eliminating the called function should still be applied, but isn't because it's handled only at the end of that method, thus the early return skips it. Moving the check for allowSizeGrowth to the end gives the expected result, main directly calling process_exit, but that seems suboptimal. I'll try to prepare a testcase and bug report (or patch) for LLVM.

jyn514

comment created time in 6 months

more