To tell you the truth, the first prototype used resolver because I didn't understand how the client works. However, that means I have to refill the IP response back to create a new packet and send back, which is cumbersome. Using client means I only need to forward query and send back the answers, which is kind of more native.

Thanks, I would investigate further to see where exact point is.

Does having multiple AsyncClient help? I suppose if each client has its own queue (background)?

FWIW, this also occurs on nightly from ~4months ago. Wondering if that’s a regression in the compiler, but unsure where to look.

I tested the same code on with Tokio 0.3 on main branch, seems like it is able to enqueue messages, but it has to wait for a long time. Can we change the channel to be unlimited? Or have an option for that

Need to upgrade all crates:

• [x] proto
• [x] rustls - depends on tokio-rustls
• [x] https - dependecies on tokio-rustls, et al. (tests failing, temp impl on git master branch from h2)
• [x] client
• [x] openssl - depends on tokio-openssl
• [x] native-tls - requires move to tokio-native-tls
• [x] resolver
• [x] server
• [x] bin
• [x] util
• [x] tests

Fixes: #1250

blocked on:

• [x] test failure: https_client_stream::tests::test_https_google in trust-dns-https
• [ ] h2 0.3 release with upgrade to Tokio 0.3

Tokio v0.3 have been released: https://tokio.rs/blog/2020-10-tokio-0-3

It appears like this might be possible since 0.18.0 release with the dangerous() configuration to set client/server verification not-based on Web-PKI.

1. It seems non-ideal (and extra dangerous) to make everyone bring their own x.509 parser for these applications.

2. I've looked at x509-signature crate. I would like to see a more complete x.509 representation to work with. It appears like it doesn't fully parse a lot of things.

Just updating this ticket. I will do some playing around with x509-signature and our own x509 library to see which path we end up taking for our application. We might end up contributing a more complete m2m/non-web verifier to the ecosystem.

Hi,

I can't build the server and client on Manjaro Linux.

I have this error:

$ cargo run --verbose --example server ./ ... Compiling quinn v0.6.1 (/home/jona1993/Bureau/quinn/quinn) Running rustc --crate-name quinn --edition=2018 quinn/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -Cembed-bitcode=no -C debuginfo=2 --cfg 'feature="certificate-transparency"' --cfg 'feature="default"' --cfg 'feature="native-certs"' --cfg 'feature="rustls"' --cfg 'feature="tls-rustls"' --cfg 'feature="webpki"' -C metadata=4707029b872475d0 -C extra-filename=-4707029b872475d0 --out-dir /home/jona1993/Bureau/quinn/target/debug/deps -C incremental=/home/jona1993/Bureau/quinn/target/debug/incremental -L dependency=/home/jona1993/Bureau/quinn/target/debug/deps --extern bytes=/home/jona1993/Bureau/quinn/target/debug/deps/libbytes-132544d621c1e922.rmeta --extern futures=/home/jona1993/Bureau/quinn/target/debug/deps/libfutures-ec01a20cd1ba0e55.rmeta --extern libc=/home/jona1993/Bureau/quinn/target/debug/deps/liblibc-89279ce17dbf6aed.rmeta --extern mio=/home/jona1993/Bureau/quinn/target/debug/deps/libmio-7d4e29593d9fecb5.rmeta --extern proto=/home/jona1993/Bureau/quinn/target/debug/deps/libquinn_proto-c77971162d457871.rmeta --extern rustls=/home/jona1993/Bureau/quinn/target/debug/deps/librustls-f460949ff94ada3a.rmeta --extern thiserror=/home/jona1993/Bureau/quinn/target/debug/deps/libthiserror-18430524a81fdaa1.rmeta --extern tokio=/home/jona1993/Bureau/quinn/target/debug/deps/libtokio-96636c1167ea3c00.rmeta --extern tracing=/home/jona1993/Bureau/quinn/target/debug/deps/libtracing-976b01f8ec586a1d.rmeta --extern webpki=/home/jona1993/Bureau/quinn/target/debug/deps/libwebpki-b777aa3e3e5339a3.rmeta -L native=/home/jona1993/Bureau/quinn/target/debug/build/ring-6a6605d43da55d7d/out error[E0596]: cannot borrow self as mutable, as it is not declared as mutable --> quinn/src/connection.rs:259:26 | 258 | fn poll(self: Pin<&mut Self>, cx: &mut Context) -> PollSelf::Output { | ---- help: consider changing this to be mutable: mut self 259 | let conn = &mut *self.0.lock().unwrap(); | ^^^^ cannot borrow as mutable

error[E0596]: cannot borrow self as mutable, as it is not declared as mutable --> quinn/src/endpoint.rs:191:30 | 190 | fn poll(self: Pin<&mut Self>, cx: &mut Context) -> PollSelf::Output { | ---- help: consider changing this to be mutable: mut self 191 | let endpoint = &mut *self.0.lock().unwrap(); | ^^^^ cannot borrow as mutable

error[E0596]: cannot borrow self as mutable, as it is not declared as mutable --> quinn/src/endpoint.rs:441:30 | 440 | fn poll_next(self: Pin<&mut Self>, cx: &mut Context) -> Poll<OptionSelf::Item> { | ---- help: consider changing this to be mutable: mut self 441 | let endpoint = &mut *self.0.lock().unwrap(); | ^^^^ cannot borrow as mutable

error: aborting due to 3 previous errors

For more information about this error, try rustc --explain E0596. error: could not compile quinn.

Caused by: process didn't exit successfully: rustc --crate-name quinn --edition=2018 quinn/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -Cembed-bitcode=no -C debuginfo=2 --cfg 'feature="certificate-transparency"' --cfg 'feature="default"' --cfg 'feature="native-certs"' --cfg 'feature="rustls"' --cfg 'feature="tls-rustls"' --cfg 'feature="webpki"' -C metadata=4707029b872475d0 -C extra-filename=-4707029b872475d0 --out-dir /home/jona1993/Bureau/quinn/target/debug/deps -C incremental=/home/jona1993/Bureau/quinn/target/debug/incremental -L dependency=/home/jona1993/Bureau/quinn/target/debug/deps --extern bytes=/home/jona1993/Bureau/quinn/target/debug/deps/libbytes-132544d621c1e922.rmeta --extern futures=/home/jona1993/Bureau/quinn/target/debug/deps/libfutures-ec01a20cd1ba0e55.rmeta --extern libc=/home/jona1993/Bureau/quinn/target/debug/deps/liblibc-89279ce17dbf6aed.rmeta --extern mio=/home/jona1993/Bureau/quinn/target/debug/deps/libmio-7d4e29593d9fecb5.rmeta --extern proto=/home/jona1993/Bureau/quinn/target/debug/deps/libquinn_proto-c77971162d457871.rmeta --extern rustls=/home/jona1993/Bureau/quinn/target/debug/deps/librustls-f460949ff94ada3a.rmeta --extern thiserror=/home/jona1993/Bureau/quinn/target/debug/deps/libthiserror-18430524a81fdaa1.rmeta --extern tokio=/home/jona1993/Bureau/quinn/target/debug/deps/libtokio-96636c1167ea3c00.rmeta --extern tracing=/home/jona1993/Bureau/quinn/target/debug/deps/libtracing-976b01f8ec586a1d.rmeta --extern webpki=/home/jona1993/Bureau/quinn/target/debug/deps/libwebpki-b777aa3e3e5339a3.rmeta -L native=/home/jona1993/Bureau/quinn/target/debug/build/ring-6a6605d43da55d7d/out (exit code: 1)

Have a nice day !

Oh thank you, it works now.

I used this command before for update rust.

$ rustup update

It's better with the last version ;)

$ cargo --version

cargo 1.45.0 (744bd1fbb 2020-06-15)

Hi,

I can't build the server and client on Manjaro Linux.

I have this error:

$ cargo run --verbose --example server ./ ... Compiling quinn v0.6.1 (/home/jona1993/Bureau/quinn/quinn) Running rustc --crate-name quinn --edition=2018 quinn/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -Cembed-bitcode=no -C debuginfo=2 --cfg 'feature="certificate-transparency"' --cfg 'feature="default"' --cfg 'feature="native-certs"' --cfg 'feature="rustls"' --cfg 'feature="tls-rustls"' --cfg 'feature="webpki"' -C metadata=4707029b872475d0 -C extra-filename=-4707029b872475d0 --out-dir /home/jona1993/Bureau/quinn/target/debug/deps -C incremental=/home/jona1993/Bureau/quinn/target/debug/incremental -L dependency=/home/jona1993/Bureau/quinn/target/debug/deps --extern bytes=/home/jona1993/Bureau/quinn/target/debug/deps/libbytes-132544d621c1e922.rmeta --extern futures=/home/jona1993/Bureau/quinn/target/debug/deps/libfutures-ec01a20cd1ba0e55.rmeta --extern libc=/home/jona1993/Bureau/quinn/target/debug/deps/liblibc-89279ce17dbf6aed.rmeta --extern mio=/home/jona1993/Bureau/quinn/target/debug/deps/libmio-7d4e29593d9fecb5.rmeta --extern proto=/home/jona1993/Bureau/quinn/target/debug/deps/libquinn_proto-c77971162d457871.rmeta --extern rustls=/home/jona1993/Bureau/quinn/target/debug/deps/librustls-f460949ff94ada3a.rmeta --extern thiserror=/home/jona1993/Bureau/quinn/target/debug/deps/libthiserror-18430524a81fdaa1.rmeta --extern tokio=/home/jona1993/Bureau/quinn/target/debug/deps/libtokio-96636c1167ea3c00.rmeta --extern tracing=/home/jona1993/Bureau/quinn/target/debug/deps/libtracing-976b01f8ec586a1d.rmeta --extern webpki=/home/jona1993/Bureau/quinn/target/debug/deps/libwebpki-b777aa3e3e5339a3.rmeta -L native=/home/jona1993/Bureau/quinn/target/debug/build/ring-6a6605d43da55d7d/out error[E0596]: cannot borrow self as mutable, as it is not declared as mutable --> quinn/src/connection.rs:259:26 | 258 | fn poll(self: Pin<&mut Self>, cx: &mut Context) -> PollSelf::Output { | ---- help: consider changing this to be mutable: mut self 259 | let conn = &mut *self.0.lock().unwrap(); | ^^^^ cannot borrow as mutable

error[E0596]: cannot borrow self as mutable, as it is not declared as mutable --> quinn/src/endpoint.rs:191:30 | 190 | fn poll(self: Pin<&mut Self>, cx: &mut Context) -> PollSelf::Output { | ---- help: consider changing this to be mutable: mut self 191 | let endpoint = &mut *self.0.lock().unwrap(); | ^^^^ cannot borrow as mutable

error[E0596]: cannot borrow self as mutable, as it is not declared as mutable --> quinn/src/endpoint.rs:441:30 | 440 | fn poll_next(self: Pin<&mut Self>, cx: &mut Context) -> Poll<OptionSelf::Item> { | ---- help: consider changing this to be mutable: mut self 441 | let endpoint = &mut *self.0.lock().unwrap(); | ^^^^ cannot borrow as mutable

error: aborting due to 3 previous errors

For more information about this error, try rustc --explain E0596. error: could not compile quinn.

Caused by: process didn't exit successfully: rustc --crate-name quinn --edition=2018 quinn/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -Cembed-bitcode=no -C debuginfo=2 --cfg 'feature="certificate-transparency"' --cfg 'feature="default"' --cfg 'feature="native-certs"' --cfg 'feature="rustls"' --cfg 'feature="tls-rustls"' --cfg 'feature="webpki"' -C metadata=4707029b872475d0 -C extra-filename=-4707029b872475d0 --out-dir /home/jona1993/Bureau/quinn/target/debug/deps -C incremental=/home/jona1993/Bureau/quinn/target/debug/incremental -L dependency=/home/jona1993/Bureau/quinn/target/debug/deps --extern bytes=/home/jona1993/Bureau/quinn/target/debug/deps/libbytes-132544d621c1e922.rmeta --extern futures=/home/jona1993/Bureau/quinn/target/debug/deps/libfutures-ec01a20cd1ba0e55.rmeta --extern libc=/home/jona1993/Bureau/quinn/target/debug/deps/liblibc-89279ce17dbf6aed.rmeta --extern mio=/home/jona1993/Bureau/quinn/target/debug/deps/libmio-7d4e29593d9fecb5.rmeta --extern proto=/home/jona1993/Bureau/quinn/target/debug/deps/libquinn_proto-c77971162d457871.rmeta --extern rustls=/home/jona1993/Bureau/quinn/target/debug/deps/librustls-f460949ff94ada3a.rmeta --extern thiserror=/home/jona1993/Bureau/quinn/target/debug/deps/libthiserror-18430524a81fdaa1.rmeta --extern tokio=/home/jona1993/Bureau/quinn/target/debug/deps/libtokio-96636c1167ea3c00.rmeta --extern tracing=/home/jona1993/Bureau/quinn/target/debug/deps/libtracing-976b01f8ec586a1d.rmeta --extern webpki=/home/jona1993/Bureau/quinn/target/debug/deps/libwebpki-b777aa3e3e5339a3.rmeta -L native=/home/jona1993/Bureau/quinn/target/debug/build/ring-6a6605d43da55d7d/out (exit code: 1)

Have a nice day !

There's a problem I'm struggling with. I would like to finish this project because my studies are stacking other projects on my table but at the same time, it takes quite a long time before work is reviewed. @Ralith @djc There are probably a lot of things you spend a lot of time on in daily life and that's understandable. But at the same time, I can't do this task without input and feedback from you. Therefore, if you find it possible, I would like to have more input/involvement in this documentation section so that the work can advance quicker.

OK, I won't notify you about version 0.6.x again, unless you re-open this PR or update to a 0.6.x release yourself.

Bumps bytes from 0.5.6 to 0.6.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tokio-rs/bytes/releases">bytes's releases</a>.</em></p> <blockquote> <h2>v0.6.0</h2> <p>API polish in preparation for a 1.0 release.</p> <h3>Changed</h3> <ul> <li><code>BufMut</code> is now an <code>unsafe</code> trait (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/432">#432</a>).</li> <li><code>BufMut::bytes_mut()</code> returns <code>&mut UninitSlice</code>, a type owned by <code>bytes</code> to avoid undefined behavior (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/433">#433</a>).</li> <li><code>Buf::copy_to_bytes(len)</code> replaces <code>Buf::into_bytes()</code> (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/439">#439</a>).</li> <li><code>Buf</code>/<code>BufMut</code> utility methods are moved onto the trait and <code>*Ext</code> traits are removed (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/431">#431</a>).</li> </ul> <h3>Removed</h3> <ul> <li><code>BufMut::bytes_vectored_mut()</code> (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/430">#430</a>).</li> <li><code>new</code> methods on combinator types (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/434">#434</a>).</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md">bytes's changelog</a>.</em></p> <blockquote> <h1>0.6.0 (October 21, 2020)</h1> <p>API polish in preparation for a 1.0 release.</p> <h3>Changed</h3> <ul> <li><code>BufMut</code> is now an <code>unsafe</code> trait (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/432">#432</a>).</li> <li><code>BufMut::bytes_mut()</code> returns <code>&mut UninitSlice</code>, a type owned by <code>bytes</code> to avoid undefined behavior (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/433">#433</a>).</li> <li><code>Buf::copy_to_bytes(len)</code> replaces <code>Buf::into_bytes()</code> (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/439">#439</a>).</li> <li><code>Buf</code>/<code>BufMut</code> utility methods are moved onto the trait and <code>*Ext</code> traits are removed (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/431">#431</a>).</li> </ul> <h3>Removed</h3> <ul> <li><code>BufMut::bytes_vectored_mut()</code> (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/430">#430</a>).</li> <li><code>new</code> methods on combinator types (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/434">#434</a>).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tokio-rs/bytes/commit/b7f75829ab521663b8906ae5bdfeadf47427d7b5"><code>b7f7582</code></a> prepare v0.6.0 release (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/440">#440</a>)</li> <li><a href="https://github.com/tokio-rs/bytes/commit/39de065a1ed7005b5b7e85fba612bf049a510807"><code>39de065</code></a> Add <code>Buf::copy_to_bytes(len)</code> (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/439">#439</a>)</li> <li><a href="https://github.com/tokio-rs/bytes/commit/5866839e4527784600f1b1d6db27dd4e82c1a536"><code>5866839</code></a> use checked addition with range (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/438">#438</a>)</li> <li><a href="https://github.com/tokio-rs/bytes/commit/e0d8413d53e3774177b040a4f9adda40ec15ce8f"><code>e0d8413</code></a> Switch <code>BufMut::bytes_mut</code> to<code>&mut UninitSlice</code> (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/433">#433</a>)</li> <li><a href="https://github.com/tokio-rs/bytes/commit/5a11c783ecf7c308e7b145f56d5c05e635b99269"><code>5a11c78</code></a> De-emphasize <code>Arc</code> implementation in <code>Bytes</code> description (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/436">#436</a>)</li> <li><a href="https://github.com/tokio-rs/bytes/commit/4724c7e8a0fbb81164f3ca992475181e776867ec"><code>4724c7e</code></a> remove <code>new</code> fns from combinator structs (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/434">#434</a>)</li> <li><a href="https://github.com/tokio-rs/bytes/commit/ced050730c7a5f9d322c0cf9aedea67f16151e90"><code>ced0507</code></a> Make BufMut an unsafe trait (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/432">#432</a>)</li> <li><a href="https://github.com/tokio-rs/bytes/commit/94c543f74b111e894d16faa43e4ad361b97ee87d"><code>94c543f</code></a> remove ext traits (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/431">#431</a>)</li> <li><a href="https://github.com/tokio-rs/bytes/commit/447530b8a6f97fc6864b39d29b24efb4ac9202d3"><code>447530b</code></a> Remove BufMut::bytes_vectored_mut() (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/430">#430</a>)</li> <li><a href="https://github.com/tokio-rs/bytes/commit/422048eb24b4f5bbe5460dfb5d9b05ec7584cee6"><code>422048e</code></a> prepare for 0.6 work (<a href="https://github-redirect.dependabot.com/tokio-rs/bytes/issues/428">#428</a>)</li> <li>See full diff in <a href="https://github.com/tokio-rs/bytes/compare/v0.5.6...v0.6.0">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Pull request limits (per update run and/or open at any time)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

</details>

@dependabot ignore this minor version

Thank you for confirming!

some part of the public API will have to expose the concrete key type that the user chose

No such API currently exists, unless I'm confused about your meaning. The choice of key can be isolated within the type erasure boundary.

Describe the bug Name resolution fails when executing lookup for records of different types.

To Reproduce Lookup records of type TXT and SRV.

Expected behavior Multiple calls to resolver functions Resolver::srv_lookup and Resolver::txt_lookup should successfully resolve a name.

System:

• OS: Manjaro
• Architecture: x64
• Version 20.0.1
• rustc version: 1.45

Version: Crate: trust-dns-resolver Version: 0.19.5

Additional context Downgrading to version 0.18.1 works well.

thread 'resolver::test::test' panicked at 'called `Result::unwrap()` on an `Err` value: ResolveError { kind: NoRecordsFound { query: Query { name: Name { is_fqdn: false, labels: [mongo-shd] }, query_type: SRV, query_class: IN }, valid_until: Some(Instant { tv_sec: 118525, tv_nsec: 559938142 }) }, backtrack: None }', core/src/resolver.rs:74:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Hey @bluejekyll I've wrote a small test just to check and give you feedback and seems to work perfect! Thank you again!

I can't @bluejekyll, have no access to related source anymore, sorry :(

ok, all deps for rustls updated.

@djc what do you think of me merging this to main even though it's not yet releasable, due to the h2 dependency?

OK, I won't notify you about version 0.21.x again, unless you re-open this PR or update to a 0.21.x release yourself.