divyenduz ( Divyendu Singh )

issue openedprisma/prisma-examples

Make workflow names better

Test matrix was implemented in https://github.com/prisma/prisma-examples/pull/2180

However, job names are "path-like" and not easily readable. This issue tracks fixing them.

created time in 6 minutes

issue closedprisma/prisma-examples

Tests should report failure if 1 of the tests fails

Right now Actions reports the tests are succeeding, although they are clearly failing:

https://github.com/prisma/prisma-examples/issues/1652 https://github.com/prisma/prisma-examples/issues/1651

That is dangerous, as one does not really see when stuff goes wrong.

Fundamentally there are 2 problems:

All tests are run in one batch, a suggestion to change that is at https://github.com/prisma/prisma-examples/issues/1653
Even when one of the tests clearly fails, the test run still reports a success as a whole.

If one of the tests fails, the run should report a failure as a whole.

closed time in 8 minutes

janpio

issue closedprisma/prisma-examples

Make it easier to read test output

Right now it is one long file with output. It would be nice if there was some visual separation (some empty lines and ######################## or something) to make it easier to visually parse. Also some clear output if a "test" (run.sh for 1 folder) succeeded or failed. Test runners do that for a reason ;)

closed time in 8 minutes

janpio

issue closedprisma/prisma-examples

Change the way tests are run

Right now there is only 1 test, that loops through all folders. That is practical, because it makes sure that all examples (= folders) have the proper test configuration that then is run during the test - no one can add a test without it also being tested.

Unfortunately that leads to super busy log output and makes it hard to understand what is going on.

An alternative suggestion: The test starts with a script that tests if for all folders there is a Github Actions workflow/job that triggers the .sh file that currently would be triggered via looping through the folders. That way, the whole test run can still be failed if an example is missing.

closed time in 8 minutes

janpio

issue closedprisma/prisma-examples

Error: listen EADDRINUSE: address already in use :::4000

+++++++++++
executing .github/tests/./typescript/subscriptions-pubsub/run.sh (tests)
yarn run v1.22.5
$ npm run generate:prisma
npm WARN lifecycle The node binary used for scripts is /tmp/yarn--1603911179469-0.4817221266893308/node but npm is using /opt/hostedtoolcache/node/12.19.0/x64/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.

> subscriptions-pubsub@ generate:prisma /home/runner/work/prisma-examples/prisma-examples/typescript/subscriptions-pubsub
> prisma generate

Prisma schema loaded from prisma/schema.prisma

✔ Generated Prisma Client (version: 2.10.0) to ./node_modules/@prisma/client in 65ms

You can now start using Prisma Client in your code:

```
import { PrismaClient } from '@prisma/client'
// or const { PrismaClient } = require('@prisma/client')

const prisma = new PrismaClient()
```

Explore the full API: http://pris.ly/d/client
$ cross-env NODE_ENV=development tsnd --no-notify --respawn --transpileOnly ./src
Using ts-node version 8.10.2, typescript version 4.0.5
Error: listen EADDRINUSE: address already in use :::4000
    at Server.setupListenHandle [as _listen2] (net.js:1317:16)
    at listenInCluster (net.js:1365:12)
    at Server.listen (net.js:1451:7)
    at /home/runner/work/prisma-examples/prisma-examples/typescript/subscriptions-pubsub/node_modules/apollo-server/src/index.ts:127:18
    at new Promise (<anonymous>)
    at ApolloServer.<anonymous> (/home/runner/work/prisma-examples/prisma-examples/typescript/subscriptions-pubsub/node_modules/apollo-server/src/index.ts:122:11)
    at Generator.next (<anonymous>)
    at /home/runner/work/prisma-examples/prisma-examples/typescript/subscriptions-pubsub/node_modules/apollo-server/dist/index.js:18:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/prisma-examples/prisma-examples/typescript/subscriptions-pubsub/node_modules/apollo-server/dist/index.js:14:12)

closed time in 9 minutes

janpio

push eventprisma/prisma-examples

Divyendu Singh

commit sha a96db3ad8e4bb295f9febc81d83a1b0be6c4dc62

feat(matrix): test matrix

Bug description

How to reproduce

Expected behavior

Bug description

How to reproduce

Expected behavior