davidjamesstone ( David Stone )

commit sha a44479d62106be89f7473110228c82ff8d9725f0

Add contact type and info fields to message table

push time in 6 days

push eventStaff-Alerts/sa-db

commit sha b3df84a7f173f3ce4db5e0e17f1f3782b49cf5e7

Add send message tables

Auto-create user in message web

push time in 6 days

issue openedStaff-Alerts/project

When a user (with a role) logs in to the app, we need to ensure a user with their AD user Id exists in the SA database. This will ensure they can use the app even in the event they haven't been imported as a user by the ETL.

created time in 7 days

issue commentStaff-Alerts/project

Define user roles for Azure acces to messages-web

I'm not sure . Currently approving a message will immediately send it. There's no process or pages to send a message.

simonneb

comment created time in 7 days

startedOrKoN/pg-queue

started time in 11 days

push eventStaff-Alerts/sa-db

commit sha 02128399b18b0a33ca83b5d392bd82c256603e00

Id changes

Create "message web" repository and initial code

push time in 13 days

issue openedStaff-Alerts/project

What: Create the repository and initial code for the website that staff will use to send staff alerts

Why: So we have a place to work on the code

This will be called sa-message-web

created time in 21 days

issue commentstandard/standard

Remove `eqeqeq` opt-in for nulls

That's actually really quite useful and a good argument to keep it as-is. 👍

davidjamesstone

comment created time in 24 days

delete branch DEFRA/hapi-web-boilerplate

delete branch : update-logging

delete time in 24 days

push eventDEFRA/hapi-web-boilerplate

commit sha cfcdbbdf0fafe70d45229f81600fa53f9980d5ae

Update deps and logging to hapi-pino (#69) * Update deps and logging to hapi-pino * isDev config property * Node 12 * Global css styles flag * Update njk paths to match design system * Update dependencies * Pinned hapi-pino

push time in 24 days

PR merged DEFRA/hapi-web-boilerplate

Update deps and logging to hapi-pino

+2156 -3037

7 commit in DEFRA/hapi-web-boilerplate/tree/update-logging DEFRA/hapi-web-boilerplate/tree/master

0 comment

9 changed files

davidjamesstone

pr closed time in 24 days

push eventDEFRA/hapi-api-boilerplate

commit sha 5be51ef563eb1ec20642ab1062ed27d2853189b5

Update deps and logging (#51) * Update deps and logging * Node 12 * Update dependencies * Pinned hapi-pino

push time in 24 days

delete branch Staff-Alerts/sa-db

delete branch : simon

delete time in a month

push eventStaff-Alerts/sa-db

Simon Nebesnuick

commit sha dea2c7029c001023c786d3f5bb151817ef9df4eb

simons changes

commit sha c21bc6fd611384df2449ca7ce5274fad36a23fa7

added contact and group type changes

commit sha 89610534582ef128783d94ef2c0f302e7890eddd

Minor fixes to get running

commit sha b5d218276689f501b7c44fabef6364e405ea0cc1

Change manager IDP id column name

commit sha 94e616f6bcd51373a062addb351677d476f92647

Rename schema to staff_alerts

commit sha d18a80621bdb8bff00f56c5fc801d47f33f6007c

slight typo change

commit sha d22ce641f5cc5905d3efcc3e84d84bb5c48546c5

added "last_matched_at" field to user table

commit sha be57ac572575f8b4ed91e2d288ccc0dfdd0c577a

add abs. removed "Not null" to code in "groups"

commit sha c8ba3f9b168de7dd04ad493b55549f0d91583ec6

PK updates

commit sha 145dfe1c2a71403cc87bc7cf8f6d628224f5f530

Merge branch 'simon' of https://github.com/Staff-Alerts/sa-db into simon

commit sha c4b0e25ffa2b9f1cb877be71bc5b20ab2c6dd9b5

Group type casing

commit sha 758f6d738e1a97c97037c207a81b6faed03c053c

Merge pull request #1 from Staff-Alerts/simon Initial DB designs

push time in a month

PR merged Staff-Alerts/sa-db

Initial DB designs

+88 -36

11 commit in Staff-Alerts/sa-db/tree/simon Staff-Alerts/sa-db/tree/master

0 comment

2 changed files

davidjamesstone

pr closed time in a month

PR opened Staff-Alerts/sa-db

Initial DB designs

+88 -36

11 commit in Staff-Alerts/sa-db/tree/simon Staff-Alerts/sa-db/tree/master

0 comment

2 changed files

pr created time in a month

push eventStaff-Alerts/sa-db

commit sha c4b0e25ffa2b9f1cb877be71bc5b20ab2c6dd9b5

Group type casing

push time in a month

push eventStaff-Alerts/sa-db

commit sha c8ba3f9b168de7dd04ad493b55549f0d91583ec6

PK updates

commit sha 145dfe1c2a71403cc87bc7cf8f6d628224f5f530

Merge branch 'simon' of https://github.com/Staff-Alerts/sa-db into simon

Remove `eqeqeq` opt-in for nulls

push time in a month

issue openedstandard/standard

What version of this package are you using? 14.3.4

What problem do you want to solve? eqeqeq enforced for nulls

What do you think is the correct solution to this problem? Setting the second arg to eqeqeq to "null": "always" (or removing the setting altogether as this is the default)

Are you willing to submit a pull request to implement this change? Yes

I was surprised to see:

if (foo == null)

Is valid in standardjs.

I can't find any background on this so I thought I'd ask why standardjs opts-in to more specific handling of null in eslint eqeqeq. I don't often come across this kind of explicit equality check but I noticed it on a code review I was doing and it jumped out at me. Personally, I'd like to enforce triple equals always for consistency. Is there a strong reason for having this exception?

created time in a month

push eventStaff-Alerts/sa-db

commit sha 94e616f6bcd51373a062addb351677d476f92647

Rename schema to staff_alerts

push time in a month

push eventStaff-Alerts/sa-db

commit sha b5d218276689f501b7c44fabef6364e405ea0cc1

Change manager IDP id column name

push time in a month

push eventStaff-Alerts/sa-db

commit sha 89610534582ef128783d94ef2c0f302e7890eddd

Minor fixes to get running

Investigate GOV.UK Platform-as-a-service as an option for hosting

push time in a month

create barnchStaff-Alerts/sa-db

branch : master

created branch time in a month

created repositoryStaff-Alerts/sa-db

Staff alerts DB

created time in a month

issue openedStaff-Alerts/project

What: Investigate GOV.UK Platform-as-a-service as an option for hosting as an alternative to traditional DDTS model

Why: We need to understand if it is suitable for our needs, whether we can or should opt for it and what the on-going application support model would look like if we did use it

created time in a month

commit sha 84eef6be4a10e8e40607c54bb470bd89748edbe9

Update dependencies

push time in a month

push eventNear-LifeTM/aframe-immersive-video

commit sha c8b902c410e13c6b8caf1484e4f3c18df414d703

Fix AFRAME.version check

push time in a month

PR opened oscarmarinmiro/aframe-immersive-video

Fix AFRAME.version check

+289484 -3

1 commit in Near-LifeTM/aframe-immersive-video/tree/master oscarmarinmiro/aframe-immersive-video/tree/master

0 comment

2445 changed files

pr created time in a month

push eventNear-LifeTM/aframe-immersive-video

commit sha 63586ccab23a678de7f8dfb369f002d90d057a2b

Fix AFRAME.version check

Create "contact web" repository and initial code

push time in a month

issue openedStaff-Alerts/project

What: Create the repository and initial code for the website that staff will use to manage their staff alerts

Why: So we have a place to work on the code

In XWS this is called xws-contact-web. Are we happy with the names sa-contact-web (and sa-message-web`)?

created time in a month

issue commentStaff-Alerts/project

Create high-level UI wireframe design

Looks nice and simple.

For the external contact maintenance:

Is the "Add new contact" verified with a OTP or against Active Directory?
On "Add new alert", would that present all target groups or just a subset?

simonneb

comment created time in a month

startedmrdoob/three.js

started time in a month

startedoscarmarinmiro/aframe-immersive-video

started time in a month

delete branch davidjamesstone/project

delete branch : patch-1

delete time in a month

PR opened Staff-Alerts/project

Create development.md

+29 -0

1 commit in davidjamesstone/project/tree/patch-2 Staff-Alerts/project/tree/master

0 comment

1 changed file

pr created time in a month

push eventdavidjamesstone/project

commit sha 2a97342d63a4bc630817ff304f2a9e7e86a2e4b4

Create development.md

push time in a month

push eventdavidjamesstone/project

commit sha 48489820c681efe013ed10b9a94d07fa7997df5b

Create development.md

Discussions with web ops around build environments, hosting and support.

push time in a month

fork davidjamesstone/project

All project information related to the Staff Alerts project.

Staff-Alerts/project davidjamesstone/project

fork in a month

issue openedStaff-Alerts/project

What: Engage with AWS WebOps to begin conversations around the environments required for building and hosting. Depending on how we authenticate users, we may also need to contact Cloud Service Center (Ishmal Marks) to set up an AD Authentication Security Group

Why: So we have a place to publish the applications and services for testing and production. To enable users to login to the application using their AD username and password

created time in a month

push eventDEFRA/hapi-web-boilerplate

commit sha d6dab2385a4d3e3081a1f7bad6e36c28a83b7941

Pinned hapi-pino

push time in a month

push eventDEFRA/hapi-api-boilerplate

commit sha ca21f89a98a6c53f3d5357c565ab83402137f963

Pinned hapi-pino

push time in a month

push eventDEFRA/hapi-api-boilerplate

commit sha ca6984e9b33effe261b261184f1645a274f83411

Update dependencies

commit sha e659f62ccd77c82bcfbc04860d378128c123d9c7

Merge branch 'update-logging' of https://github.com/DEFRA/hapi-api-boilerplate into update-logging

push time in a month

push eventDEFRA/hapi-web-boilerplate

commit sha 5a6342feb0e84efbdbfe1ee3b09632f1b14da29c

Update dependencies

Fix/update chromedriver v85

push time in a month

startedloris/api-query-params

started time in 2 months

pull request commentDEFRA/ltfri-tests

Thanks for handling this, @ccapperEA

ccapperEA

comment created time in 2 months

PullRequestReviewEvent

push eventNeXt-Warning-System/xws-message-web

commit sha 0acc3eacdc24d6cf646aec52a1e7220dcbbeab96

Create message journey

push time in 2 months

commit sha e7f081b12a5d6899f93fb83f63d3a1b8205e2d89

Fix remove issue

push time in 2 months

commit sha 8fefbc1b0e3e2bd8ccfb32a15c663ce0cd7dd18a

Responsive buttons

push time in 2 months

Mark contact with no locations as cancelled

I think there's more to discuss on this issue.

What is the need to inform the user that this account will be archived/cancelled?
If they remove their last location, should they be logged out (because their contact will no longer be active)

Personally, I don't think any of this is really necessary. It introduces complexity for the user. E.g. I only have one location but I want to change it to another. I can't - I have to add a 2nd then remove the unwanted one.

This allows for the same contact to be reused in the future without tieing it to the history of the previous user.

There's no guarantee that the previous and new user isn't the same person. There's really no notion of "users" - only a claim of someone owning a contact (email or phone) and having the means to verify it with a code.

Currently, if someone sells their phone or the mobile operators decide to reuse an old number that we have a record of, then the new owner is currently able to manage their notifications without the need to introduce a notion of historical contacts.

simonneb

comment created time in 2 months

Mark contact with no locations as cancelled

The decision on how we best manage this needs to account for the best indexing/constraint strategy to be applied to the tables. For example, currently the contact table has a unique index applied to the addressOrNumber field. Introducing a new cancelled flag and allowing multiple contacts to have the same addressOrNumber will means we need different index strategy (something like a composite index over both the addressOrNumber fields and the cancelled boolean in addition to a trigger to ensure only one row can be the real "active" one. Same for for TA's.

Sometimes keeping the indexes simple and introducing archive tables and moving expired data into them is a better approach. I have a couple of strategies in mind (and working for the Message table) but, for User Testing, it's not a priority at the moment and I'd like to be consistent in all areas where temporal data is needed.

https://clarkdave.net/2015/02/historical-records-with-postgresql-and-temporal-tables-and-sql-2011/ https://github.com/nearform/temporal_tables https://www.nearform.com/blog/time-travel-with-postgresql-on-amazon-rds/

simonneb

comment created time in 2 months

Mark contact with no locations as cancelled

Thinking about this. I think it's best for now to just do the UI to message the user that the account/contact will be cancelled (although, I'm not even sure that is necessary?).

The technicalities of how we manage "cancelled" contact might be done better (e.g. with archive tables or temporal tables). This is something we're looking at for other resources that have a lifecycle e.g. Target Areas and Warnings. They too also need flags for things like Active, De-active or InForce and Expired. I'd like a consistent approach across all resources. Flags might be the way but I'd rather look at it holistically.

simonneb

comment created time in 2 months

issue closedNeXt-Warning-System/xws-contact-web

Add "edit" contact button to account homepage

Alongside a remove button, add an edit button next to each location associated with the contact on the account page.

Once clicked this opens a new edit page for that location. The user can:

change the optional messages associated with that location. If location can only receive flood alert messages, do NOT allow the user to untick the box and instead offer to remove that location for their account
remove the location entirely
if a mobile number, they can select if they want the call via telephone or via text.

Image of screen

closed time in 2 months

simonneb

Add "edit" contact button to account homepage

Edit location now complete. Will deploy on 28/07/20.

simonneb

comment created time in 2 months

commit sha e9a637d36895313c800eada7882dcc0c38e0d113

Edit contact location

push time in 2 months

commit sha 746b4a159d9ffc60aa83c78516eea6d820e804da

England only

push time in 2 months

If location in Wales or Scotland searched for, show England only page

I have done this for place name searches as OS return a country field which we can use to filter on. For postcode searches they don't return this field so it's not so straight forward.

There are (at least) 5 options:

Download and maintain a copy of OS custodian codes. The custodian code is returned for postcode searches and can be used to determine country. It changes regularly and would need to be kept up to date. This approach was used in LTFRI but has now been removed.
Determine whether a returned address is in England using a spatial query. This requires us to hold and maintain an outline polygon of England and assess if returned addresses fall within the area. This method is currently employed in FWIS where we already had the England outline polygon. Seems overkill to go down this path unless we need that polygon for other reasons. It's also computationally expensive.
Change the address provider from OS to someone else. This has been muted in the past but I think there's a contractual obligation for EA to use OS.
Do nothing. If users search for an postcode that is in Wales or Scotland then allow them to proceed. They will not be able to sign up for warnings as there are no TAs so they'll get to the page where the message is something like "We don't provide warning service here - try somewhere else"
Maintain a lookup of postcode to country and use this to filter. Similar to the custodian code approach.

I'll keep this issue open for the time being.

It's worth noting that this issue only effects Wales and Scotland. The OS address API doesn't actually support Northern Ireland addresses but we can handle NI users because all postcodes there start with "BT" so it's easy to detect and route the user to the correct service.

simonneb

comment created time in 2 months

commit sha d233fca6f04c32ba7255640eaaba586beb923312

Replace OS with OSM

push time in 2 months

issue closedNeXt-Warning-System/xws-contact-web

Show map backgrounds

OS map background are not currently showing. We need this to work so users can get a good view on the areas they are signing up for.

closed time in 2 months

simonneb

Add HTTPS encryption to website

Show map backgrounds

Domains other than 'localhost' need to be registered with Ordnance Survey to allow use of their background maps. I have temporarily replaced OS with OSM to get around this during testing.

simonneb

comment created time in 2 months

issue closedNeXt-Warning-System/xws-contact-web

The AWS Elastic Beanstalk instance we are using does not have HTTPS enabled - this should be enabled before we test with real users.

closed time in 2 months

simonneb