profile
viewpoint
Alberto Leal dashed @getsentry (Sentry.io) Toronto, Canada https://albertoleal.ca 🇨🇦 he/him/his

dashed/albertoleal 5

✨ npx albertoleal

dashed/detour-stream 5

Use boolean expressions/functions to conditionally attach a stream as a detour or an alternative destination stream.

dashed/advent-of-code 4

🎄 https://adventofcode.com

dashed/async-queue-stream 3

Node.js through streams using async.queue under the hood.

dashed/dayofweek 1

Port of dayofweek function given by Tomohiko Sakamoto on the comp.lang.c Usenet newsgroup in 1993.

dashed/6to5 0

Turn ES6+ code into readable vanilla ES5 with source maps and more!

dashed/Adafruit_Python_CharLCD 0

Python library for accessing Adafruit character LCDs from a Raspberry Pi or BeagleBone Black.

dashed/atom-pandoc-preview 0

Pandoc-powered Previewer for Atom

dashed/awesome-advent-of-code 0

A collection of awesome resources related to the yearly Advent of Code challenge.

startedDetegr/rust-ctrlc

started time in 5 hours

startedJ-F-Liu/pom

started time in 5 hours

PR opened getsentry/sentry

feat(web-vitals): Add web vitals Discover pre-canned query

This pre-canned query will only be shown to orgs that have the measurements feature flag.

Screen Shot 2020-10-28 at 4 19 50 PM Screen Shot 2020-10-28 at 4 23 52 PM

+28 -5

0 comment

2 changed files

pr created time in 15 hours

create barnchgetsentry/sentry

branch : web-vitals-discover-query

created branch time in 15 hours

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentgetsentry/sentry-javascript

feat(web-vitals): Capture extra information from LCP and CLS web vitals.

I'm going to hold off merging this as there might be changes I'd like to put in.

dashed

comment created time in 21 hours

PullRequestReviewEvent

startedstanford-futuredata/ASAP

started time in a day

Pull request review commentgetsentry/sentry

feat(trends): Add smoothing to trends

 function transformEventStats(data: EventsStatsData, seriesName?: string): Series   ]; } -function transformEventStatsSmoothed(data: Series[], seriesName?: string): Series[] {+function transformEventStatsSmoothed(data: Series[], seriesName?: string) {+  let minValue = Number.MAX_SAFE_INTEGER;+  let maxValue = 0;   const currentData = data[0].data;   const resultData: SeriesDataUnit[] = [];-  resultData.push(currentData[0]);--  // Start at 1 so we don't get NaN from the movingAverage-  for (let i = 1; i < currentData.length; i++) {-    let value;-    if (i < AVERAGE_WINDOW) {-      // A rougher movingAverage for these points, but this way there isn't a gap-      value = movingAverage(currentData, i, i);-    } else {-      value = movingAverage(currentData, i, AVERAGE_WINDOW);-    }++  const smoothed = smoothTrend(currentData.map(({name, value}) => [Number(name), value]));

@k-fish Since the resolution is default to 100 for the ASAP function, smoothed will always be at most 100 data points. Was this intentional?

It looks like the trends chart can display more than 100 data points.

k-fish

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgetsentry/sentry

fix(tests): Decrease accuracy of mark.xxx measurements

 def load_data(             for key, entry in measurements.items():                 if key in ["fp", "fcp", "lcp", "fid"]:                     measurement_markers["mark.{}".format(key)] = {-                        "value": data["start_timestamp"] + entry["value"] / 1000+                        "value": round(data["start_timestamp"] + entry["value"] / 1000)

We need to preserve the fractional component.

                        "value": round(data["start_timestamp"] + entry["value"] / 1000, 3)
Zylphrex

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

PR opened getsentry/sentry-javascript

Reviewers
feat(web-vitals): Capture extra information from LCP and CLS web vitals.

Be able to capture extra information from LCP and CLS web vitals.

For LCP, we'd like to know the element (or image) that contributed the largest contentful paint:

  • https://wicg.github.io/largest-contentful-paint/#sec-largest-contentful-paint-interface
  • https://developer.mozilla.org/en-US/docs/Web/API/LargestContentfulPaint#Properties

For CLS, we'd like to know the top 5 DOM nodes contributing the the CLS scores:

  • https://wicg.github.io/layout-instability/#layoutshiftattribution
  • https://wicg.github.io/layout-instability/#source-attribution

These will be surfaced in the product to indicate source of poor LCP or CLS scores.

Screen Shot 2020-10-27 at 4 14 07 PM

+48 -6

0 comment

3 changed files

pr created time in 2 days

create barnchgetsentry/sentry-javascript

branch : lcp-cls-attribution

created branch time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentgetsentry/sentry

byk/fix/py3 tests

@BYK thanks! The other typo should be addressed in https://github.com/getsentry/sentry/pull/21617

BYK

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventgetsentry/sentry

Alberto Leal

commit sha 0af8de25412e16ef14df1e54cccf5924aae0c936

feat(web-vitals): Add vertical line markers for web vitals on span view (#21336)

view details

push time in 2 days

delete branch getsentry/sentry

delete branch : measurement-vertical-line-markers

delete time in 2 days

push eventgetsentry/sentry

Alberto Leal

commit sha 32933efb11300440afd1621063361446145f17be

feat(vitals): Support measurements in metric alerts (#21498) Co-authored-by: Dan Fuller <dfuller@sentry.io>

view details

push time in 2 days

delete branch getsentry/sentry

delete branch : metric-alerts-measurements

delete time in 2 days

PR merged getsentry/sentry

Reviewers
feat(vitals): Support measurements in metric alerts

Expose web vitals as options in metric alerts.

Depends on https://github.com/getsentry/sentry/pull/21566

TODO

  • [x] add test for measurement name validation
+31 -9

2 comments

4 changed files

dashed

pr closed time in 2 days

startedsindresorhus/css-in-readme-like-wat

started time in 2 days

push eventgetsentry/sentry

Alberto Leal

commit sha 132699fb502be94152d273a34d0ce60cc85d7f2e

fix

view details

push time in 2 days

push eventgetsentry/sentry

Mark Story

commit sha 62902c60a001890bb22b3a15661080b7503d07ac

feat(projects) Add transaction to projects overview (#21577) When organizations have performance-view then we should fetch the transaction stats and render them alongside errors. The charts have been changed to a log scale to help reduce the impact of transactions dwarfing errors by huge margins. The log scale will also be applied when there are only errors to be consistent and have less product complexity.

view details

Tony

commit sha 723d2b4879f6d1ab4b36200beead64cf34e3cd71

feat(discover): Restrict access to measurement specific functions (#21542) Measurement specific functions were made for use with only measurements and should not be exposed via other means. This change restricts access to these functions by requiring access to these functions to be explicitly declared.

view details

Tony

commit sha dc160098e5abc1b35acb45850b3b0de1817aaceb

feat(vitals): Add beta badge to vitals (#21596) The web vitals is now available to early adopters. Add a beta badge and alert for better discoverability.

view details

Saif Hakim

commit sha 035f6209e3b417d6cc5e9f7043d8d713c133cdf1

fix(jira): Fix submitting forms for Jira plugin (legacy integration) (#21584) This fixes a regression introduced in #15766 which referenced a non-existent `this.state.data` when it should have remained `this.state.formData`. Fixes #21463 ------ ### Investigation Breakpoint before the save happens shows that state.data is undefined, while state.formData is the expected vaue. ![image](https://user-images.githubusercontent.com/549473/97114794-e3b04500-16af-11eb-9645-3a8e778b2dfb.png) Tracing the change reveals that it looks like an accidental change: https://github.com/getsentry/sentry/pull/15766/files#diff-1ef5b383a036417bfcea5af934b4a3926017f0188f419ca6b58b506e8cacd778L72-L80 ![image](https://user-images.githubusercontent.com/549473/97114705-45bc7a80-16af-11eb-9926-46ca77bb0aae.png) ## Manual regression test: ### Before 💥 ![image](https://user-images.githubusercontent.com/549473/97114726-7a303680-16af-11eb-8ec6-74c572db07cc.png) ### After 💚 ![image](https://user-images.githubusercontent.com/549473/97114625-dd6d9900-16ae-11eb-9d21-d31993d623b4.png)

view details

Burak Yigit Kaya

commit sha 95b13c3e91f3c28661cb4b6b75455ee268b9dae2

ref(deletion): Set MAX_RETRIES to 5 for all env (#21601) Follow up to #21581. Also removes the now incorrect comment.

view details

David Wang

commit sha b3b0d10db0ae281e4e274f9f77cb825c8dabb500

feat(alert): Metric alert GUI filters feature flag (#21548) * adding feature flag for gui filters and duplicated conditions form * oops properly destructure * use optional chaining

view details

Alberto Leal

commit sha c05bfcff614e54ddaa7282603be2d72ac83846d3

feat(web-vitals): Add vertical line markers for web vitals on span view

view details

Alberto Leal

commit sha 8f273bd48e3a4302b576e7e0b96b01ae3f271257

remove onMouseEnter

view details

Alberto Leal

commit sha 6065a5ea481973fedcb3ea27184f9a26d2ef576b

add tooltips

view details

Alberto Leal

commit sha 76d06780c83dbcfe7dc8e506dae5d1b4bed5f10e

add measurements feature to performance acceptance tests

view details

Alberto Leal

commit sha 7bfb7abcbac1f3b52de1f48e3f56db7a52d90588

add measurement markers in sample acceptance transaction data

view details

Alberto Leal

commit sha a3f9dd15fc89dbf22974cd713b7e510f76f2038d

adjust spans on transaction comparison view

view details

push time in 3 days

issue commentgetsentry/sentry-rust

`tracing` integration

@kellpossible were you able to generate any useful spans/traces?

khionu

comment created time in 3 days

push eventgetsentry/sentry

Alberto Leal

commit sha 87293552d6768a78831833bb7b8973a8469dfd0d

add measurement markers in sample acceptance transaction data

view details

push time in 3 days

push eventgetsentry/sentry

Alberto Leal

commit sha b0da0b55b955fb4c10484456ca866cd703952e63

add measurements feature to performance acceptance tests

view details

push time in 3 days

Pull request review commentgetsentry/sentry

feat(web-vitals): Add vertical line markers for web vitals on span view

 export function isEventFromBrowserJavaScriptSDK(event: SentryTransactionEvent): // PerformanceMark: Duration is 0 as per https://developer.mozilla.org/en-US/docs/Web/API/PerformanceMark // PerformancePaintTiming: Duration is 0 as per https://developer.mozilla.org/en-US/docs/Web/API/PerformancePaintTiming export const durationlessBrowserOps = ['mark', 'paint'];++export function getMeasurements(event: SentryTransactionEvent): Map<number, string[]> {+  if (!event.measurements) {+    return new Map();+  }++  const measurements = Object.keys(event.measurements)+    .filter(name => name.startsWith('mark.'))

These are added by the SDK.

The convention is that measurements that begin with mark. are assumed to be timestamps for the occurrence of the measurement within the span view.

dashed

comment created time in 3 days

PullRequestReviewEvent

push eventgetsentry/sentry

Mark Story

commit sha 9e27273ea25457c93325e05c2e8ba34ac72c7ed8

ref(ts) Convert Organization stats to typescript (#21569) Get the TS conversion done so that I can replace the chart.

view details

Mark Story

commit sha 7526d8fba87cb1a62b7c3579546bff56a6968f43

ref(ui) Update release health sparklines to echarts (#21560) Use MiniBarChart to render release health sparkline charts.

view details

Stephen Cefali

commit sha 4098f058c891b7af48dbfdcc613c40a7bc03b1c2

handle camel case nonFieldErrors (#21578)

view details

Chris Fuller

commit sha 49f3ded562b2b73eb573a9fba218b9c9117c6bb5

feat(workflow): Add GroupInbox support to post_process_group (#21440)

view details

Stephen Cefali

commit sha d3b8d953a52ba5cf1e741e957fc8dd06cfd176c8

feat(ui): adds Sentry project selector field (#21571)

view details

Saif Hakim

commit sha ad9321fe94740087f7f7589ac8875225a20e7010

fix(integrations): Merge project_issue_defaults updates instead of overwrite (#21580) When an external issue is either created or linked, `store_issue_last_defaults` is called to persist the subset of field values that are configured for that integration via `get_persisted_default_config_fields` for the next issue created or linked. In common scenarios, "create" has a complete list of defaults to persist while "link" has an empty list, as only the existing issue id needs to be specified. This is problematic in the old implementation, as linking an issue would unset all default values captured via the "create" flow. Additionally, the old implementation would effectively unset defaults for any other projects. The new implementation avoids both of these issues by merging updates into both levels of the config object's "project_issue_defaults". Fixes #15720 ---- ## Test Plan - I've added regression tests for both problematic scenarios - I've tested both cases manually via the UI. To illustrate the issue, I've recorded a GIF that demonstrates the first problematic behavior: ![old-behavior](https://user-images.githubusercontent.com/549473/97099713-59cd9100-1649-11eb-8c5f-50d1342974d7.gif) With the fix applied, we see that the previous default values are preserved: ![new-behavior](https://user-images.githubusercontent.com/549473/97099884-30ae0000-164b-11eb-9342-61e562266a14.gif)

view details

William Mak

commit sha 0b187508cb4db6c02c4ded0505f84edbac8d48e2

ref(trends): Remove medium confidence as an option (#21574) - High confidence should be a good default, and users shouldn't need to click through a few options to see other transactions

view details

Abhishek Kumar Singh

commit sha aac83885d964154786fb46df740f871ec3da781e

fix(deletion): set MAX_RETRIES=5 for prod (#21581) Fixes #19721.

view details

Alberto Leal

commit sha 3b36fad15cdfc6337d2c62c8c8ea2fc6d7e3e6a2

feat(web-vitals): Add vertical line markers for web vitals on span view

view details

Alberto Leal

commit sha ce7c5180013d94fe51ce155f25225e5d77b209a2

remove onMouseEnter

view details

Alberto Leal

commit sha 0b9d8f130d0b982d0f3c1f8f918ebc04e215da74

add tooltips

view details

push time in 3 days

Pull request review commentgetsentry/sentry-python

feat(dev): Add object matcher pytest fixture

+import pytest+++@pytest.mark.parametrize(+    "test_string, expected_result",+    [+        # type matches+        ("dogs are great!", True),  # full containment - beginning+        ("go, dogs, go!", True),  # full containment - middle+        ("I like dogs", True),  # full containment - end+        ("dogs", True),  # equality+        ("", False),  # reverse containment+        ("dog", False),  # reverse conainment+        ("good dog!", False),  # partial overlap+        ("cats", False),  # no overlap+        # type mismatches+        (1231, False),+        (11.21, False),+        ([], False),+        ({}, False),+        (True, False),+    ],+)+def test_string_containing(+    test_string, expected_result, StringContaining  # noqa: N803+):++    assert (test_string == StringContaining("dogs")) is expected_result+++@pytest.mark.parametrize(+    "test_dict, expected_result",+    [+        # type matches+        ({"dogs": "yes", "cats": "maybe", "spiders": "nope"}, True),  # full containment+        ({"dogs": "yes", "cats": "maybe"}, True),  # equality+        ({}, False),  # reverse containment+        ({"dogs": "yes"}, False),  # reverse conainment
        ({"dogs": "yes"}, False),  # reverse containment
lobsterkatie

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentgetsentry/sentry-python

feat(dev): Add object matcher pytest fixture

+import pytest+++@pytest.mark.parametrize(+    "test_string, expected_result",+    [+        # type matches+        ("dogs are great!", True),  # full containment - beginning+        ("go, dogs, go!", True),  # full containment - middle+        ("I like dogs", True),  # full containment - end+        ("dogs", True),  # equality+        ("", False),  # reverse containment+        ("dog", False),  # reverse conainment
        ("dog", False),  # reverse containment
lobsterkatie

comment created time in 3 days

PullRequestReviewEvent

push eventgetsentry/sentry

Alberto Leal

commit sha 033862f985d56cdedf6c4a1b463ca31062502b89

golf

view details

push time in 3 days

Pull request review commentgetsentry/sentry

feat(vitals): Support measurements in metric alerts

 const getFieldOptionConfig = (dataset: Dataset) => {         return ['tags[sentry:user]', 'string'];       } +      if (organization.features.includes('measurements')) {

Should be addressed in https://github.com/getsentry/sentry/pull/21498/commits/524d080acc0dbde1646fcd66d091a5ab49412ff0

dashed

comment created time in 3 days

PullRequestReviewEvent

push eventgetsentry/sentry

Marcos Gaeta

commit sha 533b53bd80906fe5bb7b060fc46e37d9fab7a7bd

fix(api): request.user.is_authenticated (#21194)

view details

Marcos Gaeta

commit sha 36c577ad09ec47d66e3d9d9885c13fd8a7aaae74

fix(api): can't compare datetime.datetime to NoneType (#21269)

view details

Mark Story

commit sha 9e27273ea25457c93325e05c2e8ba34ac72c7ed8

ref(ts) Convert Organization stats to typescript (#21569) Get the TS conversion done so that I can replace the chart.

view details

Mark Story

commit sha 7526d8fba87cb1a62b7c3579546bff56a6968f43

ref(ui) Update release health sparklines to echarts (#21560) Use MiniBarChart to render release health sparkline charts.

view details

Stephen Cefali

commit sha 4098f058c891b7af48dbfdcc613c40a7bc03b1c2

handle camel case nonFieldErrors (#21578)

view details

Chris Fuller

commit sha 49f3ded562b2b73eb573a9fba218b9c9117c6bb5

feat(workflow): Add GroupInbox support to post_process_group (#21440)

view details

Stephen Cefali

commit sha d3b8d953a52ba5cf1e741e957fc8dd06cfd176c8

feat(ui): adds Sentry project selector field (#21571)

view details

Saif Hakim

commit sha ad9321fe94740087f7f7589ac8875225a20e7010

fix(integrations): Merge project_issue_defaults updates instead of overwrite (#21580) When an external issue is either created or linked, `store_issue_last_defaults` is called to persist the subset of field values that are configured for that integration via `get_persisted_default_config_fields` for the next issue created or linked. In common scenarios, "create" has a complete list of defaults to persist while "link" has an empty list, as only the existing issue id needs to be specified. This is problematic in the old implementation, as linking an issue would unset all default values captured via the "create" flow. Additionally, the old implementation would effectively unset defaults for any other projects. The new implementation avoids both of these issues by merging updates into both levels of the config object's "project_issue_defaults". Fixes #15720 ---- ## Test Plan - I've added regression tests for both problematic scenarios - I've tested both cases manually via the UI. To illustrate the issue, I've recorded a GIF that demonstrates the first problematic behavior: ![old-behavior](https://user-images.githubusercontent.com/549473/97099713-59cd9100-1649-11eb-8c5f-50d1342974d7.gif) With the fix applied, we see that the previous default values are preserved: ![new-behavior](https://user-images.githubusercontent.com/549473/97099884-30ae0000-164b-11eb-9342-61e562266a14.gif)

view details

William Mak

commit sha 0b187508cb4db6c02c4ded0505f84edbac8d48e2

ref(trends): Remove medium confidence as an option (#21574) - High confidence should be a good default, and users shouldn't need to click through a few options to see other transactions

view details

Abhishek Kumar Singh

commit sha aac83885d964154786fb46df740f871ec3da781e

fix(deletion): set MAX_RETRIES=5 for prod (#21581) Fixes #19721.

view details

Alberto Leal

commit sha dfcfe3ff93e34fe5baf19a404b53ff60304a6f12

feat(vitals): Support measurements in metric alerts

view details

Dan Fuller

commit sha b52e04bab4af017a0d9cf5c2e990a95f1b893ba1

Feedback + test

view details

Alberto Leal

commit sha 6e796ff43a06f0b47e2cf48e20bb7b0737f2cc01

filter by measurements feature

view details

Alberto Leal

commit sha 524d080acc0dbde1646fcd66d091a5ab49412ff0

source measurement options from WEB_VITAL_DETAILS + fix evan's ts bug

view details

push time in 3 days

PullRequestReviewEvent

starteddotenv-linter/dotenv-linter

started time in 3 days

startedamandaghassaei/OrigamiSimulator

started time in 4 days

startedtweag/nickel

started time in 4 days

startedrust-cli/climake

started time in 4 days

startedprisma/quaint

started time in 5 days

push eventdashed/personal

Alberto Leal

commit sha fbb240eaa9a60e71873fb7d4504cdc4d69a546c8

update musicdl

view details

push time in 5 days

push eventgetsentry/sentry

Alberto Leal

commit sha e9eee9ffa98c55d33eb47786454cf7d978b74961

feat(web-vitals): Add vertical line markers for web vitals on span view

view details

push time in 5 days

push eventgetsentry/sentry

Scott Cooper

commit sha 15431e99623c8ec824106dd1c4ee04ac67e47c30

ref(ui): Switch ts-ignore to ts-expect-error (#21565)

view details

Tony

commit sha 9e7f247db90357d63a41da19429d44ef66461ca6

ref(vitals): Reword the description for CLS (#21572)

view details

Dan Fuller

commit sha cd0f78a95fbf19844a87775d7a7d0ac782a668ab

fix(metric_alerts): Handle `None` values being returned in the subscription topic. (#21566) For some aggregates like `avg`, if no rows exist in the query period the value will end up being `nan`, which is translated to `None` when parsing json. Changing our code to be able to handle this correctly. I've modified the existing json schema rather than adding a new version - this is something that could have been sent through the entire time but hasn't happened yet, and we're just relaxing restrictions so it should be safe.

view details

Marcos Gaeta

commit sha 533b53bd80906fe5bb7b060fc46e37d9fab7a7bd

fix(api): request.user.is_authenticated (#21194)

view details

Marcos Gaeta

commit sha 36c577ad09ec47d66e3d9d9885c13fd8a7aaae74

fix(api): can't compare datetime.datetime to NoneType (#21269)

view details

Alberto Leal

commit sha 3ca52b6be6f994c6806f8250ebb1a222932b47b7

feat(web-vitals): Add vertical line markers for web vitals on span view

view details

Alberto Leal

commit sha 70fe94e21239d8b1c78bd428ca5f009ba00d9ac5

align span rectangles absolutely

view details

Alberto Leal

commit sha 5c05f25be7fedb31ef4ec1ee144fae7a9f336477

rm console

view details

Alberto Leal

commit sha f342d817ee046c6c644cabdf15cf107b9b530e57

align measurements properly

view details

Alberto Leal

commit sha b3fb2bd1d31b5f64832ed62fffbeabbe4ae28626

feature gate measurement markers

view details

Alberto Leal

commit sha 7d0285b2e8d420c102af7b3cb7d8c768bc7f6968

init secondary header content

view details

Alberto Leal

commit sha c1961986eaa08214b813d2cf84b83c9fcfb6b9e8

flesh out secondary panel

view details

Alberto Leal

commit sha 9085a2596ebf1229752a9e27ceb0b184259d4f4b

only render the secondary header if there are measurements

view details

Alberto Leal

commit sha dab655ed072e79f86f03021a0be1fabea040c9ef

things

view details

Alberto Leal

commit sha ea8706ea683b37fd78a08a15f4547de3f2872ec6

SpanViewBoundsType

view details

Alberto Leal

commit sha c8dfbbaa3f90cec994ef23f76a6993bf371d7d91

fix

view details

Alberto Leal

commit sha 041d9d2f3208a9e2abc952f2170e63ddc07a6f84

marker placement

view details

Alberto Leal

commit sha 2f83286350d59483fb9c126fa81eb1a84d7e9b4b

add Padding component

view details

Alberto Leal

commit sha ae29d75dae79fd17b99806ef468904fd4fbe8921

add acronyms

view details

Alberto Leal

commit sha a3e798f1e17ab63a77c2ebe11dff6afa34f599d2

add more acronyms

view details

push time in 5 days

push eventgetsentry/sentry

Alberto Leal

commit sha c57f1d236344aa99bfa7a4fa08e1ea8af54df387

bigger hitbox

view details

push time in 5 days

push eventgetsentry/sentry

Alberto Leal

commit sha 7e53c6f8721499bf7737acc1bcb7761ddb5a4b15

clamp label's position

view details

push time in 5 days

push eventgetsentry/sentry

Alberto Leal

commit sha 2ab739a3418bc8edec3e0dc27a3deff73caf3763

clamp span bar

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha f621a7323daefb2f62876c4315b43f693ac1b651

clamp

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha 1bbd2e49b0041d09411c12a99085d61ba37c79bd

dont display markers when span details is expanded

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha 369c9c3887eb3ced96a11c4465743f22a00ca600

add hover elements to measurement panel

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha 9bf497f662b4bd02686dea8bf23de586590a638c

fix

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha 8f0a882fe57d6badb5b7e01840201256472de365

fixes

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha e2c9717828fb865955d3e74bd97b21d35079f493

add measurements manager

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha a17f78d8a04ca16a78dabb81a7e84f9fdc46dbd5

add hover css to measurement markers

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha 4fbfb9cdab0d9e4b2be344fc323ba73f2db8ba38

deduplicate measurement markers

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha 9d3ec0dc588ac9905b8789a6c95588e38e9ee5a3

fix labels

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha 053dacc409e9e672040a1ace08659224675ac372

typo

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha 9ce2799e8e9b24ddbcaf22a0a4e67b3d5789c4ae

rm Padding

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha 74a9d2d791e791d37e6619eb0017ef974609c3ac

fixes

view details

push time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha 6f932a6996d1776761562524433f7ee36a632f91

remove padding on the sides of the span view

view details

push time in 6 days

startedliamg/gitjacker

started time in 6 days

pull request commentgetsentry/relay

fix: Get rdkafka to build on windows

Just a note. After this PR, I needed to do brew install cmake on macOS.

Swatinem

comment created time in 6 days

push eventgetsentry/sentry

Alberto Leal

commit sha d0dc038112c3a8805231588bcb8c56bfa6cc5d5e

fix

view details

push time in 6 days

PullRequestReviewEvent

push eventgetsentry/sentry

ted kaemming

commit sha fce0b9db082be6256bc8ab108f7eb9ec2c33d36b

fix(kafka): Update arbitrarily renamed `KafkaError` in commit retry policy (#21392)

view details

NisanthanNanthakumar

commit sha 77bc7725281c77b0bbd29fa190be61eb63248aa2

fix: Wait unitl plugin config form loads (#21393)

view details

Matej Minar

commit sha 4de75402c59d9cd6248104261ad94712820428cc

feat(ui): Update 100 colors (#21246) We are making the lightest shade of our colors (100) a bit darker in preparation for future changes.

view details

Matej Minar

commit sha 9452fdfb40f92d253b031659d6608ea5fce68774

fix: MiniBarChart default props (#21357)

view details

Priscila Oliveira

commit sha 8fa965db7eb3c0ee1edc0b62634b9771888f5b05

ref(frames): Remove Frame Platform Border && Replace platform icon with PlatformIcons (#21322)

view details

Burak Yigit Kaya

commit sha c23cbde83a754a31c2ddeccc80c95bc55fea9a50

build(wheel): Omit dev requirements from binary distributions (#21390) All the extra requirements are listed in the wheel which prevented us from uploading the 20.10.0 wheel to PyPI as we list `openapi-core` through our forked GitHub repo. This PR omits `dev` requirements from the binary wheels that are built to allow using git or URL based dependencies as dev dependencies.

view details

Matej Minar

commit sha d502d8961b92a68835613f1b10d6c22c39d49435

fix: Remove visual 0 visual threshold (#21402)

view details

Priscila Oliveira

commit sha de3a03ee5871ea8c8ee55c9c81ad6da163602d84

ref(ts): Convert Breadcrumb Title to ts (#21403)

view details

Priscila Oliveira

commit sha af035b1ed9a465a1dbbebe89414ea4d71a9aadc9

ref(ts): Convert Settings Project item to Typescript (#21404)

view details

Priscila Oliveira

commit sha 8bef7e08cefe74a7a0913ef9cb23c32b164bd522

ref(pill): Update pill border/bg color (#21379)

view details

Burak Yigit Kaya

commit sha 99edf0411918d57d39f1a30e19ca34a4f57e8452

fix(ci): Only set CI=1 for e2e tests for now (#21410) Our JS code (specifically, getDynamicTest) uses the CI env variable incorrectly to detect pull request or acceptance test builds and during the compilation, this value gets hard-coded into the wheel. This PR is a stop gap solution to address #21409 quickly.

view details

Tony

commit sha 6d541bf18a6042d1624ee5047f5064fe88e9310e

ref(discover): Move to using json for range functions (#21334)

view details

Mark Story

commit sha c149da43d9ae73e1a1260ddeba399f3d2df295e0

ref(search) Add warning for project searches (#21384) I think this code is unused and I'd like to remove it. Before I do I want to make sure it is unused.

view details

Mark Story

commit sha df441c8bdc59304a009d35209f199dde1b1927a7

fix(ui) Use better word in chart footer. (#21412) Fixes VIS-255

view details

Tony

commit sha 50ac5390c4fd35846c44726c49978fcdd329649d

ref(vitals): Clean up web vitals constants (#21389)

view details

Burak Yigit Kaya

commit sha f4370a6a13a7516610bf19c8134940a53e1f8122

ci(release): Add sleep between prepare and publish back (#21413) Turns out getsentry/craft#117 did not fix the issue fully.

view details

Priscila Oliveira

commit sha e2a4906db49ef3251068097b88f6f6feafc14caf

fix(pill): Minor fix (#21406)

view details

Robin Rendle

commit sha 7ba1b205eb2dc0832f0d4738c31a5e5c80bfcd5c

ref(jumbotron):removed jumbotron styles (#21396)

view details

Stephen Cefali

commit sha a355bde39ea9f92c2fc305cb8cb8b9c8242e99e3

feat(github): allow users to uninstall github from Sentry (#21327)

view details

Dan Fuller

commit sha 39d35e1f506804d9761a54e0b9dc436c99050afc

refs(metric_alerts): Keep track of pending snapshot queue size (#21351) We want to be able to track this so that we can alert if the queue grows too large.

view details

push time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgetsentry/sentry-docs

Add: Descriptions to front matter

 sidebar_order: 3 redirect_from:   - /performance/distributed-tracing/   - /performance-monitoring/distributed-tracing/+description: "Learn more about distributed tracing and how Sentry tracks your software performance, measuring things like throughput and latency, and can also display the impact of errors across multiple systems."
description: "Learn more about distributed tracing and how Sentry tracks your software performance, measure things like throughput and latency, and can also display the impact of errors across multiple systems."

I think this is the correction it needs.

MimiDumpling

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentgetsentry/sentry-docs

Add: Descriptions to front matter

 title: "Metrics" sidebar_order: 3 redirect_from:   - /performance-monitoring/performance/metrics/+description: "Learn more about Sentry's Performance Metrics and how they provide insight about how users are experiencing your application. Guage application performance with Apdex, failure rate, throughput, and latency."
description: "Learn more about Sentry's Performance Metrics and how they provide insight about how users are experiencing your application. Gauge application performance with Apdex, failure rate, throughput, and latency."
MimiDumpling

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentgetsentry/sentry-docs

Add: Descriptions to front matter

 sidebar_order: 3 redirect_from:   - /performance/distributed-tracing/   - /performance-monitoring/distributed-tracing/+description: "Learn more about distributed tracing and how Sentry tracks your software performance, measuring things like throughput and latency, and can also display the impact of errors across multiple systems."

seems weird

MimiDumpling

comment created time in 7 days

PullRequestReviewEvent

push eventgetsentry/sentry

Alberto Leal

commit sha 1c684e6d53e0b0d503ea7867809e7a799976f127

feat(discover): Allow columns that are number types to be used in aggregates. (#21515)

view details

push time in 7 days

delete branch getsentry/sentry

delete branch : add-cls-to-aggregates

delete time in 7 days

PR merged getsentry/sentry

Reviewers
feat(discover): Allow columns that are number types to be used in aggregates.

Add a validation function to functions/aggregate function that accept numeric columns as parameters. This function will be able to exclude certain built-in functions (such as stack.colno) that shouldn't be used as parameters.

Screen Shot 2020-10-22 at 3 33 47 PM Screen Shot 2020-10-22 at 3 33 34 PM

+73 -20

1 comment

3 changed files

dashed

pr closed time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch getsentry/sentry

delete branch : device-stack-as-strings

delete time in 7 days

pull request commentgetsentry/sentry

fix(discover): Coerce device and stack columns as strings instead of numbers

I'm leaving the types as is as they're correctly typed. I'll add a validation function to deny certain built-in columns in https://github.com/getsentry/sentry/pull/21515/

dashed

comment created time in 7 days

push eventgetsentry/sentry

Alberto Leal

commit sha a983b61c39fd8ca50d97a5955ce129fd9a869eb6

fix(vitals): Show only web vitals on the event details (#21512)

view details

Stephen Cefali

commit sha 00ba48dab58fc84e9e801d8e208494653dd0c6a6

ref(ts): convert projectPlugins details (#21448)

view details

Taylan Gocmen

commit sha bd6fa102ca6f3ea97605067df85f2fefc1f2e9bc

fix(workflow): Dynamic counts discovery link support text query (#21513)

view details

Dan Fuller

commit sha cc7b9015a7f43c9e5a909e28c69502c627dd6c00

fix: Allow `DEFAULT_QUEUED_MAX_MESSAGE_KBYTES` to be overriden in config (#21518) Because we assign this in the function definition we can't override it later on. Changing this so we always fetch this default dynamically.

view details

Matej Minar

commit sha 2cba3a53ab982725b325cb54343faa86ec3f9209

Update releaseChartControls.tsx (#21521)

view details

Matej Minar

commit sha 90d0dc120c36a25491efd05d9e6bc08af2cbfc5e

feat(ui): Add support for custom event/group title (#21356) This PR adds support for custom event/group title. If there is a title field in metadata object it will be respected and have a bigger weight than any other condition. This also refactors multiple getTitle and getMessage methods all over the codebase to use the same one. UI part to #21297

view details

Priscila Oliveira

commit sha f88fb914b6a9c1d07f5249f78cb74f643afe49e4

ref(annotated-text): Improve tooltip (#21502)

view details

Priscila Oliveira

commit sha 7877af3de654252c2e5dd637b6c3483af148cf2b

ref(ts): Convert Similar Issues List to typescript (#21506)

view details

Tony

commit sha 8be3ecbd5aa382d0a4b7ecede9df5484688a9065

fix(discover): Display the correct cell actions for nullable numeric cells. (#21516) With measurements now available in discover, null values wreck havoc on cell actions. For non null values, we can continue display the existing cell actions. But for null values, we do the following: 1. If the null value is function, no cell actions will be shown. 2. If the null value is a field, add/exclude cell actions will be shown.

view details

Mark Story

commit sha 00e65eed496c8e641430a0d76d12be489d01a01b

ref(ui) Replace inbound filter chart with echarts (#21505) Replace another chart with echarts. I have also updated the colours to use the theme colours. I tried to keep them close but the less colours and theme colours are noticably different. I've also replaced the loading spinner with a static placeholder. The spinner was too tall and resulted in layout shift after the chart data was loaded.

view details

Tony

commit sha 61ef7d4b7b3c54ed22e22ec4ca495bd0d57e0d96

feat(vitals): Add histogram of CLS values to the vitals tab (#21488) Now that the JS SDK records CLS data, include the histogram for CLS on the vitals tab.

view details

k-fish

commit sha d3b23e980d1f2f5d54028994ce52ed0c339e27dd

ref(ts): Convert generic interface to typescript (#20962) * ref(ts): Convert generic interface to typescript This converts `generic` interface to typescript, removing `event` as it's unused

view details

k-fish

commit sha eb9f0b4e1520378aff000419db9c07be1ce62703

fix(trends): Reset trend pages on query change (#21520) * fix(trends): Reset trend pages on query change This will reset pagination when changing the query. Added a test to ensure browser history continues to be pushed correctly.

view details

Billy Vong

commit sha 2596e6f9185447358b3b5ba3c5bb7a267d779de6

ref(ts): Convert `events/contexts/default` (#21529)

view details

Billy Vong

commit sha 19ccccf4722c55ee2956249e33725d1a73270705

ref(ts): Convert `dropdownAutoComplete/autoCompleteFilter` (#21531)

view details

MeredithAnya

commit sha 3e129a034268c74604190215b1deb1799f119933

ref(stacetrace-link): ProjectStacktraceLinkEndpoint (#21449) * ref(stacetrace-link): ProjectStacktraceLinkEndpoint

view details

Billy Vong

commit sha a0b51e969139d01fed2d14c58b72683442dd5b81

build(gha): Acceptance workflow must match filename for Visual Snapshots (#21522) This fixes a regression due to https://github.com/getsentry/sentry/pull/21386 where snapshots are not comparing against the correct set of snapshots because the workflow name must match the filename. This is because in our workflows, we only have the *workflow name* as part of [GHA Environment Variables](https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables#default-environment-variables) and the [GH API only accepts a workflow name as an argument](https://developer.github.com/v3/actions/workflows/#get-a-workflow).

view details

Lyn Nagara

commit sha 811285b3312f9257df15858b3a2e1d68dc0e679d

feat(oss): Migrate old style node data (#21519) This resaves node data using the new style ID if an older node ID is present. This affects upgrades from Sentry versions prior to 9.1.0. This issue came up in https://forum.sentry.io/t/after-upgrade-from-9-1-2-to-10-0-20-9-latest-no-events-details/11411

view details

Tony

commit sha ada272129adda86aad66b00181991ab2fa1d4cca

fix(vitals): Format failure tooltip with the right type (#21541) Vitals can be either duration or numbers. So make sure to format the tooltip with the right formatter depending on the type.

view details

Evan Purkhiser

commit sha 0e9f0116eb533962f7c919194600e3654694d49f

ref(py3): bigtable column family accepts a str, not bytes (#21493)

view details

push time in 7 days

PullRequestReviewEvent

startedwebview/webview_deno

started time in 7 days

PullRequestReviewEvent
more