fork creack/grpc-web-hacker-news
An example app implementing a Hacker News reader in React with gRPC-Web and Go backend
fork in 8 days
delete branch creack/plantuml-hot-loader
delete branch : dependabot/npm_and_yarn/eslint-utils-1.4.3
delete time in 18 days
push eventcreack/plantuml-hot-loader
commit sha 4cdddbb42c6ecebfbb06414d7b3f7bde2a8b13ef
Bump eslint-utils from 1.4.0 to 1.4.3 Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](https://github.com/mysticatea/eslint-utils/compare/v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]>
commit sha a7cf55b564550b15d2442d85d7fad197cf68b47e
Merge pull request #1 from creack/dependabot/npm_and_yarn/eslint-utils-1.4.3 Bump eslint-utils from 1.4.0 to 1.4.3
push time in 18 days
PR merged creack/plantuml-hot-loader
Bumps eslint-utils from 1.4.0 to 1.4.3. <details> <summary>Commits</summary>
23f4ddc🔖 1.4.38f9e481🐛 fix reference tracker false positive6633278⚒ fix test scripts7c8e67c⚒ fix build scripts41ff95e⚒ update dependencies4942012⚒ fix build scriptsf1c8d02⚒ update build scriptsa88598aCreate FUNDING.yml4e1bc071.4.2e4cb014🐛 add null test- Additional commits viewable in compare view </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot ignore this [patch|minor|major] versionwill close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the Security Alerts page.
</details>
pr closed time in 18 days
issue closedcreack/pty
utils.go functions to not require os.File
Would you be open to modify the signature of the functions in utils.go:
- InheritSize
- SetSize
- GetSizeFull
- GetSize
to either accept a File-like interface:
type FileLike interface {
Fd() uintptr
}
or to just require the the File descriptor myFile.Fd() instead of the os.File concrete struct?
func InheritSize(ptyFd, ttyFd uintptr) error {
...
}
If I am not mistaken otherwise it requires the caller to unnecessarily create a os.File object:
var myFileLike FileLike
myFile := os.NewFile(myFileLike.Fd(), "")
pty.InheritSize(myFile, myOtherFile)
closed time in a month
antonio-osorio
issue commentcreack/pty
utils.go functions to not require os.File
Thank you for the detail, but this seems like a very specific case, and I don't think it would justify a change in the public api / major version bump. As you mentioned, os.NewFile does the trick and I believe switching to FDs directly would confuse users.
Note that a "file-like" object which is not backed by an actual tty/pty will fail those calls with "invalid ioctl for device".
Also note that InheritSize is meant to set the pty to the size of the parent terminal, i.e. os.Stdin & co. If the process is in a test runner context, those would be the tty of the runner.
Closing for now. Let me know if you have more questions.
comment created time in a month
issue commentcreack/pty
utils.go functions to not require os.File
In what situation do you have a fd without os.File? I had that situation when dealing with CGO, but it is a quite specific and rare situation. As those Size function can only work with a terminal fd like the one pty.Start returns, I am concerned that modifying the signature to an interface would be more confusing than helpful in most cases.
Could you share more detail about your use case?
FYI, I have another lib https://github.com/creack/termios which is lower level and more "generic" expecting fds directly
comment created time in a month
push eventcreack/dotfiles
commit sha 2734cdedcfbdc0ab8deff046406cf138262abb98
Add osx support
push time in a month
push eventcreack/dotfiles
commit sha c9f69b103b9dab8db24cb6a79c4b9ab24d1d247f
Add osx support
push time in a month
push eventcreack/dotfiles
commit sha a77d7bbdb32f874f6a067a187c43740632355fd0
Update git tag alias Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha 4b294b242d90e71a8fc9d12b413aa0e518bcbe32
Disable smart paren Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha 48f16c294095bb31dcc835d2f22f91e67a51be16
Add snippet to fix elpa Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha 5a3271f77c764d39434432e3881c9ccd23f3c181
Add back missing color test script Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha 76f1ed431e67c0b4deef308691d2a86a37299c5d
Cleanup bootstrap process Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha 920079cfd1a905e2302c665584b2bd1255946f2e
Add base ssh config Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha 13ae734935ded195ac00eabd1b8afd2b2837ecbd
Cleanup unused files Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha 86013481539218fb09e4040ca1a7d16b63dec64a
Add back mergetool Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha d44e6c808a395f884d2eaec75b6da0b8deeefb7f
Update gitignore Signed-off-by: Guillaume J. Charmes <[email protected]>
commit sha 8c3208a1124a56c67b35164f3a01d78d56124b9c
Cleanup git config Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha 8e6173cf8b981691070ff828e5b77739a03bc91a
Add alias for docker grpc Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha 303656c19f48411d3f6041abe032e89b13b658f3
fix powerline json format Signed-off-by: Guillaume J. Charmes <[email protected]>
commit sha 9ccc742c528ab6f24089c1716e516ed754338847
Remove fci-mode from emacs as it break company popup Signed-off-by: Guillaume J. Charmes <[email protected]>
commit sha 9ed25343ed82d6dab198d1de9aa4c8b17b64bb9e
use ~ for path in tmux conf Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in a month
push eventcreack/dotfiles
commit sha df493cc59da59af6b90fd80050292ae91286fb4a
Add visual config for emacs Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in 2 months
push eventcreack/docker-grpc
commit sha 07c80e1bb98b40c5bd94d356cbfb81eb6be8e851
Update readme Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in 2 months
push eventcreack/docker-grpc
commit sha b6ea2a8ddfc8739020262b84b3e7213e58c18b33
Initial commit Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in 2 months
created repositorycreack/docker-grpc
Dockerfile with protobuf, grpc and protoc-gen-go installed.
created time in 2 months
push eventcreack/dotfiles
commit sha 05ac06da1b276827db49122bd2d0a50523984467
Add ansi-color to emacs Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in 2 months
push eventcreack/dotfiles
commit sha 037cfef979d0e59b493ef265d50e147193401a15
remove tpm
push time in 2 months
push eventcreack/dotfiles
commit sha cfacb0f744f0e4c7dea66a46d2fa9f630e0f6dda
fix Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in 2 months
push eventcreack/dotfiles
commit sha bb0365d91a336c3be1700fbc10241532dc1173be
Exclude dirs from recentf Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in 2 months
startedjwiegley/use-package
started time in 2 months
push eventcreack/pty
commit sha 3a6a957789163cacdfe0e291617a1c8e80612c11
Bump go 1.13 Signed-off-by: Guillaume J. Charmes <[email protected]>
push time in 2 months
issue commentopen-telemetry/opentelemetry-service
Manually updating the go.mod to use prometheus' commit 52e0504f83ea6ef05b29c458d9b89173df355da7 (i.e., skipping go mod's semver check) did the trick and I have been able to build using 1.13. Thanks!
comment created time in 2 months
issue commentopen-telemetry/opentelemetry-service
@brian-brazil the "go" way to update a vendor version is to use go get, however, getting prometheus.
https://github.com/golang/go/wiki/Modules#daily-workflow
When needed, more specific versions of dependencies can be chosen with commands such as go get [email protected], go get foo@master (foo@tip with mercurial), go get foo@e3702bed2, or by editing go.mod directly.
After manually updated go.mod, it still fails but with a different error:
go build
go: finding github.com/prometheus/prometheus v2.12.0
go: finding github.com/prometheus/prometheus v2.12.0
go: errors parsing go.mod:
/home/guillaume/go/src/github.com/census-instrumentation/opencensus-service/go.mod:36: require github.com/prometheus/prometheus: version "v2.12.0" invalid: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2
comment created time in 2 months
issue commentopen-telemetry/opentelemetry-service
Dockerfile to reproduce:
FROM golang:1.13
RUN apt-get update && apt-get install -y bzr
RUN GO111MODULE=on go run github.com/open-telemetry/opentelemetry-service/cmd/otelsvc
Working on golang:1.12.
The same issue happens with opencensus service. Seems like the issue is that the project depends on internal packages not meant to be imported from prometheus. prometheus/prometheus#6048
comment created time in 2 months
issue commentprometheus/prometheus
Thanks you, i'll move it there then. Still sad that bumping go version breaks the build.. I wish the go1compat contract would extend to the toochain
comment created time in 2 months
issue commentprometheus/prometheus
That's the great thing with go mod, when it fails, you can't know why ^^
go mod why github.com/prometheus/prometheus
go: github.com/prometheus/[email protected] requires
k8s.io/[email protected]+incompatible: invalid pseudo-version: preceding tag (v2.0.0-alpha.0) not found
But even if we remove opencensus from the issue, imho, prometheus should still be go gettable.
comment created time in 2 months
issue openedprometheus/prometheus
Hello,
It seems like go get with prometheus is broken on 1.13, which breaks opencensus service (and I suspect anything else depending on prometheus)
prometheus v2.5.0 seems to be working with go1.13, the issue starts at v2.6.0.
Dockerfile to reproduce:
FROM golang:1.13
RUN apt-get update && apt-get install -y bzr
ENV GO111MODULE=on
RUN go get -d github.com/prometheus/[email protected]
RUN go get -d github.com/census-instrumentation/[email protected]
When using golang:1.12, it works fine.
Error when trying to get promethus directly:
go: finding github.com/prometheus/prometheus v2.12.0
go: finding github.com v2.12.0
go: finding github.com/prometheus v2.12.0
go: finding github.com/prometheus/prometheus v2.12.0
go get github.com/prometheus/[email protected]: github.com/prometheus/[email protected]: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2
Error when trying to get opencensus:
go: finding github.com 0.1.11
go: finding github.com/census-instrumentation/opencensus-service 0.1.11
go: finding github.com/census-instrumentation 0.1.11
go: downloading github.com/census-instrumentation/opencensus-service v0.1.1-0.20190905224837-f37ba81b2506
go: extracting github.com/census-instrumentation/opencensus-service v0.1.1-0.20190905224837-f37ba81b2506
go get: github.com/census-instrumentation/[email protected] requires
github.com/prometheus/[email protected] requires
k8s.io/[email protected]+incompatible: invalid pseudo-version: preceding tag (v2.0.0-alpha.0) not found
created time in 2 months
startedcommanderx16/x16-emulator
started time in 2 months