@marcinwoj Does that mean it works for you? I would be happy if it worked, even if it did require sudo (though Windows users are hung out to dry). Could you update the test and get it back into a working state? I updated it to run under Python 3, but it didn't detect any of the incoming packets (from the ping subprocess) as ICMP packets and then just hung. I'm not sure if I'm missing something? I've never been able to run it successfully.

I am also a big fan of this example, as I learned from that how to intercept packets and I used something similar in my designs.

Agree with @cmarqu this shows how powerful cocotb is to leverage the external environment and use cocotb more as a "glue" rather than a test generator.

Codecov Report

Merging #2237 (4a14681) into master (0a1c46a) will decrease coverage by 10.13%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2237       +/-   ##
===========================================
- Coverage   65.86%   55.72%   -10.14%     
===========================================
  Files          47       47               
  Lines        7953     7872       -81     
  Branches     1324     1318        -6     
===========================================
- Hits         5238     4387      -851     
- Misses       2123     3032      +909     
+ Partials      592      453      -139     

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a1c46a...4a14681. Read the comment docs.

Closes #1988.

@eric-wieser I think we can replace the regression manager with pytest using a somewhat similar approach. This depends on #791.

We could change the implementation of cocotb.test decorator to add the decorated test coroutine to a scheduler when called and also ensure tests start/end in normal mode. This would translate them to normal functions that pytest can run. With this solution pytest could also run undecorated non-coroutine functions if desired. We can also support running tests using pytest without a simulator, as long as those tests don't call into the simulator.

The end result would look very similar to what we have now, but we could extend it with pytest functionality

@pytest.parameterize("a", [1, 2, 3])
@cocotb.test()
async def test_thing(a):
    # do stuff ...

Codecov Report

Merging #2236 (5031e73) into master (0a1c46a) will decrease coverage by 10.22%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2236       +/-   ##
===========================================
- Coverage   65.86%   55.63%   -10.23%     
===========================================
  Files          47       47               
  Lines        7953     7844      -109     
  Branches     1324     1318        -6     
===========================================
- Hits         5238     4364      -874     
- Misses       2123     3025      +902     
+ Partials      592      455      -137     

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a1c46a...5031e73. Read the comment docs.

Updated the issue-specific tests to use async/await, assert, and specify units in Timer. Passing specific exceptions to expect_error is #2223.

We should get one more approval before removing it.

The below warnings were generated by sphinx code in Python-land. This PR fixes these issues.

/home/kaleb/dev/cocotb/cocotb/decorators.py:docstring of cocotb.test:26: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/kaleb/dev/cocotb/cocotb/drivers/amba.py:docstring of cocotb.drivers.amba.AXI4Master.write:5: WARNING: Unexpected indentation.
/home/kaleb/dev/cocotb/documentation/source/release_notes.rst:33: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/kaleb/dev/cocotb/documentation/source/release_notes.rst:64: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/kaleb/dev/cocotb/documentation/source/install_devel.rst:31: WARNING: undefined label: https://pip.pypa.io/en/stable/user_guide/#user-installs (if the link has no caption the label must precede a section header)
/home/kaleb/dev/cocotb/cocotb/monitors/__init__.py:docstring of cocotb.monitors.Monitor:3: WARNING: more than one target found for 'any' cross-reference 'coroutine': could be :std:term:`coroutine` or :py:class:`cocotb.coroutine`

A similar example that doesn't require sudo permission would be nice. Either of the examples you mentioned would work. Matt's code is up to date, the JPEG encoder example is not.

Using latest icarus verilog from master fails with:

/mingw64/bin/vvp -M /mingw64/lib/python3.8/site-packages/cocotb/libs -m libcocotbvpi_icarus   sim_build/sim.vvp
libcocotbvpi_icarus:`C:/msys64/mingw64/lib/python3.8/site-packages/cocotb/libs\libcocotbvpi_icarus.vpl' failed to open using dlopen() because:
    %1 is not a valid Win32 application.

Starting with a59b183b icarus verilog on windows no longer exports vpi_* in vvp.exe. As a result, the current libcocotbvpi_icarus.vpl is unable to load because it no longer can import these symbols.

This was fixed in https://github.com/steveicarus/iverilog/issues/395

Codecov Report

Merging #2235 (43e549f) into master (631d571) will decrease coverage by 11.06%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2235       +/-   ##
===========================================
- Coverage   66.44%   55.37%   -11.07%     
===========================================
  Files          47       47               
  Lines        7953     7807      -146     
  Branches     1324     1318        -6     
===========================================
- Hits         5284     4323      -961     
- Misses       2082     3030      +948     
+ Partials      587      454      -133     

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 631d571...43e549f. Read the comment docs.

The below warnings were generated by sphinx code in Python-land. This PR fixes these issues.

/home/kaleb/dev/cocotb/cocotb/decorators.py:docstring of cocotb.test:26: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/kaleb/dev/cocotb/cocotb/drivers/amba.py:docstring of cocotb.drivers.amba.AXI4Master.write:5: WARNING: Unexpected indentation.
/home/kaleb/dev/cocotb/documentation/source/release_notes.rst:33: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/kaleb/dev/cocotb/documentation/source/release_notes.rst:64: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/kaleb/dev/cocotb/documentation/source/install_devel.rst:31: WARNING: undefined label: https://pip.pypa.io/en/stable/user_guide/#user-installs (if the link has no caption the label must precede a section header)
/home/kaleb/dev/cocotb/cocotb/monitors/__init__.py:docstring of cocotb.monitors.Monitor:3: WARNING: more than one target found for 'any' cross-reference 'coroutine': could be :std:term:`coroutine` or :py:class:`cocotb.coroutine`

Codecov Report

Merging #2234 (51e8a51) into master (631d571) will decrease coverage by 11.06%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2234       +/-   ##
===========================================
- Coverage   66.44%   55.37%   -11.07%     
===========================================
  Files          47       47               
  Lines        7953     7807      -146     
  Branches     1324     1318        -6     
===========================================
- Hits         5284     4323      -961     
- Misses       2082     3030      +948     
+ Partials      587      454      -133     

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 631d571...51e8a51. Read the comment docs.

Closes #2232. Still open for discussion in the issue whether this is a good idea or not.

Has a deprecation newsfragment and test, updated for readwrite_in_readonly for our current understanding. Ready for final review.

1. Remove or catch warning for deprecated Scoreboard
2. Use cocotb.top to get generics/parameters instead of exported Environment Variables

A few reasons:

• example is out of date
  • doesn't work in Python 3 without modification
  • many newer systems don't ship with ifconfig tool
  • still using old generator-based coroutines
  • even with all issues resolved it still fails?
• requires sudo or other special permissions to run
  • not run in CI
• documentation is out of date
  • copy-pasted sources are no longer correct

This was fixed another way (steveicarus/iverilog#395). But it depends on cocotb not registering any custom VPI system tasks, so we may come back to this.

Has your question been resolved? If so please close this issue. If it has not been resolved, you may need to provide more information. If no more activity on this issue occurs in 7 days, it will be closed.

Has your question been resolved? If so please close this issue. If it has not been resolved, you may need to provide more information. If no more activity on this issue occurs in 7 days, it will be closed.

The matrix_multiplier test was intended to take 30s-1min, in order to provide some performance data. When using some simulators with lower performance, the test is longer than necessary for regression purposes. This allows shortening the test by setting the environment variable. Riviera CI should be cut by ~half once this is in. If any of the GHA regressions are taking too long we can tune them.

You'll need to update test_iteration_vhdl as well.

Codecov Report

Merging #2231 (368e3ad) into master (488de76) will decrease coverage by 6.13%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2231      +/-   ##
==========================================
- Coverage   61.50%   55.37%   -6.14%     
==========================================
  Files          47       47              
  Lines        7950     7807     -143     
  Branches     1324     1318       -6     
==========================================
- Hits         4890     4323     -567     
- Misses       2517     3030     +513     
+ Partials      543      454      -89     

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 488de76...368e3ad. Read the comment docs.

Riviera-PRO 2020.04 behaves identical to 2019.10 in our discovery tests, update the expectations accordingly.

<!--

Thanks for improving cocotb! Here are some points to make this as smooth as possible. Not all of them may be applicable.

Most important: please explain why you are proposing this change.

• Make sure you have read https://github.com/cocotb/cocotb/blob/master/CONTRIBUTING.md
• Extend or add a test under tests/test_cases/.
• Add documentation under documentation/source/, docstrings in Python code, or Doxygen markup in C/C++ code. Use versionadded/versionchanged/deprecated.
• Add a newsfragment - see documentation/source/newsfragments/README.rst.
• Use closes #XXXX to auto-close the issue that this PR fixes (if such).

-->