profile
viewpoint
Jerad C cjerad Amazon Web Services

cjerad/amazon-ec2-instance-selector 0

A CLI tool and go library which recommends instance types based on resource criteria like vcpus and memory

cjerad/aws-node-termination-handler 0

A Kubernetes Daemonset to gracefully handle EC2 instance shutdown

cjerad/clouddriver 0

read and write operations across cloud providers

cjerad/deck 0

Management UI for Spinnaker

cjerad/echo 0

Spinnaker Eventing Service

cjerad/fiat 0

Spinnaker auth service

cjerad/front50 0

Spinnaker Metadata Repository Service

cjerad/gate 0

Spinnaker API Gateway

cjerad/halyard 0

A tool for configuring, installing, and updating Spinnaker

cjerad/igor 0

Integration with Jenkins and Git for Spinnaker

push eventcjerad/rosco

push time in 23 days

push eventcjerad/orca

pdk27

commit sha 65dd7b5e8ddbb3c733e3d73bc748ff1742297cba

Commenting out recent buggy change

view details

Ubuntu

commit sha 113ea7c12ebcf50a31968157c3480b5a01d6a0b0

Merge remote-tracking branch 'upstream/master'

view details

push time in 23 days

push eventcjerad/kayenta

push time in 23 days

push eventcjerad/igor

push time in 23 days

push eventcjerad/gate

push time in 23 days

push eventcjerad/front50

push time in 23 days

push eventcjerad/fiat

push time in 23 days

push eventcjerad/echo

push time in 23 days

push eventcjerad/deck

push time in 23 days

push eventcjerad/clouddriver

push time in 23 days

create barnchcjerad/rosco

branch : ec2-spot

created branch time in a month

push eventcjerad/rosco

spinnakerbot

commit sha 20b08d910709d80aa5028291a722b52cc587c1d7

chore(dependencies): Autobump korkVersion (#687) Co-authored-by: root <root@50805f9a9c19>

view details

spinnakerbot

commit sha 83331fa8646cb33b28eb33ff76d4e522e9624073

chore(dependencies): Autobump korkVersion (#688) Co-authored-by: root <root@f429c082b070>

view details

spinnakerbot

commit sha e22863cc89575b42b5b42e997b1d5b96db71b719

chore(dependencies): Autobump korkVersion (#689) Co-authored-by: root <root@12e6abdc8861>

view details

Michael Plump

commit sha 13487f2aa6852ec040725b4d31c1e7035116d138

chore(dockerfile): various Dockerfile cleanups (#690) * chore(dockerfile): delete the (unused) java8 dockerfiles * chore(dockerfile): replace deprecated MAINTAINER with LABEL * chore(dockerfile): use gid/uid 10111 for the spinnaker user * chore(dockerfile): make docker builds more cacheable

view details

spinnakerbot

commit sha 93698c9d1e28ba615226574570bd245113196f3b

chore(dependencies): Autobump spinnakerGradleVersion (#691) Co-authored-by: root <root@6a807b439d68>

view details

Cameron Fieber

commit sha 508ec0640b9c367c7c07dbd3100f3b87f0e84c60

chore(build): gradle 6.6 (#692)

view details

spinnakerbot

commit sha 162173095a2fa8fa521fa379b8d3ad15133b0f11

chore(dependencies): Autobump korkVersion (#693) Co-authored-by: root <root@87c6cb8f1126>

view details

spinnakerbot

commit sha efab813c29c4190e049975157db881998075ba2a

chore(dependencies): Autobump korkVersion (#694) Co-authored-by: root <root@048626cb7ef2>

view details

spinnakerbot

commit sha 79d1c25d215245bfb454453a8ef771fdebe2fbc7

chore(dependencies): Autobump korkVersion (#695) Co-authored-by: root <root@7cc2f7e2e8cd>

view details

spinnakerbot

commit sha f4834d6df10c26782d9347fbda72ab03f7fcceca

chore(dependencies): Autobump korkVersion (#696) Co-authored-by: root <root@4bab6a330c11>

view details

Eric Zimanyi

commit sha ffecdc9f3d51e95f7092a1c008526dcc92bf2b07

fix(bake): Fix error when updating artifacts after bake (#697) * test(bake): Add test exercising bake artifact handling There is currently no test that exercises the logic that updates the name and uuid on artifacts produced by a bake. Add a test exercising this logic that currently fails and will be fixed in the next commit. * fix(bake): Fix error when updating artifacts after bake When artifacts were made immutable, this usage was missed as it did not have tests (and was in groovy so compilation didn't catch it). Instead of mutating the artifacts, return copies with the appropriate fields changed.

view details

spinnakerbot

commit sha f7bcc01768ab8953446a531bf434676390345a5f

chore(dependencies): Autobump korkVersion (#698) Co-authored-by: root <root@534ce9888ac0>

view details

push time in a month

create barnchcjerad/orca

branch : ec2-spot

created branch time in a month

push eventcjerad/orca

Joe DeStefano

commit sha 3fa29ca79172024c96b316ec2173272788136bdd

fix(preconfigured): Allow PreconfiguredJobStage parameters to map to one-dimensional array property values (#3830) * fix(preconfigured): Update setNestedValue to handle one-dimensional array objects * fix(preconfigured): Handle case where array property is missing from root object * refactor(preconfigured): Use Groovy regex syntax * refactor(preconfigured): Update exception message to be more meaningful Co-authored-by: Mark Vulfson <markvu@live.com> Co-authored-by: Mark Vulfson <markvu@live.com>

view details

Mark Vulfson

commit sha 9aa0b3cf91504998a7f201ec1ada9e4e8ef97675

fix(exceptions): Don't let errors in `trackResult` leak out (#3843) It's possible for trackResult metrics call to fail and we don't want that failure to leak out and fail orca tasks Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

spinnakerbot

commit sha c5aa6b572889517dabcae0b016f0fc443ec66b1b

chore(dependencies): Autobump korkVersion (#3847) Co-authored-by: root <root@50805f9a9c19>

view details

spinnakerbot

commit sha 7cb1e8972a63d21a9d09c874135a913b8fa8f189

chore(dependencies): Autobump korkVersion (#3850) Co-authored-by: root <root@f429c082b070>

view details

Sairam Rekapalli

commit sha f941c53a32c3ea2a2b70957909eb12f2a38e0256

fix(misc): Wire up metrics interceptor bean explicitly and also move to the new interface impl (#3852)

view details

spinnakerbot

commit sha 717c56a68c293a06201d4c0edc1fe928c66d861e

chore(dependencies): Autobump korkVersion (#3853) Co-authored-by: root <root@12e6abdc8861>

view details

Mark Vulfson

commit sha 5f4b2edbe72ee5d7003edb71e7477592c1e928b0

fix(exceptions): add exception handler for exceptional situations (#3845) * fix(exceptions): add exceptionhandler for non-excpetional situations When a user submits a bad pipeline e.g. * with jenkins trigger that has an invalid properties file or job that doesn't exist) * with a broken pipeline template we don't want to 500 because: a) the calling service (echo in most cases here) will keep retrying which makes no sense b) it's an erroneous HTTP 500 metric that is noise * fix(exceptions): fix various exception issues 1. Don't log task failures on `UserException` 2. Don't fail retrieving properties file if the build wasn't started * fixup! Merge branch 'master' into mark/exceptionhandlers Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Sairam Rekapalli

commit sha 707d44955028ceb3786d512e912131c4693eb472

fix(misc): adding explicit dependency between the registry,metrics interceptor and web mvc configurer (#3854)

view details

Mark Vulfson

commit sha 63a3322e8186f1e1291b90a28f1d0ade22ac8a67

feat(runjob): add ability to read props file even if job fails (#3855) * feat(runjob): add ability to read props file even if job fails * fixup! feat(runjob): add ability to read props file even if job fails

view details

Daniel Reynaud

commit sha 5a6dc3532b46c84416ef9acd67a6d35bc7b414cd

fix(destroy): add disable stage to destroy server group stage (#3848) Let's add it as a beforeStage instead of duplicating the tasks in the disable stage. In particular, the task graph of DestroyServerGroupStage was missing a determineHealthProviderTask and using the now-deprecated WaitForAllInstancesNotUpTask. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Chris Thielen

commit sha da35b8e5ba958bcf6bb061a18744753ec9d0dba7

feat(pipelines): Pass 'staleCheck' through from savePipeline context to front50 (#3841) * feat(pipelines): Pass 'staleCheck' through from savePipeline context to front50 Related to https://github.com/spinnaker/front50/pull/915 * test: update SavePipelineTaskSpec Co-authored-by: spinnaker <spinnaker@netflix.net> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Michael Plump

commit sha 9d1ff489fd15101c2ddcffe7f654105863086853

chore(dockerfile): various Dockerfile cleanups (#3860) * chore(dockerfile): delete the (unused) java8 dockerfiles * chore(dockerfile): replace deprecated MAINTAINER with LABEL * chore(dockerfile): use gid/uid 10111 for the spinnaker user * chore(dockerfile): make docker builds more cacheable

view details

Mark Vulfson

commit sha 03bb515553d3de3b0864eba83ee0e4f719f3c445

feat(destroy): Add a flag to be able to skip the disable of destroy stage (#3858) Add an experimental flag `skipDisableBeforeDestroy` to the `DestroyServerGroupStage` so that applications that don't participate in discovery can skip disable step which should speed up their destruction operation. Co-authored-by: Adam Jordens <adam@jordens.org>

view details

Chris Smalley

commit sha 03cddba0eb100b08a18df39215a0dfaf04b11ac5

fix(sql): Create SqlActiveExecutionsMonitor via autoconfiguration instead of @Component (#3861) When this bean is created via @Component it fails to find the qualifier bean sqlExecutionRepository when qos is disabled. I can not say I really understand why. Now, the qualifier bean sqlExecutionRepository is found regardless of qos enabled/disabled.

view details

Karl

commit sha 3224fb04bef4757f99ba6437a204664621989608

chore(orca): Remove unused Redis info file (#3849) Discovered whilst investigating Redis connection instantiation. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

spinnakerbot

commit sha ff78f1caf5034eae4f17b21583006df6d28ee143

chore(dependencies): Autobump spinnakerGradleVersion (#3862) Co-authored-by: root <root@6a807b439d68>

view details

Mark Vulfson

commit sha 05050949193e4121a7f93142d6b2857038a14f1b

chore(warnings): Clean up some compilation warnings (#3856) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Cameron Fieber

commit sha 7fe1fe033eb261c71ff726ee3d67f4f296dec991

chore(build): gradle 6.6 (#3865)

view details

spinnakerbot

commit sha 6048dcfb8f0f99c22e05ced8b5d24411a8ae8e93

chore(dependencies): Autobump korkVersion (#3866) Co-authored-by: root <root@87c6cb8f1126>

view details

Lorin Hochstein

commit sha 6ba627bdf6dc4dffa688f7ffa4d9d483774c0bc9

refactor(task): Refactor DetermineRollbackCandidatesTask (#3833) * refactor(task): pull method out of rollback candidate * fix(pr): rename method * fix(pr): finish rename * Update orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/tasks/cluster/DetermineRollbackCandidatesTask.java Co-authored-by: Luis Pollo <1323478+luispollo@users.noreply.github.com> * Update orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/tasks/cluster/DetermineRollbackCandidatesTask.java Co-authored-by: Luis Pollo <1323478+luispollo@users.noreply.github.com> * Update orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/tasks/cluster/DetermineRollbackCandidatesTask.java Co-authored-by: Luis Pollo <1323478+luispollo@users.noreply.github.com> * fix(pr): return object instead of boolean * fix(pr): spotless * fix(pr): rename function * fix(pr): remove AtomicReference * fix(pr): spotless * fix(pr): use static member variable * fix(pr): fix incorrect error message * fix(pr): add test Co-authored-by: Luis Pollo <1323478+luispollo@users.noreply.github.com>

view details

push time in a month

create barnchcjerad/kayenta

branch : ec2-spot

created branch time in a month

push eventcjerad/kayenta

Chris Berry

commit sha fd73211e463cf80a02e4edc9ea9c172a1cb0a21f

feat(reports): allow pagination of canary reports endpoint results (#781)

view details

KeisukeYamashita

commit sha f6bda1a5c535bbe6542b906c1ce3a83cb8ef4061

chore(dockerfile): deprecated mantainer (#777) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Michael Plump

commit sha f50551dce69ec346d5e14897db409fffa19671a0

chore(dockerfile): various Dockerfile cleanups (#782) * chore(dockerfile): delete the (unused) java8 dockerfiles * chore(dockerfile): replace deprecated MAINTAINER with LABEL * chore(dockerfile): use gid/uid 10111 for the spinnaker user * chore(dockerfile): make docker builds more cacheable

view details

spinnakerbot

commit sha ed5ba538f40a992b903eeb2957d45541b3c2f4d1

chore(dependencies): Autobump spinnakerGradleVersion (#783) Co-authored-by: root <root@6a807b439d68>

view details

Cameron Fieber

commit sha cadcbca9f7c0c92cbbff84b91328c050db3f30db

chore(build): gradle 6.6 (#785)

view details

dwest-netflix

commit sha 0d1d754acc80622a20c4ae36caaa6d3eaa0e6bbd

chore(upgradeconfigbin): Upgrades configbin v1 to configbin v2. (#784) Upgrade ConfigBin v1 to ConfigBin v2.

view details

spinnakerbot

commit sha 65e2bb44b890dc280a949bc39a5519a46491bd7b

chore(dependencies): Autobump keikoVersion (#787) Co-authored-by: root <root@e077008c657c>

view details

push time in a month

create barnchcjerad/igor

branch : ec2-spot

created branch time in a month

push eventcjerad/igor

spinnakerbot

commit sha c21bc384d204d827ae2c3c258ab2c12f1888ebc2

chore(dependencies): Autobump korkVersion (#830) Co-authored-by: root <root@50805f9a9c19>

view details

spinnakerbot

commit sha bd314624a3a11e6f7542ddd1a187456dc45e2ecd

chore(dependencies): Autobump korkVersion (#831) Co-authored-by: root <root@f429c082b070>

view details

spinnakerbot

commit sha 3a9c65a32fbbacc2205e2377c4dd993c3ead86ed

chore(dependencies): Autobump korkVersion (#832) Co-authored-by: root <root@12e6abdc8861>

view details

Michael Plump

commit sha 24ed5d4705c246d281cf60cc46f72e63afdac3bc

chore(dockerfile): various Dockerfile cleanups (#833) * chore(dockerfile): delete the (unused) java8 dockerfiles * chore(dockerfile): replace deprecated MAINTAINER with LABEL * chore(dockerfile): use gid/uid 10111 for the spinnaker user * chore(dockerfile): make docker builds more cacheable

view details

spinnakerbot

commit sha 34be8592f5547128afcb9664b823d12aa783cc15

chore(dependencies): Autobump spinnakerGradleVersion (#835) Co-authored-by: root <root@6a807b439d68>

view details

Sairam Rekapalli

commit sha f5b738fedddce00b6151776c6044f97e235af60d

fix(misc): Update jenkins client providers impls to use ok3 (#834) Co-authored-by: Adam Jordens <adam@jordens.org>

view details

Cameron Fieber

commit sha 92b4fc40847488eaa1cc8636e562dec6ff1279b2

chore(build): gradle 6.6 (#836)

view details

spinnakerbot

commit sha d2d216a52a0d4272f4c6f9cd21a0f3836c3911ee

chore(dependencies): Autobump korkVersion (#837) Co-authored-by: root <root@87c6cb8f1126>

view details

Chris Smalley

commit sha 41ef2a3c44b67202b26414fda05a5f32b05a0115

chore(*): Use SprintBootApplication annotation on Main class (#838) This annotation is useful as a way of consistently obtaining the Main class package in our services so we can determine package information, like version, at runtime.

view details

Kaixiang-AWS

commit sha babd23f0437e5582a1c4120ec2ee7679f5d4b35c

fix(codebuild): set region when creating sts client (#839) There's a race condition where default region could not be found, causing STS client failed to be created. To fix it, we set STS client region to what specified in the codebuild halyard config. Fixed https://github.com/spinnaker/spinnaker/issues/5974 Co-authored-by: Clare Liguori <liguori@amazon.com>

view details

spinnakerbot

commit sha e2ab4ab9ab0568e91c36a0825bd0bfeba9b1082d

chore(dependencies): Autobump korkVersion (#840) Co-authored-by: root <root@048626cb7ef2>

view details

spinnakerbot

commit sha 56db9262b9037008e02bf43eea10ece7c01ce245

chore(dependencies): Autobump korkVersion (#841) Co-authored-by: root <root@7cc2f7e2e8cd>

view details

spinnakerbot

commit sha 6ad7cf54dc7b3c1df4d88864608cda3d4479e3e4

chore(dependencies): Autobump korkVersion (#843) Co-authored-by: root <root@4bab6a330c11>

view details

spinnakerbot

commit sha c7dd78f3ee91de092d558f7825ac81f1b3ffa239

chore(dependencies): Autobump korkVersion (#845) Co-authored-by: root <root@534ce9888ac0>

view details

push time in a month

create barnchcjerad/gate

branch : ec2-spot

created branch time in a month

push eventcjerad/gate

spinnakerbot

commit sha 86eaa5b7cd97aa0b83bd46912948b8dc2dcabcc2

chore(dependencies): Autobump korkVersion (#1300) Co-authored-by: root <root@50805f9a9c19>

view details

spinnakerbot

commit sha cc6428df52f7360e444f4410655ff46b38011ac1

chore(dependencies): Autobump korkVersion (#1301) Co-authored-by: root <root@f429c082b070>

view details

spinnakerbot

commit sha 09576b31010b3bae6efd8187faa2561e5a112f4c

chore(dependencies): Autobump korkVersion (#1302) Co-authored-by: root <root@12e6abdc8861>

view details

Gal Yardeni

commit sha 0b5c9796a9de67966812c8ba3ac3052635401769

fix(artifactReference): add artifactReference field into ConstraintStatus model (#1303)

view details

Chris Thielen

commit sha 78e4350c0d5934f67a641613ec709dd733d348e2

feat(pipeline): populate 'staleCheck' in orca savePipeline task (#1298) Related to https://github.com/spinnaker/orca/pull/3841 Co-authored-by: spinnaker <spinnaker@netflix.net> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Michael Plump

commit sha 9fc9087c908fac23277873e19d2d0255e37b25f5

chore(dockerfile): various Dockerfile cleanups (#1304) * chore(dockerfile): delete the (unused) java8 dockerfiles * chore(dockerfile): replace deprecated MAINTAINER with LABEL * chore(dockerfile): use gid/uid 10111 for the spinnaker user * chore(dockerfile): make docker builds more cacheable

view details

Sairam Rekapalli

commit sha 794159c1d46b7ac7a1bb600be47f40638526ae96

fix(misc): Updates to use retrofit service provider impl. (#1293) * fix(misc): Updates to use retrofit service provider impl fix(misc): test config * fix(misc): Make kork-retrofit as runtime dep only * fix(misc): Make kork-retrofit as runtime dep only * fix(misc): Make kork-retrofit as runtime dep only * fix(misc): move to setter injection * fix(misc): Make kork-retrofit as runtime dep only * fix(misc): trying test autoconfig option to wire up dep * fix(misc): update auto config * fix(misc): add qualifier for bean * fix(misc): update dependencies * fix(misc): explicit depends on * fix(misc): add test logging * fix(misc): test config * fix(misc): test config * fix(misc): test config * fix(misc): test config * fix(misc): test config * fix(misc): test * fix(misc): add flag to dump auto config report * fix(misc): add flag to dump auto config report * fix(misc): fix config * fix(misc): fix config * fix(misc): fix config * fix(misc): test * fix(misc): test * fix(test): test fix * fix(misc): fix config Co-authored-by: Adam Jordens <adam@jordens.org>

view details

spinnakerbot

commit sha 99146d76b29713ab0c8085d883d79711eab86f58

chore(dependencies): Autobump spinnakerGradleVersion (#1306) Co-authored-by: root <root@6a807b439d68>

view details

Kevin Woo

commit sha e8e9b8cdc722e45e0f88e4349eafe7d67f72723e

fix(v2PipelineTemplates): set response code to 200 OK because of swagger (#1307) Swagger on 2.14.5 codegen for Go doesn't parse the body for a caller. The workaround for now is to return a 200 so swagger will return the body back to a calling method. This is documented in https://github.com/swagger-api/swagger-codegen/issues/10435

view details

Cameron Fieber

commit sha 537d8c44bc95df11361f51202b2c2430215829d9

chore(build): gradle 6.6 (#1308)

view details

Chinikins

commit sha b3ede47f022b0e410b8c92a20e784e3ec9048c58

fix(getAllPluginInfo): fix return type (#1310) Co-authored-by: chini mukhopadhyay <chini@cloudera.com>

view details

Sairam Rekapalli

commit sha ab06a31f6837f5525282f7198013731f1cd9043b

fix(misc): Upgrade to kotlin 1.4 to match with kork kotlin version (#1312) * fix(misc): Upgrade to kotlin 1.4 to match with kork kotlin version * fix(misc): Remove TomcatConfiguration properties reference

view details

spinnakerbot

commit sha c5c7f5640cd0874e3bfefa6ee47a2218c60b5e9a

chore(dependencies): Autobump korkVersion (#1309) Co-authored-by: root <root@4bab6a330c11> Co-authored-by: Sairam Rekapalli <srekapalli@netflix.com>

view details

Chris Berry

commit sha 986f976ee95939f3cd7076748db02c21b0956958

feat(kayenta): expose pagination param on reports endpoint (#1305)

view details

spinnakerbot

commit sha 2015636ae0fbc646b409cb5703cad4ed2180e4a4

chore(dependencies): Autobump korkVersion (#1314) Co-authored-by: root <root@534ce9888ac0>

view details

push time in a month

create barnchcjerad/front50

branch : ec2-spot

created branch time in a month

push eventcjerad/front50

spinnakerbot

commit sha b94dfd0c648f35f7f467de0974477f9223c67fa3

chore(dependencies): Autobump korkVersion (#918) Co-authored-by: root <root@50805f9a9c19>

view details

spinnakerbot

commit sha 24085beaf211917ed9a8242f7d021793b9679034

chore(dependencies): Autobump korkVersion (#919) Co-authored-by: root <root@f429c082b070>

view details

spinnakerbot

commit sha ac2e2a72cbc0b6e9a525947f6f926b1cff085ebd

chore(dependencies): Autobump korkVersion (#921) Co-authored-by: root <root@12e6abdc8861>

view details

Mark Vulfson

commit sha cca223dbce84277137c476e6754d93d8fb7019b1

fix(exceptions): Use kork's NotFoundException (#922) Follow up from https://github.com/spinnaker/kork/pull/737 where I added a generic 400 response exception handler for UserException. But `front50` needs to return an actual 404 (since callers, e.g. `orca` expect and handle it). Kork already has a generic 404 handler for NotFoundException

view details

Michael Plump

commit sha 73993268afab8db10af96fc24e330823a8217835

chore(dockerfile): various Dockerfile cleanups (#925) * chore(dockerfile): delete the (unused) java8 dockerfiles * chore(dockerfile): replace deprecated MAINTAINER with LABEL * chore(dockerfile): use gid/uid 10111 for the spinnaker user * chore(dockerfile): make docker builds more cacheable

view details

spinnakerbot

commit sha 9655c3caac24be8ea88ab843a10b5ecfef05a1ad

chore(dependencies): Autobump spinnakerGradleVersion (#926) Co-authored-by: root <root@6a807b439d68>

view details

Cameron Fieber

commit sha d07b4cb7aaa2d2b388b3051f0dfdf3a39ef3d592

chore(build): gradle 6.6 (#928)

view details

spinnakerbot

commit sha e64126ccc0de71bec4acfa659bdd35c727e95030

chore(dependencies): Autobump korkVersion (#929) Co-authored-by: root <root@87c6cb8f1126>

view details

spinnakerbot

commit sha fc9bbb18222edd43c58ccf6136819138d272941a

chore(dependencies): Autobump korkVersion (#931) Co-authored-by: root <root@048626cb7ef2>

view details

spinnakerbot

commit sha 622bf18768280efc9498408e71d6262caa33698e

chore(dependencies): Autobump korkVersion (#932) Co-authored-by: root <root@4bab6a330c11>

view details

spinnakerbot

commit sha 07849972407e2b50ab2d2e2575aa25c7397eefdc

chore(dependencies): Autobump korkVersion (#933) Co-authored-by: root <root@534ce9888ac0>

view details

Edgar Garcia

commit sha 20c631fcc352f0d66fbb7665b9827a61a36035bb

feat(gitRepoArtifact): include migration to move subpath to location field (#930) * feat(gitRepoArtifact): include migration to move subpath in metadata to location field only for git/repo artifacts. * refactor(gitRepoArtifact): clean tests syntax on where statement * refactor(gitRepoArtifact): include small methods to avoid code duplication * refactor(gitRepoArtifact): change Valid date

view details

push time in a month

push eventcjerad/fiat

spinnakerbot

commit sha 249c05c9acc91eefa116d1d2dd4cf3be8cd524e2

chore(dependencies): Autobump korkVersion (#742) Co-authored-by: root <root@50805f9a9c19>

view details

spinnakerbot

commit sha c90eb681980396ffb20f85a284ce84663f139097

chore(dependencies): Autobump korkVersion (#743) Co-authored-by: root <root@f429c082b070>

view details

spinnakerbot

commit sha 9442ea4a01efaef89a69a3b0e1457f047d7e989b

chore(dependencies): Autobump korkVersion (#744) Co-authored-by: root <root@12e6abdc8861>

view details

Michael Plump

commit sha a6eda9c86cbb26366d3fac20c1510955e8c86a90

chore(dockerfile): various Dockerfile cleanups (#745) * chore(dockerfile): delete the (unused) java8 dockerfiles * chore(dockerfile): replace deprecated MAINTAINER with LABEL * chore(dockerfile): use gid/uid 10111 for the spinnaker user * chore(dockerfile): make docker builds more cacheable

view details

spinnakerbot

commit sha 0057cc6ddc5c1a5c82a25805da041d6ae28e7dcd

chore(dependencies): Autobump spinnakerGradleVersion (#746) Co-authored-by: root <root@6a807b439d68>

view details

Cameron Fieber

commit sha 0e4b470f7eda2c980c7c282989a6683634236377

chore(build): gradle 6.6 (#748)

view details

spinnakerbot

commit sha d0c756f6d5023c11a99bd2c9b0bbb79a9a63cdb4

chore(dependencies): Autobump korkVersion (#749) Co-authored-by: root <root@87c6cb8f1126>

view details

Cameron Fieber

commit sha 0ac386fe08523ad7898c61599c43ffab8054721a

fix(authorize): fixes for authorize redis and fallback (#750) does less work while holding a redis connection: * ensure when looking up the unrestricted user, that we don't read the same values twice from redis * close the redis connection before deserializing permission objects ensures that if we hit the fallback case for a user that was not resolved we include the unrestricted user's permissions in the resulting UserPermission * fix(roles): do less while holding a redis connection moves deserialization of permission json outside of the connection callback short circuits lookup of roles if the user does not exist (prevents loading all of anonymous for an unknown userid) * fix(redis): don't duplicate resource reads when looking up unrestricted user saves on reading the same maps twice on an explicit call to load the unrestricted user, which happens if we hit a fallback for a user that we currently have not resolved * fix(fallback): ensure fallback permissions include unrestricted user permissions if we hit the fallback case of triggering permission resolution, the permissions for the unrestricted user should be included to allow access to resources that are granted to the anonymous role

view details

spinnakerbot

commit sha 9f2697137cb834c9f157454465f4ca6348a17a7d

chore(dependencies): Autobump korkVersion (#752) Co-authored-by: root <root@048626cb7ef2>

view details

spinnakerbot

commit sha fbca7292a1e4d3d31d1321d8eaf6c948e3ebbecc

chore(dependencies): Autobump korkVersion (#753) Co-authored-by: root <root@7cc2f7e2e8cd>

view details

spinnakerbot

commit sha 969d95f3893c1b4dab1b6dc5b9547c893db61b0c

chore(dependencies): Autobump korkVersion (#754) Co-authored-by: root <root@4bab6a330c11>

view details

spinnakerbot

commit sha edea93297fc397897cabd9c0a1db42239e34c961

chore(dependencies): Autobump korkVersion (#756) Co-authored-by: root <root@534ce9888ac0>

view details

Cameron Fieber

commit sha 61f1e3640ceb2a995b55e619ec4d82bb021b2e82

feat(perf): cache the unrestricted users permissions (#751) The unrestricted user is loaded from redis each time a lookup for a user happens, and this user may end up with a lot of data associated with it if there are a large number of secured entities set up for anonymous read access. This saves the step of fetching and deserializing that data if there is a copy cached. Adds a new last modified key to track (via redis server time) the last time the unrestricted user was written to redis, and uses that to ensure a reload happens when the permissions are rebuilt.

view details

push time in a month

create barnchcjerad/fiat

branch : ec2-spot

created branch time in a month

create barnchcjerad/echo

branch : ec2-spot

created branch time in a month

push eventcjerad/echo

spinnakerbot

commit sha c295a4818b8862f3582ae7262eaafe487132e5fe

chore(dependencies): Autobump korkVersion (#989) Co-authored-by: root <root@50805f9a9c19>

view details

spinnakerbot

commit sha 6fc884bf8ee193ae67085faf71d7ff12b51a316a

chore(dependencies): Autobump korkVersion (#990) Co-authored-by: root <root@f429c082b070>

view details

spinnakerbot

commit sha ee48a0d79275c82beb46ef44514673b4d969d64b

chore(dependencies): Autobump korkVersion (#991) Co-authored-by: root <root@12e6abdc8861>

view details

KeisukeYamashita

commit sha ac99c3b25cd1f3765c062b910744e31b36bd6390

chore(gcb): unify log message of subscriber (#992) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Michael Plump

commit sha 5763f3e58661fcddc7d9a1432afac2d581fbae7d

chore(dockerfile): various Dockerfile cleanups (#993) * chore(dockerfile): delete the (unused) java8 dockerfiles * chore(dockerfile): replace deprecated MAINTAINER with LABEL * chore(dockerfile): use gid/uid 10111 for the spinnaker user * chore(dockerfile): make docker builds more cacheable Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

spinnakerbot

commit sha 62127327e4fef43a0516e8b9a134314eb18c1d6d

chore(dependencies): Autobump spinnakerGradleVersion (#994) Co-authored-by: root <root@6a807b439d68>

view details

Cameron Fieber

commit sha b51fb4ce6c941d05a97263aef1c3d19affd03a88

chore(build): gradle 6.6 (#996)

view details

Sairam Rekapalli

commit sha 5071645b407aa95b6ad2800b236afea07c5c1510

fix(misc): Upgraded kotlin version to match kork (#998)

view details

spinnakerbot

commit sha d53047067bb241939f0920bba83922fb3e10179a

chore(dependencies): Autobump korkVersion (#997) Co-authored-by: root <root@4bab6a330c11> Co-authored-by: Sairam Rekapalli <srekapalli@netflix.com>

view details

spinnakerbot

commit sha e069b8b72e34c1e52bc5013e998dfea1d69d1212

chore(dependencies): Autobump korkVersion (#999) Co-authored-by: root <root@534ce9888ac0>

view details

push time in a month

push eventcjerad/deck

Vignesh Murugesan

commit sha c956d541429f107a4d5069a7b63e0b0f26dd3590

fix(core/application): Handle edits to cloud provider in application config links

view details

Chris Thielen

commit sha e8d1ff843841e325dcccd0faf853a58edea92366

chore(package): publish amazon 0.0.262 core 0.0.499 (#8476)

view details

micnncim

commit sha 972e85d2af84f2d1dc2a8c98a64e609523ef96e9

config(auth): update default value of authEnabled (#8441) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Takaaki Nakama

commit sha 3f279bc4a3a88e126098d817aa1e2cc865fb2cf2

feat(gce): Add GCP internal http(s) load balancer. (#8397) * fix(provider/google): add internal http(s) load balancer. (#5042) * fix(provider/gce): Fix Internal HTTP LB implementations. * fix(provider/gce): convert Internal HTTP LB impl to ts * chore(gce): refactor internal http lb Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

caseyhebebrand

commit sha 5048c833ecd55f447c2202a6183485536ed5a7ed

fix(core/nav): Active nav category for hyperlinks (#8469) * fix(core/nav): Active nav category for hyperlinks * Switch to useSref

view details

Erik Munson

commit sha 256904734e3e939e9f8026a781c913252599f790

chore(deps): bump @spinnaker/styleguide from 1.0.20 to 1.0.21 (#8477)

view details

Vignesh Murugesan

commit sha 138ef6d641bb71c5369460bb3b378a13a7e90939

fix(docker/tag): Make help content explicit for tag field by placing it below the field.

view details

Kevin Woo

commit sha 7a15f5d795f7ee12d7bef470e37379baa6ce08be

fix(functions): normalizeFunction expects a Promise (#8468) https://github.com/spinnaker/deck/commit/72af6cc495cf9f82634f62631bba1f7b6e148eb7 introduced a bug when refactoring that calling `normalizeFunction` always returned a Promise. When it was removed, some calls to `normalizeFunction` may return plain objects that aren't wrapped in a Promise. Fix: wrap the return value with a `$q` to satisfy `IPromise`

view details

Erik Munson

commit sha 3d5d149c3070fc93b7b6a85ab31f1963af535a49

feat(core/managed): new visual iteration for version sidebar, 'decommissioned' cards (#8478) * feat(core/managed): add environment names, new visual treatment to version sidebar * feat(core/managed): add 'archived' status appearance, use in cards Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Erik Munson

commit sha 83b01d123371c6fb1c62d2c4c306b7883d11d4b0

feat(core/managed): new visual treatment for environment badges (#8479) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Erik Munson

commit sha 84377118d005024e6c6c0b542940fd958a59a4b6

chore(package): publish core 0.0.500 docker 0.0.58 google 0.0.17 (#8482)

view details

Luis Pollo

commit sha 621097687e758e38251d5af70e1ef9be23579a57

Replace the word "previous" with "prerequisite" in depends-on constraint text (#8483)

view details

Erik Munson

commit sha 63e31d3ce744aa19907243d27a61f58ae4aef5f4

fix(core/managed): supply references when updating constraints (#8485) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Maggie Neterval

commit sha b88e0deffdff6668cb5785037964f82e197dad52

fix(kubernetes): add nullable createdTime to base resource interface (#8486) Each resource template tries to read this field. Requires: https://github.com/spinnaker/clouddriver/pull/4791

view details

Maggie Neterval

commit sha 6a2fe671da0f65dda86a08299bfdd323a3487d00

fix(kubernetes): do not self-close element in angular template (#8487) Closes: https://github.com/spinnaker/spinnaker/issues/5962 Oddly, the `kubernetes-rolling-restart` component was rendering as expected, but each of the remaining elements in the list of actions (Edit and Delete) were not. Self-closing tags are not allowed in Angular templates, so I likely broke this when I added support for rolling restarts. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Erik Munson

commit sha c026603a590fee1234a79543fd0c8704373ac330

chore(package): publish core 0.0.501 kubernetes 0.0.46 (#8489)

view details

Vignesh Murugesan

commit sha 73805f2f25abad4d0371d70d74897c1d4ce1cd2d

fix(core/widgets): Remove CustomDropdown widget

view details

Maggie Neterval

commit sha 2c5a727ece1fe6f07928a5b727aa3900be74666d

fix(google): do not self-close react2Angular-created elements (#8493)

view details

Michael Plump

commit sha a6f9bc07d8c2fa8ed6bd31578cdbc8be07ebc380

chore(dockerfile): replace deprecated MAINTAINER with LABEL (#8494)

view details

Maggie Neterval

commit sha 0be2a84d5d732bd6170728bdebe4b3a2e87c1b1a

feat(google): add predictive autoscaling support (#8495) * feat(google): add feature flag for predictive autoscaling * refactor(google): move autoscaling policy interfaces and layout components to autoscalingPolicy directory Currently, the only Typescript/React components of the autoscaling policy modal are specific to the scale-in control feature. In the next commit, we will add support for predictive autoscaling, so in order to share these interfaces and layout components, lift them to the top level. * feat(google): add predictive autoscaling support (add/edit policy modal) * feat(google): add predictive autoscaling support (SG details view) * fix(google): sp/scaleDownInConfigured/scaleInControlsConfigured I think we missed one spot when we renamed scale-in to scale-down. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

push time in a month

create barnchcjerad/deck

branch : ec2-spot

created branch time in a month

push eventcjerad/clouddriver

spinnakerbot

commit sha fb00651f65166b5666c117dc37ffb093abd061e0

chore(dependencies): Autobump korkVersion (#4774) Co-authored-by: root <root@50805f9a9c19>

view details

spinnakerbot

commit sha 2374188cdabfacdcd9d9af59afd9f02b922e5d40

chore(dependencies): Autobump korkVersion (#4775) Co-authored-by: root <root@f429c082b070>

view details

Takaaki Nakama

commit sha a34b9510eee3ced83965723838b89c80e6a3af31

feat(gce): Add GCP internal http(s) load balancer. (#4725) * fix(provider/google): add internal http(s) load balancer. (#5042) * fix(provider/gce): Fix Internal HTTP LB implementations to use java. * fix(provider/gce): Fix internal http lb cannot be deployed with other global lbs * fix(provider/gce): Fix referencing not existing property * chore(gce): no use ProviderVersion * chore(gce): null check in common place * chore(gce): set subnet purpose default value n/a * chore(gce): refactor internal http lb Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Eric Zimanyi

commit sha 1d28568f202d51bf157cfb05da9d4871fcc94bdb

refactor(kubernetes): Further simplifications of cache data logic (#4776) * refactor(kubernetes): Remove needless ObjectMapper The object is already of the correct type. Also inline declaration/ assignment above so it's easier to see this. * refactor(kubernetes): Clean up convertAsArtifact convertAsArtifact is doing a lot of null checks on things that can't be null. If the artifact is present, it's guaranteed to have a non-null type; likewise the getCreationTimestamp never returns null. Remove these checks, inline some variables, and move to an .ifPresent to greatly simplify the function. Finally, we were storing a relationship between the infrastructure item and the artifact; we don't need or use these relationships at all and treat these two areas of the cache separately. It's better for performance on cache writes/reads, as well as simplifies the code, if we remove these relationships. This means we don't need to return the key from convertAsArtifact, or use it to add a relationship in the calling code. * refactor(kubernetes): Pull convertAsArtifact out of convertAsResource Now that convertAsArtifact and convertAsResource are not dependent on each other (because they don't store reource-artifact relationships) it's clearer if we pull convertAsArtifact up a level rather than have it be inside of convertAsResource. Also update catching an Exception to catching a RuntimeException. * refactor(kubernetes): Clean up null checks in RegistryUtils lookupHandler is really a simple function but is 15 lines long to account for unnecessary null checks. None of the callers ever pass a null kind (as they use KubernetesManifest.getKind which never returns a null). Likewise, then KubernetesResourceProperties in practice can never have a null handler; let's just enforce that at creation and add the annotation. Now that we don't need all these null checks, just directly look up the handler where needed instaed of calling lookupHandler. * refactor(kubernetes): Remove RegistryUtils These two functions are just looking properties up on an object; inline them where they are used so we can delete another static utils class. * refactor(kubernetes): Move filtering logic to stream Instead of exiting early from convertAsResource, just move the filtering logic to the stream where it's called as it's clearer there. Also update KubernetesCachingProperties to be immutable and only have the API that we actually use. Finally, remove setting the application we got from the KubernetesCachingProperties as an attribute in the cache. We don't use this in any case, and in cases where we do want the applciation, we should use the one on the moniker that we persist in the cache data. * refactor(kubernetes): Clean up some logging We check a few things on a manifest before caching and log a warning; it's not clear that this is really useful. The check that it's not null is always false; the check for name/namespace I guess could help with debugging, but we're really just checking that Kubernetes is returning a valid manifest, which seems not that useful. At points where we actually use these, I guess we could log/fail if they are missing, but I've never found a use for this log message in all my time debugging Kubernetes bugs. Similarly, logging every non-Spinnaker-owned manifest does not seem useful; there is a flag to decide if you want to cache these or not. If you have the flag on you want these cached, if not, you don't reach this log statement. * refactor(kubernetes): Use Moniker from CacheData instead of re-computing As a first step towards using the data we cache instead of re-computing things, let's use the Moniker that we store on the CacheData. We always store this, but are currently throwing it away and re-computing it. For now I'm just adding Moniker to the constructor, though my eventual plan (once we build everything from the CacheData) will be to pass in a strongly-typed CacheData object rather than greatly increase the number of constructor parameters. * refactor(kubernetes): Use a Kubernetes-specific namer registry We currently use a reasonably complex NamerRegistry to handle two things: (1) Keeping track of any NamingStrategy components on the classpath and returning them by name when we call namerRegistry.getNamingStrategy. (This happens when we construct Kubernetes credentials and have a string representing the naming strategy.) (2) Given an account name, asking for the naming strategy for that account. In both cases, it's overly complicated that we have general logic for all providers and this logic is not type-safe. For example getNamingStrategy returns a raw Namer, so we have to hope that is a Namer<KubernetesManifest>, and hope is not a naming strategy. Likewise, every time we need to look up the namer for an account, we need to query a global registry across all providers (but first tell it that we want a namer for a Kubernetes account, the name of the account, and that we want to name KubernetesManifest.) While this looks somewhat typesafe, it turns out that the only reason we pass KubernetesManifest.class to these calls is so that withResource can cast the result for us (so we don't need to), so we are only getting the illusion of safety. Let's instead: (1) Make a KubernetesNamerRegistry that keeps track of any registered NamingStrategy<KubernetesManifest> and return them by name (while guaranteeing typing). (2) Once we get the namer, just store it on the credentials object like we do for other things, instead of relying on a global registry. I don't like having more and more things on the credentials object, but I still think this is better than global state which is the current state. Also, by having these things all in one place on the object we can start to see patterns and refactor them into better classes. We now no longer use the general NamerRegistry at all in the Kubernetes provider; other providers still use it, though they may also want to just implement their own like this. * refactor(kubernetes): Make KubernetesManifestNamer immutable Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Eric Zimanyi

commit sha 22feb2a866f96606ebe19be61369bd7a4a155eb6

fix(test): Fix intermittent timeout in PooledRequestQueueTest (#4777) I fixed a deadlock in this test a few weeks ago, but just ran into one other timeout. This commit makes a few minor fixes to reduce the chances of hitting a timeout here. First: (1) Use a fixed thread pool executor so we create all the threads we need up front and reduce the work later. (2) Don't start our timeout clock until the job we're expecting to timeout has been queued. (3) Increase the startup timeout to 50 ms and only time out the test after 10x (instead of 5x); this is just so we're dealing with slightly larger absolute numbers. (Before we were only waiting 100 ms to time out the test, now we're waiting 500ms.) (4) Fail with a specific message if we timeout, rather than assert on the status of the job (which we know won't be in the expected state because we killed it). This just helps debugging as I was confused at first what happened. I think this only happens if you are running the clouddriver tests locally with your editor open while on a video call, but hopefully with these fixes the tests pass even in that case.

view details

Jason Coffman

commit sha 80d81bee5ccc277d793346d34700ea55df024613

fix(lambda): Fixes create lambda from failing when DLQ is not provided (#4779)

view details

Kevin Woo

commit sha 7166916a1adca4d3ad81e65a9314fcebab91e997

chore(build): removed UTF8 "smart quotes" (#4780)

view details

Kevin Woo

commit sha 74c8f639f9899f23e61a6c6dafdafdee5aa5cf4b

fix(test): reverts (#4777) Fix intermittent timeout in PooledRequestQueueTest (#4781) This reverts commit 22feb2a866f96606ebe19be61369bd7a4a155eb6.

view details

Kevin Woo

commit sha a1e4448da8ac652db73157685ebebbe16e8fae2f

chore(build): bump up gradle memory max to 7gb (#4782)

view details

spinnakerbot

commit sha e4bb29e19cdb72f10c9b3a5bbea4c878959a8eaf

chore(dependencies): Autobump korkVersion (#4783) Co-authored-by: root <root@12e6abdc8861>

view details

Eric Zimanyi

commit sha f5f31de4b214eadb8791508eb31b732ab53b27bb

perf(kubernetes): Always do a live lookup for getManifest (#4778) * refactor(kubernetes): Inline defaultCacheData This is a tiny function used in one place; it's clearer to just have the logic inline rather than pass so many parameters. Also the calling function never accepts nor returns nulls; annotate it as such. * refactor(kubernetes): Clean up null safety in resource relationships implicitRelationships and ownerReferenceRelationships now no longer accept any null parameters, and can remove their null-checking logic. This also finally makes all the parameters to convertAsResource non-null so we can just annotate with as such. * refactor(kubernetes): Clean up type-safety/null-safety in job provider The manifest providers should be ManifestProvider<KubernetesV2Manifest> so that we don't need to cast the result to a KubernetesV2Manifest. Also getKubernetesJob should return an Optional as it sometimes returns null; the calling functions have interface contracts so need to return null but let's annotate them as nullable. * perf(kubernetes): Only load metrics if events are requested For performance reasons we have the includeEvents flag in the getManifest function because in most cases we don't need events. We only need events when loading a manfiest from deck so that we can populate them in the UI. The same is true for metrics. We don't need metrics when checking on the status of a deployed manifest, only when loading the UI tab for the manifest. Rather than add another flag, let's just consider metrics to be events and only load them when we've requested events. * perf(kubernetes): Always do a live lookup for getManifest Many users managing large Kubernetes deployments with Spinnaker use the liveManifestCalls flag because it allows deployments to complete without waiting for a cache refresh cycle. The initial plan to remove this flag (and revert to using the cache always) was discussed at the Kubernetes SIG and users did not want to lose this functionality. In order to simplify the code and reduce the configuration necessary to get a working, scalable deployment, let's make this the default given that it has proven itself with many large users. This commit replaces the two kubernetes manifest providers with a single one; it always does a live lookup for getManifest() and always uses the cache for getClusterAndSortAscending (which was always the case for users of liveManifestCalls because this was never implemented in the live provider). This will not immediately speed up deploys for users using liveManifestCalls because we will still block on force cache refresh. We need to do this because there are bugs downstream (ie, with disabling/deleting older server groups) if the cache is not up to date. The next step will be to fix this cache refresh strategy and remove the force cache refresh stage in all cases. * refactor(kubernetes): Remove fromCacheData We're always passing includeEvents=false now; when we remove all the logic that was gated by this flag, it simplifies down to a single line so let's just inline it. * refactor(kubernetes): Delete metric caching agent Now that we only ever do live lookups of metrics in the rare cases where we need them (when someone has the infrastructure tab open to a pod) we don't need to metrics caching agent; delete it and the code supporting it.

view details

Nicolas Cohen

commit sha b53ac1d819eaddbbec6344aa65d2f1e4fca5e525

fix(kubernetes): check existing versions in the account we are deploying to (#4785) This fixes #5964 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Eric Zimanyi

commit sha f56deb5a16f702b94a23ca1d15e42c0d8b3ed1cf

fix(test): Fix intermittent timeout in PooledRequestQueueTest (#4784) This was reverted in 74c8f639f9899f23e61a6c6dafdafdee5aa5cf4b but did not end up being the cause of the issue being investigated; re-applying. I fixed a deadlock in this test a few weeks ago, but just ran into one other timeout. This commit makes a few minor fixes to reduce the chances of hitting a timeout here. First: (1) Use a fixed thread pool executor so we create all the threads we need up front and reduce the work later. (2) Don't start our timeout clock until the job we're expecting to timeout has been queued. (3) Increase the startup timeout to 50 ms and only time out the test after 10x (instead of 5x); this is just so we're dealing with slightly larger absolute numbers. (Before we were only waiting 100 ms to time out the test, now we're waiting 500ms.) (4) Fail with a specific message if we timeout, rather than assert on the status of the job (which we know won't be in the expected state because we killed it). This just helps debugging as I was confused at first what happened. I think this only happens if you are running the clouddriver tests locally with your editor open while on a video call, but hopefully with these fixes the tests pass even in that case. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Chris Smalley

commit sha a932950fe046d3ca0a80a9899475c2d071d8c00a

fix(saga): Disable retrying INVALID_ARGUMENT on rate exceeded error (#4786)

view details

Eric Zimanyi

commit sha 292d43e08c40d72ef41fba67052043bdbc871de3

fix(build): Reduce Xmx and Xms (#4788) Our container builds run on a machine with only 7.2 GB of memory; while we do want to give a lot to the JVM we should leave a bit more for the everything else. I was able to succesfully build the containers with these settings, so let's use them.

view details

Eric Zimanyi

commit sha 97d7e519ea4c8cf219027f4161e1e132ab600232

fix(google): Fix assertion error on unknown target proxy (#4789) * fix(google): Fix assertion error on unknown target proxy Our code to parse the target proxy type from a URL is overly strict and throws an IllegalArgumentException if it encounter something it doesn't recognize. While I suppose that it might be helpful for us to know if there are different types of proxies we don't support encountered, this is very disruptive to users who might have these in their deployments as we just fail. In nearly all cases, we are just checking if the result of getTargetProxyType is a particular type. This logic will still work if we just return an UNKNOWN type if we don't recognize the target proxy type, so let's do that instead. * fix(google): Changes to last commit I forgot to push a few changes before opening the pull request.

view details

Maggie Neterval

commit sha 07d719dece9c781db8b70fb9a254028155f0b481

refactor(kubernetes): remove NoopManifestProvider (#4790) * refactor(kubernetes): remove NoopManifestProvider We are never actually wiring a NoopManifestProvider, since the KubernetesV2ManifestProvider is now always wired and ManifestProvider is now kubernetes-specific. * refactor(kubernetes): simplify KubernetesManifestProvider callers Now that there is only one ManifestProvider implementation, remove the interface and have callers wire KubernetesManifestProvider directly. * refactor(kubernetes): rename KubernetesV2ManifestProvider to KubernetesManifestProvider * fix(kubernetes): mark KubernetesManifestProvider.getManifest @Nullable Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Maggie Neterval

commit sha 68748e15ec999e76388646952a0c201a85737ce4

fix(kubernetes): replace getCreatedTime in KubernetesResource interface (#4791) We [removed](https://github.com/spinnaker/clouddriver/pull/4769) getCreatedTime from the shared interface extended by Kubernetes resource types and pushed it down to KubernetesServerGroup only, but it turns out that Deck expects all resources to have this field. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

Michael Plump

commit sha 7fa9cd6502eb2cfe416d571353305c18272fe618

chore(dockerfile): various Dockerfile cleanups (#4795) * chore(dockerfile): delete the (unused) java8 dockerfiles * chore(dockerfile): replace deprecated MAINTAINER with LABEL * chore(dockerfile): use gid/uid 10111 for the spinnaker user * chore(dockerfile): make docker builds more cacheable

view details

Michael Plump

commit sha 4bb5eeca25dbf028791ec7fd7d969345212f8305

feat(gce): add support for the predictive autoscaler (#4794) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

view details

push time in a month

create barnchcjerad/clouddriver

branch : ec2-spot

created branch time in a month

push eventcjerad/aws-node-termination-handler

Jerad C

commit sha a91b0e788596ceb43b8a1893573ae9c899250fdb

add missing helm chart properties (#220) (#222)

view details

Thomas O'Neill

commit sha 95fdc025df8f92b725f988869854917d961cc14b

Fix Helm chart comment on enableSpotInterruptionDraining default behavior (#221) * default enableSpotInterruptionDraining to true * enableSpotInterruptionDraining default to "true" * Update README for helm chart, and roll back value change Co-authored-by: Thomas O'Neill <toneill@new-innov.com>

view details

Prathibha Datta Kumar

commit sha 1943f8bce4f9a1ef73a52c8973712aac1e1c3462

fix missing new line for updateStrategy (#227)

view details

Prathibha Datta Kumar

commit sha 292e4af3844abae869fb95bcd8f37255dfbf5286

updating default updateStrategy and bumping version for helm chart release (#228)

view details

Bryan™

commit sha ca45b8f8274c25be8c5180e51efdea4b52e7e847

fix manifest updating in push-docker-images (#231)

view details

Brandon Wagner

commit sha 3e355f41607f887a3ebc7e39d38137cfb193c6eb

Add Amazon EC2 Spot Instances Integration Roadmap to readme (#232)

view details

Brandon Wagner

commit sha e48c1f8b965f7e608688fb59a555f87203bd1326

upgrade to go 1.15 (#233) * upgrade to go 1.15 * remove duplicate linker flags * remove -s linker flag from windows

view details

Paulo Martins

commit sha c685bbaf7a614305bed5e33f4aed867e15a041b3

fix identation on PodMonitor (#235)

view details

Brandon Wagner

commit sha 021b71f48a2500e54def0d04dbd59046cc086bd0

Helm Template Gen Test (#236) * add helm test to check template generation * sync enableSpotInterruption usage statement

view details

Bryan™

commit sha 97f42ef9f6c656f84ccfda982be4da4fa3529e3b

Update .travis.yml go1.15 (#238)

view details

Brandon Wagner

commit sha 713db7c6b117e638500984cbe6ab26b74783b6a2

up helm chart to use v1.7.0 image (#234)

view details

Brandon Wagner

commit sha 3fa790071c86c17ad6fbb35910f982dea3072dcf

retry aemm installs (#237)

view details

Brandon Wagner

commit sha f92ed02c5a6eb7681582b8858574c9a5853d9e90

fix release script upload to github (#240)

view details

Brandon Wagner

commit sha ef0eec0e9f4cd69f873cf1fc21744ea20e799552

only build one binary to check licenses (#239)

view details

Brandon Wagner

commit sha e5705ffd6fed89b277990bf349327f09eaadc790

clear up shellcheck warnings (#242) * clear up shellcheck warnings * changes based on PR feedback * missed some spots

view details

Brandon Wagner

commit sha 24ff89c46173c56e14ed37eb26b9525bb9194e6c

fix helm test (#243)

view details

push time in a month

push eventaws/aws-node-termination-handler

Prathibha Datta Kumar

commit sha 1943f8bce4f9a1ef73a52c8973712aac1e1c3462

fix missing new line for updateStrategy (#227)

view details

push time in a month

PR merged aws/aws-node-termination-handler

fix missing new line for updateStrategy

Issue #, if available: https://github.com/aws/aws-node-termination-handler/issues/226

Description of changes: fix missing new line for updateStrategy

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+4 -4

1 comment

2 changed files

pdk27

pr closed time in a month

fork cjerad/halyard

A tool for configuring, installing, and updating Spinnaker

fork in 2 months

fork cjerad/kayenta

Automated Canary Service

fork in 2 months

fork cjerad/fiat

Spinnaker auth service

fork in 2 months

fork cjerad/echo

Spinnaker Eventing Service

fork in 2 months

fork cjerad/igor

Integration with Jenkins and Git for Spinnaker

fork in 2 months

fork cjerad/rosco

A bakery for deployable images

fork in 2 months

fork cjerad/front50

Spinnaker Metadata Repository Service

fork in 2 months

fork cjerad/clouddriver

read and write operations across cloud providers

fork in 2 months

fork cjerad/orca

orchestration engine

fork in 2 months

fork cjerad/gate

Spinnaker API Gateway

fork in 2 months

fork cjerad/deck

Management UI for Spinnaker

fork in 2 months

delete branch cjerad/aws-node-termination-handler

delete branch : issue-220

delete time in 2 months

PR opened aws/aws-node-termination-handler

add missing helm chart properties (#220)

Issue #220

Description Add properties referenced in Helm chart templates to values.yaml.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+22 -2

0 comment

2 changed files

pr created time in 2 months

create barnchcjerad/aws-node-termination-handler

branch : issue-220

created branch time in 2 months

issue openedaws/aws-node-termination-handler

Error after upgrading from 0.8.0 to 0.9.2

I'm getting the following error since upgrading from 0.8.0 to 0.9.2. Seems potentially related to this PR. I have not set that value.

Error: Failed to render chart: exit status 1: Error: template: aws-node-termination-handler/templates/daemonset.linux.yaml:28:85: executing "aws-node-termination-handler/templates/daemonset.linux.yaml" at <.Values.linuxPodAnnotations>: wrong type for value; expected map[string]interface {}; got interface {}

Originally posted by @yurrriq in https://github.com/aws/aws-node-termination-handler/pull/185#issuecomment-668372538

created time in 2 months

push eventcjerad/aws-node-termination-handler

Jerad C

commit sha d0610b4ced66c0fe431a03d2e51a9d77f924841c

Fix log output on e2e tests when a failure occurs (#163) (#212) * fix NTH log output on failure in local suite * add NTH log output on failure to EKS suite * remove trailing whitespace

view details

Brandon Wagner

commit sha af1722728d918e25100a9d3786afd121f461cf27

cleanup webhook secret after each test run (#213)

view details

Brandon Wagner

commit sha 8bf43a9fd02c5531db405fbaef62eb9678460881

webhook-http-proxy-test: print squid logs on failure and improve access log grep (#214)

view details

Brandon Wagner

commit sha 4a740f7b75aa50a429d12fe092f501c59238b3ef

squid fixes for webhook-http-proxy-test (#216) * squid fixes for webhook-http-proxy-test * moved squid pod lookup to a function

view details

Bryan™

commit sha b52d4675a716bb4150033ad3e8f0488def39a825

AEMM & Windows integrations (#215) * update aemm in e2e tests to support targetNodeOs; bumping aemm version * updating scripts+travis to support Windows deployments * bump AEMM version * update Windows version * fix push-docker-images logic to populate manifest correctly * addressing pr comments

view details

Bryan™

commit sha e68df3460c92a4db705c37319108989585b07e62

add readme for e2e tests (#218)

view details

Brandon Wagner

commit sha bad975d59e330b8af966b087f23cbf8c5692ecbb

only deploy to worker node on e2e tests (#217) * only deploy to worker node on e2e tests * fix webhook tests without using host networking * fix webhook port consistency * print gomod download logs

view details

Brandon Wagner

commit sha 91b481abceb22816019b3953ec970ae16f31877a

fix webhook test stability (#219)

view details

push time in 2 months

delete branch cjerad/aws-node-termination-handler

delete branch : issue-163

delete time in 2 months

push eventaws/aws-node-termination-handler

Bryan™

commit sha b52d4675a716bb4150033ad3e8f0488def39a825

AEMM & Windows integrations (#215) * update aemm in e2e tests to support targetNodeOs; bumping aemm version * updating scripts+travis to support Windows deployments * bump AEMM version * update Windows version * fix push-docker-images logic to populate manifest correctly * addressing pr comments

view details

push time in 2 months

PR merged aws/aws-node-termination-handler

AEMM & Windows integrations

Issue #, if available: N/A

Description of changes:

  • Using AEMM 1.2.0
  • Changing Windows 10 version to 1809
  • Updated Makefile and Travis for Windows builds+deployments
  • Corrected Dockerfile.windows for webhook-test-proxy
  • Updated push-docker-images and upload-resources-to-github scripts with the latest from AEMM
    • adding binaries-only option to upload-to-github is NTH-specific

Testing:

  • ran eks-cluster-test for Linux and Windows on muh machine

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+210 -51

1 comment

21 changed files

brycahta

pr closed time in 2 months

Pull request review commentaws/aws-node-termination-handler

squid fixes for webhook-http-proxy-test

 for i in `seq 1 $TAINT_CHECK_CYCLES`; do   if [[ $evicted -eq 1 && $sent -eq 0 ]] && kubectl logs $pod_id -n kube-system | grep 'Webhook Success' >/dev/null; then     echo "✅ Verified that webhook successfully sent"     sent=1-    squid_worker_pods=$(kubectl get pods -o json | jq '.items[] | select( .metadata.name | contains("squid") ) | .metadata.name as $name | select( .spec.nodeName | contains("worker") ) | .spec.nodeName as $nodename | $name' -r)   fi -  if [[ $sent -eq 1 ]] && kubectl exec -it $(echo $squid_worker_pods | cut -d' ' -f1) -- cat /var/log/squid/access.log | grep "${WEBHOOK_URL}" >/dev/null; then+  webhook_hostname=$(echo "${WEBHOOK_URL}" |sed -e 's|^[^/]*//||' -e 's|/.*$||')

This is super complain-y, but the use of the pipe character in the sub-shell and the sed expressions is kinda hard to read.

  webhook_hostname=$(echo "${WEBHOOK_URL}" | sed -e 's@^[^/]*//@@' -e 's@/.*$@@')
bwagner5

comment created time in 2 months

Pull request review commentaws/aws-node-termination-handler

squid fixes for webhook-http-proxy-test

 if [[ $deployed -eq 0 ]]; then     fail_end_exit 2 fi +## Squid can take a while to start, try to get a squid worker pod, if not, hope for the best when assertions are checked+squid_worker_pods=""+for i in `seq 1 10`; do+  echo "Checking if squid http-proxy has started..."+  squid_worker_pods=$(kubectl get pods -o json | jq '.items[] | select( .metadata.name | contains("squid") ) | .metadata.name as $name | select( .spec.nodeName | contains("worker") ) | .spec.nodeName as $nodename | $name' -r || :)

Minor: could that command be put in a function?

bwagner5

comment created time in 2 months

Pull request review commentaws/aws-node-termination-handler

AEMM & Windows integrations

 jobs:       name: Go Report Card Test     - stage: Test       script: make build-binaries-      name: Build Binaries+      name: Build Binaries Linux+    - stage: Test+      name: Build Binaries Windows+      os: windows+      install: choco install make && choco install zip

Is there a benefit to using two commands?

      install: choco install make zip
brycahta

comment created time in 2 months

Pull request review commentaws/aws-node-termination-handler

AEMM & Windows integrations

 if [[ ${#PLATFORMS[@]} -gt 1 && $MANIFEST != "true" ]]; then     exit 1 fi +# Existing manifests cannot be updated only overwritten; therefore,+# if manifest exists already, fetch existing platforms so "updated" manifest includes images+# that were there previously+if [[ $MANIFEST == "true" ]]; then+  manifest_exists=$(docker manifest inspect $IMAGE_REPO:$VERSION > /dev/null ; echo $?)+  if [[ manifest_exists -eq 0 ]]; then

Missing variable expansion.

  if [[ $manifest_exists -eq 0 ]]; then
brycahta

comment created time in 2 months

Pull request review commentaws/aws-node-termination-handler

AEMM & Windows integrations

 #!/bin/bash set -euo pipefail +# Script to upload release assets to Github.+# This script cleans up after itself in cases of parital failures. i.e. either all assets are uploaded or none+ SCRIPTPATH="$( cd "$(dirname "$0")" ; pwd -P )" VERSION=$(make -s -f $SCRIPTPATH/../Makefile version) BUILD_DIR=$SCRIPTPATH/../build/k8s-resources/$VERSION-INDV_RESOURCES_DIR=$BUILD_DIR/individual-resources-TAR_RESOURCES_FILE=$BUILD_DIR/individual-resources.tar+BINARY_DIR=$SCRIPTPATH/../build/bin+INDV_K8S_RESOURCES=$BUILD_DIR/individual-resources.tar AGG_RESOURCES_YAML=$BUILD_DIR/all-resources.yaml+BINARIES_ONLY="false"++USAGE=$(cat << 'EOM'+  Usage: upload-resources-to-github  [-b]+  Upload release assets to GitHub++  Example: upload-resources-to-github -b+          Optional:+            -b          Upload binaries only [DEFAULT: upload all the assets]+EOM+)++# Process our input arguments+while getopts "b" opt; do+  case ${opt} in+    b ) # Binaries only+        BINARIES_ONLY="true"+      ;;+    \? )+        echo "$USAGE" 1>&2+        exit+      ;;+  esac+done  RELEASE_ID=$(curl -s -H "Authorization: token $GITHUB_TOKEN" \     https://api.github.com/repos/aws/aws-node-termination-handler/releases | \     jq --arg VERSION "$VERSION" '.[] | select(.tag_name==$VERSION) | .id') -for binary in $SCRIPTPATH/../build/bin/*; do-    curl \-        -H "Authorization: token $GITHUB_TOKEN" \-        -H "Content-Type: $(file -b --mime-type $binary)" \-        --data-binary @$binary \-        "https://uploads.github.com/repos/aws/aws-node-termination-handler/releases/$RELEASE_ID/assets?name=$(basename $binary)"-done+ASSET_IDS_UPLOADED=() +trap 'handle_errors_and_cleanup $?' EXIT -## Upload k8s yaml-resourceFiles=($TAR_RESOURCES_FILE $AGG_RESOURCES_YAML)-for resourceFile in "${resourceFiles[@]}"; do-    curl \+handle_errors_and_cleanup() {+    if [ $1 -eq "0" ]; then+        exit 0+    fi++    if [[ ${#ASSET_IDS_UPLOADED[@]} -ne 0 ]]; then+        echo -e "\nCleaning up assets uploaded in the current execution of the script"+        for asset_id in $ASSET_IDS_UPLOADED; do+            echo "Deleting asset $asset_id"+            curl -X DELETE \+            -H "Authorization: token $GITHUB_TOKEN" \+            "https://api.github.com/repos/aws/aws-node-termination-handler/releases/assets/$asset_id"

minor: indent continued lines

            curl -X DELETE \
                -H "Authorization: token $GITHUB_TOKEN" \
                "https://api.github.com/repos/aws/aws-node-termination-handler/releases/assets/$asset_id"
brycahta

comment created time in 2 months

Pull request review commentaws/aws-node-termination-handler

AEMM & Windows integrations

 #!/bin/bash set -euo pipefail +# Script to upload release assets to Github.+# This script cleans up after itself in cases of parital failures. i.e. either all assets are uploaded or none+ SCRIPTPATH="$( cd "$(dirname "$0")" ; pwd -P )" VERSION=$(make -s -f $SCRIPTPATH/../Makefile version) BUILD_DIR=$SCRIPTPATH/../build/k8s-resources/$VERSION-INDV_RESOURCES_DIR=$BUILD_DIR/individual-resources-TAR_RESOURCES_FILE=$BUILD_DIR/individual-resources.tar+BINARY_DIR=$SCRIPTPATH/../build/bin+INDV_K8S_RESOURCES=$BUILD_DIR/individual-resources.tar AGG_RESOURCES_YAML=$BUILD_DIR/all-resources.yaml+BINARIES_ONLY="false"++USAGE=$(cat << 'EOM'+  Usage: upload-resources-to-github  [-b]+  Upload release assets to GitHub++  Example: upload-resources-to-github -b+          Optional:+            -b          Upload binaries only [DEFAULT: upload all the assets]+EOM+)++# Process our input arguments+while getopts "b" opt; do+  case ${opt} in+    b ) # Binaries only+        BINARIES_ONLY="true"+      ;;+    \? )+        echo "$USAGE" 1>&2+        exit+      ;;+  esac+done  RELEASE_ID=$(curl -s -H "Authorization: token $GITHUB_TOKEN" \     https://api.github.com/repos/aws/aws-node-termination-handler/releases | \     jq --arg VERSION "$VERSION" '.[] | select(.tag_name==$VERSION) | .id') -for binary in $SCRIPTPATH/../build/bin/*; do-    curl \-        -H "Authorization: token $GITHUB_TOKEN" \-        -H "Content-Type: $(file -b --mime-type $binary)" \-        --data-binary @$binary \-        "https://uploads.github.com/repos/aws/aws-node-termination-handler/releases/$RELEASE_ID/assets?name=$(basename $binary)"-done+ASSET_IDS_UPLOADED=() +trap 'handle_errors_and_cleanup $?' EXIT -## Upload k8s yaml-resourceFiles=($TAR_RESOURCES_FILE $AGG_RESOURCES_YAML)-for resourceFile in "${resourceFiles[@]}"; do-    curl \+handle_errors_and_cleanup() {+    if [ $1 -eq "0" ]; then

The -eq operator is for comparing numbers, but "0" is a string.

    if [ $1 -eq 0 ]; then
brycahta

comment created time in 2 months

push eventaws/amazon-ec2-metadata-mock

Bryan™

commit sha 36f573812ef890a3f9b0b54acef98c63d54c115f

fix push-docker-images logic to populate manifest correctly (#77)

view details

push time in 2 months

PR merged aws/amazon-ec2-metadata-mock

Reviewers
fix push-docker-images logic to populate manifest correctly

Issue #, if available:

  • No #, but the issue is during AEMM release, the Docker Release Windows stage will overwrite existing manifest leaving it populated with only windows/amd64 and erasing linux distros that were there previously.
  • I thought this worked before, but the manifest was cached on my machine from previous upload making it appear as if it were working

Description of changes:

  • Check for existence of manifest and update PLATFORMS accordingly
  • added --purge to push to clear local cache

Testing:

  • very locally tested on my test Dockerhub repo with no local cache this time

Notes:

  • --amend is useless

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+12 -10

0 comment

1 changed file

brycahta

pr closed time in 2 months

push eventaws/aws-node-termination-handler

Brandon Wagner

commit sha 8bf43a9fd02c5531db405fbaef62eb9678460881

webhook-http-proxy-test: print squid logs on failure and improve access log grep (#214)

view details

push time in 2 months

PR merged aws/aws-node-termination-handler

webhook-http-proxy-test: print squid logs on failure and improve access log grep

Issue #, if available: N/A

Description of changes:

  • webhook-http-proxy-test
    • print squid logs on failure
    • improve access log grep to only look for the webhook proxy server address

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+6 -1

1 comment

1 changed file

bwagner5

pr closed time in 2 months

pull request commentaws/aws-node-termination-handler

Fix log output on e2e tests when a failure occurs (#163)

how'd you find all the whitespaces?

@brycahta

  1. Ran ack -l "\s+$" . (I prefer ack over grep) from the repo root to search all the files for trailing whitespace. -l limits the output to just the filename.
  2. Opened the files in vim and searched each file with /\s\+$ (enabling search highlighting helps a lot) to find the trailing whitespaces to delete.
cjerad

comment created time in 2 months

PR opened aws/aws-node-termination-handler

Reviewers
Fix log output on e2e tests when a failure occurs (#163)

Issue #163

Description

  • fix NTH log output on failure in local suite
  • add NTH log output on failure to EKS suite
  • remove trailing whitespace

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+86 -73

0 comment

23 changed files

pr created time in 2 months

create barnchcjerad/aws-node-termination-handler

branch : issue-163

created branch time in 2 months

push eventcjerad/aws-node-termination-handler

Brandon Wagner

commit sha eaf32dc2766bbbed8c5e1f0475c4392d28fbfb02

Update Chart.yaml

view details

David Pait

commit sha 8557cf7ec0311d1f975e4355295ebe7a0773aae8

Update ec2metadata package to include AvailabilityZone info (#210)

view details

Bryan™

commit sha 1aca361687645c7d4b31f4a1e8b952d1f09541ab

Integrate AEMM with NTH integration tests (#209) * use aemm in e2e tests * renaming ec2-metadata-test-proxy to webhook-test-proxy * reorder pod installation in e2e and renamings * intregrate aemm with eks cluster test * addressing shellcheck, fmt issues * update AEMM version and address pr comments

view details

crhuber

commit sha 28f6f52be979f0673fcee28784e0464a7658724e

Add PodMonitor for Prometheus Metrics (#206) * Add PodMonitor * remove quotes on ports * add readme

view details

Bryan™

commit sha 6f9d2b056566b4b906026367e74f0fdb17923c45

bump chart.yaml version (#211)

view details

push time in 2 months

Pull request review commentaws/amazon-ec2-metadata-mock

updating helm to support windows

 if [[ $MANIFEST == "true" ]]; then     fi     cat <<< $(jq '.+{"experimental":"enabled"}' $DOCKER_CLI_CONFIG) > $DOCKER_CLI_CONFIG     echo "Enabled experimental CLI features to create the docker manifest"-    docker manifest create $IMAGE_REPO:$VERSION $MANIFEST_IMAGES++    manifest_create_args=($IMAGE_REPO:$VERSION $MANIFEST_IMAGES)+    manifest_exists=$(docker manifest inspect $IMAGE_REPO:$VERSION > /dev/null ; echo $?)+    # manifest already exists; therefore, amend is required+    if [[ manifest_exists -eq 0 ]]; then+      manifest_create_args+=(--amend)

Docker CLI has an open issue (#954) for the --amend flag. Is this script impacted?

brycahta

comment created time in 2 months

Pull request review commentaws/amazon-ec2-metadata-mock

updating helm to support windows

+{{- if (lower .Values.targetNodeOs | contains "windows") -}}+apiVersion: apps/v1+kind: DaemonSet+metadata:+  name: {{ include "amazon-ec2-metadata-mock.fullname" . }}

Should this be amazon-ec2-metadata-mock.fullname.windows?

brycahta

comment created time in 2 months

Pull request review commentaws/amazon-ec2-metadata-mock

updating helm to support windows

 Create the name of the service account to use     {{ default "default" .Values.serviceAccount.name }} {{- end -}} {{- end -}}++{{/*+Get the default node selector term prefix.++In 1.14 "beta.kubernetes.io" was deprecated and is scheduled for removal in 1.18.+See https://v1-14.docs.kubernetes.io/docs/setup/release/notes/#deprecations+*/}}+{{- define "amazon-ec2-metadata-mock.defaultNodeSelectorTermsPrefix" -}}+    {{- semverCompare "<1.14" .Capabilities.KubeVersion.Version | ternary "beta.kubernetes.io" "kubernetes.io" -}}
  1. It turns out that .Version is only present in Helm 3. Here is a workaround used to support Helm 2.
  2. An issue was encountered when the version includes build metadata. Here is a workaround.
brycahta

comment created time in 2 months

push eventaws/aws-node-termination-handler

Bryan™

commit sha 1aca361687645c7d4b31f4a1e8b952d1f09541ab

Integrate AEMM with NTH integration tests (#209) * use aemm in e2e tests * renaming ec2-metadata-test-proxy to webhook-test-proxy * reorder pod installation in e2e and renamings * intregrate aemm with eks cluster test * addressing shellcheck, fmt issues * update AEMM version and address pr comments

view details

push time in 2 months

PR merged aws/aws-node-termination-handler

Integrate AEMM with NTH integration tests

Issue #, if available: N/A

Description of changes:

  • e2e tests will use AEMM instead of metadata-test-proxy
  • rename: ec2-metadata-test-proxy --> webhook-test-proxy
  • eks-cluster-test will has the option of creating infrastructure for the user or using values provided via CONFIG
  • removing fake owners

Testing:

  • e2e tests pass locally
  • make eks-cluster-test passes
  • minor enhancements to existing eks cluster-spec to improve deployment reliability

Regression:

  • integration tests on Windows will no longer pass because AEMM daemonsets haven't been updated yet

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+767 -642

1 comment

39 changed files

brycahta

pr closed time in 2 months

Pull request review commentaws/aws-node-termination-handler

Integrate AEMM with NTH integration tests

 SCRIPTPATH="$( cd "$(dirname "$0")" ; pwd -P )"  common_helm_args=() [[ "${TEST_WINDOWS-}" == "true" ]] && common_helm_args+=(--set targetNodeOs="windows")+if [[ ! -z ${NTH_WORKER_LABEL-} ]]; then+  common_helm_args+=(--set nodeSelector."$NTH_WORKER_LABEL")+fi  anth_helm_args=(   upgrade   --install   $CLUSTER_NAME-anth   $SCRIPTPATH/../../config/helm/aws-node-termination-handler/   --namespace kube-system-  --set instanceMetadataURL=${INSTANCE_METADATA_URL:-"http://localhost:$IMDS_PORT"}+  --set instanceMetadataURL=${INSTANCE_METADATA_URL:-"http://$AEMM_URL:$IMDS_PORT"}

If AEMM_URL is missing then the script should supply a default or fail.

brycahta

comment created time in 2 months

Pull request review commentaws/aws-node-termination-handler

Integrate AEMM with NTH integration tests

 #!/bin/bash -echo "Uninstall Helm charts ..."-helm list -a -A |-    tail -n +2 |-    tr -s "\t" " " |-    awk '{ printf("helm uninstall -n %s %s\n", $2, $1) }' |-    bash -s-echo "✅ done"+function reset_cluster {+    echo "Resetting cluster"+    charts=$(helm ls --all --short)+    if [[ ! -z "$charts" ]]; then+        helm del $charts || :+    fi+    system_charts=$(helm ls --all --short --namespace kube-system)+    if [[ ! -z "$system_charts" ]]; then+        helm del $system_charts --namespace kube-system || :+    fi+    for node in $(kubectl get nodes | tail -n+2 | cut -d' ' -f1); do+        kubectl uncordon $node+        kubectl taint node $node aws-node-termination-handler/scheduled-maintenance- || true+        kubectl taint node $node aws-node-termination-handler/spot-itn- || true

To handle future changes, could this just remove all taints under aws-node-termination-handler/?

brycahta

comment created time in 2 months

Pull request review commentaws/aws-node-termination-handler

Integrate AEMM with NTH integration tests

  set -euo pipefail +SCRIPTPATH="$( cd "$(dirname "$0")" ; pwd -P )"+PRESERVE=false++export TEST_WINDOWS="false"+export AEMM_VERSION="1.1.0"+export CLUSTER_CONFIG_FILE=$SCRIPTPATH/cluster-spec.yaml++ USAGE=$(cat << 'EOM'   Usage: run-test [-a script1,scripts2,...] [-w] [-r] CONFIG

Missing the new -p option.

brycahta

comment created time in 2 months

Pull request review commentaws/aws-node-termination-handler

Integrate AEMM with NTH integration tests

 SCRIPTPATH="$( cd "$(dirname "$0")" ; pwd -P )"  common_helm_args=() [[ "${TEST_WINDOWS-}" == "true" ]] && common_helm_args+=(--set targetNodeOs="windows")+if [[ ! -z ${NTH_WORKER_LABEL-} ]]; then+  common_helm_args+=(--set nodeSelector."$NTH_WORKER_LABEL")+fi

Quibble: for consistency, could be written as

[[ -n "${NTH_WORKER_LABEL-}" ]] && common_helm_args+=(--set nodeSelector."$NTH_WORKER_LABEL")
brycahta

comment created time in 2 months

Pull request review commentaws/aws-node-termination-handler

Integrate AEMM with NTH integration tests

 set -x helm "${anth_helm_args[@]}" set +x +aemm_helm_args=(+  upgrade+  --install+  $CLUSTER_NAME-aemm+  https://github.com/aws/amazon-ec2-metadata-mock/releases/download/v"$AEMM_VERSION"/amazon-ec2-metadata-mock-"$AEMM_VERSION".tgz+  --namespace default+  --set servicePort="$IMDS_PORT"+)++set -x+helm "${aemm_helm_args[@]}"

Should aemm_helm_args include common_helm_args?

brycahta

comment created time in 2 months

Pull request review commentaws/aws-node-termination-handler

Integrate AEMM with NTH integration tests

 require ( 	go.opentelemetry.io/contrib/instrumentation/runtime v0.6.1 	go.opentelemetry.io/otel v0.6.0 	go.opentelemetry.io/otel/exporters/metric/prometheus v0.6.0-	golang.org/x/sys v0.0.0-20190616124812-15dcb6c0061f+	golang.org/x/sys v0.0.0-20200302150141-5c8b2ff67527

As long as it builds and the EKS tests pass then the version should be fine.

brycahta

comment created time in 2 months

push eventcjerad/aws-node-termination-handler

Brandon Wagner

commit sha 18ce8fdd87172c5e774b3693b29ce62c49e93272

refactor event handlers to monitors with an interface (#201) * refactor event handlers to monitors with an interface * move monitors to separate packages

view details

Jerad C

commit sha 6a6cc747a2bb08f46df52280050acba0033592f5

fix helm chart nodeSelector (#202) (#203) * fix helm chart nodeSelector (#202) * update Helm chart version

view details

push time in 2 months

delete branch cjerad/aws-node-termination-handler

delete branch : issue-202

delete time in 2 months

push eventcjerad/aws-node-termination-handler

Jerad C

commit sha 9d3f7f9f5d20e081746483282ede670edebe14be

update Helm chart version

view details

push time in 2 months

Pull request review commentaws/aws-node-termination-handler

fix helm chart nodeSelector (#202)

 spec:       nodeSelector:         {{ include "aws-node-termination-handler.nodeSelectorTermsOs" . }}: linux         {{- with .Values.nodeSelector }}-          {{- . | nindent 8 }}+          {{- toYaml . | nindent 8 }}

It just directly inserted the string.

cjerad

comment created time in 2 months

PR opened aws/aws-node-termination-handler

fix helm chart nodeSelector (#202)

Issue #202

Description Correctly convert value into YAML.

Verified that generating chart template with --set nodeSelector.lifecycle=spot,nodeSelector.foo=bar outputs:

nodeSelector:
    kubernetes.io/os: linux
    foo: bar
    lifecycle: spot

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+4 -4

0 comment

2 changed files

pr created time in 2 months

create barnchcjerad/aws-node-termination-handler

branch : issue-202

created branch time in 2 months

push eventcjerad/aws-node-termination-handler

Brandon Wagner

commit sha eb7d8114daa5286e93d531bb224e8d5e68a83501

Update README.md

view details

Ed Lim

commit sha e769d9e2dc42fa34aba5f7e47c6b81b7656c3757

Don't schedule aws-node-termination-handler on fargate nodes (#191) * Don't schedule node termination handler if compute type is of type fargate * Bump version

view details

Takayuki Watanabe

commit sha bc39bfbbfad9d7e633d2bcace41069affaab1b99

Fix explanation of ignore-daemon-sets flag (#194)

view details

Brandon Wagner

commit sha 43a69e0f41f2d7ed97e7199f5026dfc2c7eec6e4

remove + from major minor server version (#195)

view details

Brandon Wagner

commit sha 216ed72ff9e85dd93e8d11bbef270f68e26729ea

up for patch release (#196)

view details

Brandon Wagner

commit sha 4c3d2f0d7406e19de89f6f272b705f205b197cec

Update README.md

view details

Eric Bailey

commit sha 77372a20cdc08bbe71a9d94d5e87e647afd2f512

Update README.md (#199) Fix typo: DaemonsSet -> DaemonSet

view details

Brandon Wagner

commit sha 45d78df038c9eceea318208274a89eea92666c7a

add shellcheck and spellcheck (#198)

view details

Brandon Wagner

commit sha 57c4a83b1da18252543d87505b761514ad1dbea7

build .tar.gz bin files (#197) * build .tar.gz bin files * Update build-binaries

view details

push time in 2 months

issue commentaws/aws-node-termination-handler

Can't use nodeSelector with helm chart

@kuzaxak Please try again with the option formatted as --set nodeSelector="lifecycle: spot"

kuzaxak

comment created time in 2 months

push eventaws/aws-node-termination-handler

Brandon Wagner

commit sha 43a69e0f41f2d7ed97e7199f5026dfc2c7eec6e4

remove + from major minor server version (#195)

view details

push time in 2 months

PR merged aws/aws-node-termination-handler

remove + from major minor server version

Issue #, if available: https://github.com/aws/aws-node-termination-handler/issues/193

Description of changes:

  • Fix semver comparison in the helm chart when the server provider's major number includes a "+" like in the case of EKS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+3 -3

1 comment

3 changed files

bwagner5

pr closed time in 2 months

fork cjerad/amazon-ec2-instance-selector

A CLI tool and go library which recommends instance types based on resource criteria like vcpus and memory

fork in 2 months

push eventcjerad/aws-node-termination-handler

Andrey Klimentyev

commit sha e8cce3e0ec48a43388fd7200bbd255a79624f203

Fixed typo in "pre-dain" NodeAction (#184) Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>

view details

Leo Palmer Sunmo

commit sha 049947cd675206fe7e219bb4bb8f5ef4f977d4b8

Add metadata endpoint and Kiam documentation (#188) This adds documentation on which EC2 metadata endpoints the termination handler relies on. It also provides a config option to enable the termination handler to function properly on a cluster that has Kiam deployed to manage AWS IAM credentials.

view details

Jerad C

commit sha f5f8766609022dd8c2df18367089205e3a8ce92e

add Windows node support (#185) * add Windows node support * fix system test mock for k8s <1.14 * fix syntax error * fix unit tests * fix gofmt issues * increase test coverage * add make target to run unit tests in linux container * add uptime stub for darwin

view details

Brandon Wagner

commit sha 20b816957ddb9f37a3820f2ddca60fc3ef74666c

do not fail when scheduled event does not have end date (#182) * do not fail when scheduled event does not have end date. It's nice-to-have information only. * fix unit-test for scheduled events

view details

Brandon Wagner

commit sha b6cbb2a9c8bb9b7cfd91dc072ea238864a105f35

prepare for v1.6.0 release (#189)

view details

Brandon Wagner

commit sha e16065c826fc2fc350e15476ffca34f9222431e8

Kube version helm (#190) * fix kube version retrieval in helm template helpers * add helm lint test * change kube-version retrieval on emtp

view details

push time in 3 months

delete branch cjerad/aws-node-termination-handler

delete branch : issue-8

delete time in 3 months

push eventaws/aws-node-termination-handler

Brandon Wagner

commit sha e16065c826fc2fc350e15476ffca34f9222431e8

Kube version helm (#190) * fix kube version retrieval in helm template helpers * add helm lint test * change kube-version retrieval on emtp

view details

push time in 3 months

push eventcjerad/aws-node-termination-handler

Jerad C

commit sha 052bd2e0d40f800d378debeb664aae3dea3976ca

add make target to run unit tests in linux container

view details

Jerad C

commit sha eaf55cd726d7338300e770554db6166c764beb2f

add uptime stub for darwin

view details

push time in 3 months

push eventcjerad/aws-node-termination-handler

Jerad Cramp

commit sha 97731d0c2bfcd5579d4f72e3ed4585459ba09735

increase test coverage

view details

push time in 3 months

push eventcjerad/aws-node-termination-handler

Jerad C

commit sha 1aff339321aa79cac42e54a48b6048da4f1c10b1

fix system test mock for k8s <1.14

view details

Jerad Cramp

commit sha e5f51ae2028d60509977ea469b1138b5ccb721b9

fix syntax error

view details

Jerad Cramp

commit sha 8385e968ca564d5faa0e115e063c4924cb4d90e9

fix unit tests

view details

Jerad Cramp

commit sha 1140807f24c33417aa74687852eb3421767e4951

fix gofmt issues

view details

push time in 3 months

PR opened aws/aws-node-termination-handler

add Windows node support

Issue #, if available: Resolves aws/aws-node-termination-handler#8

Description of changes: Adds support for running on Windows nodes. Also updates build and test scripts.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+1530 -458

0 comment

33 changed files

pr created time in 3 months

create barnchcjerad/aws-node-termination-handler

branch : issue-8

created branch time in 3 months

push eventcjerad/aws-node-termination-handler

Ilya Shaisultanov

commit sha 0d528d632f8d3e9712da0fe678fc11240acc2fa4

Taint nodes on spot and scheduled events (#162) * Taint nodes on spot and scheduled events Fixes #160. Signed-off-by: Ilya Shaisultanov <ilya.shaisultanov@gmail.com>

view details

Brandon Wagner

commit sha ae4d988004216f84e9c1de23058e7fb342b0a7de

Update installation cmd in README (#165)

view details

Brandon Wagner

commit sha 30128670bc91a6c7008c309bcf9706c9ee9a2a02

update travis to run license test on tag releases (#166)

view details

Manuel Alonso

commit sha 011a797a264bbae2164ce168dfc467967d1a9233

Prometheus metric endpoint and Opentelemetry stats (#172) * adding/testing prometheus flags for enabling and port. * adding prometheus and OT metrics * adding constant for default prometheus port with doc * adding events metrics, and refactoring * rewording, fixing tests * removing events metrics counter, refactoring nodeName * extends helm chart and doc with prometheus values * ignoring binary, removing unused metric * adding e2e test prometheus enabled, name better args cli * refactoring error event metrics * removing metrics in func not used * fixing env for prometheus port * adding license and improving documentation * adding metrics endpoint consideration in the readme * change type port to int * adding e2e tests for metrics verifying them

view details

Brandon Wagner

commit sha 466060d6348b0977a233a79213a41f76bbf65c15

stabilize e2e tests (#174) * stabilize e2e tests * tidy up the changes

view details

Brandon Wagner

commit sha cc6170de36fd583b24e8ba122c07face3f1b610c

prepare for 1.5.0 release (#175)

view details

Brandon Wagner

commit sha 8febad4fcf28bd9eab55aff92a183802bb4c9e20

update licenses (#176)

view details

Brandon Wagner

commit sha fc625bb7187077c9bb25f615671d2fcf9385629f

travis build improvements (#177) * travis build improvements * remove name from e2e tests so that version is more accessible * remove direct downloads when building images and binaries * only run helm validation on release * update k8s 1.18 kind node image * add makefile help target * remove --force on reinstall of emtp * sort assertion scripts so that order is deterministic between different versions of find

view details

Brandon Wagner

commit sha b21fff3ff5f55c25db53a06eea331c64853ebd5b

fix docker sync readme (#178)

view details

Brandon Wagner

commit sha 4c11208c1379ec4ff8f594b1aeaf9415768e3e43

Update .travis.yml

view details

Brandon Wagner

commit sha 2112381d71ae28a19deb323e4ac783896427af3f

update kubectl apply instructions to v1.5.0

view details

Abdul Muqtadir Mohammed

commit sha 9c6268b6936ce3c519e59529d6a6baeba5c2c53e

Add support for Webhook URL as a Secret (#179) * Add support for Webhook URL as a Secret

view details

Matheus Weber da Conceição

commit sha f16d712da4aef224278b52f097785380ffbdc8fe

Add new podLabels parameter for adding labels to each pod (#180)

view details

push time in 3 months

more