profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/chlunde/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Carl Henrik Lunde chlunde @SpareBank1

chlunde/jellybeans.vim 2

A colorful, dark color scheme for Vim.

chlunde/huemenu 1

Mac OS X/Python status bar application for controlling philips hue

chlunde/humio-jaeger-storage 1

Proof of concept / demo

chlunde/api 0

Canonical location of the OpenShift API definition.

chlunde/bubbletea 0

A powerful little TUI framework 🏗

chlunde/clair 0

Vulnerability Static Analysis for Containers

chlunde/code-generator 0

Code generator for AWS Controllers for Kubernetes

chlunde/crossplane 0

Manage any infrastructure your applications need directly from Kubernetes

chlunde/dex 0

OpenID Connect Identity (OIDC) and OAuth 2.0 Provider with Pluggable Connectors

chlunde/dotfiles 0

My dotfiles

Pull request review commentaws-controllers-k8s/code-generator

Support nested Ignore.FieldPaths

 func (m *Model) ApplyShapeIgnoreRules() { 		return 	} 	for sdkShapeID, shape := range m.SDKAPI.API.Shapes {+	ignoreFields:

I don't like this, I can extract this function later... :palm_tree:

chlunde

comment created time in 16 days

PullRequestReviewEvent

push eventchlunde/code-generator

Nicholas Thomson

commit sha 89885167411100f6c736e67cad1d666cbdcefb75

Remove unnecessary homedir module (#88) `os.UserHomeDir` is supported in go1.12+. We no longer need a third party module to load the home directory. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

kumargauravsharma

commit sha 4857c76eaaca7c3ae5f3281f71e29a6c66ce3594

Extend ack-generate to generate slice with elements of type K8s Secret (#87) Issue: https://github.com/aws-controllers-k8s/community/issues/828 Description of changes: With this code change, when a field of type slice is configured as secret type inside Generator config, then the generated CRD yaml allows specifying multiple k8s secret values for that field in input yaml and generated sdk code supplies these values to the resource API input field as slice type. Added unit tests to test the scenario. Details on resultant generated code: Taking ElastiCache User API has `passwords` filed as example: ElastiCache User API has `passwords` filed of type `[]*string` in the API input. [Reference API docs](https://awscli.amazonaws.com/v2/documentation/api/latest/reference/elasticache/create-user.html) When this field is configured as secret type inside Generator config: ``` resources: User: fields: Passwords: is_secret: true ``` and service controller code is generated with changes from this PR then, the generated CRD yaml for password field is: ``` passwords: description: Passwords used for this user. You can create up to two passwords for each user. items: description: SecretKeyReference combines a k8s corev1.SecretReference with a specific key within the referred-to Secret properties: key: description: Key is the key within the secret type: string name: description: Name is unique within a namespace to reference a secret resource. type: string namespace: description: Namespace defines the space within which the secret name must be unique. type: string required: - key type: object type: array ``` Observe that the password field is `array` type with K8s Secreret as element type and User resource sdk.go file contain following code for password field while setting the inputs: ``` if r.ko.Spec.Passwords != nil { f3 := []*string{} for _, f3iter := range r.ko.Spec.Passwords { var f3elem string if f3iter != nil { tmpSecret, err := rm.rr.SecretValueFromReference(ctx, f3iter) if err != nil { return nil, err } if tmpSecret != "" { f3elem = tmpSecret } } f3 = append(f3, &f3elem) } res.SetPasswords(f3) } ``` Observe that it supplies the secrets values as slice type to the input API. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Testing: 1. ```make test``` passed for `code-generator` which contained already existing tests for secret fields code generation scenarios for MQ, ElastiCache ReplicationGroup. 2. ```make test``` passed for ElastiCache ACK controller generated code. 3. Generated ElastiCache controller code did not have any unrelated/unexpected changes.

view details

Amine

commit sha 99e7023dfb0f2b7e80d7d7880941830fcbb6c0df

Add a new operation config to override the `SetOutput` wrapper field (#78) Issue N/A In some AWS APIs `Describe` operations output contains the wanted information in a wrapper field like `TableDescription` and `GlobalTableDescription` ... However in some other APIs for the same operation type, the wanted information is wrapped in different nested object, like `BackupDescription.BackupDetails` for example. Description of changes: This patch adds a new operation configuration that instructs the code-generator to use a specific field path, in order to find the struct that contains the information we want to set the output from. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Nicholas Thomson

commit sha e278e1aef5abc644e681ac733cc23b424c136063

Add base CRD documentation (#89) Description of changes: Replaces the comment block for CRDs with the documentation of the resource shape from the AWS SDK. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Amine

commit sha 878da89d5e636efacefbc0de6b28fc1899e5acca

Add a new generator config to append an Age `printcolumn` (#84) Issue: https://github.com/aws-controllers-k8s/community/issues/822 Since All kubernetes resources have a `.metadata.creationTimestamp` field, we need a way to instruct the code generator to generate kubebuilder marker comments that will append the AGE field the `kubectl get` response. This patch extends `Resource.PrintConfig` to allow configuring the `ack-generate` to generate such marker comments. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Amine

commit sha 8e82f0a0ac21eb3c3b61347e455872abe212731c

Add a cobra `PostRunE` to save generation metadata (#90) Issue https://github.com/aws-controllers-k8s/community/issues/809 Description of changes: This patch adds a cobra `PostRunE` function that writes generator parameters, output metadata and generated files checksum, to a file within the API versions directory. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Jay Pipes

commit sha 32c92163308939abfd940a652e057cf6140ab3c6

fix: use deterministic sort for identifier field (#93) @kumargauravsharma noticed that when generating the User resource package in the elasticache-controller, sometimes he saw the Identifier field be User.Spec.UserID. Other times it was User.Spec.UserName. Turns out in the `pkg/model.CRD:SpecIdentifierField()` method, we were looping over the `CRD.SpecFields` map keys (which are not ordered) instead of a sorted list of spec field names, which is returned by the `CRD.SpecFieldNames()` method. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Nicholas Thomson

commit sha 0736a4b69046df5c4a905f40e7282f90a4500232

Conditionally allow view secrets on ClusterRole (#96) Issue #, if available: https://github.com/aws-controllers-k8s/community/issues/745 Description of changes: If any of the fields defined in the generator are set to `is_secret: True`, then add `get;list;watch` permissions for secrets on the controller `ClusterRole` Output into `cluster-role-controller.yaml`: ```yaml - apiGroups: - "" resources: - secrets verbs: - get - list - watch ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

ryansteakley

commit sha 98e1eb412c7371da5bb1ca8876af0e696c43e879

Support suffix exception (#97) Issue #, if available: https://github.com/aws-controllers-k8s/community/issues/840 Description of changes: Add support for suffix exception checking. Also added Sagemaker tests for prefix and suffix exceptions. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Jay Pipes

commit sha a42b4a1a9081824ff60a29b8a5f31ccf79026372

trace sdk.go resource manager methods (#98) Updates the sdk.go-specific templates to take advantage of the new ACK runtime logger that is embedded in all Context structs passed from the ACK runtime v0.2.3 release and after. In working these log traces into the various sdkXXX methods, I took this opportunity to clean up some of the ugly template conditionals in these methods that checked to see whether an Output shape was being referenced as a variable after calling the aws-sdk-go API calls and setting the associated variable name to `_` in order to prevent `unused variable declared` compilation failures. The template code for handling this used to look like this: ``` {{ $createCode := GoCodeSetCreateOutput .CRD "resp" "ko" 1 false }} {{ if not ( Empty $createCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.Create.ExportedName }}WithContext(ctx, input) rm.metrics.RecordAPICall("CREATE", "{{ .CRD.Ops.Create.ExportedName }}", respErr) if respErr != nil { return nil, respErr } // Merge in the information we read from the API call above to the copy of // the original Kubernetes object we passed to the function ko := r.ko.DeepCopy() {{ $createCode }} ``` but now is simpler and easier to read: ``` var resp {{ .CRD.GetOutputShapeGoType .CRD.Ops.Create }} resp, err = rm.sdkapi.{{ .CRD.Ops.Create.ExportedName }}WithContext(ctx, input) rm.metrics.RecordAPICall("CREATE", "{{ .CRD.Ops.Create.ExportedName }}", err) if err != nil { return nil, err } // Merge in the information we read from the API call above to the copy of // the original Kubernetes object we passed to the function ko := desired.ko.DeepCopy() {{ GoCodeSetCreateOutput .CRD "resp" "ko" 1 false }} ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Amine

commit sha d5797469ebb582083970136fc08f5de973e9ff1a

Update `VERSION` variable in `Makefile` to `v0.2.3` (#99) Description of changes: - Update `ack-generate` version in Makefile By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

kumargauravsharma

commit sha 85436ab1f0b7994e7c6651a03177ab90a8b61ad5

Enable crd variables and controller functions and hooks within hook templates (#91) Issue #, https://github.com/aws-controllers-k8s/community/issues/838 Description of changes: This PR enables support for crd variables and controller functions and hooks within hook templates. The hook templates insides the service controllers can be similar to the templates that are inside code-generator. For example, following hook template refers `.CRD` variable, invokes controller function `GoCodeSetCreateOutput` and has its own extension hook `sdk_addon_set_output_post_populate`: and it can be used as hook inside generator.yaml for a resource: ``` {{ $outputShape := .CRD.GetOutputShape .CRD.Ops.Create }} // This method copies the data from given {{ $outputShape.ShapeName }} by populating it // into copy of supplied resource and returns that. func (rm *resourceManager) set{{ $outputShape.ShapeName }}Output ( r *resource, obj *svcsdk.{{ $outputShape.ShapeName }}, ) (*resource, error) { if obj == nil || r == nil || r.ko == nil { return nil, nil } resp := &svcsdk.{{ .CRD.Ops.Create.OutputRef.Shape.ShapeName }}{ {{ $outputShape.ShapeName }}:obj } // Merge in the information we read from the API call above to the copy of // the original Kubernetes object we passed to the function ko := r.ko.DeepCopy() {{ $createCode := GoCodeSetCreateOutput .CRD "resp" "ko" 1 true }} {{ $createCode }} rm.setStatusDefaults(ko) {{- if $hookCode := Hook .CRD "sdk_addon_set_output_post_populate" }} {{ $hookCode }} {{- end }} return &resource{ko}, nil } ``` Testing: `make test` passed for `code-generator` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

kumargauravsharma

commit sha 4e0e553d4604cb4ff4e739f9db24c9d07dc0ed44

Add CRD method to get OutputShape (#92) Issue #, if available: Description of changes: This PR also adds a method `GetOutputShape` to crd which provides output shape For example, `CreateReplicationGroupOutput`, `ModifyReplicationGroupOutput` wrap `ReplicationGroup` object. This method is useful in creating reusable code which populates the fields from wrapped object to `ko`. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

kumargauravsharma

commit sha 38e309d07369b1e33250473084f91db3894c4379

fix template for create custom implementation scenario (#100) Issue #, if available: Code generator fails when custom implementation is provided for create scenario Steps to reproduce: 1. Run `make build-ack-generate && make build-controller SERVICE=$SERVICE` 2. Observe: > /Users/kumargsh/ws/github_ws/go/src/github.com/aws-controllers-k8s/elasticache-controller/pkg/resource/snapshot/sdk.go:311:17: expected ';', found created Error: not all generators ran successfully 3. Corresponding `sdk.go` code: > exit := rlog.Trace("rm.sdkCreate") defer exit(err)created, err = rm.CustomCreateSnapshot(ctx, desired) if created != nil || err != nil { return created, err } Observe, missing newline after `defer exit(err)` Description of changes: Updated the template. Testing * `make test` passed. * ElastiCache service controller gets generated fine. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Jay Pipes

commit sha 2e9866d86c534985dfdf0d83449b204f216f8892

prevent unused variable error (#101) A [previous commit][0] that changed the ACK pkg/resource templates introduced an error for controllers that have CREATE or UPDATE implementations where the Output shape from the operation sets no fields on the CR. In these cases, attempting to build these controllers was resulting in a build failure, like this for the RDS controller: ``` pkg/resource/db_parameter_group/sdk.go:205:6: resp declared but not used ``` This corrects that by using a blanking technique immediately after the variable declaration: ``` var resp *SomeSDKShape; _ = resp; ``` [0]: a42b4a1a9081824ff60a29b8a5f31ccf79026372 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Amine

commit sha ece6139d2cf7f72a178268c06b6a638f56858311

Remove duplicate `aws-sdk-go/$service` import (#102) Remove duplicate `aws-sdk-go/$service` import. It is already imported in L14 with the alias `svcsdk` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Nicholas Thomson

commit sha 85e4aa72816243f031d69513e06409c2064d9cf7

Fix missing replace conditions method (#104) Description of changes: Add the missing `ReplaceConditions` method introduced in https://github.com/aws-controllers-k8s/runtime/pull/24 . Fix a import path error introduced in https://github.com/aws-controllers-k8s/code-generator/pull/102 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

view details

Meghna Baijal

commit sha dc66295d5a576b74516614da24cee0b83a46af19

Initial Commit: Optional infinite requeue

view details

Meghna Baijal

commit sha 00ca5237e28b8de177e76a71dea9ad3eea907ffd

Fix Rebasing Error

view details

Meghna Baijal

commit sha c575f221b7c7c6a44882c48f411ea640d1a3659f

Address Review comments

view details

push time in 16 days

push eventchlunde/dotfiles

Carl Henrik Lunde

commit sha 41797f78601e74b69c54dd023a836d86e4b803d3

bashrc: dont open another emacs on emacsclient error

view details

Carl Henrik Lunde

commit sha e62b8ae3a3198284e222d529e4b293b062e83c9e

Update Iosevka

view details

Carl Henrik Lunde

commit sha ca639b48ed35f937682db1d5c94f9d37780f1b32

Install sops

view details

Carl Henrik Lunde

commit sha b36fdf44b84ad67254716f966ae8a604d98e47cb

emacs: raise frame from emacsclient

view details

Carl Henrik Lunde

commit sha e3883577e4291606ffd6010b9da67a2c0833292a

emacs: drop shell-pop

view details

Carl Henrik Lunde

commit sha 4eec75914c9d17148f7584ede03d552c2883e50b

emacs: yaml mode workaround

view details

Carl Henrik Lunde

commit sha 9cd2253ec904392a7ddabc07eceb69fb5f02ab7b

emacs: window management changes

view details

Carl Henrik Lunde

commit sha a1cddd36dcf2e96dc5e4d187e9891a7bd04c90e0

emacs: babel shell support

view details

Carl Henrik Lunde

commit sha a0b6dc5e5c5b2352a5d263bb97671d4a0c1e3844

emacs: no go guru

view details

Carl Henrik Lunde

commit sha 19656cea394b9fa9dd39fd763e464727a8154474

emacs: ignore crossplane temp dirs for lsp

view details

Carl Henrik Lunde

commit sha 9de868e44988e97b723254562c2069d0fb7b1609

emacs: not using evil

view details

push time in 18 days

startedkubernetes-sigs/kind

started time in 18 days

startedcharmbracelet/glamour

started time in 18 days

startedkovidgoyal/kitty

started time in 18 days

fork chlunde/kustomize

Customization of kubernetes YAML configurations

fork in 20 days

push eventchlunde/provider-aws

Carl Henrik Lunde

commit sha 7ebcfd7d76b5058c9a384b0f9e158a4d90ecbe40

s3: consistent resolver function name Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

push time in 20 days

push eventchlunde/provider-aws

Carl Henrik Lunde

commit sha 675ee0d4b7e0f3ad5cb609deafc96ac214d3a565

s3: consistent resolver function name

view details

push time in 20 days

push eventsparebank1utvikling/provider-aws

Carl Henrik Lunde

commit sha 9dd71f0c11d870e48ea6eb932ec4409a2cfbec69

meh

view details

Carl Henrik Lunde

commit sha 61239fd5373b34704ac4b29214d1f0962305e0fc

release

view details

push time in 20 days

push eventsparebank1utvikling/provider-aws

Carl Henrik Lunde

commit sha 3208cf27ea44721f6c6fc54d920ea64cc19d4708

log

view details

Carl Henrik Lunde

commit sha c9924d02331075b6714da5464c521dbd772a4ffb

release

view details

push time in 20 days

push eventsparebank1utvikling/provider-aws

Carl Henrik Lunde

commit sha bcbd52aaa69b4e1414341f3548dce0c345123ef9

foo

view details

push time in 20 days

push eventsparebank1utvikling/provider-aws

Carl Henrik Lunde

commit sha ea69a876dee17c03faea3109604eee7f9bad0b0c

s3 debug

view details

Carl Henrik Lunde

commit sha 1141c985e4e19ab0d5781291cfb028256f10df2c

release

view details

push time in 20 days

PR opened crossplane/provider-aws

s3: fix deleteMarkerReplication.Status -> deleteMarkerReplication.status

Description of your changes

fix deleteMarkerReplication.Status -> deleteMarkerReplication.status

The JSON/YAML field name had an upper case first letter, which is not consistent with any other resource.

Question: Given the other issues with replication configuration, I'm not sure if anyone has used replication lately. So I wonder if this is OK or not in beta.

I have:

  • [x] Read and followed Crossplane's contribution process.
  • [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Created replication rule and checked the console.

+3 -3

0 comment

2 changed files

pr created time in 20 days

PR opened crossplane/provider-aws

s3: replication configuration - allow user to drop Filter similar AWS documentation

Description of your changes

The filter part of a replication rule is as far as I can tell optional in the documentation. However, it was not possible to create a filter-less replication rule similar to the XML examples.

Using cloud trail and the console noticed that if you create a rule in the s3 console, cloud trail says filter: "". With aws s3api get-bucket-replicaton I see "Filter": {},. However, in the XML examples, there is no filter:

https://docs.aws.amazon.com/AmazonS3/latest/userguide/replication-add-config.html#replication-config-min-rule-config

It turns out that if you don't want a filter, you still have to include the filter element to the Go SDK.

Question: I'm not sure if this is an issue with the Go SDK, or if the documentation is simply wrong, that you need a filter XML tag? If we can dump the XML perhaps we can know if this is a good idea or not.

I have:

  • [x] Read and followed Crossplane's contribution process.
  • [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Created replication rule and check the console.

+2 -0

0 comment

1 changed file

pr created time in 20 days

PR opened crossplane/provider-aws

s3: replication storage class STANDARD was missing

Description of your changes

Add storage class STANDARD as an option.

I have:

  • [x] Read and followed Crossplane's contribution process.
  • [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Created replication rule and check the console. <!-- Before reviewers can be confident in the correctness of this pull request, it needs to tested and shown to be correct. Briefly describe the testing that has already been done or which is planned for this change. -->

+2 -1

0 comment

2 changed files

pr created time in 20 days

PR opened crossplane/provider-aws

s3: resolve bucket ARN in replication config references

Description of your changes

The replication destination bucket should resolve to an ARN, not a bucket name.

Fixes #745

I have:

  • [x] Read and followed Crossplane's contribution process.
  • [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

With blood, sweat and tears. Fixed three other issues first.

This is a "minimal" configuration (excluding role and policy):

---
apiVersion: s3.aws.crossplane.io/v1beta1
kind: Bucket
metadata:
  annotations:
    crossplane.io/external-name: repl-src.2021-06-07
  name: repl-src
spec:
  deletionPolicy: Delete
  forProvider:
    acl: private
    locationConstraint: eu-north-1
    paymentConfiguration:
      payer: BucketOwner
    serverSideEncryptionConfiguration:
      rules:
      - applyServerSideEncryptionByDefault:
          sseAlgorithm: AES256
    versioningConfiguration:
      status: Enabled
    replicationConfiguration:
      role: arn:aws:iam::...:role/s3-replication-test # assumable by s3 svc, I just tested with an s3 admin role
      rules:
      - destination:
          storageClass: STANDARD
          bucketRef:
            name: repl-dest
        deleteMarkerReplication:
          status: Disabled
        priority: 0
        id: rule-1
        status: Enabled
---
apiVersion: s3.aws.crossplane.io/v1beta1
kind: Bucket
metadata:
  annotations:
    crossplane.io/external-name: repl-dest.2021-06-07
  name: repl-dest
spec:
  deletionPolicy: Delete
  forProvider:
    acl: private
    locationConstraint: eu-north-1
    paymentConfiguration:
      payer: BucketOwner
    serverSideEncryptionConfiguration:
      rules:
      - applyServerSideEncryptionByDefault:
          sseAlgorithm: AES256
    versioningConfiguration:
      status: Enabled

Question: Do you prefer the function returning a function for BucketARN?

+23 -1

0 comment

1 changed file

pr created time in 20 days

push eventchlunde/provider-aws

Carl Henrik Lunde

commit sha fb94472d5b2192437e2bbd029b7b8698f1d2da1a

s3: resolve bucket ARN in replication config references The replication destination bucket should resolve to an ARN, not a bucket name. Fixes #745 Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

push time in 20 days

push eventchlunde/provider-aws

Carl Henrik Lunde

commit sha e000d20c4396777a9f2de034eb3c4cf26cdf9fc1

s3: Add storage class STANDARD for replication configuration Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

push time in 20 days

push eventchlunde/provider-aws

Carl Henrik Lunde

commit sha a6706d2729d5cac4a3624e84ccccf77081d456ce

s3: replication configuration - always send filter For some reason the XML is malformed if not sending and empty element here using the Go AWS SDK. When looking at minimal XML files in the documentation, this element is not included, so I'm not sure what is going on here, but I think we should do this because the error message does not give any indication to the user on what the issue is. Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

push time in 20 days

push eventchlunde/provider-aws

Carl Henrik Lunde

commit sha 9ba3bd2735e50602167e8b25f9d160a16d468cbc

s3: Add storage class STANDARD for replication configuration Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

push time in 20 days

push eventchlunde/provider-aws

Carl Henrik Lunde

commit sha 0a12b4201500bd60580be65135110ccb33842aa9

s3: fix deleteMarkerReplication.Status -> deleteMarkerReplication.status The JSON/YAML field name had an upper case first letter, which is not consistent with any other resource. Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

push time in 20 days

create barnchchlunde/provider-aws

branch : s3-replication-marker-typo

created branch time in 20 days

create barnchchlunde/provider-aws

branch : s3-replication-filter

created branch time in 20 days

create barnchchlunde/provider-aws

branch : s3-storage-standard

created branch time in 20 days

create barnchchlunde/provider-aws

branch : s3-bucket-arn

created branch time in 20 days

push eventsparebank1utvikling/provider-aws

Carl Henrik Lunde

commit sha 22b4442bf2c5c66afb1edac825eb91603ce6f5f6

rds.rdsinstance: Add storage autoscaling (MaxAllocatedStorage) This parameter defines the upper limit to which Amazon RDS can automatically scale the storage of the DB instance. For more information about this setting, including limitations that apply to it, see Managing capacity automatically with Amazon RDS storage autoscaling (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_PIOPS.StorageTypes.html#USER_PIOPS.Autoscaling) in the Amazon RDS User Guide. Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

Carl Henrik Lunde

commit sha 765814e402b6536badb6315216b6da6a3b820fde

rds.database: fixup max allocated storage always diffs

view details

Carl Henrik Lunde

commit sha bd4229893e8372f4375b8f3082cab52bb769dc44

rds.rdsinstance: Add more ready states (can receive requests) States Modifying, Backing Up and Configuring Enhanced Monitoring Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

Carl Henrik Lunde

commit sha 433068055af0d62afa2e64894673f55cd7577092

rebase on master, 0.20-sb1-1

view details

Carl Henrik Lunde

commit sha f7b0392aec75b309fe69001c5bc6e3b543a98d71

rds diff debug

view details

Carl Henrik Lunde

commit sha df97cefdd8c7dd10b5d355230cc242fefd0ac23f

release

view details

Carl Henrik Lunde

commit sha a28af018d62fab8cb2cd05312a00a8122d1b06aa

database.rdsinstance: Avoid empty updates due to two cloud watch log fields / non-declarative API

view details

Carl Henrik Lunde

commit sha 3ac5e8358ac16165d59269d5279112d6469ca553

database.rdsinstance: Avoid extra reconciles due to moving timestamp in status

view details

Carl Henrik Lunde

commit sha 24af14a131433fa574cfda44d613fd30ece61ac3

database.rdsinstance: prevent diff on CloudwatchLogsExportConfiguration

view details

Carl Henrik Lunde

commit sha d7f448b0172e8bacdd45f23156c4ec9306d732cf

rds.database: ignore CloudwatchLogsExportConfiguration in diff

view details

Carl Henrik Lunde

commit sha 4266aca32a24e420ad2a259ef9de088c6330040a

s3.bucket: resolve bucket ARN in replication config references The replication destination bucket should resolve to an ARN, not a bucket name. Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

Carl Henrik Lunde

commit sha a5de1179bd8f3ba7ed5a353b5f0d745bd68a1ac6

s3: Add storage class STANDARD for replication configuration Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

Carl Henrik Lunde

commit sha 59d9f7e7bc4ee3447fa2928db0f24a3e3b632140

s3: replication configuration - always send filter For some reason the XML is malformed if not sending and empty element here using the Go AWS SDK. When looking at minimal XML files in the documentation, this element is not included, so I'm not sure what is going on here, but I think we should do this because the error message does not give any indication to the user on what the issue is. Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

Carl Henrik Lunde

commit sha 0b22e9a665283210447eb38e4ccd8cc90d30d19e

s3: fix deleteMarkerReplication.Status -> deleteMarkerReplication.status The JSON/YAML field name had an upper case first letter, which is not consistent with any other resource. Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

Carl Henrik Lunde

commit sha dbe78fd0c468dd55350906160874c62a8bfca5d7

release Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>

view details

push time in 20 days

issue commentistio/istio

panic in pilot: GetAdapter (when Istio installed with enableAnalysis: true)

@howardjohn FYI there was a PR that never got any review: https://github.com/istio/istio/pull/31982

chlunde

comment created time in 21 days

push eventsparebank1utvikling/provider-aws

Carl Henrik Lunde

commit sha 1e434db1bc8c6e47c6daea534b6012d58a3ddd90

s3: fix Status -> status Signed-off-by: Carl Henrik Lunde <carl.henrik.lunde@sparebank1.no>

view details

Carl Henrik Lunde

commit sha 1daefcbf547b37672201065a7d6853a817bdf0d9

s3: fixup STANDARD class

view details

Carl Henrik Lunde

commit sha 8222475252d60122d644b0d9d0f9dd4579e50210

release

view details

push time in 21 days