profile
viewpoint
chansuke chansuke Georepublic Japan Tokyo

alinz/react-native-webview-bridge 1297

React Native Webview with Javascript Bridge

chansuke/actix-remote 0

Distributed actors for actix framework.

chansuke/alacritty 0

A cross-platform, GPU-accelerated terminal emulator

chansuke/allocators-rs 0

Allocactors in Rust

chansuke/almin 0

Almin.js provide Flux/CQRS patterns for JavaScript application

chansuke/amazon-cognito-identity-js 0

Amazon Cognito Identity SDK for JavaScript

chansuke/amazon-ecs-agent 0

Amazon EC2 Container Service Agent

chansuke/amazon-ecs-cli 0

A custom Amazon ECS CLI that eases up the cluster setup process, enables users to run their applications locally or on ECS using the same Docker Compose file format and familiar Compose commands.

chansuke/annict 0

Rails 4.1とAngular.jsで開発中のアニメ視聴記録サービス「Annict」です。

chansuke/apig 0

Golang RESTful API Server Generator

issue commentrust-lang/rustfmt

Attributes on expressions become duplicated under certain conditions

@calebcartwright Thank you for your comment!! I will close my PR.

coadler

comment created time in a day

pull request commentrust-lang/rust

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/wasm

@Mark-Simulacrum I was reading the sys/sgx but couldn't figure out the specific differences between

https://github.com/rust-lang/rust/blob/6b8d7911a1d329d0d98b90606d8c2cb808af090a/library/std/src/sys/sgx/alloc.rs#L19-L38

and that part

https://github.com/rust-lang/rust/blob/ac48e62db85e6db4bbe026490381ab205f4a614d/library/std/src/sys/wasm/alloc.rs#L27-L47

and what let _lock = lock::lock(); refers to

chansuke

comment created time in 2 days

push eventchansuke/rust

Mark Rousskov

commit sha e023158145ece18176a2e93420600ccda0d0bc58

Permit uninhabited enums to cast into ints This essentially reverts part of #6204.

view details

Mark Rousskov

commit sha 990a39596cf3b33e550f2045f78a62970f8d78f8

Prevent ICE on uninhabited MIR interpretation

view details

Nathan West

commit sha a02014280586b53997622c501db00398376967a8

Refactor io/buffered.rs into submodules

view details

Nathan West

commit sha 96229f02402e82914ec6100b28ad2cbdd273a0d4

move buffered.rs to mod.rs

view details

Nathan West

commit sha 6d75cdfc9ed9e6987bd23add6cf3954d2499dce2

Added updated compiler diagnostic

view details

Amjad Alsharafi

commit sha da700cba08a2b194d19e63d3c51ebadce96fe46b

Stabilize move_ref_pattern

view details

Amjad Alsharafi

commit sha afb9eeb1b9ea16ca65e38673a0ef3e7be81d7252

Disabled error `E0007` from rustc_error_codes

view details

Mark Rousskov

commit sha 05c9c0ee5dcd935f518db151bee2dc88380fb92f

Modify executable checking to be more universal This uses a dummy file to check if the filesystem being used supports the executable bit in general.

view details

Nathan West

commit sha c4280af8285c61b367a87c8f6eef9876011a8150

Retry fix error reporting suggestions

view details

Temirkhan Myrzamadi

commit sha 13dfbb64d313137b7d3c33067910e90f27bc6345

Suggest imports of unresolved macros

view details

Temirkhan Myrzamadi

commit sha 479298e05e8177b171c6d6bcd35fc7553b424bee

Re-run tests with --bless

view details

Temirkhan Myrzamadi

commit sha ea7cf6106864ce7929eb9f3cfe580f05ee418ac8

Don't suggest macros that out of scope

view details

Waffle

commit sha 0b923d3ca0b7f5a1a611564ee48c1e92f896d79e

add `str::{Split,RSplit}::as_str` methods This commit introduses 2 methods under "str_split_as_str" gate with common signature of `&Split<'a, _> -> &'a str'`. Both of them work like `Chars::as_str` - return unyield part of the inner string.

view details

Waffle

commit sha 4747215d778abd9f280202d07f279fdeaea519f8

add `str::{SplitN, RSplitN, SplitTerminator, RSplitTerminator}::as_str` methods This commit entroduce 4 methods smililar to `Split::as_str` all under the same gate "str_split_as_str".

view details

Waffle

commit sha 076514c8a82591547116a7a2212c4de4bdc56f76

add `str::SplitInclusive::as_str` method This commit entroduces `core::str::SplitInclusive::as_str` method similar to `core::str::Split::as_str`, but under different gate - "str_split_inclusive_as_str" (this is done so because `SplitInclusive` is itself unstable).

view details

Alexander Mols

commit sha 8fe61546696b626ecf68ef838d5d82e393719e80

Use posix_spawn() on unix if program is a path Previously `Command::spawn` would fall back to the non-posix_spawn based implementation if the `PATH` environment variable was possibly changed. On systems with a modern (g)libc `posix_spawn()` can be significantly faster. If program is a path itself the `PATH` environment variable is not used for the lookup and it should be safe to use the `posix_spawnp()` method. [1] We found this, because we have a cli application that effectively runs a lot of subprocesses. It would sometimes noticeably hang while printing output. Profiling showed that the process was spending the majority of time in the kernel's `copy_page_range` function while spawning subprocesses. During this time the process is completely blocked from running, explaining why users were reporting the cli app hanging. Through this we discovered that `std::process::Command` has a fast and slow path for process execution. The fast path is backed by `posix_spawnp()` and the slow path by fork/exec syscalls being called explicitly. Using fork for process creation is supposed to be fast, but it slows down as your process uses more memory. It's not because the kernel copies the actual memory from the parent, but it does need to copy the references to it (see `copy_page_range` above!). We ended up using the slow path, because the command spawn implementation in falls back to the slow path if it suspects the PATH environment variable was changed. Here is a smallish program demonstrating the slowdown before this code change: ``` use std::process::Command; use std::time::Instant; fn main() { let mut args = std::env::args().skip(1); if let Some(size) = args.next() { // Allocate some memory let _xs: Vec<_> = std::iter::repeat(0) .take(size.parse().expect("valid number")) .collect(); let mut command = Command::new("/bin/sh"); command .arg("-c") .arg("echo hello"); if args.next().is_some() { println!("Overriding PATH"); command.env("PATH", std::env::var("PATH").expect("PATH env var")); } let now = Instant::now(); let child = command .spawn() .expect("failed to execute process"); println!("Spawn took: {:?}", now.elapsed()); let output = child.wait_with_output().expect("failed to wait on process"); println!("Output: {:?}", output); } else { eprintln!("Usage: prog [size]"); std::process::exit(1); } () } ``` Running it and passing different amounts of elements to use to allocate memory shows that the time taken for `spawn()` can differ quite significantly. In latter case the `posix_spawnp()` implementation is 30x faster: ``` $ cargo run --release 10000000 ... Spawn took: 324.275µs hello $ cargo run --release 10000000 changepath ... Overriding PATH Spawn took: 2.346809ms hello $ cargo run --release 100000000 ... Spawn took: 387.842µs hello $ cargo run --release 100000000 changepath ... Overriding PATH Spawn took: 13.434677ms hello ``` [1]: https://github.com/bminor/glibc/blob/5f72f9800b250410cad3abfeeb09469ef12b2438/posix/execvpe.c#L81

view details

Mara Bos

commit sha f84f01c0148cfb2451775fcbf299a2e7b10b1e81

Use futex-based thread-parker for Wasm32.

view details

Mara Bos

commit sha 54a71e89546886951e32035960aa82a15a343668

For backtrace, use StaticMutex instead of a raw sys Mutex.

view details

Mara Bos

commit sha e6d61ade9c1523dc2dd7cbd97206d6ebc5b5d481

Use slice_as_mut_ptr instead of first_ptr_mut. This function was renamed.

view details

Mara Bos

commit sha 0f26578f2e2e41c51279f3b2bd967785241d316d

Get rid of UnsafeCell<MaybeUninit>s in cloudabi mutex.

view details

push time in 2 days

pull request commentrust-lang/rust

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

chansuke

comment created time in 2 days

push eventchansuke/rust

chansuke

commit sha d3467fe520d17f26f3781286e6b6caab4700928e

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi

view details

push time in 2 days

push eventchansuke/rust

chansuke

commit sha c1d88957e42efb798448f393b13ed061133fe813

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi

view details

push time in 2 days

push eventchansuke/rust

Mateusz Mikuła

commit sha 0ad3da06843089c0bf10d6caa3fbbc72fa67787a

Enable ASLR for windows-gnu

view details

Mark Rousskov

commit sha e023158145ece18176a2e93420600ccda0d0bc58

Permit uninhabited enums to cast into ints This essentially reverts part of #6204.

view details

Mark Rousskov

commit sha 990a39596cf3b33e550f2045f78a62970f8d78f8

Prevent ICE on uninhabited MIR interpretation

view details

Nathan West

commit sha a02014280586b53997622c501db00398376967a8

Refactor io/buffered.rs into submodules

view details

Nathan West

commit sha 96229f02402e82914ec6100b28ad2cbdd273a0d4

move buffered.rs to mod.rs

view details

Nathan West

commit sha 6d75cdfc9ed9e6987bd23add6cf3954d2499dce2

Added updated compiler diagnostic

view details

Amjad Alsharafi

commit sha da700cba08a2b194d19e63d3c51ebadce96fe46b

Stabilize move_ref_pattern

view details

Amjad Alsharafi

commit sha afb9eeb1b9ea16ca65e38673a0ef3e7be81d7252

Disabled error `E0007` from rustc_error_codes

view details

Mark Rousskov

commit sha 05c9c0ee5dcd935f518db151bee2dc88380fb92f

Modify executable checking to be more universal This uses a dummy file to check if the filesystem being used supports the executable bit in general.

view details

Nathan West

commit sha c4280af8285c61b367a87c8f6eef9876011a8150

Retry fix error reporting suggestions

view details

Aaron Hill

commit sha cfe07cd42a92610219d6ffc1ae5eefef42f5254a

Use llvm::computeLTOCacheKey to determine post-ThinLTO CGU reuse During incremental ThinLTO compilation, we attempt to re-use the optimized (post-ThinLTO) bitcode file for a module if it is 'safe' to do so. Up until now, 'safe' has meant that the set of modules that our current modules imports from/exports to is unchanged from the previous compilation session. See PR #67020 and PR #71131 for more details. However, this turns out be insufficient to guarantee that it's safe to reuse the post-LTO module (i.e. that optimizing the pre-LTO module would produce the same result). When LLVM optimizes a module during ThinLTO, it may look at other information from the 'module index', such as whether a (non-imported!) global variable is used. If this information changes between compilation runs, we may end up re-using an optimized module that (for example) had dead-code elimination run on a function that is now used by another module. Fortunately, LLVM implements its own ThinLTO module cache, which is used when ThinLTO is performed by a linker plugin (e.g. when clang is used to compile a C proect). Using this cache directly would require extensive refactoring of our code - but fortunately for us, LLVM provides a function that does exactly what we need. The function `llvm::computeLTOCacheKey` is used to compute a SHA-1 hash from all data that might influence the result of ThinLTO on a module. In addition to the module imports/exports that we manually track, it also hashes information about global variables (e.g. their liveness) which might be used during optimization. By using this function, we shouldn't have to worry about new LLVM passes breaking our module re-use behavior. In LLVM, the output of this function forms part of the filename used to store the post-ThinLTO module. To keep our current filename structure intact, this PR just writes out the mapping 'CGU name -> Hash' to a file. To determine if a post-LTO module should be reused, we compare hashes from the previous session. This should unblock PR #75199 - by sheer chance, it seems to have hit this issue due to the particular CGU partitioning and optimization decisions that end up getting made.

view details

follower

commit sha e4943ac81163db364bd8c8ad1ea9c65b4adabcd3

Link to documentation-specific guidelines. Changed because it's not obvious how to get from the previously used URL to the documentation-specific content. This is partly because the original URL was previously changed to point to different content: * https://github.com/rust-lang/rust/pull/74037/files#diff-242481015141f373dcb178e93cffa850L88 * https://github.com/rust-lang/rust/commit/3f6928f1f6eff367e6ddbfb63ebc5e568ffe0eb1#diff-6a3371457528722a734f3c51d9238c13L12

view details

Arlo Siemsen

commit sha 0a4dc8bc161c68320a60a6bde525adae258b6252

Adds a GitHub Actions CI build for aarch64-pc-windows-msvc via cross-compilation on an x86_64 host. This promotes aarch64-pc-windows-msvc from a Tier 2 Compilation Target (std) to a Tier 2 Development Platform (std+rustc+cargo+tools). Fixes #72881

view details

Lzu Tao

commit sha 446f86e370884df01cbbacc584d67859c6c2a10b

Remove useless stringify

view details

Temirkhan Myrzamadi

commit sha 13dfbb64d313137b7d3c33067910e90f27bc6345

Suggest imports of unresolved macros

view details

Temirkhan Myrzamadi

commit sha 479298e05e8177b171c6d6bcd35fc7553b424bee

Re-run tests with --bless

view details

Temirkhan Myrzamadi

commit sha ea7cf6106864ce7929eb9f3cfe580f05ee418ac8

Don't suggest macros that out of scope

view details

Jake Goulding

commit sha 225ec813a9b25cdf94811d5b6c5207848cfef829

Add a cross-compiling aarch64-apple-darwin CI builder

view details

Jake Goulding

commit sha 2fe271e4c2b5f89108314177348d7732f533582f

Move aarch64-apple-darwin to tier 2 Drive-by fixes to update the naming of "OSX" [sic] to "macOS".

view details

Waffle

commit sha 0b923d3ca0b7f5a1a611564ee48c1e92f896d79e

add `str::{Split,RSplit}::as_str` methods This commit introduses 2 methods under "str_split_as_str" gate with common signature of `&Split<'a, _> -> &'a str'`. Both of them work like `Chars::as_str` - return unyield part of the inner string.

view details

push time in 2 days

push eventchansuke/rust

Mateusz Mikuła

commit sha 0ad3da06843089c0bf10d6caa3fbbc72fa67787a

Enable ASLR for windows-gnu

view details

Aaron Hill

commit sha cfe07cd42a92610219d6ffc1ae5eefef42f5254a

Use llvm::computeLTOCacheKey to determine post-ThinLTO CGU reuse During incremental ThinLTO compilation, we attempt to re-use the optimized (post-ThinLTO) bitcode file for a module if it is 'safe' to do so. Up until now, 'safe' has meant that the set of modules that our current modules imports from/exports to is unchanged from the previous compilation session. See PR #67020 and PR #71131 for more details. However, this turns out be insufficient to guarantee that it's safe to reuse the post-LTO module (i.e. that optimizing the pre-LTO module would produce the same result). When LLVM optimizes a module during ThinLTO, it may look at other information from the 'module index', such as whether a (non-imported!) global variable is used. If this information changes between compilation runs, we may end up re-using an optimized module that (for example) had dead-code elimination run on a function that is now used by another module. Fortunately, LLVM implements its own ThinLTO module cache, which is used when ThinLTO is performed by a linker plugin (e.g. when clang is used to compile a C proect). Using this cache directly would require extensive refactoring of our code - but fortunately for us, LLVM provides a function that does exactly what we need. The function `llvm::computeLTOCacheKey` is used to compute a SHA-1 hash from all data that might influence the result of ThinLTO on a module. In addition to the module imports/exports that we manually track, it also hashes information about global variables (e.g. their liveness) which might be used during optimization. By using this function, we shouldn't have to worry about new LLVM passes breaking our module re-use behavior. In LLVM, the output of this function forms part of the filename used to store the post-ThinLTO module. To keep our current filename structure intact, this PR just writes out the mapping 'CGU name -> Hash' to a file. To determine if a post-LTO module should be reused, we compare hashes from the previous session. This should unblock PR #75199 - by sheer chance, it seems to have hit this issue due to the particular CGU partitioning and optimization decisions that end up getting made.

view details

follower

commit sha e4943ac81163db364bd8c8ad1ea9c65b4adabcd3

Link to documentation-specific guidelines. Changed because it's not obvious how to get from the previously used URL to the documentation-specific content. This is partly because the original URL was previously changed to point to different content: * https://github.com/rust-lang/rust/pull/74037/files#diff-242481015141f373dcb178e93cffa850L88 * https://github.com/rust-lang/rust/commit/3f6928f1f6eff367e6ddbfb63ebc5e568ffe0eb1#diff-6a3371457528722a734f3c51d9238c13L12

view details

Arlo Siemsen

commit sha 0a4dc8bc161c68320a60a6bde525adae258b6252

Adds a GitHub Actions CI build for aarch64-pc-windows-msvc via cross-compilation on an x86_64 host. This promotes aarch64-pc-windows-msvc from a Tier 2 Compilation Target (std) to a Tier 2 Development Platform (std+rustc+cargo+tools). Fixes #72881

view details

Lzu Tao

commit sha 446f86e370884df01cbbacc584d67859c6c2a10b

Remove useless stringify

view details

Jake Goulding

commit sha 225ec813a9b25cdf94811d5b6c5207848cfef829

Add a cross-compiling aarch64-apple-darwin CI builder

view details

Jake Goulding

commit sha 2fe271e4c2b5f89108314177348d7732f533582f

Move aarch64-apple-darwin to tier 2 Drive-by fixes to update the naming of "OSX" [sic] to "macOS".

view details

Lzu Tao

commit sha 6cb062dacfed8e647361bc94694c7177beb17390

mips32: Add f64 hard-float support co-authored-by: Amanieu <amanieu@gmail.com>

view details

Lzu Tao

commit sha 79f477bb1fe81385aebde628e5a3f5c9168b24e0

Add asm! support for mips64

view details

Lzu Tao

commit sha 4d570fb45e7650f274853a2f47f86d17c2aa0784

Removes reg aliases since there are many ABIs: o32/n32/n64

view details

Bastian Kauschke

commit sha 536674fb69ea161f50f68f3fdb65950feffd92a4

cleanup WithOptConstParam queries

view details

Mingye Wang

commit sha a35a93f09cc111a53d00efc567ad678583dd5ac7

Pass tune-cpu to LLVM I think this is how it should work...

view details

Bastian Kauschke

commit sha 8160bfa39caad79a224ec44449efe48dd0c79c36

query_name_of_opt_const_arg -> query_name_opt_const_arg

view details

khyperia

commit sha ba22fbe58494784e3ee2a6800bb16588da2f595b

Add -Z codegen-backend dylib to deps When the codegen-backend dylib changes, the program should be rebuilt.

view details

Stein Somers

commit sha 97beb074aff40cb1b6444e9eff734a1a5c17dfc7

BTreeMap: derive type-specific variants of node_as_mut and cast_unchecked

view details

Guillaume Gomez

commit sha a215151cd357945acdb2675010708cb2d10bb4c0

Allow ascii whitespace char for doc aliases

view details

Guillaume Gomez

commit sha accc26abc0e53067d7a97d0fb19800c37a24f844

Add test for whitespace in doc alias

view details

Vadim Petrochenkov

commit sha 021fcbd90cebe83bb2f0298f2e7001605b5a97d7

rustc_target: Refactor away `TargetResult` Construction of a built-in target is always infallible now, so `TargetResult` is no longer necessary.

view details

Vadim Petrochenkov

commit sha 1444ad7ba1c34685fecf7b0413403151aba51e9d

rustc_target: Further simplify loading of built-in targets using the fact that it is infallible. JSON roundtrip check on every rustc run is also removed, it's already performed by unit tests.

view details

Guillaume Gomez

commit sha 11f3476c59ee013c017e669676cfaca00a67b3f1

Enforce whitespace ascii character check for doc alias

view details

push time in 2 days

push eventGeorepublic/Autolinker.js

chansuke

commit sha a30224ec462c5a87db70748e1c4eefa94dcc04cd

Add an another phone number types

view details

chansuke

commit sha 821b4b4153d63980fec7d96ce22557fcb612cfbd

Merge pull request #3 from Georepublic/add-japanese-style-regex Add an another phone number types

view details

push time in 4 days

push eventGeorepublic/Autolinker.js

chansuke

commit sha a30224ec462c5a87db70748e1c4eefa94dcc04cd

Add an another phone number types

view details

push time in 4 days

push eventGeorepublic/react-native-autolink

chansuke

commit sha bfdd5d83c78f7963c46ad40602487b6eeb221cb1

Fix path url

view details

chansuke

commit sha 1cdc1b96fe5c90c945888515974aa73a957671bf

Merge pull request #3 from Georepublic/update-repo-link Fix path url

view details

push time in 4 days

push eventGeorepublic/Autolinker.js

chansuke

commit sha 15e2093b13c63fc56106be955f034262e016e2d9

Add japanese style phone number regex

view details

chansuke

commit sha 6cbc5c6a3d035c4e0f6746ebeb5779f71e40cfcd

Merge branch 'master' into add-japanese-style-regex

view details

chansuke

commit sha 0304846b116de442b9e029fb8e4219526ed3b6f2

Merge pull request #2 from Georepublic/add-japanese-style-regex Add japanese style phone number regex

view details

push time in 4 days

push eventGeorepublic/Autolinker.js

chansuke

commit sha e9bb09543a2c6201fdc5281da94e47fd2d1eba4e

Add japanese style phone number regex

view details

chansuke

commit sha d0bdbb9b7b734e281506764961cbd26c95dbd9dc

Merge pull request #1 from Georepublic/add-japanese-style-regex Add japanese style phone number regex

view details

chansuke

commit sha 6cbc5c6a3d035c4e0f6746ebeb5779f71e40cfcd

Merge branch 'master' into add-japanese-style-regex

view details

push time in 4 days

push eventGeorepublic/Autolinker.js

chansuke

commit sha 15e2093b13c63fc56106be955f034262e016e2d9

Add japanese style phone number regex

view details

push time in 4 days

push eventGeorepublic/react-native-autolink

chansuke

commit sha bfdd5d83c78f7963c46ad40602487b6eeb221cb1

Fix path url

view details

push time in 4 days

push eventGeorepublic/react-native-autolink

chansuke

commit sha f99fc142e48dc98a74029c481fc89ee06c867250

Fix path url

view details

chansuke

commit sha a8e0a413452ae4b6239ca29db03e3ee1b0b08afa

Merge pull request #2 from Georepublic/update-repo-link Fix path url

view details

push time in 4 days

push eventGeorepublic/react-native-autolink

chansuke

commit sha f99fc142e48dc98a74029c481fc89ee06c867250

Fix path url

view details

push time in 4 days

push eventGeorepublic/react-native-autolink

chansuke

commit sha 1b17ce75062c00aa7daafbd1cb866db06e6acea0

Update repo link

view details

chansuke

commit sha c3f72dbce9d882e2047245e21d943a7ee8997cdc

Merge pull request #1 from Georepublic/update-repo-link Update repo link

view details

push time in 4 days

PR merged Georepublic/react-native-autolink

Update repo link

Use a custom version of Autolinker for a matcher.

+1 -1

0 comment

1 changed file

chansuke

pr closed time in 4 days

PR opened Georepublic/react-native-autolink

Update repo link

Use a custom version of Autolinker for a matcher.

+1 -1

0 comment

1 changed file

pr created time in 4 days

create barnchGeorepublic/react-native-autolink

branch : update-repo-link

created branch time in 4 days

push eventGeorepublic/Autolinker.js

chansuke

commit sha e9bb09543a2c6201fdc5281da94e47fd2d1eba4e

Add japanese style phone number regex

view details

chansuke

commit sha d0bdbb9b7b734e281506764961cbd26c95dbd9dc

Merge pull request #1 from Georepublic/add-japanese-style-regex Add japanese style phone number regex

view details

push time in 4 days

create barnchGeorepublic/Autolinker.js

branch : add-japanese-style-regex

created branch time in 4 days

push eventchansuke/rust

Matt Brubeck

commit sha b4b383981abac7ca8aa180c7ae3e28876615b887

Add PartialEq impls for Vec <-> slice

view details

kadmin

commit sha 8894b366fdb976a703fe76010f6e56c591cada1f

Remove error message in specific case In the case that a trait is not implemented for an ADT with type errors, cancel the error.

view details

Mateusz Mikuła

commit sha 0ad3da06843089c0bf10d6caa3fbbc72fa67787a

Enable ASLR for windows-gnu

view details

Cassandra Fridkin

commit sha a009e2838b25df2761093d727d322a59f69d8f68

There isn't a way to pass --remove yet, but you can rm if u like

view details

Alexis Bourget

commit sha 492826ac144666c75d68bc0a0121453ecc08561f

Add a note about the panic behavior of math operations on time objects

view details

Tim Nielens

commit sha 390a13b06c79d4177b829097b06453e38188081f

needless-lifetime - fix nested elision site FPs

view details

Tim Nielens

commit sha a60e5de90c7370d4fb3e6561d3cb55495cda2e2a

needless-lifetime / nested elision sites / PR remarks

view details

Tim Nielens

commit sha c8e9e52303da6dff4bc5cc4db3021d608fca6c70

needless-lifetime / add test cases for nested elision sites

view details

Takayuki Nakata

commit sha 1778a1ec4615a42a8ba9497006b07859186c08a1

Restrict `same_item_push` to suppress false positives It emits a lint when the pushed item is a literal, a constant and an immutable binding that are initialized with those.

view details

Takayuki Nakata

commit sha 0117ea2b016133145f9e02e27421ac3672b42f57

Refactoring: use inner function

view details

Takayuki Nakata

commit sha b80576fba633e1fc214c9f6900d7ca3424bda6d0

Some refactoring

view details

Takayuki Nakata

commit sha 14faebe20ea82392f393c3ff5efaab7250e51989

Add some tests to `same_item_push` Add tests in which the variable is initialized with a match expression and function call

view details

Takayuki Nakata

commit sha 2972ad3ef661071531a61ec8999b668a6b734b74

Refactoring: tests in `same_item_push`

view details

Takayuki Nakata

commit sha 730ca457f580247667ed0cd5965bc08752ebc0b3

Address `items_after_statement`

view details

Dylan MacKenzie

commit sha 72b402ed38f0c71461038aef8a49a02e49280788

Add pass names to some common dataflow analyses

view details

Jubilee Young

commit sha ac96f5b39ca7d9fad8571595c476c2db0bce8438

Test and reject out-of-bounds shuffle vectors

view details

Aaron Hill

commit sha cfe07cd42a92610219d6ffc1ae5eefef42f5254a

Use llvm::computeLTOCacheKey to determine post-ThinLTO CGU reuse During incremental ThinLTO compilation, we attempt to re-use the optimized (post-ThinLTO) bitcode file for a module if it is 'safe' to do so. Up until now, 'safe' has meant that the set of modules that our current modules imports from/exports to is unchanged from the previous compilation session. See PR #67020 and PR #71131 for more details. However, this turns out be insufficient to guarantee that it's safe to reuse the post-LTO module (i.e. that optimizing the pre-LTO module would produce the same result). When LLVM optimizes a module during ThinLTO, it may look at other information from the 'module index', such as whether a (non-imported!) global variable is used. If this information changes between compilation runs, we may end up re-using an optimized module that (for example) had dead-code elimination run on a function that is now used by another module. Fortunately, LLVM implements its own ThinLTO module cache, which is used when ThinLTO is performed by a linker plugin (e.g. when clang is used to compile a C proect). Using this cache directly would require extensive refactoring of our code - but fortunately for us, LLVM provides a function that does exactly what we need. The function `llvm::computeLTOCacheKey` is used to compute a SHA-1 hash from all data that might influence the result of ThinLTO on a module. In addition to the module imports/exports that we manually track, it also hashes information about global variables (e.g. their liveness) which might be used during optimization. By using this function, we shouldn't have to worry about new LLVM passes breaking our module re-use behavior. In LLVM, the output of this function forms part of the filename used to store the post-ThinLTO module. To keep our current filename structure intact, this PR just writes out the mapping 'CGU name -> Hash' to a file. To determine if a post-LTO module should be reused, we compare hashes from the previous session. This should unblock PR #75199 - by sheer chance, it seems to have hit this issue due to the particular CGU partitioning and optimization decisions that end up getting made.

view details

Hoe Hao Cheng

commit sha 3c582db8cb43dac1d13dd653078a68753d4baa99

Implement as_ne_bytes for floats and integers

view details

Hanif Bin Ariffin

commit sha dc655b28424549a4775bc2e8c9021d44482bccb1

Prevent stackoverflow

view details

LingMan

commit sha a6ff925f8b5598a1f6d84964525baa1d4a08fd63

Reduce boilerplate with the matches! macro Replaces simple bool `match`es of the form match $expr { $pattern => true _ => false } and their inverse with invocations of the matches! macro.

view details

push time in 5 days

PR opened gregjacobs/Autolinker.js

Add japanese style phone number regex

Hi. This is my request for phone number regex to add a japanese phone number which is described as XX-XXXX-XXXX or XX-(XXXX)-XXXX. #330

+53 -18

0 comment

8 changed files

pr created time in 7 days

create barnchchansuke/Autolinker.js

branch : add-japanese-style-regex

created branch time in 7 days

issue openedgregjacobs/Autolinker.js

Request: Add japanese style phone number.

Hi. Thank you for the great library.

I'd like to add a japanese style phone number(which is xx-xxxx-xxxx) regex to phone validation.

It will be super useful...

created time in 7 days

fork chansuke/Autolinker.js

Utility to Automatically Link URLs, Email Addresses, Phone Numbers, Twitter handles, and Hashtags in a given block of text/HTML

fork in 7 days

fork chansuke/react-native-autolink

Automatic linking of URLs, phone numbers, emails, handles, etc. in strings for React Native

fork in 7 days

starteddenoland/deno_lint

started time in 8 days

startedservo/rust-smallvec

started time in 9 days

push eventchansuke/rust-clippy

Takayuki Nakata

commit sha 1778a1ec4615a42a8ba9497006b07859186c08a1

Restrict `same_item_push` to suppress false positives It emits a lint when the pushed item is a literal, a constant and an immutable binding that are initialized with those.

view details

Takayuki Nakata

commit sha 0117ea2b016133145f9e02e27421ac3672b42f57

Refactoring: use inner function

view details

Takayuki Nakata

commit sha b80576fba633e1fc214c9f6900d7ca3424bda6d0

Some refactoring

view details

Takayuki Nakata

commit sha 14faebe20ea82392f393c3ff5efaab7250e51989

Add some tests to `same_item_push` Add tests in which the variable is initialized with a match expression and function call

view details

Takayuki Nakata

commit sha 2972ad3ef661071531a61ec8999b668a6b734b74

Refactoring: tests in `same_item_push`

view details

Takayuki Nakata

commit sha 730ca457f580247667ed0cd5965bc08752ebc0b3

Address `items_after_statement`

view details

rail

commit sha dc89bb1135afc31fc9ee2272e627192c04354d22

Use if_chain in Increment/InitializeVisitor

view details

rail

commit sha 116f30dc33d9e3744f257f2f7f5467acfbff178b

Use else blocks instead of return statements in Increment/InitializeVisitor

view details

rail

commit sha b2d5b89a1de15df9052fdf44d01b174add82837f

Check if it's after the loop earlier

view details

rail

commit sha 31cb1109648bf4242cab47571343578244e7fb9d

add concinient methods to Increment/InitializeVisitor

view details

rail

commit sha c599e2fcfaaedb12b560f4136bab3d0b450acf8f

Split VarState

view details

rail

commit sha 13c207d3756754c54a6b20d852087616d5abfbf4

Generalise `InitializeVisitor`

view details

rail

commit sha 9573a0d378033a81e55ca834a5d305d3cf2be24d

Rename variables

view details

rail

commit sha 1026b42f0694eb9239b5cebe80be743d5ded0da5

Rename a struct and variables

view details

rail

commit sha b4b4da162f19e9a4c63854a2b5a6167b83f9d8b9

Introduce Start and StartKind

view details

rail

commit sha 720f19f2ec4282f636889b35beabf31272e3b1b2

Implement detecting `manual_memcpy` with loop counters

view details

rail

commit sha de56279cd9047832216e1d1c06dc45375bf01b31

Implement building the `manual_memcpy` sugggestion with loop counters

view details

rail

commit sha 8da6cfd17b7707d678d01a6688572169015ea83e

fmt

view details

rail

commit sha d9a88be0b05c2cfec0679caf428d129c9d46256d

Rename `get_offset` and its private items

view details

rail

commit sha 774e82a566c6c3349700a8bece44d6a8c6755039

Add the tests for `manual_memcpy` with loop counters

view details

push time in 9 days

push eventchansuke/rust-wasm-webgl

chansuke

commit sha 9ec811ac5e2e4363c99ab889179ef97cdf1b8ffe

hello world

view details

chansuke

commit sha 0eacb45e6d7a1e3e7efefafa41f53acad64e1419

Merge branch 'main' into fix

view details

chansuke

commit sha d86fc9c5bed8361fccbd494b0cea3f0523f73e52

Merge pull request #1 from chansuke/fix hello world

view details

push time in 9 days

PR merged chansuke/rust-wasm-webgl

hello world
+13 -14

0 comment

3 changed files

chansuke

pr closed time in 9 days

push eventchansuke/rust-wasm-webgl

chansuke

commit sha 40ffbecc4eb25d234cd088f84b5a79098e03ea1b

WIP: hello world

view details

chansuke

commit sha 0eacb45e6d7a1e3e7efefafa41f53acad64e1419

Merge branch 'main' into fix

view details

push time in 9 days

PR opened chansuke/rust-wasm-webgl

hello world
+43 -11

0 comment

4 changed files

pr created time in 9 days

create barnchchansuke/rust-wasm-webgl

branch : fix

created branch time in 9 days

pull request commentrust-lang/rust

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi

@crlf0710 I fixed the compilation error, thanks.

chansuke

comment created time in 10 days

startedspencertipping/jit-tutorial

started time in 10 days

push eventchansuke/rust

flip1995

commit sha f1f1e0ba8ea1895eb2568e9d19378bbe43a17bcb

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

view details

flip1995

commit sha d1f9cad102b5686f2b827f3c62a02dfe419128a6

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

view details

flip1995

commit sha d445493479711389f4dea3a0f433041077ba2088

Update Cargo.lock

view details

bors

commit sha 893fadd11a52aa26fc19c67ee1b79f03d6a1bed3

Auto merge of #76820 - jyn514:query-comments, r=davidtwco Preserve doc-comments when generating queries Closes https://github.com/rust-lang/rust/issues/76812

view details

Mark Rousskov

commit sha 4de836e2141c418d37e556bc80c4ad0127d74b71

Install std for non-host targets

view details

bors

commit sha 019c0d5f7f90f959ff92684a04b0d766b22527a5

Auto merge of #6076 - rail-rain:fix_fp_explicit_counter_loop, r=matthiaskrgr Fix a FP in `explicit_counter_loop` Fixes #4677 and #6074 Fix a false positive in `explicit_counter_loop` where the loop counter is used after incremented, adjust the test so that counters are incremented at the end of the loop and add the test for this false positive. --- changelog: Fix a false positive in `explicit_counter_loop` where the loop counter is used after incremented

view details

bors

commit sha cc1998f7b3cc04c891f92c62a52c0c45fa4c145a

Auto merge of #6077 - ebroto:revert_or_fun_call_const, r=matthiaskrgr Revert: or_fun_call should lint calls to `const fn`s with no args The changes in #5889 and #5984 were done under the incorrect assumption that a `const fn` with no args was guaranteed to be evaluated at compile time. A `const fn` is only guaranteed to be evaluated at compile time if it's inside a const context (the initializer of a `const` or a `static`). See this [zulip conversation](https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Common.20misconception.3A.20.60const.20fn.60.20and.20its.20effect.20on.20codegen/near/208059113) for more details on this common misconception. Given that none of the linted methods by `or_fun_call` can be called in const contexts, the lint should make no exceptions. changelog: [`or_fun_call`] lints again calls to `const fn` with no args

view details

Takayuki Nakata

commit sha 2892a2b0f578edd290b3be6f5e5c3280bc160f24

Fix FP in `print_stdout` This lint shouldn't be emitted in `build.rs` as `println!` and `print!` are used for the build script.

view details

Joshua Nelson

commit sha 9baa601afd50f57655be9eb7e5e2892c2ea9f005

Add `x.py setup` - Suggest `x.py setup` if config.toml doesn't exist yet (twice, once before and once after the build) - Prompt for a profile if not given on the command line - Print the configuration file that will be used - Print helpful starting commands after setup - Link to the dev-guide after finishing - Note that distro maintainers will see the changelog warning

view details

Lzu Tao

commit sha 382d7243a70f7b9fd9330334a12f76985067ef06

move test to intergrated test in library/core

view details

Oliver Scherer

commit sha fc9f2947dab6ad7856986ce98ebd3b75f5293da0

Document `FallbackToConstRef` and make sure we don't accidentally use it

view details

Oliver Scherer

commit sha 40629ef827220f4be8f043f6ff28118af22ea3dd

Always cache const eval queries

view details

Oliver Scherer

commit sha daf976f6129e5fb16effc48bf91853548774e235

Revert a test change to make sure it's still testing the original issue

view details

bors

commit sha 87d262acb50200d767baa7115f30c650a13672ee

Auto merge of #77006 - oli-obk:🐌_const_queries, r=Mark-Simulacrum Cache `eval_to_allocation_raw` on disk https://github.com/rust-lang/rust/pull/74949#issuecomment-695833161 regressed the performance on these queries, this PR gets the perf back.

view details

Mara Bos

commit sha bab15f773afd5724023d9a065b5af276e2468ff5

Remove std::io::lazy::Lazy in favour of SyncOnceCell The (internal) std::io::lazy::Lazy was used to lazily initialize the stdout and stdin buffers (and mutexes). It uses atexit() to register a destructor to flush the streams on exit, and mark the streams as 'closed'. Using the stream afterwards would result in a panic. Stdout uses a LineWriter which contains a BufWriter that will flush the buffer on drop. This one is important to be executed during shutdown, to make sure no buffered output is lost. It also forbids access to stdout afterwards, since the buffer is already flushed and gone. Stdin uses a BufReader, which does not implement Drop. It simply forgets any previously read data that was not read from the buffer yet. This means that in the case of stdin, the atexit() function's only effect is making stdin inaccessible to the program, such that later accesses result in a panic. This is uncessary, as it'd have been safe to access stdin during shutdown of the program. --- This change removes the entire io::lazy module in favour of SyncOnceCell. SyncOnceCell's fast path is much faster (a single atomic operation) than locking a sys_common::Mutex on every access like Lazy did. However, SyncOnceCell does not use atexit() to drop the contained object during shutdown. As noted above, this is not a problem for stdin. It simply means stdin is now usable during shutdown. The atexit() call for stdout is moved to the stdio module. Unlike the now-removed Lazy struct, SyncOnceCell does not have a 'gone and unusable' state that panics. Instead of adding this again, this simply replaces the buffer with one with zero capacity. This effectively flushes the old buffer *and* makes any writes afterwards pass through directly without touching a buffer, making print!() available during shutdown without panicking.

view details

Mara Bos

commit sha e9b25f520bd2e3687213aa1162e631b08b9bf7ed

Add test to check stdout flushing during shutdown.

view details

Mara Bos

commit sha 45700a9d58679131a628ddc95dd8ce0fcf1f2430

Drop use of Arc from Stdin and Stdout.

view details

Bram van den Heuvel

commit sha b832a97a51f510c77f8187c00be3b3544e195e2b

Update chalk to 0.22.0

view details

Bram van den Heuvel

commit sha 52eeff6fbea7a3252ae292c8c4e23b4c7816e719

Update chalk to 0.23.0

view details

Bram van den Heuvel

commit sha cb660c6ab5c6c2c3ab7c4bd10535e68a49b940a0

Update chalk to 0.24.0

view details

push time in 10 days

push eventchansuke/rust

Matt Brubeck

commit sha b4b383981abac7ca8aa180c7ae3e28876615b887

Add PartialEq impls for Vec <-> slice

view details

kadmin

commit sha 8894b366fdb976a703fe76010f6e56c591cada1f

Remove error message in specific case In the case that a trait is not implemented for an ADT with type errors, cancel the error.

view details

Cassandra Fridkin

commit sha a009e2838b25df2761093d727d322a59f69d8f68

There isn't a way to pass --remove yet, but you can rm if u like

view details

Alexis Bourget

commit sha 492826ac144666c75d68bc0a0121453ecc08561f

Add a note about the panic behavior of math operations on time objects

view details

Tim Nielens

commit sha 390a13b06c79d4177b829097b06453e38188081f

needless-lifetime - fix nested elision site FPs

view details

Tim Nielens

commit sha a60e5de90c7370d4fb3e6561d3cb55495cda2e2a

needless-lifetime / nested elision sites / PR remarks

view details

Tim Nielens

commit sha c8e9e52303da6dff4bc5cc4db3021d608fca6c70

needless-lifetime / add test cases for nested elision sites

view details

Takayuki Nakata

commit sha 1778a1ec4615a42a8ba9497006b07859186c08a1

Restrict `same_item_push` to suppress false positives It emits a lint when the pushed item is a literal, a constant and an immutable binding that are initialized with those.

view details

Takayuki Nakata

commit sha 0117ea2b016133145f9e02e27421ac3672b42f57

Refactoring: use inner function

view details

Takayuki Nakata

commit sha b80576fba633e1fc214c9f6900d7ca3424bda6d0

Some refactoring

view details

Takayuki Nakata

commit sha 14faebe20ea82392f393c3ff5efaab7250e51989

Add some tests to `same_item_push` Add tests in which the variable is initialized with a match expression and function call

view details

Takayuki Nakata

commit sha 2972ad3ef661071531a61ec8999b668a6b734b74

Refactoring: tests in `same_item_push`

view details

Takayuki Nakata

commit sha 730ca457f580247667ed0cd5965bc08752ebc0b3

Address `items_after_statement`

view details

Dylan MacKenzie

commit sha 72b402ed38f0c71461038aef8a49a02e49280788

Add pass names to some common dataflow analyses

view details

Jubilee Young

commit sha ac96f5b39ca7d9fad8571595c476c2db0bce8438

Test and reject out-of-bounds shuffle vectors

view details

Hoe Hao Cheng

commit sha 3c582db8cb43dac1d13dd653078a68753d4baa99

Implement as_ne_bytes for floats and integers

view details

Hanif Bin Ariffin

commit sha dc655b28424549a4775bc2e8c9021d44482bccb1

Prevent stackoverflow

view details

LingMan

commit sha a6ff925f8b5598a1f6d84964525baa1d4a08fd63

Reduce boilerplate with the matches! macro Replaces simple bool `match`es of the form match $expr { $pattern => true _ => false } and their inverse with invocations of the matches! macro.

view details

sharnoff

commit sha 8a011b5da2cc289fb7d970492ea4111980676412

minor doc changes, attribute orderings

view details

rail

commit sha 5e393c7747d081c45414060f81016e9ea3cb961f

Fix a FP in `explicit_counter_loop` Fix a false positive in `explicit_counter_loop` where the loop counter is used after incremented, adjust the test so that counters are incremented at the end of the loop and add the test for this false positive.

view details

push time in 10 days

create barnchchansuke/rustfmt

branch : fix-duplicated-expressions

created branch time in 10 days

pull request commentrust-lang/rust-clippy

Fix unwrap not to lint the #[test]ing code

@flip1995 i need help, thanks.

chansuke

comment created time in 10 days

issue commentrust-lang/rustfmt

Attributes on expressions become duplicated under certain conditions

@calebcartwright Thank you for your comment!! I will try adding ast::ExprKind::Cast(ref subexpr) => mk_sp(subexpr.attrs[0].span.lo(), subexpr.span.hi()) to the arm.

coadler

comment created time in 10 days

push eventchansuke/rust

chansuke

commit sha 4d34a584af8796de01c495f15302b0673de614d9

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/wasm

view details

push time in 11 days

push eventchansuke/rust-clippy

Felix S. Klock II

commit sha 5747c15961da9d2d0b0dd775174d39f3b5961597

Prevent forbid from being ignored if overriden at the same level. That is, this changes `#[forbid(foo)] #[allow(foo)]` from allowing foo to forbidding foo.

view details

Robin Schoonover

commit sha f34f4a732714c397c30055feddb2b520b6acd38e

Change clippy's Constant back to refcount clone byte strings

view details

Philipp Hansch

commit sha 4b459596a96a7d6f4797d4f1444311d88df60009

clippy_dev: Replace lazy_static with SyncLazy

view details

Philipp Hansch

commit sha 9b4ceee5930e5a7118ac25a0f424a7f83d01980f

integration tests: Replace lazy_static with SyncLazy

view details

Yuki Okushi

commit sha a7b721968a75be2b21c180d87328db02eb823376

Rollup merge of #77534 - Mark-Simulacrum:issue-70819-disallow-override-forbid-in-same-scope, r=petrochenkov Disallow overriding forbid in same scope Rebased #73379. Fixes #70819.

view details

Yuki Okushi

commit sha 22c5e0c34760b5d8f8a3c815f01ca2ed20d4ceeb

Rollup merge of #77560 - rschoon:fix-litkind-rc-bytebuf, r=lcnr Fix LitKind's byte buffer to use refcounted slice While working on adding a new lint for clippy (see https://github.com/rust-lang/rust-clippy/pull/6044) for avoiding shared ownership of "mutable buffer" types (such as using `Rc<Vec<T>>` instead of `Rc<[T]>`), I noticed a type exported from rustc_ast and used by clippy gets caught by the lint. This PR fixes the exported type. This PR includes the actual change to clippy too, but I will open a PR directly against clippy for that part (although it will currently fail to build there).

view details

Matthew Jasper

commit sha adb7fc6283711c881186ca85bb9ac3bb8add099b

Fix tools

view details

Philipp Hansch

commit sha da57a16872297de5b6bb7754f722381631d4dca4

clippy_lints: Replace lazy_static with SyncLazy

view details

Ivan Tham

commit sha 7021d70d2e57e081597ea34eb18226a71b665ecd

Use more concrete explanation for methods Show some code rather than "a single method call".

view details

flip1995

commit sha b05aeaa9bce36d69d9ee13d1b5f6a271b6e8c1e5

Run fmt

view details

bors

commit sha 1a4175bcec39f36654aa8b377c657b2ce47b8f7d

Auto merge of #6126 - flip1995:rustup, r=flip1995 Rustup Supersedes #6121. There was another breakage. r? `@ghost` changelog: none

view details

Eduardo Broto

commit sha 6c3611bdef09170a4b889dc759f986490a528e42

Reinstate test for forbid blanket restriction

view details

bors

commit sha c8d89ba5d52463b365e4d7306cff01401a621fb0

Auto merge of #6127 - ebroto:reinstate_forbid_restriction, r=flip1995 Reinstate test for forbid(clippy::restriction) In [this commit](https://github.com/rust-lang/rust-clippy/pull/6126/commits/5747c15961da9d2d0b0dd775174d39f3b5961597) coming from rust-lang/rust (#6126) the test for `#![forbid(clippy::restriction)]` was removed because some restriction lints were being allowed after the forbid. This change reinstates the test for `forbid` by using a separate file. changelog: none r? `@flip1995`

view details

bors

commit sha 14e72696a693ef6618a236062cce8b16f8ee1383

Auto merge of #6124 - pickfire:patch-1, r=flip1995 Use more concrete explanation for methods *Please keep the line below* changelog: none

view details

bors

commit sha 277191890b60b28790d2d100191d6bc3d8975920

Auto merge of #6120 - phansch:replace-lazy-static, r=Manishearth Replace some lazy_static usage with once_cell feature This replaces some `lazy_static` usage with [`SyncLazy`](https://doc.rust-lang.org/nightly/std/lazy/struct.SyncLazy.html) of the unstable `once_cell` feature. changelog: none

view details

push time in 13 days

push eventchansuke/rust-clippy

Eduardo Broto

commit sha 9365660a2fc57210996df733efe468019c671b2f

unnecessary sort by: avoid dereferencing closure param

view details

Michael Howell

commit sha 840f7daaadb1222c4355dbb72cabdcf912cb8877

Deprecate clippy lint

view details

bors

commit sha 2ed5143c0ec88fe4cf0e3528bb4aca11059c2c83

Auto merge of #6111 - flip1995:rustup, r=flip1995 Rustup r? `@ghost` changelog: Deprecate [`drop_bounds`] lint. This lint was uplifted to rustc with the same name.

view details

Dylan MacKenzie

commit sha 29d43f63bd41e794162a8118b422eff66b5f47eb

clippy: `(Body, DefId)` -> `Body`

view details

FliegendeWurst

commit sha 78695bd4968d45ef6afd3433af4bf6f310128770

Do not lint float fractions in `mistyped_literal_suffixes` (fixes #4706)

view details

FliegendeWurst

commit sha 428ef362d6901029bbf945d5f440f4122ebcece6

Fix test formatting

view details

Eduardo Broto

commit sha 5f492490a30e65984095287d120d78c12015c09b

Merge remote-tracking branch 'upstream/master' into rustup

view details

Eduardo Broto

commit sha 5554641fceb640116316201bf669c04e1f86fcc3

Fix rustup fallout

view details

bors

commit sha 411e3bac569272a72ea17d823b1231594c73f540

Auto merge of #6118 - ebroto:rustup, r=ebroto Rustup changelog: none r? `@ghost`

view details

bors

commit sha 3239b46e920be50dd486d7565db070598aa65a46

Auto merge of #6114 - FliegendeWurst:no-mistyped-fraction, r=Manishearth Do not lint float fractions in `mistyped_literal_suffixes` As suggested in https://github.com/rust-lang/rust-clippy/issues/4706#issuecomment-544797928, the fractional part is now ignored (the integer part is checked instead). Fixes: #4706 changelog: `mistyped_literal_suffixes` no longer warns on the fractional part of a float (e.g. 713.23_64)

view details

bors

commit sha c9fdeef643329266cedb67369328795c4abb7740

Auto merge of #6078 - ebroto:unnecessary_sort_by_take_2, r=phansch unnecessary sort by: avoid dereferencing the suggested closure parameter This change tries to simplify the solution for problematic cases but is less restrictive than #6006. * We can't dereference shared references to non-Copy types, so the new suggestion does not do that. Note that this implies that the suggested closure parameter will be a reference. * We can't take a reference to the closure parameter in the returned key, so we don't lint in those cases. This can happen either because the key borrows from the parameter (e.g. `|a| a.borrows()`), or because we suggest `|a| Reverse(a)`. If we did we would hit this error: ``` error: lifetime may not live long enough --> /home/ebroto/src/ebroto-clippy/tests/ui/unnecessary_sort_by.fixed:19:25 | 19 | vec.sort_by_key(|b| Reverse(b)); | -- ^^^^^^^^^^ returning this value requires that `'1` must outlive `'2` | || | |return type of closure is Reverse<&'2 isize> | has type `&'1 isize` error: aborting due to previous error ``` Note that Clippy does not currently have the (MIR-based) machinery necessary to check that what is borrowed is actually the closure parameter. changelog: [`unnecessary_sort_by`]: avoid dereferencing the suggested closure parameter Fixes #6001

view details

push time in 13 days

startedRDambrosio016/RSLint

started time in 15 days

issue commentrust-lang/rustfmt

Attributes on expressions become duplicated under certain conditions

@calebcartwright I'm trying to fix this issue and update the first attribute of ast::ExprKind::Cast() in src/formatting/expr.rs but I have no idea to how to find the subexpr has attributes case. Could you give me a suggestion for that...

coadler

comment created time in 15 days

fork chansuke/krabs

An x86 bootloader written in Rust.

fork in 16 days

push eventchansuke/rustfmt

Teddy Sudol

commit sha c36f760cf8be17349a2db70288b674b4884c0a9f

Turn closure bodies from exprs into blocks if there are comments (#4396) * Added test cases * Kind of working, need to refactor. * Final code * Update closures.rs * Update comments. * Use argument span instead of calculating between_span. * Add test cases for #[attr]s. * Use first attr instead of body span, if it exists. * Use rewrite_missing_comment so comments are correctly folded into blocks. * Update closures.rs * Use ? not unwrap()

view details

Caleb Cartwright

commit sha 334e297ad7735ea010bfcc0d3a2d849a08fed255

docs: update label references in Contributing guide

view details

Caleb Cartwright

commit sha 02a3ed45727fcc471095c96fc2d21c7b2064ec68

deps: bump rustc-ap to v672

view details

Caleb Cartwright

commit sha d0caafb8d80d0033c4595fba4d61b21234badfcf

deps: bump rustc-ap v673

view details

Caleb Cartwright

commit sha 62134d00e2bb6f4517967f97ab14fa8e91ac5ad9

deps: bump rustc-ap v677

view details

Caleb Cartwright

commit sha 3eab675193d4a364239bb5fac9be339fe277b53c

chore: run rustfmt

view details

Grachev Mikhail

commit sha 4e72871510a3a3487e67e1e3a453efcb855c2ea2

Change directory name in test_merged_config test (#4409) Fix #4405

view details

David Bar-On

commit sha 6646248ffce9741a748bc8f5aa25dec0d85ccb17

Formatting pre and post cast comments enhancements (#4406) * Fix issues in handling cast pre/post comments and adding test cases * Add target for cast pre/post comments test cases * Add test cases related to #2896 and #3528 * Changes per comments to the original PR

view details

Seiichi Uchida

commit sha aa8e60119fc2606e7177c970b12db7079089471d

Format error and typeof types (#4416) * Add a test for #4357 * Format error and typeof types

view details

Caleb Cartwright

commit sha 3c19c4d6b4669650fc938ae71ee3ec74d3d02815

deps: bump rustc-ap to v678 (#4423)

view details

David Tolnay

commit sha 39fe0e12ea7fefc50e4be346b9ea90c308587979

Use rustfmt given by RUSTFMT env var (#4419)

view details

IceTDrinker

commit sha 4a88598ec7f76ac86b656d3daeaa06b1b1e1f197

BraceStyle AlwaysNewLine for unsafe blocks * Unsafe blocks can now get an opening brace on a new line * Add test case for unsafe blocks

view details

David Tolnay

commit sha 197237557fe880fe3e0b61e8f0303d6cdd53282a

deps: bump rustc-ap to v679

view details

David Tolnay

commit sha 2927e89b5194ecc887d61249eed9739ff1c3a3d5

Add regression test for unsafe mods

view details

WhizSid

commit sha 0476b3983afe08bc0b9b8f57fdfbf28404123e01

Fixed comment formatting issue between assignment operator and rhs (#4440) * Fixed comment formatting issue between assignment * rewrite_rhs_with_comments method * Add more tests * Added more test cases and optimized * Removed extra new lines * Removed accidentally pushed tmp file

view details

Caleb Cartwright

commit sha 22c4437b3f1812d90b6f3313de574065481a99b4

docs: add feature request issue template

view details

Matt Blessed

commit sha c240f104bf6f9f9c8afdd9fa186c0e52fc97d333

BraceStyle AlwaysNewLine for extern blocks * extern blocks can now get an opening brace on a new line * add test case for extern blocks

view details

push time in 16 days

PR closed DefinitelyTyped/DefinitelyTyped

Add `instantiate()` to WebAssembly Perf: Same Revision needed

Added definition of instantidate() method of WebAssembly.

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/instantiate>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+9 -0

5 comments

2 changed files

chansuke

pr closed time in 16 days

pull request commentDefinitelyTyped/DefinitelyTyped

Add `instantiate()` to WebAssembly

@jhenninger Ok, thanks!! i will close this.

chansuke

comment created time in 16 days

pull request commentrust-lang/rust

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi

@crlf0710 Sorry, no progress on this issue...

chansuke

comment created time in 16 days

pull request commentrust-lang/rust

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/wasm

@JohnCSimon I have updated my previous commit. Thanks.

chansuke

comment created time in 16 days

push eventchansuke/rust

Pietro Albini

commit sha 3bddfea7e23341f788526f8b303b9a27038511e3

build-manifest: stop receiving release numbers from bootstrap

view details

Mark Rousskov

commit sha 15adc2ee830385293c3f826869033003130d904e

Remove duplicate macOS builders

view details

Mark Rousskov

commit sha d0dff8f873a80f4995e4e90bf865747eab8226db

Make sure we build target-only things (e.g., docs) for host platforms too

view details

Aaron Hill

commit sha 6a96aea36ace13ad5b1be8cce0073ee8c2f2f32a

Wrap recursive predicate evaluation with `ensure_sufficient_stack` I haven't been able to come up with a minimized test case for #76770, but this fixes a stack overflow in rustc as well.

view details

bors

commit sha 9f8ac718f44e280edb1a7b3266f2c26106ec11a0

Auto merge of #76575 - lcnr:abstract-const, r=oli-obk compare generic constants using `AbstractConst`s This is a MVP of rust-lang/compiler-team#340. The changes in this PR should only be relevant if `feature(const_evaluatable_checked)` is enabled. ~~currently based on top of #76559, so blocked on that.~~ r? `@oli-obk` cc `@varkor` `@eddyb`

view details

Christiaan Dirkx

commit sha e3c6e46168758642f0bab64da374f93ed21b1cd0

Make some methods of `Pin<&mut T>` unstable const Make the following methods unstable const under the `const_pin` feature: - `into_ref` - `get_mut` - `get_unchecked_mut`

view details

Guillaume Gomez

commit sha 28588e5df1747572110f0fc247d2efd653f3b398

Add missing examples on HashSet iter types

view details

Matthias Krüger

commit sha 40dddd33059344b546a11f150c0ec63e797f021c

use matches!() macro for simple if let conditions

view details

Bastian Kauschke

commit sha 925cd2616238d4f93b80cc26f02b5f5b256978fc

don't take `TyCtxt` by reference

view details

bors

commit sha 2cbc570e5814771a9b96db5c3d985b6452b59e80

Auto merge of #76884 - Mark-Simulacrum:fix-macos-ci, r=pietroalbini Add host triples to target lists This PR is primarily intended to fix https://github.com/rust-lang/rustup/issues/2494, which is the second commit. That bug was introduced by #76415, and incompletely fixed by #76639. (#76639 added host triples, which gave us compilers, but missed that we also need documentation and other target-only things). However, it also removes duplicate macOS CI builders. r? `@pietroalbini`

view details

Jonas Schievink

commit sha 78ff69ba1086decb205b988f05aba7711dddb221

Implement a destination propagation pass

view details

Jonas Schievink

commit sha 43ad8e4260bec289c522a2fd3597c275e9e3c39c

simplify_try: print dest_prop diff and bless The new diff is to convince me that this is correct and nothing funky is going on.

view details

Jonas Schievink

commit sha 16498953856a41e781da65709f1d111cef66af91

simplify_try: clean up test

view details

Jonas Schievink

commit sha 8a7b1c38940e8c0a013dacf52db6a7884f156d3e

Make nrvo-simple set mir-opt-level=1 The additional copies are due to the lack of copy propagation

view details

Jonas Schievink

commit sha 8a3e2b78bb0595bc9205b29898eb128836b5c57f

Bless mir-opt tests

view details

Jonas Schievink

commit sha 812d4bbc8d1a240ecc900ffafacb5ce34f69e9f3

Fix dataflow assert errors

view details

Jonas Schievink

commit sha 7dbc7f76e1a0f1d054655f6fa5786b700745b66e

Add a few dest-prop MIR tests

view details

Jonas Schievink

commit sha 402f863d8ac2e69abf415d9ed9c1b9984e037700

perf: walk liveness backwards in Conflicts::build

view details

Jonas Schievink

commit sha 665a98d21f926fbd8a89fe2af7c448ff34deadc3

Fix dest-prop mir-opt tests

view details

Jonas Schievink

commit sha ab26fb140c9225c690a219c055a54eba57188d4a

perf: only calculate conflicts for candidates

view details

push time in 16 days

push eventchansuke/rust-clippy

Tim Nielens

commit sha 2ecc2ac864739cff6aed2609021e2467dedb117a

unit-arg - improve suggestion

view details

Michael Wright

commit sha e8d33d73dc3f9d0daf9b3affe65a2431f5a3e13a

Fix `let_and_return` bad suggestion Add a cast to the suggestion when the return expression has adjustments. These adjustments are lost when the suggestion is applied. This is similar to the problem in issue #4437. Closes #5729

view details

Eduardo Broto

commit sha 6dd65b8e6a548071b19507826c53bf9a7c36b323

Fix cargo dev new_lint for late lint passes

view details

Eduardo Broto

commit sha eb8ede7f659da6c07d1f475aff9b0d46e5b49a79

Improve documentation related to the sync process

view details

Eduardo Broto

commit sha 8776db9f6d5163ca40232336dc51ad77eeb2b5e5

Fix ICE in `repeat_once` lint

view details

rail

commit sha 91b200c62b7c464cb890c68230ab2d74605a60d0

Fix fp in `borrow_interior_mutable_const` Fix false positive when referencing a field behind a pointer.

view details

bors

commit sha 2d86cc5a33dd4a7cb586ab28822cdfceace92816

Auto merge of #5930 - ebroto:dev_newlint_fix_lt, r=matthiaskrgr Fix cargo dev new_lint for late lint passes Since https://github.com/rust-lang/rust-clippy/commit/30c046ede47ea45a772d2656b0365a4807263bca, `LateLintPass` has only one lifetime parameter. I'm not sure how to easily test this, I think adding this kind of tests would be probably part of #5394 changelog: none

view details

bors

commit sha 27ae4d303ce9103a104c57088913741ab17f4d36

Auto merge of #5948 - ebroto:5944_repeat_ice, r=Manishearth Fix ICE in `repeat_once` changelog: Fix ICE in [`repeat_once`] Fixes #5944

view details

Eduardo Broto

commit sha b05077ea75f4585551650fc2d40a196ae437393d

Apply suggestions from PR review

view details

Takayuki Nakata

commit sha b2c226679251bb795d786d7cdd11d2e2c9d0e685

Fix FP for `redundant_closure_call` Visit the nested things like function body when checking closure call.

view details

Takayuki Nakata

commit sha 9fe0ac36a53dfba14f5f33f5bab2fd243fb2c18e

Avoid period in lint message according to convention

view details

rail-rain

commit sha ce8915c85cebaa30e6846322e0ab44a4f4f9cb65

typo Co-authored-by: Thibaud <ThibsG@users.noreply.github.com>

view details

ThibsG

commit sha 3d820f71fe820c0bb7a1204e28ce549407a937cc

Fix incorrect suggestion when `clone_on_ref_ptr` is triggered in macros

view details

Bastian

commit sha 680c68153bced747c90947e0265c92076edcb838

Added a lint which corrects expressions like (a - b) < f32::EPSILON

view details

Matthias Krüger

commit sha e9964f2e8a1903d46e576f67122e234f719a90f0

stable_sort_primitive: print the type that is being sorted in the lint message

view details

bors

commit sha 8d9a485ef11c3c30fb87f35f61278027e7370510

Auto merge of #5935 - matthiaskrgr:unstable_sort_ty_name, r=flip1995 stable_sort_primitive: print the type that is being sorted in the lint message changelog: stable_sort_primitive: print the type that is being sorted in the lint message

view details

Scott McMurray

commit sha 48b4aeabf83db10393b06fff3b58161ccc586fe9

Unbreak the clippy test

view details

bors

commit sha 64b53f3877dc9a843b1e4477e1c2c217e0e6a596

Auto merge of #5920 - giraffate:fix_fp_for_redundant_closure_call, r=mikerite Fix FP for `redundant_closure_call` Fix #5916 changelog: Fix FP for `redundant_closure_call` when called in function body

view details

Michael Wright

commit sha 91028326927266af5051b5d172dc3162d147a4d9

Fix incorrect comment

view details

Michael Wright

commit sha 48d473691359f7c59d7348937f71de0e5aa4ae12

Simplify fmt test by using the clippy dev alias

view details

push time in 16 days

PR opened DefinitelyTyped/DefinitelyTyped

Add `instantiate()` to WebAssembly

Added definition of instantidate() method of WebAssembly.

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/instantiate>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+9 -0

0 comment

2 changed files

pr created time in 16 days

push eventchansuke/DefinitelyTyped

chansuke

commit sha fc0555a4a2998dc3b6815edeef93771e5b1a10d0

Add `instantiate()` to WebAssembly

view details

push time in 16 days

create barnchchansuke/DefinitelyTyped

branch : update-webassembly

created branch time in 16 days

create barnchchansuke/rust-wasm-webgl

branch : main

created branch time in 16 days

created repositorychansuke/rust-wasm-webgl

created time in 16 days

push eventchansuke/DefinitelyTyped

Thomas Klepzig

commit sha f7cd2cd07cdca10cf2495be26b94bb9e27f52b53

🤖 Merge PR #47191 intercom-web: Make `intercomSettings` optional to allow `delete window.intercomSettings` (New change in TS 4.0) by @tklepzig

view details

Matheus Ashton Silva

commit sha afb01664add8c74eccc86d14b10ba9a31728dc12

🤖 Merge PR #47113 @types/auth0 ManagementClient#getUsersInRole overload order by @ashton Co-authored-by: Matheus Ashton Silva <matheus.ashton@loft.com.br>

view details

Nathan Shively-Sanders

commit sha 935afa0288e71170f2b9f20efa9bcf327d0f7639

update typesVersions instructions (#47215)

view details

Nathan Shively-Sanders

commit sha d1bc3c76373896444bc1c8730e654e0fe1ad6091

Put current version of jest in the root (#47196) * Put current version of jest in the root Previously, the code that supports the oldest version of Typescript was in the root: 3.1 and below. Newer versions were in ts*/ subdirectories. This PR puts the newest version in the root, and older versions -- 3.1 in this case -- in ts*/ subdirectories. This is possible because all supported versions of the Typescript now understand the typesVersions property in package.json. This PR needs a new version of DefinitelyTyped-tools and dtslint, which I will ship soon. It also needs to be brought up to date with master. * delete ts3.2/

view details

Nathan Shively-Sanders

commit sha babc4e3edc7128eb329283f0150e314a755ebc03

Put current version of styled-components in the root (#47199) * Put current version of styled-components in the root Previously, the code that supports the oldest version of Typescript was in the root: 3.1 and below. Newer versions were in ts*/ subdirectories. This PR puts the newest version in the root, and older versions -- before 3.7 in this case -- in ts*/ subdirectories. This is possible because all supported versions of the Typescript now understand the typesVersions property in package.json. This PR needs a new version of DefinitelyTyped-tools and dtslint, which I will ship soon. It also needs to be brought up to date with master. * Delete ts3.7/ * port change from #42092 to current version

view details

Nathan Shively-Sanders

commit sha bc404eed4afd78dd5396db0ea1ac98537ab213d7

Put current version of babel-types in the root (#47197) * Put current version of babel-types in the root Previously, the code that supports the oldest version of Typescript was in the root: 3.1 and below. Newer versions were in ts*/ subdirectories. This PR puts the newest version in the root, and older versions -- before 3.7 in this case -- in ts*/ subdirectories. This is possible because all supported versions of the Typescript now understand the typesVersions property in package.json. This PR needs a new version of DefinitelyTyped-tools and dtslint, which I will ship soon. It also needs to be brought up to date with master. * delete ts3.7/ * use correct relative reference for test

view details

Nathan Shively-Sanders

commit sha 6e8dd401ba17be8b3941f48e03fc29a9495c5438

Put current version of node in the root (#47195) * Put current version of node in the root Previously, the code that supports the oldest version of Typescript was in the root: 3.1 and below. Newer versions were is ts*/ subdirectories. This PR puts the newest version in the root, and older versions -- usually 3.7 and below -- in ts*/ subdirectories. This is possible because all supported versions of the Typescript now understand the typesVersions property in package.json. This PR needs a new version of DefinitelyTyped-tools and dtslint, which I will ship soon. It also needs to be brought up to date with master. * Delete missed files * fix relative reference

view details

Hugues Stefanski

commit sha d791dc7460d72f5b297f7333df7ba5e4409cc5aa

Update patch version for d3-selection-multi (#47168)

view details

Jack Bates

commit sha 1a44349a484c741d0c693a80423dbc68d576898f

[mapbox__s3urls] Unmangle scoped package names (#47171)

view details

Jack Bates

commit sha 9652b705d3ba116f21f74280164acd9e782f26ee

[svg-maps__usa] Unmangle scoped package names (#47175)

view details

Alan Agius

commit sha 783f883857333a82c773a67cba6136287c937fa7

🤖 Merge PR #47233 Add resolve.root option by @alan-agius4 * Add resolve.root option https://webpack.js.org/configuration/resolve/ * add test for resolve roots

view details

EvanJin

commit sha 33b4f8d69054db0da459d2d9d8f16216b396754a

Add Types for package for react-native-wheel-pick (#47169) * Add Types for package react-native-base64 * Add Types for package iamport-react-native * Add Types for package for react-native-wheel-pick Co-authored-by: evan <evanjin@toons.kr>

view details

DCsunset

commit sha b498ec10330a93438c506e0024d4d69f3207e0e5

Add types for node-ip2region (#47224)

view details

Jack Bates

commit sha 38dba383c3d8374157cc64f492c011a613906a17

[pusher__chatkit-client] Unmangle scoped package names (#47172)

view details

ExE Boss

commit sha 20142fec2fdd89c3a42c019242c102cd3d28c99a

🤖 Merge PR #47245 fix(webidl2): Fix generic IDLTypeDescription type definition by @ExE-Boss

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 3bf969403bbb0212fe0e41ca4e5914ce9cb9edee

🤖 Merge PR #47234 fix(compression-webpack-plugin): fix result type definition by @peterblazejewicz Expand allowed types for result callback to be compatible with patched version: https://github.com/webpack-contrib/compression-webpack-plugin/compare/v5.0.1...v5.0.2 https://github.com/webpack-contrib/compression-webpack-plugin/pull/190 https://github.com/gfx/universal-zopfli-js/blob/master/src/index.ts#L87 /cc @vitoyucepi Thanks! Fixes: #47230

view details

Alba Mendez

commit sha 9a5105e065d9c9513561c2e0721768d6ab77873a

🤖 Merge PR #47007 [usb] minor fixes by @mildsunrise * [usb] fix invalid return types * [usb] fix callback types * [usb] update tests * [usb] add definition for clearHalt * [usb] use consistent terms * [usb] getStringDescriptor returns string * [usb] fix type of data_or_length * [usb] add __getConfigDescriptor * [usb] expose Transfer API * [usb] expose three more interface internals * Update types/usb/index.d.ts Co-authored-by: Rob Moran <github@thegecko.org> * Update index.d.ts * make callback error parameter non-optional * more consistency fixes Co-authored-by: Rob Moran <github@thegecko.org>

view details

TJT

commit sha 6a3556a1bc18bc2650612009011e5f0df4533125

🤖 Merge PR #46863 fix(mongodb): Fix incorrect return type for calling Cursor.find with options by @Celend * [mongodb]: Fix incorrect return type for cursor.find and others * [mongodb]: Bug fixed for incorrect return type when call Cursor.find with options * [mongodb] Update types/mongodb/test/cursor.ts Co-authored-by: Lior Chen <liorchen@gmail.com> Co-authored-by: Lior Chen <liorchen@gmail.com>

view details

Nathan Shively-Sanders

commit sha ed36b1aa90c2273479c3870448ae55213be49c67

Knockout put current version in root (#47255) * Put current version of knockout in the root Previously, the code that supports the oldest version of Typescript was in the root: 3.1 and below. Newer versions were in ts*/ subdirectories. This PR puts the newest version in the root, and older versions -- before 4.0 in this case -- in ts*/ subdirectories. This is possible because all supported versions of the Typescript now understand the typesVersions property in package.json. This PR needs a new version of DefinitelyTyped-tools and dtslint, which I will ship soon. It also needs to be brought up to date with master. * Delete ts4.0/

view details

Elizabeth Samuel

commit sha d56990f3fab8e1fe9c93ff76c1d028c570b2c95e

[office-js] [office-js-preview] [custom-functions-runtime] [office-ru… (#47241) * [office-js] [office-js-preview] [custom-functions-runtime] [office-runtime] Add Alison as owner * Retrigger

view details

push time in 16 days

push eventchansuke/rust

CAD97

commit sha 728938346b02a9688c44253c19b15baa7551fd80

Adjust rc::Weak::from_raw to support unsized T

view details

CAD97

commit sha 0c61ce2cf0560577923abafab2e5bfce14516525

?Sized bounds for rc::Weak::as_ptr and friends

view details

CAD97

commit sha 5e7406c9569dce75a042ce079918cf03cfca842a

Adjust sync::Weak::from_raw to support unsized T

view details

CAD97

commit sha 9d9903c5a50bb1f5b5fc3045b86172279eff7d30

Allow Weak::as_ptr and friends for unsized T

view details

CAD97

commit sha 3d07108d3600dff50e564f57dd390337dbe14d55

Add tests for weak into/from raw

view details

Joshua Nelson

commit sha 6533c29bea5416c62c098f369553ed2b6c2c9eae

Remove --cfg dox from rustdoc.rs This was added in https://github.com/rust-lang/rust/pull/53076 because several dependencies were using `cfg(dox)` instead of `cfg(rustdoc)`. I ran `rg 'cfg\(dox\)'` on the source tree with no matches, so I think this is now safe to remove.

view details

Joshua Nelson

commit sha 351f850d33e0a000c8fd8b43e71e03d91f470383

Remove unused --cfg stageN

view details

Joshua Nelson

commit sha ca987789ea2da972dee6e84e7aa8017840553bf9

Update stdarch submodule The primary purpose is to get the fixes from https://github.com/rust-lang/stdarch/pull/920 and https://github.com/rust-lang/stdarch/pull/922. The other changes included are https://github.com/rust-lang/stdarch/pull/917 and https://github.com/rust-lang/stdarch/pull/919.

view details

Jonas Schievink

commit sha b01694e0a2f36cee14e5844e1b4abae965dee627

Returns values up to 2*usize by value

view details

bors

commit sha 6f56fbdc1c58992a9db630f5cd2ba9882d32e84b

Auto merge of #77347 - jyn514:dox, r=Amanieu Remove --cfg dox from rustdoc.rs This was added in https://github.com/rust-lang/rust/pull/53076 because several dependencies were using `cfg(dox)` instead of `cfg(rustdoc)` (now `cfg(doc)`). I ran `rg 'cfg\(dox\)'` on the source tree with no matches, so I think this is now safe to remove. r? `@Mark-Simulacrum` cc `@QuietMisdreavus` :)

view details

Ralf Jung

commit sha e27ef130c1d1cc7d8c3779a4e66e413a7a943ad4

grammar nit

view details

bors

commit sha 738d4a7a368b4da8bfa31915f06bb1ddce9e9980

Auto merge of #74160 - CAD97:weak-as-unsized-ptr, r=RalfJung Allow Weak::as_ptr and friends for unsized T Relaxes `impl<T> Weak<T>` to `impl<T: ?Sized> Weak<T>` for the methods `rc::Weak::as_ptr`, `into_raw`, and `from_raw`. Follow-up to #73845, which did most of the impl work to make these functions work for `T: ?Sized`. We still have to adjust the implementation of `Weak::from_raw` here, however, because I missed a use of `ptr.is_null()` previously. This check was necessary when `into`/`from_raw` were first implemented, as `into_raw` returned `ptr::null()` for dangling weak. However, we now just (wrapping) offset dangling weaks' pointers the same as nondangling weak, so the null check is no longer necessary (or even hit). (I can submit just 17a928f as a separate PR if desired.) As a nice side effect, moves the `fn is_dangling` definition closer to `Weak::new`, which creates the dangling weak. This technically stabilizes that "something like `align_of_val_raw`" is possible to do. However, I believe the part of the functionality required by these methods here -- specifically, getting the alignment of a pointee from a pointer where it may be dangling iff the pointee is `Sized` -- is uncontroversial enough to stabilize these methods without a way to implement them on stable Rust. r? `@RalfJung,` who reviewed #73845. ATTN: This changes (relaxes) the (input) generic bounds on stable fn!

view details

Ralf Jung

commit sha 9f1861e0f86ec6687aa33a3db528d01898b8f4f5

update Miri

view details

bors

commit sha 25c8c53dd994acb3f4f7c02fe6bb46076393f8b0

Auto merge of #77500 - RalfJung:miri, r=RalfJung update Miri Fixes https://github.com/rust-lang/rust/issues/77406 r? `@ghost` Cc `@rust-lang/miri`

view details

bors

commit sha bad9ad06c00141114900c41750e961574f2ecc15

Auto merge of #77434 - jonas-schievink:ret-in-reg-2-electric-boogalo, r=nagisa Returns values up to 2*usize by value Addresses https://github.com/rust-lang/rust/pull/76986#discussion_r498306837 and https://github.com/rust-lang/rust/pull/76986#issuecomment-696415287 by doing the optimization on all targets. This matches what we do for functions returning `&[T]` and other fat pointers, so it should be Harmless™

view details

push time in 17 days

push eventchansuke/rust-clippy

Tim Nielens

commit sha 390a13b06c79d4177b829097b06453e38188081f

needless-lifetime - fix nested elision site FPs

view details

Tim Nielens

commit sha a60e5de90c7370d4fb3e6561d3cb55495cda2e2a

needless-lifetime / nested elision sites / PR remarks

view details

Tim Nielens

commit sha c8e9e52303da6dff4bc5cc4db3021d608fca6c70

needless-lifetime / add test cases for nested elision sites

view details

bjorn3

commit sha 210e89198d72108fbba6de3fa539a8a92c1e7213

Add option to pass a custom codegen backend from a driver

view details

Ralf Jung

commit sha 952ec7d06660277dedf3436a9f50952a9caa6523

Rollup merge of #76474 - bjorn3:driver_selected_codegen, r=oli-obk Add option to pass a custom codegen backend from a driver This allows the driver to pass information to the codegen backend. For example the headcrab debugger may in the future want to use cg_clif to JIT code to be injected in the debuggee. This would PR make it possible to tell cg_clif which symbol can be found at which address and to tell it to inject the JITed code into the right process. This PR may also help with https://github.com/rust-lang/miri/pull/1540 by allowing miri to provide a codegen backend that only emits metadata and doesn't perform any codegen. cc @nbaksalyar (headcrab) cc @RalfJung (miri)

view details

Eduardo Broto

commit sha 101e76f117eeefcd2e901bab707de199b030f201

needless arbitrary self: handle macros

view details

Eduardo Broto

commit sha 1b58144af56d8e42adadb1d02dab75da00f5b2ea

Merge remote-tracking branch 'upstream/master' into rustup

view details

bors

commit sha ce678b9ac1aac0cb32a36f88294cabf88de316fc

Auto merge of #6094 - ebroto:rustup, r=ebroto Rustup changelog: none r? `@ghost`

view details

bors

commit sha 99483be1c7629a17fad45b9c208982c3891639e3

Auto merge of #6093 - ebroto:6089_renamed_lifetimes, r=Manishearth needless arbitrary self: handle macros This fixes two cases related to macros: * If the parameter comes from expansion, do not lint as the user has no possibility of changing it. This is not directly related to the fixed issue, but we should probably do that. * If *only* the lifetime name comes from expansion, lint, but allow the user decide the name of the lifetime. In the related issue, the lifetime was unnamed and then renamed by `async_trait`, so just removing the name in the suggestion would work, but in the general case a macro can rename a lifetime that was named differently, and we can't reliably know that name anymore. As a hint for the reviewer, the expanded code for the test can be checked with this command (from the root dir of the repo): ```sh rustc -L target/debug/test_build_base/needless_arbitrary_self_type_unfixable.stage-id.aux -Zunpretty=expanded tests/ui/needless_arbitrary_self_type_unfixable.rs ``` changelog: [`needless_arbitrary_self_type`]: handle macros Fixes #6089

view details

Tim Nielens

commit sha 7cfe3dc2eb49e2056d3a16731cda2bb315776296

Merge branch 'master' into needless-lifetime

view details

Tim Nielens

commit sha 124420f920fd9323e69829a35876add8c358a666

needless-lifetime / fix master merge

view details

Tim Nielens

commit sha aa2ac38fa7224bff68eeff8781321c9c355e5980

needless-lifetime / add known problem item

view details

Tim Nielens

commit sha cb2be6f9dba0224c63180eada2d089100450391a

needless-lifetime / pr remarks

view details

Jethro Beekman

commit sha 0690f9c5d526baa593cc62b175ef5e7f2c8f4f9c

Add lint for inline assembly syntax style preference

view details

Eduardo Broto

commit sha 507561ecfcec33d4263cff17cfe953518b8c3ce6

Update tests/ui/asm_syntax.rs Use a single `only` header command in asm_syntax test

view details

bors

commit sha abce9e7c9fc0520da4556ca641cce9aee462c2fc

Auto merge of #6092 - jethrogb:jb/inline-asm-syntax-lint, r=ebroto Add lint for inline assembly syntax style preference changelog: Add lint for inline assembly syntax style preference

view details

bors

commit sha d4313737d819891ae0fe790febe5a0a622e1b4a5

Auto merge of #5978 - montrivo:needless-lifetime, r=ebroto needless-lifetime - nested elision sites Closes #2944 changelog: fix needless-lifetime nested elision site FPs

view details

Takayuki Nakata

commit sha 0a91fe7016cdb48d3824c218e02eca8cfdec3854

Don't emit a lint for the suggestion leading to errors in `needless_range_loop`

view details

bors

commit sha 8c9800a3a9026aa3cc1071276d0672585ba2175e

Auto merge of #6102 - giraffate:no_lint_when_invalid_suggestion_in_needless_range_loop, r=flip1995 Don't emit a lint for the suggestion leading to errors in `needless_range_loop` Fix #5945 changelog: Don't emit a lint for the suggestion leading to errors in `needless_range_loop`

view details

Michael Wright

commit sha e91202cf683b7265eec484ad311b5a9d3b56fc3e

Allow exponent separator Fixes #6096

view details

push time in 17 days

push eventchansuke/rust

Nazım Can Altınova

commit sha a313abe3ba989ba4b6c041627c903488886f8559

Manually implement Debug for BTreeMap::{IntoKeys,IntoValues} structs

view details

Nazım Can Altınova

commit sha 456738e3d1ad7dadffaed287d3055ca38b5fa375

Only print values in the Debug of HashMap::ValuesMut struct

view details

Nazım Can Altınova

commit sha c346e89db8a57e15111daa35685a2542d3be7c77

Manually implement Debug for BTreeMap::ValuesMut struct Deriving debug prints all the values including keys. But ValuesMut struct should only print the values.

view details

Nazım Can Altınova

commit sha 8faf550e5f7211188bc9560ae459c155fb1aafdf

Remove the unused bounds from Debug impl of HashMap::{IntoKeys,IntoValues}

view details

David Wood

commit sha 01f65afa4adff6dfbea84621e6851c028aaa7159

diag: improve closure/generic parameter mismatch This commit improves the diagnostic when a type parameter is expected and a closure is found, noting that each closure has a distinct type and therefore could not always match the caller-chosen type of the parameter. Signed-off-by: David Wood <david@davidtw.co>

view details

Jubilee Young

commit sha 247b73939a619ea4dcb2affbe1c285d20d93a0b8

Move Wrapping<T> ui tests into library

view details

Jubilee Young

commit sha 797cb9526a627c37b9bb9f6be6d3b54789b67c26

Fix to libstd test

view details

Mara Bos

commit sha 84ef603c8400db203fefd714de963c88e5523424

Fix 'FIXME' about using NonZeroU32 instead of u32. It was blocked by #58732 (const fn NonZeroU32::new), which is fixed now.

view details

Pietro Albini

commit sha 0917b2123fff6cf5357b5edd5db6d675313ab8bd

build-manifest: move PkgType into the versions module

view details

Pietro Albini

commit sha 3bddfea7e23341f788526f8b303b9a27038511e3

build-manifest: stop receiving release numbers from bootstrap

view details

Without Boats

commit sha 82f5928ca68acceb1d1bd9e2b09554744e4a1dfe

Make RawFd implement the RawFd traits

view details

Without Boats

commit sha acc136ce0a665a32ddf1a16544b6f6d7a7153c30

fix typos

view details

Without Boats

commit sha 3fe279fc658450a3e3140f014554139493674217

spend another CI build to delete a double newline

view details

Without Boats

commit sha 35b30e29bffe8c4aa896ce53ded67c54401f7643

try again to appease tidy

view details

Tim Vermeulen

commit sha ecacc7534b6bf50205c37c89402565b82d95a257

Add advance_by and advance_back_by

view details

Alexis Bourget

commit sha 8aae1eee94f481bd955cff473deae1f03c313451

Move cell exterior test into library unit tests

view details

Alexis Bourget

commit sha f69c5aa428efdbc01685c3d06e63fedd3120e8e5

Move more tests using Cell to unit tests

view details

Alexis Bourget

commit sha af44a2a857618150b180dabe9c3383a3911b3640

move 'cell does not clone' test

view details

Alexis Bourget

commit sha fc152cd67e0b6d3f11f49eae43183d03a3b8bf17

move 'test zip ...' tests

view details

Alexis Bourget

commit sha 85b2d9bf6f2b04ae8996050b2fb276bd58cd92de

fmt

view details

push time in 17 days

push eventchansuke/rust

Raoul Strackx

commit sha a13239dac2b4b50e389a3e12c638d164e620ea2f

generic ret hardening test

view details

Raoul Strackx

commit sha cd31f40b6f59c8966a09e7f1e2d6c3c5ed1570f1

generic load hardening test

view details

Avi Dessauer

commit sha a7a20860537ddd05f802598866681a6f9cc3413c

Stability annotations on generic trait parameters

view details

Avi Dessauer

commit sha a9d6da576bbc4b80337c14cb3d0fcb2967a934f4

ignore-tidy-linelength generic default stab test Co-authored-by: Tim Diekmann <21277928+TimDiekmann@users.noreply.github.com>

view details

Avi Dessauer

commit sha 8b81a17d7353a75e4b2d29f96c2c0c8fb1713fec

Uncomment struct tests

view details

Avi Dessauer

commit sha 88b77b6534d5353a16e597451a22322cc7d92063

Comment out broken tests

view details

Avi Dessauer

commit sha eb7abb9e32a2ba10d0c083b13bb1a2dcd1d22b5d

Unstable default types leak in public fields

view details

Avi Dessauer

commit sha cb7264b22a45b993df57bd17e869a472a5c12b47

Fix tests

view details

Avi Dessauer

commit sha f665ccd3a2f5e58c6ac3828e34f5c8e94f71811c

Add more tests

view details

Avi Dessauer

commit sha a1892f1a798f8b0c24136d0be65fa4cc23e0ff74

Test stability on default parameter of deprecated

view details

Avi Dessauer

commit sha 3947591ee82702f124af9248463036155b83b907

Remove now unneeded check_stability argument

view details

Avi Dessauer

commit sha 19e90843a4eb99d528dea62f793ad6d523c4af6c

Add documentation

view details

Avi Dessauer

commit sha 41eec9065aef513cc41d8e2297c4f469fd7029b7

Update src/librustc_passes/stability.rs Co-authored-by: varkor <github@varkor.com>

view details

Avi Dessauer

commit sha 9eb595705e754c970de76375060455bc3f576296

Update src/librustc_typeck/astconv.rs Co-authored-by: varkor <github@varkor.com>

view details

Avi Dessauer

commit sha 25dba40cbee4161709fba653c5f3915a7ac87537

Update src/librustc_middle/middle/stability.rs Co-authored-by: varkor <github@varkor.com>

view details

Avi Dessauer

commit sha 2793da3f39033d7f0b2c07a3556d68ccd4d03d4e

Update src/librustc_passes/stability.rs Co-authored-by: varkor <github@varkor.com>

view details

Avi Dessauer

commit sha af19d4492124a9681c1e3bc9c9effe1641ad7d20

Add test case demonstrating leak

view details

Avi Dessauer

commit sha 7616b30bff843ff279fae9ae4eea44b87d46b310

Add unstable default feature enabled test

view details

Avi Dessauer

commit sha a73e7d0a4df305e8b8237163e5ac7755cf488af8

Test unstable Alloc param on Box

view details

Avi Dessauer

commit sha d281620d8f630346ea96c8c65b9fd7f5b7f1da9e

Test removing unstable default parameter

view details

push time in 22 days

push eventchansuke/rust-clippy

Dylan MacKenzie

commit sha 72b402ed38f0c71461038aef8a49a02e49280788

Add pass names to some common dataflow analyses

view details

flip1995

commit sha d1f9cad102b5686f2b827f3c62a02dfe419128a6

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

view details

Jonas Schievink

commit sha a8c60732786626928fe9dceb1ffe0775a2700969

Rollup merge of #76724 - ecstatic-morse:dataflow-pass-names, r=lcnr Allow a unique name to be assigned to dataflow graphviz output Previously, if the same analysis were invoked multiple times in a single compilation session, the graphviz output for later runs would overwrite that of previous runs. Allow callers to add a unique identifier to each run so this can be avoided.

view details

bors

commit sha 6273be6fc26b22f91389a67a30c6633d60cc459d

Auto merge of #77144 - flip1995:clippyup, r=Manishearth Update Clippy Bi-weekly Clippy update. This includes a `Cargo.lock` update (d445493479711389f4dea3a0f433041077ba2088), so probably needs `rollup=never`. r? `@Manishearth`

view details

Oliver Scherer

commit sha a6fda14394c956bdfa5f0dfac6992063d157fc41

Move `qualify_min_const_fn` out of rustc into clippy

view details

Oliver Scherer

commit sha 7072e45c6c7c480b66a3be72138a2b29117c039f

Remove all unstable feature support in the `missing_const_for_fn` lint

view details

Eduardo Broto

commit sha 798a5cf5bc70eb7d9140b8bed4ed8c48ab16feae

Merge remote-tracking branch 'upstream/master' into rustup

view details

Eduardo Broto

commit sha cd4706413fb891ffe33ef06e0c229d97258fbfaf

Run cargo dev fmt

view details

Eduardo Broto

commit sha 8bf27c5e92af39215a3d1da992a7207dafc883e1

Fix dogfood

view details

bors

commit sha db6fb90bc0d9cbf4ddf1bfa560b9e8db10851a84

Auto merge of #6091 - ebroto:rustup, r=ebroto Rustup changelog: none r? `@ghost`

view details

push time in 22 days

push eventchansuke/rust

kadmin

commit sha 6cb671628393e292d5e68e6367f80488ace46532

Add test for checking if-let or-patterns

view details

Jane Lusby

commit sha c31d4730b0d40c62934839405d0c25e2ffa3fad1

update example to be more idiomatic

view details

Ayush Kumar Mishra

commit sha 941dca8ed238a04a55741127165e9ad80671ed8a

Add Arith Tests in Library

view details

Ayush Kumar Mishra

commit sha dc37b553accd4fb2f8d0c59f69c701b524361cc2

Minor refactoring

view details

Ayush Kumar Mishra

commit sha 7d834c87d2ebb3d8dd4895bc5fabc4d44a1d2b52

Move Various str tests in library

view details

scottmcm

commit sha 2c8a4c8f73e8b36e72b15e7f97ef29ad36c15e17

Nightly is currently 1.48

view details

Ivan Tham

commit sha 685f04220ee584f00f60e5ff9d7aca16351c5399

Clean up vec benches bench_in_place style

view details

Jens Reidel

commit sha 78097d96828c16a259fa9b5c2430e8d9ff1820b3

initial attempt to add aarch64-unknown-linux-musl to dist-linux-arm

view details

scottmcm

commit sha 3d89ee9586354e736cfe4a472d8aaa507d10f77c

Typo fix Thanks, Amanieu Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>

view details

Ralf Jung

commit sha caeb5544ecd9dba4d67b68b8c1b32d8132c6d5f2

do not inline black_box when building for Miri

view details

Ralf Jung

commit sha 4b5cd544d1268df8f95424a7dc77ce6c852bac56

use black_box instead of local optimziation barriers in const tests where possible

view details

Ralf Jung

commit sha 47668edb64ed1f8676cfcb4c9ccb6fe018f660c5

Separate feature flags Co-authored-by: Ivan Tham <pickfire@riseup.net>

view details

Ralf Jung

commit sha 284b16913aa6fccdf7b14edc3bb2693aadd39919

add missing feature flag

view details

Ricky

commit sha 4f1c4a99d4d98f1acea3c9c7cc55355aa46119aa

Fixed typo in lint and test

view details

Esteban Küber

commit sha 2ac89ff994c9ddcc49eed2b06ff5327bc09f4118

Point at named argument not found when using `format_args_capture` instead of whole format string

view details

Guillaume Gomez

commit sha 69ffed763d1540c387db3b578848184026da0484

Add error explanation for E0755

view details

Ricky

commit sha d719b485434eac557e65bf55cca79e63f7b83d5b

Move map_err_ignore from style to pedantic

view details

rail

commit sha d712d7f700977240ad9bd731fc3f76e05cc1c900

Improve "known problems" of `interior_mutable_key` * Remove the mention to `Rc` and `Arc` as these are `Freeze` so the lint correctly handles already. * Instead, explain what could cause a false positive, and mention `bytes` as an example.

view details

Matthias Krüger

commit sha 46b164313288c4b5454ccdaa5ebee2412855f0fd

update cargo dev ra-setup to changed rustc source paths

view details

Tavian Barnes

commit sha a06edda3ad9abd4f07d07bbe46cb488efeebbbd0

Fix segfault if pthread_getattr_np fails glibc destroys[1] the passed pthread_attr_t if pthread_getattr_np() fails. Destroying it again leads to a segfault. Fix it by only destroying it on success for glibc. [1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/pthread_getattr_np.c;h=ce437205e41dc05653e435f6188768cccdd91c99;hb=HEAD#l205

view details

push time in 23 days

push eventchansuke/rust-clippy

Tim Nielens

commit sha 2ecc2ac864739cff6aed2609021e2467dedb117a

unit-arg - improve suggestion

view details

Tim Nielens

commit sha f3ccbef2af24d5d83f82f1fb50bd97a9b75e609f

unit-arg - pr comments

view details

Vali Schneider

commit sha 459969f88ff95c94b7b34043a7f0e13de91de4f8

added restriction lint that prohibits the usage of unimplemented, unreachable or panic in a function of type result or option

view details

Vali Schneider

commit sha ceab1a9167655eba9f9556f8766f8702e49dfef3

removed unnecessary comment

view details

Vali Schneider

commit sha 8462cce96081b87eba7a5bc89130a1a09fe1f6d0

edited documentation

view details

Vali Schneider

commit sha b2d8ca9a766703469178ea37d4d46067bb6fa926

ran cargo dev update lints

view details

Vali Schneider

commit sha b006522393a3c3c2656e1ccdfbb0076ff1bd7e99

added lint for todo and removed option

view details

Hirochika Matsumoto

commit sha 5574182b4d2d08c848a88a1ac5633fc194e0465e

Add a new lint to prevent `create_dir` from being used

view details

Hirochika Matsumoto

commit sha 607905d126c55422668007737c22d7a7a89c0d57

Add STD_FS_CREATE_DIR into paths

view details

Hirochika Matsumoto

commit sha 34e302e67c08c9b97d58d062ea83cc1fd860c56e

Fix clippy error

view details

Hirochika Matsumoto

commit sha eebd2483654456e332d7cf53218b56b9cbd6f2f5

Fix errors

view details

Hirochika Matsumoto

commit sha 5b7590f841974255f74c64d573189aecc7a30b2e

Downgrade applicability of `create_dir`

view details

Vali Schneider

commit sha a424a2c1676a29c147252873037e8943d54941d3

changed check_impl_item to check_fn and added a few more test cases

view details

Vali Schneider

commit sha 73a3288282e733bfc5893e9920d29f1de5a21591

uncommented fn

view details

Dylan MacKenzie

commit sha 1c5b0fbe53f842cd5871ea02e4e48571615d5679

Update dataflow analyses to use new interface

view details

Hirochika Matsumoto

commit sha 451ef7880392f3f06088ff7a7b957e3485f4bc6c

Use `match_def_path` instead of `match_qpath`

view details

Vali Schneider

commit sha f9fcbbea03edb735c22311522b55d7b854bd6ac0

fixed bug

view details

Ricky

commit sha e49a29933be3bd988ccb75b053f480d9c99a7ff5

Working map_err_ignore lint

view details

Ricky

commit sha 202a80c927412a548180eca5990ee764d76ed643

Added tests for map_err, ignored map_err lint on drop_ref tests

view details

Ricky

commit sha 337729137bdec31b55665653ef0cf7dc124b0eaa

Ran cargo dev update_lints

view details

push time in 23 days

push eventchansuke/rust

Ivan Tham

commit sha 2b7f87b5fa43336ed1237747f60fd9095a41ea3d

Liballoc tweak use *const T instead of *const i8 *const T is also used in the same parts and also used for arith_offset.

view details

Ivan Tham

commit sha cc0d6345500932e8118ba65e98944a6a3bac3277

Liballoc IntoIter limit unsafe to pointer arithmethic

view details

Ivan Tham

commit sha 50315238aa8ffae08f29b260aa36511e03b5e070

Liballoc DoubleEndedIterator limit unsafe to pointer arithmethic

view details

Tim Nielens

commit sha 2ecc2ac864739cff6aed2609021e2467dedb117a

unit-arg - improve suggestion

view details

Yoshua Wuyts

commit sha 688f4471fd553c83ae3ff0306956d89b7d7c2d28

Stabilize future readiness fns

view details

Eduardo Broto

commit sha baf62e7a38854ff6a0039ddccb124ff329a32143

Update changelog to beta 1.47

view details

Tim Nielens

commit sha f3ccbef2af24d5d83f82f1fb50bd97a9b75e609f

unit-arg - pr comments

view details

Hirochika Matsumoto

commit sha 5574182b4d2d08c848a88a1ac5633fc194e0465e

Add a new lint to prevent `create_dir` from being used

view details

Hirochika Matsumoto

commit sha 607905d126c55422668007737c22d7a7a89c0d57

Add STD_FS_CREATE_DIR into paths

view details

Hirochika Matsumoto

commit sha 34e302e67c08c9b97d58d062ea83cc1fd860c56e

Fix clippy error

view details

Hirochika Matsumoto

commit sha eebd2483654456e332d7cf53218b56b9cbd6f2f5

Fix errors

view details

bors

commit sha c88c6149415dd47b5f05e69d7307e0a1967c33f2

Auto merge of #5970 - ebroto:changelog_beta_1_47, r=flip1995 Update changelog to beta 1.47 [Rendered](https://github.com/ebroto/rust-clippy/blob/changelog_beta_1_47/CHANGELOG.md) changelog: none

view details

flip1995

commit sha 282c59820b8e1d8c76f440484b81a190c576f91b

Merge commit '3d0b0e66afdfaa519d8855b338b35b4605775945' into clippyup

view details

Eduardo Broto

commit sha 7a66e6502dc3c7085b3f4078c01d4957d96175ed

or_fn_call: ignore nullary associated const fns

view details

Hirochika Matsumoto

commit sha 5b7590f841974255f74c64d573189aecc7a30b2e

Downgrade applicability of `create_dir`

view details

Kyle Huey

commit sha 4972989b616cbf96c015cd9fdf1f4b4464ecaace

Add a lint for an async block/closure that yields a type that is itself awaitable. This catches bugs of the form tokio::spawn(async move { let f = some_async_thing(); f // Oh no I forgot to await f so that work will never complete. });

view details

Kyle Huey

commit sha c1d2b9376a6bb4fc06f845e12b9c2a93079bb2ee

Add a test for an async function.

view details

Kyle Huey

commit sha 04912ca115ff153a97d80b604435b10dcb155dd0

Formatting changes requested by ThibsG.

view details

Dylan MacKenzie

commit sha 1c5b0fbe53f842cd5871ea02e4e48571615d5679

Update dataflow analyses to use new interface

view details

Camelid

commit sha 17b2ba5ded12f59dba63ece659b5cd714b763800

Syntax-highlight `single_char_push_str` lint

view details

push time in a month

push eventchansuke/rust

Joshua Nelson

commit sha 3b4a346de72c3fa12b69dbcdc12116ba865ab50e

Fix incorrect wording for `verbose-tests` This info was lost in https://github.com/rust-lang/rust/pull/74334.

view details

Joshua Nelson

commit sha d983873cff7467e457bb5b3904ae7c238ffc2d38

Document the defaults for `codegen-units`

view details

Joshua Nelson

commit sha 41c13826f89665a4cf05c2e7ae470cb38fc699bc

Mention why you'd want codegen-units = 0 (other than running out of RAM)

view details

Joshua Nelson

commit sha 9f268de644df40c0ea9b323c475772d0ec2dc5b4

Address review comments - Use prettier syntax for codegen-units defaults - Remove comment about parallelism that only made sense for specific values of codegen-units - Be more specific about what `verbose-tests` does

view details

Joshua Nelson

commit sha ba664c258dd2f5516e987091a31acaa537312cf6

Codegen defaults come from rustc, not cargo

view details

Kornel

commit sha 7ec1de062a1aadef0293bb65e71fbcc7cc24ebfd

Clarify message about unresolved use

view details

Aleksey Kladov

commit sha 4231fbc0a8cb4b2b0df431d8ffcf308f837e07e3

Condense StringReader's API to a single function

view details

Aleksey Kladov

commit sha ccf41dd5eb42730b1de6a4bc9d95c03dca0a8143

Rename IsJoint -> Spacing To match better naming from proc-macro

view details

Rich Kadel

commit sha 9046a9343bbf298cf835a6b4189827fffae38eb3

Improved the MIR spanview output * Adds missing "tail" spans (spans that continue beyond the end of overlapping spans) * Adds a caret to highlight empty spans associated with MIR elements that have a position, but otherwise would not be visible. * Adds visual pointing brackets at the beginning and end of each span

view details

Ivan Tham

commit sha 3740b0064d20646e9aa484bac14076563cbf1032

Add align to rustc-attrs unstable book

view details

Aaron Hill

commit sha f422ef141a1185f721093205fabc6f5a57e3dcc0

Add CONST_ITEM_MUTATION lint Fixes #74053 Fixes #55721 This PR adds a new lint `CONST_ITEM_MUTATION`. Given an item `const FOO: SomeType = ..`, this lint fires on: * Attempting to write directly to a field (`FOO.field = some_val`) or array entry (`FOO.array_field[0] = val`) * Taking a mutable reference to the `const` item (`&mut FOO`), including through an autoderef `FOO.some_mut_self_method()` The lint message explains that since each use of a constant creates a new temporary, the original `const` item will not be modified.

view details

Joshua Nelson

commit sha ed4dcc04d8957e35da8256f6ffdd1ac574af4a76

Make rustdoc output deterministic for UI tests

view details

Ivan Tham

commit sha 3a3a08585f0a0240c7b73efd5c77e78d2af38755

Unstable book rust-attrs does not work on generics Co-authored-by: Peter Todd <pete@petertodd.org>

view details

Joshua Nelson

commit sha 0c9bf13f5f11047bb03313624f0430d93d4e840d

Add a script to automatically update Rust/Clang versions

view details

Pietro Albini

commit sha f64ddc60a504a7dfee41fec477dd678d54d19b22

triagebot: enable github releases synchronization

view details

ortem

commit sha c8262fd87b91e6a699483d8d66ef1be3ced00a71

Add missed spaces to GCC-WARNING.txt

view details

Matthias Krüger

commit sha 0065e33c24213c538ffd76b0cc771e4668819969

rustbuild: don't set PYTHON_EXECUTABLE and WITH_POLLY cmake vars since they are no longer supported by llvm CMake Warning: Manually-specified variables were not used by the project: PYTHON_EXECUTABLE WITH_POLLY

view details

Bastian Kauschke

commit sha c81935e6dfd3877db266f0a01d9323f203f92eda

make `ConstEvaluatable` more strict

view details

Bastian Kauschke

commit sha ef6100e846f215b92f0d3b951557ed2528000f61

convert to future compat lint

view details

Bastian Kauschke

commit sha c10ad0d888df19e7185e15f811fdb011278f3c20

review

view details

push time in a month

pull request commentrust-lang/rust

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/wasm

@crlf0710 Sorry for the late reply. I fixed and now it's ready for the review.

chansuke

comment created time in a month

Pull request review commentrust-lang/rust

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/wasm

 impl Condvar {      pub unsafe fn notify_one(&self) {         self.cnt.fetch_add(1, SeqCst);-        wasm32::memory_atomic_notify(self.ptr(), 1);+        // SAFETY: ptr() is always valid+        unsafe {+            wasm32::atomic_notify(self.ptr(), 1);+        }     }      #[inline]     pub unsafe fn notify_all(&self) {-        self.cnt.fetch_add(1, SeqCst);-        wasm32::memory_atomic_notify(self.ptr(), u32::MAX); // -1 == "wake everyone"+        unsafe {+            wasm32::atomic_notify(self.ptr(), u32::MAX); // -1 == "wake everyone"

Sorry, I fixed...

chansuke

comment created time in a month

PullRequestReviewEvent

push eventchansuke/rust

Josh Stone

commit sha 02b2f73fc500e33dd29547579519a60156c2e6ab

Rollup merge of #75716 - tlively:upgrade-emscripten-1.39.20, r=cuviper Upgrade Emscripten on CI to 1.39.20 This Emscripten version was the first to be cut after the LLVM 11 release branch was created, so it should be the most compatible with LLVM 11. The old version we were using was incompatible with LLVM 11 because its wasm-ld did not understand all the relocations that LLVM 11 emits.

view details

Josh Stone

commit sha 16b9b9017a30006de624935a44a1df8c02673592

Rollup merge of #75731 - lzutao:mir-cmts-suppress-float-ty-const, r=oli-obk Suppress ty::Float in MIR comments of ty::Const Already covered by MIR constant comments

view details

Josh Stone

commit sha 6ac1523b23295ca1c87cc9b05ff3548807926595

Rollup merge of #75733 - pickfire:patch-3, r=matklad Remove duplicated alloc vec bench push_all_move push_all_move is the same as extend

view details

Josh Stone

commit sha 2a3f43de428c70e140c7882174855165b1724f5f

Rollup merge of #75743 - matklad:excl, r=davidtwco Rename rustc_lexer::TokenKind::Not to Bang All other tokens are named by the punctuation they use, rather than by semantics operation they stand for. `!` is the only exception to the rule, let's fix it.

view details

bors

commit sha 332369110919ac27c8a0bc0b21bf9d2f9fd9829d

Auto merge of #75747 - cuviper:rollup-icke90l, r=cuviper Rollup of 8 pull requests Successful merges: - #75672 (Move to intra-doc links for task.rs and vec.rs) - #75702 (Clean up E0759 explanation) - #75703 (Enable stack-overflow detection on musl for non-main threads) - #75710 (Fix bad printing of const-eval queries) - #75716 (Upgrade Emscripten on CI to 1.39.20 ) - #75731 (Suppress ty::Float in MIR comments of ty::Const) - #75733 (Remove duplicated alloc vec bench push_all_move) - #75743 (Rename rustc_lexer::TokenKind::Not to Bang) Failed merges: r? @ghost

view details

Matthew Jasper

commit sha 67fb5839df4c737911556f3c9967d632ae530a7c

Don't immediately error for cycles during normalization

view details

Guillaume Gomez

commit sha 631c80659dab1e6f0b335cd7862eddc341eff0ac

Remove "total" columns in --show-coverage output

view details

Guillaume Gomez

commit sha 9c254c18d6d32a15879cc7f57e3039b66a481340

Update how doc examples are counted

view details

Guillaume Gomez

commit sha d108bd53866aef2a3b76164352c095e898fe92db

Add documentation for --show-coverage option

view details

Guillaume Gomez

commit sha 5e9cc4e31920b72fe4f1c4a44d1a6e250e36f254

fmt

view details

Camelid

commit sha 5a307cf4bbf3cb6065b43472ab99c1dd4fdc72e5

Fix intra-doc links One of the original links was linking to the wrong thing as well. Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

Alexis Bourget

commit sha fb3f9271311cedcc75ec45c385305e3e66f8959e

Move to intra doc links for std::thread documentation

view details

bors

commit sha e15510ca33ea15c893b78710101c962b11459963

Auto merge of #75494 - matthewjasper:defer-recursive-projection-error, r=nikomatsakis Don't immediately error for cycles during normalization #73452 meant some normalization cycles could be detected earlier, breaking some code. This PR makes defers errors for normalization cycles to fulfillment, fixing said code. Fixes #74868 r? @nikomatsakis

view details

bors

commit sha 410461191393e2339e79b33fa8baf4650b905db0

Auto merge of #5928 - mikerite:fix-5924, r=ebroto Fix false positive in `PRECEDENCE` lint Extend the lint to handle chains of methods combined with unary negation. Closes #5924 changelog: Fix false negative in `PRECEDENCE` lint

view details

LeSeulArtichaut

commit sha 1ababd87942dd3f62d6abc5fa1833fce2d5b88eb

Use intra-doc-links in `alloc`

view details

Dr. Koutheir Attouchi

commit sha 6fca004ba9645b2c1d4a51ddbbac0c89dd2133d5

Another motivation for CFG: return-oriented programming

view details

bors

commit sha d9d4d39612aae0b8398340bd83d592cafad8e4ec

Auto merge of #73565 - matthewjasper:core-min-spec, r=nagisa Use min_specialization in libcore Getting `TrustedRandomAccess` to work is the main interesting thing here. - `get_unchecked` is now an unstable, hidden method on `Iterator` - The contract for `TrustedRandomAccess` is made clearer in documentation - Fixed a bug where `Debug` would create aliasing references when using the specialized zip impl - Added tests for the side effects of `next_back` and `nth`. closes #68536

view details

Josh Triplett

commit sha 574f6bed62a205c743737c6b13e925a04a3de6bb

Switch to Snappy compression for metadata

view details

Tomasz Miąsko

commit sha 3b995ccc3f3b8e13af53f4bfc7bff072ee77169a

Extend normalization in const-eval-query-stack test Builds with debuginfo have additional information in backtrace.

view details

Lzu Tao

commit sha c4c017a18487145cd5fdcfda741acc6a2a00bef7

Suppress "const" prefix of FnDef in MIR dump

view details

push time in a month

push eventchansuke/rust

Caleb Cartwright

commit sha 08e35155b42279c33b26512f5ce59734147de8b6

rustc_expand: remove pub visibility for rustfmt

view details

Ivan Tham

commit sha d80415a3bf0990efa9618273d30bb2c6d23b6f43

Improve ayu doc source line number contrast Improve contrast of foreground line number.

view details

Vadim Petrochenkov

commit sha 4fff14d3d8fa0f75e745e3d6b68967b1caa3aa97

rustbuild: Remove `Mode::Codegen`

view details

MaulingMonkey

commit sha 5acd272f5f7d892b73cfbe90bdf266af10ea30ce

Fix HashMap visualizers in Visual Studio (Code) CDB doesn't care that you're using static_cast between unrelated types. VS(C) does. These should've been reinterpret_cast or C casts. Cast is from e.g. `u8*` to `tuple<$T1, $T2>*`

view details

dylni

commit sha b92b0d6ee6ef1aaca1d7b7777eaa431fd29920a3

Fix typo in tracking issue template

view details

Elichai Turkel

commit sha 9e1403373d948a8e0e3b6e0dc0beec3e31401b28

Update linker-plugin-lto.md to contain up to rust 1.46

view details

Sasha

commit sha 84fc6fd2d0005d452ec966a65518948e3eab3f06

Fix documentation for TyCtxt::all_impls

view details

Elichai Turkel

commit sha 2e82589741a475185421a481f7a00142725fb609

linker-plugin-lto.md: Convert the rust-clang MxN table to a 2xM table

view details

Joshua Nelson

commit sha 3ecfd5ca518364ba0c5fb4ed92d5ae16245f6171

Move sections about contributing closer together

view details

Joshua Nelson

commit sha aee0ef13dd13b84dd270f7729fae5e9918ee309c

Remove duplicate 'note:'

view details

Mark Rousskov

commit sha aa4554f42deec0d81f89251960f6abb5acc2f6e2

Dedicated rust development tarball This currently includes libLLVM, llvm-config, and FileCheck, but will perhaps expand to more tooling overtime. It should be considered entirely unstable and may change at any time.

view details

kadmin

commit sha ee55c1f1d2c427fecedd68e28a7dc4e6c68738b5

Add regression test and help note

view details

Camelid

commit sha bf09a529eee38a2d2d7de767e018277c01aab774

rustdoc: Fix font CSS for crate lists I had put it in the wrong file in #76126. This should fix it now. Thank you to @ollie27 for pointing this out!

view details

Camelid

commit sha 1f78509afef6a67d5deea29fc4c43c837b71b13d

Improve wording of E0607 explanation

view details

Camelid

commit sha 98a5506647a2acdea9bfcc7fca93142159867869

Add "For example,"

view details

bors

commit sha 5099914a16a215794ad243df0cc7a05d91d168e0

Auto merge of #76332 - Mark-Simulacrum:bootstrap-llvm, r=pietroalbini Add rust-dev component to support rustc development This is preparatory work for permitting rustc developers to use CI-built LLVM rather than building it locally. Unlike distro-built LLVM, CI built LLVM is essentially guaranteed to behave perfectly for local development -- it is fully up to date, and carries all necessary patches. This is a separate PR from #76349 because it needs to land before that one, since we want a master build with the full CI LLVM to be available for easier testing.

view details

Guillaume Gomez

commit sha e0df2f87b6116133740bec90f341943181d90f1c

Create new E0774 code error

view details

Guillaume Gomez

commit sha 1d02f4fdcca2ca7b6dd487b505664a37cb1e9a8b

Update tests

view details

Alexander Brausch

commit sha 98231bfb953406fd7b5dcbdfa7229d44554776a0

Make duration_since documentation more clear

view details

Eric Huss

commit sha 8b2106f77a364337675c6d4534681f1d1d18cb91

Update cargo

view details

push time in a month

push eventchansuke/rust

Jon Gjengset

commit sha 2f96ce89d03b248c269513b011d328bff2c8dc21

Stabilize deque_make_contiguous Closes #70929.

view details

Christian Duerr

commit sha f3d7645fb79d641de447d4af02d5f3cee91b4af3

Add trailing comma support to matches macro

view details

dylni

commit sha bb70e52f5f5ee25012193f9f4f4372702b97b20e

Add `slice::check_range`

view details

dylni

commit sha 202b242d87c30c2fe1475342f9b93a8dfc65cd17

Fix links

view details

dylni

commit sha ed02b90e9b76b9ce2e8e99a99dbadd96ab4dfb42

Fix links again

view details

The8472

commit sha 1316c786a08344c965a97b1b67c76a300a479eec

Workaround for copy_file_range spuriously returning EOPNOTSUPP when attemted on a NFS mount under RHEL/CentOS 7. The syscall is supposed to return ENOSYS in most cases but when calling it on NFS it may leak through EOPNOTSUPP even though that's supposed to be handled by the kernel and not returned to userspace. Since it returns ENOSYS in some cases anyway this will trip the HAS_COPY_FILE_RANGE detection anyway, so treat EOPNOTSUPP as if it were a ENOSYS. https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/7.8_release_notes/deprecated_functionality#the_literal_copy_file_range_literal_call_has_been_disabled_on_local_file_systems_and_in_nfs https://bugzilla.redhat.com/show_bug.cgi?id=1783554

view details

The8472

commit sha f0783632d315db90c0ca34d79d56207d132f3764

more concise error matching

view details

CDirkx

commit sha 6b0d44e92a529962792d3a5f1e7b44b6e3c6ed05

Make some Ordering methods const Constify the following methods of `core::cmp::Ordering`: - `reverse` - `then` Possible because of #49146 (Allow `if` and `match` in constants).

view details

The8472

commit sha 4ddedd521418d67e845ecb43dc02c09b0af53022

perform copy_file_range until EOF is reached instead of basing things on file size This solves several problems - race conditions where a file is truncated while copying from it. if we blindly trusted the file size this would lead to an infinite loop - proc files appearing empty to copy_file_range but not to read/write https://github.com/coreutils/coreutils/commit/4b04a0c - copy_file_range returning 0 for some filesystems (overlay? bind mounts?) inside docker, again leading to an infinite loop

view details

dylni

commit sha d04e6b8de5fe6bbf203c534c35e6f55e8960ab46

Replace ad hoc implementations with `slice::check_range`

view details

Yuki Okushi

commit sha 18ad5a594ec4ee039897eb03d90dfeb117b4c6d6

Add a regression test for issue-72793

view details

Stein Somers

commit sha e5f9d7ff92f62cde3ef1b7301ac4ac3adab990d9

BTreeMap: introduce marker::ValMut and reserve marker::Mut for unique access

view details

Esteban Küber

commit sha 35e166e5d28b211c4b69fe9ae7c0aa970e71e321

Account for async functions when suggesting new named lifetime Fix #75850.

view details

dylni

commit sha d9e877fb98212a47dd425e145b8b3e4283e6b487

Add more information to safety comment

view details

Camelid

commit sha acd396225e0228f297474524396e08e0f594347e

Fix typo in release notes

view details

Amjad Alsharafi

commit sha d39cc45cf251be63f3066c6002d409274aa9d2a4

Added a lot of min_const_generics revisions

view details

Amjad Alsharafi

commit sha d89d2a972d3174504594ff2eba70423dacaddcfb

Added more min_const_generics revisions to tests

view details

Amjad Alsharafi

commit sha 7a7a28d6bbfa6bbbbd3c4d65a11e9b33995cd63f

Fixed file formatting and made `tidy` happy

view details

Arkadiusz Piekarz

commit sha aa40c028fcb20a47fb214fea2899ff9a8ae88840

Unstable Book: add links to tracking issues for FFI features

view details

Camelid

commit sha 294c1160bb693a77ad2683321b9196352bd837dc

Improve docs for the `const` keyword

view details

push time in a month

push eventchansuke/rust-clippy

flip1995

commit sha 282c59820b8e1d8c76f440484b81a190c576f91b

Merge commit '3d0b0e66afdfaa519d8855b338b35b4605775945' into clippyup

view details

Eduardo Broto

commit sha 7a66e6502dc3c7085b3f4078c01d4957d96175ed

or_fn_call: ignore nullary associated const fns

view details

Kyle Huey

commit sha 4972989b616cbf96c015cd9fdf1f4b4464ecaace

Add a lint for an async block/closure that yields a type that is itself awaitable. This catches bugs of the form tokio::spawn(async move { let f = some_async_thing(); f // Oh no I forgot to await f so that work will never complete. });

view details

Kyle Huey

commit sha c1d2b9376a6bb4fc06f845e12b9c2a93079bb2ee

Add a test for an async function.

view details

Kyle Huey

commit sha 04912ca115ff153a97d80b604435b10dcb155dd0

Formatting changes requested by ThibsG.

view details

Camelid

commit sha 17b2ba5ded12f59dba63ece659b5cd714b763800

Syntax-highlight `single_char_push_str` lint

view details

bors

commit sha ab64d47c03c168bf6b2a03851894acf74a5ba117

Auto merge of #5988 - camelid:patch-2, r=ebroto Syntax-highlight `single_char_push_str` lint It wasn't being syntax highlighted in the online lint index: ![image](https://user-images.githubusercontent.com/37223377/91666682-8fc02000-eab3-11ea-95fa-6671472712c8.png) changelog: none

view details

Aaron Hill

commit sha fdc48fb90c04b26b03ee7d8ae85e3175e5fc538c

Fix clippy

view details

bors

commit sha 001c1c51d2d4b6964a2f0c0c5936bfaacf49a585

Auto merge of #5984 - ebroto:5693_const_assoc_fn, r=flip1995 or_fn_call: ignore nullary associated const fns The fix in #5889 was missing associated functions. changelog: Ignore also `const fn` methods in [`or_fun_call`] Fixes #5693

view details

Takayuki Nakata

commit sha 001f9e45f24c5617d816e7d9dfbca4dc1a694dd9

Fix the wrong suggestion when using macro in `collapsible_if`

view details

Taiki Endo

commit sha 8b0aa6a00b19b8e47a72157ec8e8f9e9060cb2fb

default_trait_access: Fix wrong suggestion

view details

bors

commit sha 8334a58c2f949fd5f1e2c131ae7b614498bae746

Auto merge of #5909 - khuey:async_yields_async, r=yaahc Add a lint for an async block/closure that yields a type that is itself awaitable. This catches bugs of the form tokio::spawn(async move { let f = some_async_thing(); f // Oh no I forgot to await f so that work will never complete. }); See the two XXXkhuey comments and the unfixed `_l` structure for things that need more thought. *Please keep the line below* changelog: none

view details

bors

commit sha 066f105d679d2c120ad92baf19a10337c446e794

Auto merge of #5992 - giraffate:fix_wrong_seggestion_in_collapsible_if, r=yaahc Fix the wrong suggestion when using macro in `collapsible_if` Fix #5962 changelog: Fix the wrong suggestion when using macro in `collapsible_if`

view details

rail

commit sha afeb917fca7eaa5b44acd29a60f687024c0ebeac

Fix a fp in `transmute_ptr_to_ptr` Avoid firing the lint when `transmute` in const contexts as dereferencing raw pointers in consts is unstable. cc #5959

view details

Taiki Endo

commit sha 2e4b4cebbbb37efa5dc69dd2616f3b7a288b92aa

useless_attribute: Permit wildcard_imports and enum_glob_use

view details

Koxiaet

commit sha b30422114e6bb7235398f21fe13ffa09429b7d0f

Allow GraphQL in doc without backticks

view details

Takayuki Nakata

commit sha aa7ffa5257667edb284de16b529df3d4111d70ab

Fix FP in `same_item_push` Don't emit a lint when the pushed item doesn't have Clone trait

view details

bors

commit sha 67e18c2d5cb56a7b34312265ec6d4c780028cfe9

Auto merge of #5993 - taiki-e:default_trait_access, r=phansch default_trait_access: Fix wrong suggestion https://github.com/rust-lang/rust-clippy/issues/5975#issuecomment-683751131 > I think the underlying problem is clippy suggests code with complete parameters, not clippy triggers this lint even for complex types. AFAIK, If code compiles with `Default::default`, it doesn't need to specify any parameters, as type inference is working. (So, in this case, `default_trait_access` should suggest `RefCell::default`.) Fixes #5975 Fixes #5990 changelog: `default_trait_access`: fixed wrong suggestion

view details

bors

commit sha 48248af6307643072b337db3fe991fd6e638bfdd

Auto merge of #5999 - rail-rain:fix_fp_transmute_ptr_to_ptr_in_consts, r=ebroto Fix a fp in `transmute_ptr_to_ptr` fixes #5959 changelog: Fix a false positive in `transmute_ptr_to_ptr` that the lint fires when `transmute` is used to cast a reference in const contexts although dereferencing raw pointers in consts is unstable.

view details

Eduardo Broto

commit sha da8606777516d8b8fe47110626c93eaef1f9795d

Merge remote-tracking branch 'upstream/master' into sync-from-rust

view details

push time in a month

issue commentrust-lang/rust

Thread 'rustc' has overflowed its stack on dumb program

@rustbot claim

AuroransSolis

comment created time in 2 months

push eventchansuke/rust-clippy

Eduardo Broto

commit sha baf62e7a38854ff6a0039ddccb124ff329a32143

Update changelog to beta 1.47

view details

Takayuki Nakata

commit sha 04bff17668be1305d9efe235665a32727ff3e0b5

Fix FP in `to_string_in_display` Don't emit a lint when `.to_string()` on anything that is not `self`

view details

ThibsG

commit sha 2a3ee5fa854b49530008582900c6ea7fac120d1c

Fix FP in `new_ret_no_self`: trigger in trait def instead of impl block

view details

ThibsG

commit sha 3cb75c2e5cdd4f450f2974c5e052d569674d95fd

Remove expansion restriction + fix doc and tests naming

view details

ThibsG

commit sha 504612622f2801b43dbe3e6788d2404d394376df

Merge logic of looking for `Self` type

view details

bors

commit sha 07c5e9edb5db8723b15573eb6ebe183fddbc5d33

Auto merge of #5971 - giraffate:fix_fp_in_to_string_in_display, r=ebroto Fix FP in `to_string_in_display` Don't emit a lint when `.to_string()` on anything that is not `self` Fix #5967 changelog: Fix FP in `to_string_in_display` when calling `.to_string()` on anything that is not `self`

view details

Thibaud

commit sha e8be047c5b2d5b1522a16b4b52cc7acfa4581ca3

Update clippy_lints/src/utils/mod.rs Co-authored-by: Eduardo Broto <ebroto@tutanota.com>

view details

Thibaud

commit sha ffaadae8e48699f115eafd2853c252f546a69a28

Update clippy_lints/src/utils/mod.rs Co-authored-by: Eduardo Broto <ebroto@tutanota.com>

view details

Thibaud

commit sha 73b1ee1a614aaad7dd43958280ff4a444c8b737e

Update clippy_lints/src/methods/mod.rs Co-authored-by: Eduardo Broto <ebroto@tutanota.com>

view details

bors

commit sha 3d0b0e66afdfaa519d8855b338b35b4605775945

Auto merge of #5774 - ThibsG:FixNewRetNoSelf, r=ebroto Fix FP in `new_ret_no_self`: trigger in trait def instead of impl block Lint in trait def instead of impl block. Fixes: #5435 changelog: none

view details

bors

commit sha c88c6149415dd47b5f05e69d7307e0a1967c33f2

Auto merge of #5970 - ebroto:changelog_beta_1_47, r=flip1995 Update changelog to beta 1.47 [Rendered](https://github.com/ebroto/rust-clippy/blob/changelog_beta_1_47/CHANGELOG.md) changelog: none

view details

push time in 2 months

push eventchansuke/rust

Philippe Nadon

commit sha 2d1515a2c532b0cceec4a14da6f21e48fdca2da5

Miri: Renamed "undef" to "uninit" Renamed remaining references to "undef" to "uninit" when referring to Miri. Impacted directories are: - src/librustc_codegen_llvm/consts.rs - src/librustc_middle/mir/interpret/ - src/librustc_middle/ty/print/pretty.rs - src/librustc_mir/ - src/tools/clippy/clippy_lints/src/consts.rs Upon building Miri based on the new changes it was verified that no changes needed to be made with the Miri project. Related issue #71193

view details

Wim Looman

commit sha a8de713e26cb0f8e8ae4a7ecb0bf8a413b539926

Improve rendering of crate features via doc(cfg)

view details

Wim Looman

commit sha 234ec956ab91d4aef51b63f25b78d176aa364a60

Render longhand multiple crate/target features nicer

view details

Tim Nielens

commit sha a77e881ec9f324cdc544150f897d8b34281f92e4

should_impl_trait - ignore methods with lifetime params

view details

Tim Nielens

commit sha 2bc0ecd44b4d09476eade641e02451d949a1c8e2

should_implement_trait - add test cases for every checked trait method

view details

Tim Nielens

commit sha e6b2254f9e55743dbace44cc73c6447b6bda58e5

should_implement_trait - pr remarks

view details

Tim Nielens

commit sha 7cc1a2ed879e45605a53b802cfa5291c9a51284c

should_implement_trait - filter on explicit lifetime param only

view details

Tim Nielens

commit sha 166c520e9a8b1a45819255e75dee737136aa6ec8

should_impl_trait - pr comments

view details

Tim Nielens

commit sha f9ba829f6701ae03a5c226044dbbde13ce87e123

should_impl_trait - self linting

view details

Ryan Wiedemann

commit sha 3e3e50bf0fa6282c7265e34589170033c2301edd

Add example of false positive to PTR_ARG docs. Fixes #214

view details

Ryan Wiedemann

commit sha fbf637d12c95528846bfa65ce67bd652f2affb43

formatting

view details

Yuki Okushi

commit sha 91aa55d891e029831e2eceb662184afc8d2e0415

Rollup merge of #75226 - pnadon:miri-undef-uninit, r=RalfJung Miri: Renamed "undef" to "uninit" Renamed remaining references to "undef" to "uninit" when referring to Miri. Impacted directories are: - `src/librustc_codegen_llvm/consts.rs` - `src/librustc_middle/mir/interpret/` - `src/librustc_middle/ty/print/pretty.rs` - `src/librustc_mir/` - `src/tools/clippy/clippy_lints/src/consts.rs` Upon building Miri based on the new changes it was verified that no changes needed to be made with the Miri project. Related issue #71193

view details

Matthias Krüger

commit sha b8713e3854cb90b974eceaa1d50484831591619c

unnecessary-mut-passed: make lint message say if fn is a function or a method.

view details

bors

commit sha 3337f7956cf6100c9e5acfd72d42ec312efb6a7f

Auto merge of #5892 - matthiaskrgr:redundant_mut, r=flip1995 unnecessary-mut-passed: make lint message say if fn is a function or a method changelog: refine "unnecessary-mut-passed" lint message

view details

Matthias Krüger

commit sha c0a9d64818d7076b72fd6c3a9e6172eca659034b

stable-sort-primitive: make lint adhere to lint message convention

view details

Matthias Krüger

commit sha ac194cafc124276d4614bf023ca7ea6e9be9c6ed

map_clone: make lint adhere to lint message convention

view details

Matthias Krüger

commit sha 04867e004ebc0f2edf66d0a457e785848451f13a

mutex-atomic: make lint adhere to lint message convention

view details

Matthias Krüger

commit sha 6af297f80e59050c87078f1ba6f05c97d6f90fd7

iter-next-slice: make lint adhere to lint message convention

view details

Matthias Krüger

commit sha f171f89aed11043e459c3baab305e7f859debb94

int_plus_one: make lint adhere to lint message convention

view details

Matthias Krüger

commit sha bdf4dc3abd9a49f699d9de209a1f4d55ce770191

implicit-saturating-sub: make lint adhere to lint message convention

view details

push time in 2 months

pull request commentrust-lang/rust

`#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi

@crlf0710 Thanks, I'll take a look at the compilation error.

chansuke

comment created time in 2 months

issue commentrust-lang/rust

Thread 'rustc' has overflowed its stack on dumb program

Hi. I'd like to work on this issue

AuroransSolis

comment created time in 2 months

push eventchansuke/rust-clippy

Michael Wright

commit sha e8d33d73dc3f9d0daf9b3affe65a2431f5a3e13a

Fix `let_and_return` bad suggestion Add a cast to the suggestion when the return expression has adjustments. These adjustments are lost when the suggestion is applied. This is similar to the problem in issue #4437. Closes #5729

view details

Eduardo Broto

commit sha 6dd65b8e6a548071b19507826c53bf9a7c36b323

Fix cargo dev new_lint for late lint passes

view details

Eduardo Broto

commit sha eb8ede7f659da6c07d1f475aff9b0d46e5b49a79

Improve documentation related to the sync process

view details

Eduardo Broto

commit sha 8776db9f6d5163ca40232336dc51ad77eeb2b5e5

Fix ICE in `repeat_once` lint

view details

rail

commit sha 91b200c62b7c464cb890c68230ab2d74605a60d0

Fix fp in `borrow_interior_mutable_const` Fix false positive when referencing a field behind a pointer.

view details

bors

commit sha 2d86cc5a33dd4a7cb586ab28822cdfceace92816

Auto merge of #5930 - ebroto:dev_newlint_fix_lt, r=matthiaskrgr Fix cargo dev new_lint for late lint passes Since https://github.com/rust-lang/rust-clippy/commit/30c046ede47ea45a772d2656b0365a4807263bca, `LateLintPass` has only one lifetime parameter. I'm not sure how to easily test this, I think adding this kind of tests would be probably part of #5394 changelog: none

view details

bors

commit sha 27ae4d303ce9103a104c57088913741ab17f4d36

Auto merge of #5948 - ebroto:5944_repeat_ice, r=Manishearth Fix ICE in `repeat_once` changelog: Fix ICE in [`repeat_once`] Fixes #5944

view details

Eduardo Broto

commit sha b05077ea75f4585551650fc2d40a196ae437393d

Apply suggestions from PR review

view details

Takayuki Nakata

commit sha b2c226679251bb795d786d7cdd11d2e2c9d0e685

Fix FP for `redundant_closure_call` Visit the nested things like function body when checking closure call.

view details

Takayuki Nakata

commit sha 9fe0ac36a53dfba14f5f33f5bab2fd243fb2c18e

Avoid period in lint message according to convention

view details

rail-rain

commit sha ce8915c85cebaa30e6846322e0ab44a4f4f9cb65

typo Co-authored-by: Thibaud <ThibsG@users.noreply.github.com>

view details

ThibsG

commit sha 3d820f71fe820c0bb7a1204e28ce549407a937cc

Fix incorrect suggestion when `clone_on_ref_ptr` is triggered in macros

view details

Bastian

commit sha 680c68153bced747c90947e0265c92076edcb838

Added a lint which corrects expressions like (a - b) < f32::EPSILON

view details

Matthias Krüger

commit sha e9964f2e8a1903d46e576f67122e234f719a90f0

stable_sort_primitive: print the type that is being sorted in the lint message

view details

bors

commit sha 8d9a485ef11c3c30fb87f35f61278027e7370510

Auto merge of #5935 - matthiaskrgr:unstable_sort_ty_name, r=flip1995 stable_sort_primitive: print the type that is being sorted in the lint message changelog: stable_sort_primitive: print the type that is being sorted in the lint message

view details

Scott McMurray

commit sha 48b4aeabf83db10393b06fff3b58161ccc586fe9

Unbreak the clippy test

view details

bors

commit sha 64b53f3877dc9a843b1e4477e1c2c217e0e6a596

Auto merge of #5920 - giraffate:fix_fp_for_redundant_closure_call, r=mikerite Fix FP for `redundant_closure_call` Fix #5916 changelog: Fix FP for `redundant_closure_call` when called in function body

view details

Michael Wright

commit sha 91028326927266af5051b5d172dc3162d147a4d9

Fix incorrect comment

view details

Michael Wright

commit sha 48d473691359f7c59d7348937f71de0e5aa4ae12

Simplify fmt test by using the clippy dev alias

view details

Michael Wright

commit sha c7dc9c3cf7dc8a810ed0456834cd162055847e9d

Fix intermittent build error The fmt test will cause clippy dev to be compiled and run. The clippy dev dependencies are currently stored at `target/debug/deps` when this happens. This location sometimes causes conflicts with ui tests which result in the build error "thread 'compile_test' panicked at 'Found multiple rlibs for crate `regex` ...". This commit forces the clippy_dev dependencies to be stored under `clippy_dev/target/` which seems to resolve this problem.

view details

push time in 2 months

push eventchansuke/rustfmt

Ayaz Hafiz

commit sha d7f0d76518a62145e540275cce42343539378bd1

Correctly indent skipped-over code Closes #4398

view details

push time in 2 months

push eventchansuke/rust

Brian Cain

commit sha 2ca1e59bb60e27abc858fc271b91ef5ba4f6b6a6

Hexagon libstd: update type defs

view details

Leon Matthes

commit sha e6c83dd57b920d2069797736ae0a1c9fe14a97cb

Document that slice means pointer to a sequence Also document that slices are twice as large as pointers to Sized types

view details

Leon Matthes

commit sha a9af93beebe183d716c0e7313ff8a0fb79b27b6b

Add missing period

view details

Leon Matthes

commit sha 41d3e1cf738b6bfe1c7f85ad09b2adea9c8744e8

Add missing import to Rc

view details

Aaron Hill

commit sha 5f7436b5fd27e534b2800389067b169cbe7864b7

Be consistent when describing a move as a 'partial' in diagnostics When an error occurs due to a partial move, we would use the world "partial" in some parts of the error message, but not in others. This commit ensures that we use the word 'partial' in either all or none of the diagnostic messages. Additionally, we no longer describe a move out of a `Box` via `*` as a 'partial move'. This was a pre-existing issue, but became more noticable when the word 'partial' is used in more places.

view details

Ryan Levick

commit sha 57572cf8096ccb332370f7a711641a061bfd7434

Call into fastfail on abort in libpanic_abort on Windows x86(_64)

view details

Ryan Levick

commit sha 6778baf516cf00d6ba2d3f448aa312b4ac2e43b5

Fix up docs

view details

Ryan Levick

commit sha b9b8b5c96b60789b6b7846a4036d3cbf2d393014

Reverse formatting

view details

DPC

commit sha 76b99d5f1d3eac78a4c4a383e42339fc88affeac

Add Arc::new_cyclic

view details

DPC

commit sha db34e352a7983bf5a4584e93e54362ef45b70b58

fix duplicated feature gate

view details

DPC

commit sha fdc2d1f49906752585177e99b8bc285d796e4b3e

add missing newline

view details

DPC

commit sha 9ad17b9ca7a0fce32abf4c85ee38ed14aefe39cf

tidy up

view details

Wonwoo Choi

commit sha c4fb3f297b36e902369a3f62214274149865e6e2

Provide better spans for the match arm without tail expression

view details

Lzu Tao

commit sha 768509ff84d8527e587df68ecfc4ed962b9f5f2a

Minor changes to Ipv4Addr * Impl IntoInner rather than AsInner for Ipv4Addr * Add some comments * Add test to show endiannes of Ipv4Addr display

view details

Tim Diekmann

commit sha 438c40efa109d7a4d83efa066c19cb95dad9ed94

Allow reallocation to different alignment

view details

Mateusz Mikuła

commit sha fbce8785d4ca784006ff84d8226befe8b372decd

Fix windows-gnu host cross-compilation

view details

Tim Diekmann

commit sha 303ee3fd8382947d0da7a728c728bc672dc0f7be

Add debug assertion for equal alignment in RawVec

view details

Tim Diekmann

commit sha 46b547cb5861febd3e0401acb0af6f65be775948

Assume same alignment in `RawVec`

view details

Jubilee Young

commit sha 31afacf65182ef2db32e140b8ab6fe2c75a6daa7

bump tidy to cargo_metadata 0.11 Updates cargo_metadata in tidy's Cargo.toml from 0.9.1 to 0.11 Real version change 0.9.11 -> 0.11.1 https://github.com/oli-obk/cargo_metadata/compare/v0.9.1...v0.11.1

view details

Wesley Wiser

commit sha 8dea3088c6f36455a6d0a2eb7eaf7a81414ce967

Add a CGU partitioning trait This will allow us to prototype different partitioning schemes without adding a lot of extra conditionals everywhere.

view details

push time in 2 months

more