profile
viewpoint
Carlos Eduardo Seo ceseo @IBM São Paulo, Brazil https://www.carlosseo.com Senior Software Engineer @IBM • Go Programming Language compiler contributor • Inventor

ceseo/glibc 1

My personal glibc repository

ceseo/go 1

The Go programming language

ceseo/libauxv 1

The Auxilary-Vector Library

ceseo/toolchain-bootstrap 1

Toolchain Bootstrap Project. A script set to ease the way of bootstraping the GNU Toolchain

ceseo/binutils-gdb 0

My personal binutils-gdb repository

ceseo/dep 0

Go dependency management tool

ceseo/libxsmm 0

Library targeting Intel Architecture for specialized dense and sparse matrix operations, and deep learning primitives.

ceseo/numpy 0

The fundamental package for scientific computing with Python.

ceseo/pytorch 0

Tensors and Dynamic neural networks in Python with strong GPU acceleration

ceseo/qtrace-tools 0

Tools to read and write qtrace instruction traces

push eventceseo/go

Dmitri Shuralyov

commit sha 1cd724acb6304d30d8998d14a5469fbab24dd3b1

doc/go1.14: highlight the addition of hash/maphash package Given that it's a package that did not exist before, was a proposal in issue #28322, got accepted and implemented for 1.14, it seems to be more than a minor change to the library. Highlight it accordingly. Also specify the results are 64-bit integers, as done in CL 219340. Updates #36878 Updates #28322 Change-Id: Idefe63d4c47a02cdcf8be8ab08c40cdb94ff2098 Reviewed-on: https://go-review.googlesource.com/c/go/+/219877 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Toshihiro Shiino <shiino.toshihiro@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in an hour

push eventceseo/go

Dmitri Shuralyov

commit sha a0cf2c872fd3b8fd34979d13b41115f9be8c90a1

doc/go1.14: remove TODO comment for CL 200439 Based on https://golang.org/issue/36878#issuecomment-587533153 and https://golang.org/issue/36878#issuecomment-587549692, this is not a CL that needs to be mentioned in the release notes. Updates #36878 Change-Id: Icaa9153da7481a1d3ebabc237411539dd770cef2 Reviewed-on: https://go-review.googlesource.com/c/go/+/219898 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 2 hours

push eventceseo/go

Cherry Zhang

commit sha a9ea91d571b75d27a49e07f3604b8faa7a48525d

cmd/link, runtime: skip holes in func table On PPC64 when external linking, for large binaries we split the text section to multiple sections, so the external linking may insert trampolines between sections. These trampolines are within the address range covered by the func table, but not known by Go. This causes runtime.findfunc to return a wrong function if the given PC is from such trampolines. In this CL, we generate a marker between text sections where there could potentially be a hole in the func table. At run time, we skip the hole if we see such a marker. Fixes #37216. Change-Id: I95ab3875a84b357dbaa65a4ed339a19282257ce0 Reviewed-on: https://go-review.googlesource.com/c/go/+/219717 Reviewed-by: David Chase <drchase@google.com>

view details

push time in 4 hours

push eventceseo/go

Alberto Donizetti

commit sha 88e564edb13f1596c12ad16d5fd3c7ac7deac855

doc/go1.14: add missing period at sentence end Change-Id: I82050f16906e7d34555a592e96b7855515a1726a Reviewed-on: https://go-review.googlesource.com/c/go/+/219641 Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>

view details

push time in a day

push eventceseo/go

Ian Lance Taylor

commit sha 6917529cc604bad3b7d67579ca8d569442e3d880

testing: remove obsolete comment in testing.(*T) docs We now only accumulate logs when not using -v. Just drop the sentence entirely rather than try to describe the current situation. Updates #24929 Updates #37203 Change-Id: Ie3bf37894ab68b5b129eff54637893c7a129da03 Reviewed-on: https://go-review.googlesource.com/c/go/+/219540 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

push time in 3 days

push eventceseo/go

Cherry Zhang

commit sha 123f7dd3e1eb90825ece57b8dde39438ca34f150

runtime: zero upper bit of Y registers in asyncPreempt on darwin/amd64 Apparently, the signal handling code path in darwin kernel leaves the upper bits of Y registers in a dirty state, which causes many SSE operations (128-bit and narrower) become much slower. Clear the upper bits to get to a clean state. We do it at the entry of asyncPreempt, which is immediately following exiting from the kernel's signal handling code, if we actually injected a call. It does not cover other exits where we don't inject a call, e.g. failed preemption, profiling signal, or other async signals. But it does cover an important use case of async signals, preempting a tight numerical loop, which we introduced in this cycle. Running the benchmark in issue #37174: name old time/op new time/op delta Fast-8 90.0ns ± 1% 46.8ns ± 3% -47.97% (p=0.000 n=10+10) Slow-8 188ns ± 5% 49ns ± 1% -73.82% (p=0.000 n=10+9) There is no more slowdown due to preemption signals. For #37174. Change-Id: I8b83d083fade1cabbda09b4bc25ccbadafaf7605 Reviewed-on: https://go-review.googlesource.com/c/go/+/219131 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>

view details

Cherry Zhang

commit sha 3eab754cd061bf90ee7b540546bc0863f3ad1d85

runtime: correct caller PC/SP offsets in walltime1/nanotime1 In walltime1/nanotime1, we save the caller's PC and SP for stack unwinding. The code does that assumed zero frame size. Now that the frame size is not zero, correct the offset. Rewrite it in a way that doesn't depend on hard-coded frame size. May fix #37127. Change-Id: I47d6d54fc3499d7d5946c3f6a2dbd24fbd679de1 Reviewed-on: https://go-review.googlesource.com/c/go/+/219118 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>

view details

push time in 5 days

push eventceseo/go

Keith Randall

commit sha a0c9fb6bd359f111f19176ff176244b91a3e7eaa

hash/maphash: mention the results are 64-bit integers Change-Id: I0d2ba52d79c34d77d475ec8d673286d0e56b826b Reviewed-on: https://go-review.googlesource.com/c/go/+/219340 Reviewed-by: Alan Donovan <adonovan@google.com>

view details

push time in 5 days

push eventceseo/go

Keith Randall

commit sha e237df5b53eb91d7a8d7247e7996f5edee6515b7

runtime: fix fallback logic for aeshash on 32/64 bit We were using the fallback hash unconditionally. Oops. Fixes #37212 Change-Id: Id37d4f5c08806fdda12a3148ba4dbc46676eeb54 Reviewed-on: https://go-review.googlesource.com/c/go/+/219337 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

push time in 5 days

push eventceseo/go

Bryan C. Mills

commit sha 363bcd0068bcc64ec09ab3d09921f559ca6d8070

cmd/go: eliminate empty '()' when passing -mod=readonly explicitly to 'go list' Discovered while investigating #37197. Updates #33326 Updates #34822 Change-Id: I38b136a4ee762a580a554125066b9778491295f2 Reviewed-on: https://go-review.googlesource.com/c/go/+/219237 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in 6 days

push eventceseo/go

Jay Conrod

commit sha 73859478257884608030e5e8d774ffa3321f0ecf

cmd/go/internal/modcmd: remove dead function addModFlag This function is never called and should have been removed earlier. work.AddModCommonFlags defines the -modfile flag instead. Fixes #37189 Change-Id: I73ad2a727013a849cba44bf70de04160f37c97dd Reviewed-on: https://go-review.googlesource.com/c/go/+/219197 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

push time in 6 days

push eventceseo/go

Kanta Ebihara

commit sha 5ce8005990f77d06f19cf70029353fb911d63d1f

cmd/go/internal/web: fix a typo dependenicies -> dependencies Change-Id: I0b8f06c04cf397c6330ffb43ac3ae5c2f7cf3138 Reviewed-on: https://go-review.googlesource.com/c/go/+/219157 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 7 days

push eventceseo/go

Dmitri Shuralyov

commit sha d0050e2871cf3916d99b11e67a4bf34ef025ec19

go/build: populate partial package information in importGo This is a followup to CL 199840 and CL 203820. Cumulatively, they caused a previously known bug to trigger more often while also nearly fixing it. This change is a small fixup to CL 199840 that resolves the known bug and prevents it from causing an additional regression in Go 1.14. Part 1 The intention in CL 199840 was to return the same error that 'go list' reported when the package wasn't located, so an early return was added. However, to determine whether the package was located or not, p.Dir was unintentionally checked instead of dir. p is initialized to &Package{ImportPath: path} at top of Context.Import, and its Dir field is never set before that line in importGo is reached. So return errors.New(errStr) was always executed whenever errStr != "". Originally, in CL 125296, the "go list" invocation did not include an '-e' flag, so it would return a non-zero exit code on packages where build constraints exclude all Go files, and importGo would return an error like "go/build: importGo import/path: unexpected output: ...". CL 199840 added an '-e' flag to the "go list" invocation, but checking the wrong dir variable caused partial package information to never get populated, and thus issue #31603 continued to occur, although with a different error message (which ironically included the location of the package that was supposedly "not found"). Now that the right dir is checked, issue #31603 is fixed. Part 2 importGo checks whether it can use the go command to find the directory of a package. In Go 1.13.x and earlier, one of the conditions to use the go command was that the source directory must be provided. CL 203820 made a change such that knowing the source directory was no longer required: // To invoke the go command, -// we must know the source directory, // ... That meant build.Import invocations where srcDir is the empty string: build.Import(path, "", build.FindOnly) Started using the go command to find the directory of the package, and started to run into issue #31603 as well. That's the #37153 regression. Since this change fixes issue #31603, it also fixes issue #37153. Part 3 There is one more thing. Delete the debugImportGo constant, it's unused. Updates #26504 (CL 125296) Updates #34752 (CL 199840) Updates #34860 (CL 203820) Fixes #31603 Fixes #37153 Change-Id: Iaa7dcc45ba0f708a978950c75fa4c836b87006f4 Reviewed-on: https://go-review.googlesource.com/c/go/+/218817 Reviewed-by: Jay Conrod <jayconrod@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

push time in 7 days

push eventceseo/go

Ian Lance Taylor

commit sha 1c241d28792fad017cbd64bae72ea3f3ee51e4df

hash/maphash: mention that hash values do not persist in package docs Updates #36878 Fixes #37040 Change-Id: Ib0bd21481e5d9c3b3966c116966ecfe071243a24 Reviewed-on: https://go-review.googlesource.com/c/go/+/218297 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>

view details

push time in 8 days

push eventceseo/go

Filippo Valsorda

commit sha 25da21ddc935f1af1b10361c52984ddaaade9265

crypto/elliptic: document the Name and names of each curve See https://tools.ietf.org/html/rfc8422#appendix-A for a helpful table. Also, commit to keeping them singletons, as that assumption is already made all over the place in the ecosystem. Fixes #34193 Change-Id: I2ec50fa18bb80e11d6101f2562df60b5e27d4f66 Reviewed-on: https://go-review.googlesource.com/c/go/+/218921 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 8 days

push eventceseo/go

Filippo Valsorda

commit sha ab5d9f5831cd267e0d8e8954cfe9987b737aec9c

doc/go1.14: add a couple minor crypto release notes These were left out of CL 216759 because they are trivial, but I was advised to be thorough. Updates #36878 Change-Id: Id4fd3a84866a82265e3f89abfdad6e3d231b507c Reviewed-on: https://go-review.googlesource.com/c/go/+/218918 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 8 days

push eventceseo/go

Dmitri Shuralyov

commit sha 6a8164a254117729104f70aecb47ecf481263c8d

go/doc: clarify that NewFromFiles caller must filter by GOOS/GOARCH The most well known and important build constraints to take into account when rendering package documentation are the GOOS/GOARCH values. Make it more clear in the NewFromFiles documentation that they are a part of all build constraints that the caller is responsible for filtering out. Also suggest the "go/build".Context.MatchFile method for performing file matching. The logic to perform build context file matching is subtle and has many rules that aren't well known (for example, taking the gc or gccgo compiler into account). It is currently the only exported API in the standard library that implements this logic, and it would be unfortunate if people attempt to re-create it because they don't realize it is already available. Updates #23864 Change-Id: I3c5901e7081acf79125b2d429ec3aa3b58416ed7 Reviewed-on: https://go-review.googlesource.com/c/go/+/218477 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 8 days

push eventceseo/go

Jay Conrod

commit sha dff55c1f7605294568ae7e00b09ef8935dbedf3b

doc: move doc/modules.md to x/website Moved /doc/modules.md from GOROOT to x/website. The corresponding change in x/website is CL 218239. See explanation there. Updates #33637 Change-Id: I329935624e6e264873bc68b6487405a63d3e7030 Reviewed-on: https://go-review.googlesource.com/c/go/+/218240 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

push time in 8 days

push eventceseo/go

Toshihiro Shiino

commit sha cfe2ab42e764d2eea3a3339aac1eaff97520baa0

doc/go1.14: rearrange in alphabetical order "Minor changes to the library" are basically arranged in alphabetical order, but there are some mistakes so we will correct them. Updates #36878 Change-Id: I8498563b739eff9f1b0a76ead3cf290191e0ce36 Reviewed-on: https://go-review.googlesource.com/c/go/+/218638 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

view details

push time in 10 days

push eventceseo/go

Toshihiro Shiino

commit sha ca8bf6380910274c4f0d9ac913fdc5d432063ac0

doc/go1.14: add link to TempFile in io/ioutil For convenience, TempFile in io/ioutil now has a link to the document. Updates #36878 Change-Id: I5c22f57c886badd8ca423e34527c4b4bb029847b Reviewed-on: https://go-review.googlesource.com/c/go/+/218637 Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>

view details

push time in 10 days

push eventceseo/go

Toshihiro Shiino

commit sha a52821569310ca3807f74993af4019dfcaa74cfe

doc/go1.14: fix inconsistent markup Unlike the others, the dt tag of reflect is not next to the dl tag. The dd's closing tags may or may not have been omitted. They were unified without omission. Updates #36878 Change-Id: I4e24f93fe8763ae8a1e4392db72e0b4818884f44 Reviewed-on: https://go-review.googlesource.com/c/go/+/217701 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

view details

push time in 10 days

push eventceseo/go

Ian Lance Taylor

commit sha 60d437f99468906935f35e5c6fbd31c7228a1045

runtime: avoid double notewakeup in netpoll stub code Otherwise we can see - goroutine 1 calls netpollBreak, the atomic.Cas succeeds, then suspends - goroutine 2 calls noteclear, sets netpollBroken to 0 - goroutine 3 calls netpollBreak, the atomic.Cas succeeds, calls notewakeup - goroutine 1 wakes up calls notewakeup, crashes due to double wakeup This doesn't happen on Plan 9 because it only runs one thread at a time. But Fuschia wants to use this code too. Change-Id: Ib636e4f327bb15e44a2c40fd681aae9a91073a30 Reviewed-on: https://go-review.googlesource.com/c/go/+/218537 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com>

view details

Ian Lance Taylor

commit sha a6b03c64b23fc51110aede0a0abf9df86f16ff1f

runtime/race: update reference to compiler-rt sources Change-Id: Iabe46677f24fef6e482a4beca774dbfc553026a2 Reviewed-on: https://go-review.googlesource.com/c/go/+/217778 Reviewed-by: Dmitry Vyukov <dvyukov@google.com>

view details

push time in 11 days

push eventceseo/go

Jay Conrod

commit sha 153a9e80332ca165d9d00149e9d8b9747d486c18

doc: add section on go.mod file syntax Updates #33637 Change-Id: I265e4fda863b871a3ce0ca7b6c926081dadbf5a6 Reviewed-on: https://go-review.googlesource.com/c/go/+/210799 Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

Jay Conrod

commit sha c7c525a79d224382ff59e238dbf1d129f26e9e2f

doc: add section on module paths to module documentation Updates #33637 Change-Id: I2197b20c2da2a5f57aacd40cc14611c5e6e25c5f Reviewed-on: https://go-review.googlesource.com/c/go/+/214377 Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Jay Conrod

commit sha ff091b5fa0c08a1f91aa6bd6e2bc080a3eba2720

doc: fill in 'Module-aware commands' section in module documentation Updates #33637 Change-Id: I6332fcdbd4c35a11cd84504f28ee594f1831ccaa Reviewed-on: https://go-review.googlesource.com/c/go/+/214378 Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Jay Conrod

commit sha 08d41dbb10c1a734630619d5bc5d5f755afd099f

doc: fill in 'go list -m' section in module documentation Updates #33637 Change-Id: I14ba3198375b98a270bbce2cd60234b071a6b974 Reviewed-on: https://go-review.googlesource.com/c/go/+/214379 Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Jay Conrod

commit sha cb16d26bd674bc7a43c6af118aca67838d5f692e

doc: fill in 'go mod download' section of module documentation Updates #33637 Change-Id: I963c04639201b32e0513a235306a03eae51222b5 Reviewed-on: https://go-review.googlesource.com/c/go/+/214380 Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Jay Conrod

commit sha b8061825e57dcee97a37fe49272ca52e84600f5e

doc: fill in 'go mod init' section of module documentation Updates #33637 Change-Id: I9c1345d0fa7a1b6c98c33b8b0837706e5261d5b4 Reviewed-on: https://go-review.googlesource.com/c/go/+/214381 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

push time in 11 days

push eventceseo/go

Than McIntosh

commit sha 1a37095062c5a1520a1cd79650852ef85ceda816

Revert "cmd/link: code cleanup in macho_combine_dwarf.go" This reverts commit 494dd1dddceb2df533feddd483b7cb05310f1085. Reason for revert: Not suitable for Go 1.14, will send to Go 1.15 instead. Change-Id: Iedc04fe6a9ace29a16498046eef9420afbaf4636 Reviewed-on: https://go-review.googlesource.com/c/go/+/218482 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>

view details

push time in 11 days

push eventceseo/go

Tamir Duberstein

commit sha 494dd1dddceb2df533feddd483b7cb05310f1085

cmd/link: code cleanup in macho_combine_dwarf.go - remove global variables - add missing error checks - add missing (*os.File).Close calls - null-check text section correctly - reduce some variable scopes - use bytes.Buffer instead of appended slice - reduce integer casting Change-Id: I4f6899923d0b26627308beb5c5c3ee9e6c68c41d Reviewed-on: https://go-review.googlesource.com/c/go/+/214657 Reviewed-by: Than McIntosh <thanm@google.com>

view details

push time in 11 days

push eventceseo/go

Roger Peppe

commit sha ab7c174183b05e36dabe0aa1943a0a4302b940d0

testing: make Cleanup work for benchmarks too. Fixes #37073. Change-Id: I6fb24a3f9d7b7adf3213ac6a8bcbf5fb43975b7e Reviewed-on: https://go-review.googlesource.com/c/go/+/218117 Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in 12 days

push eventceseo/go

Dmitri Shuralyov

commit sha ee3a3717aa16dabede5dc0385b05423e8fbce985

doc/go1.14: disable text/template processing in HTML page HTML pages served by the website have the option to opt-in to template processing, by including "Template: true" in the page metadata. This functionality is documented at https://github.com/golang/tools/blob/403f1254bdfd3da27c92a0e9e37dd180a9a82b3c/godoc/template.go#L5-L30. Historically, the Go 1 release notes have used template processing to a great extent, but release notes for all subsequent major Go releases have not. Since this feature is generally not used and not very well known, it tends to do more harm than good by making it possible for errors in the template to prevent the release notes from showing up at all. Disable this feature for Go 1.14 release notes and onwards. We can consider enabling it when there's a stronger need for it. Fixes #37072 Updates #37070 Change-Id: If93553d52df12544b46c4edcf3aa5eddc2a155ad Reviewed-on: https://go-review.googlesource.com/c/go/+/218058 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 13 days

push eventceseo/go

Ian Lance Taylor

commit sha dd0aa799ebbcb42cbc8d15aaa3edf905e8e1d83a

doc/go1.14: quote {{ and }} in text/template note Fixes #37070 Change-Id: I543957df264367e56c71a25bfaea5cf7935d438f Reviewed-on: https://go-review.googlesource.com/c/go/+/217979 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

view details

push time in 13 days

push eventceseo/go

Emmanuel T Odeke

commit sha e5b9c1068913c09f90ca4d7f8b0d97903f37fc1c

doc/go1.14: document io/ioutil.TempDir's predictable prefix+suffix Documents io/ioutil.TempDir's new ability to create predictable prefixes and suffixes, derived from the argument 'pattern', separated by the last '*' in it. References: CL 198488 Updates #36878 Change-Id: I92c52fcc7d480ce74746e99e6e85a04efb87294f Reviewed-on: https://go-review.googlesource.com/c/go/+/217780 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

Ian Lance Taylor

commit sha 9ee51745f767a8a95dfe7be095e19c9f79da4036

doc/go1.14: mention better error checking in text/template This caused 35 test failures in Google internal code, so it's worth mentioning in the release notes. Updates #31810 Updates #36878 Fixes #37066 Change-Id: I2faa6bce4c7d735107eceaef7d95223844846454 Reviewed-on: https://go-review.googlesource.com/c/go/+/217978 Reviewed-by: Rob Pike <r@golang.org>

view details

push time in 13 days

push eventceseo/go

Jerrin Shaji George

commit sha 921ceadd2997f2c0267455e13f909df044234805

runtime: rewrite a comment in malloc.go This commit changes the wording of a comment in malloc.go that describes how span objects are zeroed to make it more clear. Change-Id: I07722df1e101af3cbf8680ad07437d4a230b0168 GitHub-Last-Rev: 0e909898c709a9119cea7dbd80c25d9d7a73e22b GitHub-Pull-Request: golang/go#37008 Reviewed-on: https://go-review.googlesource.com/c/go/+/217618 Reviewed-by: Austin Clements <austin@google.com>

view details

Katie Hockman

commit sha 7a36fa400286ca51192a7661a7ffbf9a39c396b3

crypto/x509: fix godoc for MarshalPKCS8PrivateKey Fixes #36735 Change-Id: I93f005d78f4bfac773272995b165172461bae92f Reviewed-on: https://go-review.googlesource.com/c/go/+/217917 Run-TryBot: Katie Hockman <katie@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>

view details

push time in 13 days

push eventceseo/go

Filippo Valsorda

commit sha 88ae4ccefb60ce7e83b25c3bf0f55a4d8704e123

math/big: reintroduce pre-Go 1.14 mention in GCD docs It was removed in CL 217302 but was intentionally added in CL 217104. Change-Id: I1a478d80ad1ec4f0a0184bfebf8f1a5e352cfe8c Reviewed-on: https://go-review.googlesource.com/c/go/+/217941 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 13 days

push eventceseo/go

Bryan C. Mills

commit sha 8a4d05cf07cddb724422d24e57c18c1bd8d8ad02

cmd/go/internal/vet: only set work.VetExplicit if the list of explicit flags is non-empty Updates #35837 Fixes #37030 Change-Id: Ifd3435803622a8624bab55a0f3fbc8855025282f Reviewed-on: https://go-review.googlesource.com/c/go/+/217897 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>

view details

Emmanuel T Odeke

commit sha 60f11c44c02ff815e02d1e59839c6c0bf3f6605e

doc/go1.14: document http.ServeFile large file fix for Windows Document that for Windows, net/http.ServeFile can now correctly serve files >2GB after we fixed internal/poll.SendFile to transmit files larger than the default Windows limit of 2GB. References: CL 192518, CL 194218 Updates #36878 Change-Id: Ibefc8b2841bc0cee3a89884a680085f99d2b6928 Reviewed-on: https://go-review.googlesource.com/c/go/+/217779 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 13 days

push eventceseo/go

Bryan C. Mills

commit sha 702226f93321a6cc9c90c657c589c869c70872fc

doc/install.html: streamline the “Test your installation” step and make it module-agnostic In CL 199417, we updated “How to Write Go Code” to give a basic introduction to modules and to include module-mode commands. However, most new users will end up reading “Getting Started” (doc/install.html) before “How to Write Go Code”, and we forgot to update the handful of commands there for module mode. Before this change, the “Test your installation” section also covered quite a few operations beoyond merely testing the installation: it included setting up a GOPATH, building a binary, and installing and cleaning binaries. Those are valuable operations to learn, but they arguably belong in “How to Write Go Code”, not “Test your installation” — and having all that extra detail in the install instructions may well discourage folks from further essential reading. Rather than updating all of those operations here, I've removed them. A companion CL will update “How to Write Go Code” to ensure that it mentions GOPATH (as the location of the module cache and the default install location for binaries) and 'go clean -i'. Updates #37042 Change-Id: I157f21ccbe3896575fa1115dc821abf6c71ed15e Reviewed-on: https://go-review.googlesource.com/c/go/+/217840 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

push time in 13 days

push eventceseo/go

David Chase

commit sha ffd4e32885c4fed50dd0420440b8e58bff32adce

doc/go1.14: add remarks about range inference and check removal Mentions CLs 174704 and 196784. Change-Id: Ia8f821a3d90a4e08c895a6f091dbf07311e885ba Reviewed-on: https://go-review.googlesource.com/c/go/+/214946 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>

view details

push time in 13 days

push eventceseo/go

Dmitri Shuralyov

commit sha fb93cd45a647087a11f96cf2610e64a257a68c19

net: don't check LookupHost error in TestLookupNullByte net.LookupHost("foo\x00bar") may resolve successfully on some networks. Reduce the scope of the test to check only that the call doesn't panic. Also update the test comment to reference the relevant issue. Fixes #37031 Updates #31597 Change-Id: If175deed8121625ef507598c6145e937ccffd89e Reviewed-on: https://go-review.googlesource.com/c/go/+/217729 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

Dmitri Shuralyov

commit sha a864cc756083632c543f2ad582cddd81bd2f3840

doc: rename HTML element IDs to avoid duplicates These 3 release notes have had an element ID collision because both the runtime changes and changes to the package "runtime" used the same ID. Fix it by using a "pkg-" prefix for the runtime package. Move the "runtime-again" ID from CL 129635 to a nearby <dt> element so that existing links to https://golang.org/doc/go1.11#runtime-again don't break. Fixes #37036 Updates #36878 Change-Id: Ib68d93acfac802fd84c0a57485937e45dea2064a Reviewed-on: https://go-review.googlesource.com/c/go/+/217797 Reviewed-by: Toshihiro Shiino <shiino.toshihiro@gmail.com> Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 13 days

push eventceseo/go

Ian Lance Taylor

commit sha f770366f6d910e4bf92a6f885908afe134d65b23

runtime: don't treat SIGURG as a bad signal It's possible for the scheduler to try to preempt a goroutine running on a thread created by C code just as the goroutine returns from Go code to C code. If that happens, the goroutine will have a nil g, which would normally cause us to enter the badsignal code. The badsignal code will allocate an M, reset the signal handler, and raise the signal. This is all wasted work for SIGURG, as the default behavior is for the kernel to ignore the signal. It also means that there is a period of time when preemption requests are ignored, because the signal handler is reset to the default. And, finally, it triggers a bug on 386 OpenBSD 6.2. So stop doing it. No test because there is no real change in behavior (other than on OpenBSD), the new code is just more efficient Fixes #36996 Change-Id: I8c1cb9bc09f5ef890cab567924417e2423fc71f6 Reviewed-on: https://go-review.googlesource.com/c/go/+/217617 Reviewed-by: Austin Clements <austin@google.com>

view details

push time in 14 days

push eventceseo/go

Josh Bleecher Snyder

commit sha e3f2e9ac4e1ab99e1ebd0bf2a6bd3898633873b1

internal/bytealg: fix riscv64 offset names Vet caught that these were incorrect. Updates #37022 Change-Id: I7b5cd8032ea95eb8e0729f6a4f386aec613c71d8 Reviewed-on: https://go-review.googlesource.com/c/go/+/217777 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in 14 days

push eventceseo/go

Dmitri Shuralyov

commit sha e6ebbe0d20fe877b111cf4ccf8349cba129d6d3a

syscall: Revert "release a js.Func object in fsCall" This reverts CL 217417 (commit 753d56d3642eb83848aa39e65982a9fc77e722d7). This change was unintentionally submitted to master during the Go 1.14 code freeze; it should be sent again for Go 1.15. Change-Id: Ie790342f227ae3adfc5f9a90ce3abdc2c9be619b Reviewed-on: https://go-review.googlesource.com/c/go/+/217721 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>

view details

Katie Hockman

commit sha a744be42f9427a3b20e7e179e4b9831dbcf27f4c

doc: remove paragraph break for upgrading to modules Previously, the release notes broke up the sentences that modules is now ready for production use and where to file issues for migration problems into separate paragraphs. This made it look like the migration paragraph was about upgrading to 1.14, not to modules, and made the reading a bit confusing. Now the entire idea is in one paragraph. Change-Id: I10bddfb8aba5f5909ac6842f25e3e97d505835e6 Reviewed-on: https://go-review.googlesource.com/c/go/+/217720 Run-TryBot: Katie Hockman <katie@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

push time in 14 days

push eventceseo/go

Dmitri Shuralyov

commit sha 334ab8311c8c6d48985a523f4a936ff20a7a5e7a

doc/go1.14: note that all changes to the standard library are minor Updates #36878 Change-Id: I1b83ff174a139734fae75f6e1e4caa9958222a18 Reviewed-on: https://go-review.googlesource.com/c/go/+/217640 Reviewed-by: Alexander Rakoczy <alex@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>

view details

push time in 14 days

push eventceseo/go

Dmitri Shuralyov

commit sha 8278627c1589fa881a25a2aa0c62e8a56e6f268a

doc/go1.14: document encoding/asn1 support for BMPString Updates #36878 Change-Id: Ib3ea1ef21c4b8ada3d354a0022a19914c1311399 Reviewed-on: https://go-review.googlesource.com/c/go/+/217637 Reviewed-by: Carlos Amedee <carlos@golang.org>

view details

Dmitri Shuralyov

commit sha fccf2edbe1ed677008638f7ad97aecd3e5594468

doc/go1.14: remove TODO about Illumos port There is an active builder that was added in CL 201597, and it is passing on Go tip and release-branch.go1.13 (with one failure that appears to be flaky due to being out of memory). It's also passing on all golang.org/x repos on tip and release-branch.go1.13. It's not configured to run on Go 1.12 release branches. Updates #36878 Updates #15581 Change-Id: I4ed7fc62c11a09743832fca39bd61fa0cf6e7ded Reviewed-on: https://go-review.googlesource.com/c/go/+/217737 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org>

view details

Dmitri Shuralyov

commit sha fb0b6ed0cf21100b63a515a2e29b81f63fc5a2ce

doc/go1.14: remove TODO about Solaris port The solaris-amd64-oraclerel builder is passing for the main Go repo (on tip and release branches for 1.13 and 1.12), and golang.org/x repos (also on tip and release branches for 1.13 and 1.12). The builder is still maintained as described at https://golang.org/issue/15581#issuecomment-550368581. Updates #36878 Updates #15581 Change-Id: Icc6f7529ca2e05bb34f09ce4363d9582e80829c6 Reviewed-on: https://go-review.googlesource.com/c/go/+/217738 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org>

view details

Toshihiro Shiino

commit sha 6a027cdb7517c47b884f57d748898dfc1b6cb675

doc/go1.14: fix broken links Fix broken links with missing /pkg and fix os/signal import path. Change-Id: I4bf74c9f6e9b0e5fa96ca4d35c4ce404e07583b2 Reviewed-on: https://go-review.googlesource.com/c/go/+/217697 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

view details

push time in 14 days

push eventceseo/go

Toshihiro Shiino

commit sha 0fe79aad0ff800f8df3136d018e0a8b64c614d61

doc/go1.14: add missing slashes This saves a redirect and makes the document more consistent. Change-Id: I67840f5dc05dffd8893a055618eb202b682a0ebc Reviewed-on: https://go-review.googlesource.com/c/go/+/217698 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

Tobias Klauser

commit sha b8d339bc8dbb0754d1b6aa8a748598907e5b2dd2

doc/go1.14: remove TODO about Dragonfly passing Both the Dragonfly release and tip builder have been passing for a while. The net package's interface API is working on both builders since CL 202317 which has been re-vendored in CL 202438. Updates #34368 Updates #36878 Change-Id: I187178b3a59f2604187af453207fb4e24a56105c Reviewed-on: https://go-review.googlesource.com/c/go/+/217358 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 14 days

push eventceseo/go

Ian Lance Taylor

commit sha c8a91ed24932be7248eefed58ade4bb978b62f55

doc/go1.14: mention changes to debug/dwarf Updates #36878 Change-Id: Icfbf9074c731d64198b4760e1902bbd09fcc1349 Reviewed-on: https://go-review.googlesource.com/c/go/+/217067 Reviewed-by: Austin Clements <austin@google.com>

view details

push time in 15 days

push eventceseo/go

Hajime Hoshi

commit sha 753d56d3642eb83848aa39e65982a9fc77e722d7

syscall: release a js.Func object in fsCall A js.Func object in fsCall was created for each call but never released. This CL fixes this. Change-Id: I2e2b504cbf4fb130b8cfe890a66d3a66aadf56a4 Reviewed-on: https://go-review.googlesource.com/c/go/+/217417 Run-TryBot: Hajime Hoshi <hajimehoshi@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com> Reviewed-by: Richard Musiol <neelance@gmail.com>

view details

push time in 16 days

push eventceseo/go

Filippo Valsorda

commit sha 866920a07351ad5663cc712c31a0f7b5631bc85c

std,cmd: sync go.mod with new release branches cd src go get golang.org/x/sys@release-branch.go1.14-std go mod tidy && go mod vendor cd cmd go get golang.org/x/sys@release-branch.go1.14-cmd go get golang.org/x/tools@release-branch.go1.14 go mod tidy && go mod vendor Fixes #36851 Change-Id: Ib0a78eec90c92515b6f421972102cc8e8d0c08a7 Reviewed-on: https://go-review.googlesource.com/c/go/+/217305 Run-TryBot: Filippo Valsorda <filippo@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 18 days

push eventceseo/go

Ian Lance Taylor

commit sha eadf8b20bc13d663ca7c57ab6e01eee31febdaa5

doc/go1.14: mention new method encoding/json.Decoder.InputOffset Updates #29688 Updates #36878 Change-Id: I230889ec3f1c183dc5adbc662a39a791c0488497 Reviewed-on: https://go-review.googlesource.com/c/go/+/217123 Reviewed-by: Alexander Rakoczy <alex@golang.org>

view details

Brad Fitzpatrick

commit sha 8390c478600b852392cb116741b3cb239c94d123

net/http/cgi: rename a test file to be less cute My fault (from CL 4245070), sorry. Change-Id: Ib95d3170dc326e74aa74c22421c4e44a8b00f577 Reviewed-on: https://go-review.googlesource.com/c/go/+/214920 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>

view details

Filippo Valsorda

commit sha 53558cb721ec7a2a6f87ff87a4095e956c587e3d

doc/go1.14: fix math/big.(*Int).GCD notes GCD is a method, not a function, so the link was broken. Change-Id: Icbb09d39959e7c71a48987b15bb82febe12c3a19 Reviewed-on: https://go-review.googlesource.com/c/go/+/217303 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

Filippo Valsorda

commit sha cdb7fd6b06937aa38a7a4921f567697144448073

math/big: simplify GCD docs We don't usually document past behavior (like "As of Go 1.14 ...") and in isolation the current docs made it sound like a and b could only be negative or zero. Change-Id: I0d3c2b8579a9c01159ce528a3128b1478e99042a Reviewed-on: https://go-review.googlesource.com/c/go/+/217302 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 18 days

push eventceseo/go

Filippo Valsorda

commit sha 1b7fefc91f7779c886a307c809144b57d84ed35e

doc/go1.14: add crypto/tls release notes A few minor changes that didn't feel worth mentioning: * CL 205059: support leaving Certificates/GetCertificate nil if GetConfigForClient is set * CL 205059: send the unrecognized_name alert when there are no available certificates * CL 205068: add correct names for CHACHA20_POLY1305 ciphersuite constants * CL 204046: fix CreateCRL for Ed25519 CAs * CL 205058: add CertificateRequestInfo.Version Change-Id: Ie820fb0c6842e669edde031132c7cda5b09e7682 Reviewed-on: https://go-review.googlesource.com/c/go/+/216759 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 18 days

push eventceseo/go

Dmitri Shuralyov

commit sha d91c3bc20393cab601d372547471468c869320af

doc/go1.14: move "Minor changes to the library" heading up This heading was below the minor changes to the standard library. It should be on top. Many of the minor changes have been documented, so remove the broad TODO comment. It is still a TODO to highlight more prominent changes to the library, if there are any, under the "Core library" heading. Updates #36878 Change-Id: If7fd9af9a933af917523e33fd2922c5f3c02c98b Reviewed-on: https://go-review.googlesource.com/c/go/+/217277 Reviewed-by: Alexander Rakoczy <alex@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>

view details

push time in 18 days

push eventceseo/go

Ian Lance Taylor

commit sha f2a4ab32b1bcfae5c689c034953471a5541e9397

doc/go1.14: mention new field go/build.Context.Dir Updates #34860 Updates #36168 Updates #36878 Change-Id: I484d7fea5d77d6dcd451d4fdffe0c450eed73636 Reviewed-on: https://go-review.googlesource.com/c/go/+/217124 Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

Ian Lance Taylor

commit sha 6c0545ab833b2b834f351e59242a3ea64051fa3a

doc/go1.14: mention new method strconv.NumError.Unwrap Updates #30322 Updates #36878 Change-Id: I8b33eb6a8fb7c0ecf365940a1c3ae88dc807ebcd Reviewed-on: https://go-review.googlesource.com/c/go/+/217132 Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

Jean de Klerk

commit sha 96002cd25c343edfb6c06d2bf1f31ae1e345b81f

doc/go1.14: fix id attribute of Testing heading Some tweaks based on comments from CL 216917. Change-Id: I538ea0dfa947b53d5c4a7135c1aec912b0357083 Reviewed-on: https://go-review.googlesource.com/c/go/+/217121 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

view details

push time in 18 days

push eventceseo/go

Robert Griesemer

commit sha 6e592c2b6d3d32f0eb1211a3795e852627c7a086

go/types: unexport Checker.LookupFieldOrMethod Implementation changes in go/types for #6977 required that internal LookupFieldOrMethod calls had access to the current *Checker. In order to make quick progress, I added a *Checker receiver to the function LookupFieldOrMethod (thus making it a method), and added a new function LookupFieldOrMethod. The plan was always to rename that function (Checker.LookupFieldOrMethod) such that it wouldn't be exported; with the obvious name being Checker.lookupFieldOrMethod. But that name was already in use which is why I postponed the rename. Eventually I forgot to clean it up. This CL fixes that with the following renames: Checker.lookupFieldOrMethod => Checker.rawLookupFieldOrMethod Checker.LookupFieldOrMethod => Checker.lookupFieldOrMethod Updates #6977. Fixes #36916. Change-Id: Icfafd0de9a19841ba5bd87142730fe7323204491 Reviewed-on: https://go-review.googlesource.com/c/go/+/217134 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 18 days

push eventceseo/go

Ian Lance Taylor

commit sha 0eb49f67d467c93383a4d4917c9bd4d9e9f51671

doc/go1.14: mime: .js files now text/javascript Updates #32351 Updates #36878 Change-Id: I19f87430f4344dcc6664d8dd1b8adfc67660f099 Reviewed-on: https://go-review.googlesource.com/c/go/+/217122 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Ian Lance Taylor

commit sha b7689f5aa38b41c8fbd75d64aa463b898c81fca5

doc/go1.14: mention new log.Lmsgprefix flag Updates #32062 Updates #36878 Change-Id: I06c7c9a9d253177155a6d46d58231ce26e659757 Reviewed-on: https://go-review.googlesource.com/c/go/+/217126 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

push time in 19 days

push eventceseo/go

Ian Lance Taylor

commit sha f68577f2941b7e331b8b702cd1e6ca100d3820c4

doc/go1.14: mention new field net/http/httptest/Server.EnableHTTP2 Updates #34939 Updates #36878 Change-Id: Ifa9a17b5b16bfcfbfe1d113a2b66a63ea3a6b59c Reviewed-on: https://go-review.googlesource.com/c/go/+/217131 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Ian Lance Taylor

commit sha debc52038b1ae8bab4d6d901d07e5f6f3397e029

doc/go1.14: mention net/http.Header.Values, net/textproto.MIMEHeader.Values These methods are new in Go 1.14. Updates #34799 Updates #36878 Change-Id: I063f5cb4638d7e0716e6ce2a8c3fffced51bbd34 Reviewed-on: https://go-review.googlesource.com/c/go/+/217129 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Ian Lance Taylor

commit sha 4fda21bce194966b2ba018fbacb7045cb50c67db

doc/go1.14: mention new field Transport.DialTLSContext Updates #21526 Updates #36878 Change-Id: Ic3ae18d31eddb9df01241cbddcc3b7b750cfaa44 Reviewed-on: https://go-review.googlesource.com/c/go/+/217130 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Ian Lance Taylor

commit sha 862a57df5aa6948f7cc209e6c117f2dd08b066cc

doc/go1.14: mention update to Unicode 12 Updates #36878 Change-Id: Ia8441de8a04fead1f76c72f662bcb877e2265c3e Reviewed-on: https://go-review.googlesource.com/c/go/+/217133 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Ian Lance Taylor

commit sha 400a5af19bb5af842342757864f3fb303867adc3

doc/go1.14: mention new method mime/multipart.(*Reader).NextRawPart Updates #29090 Updates #36878 Change-Id: I63f0eb583285d5c12f591cb704097cdf6a67b64f Reviewed-on: https://go-review.googlesource.com/c/go/+/217128 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Ian Lance Taylor

commit sha 6dc0e977d007216f1525f4dd1f73abf881e9b12c

doc/go1.14: mention new math/bits functions Rem, Rem32, Rem64 Updates #28970 Updates #36878 Change-Id: I9676f50516dd5b32bd4e44be136fcb9f43776edd Reviewed-on: https://go-review.googlesource.com/c/go/+/217127 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

push time in 19 days

push eventceseo/go

Ian Lance Taylor

commit sha 817c5c4517855314dd67fb48041c9a570538fbc2

doc/go1.14: mention go/doc.NewFromFiles and associated new data fields Updates #23864 Updates #36878 Change-Id: I6efdaafbe5207c625643f201a5931ad735941365 Reviewed-on: https://go-review.googlesource.com/c/go/+/217125 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

view details

push time in 19 days

push eventceseo/go

Keith Randall

commit sha 25d0ffe603885a9c42400b35cb39e93a56a7aa95

doc: document new hash/maphash package Update #36878 Update #28322 Change-Id: I793c7c4dbdd23fdecd715500e90b7cc0cbe4cea5 Reviewed-on: https://go-review.googlesource.com/c/go/+/217099 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 19 days

push eventceseo/go

Filippo Valsorda

commit sha b8dd33b2f69729b7fba01fd398514e7671bbdf0a

cmd/go.mod: sync x/crypto with std go get golang.org/x/crypto@v0.0.0-20200128174031-69ecbb4d6d5d go mod vendor git checkout -- vendor/golang.org/x/sys/unix/asm_linux_riscv64.s \ vendor/golang.org/x/tools/go/analysis/passes/asmdecl/asmdecl.go Updates #36851 Change-Id: I95c0584ede599f600da927a04f135fe64a85037e Reviewed-on: https://go-review.googlesource.com/c/go/+/217118 Run-TryBot: Filippo Valsorda <filippo@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in 19 days

push eventceseo/go

Robert Griesemer

commit sha 68b55ab51319ec71fe3f00266f9c467f34c824b1

doc/go1.14: fix minor typo (update release notes) Follow-up on https://golang.org/cl/216200/2/doc/go1.14.html#423 . Updates #36878. Change-Id: I693a9eb05c6f1f42721a92fda46a4f3449defa24 Reviewed-on: https://go-review.googlesource.com/c/go/+/217100 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

Robert Griesemer

commit sha 9bb40ed8ecb8e6e470c70e169cb3cecb2e9dc69a

math/big: update comment on Int.GCD Per the suggestion https://golang.org/cl/216200/2/doc/go1.14.html#423. Updates #28878. Change-Id: I654d2d114409624219a0041916f0a4030efc7573 Reviewed-on: https://go-review.googlesource.com/c/go/+/217104 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 19 days

push eventceseo/go

Robert Griesemer

commit sha 9d5ea44bec0e923bf2ff9c7092e1dd929865200d

doc/go1.14: document overlapping interfaces change (update release notes) Updates #6977. Updates #36878. Change-Id: I40594be85ee0a0d4b35bacc90104568d2b8a4761 Reviewed-on: https://go-review.googlesource.com/c/go/+/216997 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 19 days

push eventceseo/go

Jay Conrod

commit sha 845a91dc491095e042020a60143e86eedc4cfd91

doc/go1.14: edit "Go command" section, move zone CPU cap note Minor edits to text on go command changes. Also, moved a note about runtime respecting zone CPU caps from Native Client section to Runtime section. Change-Id: Ic21e59d7ffecb4b5676a841e7f3743203a82d266 Reviewed-on: https://go-review.googlesource.com/c/go/+/216878 Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

push time in 19 days

push eventceseo/go

Hana Kim

commit sha 0d34f5f09b155a9a7496490d6204f6f18179f098

doc/go1.14.html: describe the runtime/pprof change golang.org/cl/204636 golang.org/cl/205097 Updates #36874 Change-Id: I773868fd027e9cc2187f0a738900f0fcb7711635 Reviewed-on: https://go-review.googlesource.com/c/go/+/216877 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 20 days

push eventceseo/go

Jean de Klerk

commit sha 07957b794c7b99034f41976bbab560ff4615bbc4

doc/go1.14: edit "Go command" section, adding note about go test -v streaming Change-Id: Ie88fe441521d60a4ba54ebb418860d0f71073387 Reviewed-on: https://go-review.googlesource.com/c/go/+/216917 Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

push time in 20 days

push eventceseo/go

Bryan C. Mills

commit sha 67fee6005d48f8e4554c3e933763aec7cd503f8f

go/build: update TestImportDirNotExist to accept more detailed error strings In CL 203820, we switched go/build to use the caller's working directory for the main module (rather than srcDir), so that go/build resolution now respects the requirements and replacements of the main module. When the passed-in srcDir is empty, as of that CL we use "go list" instead of falling back to in-process (GOPATH-mode) path lookup. Unfortunately, that broke go/build.TestImportDirNotExist when GO111MODULE=on: the test was looking for the specific error message produced by the in-process lookup. This change relaxes the test to accept the error message produced by "go list" when srcDir is empty. Updates #34769 Updates #34860 Updates #35734 Fixes #36867 Change-Id: Id0f7814a4b7dabe8917216eb013bb4eaee283648 Reviewed-on: https://go-review.googlesource.com/c/go/+/216817 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>

view details

push time in 20 days

push eventceseo/go

Joel Sing

commit sha 2e4f490b31272a2df73d4ba23aad7f5a8ca49a2f

cmd/compile,cmd/link: fix and re-enable open-coded defers on riscv64 The R_CALLRISCV relocation marker is on the JALR instruction, however the actual relocation is currently two instructions previous for the AUIPC+ADDI sequence. Adjust the platform dependent offset accordingly and re-enable open-coded defers. Fixes #36786. Change-Id: I71597c193c447930fbe94ce44b7355e89ae877bb Reviewed-on: https://go-review.googlesource.com/c/go/+/216797 Run-TryBot: Joel Sing <joel@sing.id.au> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

Joel Sing

commit sha a50c3ffbd47e3dcfc1b5bd2a2d19d55731481eaa

cmd/internal/obj/riscv,cmd/link: shorten the riscv64 call sequence Now that the other dependent offset has been identified, we can remove the unnecessary ADDI instruction from the riscv64 call sequence (reducing it to AUIPC+JALR, rather than the previous AUIPC+ADDI+JALR). Change-Id: I348c4efb686f9f71ed1dd1d25fb9142a41230b0d Reviewed-on: https://go-review.googlesource.com/c/go/+/216798 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in 20 days

push eventceseo/go

Brad Fitzpatrick

commit sha 566ebbc3ae97741e9419e2668833ac297d63ba54

doc/go1.14: document RISC-V support Fixes #36708 Updates #27532 Change-Id: I9e3bb92d15825e2c4a505e1aea41b2897f18e0ff Reviewed-on: https://go-review.googlesource.com/c/go/+/216757 Reviewed-by: Joel Sing <joel@sing.id.au> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

Daniel Martí

commit sha 1319bb959c17b8e6c7b44b26c61e8f02850d9c46

doc: add the change to json.Compact in the 1.14 changelog Fixes #36690. Change-Id: Id4234ab9467270d51f0411375b71ece7f41269b2 Reviewed-on: https://go-review.googlesource.com/c/go/+/215817 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>

view details

push time in 20 days

push eventceseo/go

Ian Lance Taylor

commit sha c436eadbc36704012be727457f464d8fbf950638

net/http: don't treat an alternate protocol as a known round tripper As of CL 175857, the client code checks for known round tripper implementations, and uses simpler cancellation code when it finds one. However, this code was not considering the case of a request that uses a user-defined protocol, where the user-defined protocol was registered with the transport to use a different round tripper. The effect was that round trippers that worked with earlier releases would not see the expected cancellation semantics with tip. Fixes #36820 Change-Id: I60e75b5d0badcfb9fde9d73a966ba1d3f7aa42b1 Reviewed-on: https://go-review.googlesource.com/c/go/+/216618 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

push time in 21 days

push eventceseo/go

Joel Sing

commit sha 212c0bf24c299616f24880401a621a31c9099b8c

test: disable the live test on riscv64 This test expects that open-coded defers are enabled, which is not currently the case on riscv64. Updates issue #27532 and #36786. Change-Id: I94bb558c5b0734b4cfe5ae12873be81026009bcf Reviewed-on: https://go-review.googlesource.com/c/go/+/216777 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

Brad Fitzpatrick

commit sha a6701d81a04bc84b5851e104b27783395a348832

cmd/dist: remove riscv64 from set of incomplete ports Fixes #27532 Fixes #36853 Updates #28944 Change-Id: I4d0f212deb361c941ce7e5999e237a951c89a296 Reviewed-on: https://go-review.googlesource.com/c/go/+/216758 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Joel Sing <joel@sing.id.au>

view details

push time in 21 days

push eventceseo/go

Michael Anthony Knyszek

commit sha e7f9e17b7927cad7a93c5785e864799e8d9b4381

runtime: ensure that searchAddr always refers to inUse memory This change formalizes an assumption made by the page allocator, which is that (*pageAlloc).searchAddr should never refer to memory that is not represented by (*pageAlloc).inUse. The portion of address space covered by (*pageAlloc).inUse reflects the parts of the summary arrays which are guaranteed to mapped, and so looking at any summary which is not reflected there may cause a segfault. In fact, this can happen today. This change thus also removes a micro-optimization which is the only case which may cause (*pageAlloc).searchAddr to point outside of any region covered by (*pageAlloc).inUse, and adds a test verifying that the current segfault can no longer occur. Change-Id: I98b534f0ffba8656d3bd6d782f6fc22549ddf1c2 Reviewed-on: https://go-review.googlesource.com/c/go/+/216697 Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

push time in 21 days

push eventceseo/go

Dmitri Shuralyov

commit sha b13ce14c4a6aa59b7b041ad2b6eed2d23e15b574

src/go.mod: import x/crypto/cryptobyte security fix for 32-bit archs cryptobyte: fix panic due to malformed ASN.1 inputs on 32-bit archs When int is 32 bits wide (on 32-bit architectures like 386 and arm), an overflow could occur, causing a panic, due to malformed ASN.1 being passed to any of the ASN1 methods of String. Tested on linux/386 and darwin/amd64. This fixes CVE-2020-7919 and was found thanks to the Project Wycheproof test vectors. Change-Id: I8c9696a8bfad1b40ec877cd740dba3467d66ab54 Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/645211 Reviewed-by: Katie Hockman <katiehockman@google.com> Reviewed-by: Adam Langley <agl@google.com> Reviewed-on: https://go-review.googlesource.com/c/crypto/+/216677 Run-TryBot: Katie Hockman <katie@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> x/crypto/cryptobyte is used in crypto/x509 for parsing certificates. Malformed certificates might cause a panic during parsing on 32-bit architectures (like arm and 386). Change-Id: I840feb54eba880dbb96780ef7adcade073c4c4e3 Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/647741 Reviewed-by: Katie Hockman <katiehockman@google.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/216680 Reviewed-by: Katie Hockman <katie@golang.org>

view details

push time in 21 days

startedh2oai/h2o-3

started time in 21 days

push eventceseo/go

Joel Sing

commit sha 8f14f33f96d35416786d65664ca731ae75d1c733

cmd/compile/internal/ssa/gen: avoid importing internal riscv64 packages Duplicate the register definitions and names to avoid importing the cmd/internal/obj/riscv64 package. This makes it possible to build compiler rules with a stable Go tool chain. Fixes #36663 Change-Id: I09116a97bb037ca1bc00073306a82bb88862b1e9 Reviewed-on: https://go-review.googlesource.com/c/go/+/216518 Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

Joel Sing

commit sha d8e052667f6bb93eb444cc372d03a866973d4c1b

cmd/internal/obj/riscv: use signed immediates for U-instructions On RISCV64, the U-instructions (AUIPC and LUI) take 20 bits, append 12 bits of zeros and sign extend to 64-bits. As such, the 20 bit immediate value is signed not unsigned. Updates #27532 Change-Id: I725215a1dc500106dbfdc0a4425f3c0b2a6f411e Reviewed-on: https://go-review.googlesource.com/c/go/+/216257 Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

Joel Sing

commit sha a858d15f11f87b53792a6afb156716b80f9634c7

cmd/compile: disable open-coded defers on riscv64 Open-coded defers are currently broken on riscv64 - disable them for the time being. All of the standard package tests now pass on linux/riscv64. Updates issue #27532 and #36786 Change-Id: I20fc25ce91dfad48be32409ba5c64ca9a6acef1d Reviewed-on: https://go-review.googlesource.com/c/go/+/216517 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Dan Scales <danscales@google.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in 22 days

push eventceseo/go

Jay Conrod

commit sha 22f09ced523d907177670293061be678f42608e0

doc/go1.14: remove TODO from Tools section of release notes Change-Id: I682193eb06b55eb3e9392146579f57a928c728d0 Reviewed-on: https://go-review.googlesource.com/c/go/+/216598 Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

push time in 22 days

push eventceseo/go

Jay Conrod

commit sha 74d366f4844026494e777638caffaf94255166dc

doc/go1.14: go command behavior with GO111MODULE=on outside modules Hopefully this won't affect many people, but it's a substantial change in behavior for a specific case, so it's probably worth mentioning. Updates #32027 Change-Id: I61cd50e93d0199e94b011cc90150e072b6bb10ca Reviewed-on: https://go-review.googlesource.com/c/go/+/216597 Run-TryBot: Jay Conrod <jayconrod@google.com> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in 22 days

issue openedgolang/go

x/build/dashboard: host-linux-ppc64le-power9-osu is not using GOPPC64=power9

While inspecting the dashboard, I noticed that the POWER9 builders aren't actually generating POWER9 code. This was probably an oversight when we moved to Docker.

I'll submit a CL to fix this shortly.

created time in 22 days

push eventceseo/go

Cherry Zhang

commit sha 6fbdfe48041c883a9f6d8c981a7205b7c327862a

cmd/compile: on PPC64, fold offset into some loads/stores only when offset is 4-aligned On PPC64, MOVWload, MOVDload, and MOVDstore are assembled to a "DS from" instruction which requiers the offset is a multiple of 4. Only fold offset to such instructions if it is a multiple of 4. Fixes #36723. "GOARCH=ppc64 GOOS=linux go build -gcflags=all=-d=ssa/check/on std cmd" passes now. Change-Id: I67f2a6ac02f0d33d470f68ff54936c289a4c765b Reviewed-on: https://go-review.googlesource.com/c/go/+/216379 Reviewed-by: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>

view details

push time in 22 days

issue commentgolang/go

cmd/compile: ppc64 builds failing with ssa checker on

cc @laboger

josharian

comment created time in 22 days

push eventceseo/go

Bryan C. Mills

commit sha f652015a0ab0f197a5a3929afa39d76dc73ed9e6

doc/go1.14: document the new GOINSECURE variable Fixes #36746 Change-Id: Iab9eaceb743ee52c82e7645216a671362189a021 Reviewed-on: https://go-review.googlesource.com/c/go/+/216380 Reviewed-by: witchard <ben.witchard@gmail.com> Reviewed-by: Russ Cox <rsc@golang.org>

view details

Bryan C. Mills

commit sha 4615b39514d1463c1cfed624ff3629ab1580a915

doc/go1.14: note that module support is ready for production use The public proxy and checksum database launched with Go 1.13 have been running smoothly, pkg.go.dev is serving module-aware documentation, and in 1.14 we have improved the vendoring workflow and finished Subversion support to reach parity with GOPATH mode for users of those features, updated documentation (including the “How to Write Go Code” intro document) and published blog posts describing common modes of usage, and improved the migration path for existing v2+ modules by making version resolution less aggressive about "+incompatible" major versions. We (always) have more fit-and-finish work to do, but at this point we believe that module mode will provide a better user experience than GOPATH mode for most users, including in production use. Change-Id: I897e0a43e3aebe4c90553c414337a46bfc9c2bef Reviewed-on: https://go-review.googlesource.com/c/go/+/216317 Reviewed-by: Jay Conrod <jayconrod@google.com> Reviewed-by: Katie Hockman <katie@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>

view details

push time in 22 days

push eventceseo/go

Ian Lance Taylor

commit sha c333d07ebe9268efc3cf4bd68319d65818c75966

strconv: stop describing Unicode graphic characters as non-ASCII Fixes #36778 Change-Id: I3c4ce100fc219bda0ff1d7a086c2309ed695691d Reviewed-on: https://go-review.googlesource.com/c/go/+/216478 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Rob Pike <r@golang.org>

view details

push time in 23 days

push eventceseo/go

Joel Sing

commit sha 7f331e0e1735449380299654dc915fb5c8fe84ab

test: adjust tests for riscv64 This disables some tests that are unsupported on riscv64 and adds support for risc64 to test/nosplit. Updates #27532, #36739 and #36765 Change-Id: I0a57797a05bc80236709fc240c0a0efb0ee0d16b Reviewed-on: https://go-review.googlesource.com/c/go/+/216263 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Joel Sing

commit sha bcd50e4cd0e308c05fb52b35431c454d9cb07fff

vendor: provide golang.org/x/sys/cpu/cpu_riscv64.go Manually provide golang.org/x/sys/cpu/cpu_riscv64.go until such time as this code can be updated, post release. This already exists in x/sys/cpu via: https://go-review.googlesource.com/c/sys/+/206860 Update #27532 Change-Id: I57d598ef737642f9c3aa7b280c6c680477ae7633 Reviewed-on: https://go-review.googlesource.com/c/go/+/216261 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Joel Sing

commit sha 73d213708e3186b48d5147b8eb939fdfd51f1f8d

cmd/vendor: provide riscv64 support in tools/go/analysis/passes/asmdecl Manually add riscv64 support. Currently being added via https://go-review.googlesource.com/c/tools/+/216337. Updates #27532 Change-Id: I0e1f7c0eeca4e85ae588f427eff818bb7946a851 Reviewed-on: https://go-review.googlesource.com/c/go/+/216262 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

push time in 24 days

push eventceseo/go

Joel Sing

commit sha 37981da9a4c649fe0570c84e78d9bf38a0bb90f0

cmd/vendor: cherry pick asm_linux_riscv64.s for x/sys/unix Manually cherry pick asm_linux_riscv64.s from x/sys/unix rev 4c3a92842, as needed for the linux/riscv64 port. Normally this would be a vendor update, however this is significantly more risky at this point in time - a full update can be done post release. Updates #27532 Change-Id: I03bb191bc44dcd24b9a29243957b88d7a9091852 Reviewed-on: https://go-review.googlesource.com/c/go/+/216260 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Joel Sing

commit sha 01df6601d8774f27f36ce339a093333d887ef8f6

cmd/objdump: disable unsupported tests on riscv64 Updates #27532, #36738 and #36739. Change-Id: If10031c6fd2c8ec2aa8c37f7edb148d8f26f8697 Reviewed-on: https://go-review.googlesource.com/c/go/+/216258 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Joel Sing

commit sha 69660ed7e05b8fccf071210cb0963aba8edc5ec3

cmd/go: disable link syso test on linux/riscv64 This test requires support for external linking, which does not currently exist on linux/riscv64. Updates #27532 and #36739 Change-Id: Ia0cdf69f1830b995f2882b47d1bc0be82c4b3039 Reviewed-on: https://go-review.googlesource.com/c/go/+/216259 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

push time in 25 days

push eventceseo/go

Brian Kessler

commit sha f889845ad8e291af85a4fca97cd9206b41e059b5

doc/go1.14: mention math/big.GCD argument change Change-Id: Ib3b5f64471e7b9794b15a97ba86ba001f2c7d2ae Reviewed-on: https://go-review.googlesource.com/c/go/+/216200 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 25 days

push eventceseo/go

Michael Knyszek

commit sha ad3cef184e55ab53306a466bda100dc72c40fc3b

Revert "runtime: release worldsema before Gosched in STW GC mode" This reverts commit 05511a5c0ae238325c10b0e4e44c3f66f928e4cf, CL 208379. Reason for revert: So that we can cleanly revert https://golang.org/cl/182657. Change-Id: I4fdf4f864a093db7866b3306f0f8f856b9f4d684 Reviewed-on: https://go-review.googlesource.com/c/go/+/216357 Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

Michael Knyszek

commit sha 64c22b70bf00e15615bb17c29f808b55bc339682

Revert "runtime: don't hold worldsema across mark phase" This reverts commit 7b294cdd8df0a9523010f6ffc80c59e64578f34b, CL 182657. Reason for revert: This change may be causing latency problems for applications which call ReadMemStats, because it may cause all goroutines to stop until the GC completes. https://golang.org/cl/215157 fixes this problem, but it's too late in the cycle to land that. Updates #19812. Change-Id: Iaa26f4dec9b06b9db2a771a44e45f58d0aa8f26d Reviewed-on: https://go-review.googlesource.com/c/go/+/216358 Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

push time in 25 days

push eventceseo/go

Alexander Rakoczy

commit sha e35876ec6591768edace6c6f3b12646899fd1b11

Revert "runtime: speed up receive on empty closed channel" This reverts CL 181543 (git e1446d9cee91af263af15efe8291644b590bb9ff) Reason for revert: Caused a regression in the race detector. Updates #32529 Fixes #36714 Change-Id: Ifefe6784f86ea72f414a89f131c239e9c9fd74eb Reviewed-on: https://go-review.googlesource.com/c/go/+/216158 Run-TryBot: Alexander Rakoczy <alex@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

Draven

commit sha 67539f6c532414bff9eca1a1d56f5e0192dd6fca

runtime: update deltimer comments Change-Id: I5f4c21bf650b9825ebd98330ac9faa7371a562be GitHub-Last-Rev: 4a2e9aabe91935001300619b6f58c67f05e9f3c7 GitHub-Pull-Request: golang/go#36728 Reviewed-on: https://go-review.googlesource.com/c/go/+/216223 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

Carlos Amedee

commit sha e948d2b73ede67f12bff9e4d050f0e1425163010

cmd/link: ensure cgo cflags do not leak into dwarf tests Running the dwarf tests with CGO_CFLAGS set with certain values would cause the test to fail. all.bash would fail when CGO_CFLAGS was set to '-mmacosx-version-min=10.10' because the --macosx-version-min flag is incompatible with some dwarf tests. The change guards against using an unintended flag in the unit test. Updates #35459 Change-Id: Idc9b354aba44fdab424cb0081a4b3ea7a6d0f8e3 Reviewed-on: https://go-review.googlesource.com/c/go/+/216177 Run-TryBot: Carlos Amedee <carlos@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 25 days

push eventceseo/go

Jay Conrod

commit sha 1f9f88b95eaec50c72c8595ca9f52b7b876e28f9

cmd/go: fix cgo test when min macOS version is set Regression tests for #24161 use a macro to conditionally compile some stub definitions. The macro tests that the minimum macOS version is less than 10.12. We get duplicate definitions when building this test with CGO_CFLAGS=-mmacosx-version-min=10.x where 10.x < 10.12. With this change, we use a different macro, __MAC_OS_X_VERSION_MAX_ALLOWED__, which tests the SDK version instead of the minimum macOS version. This checks whether these definitions are present in headers. After this change, 'go tool dist test cgo_test' should pass with CGO_FLAGS=-mmacosx-version-min=10.10. Updates #35459 Change-Id: I88d63601c94b0369c73c38d216a2d41ba7d4e579 Reviewed-on: https://go-review.googlesource.com/c/go/+/216243 Run-TryBot: Jay Conrod <jayconrod@google.com> Reviewed-by: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in 25 days

push eventceseo/go

Ariel Mashraki

commit sha 8d7be1e3c9a98191f8c900087025c5e78b73d962

text/template/parse: remove redundant return Change the `itemChar` clause to be like all other clauses that don't return a different state function than the default. Change-Id: I56c863a7d699c1264b24b42ef23138ec47eaacd8 Reviewed-on: https://go-review.googlesource.com/c/go/+/216117 Reviewed-by: Rob Pike <r@golang.org> Run-TryBot: Rob Pike <r@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in a month

push eventceseo/go

Filippo Valsorda

commit sha 953bc8f391a63adf00bac2515dba62abe8a1e2c2

crypto/x509: mitigate CVE-2020-0601 verification bypass on Windows An attacker can trick the Windows system verifier to use a poisoned set of elliptic curve parameters for a trusted root, allowing it to generate spoofed signatures. When this happens, the returned chain will present the unmodified original root, so the actual signatures won't verify (as they are invalid for the correct parameters). Simply double check them as a safety measure and mitigation. Windows users should still install the system security patch ASAP. This is the same mitigation adopted by Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/1994434 Change-Id: I2c734f6fb2cb51d906c7fd77034318ffeeb3e146 Reviewed-on: https://go-review.googlesource.com/c/go/+/215905 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ryan Sleevi <sleevi@google.com> Reviewed-by: Katie Hockman <katie@golang.org>

view details

push time in a month

push eventceseo/go

Carlos Amedee

commit sha ace25f82df0a27eb26a518e1883eb56c1bec6c5e

cmd/link: ensure cgo cflags do not leak into tvOS test Running the 'TestBuildForTvOS' test with CGO_CFLAGS set with certain values would cause the test to fail. all.bash would fail when CGO_CFLAGS was set to '-mmacosx-version-min=10.10' because the --macosx-version-min flag is incompatible with tvOS. The change guards against using an unintended flag in the unit test. Updates #35459 Change-Id: Ifc43f3ebfb23d37aabeaac2ea9efae5b877991bf Reviewed-on: https://go-review.googlesource.com/c/go/+/215957 Run-TryBot: Carlos Amedee <carlos@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in a month

push eventceseo/go

Kirill Tatchihin

commit sha 8453844ed774b0f864d28cb83844402c63db2849

time: document how Parse handles two-digit years Fixes #36549 Change-Id: Ia803330fc046d5807bbefd67acb419cb81640a13 GitHub-Last-Rev: bd354319083bf80c250e1915f2be6860d2f7d14b GitHub-Pull-Request: golang/go#36584 Reviewed-on: https://go-review.googlesource.com/c/go/+/214980 Reviewed-by: Rob Pike <r@golang.org>

view details

push time in a month

push eventceseo/go

Bryan C. Mills

commit sha 39ea3d0a2365fe1619fced89f94b747ce4852540

cmd/go: add a control case to the mod_vendor_trimpath test In reviewing CL 215940, it took me a while to find the control condition for the test, which was located in build_cache_trimpath.txt. We could consolidate the two tests, but since they check for regressions of separate issues (with separate root-causes), I think it makes sense to keep them separate. However, I would like the control condition to be present in the same source file, so that we'll be more likely to update both cases if the behavior of one of them is changed. Updates #36566 Change-Id: Ic588f1dfb7977dd78d1d5ef61b9841e22bad82e6 Reviewed-on: https://go-review.googlesource.com/c/go/+/216018 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>

view details

push time in a month

push eventceseo/go

Daniel Martí

commit sha 8689ea6a4a2aa33b90bfbcf5076bfff0b6fdcaed

cmd/go: make Script/test_regexps less flaky under load With the command below, I was able to reproduce failures within the first 50 or so runs: go test -c -o test && stress -p 32 ./test -test.run Script/test_regexp When printing the full failure output, we'd see: BenchmarkX BenchmarkX: x_test.go:13: LOG: X running N=1 BenchmarkX/Y BenchmarkX/Y: x_test.go:15: LOG: Y running N=1 BenchmarkX/Y: x_test.go:15: LOG: Y running N=100 BenchmarkX/Y: x_test.go:15: LOG: Y running N=10000 BenchmarkX/Y: x_test.go:15: LOG: Y running N=1000000 BenchmarkX/Y: x_test.go:15: LOG: Y running N=100000000 BenchmarkX/Y: x_test.go:15: LOG: Y running N=1000000000 BenchmarkX/Y 1000000000 0.000050 ns/op BenchmarkX/Y: x_test.go:15: LOG: Y running N=1 BenchmarkX/Y: x_test.go:15: LOG: Y running N=30 BenchmarkX/Y: x_test.go:15: LOG: Y running N=1207 BenchmarkX/Y: x_test.go:15: LOG: Y running N=120700 BenchmarkX/Y: x_test.go:15: LOG: Y running N=12070000 BenchmarkX/Y: x_test.go:15: LOG: Y running N=1000000000 BenchmarkX/Y 1000000000 0.000715 ns/op In other words, the N values aren't required to be exact. It seems like they are cut short if the machine is under stress. That's the exact scenario we reproduce above, since I used -p=32 on my laptop with only 4 real CPU cores. First, don't require each line to be present. Instead, use patterns that span multiple lines, so that we can just match the first and last N= lines. Second, don't require the last N= lines to be exact; simply require them to have a reasonably large number of digits. Fixes #36664. Change-Id: I7a9818f1a07099fa6482a26da2ac5cbea0f8ab30 Reviewed-on: https://go-review.googlesource.com/c/go/+/215578 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in a month

push eventceseo/go

Jay Conrod

commit sha 64378c233b69ca577a23a85285aa9adf3849d7f5

cmd/go: unify trimpath logic for -mod=vendor, -mod=mod If a package has a module with a version, the package's directory is replaced with the module path and version, followed by the package's path within the module. This is a follow up to CL 214945. We no longer check whether the module has a directory (with -mod=vendor, it does not). Updates #36566 Change-Id: I5bc952b13bc7b4659f58ee555bd6c6a087eb7792 Reviewed-on: https://go-review.googlesource.com/c/go/+/215940 Run-TryBot: Jay Conrod <jayconrod@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com>

view details

push time in a month

push eventceseo/go

Joel Sing

commit sha 82a2f825b7163eafebbf9b8640ef6406e4dda9a9

runtime: add missing code for linux/riscv64 Makes linux/riscv64 runtime buildable. Updates #27532 Change-Id: I91bcadaaecb8ff3ffd70fcb437b2b6e4bbe11eda Reviewed-on: https://go-review.googlesource.com/c/go/+/215839 Run-TryBot: Joel Sing <joel@sing.id.au> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

push time in a month

push eventceseo/go

Joel Sing

commit sha fa610c776e4bc659211b65a2dfbc74051ef99159

cmd/internal/obj/riscv: add missing instructions to the ternary expansion list Updates #27532 Change-Id: I5beb7941c204755948350b181c713b046bc4f1f1 Reviewed-on: https://go-review.googlesource.com/c/go/+/215841 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

Joel Sing

commit sha 9f07cdd99ee70b90e2a5fe998acb48c5fc6e39f2

cmd/internal/obj/riscv: restore the ADDI instruction in jalrToSym While this instruction is not needed for the relocation (the lower immediate can be patched directly into the JALR instruction), other code currently depends on the jump sequence being 12 bytes (or three instructions) long. Put the ADDI instruction back until these can be found and fixed. Updates #27532 Change-Id: Idb73d716be8eb2eb796591b30f1ec4dc104f2bf8 Reviewed-on: https://go-review.googlesource.com/c/go/+/215840 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in a month

push eventceseo/go

Jay Conrod

commit sha 9f1d55c4e73dbaff1f118df7125a2cd4401fcb8e

cmd/dist: print error if GOROOT is inside a module Fixes #36701 Change-Id: I22738235e7a7ee06bc5d748213aab523aad8cf12 Reviewed-on: https://go-review.googlesource.com/c/go/+/215939 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Marwan Sulaiman <marwan.sameer@gmail.com>

view details

push time in a month

push eventceseo/go

Filippo Valsorda

commit sha f9fe783c6c71d236a94ca674a8be61c7b5198fdb

Revert "net/http: support gzip, x-gzip Transfer-Encodings" This reverts commit e6c12c3d0296251f1d5a96ebde811dbfd4a914fe. Reason for revert: the assumption that a T-E of "gzip" implies "chunked" seems incorrect. The RFC does state that one "MUST apply chunked as the final transfer coding" but that should be interpreted to mean that a "chunked" encoding must be listed as the last one, not that one should be assumed to be there if not. This is confirmed by the alternative option to chunking on the server side being to "terminate the message by closing the connection". The issue seems confirmed by the fact that the code in the body of #29162 fails with the following error: net/http: HTTP/1.x transport connection broken: http: failed to gunzip body: unexpected EOF This late in the cycle, revert rather than fix, also because we don't apparently have tests for the correct behavior. Change-Id: I920ec928754cd8e96a06fb7ff8a53316c0f959e5 Reviewed-on: https://go-review.googlesource.com/c/go/+/215757 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Katie Hockman <katie@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>

view details

push time in a month

push eventceseo/go

Ian Lance Taylor

commit sha 895b7c85addfffe19b66d8ca71c31799d6e55990

runtime: don't skip checkTimers if we would clear deleted timers The timers code used to have a problem: if code started and stopped a lot of timers, as would happen with, for example, lots of calls to context.WithTimeout, then it would steadily use memory holding timers that had stopped but not been removed from the timer heap. That problem was fixed by CL 214299, which would remove all deleted timers whenever they got to be more than 1/4 of the total number of timers on the heap. The timers code had a different problem: if there were some idle P's, the running P's would have lock contention trying to steal their timers. That problem was fixed by CL 214185, which only acquired the timer lock if the next timer was ready to run or there were some timers to adjust. Unfortunately, CL 214185 partially undid 214299, in that we could now accumulate an increasing number of deleted timers while there were no timers ready to run. This CL restores the 214299 behavior, by checking whether there are lots of deleted timers without acquiring the lock. This is a performance issue to consider for the 1.14 release. Change-Id: I13c980efdcc2a46eb84882750c39e3f7c5b2e7c3 Reviewed-on: https://go-review.googlesource.com/c/go/+/215722 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

Austin Clements

commit sha 9b5bd30716914a86619c050f0d75c0da4133b257

runtime: document special memmove requirements Unlike C's memmove, Go's memmove must be careful to do indivisible writes of pointer values because it may be racing with the garbage collector reading the heap. We've had various bugs related to this over the years (#36101, #13160, #12552). Indeed, memmove is a great target for optimization and it's easy to forget the special requirements of Go's memmove. The CL documents these (currently unwritten!) requirements. We're also adding a test that should hopefully keep everyone honest going forward, though it's hard to be sure we're hitting all cases of memmove. Change-Id: I2f59f8d8d6fb42d2f10006b55d605b5efd8ddc24 Reviewed-on: https://go-review.googlesource.com/c/go/+/213418 Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

push time in a month

push eventceseo/go

Joel Sing

commit sha b4f15e79afecd04821a694ae0b41b39d8bf32a96

cmd/dist: detect gohostarch on riscv64 hosts Updates #27532 Change-Id: I66c194499bb7b831b569c66d0736fa7205eedd80 Reviewed-on: https://go-review.googlesource.com/c/go/+/215837 Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

Joel Sing

commit sha fb2e3b82f47dc9be89821d16f609df65e1f5f6ab

cmd/dist: mark cgo as disabled on linux/riscv64 cgo is not currently supported on this platform. Updates #27532 and #36641 Change-Id: I4b35f887e869ebc5c156dd754b1c79897a8c5800 Reviewed-on: https://go-review.googlesource.com/c/go/+/215838 Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

push time in a month

push eventceseo/go

Joel Sing

commit sha 6718cb617f3d09878088779fe9d18b08949a9bc0

cmd/internal/obj/riscv: implement prologue and epilogue Based on riscv-go port. Updates #27532 Change-Id: If552225552bf8d27c29b08de31146dd34986a3a1 Reviewed-on: https://go-review.googlesource.com/c/go/+/204630 Run-TryBot: Joel Sing <joel@sing.id.au> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

push time in a month

push eventceseo/go

Jay Conrod

commit sha 71bbffbc48d03b447c73da1f54ac57350fc9b36a

cmd/go: add -d flag to mod_get_test 'go get all' was run in this test without -d. This caused some std packages to be reinstalled if the test is run in a slightly different configuration than make.bash was run. run.bash would fail in some situations because of this. Nothing in the cmd/go tests should modify installed std or cmd packages. Updates #35459 Change-Id: Idd259a27d55502923b7fc54f361a77f0ac11eea2 Reviewed-on: https://go-review.googlesource.com/c/go/+/215721 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org>

view details

push time in a month

push eventceseo/go

Joel Sing

commit sha 1424889921159ed28866dff40b5d54884aaddd9c

cmd/internal/obj/riscv: correctly split immediates for FLW/FLD/FSW/FSD The FLW/FLD/FSW/FSD instructions can have immediates that exceed 12-bits and therefore cannot be encoded in the RISCV instruction. Handle these as we do for other load/store instructions. Also add test coverage for all load/store instructions with large immediates. Fixes compilation issue reported by Carlos Eduardo de Paula. Updates #27532 Change-Id: Ifa62f19493b3acaba5a90ac31d2df209a3afea81 Reviewed-on: https://go-review.googlesource.com/c/go/+/215037 Reviewed-by: Carlos Eduardo de Paula <me@carlosedp.com> Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

Joel Sing

commit sha fb8cdb7e4b491088829d59839b15270fcbcb629b

cmd/internal/obj/riscv: populate DWARF register mapping for riscv64 Updates #27532 Change-Id: If147242c45d5c2d5cdc5b0428db32eeec13a958a Reviewed-on: https://go-review.googlesource.com/c/go/+/215377 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in a month

push eventceseo/go

Kévin Dunglas

commit sha 88ed322afcd8cddc0e1ae5d02fd4d86779a4a2a3

net/http/httputil: add docs about X-Forwarded-For in ReverseProxy ReverseProxy automatically sets the X-Forwarded-For header, if the request already contains a X-Forwarded-For header, the value of the client IP is appended to the existing header value. This behavior isn't documented anywhere, and can lead to IP spoofing security issues is the client is untrusted (the most common situation). This PR documents this behavior. For future versions, I proposed #36678 that implements a more secure default behavior and adds support for other forwarded headers. Change-Id: Ief14f5063caebfccb87714f54cffa927c714e5fd GitHub-Last-Rev: fd0bd29a181861ffdb1106b42f59f9489999ccb3 GitHub-Pull-Request: golang/go#36672 Reviewed-on: https://go-review.googlesource.com/c/go/+/215617 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

view details

push time in a month

startedbordaw/LightGBM-CUDA

started time in a month

push eventceseo/go

Carlos Eduardo Seo

commit sha 71239b4f491698397149868c88d2c851de2cd49b

runtime: fix wrong offset when calling ppc64x nanotime syscall There is a wrong offset when getting the results of a clock_gettime syscall. Although the syscall will never be called in native ppc64x, QEMU doesn't implement VDSO, so it will return wrong values. Fixes #36592 Change-Id: Icf838075228dcdd62cf2c1279aa983e5993d66ee Reviewed-on: https://go-review.googlesource.com/c/go/+/215397 Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>

view details

push time in a month

push eventceseo/go

Tobias Klauser

commit sha df2999ef43ea49ce1578137017949c0ee660608a

test: disable test for #36516 when cgo is not enabled CL 214679 added a -race test which shouldn't be run when cgo is not enabled. Fixes the nocgo builder. Change-Id: Iceddf802c4ef6c0de2c3a968e86342303d2d27d8 Reviewed-on: https://go-review.googlesource.com/c/go/+/215477 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in a month

more