profile
viewpoint
Christian Clauss cclauss Christian Clauss Switzerland https://www.patreon.com/cclauss Working hard to find and fix bugs in software and to ensure that Python code is properly ported to Python 3. Building related tools and automated systems.

cclauss/500lines 1

500 Lines or Less

cclauss/adapter_pattern 1

Python adapter pattern where adapters are autoloaded from an adapters directory

cclauss/.github 0

Default configuration for @cclauss repos

cclauss/100-Days-Of-ML-Code 0

100 Days of ML Coding

cclauss/12306 0

12306智能刷票,订票

cclauss/2D_detection 0

TensorFlow implementation of SqueezeDet, trained on the KITTI dataset.

cclauss/30-Days-Of-Python 0

A 30 days of python programming challenge

cclauss/3d-photo-inpainting 0

[CVPR 2020] 3D Photography using Context-aware Layered Depth Inpainting

cclauss/3D-SDN 0

[NeurIPS 2018] 3D-Aware Scene Manipulation via Inverse Graphics

cclauss/3dpwn 0

VirtualBox 3D exploits & PoCs

delete branch cclauss/pythonista-module-versions

delete branch : pyup-update-sympy-0.7.4.1-to-1.6.1

delete time in 3 hours

push eventcclauss/pythonista-module-versions

pyup-bot

commit sha 5ce8eb86e68ca8894e57865bed9d7e093a471d8c

Update sympy from 0.7.4.1 to 1.6.2

view details

push time in 3 hours

issue commentnodejs/node-gyp

node-gyp rebuild error

Python v2.7.3 -> v2.7.18 or v3.8.5 sounds like a good place to start.

ishanuda

comment created time in 4 hours

Pull request review commentinternetarchive/openlibrary

Exporting User reading log

 def get_users_logged_books(cls, username, bookshelf_id, limit=100, page=1):          username (str) - who logged this book         work_id (int) - the Open Library work ID as an int (e.g. OL123W becomes 123)-        bookshelf_id (int) - the ID of the bookshelf, see: PRESET_BOOKSHELVES+        bookshelf_id (int) - the ID of the bookshelf, see: PRESET_BOOKSHELVES.

bookshelf_id is declared to be an int so I would be more favorable to defaulting to 0 instead of None.

tabshaikh

comment created time in 7 hours

push eventcclauss/openlibrary

cclauss

commit sha 8944a902e9b57f68df25ecbb5345f8da8c5b481a

Revert change to docker-compose.yml

view details

push time in 8 hours

push eventcclauss/openlibrary

Tabish Shaikh

commit sha 79506e3e50c0a1994130177d4687539cfa9217b4

Bug fixes for Canonical Books Page

view details

Tabish Shaikh

commit sha a64911ef5d3c75de8aac6609e4f4b2a2598f0c14

- Edit Form Revamped - Work subtitle added - Edition info duplicated in description

view details

Christian Clauss

commit sha da8047916b99596b1341a03a6b6ca87025651a43

.gitmodules: [submodule "vendor/infogami"] ignore = dirty As discussed at http://www.nils-haldenwang.de/frameworks-and-tools/git/how-to-ignore-changes-in-git-submodules

view details

Tabish Shaikh

commit sha 46ded02c784825c4929c16f297890a00991ace70

Apply suggestions from code review removed trailing spaces Co-authored-by: Christian Clauss <cclauss@me.com>

view details

Tabish Shaikh

commit sha 2fd9204d78aa35bde388d4d1d6db20891dbbb624

Update openlibrary/templates/books/edit.html Co-authored-by: Christian Clauss <cclauss@me.com>

view details

Tabish Shaikh

commit sha a745b79375f88c7ac680361d15e5dbe801273378

adding spaces and cleaning up the pr

view details

Tabish Shaikh

commit sha 9efdf909a496c56707a81a00f7f2061fd00434a7

removed the scroll view for now and cleaning up the pr

view details

Tabish Shaikh

commit sha 0b6da8910a65428a6d16037e0acb636f5463ccee

removed styles from .html file

view details

Tabish Shaikh

commit sha 95d0d9d4e5244fcec6c11cd124a79a033c1276f5

Apply suggestions from code review

view details

Tabish Shaikh

commit sha a25e5d6e961f2e33b1bad4269a5bbe24ee2bb797

removed inline styles and made tests to pass

view details

Tabish Shaikh

commit sha 19c5fe53d51e5ddcec8bc1a6a4e962ad2b8070ff

Fixed Blockers - Removed Work Covers Moved Work Id to the bottom

view details

Christian Clauss

commit sha c3f85c67c8564f899e1463929a3803c83bc0a338

openlibrary.yml: Switch from 127.0.0.1 --> localhost Docker-based processes seem to work smoothly with `localhost` but not so much with `127.0.0.1`.

view details

Drini Cami

commit sha 38caa6540e452327581ca279c5c321a8500dc760

Merge pull request #3642 from internetarchive/gitmodules_vendor/infogami_ignore_=_dirty .gitmodules: [submodule "vendor/infogami"] ignore = dirty

view details

Tabish Shaikh

commit sha 9a25bd9be661891d81c3055301083d1a37d84cb0

inline styles removed

view details

Tabish Shaikh

commit sha c42508bb43ac52c209ea8808b5341a3b64689a63

Merge branch 'master' into 3561/bug/edition-subtitle

view details

Mek

commit sha b9f75081d5b9537d77e90c3b827f3b22f167a9d7

Merge pull request #3632 from tabshaikh/3561/bug/edition-subtitle Fixing Bugs Post Canonical Book Page Launch

view details

Mek

commit sha 39d5455bcc0d66c045750ece8fa5806aca61fdd9

Merge pull request #3664 from internetarchive/localhost-in-openlibrary.yml openlibrary.yml: Switch from 127.0.0.1 --> localhost

view details

cclauss

commit sha 0e26e32551fd3472911e94491ac6c5790d31bda9

Add /plugins/upstream/tests/test_models.py

view details

Mek

commit sha 00f4f7ba8dacf65c9cf2b7fb7b8aed14200b000d

Merge pull request #3669 from cclauss/add-plugins-upstream-test-models Add /plugins/upstream/tests/test_models.py

view details

cclauss

commit sha 5c1a8a0fc23188331fcd6f0232f46b6d041c3cd5

Merge remote-tracking branch 'upstream/master' into python3

view details

push time in 8 hours

push eventcclauss/openlibrary

cclauss

commit sha 8097e5003f009bc481f1d18db6cb0e24e09d2b3d

Sync with master

view details

push time in 8 hours

Pull request review commentwebpy/webpy

avoid ResourceWarning by using with-statement when calling open() #670

 def _load_template(self, name):                 path, cache=self._cache is not None, base=self._base, **self._keywords             )         elif kind == "file":-            return Template(-                open(path, encoding="utf-8").read(), filename=path, **self._keywords-            )+            with open(path, encoding="utf-8") as tmpl_file:+                return Template(+                    tmpl_file.read(), filename=path, **self._keywords+                )
                return Template(tmpl_file.read(), filename=path, **self._keywords)

To placate that pesky psf/black formatter.

stroeder

comment created time in 8 hours

push eventcclauss/openlibrary

cclauss

commit sha 18b32410e4877711d569b2c9ba8767de7d2464f2

Reenable the Integration Tests in xfail mode

view details

push time in 9 hours

push eventcclauss/openlibrary

cclauss

commit sha fd4ca73f96949ee1d91cae34b7e5dced45408bd7

Revert bad changes in test_auth.py

view details

push time in 9 hours

Pull request review commentwebpy/webpy

avoid ResourceWarning by using with-statement when calling open() #670

 def _load_template(self, name):                 path, cache=self._cache is not None, base=self._base, **self._keywords             )         elif kind == "file":+            with open(path, encoding="utf-8") as tmpl_file:+                tmpl_str = tmpl_file.read()             return Template(-                open(path, encoding="utf-8").read(), filename=path, **self._keywords+                tmpl_str, filename=path, **self._keywords

Yes. This is no problem. The context manager will close properly even with a return statement.

stroeder

comment created time in 10 hours

push eventinternetarchive/openlibrary

Christian Clauss

commit sha 7cd0a071bda7e95ef20da55f37dec48fbf39bfb3

Update Dockerfile.olbase

view details

push time in 10 hours

Pull request review commentwebpy/webpy

avoid ResourceWarning by using with-statement when calling open() #670

 def _load_template(self, name):                 path, cache=self._cache is not None, base=self._base, **self._keywords             )         elif kind == "file":+            with open(path, encoding="utf-8") as tmpl_file:+                tmpl_str = tmpl_file.read()             return Template(-                open(path, encoding="utf-8").read(), filename=path, **self._keywords+                tmpl_str, filename=path, **self._keywords
            with open(path, encoding="utf-8") as tmpl_file:
                return Template(tmpl_file.read(), filename=path, **self._keywords)
stroeder

comment created time in 10 hours

push eventcclauss/build-tools

Christian Clauss

commit sha 3ae16fde0b58112f805e9e4ff29b9e461581cae6

Travis CI: Test on current releases of Node.js

view details

push time in 10 hours

fork cclauss/build-tools

SproutCore Build Tools

fork in 10 hours

push eventcclauss/openlibrary

cclauss

commit sha ee1a749d9538453ab651da891891dd532e9936a7

pytest tests/integration

view details

push time in 11 hours

delete branch cclauss/cryptofeed

delete branch : patch-2

delete time in 11 hours

delete branch cclauss/cryptofeed

delete branch : patch-1

delete time in 11 hours

push eventcclauss/openlibrary

cclauss

commit sha 9b04e873d24e01530353fd7f003efda91b3295b5

Reenable the Integration Tests in xfail mode

view details

push time in 11 hours

push eventcclauss/openlibrary

cclauss

commit sha 81570b5c16b0cb33bf18fe3bdbf44293e8c5c562

Really match google-chrome --version

view details

push time in 12 hours

push eventcclauss/openlibrary

cclauss

commit sha 905cb73e03d3574976ad9b37a9ce8a85b7d59f81

Match google-chrome --version

view details

push time in 15 hours

push eventcclauss/openlibrary

cclauss

commit sha 2abe2c35f4390df74c92987210c487c268c2d11a

google-chrome --version ; chrome --version

view details

push time in 15 hours

push eventcclauss/openlibrary

cclauss

commit sha ee7206b850112e74631700d795acc2df49d8fc23

wget chromedriver_linux64.zip

view details

push time in 15 hours

PR opened internetarchive/openlibrary

Docker: python3 -m pip install wheel

If the thunder don't get you then the lightning will...

Let's get rid of...

Using legacy setup.py install for DBUtils, since package 'wheel' is not installed.
Using legacy setup.py install for pymarc, since package 'wheel' is not installed.
Using legacy setup.py install for simplejson, since package 'wheel' is not installed.
Using legacy setup.py install for PyYAML, since package 'wheel' is not installed.
Using legacy setup.py install for eventer, since package 'wheel' is not installed.
Using legacy setup.py install for validate-email, since package 'wheel' is not installed.
Using legacy setup.py install for sixpack-client, since package 'wheel' is not installed.
Using legacy setup.py install for psycopg2, since package 'wheel' is not installed.
Using legacy setup.py install for wrapt, since package 'wheel' is not installed.
Using legacy setup.py install for clint, since package 'wheel' is not installed.
Using legacy setup.py install for total-ordering, since package 'wheel' is not installed.
Using legacy setup.py install for args, since package 'wheel' is not installed.

<!-- What issue does this PR close? --> Closes #

<!-- What does this PR achieve? [feature|hotfix|fix|refactor] -->

Technical

<!-- What should be noted about the implementation? -->

Testing

<!-- Steps for reviewer to reproduce/verify what this PR does/fixes. -->

Screenshot

<!-- If this PR touches UI, please post evidence (screenshots) of it behaving correctly. -->

Stakeholders

<!-- @ tag stakeholders of this bug -->

+3 -1

0 comment

1 changed file

pr created time in 16 hours

create barnchinternetarchive/openlibrary

branch : pip-install-wheel

created branch time in 16 hours

push eventcclauss/openlibrary

cclauss

commit sha 889447c7183149b71cb0c5ab65084ae157ccb0ed

whereis chromedriver

view details

push time in 16 hours

issue openedpeter279k/chromedriver-travis-ci

Updates needed

  1. Trusty is end of life.
  2. For current version of Ubuntu, Travis recommends using services: xvfb instead.
  3. Travis CI build config validation issues... Screenshot 2020-08-09 at 10 05 15

created time in 16 hours

push eventcclauss/openlibrary

cclauss

commit sha 657ae280a8b2fa6deea2b276b3f83540c19ad64b

whereis -a chromedriver

view details

push time in 16 hours

push eventcclauss/openlibrary

cclauss

commit sha d0943941e2f1d443ec801701d21064d712cf659d

Reenable the Integration Tests in xfail mode

view details

push time in 17 hours

push eventcclauss/cryptofeed

Christian Clauss

commit sha 9af5ee011e574b7e15a333e99ceb92dc6497ff59

Fix typo discovered by codespell

view details

push time in 18 hours

push eventcclauss/cryptofeed

Christian Clauss

commit sha bb8bbc5d87091ab7bff429ff06f0b3e3870bea92

Fix typos found by codespell

view details

push time in 18 hours

PR opened bmoscon/cryptofeed

Fix typos found by codespell

https://github.com/codespell-project/codespell

+1 -1

0 comment

1 changed file

pr created time in 18 hours

push eventcclauss/cryptofeed

Christian Clauss

commit sha 5d661a3455f29dd5550c6bd186efea6570811557

Fix typos found by codespell https://github.com/codespell-project/codespell

view details

push time in 18 hours

PR opened bmoscon/cryptofeed

Travis CI: Fix build config validation issues

Also:

  1. Test on current Python
  2. Now that pip will have a real dependency resolver, give it all dependencies in a single command

Screenshot 2020-08-09 at 08 15 15

+3 -5

0 comment

1 changed file

pr created time in 18 hours

push eventcclauss/cryptofeed

Christian Clauss

commit sha 1b2558462251b336e70a33321851d7d9f59419ca

Travis CI: Fix build config validation issues Also: 1. Test on current Python 2. Now that pip will have a real dependency resolver, give it all dependencies in a single command

view details

push time in 18 hours

push eventcclauss/itinerant-tester

Christian Clauss

commit sha 26116dc019cfb13b351da2b51c81646b3fee0393

bmoscon/cryptofeed

view details

push time in 18 hours

fork cclauss/cryptofeed

Cryptocurrency Exchange Feed Handler with synthetic NBBO

fork in 18 hours

push eventcclauss/openlibrary

cclauss

commit sha e4050b31249292d04772a3446aa001eba122dea8

Dicker build and remove redundant code

view details

push time in 18 hours

issue closedTheAlgorithms/Python

PythonAllgorithms

#1901

closed time in 19 hours

samuellsaraiva

pull request commentinternetarchive/openlibrary

Re-enable the Integration Tests in xfail mode

pushd tests/integration pytest .

================================ test session starts ======================================
platform darwin -- Python 3.8.5, pytest-6.0.1, py-1.9.0, pluggy-0.13.1
rootdir: /Users/cclauss/Python/itinerant_futurizer/openlibrary
collected 44 items

test_affiliate_links.py ..                                                                                                                                                                                                                                                        [  4%]
test_auth.py .xxxxxxxxxxxxxx.xxxxxxx.                                                                                                                                                                                                                                             [ 59%]
test_landing.py xxxxx                                                                                                                                                                                                                                                             [ 70%]
test_loans.py xxx                                                                                                                                                                                                                                                                 [ 77%]
test_microdata.py x.                                                                                                                                                                                                                                                              [ 81%]
test_search.py .xxx                                                                                                                                                                                                                                                               [ 90%]
test_sharing.py xx.x                                                                                                                                                                                                                                                              [100%]

=========================== 8 passed, 36 xfailed in 169.30s (0:02:49) ===========================
cclauss

comment created time in a day

PR opened internetarchive/openlibrary

Reviewers
Re-enable the Integration Tests in xfail mode Python Theme: Testing Theme: Upgrade to Python 3 integration interface

<!-- What issue does this PR close? --> Closes #672 #2725

Instead of getting rid of our Integration Tests as discussed in #2725, let's re-enable them and set the ones that are not working in pytest.mark.xfail mode so that they can be fixed over time. This approach allows us to keep the eight tests that already work and add new tests to cover the new Python 3 code.

This PR also adds a new Travis CI job to automatically run these user interface tests on all pull requests.

<!-- What does this PR achieve? [feature|hotfix|fix|refactor] -->

Technical

<!-- What should be noted about the implementation? -->

Testing

<!-- Steps for reviewer to reproduce/verify what this PR does/fixes. -->

Screenshot

<!-- If this PR touches UI, please post evidence (screenshots) of it behaving correctly. -->

Stakeholders

<!-- @ tag stakeholders of this bug -->

+103 -17

0 comment

11 changed files

pr created time in a day

push eventcclauss/openlibrary

Tabish Shaikh

commit sha 79506e3e50c0a1994130177d4687539cfa9217b4

Bug fixes for Canonical Books Page

view details

Tabish Shaikh

commit sha a64911ef5d3c75de8aac6609e4f4b2a2598f0c14

- Edit Form Revamped - Work subtitle added - Edition info duplicated in description

view details

Christian Clauss

commit sha da8047916b99596b1341a03a6b6ca87025651a43

.gitmodules: [submodule "vendor/infogami"] ignore = dirty As discussed at http://www.nils-haldenwang.de/frameworks-and-tools/git/how-to-ignore-changes-in-git-submodules

view details

Tabish Shaikh

commit sha 46ded02c784825c4929c16f297890a00991ace70

Apply suggestions from code review removed trailing spaces Co-authored-by: Christian Clauss <cclauss@me.com>

view details

Tabish Shaikh

commit sha 2fd9204d78aa35bde388d4d1d6db20891dbbb624

Update openlibrary/templates/books/edit.html Co-authored-by: Christian Clauss <cclauss@me.com>

view details

Tabish Shaikh

commit sha a745b79375f88c7ac680361d15e5dbe801273378

adding spaces and cleaning up the pr

view details

Tabish Shaikh

commit sha 9efdf909a496c56707a81a00f7f2061fd00434a7

removed the scroll view for now and cleaning up the pr

view details

Tabish Shaikh

commit sha 0b6da8910a65428a6d16037e0acb636f5463ccee

removed styles from .html file

view details

Tabish Shaikh

commit sha 95d0d9d4e5244fcec6c11cd124a79a033c1276f5

Apply suggestions from code review

view details

Tabish Shaikh

commit sha a25e5d6e961f2e33b1bad4269a5bbe24ee2bb797

removed inline styles and made tests to pass

view details

Tabish Shaikh

commit sha 19c5fe53d51e5ddcec8bc1a6a4e962ad2b8070ff

Fixed Blockers - Removed Work Covers Moved Work Id to the bottom

view details

Christian Clauss

commit sha c3f85c67c8564f899e1463929a3803c83bc0a338

openlibrary.yml: Switch from 127.0.0.1 --> localhost Docker-based processes seem to work smoothly with `localhost` but not so much with `127.0.0.1`.

view details

Drini Cami

commit sha 38caa6540e452327581ca279c5c321a8500dc760

Merge pull request #3642 from internetarchive/gitmodules_vendor/infogami_ignore_=_dirty .gitmodules: [submodule "vendor/infogami"] ignore = dirty

view details

Tabish Shaikh

commit sha 9a25bd9be661891d81c3055301083d1a37d84cb0

inline styles removed

view details

Tabish Shaikh

commit sha c42508bb43ac52c209ea8808b5341a3b64689a63

Merge branch 'master' into 3561/bug/edition-subtitle

view details

Mek

commit sha b9f75081d5b9537d77e90c3b827f3b22f167a9d7

Merge pull request #3632 from tabshaikh/3561/bug/edition-subtitle Fixing Bugs Post Canonical Book Page Launch

view details

Mek

commit sha 39d5455bcc0d66c045750ece8fa5806aca61fdd9

Merge pull request #3664 from internetarchive/localhost-in-openlibrary.yml openlibrary.yml: Switch from 127.0.0.1 --> localhost

view details

cclauss

commit sha 0e26e32551fd3472911e94491ac6c5790d31bda9

Add /plugins/upstream/tests/test_models.py

view details

Mek

commit sha 00f4f7ba8dacf65c9cf2b7fb7b8aed14200b000d

Merge pull request #3669 from cclauss/add-plugins-upstream-test-models Add /plugins/upstream/tests/test_models.py

view details

cclauss

commit sha 6bbc2edf96b9400eaa4d87fca042c523555307f1

Use local infogami

view details

push time in a day

issue closedTheAlgorithms/Python

Need contributor access to the repository

I would like to work on issue #2128, adding static type checking. I started with basic_binary_tree.py but am unable to publish my branch. This is the error I recieved.

c:\github\algo\Python\data_structures\binary_tree>git push --set-upstream origin basic_binary_tree.py-static-type-checking remote: Permission to TheAlgorithms/Python.git denied to kanthuc. fatal: unable to access 'https://github.com/TheAlgorithms/Python.git/': The requested URL returned error: 403

Could I please have access so I can publish my branch and create a PR, thank you

closed time in a day

kanthuc

issue commentTheAlgorithms/Python

Need contributor access to the repository

Push to your own fork of this repo which should be at https://github.com/kanthuc/Python to create a pull request to this repo. As noted in the comments of #2128, the file .travis.yml already runs mypy on all pull requests.

kanthuc

comment created time in a day

pull request commentsass/node-sass

Python 3 support by bumping node-gyp to 6.1.0

@keithslater Please do the following https://github.com/sass/node-sass/pull/2936#issuecomment-660965921

ext

comment created time in a day

push eventcclauss/infogami

cclauss

commit sha 1d5ec9594fc26260083b892cada3399bf5928738

Revert the definition of breakpoint()

view details

push time in a day

push eventcclauss/infogami

cclauss

commit sha 0f714b0855fe686c4d3980405f4771472893232b

Convert page.works[0] from a Thing to a Work

view details

push time in a day

pull request commentTheAlgorithms/Python

Update scoring_functions.py

https://travis-ci.com/github/TheAlgorithms/Python/builds/178988952#L252

tanujdhiman

comment created time in a day

PR opened internetarchive/infogami

WIP: A fix for work.get_sorted_edition() on Python 3

This is a hack so we should look for a more robust (closer to the source of the problem) solution to internetarchive/openlibrary#3633. @aasifkhan7 @mekarpeles @cdrini

+10 -0

0 comment

1 changed file

pr created time in 2 days

create barnchcclauss/infogami

branch : Fix_for_work.get_sorted_edition

created branch time in 2 days

Pull request review commentnodejs/node-gyp

gyp: add missing extensions to compile_commands_json

 def AddCommandsForTarget(cwd, target, params, per_config_commands):         # TODO(bnoordhuis) Handle generated source files.         extensions = (".c", ".cc", ".cpp", ".cxx")         sources = target.get("sources", [])

This line is no longer needed.

manuel-arguelles

comment created time in 2 days

push eventcclauss/openlibrary

cclauss

commit sha 26b0e9acc2d7acb0fa3f6fc95ba8bb0981544663

csv_file.next() to next(csv_file) for Python 3

view details

push time in 2 days

Pull request review commentnodejs/node-gyp

gyp: add missing extensions to compile_commands_json

 def AddCommandsForTarget(cwd, target, params, per_config_commands):         defines = ["-D" + s for s in defines]          # TODO(bnoordhuis) Handle generated source files.+        extensions = (".c", ".cc", ".cpp", ".cxx")         sources = target.get("sources", [])-        sources = [s for s in sources if s.endswith(".c") or s.endswith(".cc")]+        sources = [s for s in sources if s.endswith(extensions)]
        sources = [s for s in target.get("sources", []) if s.endswith(extensions)]

And remove line 65 to streamline the logic.

manuel-arguelles

comment created time in 2 days

push eventcclauss/openlibrary

cclauss

commit sha 1f2676bdaecf14deb16c453658076c0683e29f59

git rm openlibrary/records/tests/conftest.py

view details

push time in 2 days

delete branch cclauss/openlibrary

delete branch : run_doctests

delete time in 2 days

PR closed internetarchive/openlibrary

Reviewers
Add scripts/run_doctests.sh to run on Python 2 and 3 Python Theme: Testing Theme: Upgrade to Python 3

<!-- What does this PR achieve? [feature|hotfix|fix|refactor] --> Add scripts/run_doctests.sh to run Python doctests on both Python 2 and 3.

Output:

495 passed, 25 skipped, 10 xfailed, 35 warnings in 87.36s (0:01:27)

Technical

<!-- What should be noted about the implementation? --> Passing these tests required several absolute import changes, etc.

Testing

<!-- Steps for reviewer to reproduce/verify what this PR does/fixes. --> Yes! 495 of them.

Screenshot

<!-- If this PR touches UI, please post evidence (screenshots) of it behaving correctly. -->

Stakeholders

<!-- @ tag stakeholders of this bug -->

+159 -142

1 comment

33 changed files

cclauss

pr closed time in 2 days

pull request commentinternetarchive/openlibrary

Add scripts/run_doctests.sh to run on Python 2 and 3

Closing in favor of #3673

cclauss

comment created time in 2 days

PR opened internetarchive/openlibrary

Run doctests again

<!-- What does this PR achieve? [feature|hotfix|fix|refactor] --> Add scripts/run_doctests.sh to run Python doctests on both Python 2 and 3.

Fixes #3659 which go into a bad git state because of `vendors/infogami". Output:

495 passed, 25 skipped, 10 xfailed, 35 warnings in 87.36s (0:01:27)

Technical

<!-- What should be noted about the implementation? --> Passing these tests required several absolute import changes, etc.

Testing

<!-- Steps for reviewer to reproduce/verify what this PR does/fixes. --> Yes! 495 of them.

Screenshot

<!-- If this PR touches UI, please post evidence (screenshots) of it behaving correctly. -->

Stakeholders

<!-- @ tag stakeholders of this bug -->

+159 -102

0 comment

32 changed files

pr created time in 2 days

create barnchcclauss/openlibrary

branch : run_doctests_again

created branch time in 2 days

push eventcclauss/openlibrary

cclauss

commit sha 0571f2ae521045c301a778d758db931a6a3cb59c

git add vendor/infogami

view details

push time in 2 days

push eventcclauss/openlibrary

cclauss

commit sha 0f9c4242d7b07610a9cb50a0f39474f9962b3216

Lose vendor/infogami

view details

push time in 2 days

push eventcclauss/openlibrary

Tabish Shaikh

commit sha 79506e3e50c0a1994130177d4687539cfa9217b4

Bug fixes for Canonical Books Page

view details

Tabish Shaikh

commit sha a64911ef5d3c75de8aac6609e4f4b2a2598f0c14

- Edit Form Revamped - Work subtitle added - Edition info duplicated in description

view details

Christian Clauss

commit sha da8047916b99596b1341a03a6b6ca87025651a43

.gitmodules: [submodule "vendor/infogami"] ignore = dirty As discussed at http://www.nils-haldenwang.de/frameworks-and-tools/git/how-to-ignore-changes-in-git-submodules

view details

Tabish Shaikh

commit sha 46ded02c784825c4929c16f297890a00991ace70

Apply suggestions from code review removed trailing spaces Co-authored-by: Christian Clauss <cclauss@me.com>

view details

Tabish Shaikh

commit sha 2fd9204d78aa35bde388d4d1d6db20891dbbb624

Update openlibrary/templates/books/edit.html Co-authored-by: Christian Clauss <cclauss@me.com>

view details

Tabish Shaikh

commit sha a745b79375f88c7ac680361d15e5dbe801273378

adding spaces and cleaning up the pr

view details

Tabish Shaikh

commit sha 9efdf909a496c56707a81a00f7f2061fd00434a7

removed the scroll view for now and cleaning up the pr

view details

Tabish Shaikh

commit sha 0b6da8910a65428a6d16037e0acb636f5463ccee

removed styles from .html file

view details

Tabish Shaikh

commit sha 95d0d9d4e5244fcec6c11cd124a79a033c1276f5

Apply suggestions from code review

view details

Tabish Shaikh

commit sha a25e5d6e961f2e33b1bad4269a5bbe24ee2bb797

removed inline styles and made tests to pass

view details

Tabish Shaikh

commit sha 19c5fe53d51e5ddcec8bc1a6a4e962ad2b8070ff

Fixed Blockers - Removed Work Covers Moved Work Id to the bottom

view details

Christian Clauss

commit sha c3f85c67c8564f899e1463929a3803c83bc0a338

openlibrary.yml: Switch from 127.0.0.1 --> localhost Docker-based processes seem to work smoothly with `localhost` but not so much with `127.0.0.1`.

view details

Drini Cami

commit sha 38caa6540e452327581ca279c5c321a8500dc760

Merge pull request #3642 from internetarchive/gitmodules_vendor/infogami_ignore_=_dirty .gitmodules: [submodule "vendor/infogami"] ignore = dirty

view details

Tabish Shaikh

commit sha 9a25bd9be661891d81c3055301083d1a37d84cb0

inline styles removed

view details

Tabish Shaikh

commit sha c42508bb43ac52c209ea8808b5341a3b64689a63

Merge branch 'master' into 3561/bug/edition-subtitle

view details

Mek

commit sha b9f75081d5b9537d77e90c3b827f3b22f167a9d7

Merge pull request #3632 from tabshaikh/3561/bug/edition-subtitle Fixing Bugs Post Canonical Book Page Launch

view details

Mek

commit sha 39d5455bcc0d66c045750ece8fa5806aca61fdd9

Merge pull request #3664 from internetarchive/localhost-in-openlibrary.yml openlibrary.yml: Switch from 127.0.0.1 --> localhost

view details

cclauss

commit sha 0e26e32551fd3472911e94491ac6c5790d31bda9

Add /plugins/upstream/tests/test_models.py

view details

Mek

commit sha 00f4f7ba8dacf65c9cf2b7fb7b8aed14200b000d

Merge pull request #3669 from cclauss/add-plugins-upstream-test-models Add /plugins/upstream/tests/test_models.py

view details

cclauss

commit sha ac17b64cee6c0867dbc0a2c74d35dd3a80e94277

Merge remote-tracking branch 'upstream/master' into run_doctests

view details

push time in 2 days

push eventcclauss/openlibrary

cclauss

commit sha 6bbc2edf96b9400eaa4d87fca042c523555307f1

Use local infogami

view details

push time in 2 days

push eventcclauss/openlibrary

cclauss

commit sha 32ad864383b626e5147da1bb14a0906f426bce2f

openlibrary/plugins/upstream/tests/test_models.py

view details

push time in 2 days

Pull request review commentinternetarchive/openlibrary

Exporting User reading log

 def POST(self):                 books_wo_isbns[_book['Book Id']] = _book              return render['account/import'](books, books_wo_isbns) +class export_books(delegate.page):+    path = "/account/export"++    @require_login+    def GET(self):+        user = accounts.get_current_user()+        username = user.key.split('/')[-1]+        books = Bookshelves.get_users_logged_books(username, 0, limit=10000)+        mapping = {1:'Want to Read', 2:'Currently Reading', 3:'Already Read'}+        result = {}+        result[0] = ['Work Id', 'Edition Id', 'Bookshelf']+        for i in books:+            lis = []+            lis.append('OL'+str(i['work_id'])+'W')+            lis.append('OL'+str(i['edition_id'])+'M')+            lis.append(mapping[i['bookshelf_id']])+            result[i['work_id']] = lis
        for book in books:
            result[book['work_id']] = [
                'OL{}W'.format(book['work_id']),
                'OL{}M'.format(book['edition_id']),
                mapping[book['bookshelf_id']],
            ]
tabshaikh

comment created time in 2 days

Pull request review commentinternetarchive/openlibrary

Exporting User reading log

 def get_users_logged_books(cls, username, bookshelf_id, limit=100, page=1):          username (str) - who logged this book         work_id (int) - the Open Library work ID as an int (e.g. OL123W becomes 123)-        bookshelf_id (int) - the ID of the bookshelf, see: PRESET_BOOKSHELVES+        bookshelf_id (int) - the ID of the bookshelf, see: PRESET_BOOKSHELVES. If bookshelf_id = 0 then return books from all bookshelves.

Readability: Lines of Python code should be 88 characters max.

        bookshelf_id (int) - the ID of the bookshelf, see: PRESET_BOOKSHELVES.
            If bookshelf_id = 0 then return books from all bookshelves.
tabshaikh

comment created time in 2 days

push eventcclauss/openlibrary

cclauss

commit sha 6780bd7560fc85e1641994207b12cd36c24cc7fa

Revert change to .gitmodules

view details

push time in 2 days

push eventcclauss/openlibrary

push time in 2 days

push eventinternetarchive/openlibrary

Christian Clauss

commit sha 313e075bc009bee10a44018cf58027e90cf4b5d4

Update .travis.yml

view details

push time in 2 days

PR opened internetarchive/openlibrary

Update and rename test-py3.sh to test_py3.sh

Not only rename the file (because I am not used to hyphens in filenames) but also...

  1. Add verbose mode and display of stdout and stderr in our failing tests to aid debugging.
  2. Switch to a --ignore list it is clear where more tests could be cleaned up or added Please help us to close these last four failing test files on Python 3.

<!-- What issue does this PR close? --> Closes #

<!-- What does this PR achieve? [feature|hotfix|fix|refactor] -->

Technical

<!-- What should be noted about the implementation? -->

Testing

<!-- Steps for reviewer to reproduce/verify what this PR does/fixes. -->

Screenshot

<!-- If this PR touches UI, please post evidence (screenshots) of it behaving correctly. -->

Stakeholders

<!-- @ tag stakeholders of this bug -->

+22 -18

0 comment

2 changed files

pr created time in 2 days

create barnchinternetarchive/openlibrary

branch : test_py3.sh

created branch time in 2 days

issue commentinternetarchive/openlibrary

Python 3: openlibrary/plugins/openlibrary/tests/test_home.py fails

Please rebase because there have been a lot of key changes landed on both OpenLibrary and Infogami.

cclauss

comment created time in 2 days

push eventcclauss/openlibrary

Christian Clauss

commit sha f27ed251c002de0521b4c8bcea919a1ca98e282d

Revert changes to .gitmodules

view details

push time in 2 days

delete branch cclauss/infogami

delete branch : python3

delete time in 2 days

delete branch cclauss/infogami

delete branch : register_i18n_loadhook

delete time in 2 days

delete branch cclauss/infogami

delete branch : patch-4

delete time in 2 days

PR closed internetarchive/infogami

Server.py: json.dumps(d, default=str) for datetimes

As discussed at https://github.com/internetarchive/infogami/pull/96#pullrequestreview-453617306 and https://stackoverflow.com/questions/11875770

+2 -2

0 comment

1 changed file

cclauss

pr closed time in 2 days

delete branch cclauss/infogami

delete branch : patch-7

delete time in 2 days

PR closed internetarchive/infogami

Eliminate bare exception in infogami/infobase/cache.py

https://realpython.com/the-most-diabolical-python-antipattern

+1 -1

0 comment

1 changed file

cclauss

pr closed time in 2 days

delete branch cclauss/infogami

delete branch : import-keyencode

delete time in 2 days

PR closed internetarchive/infogami

Fix import of keyencode

keyencode() is defined in infogami/plugins/links/view.py and does not appear in any other Python file.

+0 -0

0 comment

0 changed file

cclauss

pr closed time in 2 days

push eventcclauss/infogami

cclauss

commit sha f273fb3c2bb914914cf1daebc89e13325af41df8

Upgrade web.py to match Open Library

view details

cclauss

commit sha 188930042930b829b7b5293cb502dd787e688889

Add iter and len to WikiSource

view details

cclauss

commit sha 74f6da0d06875f6fe4a52b4485074089efdd39d7

if pytest then set db_parameters

view details

cclauss

commit sha 71c918881e940470b62f8af246c395136d9965dd

Use json.dumps(d, default=str) to deal with datetimes on Py3

view details

cclauss

commit sha 7afa9fb34af0dd5c3bb4f86f27b904f3427d4bf1

web.utf8 --> web.safestr

view details

cclauss

commit sha a9b20d90d970c86e1b49eae8cfbb349beae8221c

Do fewer things

view details

cclauss

commit sha de2ae0b6c61d2af1c8d9d900ce404e8db524b506

Do fewer things

view details

cclauss

commit sha 1c64419d9a635d202d72c4a3d754bcf30449bfb6

Do fewer things

view details

Drini Cami

commit sha 8a3b246f78729009fd37baa97489265187670b27

Merge pull request #96 from cclauss/WikiSource.iter_and_len Add WikiSource().__iter__() and WikiSource().__len__()

view details

Christian Clauss

commit sha 525351f38727de89f0b94494ffeba09ddfaf8ce3

Import traceback from the standard library

view details

Christian Clauss

commit sha be3cbb8b9c929b9bc755f15b0c6178c7a3d5280c

Avoid circular imports

view details

Christian Clauss

commit sha daf816d5737993b352ac43c77d840ec73fdcaa93

web.py v0.60 drops support for legacy Python

view details

Christian Clauss

commit sha a3df53fd4fb70940fd0a2805572c473607e4e378

quotes

view details

Christian Clauss

commit sha 0361a643aeebe074d7c95310e3b241e404f78c1c

Update .travis.yml

view details

Christian Clauss

commit sha c494b90656b5cb124a3d3539bebaffe025c837d6

Revert Travis CI workaround because web.py v0.60 was yanked https://pypi.org/project/web.py/#history

view details

Christian Clauss

commit sha e42d37a1e2bcbea61cc90a2aa5ea9ba80919b60f

Requirements: web.py==0.39; python_version < '3.5' else 0.61 https://pypi.org/project/web.py and https://github.com/webpy/webpy/pull/662

view details

cclauss

commit sha 66e93140fd97527c392c6de5f7b0c0de60b05b04

Python 3: All current Infogami fixes and workarounds

view details

cclauss

commit sha 23dd95ac127cf7bcbf3f463f9e8164152ceeed56

Upgrade web.py only on Python 3

view details

Mek

commit sha 46b4d820e1c1c34fd2d3f0878ab984006d284ed5

Merge pull request #100 from cclauss/patch-7 Import traceback from the standard library

view details

Mek

commit sha b8bc4862d5d4c4d5a69d994e35cc29128ecd0fb8

Merge pull request #103 from cclauss/patch-8 Requirements: web.py==0.39; python_version < '3.5' else 0.61

view details

push time in 2 days

push eventcclauss/infogami

cclauss

commit sha 66e93140fd97527c392c6de5f7b0c0de60b05b04

Python 3: All current Infogami fixes and workarounds

view details

cclauss

commit sha 23dd95ac127cf7bcbf3f463f9e8164152ceeed56

Upgrade web.py only on Python 3

view details

cclauss

commit sha 1a5298fdd57e552e1a1563177006c471ff27c92f

Sync with master

view details

cclauss

commit sha d14ccf47c82ee3221ccdf89eaa49a21ac6095903

Special case PY3

view details

cclauss

commit sha aca72b57c68fdd545b5a0014f8c9522a9e86c917

Bare Exceptions are a pain

view details

cclauss

commit sha 6bda55d33f975b54402bdc27bc3425c879ae7a58

Register i18n_loadhook() to initialize web.ctx.lang

view details

cclauss

commit sha f09314184fb1143a5849166ca5401a25bc2e93a2

Incorporate #105

view details

cclauss

commit sha 5940fd50b587d126165b9954bdc06e270cc98e0c

Resync with #98, #99, #105, and #106

view details

Mek

commit sha 35e6e9376b02fb1cdd2c09c02bb4088a36678056

Merge pull request #104 from cclauss/python3 Python 3: All current Infogami fixes and workarounds

view details

Mek

commit sha 33d2b6d501f51a56ea55fb69d7278aee65c7fa63

Merge pull request #105 from cclauss/register_i18n_loadhook Register i18n_loadhook() to initialize web.ctx.lang

view details

push time in 2 days

delete branch TheAlgorithms/Python

delete branch : PIL.Image.point-takes-an-int

delete time in 2 days

push eventTheAlgorithms/Python

Christian Clauss

commit sha e49ece95a4273ada6e20a8a103ac5ce42f5c4a45

PIL.Image.point() takes an int, not a float (#2284) * PIL.Image.point() takes an int, not a float @furkanatesli Trying to remove these warnings from our Travis CI build logs... https://travis-ci.com/github/TheAlgorithms/Python/builds/178602503#L809 * fixup! Format Python code with psf/black push * Revert changes to change_brightness.py * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

view details

push time in 2 days

PR merged TheAlgorithms/Python

PIL.Image.point() takes an int, not a float

@furkanatesli Trying to remove these warnings from our Travis CI build logs... https://travis-ci.com/github/TheAlgorithms/Python/builds/178602503#L809

https://pillow.readthedocs.io/en/stable/reference/Image.html#PIL.Image.Image.point

Describe your change:

  • [ ] Add an algorithm?
  • [x] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [ ] I have read CONTRIBUTING.md.
  • [ ] This pull request is all my own work -- I have not plagiarized.
  • [ ] I know that pull requests will not be merged if they fail the automated tests.
  • [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ ] All new Python files are placed inside an existing directory.
  • [ ] All filenames are in all lowercase characters with no spaces or dashes.
  • [ ] All functions and variable names follow Python naming conventions.
  • [ ] All function parameters and return values are annotated with Python type hints.
  • [ ] All functions have doctests that pass the automated testing.
  • [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
+13 -3

0 comment

1 changed file

cclauss

pr closed time in 2 days

push eventTheAlgorithms/Python

Christian Clauss

commit sha 1fb1fdd130506e1db137dbcc2087b391c1880849

requirements.txt: Unpin numpy (#2287) * requirements.txt: Unpin numpy * fixup! Format Python code with psf/black push * Less clutter * fixup! Format Python code with psf/black push Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

view details

Christian Clauss

commit sha 57dfe7b815d03ce02f1757c202ee03ae1a094979

Merge branch 'master' into PIL.Image.point-takes-an-int

view details

push time in 2 days

pull request commentinternetarchive/infogami

Python 3: All current Infogami fixes and workarounds

@mekarpeles @cdrini @hornc Your review please.

cclauss

comment created time in 2 days

push eventcclauss/openlibrary

Christian Clauss

commit sha 0278bf695adb4ee40c0683778ab365334dd45ec0

Revert change to .gitmodules

view details

push time in 2 days

delete branch cclauss/openlibrary

delete branch : fix-mockcache-for-Python3

delete time in 2 days

PR closed internetarchive/openlibrary

Fix mockcache for Python 3

<!-- What does this PR achieve? [feature|hotfix|fix|refactor] --> Fix. The mockcache module that Python 2 uses has not been updated for Python 3 so substitute pymemcache.test.utils.MockMemcacheClient.

https://pymemcache.readthedocs.io/en/latest/apidoc/pymemcache.test.utils.html

Technical

<!-- What should be noted about the implementation? -->

Testing

<!-- Steps for reviewer to reproduce/verify what this PR does/fixes. -->

Screenshot

<!-- If this PR touches UI, please post evidence (screenshots) of it behaving correctly. -->

Stakeholders

<!-- @ tag stakeholders of this bug -->

+244 -155

1 comment

16 changed files

cclauss

pr closed time in 2 days

pull request commentinternetarchive/openlibrary

Fix mockcache for Python 3

Closed in favor of #3671

cclauss

comment created time in 2 days

PR opened internetarchive/openlibrary

Fix mockcache for Python 3

<!-- What issue does this PR close? --> Closes #3663 -- That PR got into a bad git state because of /vendor/infogami so this PR replaces it.

Fix. The mockcache module that Python 2 uses has not been updated for Python 3 so substitute pymemcache.test.utils.MockMemcacheClient.

https://pymemcache.readthedocs.io/en/latest/apidoc/pymemcache.test.utils.html

<!-- What does this PR achieve? [feature|hotfix|fix|refactor] -->

Technical

<!-- What should be noted about the implementation? -->

Testing

<!-- Steps for reviewer to reproduce/verify what this PR does/fixes. -->

Screenshot

<!-- If this PR touches UI, please post evidence (screenshots) of it behaving correctly. -->

Stakeholders

<!-- @ tag stakeholders of this bug -->

+6 -2

0 comment

1 changed file

pr created time in 2 days

create barnchcclauss/openlibrary

branch : fix-mockcache-for-Python3-again

created branch time in 2 days

push eventcclauss/openlibrary

cclauss

commit sha d8a0752ec9b079372ba99c89654215d8858c3b7b

Sync with upstream

view details

push time in 2 days

PR closed TheAlgorithms/Python

Create stalin_sort.py

I have added stalin_sort, a sorting algorithm with complexity of O(n)!!! Its speed is based on eliminating items that are not in order!

+12 -0

1 comment

1 changed file

GandelXIV

pr closed time in 2 days

pull request commentTheAlgorithms/Python

Create stalin_sort.py

Data loss is not to be encouraged.

GandelXIV

comment created time in 2 days

push eventcclauss/openlibrary

cclauss

commit sha 0e26e32551fd3472911e94491ac6c5790d31bda9

Add /plugins/upstream/tests/test_models.py

view details

Mek

commit sha 00f4f7ba8dacf65c9cf2b7fb7b8aed14200b000d

Merge pull request #3669 from cclauss/add-plugins-upstream-test-models Add /plugins/upstream/tests/test_models.py

view details

push time in 2 days

more